fix(clerk-js): Trim emails, usernames and identifiers by desiprisg · Pull Request #2881 · clerk/javascript

desiprisg · 2024-02-28T11:47:35Z

Description

Trim email addresses, usernames and the text identifier as whitespace at the start and end of the value is invalid.

To achieve the trimming for the identifier, a transformer prop has been added to useFormControl that can be used for other purposes as well.

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-02-28T11:47:39Z

🦋 Changeset detected

Latest commit: 1ddb455

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

nikosdouvlis · 2024-02-28T12:01:22Z

@desiprisg please add a description and a changeset as this does change the behavior of the components

desiprisg · 2024-02-28T12:05:51Z

!preview

clerk-cookie · 2024-02-28T12:10:31Z

Hey @desiprisg, your preview is available.

Status	Preview	Updated (UTC)
🍪 Deployed	Visit preview	Feb 28, 2024 12:10 PM

panteliselef · 2024-02-28T12:45:40Z

 options: [],
 defaultChecked: false,
 };
+ const transformer: NonNullable<typeof options.transformer> = options.transformer ? options.transformer : v => v;


🙃
Suggested change
consttransformer: NonNullable<typeofoptions.transformer>=options.transformer ?options.transformer :v=>v;
consttransformer: NonNullable<typeofoptions.transformer>=options.transformer??v=>v;

panteliselef · 2024-02-28T12:47:44Z

+let value = rest.value;
+let typeProps: Record<string, unknown> = { type };
+if (typeof value === 'string' && type === 'email') {
+value = value.trim();
+typeProps = { pattern: '^.*@[a-zA-Z0-9\\-]+\\.[a-zA-Z0-9\\-\\.]+$' };
+}


❓
Is it possible to have type='email' but not a value that is a string ?
I'd expect with the changes made in our useFormControl hook (below) that we wouldn't need to call value = value.trim(); manually here. Am i missing something ?

I just followed typescript here

+1 on the second question. Shouldn't there be a transformer in packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx for emailAddress?

There is a default transformer applied for type email in useFormControl

Yeah, looks good now

desiprisg · 2024-02-28T11:47:35Z

Description

Trim email addresses, usernames and the text identifier as whitespace at the start and end of the value is invalid.

To achieve the trimming for the identifier, a transformer prop has been added to useFormControl that can be used for other purposes as well.

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-02-28T11:47:39Z

🦋 Changeset detected

Latest commit: 1ddb455

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

nikosdouvlis · 2024-02-28T12:01:22Z

@desiprisg please add a description and a changeset as this does change the behavior of the components

desiprisg · 2024-02-28T12:05:51Z

!preview

clerk-cookie · 2024-02-28T12:10:31Z

Hey @desiprisg, your preview is available.

Status	Preview	Updated (UTC)
🍪 Deployed	Visit preview	Feb 28, 2024 12:10 PM

panteliselef · 2024-02-28T12:45:40Z

 options: [],
 defaultChecked: false,
 };
+ const transformer: NonNullable<typeof options.transformer> = options.transformer ? options.transformer : v => v;


🙃
Suggested change
consttransformer: NonNullable<typeofoptions.transformer>=options.transformer ?options.transformer :v=>v;
consttransformer: NonNullable<typeofoptions.transformer>=options.transformer??v=>v;

panteliselef · 2024-02-28T12:47:44Z

+let value = rest.value;
+let typeProps: Record<string, unknown> = { type };
+if (typeof value === 'string' && type === 'email') {
+value = value.trim();
+typeProps = { pattern: '^.*@[a-zA-Z0-9\\-]+\\.[a-zA-Z0-9\\-\\.]+$' };
+}


❓
Is it possible to have type='email' but not a value that is a string ?
I'd expect with the changes made in our useFormControl hook (below) that we wouldn't need to call value = value.trim(); manually here. Am i missing something ?

I just followed typescript here

+1 on the second question. Shouldn't there be a transformer in packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx for emailAddress?

There is a default transformer applied for type email in useFormControl

Yeah, looks good now

desiprisg · 2024-02-28T11:47:35Z

Description

Trim email addresses, usernames and the text identifier as whitespace at the start and end of the value is invalid.

To achieve the trimming for the identifier, a transformer prop has been added to useFormControl that can be used for other purposes as well.

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-02-28T11:47:39Z

🦋 Changeset detected

Latest commit: 1ddb455

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

nikosdouvlis · 2024-02-28T12:01:22Z

@desiprisg please add a description and a changeset as this does change the behavior of the components

desiprisg · 2024-02-28T12:05:51Z

!preview

clerk-cookie · 2024-02-28T12:10:31Z

Hey @desiprisg, your preview is available.

Status	Preview	Updated (UTC)
🍪 Deployed	Visit preview	Feb 28, 2024 12:10 PM

panteliselef · 2024-02-28T12:45:40Z

 options: [],
 defaultChecked: false,
 };
+ const transformer: NonNullable<typeof options.transformer> = options.transformer ? options.transformer : v => v;


🙃
Suggested change
consttransformer: NonNullable<typeofoptions.transformer>=options.transformer ?options.transformer :v=>v;
consttransformer: NonNullable<typeofoptions.transformer>=options.transformer??v=>v;

panteliselef · 2024-02-28T12:47:44Z

+let value = rest.value;
+let typeProps: Record<string, unknown> = { type };
+if (typeof value === 'string' && type === 'email') {
+value = value.trim();
+typeProps = { pattern: '^.*@[a-zA-Z0-9\\-]+\\.[a-zA-Z0-9\\-\\.]+$' };
+}


❓
Is it possible to have type='email' but not a value that is a string ?
I'd expect with the changes made in our useFormControl hook (below) that we wouldn't need to call value = value.trim(); manually here. Am i missing something ?

I just followed typescript here

+1 on the second question. Shouldn't there be a transformer in packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx for emailAddress?

There is a default transformer applied for type email in useFormControl

Yeah, looks good now

desiprisg · 2024-02-28T11:47:35Z

Description

Trim email addresses, usernames and the text identifier as whitespace at the start and end of the value is invalid.

To achieve the trimming for the identifier, a transformer prop has been added to useFormControl that can be used for other purposes as well.

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-02-28T11:47:39Z

🦋 Changeset detected

Latest commit: 1ddb455

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

nikosdouvlis · 2024-02-28T12:01:22Z

@desiprisg please add a description and a changeset as this does change the behavior of the components

desiprisg · 2024-02-28T12:05:51Z

!preview

clerk-cookie · 2024-02-28T12:10:31Z

Hey @desiprisg, your preview is available.

Status	Preview	Updated (UTC)
🍪 Deployed	Visit preview	Feb 28, 2024 12:10 PM

panteliselef · 2024-02-28T12:45:40Z

 options: [],
 defaultChecked: false,
 };
+ const transformer: NonNullable<typeof options.transformer> = options.transformer ? options.transformer : v => v;


🙃
Suggested change
consttransformer: NonNullable<typeofoptions.transformer>=options.transformer ?options.transformer :v=>v;
consttransformer: NonNullable<typeofoptions.transformer>=options.transformer??v=>v;

panteliselef · 2024-02-28T12:47:44Z

+let value = rest.value;
+let typeProps: Record<string, unknown> = { type };
+if (typeof value === 'string' && type === 'email') {
+value = value.trim();
+typeProps = { pattern: '^.*@[a-zA-Z0-9\\-]+\\.[a-zA-Z0-9\\-\\.]+$' };
+}


❓
Is it possible to have type='email' but not a value that is a string ?
I'd expect with the changes made in our useFormControl hook (below) that we wouldn't need to call value = value.trim(); manually here. Am i missing something ?

I just followed typescript here

+1 on the second question. Shouldn't there be a transformer in packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx for emailAddress?

There is a default transformer applied for type email in useFormControl

Yeah, looks good now

desiprisg · 2024-02-28T11:47:35Z

Description

Trim email addresses, usernames and the text identifier as whitespace at the start and end of the value is invalid.

To achieve the trimming for the identifier, a transformer prop has been added to useFormControl that can be used for other purposes as well.

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-02-28T11:47:39Z

🦋 Changeset detected

Latest commit: 1ddb455

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

nikosdouvlis · 2024-02-28T12:01:22Z

@desiprisg please add a description and a changeset as this does change the behavior of the components

desiprisg · 2024-02-28T12:05:51Z

!preview

clerk-cookie · 2024-02-28T12:10:31Z

Hey @desiprisg, your preview is available.

Status	Preview	Updated (UTC)
🍪 Deployed	Visit preview	Feb 28, 2024 12:10 PM

panteliselef · 2024-02-28T12:45:40Z

 options: [],
 defaultChecked: false,
 };
+ const transformer: NonNullable<typeof options.transformer> = options.transformer ? options.transformer : v => v;


🙃
Suggested change
consttransformer: NonNullable<typeofoptions.transformer>=options.transformer ?options.transformer :v=>v;
consttransformer: NonNullable<typeofoptions.transformer>=options.transformer??v=>v;

panteliselef · 2024-02-28T12:47:44Z

+let value = rest.value;
+let typeProps: Record<string, unknown> = { type };
+if (typeof value === 'string' && type === 'email') {
+value = value.trim();
+typeProps = { pattern: '^.*@[a-zA-Z0-9\\-]+\\.[a-zA-Z0-9\\-\\.]+$' };
+}


❓
Is it possible to have type='email' but not a value that is a string ?
I'd expect with the changes made in our useFormControl hook (below) that we wouldn't need to call value = value.trim(); manually here. Am i missing something ?

I just followed typescript here

+1 on the second question. Shouldn't there be a transformer in packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx for emailAddress?

There is a default transformer applied for type email in useFormControl

Yeah, looks good now

desiprisg · 2024-02-28T11:47:35Z

Description

Trim email addresses, usernames and the text identifier as whitespace at the start and end of the value is invalid.

To achieve the trimming for the identifier, a transformer prop has been added to useFormControl that can be used for other purposes as well.

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-02-28T11:47:39Z

🦋 Changeset detected

Latest commit: 1ddb455

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

nikosdouvlis · 2024-02-28T12:01:22Z

@desiprisg please add a description and a changeset as this does change the behavior of the components

desiprisg · 2024-02-28T12:05:51Z

!preview

clerk-cookie · 2024-02-28T12:10:31Z

Hey @desiprisg, your preview is available.

Status	Preview	Updated (UTC)
🍪 Deployed	Visit preview	Feb 28, 2024 12:10 PM

panteliselef · 2024-02-28T12:45:40Z

 options: [],
 defaultChecked: false,
 };
+ const transformer: NonNullable<typeof options.transformer> = options.transformer ? options.transformer : v => v;


🙃
Suggested change
consttransformer: NonNullable<typeofoptions.transformer>=options.transformer ?options.transformer :v=>v;
consttransformer: NonNullable<typeofoptions.transformer>=options.transformer??v=>v;

panteliselef · 2024-02-28T12:47:44Z

+let value = rest.value;
+let typeProps: Record<string, unknown> = { type };
+if (typeof value === 'string' && type === 'email') {
+value = value.trim();
+typeProps = { pattern: '^.*@[a-zA-Z0-9\\-]+\\.[a-zA-Z0-9\\-\\.]+$' };
+}


❓
Is it possible to have type='email' but not a value that is a string ?
I'd expect with the changes made in our useFormControl hook (below) that we wouldn't need to call value = value.trim(); manually here. Am i missing something ?

I just followed typescript here

+1 on the second question. Shouldn't there be a transformer in packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx for emailAddress?

There is a default transformer applied for type email in useFormControl

Yeah, looks good now

desiprisg · 2024-02-28T11:47:35Z

Description

Trim email addresses, usernames and the text identifier as whitespace at the start and end of the value is invalid.

To achieve the trimming for the identifier, a transformer prop has been added to useFormControl that can be used for other purposes as well.

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-02-28T11:47:39Z

🦋 Changeset detected

Latest commit: 1ddb455

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

nikosdouvlis · 2024-02-28T12:01:22Z

@desiprisg please add a description and a changeset as this does change the behavior of the components

desiprisg · 2024-02-28T12:05:51Z

!preview

clerk-cookie · 2024-02-28T12:10:31Z

Hey @desiprisg, your preview is available.

Status	Preview	Updated (UTC)
🍪 Deployed	Visit preview	Feb 28, 2024 12:10 PM

panteliselef · 2024-02-28T12:45:40Z

 options: [],
 defaultChecked: false,
 };
+ const transformer: NonNullable<typeof options.transformer> = options.transformer ? options.transformer : v => v;


🙃
Suggested change
consttransformer: NonNullable<typeofoptions.transformer>=options.transformer ?options.transformer :v=>v;
consttransformer: NonNullable<typeofoptions.transformer>=options.transformer??v=>v;

panteliselef · 2024-02-28T12:47:44Z

+let value = rest.value;
+let typeProps: Record<string, unknown> = { type };
+if (typeof value === 'string' && type === 'email') {
+value = value.trim();
+typeProps = { pattern: '^.*@[a-zA-Z0-9\\-]+\\.[a-zA-Z0-9\\-\\.]+$' };
+}


❓
Is it possible to have type='email' but not a value that is a string ?
I'd expect with the changes made in our useFormControl hook (below) that we wouldn't need to call value = value.trim(); manually here. Am i missing something ?

I just followed typescript here

+1 on the second question. Shouldn't there be a transformer in packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx for emailAddress?

There is a default transformer applied for type email in useFormControl

Yeah, looks good now

desiprisg · 2024-02-28T11:47:35Z

Description

Trim email addresses, usernames and the text identifier as whitespace at the start and end of the value is invalid.

To achieve the trimming for the identifier, a transformer prop has been added to useFormControl that can be used for other purposes as well.

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-02-28T11:47:39Z

🦋 Changeset detected

Latest commit: 1ddb455

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

nikosdouvlis · 2024-02-28T12:01:22Z

@desiprisg please add a description and a changeset as this does change the behavior of the components

desiprisg · 2024-02-28T12:05:51Z

!preview

clerk-cookie · 2024-02-28T12:10:31Z

Hey @desiprisg, your preview is available.

Status	Preview	Updated (UTC)
🍪 Deployed	Visit preview	Feb 28, 2024 12:10 PM

panteliselef · 2024-02-28T12:45:40Z

 options: [],
 defaultChecked: false,
 };
+ const transformer: NonNullable<typeof options.transformer> = options.transformer ? options.transformer : v => v;


🙃
Suggested change
consttransformer: NonNullable<typeofoptions.transformer>=options.transformer ?options.transformer :v=>v;
consttransformer: NonNullable<typeofoptions.transformer>=options.transformer??v=>v;

panteliselef · 2024-02-28T12:47:44Z

+let value = rest.value;
+let typeProps: Record<string, unknown> = { type };
+if (typeof value === 'string' && type === 'email') {
+value = value.trim();
+typeProps = { pattern: '^.*@[a-zA-Z0-9\\-]+\\.[a-zA-Z0-9\\-\\.]+$' };
+}


❓
Is it possible to have type='email' but not a value that is a string ?
I'd expect with the changes made in our useFormControl hook (below) that we wouldn't need to call value = value.trim(); manually here. Am i missing something ?

I just followed typescript here

+1 on the second question. Shouldn't there be a transformer in packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx for emailAddress?

There is a default transformer applied for type email in useFormControl

Yeah, looks good now

desiprisg requested review from nikosdouvlis and panteliselef February 28, 2024 11:47

clerk-cookie added the clerk-js label Feb 28, 2024

desiprisg force-pushed the george/sdk-1417-white-space-around-email-in-signin-results-in-error-no-trim branch from 2045d60 to 34bce6eCompare February 28, 2024 12:04

desiprisg self-assigned this Feb 28, 2024

panteliselef reviewed Feb 28, 2024
View reviewed changes

fix(clerk-js): Trim emails, usernames and identifiers
1ddb455

desiprisg force-pushed the george/sdk-1417-white-space-around-email-in-signin-results-in-error-no-trim branch from 34bce6e to 1ddb455Compare February 28, 2024 13:38

panteliselef approved these changes Feb 28, 2024
View reviewed changes

Comment threadpackages/clerk-js/src/ui/utils/useFormControl.ts

nikosdouvlis merged commit 7904096 into mainFeb 28, 2024

nikosdouvlis deleted the george/sdk-1417-white-space-around-email-in-signin-results-in-error-no-trim branch February 28, 2024 13:55

clerk-cookie mentioned this pull request Feb 28, 2024
Version Packages (beta) #2886
Merged

desiprisg requested review from nikosdouvlis and panteliselef February 28, 2024 11:47

clerk-cookie added the clerk-js label Feb 28, 2024

desiprisg force-pushed the george/sdk-1417-white-space-around-email-in-signin-results-in-error-no-trim branch from 2045d60 to 34bce6eCompare February 28, 2024 12:04

desiprisg self-assigned this Feb 28, 2024

panteliselef reviewed Feb 28, 2024
View reviewed changes

fix(clerk-js): Trim emails, usernames and identifiers
1ddb455

desiprisg force-pushed the george/sdk-1417-white-space-around-email-in-signin-results-in-error-no-trim branch from 34bce6e to 1ddb455Compare February 28, 2024 13:38

panteliselef approved these changes Feb 28, 2024
View reviewed changes

Comment threadpackages/clerk-js/src/ui/utils/useFormControl.ts

nikosdouvlis merged commit 7904096 into mainFeb 28, 2024

nikosdouvlis deleted the george/sdk-1417-white-space-around-email-in-signin-results-in-error-no-trim branch February 28, 2024 13:55

clerk-cookie mentioned this pull request Feb 28, 2024
Version Packages (beta) #2886
Merged

desiprisg requested review from nikosdouvlis and panteliselef February 28, 2024 11:47

clerk-cookie added the clerk-js label Feb 28, 2024

desiprisg force-pushed the george/sdk-1417-white-space-around-email-in-signin-results-in-error-no-trim branch from 2045d60 to 34bce6eCompare February 28, 2024 12:04

desiprisg self-assigned this Feb 28, 2024

panteliselef reviewed Feb 28, 2024
View reviewed changes

fix(clerk-js): Trim emails, usernames and identifiers
1ddb455

desiprisg force-pushed the george/sdk-1417-white-space-around-email-in-signin-results-in-error-no-trim branch from 34bce6e to 1ddb455Compare February 28, 2024 13:38

panteliselef approved these changes Feb 28, 2024
View reviewed changes

Comment threadpackages/clerk-js/src/ui/utils/useFormControl.ts

nikosdouvlis merged commit 7904096 into mainFeb 28, 2024

nikosdouvlis deleted the george/sdk-1417-white-space-around-email-in-signin-results-in-error-no-trim branch February 28, 2024 13:55

clerk-cookie mentioned this pull request Feb 28, 2024
Version Packages (beta) #2886
Merged

desiprisg requested review from nikosdouvlis and panteliselef February 28, 2024 11:47

clerk-cookie added the clerk-js label Feb 28, 2024

desiprisg force-pushed the george/sdk-1417-white-space-around-email-in-signin-results-in-error-no-trim branch from 2045d60 to 34bce6eCompare February 28, 2024 12:04

desiprisg self-assigned this Feb 28, 2024

panteliselef reviewed Feb 28, 2024
View reviewed changes

fix(clerk-js): Trim emails, usernames and identifiers
1ddb455

desiprisg force-pushed the george/sdk-1417-white-space-around-email-in-signin-results-in-error-no-trim branch from 34bce6e to 1ddb455Compare February 28, 2024 13:38

panteliselef approved these changes Feb 28, 2024
View reviewed changes

Comment threadpackages/clerk-js/src/ui/utils/useFormControl.ts

nikosdouvlis merged commit 7904096 into mainFeb 28, 2024

nikosdouvlis deleted the george/sdk-1417-white-space-around-email-in-signin-results-in-error-no-trim branch February 28, 2024 13:55

clerk-cookie mentioned this pull request Feb 28, 2024
Version Packages (beta) #2886
Merged

desiprisg requested review from nikosdouvlis and panteliselef February 28, 2024 11:47

clerk-cookie added the clerk-js label Feb 28, 2024

desiprisg force-pushed the george/sdk-1417-white-space-around-email-in-signin-results-in-error-no-trim branch from 2045d60 to 34bce6eCompare February 28, 2024 12:04

desiprisg self-assigned this Feb 28, 2024

panteliselef reviewed Feb 28, 2024
View reviewed changes

fix(clerk-js): Trim emails, usernames and identifiers
1ddb455

desiprisg force-pushed the george/sdk-1417-white-space-around-email-in-signin-results-in-error-no-trim branch from 34bce6e to 1ddb455Compare February 28, 2024 13:38

panteliselef approved these changes Feb 28, 2024
View reviewed changes

Comment threadpackages/clerk-js/src/ui/utils/useFormControl.ts

nikosdouvlis merged commit 7904096 into mainFeb 28, 2024

nikosdouvlis deleted the george/sdk-1417-white-space-around-email-in-signin-results-in-error-no-trim branch February 28, 2024 13:55

clerk-cookie mentioned this pull request Feb 28, 2024
Version Packages (beta) #2886
Merged

desiprisg requested review from nikosdouvlis and panteliselef February 28, 2024 11:47

clerk-cookie added the clerk-js label Feb 28, 2024

desiprisg force-pushed the george/sdk-1417-white-space-around-email-in-signin-results-in-error-no-trim branch from 2045d60 to 34bce6eCompare February 28, 2024 12:04

desiprisg self-assigned this Feb 28, 2024

panteliselef reviewed Feb 28, 2024
View reviewed changes

fix(clerk-js): Trim emails, usernames and identifiers
1ddb455

desiprisg force-pushed the george/sdk-1417-white-space-around-email-in-signin-results-in-error-no-trim branch from 34bce6e to 1ddb455Compare February 28, 2024 13:38

panteliselef approved these changes Feb 28, 2024
View reviewed changes

Comment threadpackages/clerk-js/src/ui/utils/useFormControl.ts

nikosdouvlis merged commit 7904096 into mainFeb 28, 2024

nikosdouvlis deleted the george/sdk-1417-white-space-around-email-in-signin-results-in-error-no-trim branch February 28, 2024 13:55

clerk-cookie mentioned this pull request Feb 28, 2024
Version Packages (beta) #2886
Merged

desiprisg requested review from nikosdouvlis and panteliselef February 28, 2024 11:47

clerk-cookie added the clerk-js label Feb 28, 2024

desiprisg force-pushed the george/sdk-1417-white-space-around-email-in-signin-results-in-error-no-trim branch from 2045d60 to 34bce6eCompare February 28, 2024 12:04

desiprisg self-assigned this Feb 28, 2024

panteliselef reviewed Feb 28, 2024
View reviewed changes

fix(clerk-js): Trim emails, usernames and identifiers
1ddb455

desiprisg force-pushed the george/sdk-1417-white-space-around-email-in-signin-results-in-error-no-trim branch from 34bce6e to 1ddb455Compare February 28, 2024 13:38

panteliselef approved these changes Feb 28, 2024
View reviewed changes

Comment threadpackages/clerk-js/src/ui/utils/useFormControl.ts

nikosdouvlis merged commit 7904096 into mainFeb 28, 2024

nikosdouvlis deleted the george/sdk-1417-white-space-around-email-in-signin-results-in-error-no-trim branch February 28, 2024 13:55

clerk-cookie mentioned this pull request Feb 28, 2024
Version Packages (beta) #2886
Merged

desiprisg requested review from nikosdouvlis and panteliselef February 28, 2024 11:47

clerk-cookie added the clerk-js label Feb 28, 2024

desiprisg force-pushed the george/sdk-1417-white-space-around-email-in-signin-results-in-error-no-trim branch from 2045d60 to 34bce6eCompare February 28, 2024 12:04

desiprisg self-assigned this Feb 28, 2024

panteliselef reviewed Feb 28, 2024
View reviewed changes

fix(clerk-js): Trim emails, usernames and identifiers
1ddb455

desiprisg force-pushed the george/sdk-1417-white-space-around-email-in-signin-results-in-error-no-trim branch from 34bce6e to 1ddb455Compare February 28, 2024 13:38

panteliselef approved these changes Feb 28, 2024
View reviewed changes

Comment threadpackages/clerk-js/src/ui/utils/useFormControl.ts

nikosdouvlis merged commit 7904096 into mainFeb 28, 2024

nikosdouvlis deleted the george/sdk-1417-white-space-around-email-in-signin-results-in-error-no-trim branch February 28, 2024 13:55

clerk-cookie mentioned this pull request Feb 28, 2024
Version Packages (beta) #2886
Merged

	consttransformer: NonNullable<typeofoptions.transformer>=options.transformer ?options.transformer :v=>v;
	consttransformer: NonNullable<typeofoptions.transformer>=options.transformer??v=>v;

Uh oh!

Conversation

desiprisg commented Feb 28, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

changeset-botBot commented Feb 28, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

nikosdouvlis commented Feb 28, 2024

Uh oh!

desiprisg commented Feb 28, 2024

Uh oh!

clerk-cookie commented Feb 28, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

desiprisg commented Feb 28, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

changeset-botBot commented Feb 28, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

nikosdouvlis commented Feb 28, 2024

Uh oh!

desiprisg commented Feb 28, 2024

Uh oh!

clerk-cookie commented Feb 28, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

desiprisg commented Feb 28, 2024•
edited
Loading

changeset-botBot commented Feb 28, 2024•
edited
Loading

clerk-cookie commented Feb 28, 2024•
edited
Loading

desiprisg commented Feb 28, 2024•
edited
Loading

changeset-botBot commented Feb 28, 2024•
edited
Loading

clerk-cookie commented Feb 28, 2024•
edited
Loading

desiprisg commented Feb 28, 2024•
edited
Loading

changeset-botBot commented Feb 28, 2024•
edited
Loading

clerk-cookie commented Feb 28, 2024•
edited
Loading