Skip to content

fix(nextjs,clerk-js): Make useAwaitableNavigate handle navigations be… - #2899

Merged
nikosdouvlis merged 1 commit into
mainfrom
nikos/v5-fix-awaitable-navigate
Mar 1, 2024
Merged

fix(nextjs,clerk-js): Make useAwaitableNavigate handle navigations be…#2899
nikosdouvlis merged 1 commit into
mainfrom
nikos/v5-fix-awaitable-navigate

Conversation

@nikosdouvlis

@nikosdouvlisnikosdouvlis commented Feb 29, 2024

Copy link
Copy Markdown
Member

…tween pages reliably

We need to use window to store the reference to the buffer, as ClerkProvider might be unmounted and remounted during navigations. If we use a ref, it will be reset when ClerkProvider is unmounted

v5 port of #2889

Description

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented Feb 29, 2024•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 816cd12

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
NameType
@clerk/clerk-jsPatch
@clerk/nextjsPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nikosdouvlis

nikosdouvlis commented Feb 29, 2024

Copy link
Copy Markdown
MemberAuthor

!snapshot

@clerk-cookie

clerk-cookie commented Feb 29, 2024

Copy link
Copy Markdown
Collaborator

Hey @nikosdouvlis - the snapshot version command generated the following package versions:

PackageVersion
@clerk/backend1.0.1-snapshot.v009a4cc
@clerk/chrome-extension1.0.1-snapshot.v009a4cc
@clerk/clerk-js5.0.1-snapshot.v009a4cc
@clerk/clerk-expo1.0.1-snapshot.v009a4cc
@clerk/fastify1.0.1-snapshot.v009a4cc
gatsby-plugin-clerk5.0.1-snapshot.v009a4cc
@clerk/localizations2.0.1-snapshot.v009a4cc
@clerk/nextjs5.0.1-snapshot.v009a4cc
@clerk/clerk-react5.0.1-snapshot.v009a4cc
@clerk/remix4.0.1-snapshot.v009a4cc
@clerk/clerk-sdk-node5.0.1-snapshot.v009a4cc
@clerk/shared2.0.1-snapshot.v009a4cc
@clerk/themes2.0.1-snapshot.v009a4cc
@clerk/types4.0.1-snapshot.v009a4cc

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend

npm i @clerk/backend@1.0.1-snapshot.v009a4cc --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.0.1-snapshot.v009a4cc --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.0.1-snapshot.v009a4cc --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.0.1-snapshot.v009a4cc --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.1-snapshot.v009a4cc --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.1-snapshot.v009a4cc --save-exact

@clerk/localizations

npm i @clerk/localizations@2.0.1-snapshot.v009a4cc --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.0.1-snapshot.v009a4cc --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.0.1-snapshot.v009a4cc --save-exact

@clerk/remix

npm i @clerk/remix@4.0.1-snapshot.v009a4cc --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.1-snapshot.v009a4cc --save-exact

@clerk/shared

npm i @clerk/shared@2.0.1-snapshot.v009a4cc --save-exact

@clerk/themes

npm i @clerk/themes@2.0.1-snapshot.v009a4cc --save-exact

@clerk/types

npm i @clerk/types@4.0.1-snapshot.v009a4cc --save-exact

@nikosdouvlis
nikosdouvlisforce-pushed the nikos/v5-fix-awaitable-navigate branch from 009a4cc to ee06378CompareFebruary 29, 2024 23:50
@nikosdouvlis
fix(nextjs,clerk-js): Make useAwaitableNavigate handle navigations be…
816cd12
…tween pages reliably
We need to use window to store the reference to the buffer, as ClerkProvider might be unmounted and remounted during navigations. If we use a ref, it will be reset when ClerkProvider is unmounted
@nikosdouvlis
nikosdouvlisforce-pushed the nikos/v5-fix-awaitable-navigate branch from ee06378 to 816cd12CompareMarch 1, 2024 00:35
@nikosdouvlis
nikosdouvlis merged commit 0462241 into mainMar 1, 2024
@nikosdouvlis
nikosdouvlis deleted the nikos/v5-fix-awaitable-navigate branch March 1, 2024 00:45
@clerk-cookieclerk-cookie mentioned this pull request Feb 29, 2024
Merged
jacekradko added a commit that referenced this pull request Mar 5, 2026
@jacekradko
test(nextjs): Add tests for useInternalNavFun navigation promise reso…
47ecfbd
…lution
Add unit and integration tests to validate that removing usePathname
from useInternalNavFun's effect deps (#7989) doesn't regress the
navigation promise flushing behavior originally fixed in #2899.
Unit tests:
- Single navigation promise resolves via isPending alone
- Pre-existing window buffer flushed on mount (ClerkProvider remount)
- Pending promises flushed on unmount (ClerkProvider unmount)
- Internal navigations use history pushState instead of router
Integration tests (cache-components / cacheComponents: true):
- Sign out completes without hanging (exercises full setActive → navigate → routerPush → useInternalNavFun chain)
- Protected route redirects correctly after sign out (validates cache invalidation + navigation)
@jacekradkojacekradko mentioned this pull request Mar 5, 2026
Merged
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

clerk-jsnextjs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nikosdouvlis@clerk-cookie
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(nextjs,clerk-js): Make useAwaitableNavigate handle navigations be… by nikosdouvlis · Pull Request #2899 · clerk/javascript · GitHub
Skip to content
fix(nextjs,clerk-js): Make useAwaitableNavigate handle navigations be… - #2899
Merged
nikosdouvlis merged 1 commit into
mainfrom 
nikos/v5-fix-awaitable-navigate
Mar 1, 2024
Merged
fix(nextjs,clerk-js): Make useAwaitableNavigate handle navigations be…#2899
nikosdouvlis merged 1 commit into
mainfrom 
nikos/v5-fix-awaitable-navigate
Conversation
@nikosdouvlis
@nikosdouvlisnikosdouvlis
commented
Feb 29, 2024

Copy link


Copy Markdown

Member
…tween pages reliably
We need to use window to store the reference to the buffer, as ClerkProvider might be unmounted and remounted during navigations. If we use a ref, it will be reset when ClerkProvider is unmounted
v5 port of #2889
Description
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@changeset-bot
changeset-botBot
commented
Feb 29, 2024•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 816cd12
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 4 packages
NameType
@clerk/clerk-jsPatch
@clerk/nextjsPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@nikosdouvlis
nikosdouvlis
commented
Feb 29, 2024

Copy link


Copy Markdown

MemberAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Feb 29, 2024

Copy link


Copy Markdown

Collaborator
Hey @nikosdouvlis - the snapshot version command generated the following package versions:
PackageVersion
@clerk/backend1.0.1-snapshot.v009a4cc
@clerk/chrome-extension1.0.1-snapshot.v009a4cc
@clerk/clerk-js5.0.1-snapshot.v009a4cc
@clerk/clerk-expo1.0.1-snapshot.v009a4cc
@clerk/fastify1.0.1-snapshot.v009a4cc
gatsby-plugin-clerk5.0.1-snapshot.v009a4cc
@clerk/localizations2.0.1-snapshot.v009a4cc
@clerk/nextjs5.0.1-snapshot.v009a4cc
@clerk/clerk-react5.0.1-snapshot.v009a4cc
@clerk/remix4.0.1-snapshot.v009a4cc
@clerk/clerk-sdk-node5.0.1-snapshot.v009a4cc
@clerk/shared2.0.1-snapshot.v009a4cc
@clerk/themes2.0.1-snapshot.v009a4cc
@clerk/types4.0.1-snapshot.v009a4cc
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend
npm i @clerk/backend@1.0.1-snapshot.v009a4cc --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@1.0.1-snapshot.v009a4cc --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.0.1-snapshot.v009a4cc --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@1.0.1-snapshot.v009a4cc --save-exact
@clerk/fastify
npm i @clerk/fastify@1.0.1-snapshot.v009a4cc --save-exact
gatsby-plugin-clerk
npm i gatsby-plugin-clerk@5.0.1-snapshot.v009a4cc --save-exact
@clerk/localizations
npm i @clerk/localizations@2.0.1-snapshot.v009a4cc --save-exact
@clerk/nextjs
npm i @clerk/nextjs@5.0.1-snapshot.v009a4cc --save-exact
@clerk/clerk-react
npm i @clerk/clerk-react@5.0.1-snapshot.v009a4cc --save-exact
@clerk/remix
npm i @clerk/remix@4.0.1-snapshot.v009a4cc --save-exact
@clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@5.0.1-snapshot.v009a4cc --save-exact
@clerk/shared
npm i @clerk/shared@2.0.1-snapshot.v009a4cc --save-exact
@clerk/themes
npm i @clerk/themes@2.0.1-snapshot.v009a4cc --save-exact
@clerk/types
npm i @clerk/types@4.0.1-snapshot.v009a4cc --save-exact
@nikosdouvlis
nikosdouvlisforce-pushed
the
nikos/v5-fix-awaitable-navigate
branch
from
009a4cc to
ee06378CompareFebruary 29, 2024 23:50
@nikosdouvlis
fix(nextjs,clerk-js): Make useAwaitableNavigate handle navigations be…
816cd12
…tween pages reliably
We need to use window to store the reference to the buffer, as ClerkProvider might be unmounted and remounted during navigations. If we use a ref, it will be reset when ClerkProvider is unmounted
@nikosdouvlis
nikosdouvlisforce-pushed
the
nikos/v5-fix-awaitable-navigate
branch
from
ee06378 to
816cd12CompareMarch 1, 2024 00:35
@nikosdouvlis
nikosdouvlis
merged commit 0462241
into
mainMar 1, 2024
@nikosdouvlis
nikosdouvlis
deleted the

nikos/v5-fix-awaitable-navigate

branch
March 1, 2024 00:45
@clerk-cookieclerk-cookie
mentioned this pull request
Feb 29, 2024
 Merged

jacekradko added a commit
that referenced
this pull request
Mar 5, 2026
@jacekradko
test(nextjs): Add tests for useInternalNavFun navigation promise reso…
47ecfbd
…lution
Add unit and integration tests to validate that removing usePathname
from useInternalNavFun's effect deps (#7989) doesn't regress the
navigation promise flushing behavior originally fixed in #2899.
Unit tests:
- Single navigation promise resolves via isPending alone
- Pre-existing window buffer flushed on mount (ClerkProvider remount)
- Pending promises flushed on unmount (ClerkProvider unmount)
- Internal navigations use history pushState instead of router
Integration tests (cache-components / cacheComponents: true):
- Sign out completes without hanging (exercises full setActive → navigate → routerPush → useInternalNavFun chain)
- Protected route redirects correctly after sign out (validates cache invalidation + navigation)
@jacekradkojacekradko
mentioned this pull request
Mar 5, 2026
 Merged

2 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

clerk-jsnextjs

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@nikosdouvlis@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(nextjs,clerk-js): Make useAwaitableNavigate handle navigations be… by nikosdouvlis · Pull Request #2899 · clerk/javascript · GitHub
Skip to content
fix(nextjs,clerk-js): Make useAwaitableNavigate handle navigations be… - #2899
Merged
nikosdouvlis merged 1 commit into
mainfrom 
nikos/v5-fix-awaitable-navigate
Mar 1, 2024
Merged
fix(nextjs,clerk-js): Make useAwaitableNavigate handle navigations be…#2899
nikosdouvlis merged 1 commit into
mainfrom 
nikos/v5-fix-awaitable-navigate
Conversation
@nikosdouvlis
@nikosdouvlisnikosdouvlis
commented
Feb 29, 2024

Copy link


Copy Markdown

Member
…tween pages reliably
We need to use window to store the reference to the buffer, as ClerkProvider might be unmounted and remounted during navigations. If we use a ref, it will be reset when ClerkProvider is unmounted
v5 port of #2889
Description
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@changeset-bot
changeset-botBot
commented
Feb 29, 2024•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 816cd12
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 4 packages
NameType
@clerk/clerk-jsPatch
@clerk/nextjsPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@nikosdouvlis
nikosdouvlis
commented
Feb 29, 2024

Copy link


Copy Markdown

MemberAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Feb 29, 2024

Copy link


Copy Markdown

Collaborator
Hey @nikosdouvlis - the snapshot version command generated the following package versions:
PackageVersion
@clerk/backend1.0.1-snapshot.v009a4cc
@clerk/chrome-extension1.0.1-snapshot.v009a4cc
@clerk/clerk-js5.0.1-snapshot.v009a4cc
@clerk/clerk-expo1.0.1-snapshot.v009a4cc
@clerk/fastify1.0.1-snapshot.v009a4cc
gatsby-plugin-clerk5.0.1-snapshot.v009a4cc
@clerk/localizations2.0.1-snapshot.v009a4cc
@clerk/nextjs5.0.1-snapshot.v009a4cc
@clerk/clerk-react5.0.1-snapshot.v009a4cc
@clerk/remix4.0.1-snapshot.v009a4cc
@clerk/clerk-sdk-node5.0.1-snapshot.v009a4cc
@clerk/shared2.0.1-snapshot.v009a4cc
@clerk/themes2.0.1-snapshot.v009a4cc
@clerk/types4.0.1-snapshot.v009a4cc
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend
npm i @clerk/backend@1.0.1-snapshot.v009a4cc --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@1.0.1-snapshot.v009a4cc --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.0.1-snapshot.v009a4cc --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@1.0.1-snapshot.v009a4cc --save-exact
@clerk/fastify
npm i @clerk/fastify@1.0.1-snapshot.v009a4cc --save-exact
gatsby-plugin-clerk
npm i gatsby-plugin-clerk@5.0.1-snapshot.v009a4cc --save-exact
@clerk/localizations
npm i @clerk/localizations@2.0.1-snapshot.v009a4cc --save-exact
@clerk/nextjs
npm i @clerk/nextjs@5.0.1-snapshot.v009a4cc --save-exact
@clerk/clerk-react
npm i @clerk/clerk-react@5.0.1-snapshot.v009a4cc --save-exact
@clerk/remix
npm i @clerk/remix@4.0.1-snapshot.v009a4cc --save-exact
@clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@5.0.1-snapshot.v009a4cc --save-exact
@clerk/shared
npm i @clerk/shared@2.0.1-snapshot.v009a4cc --save-exact
@clerk/themes
npm i @clerk/themes@2.0.1-snapshot.v009a4cc --save-exact
@clerk/types
npm i @clerk/types@4.0.1-snapshot.v009a4cc --save-exact
@nikosdouvlis
nikosdouvlisforce-pushed
the
nikos/v5-fix-awaitable-navigate
branch
from
009a4cc to
ee06378CompareFebruary 29, 2024 23:50
@nikosdouvlis
fix(nextjs,clerk-js): Make useAwaitableNavigate handle navigations be…
816cd12
…tween pages reliably
We need to use window to store the reference to the buffer, as ClerkProvider might be unmounted and remounted during navigations. If we use a ref, it will be reset when ClerkProvider is unmounted
@nikosdouvlis
nikosdouvlisforce-pushed
the
nikos/v5-fix-awaitable-navigate
branch
from
ee06378 to
816cd12CompareMarch 1, 2024 00:35
@nikosdouvlis
nikosdouvlis
merged commit 0462241
into
mainMar 1, 2024
@nikosdouvlis
nikosdouvlis
deleted the

nikos/v5-fix-awaitable-navigate

branch
March 1, 2024 00:45
@clerk-cookieclerk-cookie
mentioned this pull request
Feb 29, 2024
 Merged

jacekradko added a commit
that referenced
this pull request
Mar 5, 2026
@jacekradko
test(nextjs): Add tests for useInternalNavFun navigation promise reso…
47ecfbd
…lution
Add unit and integration tests to validate that removing usePathname
from useInternalNavFun's effect deps (#7989) doesn't regress the
navigation promise flushing behavior originally fixed in #2899.
Unit tests:
- Single navigation promise resolves via isPending alone
- Pre-existing window buffer flushed on mount (ClerkProvider remount)
- Pending promises flushed on unmount (ClerkProvider unmount)
- Internal navigations use history pushState instead of router
Integration tests (cache-components / cacheComponents: true):
- Sign out completes without hanging (exercises full setActive → navigate → routerPush → useInternalNavFun chain)
- Protected route redirects correctly after sign out (validates cache invalidation + navigation)
@jacekradkojacekradko
mentioned this pull request
Mar 5, 2026
 Merged

2 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

clerk-jsnextjs

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@nikosdouvlis@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(nextjs,clerk-js): Make useAwaitableNavigate handle navigations be… by nikosdouvlis · Pull Request #2899 · clerk/javascript · GitHub
Skip to content
fix(nextjs,clerk-js): Make useAwaitableNavigate handle navigations be… - #2899
Merged
nikosdouvlis merged 1 commit into
mainfrom 
nikos/v5-fix-awaitable-navigate
Mar 1, 2024
Merged
fix(nextjs,clerk-js): Make useAwaitableNavigate handle navigations be…#2899
nikosdouvlis merged 1 commit into
mainfrom 
nikos/v5-fix-awaitable-navigate
Conversation
@nikosdouvlis
@nikosdouvlisnikosdouvlis
commented
Feb 29, 2024

Copy link


Copy Markdown

Member
…tween pages reliably
We need to use window to store the reference to the buffer, as ClerkProvider might be unmounted and remounted during navigations. If we use a ref, it will be reset when ClerkProvider is unmounted
v5 port of #2889
Description
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@changeset-bot
changeset-botBot
commented
Feb 29, 2024•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 816cd12
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 4 packages
NameType
@clerk/clerk-jsPatch
@clerk/nextjsPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@nikosdouvlis
nikosdouvlis
commented
Feb 29, 2024

Copy link


Copy Markdown

MemberAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Feb 29, 2024

Copy link


Copy Markdown

Collaborator
Hey @nikosdouvlis - the snapshot version command generated the following package versions:
PackageVersion
@clerk/backend1.0.1-snapshot.v009a4cc
@clerk/chrome-extension1.0.1-snapshot.v009a4cc
@clerk/clerk-js5.0.1-snapshot.v009a4cc
@clerk/clerk-expo1.0.1-snapshot.v009a4cc
@clerk/fastify1.0.1-snapshot.v009a4cc
gatsby-plugin-clerk5.0.1-snapshot.v009a4cc
@clerk/localizations2.0.1-snapshot.v009a4cc
@clerk/nextjs5.0.1-snapshot.v009a4cc
@clerk/clerk-react5.0.1-snapshot.v009a4cc
@clerk/remix4.0.1-snapshot.v009a4cc
@clerk/clerk-sdk-node5.0.1-snapshot.v009a4cc
@clerk/shared2.0.1-snapshot.v009a4cc
@clerk/themes2.0.1-snapshot.v009a4cc
@clerk/types4.0.1-snapshot.v009a4cc
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend
npm i @clerk/backend@1.0.1-snapshot.v009a4cc --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@1.0.1-snapshot.v009a4cc --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.0.1-snapshot.v009a4cc --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@1.0.1-snapshot.v009a4cc --save-exact
@clerk/fastify
npm i @clerk/fastify@1.0.1-snapshot.v009a4cc --save-exact
gatsby-plugin-clerk
npm i gatsby-plugin-clerk@5.0.1-snapshot.v009a4cc --save-exact
@clerk/localizations
npm i @clerk/localizations@2.0.1-snapshot.v009a4cc --save-exact
@clerk/nextjs
npm i @clerk/nextjs@5.0.1-snapshot.v009a4cc --save-exact
@clerk/clerk-react
npm i @clerk/clerk-react@5.0.1-snapshot.v009a4cc --save-exact
@clerk/remix
npm i @clerk/remix@4.0.1-snapshot.v009a4cc --save-exact
@clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@5.0.1-snapshot.v009a4cc --save-exact
@clerk/shared
npm i @clerk/shared@2.0.1-snapshot.v009a4cc --save-exact
@clerk/themes
npm i @clerk/themes@2.0.1-snapshot.v009a4cc --save-exact
@clerk/types
npm i @clerk/types@4.0.1-snapshot.v009a4cc --save-exact
@nikosdouvlis
nikosdouvlisforce-pushed
the
nikos/v5-fix-awaitable-navigate
branch
from
009a4cc to
ee06378CompareFebruary 29, 2024 23:50
@nikosdouvlis
fix(nextjs,clerk-js): Make useAwaitableNavigate handle navigations be…
816cd12
…tween pages reliably
We need to use window to store the reference to the buffer, as ClerkProvider might be unmounted and remounted during navigations. If we use a ref, it will be reset when ClerkProvider is unmounted
@nikosdouvlis
nikosdouvlisforce-pushed
the
nikos/v5-fix-awaitable-navigate
branch
from
ee06378 to
816cd12CompareMarch 1, 2024 00:35
@nikosdouvlis
nikosdouvlis
merged commit 0462241
into
mainMar 1, 2024
@nikosdouvlis
nikosdouvlis
deleted the

nikos/v5-fix-awaitable-navigate

branch
March 1, 2024 00:45
@clerk-cookieclerk-cookie
mentioned this pull request
Feb 29, 2024
 Merged

jacekradko added a commit
that referenced
this pull request
Mar 5, 2026
@jacekradko
test(nextjs): Add tests for useInternalNavFun navigation promise reso…
47ecfbd
…lution
Add unit and integration tests to validate that removing usePathname
from useInternalNavFun's effect deps (#7989) doesn't regress the
navigation promise flushing behavior originally fixed in #2899.
Unit tests:
- Single navigation promise resolves via isPending alone
- Pre-existing window buffer flushed on mount (ClerkProvider remount)
- Pending promises flushed on unmount (ClerkProvider unmount)
- Internal navigations use history pushState instead of router
Integration tests (cache-components / cacheComponents: true):
- Sign out completes without hanging (exercises full setActive → navigate → routerPush → useInternalNavFun chain)
- Protected route redirects correctly after sign out (validates cache invalidation + navigation)
@jacekradkojacekradko
mentioned this pull request
Mar 5, 2026
 Merged

2 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

clerk-jsnextjs

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@nikosdouvlis@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(nextjs,clerk-js): Make useAwaitableNavigate handle navigations be… by nikosdouvlis · Pull Request #2899 · clerk/javascript · GitHub
Skip to content
fix(nextjs,clerk-js): Make useAwaitableNavigate handle navigations be… - #2899
Merged
nikosdouvlis merged 1 commit into
mainfrom 
nikos/v5-fix-awaitable-navigate
Mar 1, 2024
Merged
fix(nextjs,clerk-js): Make useAwaitableNavigate handle navigations be…#2899
nikosdouvlis merged 1 commit into
mainfrom 
nikos/v5-fix-awaitable-navigate
Conversation
@nikosdouvlis
@nikosdouvlisnikosdouvlis
commented
Feb 29, 2024

Copy link


Copy Markdown

Member
…tween pages reliably
We need to use window to store the reference to the buffer, as ClerkProvider might be unmounted and remounted during navigations. If we use a ref, it will be reset when ClerkProvider is unmounted
v5 port of #2889
Description
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@changeset-bot
changeset-botBot
commented
Feb 29, 2024•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 816cd12
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 4 packages
NameType
@clerk/clerk-jsPatch
@clerk/nextjsPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@nikosdouvlis
nikosdouvlis
commented
Feb 29, 2024

Copy link


Copy Markdown

MemberAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Feb 29, 2024

Copy link


Copy Markdown

Collaborator
Hey @nikosdouvlis - the snapshot version command generated the following package versions:
PackageVersion
@clerk/backend1.0.1-snapshot.v009a4cc
@clerk/chrome-extension1.0.1-snapshot.v009a4cc
@clerk/clerk-js5.0.1-snapshot.v009a4cc
@clerk/clerk-expo1.0.1-snapshot.v009a4cc
@clerk/fastify1.0.1-snapshot.v009a4cc
gatsby-plugin-clerk5.0.1-snapshot.v009a4cc
@clerk/localizations2.0.1-snapshot.v009a4cc
@clerk/nextjs5.0.1-snapshot.v009a4cc
@clerk/clerk-react5.0.1-snapshot.v009a4cc
@clerk/remix4.0.1-snapshot.v009a4cc
@clerk/clerk-sdk-node5.0.1-snapshot.v009a4cc
@clerk/shared2.0.1-snapshot.v009a4cc
@clerk/themes2.0.1-snapshot.v009a4cc
@clerk/types4.0.1-snapshot.v009a4cc
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend
npm i @clerk/backend@1.0.1-snapshot.v009a4cc --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@1.0.1-snapshot.v009a4cc --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.0.1-snapshot.v009a4cc --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@1.0.1-snapshot.v009a4cc --save-exact
@clerk/fastify
npm i @clerk/fastify@1.0.1-snapshot.v009a4cc --save-exact
gatsby-plugin-clerk
npm i gatsby-plugin-clerk@5.0.1-snapshot.v009a4cc --save-exact
@clerk/localizations
npm i @clerk/localizations@2.0.1-snapshot.v009a4cc --save-exact
@clerk/nextjs
npm i @clerk/nextjs@5.0.1-snapshot.v009a4cc --save-exact
@clerk/clerk-react
npm i @clerk/clerk-react@5.0.1-snapshot.v009a4cc --save-exact
@clerk/remix
npm i @clerk/remix@4.0.1-snapshot.v009a4cc --save-exact
@clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@5.0.1-snapshot.v009a4cc --save-exact
@clerk/shared
npm i @clerk/shared@2.0.1-snapshot.v009a4cc --save-exact
@clerk/themes
npm i @clerk/themes@2.0.1-snapshot.v009a4cc --save-exact
@clerk/types
npm i @clerk/types@4.0.1-snapshot.v009a4cc --save-exact
@nikosdouvlis
nikosdouvlisforce-pushed
the
nikos/v5-fix-awaitable-navigate
branch
from
009a4cc to
ee06378CompareFebruary 29, 2024 23:50
@nikosdouvlis
fix(nextjs,clerk-js): Make useAwaitableNavigate handle navigations be…
816cd12
…tween pages reliably
We need to use window to store the reference to the buffer, as ClerkProvider might be unmounted and remounted during navigations. If we use a ref, it will be reset when ClerkProvider is unmounted
@nikosdouvlis
nikosdouvlisforce-pushed
the
nikos/v5-fix-awaitable-navigate
branch
from
ee06378 to
816cd12CompareMarch 1, 2024 00:35
@nikosdouvlis
nikosdouvlis
merged commit 0462241
into
mainMar 1, 2024
@nikosdouvlis
nikosdouvlis
deleted the

nikos/v5-fix-awaitable-navigate

branch
March 1, 2024 00:45
@clerk-cookieclerk-cookie
mentioned this pull request
Feb 29, 2024
 Merged

jacekradko added a commit
that referenced
this pull request
Mar 5, 2026
@jacekradko
test(nextjs): Add tests for useInternalNavFun navigation promise reso…
47ecfbd
…lution
Add unit and integration tests to validate that removing usePathname
from useInternalNavFun's effect deps (#7989) doesn't regress the
navigation promise flushing behavior originally fixed in #2899.
Unit tests:
- Single navigation promise resolves via isPending alone
- Pre-existing window buffer flushed on mount (ClerkProvider remount)
- Pending promises flushed on unmount (ClerkProvider unmount)
- Internal navigations use history pushState instead of router
Integration tests (cache-components / cacheComponents: true):
- Sign out completes without hanging (exercises full setActive → navigate → routerPush → useInternalNavFun chain)
- Protected route redirects correctly after sign out (validates cache invalidation + navigation)
@jacekradkojacekradko
mentioned this pull request
Mar 5, 2026
 Merged

2 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

clerk-jsnextjs

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@nikosdouvlis@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(nextjs,clerk-js): Make useAwaitableNavigate handle navigations be… by nikosdouvlis · Pull Request #2899 · clerk/javascript · GitHub
Skip to content
fix(nextjs,clerk-js): Make useAwaitableNavigate handle navigations be… - #2899
Merged
nikosdouvlis merged 1 commit into
mainfrom 
nikos/v5-fix-awaitable-navigate
Mar 1, 2024
Merged
fix(nextjs,clerk-js): Make useAwaitableNavigate handle navigations be…#2899
nikosdouvlis merged 1 commit into
mainfrom 
nikos/v5-fix-awaitable-navigate
Conversation
@nikosdouvlis
@nikosdouvlisnikosdouvlis
commented
Feb 29, 2024

Copy link


Copy Markdown

Member
…tween pages reliably
We need to use window to store the reference to the buffer, as ClerkProvider might be unmounted and remounted during navigations. If we use a ref, it will be reset when ClerkProvider is unmounted
v5 port of #2889
Description
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@changeset-bot
changeset-botBot
commented
Feb 29, 2024•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 816cd12
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 4 packages
NameType
@clerk/clerk-jsPatch
@clerk/nextjsPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@nikosdouvlis
nikosdouvlis
commented
Feb 29, 2024

Copy link


Copy Markdown

MemberAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Feb 29, 2024

Copy link


Copy Markdown

Collaborator
Hey @nikosdouvlis - the snapshot version command generated the following package versions:
PackageVersion
@clerk/backend1.0.1-snapshot.v009a4cc
@clerk/chrome-extension1.0.1-snapshot.v009a4cc
@clerk/clerk-js5.0.1-snapshot.v009a4cc
@clerk/clerk-expo1.0.1-snapshot.v009a4cc
@clerk/fastify1.0.1-snapshot.v009a4cc
gatsby-plugin-clerk5.0.1-snapshot.v009a4cc
@clerk/localizations2.0.1-snapshot.v009a4cc
@clerk/nextjs5.0.1-snapshot.v009a4cc
@clerk/clerk-react5.0.1-snapshot.v009a4cc
@clerk/remix4.0.1-snapshot.v009a4cc
@clerk/clerk-sdk-node5.0.1-snapshot.v009a4cc
@clerk/shared2.0.1-snapshot.v009a4cc
@clerk/themes2.0.1-snapshot.v009a4cc
@clerk/types4.0.1-snapshot.v009a4cc
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend
npm i @clerk/backend@1.0.1-snapshot.v009a4cc --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@1.0.1-snapshot.v009a4cc --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.0.1-snapshot.v009a4cc --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@1.0.1-snapshot.v009a4cc --save-exact
@clerk/fastify
npm i @clerk/fastify@1.0.1-snapshot.v009a4cc --save-exact
gatsby-plugin-clerk
npm i gatsby-plugin-clerk@5.0.1-snapshot.v009a4cc --save-exact
@clerk/localizations
npm i @clerk/localizations@2.0.1-snapshot.v009a4cc --save-exact
@clerk/nextjs
npm i @clerk/nextjs@5.0.1-snapshot.v009a4cc --save-exact
@clerk/clerk-react
npm i @clerk/clerk-react@5.0.1-snapshot.v009a4cc --save-exact
@clerk/remix
npm i @clerk/remix@4.0.1-snapshot.v009a4cc --save-exact
@clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@5.0.1-snapshot.v009a4cc --save-exact
@clerk/shared
npm i @clerk/shared@2.0.1-snapshot.v009a4cc --save-exact
@clerk/themes
npm i @clerk/themes@2.0.1-snapshot.v009a4cc --save-exact
@clerk/types
npm i @clerk/types@4.0.1-snapshot.v009a4cc --save-exact
@nikosdouvlis
nikosdouvlisforce-pushed
the
nikos/v5-fix-awaitable-navigate
branch
from
009a4cc to
ee06378CompareFebruary 29, 2024 23:50
@nikosdouvlis
fix(nextjs,clerk-js): Make useAwaitableNavigate handle navigations be…
816cd12
…tween pages reliably
We need to use window to store the reference to the buffer, as ClerkProvider might be unmounted and remounted during navigations. If we use a ref, it will be reset when ClerkProvider is unmounted
@nikosdouvlis
nikosdouvlisforce-pushed
the
nikos/v5-fix-awaitable-navigate
branch
from
ee06378 to
816cd12CompareMarch 1, 2024 00:35
@nikosdouvlis
nikosdouvlis
merged commit 0462241
into
mainMar 1, 2024
@nikosdouvlis
nikosdouvlis
deleted the

nikos/v5-fix-awaitable-navigate

branch
March 1, 2024 00:45
@clerk-cookieclerk-cookie
mentioned this pull request
Feb 29, 2024
 Merged

jacekradko added a commit
that referenced
this pull request
Mar 5, 2026
@jacekradko
test(nextjs): Add tests for useInternalNavFun navigation promise reso…
47ecfbd
…lution
Add unit and integration tests to validate that removing usePathname
from useInternalNavFun's effect deps (#7989) doesn't regress the
navigation promise flushing behavior originally fixed in #2899.
Unit tests:
- Single navigation promise resolves via isPending alone
- Pre-existing window buffer flushed on mount (ClerkProvider remount)
- Pending promises flushed on unmount (ClerkProvider unmount)
- Internal navigations use history pushState instead of router
Integration tests (cache-components / cacheComponents: true):
- Sign out completes without hanging (exercises full setActive → navigate → routerPush → useInternalNavFun chain)
- Protected route redirects correctly after sign out (validates cache invalidation + navigation)
@jacekradkojacekradko
mentioned this pull request
Mar 5, 2026
 Merged

2 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

clerk-jsnextjs

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@nikosdouvlis@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
fix(nextjs,clerk-js): Make useAwaitableNavigate handle navigations be… by nikosdouvlis · Pull Request #2899 · clerk/javascript · GitHub
Skip to content
fix(nextjs,clerk-js): Make useAwaitableNavigate handle navigations be… - #2899
Merged
nikosdouvlis merged 1 commit into
mainfrom 
nikos/v5-fix-awaitable-navigate
Mar 1, 2024
Merged
fix(nextjs,clerk-js): Make useAwaitableNavigate handle navigations be…#2899
nikosdouvlis merged 1 commit into
mainfrom 
nikos/v5-fix-awaitable-navigate
Conversation
@nikosdouvlis
@nikosdouvlisnikosdouvlis
commented
Feb 29, 2024

Copy link


Copy Markdown

Member
…tween pages reliably
We need to use window to store the reference to the buffer, as ClerkProvider might be unmounted and remounted during navigations. If we use a ref, it will be reset when ClerkProvider is unmounted
v5 port of #2889
Description
Checklist
  • npm test runs as expected.
  • npm run build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@changeset-bot
changeset-botBot
commented
Feb 29, 2024•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 816cd12
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 4 packages
NameType
@clerk/clerk-jsPatch
@clerk/nextjsPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@nikosdouvlis
nikosdouvlis
commented
Feb 29, 2024

Copy link


Copy Markdown

MemberAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Feb 29, 2024

Copy link


Copy Markdown

Collaborator
Hey @nikosdouvlis - the snapshot version command generated the following package versions:
PackageVersion
@clerk/backend1.0.1-snapshot.v009a4cc
@clerk/chrome-extension1.0.1-snapshot.v009a4cc
@clerk/clerk-js5.0.1-snapshot.v009a4cc
@clerk/clerk-expo1.0.1-snapshot.v009a4cc
@clerk/fastify1.0.1-snapshot.v009a4cc
gatsby-plugin-clerk5.0.1-snapshot.v009a4cc
@clerk/localizations2.0.1-snapshot.v009a4cc
@clerk/nextjs5.0.1-snapshot.v009a4cc
@clerk/clerk-react5.0.1-snapshot.v009a4cc
@clerk/remix4.0.1-snapshot.v009a4cc
@clerk/clerk-sdk-node5.0.1-snapshot.v009a4cc
@clerk/shared2.0.1-snapshot.v009a4cc
@clerk/themes2.0.1-snapshot.v009a4cc
@clerk/types4.0.1-snapshot.v009a4cc
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend
npm i @clerk/backend@1.0.1-snapshot.v009a4cc --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@1.0.1-snapshot.v009a4cc --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.0.1-snapshot.v009a4cc --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@1.0.1-snapshot.v009a4cc --save-exact
@clerk/fastify
npm i @clerk/fastify@1.0.1-snapshot.v009a4cc --save-exact
gatsby-plugin-clerk
npm i gatsby-plugin-clerk@5.0.1-snapshot.v009a4cc --save-exact
@clerk/localizations
npm i @clerk/localizations@2.0.1-snapshot.v009a4cc --save-exact
@clerk/nextjs
npm i @clerk/nextjs@5.0.1-snapshot.v009a4cc --save-exact
@clerk/clerk-react
npm i @clerk/clerk-react@5.0.1-snapshot.v009a4cc --save-exact
@clerk/remix
npm i @clerk/remix@4.0.1-snapshot.v009a4cc --save-exact
@clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@5.0.1-snapshot.v009a4cc --save-exact
@clerk/shared
npm i @clerk/shared@2.0.1-snapshot.v009a4cc --save-exact
@clerk/themes
npm i @clerk/themes@2.0.1-snapshot.v009a4cc --save-exact
@clerk/types
npm i @clerk/types@4.0.1-snapshot.v009a4cc --save-exact
@nikosdouvlis
nikosdouvlisforce-pushed
the
nikos/v5-fix-awaitable-navigate
branch
from
009a4cc to
ee06378CompareFebruary 29, 2024 23:50
@nikosdouvlis
fix(nextjs,clerk-js): Make useAwaitableNavigate handle navigations be…
816cd12
…tween pages reliably
We need to use window to store the reference to the buffer, as ClerkProvider might be unmounted and remounted during navigations. If we use a ref, it will be reset when ClerkProvider is unmounted
@nikosdouvlis
nikosdouvlisforce-pushed
the
nikos/v5-fix-awaitable-navigate
branch
from
ee06378 to
816cd12CompareMarch 1, 2024 00:35
@nikosdouvlis
nikosdouvlis
merged commit 0462241
into
mainMar 1, 2024
@nikosdouvlis
nikosdouvlis
deleted the

nikos/v5-fix-awaitable-navigate

branch
March 1, 2024 00:45
@clerk-cookieclerk-cookie
mentioned this pull request
Feb 29, 2024
 Merged

jacekradko added a commit
that referenced
this pull request
Mar 5, 2026
@jacekradko
test(nextjs): Add tests for useInternalNavFun navigation promise reso…
47ecfbd
…lution
Add unit and integration tests to validate that removing usePathname
from useInternalNavFun's effect deps (#7989) doesn't regress the
navigation promise flushing behavior originally fixed in #2899.
Unit tests:
- Single navigation promise resolves via isPending alone
- Pre-existing window buffer flushed on mount (ClerkProvider remount)
- Pending promises flushed on unmount (ClerkProvider unmount)
- Internal navigations use history pushState instead of router
Integration tests (cache-components / cacheComponents: true):
- Sign out completes without hanging (exercises full setActive → navigate → routerPush → useInternalNavFun chain)
- Protected route redirects correctly after sign out (validates cache invalidation + navigation)
@jacekradkojacekradko
mentioned this pull request
Mar 5, 2026
 Merged

2 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

clerk-jsnextjs

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@nikosdouvlis@clerk-cookie