Uh oh!
There was an error while loading. Please reload this page.
feat(express): Introduce Clerk package for Express - #2918
Conversation
🦋 Changeset detectedLatest commit: 55d9b64 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LekoArts
left a comment
There was a problem hiding this comment.
First pass at looking through the changes :)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
e213120 to
3ed2a03Compared771634 to
94530c5Compare61e0396 to
2029c38Compare3d62ee1 to
5ac94e9Comparedimkl
commented
Apr 2, 2024
@LekoArts, @nikosdouvlis Could you take another look at this PR? |
e13a230 to
4a035c5Compare
LekoArts
left a comment
There was a problem hiding this comment.
Overall LGTM, some minor comments I'd like to resolve before merging
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
30cceb7 to
91e596aCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Lennart <lekoarts@gmail.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
… instead of implicit creation
Description
Introduce Express specific Clerk SDK
@clerk/express. The SDK exposes the following API:clerkClient: default @clerk/backend client initialized from env variables and used to make BAPI requestsclerkMiddleware: centralized middleware that authenticates all requests without blocking them (also triggers handshake mechanism)getAuth: utility to retrieve the auth state from the request (requires clerkMiddleware to executed)requireAuth: middleware that returns http 401 response when request is signed-outAlso all the top level exports from
@clerk/backendare re-exported from@clerk/expresstop level.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
TODOs
TODO(express)TODOs