feat(clerk-expo): Remove headers causing CORS errors by thiskevinwang · Pull Request #3326 · clerk/javascript

thiskevinwang · 2024-05-06T16:08:05Z

Description

This removes two headers, added in #2528, that are resulting in CORS errors being returned from the Clerk Frontend API.

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-05-06T16:08:08Z

🦋 Changeset detected

Latest commit: 9e6b63f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/clerk-expo	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

panteliselef · 2024-05-06T20:38:12Z

- // Send some non-identifying headers that are useful for logging
- (requestInit.headers as Headers).set('x-expo-execution-environment', Constants.executionEnvironment);
- (requestInit.headers as Headers).set(
- 'x-expo-native-application-version',
- Application.nativeApplicationVersion || 'NULL',
- );


@thiskevinwang If having this kind of information was useful, and don't wanna completely removed it, couldn't we just do this ?
if(!isValidBrowser()){// Send some non-identifying headers that are useful for logging(requestInit.headersasHeaders).set('x-expo-execution-environment',Constants.executionEnvironment);(requestInit.headersasHeaders).set('x-expo-native-application-version',Application.nativeApplicationVersion||'NULL',);}
of use import { Platform } from 'react-native';
if(Platform.OS!=='web'){// Send some non-identifying headers that are useful for logging(requestInit.headersasHeaders).set('x-expo-execution-environment',Constants.executionEnvironment);(requestInit.headersasHeaders).set('x-expo-native-application-version',Application.nativeApplicationVersion||'NULL',);}

@panteliselef Oh, smart thinking! But also...
If having this kind of information was useful
...Turns out, it was not particularly useful so I'd say we just remove this!

- this reverts #2528

panteliselef

lgtm

anagstef · 2024-05-09T13:36:38Z

+Remove headers that were added in #2528
+
+Remove `expo-application` & `expo-constants` peer deps


@thiskevinwang Maybe we could make this a little bit easier to read, as it'll be included in the changelog which is facing the developers using our product. For example, let's mention what are the headers this change removes. :)

Updated in 05e82b4

dimkl · 2024-05-09T18:05:29Z

@thiskevinwang You should also remove those dependencies from the devDependencies.

Done in 05e82b4

thiskevinwang · 2024-05-06T16:08:05Z

Description

This removes two headers, added in #2528, that are resulting in CORS errors being returned from the Clerk Frontend API.

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-05-06T16:08:08Z

🦋 Changeset detected

Latest commit: 9e6b63f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/clerk-expo	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

panteliselef · 2024-05-06T20:38:12Z

- // Send some non-identifying headers that are useful for logging
- (requestInit.headers as Headers).set('x-expo-execution-environment', Constants.executionEnvironment);
- (requestInit.headers as Headers).set(
- 'x-expo-native-application-version',
- Application.nativeApplicationVersion || 'NULL',
- );


@thiskevinwang If having this kind of information was useful, and don't wanna completely removed it, couldn't we just do this ?
if(!isValidBrowser()){// Send some non-identifying headers that are useful for logging(requestInit.headersasHeaders).set('x-expo-execution-environment',Constants.executionEnvironment);(requestInit.headersasHeaders).set('x-expo-native-application-version',Application.nativeApplicationVersion||'NULL',);}
of use import { Platform } from 'react-native';
if(Platform.OS!=='web'){// Send some non-identifying headers that are useful for logging(requestInit.headersasHeaders).set('x-expo-execution-environment',Constants.executionEnvironment);(requestInit.headersasHeaders).set('x-expo-native-application-version',Application.nativeApplicationVersion||'NULL',);}

@panteliselef Oh, smart thinking! But also...
If having this kind of information was useful
...Turns out, it was not particularly useful so I'd say we just remove this!

- this reverts #2528

panteliselef

lgtm

anagstef · 2024-05-09T13:36:38Z

+Remove headers that were added in #2528
+
+Remove `expo-application` & `expo-constants` peer deps


@thiskevinwang Maybe we could make this a little bit easier to read, as it'll be included in the changelog which is facing the developers using our product. For example, let's mention what are the headers this change removes. :)

Updated in 05e82b4

dimkl · 2024-05-09T18:05:29Z

@thiskevinwang You should also remove those dependencies from the devDependencies.

Done in 05e82b4

thiskevinwang · 2024-05-06T16:08:05Z

Description

This removes two headers, added in #2528, that are resulting in CORS errors being returned from the Clerk Frontend API.

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-05-06T16:08:08Z

🦋 Changeset detected

Latest commit: 9e6b63f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/clerk-expo	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

panteliselef · 2024-05-06T20:38:12Z

- // Send some non-identifying headers that are useful for logging
- (requestInit.headers as Headers).set('x-expo-execution-environment', Constants.executionEnvironment);
- (requestInit.headers as Headers).set(
- 'x-expo-native-application-version',
- Application.nativeApplicationVersion || 'NULL',
- );


@thiskevinwang If having this kind of information was useful, and don't wanna completely removed it, couldn't we just do this ?
if(!isValidBrowser()){// Send some non-identifying headers that are useful for logging(requestInit.headersasHeaders).set('x-expo-execution-environment',Constants.executionEnvironment);(requestInit.headersasHeaders).set('x-expo-native-application-version',Application.nativeApplicationVersion||'NULL',);}
of use import { Platform } from 'react-native';
if(Platform.OS!=='web'){// Send some non-identifying headers that are useful for logging(requestInit.headersasHeaders).set('x-expo-execution-environment',Constants.executionEnvironment);(requestInit.headersasHeaders).set('x-expo-native-application-version',Application.nativeApplicationVersion||'NULL',);}

@panteliselef Oh, smart thinking! But also...
If having this kind of information was useful
...Turns out, it was not particularly useful so I'd say we just remove this!

- this reverts #2528

panteliselef

lgtm

anagstef · 2024-05-09T13:36:38Z

+Remove headers that were added in #2528
+
+Remove `expo-application` & `expo-constants` peer deps


@thiskevinwang Maybe we could make this a little bit easier to read, as it'll be included in the changelog which is facing the developers using our product. For example, let's mention what are the headers this change removes. :)

Updated in 05e82b4

dimkl · 2024-05-09T18:05:29Z

@thiskevinwang You should also remove those dependencies from the devDependencies.

Done in 05e82b4

thiskevinwang · 2024-05-06T16:08:05Z

Description

This removes two headers, added in #2528, that are resulting in CORS errors being returned from the Clerk Frontend API.

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-05-06T16:08:08Z

🦋 Changeset detected

Latest commit: 9e6b63f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/clerk-expo	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

panteliselef · 2024-05-06T20:38:12Z

- // Send some non-identifying headers that are useful for logging
- (requestInit.headers as Headers).set('x-expo-execution-environment', Constants.executionEnvironment);
- (requestInit.headers as Headers).set(
- 'x-expo-native-application-version',
- Application.nativeApplicationVersion || 'NULL',
- );


@thiskevinwang If having this kind of information was useful, and don't wanna completely removed it, couldn't we just do this ?
if(!isValidBrowser()){// Send some non-identifying headers that are useful for logging(requestInit.headersasHeaders).set('x-expo-execution-environment',Constants.executionEnvironment);(requestInit.headersasHeaders).set('x-expo-native-application-version',Application.nativeApplicationVersion||'NULL',);}
of use import { Platform } from 'react-native';
if(Platform.OS!=='web'){// Send some non-identifying headers that are useful for logging(requestInit.headersasHeaders).set('x-expo-execution-environment',Constants.executionEnvironment);(requestInit.headersasHeaders).set('x-expo-native-application-version',Application.nativeApplicationVersion||'NULL',);}

@panteliselef Oh, smart thinking! But also...
If having this kind of information was useful
...Turns out, it was not particularly useful so I'd say we just remove this!

- this reverts #2528

panteliselef

lgtm

anagstef · 2024-05-09T13:36:38Z

+Remove headers that were added in #2528
+
+Remove `expo-application` & `expo-constants` peer deps


@thiskevinwang Maybe we could make this a little bit easier to read, as it'll be included in the changelog which is facing the developers using our product. For example, let's mention what are the headers this change removes. :)

Updated in 05e82b4

dimkl · 2024-05-09T18:05:29Z

@thiskevinwang You should also remove those dependencies from the devDependencies.

Done in 05e82b4

thiskevinwang · 2024-05-06T16:08:05Z

Description

This removes two headers, added in #2528, that are resulting in CORS errors being returned from the Clerk Frontend API.

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-05-06T16:08:08Z

🦋 Changeset detected

Latest commit: 9e6b63f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/clerk-expo	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

panteliselef · 2024-05-06T20:38:12Z

- // Send some non-identifying headers that are useful for logging
- (requestInit.headers as Headers).set('x-expo-execution-environment', Constants.executionEnvironment);
- (requestInit.headers as Headers).set(
- 'x-expo-native-application-version',
- Application.nativeApplicationVersion || 'NULL',
- );


@thiskevinwang If having this kind of information was useful, and don't wanna completely removed it, couldn't we just do this ?
if(!isValidBrowser()){// Send some non-identifying headers that are useful for logging(requestInit.headersasHeaders).set('x-expo-execution-environment',Constants.executionEnvironment);(requestInit.headersasHeaders).set('x-expo-native-application-version',Application.nativeApplicationVersion||'NULL',);}
of use import { Platform } from 'react-native';
if(Platform.OS!=='web'){// Send some non-identifying headers that are useful for logging(requestInit.headersasHeaders).set('x-expo-execution-environment',Constants.executionEnvironment);(requestInit.headersasHeaders).set('x-expo-native-application-version',Application.nativeApplicationVersion||'NULL',);}

@panteliselef Oh, smart thinking! But also...
If having this kind of information was useful
...Turns out, it was not particularly useful so I'd say we just remove this!

- this reverts #2528

panteliselef

lgtm

anagstef · 2024-05-09T13:36:38Z

+Remove headers that were added in #2528
+
+Remove `expo-application` & `expo-constants` peer deps


@thiskevinwang Maybe we could make this a little bit easier to read, as it'll be included in the changelog which is facing the developers using our product. For example, let's mention what are the headers this change removes. :)

Updated in 05e82b4

dimkl · 2024-05-09T18:05:29Z

@thiskevinwang You should also remove those dependencies from the devDependencies.

Done in 05e82b4

thiskevinwang · 2024-05-06T16:08:05Z

Description

This removes two headers, added in #2528, that are resulting in CORS errors being returned from the Clerk Frontend API.

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-05-06T16:08:08Z

🦋 Changeset detected

Latest commit: 9e6b63f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/clerk-expo	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

panteliselef · 2024-05-06T20:38:12Z

- // Send some non-identifying headers that are useful for logging
- (requestInit.headers as Headers).set('x-expo-execution-environment', Constants.executionEnvironment);
- (requestInit.headers as Headers).set(
- 'x-expo-native-application-version',
- Application.nativeApplicationVersion || 'NULL',
- );


@thiskevinwang If having this kind of information was useful, and don't wanna completely removed it, couldn't we just do this ?
if(!isValidBrowser()){// Send some non-identifying headers that are useful for logging(requestInit.headersasHeaders).set('x-expo-execution-environment',Constants.executionEnvironment);(requestInit.headersasHeaders).set('x-expo-native-application-version',Application.nativeApplicationVersion||'NULL',);}
of use import { Platform } from 'react-native';
if(Platform.OS!=='web'){// Send some non-identifying headers that are useful for logging(requestInit.headersasHeaders).set('x-expo-execution-environment',Constants.executionEnvironment);(requestInit.headersasHeaders).set('x-expo-native-application-version',Application.nativeApplicationVersion||'NULL',);}

@panteliselef Oh, smart thinking! But also...
If having this kind of information was useful
...Turns out, it was not particularly useful so I'd say we just remove this!

- this reverts #2528

panteliselef

lgtm

anagstef · 2024-05-09T13:36:38Z

+Remove headers that were added in #2528
+
+Remove `expo-application` & `expo-constants` peer deps


@thiskevinwang Maybe we could make this a little bit easier to read, as it'll be included in the changelog which is facing the developers using our product. For example, let's mention what are the headers this change removes. :)

Updated in 05e82b4

dimkl · 2024-05-09T18:05:29Z

@thiskevinwang You should also remove those dependencies from the devDependencies.

Done in 05e82b4

thiskevinwang · 2024-05-06T16:08:05Z

Description

This removes two headers, added in #2528, that are resulting in CORS errors being returned from the Clerk Frontend API.

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-05-06T16:08:08Z

🦋 Changeset detected

Latest commit: 9e6b63f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/clerk-expo	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

panteliselef · 2024-05-06T20:38:12Z

- // Send some non-identifying headers that are useful for logging
- (requestInit.headers as Headers).set('x-expo-execution-environment', Constants.executionEnvironment);
- (requestInit.headers as Headers).set(
- 'x-expo-native-application-version',
- Application.nativeApplicationVersion || 'NULL',
- );


@thiskevinwang If having this kind of information was useful, and don't wanna completely removed it, couldn't we just do this ?
if(!isValidBrowser()){// Send some non-identifying headers that are useful for logging(requestInit.headersasHeaders).set('x-expo-execution-environment',Constants.executionEnvironment);(requestInit.headersasHeaders).set('x-expo-native-application-version',Application.nativeApplicationVersion||'NULL',);}
of use import { Platform } from 'react-native';
if(Platform.OS!=='web'){// Send some non-identifying headers that are useful for logging(requestInit.headersasHeaders).set('x-expo-execution-environment',Constants.executionEnvironment);(requestInit.headersasHeaders).set('x-expo-native-application-version',Application.nativeApplicationVersion||'NULL',);}

@panteliselef Oh, smart thinking! But also...
If having this kind of information was useful
...Turns out, it was not particularly useful so I'd say we just remove this!

- this reverts #2528

panteliselef

lgtm

anagstef · 2024-05-09T13:36:38Z

+Remove headers that were added in #2528
+
+Remove `expo-application` & `expo-constants` peer deps


@thiskevinwang Maybe we could make this a little bit easier to read, as it'll be included in the changelog which is facing the developers using our product. For example, let's mention what are the headers this change removes. :)

Updated in 05e82b4

dimkl · 2024-05-09T18:05:29Z

@thiskevinwang You should also remove those dependencies from the devDependencies.

Done in 05e82b4

thiskevinwang · 2024-05-06T16:08:05Z

Description

This removes two headers, added in #2528, that are resulting in CORS errors being returned from the Clerk Frontend API.

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-05-06T16:08:08Z

🦋 Changeset detected

Latest commit: 9e6b63f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/clerk-expo	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

panteliselef · 2024-05-06T20:38:12Z

- // Send some non-identifying headers that are useful for logging
- (requestInit.headers as Headers).set('x-expo-execution-environment', Constants.executionEnvironment);
- (requestInit.headers as Headers).set(
- 'x-expo-native-application-version',
- Application.nativeApplicationVersion || 'NULL',
- );


@thiskevinwang If having this kind of information was useful, and don't wanna completely removed it, couldn't we just do this ?
if(!isValidBrowser()){// Send some non-identifying headers that are useful for logging(requestInit.headersasHeaders).set('x-expo-execution-environment',Constants.executionEnvironment);(requestInit.headersasHeaders).set('x-expo-native-application-version',Application.nativeApplicationVersion||'NULL',);}
of use import { Platform } from 'react-native';
if(Platform.OS!=='web'){// Send some non-identifying headers that are useful for logging(requestInit.headersasHeaders).set('x-expo-execution-environment',Constants.executionEnvironment);(requestInit.headersasHeaders).set('x-expo-native-application-version',Application.nativeApplicationVersion||'NULL',);}

@panteliselef Oh, smart thinking! But also...
If having this kind of information was useful
...Turns out, it was not particularly useful so I'd say we just remove this!

- this reverts #2528

panteliselef

lgtm

anagstef · 2024-05-09T13:36:38Z

+Remove headers that were added in #2528
+
+Remove `expo-application` & `expo-constants` peer deps


@thiskevinwang Maybe we could make this a little bit easier to read, as it'll be included in the changelog which is facing the developers using our product. For example, let's mention what are the headers this change removes. :)

Updated in 05e82b4

dimkl · 2024-05-09T18:05:29Z

@thiskevinwang You should also remove those dependencies from the devDependencies.

Done in 05e82b4

clerk-cookie added the expo label May 6, 2024

thiskevinwang changed the title ~~feat(clerk-expo): Remove headers - this reverts #2528~~feat(clerk-expo): Remove headers causing CORS errorsMay 6, 2024

thiskevinwang marked this pull request as ready for review May 6, 2024 16:12

thiskevinwang mentioned this pull request May 6, 2024
getToken method returns null right after isSIgnedIn becomes true #2266
Closed
4 tasks

panteliselef reviewed May 6, 2024
View reviewed changes

thiskevinwang requested a review from panteliselef May 8, 2024 16:42

thiskevinwang added 2 commits May 8, 2024 12:42

feat(clerk-expo): Remove headers
30a4d42
- this reverts #2528

chore(clerk-expo): Changeset
e392c80

thiskevinwang force-pushed the kevin/remove-expo-headers branch from 75c227f to e392c80Compare May 8, 2024 16:42

panteliselef approved these changes May 9, 2024
View reviewed changes

anagstef reviewed May 9, 2024
View reviewed changes

anagstef approved these changes May 9, 2024
View reviewed changes

dimkl reviewed May 9, 2024
View reviewed changes

dimkl approved these changes May 9, 2024
View reviewed changes

chore(clerk-expo): Remove dev deps and update changset
05e82b4

thiskevinwang enabled auto-merge (squash) May 10, 2024 18:46

Merge branch 'main' into kevin/remove-expo-headers
9e6b63f

thiskevinwang merged commit d76723d into mainMay 10, 2024

thiskevinwang deleted the kevin/remove-expo-headers branch May 10, 2024 19:25

clerk-cookie mentioned this pull request May 10, 2024
Version Packages #3356
Merged

thiskevinwang mentioned this pull request May 10, 2024
React Native @clerk/clerk-expo is not working as expected #3339
Closed
4 tasks

clerk-cookie added the expo label May 6, 2024

thiskevinwang changed the title ~~feat(clerk-expo): Remove headers - this reverts #2528~~feat(clerk-expo): Remove headers causing CORS errorsMay 6, 2024

thiskevinwang marked this pull request as ready for review May 6, 2024 16:12

thiskevinwang mentioned this pull request May 6, 2024
getToken method returns null right after isSIgnedIn becomes true #2266
Closed
4 tasks

panteliselef reviewed May 6, 2024
View reviewed changes

thiskevinwang requested a review from panteliselef May 8, 2024 16:42

thiskevinwang added 2 commits May 8, 2024 12:42

feat(clerk-expo): Remove headers
30a4d42
- this reverts #2528

chore(clerk-expo): Changeset
e392c80

thiskevinwang force-pushed the kevin/remove-expo-headers branch from 75c227f to e392c80Compare May 8, 2024 16:42

panteliselef approved these changes May 9, 2024
View reviewed changes

anagstef reviewed May 9, 2024
View reviewed changes

anagstef approved these changes May 9, 2024
View reviewed changes

dimkl reviewed May 9, 2024
View reviewed changes

dimkl approved these changes May 9, 2024
View reviewed changes

chore(clerk-expo): Remove dev deps and update changset
05e82b4

thiskevinwang enabled auto-merge (squash) May 10, 2024 18:46

Merge branch 'main' into kevin/remove-expo-headers
9e6b63f

thiskevinwang merged commit d76723d into mainMay 10, 2024

thiskevinwang deleted the kevin/remove-expo-headers branch May 10, 2024 19:25

clerk-cookie mentioned this pull request May 10, 2024
Version Packages #3356
Merged

thiskevinwang mentioned this pull request May 10, 2024
React Native @clerk/clerk-expo is not working as expected #3339
Closed
4 tasks

clerk-cookie added the expo label May 6, 2024

thiskevinwang changed the title ~~feat(clerk-expo): Remove headers - this reverts #2528~~feat(clerk-expo): Remove headers causing CORS errorsMay 6, 2024

thiskevinwang marked this pull request as ready for review May 6, 2024 16:12

thiskevinwang mentioned this pull request May 6, 2024
getToken method returns null right after isSIgnedIn becomes true #2266
Closed
4 tasks

panteliselef reviewed May 6, 2024
View reviewed changes

thiskevinwang requested a review from panteliselef May 8, 2024 16:42

thiskevinwang added 2 commits May 8, 2024 12:42

feat(clerk-expo): Remove headers
30a4d42
- this reverts #2528

chore(clerk-expo): Changeset
e392c80

thiskevinwang force-pushed the kevin/remove-expo-headers branch from 75c227f to e392c80Compare May 8, 2024 16:42

panteliselef approved these changes May 9, 2024
View reviewed changes

anagstef reviewed May 9, 2024
View reviewed changes

anagstef approved these changes May 9, 2024
View reviewed changes

dimkl reviewed May 9, 2024
View reviewed changes

dimkl approved these changes May 9, 2024
View reviewed changes

chore(clerk-expo): Remove dev deps and update changset
05e82b4

thiskevinwang enabled auto-merge (squash) May 10, 2024 18:46

Merge branch 'main' into kevin/remove-expo-headers
9e6b63f

thiskevinwang merged commit d76723d into mainMay 10, 2024

thiskevinwang deleted the kevin/remove-expo-headers branch May 10, 2024 19:25

clerk-cookie mentioned this pull request May 10, 2024
Version Packages #3356
Merged

thiskevinwang mentioned this pull request May 10, 2024
React Native @clerk/clerk-expo is not working as expected #3339
Closed
4 tasks

clerk-cookie added the expo label May 6, 2024

thiskevinwang changed the title ~~feat(clerk-expo): Remove headers - this reverts #2528~~feat(clerk-expo): Remove headers causing CORS errorsMay 6, 2024

thiskevinwang marked this pull request as ready for review May 6, 2024 16:12

thiskevinwang mentioned this pull request May 6, 2024
getToken method returns null right after isSIgnedIn becomes true #2266
Closed
4 tasks

panteliselef reviewed May 6, 2024
View reviewed changes

thiskevinwang requested a review from panteliselef May 8, 2024 16:42

thiskevinwang added 2 commits May 8, 2024 12:42

feat(clerk-expo): Remove headers
30a4d42
- this reverts #2528

chore(clerk-expo): Changeset
e392c80

thiskevinwang force-pushed the kevin/remove-expo-headers branch from 75c227f to e392c80Compare May 8, 2024 16:42

panteliselef approved these changes May 9, 2024
View reviewed changes

anagstef reviewed May 9, 2024
View reviewed changes

anagstef approved these changes May 9, 2024
View reviewed changes

dimkl reviewed May 9, 2024
View reviewed changes

dimkl approved these changes May 9, 2024
View reviewed changes

chore(clerk-expo): Remove dev deps and update changset
05e82b4

thiskevinwang enabled auto-merge (squash) May 10, 2024 18:46

Merge branch 'main' into kevin/remove-expo-headers
9e6b63f

thiskevinwang merged commit d76723d into mainMay 10, 2024

thiskevinwang deleted the kevin/remove-expo-headers branch May 10, 2024 19:25

clerk-cookie mentioned this pull request May 10, 2024
Version Packages #3356
Merged

thiskevinwang mentioned this pull request May 10, 2024
React Native @clerk/clerk-expo is not working as expected #3339
Closed
4 tasks

clerk-cookie added the expo label May 6, 2024

thiskevinwang changed the title ~~feat(clerk-expo): Remove headers - this reverts #2528~~feat(clerk-expo): Remove headers causing CORS errorsMay 6, 2024

thiskevinwang marked this pull request as ready for review May 6, 2024 16:12

thiskevinwang mentioned this pull request May 6, 2024
getToken method returns null right after isSIgnedIn becomes true #2266
Closed
4 tasks

panteliselef reviewed May 6, 2024
View reviewed changes

thiskevinwang requested a review from panteliselef May 8, 2024 16:42

thiskevinwang added 2 commits May 8, 2024 12:42

feat(clerk-expo): Remove headers
30a4d42
- this reverts #2528

chore(clerk-expo): Changeset
e392c80

thiskevinwang force-pushed the kevin/remove-expo-headers branch from 75c227f to e392c80Compare May 8, 2024 16:42

panteliselef approved these changes May 9, 2024
View reviewed changes

anagstef reviewed May 9, 2024
View reviewed changes

anagstef approved these changes May 9, 2024
View reviewed changes

dimkl reviewed May 9, 2024
View reviewed changes

dimkl approved these changes May 9, 2024
View reviewed changes

chore(clerk-expo): Remove dev deps and update changset
05e82b4

thiskevinwang enabled auto-merge (squash) May 10, 2024 18:46

Merge branch 'main' into kevin/remove-expo-headers
9e6b63f

thiskevinwang merged commit d76723d into mainMay 10, 2024

thiskevinwang deleted the kevin/remove-expo-headers branch May 10, 2024 19:25

clerk-cookie mentioned this pull request May 10, 2024
Version Packages #3356
Merged

thiskevinwang mentioned this pull request May 10, 2024
React Native @clerk/clerk-expo is not working as expected #3339
Closed
4 tasks

clerk-cookie added the expo label May 6, 2024

thiskevinwang changed the title ~~feat(clerk-expo): Remove headers - this reverts #2528~~feat(clerk-expo): Remove headers causing CORS errorsMay 6, 2024

thiskevinwang marked this pull request as ready for review May 6, 2024 16:12

thiskevinwang mentioned this pull request May 6, 2024
getToken method returns null right after isSIgnedIn becomes true #2266
Closed
4 tasks

panteliselef reviewed May 6, 2024
View reviewed changes

thiskevinwang requested a review from panteliselef May 8, 2024 16:42

thiskevinwang added 2 commits May 8, 2024 12:42

feat(clerk-expo): Remove headers
30a4d42
- this reverts #2528

chore(clerk-expo): Changeset
e392c80

thiskevinwang force-pushed the kevin/remove-expo-headers branch from 75c227f to e392c80Compare May 8, 2024 16:42

panteliselef approved these changes May 9, 2024
View reviewed changes

anagstef reviewed May 9, 2024
View reviewed changes

anagstef approved these changes May 9, 2024
View reviewed changes

dimkl reviewed May 9, 2024
View reviewed changes

dimkl approved these changes May 9, 2024
View reviewed changes

chore(clerk-expo): Remove dev deps and update changset
05e82b4

thiskevinwang enabled auto-merge (squash) May 10, 2024 18:46

Merge branch 'main' into kevin/remove-expo-headers
9e6b63f

thiskevinwang merged commit d76723d into mainMay 10, 2024

thiskevinwang deleted the kevin/remove-expo-headers branch May 10, 2024 19:25

clerk-cookie mentioned this pull request May 10, 2024
Version Packages #3356
Merged

thiskevinwang mentioned this pull request May 10, 2024
React Native @clerk/clerk-expo is not working as expected #3339
Closed
4 tasks

clerk-cookie added the expo label May 6, 2024

thiskevinwang changed the title ~~feat(clerk-expo): Remove headers - this reverts #2528~~feat(clerk-expo): Remove headers causing CORS errorsMay 6, 2024

thiskevinwang marked this pull request as ready for review May 6, 2024 16:12

thiskevinwang mentioned this pull request May 6, 2024
getToken method returns null right after isSIgnedIn becomes true #2266
Closed
4 tasks

panteliselef reviewed May 6, 2024
View reviewed changes

thiskevinwang requested a review from panteliselef May 8, 2024 16:42

thiskevinwang added 2 commits May 8, 2024 12:42

feat(clerk-expo): Remove headers
30a4d42
- this reverts #2528

chore(clerk-expo): Changeset
e392c80

thiskevinwang force-pushed the kevin/remove-expo-headers branch from 75c227f to e392c80Compare May 8, 2024 16:42

panteliselef approved these changes May 9, 2024
View reviewed changes

anagstef reviewed May 9, 2024
View reviewed changes

anagstef approved these changes May 9, 2024
View reviewed changes

dimkl reviewed May 9, 2024
View reviewed changes

dimkl approved these changes May 9, 2024
View reviewed changes

chore(clerk-expo): Remove dev deps and update changset
05e82b4

thiskevinwang enabled auto-merge (squash) May 10, 2024 18:46

Merge branch 'main' into kevin/remove-expo-headers
9e6b63f

thiskevinwang merged commit d76723d into mainMay 10, 2024

thiskevinwang deleted the kevin/remove-expo-headers branch May 10, 2024 19:25

clerk-cookie mentioned this pull request May 10, 2024
Version Packages #3356
Merged

thiskevinwang mentioned this pull request May 10, 2024
React Native @clerk/clerk-expo is not working as expected #3339
Closed
4 tasks

clerk-cookie added the expo label May 6, 2024

thiskevinwang changed the title ~~feat(clerk-expo): Remove headers - this reverts #2528~~feat(clerk-expo): Remove headers causing CORS errorsMay 6, 2024

thiskevinwang marked this pull request as ready for review May 6, 2024 16:12

thiskevinwang mentioned this pull request May 6, 2024
getToken method returns null right after isSIgnedIn becomes true #2266
Closed
4 tasks

panteliselef reviewed May 6, 2024
View reviewed changes

thiskevinwang requested a review from panteliselef May 8, 2024 16:42

thiskevinwang added 2 commits May 8, 2024 12:42

feat(clerk-expo): Remove headers
30a4d42
- this reverts #2528

chore(clerk-expo): Changeset
e392c80

thiskevinwang force-pushed the kevin/remove-expo-headers branch from 75c227f to e392c80Compare May 8, 2024 16:42

panteliselef approved these changes May 9, 2024
View reviewed changes

anagstef reviewed May 9, 2024
View reviewed changes

anagstef approved these changes May 9, 2024
View reviewed changes

dimkl reviewed May 9, 2024
View reviewed changes

dimkl approved these changes May 9, 2024
View reviewed changes

chore(clerk-expo): Remove dev deps and update changset
05e82b4

thiskevinwang enabled auto-merge (squash) May 10, 2024 18:46

Merge branch 'main' into kevin/remove-expo-headers
9e6b63f

thiskevinwang merged commit d76723d into mainMay 10, 2024

thiskevinwang deleted the kevin/remove-expo-headers branch May 10, 2024 19:25

clerk-cookie mentioned this pull request May 10, 2024
Version Packages #3356
Merged

thiskevinwang mentioned this pull request May 10, 2024
React Native @clerk/clerk-expo is not working as expected #3339
Closed
4 tasks

		Remove headers that were added in #2528

		Remove `expo-application` & `expo-constants` peer deps

Uh oh!

Conversation

thiskevinwang commented May 6, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

changeset-botBot commented May 6, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

panteliselef left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

thiskevinwang commented May 6, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

changeset-botBot commented May 6, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

panteliselef left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

thiskevinwang commented May 6, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

changeset-botBot commented May 6, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

thiskevinwang commented May 6, 2024•
edited
Loading

changeset-botBot commented May 6, 2024•
edited
Loading

thiskevinwang commented May 6, 2024•
edited
Loading

changeset-botBot commented May 6, 2024•
edited
Loading

thiskevinwang commented May 6, 2024•
edited
Loading

changeset-botBot commented May 6, 2024•
edited
Loading

thiskevinwang commented May 6, 2024•
edited
Loading

changeset-botBot commented May 6, 2024•
edited
Loading