fix(clerk-js): Improve logging for CAPTCHA script loading errors by anagstef · Pull Request #3374 · clerk/javascript

anagstef · 2024-05-13T12:33:46Z

Description

This PR adds a console.error on every CAPTCHA error.

Also, when script loading fails, we log it in the FAPI, meaning that the /sign_ups API call will be executed and will include the following value:

captchaError: 'captcha_script_failed_to_load'

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-05-13T12:33:50Z

🦋 Changeset detected

Latest commit: e30bde7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dimkl · 2024-05-13T12:45:17Z

+ console.error('Clerk: Failed to load the CAPTCHA script from the URL: ', url);
+ throw {
+ captchaError: 'captcha_script_failed_to_load',
+ };


🙃 I would suggest we throw a ClerkError (an existing one or create a new one) instead of throwing an object. In order to provide a better error handling in the future i think that we will need to use our Error classes.

It's a bit complicated! We don't want everything to throw here. We actually send the captchaError error value to the FAPI.

dimkl · 2024-05-13T12:46:55Z

- } catch (_) {
+ } catch {
 // Rethrow with specific message
- clerkFailedToLoadThirdPartyScript('Cloudflare Turnstile');


🙃 Why did we drop the usage of clerkFailedToLoadThirdPartyScript ? Couldn't we enhance it with an optional url parameter?

As described above, the clerkFailedToLoadThirdPartyScript throws an Error object which is not what we want to do here.

agis · 2024-05-13T13:04:29Z

I think it's worth noting that, even more important that the console log that this PR achieves, is the request that we'll make to FAPI's signUp.create in case there's an error loading the script - this was not the case before this PR. I'm mentioning this for reviewers, because it might not be apparent how this is achieved by looking at the code changes.

…ose-more-information-on-turnstile

* fix(clerk-js): Improve logging for CAPTCHA script loading errors * fix(clerk-js): Remove the generic CAPTCHA console error (cherry picked from commit 34befee)

…lure logging (#3384) * fix(clerk-js): Improve logging for CAPTCHA script loading errors (#3374) * fix(clerk-js): Improve logging for CAPTCHA script loading errors * fix(clerk-js): Remove the generic CAPTCHA console error (cherry picked from commit 34befee) * fix(clerk-js): Use first-party cookies when running on Cypress (#3245) * fix(clerk-js): Use first-party cookies when running on Cypress * fix(clerk-js): Create isCypress util (cherry picked from commit 7b213d5)

anagstef · 2024-05-13T12:33:46Z

Description

This PR adds a console.error on every CAPTCHA error.

Also, when script loading fails, we log it in the FAPI, meaning that the /sign_ups API call will be executed and will include the following value:

captchaError: 'captcha_script_failed_to_load'

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-05-13T12:33:50Z

🦋 Changeset detected

Latest commit: e30bde7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dimkl · 2024-05-13T12:45:17Z

+ console.error('Clerk: Failed to load the CAPTCHA script from the URL: ', url);
+ throw {
+ captchaError: 'captcha_script_failed_to_load',
+ };


🙃 I would suggest we throw a ClerkError (an existing one or create a new one) instead of throwing an object. In order to provide a better error handling in the future i think that we will need to use our Error classes.

It's a bit complicated! We don't want everything to throw here. We actually send the captchaError error value to the FAPI.

dimkl · 2024-05-13T12:46:55Z

- } catch (_) {
+ } catch {
 // Rethrow with specific message
- clerkFailedToLoadThirdPartyScript('Cloudflare Turnstile');


🙃 Why did we drop the usage of clerkFailedToLoadThirdPartyScript ? Couldn't we enhance it with an optional url parameter?

As described above, the clerkFailedToLoadThirdPartyScript throws an Error object which is not what we want to do here.

agis · 2024-05-13T13:04:29Z

I think it's worth noting that, even more important that the console log that this PR achieves, is the request that we'll make to FAPI's signUp.create in case there's an error loading the script - this was not the case before this PR. I'm mentioning this for reviewers, because it might not be apparent how this is achieved by looking at the code changes.

…ose-more-information-on-turnstile

* fix(clerk-js): Improve logging for CAPTCHA script loading errors * fix(clerk-js): Remove the generic CAPTCHA console error (cherry picked from commit 34befee)

…lure logging (#3384) * fix(clerk-js): Improve logging for CAPTCHA script loading errors (#3374) * fix(clerk-js): Improve logging for CAPTCHA script loading errors * fix(clerk-js): Remove the generic CAPTCHA console error (cherry picked from commit 34befee) * fix(clerk-js): Use first-party cookies when running on Cypress (#3245) * fix(clerk-js): Use first-party cookies when running on Cypress * fix(clerk-js): Create isCypress util (cherry picked from commit 7b213d5)

anagstef · 2024-05-13T12:33:46Z

Description

This PR adds a console.error on every CAPTCHA error.

Also, when script loading fails, we log it in the FAPI, meaning that the /sign_ups API call will be executed and will include the following value:

captchaError: 'captcha_script_failed_to_load'

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-05-13T12:33:50Z

🦋 Changeset detected

Latest commit: e30bde7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dimkl · 2024-05-13T12:45:17Z

+ console.error('Clerk: Failed to load the CAPTCHA script from the URL: ', url);
+ throw {
+ captchaError: 'captcha_script_failed_to_load',
+ };


🙃 I would suggest we throw a ClerkError (an existing one or create a new one) instead of throwing an object. In order to provide a better error handling in the future i think that we will need to use our Error classes.

It's a bit complicated! We don't want everything to throw here. We actually send the captchaError error value to the FAPI.

dimkl · 2024-05-13T12:46:55Z

- } catch (_) {
+ } catch {
 // Rethrow with specific message
- clerkFailedToLoadThirdPartyScript('Cloudflare Turnstile');


🙃 Why did we drop the usage of clerkFailedToLoadThirdPartyScript ? Couldn't we enhance it with an optional url parameter?

As described above, the clerkFailedToLoadThirdPartyScript throws an Error object which is not what we want to do here.

agis · 2024-05-13T13:04:29Z

I think it's worth noting that, even more important that the console log that this PR achieves, is the request that we'll make to FAPI's signUp.create in case there's an error loading the script - this was not the case before this PR. I'm mentioning this for reviewers, because it might not be apparent how this is achieved by looking at the code changes.

…ose-more-information-on-turnstile

* fix(clerk-js): Improve logging for CAPTCHA script loading errors * fix(clerk-js): Remove the generic CAPTCHA console error (cherry picked from commit 34befee)

…lure logging (#3384) * fix(clerk-js): Improve logging for CAPTCHA script loading errors (#3374) * fix(clerk-js): Improve logging for CAPTCHA script loading errors * fix(clerk-js): Remove the generic CAPTCHA console error (cherry picked from commit 34befee) * fix(clerk-js): Use first-party cookies when running on Cypress (#3245) * fix(clerk-js): Use first-party cookies when running on Cypress * fix(clerk-js): Create isCypress util (cherry picked from commit 7b213d5)

anagstef · 2024-05-13T12:33:46Z

Description

This PR adds a console.error on every CAPTCHA error.

Also, when script loading fails, we log it in the FAPI, meaning that the /sign_ups API call will be executed and will include the following value:

captchaError: 'captcha_script_failed_to_load'

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-05-13T12:33:50Z

🦋 Changeset detected

Latest commit: e30bde7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dimkl · 2024-05-13T12:45:17Z

+ console.error('Clerk: Failed to load the CAPTCHA script from the URL: ', url);
+ throw {
+ captchaError: 'captcha_script_failed_to_load',
+ };


🙃 I would suggest we throw a ClerkError (an existing one or create a new one) instead of throwing an object. In order to provide a better error handling in the future i think that we will need to use our Error classes.

It's a bit complicated! We don't want everything to throw here. We actually send the captchaError error value to the FAPI.

dimkl · 2024-05-13T12:46:55Z

- } catch (_) {
+ } catch {
 // Rethrow with specific message
- clerkFailedToLoadThirdPartyScript('Cloudflare Turnstile');


🙃 Why did we drop the usage of clerkFailedToLoadThirdPartyScript ? Couldn't we enhance it with an optional url parameter?

As described above, the clerkFailedToLoadThirdPartyScript throws an Error object which is not what we want to do here.

agis · 2024-05-13T13:04:29Z

I think it's worth noting that, even more important that the console log that this PR achieves, is the request that we'll make to FAPI's signUp.create in case there's an error loading the script - this was not the case before this PR. I'm mentioning this for reviewers, because it might not be apparent how this is achieved by looking at the code changes.

…ose-more-information-on-turnstile

* fix(clerk-js): Improve logging for CAPTCHA script loading errors * fix(clerk-js): Remove the generic CAPTCHA console error (cherry picked from commit 34befee)

…lure logging (#3384) * fix(clerk-js): Improve logging for CAPTCHA script loading errors (#3374) * fix(clerk-js): Improve logging for CAPTCHA script loading errors * fix(clerk-js): Remove the generic CAPTCHA console error (cherry picked from commit 34befee) * fix(clerk-js): Use first-party cookies when running on Cypress (#3245) * fix(clerk-js): Use first-party cookies when running on Cypress * fix(clerk-js): Create isCypress util (cherry picked from commit 7b213d5)

anagstef · 2024-05-13T12:33:46Z

Description

This PR adds a console.error on every CAPTCHA error.

Also, when script loading fails, we log it in the FAPI, meaning that the /sign_ups API call will be executed and will include the following value:

captchaError: 'captcha_script_failed_to_load'

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-05-13T12:33:50Z

🦋 Changeset detected

Latest commit: e30bde7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dimkl · 2024-05-13T12:45:17Z

+ console.error('Clerk: Failed to load the CAPTCHA script from the URL: ', url);
+ throw {
+ captchaError: 'captcha_script_failed_to_load',
+ };


🙃 I would suggest we throw a ClerkError (an existing one or create a new one) instead of throwing an object. In order to provide a better error handling in the future i think that we will need to use our Error classes.

It's a bit complicated! We don't want everything to throw here. We actually send the captchaError error value to the FAPI.

dimkl · 2024-05-13T12:46:55Z

- } catch (_) {
+ } catch {
 // Rethrow with specific message
- clerkFailedToLoadThirdPartyScript('Cloudflare Turnstile');


🙃 Why did we drop the usage of clerkFailedToLoadThirdPartyScript ? Couldn't we enhance it with an optional url parameter?

As described above, the clerkFailedToLoadThirdPartyScript throws an Error object which is not what we want to do here.

agis · 2024-05-13T13:04:29Z

I think it's worth noting that, even more important that the console log that this PR achieves, is the request that we'll make to FAPI's signUp.create in case there's an error loading the script - this was not the case before this PR. I'm mentioning this for reviewers, because it might not be apparent how this is achieved by looking at the code changes.

…ose-more-information-on-turnstile

* fix(clerk-js): Improve logging for CAPTCHA script loading errors * fix(clerk-js): Remove the generic CAPTCHA console error (cherry picked from commit 34befee)

…lure logging (#3384) * fix(clerk-js): Improve logging for CAPTCHA script loading errors (#3374) * fix(clerk-js): Improve logging for CAPTCHA script loading errors * fix(clerk-js): Remove the generic CAPTCHA console error (cherry picked from commit 34befee) * fix(clerk-js): Use first-party cookies when running on Cypress (#3245) * fix(clerk-js): Use first-party cookies when running on Cypress * fix(clerk-js): Create isCypress util (cherry picked from commit 7b213d5)

anagstef · 2024-05-13T12:33:46Z

Description

This PR adds a console.error on every CAPTCHA error.

Also, when script loading fails, we log it in the FAPI, meaning that the /sign_ups API call will be executed and will include the following value:

captchaError: 'captcha_script_failed_to_load'

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-05-13T12:33:50Z

🦋 Changeset detected

Latest commit: e30bde7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dimkl · 2024-05-13T12:45:17Z

+ console.error('Clerk: Failed to load the CAPTCHA script from the URL: ', url);
+ throw {
+ captchaError: 'captcha_script_failed_to_load',
+ };


🙃 I would suggest we throw a ClerkError (an existing one or create a new one) instead of throwing an object. In order to provide a better error handling in the future i think that we will need to use our Error classes.

It's a bit complicated! We don't want everything to throw here. We actually send the captchaError error value to the FAPI.

dimkl · 2024-05-13T12:46:55Z

- } catch (_) {
+ } catch {
 // Rethrow with specific message
- clerkFailedToLoadThirdPartyScript('Cloudflare Turnstile');


🙃 Why did we drop the usage of clerkFailedToLoadThirdPartyScript ? Couldn't we enhance it with an optional url parameter?

As described above, the clerkFailedToLoadThirdPartyScript throws an Error object which is not what we want to do here.

agis · 2024-05-13T13:04:29Z

I think it's worth noting that, even more important that the console log that this PR achieves, is the request that we'll make to FAPI's signUp.create in case there's an error loading the script - this was not the case before this PR. I'm mentioning this for reviewers, because it might not be apparent how this is achieved by looking at the code changes.

…ose-more-information-on-turnstile

* fix(clerk-js): Improve logging for CAPTCHA script loading errors * fix(clerk-js): Remove the generic CAPTCHA console error (cherry picked from commit 34befee)

…lure logging (#3384) * fix(clerk-js): Improve logging for CAPTCHA script loading errors (#3374) * fix(clerk-js): Improve logging for CAPTCHA script loading errors * fix(clerk-js): Remove the generic CAPTCHA console error (cherry picked from commit 34befee) * fix(clerk-js): Use first-party cookies when running on Cypress (#3245) * fix(clerk-js): Use first-party cookies when running on Cypress * fix(clerk-js): Create isCypress util (cherry picked from commit 7b213d5)

anagstef · 2024-05-13T12:33:46Z

Description

This PR adds a console.error on every CAPTCHA error.

Also, when script loading fails, we log it in the FAPI, meaning that the /sign_ups API call will be executed and will include the following value:

captchaError: 'captcha_script_failed_to_load'

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-05-13T12:33:50Z

🦋 Changeset detected

Latest commit: e30bde7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dimkl · 2024-05-13T12:45:17Z

+ console.error('Clerk: Failed to load the CAPTCHA script from the URL: ', url);
+ throw {
+ captchaError: 'captcha_script_failed_to_load',
+ };


🙃 I would suggest we throw a ClerkError (an existing one or create a new one) instead of throwing an object. In order to provide a better error handling in the future i think that we will need to use our Error classes.

It's a bit complicated! We don't want everything to throw here. We actually send the captchaError error value to the FAPI.

dimkl · 2024-05-13T12:46:55Z

- } catch (_) {
+ } catch {
 // Rethrow with specific message
- clerkFailedToLoadThirdPartyScript('Cloudflare Turnstile');


🙃 Why did we drop the usage of clerkFailedToLoadThirdPartyScript ? Couldn't we enhance it with an optional url parameter?

As described above, the clerkFailedToLoadThirdPartyScript throws an Error object which is not what we want to do here.

agis · 2024-05-13T13:04:29Z

I think it's worth noting that, even more important that the console log that this PR achieves, is the request that we'll make to FAPI's signUp.create in case there's an error loading the script - this was not the case before this PR. I'm mentioning this for reviewers, because it might not be apparent how this is achieved by looking at the code changes.

…ose-more-information-on-turnstile

* fix(clerk-js): Improve logging for CAPTCHA script loading errors * fix(clerk-js): Remove the generic CAPTCHA console error (cherry picked from commit 34befee)

…lure logging (#3384) * fix(clerk-js): Improve logging for CAPTCHA script loading errors (#3374) * fix(clerk-js): Improve logging for CAPTCHA script loading errors * fix(clerk-js): Remove the generic CAPTCHA console error (cherry picked from commit 34befee) * fix(clerk-js): Use first-party cookies when running on Cypress (#3245) * fix(clerk-js): Use first-party cookies when running on Cypress * fix(clerk-js): Create isCypress util (cherry picked from commit 7b213d5)

anagstef · 2024-05-13T12:33:46Z

Description

This PR adds a console.error on every CAPTCHA error.

Also, when script loading fails, we log it in the FAPI, meaning that the /sign_ups API call will be executed and will include the following value:

captchaError: 'captcha_script_failed_to_load'

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-05-13T12:33:50Z

🦋 Changeset detected

Latest commit: e30bde7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dimkl · 2024-05-13T12:45:17Z

+ console.error('Clerk: Failed to load the CAPTCHA script from the URL: ', url);
+ throw {
+ captchaError: 'captcha_script_failed_to_load',
+ };


🙃 I would suggest we throw a ClerkError (an existing one or create a new one) instead of throwing an object. In order to provide a better error handling in the future i think that we will need to use our Error classes.

It's a bit complicated! We don't want everything to throw here. We actually send the captchaError error value to the FAPI.

dimkl · 2024-05-13T12:46:55Z

- } catch (_) {
+ } catch {
 // Rethrow with specific message
- clerkFailedToLoadThirdPartyScript('Cloudflare Turnstile');


🙃 Why did we drop the usage of clerkFailedToLoadThirdPartyScript ? Couldn't we enhance it with an optional url parameter?

As described above, the clerkFailedToLoadThirdPartyScript throws an Error object which is not what we want to do here.

agis · 2024-05-13T13:04:29Z

I think it's worth noting that, even more important that the console log that this PR achieves, is the request that we'll make to FAPI's signUp.create in case there's an error loading the script - this was not the case before this PR. I'm mentioning this for reviewers, because it might not be apparent how this is achieved by looking at the code changes.

…ose-more-information-on-turnstile

* fix(clerk-js): Improve logging for CAPTCHA script loading errors * fix(clerk-js): Remove the generic CAPTCHA console error (cherry picked from commit 34befee)

…lure logging (#3384) * fix(clerk-js): Improve logging for CAPTCHA script loading errors (#3374) * fix(clerk-js): Improve logging for CAPTCHA script loading errors * fix(clerk-js): Remove the generic CAPTCHA console error (cherry picked from commit 34befee) * fix(clerk-js): Use first-party cookies when running on Cypress (#3245) * fix(clerk-js): Use first-party cookies when running on Cypress * fix(clerk-js): Create isCypress util (cherry picked from commit 7b213d5)

fix(clerk-js): Improve logging for CAPTCHA script loading errors
b5f9811

anagstef requested review from agis, chanioxaris, dimkl, nikosdouvlis and panteliselef May 13, 2024 12:33

anagstef self-assigned this May 13, 2024

clerk-cookie added the clerk-js label May 13, 2024

dimkl reviewed May 13, 2024
View reviewed changes

panteliselef reviewed May 13, 2024
View reviewed changes

Comment threadpackages/clerk-js/src/core/resources/SignUp.ts Outdated

fix(clerk-js): Remove the generic CAPTCHA console error
3984bd9

panteliselef approved these changes May 13, 2024
View reviewed changes

Merge branch 'main' into stefanos/core-2247-investigate-if-we-can-exp…
e30bde7
…ose-more-information-on-turnstile

anagstef merged commit 34befee into mainMay 13, 2024

anagstef deleted the stefanos/core-2247-investigate-if-we-can-expose-more-information-on-turnstile branch May 13, 2024 17:34

clerk-cookie mentioned this pull request May 13, 2024
Version Packages #3370
Merged

anagstef mentioned this pull request May 15, 2024
[Core 1 Backport] Fix cookies on Cypress + Improve script loading failure logging #3384
Merged
9 tasks

fix(clerk-js): Improve logging for CAPTCHA script loading errors
b5f9811

anagstef requested review from agis, chanioxaris, dimkl, nikosdouvlis and panteliselef May 13, 2024 12:33

anagstef self-assigned this May 13, 2024

clerk-cookie added the clerk-js label May 13, 2024

dimkl reviewed May 13, 2024
View reviewed changes

panteliselef reviewed May 13, 2024
View reviewed changes

Comment threadpackages/clerk-js/src/core/resources/SignUp.ts Outdated

fix(clerk-js): Remove the generic CAPTCHA console error
3984bd9

panteliselef approved these changes May 13, 2024
View reviewed changes

Merge branch 'main' into stefanos/core-2247-investigate-if-we-can-exp…
e30bde7
…ose-more-information-on-turnstile

anagstef merged commit 34befee into mainMay 13, 2024

anagstef deleted the stefanos/core-2247-investigate-if-we-can-expose-more-information-on-turnstile branch May 13, 2024 17:34

clerk-cookie mentioned this pull request May 13, 2024
Version Packages #3370
Merged

anagstef mentioned this pull request May 15, 2024
[Core 1 Backport] Fix cookies on Cypress + Improve script loading failure logging #3384
Merged
9 tasks

fix(clerk-js): Improve logging for CAPTCHA script loading errors
b5f9811

anagstef requested review from agis, chanioxaris, dimkl, nikosdouvlis and panteliselef May 13, 2024 12:33

anagstef self-assigned this May 13, 2024

clerk-cookie added the clerk-js label May 13, 2024

dimkl reviewed May 13, 2024
View reviewed changes

panteliselef reviewed May 13, 2024
View reviewed changes

Comment threadpackages/clerk-js/src/core/resources/SignUp.ts Outdated

fix(clerk-js): Remove the generic CAPTCHA console error
3984bd9

panteliselef approved these changes May 13, 2024
View reviewed changes

Merge branch 'main' into stefanos/core-2247-investigate-if-we-can-exp…
e30bde7
…ose-more-information-on-turnstile

anagstef merged commit 34befee into mainMay 13, 2024

anagstef deleted the stefanos/core-2247-investigate-if-we-can-expose-more-information-on-turnstile branch May 13, 2024 17:34

clerk-cookie mentioned this pull request May 13, 2024
Version Packages #3370
Merged

anagstef mentioned this pull request May 15, 2024
[Core 1 Backport] Fix cookies on Cypress + Improve script loading failure logging #3384
Merged
9 tasks

fix(clerk-js): Improve logging for CAPTCHA script loading errors
b5f9811

anagstef requested review from agis, chanioxaris, dimkl, nikosdouvlis and panteliselef May 13, 2024 12:33

anagstef self-assigned this May 13, 2024

clerk-cookie added the clerk-js label May 13, 2024

dimkl reviewed May 13, 2024
View reviewed changes

panteliselef reviewed May 13, 2024
View reviewed changes

Comment threadpackages/clerk-js/src/core/resources/SignUp.ts Outdated

fix(clerk-js): Remove the generic CAPTCHA console error
3984bd9

panteliselef approved these changes May 13, 2024
View reviewed changes

Merge branch 'main' into stefanos/core-2247-investigate-if-we-can-exp…
e30bde7
…ose-more-information-on-turnstile

anagstef merged commit 34befee into mainMay 13, 2024

anagstef deleted the stefanos/core-2247-investigate-if-we-can-expose-more-information-on-turnstile branch May 13, 2024 17:34

clerk-cookie mentioned this pull request May 13, 2024
Version Packages #3370
Merged

anagstef mentioned this pull request May 15, 2024
[Core 1 Backport] Fix cookies on Cypress + Improve script loading failure logging #3384
Merged
9 tasks

fix(clerk-js): Improve logging for CAPTCHA script loading errors
b5f9811

anagstef requested review from agis, chanioxaris, dimkl, nikosdouvlis and panteliselef May 13, 2024 12:33

anagstef self-assigned this May 13, 2024

clerk-cookie added the clerk-js label May 13, 2024

dimkl reviewed May 13, 2024
View reviewed changes

panteliselef reviewed May 13, 2024
View reviewed changes

Comment threadpackages/clerk-js/src/core/resources/SignUp.ts Outdated

fix(clerk-js): Remove the generic CAPTCHA console error
3984bd9

panteliselef approved these changes May 13, 2024
View reviewed changes

Merge branch 'main' into stefanos/core-2247-investigate-if-we-can-exp…
e30bde7
…ose-more-information-on-turnstile

anagstef merged commit 34befee into mainMay 13, 2024

anagstef deleted the stefanos/core-2247-investigate-if-we-can-expose-more-information-on-turnstile branch May 13, 2024 17:34

clerk-cookie mentioned this pull request May 13, 2024
Version Packages #3370
Merged

anagstef mentioned this pull request May 15, 2024
[Core 1 Backport] Fix cookies on Cypress + Improve script loading failure logging #3384
Merged
9 tasks

fix(clerk-js): Improve logging for CAPTCHA script loading errors
b5f9811

anagstef requested review from agis, chanioxaris, dimkl, nikosdouvlis and panteliselef May 13, 2024 12:33

anagstef self-assigned this May 13, 2024

clerk-cookie added the clerk-js label May 13, 2024

dimkl reviewed May 13, 2024
View reviewed changes

panteliselef reviewed May 13, 2024
View reviewed changes

Comment threadpackages/clerk-js/src/core/resources/SignUp.ts Outdated

fix(clerk-js): Remove the generic CAPTCHA console error
3984bd9

panteliselef approved these changes May 13, 2024
View reviewed changes

Merge branch 'main' into stefanos/core-2247-investigate-if-we-can-exp…
e30bde7
…ose-more-information-on-turnstile

anagstef merged commit 34befee into mainMay 13, 2024

anagstef deleted the stefanos/core-2247-investigate-if-we-can-expose-more-information-on-turnstile branch May 13, 2024 17:34

clerk-cookie mentioned this pull request May 13, 2024
Version Packages #3370
Merged

anagstef mentioned this pull request May 15, 2024
[Core 1 Backport] Fix cookies on Cypress + Improve script loading failure logging #3384
Merged
9 tasks

fix(clerk-js): Improve logging for CAPTCHA script loading errors
b5f9811

anagstef requested review from agis, chanioxaris, dimkl, nikosdouvlis and panteliselef May 13, 2024 12:33

anagstef self-assigned this May 13, 2024

clerk-cookie added the clerk-js label May 13, 2024

dimkl reviewed May 13, 2024
View reviewed changes

panteliselef reviewed May 13, 2024
View reviewed changes

Comment threadpackages/clerk-js/src/core/resources/SignUp.ts Outdated

fix(clerk-js): Remove the generic CAPTCHA console error
3984bd9

panteliselef approved these changes May 13, 2024
View reviewed changes

Merge branch 'main' into stefanos/core-2247-investigate-if-we-can-exp…
e30bde7
…ose-more-information-on-turnstile

anagstef merged commit 34befee into mainMay 13, 2024

anagstef deleted the stefanos/core-2247-investigate-if-we-can-expose-more-information-on-turnstile branch May 13, 2024 17:34

clerk-cookie mentioned this pull request May 13, 2024
Version Packages #3370
Merged

anagstef mentioned this pull request May 15, 2024
[Core 1 Backport] Fix cookies on Cypress + Improve script loading failure logging #3384
Merged
9 tasks

fix(clerk-js): Improve logging for CAPTCHA script loading errors
b5f9811

anagstef requested review from agis, chanioxaris, dimkl, nikosdouvlis and panteliselef May 13, 2024 12:33

anagstef self-assigned this May 13, 2024

clerk-cookie added the clerk-js label May 13, 2024

dimkl reviewed May 13, 2024
View reviewed changes

panteliselef reviewed May 13, 2024
View reviewed changes

Comment threadpackages/clerk-js/src/core/resources/SignUp.ts Outdated

fix(clerk-js): Remove the generic CAPTCHA console error
3984bd9

panteliselef approved these changes May 13, 2024
View reviewed changes

Merge branch 'main' into stefanos/core-2247-investigate-if-we-can-exp…
e30bde7
…ose-more-information-on-turnstile

anagstef merged commit 34befee into mainMay 13, 2024

anagstef deleted the stefanos/core-2247-investigate-if-we-can-expose-more-information-on-turnstile branch May 13, 2024 17:34

clerk-cookie mentioned this pull request May 13, 2024
Version Packages #3370
Merged

anagstef mentioned this pull request May 15, 2024
[Core 1 Backport] Fix cookies on Cypress + Improve script loading failure logging #3384
Merged
9 tasks

Uh oh!

Conversation

anagstef commented May 13, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

changeset-botBot commented May 13, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

agis commented May 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

anagstef commented May 13, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

changeset-botBot commented May 13, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

agis commented May 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

anagstef commented May 13, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

changeset-botBot commented May 13, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anagstef commented May 13, 2024•
edited
Loading

changeset-botBot commented May 13, 2024•
edited
Loading

anagstef commented May 13, 2024•
edited
Loading

changeset-botBot commented May 13, 2024•
edited
Loading

anagstef commented May 13, 2024•
edited
Loading

changeset-botBot commented May 13, 2024•
edited
Loading

anagstef commented May 13, 2024•
edited
Loading

changeset-botBot commented May 13, 2024•
edited
Loading