Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/funny-berries-nail.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
---
'@clerk/nextjs': minor
'@clerk/clerk-react': minor
---

Add support for GoogleOneTap
### React component
- `<GoogleOneTap/>`

Customize the UX of the prompt

```tsx
<GoogleOneTap cancelOnTapOutside={false} itpSupport={false} fedCmSupport={false}/>
```
37 changes: 37 additions & 0 deletions .changeset/mighty-dolphins-look.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
---
'@clerk/clerk-js': minor
---

### Use the Google One Tap component from with Vanilla JS
- `Clerk.openGoogleOneTap({ cancelOnTapOutside: false, fedCmSupport: false, itpSupport: false })`
- `Clerk.closeGoogleOneTap()`
### Low level APIs for custom flows
- `await Clerk.authenticateWithGoogleOneTap({ token: 'xxxx'})`
- `await Clerk.handleGoogleOneTapCallback()`


We recommend using this two methods together in order and let Clerk perform the correct redirections.
```tsx
google.accounts.id.initialize({
callback: async response => {
const signInOrUp = await Clerk.authenticateWithGoogleOneTap({ token: response.credential})
await Clerk.handleGoogleOneTapCallback(signInOrUp, {
afterSignInUrl: window.location.href,
})
},
});
```

In case you want to handle the redirection and session management yourself you can do so like this
```tsx
google.accounts.id.initialize({
callback: async response => {
const signInOrUp = await Clerk.authenticateWithGoogleOneTap({ token: response.credential})
if(signInOrUp.status === 'complete') {
await Clerk.setActive({
session: signInOrUp.createdSessionId
})
}
},
});
```
5 changes: 5 additions & 0 deletions .changeset/shaggy-elephants-shop.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/chrome-extension': minor
---

Update export snapshot tests to include `GoogleOneTap`.
21 changes: 21 additions & 0 deletions .changeset/silly-mugs-type.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
---
'@clerk/types': minor
---

Added the following types
```tsx
interface Clerk {
...
openGoogleOneTap: (props?: GoogleOneTapProps) => void;
closeGoogleOneTap: () => void;
authenticateWithGoogleOneTap: (params: AuthenticateWithGoogleOneTapParams) => Promise<SignInResource | SignUpResource>;
handleGoogleOneTapCallback: (
signInOrUp: SignInResource | SignUpResource,
params: HandleOAuthCallbackParams,
customNavigate?: (to: string) => Promise<unknown>,
) => Promise<unknown>;
...
}

type GoogleOneTapStrategy = 'google_one_tap'
```
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,7 @@ exports[`public exports should not include a breaking change 1`] = `
"ClerkProvider",
"CreateOrganization",
"EmailLinkErrorCode",
"GoogleOneTap",
"MagicLinkErrorCode",
"MultisessionAppSupport",
"OrganizationList",
Expand All@@ -32,7 +33,6 @@ exports[`public exports should not include a breaking change 1`] = `
"WithClerk",
"WithSession",
"WithUser",
"__experimental_GoogleOneTap",
"__internal__setErrorThrowerOptions",
"isClerkAPIResponseError",
"isEmailLinkError",
Expand Down
144 changes: 112 additions & 32 deletions packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@ import {
handleValueOrFn,
inBrowser as inClientSide,
is4xxError,
isClerkAPIResponseError,
isHttpOrHttps,
isLegacyFrontendApiKey,
isValidBrowserOnline,
Expand All@@ -17,6 +18,7 @@ import {
} from '@clerk/shared';
import type {
ActiveSessionResource,
AuthenticateWithGoogleOneTapParams,
AuthenticateWithMetamaskParams,
BeforeEmitCallback,
Clerk as ClerkInterface,
Expand All@@ -28,12 +30,12 @@ import type {
DomainOrProxyUrl,
EnvironmentJSON,
EnvironmentResource,
GoogleOneTapProps,
HandleEmailLinkVerificationParams,
HandleMagicLinkVerificationParams,
HandleOAuthCallbackParams,
InstanceType,
ListenerCallback,
OneTapProps,
OrganizationInvitationResource,
OrganizationListProps,
OrganizationMembershipResource,
Expand DownExpand Up@@ -364,6 +366,18 @@ export default class Clerk implements ClerkInterface {
}
};

public openGoogleOneTap = (props?: GoogleOneTapProps): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls
.ensureMounted({ preloadHint: 'GoogleOneTap' })
.then(controls => controls.openModal('googleOneTap', props || {}));
};

public closeGoogleOneTap = (): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls.ensureMounted().then(controls => controls.closeModal('googleOneTap'));
};

public openSignIn = (props?: SignInProps): void => {
this.assertComponentsReady(this.#componentControls);
if (sessionExistsAndSingleSessionModeEnabled(this, this.#environment) && this.#instanceType === 'development') {
Expand DownExpand Up@@ -457,30 +471,6 @@ export default class Clerk implements ClerkInterface {
);
};

public __experimental_mountGoogleOneTap = (node: HTMLDivElement, props?: OneTapProps): void => {
this.assertComponentsReady(this.#componentControls);

void this.#componentControls.ensureMounted({ preloadHint: 'OneTap' }).then(controls =>
controls.mountComponent({
name: 'OneTap',
appearanceKey: 'oneTap',
node,
props,
}),
);
// TODO-ONETAP: Enable telemetry one feature is ready for public beta
// this.telemetry?.record(eventComponentMounted('GoogleOneTap', props));
};

public __experimental_unmountGoogleOneTap = (node: HTMLDivElement): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls.ensureMounted().then(controls =>
controls.unmountComponent({
node,
}),
);
};

public mountSignUp = (node: HTMLDivElement, props?: SignUpProps): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls.ensureMounted({ preloadHint: 'SignUp' }).then(controls =>
Expand DownExpand Up@@ -966,14 +956,47 @@ export default class Clerk implements ClerkInterface {
return null;
};

public handleRedirectCallback = async (
params: HandleOAuthCallbackParams = {},
public handleGoogleOneTapCallback = async (
signInOrUp: SignInResource | SignUpResource,
params: HandleOAuthCallbackParams,
customNavigate?: (to: string) => Promise<unknown>,
): Promise<unknown> => {
if (!this.#isReady || !this.#environment || !this.client) {
return;
}
const { signIn, signUp } = this.client;
const { signIn: _signIn, signUp: _signUp } = this.client;

const signIn = 'identifier' in (signInOrUp || {}) ? (signInOrUp as SignInResource) : _signIn;
const signUp = 'missingFields' in (signInOrUp || {}) ? (signInOrUp as SignUpResource) : _signUp;

const navigate = (to: string) =>
customNavigate && typeof customNavigate === 'function'
? customNavigate(this.buildUrlWithAuth(to))
: this.navigate(this.buildUrlWithAuth(to));

return this._handleRedirectCallback(params, {
signUp,
signIn,
navigate,
});
};

private _handleRedirectCallback = async (
params: HandleOAuthCallbackParams,
{
signIn,
signUp,
navigate,
}: {
signIn: SignInResource;
signUp: SignUpResource;
navigate: (to: string) => Promise<unknown>;
},
): Promise<unknown> => {
if (!this.loaded || !this.#environment || !this.client) {
return;
}

const { displayConfig } = this.#environment;
const { firstFactorVerification } = signIn;
const { externalAccount } = signUp.verifications;
Expand All@@ -983,18 +1006,17 @@ export default class Clerk implements ClerkInterface {
externalAccountStatus: externalAccount.status,
externalAccountErrorCode: externalAccount.error?.code,
externalAccountSessionId: externalAccount.error?.meta?.sessionId,
sessionId: signUp.createdSessionId,
};

const si = {
status: signIn.status,
firstFactorVerificationStatus: firstFactorVerification.status,
firstFactorVerificationErrorCode: firstFactorVerification.error?.code,
firstFactorVerificationSessionId: firstFactorVerification.error?.meta?.sessionId,
sessionId: signIn.createdSessionId,
};

const navigate = (to: string) =>
customNavigate && typeof customNavigate === 'function' ? customNavigate(to) : this.navigate(to);

const makeNavigate = (to: string) => () => navigate(to);

const navigateToSignIn = makeNavigate(displayConfig.signInUrl);
Expand DownExpand Up@@ -1026,7 +1048,13 @@ export default class Clerk implements ClerkInterface {

const navigateToContinueSignUp = makeNavigate(
params.continueSignUpUrl ||
buildURL({ base: displayConfig.signUpUrl, hashPath: '/continue' }, { stringify: true }),
buildURL(
{
base: displayConfig.signUpUrl,
hashPath: '/continue',
},
{ stringify: true },
),
);

const navigateToNextStepSignUp = ({ missingFields }: { missingFields: SignUpField[] }) => {
Expand All@@ -1046,6 +1074,13 @@ export default class Clerk implements ClerkInterface {
});
};

if (si.status === 'complete') {
return this.setActive({
session: si.sessionId,
beforeEmit: navigateAfterSignIn,
});
}

const userExistsButNeedsToSignIn =
su.externalAccountStatus === 'transferable' && su.externalAccountErrorCode === 'external_account_exists';

Expand DownExpand Up@@ -1108,6 +1143,13 @@ export default class Clerk implements ClerkInterface {
}
}

if (su.status === 'complete') {
return this.setActive({
session: su.sessionId,
beforeEmit: navigateAfterSignUp,
});
}

if (si.status === 'needs_second_factor') {
return navigateToFactorTwo();
}
Expand DownExpand Up@@ -1144,6 +1186,25 @@ export default class Clerk implements ClerkInterface {
return navigateToSignIn();
};

public handleRedirectCallback = async (
params: HandleOAuthCallbackParams = {},
customNavigate?: (to: string) => Promise<unknown>,
): Promise<unknown> => {
if (!this.loaded || !this.#environment || !this.client) {
return;
}
const { signIn, signUp } = this.client;

const navigate = (to: string) =>
customNavigate && typeof customNavigate === 'function' ? customNavigate(to) : this.navigate(to);

return this._handleRedirectCallback(params, {
signUp,
signIn,
navigate,
});
};

public handleUnauthenticated = async (opts = { broadcast: true }): Promise<unknown> => {
if (!this.client || !this.session) {
return;
Expand All@@ -1159,6 +1220,25 @@ export default class Clerk implements ClerkInterface {
return this.setActive({ session: null });
};

public authenticateWithGoogleOneTap = async (
params: AuthenticateWithGoogleOneTapParams,
): Promise<SignInResource | SignUpResource> => {
return this.client?.signIn
.create({
strategy: 'google_one_tap',
token: params.token,
})
.catch(err => {
if (isClerkAPIResponseError(err) && err.errors[0].code === 'external_account_not_found') {
return this.client?.signUp.create({

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panteliselef I think I've mentioned this before, but I'm double-checking that this signUp.create will trigger a Captcha functionality, and if the user has selected the "Smart" option it will try to find the clerk-captcha in the DOM. Thankfully, it won't break, because we fallback to "Invisible", but the fallback mechanism may change in the future, we should not depend on it.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

strategy: 'google_one_tap',
token: params.token,
});
}
throw err;
}) as Promise<SignInResource | SignUpResource>;
};

public authenticateWithMetamask = async ({
redirectUrl,
signUpContinueUrl,
Expand Down
25 changes: 1 addition & 24 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { deepSnakeToCamel, deprecated, isClerkAPIResponseError, Poller } from '@clerk/shared';
import { deepSnakeToCamel, deprecated, Poller } from '@clerk/shared';
import type {
__experimental_AuthenticateWithGoogleOneTapParams,
AttemptFirstFactorParams,
AttemptSecondFactorParams,
AuthenticateWithRedirectParams,
Expand All@@ -25,7 +24,6 @@ import type {
SignInStartEmailLinkFlowParams,
SignInStartMagicLinkFlowParams,
SignInStatus,
SignUpResource,
VerificationResource,
Web3SignatureConfig,
Web3SignatureFactor,
Expand DownExpand Up@@ -240,27 +238,6 @@ export class SignIn extends BaseResource implements SignInResource {
}
};

public __experimental_authenticateWithGoogleOneTap = async (
params: __experimental_AuthenticateWithGoogleOneTapParams,
): Promise<SignInResource | SignUpResource> => {
return this.create({
// TODO-ONETAP: Add new types when feature is ready for public beta
// @ts-expect-error
strategy: 'google_one_tap',
googleOneTapToken: params.token,
}).catch(err => {
if (isClerkAPIResponseError(err) && err.errors[0].code === 'external_account_not_found') {
return SignIn.clerk.client?.signUp.create({
// TODO-ONETAP: Add new types when feature is ready for public beta
// @ts-expect-error
strategy: 'google_one_tap',
googleOneTapToken: params.token,
});
}
throw err;
}) as Promise<SignInResource | SignUpResource>;
};

public authenticateWithWeb3 = async (params: AuthenticateWithWeb3Params): Promise<SignInResource> => {
const { identifier, generateSignature } = params || {};
if (!(typeof generateSignature === 'function')) {
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/funny-berries-nail.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
---
'@clerk/nextjs': minor
'@clerk/clerk-react': minor
---

Add support for GoogleOneTap
### React component
- `<GoogleOneTap/>`

Customize the UX of the prompt

```tsx
<GoogleOneTap cancelOnTapOutside={false} itpSupport={false} fedCmSupport={false}/>
```
37 changes: 37 additions & 0 deletions .changeset/mighty-dolphins-look.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
---
'@clerk/clerk-js': minor
---

### Use the Google One Tap component from with Vanilla JS
- `Clerk.openGoogleOneTap({ cancelOnTapOutside: false, fedCmSupport: false, itpSupport: false })`
- `Clerk.closeGoogleOneTap()`
### Low level APIs for custom flows
- `await Clerk.authenticateWithGoogleOneTap({ token: 'xxxx'})`
- `await Clerk.handleGoogleOneTapCallback()`


We recommend using this two methods together in order and let Clerk perform the correct redirections.
```tsx
google.accounts.id.initialize({
callback: async response => {
const signInOrUp = await Clerk.authenticateWithGoogleOneTap({ token: response.credential})
await Clerk.handleGoogleOneTapCallback(signInOrUp, {
afterSignInUrl: window.location.href,
})
},
});
```

In case you want to handle the redirection and session management yourself you can do so like this
```tsx
google.accounts.id.initialize({
callback: async response => {
const signInOrUp = await Clerk.authenticateWithGoogleOneTap({ token: response.credential})
if(signInOrUp.status === 'complete') {
await Clerk.setActive({
session: signInOrUp.createdSessionId
})
}
},
});
```
5 changes: 5 additions & 0 deletions .changeset/shaggy-elephants-shop.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/chrome-extension': minor
---

Update export snapshot tests to include `GoogleOneTap`.
21 changes: 21 additions & 0 deletions .changeset/silly-mugs-type.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
---
'@clerk/types': minor
---

Added the following types
```tsx
interface Clerk {
...
openGoogleOneTap: (props?: GoogleOneTapProps) => void;
closeGoogleOneTap: () => void;
authenticateWithGoogleOneTap: (params: AuthenticateWithGoogleOneTapParams) => Promise<SignInResource | SignUpResource>;
handleGoogleOneTapCallback: (
signInOrUp: SignInResource | SignUpResource,
params: HandleOAuthCallbackParams,
customNavigate?: (to: string) => Promise<unknown>,
) => Promise<unknown>;
...
}

type GoogleOneTapStrategy = 'google_one_tap'
```
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,7 @@ exports[`public exports should not include a breaking change 1`] = `
"ClerkProvider",
"CreateOrganization",
"EmailLinkErrorCode",
"GoogleOneTap",
"MagicLinkErrorCode",
"MultisessionAppSupport",
"OrganizationList",
Expand All@@ -32,7 +33,6 @@ exports[`public exports should not include a breaking change 1`] = `
"WithClerk",
"WithSession",
"WithUser",
"__experimental_GoogleOneTap",
"__internal__setErrorThrowerOptions",
"isClerkAPIResponseError",
"isEmailLinkError",
Expand Down
144 changes: 112 additions & 32 deletions packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@ import {
handleValueOrFn,
inBrowser as inClientSide,
is4xxError,
isClerkAPIResponseError,
isHttpOrHttps,
isLegacyFrontendApiKey,
isValidBrowserOnline,
Expand All@@ -17,6 +18,7 @@ import {
} from '@clerk/shared';
import type {
ActiveSessionResource,
AuthenticateWithGoogleOneTapParams,
AuthenticateWithMetamaskParams,
BeforeEmitCallback,
Clerk as ClerkInterface,
Expand All@@ -28,12 +30,12 @@ import type {
DomainOrProxyUrl,
EnvironmentJSON,
EnvironmentResource,
GoogleOneTapProps,
HandleEmailLinkVerificationParams,
HandleMagicLinkVerificationParams,
HandleOAuthCallbackParams,
InstanceType,
ListenerCallback,
OneTapProps,
OrganizationInvitationResource,
OrganizationListProps,
OrganizationMembershipResource,
Expand DownExpand Up@@ -364,6 +366,18 @@ export default class Clerk implements ClerkInterface {
}
};

public openGoogleOneTap = (props?: GoogleOneTapProps): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls
.ensureMounted({ preloadHint: 'GoogleOneTap' })
.then(controls => controls.openModal('googleOneTap', props || {}));
};

public closeGoogleOneTap = (): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls.ensureMounted().then(controls => controls.closeModal('googleOneTap'));
};

public openSignIn = (props?: SignInProps): void => {
this.assertComponentsReady(this.#componentControls);
if (sessionExistsAndSingleSessionModeEnabled(this, this.#environment) && this.#instanceType === 'development') {
Expand DownExpand Up@@ -457,30 +471,6 @@ export default class Clerk implements ClerkInterface {
);
};

public __experimental_mountGoogleOneTap = (node: HTMLDivElement, props?: OneTapProps): void => {
this.assertComponentsReady(this.#componentControls);

void this.#componentControls.ensureMounted({ preloadHint: 'OneTap' }).then(controls =>
controls.mountComponent({
name: 'OneTap',
appearanceKey: 'oneTap',
node,
props,
}),
);
// TODO-ONETAP: Enable telemetry one feature is ready for public beta
// this.telemetry?.record(eventComponentMounted('GoogleOneTap', props));
};

public __experimental_unmountGoogleOneTap = (node: HTMLDivElement): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls.ensureMounted().then(controls =>
controls.unmountComponent({
node,
}),
);
};

public mountSignUp = (node: HTMLDivElement, props?: SignUpProps): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls.ensureMounted({ preloadHint: 'SignUp' }).then(controls =>
Expand DownExpand Up@@ -966,14 +956,47 @@ export default class Clerk implements ClerkInterface {
return null;
};

public handleRedirectCallback = async (
params: HandleOAuthCallbackParams = {},
public handleGoogleOneTapCallback = async (
signInOrUp: SignInResource | SignUpResource,
params: HandleOAuthCallbackParams,
customNavigate?: (to: string) => Promise<unknown>,
): Promise<unknown> => {
if (!this.#isReady || !this.#environment || !this.client) {
return;
}
const { signIn, signUp } = this.client;
const { signIn: _signIn, signUp: _signUp } = this.client;

const signIn = 'identifier' in (signInOrUp || {}) ? (signInOrUp as SignInResource) : _signIn;
const signUp = 'missingFields' in (signInOrUp || {}) ? (signInOrUp as SignUpResource) : _signUp;

const navigate = (to: string) =>
customNavigate && typeof customNavigate === 'function'
? customNavigate(this.buildUrlWithAuth(to))
: this.navigate(this.buildUrlWithAuth(to));

return this._handleRedirectCallback(params, {
signUp,
signIn,
navigate,
});
};

private _handleRedirectCallback = async (
params: HandleOAuthCallbackParams,
{
signIn,
signUp,
navigate,
}: {
signIn: SignInResource;
signUp: SignUpResource;
navigate: (to: string) => Promise<unknown>;
},
): Promise<unknown> => {
if (!this.loaded || !this.#environment || !this.client) {
return;
}

const { displayConfig } = this.#environment;
const { firstFactorVerification } = signIn;
const { externalAccount } = signUp.verifications;
Expand All@@ -983,18 +1006,17 @@ export default class Clerk implements ClerkInterface {
externalAccountStatus: externalAccount.status,
externalAccountErrorCode: externalAccount.error?.code,
externalAccountSessionId: externalAccount.error?.meta?.sessionId,
sessionId: signUp.createdSessionId,
};

const si = {
status: signIn.status,
firstFactorVerificationStatus: firstFactorVerification.status,
firstFactorVerificationErrorCode: firstFactorVerification.error?.code,
firstFactorVerificationSessionId: firstFactorVerification.error?.meta?.sessionId,
sessionId: signIn.createdSessionId,
};

const navigate = (to: string) =>
customNavigate && typeof customNavigate === 'function' ? customNavigate(to) : this.navigate(to);

const makeNavigate = (to: string) => () => navigate(to);

const navigateToSignIn = makeNavigate(displayConfig.signInUrl);
Expand DownExpand Up@@ -1026,7 +1048,13 @@ export default class Clerk implements ClerkInterface {

const navigateToContinueSignUp = makeNavigate(
params.continueSignUpUrl ||
buildURL({ base: displayConfig.signUpUrl, hashPath: '/continue' }, { stringify: true }),
buildURL(
{
base: displayConfig.signUpUrl,
hashPath: '/continue',
},
{ stringify: true },
),
);

const navigateToNextStepSignUp = ({ missingFields }: { missingFields: SignUpField[] }) => {
Expand All@@ -1046,6 +1074,13 @@ export default class Clerk implements ClerkInterface {
});
};

if (si.status === 'complete') {
return this.setActive({
session: si.sessionId,
beforeEmit: navigateAfterSignIn,
});
}

const userExistsButNeedsToSignIn =
su.externalAccountStatus === 'transferable' && su.externalAccountErrorCode === 'external_account_exists';

Expand DownExpand Up@@ -1108,6 +1143,13 @@ export default class Clerk implements ClerkInterface {
}
}

if (su.status === 'complete') {
return this.setActive({
session: su.sessionId,
beforeEmit: navigateAfterSignUp,
});
}

if (si.status === 'needs_second_factor') {
return navigateToFactorTwo();
}
Expand DownExpand Up@@ -1144,6 +1186,25 @@ export default class Clerk implements ClerkInterface {
return navigateToSignIn();
};

public handleRedirectCallback = async (
params: HandleOAuthCallbackParams = {},
customNavigate?: (to: string) => Promise<unknown>,
): Promise<unknown> => {
if (!this.loaded || !this.#environment || !this.client) {
return;
}
const { signIn, signUp } = this.client;

const navigate = (to: string) =>
customNavigate && typeof customNavigate === 'function' ? customNavigate(to) : this.navigate(to);

return this._handleRedirectCallback(params, {
signUp,
signIn,
navigate,
});
};

public handleUnauthenticated = async (opts = { broadcast: true }): Promise<unknown> => {
if (!this.client || !this.session) {
return;
Expand All@@ -1159,6 +1220,25 @@ export default class Clerk implements ClerkInterface {
return this.setActive({ session: null });
};

public authenticateWithGoogleOneTap = async (
params: AuthenticateWithGoogleOneTapParams,
): Promise<SignInResource | SignUpResource> => {
return this.client?.signIn
.create({
strategy: 'google_one_tap',
token: params.token,
})
.catch(err => {
if (isClerkAPIResponseError(err) && err.errors[0].code === 'external_account_not_found') {
return this.client?.signUp.create({

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panteliselef I think I've mentioned this before, but I'm double-checking that this signUp.create will trigger a Captcha functionality, and if the user has selected the "Smart" option it will try to find the clerk-captcha in the DOM. Thankfully, it won't break, because we fallback to "Invisible", but the fallback mechanism may change in the future, we should not depend on it.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

strategy: 'google_one_tap',
token: params.token,
});
}
throw err;
}) as Promise<SignInResource | SignUpResource>;
};

public authenticateWithMetamask = async ({
redirectUrl,
signUpContinueUrl,
Expand Down
25 changes: 1 addition & 24 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { deepSnakeToCamel, deprecated, isClerkAPIResponseError, Poller } from '@clerk/shared';
import { deepSnakeToCamel, deprecated, Poller } from '@clerk/shared';
import type {
__experimental_AuthenticateWithGoogleOneTapParams,
AttemptFirstFactorParams,
AttemptSecondFactorParams,
AuthenticateWithRedirectParams,
Expand All@@ -25,7 +24,6 @@ import type {
SignInStartEmailLinkFlowParams,
SignInStartMagicLinkFlowParams,
SignInStatus,
SignUpResource,
VerificationResource,
Web3SignatureConfig,
Web3SignatureFactor,
Expand DownExpand Up@@ -240,27 +238,6 @@ export class SignIn extends BaseResource implements SignInResource {
}
};

public __experimental_authenticateWithGoogleOneTap = async (
params: __experimental_AuthenticateWithGoogleOneTapParams,
): Promise<SignInResource | SignUpResource> => {
return this.create({
// TODO-ONETAP: Add new types when feature is ready for public beta
// @ts-expect-error
strategy: 'google_one_tap',
googleOneTapToken: params.token,
}).catch(err => {
if (isClerkAPIResponseError(err) && err.errors[0].code === 'external_account_not_found') {
return SignIn.clerk.client?.signUp.create({
// TODO-ONETAP: Add new types when feature is ready for public beta
// @ts-expect-error
strategy: 'google_one_tap',
googleOneTapToken: params.token,
});
}
throw err;
}) as Promise<SignInResource | SignUpResource>;
};

public authenticateWithWeb3 = async (params: AuthenticateWithWeb3Params): Promise<SignInResource> => {
const { identifier, generateSignature } = params || {};
if (!(typeof generateSignature === 'function')) {
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/funny-berries-nail.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
---
'@clerk/nextjs': minor
'@clerk/clerk-react': minor
---

Add support for GoogleOneTap
### React component
- `<GoogleOneTap/>`

Customize the UX of the prompt

```tsx
<GoogleOneTap cancelOnTapOutside={false} itpSupport={false} fedCmSupport={false}/>
```
37 changes: 37 additions & 0 deletions .changeset/mighty-dolphins-look.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
---
'@clerk/clerk-js': minor
---

### Use the Google One Tap component from with Vanilla JS
- `Clerk.openGoogleOneTap({ cancelOnTapOutside: false, fedCmSupport: false, itpSupport: false })`
- `Clerk.closeGoogleOneTap()`
### Low level APIs for custom flows
- `await Clerk.authenticateWithGoogleOneTap({ token: 'xxxx'})`
- `await Clerk.handleGoogleOneTapCallback()`


We recommend using this two methods together in order and let Clerk perform the correct redirections.
```tsx
google.accounts.id.initialize({
callback: async response => {
const signInOrUp = await Clerk.authenticateWithGoogleOneTap({ token: response.credential})
await Clerk.handleGoogleOneTapCallback(signInOrUp, {
afterSignInUrl: window.location.href,
})
},
});
```

In case you want to handle the redirection and session management yourself you can do so like this
```tsx
google.accounts.id.initialize({
callback: async response => {
const signInOrUp = await Clerk.authenticateWithGoogleOneTap({ token: response.credential})
if(signInOrUp.status === 'complete') {
await Clerk.setActive({
session: signInOrUp.createdSessionId
})
}
},
});
```
5 changes: 5 additions & 0 deletions .changeset/shaggy-elephants-shop.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/chrome-extension': minor
---

Update export snapshot tests to include `GoogleOneTap`.
21 changes: 21 additions & 0 deletions .changeset/silly-mugs-type.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
---
'@clerk/types': minor
---

Added the following types
```tsx
interface Clerk {
...
openGoogleOneTap: (props?: GoogleOneTapProps) => void;
closeGoogleOneTap: () => void;
authenticateWithGoogleOneTap: (params: AuthenticateWithGoogleOneTapParams) => Promise<SignInResource | SignUpResource>;
handleGoogleOneTapCallback: (
signInOrUp: SignInResource | SignUpResource,
params: HandleOAuthCallbackParams,
customNavigate?: (to: string) => Promise<unknown>,
) => Promise<unknown>;
...
}

type GoogleOneTapStrategy = 'google_one_tap'
```
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,7 @@ exports[`public exports should not include a breaking change 1`] = `
"ClerkProvider",
"CreateOrganization",
"EmailLinkErrorCode",
"GoogleOneTap",
"MagicLinkErrorCode",
"MultisessionAppSupport",
"OrganizationList",
Expand All@@ -32,7 +33,6 @@ exports[`public exports should not include a breaking change 1`] = `
"WithClerk",
"WithSession",
"WithUser",
"__experimental_GoogleOneTap",
"__internal__setErrorThrowerOptions",
"isClerkAPIResponseError",
"isEmailLinkError",
Expand Down
144 changes: 112 additions & 32 deletions packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@ import {
handleValueOrFn,
inBrowser as inClientSide,
is4xxError,
isClerkAPIResponseError,
isHttpOrHttps,
isLegacyFrontendApiKey,
isValidBrowserOnline,
Expand All@@ -17,6 +18,7 @@ import {
} from '@clerk/shared';
import type {
ActiveSessionResource,
AuthenticateWithGoogleOneTapParams,
AuthenticateWithMetamaskParams,
BeforeEmitCallback,
Clerk as ClerkInterface,
Expand All@@ -28,12 +30,12 @@ import type {
DomainOrProxyUrl,
EnvironmentJSON,
EnvironmentResource,
GoogleOneTapProps,
HandleEmailLinkVerificationParams,
HandleMagicLinkVerificationParams,
HandleOAuthCallbackParams,
InstanceType,
ListenerCallback,
OneTapProps,
OrganizationInvitationResource,
OrganizationListProps,
OrganizationMembershipResource,
Expand DownExpand Up@@ -364,6 +366,18 @@ export default class Clerk implements ClerkInterface {
}
};

public openGoogleOneTap = (props?: GoogleOneTapProps): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls
.ensureMounted({ preloadHint: 'GoogleOneTap' })
.then(controls => controls.openModal('googleOneTap', props || {}));
};

public closeGoogleOneTap = (): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls.ensureMounted().then(controls => controls.closeModal('googleOneTap'));
};

public openSignIn = (props?: SignInProps): void => {
this.assertComponentsReady(this.#componentControls);
if (sessionExistsAndSingleSessionModeEnabled(this, this.#environment) && this.#instanceType === 'development') {
Expand DownExpand Up@@ -457,30 +471,6 @@ export default class Clerk implements ClerkInterface {
);
};

public __experimental_mountGoogleOneTap = (node: HTMLDivElement, props?: OneTapProps): void => {
this.assertComponentsReady(this.#componentControls);

void this.#componentControls.ensureMounted({ preloadHint: 'OneTap' }).then(controls =>
controls.mountComponent({
name: 'OneTap',
appearanceKey: 'oneTap',
node,
props,
}),
);
// TODO-ONETAP: Enable telemetry one feature is ready for public beta
// this.telemetry?.record(eventComponentMounted('GoogleOneTap', props));
};

public __experimental_unmountGoogleOneTap = (node: HTMLDivElement): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls.ensureMounted().then(controls =>
controls.unmountComponent({
node,
}),
);
};

public mountSignUp = (node: HTMLDivElement, props?: SignUpProps): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls.ensureMounted({ preloadHint: 'SignUp' }).then(controls =>
Expand DownExpand Up@@ -966,14 +956,47 @@ export default class Clerk implements ClerkInterface {
return null;
};

public handleRedirectCallback = async (
params: HandleOAuthCallbackParams = {},
public handleGoogleOneTapCallback = async (
signInOrUp: SignInResource | SignUpResource,
params: HandleOAuthCallbackParams,
customNavigate?: (to: string) => Promise<unknown>,
): Promise<unknown> => {
if (!this.#isReady || !this.#environment || !this.client) {
return;
}
const { signIn, signUp } = this.client;
const { signIn: _signIn, signUp: _signUp } = this.client;

const signIn = 'identifier' in (signInOrUp || {}) ? (signInOrUp as SignInResource) : _signIn;
const signUp = 'missingFields' in (signInOrUp || {}) ? (signInOrUp as SignUpResource) : _signUp;

const navigate = (to: string) =>
customNavigate && typeof customNavigate === 'function'
? customNavigate(this.buildUrlWithAuth(to))
: this.navigate(this.buildUrlWithAuth(to));

return this._handleRedirectCallback(params, {
signUp,
signIn,
navigate,
});
};

private _handleRedirectCallback = async (
params: HandleOAuthCallbackParams,
{
signIn,
signUp,
navigate,
}: {
signIn: SignInResource;
signUp: SignUpResource;
navigate: (to: string) => Promise<unknown>;
},
): Promise<unknown> => {
if (!this.loaded || !this.#environment || !this.client) {
return;
}

const { displayConfig } = this.#environment;
const { firstFactorVerification } = signIn;
const { externalAccount } = signUp.verifications;
Expand All@@ -983,18 +1006,17 @@ export default class Clerk implements ClerkInterface {
externalAccountStatus: externalAccount.status,
externalAccountErrorCode: externalAccount.error?.code,
externalAccountSessionId: externalAccount.error?.meta?.sessionId,
sessionId: signUp.createdSessionId,
};

const si = {
status: signIn.status,
firstFactorVerificationStatus: firstFactorVerification.status,
firstFactorVerificationErrorCode: firstFactorVerification.error?.code,
firstFactorVerificationSessionId: firstFactorVerification.error?.meta?.sessionId,
sessionId: signIn.createdSessionId,
};

const navigate = (to: string) =>
customNavigate && typeof customNavigate === 'function' ? customNavigate(to) : this.navigate(to);

const makeNavigate = (to: string) => () => navigate(to);

const navigateToSignIn = makeNavigate(displayConfig.signInUrl);
Expand DownExpand Up@@ -1026,7 +1048,13 @@ export default class Clerk implements ClerkInterface {

const navigateToContinueSignUp = makeNavigate(
params.continueSignUpUrl ||
buildURL({ base: displayConfig.signUpUrl, hashPath: '/continue' }, { stringify: true }),
buildURL(
{
base: displayConfig.signUpUrl,
hashPath: '/continue',
},
{ stringify: true },
),
);

const navigateToNextStepSignUp = ({ missingFields }: { missingFields: SignUpField[] }) => {
Expand All@@ -1046,6 +1074,13 @@ export default class Clerk implements ClerkInterface {
});
};

if (si.status === 'complete') {
return this.setActive({
session: si.sessionId,
beforeEmit: navigateAfterSignIn,
});
}

const userExistsButNeedsToSignIn =
su.externalAccountStatus === 'transferable' && su.externalAccountErrorCode === 'external_account_exists';

Expand DownExpand Up@@ -1108,6 +1143,13 @@ export default class Clerk implements ClerkInterface {
}
}

if (su.status === 'complete') {
return this.setActive({
session: su.sessionId,
beforeEmit: navigateAfterSignUp,
});
}

if (si.status === 'needs_second_factor') {
return navigateToFactorTwo();
}
Expand DownExpand Up@@ -1144,6 +1186,25 @@ export default class Clerk implements ClerkInterface {
return navigateToSignIn();
};

public handleRedirectCallback = async (
params: HandleOAuthCallbackParams = {},
customNavigate?: (to: string) => Promise<unknown>,
): Promise<unknown> => {
if (!this.loaded || !this.#environment || !this.client) {
return;
}
const { signIn, signUp } = this.client;

const navigate = (to: string) =>
customNavigate && typeof customNavigate === 'function' ? customNavigate(to) : this.navigate(to);

return this._handleRedirectCallback(params, {
signUp,
signIn,
navigate,
});
};

public handleUnauthenticated = async (opts = { broadcast: true }): Promise<unknown> => {
if (!this.client || !this.session) {
return;
Expand All@@ -1159,6 +1220,25 @@ export default class Clerk implements ClerkInterface {
return this.setActive({ session: null });
};

public authenticateWithGoogleOneTap = async (
params: AuthenticateWithGoogleOneTapParams,
): Promise<SignInResource | SignUpResource> => {
return this.client?.signIn
.create({
strategy: 'google_one_tap',
token: params.token,
})
.catch(err => {
if (isClerkAPIResponseError(err) && err.errors[0].code === 'external_account_not_found') {
return this.client?.signUp.create({

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panteliselef I think I've mentioned this before, but I'm double-checking that this signUp.create will trigger a Captcha functionality, and if the user has selected the "Smart" option it will try to find the clerk-captcha in the DOM. Thankfully, it won't break, because we fallback to "Invisible", but the fallback mechanism may change in the future, we should not depend on it.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

strategy: 'google_one_tap',
token: params.token,
});
}
throw err;
}) as Promise<SignInResource | SignUpResource>;
};

public authenticateWithMetamask = async ({
redirectUrl,
signUpContinueUrl,
Expand Down
25 changes: 1 addition & 24 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { deepSnakeToCamel, deprecated, isClerkAPIResponseError, Poller } from '@clerk/shared';
import { deepSnakeToCamel, deprecated, Poller } from '@clerk/shared';
import type {
__experimental_AuthenticateWithGoogleOneTapParams,
AttemptFirstFactorParams,
AttemptSecondFactorParams,
AuthenticateWithRedirectParams,
Expand All@@ -25,7 +24,6 @@ import type {
SignInStartEmailLinkFlowParams,
SignInStartMagicLinkFlowParams,
SignInStatus,
SignUpResource,
VerificationResource,
Web3SignatureConfig,
Web3SignatureFactor,
Expand DownExpand Up@@ -240,27 +238,6 @@ export class SignIn extends BaseResource implements SignInResource {
}
};

public __experimental_authenticateWithGoogleOneTap = async (
params: __experimental_AuthenticateWithGoogleOneTapParams,
): Promise<SignInResource | SignUpResource> => {
return this.create({
// TODO-ONETAP: Add new types when feature is ready for public beta
// @ts-expect-error
strategy: 'google_one_tap',
googleOneTapToken: params.token,
}).catch(err => {
if (isClerkAPIResponseError(err) && err.errors[0].code === 'external_account_not_found') {
return SignIn.clerk.client?.signUp.create({
// TODO-ONETAP: Add new types when feature is ready for public beta
// @ts-expect-error
strategy: 'google_one_tap',
googleOneTapToken: params.token,
});
}
throw err;
}) as Promise<SignInResource | SignUpResource>;
};

public authenticateWithWeb3 = async (params: AuthenticateWithWeb3Params): Promise<SignInResource> => {
const { identifier, generateSignature } = params || {};
if (!(typeof generateSignature === 'function')) {
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/funny-berries-nail.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
---
'@clerk/nextjs': minor
'@clerk/clerk-react': minor
---

Add support for GoogleOneTap
### React component
- `<GoogleOneTap/>`

Customize the UX of the prompt

```tsx
<GoogleOneTap cancelOnTapOutside={false} itpSupport={false} fedCmSupport={false}/>
```
37 changes: 37 additions & 0 deletions .changeset/mighty-dolphins-look.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
---
'@clerk/clerk-js': minor
---

### Use the Google One Tap component from with Vanilla JS
- `Clerk.openGoogleOneTap({ cancelOnTapOutside: false, fedCmSupport: false, itpSupport: false })`
- `Clerk.closeGoogleOneTap()`
### Low level APIs for custom flows
- `await Clerk.authenticateWithGoogleOneTap({ token: 'xxxx'})`
- `await Clerk.handleGoogleOneTapCallback()`


We recommend using this two methods together in order and let Clerk perform the correct redirections.
```tsx
google.accounts.id.initialize({
callback: async response => {
const signInOrUp = await Clerk.authenticateWithGoogleOneTap({ token: response.credential})
await Clerk.handleGoogleOneTapCallback(signInOrUp, {
afterSignInUrl: window.location.href,
})
},
});
```

In case you want to handle the redirection and session management yourself you can do so like this
```tsx
google.accounts.id.initialize({
callback: async response => {
const signInOrUp = await Clerk.authenticateWithGoogleOneTap({ token: response.credential})
if(signInOrUp.status === 'complete') {
await Clerk.setActive({
session: signInOrUp.createdSessionId
})
}
},
});
```
5 changes: 5 additions & 0 deletions .changeset/shaggy-elephants-shop.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/chrome-extension': minor
---

Update export snapshot tests to include `GoogleOneTap`.
21 changes: 21 additions & 0 deletions .changeset/silly-mugs-type.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
---
'@clerk/types': minor
---

Added the following types
```tsx
interface Clerk {
...
openGoogleOneTap: (props?: GoogleOneTapProps) => void;
closeGoogleOneTap: () => void;
authenticateWithGoogleOneTap: (params: AuthenticateWithGoogleOneTapParams) => Promise<SignInResource | SignUpResource>;
handleGoogleOneTapCallback: (
signInOrUp: SignInResource | SignUpResource,
params: HandleOAuthCallbackParams,
customNavigate?: (to: string) => Promise<unknown>,
) => Promise<unknown>;
...
}

type GoogleOneTapStrategy = 'google_one_tap'
```
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,7 @@ exports[`public exports should not include a breaking change 1`] = `
"ClerkProvider",
"CreateOrganization",
"EmailLinkErrorCode",
"GoogleOneTap",
"MagicLinkErrorCode",
"MultisessionAppSupport",
"OrganizationList",
Expand All@@ -32,7 +33,6 @@ exports[`public exports should not include a breaking change 1`] = `
"WithClerk",
"WithSession",
"WithUser",
"__experimental_GoogleOneTap",
"__internal__setErrorThrowerOptions",
"isClerkAPIResponseError",
"isEmailLinkError",
Expand Down
144 changes: 112 additions & 32 deletions packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@ import {
handleValueOrFn,
inBrowser as inClientSide,
is4xxError,
isClerkAPIResponseError,
isHttpOrHttps,
isLegacyFrontendApiKey,
isValidBrowserOnline,
Expand All@@ -17,6 +18,7 @@ import {
} from '@clerk/shared';
import type {
ActiveSessionResource,
AuthenticateWithGoogleOneTapParams,
AuthenticateWithMetamaskParams,
BeforeEmitCallback,
Clerk as ClerkInterface,
Expand All@@ -28,12 +30,12 @@ import type {
DomainOrProxyUrl,
EnvironmentJSON,
EnvironmentResource,
GoogleOneTapProps,
HandleEmailLinkVerificationParams,
HandleMagicLinkVerificationParams,
HandleOAuthCallbackParams,
InstanceType,
ListenerCallback,
OneTapProps,
OrganizationInvitationResource,
OrganizationListProps,
OrganizationMembershipResource,
Expand DownExpand Up@@ -364,6 +366,18 @@ export default class Clerk implements ClerkInterface {
}
};

public openGoogleOneTap = (props?: GoogleOneTapProps): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls
.ensureMounted({ preloadHint: 'GoogleOneTap' })
.then(controls => controls.openModal('googleOneTap', props || {}));
};

public closeGoogleOneTap = (): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls.ensureMounted().then(controls => controls.closeModal('googleOneTap'));
};

public openSignIn = (props?: SignInProps): void => {
this.assertComponentsReady(this.#componentControls);
if (sessionExistsAndSingleSessionModeEnabled(this, this.#environment) && this.#instanceType === 'development') {
Expand DownExpand Up@@ -457,30 +471,6 @@ export default class Clerk implements ClerkInterface {
);
};

public __experimental_mountGoogleOneTap = (node: HTMLDivElement, props?: OneTapProps): void => {
this.assertComponentsReady(this.#componentControls);

void this.#componentControls.ensureMounted({ preloadHint: 'OneTap' }).then(controls =>
controls.mountComponent({
name: 'OneTap',
appearanceKey: 'oneTap',
node,
props,
}),
);
// TODO-ONETAP: Enable telemetry one feature is ready for public beta
// this.telemetry?.record(eventComponentMounted('GoogleOneTap', props));
};

public __experimental_unmountGoogleOneTap = (node: HTMLDivElement): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls.ensureMounted().then(controls =>
controls.unmountComponent({
node,
}),
);
};

public mountSignUp = (node: HTMLDivElement, props?: SignUpProps): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls.ensureMounted({ preloadHint: 'SignUp' }).then(controls =>
Expand DownExpand Up@@ -966,14 +956,47 @@ export default class Clerk implements ClerkInterface {
return null;
};

public handleRedirectCallback = async (
params: HandleOAuthCallbackParams = {},
public handleGoogleOneTapCallback = async (
signInOrUp: SignInResource | SignUpResource,
params: HandleOAuthCallbackParams,
customNavigate?: (to: string) => Promise<unknown>,
): Promise<unknown> => {
if (!this.#isReady || !this.#environment || !this.client) {
return;
}
const { signIn, signUp } = this.client;
const { signIn: _signIn, signUp: _signUp } = this.client;

const signIn = 'identifier' in (signInOrUp || {}) ? (signInOrUp as SignInResource) : _signIn;
const signUp = 'missingFields' in (signInOrUp || {}) ? (signInOrUp as SignUpResource) : _signUp;

const navigate = (to: string) =>
customNavigate && typeof customNavigate === 'function'
? customNavigate(this.buildUrlWithAuth(to))
: this.navigate(this.buildUrlWithAuth(to));

return this._handleRedirectCallback(params, {
signUp,
signIn,
navigate,
});
};

private _handleRedirectCallback = async (
params: HandleOAuthCallbackParams,
{
signIn,
signUp,
navigate,
}: {
signIn: SignInResource;
signUp: SignUpResource;
navigate: (to: string) => Promise<unknown>;
},
): Promise<unknown> => {
if (!this.loaded || !this.#environment || !this.client) {
return;
}

const { displayConfig } = this.#environment;
const { firstFactorVerification } = signIn;
const { externalAccount } = signUp.verifications;
Expand All@@ -983,18 +1006,17 @@ export default class Clerk implements ClerkInterface {
externalAccountStatus: externalAccount.status,
externalAccountErrorCode: externalAccount.error?.code,
externalAccountSessionId: externalAccount.error?.meta?.sessionId,
sessionId: signUp.createdSessionId,
};

const si = {
status: signIn.status,
firstFactorVerificationStatus: firstFactorVerification.status,
firstFactorVerificationErrorCode: firstFactorVerification.error?.code,
firstFactorVerificationSessionId: firstFactorVerification.error?.meta?.sessionId,
sessionId: signIn.createdSessionId,
};

const navigate = (to: string) =>
customNavigate && typeof customNavigate === 'function' ? customNavigate(to) : this.navigate(to);

const makeNavigate = (to: string) => () => navigate(to);

const navigateToSignIn = makeNavigate(displayConfig.signInUrl);
Expand DownExpand Up@@ -1026,7 +1048,13 @@ export default class Clerk implements ClerkInterface {

const navigateToContinueSignUp = makeNavigate(
params.continueSignUpUrl ||
buildURL({ base: displayConfig.signUpUrl, hashPath: '/continue' }, { stringify: true }),
buildURL(
{
base: displayConfig.signUpUrl,
hashPath: '/continue',
},
{ stringify: true },
),
);

const navigateToNextStepSignUp = ({ missingFields }: { missingFields: SignUpField[] }) => {
Expand All@@ -1046,6 +1074,13 @@ export default class Clerk implements ClerkInterface {
});
};

if (si.status === 'complete') {
return this.setActive({
session: si.sessionId,
beforeEmit: navigateAfterSignIn,
});
}

const userExistsButNeedsToSignIn =
su.externalAccountStatus === 'transferable' && su.externalAccountErrorCode === 'external_account_exists';

Expand DownExpand Up@@ -1108,6 +1143,13 @@ export default class Clerk implements ClerkInterface {
}
}

if (su.status === 'complete') {
return this.setActive({
session: su.sessionId,
beforeEmit: navigateAfterSignUp,
});
}

if (si.status === 'needs_second_factor') {
return navigateToFactorTwo();
}
Expand DownExpand Up@@ -1144,6 +1186,25 @@ export default class Clerk implements ClerkInterface {
return navigateToSignIn();
};

public handleRedirectCallback = async (
params: HandleOAuthCallbackParams = {},
customNavigate?: (to: string) => Promise<unknown>,
): Promise<unknown> => {
if (!this.loaded || !this.#environment || !this.client) {
return;
}
const { signIn, signUp } = this.client;

const navigate = (to: string) =>
customNavigate && typeof customNavigate === 'function' ? customNavigate(to) : this.navigate(to);

return this._handleRedirectCallback(params, {
signUp,
signIn,
navigate,
});
};

public handleUnauthenticated = async (opts = { broadcast: true }): Promise<unknown> => {
if (!this.client || !this.session) {
return;
Expand All@@ -1159,6 +1220,25 @@ export default class Clerk implements ClerkInterface {
return this.setActive({ session: null });
};

public authenticateWithGoogleOneTap = async (
params: AuthenticateWithGoogleOneTapParams,
): Promise<SignInResource | SignUpResource> => {
return this.client?.signIn
.create({
strategy: 'google_one_tap',
token: params.token,
})
.catch(err => {
if (isClerkAPIResponseError(err) && err.errors[0].code === 'external_account_not_found') {
return this.client?.signUp.create({

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panteliselef I think I've mentioned this before, but I'm double-checking that this signUp.create will trigger a Captcha functionality, and if the user has selected the "Smart" option it will try to find the clerk-captcha in the DOM. Thankfully, it won't break, because we fallback to "Invisible", but the fallback mechanism may change in the future, we should not depend on it.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

strategy: 'google_one_tap',
token: params.token,
});
}
throw err;
}) as Promise<SignInResource | SignUpResource>;
};

public authenticateWithMetamask = async ({
redirectUrl,
signUpContinueUrl,
Expand Down
25 changes: 1 addition & 24 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { deepSnakeToCamel, deprecated, isClerkAPIResponseError, Poller } from '@clerk/shared';
import { deepSnakeToCamel, deprecated, Poller } from '@clerk/shared';
import type {
__experimental_AuthenticateWithGoogleOneTapParams,
AttemptFirstFactorParams,
AttemptSecondFactorParams,
AuthenticateWithRedirectParams,
Expand All@@ -25,7 +24,6 @@ import type {
SignInStartEmailLinkFlowParams,
SignInStartMagicLinkFlowParams,
SignInStatus,
SignUpResource,
VerificationResource,
Web3SignatureConfig,
Web3SignatureFactor,
Expand DownExpand Up@@ -240,27 +238,6 @@ export class SignIn extends BaseResource implements SignInResource {
}
};

public __experimental_authenticateWithGoogleOneTap = async (
params: __experimental_AuthenticateWithGoogleOneTapParams,
): Promise<SignInResource | SignUpResource> => {
return this.create({
// TODO-ONETAP: Add new types when feature is ready for public beta
// @ts-expect-error
strategy: 'google_one_tap',
googleOneTapToken: params.token,
}).catch(err => {
if (isClerkAPIResponseError(err) && err.errors[0].code === 'external_account_not_found') {
return SignIn.clerk.client?.signUp.create({
// TODO-ONETAP: Add new types when feature is ready for public beta
// @ts-expect-error
strategy: 'google_one_tap',
googleOneTapToken: params.token,
});
}
throw err;
}) as Promise<SignInResource | SignUpResource>;
};

public authenticateWithWeb3 = async (params: AuthenticateWithWeb3Params): Promise<SignInResource> => {
const { identifier, generateSignature } = params || {};
if (!(typeof generateSignature === 'function')) {
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/funny-berries-nail.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
---
'@clerk/nextjs': minor
'@clerk/clerk-react': minor
---

Add support for GoogleOneTap
### React component
- `<GoogleOneTap/>`

Customize the UX of the prompt

```tsx
<GoogleOneTap cancelOnTapOutside={false} itpSupport={false} fedCmSupport={false}/>
```
37 changes: 37 additions & 0 deletions .changeset/mighty-dolphins-look.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
---
'@clerk/clerk-js': minor
---

### Use the Google One Tap component from with Vanilla JS
- `Clerk.openGoogleOneTap({ cancelOnTapOutside: false, fedCmSupport: false, itpSupport: false })`
- `Clerk.closeGoogleOneTap()`
### Low level APIs for custom flows
- `await Clerk.authenticateWithGoogleOneTap({ token: 'xxxx'})`
- `await Clerk.handleGoogleOneTapCallback()`


We recommend using this two methods together in order and let Clerk perform the correct redirections.
```tsx
google.accounts.id.initialize({
callback: async response => {
const signInOrUp = await Clerk.authenticateWithGoogleOneTap({ token: response.credential})
await Clerk.handleGoogleOneTapCallback(signInOrUp, {
afterSignInUrl: window.location.href,
})
},
});
```

In case you want to handle the redirection and session management yourself you can do so like this
```tsx
google.accounts.id.initialize({
callback: async response => {
const signInOrUp = await Clerk.authenticateWithGoogleOneTap({ token: response.credential})
if(signInOrUp.status === 'complete') {
await Clerk.setActive({
session: signInOrUp.createdSessionId
})
}
},
});
```
5 changes: 5 additions & 0 deletions .changeset/shaggy-elephants-shop.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/chrome-extension': minor
---

Update export snapshot tests to include `GoogleOneTap`.
21 changes: 21 additions & 0 deletions .changeset/silly-mugs-type.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
---
'@clerk/types': minor
---

Added the following types
```tsx
interface Clerk {
...
openGoogleOneTap: (props?: GoogleOneTapProps) => void;
closeGoogleOneTap: () => void;
authenticateWithGoogleOneTap: (params: AuthenticateWithGoogleOneTapParams) => Promise<SignInResource | SignUpResource>;
handleGoogleOneTapCallback: (
signInOrUp: SignInResource | SignUpResource,
params: HandleOAuthCallbackParams,
customNavigate?: (to: string) => Promise<unknown>,
) => Promise<unknown>;
...
}

type GoogleOneTapStrategy = 'google_one_tap'
```
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,7 @@ exports[`public exports should not include a breaking change 1`] = `
"ClerkProvider",
"CreateOrganization",
"EmailLinkErrorCode",
"GoogleOneTap",
"MagicLinkErrorCode",
"MultisessionAppSupport",
"OrganizationList",
Expand All@@ -32,7 +33,6 @@ exports[`public exports should not include a breaking change 1`] = `
"WithClerk",
"WithSession",
"WithUser",
"__experimental_GoogleOneTap",
"__internal__setErrorThrowerOptions",
"isClerkAPIResponseError",
"isEmailLinkError",
Expand Down
144 changes: 112 additions & 32 deletions packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@ import {
handleValueOrFn,
inBrowser as inClientSide,
is4xxError,
isClerkAPIResponseError,
isHttpOrHttps,
isLegacyFrontendApiKey,
isValidBrowserOnline,
Expand All@@ -17,6 +18,7 @@ import {
} from '@clerk/shared';
import type {
ActiveSessionResource,
AuthenticateWithGoogleOneTapParams,
AuthenticateWithMetamaskParams,
BeforeEmitCallback,
Clerk as ClerkInterface,
Expand All@@ -28,12 +30,12 @@ import type {
DomainOrProxyUrl,
EnvironmentJSON,
EnvironmentResource,
GoogleOneTapProps,
HandleEmailLinkVerificationParams,
HandleMagicLinkVerificationParams,
HandleOAuthCallbackParams,
InstanceType,
ListenerCallback,
OneTapProps,
OrganizationInvitationResource,
OrganizationListProps,
OrganizationMembershipResource,
Expand DownExpand Up@@ -364,6 +366,18 @@ export default class Clerk implements ClerkInterface {
}
};

public openGoogleOneTap = (props?: GoogleOneTapProps): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls
.ensureMounted({ preloadHint: 'GoogleOneTap' })
.then(controls => controls.openModal('googleOneTap', props || {}));
};

public closeGoogleOneTap = (): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls.ensureMounted().then(controls => controls.closeModal('googleOneTap'));
};

public openSignIn = (props?: SignInProps): void => {
this.assertComponentsReady(this.#componentControls);
if (sessionExistsAndSingleSessionModeEnabled(this, this.#environment) && this.#instanceType === 'development') {
Expand DownExpand Up@@ -457,30 +471,6 @@ export default class Clerk implements ClerkInterface {
);
};

public __experimental_mountGoogleOneTap = (node: HTMLDivElement, props?: OneTapProps): void => {
this.assertComponentsReady(this.#componentControls);

void this.#componentControls.ensureMounted({ preloadHint: 'OneTap' }).then(controls =>
controls.mountComponent({
name: 'OneTap',
appearanceKey: 'oneTap',
node,
props,
}),
);
// TODO-ONETAP: Enable telemetry one feature is ready for public beta
// this.telemetry?.record(eventComponentMounted('GoogleOneTap', props));
};

public __experimental_unmountGoogleOneTap = (node: HTMLDivElement): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls.ensureMounted().then(controls =>
controls.unmountComponent({
node,
}),
);
};

public mountSignUp = (node: HTMLDivElement, props?: SignUpProps): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls.ensureMounted({ preloadHint: 'SignUp' }).then(controls =>
Expand DownExpand Up@@ -966,14 +956,47 @@ export default class Clerk implements ClerkInterface {
return null;
};

public handleRedirectCallback = async (
params: HandleOAuthCallbackParams = {},
public handleGoogleOneTapCallback = async (
signInOrUp: SignInResource | SignUpResource,
params: HandleOAuthCallbackParams,
customNavigate?: (to: string) => Promise<unknown>,
): Promise<unknown> => {
if (!this.#isReady || !this.#environment || !this.client) {
return;
}
const { signIn, signUp } = this.client;
const { signIn: _signIn, signUp: _signUp } = this.client;

const signIn = 'identifier' in (signInOrUp || {}) ? (signInOrUp as SignInResource) : _signIn;
const signUp = 'missingFields' in (signInOrUp || {}) ? (signInOrUp as SignUpResource) : _signUp;

const navigate = (to: string) =>
customNavigate && typeof customNavigate === 'function'
? customNavigate(this.buildUrlWithAuth(to))
: this.navigate(this.buildUrlWithAuth(to));

return this._handleRedirectCallback(params, {
signUp,
signIn,
navigate,
});
};

private _handleRedirectCallback = async (
params: HandleOAuthCallbackParams,
{
signIn,
signUp,
navigate,
}: {
signIn: SignInResource;
signUp: SignUpResource;
navigate: (to: string) => Promise<unknown>;
},
): Promise<unknown> => {
if (!this.loaded || !this.#environment || !this.client) {
return;
}

const { displayConfig } = this.#environment;
const { firstFactorVerification } = signIn;
const { externalAccount } = signUp.verifications;
Expand All@@ -983,18 +1006,17 @@ export default class Clerk implements ClerkInterface {
externalAccountStatus: externalAccount.status,
externalAccountErrorCode: externalAccount.error?.code,
externalAccountSessionId: externalAccount.error?.meta?.sessionId,
sessionId: signUp.createdSessionId,
};

const si = {
status: signIn.status,
firstFactorVerificationStatus: firstFactorVerification.status,
firstFactorVerificationErrorCode: firstFactorVerification.error?.code,
firstFactorVerificationSessionId: firstFactorVerification.error?.meta?.sessionId,
sessionId: signIn.createdSessionId,
};

const navigate = (to: string) =>
customNavigate && typeof customNavigate === 'function' ? customNavigate(to) : this.navigate(to);

const makeNavigate = (to: string) => () => navigate(to);

const navigateToSignIn = makeNavigate(displayConfig.signInUrl);
Expand DownExpand Up@@ -1026,7 +1048,13 @@ export default class Clerk implements ClerkInterface {

const navigateToContinueSignUp = makeNavigate(
params.continueSignUpUrl ||
buildURL({ base: displayConfig.signUpUrl, hashPath: '/continue' }, { stringify: true }),
buildURL(
{
base: displayConfig.signUpUrl,
hashPath: '/continue',
},
{ stringify: true },
),
);

const navigateToNextStepSignUp = ({ missingFields }: { missingFields: SignUpField[] }) => {
Expand All@@ -1046,6 +1074,13 @@ export default class Clerk implements ClerkInterface {
});
};

if (si.status === 'complete') {
return this.setActive({
session: si.sessionId,
beforeEmit: navigateAfterSignIn,
});
}

const userExistsButNeedsToSignIn =
su.externalAccountStatus === 'transferable' && su.externalAccountErrorCode === 'external_account_exists';

Expand DownExpand Up@@ -1108,6 +1143,13 @@ export default class Clerk implements ClerkInterface {
}
}

if (su.status === 'complete') {
return this.setActive({
session: su.sessionId,
beforeEmit: navigateAfterSignUp,
});
}

if (si.status === 'needs_second_factor') {
return navigateToFactorTwo();
}
Expand DownExpand Up@@ -1144,6 +1186,25 @@ export default class Clerk implements ClerkInterface {
return navigateToSignIn();
};

public handleRedirectCallback = async (
params: HandleOAuthCallbackParams = {},
customNavigate?: (to: string) => Promise<unknown>,
): Promise<unknown> => {
if (!this.loaded || !this.#environment || !this.client) {
return;
}
const { signIn, signUp } = this.client;

const navigate = (to: string) =>
customNavigate && typeof customNavigate === 'function' ? customNavigate(to) : this.navigate(to);

return this._handleRedirectCallback(params, {
signUp,
signIn,
navigate,
});
};

public handleUnauthenticated = async (opts = { broadcast: true }): Promise<unknown> => {
if (!this.client || !this.session) {
return;
Expand All@@ -1159,6 +1220,25 @@ export default class Clerk implements ClerkInterface {
return this.setActive({ session: null });
};

public authenticateWithGoogleOneTap = async (
params: AuthenticateWithGoogleOneTapParams,
): Promise<SignInResource | SignUpResource> => {
return this.client?.signIn
.create({
strategy: 'google_one_tap',
token: params.token,
})
.catch(err => {
if (isClerkAPIResponseError(err) && err.errors[0].code === 'external_account_not_found') {
return this.client?.signUp.create({

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panteliselef I think I've mentioned this before, but I'm double-checking that this signUp.create will trigger a Captcha functionality, and if the user has selected the "Smart" option it will try to find the clerk-captcha in the DOM. Thankfully, it won't break, because we fallback to "Invisible", but the fallback mechanism may change in the future, we should not depend on it.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

strategy: 'google_one_tap',
token: params.token,
});
}
throw err;
}) as Promise<SignInResource | SignUpResource>;
};

public authenticateWithMetamask = async ({
redirectUrl,
signUpContinueUrl,
Expand Down
25 changes: 1 addition & 24 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { deepSnakeToCamel, deprecated, isClerkAPIResponseError, Poller } from '@clerk/shared';
import { deepSnakeToCamel, deprecated, Poller } from '@clerk/shared';
import type {
__experimental_AuthenticateWithGoogleOneTapParams,
AttemptFirstFactorParams,
AttemptSecondFactorParams,
AuthenticateWithRedirectParams,
Expand All@@ -25,7 +24,6 @@ import type {
SignInStartEmailLinkFlowParams,
SignInStartMagicLinkFlowParams,
SignInStatus,
SignUpResource,
VerificationResource,
Web3SignatureConfig,
Web3SignatureFactor,
Expand DownExpand Up@@ -240,27 +238,6 @@ export class SignIn extends BaseResource implements SignInResource {
}
};

public __experimental_authenticateWithGoogleOneTap = async (
params: __experimental_AuthenticateWithGoogleOneTapParams,
): Promise<SignInResource | SignUpResource> => {
return this.create({
// TODO-ONETAP: Add new types when feature is ready for public beta
// @ts-expect-error
strategy: 'google_one_tap',
googleOneTapToken: params.token,
}).catch(err => {
if (isClerkAPIResponseError(err) && err.errors[0].code === 'external_account_not_found') {
return SignIn.clerk.client?.signUp.create({
// TODO-ONETAP: Add new types when feature is ready for public beta
// @ts-expect-error
strategy: 'google_one_tap',
googleOneTapToken: params.token,
});
}
throw err;
}) as Promise<SignInResource | SignUpResource>;
};

public authenticateWithWeb3 = async (params: AuthenticateWithWeb3Params): Promise<SignInResource> => {
const { identifier, generateSignature } = params || {};
if (!(typeof generateSignature === 'function')) {
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/funny-berries-nail.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
---
'@clerk/nextjs': minor
'@clerk/clerk-react': minor
---

Add support for GoogleOneTap
### React component
- `<GoogleOneTap/>`

Customize the UX of the prompt

```tsx
<GoogleOneTap cancelOnTapOutside={false} itpSupport={false} fedCmSupport={false}/>
```
37 changes: 37 additions & 0 deletions .changeset/mighty-dolphins-look.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
---
'@clerk/clerk-js': minor
---

### Use the Google One Tap component from with Vanilla JS
- `Clerk.openGoogleOneTap({ cancelOnTapOutside: false, fedCmSupport: false, itpSupport: false })`
- `Clerk.closeGoogleOneTap()`
### Low level APIs for custom flows
- `await Clerk.authenticateWithGoogleOneTap({ token: 'xxxx'})`
- `await Clerk.handleGoogleOneTapCallback()`


We recommend using this two methods together in order and let Clerk perform the correct redirections.
```tsx
google.accounts.id.initialize({
callback: async response => {
const signInOrUp = await Clerk.authenticateWithGoogleOneTap({ token: response.credential})
await Clerk.handleGoogleOneTapCallback(signInOrUp, {
afterSignInUrl: window.location.href,
})
},
});
```

In case you want to handle the redirection and session management yourself you can do so like this
```tsx
google.accounts.id.initialize({
callback: async response => {
const signInOrUp = await Clerk.authenticateWithGoogleOneTap({ token: response.credential})
if(signInOrUp.status === 'complete') {
await Clerk.setActive({
session: signInOrUp.createdSessionId
})
}
},
});
```
5 changes: 5 additions & 0 deletions .changeset/shaggy-elephants-shop.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/chrome-extension': minor
---

Update export snapshot tests to include `GoogleOneTap`.
21 changes: 21 additions & 0 deletions .changeset/silly-mugs-type.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
---
'@clerk/types': minor
---

Added the following types
```tsx
interface Clerk {
...
openGoogleOneTap: (props?: GoogleOneTapProps) => void;
closeGoogleOneTap: () => void;
authenticateWithGoogleOneTap: (params: AuthenticateWithGoogleOneTapParams) => Promise<SignInResource | SignUpResource>;
handleGoogleOneTapCallback: (
signInOrUp: SignInResource | SignUpResource,
params: HandleOAuthCallbackParams,
customNavigate?: (to: string) => Promise<unknown>,
) => Promise<unknown>;
...
}

type GoogleOneTapStrategy = 'google_one_tap'
```
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,7 @@ exports[`public exports should not include a breaking change 1`] = `
"ClerkProvider",
"CreateOrganization",
"EmailLinkErrorCode",
"GoogleOneTap",
"MagicLinkErrorCode",
"MultisessionAppSupport",
"OrganizationList",
Expand All@@ -32,7 +33,6 @@ exports[`public exports should not include a breaking change 1`] = `
"WithClerk",
"WithSession",
"WithUser",
"__experimental_GoogleOneTap",
"__internal__setErrorThrowerOptions",
"isClerkAPIResponseError",
"isEmailLinkError",
Expand Down
144 changes: 112 additions & 32 deletions packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@ import {
handleValueOrFn,
inBrowser as inClientSide,
is4xxError,
isClerkAPIResponseError,
isHttpOrHttps,
isLegacyFrontendApiKey,
isValidBrowserOnline,
Expand All@@ -17,6 +18,7 @@ import {
} from '@clerk/shared';
import type {
ActiveSessionResource,
AuthenticateWithGoogleOneTapParams,
AuthenticateWithMetamaskParams,
BeforeEmitCallback,
Clerk as ClerkInterface,
Expand All@@ -28,12 +30,12 @@ import type {
DomainOrProxyUrl,
EnvironmentJSON,
EnvironmentResource,
GoogleOneTapProps,
HandleEmailLinkVerificationParams,
HandleMagicLinkVerificationParams,
HandleOAuthCallbackParams,
InstanceType,
ListenerCallback,
OneTapProps,
OrganizationInvitationResource,
OrganizationListProps,
OrganizationMembershipResource,
Expand DownExpand Up@@ -364,6 +366,18 @@ export default class Clerk implements ClerkInterface {
}
};

public openGoogleOneTap = (props?: GoogleOneTapProps): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls
.ensureMounted({ preloadHint: 'GoogleOneTap' })
.then(controls => controls.openModal('googleOneTap', props || {}));
};

public closeGoogleOneTap = (): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls.ensureMounted().then(controls => controls.closeModal('googleOneTap'));
};

public openSignIn = (props?: SignInProps): void => {
this.assertComponentsReady(this.#componentControls);
if (sessionExistsAndSingleSessionModeEnabled(this, this.#environment) && this.#instanceType === 'development') {
Expand DownExpand Up@@ -457,30 +471,6 @@ export default class Clerk implements ClerkInterface {
);
};

public __experimental_mountGoogleOneTap = (node: HTMLDivElement, props?: OneTapProps): void => {
this.assertComponentsReady(this.#componentControls);

void this.#componentControls.ensureMounted({ preloadHint: 'OneTap' }).then(controls =>
controls.mountComponent({
name: 'OneTap',
appearanceKey: 'oneTap',
node,
props,
}),
);
// TODO-ONETAP: Enable telemetry one feature is ready for public beta
// this.telemetry?.record(eventComponentMounted('GoogleOneTap', props));
};

public __experimental_unmountGoogleOneTap = (node: HTMLDivElement): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls.ensureMounted().then(controls =>
controls.unmountComponent({
node,
}),
);
};

public mountSignUp = (node: HTMLDivElement, props?: SignUpProps): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls.ensureMounted({ preloadHint: 'SignUp' }).then(controls =>
Expand DownExpand Up@@ -966,14 +956,47 @@ export default class Clerk implements ClerkInterface {
return null;
};

public handleRedirectCallback = async (
params: HandleOAuthCallbackParams = {},
public handleGoogleOneTapCallback = async (
signInOrUp: SignInResource | SignUpResource,
params: HandleOAuthCallbackParams,
customNavigate?: (to: string) => Promise<unknown>,
): Promise<unknown> => {
if (!this.#isReady || !this.#environment || !this.client) {
return;
}
const { signIn, signUp } = this.client;
const { signIn: _signIn, signUp: _signUp } = this.client;

const signIn = 'identifier' in (signInOrUp || {}) ? (signInOrUp as SignInResource) : _signIn;
const signUp = 'missingFields' in (signInOrUp || {}) ? (signInOrUp as SignUpResource) : _signUp;

const navigate = (to: string) =>
customNavigate && typeof customNavigate === 'function'
? customNavigate(this.buildUrlWithAuth(to))
: this.navigate(this.buildUrlWithAuth(to));

return this._handleRedirectCallback(params, {
signUp,
signIn,
navigate,
});
};

private _handleRedirectCallback = async (
params: HandleOAuthCallbackParams,
{
signIn,
signUp,
navigate,
}: {
signIn: SignInResource;
signUp: SignUpResource;
navigate: (to: string) => Promise<unknown>;
},
): Promise<unknown> => {
if (!this.loaded || !this.#environment || !this.client) {
return;
}

const { displayConfig } = this.#environment;
const { firstFactorVerification } = signIn;
const { externalAccount } = signUp.verifications;
Expand All@@ -983,18 +1006,17 @@ export default class Clerk implements ClerkInterface {
externalAccountStatus: externalAccount.status,
externalAccountErrorCode: externalAccount.error?.code,
externalAccountSessionId: externalAccount.error?.meta?.sessionId,
sessionId: signUp.createdSessionId,
};

const si = {
status: signIn.status,
firstFactorVerificationStatus: firstFactorVerification.status,
firstFactorVerificationErrorCode: firstFactorVerification.error?.code,
firstFactorVerificationSessionId: firstFactorVerification.error?.meta?.sessionId,
sessionId: signIn.createdSessionId,
};

const navigate = (to: string) =>
customNavigate && typeof customNavigate === 'function' ? customNavigate(to) : this.navigate(to);

const makeNavigate = (to: string) => () => navigate(to);

const navigateToSignIn = makeNavigate(displayConfig.signInUrl);
Expand DownExpand Up@@ -1026,7 +1048,13 @@ export default class Clerk implements ClerkInterface {

const navigateToContinueSignUp = makeNavigate(
params.continueSignUpUrl ||
buildURL({ base: displayConfig.signUpUrl, hashPath: '/continue' }, { stringify: true }),
buildURL(
{
base: displayConfig.signUpUrl,
hashPath: '/continue',
},
{ stringify: true },
),
);

const navigateToNextStepSignUp = ({ missingFields }: { missingFields: SignUpField[] }) => {
Expand All@@ -1046,6 +1074,13 @@ export default class Clerk implements ClerkInterface {
});
};

if (si.status === 'complete') {
return this.setActive({
session: si.sessionId,
beforeEmit: navigateAfterSignIn,
});
}

const userExistsButNeedsToSignIn =
su.externalAccountStatus === 'transferable' && su.externalAccountErrorCode === 'external_account_exists';

Expand DownExpand Up@@ -1108,6 +1143,13 @@ export default class Clerk implements ClerkInterface {
}
}

if (su.status === 'complete') {
return this.setActive({
session: su.sessionId,
beforeEmit: navigateAfterSignUp,
});
}

if (si.status === 'needs_second_factor') {
return navigateToFactorTwo();
}
Expand DownExpand Up@@ -1144,6 +1186,25 @@ export default class Clerk implements ClerkInterface {
return navigateToSignIn();
};

public handleRedirectCallback = async (
params: HandleOAuthCallbackParams = {},
customNavigate?: (to: string) => Promise<unknown>,
): Promise<unknown> => {
if (!this.loaded || !this.#environment || !this.client) {
return;
}
const { signIn, signUp } = this.client;

const navigate = (to: string) =>
customNavigate && typeof customNavigate === 'function' ? customNavigate(to) : this.navigate(to);

return this._handleRedirectCallback(params, {
signUp,
signIn,
navigate,
});
};

public handleUnauthenticated = async (opts = { broadcast: true }): Promise<unknown> => {
if (!this.client || !this.session) {
return;
Expand All@@ -1159,6 +1220,25 @@ export default class Clerk implements ClerkInterface {
return this.setActive({ session: null });
};

public authenticateWithGoogleOneTap = async (
params: AuthenticateWithGoogleOneTapParams,
): Promise<SignInResource | SignUpResource> => {
return this.client?.signIn
.create({
strategy: 'google_one_tap',
token: params.token,
})
.catch(err => {
if (isClerkAPIResponseError(err) && err.errors[0].code === 'external_account_not_found') {
return this.client?.signUp.create({

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panteliselef I think I've mentioned this before, but I'm double-checking that this signUp.create will trigger a Captcha functionality, and if the user has selected the "Smart" option it will try to find the clerk-captcha in the DOM. Thankfully, it won't break, because we fallback to "Invisible", but the fallback mechanism may change in the future, we should not depend on it.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

strategy: 'google_one_tap',
token: params.token,
});
}
throw err;
}) as Promise<SignInResource | SignUpResource>;
};

public authenticateWithMetamask = async ({
redirectUrl,
signUpContinueUrl,
Expand Down
25 changes: 1 addition & 24 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { deepSnakeToCamel, deprecated, isClerkAPIResponseError, Poller } from '@clerk/shared';
import { deepSnakeToCamel, deprecated, Poller } from '@clerk/shared';
import type {
__experimental_AuthenticateWithGoogleOneTapParams,
AttemptFirstFactorParams,
AttemptSecondFactorParams,
AuthenticateWithRedirectParams,
Expand All@@ -25,7 +24,6 @@ import type {
SignInStartEmailLinkFlowParams,
SignInStartMagicLinkFlowParams,
SignInStatus,
SignUpResource,
VerificationResource,
Web3SignatureConfig,
Web3SignatureFactor,
Expand DownExpand Up@@ -240,27 +238,6 @@ export class SignIn extends BaseResource implements SignInResource {
}
};

public __experimental_authenticateWithGoogleOneTap = async (
params: __experimental_AuthenticateWithGoogleOneTapParams,
): Promise<SignInResource | SignUpResource> => {
return this.create({
// TODO-ONETAP: Add new types when feature is ready for public beta
// @ts-expect-error
strategy: 'google_one_tap',
googleOneTapToken: params.token,
}).catch(err => {
if (isClerkAPIResponseError(err) && err.errors[0].code === 'external_account_not_found') {
return SignIn.clerk.client?.signUp.create({
// TODO-ONETAP: Add new types when feature is ready for public beta
// @ts-expect-error
strategy: 'google_one_tap',
googleOneTapToken: params.token,
});
}
throw err;
}) as Promise<SignInResource | SignUpResource>;
};

public authenticateWithWeb3 = async (params: AuthenticateWithWeb3Params): Promise<SignInResource> => {
const { identifier, generateSignature } = params || {};
if (!(typeof generateSignature === 'function')) {
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/funny-berries-nail.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
---
'@clerk/nextjs': minor
'@clerk/clerk-react': minor
---

Add support for GoogleOneTap
### React component
- `<GoogleOneTap/>`

Customize the UX of the prompt

```tsx
<GoogleOneTap cancelOnTapOutside={false} itpSupport={false} fedCmSupport={false}/>
```
37 changes: 37 additions & 0 deletions .changeset/mighty-dolphins-look.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
---
'@clerk/clerk-js': minor
---

### Use the Google One Tap component from with Vanilla JS
- `Clerk.openGoogleOneTap({ cancelOnTapOutside: false, fedCmSupport: false, itpSupport: false })`
- `Clerk.closeGoogleOneTap()`
### Low level APIs for custom flows
- `await Clerk.authenticateWithGoogleOneTap({ token: 'xxxx'})`
- `await Clerk.handleGoogleOneTapCallback()`


We recommend using this two methods together in order and let Clerk perform the correct redirections.
```tsx
google.accounts.id.initialize({
callback: async response => {
const signInOrUp = await Clerk.authenticateWithGoogleOneTap({ token: response.credential})
await Clerk.handleGoogleOneTapCallback(signInOrUp, {
afterSignInUrl: window.location.href,
})
},
});
```

In case you want to handle the redirection and session management yourself you can do so like this
```tsx
google.accounts.id.initialize({
callback: async response => {
const signInOrUp = await Clerk.authenticateWithGoogleOneTap({ token: response.credential})
if(signInOrUp.status === 'complete') {
await Clerk.setActive({
session: signInOrUp.createdSessionId
})
}
},
});
```
5 changes: 5 additions & 0 deletions .changeset/shaggy-elephants-shop.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/chrome-extension': minor
---

Update export snapshot tests to include `GoogleOneTap`.
21 changes: 21 additions & 0 deletions .changeset/silly-mugs-type.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
---
'@clerk/types': minor
---

Added the following types
```tsx
interface Clerk {
...
openGoogleOneTap: (props?: GoogleOneTapProps) => void;
closeGoogleOneTap: () => void;
authenticateWithGoogleOneTap: (params: AuthenticateWithGoogleOneTapParams) => Promise<SignInResource | SignUpResource>;
handleGoogleOneTapCallback: (
signInOrUp: SignInResource | SignUpResource,
params: HandleOAuthCallbackParams,
customNavigate?: (to: string) => Promise<unknown>,
) => Promise<unknown>;
...
}

type GoogleOneTapStrategy = 'google_one_tap'
```
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,7 @@ exports[`public exports should not include a breaking change 1`] = `
"ClerkProvider",
"CreateOrganization",
"EmailLinkErrorCode",
"GoogleOneTap",
"MagicLinkErrorCode",
"MultisessionAppSupport",
"OrganizationList",
Expand All@@ -32,7 +33,6 @@ exports[`public exports should not include a breaking change 1`] = `
"WithClerk",
"WithSession",
"WithUser",
"__experimental_GoogleOneTap",
"__internal__setErrorThrowerOptions",
"isClerkAPIResponseError",
"isEmailLinkError",
Expand Down
144 changes: 112 additions & 32 deletions packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@ import {
handleValueOrFn,
inBrowser as inClientSide,
is4xxError,
isClerkAPIResponseError,
isHttpOrHttps,
isLegacyFrontendApiKey,
isValidBrowserOnline,
Expand All@@ -17,6 +18,7 @@ import {
} from '@clerk/shared';
import type {
ActiveSessionResource,
AuthenticateWithGoogleOneTapParams,
AuthenticateWithMetamaskParams,
BeforeEmitCallback,
Clerk as ClerkInterface,
Expand All@@ -28,12 +30,12 @@ import type {
DomainOrProxyUrl,
EnvironmentJSON,
EnvironmentResource,
GoogleOneTapProps,
HandleEmailLinkVerificationParams,
HandleMagicLinkVerificationParams,
HandleOAuthCallbackParams,
InstanceType,
ListenerCallback,
OneTapProps,
OrganizationInvitationResource,
OrganizationListProps,
OrganizationMembershipResource,
Expand DownExpand Up@@ -364,6 +366,18 @@ export default class Clerk implements ClerkInterface {
}
};

public openGoogleOneTap = (props?: GoogleOneTapProps): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls
.ensureMounted({ preloadHint: 'GoogleOneTap' })
.then(controls => controls.openModal('googleOneTap', props || {}));
};

public closeGoogleOneTap = (): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls.ensureMounted().then(controls => controls.closeModal('googleOneTap'));
};

public openSignIn = (props?: SignInProps): void => {
this.assertComponentsReady(this.#componentControls);
if (sessionExistsAndSingleSessionModeEnabled(this, this.#environment) && this.#instanceType === 'development') {
Expand DownExpand Up@@ -457,30 +471,6 @@ export default class Clerk implements ClerkInterface {
);
};

public __experimental_mountGoogleOneTap = (node: HTMLDivElement, props?: OneTapProps): void => {
this.assertComponentsReady(this.#componentControls);

void this.#componentControls.ensureMounted({ preloadHint: 'OneTap' }).then(controls =>
controls.mountComponent({
name: 'OneTap',
appearanceKey: 'oneTap',
node,
props,
}),
);
// TODO-ONETAP: Enable telemetry one feature is ready for public beta
// this.telemetry?.record(eventComponentMounted('GoogleOneTap', props));
};

public __experimental_unmountGoogleOneTap = (node: HTMLDivElement): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls.ensureMounted().then(controls =>
controls.unmountComponent({
node,
}),
);
};

public mountSignUp = (node: HTMLDivElement, props?: SignUpProps): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls.ensureMounted({ preloadHint: 'SignUp' }).then(controls =>
Expand DownExpand Up@@ -966,14 +956,47 @@ export default class Clerk implements ClerkInterface {
return null;
};

public handleRedirectCallback = async (
params: HandleOAuthCallbackParams = {},
public handleGoogleOneTapCallback = async (
signInOrUp: SignInResource | SignUpResource,
params: HandleOAuthCallbackParams,
customNavigate?: (to: string) => Promise<unknown>,
): Promise<unknown> => {
if (!this.#isReady || !this.#environment || !this.client) {
return;
}
const { signIn, signUp } = this.client;
const { signIn: _signIn, signUp: _signUp } = this.client;

const signIn = 'identifier' in (signInOrUp || {}) ? (signInOrUp as SignInResource) : _signIn;
const signUp = 'missingFields' in (signInOrUp || {}) ? (signInOrUp as SignUpResource) : _signUp;

const navigate = (to: string) =>
customNavigate && typeof customNavigate === 'function'
? customNavigate(this.buildUrlWithAuth(to))
: this.navigate(this.buildUrlWithAuth(to));

return this._handleRedirectCallback(params, {
signUp,
signIn,
navigate,
});
};

private _handleRedirectCallback = async (
params: HandleOAuthCallbackParams,
{
signIn,
signUp,
navigate,
}: {
signIn: SignInResource;
signUp: SignUpResource;
navigate: (to: string) => Promise<unknown>;
},
): Promise<unknown> => {
if (!this.loaded || !this.#environment || !this.client) {
return;
}

const { displayConfig } = this.#environment;
const { firstFactorVerification } = signIn;
const { externalAccount } = signUp.verifications;
Expand All@@ -983,18 +1006,17 @@ export default class Clerk implements ClerkInterface {
externalAccountStatus: externalAccount.status,
externalAccountErrorCode: externalAccount.error?.code,
externalAccountSessionId: externalAccount.error?.meta?.sessionId,
sessionId: signUp.createdSessionId,
};

const si = {
status: signIn.status,
firstFactorVerificationStatus: firstFactorVerification.status,
firstFactorVerificationErrorCode: firstFactorVerification.error?.code,
firstFactorVerificationSessionId: firstFactorVerification.error?.meta?.sessionId,
sessionId: signIn.createdSessionId,
};

const navigate = (to: string) =>
customNavigate && typeof customNavigate === 'function' ? customNavigate(to) : this.navigate(to);

const makeNavigate = (to: string) => () => navigate(to);

const navigateToSignIn = makeNavigate(displayConfig.signInUrl);
Expand DownExpand Up@@ -1026,7 +1048,13 @@ export default class Clerk implements ClerkInterface {

const navigateToContinueSignUp = makeNavigate(
params.continueSignUpUrl ||
buildURL({ base: displayConfig.signUpUrl, hashPath: '/continue' }, { stringify: true }),
buildURL(
{
base: displayConfig.signUpUrl,
hashPath: '/continue',
},
{ stringify: true },
),
);

const navigateToNextStepSignUp = ({ missingFields }: { missingFields: SignUpField[] }) => {
Expand All@@ -1046,6 +1074,13 @@ export default class Clerk implements ClerkInterface {
});
};

if (si.status === 'complete') {
return this.setActive({
session: si.sessionId,
beforeEmit: navigateAfterSignIn,
});
}

const userExistsButNeedsToSignIn =
su.externalAccountStatus === 'transferable' && su.externalAccountErrorCode === 'external_account_exists';

Expand DownExpand Up@@ -1108,6 +1143,13 @@ export default class Clerk implements ClerkInterface {
}
}

if (su.status === 'complete') {
return this.setActive({
session: su.sessionId,
beforeEmit: navigateAfterSignUp,
});
}

if (si.status === 'needs_second_factor') {
return navigateToFactorTwo();
}
Expand DownExpand Up@@ -1144,6 +1186,25 @@ export default class Clerk implements ClerkInterface {
return navigateToSignIn();
};

public handleRedirectCallback = async (
params: HandleOAuthCallbackParams = {},
customNavigate?: (to: string) => Promise<unknown>,
): Promise<unknown> => {
if (!this.loaded || !this.#environment || !this.client) {
return;
}
const { signIn, signUp } = this.client;

const navigate = (to: string) =>
customNavigate && typeof customNavigate === 'function' ? customNavigate(to) : this.navigate(to);

return this._handleRedirectCallback(params, {
signUp,
signIn,
navigate,
});
};

public handleUnauthenticated = async (opts = { broadcast: true }): Promise<unknown> => {
if (!this.client || !this.session) {
return;
Expand All@@ -1159,6 +1220,25 @@ export default class Clerk implements ClerkInterface {
return this.setActive({ session: null });
};

public authenticateWithGoogleOneTap = async (
params: AuthenticateWithGoogleOneTapParams,
): Promise<SignInResource | SignUpResource> => {
return this.client?.signIn
.create({
strategy: 'google_one_tap',
token: params.token,
})
.catch(err => {
if (isClerkAPIResponseError(err) && err.errors[0].code === 'external_account_not_found') {
return this.client?.signUp.create({

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panteliselef I think I've mentioned this before, but I'm double-checking that this signUp.create will trigger a Captcha functionality, and if the user has selected the "Smart" option it will try to find the clerk-captcha in the DOM. Thankfully, it won't break, because we fallback to "Invisible", but the fallback mechanism may change in the future, we should not depend on it.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

strategy: 'google_one_tap',
token: params.token,
});
}
throw err;
}) as Promise<SignInResource | SignUpResource>;
};

public authenticateWithMetamask = async ({
redirectUrl,
signUpContinueUrl,
Expand Down
25 changes: 1 addition & 24 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { deepSnakeToCamel, deprecated, isClerkAPIResponseError, Poller } from '@clerk/shared';
import { deepSnakeToCamel, deprecated, Poller } from '@clerk/shared';
import type {
__experimental_AuthenticateWithGoogleOneTapParams,
AttemptFirstFactorParams,
AttemptSecondFactorParams,
AuthenticateWithRedirectParams,
Expand All@@ -25,7 +24,6 @@ import type {
SignInStartEmailLinkFlowParams,
SignInStartMagicLinkFlowParams,
SignInStatus,
SignUpResource,
VerificationResource,
Web3SignatureConfig,
Web3SignatureFactor,
Expand DownExpand Up@@ -240,27 +238,6 @@ export class SignIn extends BaseResource implements SignInResource {
}
};

public __experimental_authenticateWithGoogleOneTap = async (
params: __experimental_AuthenticateWithGoogleOneTapParams,
): Promise<SignInResource | SignUpResource> => {
return this.create({
// TODO-ONETAP: Add new types when feature is ready for public beta
// @ts-expect-error
strategy: 'google_one_tap',
googleOneTapToken: params.token,
}).catch(err => {
if (isClerkAPIResponseError(err) && err.errors[0].code === 'external_account_not_found') {
return SignIn.clerk.client?.signUp.create({
// TODO-ONETAP: Add new types when feature is ready for public beta
// @ts-expect-error
strategy: 'google_one_tap',
googleOneTapToken: params.token,
});
}
throw err;
}) as Promise<SignInResource | SignUpResource>;
};

public authenticateWithWeb3 = async (params: AuthenticateWithWeb3Params): Promise<SignInResource> => {
const { identifier, generateSignature } = params || {};
if (!(typeof generateSignature === 'function')) {
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/funny-berries-nail.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
---
'@clerk/nextjs': minor
'@clerk/clerk-react': minor
---

Add support for GoogleOneTap
### React component
- `<GoogleOneTap/>`

Customize the UX of the prompt

```tsx
<GoogleOneTap cancelOnTapOutside={false} itpSupport={false} fedCmSupport={false}/>
```
37 changes: 37 additions & 0 deletions .changeset/mighty-dolphins-look.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
---
'@clerk/clerk-js': minor
---

### Use the Google One Tap component from with Vanilla JS
- `Clerk.openGoogleOneTap({ cancelOnTapOutside: false, fedCmSupport: false, itpSupport: false })`
- `Clerk.closeGoogleOneTap()`
### Low level APIs for custom flows
- `await Clerk.authenticateWithGoogleOneTap({ token: 'xxxx'})`
- `await Clerk.handleGoogleOneTapCallback()`


We recommend using this two methods together in order and let Clerk perform the correct redirections.
```tsx
google.accounts.id.initialize({
callback: async response => {
const signInOrUp = await Clerk.authenticateWithGoogleOneTap({ token: response.credential})
await Clerk.handleGoogleOneTapCallback(signInOrUp, {
afterSignInUrl: window.location.href,
})
},
});
```

In case you want to handle the redirection and session management yourself you can do so like this
```tsx
google.accounts.id.initialize({
callback: async response => {
const signInOrUp = await Clerk.authenticateWithGoogleOneTap({ token: response.credential})
if(signInOrUp.status === 'complete') {
await Clerk.setActive({
session: signInOrUp.createdSessionId
})
}
},
});
```
5 changes: 5 additions & 0 deletions .changeset/shaggy-elephants-shop.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/chrome-extension': minor
---

Update export snapshot tests to include `GoogleOneTap`.
21 changes: 21 additions & 0 deletions .changeset/silly-mugs-type.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
---
'@clerk/types': minor
---

Added the following types
```tsx
interface Clerk {
...
openGoogleOneTap: (props?: GoogleOneTapProps) => void;
closeGoogleOneTap: () => void;
authenticateWithGoogleOneTap: (params: AuthenticateWithGoogleOneTapParams) => Promise<SignInResource | SignUpResource>;
handleGoogleOneTapCallback: (
signInOrUp: SignInResource | SignUpResource,
params: HandleOAuthCallbackParams,
customNavigate?: (to: string) => Promise<unknown>,
) => Promise<unknown>;
...
}

type GoogleOneTapStrategy = 'google_one_tap'
```
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,7 @@ exports[`public exports should not include a breaking change 1`] = `
"ClerkProvider",
"CreateOrganization",
"EmailLinkErrorCode",
"GoogleOneTap",
"MagicLinkErrorCode",
"MultisessionAppSupport",
"OrganizationList",
Expand All@@ -32,7 +33,6 @@ exports[`public exports should not include a breaking change 1`] = `
"WithClerk",
"WithSession",
"WithUser",
"__experimental_GoogleOneTap",
"__internal__setErrorThrowerOptions",
"isClerkAPIResponseError",
"isEmailLinkError",
Expand Down
144 changes: 112 additions & 32 deletions packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@ import {
handleValueOrFn,
inBrowser as inClientSide,
is4xxError,
isClerkAPIResponseError,
isHttpOrHttps,
isLegacyFrontendApiKey,
isValidBrowserOnline,
Expand All@@ -17,6 +18,7 @@ import {
} from '@clerk/shared';
import type {
ActiveSessionResource,
AuthenticateWithGoogleOneTapParams,
AuthenticateWithMetamaskParams,
BeforeEmitCallback,
Clerk as ClerkInterface,
Expand All@@ -28,12 +30,12 @@ import type {
DomainOrProxyUrl,
EnvironmentJSON,
EnvironmentResource,
GoogleOneTapProps,
HandleEmailLinkVerificationParams,
HandleMagicLinkVerificationParams,
HandleOAuthCallbackParams,
InstanceType,
ListenerCallback,
OneTapProps,
OrganizationInvitationResource,
OrganizationListProps,
OrganizationMembershipResource,
Expand DownExpand Up@@ -364,6 +366,18 @@ export default class Clerk implements ClerkInterface {
}
};

public openGoogleOneTap = (props?: GoogleOneTapProps): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls
.ensureMounted({ preloadHint: 'GoogleOneTap' })
.then(controls => controls.openModal('googleOneTap', props || {}));
};

public closeGoogleOneTap = (): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls.ensureMounted().then(controls => controls.closeModal('googleOneTap'));
};

public openSignIn = (props?: SignInProps): void => {
this.assertComponentsReady(this.#componentControls);
if (sessionExistsAndSingleSessionModeEnabled(this, this.#environment) && this.#instanceType === 'development') {
Expand DownExpand Up@@ -457,30 +471,6 @@ export default class Clerk implements ClerkInterface {
);
};

public __experimental_mountGoogleOneTap = (node: HTMLDivElement, props?: OneTapProps): void => {
this.assertComponentsReady(this.#componentControls);

void this.#componentControls.ensureMounted({ preloadHint: 'OneTap' }).then(controls =>
controls.mountComponent({
name: 'OneTap',
appearanceKey: 'oneTap',
node,
props,
}),
);
// TODO-ONETAP: Enable telemetry one feature is ready for public beta
// this.telemetry?.record(eventComponentMounted('GoogleOneTap', props));
};

public __experimental_unmountGoogleOneTap = (node: HTMLDivElement): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls.ensureMounted().then(controls =>
controls.unmountComponent({
node,
}),
);
};

public mountSignUp = (node: HTMLDivElement, props?: SignUpProps): void => {
this.assertComponentsReady(this.#componentControls);
void this.#componentControls.ensureMounted({ preloadHint: 'SignUp' }).then(controls =>
Expand DownExpand Up@@ -966,14 +956,47 @@ export default class Clerk implements ClerkInterface {
return null;
};

public handleRedirectCallback = async (
params: HandleOAuthCallbackParams = {},
public handleGoogleOneTapCallback = async (
signInOrUp: SignInResource | SignUpResource,
params: HandleOAuthCallbackParams,
customNavigate?: (to: string) => Promise<unknown>,
): Promise<unknown> => {
if (!this.#isReady || !this.#environment || !this.client) {
return;
}
const { signIn, signUp } = this.client;
const { signIn: _signIn, signUp: _signUp } = this.client;

const signIn = 'identifier' in (signInOrUp || {}) ? (signInOrUp as SignInResource) : _signIn;
const signUp = 'missingFields' in (signInOrUp || {}) ? (signInOrUp as SignUpResource) : _signUp;

const navigate = (to: string) =>
customNavigate && typeof customNavigate === 'function'
? customNavigate(this.buildUrlWithAuth(to))
: this.navigate(this.buildUrlWithAuth(to));

return this._handleRedirectCallback(params, {
signUp,
signIn,
navigate,
});
};

private _handleRedirectCallback = async (
params: HandleOAuthCallbackParams,
{
signIn,
signUp,
navigate,
}: {
signIn: SignInResource;
signUp: SignUpResource;
navigate: (to: string) => Promise<unknown>;
},
): Promise<unknown> => {
if (!this.loaded || !this.#environment || !this.client) {
return;
}

const { displayConfig } = this.#environment;
const { firstFactorVerification } = signIn;
const { externalAccount } = signUp.verifications;
Expand All@@ -983,18 +1006,17 @@ export default class Clerk implements ClerkInterface {
externalAccountStatus: externalAccount.status,
externalAccountErrorCode: externalAccount.error?.code,
externalAccountSessionId: externalAccount.error?.meta?.sessionId,
sessionId: signUp.createdSessionId,
};

const si = {
status: signIn.status,
firstFactorVerificationStatus: firstFactorVerification.status,
firstFactorVerificationErrorCode: firstFactorVerification.error?.code,
firstFactorVerificationSessionId: firstFactorVerification.error?.meta?.sessionId,
sessionId: signIn.createdSessionId,
};

const navigate = (to: string) =>
customNavigate && typeof customNavigate === 'function' ? customNavigate(to) : this.navigate(to);

const makeNavigate = (to: string) => () => navigate(to);

const navigateToSignIn = makeNavigate(displayConfig.signInUrl);
Expand DownExpand Up@@ -1026,7 +1048,13 @@ export default class Clerk implements ClerkInterface {

const navigateToContinueSignUp = makeNavigate(
params.continueSignUpUrl ||
buildURL({ base: displayConfig.signUpUrl, hashPath: '/continue' }, { stringify: true }),
buildURL(
{
base: displayConfig.signUpUrl,
hashPath: '/continue',
},
{ stringify: true },
),
);

const navigateToNextStepSignUp = ({ missingFields }: { missingFields: SignUpField[] }) => {
Expand All@@ -1046,6 +1074,13 @@ export default class Clerk implements ClerkInterface {
});
};

if (si.status === 'complete') {
return this.setActive({
session: si.sessionId,
beforeEmit: navigateAfterSignIn,
});
}

const userExistsButNeedsToSignIn =
su.externalAccountStatus === 'transferable' && su.externalAccountErrorCode === 'external_account_exists';

Expand DownExpand Up@@ -1108,6 +1143,13 @@ export default class Clerk implements ClerkInterface {
}
}

if (su.status === 'complete') {
return this.setActive({
session: su.sessionId,
beforeEmit: navigateAfterSignUp,
});
}

if (si.status === 'needs_second_factor') {
return navigateToFactorTwo();
}
Expand DownExpand Up@@ -1144,6 +1186,25 @@ export default class Clerk implements ClerkInterface {
return navigateToSignIn();
};

public handleRedirectCallback = async (
params: HandleOAuthCallbackParams = {},
customNavigate?: (to: string) => Promise<unknown>,
): Promise<unknown> => {
if (!this.loaded || !this.#environment || !this.client) {
return;
}
const { signIn, signUp } = this.client;

const navigate = (to: string) =>
customNavigate && typeof customNavigate === 'function' ? customNavigate(to) : this.navigate(to);

return this._handleRedirectCallback(params, {
signUp,
signIn,
navigate,
});
};

public handleUnauthenticated = async (opts = { broadcast: true }): Promise<unknown> => {
if (!this.client || !this.session) {
return;
Expand All@@ -1159,6 +1220,25 @@ export default class Clerk implements ClerkInterface {
return this.setActive({ session: null });
};

public authenticateWithGoogleOneTap = async (
params: AuthenticateWithGoogleOneTapParams,
): Promise<SignInResource | SignUpResource> => {
return this.client?.signIn
.create({
strategy: 'google_one_tap',
token: params.token,
})
.catch(err => {
if (isClerkAPIResponseError(err) && err.errors[0].code === 'external_account_not_found') {
return this.client?.signUp.create({

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panteliselef I think I've mentioned this before, but I'm double-checking that this signUp.create will trigger a Captcha functionality, and if the user has selected the "Smart" option it will try to find the clerk-captcha in the DOM. Thankfully, it won't break, because we fallback to "Invisible", but the fallback mechanism may change in the future, we should not depend on it.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

strategy: 'google_one_tap',
token: params.token,
});
}
throw err;
}) as Promise<SignInResource | SignUpResource>;
};

public authenticateWithMetamask = async ({
redirectUrl,
signUpContinueUrl,
Expand Down
25 changes: 1 addition & 24 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { deepSnakeToCamel, deprecated, isClerkAPIResponseError, Poller } from '@clerk/shared';
import { deepSnakeToCamel, deprecated, Poller } from '@clerk/shared';
import type {
__experimental_AuthenticateWithGoogleOneTapParams,
AttemptFirstFactorParams,
AttemptSecondFactorParams,
AuthenticateWithRedirectParams,
Expand All@@ -25,7 +24,6 @@ import type {
SignInStartEmailLinkFlowParams,
SignInStartMagicLinkFlowParams,
SignInStatus,
SignUpResource,
VerificationResource,
Web3SignatureConfig,
Web3SignatureFactor,
Expand DownExpand Up@@ -240,27 +238,6 @@ export class SignIn extends BaseResource implements SignInResource {
}
};

public __experimental_authenticateWithGoogleOneTap = async (
params: __experimental_AuthenticateWithGoogleOneTapParams,
): Promise<SignInResource | SignUpResource> => {
return this.create({
// TODO-ONETAP: Add new types when feature is ready for public beta
// @ts-expect-error
strategy: 'google_one_tap',
googleOneTapToken: params.token,
}).catch(err => {
if (isClerkAPIResponseError(err) && err.errors[0].code === 'external_account_not_found') {
return SignIn.clerk.client?.signUp.create({
// TODO-ONETAP: Add new types when feature is ready for public beta
// @ts-expect-error
strategy: 'google_one_tap',
googleOneTapToken: params.token,
});
}
throw err;
}) as Promise<SignInResource | SignUpResource>;
};

public authenticateWithWeb3 = async (params: AuthenticateWithWeb3Params): Promise<SignInResource> => {
const { identifier, generateSignature } = params || {};
if (!(typeof generateSignature === 'function')) {
Expand Down
Loading