fix(nextjs): Replace router.refresh() with cookies().delete() - #3518

Merged
nikosdouvlis merged 3 commits into
mainfrom
nikos/replace-router-refresh
Jun 11, 2024
Merged

fix(nextjs): Replace router.refresh() with cookies().delete()#3518
nikosdouvlis merged 3 commits into
mainfrom
nikos/replace-router-refresh

Conversation

@nikosdouvlis

@nikosdouvlisnikosdouvlis commented Jun 5, 2024

Copy link
Copy Markdown
Member

Description

In this PR we replace router.refresh with a server action that calls cookies().delete. According to the NextJS docs, using the cookies().delete API invalidates the FE client cache, similar to what router.refresh does.

The main difference between the two is that router.refresh will then attempt to fetch and re-mount the current page. This causes our components to unmount and mount again, losing state before setActive completes. This usually leads to navigation/redirect issues, issues completing oauth flows etc.

Caveat:
We can only use server action directly for next@14 and above, as server actions were an experimental feature in next@13.
For next@13 we still call router.refresh. Users that are on next@13 should upgrade to at least next@14 if they notice any of the issues described above.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented Jun 5, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: df967c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/nextjsPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LekoArts
LekoArts marked this pull request as draft June 6, 2024 09:42
@joysamaddar

joysamaddar commented Jun 7, 2024

Copy link
Copy Markdown

Hi @nikosdouvlis,
Hope you are having a good day.
Is this PR related to fixing the issue where in NextJS, the protected page gets server reloaded once we press signout and hence clerk is not redirecting to the sign out route instead reloads the same route which redirects us to the signin page with the fallback of the current route?

@desiprisg

Copy link
Copy Markdown
Contributor

!snapshot

@clerk-cookie

Copy link
Copy Markdown
Collaborator

Hey @desiprisg - the snapshot version command generated the following package versions:

PackageVersion
@clerk/backend1.2.2-snapshot.v958fab4
@clerk/chrome-extension1.0.17-snapshot.v958fab4
@clerk/clerk-js5.6.0-snapshot.v958fab4
@clerk/elements0.6.0-snapshot.v958fab4
@clerk/clerk-expo1.2.0-snapshot.v958fab4
@clerk/express0.0.11-snapshot.v958fab4
@clerk/fastify1.0.13-snapshot.v958fab4
gatsby-plugin-clerk5.0.0-beta.45
@clerk/localizations2.4.4-snapshot.v958fab4
@clerk/nextjs5.1.4-snapshot.v958fab4
@clerk/clerk-react5.2.3-snapshot.v958fab4
@clerk/remix4.1.0-snapshot.v958fab4
@clerk/clerk-sdk-node5.0.10-snapshot.v958fab4
@clerk/shared2.2.2-snapshot.v958fab4
@clerk/testing1.1.6-snapshot.v958fab4
@clerk/themes2.1.9-snapshot.v958fab4
@clerk/types4.6.0-snapshot.v958fab4

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend

npm i @clerk/backend@1.2.2-snapshot.v958fab4 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.0.17-snapshot.v958fab4 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.6.0-snapshot.v958fab4 --save-exact

@clerk/elements

npm i @clerk/elements@0.6.0-snapshot.v958fab4 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.2.0-snapshot.v958fab4 --save-exact

@clerk/express

npm i @clerk/express@0.0.11-snapshot.v958fab4 --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.13-snapshot.v958fab4 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.4.4-snapshot.v958fab4 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.1.4-snapshot.v958fab4 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.2.3-snapshot.v958fab4 --save-exact

@clerk/remix

npm i @clerk/remix@4.1.0-snapshot.v958fab4 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.10-snapshot.v958fab4 --save-exact

@clerk/shared

npm i @clerk/shared@2.2.2-snapshot.v958fab4 --save-exact

@clerk/testing

npm i @clerk/testing@1.1.6-snapshot.v958fab4 --save-exact

@clerk/themes

npm i @clerk/themes@2.1.9-snapshot.v958fab4 --save-exact

@clerk/types

npm i @clerk/types@4.6.0-snapshot.v958fab4 --save-exact

@nikosdouvlis

Copy link
Copy Markdown
MemberAuthor

Hi @nikosdouvlis, Hope you are having a good day. Is this PR related to fixing the issue where in NextJS, the protected page gets server reloaded once we press signout and hence clerk is not redirecting to the sign out route instead reloads the same route which redirects us to the signin page with the fallback of the current route?

Hello @joysamaddar , I hope you're having a great day as well :)
Even though I am not completely sure yet, as this fix was intended to solve a different issue, the underlying root cause does look like it's the same, so I'm fairly confident that this will resolve the issue you describe. That being said, more testing needs to be done on our end!

Would you mind sharing a GH issue that describes your problem in detail, if there is one? Happy to take a look.

@joysamaddar

joysamaddar commented Jun 8, 2024

Copy link
Copy Markdown

Hi @nikosdouvlis, Hope you are having a good day. Is this PR related to fixing the issue where in NextJS, the protected page gets server reloaded once we press signout and hence clerk is not redirecting to the sign out route instead reloads the same route which redirects us to the signin page with the fallback of the current route?

Hello @joysamaddar , I hope you're having a great day as well :) Even though I am not completely sure yet, as this fix was intended to solve a different issue, the underlying root cause does look like it's the same, so I'm fairly confident that this will resolve the issue you describe. That being said, more testing needs to be done on our end!

Would you mind sharing a GH issue that describes your problem in detail, if there is one? Happy to take a look.

Hello again,
I tried out the snapshot version of this PR and it seems this PR fixed the issue i described.
Do you still want me to make an issue for this? Happy to do so if it helps.

@nikosdouvlis
nikosdouvlis marked this pull request as ready for review June 11, 2024 07:41
Comment threadpackages/nextjs/src/app-router/client/ClerkProvider.tsx Outdated
@desiprisg
desiprisgforce-pushed the nikos/replace-router-refresh branch from ab98df2 to f17124aCompareJune 11, 2024 12:53
@nikosdouvlisnikosdouvlis self-assigned this Jun 11, 2024

@anagstefanagstef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@panteliselefpanteliselef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@desiprisgdesiprisg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on that conditional check

@nikosdouvlis
nikosdouvlis merged commit 8741003 into mainJun 11, 2024
@nikosdouvlis
nikosdouvlis deleted the nikos/replace-router-refresh branch June 11, 2024 14:55
This was referenced Jun 11, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@nikosdouvlis@joysamaddar@desiprisg@clerk-cookie@dimkl@anagstef@panteliselef
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(nextjs): Replace router.refresh() with cookies().delete() - #3518

Merged
nikosdouvlis merged 3 commits into
mainfrom
nikos/replace-router-refresh
Jun 11, 2024
Merged

fix(nextjs): Replace router.refresh() with cookies().delete()#3518
nikosdouvlis merged 3 commits into
mainfrom
nikos/replace-router-refresh

Conversation

@nikosdouvlis

@nikosdouvlisnikosdouvlis commented Jun 5, 2024

Copy link
Copy Markdown
Member

Description

In this PR we replace router.refresh with a server action that calls cookies().delete. According to the NextJS docs, using the cookies().delete API invalidates the FE client cache, similar to what router.refresh does.

The main difference between the two is that router.refresh will then attempt to fetch and re-mount the current page. This causes our components to unmount and mount again, losing state before setActive completes. This usually leads to navigation/redirect issues, issues completing oauth flows etc.

Caveat:
We can only use server action directly for next@14 and above, as server actions were an experimental feature in next@13.
For next@13 we still call router.refresh. Users that are on next@13 should upgrade to at least next@14 if they notice any of the issues described above.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented Jun 5, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: df967c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/nextjsPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LekoArts
LekoArts marked this pull request as draft June 6, 2024 09:42
@joysamaddar

joysamaddar commented Jun 7, 2024

Copy link
Copy Markdown

Hi @nikosdouvlis,
Hope you are having a good day.
Is this PR related to fixing the issue where in NextJS, the protected page gets server reloaded once we press signout and hence clerk is not redirecting to the sign out route instead reloads the same route which redirects us to the signin page with the fallback of the current route?

@desiprisg

Copy link
Copy Markdown
Contributor

!snapshot

@clerk-cookie

Copy link
Copy Markdown
Collaborator

Hey @desiprisg - the snapshot version command generated the following package versions:

PackageVersion
@clerk/backend1.2.2-snapshot.v958fab4
@clerk/chrome-extension1.0.17-snapshot.v958fab4
@clerk/clerk-js5.6.0-snapshot.v958fab4
@clerk/elements0.6.0-snapshot.v958fab4
@clerk/clerk-expo1.2.0-snapshot.v958fab4
@clerk/express0.0.11-snapshot.v958fab4
@clerk/fastify1.0.13-snapshot.v958fab4
gatsby-plugin-clerk5.0.0-beta.45
@clerk/localizations2.4.4-snapshot.v958fab4
@clerk/nextjs5.1.4-snapshot.v958fab4
@clerk/clerk-react5.2.3-snapshot.v958fab4
@clerk/remix4.1.0-snapshot.v958fab4
@clerk/clerk-sdk-node5.0.10-snapshot.v958fab4
@clerk/shared2.2.2-snapshot.v958fab4
@clerk/testing1.1.6-snapshot.v958fab4
@clerk/themes2.1.9-snapshot.v958fab4
@clerk/types4.6.0-snapshot.v958fab4

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend

npm i @clerk/backend@1.2.2-snapshot.v958fab4 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.0.17-snapshot.v958fab4 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.6.0-snapshot.v958fab4 --save-exact

@clerk/elements

npm i @clerk/elements@0.6.0-snapshot.v958fab4 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.2.0-snapshot.v958fab4 --save-exact

@clerk/express

npm i @clerk/express@0.0.11-snapshot.v958fab4 --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.13-snapshot.v958fab4 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.4.4-snapshot.v958fab4 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.1.4-snapshot.v958fab4 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.2.3-snapshot.v958fab4 --save-exact

@clerk/remix

npm i @clerk/remix@4.1.0-snapshot.v958fab4 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.10-snapshot.v958fab4 --save-exact

@clerk/shared

npm i @clerk/shared@2.2.2-snapshot.v958fab4 --save-exact

@clerk/testing

npm i @clerk/testing@1.1.6-snapshot.v958fab4 --save-exact

@clerk/themes

npm i @clerk/themes@2.1.9-snapshot.v958fab4 --save-exact

@clerk/types

npm i @clerk/types@4.6.0-snapshot.v958fab4 --save-exact

@nikosdouvlis

Copy link
Copy Markdown
MemberAuthor

Hi @nikosdouvlis, Hope you are having a good day. Is this PR related to fixing the issue where in NextJS, the protected page gets server reloaded once we press signout and hence clerk is not redirecting to the sign out route instead reloads the same route which redirects us to the signin page with the fallback of the current route?

Hello @joysamaddar , I hope you're having a great day as well :)
Even though I am not completely sure yet, as this fix was intended to solve a different issue, the underlying root cause does look like it's the same, so I'm fairly confident that this will resolve the issue you describe. That being said, more testing needs to be done on our end!

Would you mind sharing a GH issue that describes your problem in detail, if there is one? Happy to take a look.

@joysamaddar

joysamaddar commented Jun 8, 2024

Copy link
Copy Markdown

Hi @nikosdouvlis, Hope you are having a good day. Is this PR related to fixing the issue where in NextJS, the protected page gets server reloaded once we press signout and hence clerk is not redirecting to the sign out route instead reloads the same route which redirects us to the signin page with the fallback of the current route?

Hello @joysamaddar , I hope you're having a great day as well :) Even though I am not completely sure yet, as this fix was intended to solve a different issue, the underlying root cause does look like it's the same, so I'm fairly confident that this will resolve the issue you describe. That being said, more testing needs to be done on our end!

Would you mind sharing a GH issue that describes your problem in detail, if there is one? Happy to take a look.

Hello again,
I tried out the snapshot version of this PR and it seems this PR fixed the issue i described.
Do you still want me to make an issue for this? Happy to do so if it helps.

@nikosdouvlis
nikosdouvlis marked this pull request as ready for review June 11, 2024 07:41
Comment threadpackages/nextjs/src/app-router/client/ClerkProvider.tsx Outdated
@desiprisg
desiprisgforce-pushed the nikos/replace-router-refresh branch from ab98df2 to f17124aCompareJune 11, 2024 12:53
@nikosdouvlisnikosdouvlis self-assigned this Jun 11, 2024

@anagstefanagstef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@panteliselefpanteliselef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@desiprisgdesiprisg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on that conditional check

@nikosdouvlis
nikosdouvlis merged commit 8741003 into mainJun 11, 2024
@nikosdouvlis
nikosdouvlis deleted the nikos/replace-router-refresh branch June 11, 2024 14:55
This was referenced Jun 11, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@nikosdouvlis@joysamaddar@desiprisg@clerk-cookie@dimkl@anagstef@panteliselef
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(nextjs): Replace router.refresh() with cookies().delete() - #3518

Merged
nikosdouvlis merged 3 commits into
mainfrom
nikos/replace-router-refresh
Jun 11, 2024
Merged

fix(nextjs): Replace router.refresh() with cookies().delete()#3518
nikosdouvlis merged 3 commits into
mainfrom
nikos/replace-router-refresh

Conversation

@nikosdouvlis

@nikosdouvlisnikosdouvlis commented Jun 5, 2024

Copy link
Copy Markdown
Member

Description

In this PR we replace router.refresh with a server action that calls cookies().delete. According to the NextJS docs, using the cookies().delete API invalidates the FE client cache, similar to what router.refresh does.

The main difference between the two is that router.refresh will then attempt to fetch and re-mount the current page. This causes our components to unmount and mount again, losing state before setActive completes. This usually leads to navigation/redirect issues, issues completing oauth flows etc.

Caveat:
We can only use server action directly for next@14 and above, as server actions were an experimental feature in next@13.
For next@13 we still call router.refresh. Users that are on next@13 should upgrade to at least next@14 if they notice any of the issues described above.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented Jun 5, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: df967c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/nextjsPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LekoArts
LekoArts marked this pull request as draft June 6, 2024 09:42
@joysamaddar

joysamaddar commented Jun 7, 2024

Copy link
Copy Markdown

Hi @nikosdouvlis,
Hope you are having a good day.
Is this PR related to fixing the issue where in NextJS, the protected page gets server reloaded once we press signout and hence clerk is not redirecting to the sign out route instead reloads the same route which redirects us to the signin page with the fallback of the current route?

@desiprisg

Copy link
Copy Markdown
Contributor

!snapshot

@clerk-cookie

Copy link
Copy Markdown
Collaborator

Hey @desiprisg - the snapshot version command generated the following package versions:

PackageVersion
@clerk/backend1.2.2-snapshot.v958fab4
@clerk/chrome-extension1.0.17-snapshot.v958fab4
@clerk/clerk-js5.6.0-snapshot.v958fab4
@clerk/elements0.6.0-snapshot.v958fab4
@clerk/clerk-expo1.2.0-snapshot.v958fab4
@clerk/express0.0.11-snapshot.v958fab4
@clerk/fastify1.0.13-snapshot.v958fab4
gatsby-plugin-clerk5.0.0-beta.45
@clerk/localizations2.4.4-snapshot.v958fab4
@clerk/nextjs5.1.4-snapshot.v958fab4
@clerk/clerk-react5.2.3-snapshot.v958fab4
@clerk/remix4.1.0-snapshot.v958fab4
@clerk/clerk-sdk-node5.0.10-snapshot.v958fab4
@clerk/shared2.2.2-snapshot.v958fab4
@clerk/testing1.1.6-snapshot.v958fab4
@clerk/themes2.1.9-snapshot.v958fab4
@clerk/types4.6.0-snapshot.v958fab4

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend

npm i @clerk/backend@1.2.2-snapshot.v958fab4 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.0.17-snapshot.v958fab4 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.6.0-snapshot.v958fab4 --save-exact

@clerk/elements

npm i @clerk/elements@0.6.0-snapshot.v958fab4 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.2.0-snapshot.v958fab4 --save-exact

@clerk/express

npm i @clerk/express@0.0.11-snapshot.v958fab4 --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.13-snapshot.v958fab4 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.4.4-snapshot.v958fab4 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.1.4-snapshot.v958fab4 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.2.3-snapshot.v958fab4 --save-exact

@clerk/remix

npm i @clerk/remix@4.1.0-snapshot.v958fab4 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.10-snapshot.v958fab4 --save-exact

@clerk/shared

npm i @clerk/shared@2.2.2-snapshot.v958fab4 --save-exact

@clerk/testing

npm i @clerk/testing@1.1.6-snapshot.v958fab4 --save-exact

@clerk/themes

npm i @clerk/themes@2.1.9-snapshot.v958fab4 --save-exact

@clerk/types

npm i @clerk/types@4.6.0-snapshot.v958fab4 --save-exact

@nikosdouvlis

Copy link
Copy Markdown
MemberAuthor

Hi @nikosdouvlis, Hope you are having a good day. Is this PR related to fixing the issue where in NextJS, the protected page gets server reloaded once we press signout and hence clerk is not redirecting to the sign out route instead reloads the same route which redirects us to the signin page with the fallback of the current route?

Hello @joysamaddar , I hope you're having a great day as well :)
Even though I am not completely sure yet, as this fix was intended to solve a different issue, the underlying root cause does look like it's the same, so I'm fairly confident that this will resolve the issue you describe. That being said, more testing needs to be done on our end!

Would you mind sharing a GH issue that describes your problem in detail, if there is one? Happy to take a look.

@joysamaddar

joysamaddar commented Jun 8, 2024

Copy link
Copy Markdown

Hi @nikosdouvlis, Hope you are having a good day. Is this PR related to fixing the issue where in NextJS, the protected page gets server reloaded once we press signout and hence clerk is not redirecting to the sign out route instead reloads the same route which redirects us to the signin page with the fallback of the current route?

Hello @joysamaddar , I hope you're having a great day as well :) Even though I am not completely sure yet, as this fix was intended to solve a different issue, the underlying root cause does look like it's the same, so I'm fairly confident that this will resolve the issue you describe. That being said, more testing needs to be done on our end!

Would you mind sharing a GH issue that describes your problem in detail, if there is one? Happy to take a look.

Hello again,
I tried out the snapshot version of this PR and it seems this PR fixed the issue i described.
Do you still want me to make an issue for this? Happy to do so if it helps.

@nikosdouvlis
nikosdouvlis marked this pull request as ready for review June 11, 2024 07:41
Comment threadpackages/nextjs/src/app-router/client/ClerkProvider.tsx Outdated
@desiprisg
desiprisgforce-pushed the nikos/replace-router-refresh branch from ab98df2 to f17124aCompareJune 11, 2024 12:53
@nikosdouvlisnikosdouvlis self-assigned this Jun 11, 2024

@anagstefanagstef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@panteliselefpanteliselef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@desiprisgdesiprisg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on that conditional check

@nikosdouvlis
nikosdouvlis merged commit 8741003 into mainJun 11, 2024
@nikosdouvlis
nikosdouvlis deleted the nikos/replace-router-refresh branch June 11, 2024 14:55
This was referenced Jun 11, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@nikosdouvlis@joysamaddar@desiprisg@clerk-cookie@dimkl@anagstef@panteliselef
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(nextjs): Replace router.refresh() with cookies().delete() - #3518

Merged
nikosdouvlis merged 3 commits into
mainfrom
nikos/replace-router-refresh
Jun 11, 2024
Merged

fix(nextjs): Replace router.refresh() with cookies().delete()#3518
nikosdouvlis merged 3 commits into
mainfrom
nikos/replace-router-refresh

Conversation

@nikosdouvlis

@nikosdouvlisnikosdouvlis commented Jun 5, 2024

Copy link
Copy Markdown
Member

Description

In this PR we replace router.refresh with a server action that calls cookies().delete. According to the NextJS docs, using the cookies().delete API invalidates the FE client cache, similar to what router.refresh does.

The main difference between the two is that router.refresh will then attempt to fetch and re-mount the current page. This causes our components to unmount and mount again, losing state before setActive completes. This usually leads to navigation/redirect issues, issues completing oauth flows etc.

Caveat:
We can only use server action directly for next@14 and above, as server actions were an experimental feature in next@13.
For next@13 we still call router.refresh. Users that are on next@13 should upgrade to at least next@14 if they notice any of the issues described above.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented Jun 5, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: df967c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/nextjsPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LekoArts
LekoArts marked this pull request as draft June 6, 2024 09:42
@joysamaddar

joysamaddar commented Jun 7, 2024

Copy link
Copy Markdown

Hi @nikosdouvlis,
Hope you are having a good day.
Is this PR related to fixing the issue where in NextJS, the protected page gets server reloaded once we press signout and hence clerk is not redirecting to the sign out route instead reloads the same route which redirects us to the signin page with the fallback of the current route?

@desiprisg

Copy link
Copy Markdown
Contributor

!snapshot

@clerk-cookie

Copy link
Copy Markdown
Collaborator

Hey @desiprisg - the snapshot version command generated the following package versions:

PackageVersion
@clerk/backend1.2.2-snapshot.v958fab4
@clerk/chrome-extension1.0.17-snapshot.v958fab4
@clerk/clerk-js5.6.0-snapshot.v958fab4
@clerk/elements0.6.0-snapshot.v958fab4
@clerk/clerk-expo1.2.0-snapshot.v958fab4
@clerk/express0.0.11-snapshot.v958fab4
@clerk/fastify1.0.13-snapshot.v958fab4
gatsby-plugin-clerk5.0.0-beta.45
@clerk/localizations2.4.4-snapshot.v958fab4
@clerk/nextjs5.1.4-snapshot.v958fab4
@clerk/clerk-react5.2.3-snapshot.v958fab4
@clerk/remix4.1.0-snapshot.v958fab4
@clerk/clerk-sdk-node5.0.10-snapshot.v958fab4
@clerk/shared2.2.2-snapshot.v958fab4
@clerk/testing1.1.6-snapshot.v958fab4
@clerk/themes2.1.9-snapshot.v958fab4
@clerk/types4.6.0-snapshot.v958fab4

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend

npm i @clerk/backend@1.2.2-snapshot.v958fab4 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.0.17-snapshot.v958fab4 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.6.0-snapshot.v958fab4 --save-exact

@clerk/elements

npm i @clerk/elements@0.6.0-snapshot.v958fab4 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.2.0-snapshot.v958fab4 --save-exact

@clerk/express

npm i @clerk/express@0.0.11-snapshot.v958fab4 --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.13-snapshot.v958fab4 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.4.4-snapshot.v958fab4 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.1.4-snapshot.v958fab4 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.2.3-snapshot.v958fab4 --save-exact

@clerk/remix

npm i @clerk/remix@4.1.0-snapshot.v958fab4 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.10-snapshot.v958fab4 --save-exact

@clerk/shared

npm i @clerk/shared@2.2.2-snapshot.v958fab4 --save-exact

@clerk/testing

npm i @clerk/testing@1.1.6-snapshot.v958fab4 --save-exact

@clerk/themes

npm i @clerk/themes@2.1.9-snapshot.v958fab4 --save-exact

@clerk/types

npm i @clerk/types@4.6.0-snapshot.v958fab4 --save-exact

@nikosdouvlis

Copy link
Copy Markdown
MemberAuthor

Hi @nikosdouvlis, Hope you are having a good day. Is this PR related to fixing the issue where in NextJS, the protected page gets server reloaded once we press signout and hence clerk is not redirecting to the sign out route instead reloads the same route which redirects us to the signin page with the fallback of the current route?

Hello @joysamaddar , I hope you're having a great day as well :)
Even though I am not completely sure yet, as this fix was intended to solve a different issue, the underlying root cause does look like it's the same, so I'm fairly confident that this will resolve the issue you describe. That being said, more testing needs to be done on our end!

Would you mind sharing a GH issue that describes your problem in detail, if there is one? Happy to take a look.

@joysamaddar

joysamaddar commented Jun 8, 2024

Copy link
Copy Markdown

Hi @nikosdouvlis, Hope you are having a good day. Is this PR related to fixing the issue where in NextJS, the protected page gets server reloaded once we press signout and hence clerk is not redirecting to the sign out route instead reloads the same route which redirects us to the signin page with the fallback of the current route?

Hello @joysamaddar , I hope you're having a great day as well :) Even though I am not completely sure yet, as this fix was intended to solve a different issue, the underlying root cause does look like it's the same, so I'm fairly confident that this will resolve the issue you describe. That being said, more testing needs to be done on our end!

Would you mind sharing a GH issue that describes your problem in detail, if there is one? Happy to take a look.

Hello again,
I tried out the snapshot version of this PR and it seems this PR fixed the issue i described.
Do you still want me to make an issue for this? Happy to do so if it helps.

@nikosdouvlis
nikosdouvlis marked this pull request as ready for review June 11, 2024 07:41
Comment threadpackages/nextjs/src/app-router/client/ClerkProvider.tsx Outdated
@desiprisg
desiprisgforce-pushed the nikos/replace-router-refresh branch from ab98df2 to f17124aCompareJune 11, 2024 12:53
@nikosdouvlisnikosdouvlis self-assigned this Jun 11, 2024

@anagstefanagstef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@panteliselefpanteliselef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@desiprisgdesiprisg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on that conditional check

@nikosdouvlis
nikosdouvlis merged commit 8741003 into mainJun 11, 2024
@nikosdouvlis
nikosdouvlis deleted the nikos/replace-router-refresh branch June 11, 2024 14:55
This was referenced Jun 11, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@nikosdouvlis@joysamaddar@desiprisg@clerk-cookie@dimkl@anagstef@panteliselef
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(nextjs): Replace router.refresh() with cookies().delete() - #3518

Merged
nikosdouvlis merged 3 commits into
mainfrom
nikos/replace-router-refresh
Jun 11, 2024
Merged

fix(nextjs): Replace router.refresh() with cookies().delete()#3518
nikosdouvlis merged 3 commits into
mainfrom
nikos/replace-router-refresh

Conversation

@nikosdouvlis

@nikosdouvlisnikosdouvlis commented Jun 5, 2024

Copy link
Copy Markdown
Member

Description

In this PR we replace router.refresh with a server action that calls cookies().delete. According to the NextJS docs, using the cookies().delete API invalidates the FE client cache, similar to what router.refresh does.

The main difference between the two is that router.refresh will then attempt to fetch and re-mount the current page. This causes our components to unmount and mount again, losing state before setActive completes. This usually leads to navigation/redirect issues, issues completing oauth flows etc.

Caveat:
We can only use server action directly for next@14 and above, as server actions were an experimental feature in next@13.
For next@13 we still call router.refresh. Users that are on next@13 should upgrade to at least next@14 if they notice any of the issues described above.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented Jun 5, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: df967c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/nextjsPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LekoArts
LekoArts marked this pull request as draft June 6, 2024 09:42
@joysamaddar

joysamaddar commented Jun 7, 2024

Copy link
Copy Markdown

Hi @nikosdouvlis,
Hope you are having a good day.
Is this PR related to fixing the issue where in NextJS, the protected page gets server reloaded once we press signout and hence clerk is not redirecting to the sign out route instead reloads the same route which redirects us to the signin page with the fallback of the current route?

@desiprisg

Copy link
Copy Markdown
Contributor

!snapshot

@clerk-cookie

Copy link
Copy Markdown
Collaborator

Hey @desiprisg - the snapshot version command generated the following package versions:

PackageVersion
@clerk/backend1.2.2-snapshot.v958fab4
@clerk/chrome-extension1.0.17-snapshot.v958fab4
@clerk/clerk-js5.6.0-snapshot.v958fab4
@clerk/elements0.6.0-snapshot.v958fab4
@clerk/clerk-expo1.2.0-snapshot.v958fab4
@clerk/express0.0.11-snapshot.v958fab4
@clerk/fastify1.0.13-snapshot.v958fab4
gatsby-plugin-clerk5.0.0-beta.45
@clerk/localizations2.4.4-snapshot.v958fab4
@clerk/nextjs5.1.4-snapshot.v958fab4
@clerk/clerk-react5.2.3-snapshot.v958fab4
@clerk/remix4.1.0-snapshot.v958fab4
@clerk/clerk-sdk-node5.0.10-snapshot.v958fab4
@clerk/shared2.2.2-snapshot.v958fab4
@clerk/testing1.1.6-snapshot.v958fab4
@clerk/themes2.1.9-snapshot.v958fab4
@clerk/types4.6.0-snapshot.v958fab4

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend

npm i @clerk/backend@1.2.2-snapshot.v958fab4 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.0.17-snapshot.v958fab4 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.6.0-snapshot.v958fab4 --save-exact

@clerk/elements

npm i @clerk/elements@0.6.0-snapshot.v958fab4 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.2.0-snapshot.v958fab4 --save-exact

@clerk/express

npm i @clerk/express@0.0.11-snapshot.v958fab4 --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.13-snapshot.v958fab4 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.4.4-snapshot.v958fab4 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.1.4-snapshot.v958fab4 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.2.3-snapshot.v958fab4 --save-exact

@clerk/remix

npm i @clerk/remix@4.1.0-snapshot.v958fab4 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.10-snapshot.v958fab4 --save-exact

@clerk/shared

npm i @clerk/shared@2.2.2-snapshot.v958fab4 --save-exact

@clerk/testing

npm i @clerk/testing@1.1.6-snapshot.v958fab4 --save-exact

@clerk/themes

npm i @clerk/themes@2.1.9-snapshot.v958fab4 --save-exact

@clerk/types

npm i @clerk/types@4.6.0-snapshot.v958fab4 --save-exact

@nikosdouvlis

Copy link
Copy Markdown
MemberAuthor

Hi @nikosdouvlis, Hope you are having a good day. Is this PR related to fixing the issue where in NextJS, the protected page gets server reloaded once we press signout and hence clerk is not redirecting to the sign out route instead reloads the same route which redirects us to the signin page with the fallback of the current route?

Hello @joysamaddar , I hope you're having a great day as well :)
Even though I am not completely sure yet, as this fix was intended to solve a different issue, the underlying root cause does look like it's the same, so I'm fairly confident that this will resolve the issue you describe. That being said, more testing needs to be done on our end!

Would you mind sharing a GH issue that describes your problem in detail, if there is one? Happy to take a look.

@joysamaddar

joysamaddar commented Jun 8, 2024

Copy link
Copy Markdown

Hi @nikosdouvlis, Hope you are having a good day. Is this PR related to fixing the issue where in NextJS, the protected page gets server reloaded once we press signout and hence clerk is not redirecting to the sign out route instead reloads the same route which redirects us to the signin page with the fallback of the current route?

Hello @joysamaddar , I hope you're having a great day as well :) Even though I am not completely sure yet, as this fix was intended to solve a different issue, the underlying root cause does look like it's the same, so I'm fairly confident that this will resolve the issue you describe. That being said, more testing needs to be done on our end!

Would you mind sharing a GH issue that describes your problem in detail, if there is one? Happy to take a look.

Hello again,
I tried out the snapshot version of this PR and it seems this PR fixed the issue i described.
Do you still want me to make an issue for this? Happy to do so if it helps.

@nikosdouvlis
nikosdouvlis marked this pull request as ready for review June 11, 2024 07:41
Comment threadpackages/nextjs/src/app-router/client/ClerkProvider.tsx Outdated
@desiprisg
desiprisgforce-pushed the nikos/replace-router-refresh branch from ab98df2 to f17124aCompareJune 11, 2024 12:53
@nikosdouvlisnikosdouvlis self-assigned this Jun 11, 2024

@anagstefanagstef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@panteliselefpanteliselef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@desiprisgdesiprisg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on that conditional check

@nikosdouvlis
nikosdouvlis merged commit 8741003 into mainJun 11, 2024
@nikosdouvlis
nikosdouvlis deleted the nikos/replace-router-refresh branch June 11, 2024 14:55
This was referenced Jun 11, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@nikosdouvlis@joysamaddar@desiprisg@clerk-cookie@dimkl@anagstef@panteliselef
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(nextjs): Replace router.refresh() with cookies().delete() - #3518

Merged
nikosdouvlis merged 3 commits into
mainfrom
nikos/replace-router-refresh
Jun 11, 2024
Merged

fix(nextjs): Replace router.refresh() with cookies().delete()#3518
nikosdouvlis merged 3 commits into
mainfrom
nikos/replace-router-refresh

Conversation

@nikosdouvlis

@nikosdouvlisnikosdouvlis commented Jun 5, 2024

Copy link
Copy Markdown
Member

Description

In this PR we replace router.refresh with a server action that calls cookies().delete. According to the NextJS docs, using the cookies().delete API invalidates the FE client cache, similar to what router.refresh does.

The main difference between the two is that router.refresh will then attempt to fetch and re-mount the current page. This causes our components to unmount and mount again, losing state before setActive completes. This usually leads to navigation/redirect issues, issues completing oauth flows etc.

Caveat:
We can only use server action directly for next@14 and above, as server actions were an experimental feature in next@13.
For next@13 we still call router.refresh. Users that are on next@13 should upgrade to at least next@14 if they notice any of the issues described above.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented Jun 5, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: df967c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/nextjsPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LekoArts
LekoArts marked this pull request as draft June 6, 2024 09:42
@joysamaddar

joysamaddar commented Jun 7, 2024

Copy link
Copy Markdown

Hi @nikosdouvlis,
Hope you are having a good day.
Is this PR related to fixing the issue where in NextJS, the protected page gets server reloaded once we press signout and hence clerk is not redirecting to the sign out route instead reloads the same route which redirects us to the signin page with the fallback of the current route?

@desiprisg

Copy link
Copy Markdown
Contributor

!snapshot

@clerk-cookie

Copy link
Copy Markdown
Collaborator

Hey @desiprisg - the snapshot version command generated the following package versions:

PackageVersion
@clerk/backend1.2.2-snapshot.v958fab4
@clerk/chrome-extension1.0.17-snapshot.v958fab4
@clerk/clerk-js5.6.0-snapshot.v958fab4
@clerk/elements0.6.0-snapshot.v958fab4
@clerk/clerk-expo1.2.0-snapshot.v958fab4
@clerk/express0.0.11-snapshot.v958fab4
@clerk/fastify1.0.13-snapshot.v958fab4
gatsby-plugin-clerk5.0.0-beta.45
@clerk/localizations2.4.4-snapshot.v958fab4
@clerk/nextjs5.1.4-snapshot.v958fab4
@clerk/clerk-react5.2.3-snapshot.v958fab4
@clerk/remix4.1.0-snapshot.v958fab4
@clerk/clerk-sdk-node5.0.10-snapshot.v958fab4
@clerk/shared2.2.2-snapshot.v958fab4
@clerk/testing1.1.6-snapshot.v958fab4
@clerk/themes2.1.9-snapshot.v958fab4
@clerk/types4.6.0-snapshot.v958fab4

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend

npm i @clerk/backend@1.2.2-snapshot.v958fab4 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.0.17-snapshot.v958fab4 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.6.0-snapshot.v958fab4 --save-exact

@clerk/elements

npm i @clerk/elements@0.6.0-snapshot.v958fab4 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.2.0-snapshot.v958fab4 --save-exact

@clerk/express

npm i @clerk/express@0.0.11-snapshot.v958fab4 --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.13-snapshot.v958fab4 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.4.4-snapshot.v958fab4 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.1.4-snapshot.v958fab4 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.2.3-snapshot.v958fab4 --save-exact

@clerk/remix

npm i @clerk/remix@4.1.0-snapshot.v958fab4 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.10-snapshot.v958fab4 --save-exact

@clerk/shared

npm i @clerk/shared@2.2.2-snapshot.v958fab4 --save-exact

@clerk/testing

npm i @clerk/testing@1.1.6-snapshot.v958fab4 --save-exact

@clerk/themes

npm i @clerk/themes@2.1.9-snapshot.v958fab4 --save-exact

@clerk/types

npm i @clerk/types@4.6.0-snapshot.v958fab4 --save-exact

@nikosdouvlis

Copy link
Copy Markdown
MemberAuthor

Hi @nikosdouvlis, Hope you are having a good day. Is this PR related to fixing the issue where in NextJS, the protected page gets server reloaded once we press signout and hence clerk is not redirecting to the sign out route instead reloads the same route which redirects us to the signin page with the fallback of the current route?

Hello @joysamaddar , I hope you're having a great day as well :)
Even though I am not completely sure yet, as this fix was intended to solve a different issue, the underlying root cause does look like it's the same, so I'm fairly confident that this will resolve the issue you describe. That being said, more testing needs to be done on our end!

Would you mind sharing a GH issue that describes your problem in detail, if there is one? Happy to take a look.

@joysamaddar

joysamaddar commented Jun 8, 2024

Copy link
Copy Markdown

Hi @nikosdouvlis, Hope you are having a good day. Is this PR related to fixing the issue where in NextJS, the protected page gets server reloaded once we press signout and hence clerk is not redirecting to the sign out route instead reloads the same route which redirects us to the signin page with the fallback of the current route?

Hello @joysamaddar , I hope you're having a great day as well :) Even though I am not completely sure yet, as this fix was intended to solve a different issue, the underlying root cause does look like it's the same, so I'm fairly confident that this will resolve the issue you describe. That being said, more testing needs to be done on our end!

Would you mind sharing a GH issue that describes your problem in detail, if there is one? Happy to take a look.

Hello again,
I tried out the snapshot version of this PR and it seems this PR fixed the issue i described.
Do you still want me to make an issue for this? Happy to do so if it helps.

@nikosdouvlis
nikosdouvlis marked this pull request as ready for review June 11, 2024 07:41
Comment threadpackages/nextjs/src/app-router/client/ClerkProvider.tsx Outdated
@desiprisg
desiprisgforce-pushed the nikos/replace-router-refresh branch from ab98df2 to f17124aCompareJune 11, 2024 12:53
@nikosdouvlisnikosdouvlis self-assigned this Jun 11, 2024

@anagstefanagstef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@panteliselefpanteliselef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@desiprisgdesiprisg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on that conditional check

@nikosdouvlis
nikosdouvlis merged commit 8741003 into mainJun 11, 2024
@nikosdouvlis
nikosdouvlis deleted the nikos/replace-router-refresh branch June 11, 2024 14:55
This was referenced Jun 11, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@nikosdouvlis@joysamaddar@desiprisg@clerk-cookie@dimkl@anagstef@panteliselef
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(nextjs): Replace router.refresh() with cookies().delete() - #3518

Merged
nikosdouvlis merged 3 commits into
mainfrom
nikos/replace-router-refresh
Jun 11, 2024
Merged

fix(nextjs): Replace router.refresh() with cookies().delete()#3518
nikosdouvlis merged 3 commits into
mainfrom
nikos/replace-router-refresh

Conversation

@nikosdouvlis

@nikosdouvlisnikosdouvlis commented Jun 5, 2024

Copy link
Copy Markdown
Member

Description

In this PR we replace router.refresh with a server action that calls cookies().delete. According to the NextJS docs, using the cookies().delete API invalidates the FE client cache, similar to what router.refresh does.

The main difference between the two is that router.refresh will then attempt to fetch and re-mount the current page. This causes our components to unmount and mount again, losing state before setActive completes. This usually leads to navigation/redirect issues, issues completing oauth flows etc.

Caveat:
We can only use server action directly for next@14 and above, as server actions were an experimental feature in next@13.
For next@13 we still call router.refresh. Users that are on next@13 should upgrade to at least next@14 if they notice any of the issues described above.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented Jun 5, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: df967c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/nextjsPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LekoArts
LekoArts marked this pull request as draft June 6, 2024 09:42
@joysamaddar

joysamaddar commented Jun 7, 2024

Copy link
Copy Markdown

Hi @nikosdouvlis,
Hope you are having a good day.
Is this PR related to fixing the issue where in NextJS, the protected page gets server reloaded once we press signout and hence clerk is not redirecting to the sign out route instead reloads the same route which redirects us to the signin page with the fallback of the current route?

@desiprisg

Copy link
Copy Markdown
Contributor

!snapshot

@clerk-cookie

Copy link
Copy Markdown
Collaborator

Hey @desiprisg - the snapshot version command generated the following package versions:

PackageVersion
@clerk/backend1.2.2-snapshot.v958fab4
@clerk/chrome-extension1.0.17-snapshot.v958fab4
@clerk/clerk-js5.6.0-snapshot.v958fab4
@clerk/elements0.6.0-snapshot.v958fab4
@clerk/clerk-expo1.2.0-snapshot.v958fab4
@clerk/express0.0.11-snapshot.v958fab4
@clerk/fastify1.0.13-snapshot.v958fab4
gatsby-plugin-clerk5.0.0-beta.45
@clerk/localizations2.4.4-snapshot.v958fab4
@clerk/nextjs5.1.4-snapshot.v958fab4
@clerk/clerk-react5.2.3-snapshot.v958fab4
@clerk/remix4.1.0-snapshot.v958fab4
@clerk/clerk-sdk-node5.0.10-snapshot.v958fab4
@clerk/shared2.2.2-snapshot.v958fab4
@clerk/testing1.1.6-snapshot.v958fab4
@clerk/themes2.1.9-snapshot.v958fab4
@clerk/types4.6.0-snapshot.v958fab4

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend

npm i @clerk/backend@1.2.2-snapshot.v958fab4 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.0.17-snapshot.v958fab4 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.6.0-snapshot.v958fab4 --save-exact

@clerk/elements

npm i @clerk/elements@0.6.0-snapshot.v958fab4 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.2.0-snapshot.v958fab4 --save-exact

@clerk/express

npm i @clerk/express@0.0.11-snapshot.v958fab4 --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.13-snapshot.v958fab4 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.4.4-snapshot.v958fab4 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.1.4-snapshot.v958fab4 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.2.3-snapshot.v958fab4 --save-exact

@clerk/remix

npm i @clerk/remix@4.1.0-snapshot.v958fab4 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.10-snapshot.v958fab4 --save-exact

@clerk/shared

npm i @clerk/shared@2.2.2-snapshot.v958fab4 --save-exact

@clerk/testing

npm i @clerk/testing@1.1.6-snapshot.v958fab4 --save-exact

@clerk/themes

npm i @clerk/themes@2.1.9-snapshot.v958fab4 --save-exact

@clerk/types

npm i @clerk/types@4.6.0-snapshot.v958fab4 --save-exact

@nikosdouvlis

Copy link
Copy Markdown
MemberAuthor

Hi @nikosdouvlis, Hope you are having a good day. Is this PR related to fixing the issue where in NextJS, the protected page gets server reloaded once we press signout and hence clerk is not redirecting to the sign out route instead reloads the same route which redirects us to the signin page with the fallback of the current route?

Hello @joysamaddar , I hope you're having a great day as well :)
Even though I am not completely sure yet, as this fix was intended to solve a different issue, the underlying root cause does look like it's the same, so I'm fairly confident that this will resolve the issue you describe. That being said, more testing needs to be done on our end!

Would you mind sharing a GH issue that describes your problem in detail, if there is one? Happy to take a look.

@joysamaddar

joysamaddar commented Jun 8, 2024

Copy link
Copy Markdown

Hi @nikosdouvlis, Hope you are having a good day. Is this PR related to fixing the issue where in NextJS, the protected page gets server reloaded once we press signout and hence clerk is not redirecting to the sign out route instead reloads the same route which redirects us to the signin page with the fallback of the current route?

Hello @joysamaddar , I hope you're having a great day as well :) Even though I am not completely sure yet, as this fix was intended to solve a different issue, the underlying root cause does look like it's the same, so I'm fairly confident that this will resolve the issue you describe. That being said, more testing needs to be done on our end!

Would you mind sharing a GH issue that describes your problem in detail, if there is one? Happy to take a look.

Hello again,
I tried out the snapshot version of this PR and it seems this PR fixed the issue i described.
Do you still want me to make an issue for this? Happy to do so if it helps.

@nikosdouvlis
nikosdouvlis marked this pull request as ready for review June 11, 2024 07:41
Comment threadpackages/nextjs/src/app-router/client/ClerkProvider.tsx Outdated
@desiprisg
desiprisgforce-pushed the nikos/replace-router-refresh branch from ab98df2 to f17124aCompareJune 11, 2024 12:53
@nikosdouvlisnikosdouvlis self-assigned this Jun 11, 2024

@anagstefanagstef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@panteliselefpanteliselef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@desiprisgdesiprisg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on that conditional check

@nikosdouvlis
nikosdouvlis merged commit 8741003 into mainJun 11, 2024
@nikosdouvlis
nikosdouvlis deleted the nikos/replace-router-refresh branch June 11, 2024 14:55
This was referenced Jun 11, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@nikosdouvlis@joysamaddar@desiprisg@clerk-cookie@dimkl@anagstef@panteliselef
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(nextjs): Replace router.refresh() with cookies().delete() - #3518

Merged
nikosdouvlis merged 3 commits into
mainfrom
nikos/replace-router-refresh
Jun 11, 2024
Merged

fix(nextjs): Replace router.refresh() with cookies().delete()#3518
nikosdouvlis merged 3 commits into
mainfrom
nikos/replace-router-refresh

Conversation

@nikosdouvlis

@nikosdouvlisnikosdouvlis commented Jun 5, 2024

Copy link
Copy Markdown
Member

Description

In this PR we replace router.refresh with a server action that calls cookies().delete. According to the NextJS docs, using the cookies().delete API invalidates the FE client cache, similar to what router.refresh does.

The main difference between the two is that router.refresh will then attempt to fetch and re-mount the current page. This causes our components to unmount and mount again, losing state before setActive completes. This usually leads to navigation/redirect issues, issues completing oauth flows etc.

Caveat:
We can only use server action directly for next@14 and above, as server actions were an experimental feature in next@13.
For next@13 we still call router.refresh. Users that are on next@13 should upgrade to at least next@14 if they notice any of the issues described above.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented Jun 5, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: df967c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/nextjsPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LekoArts
LekoArts marked this pull request as draft June 6, 2024 09:42
@joysamaddar

joysamaddar commented Jun 7, 2024

Copy link
Copy Markdown

Hi @nikosdouvlis,
Hope you are having a good day.
Is this PR related to fixing the issue where in NextJS, the protected page gets server reloaded once we press signout and hence clerk is not redirecting to the sign out route instead reloads the same route which redirects us to the signin page with the fallback of the current route?

@desiprisg

Copy link
Copy Markdown
Contributor

!snapshot

@clerk-cookie

Copy link
Copy Markdown
Collaborator

Hey @desiprisg - the snapshot version command generated the following package versions:

PackageVersion
@clerk/backend1.2.2-snapshot.v958fab4
@clerk/chrome-extension1.0.17-snapshot.v958fab4
@clerk/clerk-js5.6.0-snapshot.v958fab4
@clerk/elements0.6.0-snapshot.v958fab4
@clerk/clerk-expo1.2.0-snapshot.v958fab4
@clerk/express0.0.11-snapshot.v958fab4
@clerk/fastify1.0.13-snapshot.v958fab4
gatsby-plugin-clerk5.0.0-beta.45
@clerk/localizations2.4.4-snapshot.v958fab4
@clerk/nextjs5.1.4-snapshot.v958fab4
@clerk/clerk-react5.2.3-snapshot.v958fab4
@clerk/remix4.1.0-snapshot.v958fab4
@clerk/clerk-sdk-node5.0.10-snapshot.v958fab4
@clerk/shared2.2.2-snapshot.v958fab4
@clerk/testing1.1.6-snapshot.v958fab4
@clerk/themes2.1.9-snapshot.v958fab4
@clerk/types4.6.0-snapshot.v958fab4

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend

npm i @clerk/backend@1.2.2-snapshot.v958fab4 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.0.17-snapshot.v958fab4 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.6.0-snapshot.v958fab4 --save-exact

@clerk/elements

npm i @clerk/elements@0.6.0-snapshot.v958fab4 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.2.0-snapshot.v958fab4 --save-exact

@clerk/express

npm i @clerk/express@0.0.11-snapshot.v958fab4 --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.13-snapshot.v958fab4 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.4.4-snapshot.v958fab4 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.1.4-snapshot.v958fab4 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.2.3-snapshot.v958fab4 --save-exact

@clerk/remix

npm i @clerk/remix@4.1.0-snapshot.v958fab4 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.10-snapshot.v958fab4 --save-exact

@clerk/shared

npm i @clerk/shared@2.2.2-snapshot.v958fab4 --save-exact

@clerk/testing

npm i @clerk/testing@1.1.6-snapshot.v958fab4 --save-exact

@clerk/themes

npm i @clerk/themes@2.1.9-snapshot.v958fab4 --save-exact

@clerk/types

npm i @clerk/types@4.6.0-snapshot.v958fab4 --save-exact

@nikosdouvlis

Copy link
Copy Markdown
MemberAuthor

Hi @nikosdouvlis, Hope you are having a good day. Is this PR related to fixing the issue where in NextJS, the protected page gets server reloaded once we press signout and hence clerk is not redirecting to the sign out route instead reloads the same route which redirects us to the signin page with the fallback of the current route?

Hello @joysamaddar , I hope you're having a great day as well :)
Even though I am not completely sure yet, as this fix was intended to solve a different issue, the underlying root cause does look like it's the same, so I'm fairly confident that this will resolve the issue you describe. That being said, more testing needs to be done on our end!

Would you mind sharing a GH issue that describes your problem in detail, if there is one? Happy to take a look.

@joysamaddar

joysamaddar commented Jun 8, 2024

Copy link
Copy Markdown

Hi @nikosdouvlis, Hope you are having a good day. Is this PR related to fixing the issue where in NextJS, the protected page gets server reloaded once we press signout and hence clerk is not redirecting to the sign out route instead reloads the same route which redirects us to the signin page with the fallback of the current route?

Hello @joysamaddar , I hope you're having a great day as well :) Even though I am not completely sure yet, as this fix was intended to solve a different issue, the underlying root cause does look like it's the same, so I'm fairly confident that this will resolve the issue you describe. That being said, more testing needs to be done on our end!

Would you mind sharing a GH issue that describes your problem in detail, if there is one? Happy to take a look.

Hello again,
I tried out the snapshot version of this PR and it seems this PR fixed the issue i described.
Do you still want me to make an issue for this? Happy to do so if it helps.

@nikosdouvlis
nikosdouvlis marked this pull request as ready for review June 11, 2024 07:41
Comment threadpackages/nextjs/src/app-router/client/ClerkProvider.tsx Outdated
@desiprisg
desiprisgforce-pushed the nikos/replace-router-refresh branch from ab98df2 to f17124aCompareJune 11, 2024 12:53
@nikosdouvlisnikosdouvlis self-assigned this Jun 11, 2024

@anagstefanagstef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@panteliselefpanteliselef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@desiprisgdesiprisg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on that conditional check

@nikosdouvlis
nikosdouvlis merged commit 8741003 into mainJun 11, 2024
@nikosdouvlis
nikosdouvlis deleted the nikos/replace-router-refresh branch June 11, 2024 14:55
This was referenced Jun 11, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@nikosdouvlis@joysamaddar@desiprisg@clerk-cookie@dimkl@anagstef@panteliselef