feat(astro): Introduce Astro SDK by panteliselef · Pull Request #3646 · clerk/javascript

panteliselef · 2024-07-01T12:16:14Z

Description

This PR is tackling ECO-6 and ports the original code from astro-clerk-auth inside this monorepo as a new package called @clerk/astro.

@clerk/astro will become the official Astro SDK from Clerk.

While porting the original code the following things happened

Hotload is now the default method of loading clerk-js on the client.
Dropped the deprecated internal stores, now the stores are only available from /client/stores.
Dropped the /v0 module
Dropped the exported clerkClient as a variable, now you need to call clerkClient(context) and pass the astro context.

In follow up PRs, we will introduce a playground application for Astro, and e2e tests for the node runtime

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-07-01T12:16:17Z

🦋 Changeset detected

Latest commit: 1d11827

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wobsoriano

@panteliselef and I reviewed this code last week, and the changes look good to me.

I've left a few suggestions for improvement.

brkalow

A self-review would be helpful here given the size of the PR and most folks unfamiliarity with some of the more Astro-specific logic.

brkalow · 2024-07-02T17:02:16Z

+const isUnauthorized =
+ !userId ||
+ (typeof Astro.props.condition === "function" &&
+ !Astro.props.condition(has)) ||
+ ((Astro.props.role || Astro.props.permission) && !has(Astro.props));


nit: What do you think about reversing the logic here? isAuthorized feels clearer than isUnauthorized (default to unauthorized in the logic).

Agree, that this is hard to grok

That's a fair point, I will added it as a todo if that's ok

brkalow · 2024-07-02T17:08:53Z

+import { $clerk, $csrState, $initialState } from './internal';
+import { deriveState } from './utils';
+
+export const $authStore = computed([$csrState, $initialState], (state, initialState) => {


Is this part of the public API? If so, can we add a JSDoc comment?

Yes it is, i will add them

brkalow · 2024-07-02T17:27:36Z

+ ),
+ );
+
+ if (__HOTLOAD__) {


❓ why are we providing hotloading as an option?

So in the community sdk, hotloading was opt-in, now it is opt-out, but we are still allowing devs to use the astro integration with clerk-js as a direct dependency bundled with the rest of the app.

brkalow · 2024-07-02T17:29:05Z

+ // When the auth status is set, we trust that the middleware has already run
+ // Then, we don't have to re-verify the JWT here,
+ // we can just strip out the claims manually.
+ const authToken = locals.authToken || getAuthKeyFromRequest(req, 'AuthToken');


how does Astro middleware work? Does it run in the same process as the app server itself, or is it like Next where it runs somewhere else? Do we need to worry about the validity of the token here or are we safe to assume it is the token we previously verified in the middleware?

It runs on the same machine, where SSR takes place. Astro supports deployment to vercel where you can choose to use the edge middleware, but we are kind of blocking that because our middleware is using an AsyncLocalStorage

brkalow · 2024-07-02T17:34:38Z

+import { createIntegration } from './create-integration';
+
+export default createIntegration({
+ mode: 'hotload',


is this overridable by the user? If yes, why?

A developer cannot manipulate this code, or call createIntegration explictly.
what the can do though is import the clerk integration from @clerk/astro/bunlded instead of @clerk/astro
The default export of @clerk/astro uses the clerk integration with hotloading.

Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>

anagstef

🚀 ⭐

LekoArts

First pass

LekoArts · 2024-07-03T13:38:21Z

+ "astro": "^3.2.0 || ^4.0.0"
+ },
+ "engines": {
+ "node": ">=18.17.0"


The README says that Node 20 is required?

I had it original to node 20, but because our ci runs with v18 i had to update it. No worries i've checked the Astro minimum node version and this is compatible, also the API for AsyncLocalStorage that we are using has been stable for many versions prior to v18.

LekoArts · 2024-07-03T13:39:33Z

+const isUnauthorized =
+ !userId ||
+ (typeof Astro.props.condition === "function" &&
+ !Astro.props.condition(has)) ||
+ ((Astro.props.role || Astro.props.permission) && !has(Astro.props));


Agree, that this is hard to grok

LekoArts · 2024-07-03T13:42:23Z

+<div id={`clerk-organization-list-${safeId}`}></div>
+
+<script is:inline define:vars={{ props: Astro.props, safeId }}>


The safeId and setOrCreatePropMap are repeated in multiple Astro components. Can we consolidate that into shared utils?

We will resolve this in a follow up PR, i've documented it

LekoArts · 2024-07-03T13:45:24Z

+ hooks: {
+ 'astro:config:setup': ({ config, injectScript, updateConfig, logger, command }) => {
+ if (config.output === 'static') {
+ logger.error(`${packageName} requires SSR to be turned on. Please update output to "server"`);


Why is SSR required? Can't it also work with CSR?

Currently we support only SSR, because we are injecting the clerk-js script from the middleware. But i will add a ticket in order to explore this.

panteliselef · 2024-07-01T12:16:14Z

Description

This PR is tackling ECO-6 and ports the original code from astro-clerk-auth inside this monorepo as a new package called @clerk/astro.

@clerk/astro will become the official Astro SDK from Clerk.

While porting the original code the following things happened

Hotload is now the default method of loading clerk-js on the client.
Dropped the deprecated internal stores, now the stores are only available from /client/stores.
Dropped the /v0 module
Dropped the exported clerkClient as a variable, now you need to call clerkClient(context) and pass the astro context.

In follow up PRs, we will introduce a playground application for Astro, and e2e tests for the node runtime

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-07-01T12:16:17Z

🦋 Changeset detected

Latest commit: 1d11827

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wobsoriano

@panteliselef and I reviewed this code last week, and the changes look good to me.

I've left a few suggestions for improvement.

brkalow

A self-review would be helpful here given the size of the PR and most folks unfamiliarity with some of the more Astro-specific logic.

brkalow · 2024-07-02T17:02:16Z

+const isUnauthorized =
+ !userId ||
+ (typeof Astro.props.condition === "function" &&
+ !Astro.props.condition(has)) ||
+ ((Astro.props.role || Astro.props.permission) && !has(Astro.props));


nit: What do you think about reversing the logic here? isAuthorized feels clearer than isUnauthorized (default to unauthorized in the logic).

Agree, that this is hard to grok

That's a fair point, I will added it as a todo if that's ok

brkalow · 2024-07-02T17:08:53Z

+import { $clerk, $csrState, $initialState } from './internal';
+import { deriveState } from './utils';
+
+export const $authStore = computed([$csrState, $initialState], (state, initialState) => {


Is this part of the public API? If so, can we add a JSDoc comment?

Yes it is, i will add them

brkalow · 2024-07-02T17:27:36Z

+ ),
+ );
+
+ if (__HOTLOAD__) {


❓ why are we providing hotloading as an option?

So in the community sdk, hotloading was opt-in, now it is opt-out, but we are still allowing devs to use the astro integration with clerk-js as a direct dependency bundled with the rest of the app.

brkalow · 2024-07-02T17:29:05Z

+ // When the auth status is set, we trust that the middleware has already run
+ // Then, we don't have to re-verify the JWT here,
+ // we can just strip out the claims manually.
+ const authToken = locals.authToken || getAuthKeyFromRequest(req, 'AuthToken');


how does Astro middleware work? Does it run in the same process as the app server itself, or is it like Next where it runs somewhere else? Do we need to worry about the validity of the token here or are we safe to assume it is the token we previously verified in the middleware?

It runs on the same machine, where SSR takes place. Astro supports deployment to vercel where you can choose to use the edge middleware, but we are kind of blocking that because our middleware is using an AsyncLocalStorage

brkalow · 2024-07-02T17:34:38Z

+import { createIntegration } from './create-integration';
+
+export default createIntegration({
+ mode: 'hotload',


is this overridable by the user? If yes, why?

A developer cannot manipulate this code, or call createIntegration explictly.
what the can do though is import the clerk integration from @clerk/astro/bunlded instead of @clerk/astro
The default export of @clerk/astro uses the clerk integration with hotloading.

Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>

anagstef

🚀 ⭐

LekoArts

First pass

LekoArts · 2024-07-03T13:38:21Z

+ "astro": "^3.2.0 || ^4.0.0"
+ },
+ "engines": {
+ "node": ">=18.17.0"


The README says that Node 20 is required?

I had it original to node 20, but because our ci runs with v18 i had to update it. No worries i've checked the Astro minimum node version and this is compatible, also the API for AsyncLocalStorage that we are using has been stable for many versions prior to v18.

LekoArts · 2024-07-03T13:39:33Z

+const isUnauthorized =
+ !userId ||
+ (typeof Astro.props.condition === "function" &&
+ !Astro.props.condition(has)) ||
+ ((Astro.props.role || Astro.props.permission) && !has(Astro.props));


Agree, that this is hard to grok

LekoArts · 2024-07-03T13:42:23Z

+<div id={`clerk-organization-list-${safeId}`}></div>
+
+<script is:inline define:vars={{ props: Astro.props, safeId }}>


The safeId and setOrCreatePropMap are repeated in multiple Astro components. Can we consolidate that into shared utils?

We will resolve this in a follow up PR, i've documented it

LekoArts · 2024-07-03T13:45:24Z

+ hooks: {
+ 'astro:config:setup': ({ config, injectScript, updateConfig, logger, command }) => {
+ if (config.output === 'static') {
+ logger.error(`${packageName} requires SSR to be turned on. Please update output to "server"`);


Why is SSR required? Can't it also work with CSR?

Currently we support only SSR, because we are injecting the clerk-js script from the middleware. But i will add a ticket in order to explore this.

panteliselef · 2024-07-01T12:16:14Z

Description

This PR is tackling ECO-6 and ports the original code from astro-clerk-auth inside this monorepo as a new package called @clerk/astro.

@clerk/astro will become the official Astro SDK from Clerk.

While porting the original code the following things happened

Hotload is now the default method of loading clerk-js on the client.
Dropped the deprecated internal stores, now the stores are only available from /client/stores.
Dropped the /v0 module
Dropped the exported clerkClient as a variable, now you need to call clerkClient(context) and pass the astro context.

In follow up PRs, we will introduce a playground application for Astro, and e2e tests for the node runtime

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-07-01T12:16:17Z

🦋 Changeset detected

Latest commit: 1d11827

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wobsoriano

@panteliselef and I reviewed this code last week, and the changes look good to me.

I've left a few suggestions for improvement.

brkalow

A self-review would be helpful here given the size of the PR and most folks unfamiliarity with some of the more Astro-specific logic.

brkalow · 2024-07-02T17:02:16Z

+const isUnauthorized =
+ !userId ||
+ (typeof Astro.props.condition === "function" &&
+ !Astro.props.condition(has)) ||
+ ((Astro.props.role || Astro.props.permission) && !has(Astro.props));


nit: What do you think about reversing the logic here? isAuthorized feels clearer than isUnauthorized (default to unauthorized in the logic).

Agree, that this is hard to grok

That's a fair point, I will added it as a todo if that's ok

brkalow · 2024-07-02T17:08:53Z

+import { $clerk, $csrState, $initialState } from './internal';
+import { deriveState } from './utils';
+
+export const $authStore = computed([$csrState, $initialState], (state, initialState) => {


Is this part of the public API? If so, can we add a JSDoc comment?

Yes it is, i will add them

brkalow · 2024-07-02T17:27:36Z

+ ),
+ );
+
+ if (__HOTLOAD__) {


❓ why are we providing hotloading as an option?

So in the community sdk, hotloading was opt-in, now it is opt-out, but we are still allowing devs to use the astro integration with clerk-js as a direct dependency bundled with the rest of the app.

brkalow · 2024-07-02T17:29:05Z

+ // When the auth status is set, we trust that the middleware has already run
+ // Then, we don't have to re-verify the JWT here,
+ // we can just strip out the claims manually.
+ const authToken = locals.authToken || getAuthKeyFromRequest(req, 'AuthToken');


how does Astro middleware work? Does it run in the same process as the app server itself, or is it like Next where it runs somewhere else? Do we need to worry about the validity of the token here or are we safe to assume it is the token we previously verified in the middleware?

It runs on the same machine, where SSR takes place. Astro supports deployment to vercel where you can choose to use the edge middleware, but we are kind of blocking that because our middleware is using an AsyncLocalStorage

brkalow · 2024-07-02T17:34:38Z

+import { createIntegration } from './create-integration';
+
+export default createIntegration({
+ mode: 'hotload',


is this overridable by the user? If yes, why?

A developer cannot manipulate this code, or call createIntegration explictly.
what the can do though is import the clerk integration from @clerk/astro/bunlded instead of @clerk/astro
The default export of @clerk/astro uses the clerk integration with hotloading.

Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>

anagstef

🚀 ⭐

LekoArts

First pass

LekoArts · 2024-07-03T13:38:21Z

+ "astro": "^3.2.0 || ^4.0.0"
+ },
+ "engines": {
+ "node": ">=18.17.0"


The README says that Node 20 is required?

I had it original to node 20, but because our ci runs with v18 i had to update it. No worries i've checked the Astro minimum node version and this is compatible, also the API for AsyncLocalStorage that we are using has been stable for many versions prior to v18.

LekoArts · 2024-07-03T13:39:33Z

+const isUnauthorized =
+ !userId ||
+ (typeof Astro.props.condition === "function" &&
+ !Astro.props.condition(has)) ||
+ ((Astro.props.role || Astro.props.permission) && !has(Astro.props));


Agree, that this is hard to grok

LekoArts · 2024-07-03T13:42:23Z

+<div id={`clerk-organization-list-${safeId}`}></div>
+
+<script is:inline define:vars={{ props: Astro.props, safeId }}>


The safeId and setOrCreatePropMap are repeated in multiple Astro components. Can we consolidate that into shared utils?

We will resolve this in a follow up PR, i've documented it

LekoArts · 2024-07-03T13:45:24Z

+ hooks: {
+ 'astro:config:setup': ({ config, injectScript, updateConfig, logger, command }) => {
+ if (config.output === 'static') {
+ logger.error(`${packageName} requires SSR to be turned on. Please update output to "server"`);


Why is SSR required? Can't it also work with CSR?

Currently we support only SSR, because we are injecting the clerk-js script from the middleware. But i will add a ticket in order to explore this.

panteliselef · 2024-07-01T12:16:14Z

Description

This PR is tackling ECO-6 and ports the original code from astro-clerk-auth inside this monorepo as a new package called @clerk/astro.

@clerk/astro will become the official Astro SDK from Clerk.

While porting the original code the following things happened

Hotload is now the default method of loading clerk-js on the client.
Dropped the deprecated internal stores, now the stores are only available from /client/stores.
Dropped the /v0 module
Dropped the exported clerkClient as a variable, now you need to call clerkClient(context) and pass the astro context.

In follow up PRs, we will introduce a playground application for Astro, and e2e tests for the node runtime

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-07-01T12:16:17Z

🦋 Changeset detected

Latest commit: 1d11827

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wobsoriano

@panteliselef and I reviewed this code last week, and the changes look good to me.

I've left a few suggestions for improvement.

brkalow

A self-review would be helpful here given the size of the PR and most folks unfamiliarity with some of the more Astro-specific logic.

brkalow · 2024-07-02T17:02:16Z

+const isUnauthorized =
+ !userId ||
+ (typeof Astro.props.condition === "function" &&
+ !Astro.props.condition(has)) ||
+ ((Astro.props.role || Astro.props.permission) && !has(Astro.props));


nit: What do you think about reversing the logic here? isAuthorized feels clearer than isUnauthorized (default to unauthorized in the logic).

Agree, that this is hard to grok

That's a fair point, I will added it as a todo if that's ok

brkalow · 2024-07-02T17:08:53Z

+import { $clerk, $csrState, $initialState } from './internal';
+import { deriveState } from './utils';
+
+export const $authStore = computed([$csrState, $initialState], (state, initialState) => {


Is this part of the public API? If so, can we add a JSDoc comment?

Yes it is, i will add them

brkalow · 2024-07-02T17:27:36Z

+ ),
+ );
+
+ if (__HOTLOAD__) {


❓ why are we providing hotloading as an option?

So in the community sdk, hotloading was opt-in, now it is opt-out, but we are still allowing devs to use the astro integration with clerk-js as a direct dependency bundled with the rest of the app.

brkalow · 2024-07-02T17:29:05Z

+ // When the auth status is set, we trust that the middleware has already run
+ // Then, we don't have to re-verify the JWT here,
+ // we can just strip out the claims manually.
+ const authToken = locals.authToken || getAuthKeyFromRequest(req, 'AuthToken');


how does Astro middleware work? Does it run in the same process as the app server itself, or is it like Next where it runs somewhere else? Do we need to worry about the validity of the token here or are we safe to assume it is the token we previously verified in the middleware?

It runs on the same machine, where SSR takes place. Astro supports deployment to vercel where you can choose to use the edge middleware, but we are kind of blocking that because our middleware is using an AsyncLocalStorage

brkalow · 2024-07-02T17:34:38Z

+import { createIntegration } from './create-integration';
+
+export default createIntegration({
+ mode: 'hotload',


is this overridable by the user? If yes, why?

A developer cannot manipulate this code, or call createIntegration explictly.
what the can do though is import the clerk integration from @clerk/astro/bunlded instead of @clerk/astro
The default export of @clerk/astro uses the clerk integration with hotloading.

Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>

anagstef

🚀 ⭐

LekoArts

First pass

LekoArts · 2024-07-03T13:38:21Z

+ "astro": "^3.2.0 || ^4.0.0"
+ },
+ "engines": {
+ "node": ">=18.17.0"


The README says that Node 20 is required?

I had it original to node 20, but because our ci runs with v18 i had to update it. No worries i've checked the Astro minimum node version and this is compatible, also the API for AsyncLocalStorage that we are using has been stable for many versions prior to v18.

LekoArts · 2024-07-03T13:39:33Z

+const isUnauthorized =
+ !userId ||
+ (typeof Astro.props.condition === "function" &&
+ !Astro.props.condition(has)) ||
+ ((Astro.props.role || Astro.props.permission) && !has(Astro.props));


Agree, that this is hard to grok

LekoArts · 2024-07-03T13:42:23Z

+<div id={`clerk-organization-list-${safeId}`}></div>
+
+<script is:inline define:vars={{ props: Astro.props, safeId }}>


The safeId and setOrCreatePropMap are repeated in multiple Astro components. Can we consolidate that into shared utils?

We will resolve this in a follow up PR, i've documented it

LekoArts · 2024-07-03T13:45:24Z

+ hooks: {
+ 'astro:config:setup': ({ config, injectScript, updateConfig, logger, command }) => {
+ if (config.output === 'static') {
+ logger.error(`${packageName} requires SSR to be turned on. Please update output to "server"`);


Why is SSR required? Can't it also work with CSR?

Currently we support only SSR, because we are injecting the clerk-js script from the middleware. But i will add a ticket in order to explore this.

panteliselef · 2024-07-01T12:16:14Z

Description

This PR is tackling ECO-6 and ports the original code from astro-clerk-auth inside this monorepo as a new package called @clerk/astro.

@clerk/astro will become the official Astro SDK from Clerk.

While porting the original code the following things happened

Hotload is now the default method of loading clerk-js on the client.
Dropped the deprecated internal stores, now the stores are only available from /client/stores.
Dropped the /v0 module
Dropped the exported clerkClient as a variable, now you need to call clerkClient(context) and pass the astro context.

In follow up PRs, we will introduce a playground application for Astro, and e2e tests for the node runtime

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-07-01T12:16:17Z

🦋 Changeset detected

Latest commit: 1d11827

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wobsoriano

@panteliselef and I reviewed this code last week, and the changes look good to me.

I've left a few suggestions for improvement.

brkalow

A self-review would be helpful here given the size of the PR and most folks unfamiliarity with some of the more Astro-specific logic.

brkalow · 2024-07-02T17:02:16Z

+const isUnauthorized =
+ !userId ||
+ (typeof Astro.props.condition === "function" &&
+ !Astro.props.condition(has)) ||
+ ((Astro.props.role || Astro.props.permission) && !has(Astro.props));


nit: What do you think about reversing the logic here? isAuthorized feels clearer than isUnauthorized (default to unauthorized in the logic).

Agree, that this is hard to grok

That's a fair point, I will added it as a todo if that's ok

brkalow · 2024-07-02T17:08:53Z

+import { $clerk, $csrState, $initialState } from './internal';
+import { deriveState } from './utils';
+
+export const $authStore = computed([$csrState, $initialState], (state, initialState) => {


Is this part of the public API? If so, can we add a JSDoc comment?

Yes it is, i will add them

brkalow · 2024-07-02T17:27:36Z

+ ),
+ );
+
+ if (__HOTLOAD__) {


❓ why are we providing hotloading as an option?

So in the community sdk, hotloading was opt-in, now it is opt-out, but we are still allowing devs to use the astro integration with clerk-js as a direct dependency bundled with the rest of the app.

brkalow · 2024-07-02T17:29:05Z

+ // When the auth status is set, we trust that the middleware has already run
+ // Then, we don't have to re-verify the JWT here,
+ // we can just strip out the claims manually.
+ const authToken = locals.authToken || getAuthKeyFromRequest(req, 'AuthToken');


how does Astro middleware work? Does it run in the same process as the app server itself, or is it like Next where it runs somewhere else? Do we need to worry about the validity of the token here or are we safe to assume it is the token we previously verified in the middleware?

It runs on the same machine, where SSR takes place. Astro supports deployment to vercel where you can choose to use the edge middleware, but we are kind of blocking that because our middleware is using an AsyncLocalStorage

brkalow · 2024-07-02T17:34:38Z

+import { createIntegration } from './create-integration';
+
+export default createIntegration({
+ mode: 'hotload',


is this overridable by the user? If yes, why?

A developer cannot manipulate this code, or call createIntegration explictly.
what the can do though is import the clerk integration from @clerk/astro/bunlded instead of @clerk/astro
The default export of @clerk/astro uses the clerk integration with hotloading.

Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>

anagstef

🚀 ⭐

LekoArts

First pass

LekoArts · 2024-07-03T13:38:21Z

+ "astro": "^3.2.0 || ^4.0.0"
+ },
+ "engines": {
+ "node": ">=18.17.0"


The README says that Node 20 is required?

I had it original to node 20, but because our ci runs with v18 i had to update it. No worries i've checked the Astro minimum node version and this is compatible, also the API for AsyncLocalStorage that we are using has been stable for many versions prior to v18.

LekoArts · 2024-07-03T13:39:33Z

+const isUnauthorized =
+ !userId ||
+ (typeof Astro.props.condition === "function" &&
+ !Astro.props.condition(has)) ||
+ ((Astro.props.role || Astro.props.permission) && !has(Astro.props));


Agree, that this is hard to grok

LekoArts · 2024-07-03T13:42:23Z

+<div id={`clerk-organization-list-${safeId}`}></div>
+
+<script is:inline define:vars={{ props: Astro.props, safeId }}>


The safeId and setOrCreatePropMap are repeated in multiple Astro components. Can we consolidate that into shared utils?

We will resolve this in a follow up PR, i've documented it

LekoArts · 2024-07-03T13:45:24Z

+ hooks: {
+ 'astro:config:setup': ({ config, injectScript, updateConfig, logger, command }) => {
+ if (config.output === 'static') {
+ logger.error(`${packageName} requires SSR to be turned on. Please update output to "server"`);


Why is SSR required? Can't it also work with CSR?

Currently we support only SSR, because we are injecting the clerk-js script from the middleware. But i will add a ticket in order to explore this.

panteliselef · 2024-07-01T12:16:14Z

Description

This PR is tackling ECO-6 and ports the original code from astro-clerk-auth inside this monorepo as a new package called @clerk/astro.

@clerk/astro will become the official Astro SDK from Clerk.

While porting the original code the following things happened

Hotload is now the default method of loading clerk-js on the client.
Dropped the deprecated internal stores, now the stores are only available from /client/stores.
Dropped the /v0 module
Dropped the exported clerkClient as a variable, now you need to call clerkClient(context) and pass the astro context.

In follow up PRs, we will introduce a playground application for Astro, and e2e tests for the node runtime

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-07-01T12:16:17Z

🦋 Changeset detected

Latest commit: 1d11827

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wobsoriano

@panteliselef and I reviewed this code last week, and the changes look good to me.

I've left a few suggestions for improvement.

brkalow

A self-review would be helpful here given the size of the PR and most folks unfamiliarity with some of the more Astro-specific logic.

brkalow · 2024-07-02T17:02:16Z

+const isUnauthorized =
+ !userId ||
+ (typeof Astro.props.condition === "function" &&
+ !Astro.props.condition(has)) ||
+ ((Astro.props.role || Astro.props.permission) && !has(Astro.props));


nit: What do you think about reversing the logic here? isAuthorized feels clearer than isUnauthorized (default to unauthorized in the logic).

Agree, that this is hard to grok

That's a fair point, I will added it as a todo if that's ok

brkalow · 2024-07-02T17:08:53Z

+import { $clerk, $csrState, $initialState } from './internal';
+import { deriveState } from './utils';
+
+export const $authStore = computed([$csrState, $initialState], (state, initialState) => {


Is this part of the public API? If so, can we add a JSDoc comment?

Yes it is, i will add them

brkalow · 2024-07-02T17:27:36Z

+ ),
+ );
+
+ if (__HOTLOAD__) {


❓ why are we providing hotloading as an option?

So in the community sdk, hotloading was opt-in, now it is opt-out, but we are still allowing devs to use the astro integration with clerk-js as a direct dependency bundled with the rest of the app.

brkalow · 2024-07-02T17:29:05Z

+ // When the auth status is set, we trust that the middleware has already run
+ // Then, we don't have to re-verify the JWT here,
+ // we can just strip out the claims manually.
+ const authToken = locals.authToken || getAuthKeyFromRequest(req, 'AuthToken');


how does Astro middleware work? Does it run in the same process as the app server itself, or is it like Next where it runs somewhere else? Do we need to worry about the validity of the token here or are we safe to assume it is the token we previously verified in the middleware?

It runs on the same machine, where SSR takes place. Astro supports deployment to vercel where you can choose to use the edge middleware, but we are kind of blocking that because our middleware is using an AsyncLocalStorage

brkalow · 2024-07-02T17:34:38Z

+import { createIntegration } from './create-integration';
+
+export default createIntegration({
+ mode: 'hotload',


is this overridable by the user? If yes, why?

A developer cannot manipulate this code, or call createIntegration explictly.
what the can do though is import the clerk integration from @clerk/astro/bunlded instead of @clerk/astro
The default export of @clerk/astro uses the clerk integration with hotloading.

Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>

anagstef

🚀 ⭐

LekoArts

First pass

LekoArts · 2024-07-03T13:38:21Z

+ "astro": "^3.2.0 || ^4.0.0"
+ },
+ "engines": {
+ "node": ">=18.17.0"


The README says that Node 20 is required?

I had it original to node 20, but because our ci runs with v18 i had to update it. No worries i've checked the Astro minimum node version and this is compatible, also the API for AsyncLocalStorage that we are using has been stable for many versions prior to v18.

LekoArts · 2024-07-03T13:39:33Z

+const isUnauthorized =
+ !userId ||
+ (typeof Astro.props.condition === "function" &&
+ !Astro.props.condition(has)) ||
+ ((Astro.props.role || Astro.props.permission) && !has(Astro.props));


Agree, that this is hard to grok

LekoArts · 2024-07-03T13:42:23Z

+<div id={`clerk-organization-list-${safeId}`}></div>
+
+<script is:inline define:vars={{ props: Astro.props, safeId }}>


The safeId and setOrCreatePropMap are repeated in multiple Astro components. Can we consolidate that into shared utils?

We will resolve this in a follow up PR, i've documented it

LekoArts · 2024-07-03T13:45:24Z

+ hooks: {
+ 'astro:config:setup': ({ config, injectScript, updateConfig, logger, command }) => {
+ if (config.output === 'static') {
+ logger.error(`${packageName} requires SSR to be turned on. Please update output to "server"`);


Why is SSR required? Can't it also work with CSR?

Currently we support only SSR, because we are injecting the clerk-js script from the middleware. But i will add a ticket in order to explore this.

panteliselef · 2024-07-01T12:16:14Z

Description

This PR is tackling ECO-6 and ports the original code from astro-clerk-auth inside this monorepo as a new package called @clerk/astro.

@clerk/astro will become the official Astro SDK from Clerk.

While porting the original code the following things happened

Hotload is now the default method of loading clerk-js on the client.
Dropped the deprecated internal stores, now the stores are only available from /client/stores.
Dropped the /v0 module
Dropped the exported clerkClient as a variable, now you need to call clerkClient(context) and pass the astro context.

In follow up PRs, we will introduce a playground application for Astro, and e2e tests for the node runtime

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-07-01T12:16:17Z

🦋 Changeset detected

Latest commit: 1d11827

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wobsoriano

@panteliselef and I reviewed this code last week, and the changes look good to me.

I've left a few suggestions for improvement.

brkalow

A self-review would be helpful here given the size of the PR and most folks unfamiliarity with some of the more Astro-specific logic.

brkalow · 2024-07-02T17:02:16Z

+const isUnauthorized =
+ !userId ||
+ (typeof Astro.props.condition === "function" &&
+ !Astro.props.condition(has)) ||
+ ((Astro.props.role || Astro.props.permission) && !has(Astro.props));


nit: What do you think about reversing the logic here? isAuthorized feels clearer than isUnauthorized (default to unauthorized in the logic).

Agree, that this is hard to grok

That's a fair point, I will added it as a todo if that's ok

brkalow · 2024-07-02T17:08:53Z

+import { $clerk, $csrState, $initialState } from './internal';
+import { deriveState } from './utils';
+
+export const $authStore = computed([$csrState, $initialState], (state, initialState) => {


Is this part of the public API? If so, can we add a JSDoc comment?

Yes it is, i will add them

brkalow · 2024-07-02T17:27:36Z

+ ),
+ );
+
+ if (__HOTLOAD__) {


❓ why are we providing hotloading as an option?

So in the community sdk, hotloading was opt-in, now it is opt-out, but we are still allowing devs to use the astro integration with clerk-js as a direct dependency bundled with the rest of the app.

brkalow · 2024-07-02T17:29:05Z

+ // When the auth status is set, we trust that the middleware has already run
+ // Then, we don't have to re-verify the JWT here,
+ // we can just strip out the claims manually.
+ const authToken = locals.authToken || getAuthKeyFromRequest(req, 'AuthToken');


how does Astro middleware work? Does it run in the same process as the app server itself, or is it like Next where it runs somewhere else? Do we need to worry about the validity of the token here or are we safe to assume it is the token we previously verified in the middleware?

It runs on the same machine, where SSR takes place. Astro supports deployment to vercel where you can choose to use the edge middleware, but we are kind of blocking that because our middleware is using an AsyncLocalStorage

brkalow · 2024-07-02T17:34:38Z

+import { createIntegration } from './create-integration';
+
+export default createIntegration({
+ mode: 'hotload',


is this overridable by the user? If yes, why?

A developer cannot manipulate this code, or call createIntegration explictly.
what the can do though is import the clerk integration from @clerk/astro/bunlded instead of @clerk/astro
The default export of @clerk/astro uses the clerk integration with hotloading.

Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>

anagstef

🚀 ⭐

LekoArts

First pass

LekoArts · 2024-07-03T13:38:21Z

+ "astro": "^3.2.0 || ^4.0.0"
+ },
+ "engines": {
+ "node": ">=18.17.0"


The README says that Node 20 is required?

I had it original to node 20, but because our ci runs with v18 i had to update it. No worries i've checked the Astro minimum node version and this is compatible, also the API for AsyncLocalStorage that we are using has been stable for many versions prior to v18.

LekoArts · 2024-07-03T13:39:33Z

+const isUnauthorized =
+ !userId ||
+ (typeof Astro.props.condition === "function" &&
+ !Astro.props.condition(has)) ||
+ ((Astro.props.role || Astro.props.permission) && !has(Astro.props));


Agree, that this is hard to grok

LekoArts · 2024-07-03T13:42:23Z

+<div id={`clerk-organization-list-${safeId}`}></div>
+
+<script is:inline define:vars={{ props: Astro.props, safeId }}>


The safeId and setOrCreatePropMap are repeated in multiple Astro components. Can we consolidate that into shared utils?

We will resolve this in a follow up PR, i've documented it

LekoArts · 2024-07-03T13:45:24Z

+ hooks: {
+ 'astro:config:setup': ({ config, injectScript, updateConfig, logger, command }) => {
+ if (config.output === 'static') {
+ logger.error(`${packageName} requires SSR to be turned on. Please update output to "server"`);


Why is SSR required? Can't it also work with CSR?

Currently we support only SSR, because we are injecting the clerk-js script from the middleware. But i will add a ticket in order to explore this.

panteliselef · 2024-07-01T12:16:14Z

Description

This PR is tackling ECO-6 and ports the original code from astro-clerk-auth inside this monorepo as a new package called @clerk/astro.

@clerk/astro will become the official Astro SDK from Clerk.

While porting the original code the following things happened

Hotload is now the default method of loading clerk-js on the client.
Dropped the deprecated internal stores, now the stores are only available from /client/stores.
Dropped the /v0 module
Dropped the exported clerkClient as a variable, now you need to call clerkClient(context) and pass the astro context.

In follow up PRs, we will introduce a playground application for Astro, and e2e tests for the node runtime

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-07-01T12:16:17Z

🦋 Changeset detected

Latest commit: 1d11827

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wobsoriano

@panteliselef and I reviewed this code last week, and the changes look good to me.

I've left a few suggestions for improvement.

brkalow

A self-review would be helpful here given the size of the PR and most folks unfamiliarity with some of the more Astro-specific logic.

brkalow · 2024-07-02T17:02:16Z

+const isUnauthorized =
+ !userId ||
+ (typeof Astro.props.condition === "function" &&
+ !Astro.props.condition(has)) ||
+ ((Astro.props.role || Astro.props.permission) && !has(Astro.props));


nit: What do you think about reversing the logic here? isAuthorized feels clearer than isUnauthorized (default to unauthorized in the logic).

Agree, that this is hard to grok

That's a fair point, I will added it as a todo if that's ok

brkalow · 2024-07-02T17:08:53Z

+import { $clerk, $csrState, $initialState } from './internal';
+import { deriveState } from './utils';
+
+export const $authStore = computed([$csrState, $initialState], (state, initialState) => {


Is this part of the public API? If so, can we add a JSDoc comment?

Yes it is, i will add them

brkalow · 2024-07-02T17:27:36Z

+ ),
+ );
+
+ if (__HOTLOAD__) {


❓ why are we providing hotloading as an option?

So in the community sdk, hotloading was opt-in, now it is opt-out, but we are still allowing devs to use the astro integration with clerk-js as a direct dependency bundled with the rest of the app.

brkalow · 2024-07-02T17:29:05Z

+ // When the auth status is set, we trust that the middleware has already run
+ // Then, we don't have to re-verify the JWT here,
+ // we can just strip out the claims manually.
+ const authToken = locals.authToken || getAuthKeyFromRequest(req, 'AuthToken');


how does Astro middleware work? Does it run in the same process as the app server itself, or is it like Next where it runs somewhere else? Do we need to worry about the validity of the token here or are we safe to assume it is the token we previously verified in the middleware?

It runs on the same machine, where SSR takes place. Astro supports deployment to vercel where you can choose to use the edge middleware, but we are kind of blocking that because our middleware is using an AsyncLocalStorage

brkalow · 2024-07-02T17:34:38Z

+import { createIntegration } from './create-integration';
+
+export default createIntegration({
+ mode: 'hotload',


is this overridable by the user? If yes, why?

A developer cannot manipulate this code, or call createIntegration explictly.
what the can do though is import the clerk integration from @clerk/astro/bunlded instead of @clerk/astro
The default export of @clerk/astro uses the clerk integration with hotloading.

Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>

anagstef

🚀 ⭐

LekoArts

First pass

LekoArts · 2024-07-03T13:38:21Z

+ "astro": "^3.2.0 || ^4.0.0"
+ },
+ "engines": {
+ "node": ">=18.17.0"


The README says that Node 20 is required?

I had it original to node 20, but because our ci runs with v18 i had to update it. No worries i've checked the Astro minimum node version and this is compatible, also the API for AsyncLocalStorage that we are using has been stable for many versions prior to v18.

LekoArts · 2024-07-03T13:39:33Z

+const isUnauthorized =
+ !userId ||
+ (typeof Astro.props.condition === "function" &&
+ !Astro.props.condition(has)) ||
+ ((Astro.props.role || Astro.props.permission) && !has(Astro.props));


Agree, that this is hard to grok

LekoArts · 2024-07-03T13:42:23Z

+<div id={`clerk-organization-list-${safeId}`}></div>
+
+<script is:inline define:vars={{ props: Astro.props, safeId }}>


The safeId and setOrCreatePropMap are repeated in multiple Astro components. Can we consolidate that into shared utils?

We will resolve this in a follow up PR, i've documented it

LekoArts · 2024-07-03T13:45:24Z

+ hooks: {
+ 'astro:config:setup': ({ config, injectScript, updateConfig, logger, command }) => {
+ if (config.output === 'static') {
+ logger.error(`${packageName} requires SSR to be turned on. Please update output to "server"`);


Why is SSR required? Can't it also work with CSR?

Currently we support only SSR, because we are injecting the clerk-js script from the middleware. But i will add a ticket in order to explore this.

panteliselef added 2 commits July 1, 2024 14:47

feat(astro): Introduce Astro SDK
956f8a5

chore(astro): Cleanup
69794b6

panteliselef self-assigned this Jul 1, 2024

panteliselef added 9 commits July 1, 2024 15:31

chore(astro): Drop deprecations
c0454bd

chore(astro): Make hotloading the default
d5fbc8b

chore(astro): Update REAMDE
a809ca8

chore(astro): Add changeset
a8862ee

chore(astro): Change supported engine to node 18
57d9666

chore(astro): Update package-lock.json
184808a

chore(astro): Format .eslintrc.cjs for astro
303257f

chore(astro): Add common scripts
a3a579a

chore(astro): Adjust linting in CI
883c6eb

clerk-cookie added the actions label Jul 2, 2024

panteliselef changed the title ~~feat(astro): Introduce Astro SDK~~feat(astro): Introduce Astro SDKJul 2, 2024

Merge branch 'main' into elef/introduce-astro-sdk
6b8f8f7

panteliselef marked this pull request as ready for review July 2, 2024 15:11

panteliselef requested review from anagstef, nikosdouvlis, octoper and wobsoriano July 2, 2024 15:17

chore(astro): Update @clerk/* to latest canary
91e7099

wobsoriano reviewed Jul 2, 2024
View reviewed changes

Comment threadpackages/astro/src/async-local-storage.server.ts Outdated
Comment threadpackages/astro/src/server/get-auth.ts Outdated
Comment threadpackages/astro/src/server/clerk-middleware.ts Outdated
Comment threadpackages/astro/src/astro-components/interactive/OrganizationList.astro

panteliselef added 2 commits July 2, 2024 19:33

Merge branch 'main' into elef/introduce-astro-sdk
49e480e

chore(astro): Address PR comments
1ee304d

brkalow reviewed Jul 2, 2024
View reviewed changes

anagstef reviewed Jul 3, 2024
View reviewed changes

Comment threadpackages/astro/LICENCE Outdated

Update packages/astro/LICENCE
28dd1f4
Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>

anagstef approved these changes Jul 3, 2024
View reviewed changes

Comment threadpackages/astro/README.md Outdated
Comment threadpackages/astro/README.md Outdated
Comment threadpackages/astro/src/client/react/uiComponents.tsx
Comment threadpackages/astro/src/client/react/utils.tsx

LekoArts suggested changes Jul 3, 2024
View reviewed changes

panteliselef added 5 commits July 3, 2024 17:31

chore(astro): Add jsdoc and todo comments
777c435

chore(astro): Add jsdoc and todo comments
3d3b88e

chore(astro): Drop private from package.json
8c4f015

Merge branch 'refs/heads/main' into elef/introduce-astro-sdk
7924ad6

chore(astro): Update clerk dependencies
1d11827

LekoArts approved these changes Jul 4, 2024
View reviewed changes

panteliselef enabled auto-merge (squash) July 4, 2024 09:28

panteliselef merged commit 7ae5681 into mainJul 4, 2024

panteliselef deleted the elef/introduce-astro-sdk branch July 4, 2024 09:51

clerk-cookie mentioned this pull request Jul 4, 2024
ci(repo): Version packages #3665
Merged

mlafeldt mentioned this pull request Jul 18, 2025
fix(astro): fix async_hooks import for Cloudflare compatibility #6287
Merged
9 tasks

panteliselef added 2 commits July 1, 2024 14:47

feat(astro): Introduce Astro SDK
956f8a5

chore(astro): Cleanup
69794b6

panteliselef self-assigned this Jul 1, 2024

panteliselef added 9 commits July 1, 2024 15:31

chore(astro): Drop deprecations
c0454bd

chore(astro): Make hotloading the default
d5fbc8b

chore(astro): Update REAMDE
a809ca8

chore(astro): Add changeset
a8862ee

chore(astro): Change supported engine to node 18
57d9666

chore(astro): Update package-lock.json
184808a

chore(astro): Format .eslintrc.cjs for astro
303257f

chore(astro): Add common scripts
a3a579a

chore(astro): Adjust linting in CI
883c6eb

clerk-cookie added the actions label Jul 2, 2024

panteliselef changed the title ~~feat(astro): Introduce Astro SDK~~feat(astro): Introduce Astro SDKJul 2, 2024

Merge branch 'main' into elef/introduce-astro-sdk
6b8f8f7

panteliselef marked this pull request as ready for review July 2, 2024 15:11

panteliselef requested review from anagstef, nikosdouvlis, octoper and wobsoriano July 2, 2024 15:17

chore(astro): Update @clerk/* to latest canary
91e7099

wobsoriano reviewed Jul 2, 2024
View reviewed changes

Comment threadpackages/astro/src/async-local-storage.server.ts Outdated
Comment threadpackages/astro/src/server/get-auth.ts Outdated
Comment threadpackages/astro/src/server/clerk-middleware.ts Outdated
Comment threadpackages/astro/src/astro-components/interactive/OrganizationList.astro

panteliselef added 2 commits July 2, 2024 19:33

Merge branch 'main' into elef/introduce-astro-sdk
49e480e

chore(astro): Address PR comments
1ee304d

brkalow reviewed Jul 2, 2024
View reviewed changes

anagstef reviewed Jul 3, 2024
View reviewed changes

Comment threadpackages/astro/LICENCE Outdated

Update packages/astro/LICENCE
28dd1f4
Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>

anagstef approved these changes Jul 3, 2024
View reviewed changes

Comment threadpackages/astro/README.md Outdated
Comment threadpackages/astro/README.md Outdated
Comment threadpackages/astro/src/client/react/uiComponents.tsx
Comment threadpackages/astro/src/client/react/utils.tsx

LekoArts suggested changes Jul 3, 2024
View reviewed changes

panteliselef added 5 commits July 3, 2024 17:31

chore(astro): Add jsdoc and todo comments
777c435

chore(astro): Add jsdoc and todo comments
3d3b88e

chore(astro): Drop private from package.json
8c4f015

Merge branch 'refs/heads/main' into elef/introduce-astro-sdk
7924ad6

chore(astro): Update clerk dependencies
1d11827

LekoArts approved these changes Jul 4, 2024
View reviewed changes

panteliselef enabled auto-merge (squash) July 4, 2024 09:28

panteliselef merged commit 7ae5681 into mainJul 4, 2024

panteliselef deleted the elef/introduce-astro-sdk branch July 4, 2024 09:51

clerk-cookie mentioned this pull request Jul 4, 2024
ci(repo): Version packages #3665
Merged

mlafeldt mentioned this pull request Jul 18, 2025
fix(astro): fix async_hooks import for Cloudflare compatibility #6287
Merged
9 tasks

panteliselef added 2 commits July 1, 2024 14:47

feat(astro): Introduce Astro SDK
956f8a5

chore(astro): Cleanup
69794b6

panteliselef self-assigned this Jul 1, 2024

panteliselef added 9 commits July 1, 2024 15:31

chore(astro): Drop deprecations
c0454bd

chore(astro): Make hotloading the default
d5fbc8b

chore(astro): Update REAMDE
a809ca8

chore(astro): Add changeset
a8862ee

chore(astro): Change supported engine to node 18
57d9666

chore(astro): Update package-lock.json
184808a

chore(astro): Format .eslintrc.cjs for astro
303257f

chore(astro): Add common scripts
a3a579a

chore(astro): Adjust linting in CI
883c6eb

clerk-cookie added the actions label Jul 2, 2024

panteliselef changed the title ~~feat(astro): Introduce Astro SDK~~feat(astro): Introduce Astro SDKJul 2, 2024

Merge branch 'main' into elef/introduce-astro-sdk
6b8f8f7

panteliselef marked this pull request as ready for review July 2, 2024 15:11

panteliselef requested review from anagstef, nikosdouvlis, octoper and wobsoriano July 2, 2024 15:17

chore(astro): Update @clerk/* to latest canary
91e7099

wobsoriano reviewed Jul 2, 2024
View reviewed changes

Comment threadpackages/astro/src/async-local-storage.server.ts Outdated
Comment threadpackages/astro/src/server/get-auth.ts Outdated
Comment threadpackages/astro/src/server/clerk-middleware.ts Outdated
Comment threadpackages/astro/src/astro-components/interactive/OrganizationList.astro

panteliselef added 2 commits July 2, 2024 19:33

Merge branch 'main' into elef/introduce-astro-sdk
49e480e

chore(astro): Address PR comments
1ee304d

brkalow reviewed Jul 2, 2024
View reviewed changes

anagstef reviewed Jul 3, 2024
View reviewed changes

Comment threadpackages/astro/LICENCE Outdated

Update packages/astro/LICENCE
28dd1f4
Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>

anagstef approved these changes Jul 3, 2024
View reviewed changes

Comment threadpackages/astro/README.md Outdated
Comment threadpackages/astro/README.md Outdated
Comment threadpackages/astro/src/client/react/uiComponents.tsx
Comment threadpackages/astro/src/client/react/utils.tsx

LekoArts suggested changes Jul 3, 2024
View reviewed changes

panteliselef added 5 commits July 3, 2024 17:31

chore(astro): Add jsdoc and todo comments
777c435

chore(astro): Add jsdoc and todo comments
3d3b88e

chore(astro): Drop private from package.json
8c4f015

Merge branch 'refs/heads/main' into elef/introduce-astro-sdk
7924ad6

chore(astro): Update clerk dependencies
1d11827

LekoArts approved these changes Jul 4, 2024
View reviewed changes

panteliselef enabled auto-merge (squash) July 4, 2024 09:28

panteliselef merged commit 7ae5681 into mainJul 4, 2024

panteliselef deleted the elef/introduce-astro-sdk branch July 4, 2024 09:51

clerk-cookie mentioned this pull request Jul 4, 2024
ci(repo): Version packages #3665
Merged

mlafeldt mentioned this pull request Jul 18, 2025
fix(astro): fix async_hooks import for Cloudflare compatibility #6287
Merged
9 tasks

panteliselef added 2 commits July 1, 2024 14:47

feat(astro): Introduce Astro SDK
956f8a5

chore(astro): Cleanup
69794b6

panteliselef self-assigned this Jul 1, 2024

panteliselef added 9 commits July 1, 2024 15:31

chore(astro): Drop deprecations
c0454bd

chore(astro): Make hotloading the default
d5fbc8b

chore(astro): Update REAMDE
a809ca8

chore(astro): Add changeset
a8862ee

chore(astro): Change supported engine to node 18
57d9666

chore(astro): Update package-lock.json
184808a

chore(astro): Format .eslintrc.cjs for astro
303257f

chore(astro): Add common scripts
a3a579a

chore(astro): Adjust linting in CI
883c6eb

clerk-cookie added the actions label Jul 2, 2024

panteliselef changed the title ~~feat(astro): Introduce Astro SDK~~feat(astro): Introduce Astro SDKJul 2, 2024

Merge branch 'main' into elef/introduce-astro-sdk
6b8f8f7

panteliselef marked this pull request as ready for review July 2, 2024 15:11

panteliselef requested review from anagstef, nikosdouvlis, octoper and wobsoriano July 2, 2024 15:17

chore(astro): Update @clerk/* to latest canary
91e7099

wobsoriano reviewed Jul 2, 2024
View reviewed changes

Comment threadpackages/astro/src/async-local-storage.server.ts Outdated
Comment threadpackages/astro/src/server/get-auth.ts Outdated
Comment threadpackages/astro/src/server/clerk-middleware.ts Outdated
Comment threadpackages/astro/src/astro-components/interactive/OrganizationList.astro

panteliselef added 2 commits July 2, 2024 19:33

Merge branch 'main' into elef/introduce-astro-sdk
49e480e

chore(astro): Address PR comments
1ee304d

brkalow reviewed Jul 2, 2024
View reviewed changes

anagstef reviewed Jul 3, 2024
View reviewed changes

Comment threadpackages/astro/LICENCE Outdated

Update packages/astro/LICENCE
28dd1f4
Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>

anagstef approved these changes Jul 3, 2024
View reviewed changes

Comment threadpackages/astro/README.md Outdated
Comment threadpackages/astro/README.md Outdated
Comment threadpackages/astro/src/client/react/uiComponents.tsx
Comment threadpackages/astro/src/client/react/utils.tsx

LekoArts suggested changes Jul 3, 2024
View reviewed changes

panteliselef added 5 commits July 3, 2024 17:31

chore(astro): Add jsdoc and todo comments
777c435

chore(astro): Add jsdoc and todo comments
3d3b88e

chore(astro): Drop private from package.json
8c4f015

Merge branch 'refs/heads/main' into elef/introduce-astro-sdk
7924ad6

chore(astro): Update clerk dependencies
1d11827

LekoArts approved these changes Jul 4, 2024
View reviewed changes

panteliselef enabled auto-merge (squash) July 4, 2024 09:28

panteliselef merged commit 7ae5681 into mainJul 4, 2024

panteliselef deleted the elef/introduce-astro-sdk branch July 4, 2024 09:51

clerk-cookie mentioned this pull request Jul 4, 2024
ci(repo): Version packages #3665
Merged

mlafeldt mentioned this pull request Jul 18, 2025
fix(astro): fix async_hooks import for Cloudflare compatibility #6287
Merged
9 tasks

panteliselef added 2 commits July 1, 2024 14:47

feat(astro): Introduce Astro SDK
956f8a5

chore(astro): Cleanup
69794b6

panteliselef self-assigned this Jul 1, 2024

panteliselef added 9 commits July 1, 2024 15:31

chore(astro): Drop deprecations
c0454bd

chore(astro): Make hotloading the default
d5fbc8b

chore(astro): Update REAMDE
a809ca8

chore(astro): Add changeset
a8862ee

chore(astro): Change supported engine to node 18
57d9666

chore(astro): Update package-lock.json
184808a

chore(astro): Format .eslintrc.cjs for astro
303257f

chore(astro): Add common scripts
a3a579a

chore(astro): Adjust linting in CI
883c6eb

clerk-cookie added the actions label Jul 2, 2024

panteliselef changed the title ~~feat(astro): Introduce Astro SDK~~feat(astro): Introduce Astro SDKJul 2, 2024

Merge branch 'main' into elef/introduce-astro-sdk
6b8f8f7

panteliselef marked this pull request as ready for review July 2, 2024 15:11

panteliselef requested review from anagstef, nikosdouvlis, octoper and wobsoriano July 2, 2024 15:17

chore(astro): Update @clerk/* to latest canary
91e7099

wobsoriano reviewed Jul 2, 2024
View reviewed changes

Comment threadpackages/astro/src/async-local-storage.server.ts Outdated
Comment threadpackages/astro/src/server/get-auth.ts Outdated
Comment threadpackages/astro/src/server/clerk-middleware.ts Outdated
Comment threadpackages/astro/src/astro-components/interactive/OrganizationList.astro

panteliselef added 2 commits July 2, 2024 19:33

Merge branch 'main' into elef/introduce-astro-sdk
49e480e

chore(astro): Address PR comments
1ee304d

brkalow reviewed Jul 2, 2024
View reviewed changes

anagstef reviewed Jul 3, 2024
View reviewed changes

Comment threadpackages/astro/LICENCE Outdated

Update packages/astro/LICENCE
28dd1f4
Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>

anagstef approved these changes Jul 3, 2024
View reviewed changes

Comment threadpackages/astro/README.md Outdated
Comment threadpackages/astro/README.md Outdated
Comment threadpackages/astro/src/client/react/uiComponents.tsx
Comment threadpackages/astro/src/client/react/utils.tsx

LekoArts suggested changes Jul 3, 2024
View reviewed changes

panteliselef added 5 commits July 3, 2024 17:31

chore(astro): Add jsdoc and todo comments
777c435

chore(astro): Add jsdoc and todo comments
3d3b88e

chore(astro): Drop private from package.json
8c4f015

Merge branch 'refs/heads/main' into elef/introduce-astro-sdk
7924ad6

chore(astro): Update clerk dependencies
1d11827

LekoArts approved these changes Jul 4, 2024
View reviewed changes

panteliselef enabled auto-merge (squash) July 4, 2024 09:28

panteliselef merged commit 7ae5681 into mainJul 4, 2024

panteliselef deleted the elef/introduce-astro-sdk branch July 4, 2024 09:51

clerk-cookie mentioned this pull request Jul 4, 2024
ci(repo): Version packages #3665
Merged

mlafeldt mentioned this pull request Jul 18, 2025
fix(astro): fix async_hooks import for Cloudflare compatibility #6287
Merged
9 tasks

panteliselef added 2 commits July 1, 2024 14:47

feat(astro): Introduce Astro SDK
956f8a5

chore(astro): Cleanup
69794b6

panteliselef self-assigned this Jul 1, 2024

panteliselef added 9 commits July 1, 2024 15:31

chore(astro): Drop deprecations
c0454bd

chore(astro): Make hotloading the default
d5fbc8b

chore(astro): Update REAMDE
a809ca8

chore(astro): Add changeset
a8862ee

chore(astro): Change supported engine to node 18
57d9666

chore(astro): Update package-lock.json
184808a

chore(astro): Format .eslintrc.cjs for astro
303257f

chore(astro): Add common scripts
a3a579a

chore(astro): Adjust linting in CI
883c6eb

clerk-cookie added the actions label Jul 2, 2024

panteliselef changed the title ~~feat(astro): Introduce Astro SDK~~feat(astro): Introduce Astro SDKJul 2, 2024

Merge branch 'main' into elef/introduce-astro-sdk
6b8f8f7

panteliselef marked this pull request as ready for review July 2, 2024 15:11

panteliselef requested review from anagstef, nikosdouvlis, octoper and wobsoriano July 2, 2024 15:17

chore(astro): Update @clerk/* to latest canary
91e7099

wobsoriano reviewed Jul 2, 2024
View reviewed changes

Comment threadpackages/astro/src/async-local-storage.server.ts Outdated
Comment threadpackages/astro/src/server/get-auth.ts Outdated
Comment threadpackages/astro/src/server/clerk-middleware.ts Outdated
Comment threadpackages/astro/src/astro-components/interactive/OrganizationList.astro

panteliselef added 2 commits July 2, 2024 19:33

Merge branch 'main' into elef/introduce-astro-sdk
49e480e

chore(astro): Address PR comments
1ee304d

brkalow reviewed Jul 2, 2024
View reviewed changes

anagstef reviewed Jul 3, 2024
View reviewed changes

Comment threadpackages/astro/LICENCE Outdated

Update packages/astro/LICENCE
28dd1f4
Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>

anagstef approved these changes Jul 3, 2024
View reviewed changes

Comment threadpackages/astro/README.md Outdated
Comment threadpackages/astro/README.md Outdated
Comment threadpackages/astro/src/client/react/uiComponents.tsx
Comment threadpackages/astro/src/client/react/utils.tsx

LekoArts suggested changes Jul 3, 2024
View reviewed changes

panteliselef added 5 commits July 3, 2024 17:31

chore(astro): Add jsdoc and todo comments
777c435

chore(astro): Add jsdoc and todo comments
3d3b88e

chore(astro): Drop private from package.json
8c4f015

Merge branch 'refs/heads/main' into elef/introduce-astro-sdk
7924ad6

chore(astro): Update clerk dependencies
1d11827

LekoArts approved these changes Jul 4, 2024
View reviewed changes

panteliselef enabled auto-merge (squash) July 4, 2024 09:28

panteliselef merged commit 7ae5681 into mainJul 4, 2024

panteliselef deleted the elef/introduce-astro-sdk branch July 4, 2024 09:51

clerk-cookie mentioned this pull request Jul 4, 2024
ci(repo): Version packages #3665
Merged

mlafeldt mentioned this pull request Jul 18, 2025
fix(astro): fix async_hooks import for Cloudflare compatibility #6287
Merged
9 tasks

panteliselef added 2 commits July 1, 2024 14:47

feat(astro): Introduce Astro SDK
956f8a5

chore(astro): Cleanup
69794b6

panteliselef self-assigned this Jul 1, 2024

panteliselef added 9 commits July 1, 2024 15:31

chore(astro): Drop deprecations
c0454bd

chore(astro): Make hotloading the default
d5fbc8b

chore(astro): Update REAMDE
a809ca8

chore(astro): Add changeset
a8862ee

chore(astro): Change supported engine to node 18
57d9666

chore(astro): Update package-lock.json
184808a

chore(astro): Format .eslintrc.cjs for astro
303257f

chore(astro): Add common scripts
a3a579a

chore(astro): Adjust linting in CI
883c6eb

clerk-cookie added the actions label Jul 2, 2024

panteliselef changed the title ~~feat(astro): Introduce Astro SDK~~feat(astro): Introduce Astro SDKJul 2, 2024

Merge branch 'main' into elef/introduce-astro-sdk
6b8f8f7

panteliselef marked this pull request as ready for review July 2, 2024 15:11

panteliselef requested review from anagstef, nikosdouvlis, octoper and wobsoriano July 2, 2024 15:17

chore(astro): Update @clerk/* to latest canary
91e7099

wobsoriano reviewed Jul 2, 2024
View reviewed changes

Comment threadpackages/astro/src/async-local-storage.server.ts Outdated
Comment threadpackages/astro/src/server/get-auth.ts Outdated
Comment threadpackages/astro/src/server/clerk-middleware.ts Outdated
Comment threadpackages/astro/src/astro-components/interactive/OrganizationList.astro

panteliselef added 2 commits July 2, 2024 19:33

Merge branch 'main' into elef/introduce-astro-sdk
49e480e

chore(astro): Address PR comments
1ee304d

brkalow reviewed Jul 2, 2024
View reviewed changes

anagstef reviewed Jul 3, 2024
View reviewed changes

Comment threadpackages/astro/LICENCE Outdated

Update packages/astro/LICENCE
28dd1f4
Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>

anagstef approved these changes Jul 3, 2024
View reviewed changes

Comment threadpackages/astro/README.md Outdated
Comment threadpackages/astro/README.md Outdated
Comment threadpackages/astro/src/client/react/uiComponents.tsx
Comment threadpackages/astro/src/client/react/utils.tsx

LekoArts suggested changes Jul 3, 2024
View reviewed changes

panteliselef added 5 commits July 3, 2024 17:31

chore(astro): Add jsdoc and todo comments
777c435

chore(astro): Add jsdoc and todo comments
3d3b88e

chore(astro): Drop private from package.json
8c4f015

Merge branch 'refs/heads/main' into elef/introduce-astro-sdk
7924ad6

chore(astro): Update clerk dependencies
1d11827

LekoArts approved these changes Jul 4, 2024
View reviewed changes

panteliselef enabled auto-merge (squash) July 4, 2024 09:28

panteliselef merged commit 7ae5681 into mainJul 4, 2024

panteliselef deleted the elef/introduce-astro-sdk branch July 4, 2024 09:51

clerk-cookie mentioned this pull request Jul 4, 2024
ci(repo): Version packages #3665
Merged

mlafeldt mentioned this pull request Jul 18, 2025
fix(astro): fix async_hooks import for Cloudflare compatibility #6287
Merged
9 tasks

panteliselef added 2 commits July 1, 2024 14:47

feat(astro): Introduce Astro SDK
956f8a5

chore(astro): Cleanup
69794b6

panteliselef self-assigned this Jul 1, 2024

panteliselef added 9 commits July 1, 2024 15:31

chore(astro): Drop deprecations
c0454bd

chore(astro): Make hotloading the default
d5fbc8b

chore(astro): Update REAMDE
a809ca8

chore(astro): Add changeset
a8862ee

chore(astro): Change supported engine to node 18
57d9666

chore(astro): Update package-lock.json
184808a

chore(astro): Format .eslintrc.cjs for astro
303257f

chore(astro): Add common scripts
a3a579a

chore(astro): Adjust linting in CI
883c6eb

clerk-cookie added the actions label Jul 2, 2024

panteliselef changed the title ~~feat(astro): Introduce Astro SDK~~feat(astro): Introduce Astro SDKJul 2, 2024

Merge branch 'main' into elef/introduce-astro-sdk
6b8f8f7

panteliselef marked this pull request as ready for review July 2, 2024 15:11

panteliselef requested review from anagstef, nikosdouvlis, octoper and wobsoriano July 2, 2024 15:17

chore(astro): Update @clerk/* to latest canary
91e7099

wobsoriano reviewed Jul 2, 2024
View reviewed changes

Comment threadpackages/astro/src/async-local-storage.server.ts Outdated
Comment threadpackages/astro/src/server/get-auth.ts Outdated
Comment threadpackages/astro/src/server/clerk-middleware.ts Outdated
Comment threadpackages/astro/src/astro-components/interactive/OrganizationList.astro

panteliselef added 2 commits July 2, 2024 19:33

Merge branch 'main' into elef/introduce-astro-sdk
49e480e

chore(astro): Address PR comments
1ee304d

brkalow reviewed Jul 2, 2024
View reviewed changes

anagstef reviewed Jul 3, 2024
View reviewed changes

Comment threadpackages/astro/LICENCE Outdated

Update packages/astro/LICENCE
28dd1f4
Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>

anagstef approved these changes Jul 3, 2024
View reviewed changes

Comment threadpackages/astro/README.md Outdated
Comment threadpackages/astro/README.md Outdated
Comment threadpackages/astro/src/client/react/uiComponents.tsx
Comment threadpackages/astro/src/client/react/utils.tsx

LekoArts suggested changes Jul 3, 2024
View reviewed changes

panteliselef added 5 commits July 3, 2024 17:31

chore(astro): Add jsdoc and todo comments
777c435

chore(astro): Add jsdoc and todo comments
3d3b88e

chore(astro): Drop private from package.json
8c4f015

Merge branch 'refs/heads/main' into elef/introduce-astro-sdk
7924ad6

chore(astro): Update clerk dependencies
1d11827

LekoArts approved these changes Jul 4, 2024
View reviewed changes

panteliselef enabled auto-merge (squash) July 4, 2024 09:28

panteliselef merged commit 7ae5681 into mainJul 4, 2024

panteliselef deleted the elef/introduce-astro-sdk branch July 4, 2024 09:51

clerk-cookie mentioned this pull request Jul 4, 2024
ci(repo): Version packages #3665
Merged

mlafeldt mentioned this pull request Jul 18, 2025
fix(astro): fix async_hooks import for Cloudflare compatibility #6287
Merged
9 tasks

		<div id={`clerk-organization-list-${safeId}`}></div>

		<script is:inline define:vars={{ props: Astro.props, safeId }}>

Uh oh!

Conversation

panteliselef commented Jul 1, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

changeset-botBot commented Jul 1, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

wobsoriano left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brkalow left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

anagstef left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LekoArts left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

panteliselef commented Jul 1, 2024•
edited
Loading

changeset-botBot commented Jul 1, 2024•
edited
Loading

panteliselef commented Jul 1, 2024•
edited
Loading

changeset-botBot commented Jul 1, 2024•
edited
Loading