chore(astro): Add unstyled components by wobsoriano · Pull Request #3656 · clerk/javascript

wobsoriano · 2024-07-02T21:26:49Z

Description

This PR is tackling ECO-2 and adds unstyled sign in, sign up, and sign out components for both Astro and React.

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-07-02T21:26:52Z

🦋 Changeset detected

Latest commit: 0d9ccf9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wobsoriano · 2024-07-04T16:08:18Z

+import { customAlphabet, urlAlphabet } from "nanoid";
+
+const safeId = customAlphabet(urlAlphabet, 10)();


Starting to notice we're repeating this piece of logic in all our Astro components. I'll make a ticket that will address this

panteliselef · 2024-07-08T18:17:23Z

+---
+import type { SignInButtonProps } from "@clerk/astro/client/react";
+type Props = SignInButtonProps
+
+import { SignInButton as SignInButtonReact } from "@clerk/astro/client/react";
+
+const props = {
+ ...Astro.props
+}
+---
+
+<SignInButtonReact
+ client:load
+ {...props}
+/>


So in general we still are not sure if we are keeping astro-components/react. Do you think we should ?

I think we should just drop it. Unstyled components won't benefit here anyway since islands don't support React.cloneElement

panteliselef · 2024-07-08T18:22:48Z

+ btn.addEventListener("click", () => {
+ window.Clerk.signOut({ redirectUrl })
+ });


I know that this is how it is implemented in clerk-react but can you find out if we maybe need to respect all the functionality signOut provides ? Type here

Nice catch. I think we need to respect the sessionId since it's needed if a user wants to sign out of a specific session.
Also, looking at the SignOutButtonreference, the callback is never stated and it's recommended to migrate to redirectUrl in the Core 2 migration doc. So are we looking at deprecation of the callback property in the future here?
The signOutCallback prop on the component has been removed. Instead, you can use the redirectUrl prop

Added sessionId to sign out options. We had a small discussion in Slack about this. signOutCallback is removed.
Here's a reference to where the sessionId was accidentally ignored

chore(astro): use data attribute in referencing unstyled components

Co-authored-by: panteliselef <panteliselef@outlook.com>

wobsoriano · 2024-07-02T21:26:49Z

Description

This PR is tackling ECO-2 and adds unstyled sign in, sign up, and sign out components for both Astro and React.

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-07-02T21:26:52Z

🦋 Changeset detected

Latest commit: 0d9ccf9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wobsoriano · 2024-07-04T16:08:18Z

+import { customAlphabet, urlAlphabet } from "nanoid";
+
+const safeId = customAlphabet(urlAlphabet, 10)();


Starting to notice we're repeating this piece of logic in all our Astro components. I'll make a ticket that will address this

panteliselef · 2024-07-08T18:17:23Z

+---
+import type { SignInButtonProps } from "@clerk/astro/client/react";
+type Props = SignInButtonProps
+
+import { SignInButton as SignInButtonReact } from "@clerk/astro/client/react";
+
+const props = {
+ ...Astro.props
+}
+---
+
+<SignInButtonReact
+ client:load
+ {...props}
+/>


So in general we still are not sure if we are keeping astro-components/react. Do you think we should ?

I think we should just drop it. Unstyled components won't benefit here anyway since islands don't support React.cloneElement

panteliselef · 2024-07-08T18:22:48Z

+ btn.addEventListener("click", () => {
+ window.Clerk.signOut({ redirectUrl })
+ });


I know that this is how it is implemented in clerk-react but can you find out if we maybe need to respect all the functionality signOut provides ? Type here

Nice catch. I think we need to respect the sessionId since it's needed if a user wants to sign out of a specific session.
Also, looking at the SignOutButtonreference, the callback is never stated and it's recommended to migrate to redirectUrl in the Core 2 migration doc. So are we looking at deprecation of the callback property in the future here?
The signOutCallback prop on the component has been removed. Instead, you can use the redirectUrl prop

Added sessionId to sign out options. We had a small discussion in Slack about this. signOutCallback is removed.
Here's a reference to where the sessionId was accidentally ignored

chore(astro): use data attribute in referencing unstyled components

Co-authored-by: panteliselef <panteliselef@outlook.com>

wobsoriano · 2024-07-02T21:26:49Z

Description

This PR is tackling ECO-2 and adds unstyled sign in, sign up, and sign out components for both Astro and React.

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-07-02T21:26:52Z

🦋 Changeset detected

Latest commit: 0d9ccf9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wobsoriano · 2024-07-04T16:08:18Z

+import { customAlphabet, urlAlphabet } from "nanoid";
+
+const safeId = customAlphabet(urlAlphabet, 10)();


Starting to notice we're repeating this piece of logic in all our Astro components. I'll make a ticket that will address this

panteliselef · 2024-07-08T18:17:23Z

+---
+import type { SignInButtonProps } from "@clerk/astro/client/react";
+type Props = SignInButtonProps
+
+import { SignInButton as SignInButtonReact } from "@clerk/astro/client/react";
+
+const props = {
+ ...Astro.props
+}
+---
+
+<SignInButtonReact
+ client:load
+ {...props}
+/>


So in general we still are not sure if we are keeping astro-components/react. Do you think we should ?

I think we should just drop it. Unstyled components won't benefit here anyway since islands don't support React.cloneElement

panteliselef · 2024-07-08T18:22:48Z

+ btn.addEventListener("click", () => {
+ window.Clerk.signOut({ redirectUrl })
+ });


I know that this is how it is implemented in clerk-react but can you find out if we maybe need to respect all the functionality signOut provides ? Type here

Nice catch. I think we need to respect the sessionId since it's needed if a user wants to sign out of a specific session.
Also, looking at the SignOutButtonreference, the callback is never stated and it's recommended to migrate to redirectUrl in the Core 2 migration doc. So are we looking at deprecation of the callback property in the future here?
The signOutCallback prop on the component has been removed. Instead, you can use the redirectUrl prop

Added sessionId to sign out options. We had a small discussion in Slack about this. signOutCallback is removed.
Here's a reference to where the sessionId was accidentally ignored

chore(astro): use data attribute in referencing unstyled components

Co-authored-by: panteliselef <panteliselef@outlook.com>

wobsoriano · 2024-07-02T21:26:49Z

Description

This PR is tackling ECO-2 and adds unstyled sign in, sign up, and sign out components for both Astro and React.

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-07-02T21:26:52Z

🦋 Changeset detected

Latest commit: 0d9ccf9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wobsoriano · 2024-07-04T16:08:18Z

+import { customAlphabet, urlAlphabet } from "nanoid";
+
+const safeId = customAlphabet(urlAlphabet, 10)();


Starting to notice we're repeating this piece of logic in all our Astro components. I'll make a ticket that will address this

panteliselef · 2024-07-08T18:17:23Z

+---
+import type { SignInButtonProps } from "@clerk/astro/client/react";
+type Props = SignInButtonProps
+
+import { SignInButton as SignInButtonReact } from "@clerk/astro/client/react";
+
+const props = {
+ ...Astro.props
+}
+---
+
+<SignInButtonReact
+ client:load
+ {...props}
+/>


So in general we still are not sure if we are keeping astro-components/react. Do you think we should ?

I think we should just drop it. Unstyled components won't benefit here anyway since islands don't support React.cloneElement

panteliselef · 2024-07-08T18:22:48Z

+ btn.addEventListener("click", () => {
+ window.Clerk.signOut({ redirectUrl })
+ });


I know that this is how it is implemented in clerk-react but can you find out if we maybe need to respect all the functionality signOut provides ? Type here

Nice catch. I think we need to respect the sessionId since it's needed if a user wants to sign out of a specific session.
Also, looking at the SignOutButtonreference, the callback is never stated and it's recommended to migrate to redirectUrl in the Core 2 migration doc. So are we looking at deprecation of the callback property in the future here?
The signOutCallback prop on the component has been removed. Instead, you can use the redirectUrl prop

Added sessionId to sign out options. We had a small discussion in Slack about this. signOutCallback is removed.
Here's a reference to where the sessionId was accidentally ignored

chore(astro): use data attribute in referencing unstyled components

Co-authored-by: panteliselef <panteliselef@outlook.com>

wobsoriano · 2024-07-02T21:26:49Z

Description

This PR is tackling ECO-2 and adds unstyled sign in, sign up, and sign out components for both Astro and React.

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-07-02T21:26:52Z

🦋 Changeset detected

Latest commit: 0d9ccf9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wobsoriano · 2024-07-04T16:08:18Z

+import { customAlphabet, urlAlphabet } from "nanoid";
+
+const safeId = customAlphabet(urlAlphabet, 10)();


Starting to notice we're repeating this piece of logic in all our Astro components. I'll make a ticket that will address this

panteliselef · 2024-07-08T18:17:23Z

+---
+import type { SignInButtonProps } from "@clerk/astro/client/react";
+type Props = SignInButtonProps
+
+import { SignInButton as SignInButtonReact } from "@clerk/astro/client/react";
+
+const props = {
+ ...Astro.props
+}
+---
+
+<SignInButtonReact
+ client:load
+ {...props}
+/>


So in general we still are not sure if we are keeping astro-components/react. Do you think we should ?

I think we should just drop it. Unstyled components won't benefit here anyway since islands don't support React.cloneElement

panteliselef · 2024-07-08T18:22:48Z

+ btn.addEventListener("click", () => {
+ window.Clerk.signOut({ redirectUrl })
+ });


I know that this is how it is implemented in clerk-react but can you find out if we maybe need to respect all the functionality signOut provides ? Type here

Nice catch. I think we need to respect the sessionId since it's needed if a user wants to sign out of a specific session.
Also, looking at the SignOutButtonreference, the callback is never stated and it's recommended to migrate to redirectUrl in the Core 2 migration doc. So are we looking at deprecation of the callback property in the future here?
The signOutCallback prop on the component has been removed. Instead, you can use the redirectUrl prop

Added sessionId to sign out options. We had a small discussion in Slack about this. signOutCallback is removed.
Here's a reference to where the sessionId was accidentally ignored

chore(astro): use data attribute in referencing unstyled components

Co-authored-by: panteliselef <panteliselef@outlook.com>

wobsoriano · 2024-07-02T21:26:49Z

Description

This PR is tackling ECO-2 and adds unstyled sign in, sign up, and sign out components for both Astro and React.

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-07-02T21:26:52Z

🦋 Changeset detected

Latest commit: 0d9ccf9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wobsoriano · 2024-07-04T16:08:18Z

+import { customAlphabet, urlAlphabet } from "nanoid";
+
+const safeId = customAlphabet(urlAlphabet, 10)();


Starting to notice we're repeating this piece of logic in all our Astro components. I'll make a ticket that will address this

panteliselef · 2024-07-08T18:17:23Z

+---
+import type { SignInButtonProps } from "@clerk/astro/client/react";
+type Props = SignInButtonProps
+
+import { SignInButton as SignInButtonReact } from "@clerk/astro/client/react";
+
+const props = {
+ ...Astro.props
+}
+---
+
+<SignInButtonReact
+ client:load
+ {...props}
+/>


So in general we still are not sure if we are keeping astro-components/react. Do you think we should ?

I think we should just drop it. Unstyled components won't benefit here anyway since islands don't support React.cloneElement

panteliselef · 2024-07-08T18:22:48Z

+ btn.addEventListener("click", () => {
+ window.Clerk.signOut({ redirectUrl })
+ });


I know that this is how it is implemented in clerk-react but can you find out if we maybe need to respect all the functionality signOut provides ? Type here

Nice catch. I think we need to respect the sessionId since it's needed if a user wants to sign out of a specific session.
Also, looking at the SignOutButtonreference, the callback is never stated and it's recommended to migrate to redirectUrl in the Core 2 migration doc. So are we looking at deprecation of the callback property in the future here?
The signOutCallback prop on the component has been removed. Instead, you can use the redirectUrl prop

Added sessionId to sign out options. We had a small discussion in Slack about this. signOutCallback is removed.
Here's a reference to where the sessionId was accidentally ignored

chore(astro): use data attribute in referencing unstyled components

Co-authored-by: panteliselef <panteliselef@outlook.com>

wobsoriano · 2024-07-02T21:26:49Z

Description

This PR is tackling ECO-2 and adds unstyled sign in, sign up, and sign out components for both Astro and React.

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-07-02T21:26:52Z

🦋 Changeset detected

Latest commit: 0d9ccf9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wobsoriano · 2024-07-04T16:08:18Z

+import { customAlphabet, urlAlphabet } from "nanoid";
+
+const safeId = customAlphabet(urlAlphabet, 10)();


Starting to notice we're repeating this piece of logic in all our Astro components. I'll make a ticket that will address this

panteliselef · 2024-07-08T18:17:23Z

+---
+import type { SignInButtonProps } from "@clerk/astro/client/react";
+type Props = SignInButtonProps
+
+import { SignInButton as SignInButtonReact } from "@clerk/astro/client/react";
+
+const props = {
+ ...Astro.props
+}
+---
+
+<SignInButtonReact
+ client:load
+ {...props}
+/>


So in general we still are not sure if we are keeping astro-components/react. Do you think we should ?

I think we should just drop it. Unstyled components won't benefit here anyway since islands don't support React.cloneElement

panteliselef · 2024-07-08T18:22:48Z

+ btn.addEventListener("click", () => {
+ window.Clerk.signOut({ redirectUrl })
+ });


I know that this is how it is implemented in clerk-react but can you find out if we maybe need to respect all the functionality signOut provides ? Type here

Nice catch. I think we need to respect the sessionId since it's needed if a user wants to sign out of a specific session.
Also, looking at the SignOutButtonreference, the callback is never stated and it's recommended to migrate to redirectUrl in the Core 2 migration doc. So are we looking at deprecation of the callback property in the future here?
The signOutCallback prop on the component has been removed. Instead, you can use the redirectUrl prop

Added sessionId to sign out options. We had a small discussion in Slack about this. signOutCallback is removed.
Here's a reference to where the sessionId was accidentally ignored

chore(astro): use data attribute in referencing unstyled components

Co-authored-by: panteliselef <panteliselef@outlook.com>

wobsoriano · 2024-07-02T21:26:49Z

Description

This PR is tackling ECO-2 and adds unstyled sign in, sign up, and sign out components for both Astro and React.

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-07-02T21:26:52Z

🦋 Changeset detected

Latest commit: 0d9ccf9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wobsoriano · 2024-07-04T16:08:18Z

+import { customAlphabet, urlAlphabet } from "nanoid";
+
+const safeId = customAlphabet(urlAlphabet, 10)();


Starting to notice we're repeating this piece of logic in all our Astro components. I'll make a ticket that will address this

panteliselef · 2024-07-08T18:17:23Z

+---
+import type { SignInButtonProps } from "@clerk/astro/client/react";
+type Props = SignInButtonProps
+
+import { SignInButton as SignInButtonReact } from "@clerk/astro/client/react";
+
+const props = {
+ ...Astro.props
+}
+---
+
+<SignInButtonReact
+ client:load
+ {...props}
+/>


So in general we still are not sure if we are keeping astro-components/react. Do you think we should ?

I think we should just drop it. Unstyled components won't benefit here anyway since islands don't support React.cloneElement

panteliselef · 2024-07-08T18:22:48Z

+ btn.addEventListener("click", () => {
+ window.Clerk.signOut({ redirectUrl })
+ });


I know that this is how it is implemented in clerk-react but can you find out if we maybe need to respect all the functionality signOut provides ? Type here

Nice catch. I think we need to respect the sessionId since it's needed if a user wants to sign out of a specific session.
Also, looking at the SignOutButtonreference, the callback is never stated and it's recommended to migrate to redirectUrl in the Core 2 migration doc. So are we looking at deprecation of the callback property in the future here?
The signOutCallback prop on the component has been removed. Instead, you can use the redirectUrl prop

Added sessionId to sign out options. We had a small discussion in Slack about this. signOutCallback is removed.
Here's a reference to where the sessionId was accidentally ignored

chore(astro): use data attribute in referencing unstyled components

Co-authored-by: panteliselef <panteliselef@outlook.com>

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch from 1216188 to dc34eb8Compare July 3, 2024 22:44

wobsoriano changed the title ~~feat(astro): Add unstyled components~~chore(astro): Add unstyled componentsJul 3, 2024

Base automatically changed from elef/introduce-astro-sdk to mainJuly 4, 2024 09:51

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch 2 times, most recently from 5e251ae to 5aa67d0Compare July 4, 2024 15:57

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/react/SignInButton.astro Outdated

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/unstyled/SignInButton.astro Outdated

wobsoriano commented Jul 4, 2024
View reviewed changes

wobsoriano marked this pull request as ready for review July 4, 2024 16:09

wobsoriano requested a review from panteliselef July 4, 2024 16:09

wobsoriano marked this pull request as draft July 4, 2024 16:24

wobsoriano marked this pull request as ready for review July 4, 2024 17:58

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/unstyled/SignInButton.astro Outdated

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/unstyled/SignInButton.astro Outdated

panteliselef assigned wobsoriano Jul 5, 2024

wobsoriano mentioned this pull request Jul 5, 2024
chore(astro): Remove duplicate logic in interactive components #3664
Merged
9 tasks

clerk-cookie added nextjs actions integration testing and removed nextjs actions integration testing labels Jul 5, 2024

panteliselef reviewed Jul 8, 2024
View reviewed changes

panteliselef added 4 commits July 8, 2024 12:08

feat(astro): Introduce Astro SDK
65ab498

chore(astro): Cleanup
52bb715

chore(astro): Drop deprecations
f6ae5ae

chore(astro): Make hotloading the default
0421dd0

wobsoriano added 11 commits July 8, 2024 12:08

chore(astro): add react unstyled components
3f6b158

chore(astro): add astro unstyled components
2e0aa4f

chore(astro): fix typescript error in signout click handler
82226fd

chore(astro): update polymorphic element name for clarity
243f023

chore(astro): spread element props in dynamic tag
a596fd2

chore(astro): make sure options dont merge with element props
f247208

chore(astro): add missing redirectUrl prop type
9809f1d

chore(astro): add default slot content
2a79d56

chore(astro): add changeset
5b5272d

chore(astro): add comments regarding duplicate functions
62b269a

chore(astro): add comments regarding duplicate functions
d405525

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch from 3118dbf to d405525Compare July 8, 2024 19:19

chore(astro): use data attribute in referencing unstyled components
45ae288
chore(astro): use data attribute in referencing unstyled components

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch from 0c22841 to 45ae288Compare July 8, 2024 19:34

wobsorianoand others added 6 commits July 8, 2024 13:41

Merge branch 'main' into rob/eco-2-export-unstyled-components
fb964c8

chore(astro): Set default Prop value for Polymorphic types
0754f04

fix(astro): Add build step as dependency for e2e tests (#3677)
209e67f

fix(elements): Correct TS types for verification machine (#3671)
f4a1500

chore(astro): Optimize stream modification (#3673)
6c609c7
Co-authored-by: panteliselef <panteliselef@outlook.com>

chore(astro): Add session id prop to sign out button
380c329

clerk-cookie added the elements label Jul 9, 2024

Merge branch 'main' into rob/eco-2-export-unstyled-components
ec8a1d4

clerk-cookie removed the elements label Jul 9, 2024

wobsoriano added 2 commits July 9, 2024 10:52

chore(astro): Remove wrapped unstyled react components
61db931

chore(astro): Fix children prop type
7e92620

panteliselef approved these changes Jul 9, 2024
View reviewed changes

Merge branch 'main' into rob/eco-2-export-unstyled-components
0d9ccf9

wobsoriano merged commit 7ffb4b0 into mainJul 9, 2024

wobsoriano deleted the rob/eco-2-export-unstyled-components branch July 9, 2024 19:44

clerk-cookie mentioned this pull request Jul 9, 2024
ci(repo): Version packages #3668
Merged

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch from 1216188 to dc34eb8Compare July 3, 2024 22:44

wobsoriano changed the title ~~feat(astro): Add unstyled components~~chore(astro): Add unstyled componentsJul 3, 2024

Base automatically changed from elef/introduce-astro-sdk to mainJuly 4, 2024 09:51

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch 2 times, most recently from 5e251ae to 5aa67d0Compare July 4, 2024 15:57

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/react/SignInButton.astro Outdated

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/unstyled/SignInButton.astro Outdated

wobsoriano commented Jul 4, 2024
View reviewed changes

wobsoriano marked this pull request as ready for review July 4, 2024 16:09

wobsoriano requested a review from panteliselef July 4, 2024 16:09

wobsoriano marked this pull request as draft July 4, 2024 16:24

wobsoriano marked this pull request as ready for review July 4, 2024 17:58

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/unstyled/SignInButton.astro Outdated

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/unstyled/SignInButton.astro Outdated

panteliselef assigned wobsoriano Jul 5, 2024

wobsoriano mentioned this pull request Jul 5, 2024
chore(astro): Remove duplicate logic in interactive components #3664
Merged
9 tasks

clerk-cookie added nextjs actions integration testing and removed nextjs actions integration testing labels Jul 5, 2024

panteliselef reviewed Jul 8, 2024
View reviewed changes

panteliselef added 4 commits July 8, 2024 12:08

feat(astro): Introduce Astro SDK
65ab498

chore(astro): Cleanup
52bb715

chore(astro): Drop deprecations
f6ae5ae

chore(astro): Make hotloading the default
0421dd0

wobsoriano added 11 commits July 8, 2024 12:08

chore(astro): add react unstyled components
3f6b158

chore(astro): add astro unstyled components
2e0aa4f

chore(astro): fix typescript error in signout click handler
82226fd

chore(astro): update polymorphic element name for clarity
243f023

chore(astro): spread element props in dynamic tag
a596fd2

chore(astro): make sure options dont merge with element props
f247208

chore(astro): add missing redirectUrl prop type
9809f1d

chore(astro): add default slot content
2a79d56

chore(astro): add changeset
5b5272d

chore(astro): add comments regarding duplicate functions
62b269a

chore(astro): add comments regarding duplicate functions
d405525

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch from 3118dbf to d405525Compare July 8, 2024 19:19

chore(astro): use data attribute in referencing unstyled components
45ae288
chore(astro): use data attribute in referencing unstyled components

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch from 0c22841 to 45ae288Compare July 8, 2024 19:34

wobsorianoand others added 6 commits July 8, 2024 13:41

Merge branch 'main' into rob/eco-2-export-unstyled-components
fb964c8

chore(astro): Set default Prop value for Polymorphic types
0754f04

fix(astro): Add build step as dependency for e2e tests (#3677)
209e67f

fix(elements): Correct TS types for verification machine (#3671)
f4a1500

chore(astro): Optimize stream modification (#3673)
6c609c7
Co-authored-by: panteliselef <panteliselef@outlook.com>

chore(astro): Add session id prop to sign out button
380c329

clerk-cookie added the elements label Jul 9, 2024

Merge branch 'main' into rob/eco-2-export-unstyled-components
ec8a1d4

clerk-cookie removed the elements label Jul 9, 2024

wobsoriano added 2 commits July 9, 2024 10:52

chore(astro): Remove wrapped unstyled react components
61db931

chore(astro): Fix children prop type
7e92620

panteliselef approved these changes Jul 9, 2024
View reviewed changes

Merge branch 'main' into rob/eco-2-export-unstyled-components
0d9ccf9

wobsoriano merged commit 7ffb4b0 into mainJul 9, 2024

wobsoriano deleted the rob/eco-2-export-unstyled-components branch July 9, 2024 19:44

clerk-cookie mentioned this pull request Jul 9, 2024
ci(repo): Version packages #3668
Merged

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch from 1216188 to dc34eb8Compare July 3, 2024 22:44

wobsoriano changed the title ~~feat(astro): Add unstyled components~~chore(astro): Add unstyled componentsJul 3, 2024

Base automatically changed from elef/introduce-astro-sdk to mainJuly 4, 2024 09:51

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch 2 times, most recently from 5e251ae to 5aa67d0Compare July 4, 2024 15:57

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/react/SignInButton.astro Outdated

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/unstyled/SignInButton.astro Outdated

wobsoriano commented Jul 4, 2024
View reviewed changes

wobsoriano marked this pull request as ready for review July 4, 2024 16:09

wobsoriano requested a review from panteliselef July 4, 2024 16:09

wobsoriano marked this pull request as draft July 4, 2024 16:24

wobsoriano marked this pull request as ready for review July 4, 2024 17:58

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/unstyled/SignInButton.astro Outdated

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/unstyled/SignInButton.astro Outdated

panteliselef assigned wobsoriano Jul 5, 2024

wobsoriano mentioned this pull request Jul 5, 2024
chore(astro): Remove duplicate logic in interactive components #3664
Merged
9 tasks

clerk-cookie added nextjs actions integration testing and removed nextjs actions integration testing labels Jul 5, 2024

panteliselef reviewed Jul 8, 2024
View reviewed changes

panteliselef added 4 commits July 8, 2024 12:08

feat(astro): Introduce Astro SDK
65ab498

chore(astro): Cleanup
52bb715

chore(astro): Drop deprecations
f6ae5ae

chore(astro): Make hotloading the default
0421dd0

wobsoriano added 11 commits July 8, 2024 12:08

chore(astro): add react unstyled components
3f6b158

chore(astro): add astro unstyled components
2e0aa4f

chore(astro): fix typescript error in signout click handler
82226fd

chore(astro): update polymorphic element name for clarity
243f023

chore(astro): spread element props in dynamic tag
a596fd2

chore(astro): make sure options dont merge with element props
f247208

chore(astro): add missing redirectUrl prop type
9809f1d

chore(astro): add default slot content
2a79d56

chore(astro): add changeset
5b5272d

chore(astro): add comments regarding duplicate functions
62b269a

chore(astro): add comments regarding duplicate functions
d405525

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch from 3118dbf to d405525Compare July 8, 2024 19:19

chore(astro): use data attribute in referencing unstyled components
45ae288
chore(astro): use data attribute in referencing unstyled components

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch from 0c22841 to 45ae288Compare July 8, 2024 19:34

wobsorianoand others added 6 commits July 8, 2024 13:41

Merge branch 'main' into rob/eco-2-export-unstyled-components
fb964c8

chore(astro): Set default Prop value for Polymorphic types
0754f04

fix(astro): Add build step as dependency for e2e tests (#3677)
209e67f

fix(elements): Correct TS types for verification machine (#3671)
f4a1500

chore(astro): Optimize stream modification (#3673)
6c609c7
Co-authored-by: panteliselef <panteliselef@outlook.com>

chore(astro): Add session id prop to sign out button
380c329

clerk-cookie added the elements label Jul 9, 2024

Merge branch 'main' into rob/eco-2-export-unstyled-components
ec8a1d4

clerk-cookie removed the elements label Jul 9, 2024

wobsoriano added 2 commits July 9, 2024 10:52

chore(astro): Remove wrapped unstyled react components
61db931

chore(astro): Fix children prop type
7e92620

panteliselef approved these changes Jul 9, 2024
View reviewed changes

Merge branch 'main' into rob/eco-2-export-unstyled-components
0d9ccf9

wobsoriano merged commit 7ffb4b0 into mainJul 9, 2024

wobsoriano deleted the rob/eco-2-export-unstyled-components branch July 9, 2024 19:44

clerk-cookie mentioned this pull request Jul 9, 2024
ci(repo): Version packages #3668
Merged

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch from 1216188 to dc34eb8Compare July 3, 2024 22:44

wobsoriano changed the title ~~feat(astro): Add unstyled components~~chore(astro): Add unstyled componentsJul 3, 2024

Base automatically changed from elef/introduce-astro-sdk to mainJuly 4, 2024 09:51

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch 2 times, most recently from 5e251ae to 5aa67d0Compare July 4, 2024 15:57

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/react/SignInButton.astro Outdated

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/unstyled/SignInButton.astro Outdated

wobsoriano commented Jul 4, 2024
View reviewed changes

wobsoriano marked this pull request as ready for review July 4, 2024 16:09

wobsoriano requested a review from panteliselef July 4, 2024 16:09

wobsoriano marked this pull request as draft July 4, 2024 16:24

wobsoriano marked this pull request as ready for review July 4, 2024 17:58

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/unstyled/SignInButton.astro Outdated

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/unstyled/SignInButton.astro Outdated

panteliselef assigned wobsoriano Jul 5, 2024

wobsoriano mentioned this pull request Jul 5, 2024
chore(astro): Remove duplicate logic in interactive components #3664
Merged
9 tasks

clerk-cookie added nextjs actions integration testing and removed nextjs actions integration testing labels Jul 5, 2024

panteliselef reviewed Jul 8, 2024
View reviewed changes

panteliselef added 4 commits July 8, 2024 12:08

feat(astro): Introduce Astro SDK
65ab498

chore(astro): Cleanup
52bb715

chore(astro): Drop deprecations
f6ae5ae

chore(astro): Make hotloading the default
0421dd0

wobsoriano added 11 commits July 8, 2024 12:08

chore(astro): add react unstyled components
3f6b158

chore(astro): add astro unstyled components
2e0aa4f

chore(astro): fix typescript error in signout click handler
82226fd

chore(astro): update polymorphic element name for clarity
243f023

chore(astro): spread element props in dynamic tag
a596fd2

chore(astro): make sure options dont merge with element props
f247208

chore(astro): add missing redirectUrl prop type
9809f1d

chore(astro): add default slot content
2a79d56

chore(astro): add changeset
5b5272d

chore(astro): add comments regarding duplicate functions
62b269a

chore(astro): add comments regarding duplicate functions
d405525

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch from 3118dbf to d405525Compare July 8, 2024 19:19

chore(astro): use data attribute in referencing unstyled components
45ae288
chore(astro): use data attribute in referencing unstyled components

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch from 0c22841 to 45ae288Compare July 8, 2024 19:34

wobsorianoand others added 6 commits July 8, 2024 13:41

Merge branch 'main' into rob/eco-2-export-unstyled-components
fb964c8

chore(astro): Set default Prop value for Polymorphic types
0754f04

fix(astro): Add build step as dependency for e2e tests (#3677)
209e67f

fix(elements): Correct TS types for verification machine (#3671)
f4a1500

chore(astro): Optimize stream modification (#3673)
6c609c7
Co-authored-by: panteliselef <panteliselef@outlook.com>

chore(astro): Add session id prop to sign out button
380c329

clerk-cookie added the elements label Jul 9, 2024

Merge branch 'main' into rob/eco-2-export-unstyled-components
ec8a1d4

clerk-cookie removed the elements label Jul 9, 2024

wobsoriano added 2 commits July 9, 2024 10:52

chore(astro): Remove wrapped unstyled react components
61db931

chore(astro): Fix children prop type
7e92620

panteliselef approved these changes Jul 9, 2024
View reviewed changes

Merge branch 'main' into rob/eco-2-export-unstyled-components
0d9ccf9

wobsoriano merged commit 7ffb4b0 into mainJul 9, 2024

wobsoriano deleted the rob/eco-2-export-unstyled-components branch July 9, 2024 19:44

clerk-cookie mentioned this pull request Jul 9, 2024
ci(repo): Version packages #3668
Merged

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch from 1216188 to dc34eb8Compare July 3, 2024 22:44

wobsoriano changed the title ~~feat(astro): Add unstyled components~~chore(astro): Add unstyled componentsJul 3, 2024

Base automatically changed from elef/introduce-astro-sdk to mainJuly 4, 2024 09:51

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch 2 times, most recently from 5e251ae to 5aa67d0Compare July 4, 2024 15:57

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/react/SignInButton.astro Outdated

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/unstyled/SignInButton.astro Outdated

wobsoriano commented Jul 4, 2024
View reviewed changes

wobsoriano marked this pull request as ready for review July 4, 2024 16:09

wobsoriano requested a review from panteliselef July 4, 2024 16:09

wobsoriano marked this pull request as draft July 4, 2024 16:24

wobsoriano marked this pull request as ready for review July 4, 2024 17:58

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/unstyled/SignInButton.astro Outdated

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/unstyled/SignInButton.astro Outdated

panteliselef assigned wobsoriano Jul 5, 2024

wobsoriano mentioned this pull request Jul 5, 2024
chore(astro): Remove duplicate logic in interactive components #3664
Merged
9 tasks

clerk-cookie added nextjs actions integration testing and removed nextjs actions integration testing labels Jul 5, 2024

panteliselef reviewed Jul 8, 2024
View reviewed changes

panteliselef added 4 commits July 8, 2024 12:08

feat(astro): Introduce Astro SDK
65ab498

chore(astro): Cleanup
52bb715

chore(astro): Drop deprecations
f6ae5ae

chore(astro): Make hotloading the default
0421dd0

wobsoriano added 11 commits July 8, 2024 12:08

chore(astro): add react unstyled components
3f6b158

chore(astro): add astro unstyled components
2e0aa4f

chore(astro): fix typescript error in signout click handler
82226fd

chore(astro): update polymorphic element name for clarity
243f023

chore(astro): spread element props in dynamic tag
a596fd2

chore(astro): make sure options dont merge with element props
f247208

chore(astro): add missing redirectUrl prop type
9809f1d

chore(astro): add default slot content
2a79d56

chore(astro): add changeset
5b5272d

chore(astro): add comments regarding duplicate functions
62b269a

chore(astro): add comments regarding duplicate functions
d405525

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch from 3118dbf to d405525Compare July 8, 2024 19:19

chore(astro): use data attribute in referencing unstyled components
45ae288
chore(astro): use data attribute in referencing unstyled components

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch from 0c22841 to 45ae288Compare July 8, 2024 19:34

wobsorianoand others added 6 commits July 8, 2024 13:41

Merge branch 'main' into rob/eco-2-export-unstyled-components
fb964c8

chore(astro): Set default Prop value for Polymorphic types
0754f04

fix(astro): Add build step as dependency for e2e tests (#3677)
209e67f

fix(elements): Correct TS types for verification machine (#3671)
f4a1500

chore(astro): Optimize stream modification (#3673)
6c609c7
Co-authored-by: panteliselef <panteliselef@outlook.com>

chore(astro): Add session id prop to sign out button
380c329

clerk-cookie added the elements label Jul 9, 2024

Merge branch 'main' into rob/eco-2-export-unstyled-components
ec8a1d4

clerk-cookie removed the elements label Jul 9, 2024

wobsoriano added 2 commits July 9, 2024 10:52

chore(astro): Remove wrapped unstyled react components
61db931

chore(astro): Fix children prop type
7e92620

panteliselef approved these changes Jul 9, 2024
View reviewed changes

Merge branch 'main' into rob/eco-2-export-unstyled-components
0d9ccf9

wobsoriano merged commit 7ffb4b0 into mainJul 9, 2024

wobsoriano deleted the rob/eco-2-export-unstyled-components branch July 9, 2024 19:44

clerk-cookie mentioned this pull request Jul 9, 2024
ci(repo): Version packages #3668
Merged

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch from 1216188 to dc34eb8Compare July 3, 2024 22:44

wobsoriano changed the title ~~feat(astro): Add unstyled components~~chore(astro): Add unstyled componentsJul 3, 2024

Base automatically changed from elef/introduce-astro-sdk to mainJuly 4, 2024 09:51

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch 2 times, most recently from 5e251ae to 5aa67d0Compare July 4, 2024 15:57

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/react/SignInButton.astro Outdated

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/unstyled/SignInButton.astro Outdated

wobsoriano commented Jul 4, 2024
View reviewed changes

wobsoriano marked this pull request as ready for review July 4, 2024 16:09

wobsoriano requested a review from panteliselef July 4, 2024 16:09

wobsoriano marked this pull request as draft July 4, 2024 16:24

wobsoriano marked this pull request as ready for review July 4, 2024 17:58

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/unstyled/SignInButton.astro Outdated

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/unstyled/SignInButton.astro Outdated

panteliselef assigned wobsoriano Jul 5, 2024

wobsoriano mentioned this pull request Jul 5, 2024
chore(astro): Remove duplicate logic in interactive components #3664
Merged
9 tasks

clerk-cookie added nextjs actions integration testing and removed nextjs actions integration testing labels Jul 5, 2024

panteliselef reviewed Jul 8, 2024
View reviewed changes

panteliselef added 4 commits July 8, 2024 12:08

feat(astro): Introduce Astro SDK
65ab498

chore(astro): Cleanup
52bb715

chore(astro): Drop deprecations
f6ae5ae

chore(astro): Make hotloading the default
0421dd0

wobsoriano added 11 commits July 8, 2024 12:08

chore(astro): add react unstyled components
3f6b158

chore(astro): add astro unstyled components
2e0aa4f

chore(astro): fix typescript error in signout click handler
82226fd

chore(astro): update polymorphic element name for clarity
243f023

chore(astro): spread element props in dynamic tag
a596fd2

chore(astro): make sure options dont merge with element props
f247208

chore(astro): add missing redirectUrl prop type
9809f1d

chore(astro): add default slot content
2a79d56

chore(astro): add changeset
5b5272d

chore(astro): add comments regarding duplicate functions
62b269a

chore(astro): add comments regarding duplicate functions
d405525

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch from 3118dbf to d405525Compare July 8, 2024 19:19

chore(astro): use data attribute in referencing unstyled components
45ae288
chore(astro): use data attribute in referencing unstyled components

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch from 0c22841 to 45ae288Compare July 8, 2024 19:34

wobsorianoand others added 6 commits July 8, 2024 13:41

Merge branch 'main' into rob/eco-2-export-unstyled-components
fb964c8

chore(astro): Set default Prop value for Polymorphic types
0754f04

fix(astro): Add build step as dependency for e2e tests (#3677)
209e67f

fix(elements): Correct TS types for verification machine (#3671)
f4a1500

chore(astro): Optimize stream modification (#3673)
6c609c7
Co-authored-by: panteliselef <panteliselef@outlook.com>

chore(astro): Add session id prop to sign out button
380c329

clerk-cookie added the elements label Jul 9, 2024

Merge branch 'main' into rob/eco-2-export-unstyled-components
ec8a1d4

clerk-cookie removed the elements label Jul 9, 2024

wobsoriano added 2 commits July 9, 2024 10:52

chore(astro): Remove wrapped unstyled react components
61db931

chore(astro): Fix children prop type
7e92620

panteliselef approved these changes Jul 9, 2024
View reviewed changes

Merge branch 'main' into rob/eco-2-export-unstyled-components
0d9ccf9

wobsoriano merged commit 7ffb4b0 into mainJul 9, 2024

wobsoriano deleted the rob/eco-2-export-unstyled-components branch July 9, 2024 19:44

clerk-cookie mentioned this pull request Jul 9, 2024
ci(repo): Version packages #3668
Merged

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch from 1216188 to dc34eb8Compare July 3, 2024 22:44

wobsoriano changed the title ~~feat(astro): Add unstyled components~~chore(astro): Add unstyled componentsJul 3, 2024

Base automatically changed from elef/introduce-astro-sdk to mainJuly 4, 2024 09:51

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch 2 times, most recently from 5e251ae to 5aa67d0Compare July 4, 2024 15:57

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/react/SignInButton.astro Outdated

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/unstyled/SignInButton.astro Outdated

wobsoriano commented Jul 4, 2024
View reviewed changes

wobsoriano marked this pull request as ready for review July 4, 2024 16:09

wobsoriano requested a review from panteliselef July 4, 2024 16:09

wobsoriano marked this pull request as draft July 4, 2024 16:24

wobsoriano marked this pull request as ready for review July 4, 2024 17:58

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/unstyled/SignInButton.astro Outdated

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/unstyled/SignInButton.astro Outdated

panteliselef assigned wobsoriano Jul 5, 2024

wobsoriano mentioned this pull request Jul 5, 2024
chore(astro): Remove duplicate logic in interactive components #3664
Merged
9 tasks

clerk-cookie added nextjs actions integration testing and removed nextjs actions integration testing labels Jul 5, 2024

panteliselef reviewed Jul 8, 2024
View reviewed changes

panteliselef added 4 commits July 8, 2024 12:08

feat(astro): Introduce Astro SDK
65ab498

chore(astro): Cleanup
52bb715

chore(astro): Drop deprecations
f6ae5ae

chore(astro): Make hotloading the default
0421dd0

wobsoriano added 11 commits July 8, 2024 12:08

chore(astro): add react unstyled components
3f6b158

chore(astro): add astro unstyled components
2e0aa4f

chore(astro): fix typescript error in signout click handler
82226fd

chore(astro): update polymorphic element name for clarity
243f023

chore(astro): spread element props in dynamic tag
a596fd2

chore(astro): make sure options dont merge with element props
f247208

chore(astro): add missing redirectUrl prop type
9809f1d

chore(astro): add default slot content
2a79d56

chore(astro): add changeset
5b5272d

chore(astro): add comments regarding duplicate functions
62b269a

chore(astro): add comments regarding duplicate functions
d405525

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch from 3118dbf to d405525Compare July 8, 2024 19:19

chore(astro): use data attribute in referencing unstyled components
45ae288
chore(astro): use data attribute in referencing unstyled components

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch from 0c22841 to 45ae288Compare July 8, 2024 19:34

wobsorianoand others added 6 commits July 8, 2024 13:41

Merge branch 'main' into rob/eco-2-export-unstyled-components
fb964c8

chore(astro): Set default Prop value for Polymorphic types
0754f04

fix(astro): Add build step as dependency for e2e tests (#3677)
209e67f

fix(elements): Correct TS types for verification machine (#3671)
f4a1500

chore(astro): Optimize stream modification (#3673)
6c609c7
Co-authored-by: panteliselef <panteliselef@outlook.com>

chore(astro): Add session id prop to sign out button
380c329

clerk-cookie added the elements label Jul 9, 2024

Merge branch 'main' into rob/eco-2-export-unstyled-components
ec8a1d4

clerk-cookie removed the elements label Jul 9, 2024

wobsoriano added 2 commits July 9, 2024 10:52

chore(astro): Remove wrapped unstyled react components
61db931

chore(astro): Fix children prop type
7e92620

panteliselef approved these changes Jul 9, 2024
View reviewed changes

Merge branch 'main' into rob/eco-2-export-unstyled-components
0d9ccf9

wobsoriano merged commit 7ffb4b0 into mainJul 9, 2024

wobsoriano deleted the rob/eco-2-export-unstyled-components branch July 9, 2024 19:44

clerk-cookie mentioned this pull request Jul 9, 2024
ci(repo): Version packages #3668
Merged

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch from 1216188 to dc34eb8Compare July 3, 2024 22:44

wobsoriano changed the title ~~feat(astro): Add unstyled components~~chore(astro): Add unstyled componentsJul 3, 2024

Base automatically changed from elef/introduce-astro-sdk to mainJuly 4, 2024 09:51

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch 2 times, most recently from 5e251ae to 5aa67d0Compare July 4, 2024 15:57

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/react/SignInButton.astro Outdated

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/unstyled/SignInButton.astro Outdated

wobsoriano commented Jul 4, 2024
View reviewed changes

wobsoriano marked this pull request as ready for review July 4, 2024 16:09

wobsoriano requested a review from panteliselef July 4, 2024 16:09

wobsoriano marked this pull request as draft July 4, 2024 16:24

wobsoriano marked this pull request as ready for review July 4, 2024 17:58

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/unstyled/SignInButton.astro Outdated

wobsoriano commented Jul 4, 2024
View reviewed changes

Comment threadpackages/astro/src/astro-components/unstyled/SignInButton.astro Outdated

panteliselef assigned wobsoriano Jul 5, 2024

wobsoriano mentioned this pull request Jul 5, 2024
chore(astro): Remove duplicate logic in interactive components #3664
Merged
9 tasks

clerk-cookie added nextjs actions integration testing and removed nextjs actions integration testing labels Jul 5, 2024

panteliselef reviewed Jul 8, 2024
View reviewed changes

panteliselef added 4 commits July 8, 2024 12:08

feat(astro): Introduce Astro SDK
65ab498

chore(astro): Cleanup
52bb715

chore(astro): Drop deprecations
f6ae5ae

chore(astro): Make hotloading the default
0421dd0

wobsoriano added 11 commits July 8, 2024 12:08

chore(astro): add react unstyled components
3f6b158

chore(astro): add astro unstyled components
2e0aa4f

chore(astro): fix typescript error in signout click handler
82226fd

chore(astro): update polymorphic element name for clarity
243f023

chore(astro): spread element props in dynamic tag
a596fd2

chore(astro): make sure options dont merge with element props
f247208

chore(astro): add missing redirectUrl prop type
9809f1d

chore(astro): add default slot content
2a79d56

chore(astro): add changeset
5b5272d

chore(astro): add comments regarding duplicate functions
62b269a

chore(astro): add comments regarding duplicate functions
d405525

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch from 3118dbf to d405525Compare July 8, 2024 19:19

chore(astro): use data attribute in referencing unstyled components
45ae288
chore(astro): use data attribute in referencing unstyled components

wobsoriano force-pushed the rob/eco-2-export-unstyled-components branch from 0c22841 to 45ae288Compare July 8, 2024 19:34

wobsorianoand others added 6 commits July 8, 2024 13:41

Merge branch 'main' into rob/eco-2-export-unstyled-components
fb964c8

chore(astro): Set default Prop value for Polymorphic types
0754f04

fix(astro): Add build step as dependency for e2e tests (#3677)
209e67f

fix(elements): Correct TS types for verification machine (#3671)
f4a1500

chore(astro): Optimize stream modification (#3673)
6c609c7
Co-authored-by: panteliselef <panteliselef@outlook.com>

chore(astro): Add session id prop to sign out button
380c329

clerk-cookie added the elements label Jul 9, 2024

Merge branch 'main' into rob/eco-2-export-unstyled-components
ec8a1d4

clerk-cookie removed the elements label Jul 9, 2024

wobsoriano added 2 commits July 9, 2024 10:52

chore(astro): Remove wrapped unstyled react components
61db931

chore(astro): Fix children prop type
7e92620

panteliselef approved these changes Jul 9, 2024
View reviewed changes

Merge branch 'main' into rob/eco-2-export-unstyled-components
0d9ccf9

wobsoriano merged commit 7ffb4b0 into mainJul 9, 2024

wobsoriano deleted the rob/eco-2-export-unstyled-components branch July 9, 2024 19:44

clerk-cookie mentioned this pull request Jul 9, 2024
ci(repo): Version packages #3668
Merged

		import { customAlphabet, urlAlphabet } from "nanoid";

		const safeId = customAlphabet(urlAlphabet, 10)();

Uh oh!

Conversation

wobsoriano commented Jul 2, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

changeset-botBot commented Jul 2, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

Uh oh!

wobsorianoJul 4, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wobsorianoJul 8, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wobsorianoJul 9, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

wobsoriano commented Jul 2, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

changeset-botBot commented Jul 2, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

Uh oh!

wobsorianoJul 4, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wobsorianoJul 8, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wobsorianoJul 9, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wobsoriano commented Jul 2, 2024•
edited
Loading

changeset-botBot commented Jul 2, 2024•
edited
Loading

wobsorianoJul 4, 2024•
edited
Loading

wobsorianoJul 8, 2024•
edited
Loading

wobsorianoJul 9, 2024•
edited
Loading

wobsoriano commented Jul 2, 2024•
edited
Loading

changeset-botBot commented Jul 2, 2024•
edited
Loading

wobsorianoJul 4, 2024•
edited
Loading

wobsorianoJul 8, 2024•
edited
Loading

wobsorianoJul 9, 2024•
edited
Loading

wobsoriano commented Jul 2, 2024•
edited
Loading

changeset-botBot commented Jul 2, 2024•
edited
Loading

wobsorianoJul 4, 2024•
edited
Loading

wobsorianoJul 8, 2024•
edited
Loading

wobsorianoJul 9, 2024•
edited
Loading