Skip to content

fix(types,elements,clerk-js): Update types to account for null second factors - #3780

Merged
LekoArts merged 1 commit into
mainfrom
ds.fix/null-second-factors
Jul 23, 2024
Merged

fix(types,elements,clerk-js): Update types to account for null second factors#3780
LekoArts merged 1 commit into
mainfrom
ds.fix/null-second-factors

Conversation

@dstaley

Copy link
Copy Markdown
Member

Description

This PR updates the types for supportedSecondFactors to account for the fact that the API can return a null value. This was mostly already encoded into the application logic, so the only logic change was adding a logical AND where we were calling Array.sort on a value that was potentially null.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3cd966e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
NameType
@clerk/clerk-jsPatch
@clerk/elementsPatch
@clerk/typesPatch
@clerk/astroPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/backendPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/clerk-sdk-nodePatch
@clerk/sharedPatch
@clerk/tanstack-startPatch
@clerk/testingPatch
@clerk/themesPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LekoArts
LekoArts merged commit 86c75e5 into mainJul 23, 2024
@LekoArts
LekoArts deleted the ds.fix/null-second-factors branch July 23, 2024 08:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dstaley@LekoArts@clerk-cookie