Skip to content

chore(gatsby-plugin-clerk): Add transition period notice - #3840

Merged
wobsoriano merged 5 commits into
mainfrom
rob/eco-86-add-notice-of-eol-on-repo-readme
Aug 1, 2024
Merged

chore(gatsby-plugin-clerk): Add transition period notice#3840
wobsoriano merged 5 commits into
mainfrom
rob/eco-86-add-notice-of-eol-on-repo-readme

Conversation

@wobsoriano

@wobsorianowobsoriano commented Jul 30, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Description

This PR adds notice of plan to EOL Gatsby SDK

Fixes ECO-86 and ECO-92

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented Jul 30, 2024•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5d83cc6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
gatsby-plugin-clerkPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wobsoriano
wobsoriano commented Jul 30, 2024
View reviewed changes
Comment thread.changeset/config.json
"baseBranch": "origin/main",
"updateInternalDependencies": "patch",
"ignore": ["gatsby-plugin-clerk"],
"ignore": [],

@wobsorianowobsorianoJul 30, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporarily removing the gatsby SDK to ignored list so we can publish the notice to NPM

wobsoriano
wobsoriano commented Jul 30, 2024
View reviewed changes
Comment threadpackages/gatsby-plugin-clerk/README.md Outdated
nikosdouvlis
nikosdouvlis approved these changes Aug 1, 2024
View reviewed changes

@nikosdouvlisnikosdouvlis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻
Let's make sure that this package gets released under the 4 version tag before release

@wobsoriano
wobsorianoforce-pushed the rob/eco-86-add-notice-of-eol-on-repo-readme branch from b252aab to 3b35bb3CompareAugust 1, 2024 13:13
@wobsoriano

wobsoriano commented Aug 1, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@nikosdouvlis thanks for reviewing!

That just means updating the version in the package.json file back to 4.4.7 (the last main version), right? Or are there any other steps required?

Also since 4.x.x is in Core 1, would doing this release a 4.x.x in Core 2?

@wobsorianowobsoriano changed the title chore(gatsby): Add transition period noticechore(gatsby-plugin-clerk): Add transition period noticeAug 1, 2024
@wobsoriano
wobsorianoforce-pushed the rob/eco-86-add-notice-of-eol-on-repo-readme branch from a7d7462 to 5d83cc6CompareAugust 1, 2024 15:00
@wobsorianowobsoriano mentioned this pull request Aug 1, 2024
Merged
9 tasks
@wobsoriano
wobsoriano marked this pull request as ready for review August 1, 2024 18:15
@wobsoriano
wobsoriano merged commit 35fb0c7 into mainAug 1, 2024
@wobsoriano
wobsoriano deleted the rob/eco-86-add-notice-of-eol-on-repo-readme branch August 1, 2024 18:47
@clerk-cookieclerk-cookie mentioned this pull request Aug 1, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kylemackylemackylemac approved these changes
@nikosdouvlisnikosdouvlisnikosdouvlis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wobsoriano@kylemac@nikosdouvlis@clerk-cookie