Uh oh!
There was an error while loading. Please reload this page.
feat(elements): Add support for sign in with email_link via redirect_url - #3926
Merged
Conversation
🦋 Changeset detectedLatest commit: 57061c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dstaley
commented
Aug 9, 2024
| params: context.currentFactor as PrepareFirstFactorParams, | ||
| params: { | ||
| ...context.currentFactor, | ||
| redirectUrl: `${window.location.origin}${context.basePath}${MAGIC_LINK_VERIFY_PATH_ROUTE}`, |
MemberAuthor
There was a problem hiding this comment.
It might make sense for this URL to be built somewhere else. In clerk-js we have a buildURL helper that handles appending the origin based on the routing type.
dstaley
marked this pull request as ready for review
August 13, 2024 20:13
alexcarpenter
approved these changes
Aug 15, 2024
alexcarpenter
left a comment
Member
There was a problem hiding this comment.
Tested the flow, and successfully signing in via email link flows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the required
redirectUrlparameter to the prepare call for email_link first factor verification. Currently this only work if Account Portal is disabled.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change