Skip to content

feat(elements): Add active session selection [SDKI-290] - #3957

Merged
tmilewski merged 5 commits into
mainfrom
tm/elements-choose-session
Aug 16, 2024
Merged

feat(elements): Add active session selection [SDKI-290]#3957
tmilewski merged 5 commits into
mainfrom
tm/elements-choose-session

Conversation

@tmilewski

@tmilewskitmilewski commented Aug 14, 2024

Copy link
Copy Markdown
Member

Description

Introduce multi-session choose account step and associated actions/components.

Example:

<SignIn.Stepname='choose-session'><SignIn.SessionList><SignIn.SessionListItem>{({ session })=><>{session.identifier} | <SignIn.ActionsetActiveSession>Switch...</SignIn.Action></>}</SignIn.SessionListItem></SignIn.SessionList></SignIn.Step>

By default, SessionList does not include the current session. Adding includeCurrentSession to SignIn.SessionList will include it.

Fixes SDKI-290

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented Aug 14, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: fc7bd76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/elementsMinor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tmilewski
tmilewskiforce-pushed the tm/elements-choose-session branch from 3ce9121 to 608d43dCompareAugust 16, 2024 15:13
@tmilewskitmilewski self-assigned this Aug 16, 2024
@tmilewski
tmilewski marked this pull request as ready for review August 16, 2024 15:16

@alexcarpenteralexcarpenter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works beautifully 👏🏼 #3973

@tmilewski
tmilewski merged commit 2f37bd2 into mainAug 16, 2024
@tmilewski
tmilewski deleted the tm/elements-choose-session branch August 16, 2024 15:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tmilewski@alexcarpenter@clerk-cookie