feat(nextjs): Handle URL <> Session Org Mismatch in Middleware by izaaklauer · Pull Request #3977 · clerk/javascript

izaaklauer · 2024-08-16T22:38:00Z

What problem is this solving?

Today, when developers use organization slugs in URLs, they need to go through contortions to be able to depend on the organization data in the clerk session, especially in server-rendered pages. In short, they need to detect the mismatch between the URL and the session on the server component, punt back to client-side javascript that can call setActive for the org as specified by the URL, and then re-render the server component. See some of that workflow here: https://clerk.com/docs/guides/force-organizations#set-an-active-organization-based-on-the-url

What changed?

This PR introduces a new NextJS middleware option that allows developers to specify their URL structure to the middleware - specifically which url patterns indicate a desire to activate the personal workspace or an organization, and if so which one (by slug or ID).

The middleware then checks the actual URL against that pattern, and if it detects a mismatch between the desired-active organization (from the url) and the actually-active organization (from the session), it performs a handshake with a new query param, which will activate the new organization.

What does the new API look like?

Imagine an application that supports organizations and the personal workspace, but includes both in their URLs. The might have URLs like:

URL	Indicates
`/orgs/bcorp`	org with slug "bcorp" should be active
`/orgs/bcorp/settings`	org with slug "bcorp" should be active
`/personal-workspace/home`	the personal workspace should be active

Currently, that application would require special handling in both server and client javascript to detect and resolve an organization mismatch.

Now, they can add middleware config like this:

import{clerkMiddleware,createRouteMatcher}from"@clerk/nextjs/server";constisProtectedRoute=createRouteMatcher(["(.*)"]);exportdefaultclerkMiddleware((auth,req)=>{if(isProtectedRoute(req))auth().protect();},{organizationSyncOptions: {organizationPatterns: ["/orgs/:slug","/orgs/:slug/(.*)",],personalWorkspacePatterns: ["/personal-workspace","/personal-workspace/(.*)"],},});

What's next?

A public-facing guide explaining the new guidance for managing an organization via the URL
A public-facing sample repository demonstrating the new option

What problem is this solving?

Today, when developers use organization slugs in URLs, they need to go through contortions to be able to depend on the organization data in the clerk session, especially in server-rendered pages. In short, they need to detect the mismatch between the URL and the session on the server component, punt back to client-side javascript that can call setActive for the org as specified by the URL, and then re-render the server component. See some of that workflow here: https://clerk.com/docs/guides/force-organizations#set-an-active-organization-based-on-the-url

What changed?

This PR introduces a new NextJS middleware option that allows developers to specify their URL structure to the middleware - specifically which url patterns indicate a desire to activate the personal workspace or an organization, and if so which one (by slug or ID).

The middleware then checks the actual URL against that pattern, and if it detects a mismatch between the desired-active organization (from the url) and the actually-active organization (from the session), it performs a handshake with a new query param, which will activate the new organization.

What does the new API look like?

Imagine an application that supports organizations and the personal workspace, but includes both in their URLs. The might have URLs like:

URL	Indicates
`/orgs/bcorp`	org with slug "bcorp" should be active
`/orgs/bcorp/settings`	org with slug "bcorp" should be active
`/personal-workspace/home`	the personal workspace should be active

Currently, that application would require special handling in both server and client javascript to detect and resolve an organization mismatch.

Now, they can add middleware config like this:

import{clerkMiddleware,createRouteMatcher}from"@clerk/nextjs/server";constisProtectedRoute=createRouteMatcher(["(.*)"]);exportdefaultclerkMiddleware((auth,req)=>{if(isProtectedRoute(req))auth().protect();},{organizationSyncOptions: {organizationPatterns: ["/orgs/:slug","/orgs/:slug/(.*)",],personalWorkspacePatterns: ["/personal-workspace","/personal-workspace/(.*)"],},});

What's next?

A public-facing guide explaining the new guidance for managing an organization via the URL
A public-facing sample repository demonstrating the new option

What problem is this solving?

Today, when developers use organization slugs in URLs, they need to go through contortions to be able to depend on the organization data in the clerk session, especially in server-rendered pages. In short, they need to detect the mismatch between the URL and the session on the server component, punt back to client-side javascript that can call setActive for the org as specified by the URL, and then re-render the server component. See some of that workflow here: https://clerk.com/docs/guides/force-organizations#set-an-active-organization-based-on-the-url

What changed?

This PR introduces a new NextJS middleware option that allows developers to specify their URL structure to the middleware - specifically which url patterns indicate a desire to activate the personal workspace or an organization, and if so which one (by slug or ID).

The middleware then checks the actual URL against that pattern, and if it detects a mismatch between the desired-active organization (from the url) and the actually-active organization (from the session), it performs a handshake with a new query param, which will activate the new organization.

What does the new API look like?

Imagine an application that supports organizations and the personal workspace, but includes both in their URLs. The might have URLs like:

URL	Indicates
`/orgs/bcorp`	org with slug "bcorp" should be active
`/orgs/bcorp/settings`	org with slug "bcorp" should be active
`/personal-workspace/home`	the personal workspace should be active

Currently, that application would require special handling in both server and client javascript to detect and resolve an organization mismatch.

Now, they can add middleware config like this:

import{clerkMiddleware,createRouteMatcher}from"@clerk/nextjs/server";constisProtectedRoute=createRouteMatcher(["(.*)"]);exportdefaultclerkMiddleware((auth,req)=>{if(isProtectedRoute(req))auth().protect();},{organizationSyncOptions: {organizationPatterns: ["/orgs/:slug","/orgs/:slug/(.*)",],personalWorkspacePatterns: ["/personal-workspace","/personal-workspace/(.*)"],},});

What's next?

A public-facing guide explaining the new guidance for managing an organization via the URL
A public-facing sample repository demonstrating the new option

What problem is this solving?

Today, when developers use organization slugs in URLs, they need to go through contortions to be able to depend on the organization data in the clerk session, especially in server-rendered pages. In short, they need to detect the mismatch between the URL and the session on the server component, punt back to client-side javascript that can call setActive for the org as specified by the URL, and then re-render the server component. See some of that workflow here: https://clerk.com/docs/guides/force-organizations#set-an-active-organization-based-on-the-url

What changed?

This PR introduces a new NextJS middleware option that allows developers to specify their URL structure to the middleware - specifically which url patterns indicate a desire to activate the personal workspace or an organization, and if so which one (by slug or ID).

The middleware then checks the actual URL against that pattern, and if it detects a mismatch between the desired-active organization (from the url) and the actually-active organization (from the session), it performs a handshake with a new query param, which will activate the new organization.

What does the new API look like?

Imagine an application that supports organizations and the personal workspace, but includes both in their URLs. The might have URLs like:

URL	Indicates
`/orgs/bcorp`	org with slug "bcorp" should be active
`/orgs/bcorp/settings`	org with slug "bcorp" should be active
`/personal-workspace/home`	the personal workspace should be active

Currently, that application would require special handling in both server and client javascript to detect and resolve an organization mismatch.

Now, they can add middleware config like this:

import{clerkMiddleware,createRouteMatcher}from"@clerk/nextjs/server";constisProtectedRoute=createRouteMatcher(["(.*)"]);exportdefaultclerkMiddleware((auth,req)=>{if(isProtectedRoute(req))auth().protect();},{organizationSyncOptions: {organizationPatterns: ["/orgs/:slug","/orgs/:slug/(.*)",],personalWorkspacePatterns: ["/personal-workspace","/personal-workspace/(.*)"],},});

What's next?

A public-facing guide explaining the new guidance for managing an organization via the URL
A public-facing sample repository demonstrating the new option

What problem is this solving?

Today, when developers use organization slugs in URLs, they need to go through contortions to be able to depend on the organization data in the clerk session, especially in server-rendered pages. In short, they need to detect the mismatch between the URL and the session on the server component, punt back to client-side javascript that can call setActive for the org as specified by the URL, and then re-render the server component. See some of that workflow here: https://clerk.com/docs/guides/force-organizations#set-an-active-organization-based-on-the-url

What changed?

This PR introduces a new NextJS middleware option that allows developers to specify their URL structure to the middleware - specifically which url patterns indicate a desire to activate the personal workspace or an organization, and if so which one (by slug or ID).

The middleware then checks the actual URL against that pattern, and if it detects a mismatch between the desired-active organization (from the url) and the actually-active organization (from the session), it performs a handshake with a new query param, which will activate the new organization.

What does the new API look like?

Imagine an application that supports organizations and the personal workspace, but includes both in their URLs. The might have URLs like:

URL	Indicates
`/orgs/bcorp`	org with slug "bcorp" should be active
`/orgs/bcorp/settings`	org with slug "bcorp" should be active
`/personal-workspace/home`	the personal workspace should be active

Currently, that application would require special handling in both server and client javascript to detect and resolve an organization mismatch.

Now, they can add middleware config like this:

import{clerkMiddleware,createRouteMatcher}from"@clerk/nextjs/server";constisProtectedRoute=createRouteMatcher(["(.*)"]);exportdefaultclerkMiddleware((auth,req)=>{if(isProtectedRoute(req))auth().protect();},{organizationSyncOptions: {organizationPatterns: ["/orgs/:slug","/orgs/:slug/(.*)",],personalWorkspacePatterns: ["/personal-workspace","/personal-workspace/(.*)"],},});

What's next?

A public-facing guide explaining the new guidance for managing an organization via the URL
A public-facing sample repository demonstrating the new option

What problem is this solving?

Today, when developers use organization slugs in URLs, they need to go through contortions to be able to depend on the organization data in the clerk session, especially in server-rendered pages. In short, they need to detect the mismatch between the URL and the session on the server component, punt back to client-side javascript that can call setActive for the org as specified by the URL, and then re-render the server component. See some of that workflow here: https://clerk.com/docs/guides/force-organizations#set-an-active-organization-based-on-the-url

What changed?

This PR introduces a new NextJS middleware option that allows developers to specify their URL structure to the middleware - specifically which url patterns indicate a desire to activate the personal workspace or an organization, and if so which one (by slug or ID).

The middleware then checks the actual URL against that pattern, and if it detects a mismatch between the desired-active organization (from the url) and the actually-active organization (from the session), it performs a handshake with a new query param, which will activate the new organization.

What does the new API look like?

Imagine an application that supports organizations and the personal workspace, but includes both in their URLs. The might have URLs like:

URL	Indicates
`/orgs/bcorp`	org with slug "bcorp" should be active
`/orgs/bcorp/settings`	org with slug "bcorp" should be active
`/personal-workspace/home`	the personal workspace should be active

Currently, that application would require special handling in both server and client javascript to detect and resolve an organization mismatch.

Now, they can add middleware config like this:

import{clerkMiddleware,createRouteMatcher}from"@clerk/nextjs/server";constisProtectedRoute=createRouteMatcher(["(.*)"]);exportdefaultclerkMiddleware((auth,req)=>{if(isProtectedRoute(req))auth().protect();},{organizationSyncOptions: {organizationPatterns: ["/orgs/:slug","/orgs/:slug/(.*)",],personalWorkspacePatterns: ["/personal-workspace","/personal-workspace/(.*)"],},});

What's next?

A public-facing guide explaining the new guidance for managing an organization via the URL
A public-facing sample repository demonstrating the new option

What problem is this solving?

Today, when developers use organization slugs in URLs, they need to go through contortions to be able to depend on the organization data in the clerk session, especially in server-rendered pages. In short, they need to detect the mismatch between the URL and the session on the server component, punt back to client-side javascript that can call setActive for the org as specified by the URL, and then re-render the server component. See some of that workflow here: https://clerk.com/docs/guides/force-organizations#set-an-active-organization-based-on-the-url

What changed?

This PR introduces a new NextJS middleware option that allows developers to specify their URL structure to the middleware - specifically which url patterns indicate a desire to activate the personal workspace or an organization, and if so which one (by slug or ID).

The middleware then checks the actual URL against that pattern, and if it detects a mismatch between the desired-active organization (from the url) and the actually-active organization (from the session), it performs a handshake with a new query param, which will activate the new organization.

What does the new API look like?

Imagine an application that supports organizations and the personal workspace, but includes both in their URLs. The might have URLs like:

URL	Indicates
`/orgs/bcorp`	org with slug "bcorp" should be active
`/orgs/bcorp/settings`	org with slug "bcorp" should be active
`/personal-workspace/home`	the personal workspace should be active

Currently, that application would require special handling in both server and client javascript to detect and resolve an organization mismatch.

Now, they can add middleware config like this:

import{clerkMiddleware,createRouteMatcher}from"@clerk/nextjs/server";constisProtectedRoute=createRouteMatcher(["(.*)"]);exportdefaultclerkMiddleware((auth,req)=>{if(isProtectedRoute(req))auth().protect();},{organizationSyncOptions: {organizationPatterns: ["/orgs/:slug","/orgs/:slug/(.*)",],personalWorkspacePatterns: ["/personal-workspace","/personal-workspace/(.*)"],},});

What's next?

A public-facing guide explaining the new guidance for managing an organization via the URL
A public-facing sample repository demonstrating the new option

What problem is this solving?

Today, when developers use organization slugs in URLs, they need to go through contortions to be able to depend on the organization data in the clerk session, especially in server-rendered pages. In short, they need to detect the mismatch between the URL and the session on the server component, punt back to client-side javascript that can call setActive for the org as specified by the URL, and then re-render the server component. See some of that workflow here: https://clerk.com/docs/guides/force-organizations#set-an-active-organization-based-on-the-url

What changed?

This PR introduces a new NextJS middleware option that allows developers to specify their URL structure to the middleware - specifically which url patterns indicate a desire to activate the personal workspace or an organization, and if so which one (by slug or ID).

The middleware then checks the actual URL against that pattern, and if it detects a mismatch between the desired-active organization (from the url) and the actually-active organization (from the session), it performs a handshake with a new query param, which will activate the new organization.

What does the new API look like?

Imagine an application that supports organizations and the personal workspace, but includes both in their URLs. The might have URLs like:

URL	Indicates
`/orgs/bcorp`	org with slug "bcorp" should be active
`/orgs/bcorp/settings`	org with slug "bcorp" should be active
`/personal-workspace/home`	the personal workspace should be active

Currently, that application would require special handling in both server and client javascript to detect and resolve an organization mismatch.

Now, they can add middleware config like this:

import{clerkMiddleware,createRouteMatcher}from"@clerk/nextjs/server";constisProtectedRoute=createRouteMatcher(["(.*)"]);exportdefaultclerkMiddleware((auth,req)=>{if(isProtectedRoute(req))auth().protect();},{organizationSyncOptions: {organizationPatterns: ["/orgs/:slug","/orgs/:slug/(.*)",],personalWorkspacePatterns: ["/personal-workspace","/personal-workspace/(.*)"],},});

What's next?

A public-facing guide explaining the new guidance for managing an organization via the URL
A public-facing sample repository demonstrating the new option

+ organizationPatterns?: Array<Pattern>;
+
+ /**
+ * URL patterns for resources in the context of a clerk personal workspace (user-specific, outside any organization).
+ * If the route also matches the organizationPattern, this takes precedence.
+ *
+ * Common examples:
+ * - ["/user", "/user/(.*)"]
+ * - ["/user/:any", "/user/:any/(.*)"]
+ */
+ personalWorkspacePatterns?: Array<Pattern>;
+};


Maybe there is a benefit of redefining those for the nextjs package and take advantage of our RouteMatcherWithNextTypedRoutes

And just to double check here, we don't wanna use the createRouteMatcher pattern here, because we are not expecting for folks to use more than one path ? Although the name of the properties hints that you can. If not, I think supporting the route matcher here makes sense.
cc @nikosdouvlis

Good idea! I didn't realize we already have RouteMatcherParams, which serves the same purpose.
It looks like there's some duplication between the astro and nextjs RouteMatcherParams. My inclination here is to make the astro version (which doesn't depend on anything astro-specific) shared, and import that for use here. But let me know if you think another path would be better!
r/e createRouteMatcher - We could take a createRouteMatcher-returned function here too, but my inclination is to start with just accepting the pattern syntax for simplicity and expand the the more complex types if necessary in the future - I explored that a bit here (internal only): https://www.notion.so/Sync-Org-from-URL-to-Session-via-Middleware-f41f00865390480ab2279391c5625b27?d=f3738cb7f62c48bb90f8924c653a83a9&pvs=4#c0b57bf937694dd6bf510aeb4dde12af. Again, differing opinions welcome.

Oh you know, digging in a bit further, I think the main difference here between this and RouteMatcherWithNextTypedRoutes/RouteMatcherRoutes is that they're geared at returning true/false, not pulling information out of the path. For the organization pattern, we need it to include a group (which I have here as :slug or :id). I don't see a clear way to extend the RouteMatcherParams to encompass that without making the type too complex for my taste. I could have the personal workspace pattern use RouteMatcherParams, but I think the mixed types would be worse DX.
And to answer your question:
we are not expecting for folks to use more than one path ?
I am expecting more than one path! It's very tricky to get most practical examples down to just one path expression, so I think allowing multiples is the way to go.

brkalow · 2024-09-30T15:31:01Z

 });
 });
+
+test.describe('Client handshake with organization activation @nextjs', () => {


One thing we've done in the past is pass options via request headers to avoid extra app overhead. Maybe this is something we can also do here?

@panteliselef

Thanks @panteliselef! #3977 (comment)

@brkalow

Responding to #3977 (comment). Thanks @brkalow !

@brkalow

Thanks @brkalow! #3977 (comment)

@brkalow

Thanks @brkalow! #3977 (comment)

brkalow

lgtm!

Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>

WIP - first rough pass at args-based approach
37f0478

clerk-cookie added the backend label Aug 16, 2024

izaaklauer commented Aug 16, 2024
View reviewed changes

Comment threadpackages/backend/src/tokens/request.ts Outdated

clerk-cookie added nextjs integration labels Sep 6, 2024

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 28ece32 to 8dc238fCompare September 6, 2024 22:28

Tested end-to-end with corresponding fapi changes locally
7c3f936

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch 2 times, most recently from cf8ad6c to 509ada1Compare September 6, 2024 22:33

Starting on integration tests
54e6752

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 509ada1 to 54e6752Compare September 6, 2024 22:47

Two more tests
d724695

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from cff9d48 to d724695Compare September 6, 2024 23:12

izaaklauer added 3 commits September 9, 2024 09:47

First pass at table-driven tests
925be56

Trying out server-per-test
fee771a

Now in parallel!
5c575ee

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from d6b3f6b to 5c575eeCompare September 9, 2024 15:32

The table-driven tests are now looking quite nice!
aa84f66

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 42612d2 to aa84f66Compare September 9, 2024 15:55

izaaklauer added 9 commits September 9, 2024 15:16

Doc comments
45a982b

Detecting and handling handshake org sync loops
edffbe0
https://clerkinc.slack.com/archives/C078JFZLLQ3/p1725908922766149

A handful more tests
256bef6

Handling multiple path patterns, better test structure
830dfea

testing paths with sub-resources
63519d9

Merge branch 'main' into izaak/ORGS-132-middleware-orgsync
d77382d

Upgrading path-to-regexp
02823ef
I'll admit, i'm a bit fuzzy here on why it wasn't a dependency before, and also as to why it's only a dev dependency.

Test case with erroneous trailing slash now passing
a6d4136
Turns out someone in the call chain was redirecting before we hit handshake. That's great!

Handling header auth in addition to cookie auth
3a8f583

izaaklauer commented Sep 13, 2024
View reviewed changes

izaaklauerand others added 7 commits September 27, 2024 10:53

Merge branch 'main' into izaak/ORGS-132-middleware-orgsync
0afcd0a

Small refactor to remove redundancy
efc5599

ran npm i
f55a074
Not sure why it made this change, but I believe it.

Running npm run format
f7bec4f

Quieting typescript's objections
4bce2ce

Update packages/backend/src/tokens/request.ts
b7e8ac1
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>

Update packages/backend/src/tokens/request.ts
5ce428d
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 9738a97 to 5ce428dCompare September 27, 2024 18:57

panteliselef reviewed Sep 30, 2024
View reviewed changes

Comment threadpackages/backend/src/tokens/request.ts Outdated

panteliselef reviewed Sep 30, 2024
View reviewed changes

brkalow reviewed Sep 30, 2024
View reviewed changes

izaaklauer added 5 commits October 1, 2024 17:57

Renaming "personal wockrkspace" to "personal account"
5858a24
Thanks @panteliselef! #3977 (comment)

avoiding spinning up a separate sample app per test case
3551d2f

Only computing matchers once for efficency.
9f36a37
Responding to #3977 (comment). Thanks @brkalow !

Making types PascelCase
5780554
Thanks @brkalow! #3977 (comment)

Using more concise array type declaration
4076c03
Thanks @brkalow! #3977 (comment)

izaaklauer requested review from brkalow and panteliselef October 3, 2024 16:09

brkalow approved these changes Oct 4, 2024
View reviewed changes

tmilewski assigned izaaklauer Oct 4, 2024

izaaklauer added 2 commits October 7, 2024 11:43

Reverting an incidental upgrate to path-to-regexp
3aa3f67

Merge branch 'main' into izaak/ORGS-132-middleware-orgsync
bc89068

izaaklauer merged commit 2ea1a60 into mainOct 8, 2024

izaaklauer deleted the izaak/ORGS-132-middleware-orgsync branch October 8, 2024 13:35

clerk-cookie mentioned this pull request Oct 9, 2024
ci(repo): Version packages #4307
Merged

izaaklauer mentioned this pull request Oct 17, 2024
Add organizationSyncOptions prop to clerkMiddleware() options clerk/clerk-docs#1634
Merged

izaaklauer mentioned this pull request Oct 28, 2024
DX Guide: Using Organization Slugs in URLs clerk/clerk-docs#1664
Merged

wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
feat(nextjs): Handle URL <> Session Org Mismatch in Middleware (#3977)
d159185
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>

coderabbitaiBot mentioned this pull request May 10, 2026
implement auth naoya5/ghost-ai#2
Merged

Rohan170603 mentioned this pull request Aug 20, 2026
docs(express): add platform limitation warning for organizationSyncOptions clerk/clerk-docs#3530
Closed

WIP - first rough pass at args-based approach
37f0478

clerk-cookie added the backend label Aug 16, 2024

izaaklauer commented Aug 16, 2024
View reviewed changes

Comment threadpackages/backend/src/tokens/request.ts Outdated

clerk-cookie added nextjs integration labels Sep 6, 2024

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 28ece32 to 8dc238fCompare September 6, 2024 22:28

Tested end-to-end with corresponding fapi changes locally
7c3f936

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch 2 times, most recently from cf8ad6c to 509ada1Compare September 6, 2024 22:33

Starting on integration tests
54e6752

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 509ada1 to 54e6752Compare September 6, 2024 22:47

Two more tests
d724695

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from cff9d48 to d724695Compare September 6, 2024 23:12

izaaklauer added 3 commits September 9, 2024 09:47

First pass at table-driven tests
925be56

Trying out server-per-test
fee771a

Now in parallel!
5c575ee

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from d6b3f6b to 5c575eeCompare September 9, 2024 15:32

The table-driven tests are now looking quite nice!
aa84f66

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 42612d2 to aa84f66Compare September 9, 2024 15:55

izaaklauer added 9 commits September 9, 2024 15:16

Doc comments
45a982b

Detecting and handling handshake org sync loops
edffbe0
https://clerkinc.slack.com/archives/C078JFZLLQ3/p1725908922766149

A handful more tests
256bef6

Handling multiple path patterns, better test structure
830dfea

testing paths with sub-resources
63519d9

Merge branch 'main' into izaak/ORGS-132-middleware-orgsync
d77382d

Upgrading path-to-regexp
02823ef
I'll admit, i'm a bit fuzzy here on why it wasn't a dependency before, and also as to why it's only a dev dependency.

Test case with erroneous trailing slash now passing
a6d4136
Turns out someone in the call chain was redirecting before we hit handshake. That's great!

Handling header auth in addition to cookie auth
3a8f583

izaaklauer commented Sep 13, 2024
View reviewed changes

izaaklauerand others added 7 commits September 27, 2024 10:53

Merge branch 'main' into izaak/ORGS-132-middleware-orgsync
0afcd0a

Small refactor to remove redundancy
efc5599

ran npm i
f55a074
Not sure why it made this change, but I believe it.

Running npm run format
f7bec4f

Quieting typescript's objections
4bce2ce

Update packages/backend/src/tokens/request.ts
b7e8ac1
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>

Update packages/backend/src/tokens/request.ts
5ce428d
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 9738a97 to 5ce428dCompare September 27, 2024 18:57

panteliselef reviewed Sep 30, 2024
View reviewed changes

Comment threadpackages/backend/src/tokens/request.ts Outdated

panteliselef reviewed Sep 30, 2024
View reviewed changes

brkalow reviewed Sep 30, 2024
View reviewed changes

izaaklauer added 5 commits October 1, 2024 17:57

Renaming "personal wockrkspace" to "personal account"
5858a24
Thanks @panteliselef! #3977 (comment)

avoiding spinning up a separate sample app per test case
3551d2f

Only computing matchers once for efficency.
9f36a37
Responding to #3977 (comment). Thanks @brkalow !

Making types PascelCase
5780554
Thanks @brkalow! #3977 (comment)

Using more concise array type declaration
4076c03
Thanks @brkalow! #3977 (comment)

izaaklauer requested review from brkalow and panteliselef October 3, 2024 16:09

brkalow approved these changes Oct 4, 2024
View reviewed changes

tmilewski assigned izaaklauer Oct 4, 2024

izaaklauer added 2 commits October 7, 2024 11:43

Reverting an incidental upgrate to path-to-regexp
3aa3f67

Merge branch 'main' into izaak/ORGS-132-middleware-orgsync
bc89068

izaaklauer merged commit 2ea1a60 into mainOct 8, 2024

izaaklauer deleted the izaak/ORGS-132-middleware-orgsync branch October 8, 2024 13:35

clerk-cookie mentioned this pull request Oct 9, 2024
ci(repo): Version packages #4307
Merged

izaaklauer mentioned this pull request Oct 17, 2024
Add organizationSyncOptions prop to clerkMiddleware() options clerk/clerk-docs#1634
Merged

izaaklauer mentioned this pull request Oct 28, 2024
DX Guide: Using Organization Slugs in URLs clerk/clerk-docs#1664
Merged

wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
feat(nextjs): Handle URL <> Session Org Mismatch in Middleware (#3977)
d159185
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>

coderabbitaiBot mentioned this pull request May 10, 2026
implement auth naoya5/ghost-ai#2
Merged

Rohan170603 mentioned this pull request Aug 20, 2026
docs(express): add platform limitation warning for organizationSyncOptions clerk/clerk-docs#3530
Closed

WIP - first rough pass at args-based approach
37f0478

clerk-cookie added the backend label Aug 16, 2024

izaaklauer commented Aug 16, 2024
View reviewed changes

Comment threadpackages/backend/src/tokens/request.ts Outdated

clerk-cookie added nextjs integration labels Sep 6, 2024

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 28ece32 to 8dc238fCompare September 6, 2024 22:28

Tested end-to-end with corresponding fapi changes locally
7c3f936

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch 2 times, most recently from cf8ad6c to 509ada1Compare September 6, 2024 22:33

Starting on integration tests
54e6752

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 509ada1 to 54e6752Compare September 6, 2024 22:47

Two more tests
d724695

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from cff9d48 to d724695Compare September 6, 2024 23:12

izaaklauer added 3 commits September 9, 2024 09:47

First pass at table-driven tests
925be56

Trying out server-per-test
fee771a

Now in parallel!
5c575ee

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from d6b3f6b to 5c575eeCompare September 9, 2024 15:32

The table-driven tests are now looking quite nice!
aa84f66

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 42612d2 to aa84f66Compare September 9, 2024 15:55

izaaklauer added 9 commits September 9, 2024 15:16

Doc comments
45a982b

Detecting and handling handshake org sync loops
edffbe0
https://clerkinc.slack.com/archives/C078JFZLLQ3/p1725908922766149

A handful more tests
256bef6

Handling multiple path patterns, better test structure
830dfea

testing paths with sub-resources
63519d9

Merge branch 'main' into izaak/ORGS-132-middleware-orgsync
d77382d

Upgrading path-to-regexp
02823ef
I'll admit, i'm a bit fuzzy here on why it wasn't a dependency before, and also as to why it's only a dev dependency.

Test case with erroneous trailing slash now passing
a6d4136
Turns out someone in the call chain was redirecting before we hit handshake. That's great!

Handling header auth in addition to cookie auth
3a8f583

izaaklauer commented Sep 13, 2024
View reviewed changes

izaaklauerand others added 7 commits September 27, 2024 10:53

Merge branch 'main' into izaak/ORGS-132-middleware-orgsync
0afcd0a

Small refactor to remove redundancy
efc5599

ran npm i
f55a074
Not sure why it made this change, but I believe it.

Running npm run format
f7bec4f

Quieting typescript's objections
4bce2ce

Update packages/backend/src/tokens/request.ts
b7e8ac1
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>

Update packages/backend/src/tokens/request.ts
5ce428d
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 9738a97 to 5ce428dCompare September 27, 2024 18:57

panteliselef reviewed Sep 30, 2024
View reviewed changes

Comment threadpackages/backend/src/tokens/request.ts Outdated

panteliselef reviewed Sep 30, 2024
View reviewed changes

brkalow reviewed Sep 30, 2024
View reviewed changes

izaaklauer added 5 commits October 1, 2024 17:57

Renaming "personal wockrkspace" to "personal account"
5858a24
Thanks @panteliselef! #3977 (comment)

avoiding spinning up a separate sample app per test case
3551d2f

Only computing matchers once for efficency.
9f36a37
Responding to #3977 (comment). Thanks @brkalow !

Making types PascelCase
5780554
Thanks @brkalow! #3977 (comment)

Using more concise array type declaration
4076c03
Thanks @brkalow! #3977 (comment)

izaaklauer requested review from brkalow and panteliselef October 3, 2024 16:09

brkalow approved these changes Oct 4, 2024
View reviewed changes

tmilewski assigned izaaklauer Oct 4, 2024

izaaklauer added 2 commits October 7, 2024 11:43

Reverting an incidental upgrate to path-to-regexp
3aa3f67

Merge branch 'main' into izaak/ORGS-132-middleware-orgsync
bc89068

izaaklauer merged commit 2ea1a60 into mainOct 8, 2024

izaaklauer deleted the izaak/ORGS-132-middleware-orgsync branch October 8, 2024 13:35

clerk-cookie mentioned this pull request Oct 9, 2024
ci(repo): Version packages #4307
Merged

izaaklauer mentioned this pull request Oct 17, 2024
Add organizationSyncOptions prop to clerkMiddleware() options clerk/clerk-docs#1634
Merged

izaaklauer mentioned this pull request Oct 28, 2024
DX Guide: Using Organization Slugs in URLs clerk/clerk-docs#1664
Merged

wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
feat(nextjs): Handle URL <> Session Org Mismatch in Middleware (#3977)
d159185
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>

coderabbitaiBot mentioned this pull request May 10, 2026
implement auth naoya5/ghost-ai#2
Merged

Rohan170603 mentioned this pull request Aug 20, 2026
docs(express): add platform limitation warning for organizationSyncOptions clerk/clerk-docs#3530
Closed

WIP - first rough pass at args-based approach
37f0478

clerk-cookie added the backend label Aug 16, 2024

izaaklauer commented Aug 16, 2024
View reviewed changes

Comment threadpackages/backend/src/tokens/request.ts Outdated

clerk-cookie added nextjs integration labels Sep 6, 2024

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 28ece32 to 8dc238fCompare September 6, 2024 22:28

Tested end-to-end with corresponding fapi changes locally
7c3f936

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch 2 times, most recently from cf8ad6c to 509ada1Compare September 6, 2024 22:33

Starting on integration tests
54e6752

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 509ada1 to 54e6752Compare September 6, 2024 22:47

Two more tests
d724695

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from cff9d48 to d724695Compare September 6, 2024 23:12

izaaklauer added 3 commits September 9, 2024 09:47

First pass at table-driven tests
925be56

Trying out server-per-test
fee771a

Now in parallel!
5c575ee

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from d6b3f6b to 5c575eeCompare September 9, 2024 15:32

The table-driven tests are now looking quite nice!
aa84f66

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 42612d2 to aa84f66Compare September 9, 2024 15:55

izaaklauer added 9 commits September 9, 2024 15:16

Doc comments
45a982b

Detecting and handling handshake org sync loops
edffbe0
https://clerkinc.slack.com/archives/C078JFZLLQ3/p1725908922766149

A handful more tests
256bef6

Handling multiple path patterns, better test structure
830dfea

testing paths with sub-resources
63519d9

Merge branch 'main' into izaak/ORGS-132-middleware-orgsync
d77382d

Upgrading path-to-regexp
02823ef
I'll admit, i'm a bit fuzzy here on why it wasn't a dependency before, and also as to why it's only a dev dependency.

Test case with erroneous trailing slash now passing
a6d4136
Turns out someone in the call chain was redirecting before we hit handshake. That's great!

Handling header auth in addition to cookie auth
3a8f583

izaaklauer commented Sep 13, 2024
View reviewed changes

izaaklauerand others added 7 commits September 27, 2024 10:53

Merge branch 'main' into izaak/ORGS-132-middleware-orgsync
0afcd0a

Small refactor to remove redundancy
efc5599

ran npm i
f55a074
Not sure why it made this change, but I believe it.

Running npm run format
f7bec4f

Quieting typescript's objections
4bce2ce

Update packages/backend/src/tokens/request.ts
b7e8ac1
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>

Update packages/backend/src/tokens/request.ts
5ce428d
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 9738a97 to 5ce428dCompare September 27, 2024 18:57

panteliselef reviewed Sep 30, 2024
View reviewed changes

Comment threadpackages/backend/src/tokens/request.ts Outdated

panteliselef reviewed Sep 30, 2024
View reviewed changes

brkalow reviewed Sep 30, 2024
View reviewed changes

izaaklauer added 5 commits October 1, 2024 17:57

Renaming "personal wockrkspace" to "personal account"
5858a24
Thanks @panteliselef! #3977 (comment)

avoiding spinning up a separate sample app per test case
3551d2f

Only computing matchers once for efficency.
9f36a37
Responding to #3977 (comment). Thanks @brkalow !

Making types PascelCase
5780554
Thanks @brkalow! #3977 (comment)

Using more concise array type declaration
4076c03
Thanks @brkalow! #3977 (comment)

izaaklauer requested review from brkalow and panteliselef October 3, 2024 16:09

brkalow approved these changes Oct 4, 2024
View reviewed changes

tmilewski assigned izaaklauer Oct 4, 2024

izaaklauer added 2 commits October 7, 2024 11:43

Reverting an incidental upgrate to path-to-regexp
3aa3f67

Merge branch 'main' into izaak/ORGS-132-middleware-orgsync
bc89068

izaaklauer merged commit 2ea1a60 into mainOct 8, 2024

izaaklauer deleted the izaak/ORGS-132-middleware-orgsync branch October 8, 2024 13:35

clerk-cookie mentioned this pull request Oct 9, 2024
ci(repo): Version packages #4307
Merged

izaaklauer mentioned this pull request Oct 17, 2024
Add organizationSyncOptions prop to clerkMiddleware() options clerk/clerk-docs#1634
Merged

izaaklauer mentioned this pull request Oct 28, 2024
DX Guide: Using Organization Slugs in URLs clerk/clerk-docs#1664
Merged

wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
feat(nextjs): Handle URL <> Session Org Mismatch in Middleware (#3977)
d159185
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>

coderabbitaiBot mentioned this pull request May 10, 2026
implement auth naoya5/ghost-ai#2
Merged

Rohan170603 mentioned this pull request Aug 20, 2026
docs(express): add platform limitation warning for organizationSyncOptions clerk/clerk-docs#3530
Closed

WIP - first rough pass at args-based approach
37f0478

clerk-cookie added the backend label Aug 16, 2024

izaaklauer commented Aug 16, 2024
View reviewed changes

Comment threadpackages/backend/src/tokens/request.ts Outdated

clerk-cookie added nextjs integration labels Sep 6, 2024

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 28ece32 to 8dc238fCompare September 6, 2024 22:28

Tested end-to-end with corresponding fapi changes locally
7c3f936

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch 2 times, most recently from cf8ad6c to 509ada1Compare September 6, 2024 22:33

Starting on integration tests
54e6752

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 509ada1 to 54e6752Compare September 6, 2024 22:47

Two more tests
d724695

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from cff9d48 to d724695Compare September 6, 2024 23:12

izaaklauer added 3 commits September 9, 2024 09:47

First pass at table-driven tests
925be56

Trying out server-per-test
fee771a

Now in parallel!
5c575ee

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from d6b3f6b to 5c575eeCompare September 9, 2024 15:32

The table-driven tests are now looking quite nice!
aa84f66

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 42612d2 to aa84f66Compare September 9, 2024 15:55

izaaklauer added 9 commits September 9, 2024 15:16

Doc comments
45a982b

Detecting and handling handshake org sync loops
edffbe0
https://clerkinc.slack.com/archives/C078JFZLLQ3/p1725908922766149

A handful more tests
256bef6

Handling multiple path patterns, better test structure
830dfea

testing paths with sub-resources
63519d9

Merge branch 'main' into izaak/ORGS-132-middleware-orgsync
d77382d

Upgrading path-to-regexp
02823ef
I'll admit, i'm a bit fuzzy here on why it wasn't a dependency before, and also as to why it's only a dev dependency.

Test case with erroneous trailing slash now passing
a6d4136
Turns out someone in the call chain was redirecting before we hit handshake. That's great!

Handling header auth in addition to cookie auth
3a8f583

izaaklauer commented Sep 13, 2024
View reviewed changes

izaaklauerand others added 7 commits September 27, 2024 10:53

Merge branch 'main' into izaak/ORGS-132-middleware-orgsync
0afcd0a

Small refactor to remove redundancy
efc5599

ran npm i
f55a074
Not sure why it made this change, but I believe it.

Running npm run format
f7bec4f

Quieting typescript's objections
4bce2ce

Update packages/backend/src/tokens/request.ts
b7e8ac1
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>

Update packages/backend/src/tokens/request.ts
5ce428d
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 9738a97 to 5ce428dCompare September 27, 2024 18:57

panteliselef reviewed Sep 30, 2024
View reviewed changes

Comment threadpackages/backend/src/tokens/request.ts Outdated

panteliselef reviewed Sep 30, 2024
View reviewed changes

brkalow reviewed Sep 30, 2024
View reviewed changes

izaaklauer added 5 commits October 1, 2024 17:57

Renaming "personal wockrkspace" to "personal account"
5858a24
Thanks @panteliselef! #3977 (comment)

avoiding spinning up a separate sample app per test case
3551d2f

Only computing matchers once for efficency.
9f36a37
Responding to #3977 (comment). Thanks @brkalow !

Making types PascelCase
5780554
Thanks @brkalow! #3977 (comment)

Using more concise array type declaration
4076c03
Thanks @brkalow! #3977 (comment)

izaaklauer requested review from brkalow and panteliselef October 3, 2024 16:09

brkalow approved these changes Oct 4, 2024
View reviewed changes

tmilewski assigned izaaklauer Oct 4, 2024

izaaklauer added 2 commits October 7, 2024 11:43

Reverting an incidental upgrate to path-to-regexp
3aa3f67

Merge branch 'main' into izaak/ORGS-132-middleware-orgsync
bc89068

izaaklauer merged commit 2ea1a60 into mainOct 8, 2024

izaaklauer deleted the izaak/ORGS-132-middleware-orgsync branch October 8, 2024 13:35

clerk-cookie mentioned this pull request Oct 9, 2024
ci(repo): Version packages #4307
Merged

izaaklauer mentioned this pull request Oct 17, 2024
Add organizationSyncOptions prop to clerkMiddleware() options clerk/clerk-docs#1634
Merged

izaaklauer mentioned this pull request Oct 28, 2024
DX Guide: Using Organization Slugs in URLs clerk/clerk-docs#1664
Merged

wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
feat(nextjs): Handle URL <> Session Org Mismatch in Middleware (#3977)
d159185
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>

coderabbitaiBot mentioned this pull request May 10, 2026
implement auth naoya5/ghost-ai#2
Merged

Rohan170603 mentioned this pull request Aug 20, 2026
docs(express): add platform limitation warning for organizationSyncOptions clerk/clerk-docs#3530
Closed

WIP - first rough pass at args-based approach
37f0478

clerk-cookie added the backend label Aug 16, 2024

izaaklauer commented Aug 16, 2024
View reviewed changes

Comment threadpackages/backend/src/tokens/request.ts Outdated

clerk-cookie added nextjs integration labels Sep 6, 2024

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 28ece32 to 8dc238fCompare September 6, 2024 22:28

Tested end-to-end with corresponding fapi changes locally
7c3f936

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch 2 times, most recently from cf8ad6c to 509ada1Compare September 6, 2024 22:33

Starting on integration tests
54e6752

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 509ada1 to 54e6752Compare September 6, 2024 22:47

Two more tests
d724695

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from cff9d48 to d724695Compare September 6, 2024 23:12

izaaklauer added 3 commits September 9, 2024 09:47

First pass at table-driven tests
925be56

Trying out server-per-test
fee771a

Now in parallel!
5c575ee

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from d6b3f6b to 5c575eeCompare September 9, 2024 15:32

The table-driven tests are now looking quite nice!
aa84f66

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 42612d2 to aa84f66Compare September 9, 2024 15:55

izaaklauer added 9 commits September 9, 2024 15:16

Doc comments
45a982b

Detecting and handling handshake org sync loops
edffbe0
https://clerkinc.slack.com/archives/C078JFZLLQ3/p1725908922766149

A handful more tests
256bef6

Handling multiple path patterns, better test structure
830dfea

testing paths with sub-resources
63519d9

Merge branch 'main' into izaak/ORGS-132-middleware-orgsync
d77382d

Upgrading path-to-regexp
02823ef
I'll admit, i'm a bit fuzzy here on why it wasn't a dependency before, and also as to why it's only a dev dependency.

Test case with erroneous trailing slash now passing
a6d4136
Turns out someone in the call chain was redirecting before we hit handshake. That's great!

Handling header auth in addition to cookie auth
3a8f583

izaaklauer commented Sep 13, 2024
View reviewed changes

izaaklauerand others added 7 commits September 27, 2024 10:53

Merge branch 'main' into izaak/ORGS-132-middleware-orgsync
0afcd0a

Small refactor to remove redundancy
efc5599

ran npm i
f55a074
Not sure why it made this change, but I believe it.

Running npm run format
f7bec4f

Quieting typescript's objections
4bce2ce

Update packages/backend/src/tokens/request.ts
b7e8ac1
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>

Update packages/backend/src/tokens/request.ts
5ce428d
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 9738a97 to 5ce428dCompare September 27, 2024 18:57

panteliselef reviewed Sep 30, 2024
View reviewed changes

Comment threadpackages/backend/src/tokens/request.ts Outdated

panteliselef reviewed Sep 30, 2024
View reviewed changes

brkalow reviewed Sep 30, 2024
View reviewed changes

izaaklauer added 5 commits October 1, 2024 17:57

Renaming "personal wockrkspace" to "personal account"
5858a24
Thanks @panteliselef! #3977 (comment)

avoiding spinning up a separate sample app per test case
3551d2f

Only computing matchers once for efficency.
9f36a37
Responding to #3977 (comment). Thanks @brkalow !

Making types PascelCase
5780554
Thanks @brkalow! #3977 (comment)

Using more concise array type declaration
4076c03
Thanks @brkalow! #3977 (comment)

izaaklauer requested review from brkalow and panteliselef October 3, 2024 16:09

brkalow approved these changes Oct 4, 2024
View reviewed changes

tmilewski assigned izaaklauer Oct 4, 2024

izaaklauer added 2 commits October 7, 2024 11:43

Reverting an incidental upgrate to path-to-regexp
3aa3f67

Merge branch 'main' into izaak/ORGS-132-middleware-orgsync
bc89068

izaaklauer merged commit 2ea1a60 into mainOct 8, 2024

izaaklauer deleted the izaak/ORGS-132-middleware-orgsync branch October 8, 2024 13:35

clerk-cookie mentioned this pull request Oct 9, 2024
ci(repo): Version packages #4307
Merged

izaaklauer mentioned this pull request Oct 17, 2024
Add organizationSyncOptions prop to clerkMiddleware() options clerk/clerk-docs#1634
Merged

izaaklauer mentioned this pull request Oct 28, 2024
DX Guide: Using Organization Slugs in URLs clerk/clerk-docs#1664
Merged

wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
feat(nextjs): Handle URL <> Session Org Mismatch in Middleware (#3977)
d159185
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>

coderabbitaiBot mentioned this pull request May 10, 2026
implement auth naoya5/ghost-ai#2
Merged

Rohan170603 mentioned this pull request Aug 20, 2026
docs(express): add platform limitation warning for organizationSyncOptions clerk/clerk-docs#3530
Closed

WIP - first rough pass at args-based approach
37f0478

clerk-cookie added the backend label Aug 16, 2024

izaaklauer commented Aug 16, 2024
View reviewed changes

Comment threadpackages/backend/src/tokens/request.ts Outdated

clerk-cookie added nextjs integration labels Sep 6, 2024

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 28ece32 to 8dc238fCompare September 6, 2024 22:28

Tested end-to-end with corresponding fapi changes locally
7c3f936

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch 2 times, most recently from cf8ad6c to 509ada1Compare September 6, 2024 22:33

Starting on integration tests
54e6752

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 509ada1 to 54e6752Compare September 6, 2024 22:47

Two more tests
d724695

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from cff9d48 to d724695Compare September 6, 2024 23:12

izaaklauer added 3 commits September 9, 2024 09:47

First pass at table-driven tests
925be56

Trying out server-per-test
fee771a

Now in parallel!
5c575ee

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from d6b3f6b to 5c575eeCompare September 9, 2024 15:32

The table-driven tests are now looking quite nice!
aa84f66

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 42612d2 to aa84f66Compare September 9, 2024 15:55

izaaklauer added 9 commits September 9, 2024 15:16

Doc comments
45a982b

Detecting and handling handshake org sync loops
edffbe0
https://clerkinc.slack.com/archives/C078JFZLLQ3/p1725908922766149

A handful more tests
256bef6

Handling multiple path patterns, better test structure
830dfea

testing paths with sub-resources
63519d9

Merge branch 'main' into izaak/ORGS-132-middleware-orgsync
d77382d

Upgrading path-to-regexp
02823ef
I'll admit, i'm a bit fuzzy here on why it wasn't a dependency before, and also as to why it's only a dev dependency.

Test case with erroneous trailing slash now passing
a6d4136
Turns out someone in the call chain was redirecting before we hit handshake. That's great!

Handling header auth in addition to cookie auth
3a8f583

izaaklauer commented Sep 13, 2024
View reviewed changes

izaaklauerand others added 7 commits September 27, 2024 10:53

Merge branch 'main' into izaak/ORGS-132-middleware-orgsync
0afcd0a

Small refactor to remove redundancy
efc5599

ran npm i
f55a074
Not sure why it made this change, but I believe it.

Running npm run format
f7bec4f

Quieting typescript's objections
4bce2ce

Update packages/backend/src/tokens/request.ts
b7e8ac1
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>

Update packages/backend/src/tokens/request.ts
5ce428d
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 9738a97 to 5ce428dCompare September 27, 2024 18:57

panteliselef reviewed Sep 30, 2024
View reviewed changes

Comment threadpackages/backend/src/tokens/request.ts Outdated

panteliselef reviewed Sep 30, 2024
View reviewed changes

brkalow reviewed Sep 30, 2024
View reviewed changes

izaaklauer added 5 commits October 1, 2024 17:57

Renaming "personal wockrkspace" to "personal account"
5858a24
Thanks @panteliselef! #3977 (comment)

avoiding spinning up a separate sample app per test case
3551d2f

Only computing matchers once for efficency.
9f36a37
Responding to #3977 (comment). Thanks @brkalow !

Making types PascelCase
5780554
Thanks @brkalow! #3977 (comment)

Using more concise array type declaration
4076c03
Thanks @brkalow! #3977 (comment)

izaaklauer requested review from brkalow and panteliselef October 3, 2024 16:09

brkalow approved these changes Oct 4, 2024
View reviewed changes

tmilewski assigned izaaklauer Oct 4, 2024

izaaklauer added 2 commits October 7, 2024 11:43

Reverting an incidental upgrate to path-to-regexp
3aa3f67

Merge branch 'main' into izaak/ORGS-132-middleware-orgsync
bc89068

izaaklauer merged commit 2ea1a60 into mainOct 8, 2024

izaaklauer deleted the izaak/ORGS-132-middleware-orgsync branch October 8, 2024 13:35

clerk-cookie mentioned this pull request Oct 9, 2024
ci(repo): Version packages #4307
Merged

izaaklauer mentioned this pull request Oct 17, 2024
Add organizationSyncOptions prop to clerkMiddleware() options clerk/clerk-docs#1634
Merged

izaaklauer mentioned this pull request Oct 28, 2024
DX Guide: Using Organization Slugs in URLs clerk/clerk-docs#1664
Merged

wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
feat(nextjs): Handle URL <> Session Org Mismatch in Middleware (#3977)
d159185
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>

coderabbitaiBot mentioned this pull request May 10, 2026
implement auth naoya5/ghost-ai#2
Merged

Rohan170603 mentioned this pull request Aug 20, 2026
docs(express): add platform limitation warning for organizationSyncOptions clerk/clerk-docs#3530
Closed

WIP - first rough pass at args-based approach
37f0478

clerk-cookie added the backend label Aug 16, 2024

izaaklauer commented Aug 16, 2024
View reviewed changes

Comment threadpackages/backend/src/tokens/request.ts Outdated

clerk-cookie added nextjs integration labels Sep 6, 2024

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 28ece32 to 8dc238fCompare September 6, 2024 22:28

Tested end-to-end with corresponding fapi changes locally
7c3f936

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch 2 times, most recently from cf8ad6c to 509ada1Compare September 6, 2024 22:33

Starting on integration tests
54e6752

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 509ada1 to 54e6752Compare September 6, 2024 22:47

Two more tests
d724695

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from cff9d48 to d724695Compare September 6, 2024 23:12

izaaklauer added 3 commits September 9, 2024 09:47

First pass at table-driven tests
925be56

Trying out server-per-test
fee771a

Now in parallel!
5c575ee

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from d6b3f6b to 5c575eeCompare September 9, 2024 15:32

The table-driven tests are now looking quite nice!
aa84f66

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 42612d2 to aa84f66Compare September 9, 2024 15:55

izaaklauer added 9 commits September 9, 2024 15:16

Doc comments
45a982b

Detecting and handling handshake org sync loops
edffbe0
https://clerkinc.slack.com/archives/C078JFZLLQ3/p1725908922766149

A handful more tests
256bef6

Handling multiple path patterns, better test structure
830dfea

testing paths with sub-resources
63519d9

Merge branch 'main' into izaak/ORGS-132-middleware-orgsync
d77382d

Upgrading path-to-regexp
02823ef
I'll admit, i'm a bit fuzzy here on why it wasn't a dependency before, and also as to why it's only a dev dependency.

Test case with erroneous trailing slash now passing
a6d4136
Turns out someone in the call chain was redirecting before we hit handshake. That's great!

Handling header auth in addition to cookie auth
3a8f583

izaaklauer commented Sep 13, 2024
View reviewed changes

izaaklauerand others added 7 commits September 27, 2024 10:53

Merge branch 'main' into izaak/ORGS-132-middleware-orgsync
0afcd0a

Small refactor to remove redundancy
efc5599

ran npm i
f55a074
Not sure why it made this change, but I believe it.

Running npm run format
f7bec4f

Quieting typescript's objections
4bce2ce

Update packages/backend/src/tokens/request.ts
b7e8ac1
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>

Update packages/backend/src/tokens/request.ts
5ce428d
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>

izaaklauer force-pushed the izaak/ORGS-132-middleware-orgsync branch from 9738a97 to 5ce428dCompare September 27, 2024 18:57

panteliselef reviewed Sep 30, 2024
View reviewed changes

Comment threadpackages/backend/src/tokens/request.ts Outdated

panteliselef reviewed Sep 30, 2024
View reviewed changes

brkalow reviewed Sep 30, 2024
View reviewed changes

izaaklauer added 5 commits October 1, 2024 17:57

Renaming "personal wockrkspace" to "personal account"
5858a24
Thanks @panteliselef! #3977 (comment)

avoiding spinning up a separate sample app per test case
3551d2f

Only computing matchers once for efficency.
9f36a37
Responding to #3977 (comment). Thanks @brkalow !

Making types PascelCase
5780554
Thanks @brkalow! #3977 (comment)

Using more concise array type declaration
4076c03
Thanks @brkalow! #3977 (comment)

izaaklauer requested review from brkalow and panteliselef October 3, 2024 16:09

brkalow approved these changes Oct 4, 2024
View reviewed changes

tmilewski assigned izaaklauer Oct 4, 2024

izaaklauer added 2 commits October 7, 2024 11:43

Reverting an incidental upgrate to path-to-regexp
3aa3f67

Merge branch 'main' into izaak/ORGS-132-middleware-orgsync
bc89068

izaaklauer merged commit 2ea1a60 into mainOct 8, 2024

izaaklauer deleted the izaak/ORGS-132-middleware-orgsync branch October 8, 2024 13:35

clerk-cookie mentioned this pull request Oct 9, 2024
ci(repo): Version packages #4307
Merged

izaaklauer mentioned this pull request Oct 17, 2024
Add organizationSyncOptions prop to clerkMiddleware() options clerk/clerk-docs#1634
Merged

izaaklauer mentioned this pull request Oct 28, 2024
DX Guide: Using Organization Slugs in URLs clerk/clerk-docs#1664
Merged

wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
feat(nextjs): Handle URL <> Session Org Mismatch in Middleware (#3977)
d159185
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>

coderabbitaiBot mentioned this pull request May 10, 2026
implement auth naoya5/ghost-ai#2
Merged

Rohan170603 mentioned this pull request Aug 20, 2026
docs(express): add platform limitation warning for organizationSyncOptions clerk/clerk-docs#3530
Closed

  await new Promise<void>(resolve => jwksServer.close(() => resolve()));
  });
- test('Test standard signed-in - dev', async () => {

+ * WARNING: If the organization cannot be activated either because it does not exist or the user lacks access,
+ * organization-related fields will be set to null. The server component must detect this and respond
+ * with an appropriate error (e.g., notFound()).

Uh oh!

Conversation

izaaklauer commented Aug 16, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem is this solving?

What changed?

What does the new API look like?

What's next?

Further Reading:

Uh oh!

changeset-botBot commented Aug 16, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

izaaklauerOct 3, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

brkalow left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

izaaklauer commented Aug 16, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem is this solving?

What changed?

What does the new API look like?

What's next?

Further Reading:

Uh oh!

changeset-botBot commented Aug 16, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

izaaklauerOct 3, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

izaaklauer commented Aug 16, 2024•
edited
Loading

changeset-botBot commented Aug 16, 2024•
edited
Loading

izaaklauerOct 3, 2024•
edited
Loading

izaaklauer commented Aug 16, 2024•
edited
Loading

changeset-botBot commented Aug 16, 2024•
edited
Loading

izaaklauerOct 3, 2024•
edited
Loading

izaaklauer commented Aug 16, 2024•
edited
Loading

changeset-botBot commented Aug 16, 2024•
edited
Loading

izaaklauerOct 3, 2024•
edited
Loading