fix(astro): Use batched stores to avoid race conditions in auth store by wobsoriano · Pull Request #4000 · clerk/javascript

wobsoriano · 2024-08-22T02:29:11Z

Description

This PR fixes an issue where the $authStore nanostore goes back to its initial values (null/undefined) after clerk-js has been loaded. See what's happening in the screen recording below:

Screen.Recording.2024-08-21.at.12.20.12.PM.mov

This is happening because computed stores react each time any of their dependencies get updated. In our case, the $csrStore and $initialState stores. It resets back to undefined even though we have an initial value because of how the derivedStore function works:

We set the $initialState coming from SSR, we have an $authStore value available.
Next, after clerk-js has been loaded, we set the isLoaded property of $csrStore to true, and derivedState will recalculate and give us the client state and not SSR state, which at this time is still undefined since it didn't reach the listener for resources yet. This is where we get undefined values again.
Next, we are setting each key of the resources (client, user, org, session), and each action will trigger the computed $authStore again, giving us different values.

This is where the batched store comes in. This store will wait until the end of a tick to update itself. This is what we want for derivedState to give a correct output in SSR and CSR:

batched.mov

All other stores should work properly as they depend on the $authStore.

Fixes ECO-162

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-08-22T02:29:15Z

🦋 Changeset detected

Latest commit: e8b3265

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wobsoriano · 2024-08-22T02:56:41Z

+ client: undefined,
+ user: undefined,
+ session: undefined,
+ organization: undefined,


See my comment here. Putting the update here as they're related

wobsoriano · 2024-08-22T02:57:39Z

 "@clerk/types": "4.14.0",
 "nanoid": "5.0.7",
- "nanostores": "0.10.3",
+ "nanostores": "0.11.2",


Version bump with bug fixes and perf improvements. No breaking change. See changelog

panteliselef · 2024-08-22T08:14:46Z

 * $authStore.subscribe((auth) => console.log(auth.userId))
 */
-export const $authStore = computed([$csrState, $initialState], (state, initialState) => {
+export const $authStore = batched([$csrState, $initialState], (state, initialState) => {


Does this return a read only store similar to computed ?

Yes readonly too

…#4000)

wobsoriano · 2024-08-22T02:29:11Z

Description

This PR fixes an issue where the $authStore nanostore goes back to its initial values (null/undefined) after clerk-js has been loaded. See what's happening in the screen recording below:

Screen.Recording.2024-08-21.at.12.20.12.PM.mov

This is happening because computed stores react each time any of their dependencies get updated. In our case, the $csrStore and $initialState stores. It resets back to undefined even though we have an initial value because of how the derivedStore function works:

We set the $initialState coming from SSR, we have an $authStore value available.
Next, after clerk-js has been loaded, we set the isLoaded property of $csrStore to true, and derivedState will recalculate and give us the client state and not SSR state, which at this time is still undefined since it didn't reach the listener for resources yet. This is where we get undefined values again.
Next, we are setting each key of the resources (client, user, org, session), and each action will trigger the computed $authStore again, giving us different values.

This is where the batched store comes in. This store will wait until the end of a tick to update itself. This is what we want for derivedState to give a correct output in SSR and CSR:

batched.mov

All other stores should work properly as they depend on the $authStore.

Fixes ECO-162

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-08-22T02:29:15Z

🦋 Changeset detected

Latest commit: e8b3265

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wobsoriano · 2024-08-22T02:56:41Z

+ client: undefined,
+ user: undefined,
+ session: undefined,
+ organization: undefined,


See my comment here. Putting the update here as they're related

wobsoriano · 2024-08-22T02:57:39Z

 "@clerk/types": "4.14.0",
 "nanoid": "5.0.7",
- "nanostores": "0.10.3",
+ "nanostores": "0.11.2",


Version bump with bug fixes and perf improvements. No breaking change. See changelog

panteliselef · 2024-08-22T08:14:46Z

 * $authStore.subscribe((auth) => console.log(auth.userId))
 */
-export const $authStore = computed([$csrState, $initialState], (state, initialState) => {
+export const $authStore = batched([$csrState, $initialState], (state, initialState) => {


Does this return a read only store similar to computed ?

Yes readonly too

…#4000)

wobsoriano · 2024-08-22T02:29:11Z

Description

This PR fixes an issue where the $authStore nanostore goes back to its initial values (null/undefined) after clerk-js has been loaded. See what's happening in the screen recording below:

Screen.Recording.2024-08-21.at.12.20.12.PM.mov

This is happening because computed stores react each time any of their dependencies get updated. In our case, the $csrStore and $initialState stores. It resets back to undefined even though we have an initial value because of how the derivedStore function works:

We set the $initialState coming from SSR, we have an $authStore value available.
Next, after clerk-js has been loaded, we set the isLoaded property of $csrStore to true, and derivedState will recalculate and give us the client state and not SSR state, which at this time is still undefined since it didn't reach the listener for resources yet. This is where we get undefined values again.
Next, we are setting each key of the resources (client, user, org, session), and each action will trigger the computed $authStore again, giving us different values.

This is where the batched store comes in. This store will wait until the end of a tick to update itself. This is what we want for derivedState to give a correct output in SSR and CSR:

batched.mov

All other stores should work properly as they depend on the $authStore.

Fixes ECO-162

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-08-22T02:29:15Z

🦋 Changeset detected

Latest commit: e8b3265

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wobsoriano · 2024-08-22T02:56:41Z

+ client: undefined,
+ user: undefined,
+ session: undefined,
+ organization: undefined,


See my comment here. Putting the update here as they're related

wobsoriano · 2024-08-22T02:57:39Z

 "@clerk/types": "4.14.0",
 "nanoid": "5.0.7",
- "nanostores": "0.10.3",
+ "nanostores": "0.11.2",


Version bump with bug fixes and perf improvements. No breaking change. See changelog

panteliselef · 2024-08-22T08:14:46Z

 * $authStore.subscribe((auth) => console.log(auth.userId))
 */
-export const $authStore = computed([$csrState, $initialState], (state, initialState) => {
+export const $authStore = batched([$csrState, $initialState], (state, initialState) => {


Does this return a read only store similar to computed ?

Yes readonly too

…#4000)

wobsoriano · 2024-08-22T02:29:11Z

Description

This PR fixes an issue where the $authStore nanostore goes back to its initial values (null/undefined) after clerk-js has been loaded. See what's happening in the screen recording below:

Screen.Recording.2024-08-21.at.12.20.12.PM.mov

This is happening because computed stores react each time any of their dependencies get updated. In our case, the $csrStore and $initialState stores. It resets back to undefined even though we have an initial value because of how the derivedStore function works:

We set the $initialState coming from SSR, we have an $authStore value available.
Next, after clerk-js has been loaded, we set the isLoaded property of $csrStore to true, and derivedState will recalculate and give us the client state and not SSR state, which at this time is still undefined since it didn't reach the listener for resources yet. This is where we get undefined values again.
Next, we are setting each key of the resources (client, user, org, session), and each action will trigger the computed $authStore again, giving us different values.

This is where the batched store comes in. This store will wait until the end of a tick to update itself. This is what we want for derivedState to give a correct output in SSR and CSR:

batched.mov

All other stores should work properly as they depend on the $authStore.

Fixes ECO-162

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-08-22T02:29:15Z

🦋 Changeset detected

Latest commit: e8b3265

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wobsoriano · 2024-08-22T02:56:41Z

+ client: undefined,
+ user: undefined,
+ session: undefined,
+ organization: undefined,


See my comment here. Putting the update here as they're related

wobsoriano · 2024-08-22T02:57:39Z

 "@clerk/types": "4.14.0",
 "nanoid": "5.0.7",
- "nanostores": "0.10.3",
+ "nanostores": "0.11.2",


Version bump with bug fixes and perf improvements. No breaking change. See changelog

panteliselef · 2024-08-22T08:14:46Z

 * $authStore.subscribe((auth) => console.log(auth.userId))
 */
-export const $authStore = computed([$csrState, $initialState], (state, initialState) => {
+export const $authStore = batched([$csrState, $initialState], (state, initialState) => {


Does this return a read only store similar to computed ?

Yes readonly too

…#4000)

wobsoriano · 2024-08-22T02:29:11Z

Description

This PR fixes an issue where the $authStore nanostore goes back to its initial values (null/undefined) after clerk-js has been loaded. See what's happening in the screen recording below:

Screen.Recording.2024-08-21.at.12.20.12.PM.mov

This is happening because computed stores react each time any of their dependencies get updated. In our case, the $csrStore and $initialState stores. It resets back to undefined even though we have an initial value because of how the derivedStore function works:

We set the $initialState coming from SSR, we have an $authStore value available.
Next, after clerk-js has been loaded, we set the isLoaded property of $csrStore to true, and derivedState will recalculate and give us the client state and not SSR state, which at this time is still undefined since it didn't reach the listener for resources yet. This is where we get undefined values again.
Next, we are setting each key of the resources (client, user, org, session), and each action will trigger the computed $authStore again, giving us different values.

This is where the batched store comes in. This store will wait until the end of a tick to update itself. This is what we want for derivedState to give a correct output in SSR and CSR:

batched.mov

All other stores should work properly as they depend on the $authStore.

Fixes ECO-162

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-08-22T02:29:15Z

🦋 Changeset detected

Latest commit: e8b3265

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wobsoriano · 2024-08-22T02:56:41Z

+ client: undefined,
+ user: undefined,
+ session: undefined,
+ organization: undefined,


See my comment here. Putting the update here as they're related

wobsoriano · 2024-08-22T02:57:39Z

 "@clerk/types": "4.14.0",
 "nanoid": "5.0.7",
- "nanostores": "0.10.3",
+ "nanostores": "0.11.2",


Version bump with bug fixes and perf improvements. No breaking change. See changelog

panteliselef · 2024-08-22T08:14:46Z

 * $authStore.subscribe((auth) => console.log(auth.userId))
 */
-export const $authStore = computed([$csrState, $initialState], (state, initialState) => {
+export const $authStore = batched([$csrState, $initialState], (state, initialState) => {


Does this return a read only store similar to computed ?

Yes readonly too

…#4000)

wobsoriano · 2024-08-22T02:29:11Z

Description

This PR fixes an issue where the $authStore nanostore goes back to its initial values (null/undefined) after clerk-js has been loaded. See what's happening in the screen recording below:

Screen.Recording.2024-08-21.at.12.20.12.PM.mov

This is happening because computed stores react each time any of their dependencies get updated. In our case, the $csrStore and $initialState stores. It resets back to undefined even though we have an initial value because of how the derivedStore function works:

We set the $initialState coming from SSR, we have an $authStore value available.
Next, after clerk-js has been loaded, we set the isLoaded property of $csrStore to true, and derivedState will recalculate and give us the client state and not SSR state, which at this time is still undefined since it didn't reach the listener for resources yet. This is where we get undefined values again.
Next, we are setting each key of the resources (client, user, org, session), and each action will trigger the computed $authStore again, giving us different values.

This is where the batched store comes in. This store will wait until the end of a tick to update itself. This is what we want for derivedState to give a correct output in SSR and CSR:

batched.mov

All other stores should work properly as they depend on the $authStore.

Fixes ECO-162

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-08-22T02:29:15Z

🦋 Changeset detected

Latest commit: e8b3265

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wobsoriano · 2024-08-22T02:56:41Z

+ client: undefined,
+ user: undefined,
+ session: undefined,
+ organization: undefined,


See my comment here. Putting the update here as they're related

wobsoriano · 2024-08-22T02:57:39Z

 "@clerk/types": "4.14.0",
 "nanoid": "5.0.7",
- "nanostores": "0.10.3",
+ "nanostores": "0.11.2",


Version bump with bug fixes and perf improvements. No breaking change. See changelog

panteliselef · 2024-08-22T08:14:46Z

 * $authStore.subscribe((auth) => console.log(auth.userId))
 */
-export const $authStore = computed([$csrState, $initialState], (state, initialState) => {
+export const $authStore = batched([$csrState, $initialState], (state, initialState) => {


Does this return a read only store similar to computed ?

Yes readonly too

…#4000)

wobsoriano · 2024-08-22T02:29:11Z

Description

This PR fixes an issue where the $authStore nanostore goes back to its initial values (null/undefined) after clerk-js has been loaded. See what's happening in the screen recording below:

Screen.Recording.2024-08-21.at.12.20.12.PM.mov

This is happening because computed stores react each time any of their dependencies get updated. In our case, the $csrStore and $initialState stores. It resets back to undefined even though we have an initial value because of how the derivedStore function works:

We set the $initialState coming from SSR, we have an $authStore value available.
Next, after clerk-js has been loaded, we set the isLoaded property of $csrStore to true, and derivedState will recalculate and give us the client state and not SSR state, which at this time is still undefined since it didn't reach the listener for resources yet. This is where we get undefined values again.
Next, we are setting each key of the resources (client, user, org, session), and each action will trigger the computed $authStore again, giving us different values.

This is where the batched store comes in. This store will wait until the end of a tick to update itself. This is what we want for derivedState to give a correct output in SSR and CSR:

batched.mov

All other stores should work properly as they depend on the $authStore.

Fixes ECO-162

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-08-22T02:29:15Z

🦋 Changeset detected

Latest commit: e8b3265

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wobsoriano · 2024-08-22T02:56:41Z

+ client: undefined,
+ user: undefined,
+ session: undefined,
+ organization: undefined,


See my comment here. Putting the update here as they're related

wobsoriano · 2024-08-22T02:57:39Z

 "@clerk/types": "4.14.0",
 "nanoid": "5.0.7",
- "nanostores": "0.10.3",
+ "nanostores": "0.11.2",


Version bump with bug fixes and perf improvements. No breaking change. See changelog

panteliselef · 2024-08-22T08:14:46Z

 * $authStore.subscribe((auth) => console.log(auth.userId))
 */
-export const $authStore = computed([$csrState, $initialState], (state, initialState) => {
+export const $authStore = batched([$csrState, $initialState], (state, initialState) => {


Does this return a read only store similar to computed ?

Yes readonly too

…#4000)

wobsoriano · 2024-08-22T02:29:11Z

Description

This PR fixes an issue where the $authStore nanostore goes back to its initial values (null/undefined) after clerk-js has been loaded. See what's happening in the screen recording below:

Screen.Recording.2024-08-21.at.12.20.12.PM.mov

This is happening because computed stores react each time any of their dependencies get updated. In our case, the $csrStore and $initialState stores. It resets back to undefined even though we have an initial value because of how the derivedStore function works:

We set the $initialState coming from SSR, we have an $authStore value available.
Next, after clerk-js has been loaded, we set the isLoaded property of $csrStore to true, and derivedState will recalculate and give us the client state and not SSR state, which at this time is still undefined since it didn't reach the listener for resources yet. This is where we get undefined values again.
Next, we are setting each key of the resources (client, user, org, session), and each action will trigger the computed $authStore again, giving us different values.

This is where the batched store comes in. This store will wait until the end of a tick to update itself. This is what we want for derivedState to give a correct output in SSR and CSR:

batched.mov

All other stores should work properly as they depend on the $authStore.

Fixes ECO-162

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-08-22T02:29:15Z

🦋 Changeset detected

Latest commit: e8b3265

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wobsoriano · 2024-08-22T02:56:41Z

+ client: undefined,
+ user: undefined,
+ session: undefined,
+ organization: undefined,


See my comment here. Putting the update here as they're related

wobsoriano · 2024-08-22T02:57:39Z

 "@clerk/types": "4.14.0",
 "nanoid": "5.0.7",
- "nanostores": "0.10.3",
+ "nanostores": "0.11.2",


Version bump with bug fixes and perf improvements. No breaking change. See changelog

panteliselef · 2024-08-22T08:14:46Z

 * $authStore.subscribe((auth) => console.log(auth.userId))
 */
-export const $authStore = computed([$csrState, $initialState], (state, initialState) => {
+export const $authStore = batched([$csrState, $initialState], (state, initialState) => {


Does this return a read only store similar to computed ?

Yes readonly too

…#4000)

wobsoriano added 2 commits August 21, 2024 18:48

fix(astro): Use batched store to avoid race conditions for auth state
bf91ae9

chore(astro): Bump nanostores to 0.11.2
5f94799

chore(astro): Add changeset
e8b3265

wobsoriano changed the title ~~fix(astro): Use batched stores to avoid race conditions in stores~~fix(astro): Use batched stores to avoid race conditionsAug 22, 2024

wobsoriano changed the title ~~fix(astro): Use batched stores to avoid race conditions~~fix(astro): Use batched stores to avoid race conditions in auth storeAug 22, 2024

wobsoriano commented Aug 22, 2024
View reviewed changes

wobsoriano marked this pull request as ready for review August 22, 2024 02:57

wobsoriano requested a review from panteliselef August 22, 2024 02:59

panteliselef approved these changes Aug 22, 2024
View reviewed changes

panteliselef assigned wobsoriano Aug 22, 2024

wobsoriano merged commit 540b720 into mainAug 22, 2024

wobsoriano deleted the rob/eco-162-investigate-why-client-stores-give-different-values branch August 22, 2024 11:15

clerk-cookie mentioned this pull request Aug 22, 2024
ci(repo): Version packages #3990
Merged

brkalow pushed a commit that referenced this pull request Aug 22, 2024
fix(astro): Use batched stores to avoid race conditions in auth store (…
13583e7
…#4000)

wobsoriano added 2 commits August 21, 2024 18:48

fix(astro): Use batched store to avoid race conditions for auth state
bf91ae9

chore(astro): Bump nanostores to 0.11.2
5f94799

chore(astro): Add changeset
e8b3265

wobsoriano changed the title ~~fix(astro): Use batched stores to avoid race conditions in stores~~fix(astro): Use batched stores to avoid race conditionsAug 22, 2024

wobsoriano changed the title ~~fix(astro): Use batched stores to avoid race conditions~~fix(astro): Use batched stores to avoid race conditions in auth storeAug 22, 2024

wobsoriano commented Aug 22, 2024
View reviewed changes

wobsoriano marked this pull request as ready for review August 22, 2024 02:57

wobsoriano requested a review from panteliselef August 22, 2024 02:59

panteliselef approved these changes Aug 22, 2024
View reviewed changes

panteliselef assigned wobsoriano Aug 22, 2024

wobsoriano merged commit 540b720 into mainAug 22, 2024

wobsoriano deleted the rob/eco-162-investigate-why-client-stores-give-different-values branch August 22, 2024 11:15

clerk-cookie mentioned this pull request Aug 22, 2024
ci(repo): Version packages #3990
Merged

brkalow pushed a commit that referenced this pull request Aug 22, 2024
fix(astro): Use batched stores to avoid race conditions in auth store (…
13583e7
…#4000)

wobsoriano added 2 commits August 21, 2024 18:48

fix(astro): Use batched store to avoid race conditions for auth state
bf91ae9

chore(astro): Bump nanostores to 0.11.2
5f94799

chore(astro): Add changeset
e8b3265

wobsoriano changed the title ~~fix(astro): Use batched stores to avoid race conditions in stores~~fix(astro): Use batched stores to avoid race conditionsAug 22, 2024

wobsoriano changed the title ~~fix(astro): Use batched stores to avoid race conditions~~fix(astro): Use batched stores to avoid race conditions in auth storeAug 22, 2024

wobsoriano commented Aug 22, 2024
View reviewed changes

wobsoriano marked this pull request as ready for review August 22, 2024 02:57

wobsoriano requested a review from panteliselef August 22, 2024 02:59

panteliselef approved these changes Aug 22, 2024
View reviewed changes

panteliselef assigned wobsoriano Aug 22, 2024

wobsoriano merged commit 540b720 into mainAug 22, 2024

wobsoriano deleted the rob/eco-162-investigate-why-client-stores-give-different-values branch August 22, 2024 11:15

clerk-cookie mentioned this pull request Aug 22, 2024
ci(repo): Version packages #3990
Merged

brkalow pushed a commit that referenced this pull request Aug 22, 2024
fix(astro): Use batched stores to avoid race conditions in auth store (…
13583e7
…#4000)

wobsoriano added 2 commits August 21, 2024 18:48

fix(astro): Use batched store to avoid race conditions for auth state
bf91ae9

chore(astro): Bump nanostores to 0.11.2
5f94799

chore(astro): Add changeset
e8b3265

wobsoriano changed the title ~~fix(astro): Use batched stores to avoid race conditions in stores~~fix(astro): Use batched stores to avoid race conditionsAug 22, 2024

wobsoriano changed the title ~~fix(astro): Use batched stores to avoid race conditions~~fix(astro): Use batched stores to avoid race conditions in auth storeAug 22, 2024

wobsoriano commented Aug 22, 2024
View reviewed changes

wobsoriano marked this pull request as ready for review August 22, 2024 02:57

wobsoriano requested a review from panteliselef August 22, 2024 02:59

panteliselef approved these changes Aug 22, 2024
View reviewed changes

panteliselef assigned wobsoriano Aug 22, 2024

wobsoriano merged commit 540b720 into mainAug 22, 2024

wobsoriano deleted the rob/eco-162-investigate-why-client-stores-give-different-values branch August 22, 2024 11:15

clerk-cookie mentioned this pull request Aug 22, 2024
ci(repo): Version packages #3990
Merged

brkalow pushed a commit that referenced this pull request Aug 22, 2024
fix(astro): Use batched stores to avoid race conditions in auth store (…
13583e7
…#4000)

wobsoriano added 2 commits August 21, 2024 18:48

fix(astro): Use batched store to avoid race conditions for auth state
bf91ae9

chore(astro): Bump nanostores to 0.11.2
5f94799

chore(astro): Add changeset
e8b3265

wobsoriano changed the title ~~fix(astro): Use batched stores to avoid race conditions in stores~~fix(astro): Use batched stores to avoid race conditionsAug 22, 2024

wobsoriano changed the title ~~fix(astro): Use batched stores to avoid race conditions~~fix(astro): Use batched stores to avoid race conditions in auth storeAug 22, 2024

wobsoriano commented Aug 22, 2024
View reviewed changes

wobsoriano marked this pull request as ready for review August 22, 2024 02:57

wobsoriano requested a review from panteliselef August 22, 2024 02:59

panteliselef approved these changes Aug 22, 2024
View reviewed changes

panteliselef assigned wobsoriano Aug 22, 2024

wobsoriano merged commit 540b720 into mainAug 22, 2024

wobsoriano deleted the rob/eco-162-investigate-why-client-stores-give-different-values branch August 22, 2024 11:15

clerk-cookie mentioned this pull request Aug 22, 2024
ci(repo): Version packages #3990
Merged

brkalow pushed a commit that referenced this pull request Aug 22, 2024
fix(astro): Use batched stores to avoid race conditions in auth store (…
13583e7
…#4000)

wobsoriano added 2 commits August 21, 2024 18:48

fix(astro): Use batched store to avoid race conditions for auth state
bf91ae9

chore(astro): Bump nanostores to 0.11.2
5f94799

chore(astro): Add changeset
e8b3265

wobsoriano changed the title ~~fix(astro): Use batched stores to avoid race conditions in stores~~fix(astro): Use batched stores to avoid race conditionsAug 22, 2024

wobsoriano changed the title ~~fix(astro): Use batched stores to avoid race conditions~~fix(astro): Use batched stores to avoid race conditions in auth storeAug 22, 2024

wobsoriano commented Aug 22, 2024
View reviewed changes

wobsoriano marked this pull request as ready for review August 22, 2024 02:57

wobsoriano requested a review from panteliselef August 22, 2024 02:59

panteliselef approved these changes Aug 22, 2024
View reviewed changes

panteliselef assigned wobsoriano Aug 22, 2024

wobsoriano merged commit 540b720 into mainAug 22, 2024

wobsoriano deleted the rob/eco-162-investigate-why-client-stores-give-different-values branch August 22, 2024 11:15

clerk-cookie mentioned this pull request Aug 22, 2024
ci(repo): Version packages #3990
Merged

brkalow pushed a commit that referenced this pull request Aug 22, 2024
fix(astro): Use batched stores to avoid race conditions in auth store (…
13583e7
…#4000)

wobsoriano added 2 commits August 21, 2024 18:48

fix(astro): Use batched store to avoid race conditions for auth state
bf91ae9

chore(astro): Bump nanostores to 0.11.2
5f94799

chore(astro): Add changeset
e8b3265

wobsoriano changed the title ~~fix(astro): Use batched stores to avoid race conditions in stores~~fix(astro): Use batched stores to avoid race conditionsAug 22, 2024

wobsoriano changed the title ~~fix(astro): Use batched stores to avoid race conditions~~fix(astro): Use batched stores to avoid race conditions in auth storeAug 22, 2024

wobsoriano commented Aug 22, 2024
View reviewed changes

wobsoriano marked this pull request as ready for review August 22, 2024 02:57

wobsoriano requested a review from panteliselef August 22, 2024 02:59

panteliselef approved these changes Aug 22, 2024
View reviewed changes

panteliselef assigned wobsoriano Aug 22, 2024

wobsoriano merged commit 540b720 into mainAug 22, 2024

wobsoriano deleted the rob/eco-162-investigate-why-client-stores-give-different-values branch August 22, 2024 11:15

clerk-cookie mentioned this pull request Aug 22, 2024
ci(repo): Version packages #3990
Merged

brkalow pushed a commit that referenced this pull request Aug 22, 2024
fix(astro): Use batched stores to avoid race conditions in auth store (…
13583e7
…#4000)

wobsoriano added 2 commits August 21, 2024 18:48

fix(astro): Use batched store to avoid race conditions for auth state
bf91ae9

chore(astro): Bump nanostores to 0.11.2
5f94799

chore(astro): Add changeset
e8b3265

wobsoriano changed the title ~~fix(astro): Use batched stores to avoid race conditions in stores~~fix(astro): Use batched stores to avoid race conditionsAug 22, 2024

wobsoriano changed the title ~~fix(astro): Use batched stores to avoid race conditions~~fix(astro): Use batched stores to avoid race conditions in auth storeAug 22, 2024

wobsoriano commented Aug 22, 2024
View reviewed changes

wobsoriano marked this pull request as ready for review August 22, 2024 02:57

wobsoriano requested a review from panteliselef August 22, 2024 02:59

panteliselef approved these changes Aug 22, 2024
View reviewed changes

panteliselef assigned wobsoriano Aug 22, 2024

wobsoriano merged commit 540b720 into mainAug 22, 2024

wobsoriano deleted the rob/eco-162-investigate-why-client-stores-give-different-values branch August 22, 2024 11:15

clerk-cookie mentioned this pull request Aug 22, 2024
ci(repo): Version packages #3990
Merged

brkalow pushed a commit that referenced this pull request Aug 22, 2024
fix(astro): Use batched stores to avoid race conditions in auth store (…
13583e7
…#4000)

Uh oh!

Conversation

wobsoriano commented Aug 22, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

changeset-botBot commented Aug 22, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

wobsoriano commented Aug 22, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

changeset-botBot commented Aug 22, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

wobsoriano commented Aug 22, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

changeset-botBot commented Aug 22, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

wobsoriano commented Aug 22, 2024•
edited
Loading

changeset-botBot commented Aug 22, 2024•
edited
Loading

wobsoriano commented Aug 22, 2024•
edited
Loading

changeset-botBot commented Aug 22, 2024•
edited
Loading

wobsoriano commented Aug 22, 2024•
edited
Loading

changeset-botBot commented Aug 22, 2024•
edited
Loading

wobsoriano commented Aug 22, 2024•
edited
Loading

changeset-botBot commented Aug 22, 2024•
edited
Loading