feat(backend,types,clerk-js,clerk-react): Add the `fva` sessionClaim by panteliselef · Pull Request #4061 · clerk/javascript

panteliselef · 2024-08-30T16:40:23Z

Description

fva will power the concept of "assurance". has() and protect() will be updated ( in follow up PRs ) in order to take advatage of the fva values

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

…onClaim

changeset-bot · 2024-08-30T16:40:27Z

🦋 Changeset detected

Latest commit: ee05185

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
@clerk/clerk-js	Minor
@clerk/backend	Minor
@clerk/clerk-react	Minor
@clerk/types	Minor
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch
@clerk/astro	Patch
@clerk/express	Patch
@clerk/fastify	Patch
@clerk/nextjs	Patch
@clerk/remix	Patch
@clerk/clerk-sdk-node	Patch
@clerk/tanstack-start	Patch
@clerk/testing	Patch
@clerk/elements	Patch
@clerk/localizations	Patch
@clerk/shared	Patch
@clerk/themes	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

LekoArts · 2024-09-02T13:38:08Z

+ * [fistFactorAge, secondFactorAge]
+ * @experimental This API is experimental and may change at any moment.
+ */
+ __experimental_fva: [number | null, number | null];


Gut feeling: This should be called __experimental_factorVerificationAge for public consumption everywhere, too. We're not really doing pure acronyms in other places and I wondered why we use another name internally

We are not expecting this to be consumed directly, people should be using protect | has({ assurance: {..} }) which abstracts fva away.
We only need to expose and provide the fva value to ClerkProvider internally in order to ensure SSR working properly.

@chanioxaris Do you think we should rename ?

Yeah i believe it's better to use the full claim name vs the short version

panteliselef · 2024-09-02T15:11:14Z

+ */
+ fva: [number | null, number | null];
+


@chanioxaris please confirm that the actual session claim will be called fva

As where we stand right now, that's correct!

…the-new-fva-claim

Co-authored-by: Haris Chaniotakis <haris@clerk.dev>

…the-new-fva-claim

panteliselef · 2024-08-30T16:40:23Z

Description

fva will power the concept of "assurance". has() and protect() will be updated ( in follow up PRs ) in order to take advatage of the fva values

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

…onClaim

changeset-bot · 2024-08-30T16:40:27Z

🦋 Changeset detected

Latest commit: ee05185

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
@clerk/clerk-js	Minor
@clerk/backend	Minor
@clerk/clerk-react	Minor
@clerk/types	Minor
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch
@clerk/astro	Patch
@clerk/express	Patch
@clerk/fastify	Patch
@clerk/nextjs	Patch
@clerk/remix	Patch
@clerk/clerk-sdk-node	Patch
@clerk/tanstack-start	Patch
@clerk/testing	Patch
@clerk/elements	Patch
@clerk/localizations	Patch
@clerk/shared	Patch
@clerk/themes	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

LekoArts · 2024-09-02T13:38:08Z

+ * [fistFactorAge, secondFactorAge]
+ * @experimental This API is experimental and may change at any moment.
+ */
+ __experimental_fva: [number | null, number | null];


Gut feeling: This should be called __experimental_factorVerificationAge for public consumption everywhere, too. We're not really doing pure acronyms in other places and I wondered why we use another name internally

We are not expecting this to be consumed directly, people should be using protect | has({ assurance: {..} }) which abstracts fva away.
We only need to expose and provide the fva value to ClerkProvider internally in order to ensure SSR working properly.

@chanioxaris Do you think we should rename ?

Yeah i believe it's better to use the full claim name vs the short version

panteliselef · 2024-09-02T15:11:14Z

+ */
+ fva: [number | null, number | null];
+


@chanioxaris please confirm that the actual session claim will be called fva

As where we stand right now, that's correct!

…the-new-fva-claim

Co-authored-by: Haris Chaniotakis <haris@clerk.dev>

…the-new-fva-claim

panteliselef · 2024-08-30T16:40:23Z

Description

fva will power the concept of "assurance". has() and protect() will be updated ( in follow up PRs ) in order to take advatage of the fva values

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

…onClaim

changeset-bot · 2024-08-30T16:40:27Z

🦋 Changeset detected

Latest commit: ee05185

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
@clerk/clerk-js	Minor
@clerk/backend	Minor
@clerk/clerk-react	Minor
@clerk/types	Minor
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch
@clerk/astro	Patch
@clerk/express	Patch
@clerk/fastify	Patch
@clerk/nextjs	Patch
@clerk/remix	Patch
@clerk/clerk-sdk-node	Patch
@clerk/tanstack-start	Patch
@clerk/testing	Patch
@clerk/elements	Patch
@clerk/localizations	Patch
@clerk/shared	Patch
@clerk/themes	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

LekoArts · 2024-09-02T13:38:08Z

+ * [fistFactorAge, secondFactorAge]
+ * @experimental This API is experimental and may change at any moment.
+ */
+ __experimental_fva: [number | null, number | null];


Gut feeling: This should be called __experimental_factorVerificationAge for public consumption everywhere, too. We're not really doing pure acronyms in other places and I wondered why we use another name internally

We are not expecting this to be consumed directly, people should be using protect | has({ assurance: {..} }) which abstracts fva away.
We only need to expose and provide the fva value to ClerkProvider internally in order to ensure SSR working properly.

@chanioxaris Do you think we should rename ?

Yeah i believe it's better to use the full claim name vs the short version

panteliselef · 2024-09-02T15:11:14Z

+ */
+ fva: [number | null, number | null];
+


@chanioxaris please confirm that the actual session claim will be called fva

As where we stand right now, that's correct!

…the-new-fva-claim

Co-authored-by: Haris Chaniotakis <haris@clerk.dev>

…the-new-fva-claim

panteliselef · 2024-08-30T16:40:23Z

Description

fva will power the concept of "assurance". has() and protect() will be updated ( in follow up PRs ) in order to take advatage of the fva values

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

…onClaim

changeset-bot · 2024-08-30T16:40:27Z

🦋 Changeset detected

Latest commit: ee05185

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
@clerk/clerk-js	Minor
@clerk/backend	Minor
@clerk/clerk-react	Minor
@clerk/types	Minor
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch
@clerk/astro	Patch
@clerk/express	Patch
@clerk/fastify	Patch
@clerk/nextjs	Patch
@clerk/remix	Patch
@clerk/clerk-sdk-node	Patch
@clerk/tanstack-start	Patch
@clerk/testing	Patch
@clerk/elements	Patch
@clerk/localizations	Patch
@clerk/shared	Patch
@clerk/themes	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

LekoArts · 2024-09-02T13:38:08Z

+ * [fistFactorAge, secondFactorAge]
+ * @experimental This API is experimental and may change at any moment.
+ */
+ __experimental_fva: [number | null, number | null];


Gut feeling: This should be called __experimental_factorVerificationAge for public consumption everywhere, too. We're not really doing pure acronyms in other places and I wondered why we use another name internally

We are not expecting this to be consumed directly, people should be using protect | has({ assurance: {..} }) which abstracts fva away.
We only need to expose and provide the fva value to ClerkProvider internally in order to ensure SSR working properly.

@chanioxaris Do you think we should rename ?

Yeah i believe it's better to use the full claim name vs the short version

panteliselef · 2024-09-02T15:11:14Z

+ */
+ fva: [number | null, number | null];
+


@chanioxaris please confirm that the actual session claim will be called fva

As where we stand right now, that's correct!

…the-new-fva-claim

Co-authored-by: Haris Chaniotakis <haris@clerk.dev>

…the-new-fva-claim

panteliselef · 2024-08-30T16:40:23Z

Description

fva will power the concept of "assurance". has() and protect() will be updated ( in follow up PRs ) in order to take advatage of the fva values

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

…onClaim

changeset-bot · 2024-08-30T16:40:27Z

🦋 Changeset detected

Latest commit: ee05185

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
@clerk/clerk-js	Minor
@clerk/backend	Minor
@clerk/clerk-react	Minor
@clerk/types	Minor
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch
@clerk/astro	Patch
@clerk/express	Patch
@clerk/fastify	Patch
@clerk/nextjs	Patch
@clerk/remix	Patch
@clerk/clerk-sdk-node	Patch
@clerk/tanstack-start	Patch
@clerk/testing	Patch
@clerk/elements	Patch
@clerk/localizations	Patch
@clerk/shared	Patch
@clerk/themes	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

LekoArts · 2024-09-02T13:38:08Z

+ * [fistFactorAge, secondFactorAge]
+ * @experimental This API is experimental and may change at any moment.
+ */
+ __experimental_fva: [number | null, number | null];


Gut feeling: This should be called __experimental_factorVerificationAge for public consumption everywhere, too. We're not really doing pure acronyms in other places and I wondered why we use another name internally

We are not expecting this to be consumed directly, people should be using protect | has({ assurance: {..} }) which abstracts fva away.
We only need to expose and provide the fva value to ClerkProvider internally in order to ensure SSR working properly.

@chanioxaris Do you think we should rename ?

Yeah i believe it's better to use the full claim name vs the short version

panteliselef · 2024-09-02T15:11:14Z

+ */
+ fva: [number | null, number | null];
+


@chanioxaris please confirm that the actual session claim will be called fva

As where we stand right now, that's correct!

…the-new-fva-claim

Co-authored-by: Haris Chaniotakis <haris@clerk.dev>

…the-new-fva-claim

panteliselef · 2024-08-30T16:40:23Z

Description

fva will power the concept of "assurance". has() and protect() will be updated ( in follow up PRs ) in order to take advatage of the fva values

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

…onClaim

changeset-bot · 2024-08-30T16:40:27Z

🦋 Changeset detected

Latest commit: ee05185

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
@clerk/clerk-js	Minor
@clerk/backend	Minor
@clerk/clerk-react	Minor
@clerk/types	Minor
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch
@clerk/astro	Patch
@clerk/express	Patch
@clerk/fastify	Patch
@clerk/nextjs	Patch
@clerk/remix	Patch
@clerk/clerk-sdk-node	Patch
@clerk/tanstack-start	Patch
@clerk/testing	Patch
@clerk/elements	Patch
@clerk/localizations	Patch
@clerk/shared	Patch
@clerk/themes	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

LekoArts · 2024-09-02T13:38:08Z

+ * [fistFactorAge, secondFactorAge]
+ * @experimental This API is experimental and may change at any moment.
+ */
+ __experimental_fva: [number | null, number | null];


Gut feeling: This should be called __experimental_factorVerificationAge for public consumption everywhere, too. We're not really doing pure acronyms in other places and I wondered why we use another name internally

We are not expecting this to be consumed directly, people should be using protect | has({ assurance: {..} }) which abstracts fva away.
We only need to expose and provide the fva value to ClerkProvider internally in order to ensure SSR working properly.

@chanioxaris Do you think we should rename ?

Yeah i believe it's better to use the full claim name vs the short version

panteliselef · 2024-09-02T15:11:14Z

+ */
+ fva: [number | null, number | null];
+


@chanioxaris please confirm that the actual session claim will be called fva

As where we stand right now, that's correct!

…the-new-fva-claim

Co-authored-by: Haris Chaniotakis <haris@clerk.dev>

…the-new-fva-claim

panteliselef · 2024-08-30T16:40:23Z

Description

fva will power the concept of "assurance". has() and protect() will be updated ( in follow up PRs ) in order to take advatage of the fva values

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

…onClaim

changeset-bot · 2024-08-30T16:40:27Z

🦋 Changeset detected

Latest commit: ee05185

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
@clerk/clerk-js	Minor
@clerk/backend	Minor
@clerk/clerk-react	Minor
@clerk/types	Minor
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch
@clerk/astro	Patch
@clerk/express	Patch
@clerk/fastify	Patch
@clerk/nextjs	Patch
@clerk/remix	Patch
@clerk/clerk-sdk-node	Patch
@clerk/tanstack-start	Patch
@clerk/testing	Patch
@clerk/elements	Patch
@clerk/localizations	Patch
@clerk/shared	Patch
@clerk/themes	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

LekoArts · 2024-09-02T13:38:08Z

+ * [fistFactorAge, secondFactorAge]
+ * @experimental This API is experimental and may change at any moment.
+ */
+ __experimental_fva: [number | null, number | null];


Gut feeling: This should be called __experimental_factorVerificationAge for public consumption everywhere, too. We're not really doing pure acronyms in other places and I wondered why we use another name internally

We are not expecting this to be consumed directly, people should be using protect | has({ assurance: {..} }) which abstracts fva away.
We only need to expose and provide the fva value to ClerkProvider internally in order to ensure SSR working properly.

@chanioxaris Do you think we should rename ?

Yeah i believe it's better to use the full claim name vs the short version

panteliselef · 2024-09-02T15:11:14Z

+ */
+ fva: [number | null, number | null];
+


@chanioxaris please confirm that the actual session claim will be called fva

As where we stand right now, that's correct!

…the-new-fva-claim

Co-authored-by: Haris Chaniotakis <haris@clerk.dev>

…the-new-fva-claim

panteliselef · 2024-08-30T16:40:23Z

Description

fva will power the concept of "assurance". has() and protect() will be updated ( in follow up PRs ) in order to take advatage of the fva values

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

…onClaim

changeset-bot · 2024-08-30T16:40:27Z

🦋 Changeset detected

Latest commit: ee05185

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
@clerk/clerk-js	Minor
@clerk/backend	Minor
@clerk/clerk-react	Minor
@clerk/types	Minor
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch
@clerk/astro	Patch
@clerk/express	Patch
@clerk/fastify	Patch
@clerk/nextjs	Patch
@clerk/remix	Patch
@clerk/clerk-sdk-node	Patch
@clerk/tanstack-start	Patch
@clerk/testing	Patch
@clerk/elements	Patch
@clerk/localizations	Patch
@clerk/shared	Patch
@clerk/themes	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

LekoArts · 2024-09-02T13:38:08Z

+ * [fistFactorAge, secondFactorAge]
+ * @experimental This API is experimental and may change at any moment.
+ */
+ __experimental_fva: [number | null, number | null];


Gut feeling: This should be called __experimental_factorVerificationAge for public consumption everywhere, too. We're not really doing pure acronyms in other places and I wondered why we use another name internally

We are not expecting this to be consumed directly, people should be using protect | has({ assurance: {..} }) which abstracts fva away.
We only need to expose and provide the fva value to ClerkProvider internally in order to ensure SSR working properly.

@chanioxaris Do you think we should rename ?

Yeah i believe it's better to use the full claim name vs the short version

panteliselef · 2024-09-02T15:11:14Z

+ */
+ fva: [number | null, number | null];
+


@chanioxaris please confirm that the actual session claim will be called fva

As where we stand right now, that's correct!

…the-new-fva-claim

Co-authored-by: Haris Chaniotakis <haris@clerk.dev>

…the-new-fva-claim

feat(backend,types,clerk-js,clerk-react): Keep track of the fva sessi…
ac57074
…onClaim

panteliselef requested a review from a teamAugust 30, 2024 16:40

panteliselef self-assigned this Aug 30, 2024

clerk-cookie added types clerk-js react backend labels Aug 30, 2024

panteliselef changed the title ~~feat(backend,types,clerk-js,clerk-react): Keep track of the fva sessionClaim~~feat(backend,types,clerk-js,clerk-react): Add the fva sessionClaimAug 30, 2024

bump bundlewatch limit
281150a

LekoArts reviewed Sep 2, 2024
View reviewed changes

rename to full name
8b7f1ff

panteliselef commented Sep 2, 2024
View reviewed changes

Comment thread.changeset/eleven-apricots-rest.md Outdated

panteliselef added 6 commits September 2, 2024 18:18

Update .changeset/eleven-apricots-rest.md
912953b

Update eleven-apricots-rest.md
98bae9d

Merge branch 'main' into elef/user-610-update-clerkbackend-to-expect-…
0b8deaf
…the-new-fva-claim

Merge branch 'main' into elef/user-610-update-clerkbackend-to-expect-…
88cf922
…the-new-fva-claim

Merge branch 'main' into elef/user-610-update-clerkbackend-to-expect-…
58fac79
…the-new-fva-claim

Merge branch 'main' into elef/user-610-update-clerkbackend-to-expect-…
58df3e8
…the-new-fva-claim

chanioxaris approved these changes Sep 3, 2024
View reviewed changes

Comment threadpackages/clerk-js/src/utils/memoizeStateListenerCallback.ts Outdated
Comment threadpackages/clerk-js/src/utils/memoizeStateListenerCallback.ts Outdated

panteliselefand others added 4 commits September 3, 2024 15:29

Merge branch 'main' into elef/user-610-update-clerkbackend-to-expect-…
c5f5ac3
…the-new-fva-claim

Merge branch 'main' into elef/user-610-update-clerkbackend-to-expect-…
e42c0bb
…the-new-fva-claim

Apply suggestions from code review
19b7682
Co-authored-by: Haris Chaniotakis <haris@clerk.dev>

Merge branch 'main' into elef/user-610-update-clerkbackend-to-expect-…
375ee23
…the-new-fva-claim

panteliselef enabled auto-merge (squash) September 3, 2024 14:47

panteliselef added 2 commits September 3, 2024 19:27

Merge branch 'main' into elef/user-610-update-clerkbackend-to-expect-…
a20a694
…the-new-fva-claim

update package-lock.json
ee05185

nikosdouvlis disabled auto-merge September 3, 2024 18:03

nikosdouvlis merged commit c63a5ad into mainSep 3, 2024

nikosdouvlis deleted the elef/user-610-update-clerkbackend-to-expect-the-new-fva-claim branch September 3, 2024 18:03

clerk-cookie mentioned this pull request Sep 3, 2024
ci(repo): Version packages #4091
Merged