chore(clerk-js,types,clerk-react,elements): Drop coinbase web3 provider by chanioxaris · Pull Request #4092 · clerk/javascript

chanioxaris · 2024-09-03T19:00:22Z

Description

The current 'coinbase' web3 provider has been replaced by a generic 'coinbase_wallet' provider which supports both Smart Wallets and the Coinbase Wallet browser extension. The feature is not yet released, so it's safe to remove them

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-09-03T19:00:25Z

🦋 Changeset detected

Latest commit: 7fa822c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/elements	Patch
@clerk/clerk-react	Patch
@clerk/types	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch
@clerk/nextjs	Patch
@clerk/remix	Patch
@clerk/tanstack-start	Patch
@clerk/astro	Patch
@clerk/backend	Patch
@clerk/express	Patch
@clerk/fastify	Patch
@clerk/localizations	Patch
@clerk/clerk-sdk-node	Patch
@clerk/shared	Patch
@clerk/testing	Patch
@clerk/themes	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

panteliselef

Minor feedback about elements

panteliselef · 2024-09-04T07:44:44Z

- case 'web3_coinbase_signature': {
- const signature = fields.get('signature')?.value as string | undefined;
- assertIsDefined(signature, 'Web3 Coinbase signature');
-
- attemptParams = {
- strategy,
- signature,
- } satisfies Web3Attempt;
-
- break;
- }


Are we removing the elements support for Coinbase completely or are we replacing it with Coinbase Wallet ? Will this be done in a follow up PR ?

In this PR we are removing the support for the deprecated Coinbase completely. There is a separate PR #4103 to handle the new Coinbase Wallet provider

octoper · 2024-09-04T09:55:00Z

@@ -0,0 +1,2 @@
+---


Shouldn't we add a changeset about these changes?

I was thinking to avoid adding one as we never really released the Coinbase provider, so in some way we revert the changes. But sure let me add one

octoper · 2024-09-04T09:57:33Z


 type EIP6963AnnounceProviderEvent = CustomEvent;
-type InjectedWeb3Provider = MetamaskWeb3Provider | CoinbaseWeb3Provider;
+type InjectedWeb3Provider = MetamaskWeb3Provider;


❓ We don't need CoinbaseWalletWeb3Provider here?

No because CoinbaseWallet is not an injected provider but it's handled via the coinbase wallet sdk

…ed Coinbase web3 provider The current 'coinbase' web3 provider has been replaced by a generic 'coinbase_wallet' provider which supports both Smart Wallets and the Coinbase Wallet browser extension. The feature is not yet released, so it's safe to remove them

…er (#4092)

chanioxaris · 2024-09-03T19:00:22Z

Description

The current 'coinbase' web3 provider has been replaced by a generic 'coinbase_wallet' provider which supports both Smart Wallets and the Coinbase Wallet browser extension. The feature is not yet released, so it's safe to remove them

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-09-03T19:00:25Z

🦋 Changeset detected

Latest commit: 7fa822c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/elements	Patch
@clerk/clerk-react	Patch
@clerk/types	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch
@clerk/nextjs	Patch
@clerk/remix	Patch
@clerk/tanstack-start	Patch
@clerk/astro	Patch
@clerk/backend	Patch
@clerk/express	Patch
@clerk/fastify	Patch
@clerk/localizations	Patch
@clerk/clerk-sdk-node	Patch
@clerk/shared	Patch
@clerk/testing	Patch
@clerk/themes	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

panteliselef

Minor feedback about elements

panteliselef · 2024-09-04T07:44:44Z

- case 'web3_coinbase_signature': {
- const signature = fields.get('signature')?.value as string | undefined;
- assertIsDefined(signature, 'Web3 Coinbase signature');
-
- attemptParams = {
- strategy,
- signature,
- } satisfies Web3Attempt;
-
- break;
- }


Are we removing the elements support for Coinbase completely or are we replacing it with Coinbase Wallet ? Will this be done in a follow up PR ?

In this PR we are removing the support for the deprecated Coinbase completely. There is a separate PR #4103 to handle the new Coinbase Wallet provider

octoper · 2024-09-04T09:55:00Z

@@ -0,0 +1,2 @@
+---


Shouldn't we add a changeset about these changes?

I was thinking to avoid adding one as we never really released the Coinbase provider, so in some way we revert the changes. But sure let me add one

octoper · 2024-09-04T09:57:33Z


 type EIP6963AnnounceProviderEvent = CustomEvent;
-type InjectedWeb3Provider = MetamaskWeb3Provider | CoinbaseWeb3Provider;
+type InjectedWeb3Provider = MetamaskWeb3Provider;


❓ We don't need CoinbaseWalletWeb3Provider here?

No because CoinbaseWallet is not an injected provider but it's handled via the coinbase wallet sdk

…ed Coinbase web3 provider The current 'coinbase' web3 provider has been replaced by a generic 'coinbase_wallet' provider which supports both Smart Wallets and the Coinbase Wallet browser extension. The feature is not yet released, so it's safe to remove them

…er (#4092)

chanioxaris · 2024-09-03T19:00:22Z

Description

The current 'coinbase' web3 provider has been replaced by a generic 'coinbase_wallet' provider which supports both Smart Wallets and the Coinbase Wallet browser extension. The feature is not yet released, so it's safe to remove them

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-09-03T19:00:25Z

🦋 Changeset detected

Latest commit: 7fa822c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/elements	Patch
@clerk/clerk-react	Patch
@clerk/types	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch
@clerk/nextjs	Patch
@clerk/remix	Patch
@clerk/tanstack-start	Patch
@clerk/astro	Patch
@clerk/backend	Patch
@clerk/express	Patch
@clerk/fastify	Patch
@clerk/localizations	Patch
@clerk/clerk-sdk-node	Patch
@clerk/shared	Patch
@clerk/testing	Patch
@clerk/themes	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

panteliselef

Minor feedback about elements

panteliselef · 2024-09-04T07:44:44Z

- case 'web3_coinbase_signature': {
- const signature = fields.get('signature')?.value as string | undefined;
- assertIsDefined(signature, 'Web3 Coinbase signature');
-
- attemptParams = {
- strategy,
- signature,
- } satisfies Web3Attempt;
-
- break;
- }


Are we removing the elements support for Coinbase completely or are we replacing it with Coinbase Wallet ? Will this be done in a follow up PR ?

In this PR we are removing the support for the deprecated Coinbase completely. There is a separate PR #4103 to handle the new Coinbase Wallet provider

octoper · 2024-09-04T09:55:00Z

@@ -0,0 +1,2 @@
+---


Shouldn't we add a changeset about these changes?

I was thinking to avoid adding one as we never really released the Coinbase provider, so in some way we revert the changes. But sure let me add one

octoper · 2024-09-04T09:57:33Z


 type EIP6963AnnounceProviderEvent = CustomEvent;
-type InjectedWeb3Provider = MetamaskWeb3Provider | CoinbaseWeb3Provider;
+type InjectedWeb3Provider = MetamaskWeb3Provider;


❓ We don't need CoinbaseWalletWeb3Provider here?

No because CoinbaseWallet is not an injected provider but it's handled via the coinbase wallet sdk

…ed Coinbase web3 provider The current 'coinbase' web3 provider has been replaced by a generic 'coinbase_wallet' provider which supports both Smart Wallets and the Coinbase Wallet browser extension. The feature is not yet released, so it's safe to remove them

…er (#4092)

chanioxaris · 2024-09-03T19:00:22Z

Description

The current 'coinbase' web3 provider has been replaced by a generic 'coinbase_wallet' provider which supports both Smart Wallets and the Coinbase Wallet browser extension. The feature is not yet released, so it's safe to remove them

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-09-03T19:00:25Z

🦋 Changeset detected

Latest commit: 7fa822c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/elements	Patch
@clerk/clerk-react	Patch
@clerk/types	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch
@clerk/nextjs	Patch
@clerk/remix	Patch
@clerk/tanstack-start	Patch
@clerk/astro	Patch
@clerk/backend	Patch
@clerk/express	Patch
@clerk/fastify	Patch
@clerk/localizations	Patch
@clerk/clerk-sdk-node	Patch
@clerk/shared	Patch
@clerk/testing	Patch
@clerk/themes	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

panteliselef

Minor feedback about elements

panteliselef · 2024-09-04T07:44:44Z

- case 'web3_coinbase_signature': {
- const signature = fields.get('signature')?.value as string | undefined;
- assertIsDefined(signature, 'Web3 Coinbase signature');
-
- attemptParams = {
- strategy,
- signature,
- } satisfies Web3Attempt;
-
- break;
- }


Are we removing the elements support for Coinbase completely or are we replacing it with Coinbase Wallet ? Will this be done in a follow up PR ?

In this PR we are removing the support for the deprecated Coinbase completely. There is a separate PR #4103 to handle the new Coinbase Wallet provider

octoper · 2024-09-04T09:55:00Z

@@ -0,0 +1,2 @@
+---


Shouldn't we add a changeset about these changes?

I was thinking to avoid adding one as we never really released the Coinbase provider, so in some way we revert the changes. But sure let me add one

octoper · 2024-09-04T09:57:33Z


 type EIP6963AnnounceProviderEvent = CustomEvent;
-type InjectedWeb3Provider = MetamaskWeb3Provider | CoinbaseWeb3Provider;
+type InjectedWeb3Provider = MetamaskWeb3Provider;


❓ We don't need CoinbaseWalletWeb3Provider here?

No because CoinbaseWallet is not an injected provider but it's handled via the coinbase wallet sdk

…ed Coinbase web3 provider The current 'coinbase' web3 provider has been replaced by a generic 'coinbase_wallet' provider which supports both Smart Wallets and the Coinbase Wallet browser extension. The feature is not yet released, so it's safe to remove them

…er (#4092)

chanioxaris · 2024-09-03T19:00:22Z

Description

The current 'coinbase' web3 provider has been replaced by a generic 'coinbase_wallet' provider which supports both Smart Wallets and the Coinbase Wallet browser extension. The feature is not yet released, so it's safe to remove them

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-09-03T19:00:25Z

🦋 Changeset detected

Latest commit: 7fa822c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/elements	Patch
@clerk/clerk-react	Patch
@clerk/types	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch
@clerk/nextjs	Patch
@clerk/remix	Patch
@clerk/tanstack-start	Patch
@clerk/astro	Patch
@clerk/backend	Patch
@clerk/express	Patch
@clerk/fastify	Patch
@clerk/localizations	Patch
@clerk/clerk-sdk-node	Patch
@clerk/shared	Patch
@clerk/testing	Patch
@clerk/themes	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

panteliselef

Minor feedback about elements

panteliselef · 2024-09-04T07:44:44Z

- case 'web3_coinbase_signature': {
- const signature = fields.get('signature')?.value as string | undefined;
- assertIsDefined(signature, 'Web3 Coinbase signature');
-
- attemptParams = {
- strategy,
- signature,
- } satisfies Web3Attempt;
-
- break;
- }


Are we removing the elements support for Coinbase completely or are we replacing it with Coinbase Wallet ? Will this be done in a follow up PR ?

In this PR we are removing the support for the deprecated Coinbase completely. There is a separate PR #4103 to handle the new Coinbase Wallet provider

octoper · 2024-09-04T09:55:00Z

@@ -0,0 +1,2 @@
+---


Shouldn't we add a changeset about these changes?

I was thinking to avoid adding one as we never really released the Coinbase provider, so in some way we revert the changes. But sure let me add one

octoper · 2024-09-04T09:57:33Z


 type EIP6963AnnounceProviderEvent = CustomEvent;
-type InjectedWeb3Provider = MetamaskWeb3Provider | CoinbaseWeb3Provider;
+type InjectedWeb3Provider = MetamaskWeb3Provider;


❓ We don't need CoinbaseWalletWeb3Provider here?

No because CoinbaseWallet is not an injected provider but it's handled via the coinbase wallet sdk

…ed Coinbase web3 provider The current 'coinbase' web3 provider has been replaced by a generic 'coinbase_wallet' provider which supports both Smart Wallets and the Coinbase Wallet browser extension. The feature is not yet released, so it's safe to remove them

…er (#4092)

chanioxaris · 2024-09-03T19:00:22Z

Description

The current 'coinbase' web3 provider has been replaced by a generic 'coinbase_wallet' provider which supports both Smart Wallets and the Coinbase Wallet browser extension. The feature is not yet released, so it's safe to remove them

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-09-03T19:00:25Z

🦋 Changeset detected

Latest commit: 7fa822c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/elements	Patch
@clerk/clerk-react	Patch
@clerk/types	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch
@clerk/nextjs	Patch
@clerk/remix	Patch
@clerk/tanstack-start	Patch
@clerk/astro	Patch
@clerk/backend	Patch
@clerk/express	Patch
@clerk/fastify	Patch
@clerk/localizations	Patch
@clerk/clerk-sdk-node	Patch
@clerk/shared	Patch
@clerk/testing	Patch
@clerk/themes	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

panteliselef

Minor feedback about elements

panteliselef · 2024-09-04T07:44:44Z

- case 'web3_coinbase_signature': {
- const signature = fields.get('signature')?.value as string | undefined;
- assertIsDefined(signature, 'Web3 Coinbase signature');
-
- attemptParams = {
- strategy,
- signature,
- } satisfies Web3Attempt;
-
- break;
- }


Are we removing the elements support for Coinbase completely or are we replacing it with Coinbase Wallet ? Will this be done in a follow up PR ?

In this PR we are removing the support for the deprecated Coinbase completely. There is a separate PR #4103 to handle the new Coinbase Wallet provider

octoper · 2024-09-04T09:55:00Z

@@ -0,0 +1,2 @@
+---


Shouldn't we add a changeset about these changes?

I was thinking to avoid adding one as we never really released the Coinbase provider, so in some way we revert the changes. But sure let me add one

octoper · 2024-09-04T09:57:33Z


 type EIP6963AnnounceProviderEvent = CustomEvent;
-type InjectedWeb3Provider = MetamaskWeb3Provider | CoinbaseWeb3Provider;
+type InjectedWeb3Provider = MetamaskWeb3Provider;


❓ We don't need CoinbaseWalletWeb3Provider here?

No because CoinbaseWallet is not an injected provider but it's handled via the coinbase wallet sdk

…ed Coinbase web3 provider The current 'coinbase' web3 provider has been replaced by a generic 'coinbase_wallet' provider which supports both Smart Wallets and the Coinbase Wallet browser extension. The feature is not yet released, so it's safe to remove them

…er (#4092)

chanioxaris · 2024-09-03T19:00:22Z

Description

The current 'coinbase' web3 provider has been replaced by a generic 'coinbase_wallet' provider which supports both Smart Wallets and the Coinbase Wallet browser extension. The feature is not yet released, so it's safe to remove them

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-09-03T19:00:25Z

🦋 Changeset detected

Latest commit: 7fa822c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/elements	Patch
@clerk/clerk-react	Patch
@clerk/types	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch
@clerk/nextjs	Patch
@clerk/remix	Patch
@clerk/tanstack-start	Patch
@clerk/astro	Patch
@clerk/backend	Patch
@clerk/express	Patch
@clerk/fastify	Patch
@clerk/localizations	Patch
@clerk/clerk-sdk-node	Patch
@clerk/shared	Patch
@clerk/testing	Patch
@clerk/themes	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

panteliselef

Minor feedback about elements

panteliselef · 2024-09-04T07:44:44Z

- case 'web3_coinbase_signature': {
- const signature = fields.get('signature')?.value as string | undefined;
- assertIsDefined(signature, 'Web3 Coinbase signature');
-
- attemptParams = {
- strategy,
- signature,
- } satisfies Web3Attempt;
-
- break;
- }


Are we removing the elements support for Coinbase completely or are we replacing it with Coinbase Wallet ? Will this be done in a follow up PR ?

In this PR we are removing the support for the deprecated Coinbase completely. There is a separate PR #4103 to handle the new Coinbase Wallet provider

octoper · 2024-09-04T09:55:00Z

@@ -0,0 +1,2 @@
+---


Shouldn't we add a changeset about these changes?

I was thinking to avoid adding one as we never really released the Coinbase provider, so in some way we revert the changes. But sure let me add one

octoper · 2024-09-04T09:57:33Z


 type EIP6963AnnounceProviderEvent = CustomEvent;
-type InjectedWeb3Provider = MetamaskWeb3Provider | CoinbaseWeb3Provider;
+type InjectedWeb3Provider = MetamaskWeb3Provider;


❓ We don't need CoinbaseWalletWeb3Provider here?

No because CoinbaseWallet is not an injected provider but it's handled via the coinbase wallet sdk

…ed Coinbase web3 provider The current 'coinbase' web3 provider has been replaced by a generic 'coinbase_wallet' provider which supports both Smart Wallets and the Coinbase Wallet browser extension. The feature is not yet released, so it's safe to remove them

…er (#4092)

chanioxaris · 2024-09-03T19:00:22Z

Description

The current 'coinbase' web3 provider has been replaced by a generic 'coinbase_wallet' provider which supports both Smart Wallets and the Coinbase Wallet browser extension. The feature is not yet released, so it's safe to remove them

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-09-03T19:00:25Z

🦋 Changeset detected

Latest commit: 7fa822c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/elements	Patch
@clerk/clerk-react	Patch
@clerk/types	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch
@clerk/nextjs	Patch
@clerk/remix	Patch
@clerk/tanstack-start	Patch
@clerk/astro	Patch
@clerk/backend	Patch
@clerk/express	Patch
@clerk/fastify	Patch
@clerk/localizations	Patch
@clerk/clerk-sdk-node	Patch
@clerk/shared	Patch
@clerk/testing	Patch
@clerk/themes	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

panteliselef

Minor feedback about elements

panteliselef · 2024-09-04T07:44:44Z

- case 'web3_coinbase_signature': {
- const signature = fields.get('signature')?.value as string | undefined;
- assertIsDefined(signature, 'Web3 Coinbase signature');
-
- attemptParams = {
- strategy,
- signature,
- } satisfies Web3Attempt;
-
- break;
- }


Are we removing the elements support for Coinbase completely or are we replacing it with Coinbase Wallet ? Will this be done in a follow up PR ?

In this PR we are removing the support for the deprecated Coinbase completely. There is a separate PR #4103 to handle the new Coinbase Wallet provider

octoper · 2024-09-04T09:55:00Z

@@ -0,0 +1,2 @@
+---


Shouldn't we add a changeset about these changes?

I was thinking to avoid adding one as we never really released the Coinbase provider, so in some way we revert the changes. But sure let me add one

octoper · 2024-09-04T09:57:33Z


 type EIP6963AnnounceProviderEvent = CustomEvent;
-type InjectedWeb3Provider = MetamaskWeb3Provider | CoinbaseWeb3Provider;
+type InjectedWeb3Provider = MetamaskWeb3Provider;


❓ We don't need CoinbaseWalletWeb3Provider here?

No because CoinbaseWallet is not an injected provider but it's handled via the coinbase wallet sdk

…ed Coinbase web3 provider The current 'coinbase' web3 provider has been replaced by a generic 'coinbase_wallet' provider which supports both Smart Wallets and the Coinbase Wallet browser extension. The feature is not yet released, so it's safe to remove them

…er (#4092)

chanioxaris requested review from a team, EmmanouelaPothitou, nikosdouvlis, octoper and panteliselef September 3, 2024 19:00

clerk-cookie added types clerk-js react elements labels Sep 3, 2024

panteliselef approved these changes Sep 4, 2024
View reviewed changes

octoper reviewed Sep 4, 2024
View reviewed changes

chanioxaris force-pushed the haris/user-655-remove-coinbase-web3-provider-and-strategy branch from 7841b21 to 0fc8d40Compare September 4, 2024 16:09

chanioxaris commented Sep 4, 2024
View reviewed changes

Comment threadpackages/elements/src/internals/machines/sign-in/verification.machine.ts Outdated

Apply code review suggestion
7fa822c

chanioxaris merged commit a0cb062 into mainSep 4, 2024

chanioxaris deleted the haris/user-655-remove-coinbase-web3-provider-and-strategy branch September 4, 2024 16:36

wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
chore(clerk-js,types,clerk-react,elements): Drop coinbase web3 provid…
e10fa83
…er (#4092)

chanioxaris requested review from a team, EmmanouelaPothitou, nikosdouvlis, octoper and panteliselef September 3, 2024 19:00

clerk-cookie added types clerk-js react elements labels Sep 3, 2024

panteliselef approved these changes Sep 4, 2024
View reviewed changes

octoper reviewed Sep 4, 2024
View reviewed changes

chanioxaris force-pushed the haris/user-655-remove-coinbase-web3-provider-and-strategy branch from 7841b21 to 0fc8d40Compare September 4, 2024 16:09

chanioxaris commented Sep 4, 2024
View reviewed changes

Comment threadpackages/elements/src/internals/machines/sign-in/verification.machine.ts Outdated

Apply code review suggestion
7fa822c

chanioxaris merged commit a0cb062 into mainSep 4, 2024

chanioxaris deleted the haris/user-655-remove-coinbase-web3-provider-and-strategy branch September 4, 2024 16:36

wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
chore(clerk-js,types,clerk-react,elements): Drop coinbase web3 provid…
e10fa83
…er (#4092)

chanioxaris requested review from a team, EmmanouelaPothitou, nikosdouvlis, octoper and panteliselef September 3, 2024 19:00

clerk-cookie added types clerk-js react elements labels Sep 3, 2024

panteliselef approved these changes Sep 4, 2024
View reviewed changes

octoper reviewed Sep 4, 2024
View reviewed changes

chanioxaris force-pushed the haris/user-655-remove-coinbase-web3-provider-and-strategy branch from 7841b21 to 0fc8d40Compare September 4, 2024 16:09

chanioxaris commented Sep 4, 2024
View reviewed changes

Comment threadpackages/elements/src/internals/machines/sign-in/verification.machine.ts Outdated

Apply code review suggestion
7fa822c

chanioxaris merged commit a0cb062 into mainSep 4, 2024

chanioxaris deleted the haris/user-655-remove-coinbase-web3-provider-and-strategy branch September 4, 2024 16:36

wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
chore(clerk-js,types,clerk-react,elements): Drop coinbase web3 provid…
e10fa83
…er (#4092)

chanioxaris requested review from a team, EmmanouelaPothitou, nikosdouvlis, octoper and panteliselef September 3, 2024 19:00

clerk-cookie added types clerk-js react elements labels Sep 3, 2024

panteliselef approved these changes Sep 4, 2024
View reviewed changes

octoper reviewed Sep 4, 2024
View reviewed changes

chanioxaris force-pushed the haris/user-655-remove-coinbase-web3-provider-and-strategy branch from 7841b21 to 0fc8d40Compare September 4, 2024 16:09

chanioxaris commented Sep 4, 2024
View reviewed changes

Comment threadpackages/elements/src/internals/machines/sign-in/verification.machine.ts Outdated

Apply code review suggestion
7fa822c

chanioxaris merged commit a0cb062 into mainSep 4, 2024

chanioxaris deleted the haris/user-655-remove-coinbase-web3-provider-and-strategy branch September 4, 2024 16:36

wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
chore(clerk-js,types,clerk-react,elements): Drop coinbase web3 provid…
e10fa83
…er (#4092)

chanioxaris requested review from a team, EmmanouelaPothitou, nikosdouvlis, octoper and panteliselef September 3, 2024 19:00

clerk-cookie added types clerk-js react elements labels Sep 3, 2024

panteliselef approved these changes Sep 4, 2024
View reviewed changes

octoper reviewed Sep 4, 2024
View reviewed changes

chanioxaris force-pushed the haris/user-655-remove-coinbase-web3-provider-and-strategy branch from 7841b21 to 0fc8d40Compare September 4, 2024 16:09

chanioxaris commented Sep 4, 2024
View reviewed changes

Comment threadpackages/elements/src/internals/machines/sign-in/verification.machine.ts Outdated

Apply code review suggestion
7fa822c

chanioxaris merged commit a0cb062 into mainSep 4, 2024

chanioxaris deleted the haris/user-655-remove-coinbase-web3-provider-and-strategy branch September 4, 2024 16:36

wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
chore(clerk-js,types,clerk-react,elements): Drop coinbase web3 provid…
e10fa83
…er (#4092)

chanioxaris requested review from a team, EmmanouelaPothitou, nikosdouvlis, octoper and panteliselef September 3, 2024 19:00

clerk-cookie added types clerk-js react elements labels Sep 3, 2024

panteliselef approved these changes Sep 4, 2024
View reviewed changes

octoper reviewed Sep 4, 2024
View reviewed changes

chanioxaris force-pushed the haris/user-655-remove-coinbase-web3-provider-and-strategy branch from 7841b21 to 0fc8d40Compare September 4, 2024 16:09

chanioxaris commented Sep 4, 2024
View reviewed changes

Comment threadpackages/elements/src/internals/machines/sign-in/verification.machine.ts Outdated

Apply code review suggestion
7fa822c

chanioxaris merged commit a0cb062 into mainSep 4, 2024

chanioxaris deleted the haris/user-655-remove-coinbase-web3-provider-and-strategy branch September 4, 2024 16:36

wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
chore(clerk-js,types,clerk-react,elements): Drop coinbase web3 provid…
e10fa83
…er (#4092)

chanioxaris requested review from a team, EmmanouelaPothitou, nikosdouvlis, octoper and panteliselef September 3, 2024 19:00

clerk-cookie added types clerk-js react elements labels Sep 3, 2024

panteliselef approved these changes Sep 4, 2024
View reviewed changes

octoper reviewed Sep 4, 2024
View reviewed changes

chanioxaris force-pushed the haris/user-655-remove-coinbase-web3-provider-and-strategy branch from 7841b21 to 0fc8d40Compare September 4, 2024 16:09

chanioxaris commented Sep 4, 2024
View reviewed changes

Comment threadpackages/elements/src/internals/machines/sign-in/verification.machine.ts Outdated

Apply code review suggestion
7fa822c

chanioxaris merged commit a0cb062 into mainSep 4, 2024

chanioxaris deleted the haris/user-655-remove-coinbase-web3-provider-and-strategy branch September 4, 2024 16:36

wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
chore(clerk-js,types,clerk-react,elements): Drop coinbase web3 provid…
e10fa83
…er (#4092)

chanioxaris requested review from a team, EmmanouelaPothitou, nikosdouvlis, octoper and panteliselef September 3, 2024 19:00

clerk-cookie added types clerk-js react elements labels Sep 3, 2024

panteliselef approved these changes Sep 4, 2024
View reviewed changes

octoper reviewed Sep 4, 2024
View reviewed changes

chanioxaris force-pushed the haris/user-655-remove-coinbase-web3-provider-and-strategy branch from 7841b21 to 0fc8d40Compare September 4, 2024 16:09

chanioxaris commented Sep 4, 2024
View reviewed changes

Comment threadpackages/elements/src/internals/machines/sign-in/verification.machine.ts Outdated

Apply code review suggestion
7fa822c

chanioxaris merged commit a0cb062 into mainSep 4, 2024

chanioxaris deleted the haris/user-655-remove-coinbase-web3-provider-and-strategy branch September 4, 2024 16:36

wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
chore(clerk-js,types,clerk-react,elements): Drop coinbase web3 provid…
e10fa83
…er (#4092)

Uh oh!

Conversation

chanioxaris commented Sep 3, 2024

Description

Checklist

Type of change

Uh oh!

changeset-botBot commented Sep 3, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

panteliselef left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

chanioxaris commented Sep 3, 2024

Description

Checklist

Type of change

Uh oh!

changeset-botBot commented Sep 3, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

panteliselef left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

chanioxaris commented Sep 3, 2024

Description

Checklist

Type of change

Uh oh!

changeset-botBot commented Sep 3, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

changeset-botBot commented Sep 3, 2024•
edited
Loading

changeset-botBot commented Sep 3, 2024•
edited
Loading

changeset-botBot commented Sep 3, 2024•
edited
Loading

changeset-botBot commented Sep 3, 2024•
edited
Loading