Uh oh!
There was an error while loading. Please reload this page.
fix(clerk-js): Ensure we do not access addEventListener and dispatchEvent in non-browser environments - #4095
Merged
wobsoriano merged 5 commits intoSep 3, 2024
Conversation
🦋 Changeset detectedLatest commit: 846c8cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wobsoriano
marked this pull request as ready for review
September 3, 2024 21:32
wobsoriano
commented
Sep 3, 2024
| }; | ||
| } | ||
| export const injectedWeb3Providers = new InjectedWeb3Providers(); |
MemberAuthor
There was a problem hiding this comment.
Exporting this makes it global (calling the addEventListener and dispatchEvent methods) and errors out in non-browser environments
addEventListener and dispatchEvent in non-browser environmentswobsoriano
marked this pull request as draft
September 3, 2024 21:51
wobsoriano
commented
Sep 3, 2024
| } | ||
| export const injectedWeb3Providers = new InjectedWeb3Providers(); | ||
| export const getInjectedWeb3Providers = () => InjectedWeb3Providers.getInstance(); |
MemberAuthor
There was a problem hiding this comment.
Exporting it now as a function but making sure it's still instantiated once
wobsoriano
marked this pull request as ready for review
September 3, 2024 22:04
brkalow
approved these changes
Sep 3, 2024
| constructor() { | ||
| private constructor() { | ||
| if (typeof window === 'undefined') { |
Member
There was a problem hiding this comment.
Odd that this didn't catch it. Does this mean expo is defining window, but notaddEventListener? 😵
wobsoriano
deleted the
rob/sdk-1922-clerk-expo-is-throwing-typeerror-windowaddeventlistener-is
branch
September 3, 2024 22:20
4 tasks
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes sure to NOT call browser specific methods (
addEventListener,dispatchEvent) implemented in 4059 in non-browser environments. Even though we are trying to block calls by checkingwindowobject, it'll still pass because React Native does have some polyfills to thewindowobject.Fixes SDK-1922
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change