Uh oh!
There was an error while loading. Please reload this page.
feat(types,clerk-js): Bypass captcha for providers dynamically provided in environment - #4322
Merged
nikosdouvlis merged 2 commits intoOct 14, 2024
Conversation
🦋 Changeset detectedLatest commit: ebe049d The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
approved these changes
Oct 14, 2024
Uh oh!
There was an error while loading. Please reload this page.
nikosdouvlis
deleted the
nikos/user-858-dynamically-bypass-captcha-for-oauth-providers
branch
October 14, 2024 13:40
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Why?
How?
This PR introduces the
displayConfig.captchaOauthBypassfield to replace the hard-coded values inclerk-js. The bypassed strategies will now be controlled by FAPI instead. If for any reason FAPI needs to be rolled back,clerk-jswill bypass captcha for google/ microsoft/ apple oauth as it does at the moment.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change