Skip to content

fix(tanstack-start): Fix environment variable loading in runtime contexts - #4743

Merged
wobsoriano merged 9 commits into
mainfrom
vaggelis/eco-274-env-loading-issue-in-tanstack-start
Jan 15, 2025
Merged

fix(tanstack-start): Fix environment variable loading in runtime contexts#4743
wobsoriano merged 9 commits into
mainfrom
vaggelis/eco-274-env-loading-issue-in-tanstack-start

Conversation

@octoper

@octoperoctoper commented Dec 10, 2024•
edited by wobsoriano
Loading

Copy link
Copy Markdown
Contributor

Description

The PR fixes an issue where environment variables are accessed global contexts, which doesn't work in runtimes like Cloudflare that only make them available during the request lifecycle.

Nitro environment variables guideline

Resolves ECO-288 and ECO-274

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented Dec 10, 2024•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6685212

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/tanstack-startPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Dec 10, 2024•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackJan 15, 2025 0:05am

@octoper

octoper commented Dec 10, 2024

Copy link
Copy Markdown
ContributorAuthor

!snapshot

@clerk-cookie

clerk-cookie commented Dec 10, 2024

Copy link
Copy Markdown
Collaborator

Hey @octoper - the snapshot version command generated the following package versions:

PackageVersion
@clerk/astro2.0.1-snapshot.v20241210001110
@clerk/backend1.20.3-snapshot.v20241210001110
@clerk/chrome-extension2.0.9-snapshot.v20241210001110
@clerk/clerk-js5.40.3-snapshot.v20241210001110
@clerk/elements0.21.4-snapshot.v20241210001110
@clerk/clerk-expo2.4.5-snapshot.v20241210001110
@clerk/expo-passkeys0.0.17-snapshot.v20241210001110
@clerk/express1.3.26-snapshot.v20241210001110
@clerk/fastify2.0.28-snapshot.v20241210001110
@clerk/localizations3.8.2-snapshot.v20241210001110
@clerk/nextjs6.8.3-snapshot.v20241210001110
@clerk/nuxt0.0.13-snapshot.v20241210001110
@clerk/clerk-react5.19.3-snapshot.v20241210001110
@clerk/react-router0.0.2-snapshot.v20241210001110
@clerk/remix4.3.6-snapshot.v20241210001110
@clerk/clerk-sdk-node5.0.77-snapshot.v20241210001110
@clerk/shared2.19.4-snapshot.v20241210001110
@clerk/tanstack-start0.7.0-snapshot.v20241210001110
@clerk/testing1.3.38-snapshot.v20241210001110
@clerk/themes2.1.55-snapshot.v20241210001110
@clerk/types4.39.2-snapshot.v20241210001110
@clerk/ui0.2.4-snapshot.v20241210001110
@clerk/vue0.0.17-snapshot.v20241210001110

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/astro@2.0.1-snapshot.v20241210001110 --save-exact

@clerk/backend

npm i @clerk/backend@1.20.3-snapshot.v20241210001110 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@2.0.9-snapshot.v20241210001110 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.40.3-snapshot.v20241210001110 --save-exact

@clerk/elements

npm i @clerk/elements@0.21.4-snapshot.v20241210001110 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@2.4.5-snapshot.v20241210001110 --save-exact

@clerk/expo-passkeys

npm i @clerk/expo-passkeys@0.0.17-snapshot.v20241210001110 --save-exact

@clerk/express

npm i @clerk/express@1.3.26-snapshot.v20241210001110 --save-exact

@clerk/fastify

npm i @clerk/fastify@2.0.28-snapshot.v20241210001110 --save-exact

@clerk/localizations

npm i @clerk/localizations@3.8.2-snapshot.v20241210001110 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@6.8.3-snapshot.v20241210001110 --save-exact

@clerk/nuxt

npm i @clerk/nuxt@0.0.13-snapshot.v20241210001110 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.19.3-snapshot.v20241210001110 --save-exact

@clerk/react-router

npm i @clerk/react-router@0.0.2-snapshot.v20241210001110 --save-exact

@clerk/remix

npm i @clerk/remix@4.3.6-snapshot.v20241210001110 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.77-snapshot.v20241210001110 --save-exact

@clerk/shared

npm i @clerk/shared@2.19.4-snapshot.v20241210001110 --save-exact

@clerk/tanstack-start

npm i @clerk/tanstack-start@0.7.0-snapshot.v20241210001110 --save-exact

@clerk/testing

npm i @clerk/testing@1.3.38-snapshot.v20241210001110 --save-exact

@clerk/themes

npm i @clerk/themes@2.1.55-snapshot.v20241210001110 --save-exact

@clerk/types

npm i @clerk/types@4.39.2-snapshot.v20241210001110 --save-exact

@clerk/ui

npm i @clerk/ui@0.2.4-snapshot.v20241210001110 --save-exact

@clerk/vue

npm i @clerk/vue@0.0.17-snapshot.v20241210001110 --save-exact

@clerkclerk deleted a comment from clerk-cookieJan 14, 2025
@wobsorianowobsoriano changed the title fix(tanstack-start): Fix ENV variable loadingfix(tanstack-start): Improve environment variable resolution for runtime contextJan 14, 2025
@wobsoriano

wobsoriano commented Jan 15, 2025

Copy link
Copy Markdown
Member

!snapshot

@clerk-cookie

clerk-cookie commented Jan 15, 2025

Copy link
Copy Markdown
Collaborator

Hey @wobsoriano - the snapshot version command generated the following package versions:

PackageVersion
@clerk/astro2.1.8-snapshot.v20250115000107
@clerk/backend1.22.1-snapshot.v20250115000107
@clerk/chrome-extension2.1.12-snapshot.v20250115000107
@clerk/clerk-js5.44.1-snapshot.v20250115000107
@clerk/clerk-expo2.6.11-snapshot.v20250115000107
@clerk/express1.3.35-snapshot.v20250115000107
@clerk/fastify2.1.8-snapshot.v20250115000107
@clerk/nextjs6.9.11-snapshot.v20250115000107
@clerk/nuxt1.0.4-snapshot.v20250115000107
@clerk/react-router0.1.9-snapshot.v20250115000107
@clerk/remix4.4.10-snapshot.v20250115000107
@clerk/tanstack-start0.8.9-snapshot.v20250115000107
@clerk/testing1.4.8-snapshot.v20250115000107
@clerk/vue1.0.3-snapshot.v20250115000107

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/astro@2.1.8-snapshot.v20250115000107 --save-exact

@clerk/backend

npm i @clerk/backend@1.22.1-snapshot.v20250115000107 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@2.1.12-snapshot.v20250115000107 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.44.1-snapshot.v20250115000107 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@2.6.11-snapshot.v20250115000107 --save-exact

@clerk/express

npm i @clerk/express@1.3.35-snapshot.v20250115000107 --save-exact

@clerk/fastify

npm i @clerk/fastify@2.1.8-snapshot.v20250115000107 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@6.9.11-snapshot.v20250115000107 --save-exact

@clerk/nuxt

npm i @clerk/nuxt@1.0.4-snapshot.v20250115000107 --save-exact

@clerk/react-router

npm i @clerk/react-router@0.1.9-snapshot.v20250115000107 --save-exact

@clerk/remix

npm i @clerk/remix@4.4.10-snapshot.v20250115000107 --save-exact

@clerk/tanstack-start

npm i @clerk/tanstack-start@0.8.9-snapshot.v20250115000107 --save-exact

@clerk/testing

npm i @clerk/testing@1.4.8-snapshot.v20250115000107 --save-exact

@clerk/vue

npm i @clerk/vue@1.0.3-snapshot.v20250115000107 --save-exact

@wobsorianowobsoriano changed the title fix(tanstack-start): Improve environment variable resolution for runtime contextfix(tanstack-start): Fix environment variable resolution for runtime contextJan 15, 2025
@wobsorianowobsoriano changed the title fix(tanstack-start): Fix environment variable resolution for runtime contextfix(tanstack-start): Fix environment variable loading in runtime contextsJan 15, 2025
wobsoriano
wobsoriano reviewed Jan 15, 2025
View reviewed changes
Comment threadpackages/tanstack-start/src/utils/env.ts
Comment on lines +16 to +20
// Cloudflare context check
const cfValue = event?.context?.cloudflare?.env[name];
if (cfValue) {
return cfValue;
}

@wobsorianowobsorianoJan 15, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitro injects the runtime env vars to the H3 event context. For Cloudflare, the property is event.context.cloudflare.

We pass this event object in a request lifecycle to make runtime env vars available

I answered the same question here.

@wobsoriano
wobsoriano marked this pull request as ready for review January 15, 2025 00:53
@wobsorianowobsoriano mentioned this pull request Jan 15, 2025
Closed
4 tasks
@wobsoriano
wobsoriano merged commit bd5f050 into mainJan 15, 2025
@wobsoriano
wobsoriano deleted the vaggelis/eco-274-env-loading-issue-in-tanstack-start branch January 15, 2025 15:30
@clerk-cookieclerk-cookie mentioned this pull request Jan 15, 2025
Merged
@wobsorianowobsoriano mentioned this pull request Jan 21, 2025
Closed
4 tasks
wobsoriano added a commit that referenced this pull request Feb 8, 2025
@octoper@wobsoriano
fix(tanstack-start): Fix environment variable loading in runtime cont…
3f7a4d7
…exts (#4743)
Co-authored-by: Robert Soriano <sorianorobertc@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano left review comments
@anagstefanagstefAwaiting requested review from anagstef
@panteliselefpanteliselefAwaiting requested review from panteliselef
+1 more reviewer
@LekoArtsLekoArtsLekoArts approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tanstack

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@octoper@clerk-cookie@wobsoriano@LekoArts
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(tanstack-start): Fix environment variable loading in runtime contexts by octoper · Pull Request #4743 · clerk/javascript · GitHub
Skip to content
fix(tanstack-start): Fix environment variable loading in runtime contexts - #4743
Merged
wobsoriano merged 9 commits into
mainfrom 
vaggelis/eco-274-env-loading-issue-in-tanstack-start
Jan 15, 2025
Merged
fix(tanstack-start): Fix environment variable loading in runtime contexts#4743
wobsoriano merged 9 commits into
mainfrom 
vaggelis/eco-274-env-loading-issue-in-tanstack-start
Conversation
@octoper
@octoperoctoper
commented
Dec 10, 2024•

edited by wobsoriano

Loading

Copy link


Copy Markdown

Contributor
Description
The PR fixes an issue where environment variables are accessed global contexts, which doesn't work in runtimes like Cloudflare that only make them available during the request lifecycle.
Nitro environment variables guideline
Resolves ECO-288 and ECO-274
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@changeset-bot
changeset-botBot
commented
Dec 10, 2024•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 6685212
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/tanstack-startPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Dec 10, 2024•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackJan 15, 2025 0:05am
@octoper
octoper
commented
Dec 10, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Dec 10, 2024

Copy link


Copy Markdown

Collaborator
Hey @octoper - the snapshot version command generated the following package versions:
PackageVersion
@clerk/astro2.0.1-snapshot.v20241210001110
@clerk/backend1.20.3-snapshot.v20241210001110
@clerk/chrome-extension2.0.9-snapshot.v20241210001110
@clerk/clerk-js5.40.3-snapshot.v20241210001110
@clerk/elements0.21.4-snapshot.v20241210001110
@clerk/clerk-expo2.4.5-snapshot.v20241210001110
@clerk/expo-passkeys0.0.17-snapshot.v20241210001110
@clerk/express1.3.26-snapshot.v20241210001110
@clerk/fastify2.0.28-snapshot.v20241210001110
@clerk/localizations3.8.2-snapshot.v20241210001110
@clerk/nextjs6.8.3-snapshot.v20241210001110
@clerk/nuxt0.0.13-snapshot.v20241210001110
@clerk/clerk-react5.19.3-snapshot.v20241210001110
@clerk/react-router0.0.2-snapshot.v20241210001110
@clerk/remix4.3.6-snapshot.v20241210001110
@clerk/clerk-sdk-node5.0.77-snapshot.v20241210001110
@clerk/shared2.19.4-snapshot.v20241210001110
@clerk/tanstack-start0.7.0-snapshot.v20241210001110
@clerk/testing1.3.38-snapshot.v20241210001110
@clerk/themes2.1.55-snapshot.v20241210001110
@clerk/types4.39.2-snapshot.v20241210001110
@clerk/ui0.2.4-snapshot.v20241210001110
@clerk/vue0.0.17-snapshot.v20241210001110
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro
npm i @clerk/astro@2.0.1-snapshot.v20241210001110 --save-exact
@clerk/backend
npm i @clerk/backend@1.20.3-snapshot.v20241210001110 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@2.0.9-snapshot.v20241210001110 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.40.3-snapshot.v20241210001110 --save-exact
@clerk/elements
npm i @clerk/elements@0.21.4-snapshot.v20241210001110 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@2.4.5-snapshot.v20241210001110 --save-exact
@clerk/expo-passkeys
npm i @clerk/expo-passkeys@0.0.17-snapshot.v20241210001110 --save-exact
@clerk/express
npm i @clerk/express@1.3.26-snapshot.v20241210001110 --save-exact
@clerk/fastify
npm i @clerk/fastify@2.0.28-snapshot.v20241210001110 --save-exact
@clerk/localizations
npm i @clerk/localizations@3.8.2-snapshot.v20241210001110 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@6.8.3-snapshot.v20241210001110 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@0.0.13-snapshot.v20241210001110 --save-exact
@clerk/clerk-react
npm i @clerk/clerk-react@5.19.3-snapshot.v20241210001110 --save-exact
@clerk/react-router
npm i @clerk/react-router@0.0.2-snapshot.v20241210001110 --save-exact
@clerk/remix
npm i @clerk/remix@4.3.6-snapshot.v20241210001110 --save-exact
@clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@5.0.77-snapshot.v20241210001110 --save-exact
@clerk/shared
npm i @clerk/shared@2.19.4-snapshot.v20241210001110 --save-exact
@clerk/tanstack-start
npm i @clerk/tanstack-start@0.7.0-snapshot.v20241210001110 --save-exact
@clerk/testing
npm i @clerk/testing@1.3.38-snapshot.v20241210001110 --save-exact
@clerk/themes
npm i @clerk/themes@2.1.55-snapshot.v20241210001110 --save-exact
@clerk/types
npm i @clerk/types@4.39.2-snapshot.v20241210001110 --save-exact
@clerk/ui
npm i @clerk/ui@0.2.4-snapshot.v20241210001110 --save-exact
@clerk/vue
npm i @clerk/vue@0.0.17-snapshot.v20241210001110 --save-exact
@clerkclerk
deleted a comment from clerk-cookieJan 14, 2025
@wobsorianowobsoriano
changed the title
fix(tanstack-start): Fix ENV variable loadingfix(tanstack-start): Improve environment variable resolution for runtime contextJan 14, 2025
@wobsoriano
wobsoriano
commented
Jan 15, 2025

Copy link


Copy Markdown

Member
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 15, 2025

Copy link


Copy Markdown

Collaborator
Hey @wobsoriano - the snapshot version command generated the following package versions:
PackageVersion
@clerk/astro2.1.8-snapshot.v20250115000107
@clerk/backend1.22.1-snapshot.v20250115000107
@clerk/chrome-extension2.1.12-snapshot.v20250115000107
@clerk/clerk-js5.44.1-snapshot.v20250115000107
@clerk/clerk-expo2.6.11-snapshot.v20250115000107
@clerk/express1.3.35-snapshot.v20250115000107
@clerk/fastify2.1.8-snapshot.v20250115000107
@clerk/nextjs6.9.11-snapshot.v20250115000107
@clerk/nuxt1.0.4-snapshot.v20250115000107
@clerk/react-router0.1.9-snapshot.v20250115000107
@clerk/remix4.4.10-snapshot.v20250115000107
@clerk/tanstack-start0.8.9-snapshot.v20250115000107
@clerk/testing1.4.8-snapshot.v20250115000107
@clerk/vue1.0.3-snapshot.v20250115000107
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro
npm i @clerk/astro@2.1.8-snapshot.v20250115000107 --save-exact
@clerk/backend
npm i @clerk/backend@1.22.1-snapshot.v20250115000107 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@2.1.12-snapshot.v20250115000107 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.44.1-snapshot.v20250115000107 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@2.6.11-snapshot.v20250115000107 --save-exact
@clerk/express
npm i @clerk/express@1.3.35-snapshot.v20250115000107 --save-exact
@clerk/fastify
npm i @clerk/fastify@2.1.8-snapshot.v20250115000107 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@6.9.11-snapshot.v20250115000107 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@1.0.4-snapshot.v20250115000107 --save-exact
@clerk/react-router
npm i @clerk/react-router@0.1.9-snapshot.v20250115000107 --save-exact
@clerk/remix
npm i @clerk/remix@4.4.10-snapshot.v20250115000107 --save-exact
@clerk/tanstack-start
npm i @clerk/tanstack-start@0.8.9-snapshot.v20250115000107 --save-exact
@clerk/testing
npm i @clerk/testing@1.4.8-snapshot.v20250115000107 --save-exact
@clerk/vue
npm i @clerk/vue@1.0.3-snapshot.v20250115000107 --save-exact
@wobsorianowobsoriano
changed the title
fix(tanstack-start): Improve environment variable resolution for runtime contextfix(tanstack-start): Fix environment variable resolution for runtime contextJan 15, 2025
@wobsorianowobsoriano
changed the title
fix(tanstack-start): Fix environment variable resolution for runtime contextfix(tanstack-start): Fix environment variable loading in runtime contextsJan 15, 2025
wobsoriano
wobsoriano
reviewed
Jan 15, 2025
View reviewed changes
Comment threadpackages/tanstack-start/src/utils/env.ts

Comment on lines

+16
 to 
+20

 // Cloudflare context check
 const cfValue = event?.context?.cloudflare?.env[name];
 if (cfValue) {
 return cfValue;
 }
@wobsorianowobsorianoJan 15, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitro injects the runtime env vars to the H3 event context. For Cloudflare, the property is event.context.cloudflare.
We pass this event object in a request lifecycle to make runtime env vars available
I answered the same question here.
@wobsoriano
wobsoriano
marked this pull request as ready for review
January 15, 2025 00:53
@wobsorianowobsoriano
mentioned this pull request
Jan 15, 2025

Closed

4 tasks
@wobsoriano
wobsoriano
merged commit bd5f050
into
mainJan 15, 2025
@wobsoriano
wobsoriano
deleted the

vaggelis/eco-274-env-loading-issue-in-tanstack-start

branch
January 15, 2025 15:30
@clerk-cookieclerk-cookie
mentioned this pull request
Jan 15, 2025
 Merged

@wobsorianowobsoriano
mentioned this pull request
Jan 21, 2025

Closed

4 tasks
wobsoriano added a commit
that referenced
this pull request
Feb 8, 2025
@octoper@wobsoriano
fix(tanstack-start): Fix environment variable loading in runtime cont…
3f7a4d7
…exts (#4743)
Co-authored-by: Robert Soriano <sorianorobertc@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano left review comments
@anagstefanagstefAwaiting requested review from anagstef
@panteliselefpanteliselefAwaiting requested review from panteliselef

+1 more reviewer

@LekoArtsLekoArtsLekoArts approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

tanstack

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@octoper@clerk-cookie@wobsoriano@LekoArts

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(tanstack-start): Fix environment variable loading in runtime contexts by octoper · Pull Request #4743 · clerk/javascript · GitHub
Skip to content
fix(tanstack-start): Fix environment variable loading in runtime contexts - #4743
Merged
wobsoriano merged 9 commits into
mainfrom 
vaggelis/eco-274-env-loading-issue-in-tanstack-start
Jan 15, 2025
Merged
fix(tanstack-start): Fix environment variable loading in runtime contexts#4743
wobsoriano merged 9 commits into
mainfrom 
vaggelis/eco-274-env-loading-issue-in-tanstack-start
Conversation
@octoper
@octoperoctoper
commented
Dec 10, 2024•

edited by wobsoriano

Loading

Copy link


Copy Markdown

Contributor
Description
The PR fixes an issue where environment variables are accessed global contexts, which doesn't work in runtimes like Cloudflare that only make them available during the request lifecycle.
Nitro environment variables guideline
Resolves ECO-288 and ECO-274
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@changeset-bot
changeset-botBot
commented
Dec 10, 2024•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 6685212
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/tanstack-startPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Dec 10, 2024•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackJan 15, 2025 0:05am
@octoper
octoper
commented
Dec 10, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Dec 10, 2024

Copy link


Copy Markdown

Collaborator
Hey @octoper - the snapshot version command generated the following package versions:
PackageVersion
@clerk/astro2.0.1-snapshot.v20241210001110
@clerk/backend1.20.3-snapshot.v20241210001110
@clerk/chrome-extension2.0.9-snapshot.v20241210001110
@clerk/clerk-js5.40.3-snapshot.v20241210001110
@clerk/elements0.21.4-snapshot.v20241210001110
@clerk/clerk-expo2.4.5-snapshot.v20241210001110
@clerk/expo-passkeys0.0.17-snapshot.v20241210001110
@clerk/express1.3.26-snapshot.v20241210001110
@clerk/fastify2.0.28-snapshot.v20241210001110
@clerk/localizations3.8.2-snapshot.v20241210001110
@clerk/nextjs6.8.3-snapshot.v20241210001110
@clerk/nuxt0.0.13-snapshot.v20241210001110
@clerk/clerk-react5.19.3-snapshot.v20241210001110
@clerk/react-router0.0.2-snapshot.v20241210001110
@clerk/remix4.3.6-snapshot.v20241210001110
@clerk/clerk-sdk-node5.0.77-snapshot.v20241210001110
@clerk/shared2.19.4-snapshot.v20241210001110
@clerk/tanstack-start0.7.0-snapshot.v20241210001110
@clerk/testing1.3.38-snapshot.v20241210001110
@clerk/themes2.1.55-snapshot.v20241210001110
@clerk/types4.39.2-snapshot.v20241210001110
@clerk/ui0.2.4-snapshot.v20241210001110
@clerk/vue0.0.17-snapshot.v20241210001110
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro
npm i @clerk/astro@2.0.1-snapshot.v20241210001110 --save-exact
@clerk/backend
npm i @clerk/backend@1.20.3-snapshot.v20241210001110 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@2.0.9-snapshot.v20241210001110 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.40.3-snapshot.v20241210001110 --save-exact
@clerk/elements
npm i @clerk/elements@0.21.4-snapshot.v20241210001110 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@2.4.5-snapshot.v20241210001110 --save-exact
@clerk/expo-passkeys
npm i @clerk/expo-passkeys@0.0.17-snapshot.v20241210001110 --save-exact
@clerk/express
npm i @clerk/express@1.3.26-snapshot.v20241210001110 --save-exact
@clerk/fastify
npm i @clerk/fastify@2.0.28-snapshot.v20241210001110 --save-exact
@clerk/localizations
npm i @clerk/localizations@3.8.2-snapshot.v20241210001110 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@6.8.3-snapshot.v20241210001110 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@0.0.13-snapshot.v20241210001110 --save-exact
@clerk/clerk-react
npm i @clerk/clerk-react@5.19.3-snapshot.v20241210001110 --save-exact
@clerk/react-router
npm i @clerk/react-router@0.0.2-snapshot.v20241210001110 --save-exact
@clerk/remix
npm i @clerk/remix@4.3.6-snapshot.v20241210001110 --save-exact
@clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@5.0.77-snapshot.v20241210001110 --save-exact
@clerk/shared
npm i @clerk/shared@2.19.4-snapshot.v20241210001110 --save-exact
@clerk/tanstack-start
npm i @clerk/tanstack-start@0.7.0-snapshot.v20241210001110 --save-exact
@clerk/testing
npm i @clerk/testing@1.3.38-snapshot.v20241210001110 --save-exact
@clerk/themes
npm i @clerk/themes@2.1.55-snapshot.v20241210001110 --save-exact
@clerk/types
npm i @clerk/types@4.39.2-snapshot.v20241210001110 --save-exact
@clerk/ui
npm i @clerk/ui@0.2.4-snapshot.v20241210001110 --save-exact
@clerk/vue
npm i @clerk/vue@0.0.17-snapshot.v20241210001110 --save-exact
@clerkclerk
deleted a comment from clerk-cookieJan 14, 2025
@wobsorianowobsoriano
changed the title
fix(tanstack-start): Fix ENV variable loadingfix(tanstack-start): Improve environment variable resolution for runtime contextJan 14, 2025
@wobsoriano
wobsoriano
commented
Jan 15, 2025

Copy link


Copy Markdown

Member
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 15, 2025

Copy link


Copy Markdown

Collaborator
Hey @wobsoriano - the snapshot version command generated the following package versions:
PackageVersion
@clerk/astro2.1.8-snapshot.v20250115000107
@clerk/backend1.22.1-snapshot.v20250115000107
@clerk/chrome-extension2.1.12-snapshot.v20250115000107
@clerk/clerk-js5.44.1-snapshot.v20250115000107
@clerk/clerk-expo2.6.11-snapshot.v20250115000107
@clerk/express1.3.35-snapshot.v20250115000107
@clerk/fastify2.1.8-snapshot.v20250115000107
@clerk/nextjs6.9.11-snapshot.v20250115000107
@clerk/nuxt1.0.4-snapshot.v20250115000107
@clerk/react-router0.1.9-snapshot.v20250115000107
@clerk/remix4.4.10-snapshot.v20250115000107
@clerk/tanstack-start0.8.9-snapshot.v20250115000107
@clerk/testing1.4.8-snapshot.v20250115000107
@clerk/vue1.0.3-snapshot.v20250115000107
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro
npm i @clerk/astro@2.1.8-snapshot.v20250115000107 --save-exact
@clerk/backend
npm i @clerk/backend@1.22.1-snapshot.v20250115000107 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@2.1.12-snapshot.v20250115000107 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.44.1-snapshot.v20250115000107 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@2.6.11-snapshot.v20250115000107 --save-exact
@clerk/express
npm i @clerk/express@1.3.35-snapshot.v20250115000107 --save-exact
@clerk/fastify
npm i @clerk/fastify@2.1.8-snapshot.v20250115000107 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@6.9.11-snapshot.v20250115000107 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@1.0.4-snapshot.v20250115000107 --save-exact
@clerk/react-router
npm i @clerk/react-router@0.1.9-snapshot.v20250115000107 --save-exact
@clerk/remix
npm i @clerk/remix@4.4.10-snapshot.v20250115000107 --save-exact
@clerk/tanstack-start
npm i @clerk/tanstack-start@0.8.9-snapshot.v20250115000107 --save-exact
@clerk/testing
npm i @clerk/testing@1.4.8-snapshot.v20250115000107 --save-exact
@clerk/vue
npm i @clerk/vue@1.0.3-snapshot.v20250115000107 --save-exact
@wobsorianowobsoriano
changed the title
fix(tanstack-start): Improve environment variable resolution for runtime contextfix(tanstack-start): Fix environment variable resolution for runtime contextJan 15, 2025
@wobsorianowobsoriano
changed the title
fix(tanstack-start): Fix environment variable resolution for runtime contextfix(tanstack-start): Fix environment variable loading in runtime contextsJan 15, 2025
wobsoriano
wobsoriano
reviewed
Jan 15, 2025
View reviewed changes
Comment threadpackages/tanstack-start/src/utils/env.ts

Comment on lines

+16
 to 
+20

 // Cloudflare context check
 const cfValue = event?.context?.cloudflare?.env[name];
 if (cfValue) {
 return cfValue;
 }
@wobsorianowobsorianoJan 15, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitro injects the runtime env vars to the H3 event context. For Cloudflare, the property is event.context.cloudflare.
We pass this event object in a request lifecycle to make runtime env vars available
I answered the same question here.
@wobsoriano
wobsoriano
marked this pull request as ready for review
January 15, 2025 00:53
@wobsorianowobsoriano
mentioned this pull request
Jan 15, 2025

Closed

4 tasks
@wobsoriano
wobsoriano
merged commit bd5f050
into
mainJan 15, 2025
@wobsoriano
wobsoriano
deleted the

vaggelis/eco-274-env-loading-issue-in-tanstack-start

branch
January 15, 2025 15:30
@clerk-cookieclerk-cookie
mentioned this pull request
Jan 15, 2025
 Merged

@wobsorianowobsoriano
mentioned this pull request
Jan 21, 2025

Closed

4 tasks
wobsoriano added a commit
that referenced
this pull request
Feb 8, 2025
@octoper@wobsoriano
fix(tanstack-start): Fix environment variable loading in runtime cont…
3f7a4d7
…exts (#4743)
Co-authored-by: Robert Soriano <sorianorobertc@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano left review comments
@anagstefanagstefAwaiting requested review from anagstef
@panteliselefpanteliselefAwaiting requested review from panteliselef

+1 more reviewer

@LekoArtsLekoArtsLekoArts approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

tanstack

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@octoper@clerk-cookie@wobsoriano@LekoArts

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(tanstack-start): Fix environment variable loading in runtime contexts by octoper · Pull Request #4743 · clerk/javascript · GitHub
Skip to content
fix(tanstack-start): Fix environment variable loading in runtime contexts - #4743
Merged
wobsoriano merged 9 commits into
mainfrom 
vaggelis/eco-274-env-loading-issue-in-tanstack-start
Jan 15, 2025
Merged
fix(tanstack-start): Fix environment variable loading in runtime contexts#4743
wobsoriano merged 9 commits into
mainfrom 
vaggelis/eco-274-env-loading-issue-in-tanstack-start
Conversation
@octoper
@octoperoctoper
commented
Dec 10, 2024•

edited by wobsoriano

Loading

Copy link


Copy Markdown

Contributor
Description
The PR fixes an issue where environment variables are accessed global contexts, which doesn't work in runtimes like Cloudflare that only make them available during the request lifecycle.
Nitro environment variables guideline
Resolves ECO-288 and ECO-274
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@changeset-bot
changeset-botBot
commented
Dec 10, 2024•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 6685212
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/tanstack-startPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Dec 10, 2024•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackJan 15, 2025 0:05am
@octoper
octoper
commented
Dec 10, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Dec 10, 2024

Copy link


Copy Markdown

Collaborator
Hey @octoper - the snapshot version command generated the following package versions:
PackageVersion
@clerk/astro2.0.1-snapshot.v20241210001110
@clerk/backend1.20.3-snapshot.v20241210001110
@clerk/chrome-extension2.0.9-snapshot.v20241210001110
@clerk/clerk-js5.40.3-snapshot.v20241210001110
@clerk/elements0.21.4-snapshot.v20241210001110
@clerk/clerk-expo2.4.5-snapshot.v20241210001110
@clerk/expo-passkeys0.0.17-snapshot.v20241210001110
@clerk/express1.3.26-snapshot.v20241210001110
@clerk/fastify2.0.28-snapshot.v20241210001110
@clerk/localizations3.8.2-snapshot.v20241210001110
@clerk/nextjs6.8.3-snapshot.v20241210001110
@clerk/nuxt0.0.13-snapshot.v20241210001110
@clerk/clerk-react5.19.3-snapshot.v20241210001110
@clerk/react-router0.0.2-snapshot.v20241210001110
@clerk/remix4.3.6-snapshot.v20241210001110
@clerk/clerk-sdk-node5.0.77-snapshot.v20241210001110
@clerk/shared2.19.4-snapshot.v20241210001110
@clerk/tanstack-start0.7.0-snapshot.v20241210001110
@clerk/testing1.3.38-snapshot.v20241210001110
@clerk/themes2.1.55-snapshot.v20241210001110
@clerk/types4.39.2-snapshot.v20241210001110
@clerk/ui0.2.4-snapshot.v20241210001110
@clerk/vue0.0.17-snapshot.v20241210001110
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro
npm i @clerk/astro@2.0.1-snapshot.v20241210001110 --save-exact
@clerk/backend
npm i @clerk/backend@1.20.3-snapshot.v20241210001110 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@2.0.9-snapshot.v20241210001110 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.40.3-snapshot.v20241210001110 --save-exact
@clerk/elements
npm i @clerk/elements@0.21.4-snapshot.v20241210001110 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@2.4.5-snapshot.v20241210001110 --save-exact
@clerk/expo-passkeys
npm i @clerk/expo-passkeys@0.0.17-snapshot.v20241210001110 --save-exact
@clerk/express
npm i @clerk/express@1.3.26-snapshot.v20241210001110 --save-exact
@clerk/fastify
npm i @clerk/fastify@2.0.28-snapshot.v20241210001110 --save-exact
@clerk/localizations
npm i @clerk/localizations@3.8.2-snapshot.v20241210001110 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@6.8.3-snapshot.v20241210001110 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@0.0.13-snapshot.v20241210001110 --save-exact
@clerk/clerk-react
npm i @clerk/clerk-react@5.19.3-snapshot.v20241210001110 --save-exact
@clerk/react-router
npm i @clerk/react-router@0.0.2-snapshot.v20241210001110 --save-exact
@clerk/remix
npm i @clerk/remix@4.3.6-snapshot.v20241210001110 --save-exact
@clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@5.0.77-snapshot.v20241210001110 --save-exact
@clerk/shared
npm i @clerk/shared@2.19.4-snapshot.v20241210001110 --save-exact
@clerk/tanstack-start
npm i @clerk/tanstack-start@0.7.0-snapshot.v20241210001110 --save-exact
@clerk/testing
npm i @clerk/testing@1.3.38-snapshot.v20241210001110 --save-exact
@clerk/themes
npm i @clerk/themes@2.1.55-snapshot.v20241210001110 --save-exact
@clerk/types
npm i @clerk/types@4.39.2-snapshot.v20241210001110 --save-exact
@clerk/ui
npm i @clerk/ui@0.2.4-snapshot.v20241210001110 --save-exact
@clerk/vue
npm i @clerk/vue@0.0.17-snapshot.v20241210001110 --save-exact
@clerkclerk
deleted a comment from clerk-cookieJan 14, 2025
@wobsorianowobsoriano
changed the title
fix(tanstack-start): Fix ENV variable loadingfix(tanstack-start): Improve environment variable resolution for runtime contextJan 14, 2025
@wobsoriano
wobsoriano
commented
Jan 15, 2025

Copy link


Copy Markdown

Member
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 15, 2025

Copy link


Copy Markdown

Collaborator
Hey @wobsoriano - the snapshot version command generated the following package versions:
PackageVersion
@clerk/astro2.1.8-snapshot.v20250115000107
@clerk/backend1.22.1-snapshot.v20250115000107
@clerk/chrome-extension2.1.12-snapshot.v20250115000107
@clerk/clerk-js5.44.1-snapshot.v20250115000107
@clerk/clerk-expo2.6.11-snapshot.v20250115000107
@clerk/express1.3.35-snapshot.v20250115000107
@clerk/fastify2.1.8-snapshot.v20250115000107
@clerk/nextjs6.9.11-snapshot.v20250115000107
@clerk/nuxt1.0.4-snapshot.v20250115000107
@clerk/react-router0.1.9-snapshot.v20250115000107
@clerk/remix4.4.10-snapshot.v20250115000107
@clerk/tanstack-start0.8.9-snapshot.v20250115000107
@clerk/testing1.4.8-snapshot.v20250115000107
@clerk/vue1.0.3-snapshot.v20250115000107
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro
npm i @clerk/astro@2.1.8-snapshot.v20250115000107 --save-exact
@clerk/backend
npm i @clerk/backend@1.22.1-snapshot.v20250115000107 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@2.1.12-snapshot.v20250115000107 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.44.1-snapshot.v20250115000107 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@2.6.11-snapshot.v20250115000107 --save-exact
@clerk/express
npm i @clerk/express@1.3.35-snapshot.v20250115000107 --save-exact
@clerk/fastify
npm i @clerk/fastify@2.1.8-snapshot.v20250115000107 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@6.9.11-snapshot.v20250115000107 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@1.0.4-snapshot.v20250115000107 --save-exact
@clerk/react-router
npm i @clerk/react-router@0.1.9-snapshot.v20250115000107 --save-exact
@clerk/remix
npm i @clerk/remix@4.4.10-snapshot.v20250115000107 --save-exact
@clerk/tanstack-start
npm i @clerk/tanstack-start@0.8.9-snapshot.v20250115000107 --save-exact
@clerk/testing
npm i @clerk/testing@1.4.8-snapshot.v20250115000107 --save-exact
@clerk/vue
npm i @clerk/vue@1.0.3-snapshot.v20250115000107 --save-exact
@wobsorianowobsoriano
changed the title
fix(tanstack-start): Improve environment variable resolution for runtime contextfix(tanstack-start): Fix environment variable resolution for runtime contextJan 15, 2025
@wobsorianowobsoriano
changed the title
fix(tanstack-start): Fix environment variable resolution for runtime contextfix(tanstack-start): Fix environment variable loading in runtime contextsJan 15, 2025
wobsoriano
wobsoriano
reviewed
Jan 15, 2025
View reviewed changes
Comment threadpackages/tanstack-start/src/utils/env.ts

Comment on lines

+16
 to 
+20

 // Cloudflare context check
 const cfValue = event?.context?.cloudflare?.env[name];
 if (cfValue) {
 return cfValue;
 }
@wobsorianowobsorianoJan 15, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitro injects the runtime env vars to the H3 event context. For Cloudflare, the property is event.context.cloudflare.
We pass this event object in a request lifecycle to make runtime env vars available
I answered the same question here.
@wobsoriano
wobsoriano
marked this pull request as ready for review
January 15, 2025 00:53
@wobsorianowobsoriano
mentioned this pull request
Jan 15, 2025

Closed

4 tasks
@wobsoriano
wobsoriano
merged commit bd5f050
into
mainJan 15, 2025
@wobsoriano
wobsoriano
deleted the

vaggelis/eco-274-env-loading-issue-in-tanstack-start

branch
January 15, 2025 15:30
@clerk-cookieclerk-cookie
mentioned this pull request
Jan 15, 2025
 Merged

@wobsorianowobsoriano
mentioned this pull request
Jan 21, 2025

Closed

4 tasks
wobsoriano added a commit
that referenced
this pull request
Feb 8, 2025
@octoper@wobsoriano
fix(tanstack-start): Fix environment variable loading in runtime cont…
3f7a4d7
…exts (#4743)
Co-authored-by: Robert Soriano <sorianorobertc@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano left review comments
@anagstefanagstefAwaiting requested review from anagstef
@panteliselefpanteliselefAwaiting requested review from panteliselef

+1 more reviewer

@LekoArtsLekoArtsLekoArts approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

tanstack

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@octoper@clerk-cookie@wobsoriano@LekoArts

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(tanstack-start): Fix environment variable loading in runtime contexts by octoper · Pull Request #4743 · clerk/javascript · GitHub
Skip to content
fix(tanstack-start): Fix environment variable loading in runtime contexts - #4743
Merged
wobsoriano merged 9 commits into
mainfrom 
vaggelis/eco-274-env-loading-issue-in-tanstack-start
Jan 15, 2025
Merged
fix(tanstack-start): Fix environment variable loading in runtime contexts#4743
wobsoriano merged 9 commits into
mainfrom 
vaggelis/eco-274-env-loading-issue-in-tanstack-start
Conversation
@octoper
@octoperoctoper
commented
Dec 10, 2024•

edited by wobsoriano

Loading

Copy link


Copy Markdown

Contributor
Description
The PR fixes an issue where environment variables are accessed global contexts, which doesn't work in runtimes like Cloudflare that only make them available during the request lifecycle.
Nitro environment variables guideline
Resolves ECO-288 and ECO-274
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@changeset-bot
changeset-botBot
commented
Dec 10, 2024•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 6685212
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/tanstack-startPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Dec 10, 2024•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackJan 15, 2025 0:05am
@octoper
octoper
commented
Dec 10, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Dec 10, 2024

Copy link


Copy Markdown

Collaborator
Hey @octoper - the snapshot version command generated the following package versions:
PackageVersion
@clerk/astro2.0.1-snapshot.v20241210001110
@clerk/backend1.20.3-snapshot.v20241210001110
@clerk/chrome-extension2.0.9-snapshot.v20241210001110
@clerk/clerk-js5.40.3-snapshot.v20241210001110
@clerk/elements0.21.4-snapshot.v20241210001110
@clerk/clerk-expo2.4.5-snapshot.v20241210001110
@clerk/expo-passkeys0.0.17-snapshot.v20241210001110
@clerk/express1.3.26-snapshot.v20241210001110
@clerk/fastify2.0.28-snapshot.v20241210001110
@clerk/localizations3.8.2-snapshot.v20241210001110
@clerk/nextjs6.8.3-snapshot.v20241210001110
@clerk/nuxt0.0.13-snapshot.v20241210001110
@clerk/clerk-react5.19.3-snapshot.v20241210001110
@clerk/react-router0.0.2-snapshot.v20241210001110
@clerk/remix4.3.6-snapshot.v20241210001110
@clerk/clerk-sdk-node5.0.77-snapshot.v20241210001110
@clerk/shared2.19.4-snapshot.v20241210001110
@clerk/tanstack-start0.7.0-snapshot.v20241210001110
@clerk/testing1.3.38-snapshot.v20241210001110
@clerk/themes2.1.55-snapshot.v20241210001110
@clerk/types4.39.2-snapshot.v20241210001110
@clerk/ui0.2.4-snapshot.v20241210001110
@clerk/vue0.0.17-snapshot.v20241210001110
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro
npm i @clerk/astro@2.0.1-snapshot.v20241210001110 --save-exact
@clerk/backend
npm i @clerk/backend@1.20.3-snapshot.v20241210001110 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@2.0.9-snapshot.v20241210001110 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.40.3-snapshot.v20241210001110 --save-exact
@clerk/elements
npm i @clerk/elements@0.21.4-snapshot.v20241210001110 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@2.4.5-snapshot.v20241210001110 --save-exact
@clerk/expo-passkeys
npm i @clerk/expo-passkeys@0.0.17-snapshot.v20241210001110 --save-exact
@clerk/express
npm i @clerk/express@1.3.26-snapshot.v20241210001110 --save-exact
@clerk/fastify
npm i @clerk/fastify@2.0.28-snapshot.v20241210001110 --save-exact
@clerk/localizations
npm i @clerk/localizations@3.8.2-snapshot.v20241210001110 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@6.8.3-snapshot.v20241210001110 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@0.0.13-snapshot.v20241210001110 --save-exact
@clerk/clerk-react
npm i @clerk/clerk-react@5.19.3-snapshot.v20241210001110 --save-exact
@clerk/react-router
npm i @clerk/react-router@0.0.2-snapshot.v20241210001110 --save-exact
@clerk/remix
npm i @clerk/remix@4.3.6-snapshot.v20241210001110 --save-exact
@clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@5.0.77-snapshot.v20241210001110 --save-exact
@clerk/shared
npm i @clerk/shared@2.19.4-snapshot.v20241210001110 --save-exact
@clerk/tanstack-start
npm i @clerk/tanstack-start@0.7.0-snapshot.v20241210001110 --save-exact
@clerk/testing
npm i @clerk/testing@1.3.38-snapshot.v20241210001110 --save-exact
@clerk/themes
npm i @clerk/themes@2.1.55-snapshot.v20241210001110 --save-exact
@clerk/types
npm i @clerk/types@4.39.2-snapshot.v20241210001110 --save-exact
@clerk/ui
npm i @clerk/ui@0.2.4-snapshot.v20241210001110 --save-exact
@clerk/vue
npm i @clerk/vue@0.0.17-snapshot.v20241210001110 --save-exact
@clerkclerk
deleted a comment from clerk-cookieJan 14, 2025
@wobsorianowobsoriano
changed the title
fix(tanstack-start): Fix ENV variable loadingfix(tanstack-start): Improve environment variable resolution for runtime contextJan 14, 2025
@wobsoriano
wobsoriano
commented
Jan 15, 2025

Copy link


Copy Markdown

Member
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 15, 2025

Copy link


Copy Markdown

Collaborator
Hey @wobsoriano - the snapshot version command generated the following package versions:
PackageVersion
@clerk/astro2.1.8-snapshot.v20250115000107
@clerk/backend1.22.1-snapshot.v20250115000107
@clerk/chrome-extension2.1.12-snapshot.v20250115000107
@clerk/clerk-js5.44.1-snapshot.v20250115000107
@clerk/clerk-expo2.6.11-snapshot.v20250115000107
@clerk/express1.3.35-snapshot.v20250115000107
@clerk/fastify2.1.8-snapshot.v20250115000107
@clerk/nextjs6.9.11-snapshot.v20250115000107
@clerk/nuxt1.0.4-snapshot.v20250115000107
@clerk/react-router0.1.9-snapshot.v20250115000107
@clerk/remix4.4.10-snapshot.v20250115000107
@clerk/tanstack-start0.8.9-snapshot.v20250115000107
@clerk/testing1.4.8-snapshot.v20250115000107
@clerk/vue1.0.3-snapshot.v20250115000107
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro
npm i @clerk/astro@2.1.8-snapshot.v20250115000107 --save-exact
@clerk/backend
npm i @clerk/backend@1.22.1-snapshot.v20250115000107 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@2.1.12-snapshot.v20250115000107 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.44.1-snapshot.v20250115000107 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@2.6.11-snapshot.v20250115000107 --save-exact
@clerk/express
npm i @clerk/express@1.3.35-snapshot.v20250115000107 --save-exact
@clerk/fastify
npm i @clerk/fastify@2.1.8-snapshot.v20250115000107 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@6.9.11-snapshot.v20250115000107 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@1.0.4-snapshot.v20250115000107 --save-exact
@clerk/react-router
npm i @clerk/react-router@0.1.9-snapshot.v20250115000107 --save-exact
@clerk/remix
npm i @clerk/remix@4.4.10-snapshot.v20250115000107 --save-exact
@clerk/tanstack-start
npm i @clerk/tanstack-start@0.8.9-snapshot.v20250115000107 --save-exact
@clerk/testing
npm i @clerk/testing@1.4.8-snapshot.v20250115000107 --save-exact
@clerk/vue
npm i @clerk/vue@1.0.3-snapshot.v20250115000107 --save-exact
@wobsorianowobsoriano
changed the title
fix(tanstack-start): Improve environment variable resolution for runtime contextfix(tanstack-start): Fix environment variable resolution for runtime contextJan 15, 2025
@wobsorianowobsoriano
changed the title
fix(tanstack-start): Fix environment variable resolution for runtime contextfix(tanstack-start): Fix environment variable loading in runtime contextsJan 15, 2025
wobsoriano
wobsoriano
reviewed
Jan 15, 2025
View reviewed changes
Comment threadpackages/tanstack-start/src/utils/env.ts

Comment on lines

+16
 to 
+20

 // Cloudflare context check
 const cfValue = event?.context?.cloudflare?.env[name];
 if (cfValue) {
 return cfValue;
 }
@wobsorianowobsorianoJan 15, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitro injects the runtime env vars to the H3 event context. For Cloudflare, the property is event.context.cloudflare.
We pass this event object in a request lifecycle to make runtime env vars available
I answered the same question here.
@wobsoriano
wobsoriano
marked this pull request as ready for review
January 15, 2025 00:53
@wobsorianowobsoriano
mentioned this pull request
Jan 15, 2025

Closed

4 tasks
@wobsoriano
wobsoriano
merged commit bd5f050
into
mainJan 15, 2025
@wobsoriano
wobsoriano
deleted the

vaggelis/eco-274-env-loading-issue-in-tanstack-start

branch
January 15, 2025 15:30
@clerk-cookieclerk-cookie
mentioned this pull request
Jan 15, 2025
 Merged

@wobsorianowobsoriano
mentioned this pull request
Jan 21, 2025

Closed

4 tasks
wobsoriano added a commit
that referenced
this pull request
Feb 8, 2025
@octoper@wobsoriano
fix(tanstack-start): Fix environment variable loading in runtime cont…
3f7a4d7
…exts (#4743)
Co-authored-by: Robert Soriano <sorianorobertc@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano left review comments
@anagstefanagstefAwaiting requested review from anagstef
@panteliselefpanteliselefAwaiting requested review from panteliselef

+1 more reviewer

@LekoArtsLekoArtsLekoArts approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

tanstack

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@octoper@clerk-cookie@wobsoriano@LekoArts

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(tanstack-start): Fix environment variable loading in runtime contexts by octoper · Pull Request #4743 · clerk/javascript · GitHub
Skip to content
fix(tanstack-start): Fix environment variable loading in runtime contexts - #4743
Merged
wobsoriano merged 9 commits into
mainfrom 
vaggelis/eco-274-env-loading-issue-in-tanstack-start
Jan 15, 2025
Merged
fix(tanstack-start): Fix environment variable loading in runtime contexts#4743
wobsoriano merged 9 commits into
mainfrom 
vaggelis/eco-274-env-loading-issue-in-tanstack-start
Conversation
@octoper
@octoperoctoper
commented
Dec 10, 2024•

edited by wobsoriano

Loading

Copy link


Copy Markdown

Contributor
Description
The PR fixes an issue where environment variables are accessed global contexts, which doesn't work in runtimes like Cloudflare that only make them available during the request lifecycle.
Nitro environment variables guideline
Resolves ECO-288 and ECO-274
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@changeset-bot
changeset-botBot
commented
Dec 10, 2024•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 6685212
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/tanstack-startPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Dec 10, 2024•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackJan 15, 2025 0:05am
@octoper
octoper
commented
Dec 10, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Dec 10, 2024

Copy link


Copy Markdown

Collaborator
Hey @octoper - the snapshot version command generated the following package versions:
PackageVersion
@clerk/astro2.0.1-snapshot.v20241210001110
@clerk/backend1.20.3-snapshot.v20241210001110
@clerk/chrome-extension2.0.9-snapshot.v20241210001110
@clerk/clerk-js5.40.3-snapshot.v20241210001110
@clerk/elements0.21.4-snapshot.v20241210001110
@clerk/clerk-expo2.4.5-snapshot.v20241210001110
@clerk/expo-passkeys0.0.17-snapshot.v20241210001110
@clerk/express1.3.26-snapshot.v20241210001110
@clerk/fastify2.0.28-snapshot.v20241210001110
@clerk/localizations3.8.2-snapshot.v20241210001110
@clerk/nextjs6.8.3-snapshot.v20241210001110
@clerk/nuxt0.0.13-snapshot.v20241210001110
@clerk/clerk-react5.19.3-snapshot.v20241210001110
@clerk/react-router0.0.2-snapshot.v20241210001110
@clerk/remix4.3.6-snapshot.v20241210001110
@clerk/clerk-sdk-node5.0.77-snapshot.v20241210001110
@clerk/shared2.19.4-snapshot.v20241210001110
@clerk/tanstack-start0.7.0-snapshot.v20241210001110
@clerk/testing1.3.38-snapshot.v20241210001110
@clerk/themes2.1.55-snapshot.v20241210001110
@clerk/types4.39.2-snapshot.v20241210001110
@clerk/ui0.2.4-snapshot.v20241210001110
@clerk/vue0.0.17-snapshot.v20241210001110
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro
npm i @clerk/astro@2.0.1-snapshot.v20241210001110 --save-exact
@clerk/backend
npm i @clerk/backend@1.20.3-snapshot.v20241210001110 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@2.0.9-snapshot.v20241210001110 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.40.3-snapshot.v20241210001110 --save-exact
@clerk/elements
npm i @clerk/elements@0.21.4-snapshot.v20241210001110 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@2.4.5-snapshot.v20241210001110 --save-exact
@clerk/expo-passkeys
npm i @clerk/expo-passkeys@0.0.17-snapshot.v20241210001110 --save-exact
@clerk/express
npm i @clerk/express@1.3.26-snapshot.v20241210001110 --save-exact
@clerk/fastify
npm i @clerk/fastify@2.0.28-snapshot.v20241210001110 --save-exact
@clerk/localizations
npm i @clerk/localizations@3.8.2-snapshot.v20241210001110 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@6.8.3-snapshot.v20241210001110 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@0.0.13-snapshot.v20241210001110 --save-exact
@clerk/clerk-react
npm i @clerk/clerk-react@5.19.3-snapshot.v20241210001110 --save-exact
@clerk/react-router
npm i @clerk/react-router@0.0.2-snapshot.v20241210001110 --save-exact
@clerk/remix
npm i @clerk/remix@4.3.6-snapshot.v20241210001110 --save-exact
@clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@5.0.77-snapshot.v20241210001110 --save-exact
@clerk/shared
npm i @clerk/shared@2.19.4-snapshot.v20241210001110 --save-exact
@clerk/tanstack-start
npm i @clerk/tanstack-start@0.7.0-snapshot.v20241210001110 --save-exact
@clerk/testing
npm i @clerk/testing@1.3.38-snapshot.v20241210001110 --save-exact
@clerk/themes
npm i @clerk/themes@2.1.55-snapshot.v20241210001110 --save-exact
@clerk/types
npm i @clerk/types@4.39.2-snapshot.v20241210001110 --save-exact
@clerk/ui
npm i @clerk/ui@0.2.4-snapshot.v20241210001110 --save-exact
@clerk/vue
npm i @clerk/vue@0.0.17-snapshot.v20241210001110 --save-exact
@clerkclerk
deleted a comment from clerk-cookieJan 14, 2025
@wobsorianowobsoriano
changed the title
fix(tanstack-start): Fix ENV variable loadingfix(tanstack-start): Improve environment variable resolution for runtime contextJan 14, 2025
@wobsoriano
wobsoriano
commented
Jan 15, 2025

Copy link


Copy Markdown

Member
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 15, 2025

Copy link


Copy Markdown

Collaborator
Hey @wobsoriano - the snapshot version command generated the following package versions:
PackageVersion
@clerk/astro2.1.8-snapshot.v20250115000107
@clerk/backend1.22.1-snapshot.v20250115000107
@clerk/chrome-extension2.1.12-snapshot.v20250115000107
@clerk/clerk-js5.44.1-snapshot.v20250115000107
@clerk/clerk-expo2.6.11-snapshot.v20250115000107
@clerk/express1.3.35-snapshot.v20250115000107
@clerk/fastify2.1.8-snapshot.v20250115000107
@clerk/nextjs6.9.11-snapshot.v20250115000107
@clerk/nuxt1.0.4-snapshot.v20250115000107
@clerk/react-router0.1.9-snapshot.v20250115000107
@clerk/remix4.4.10-snapshot.v20250115000107
@clerk/tanstack-start0.8.9-snapshot.v20250115000107
@clerk/testing1.4.8-snapshot.v20250115000107
@clerk/vue1.0.3-snapshot.v20250115000107
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro
npm i @clerk/astro@2.1.8-snapshot.v20250115000107 --save-exact
@clerk/backend
npm i @clerk/backend@1.22.1-snapshot.v20250115000107 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@2.1.12-snapshot.v20250115000107 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.44.1-snapshot.v20250115000107 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@2.6.11-snapshot.v20250115000107 --save-exact
@clerk/express
npm i @clerk/express@1.3.35-snapshot.v20250115000107 --save-exact
@clerk/fastify
npm i @clerk/fastify@2.1.8-snapshot.v20250115000107 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@6.9.11-snapshot.v20250115000107 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@1.0.4-snapshot.v20250115000107 --save-exact
@clerk/react-router
npm i @clerk/react-router@0.1.9-snapshot.v20250115000107 --save-exact
@clerk/remix
npm i @clerk/remix@4.4.10-snapshot.v20250115000107 --save-exact
@clerk/tanstack-start
npm i @clerk/tanstack-start@0.8.9-snapshot.v20250115000107 --save-exact
@clerk/testing
npm i @clerk/testing@1.4.8-snapshot.v20250115000107 --save-exact
@clerk/vue
npm i @clerk/vue@1.0.3-snapshot.v20250115000107 --save-exact
@wobsorianowobsoriano
changed the title
fix(tanstack-start): Improve environment variable resolution for runtime contextfix(tanstack-start): Fix environment variable resolution for runtime contextJan 15, 2025
@wobsorianowobsoriano
changed the title
fix(tanstack-start): Fix environment variable resolution for runtime contextfix(tanstack-start): Fix environment variable loading in runtime contextsJan 15, 2025
wobsoriano
wobsoriano
reviewed
Jan 15, 2025
View reviewed changes
Comment threadpackages/tanstack-start/src/utils/env.ts

Comment on lines

+16
 to 
+20

 // Cloudflare context check
 const cfValue = event?.context?.cloudflare?.env[name];
 if (cfValue) {
 return cfValue;
 }
@wobsorianowobsorianoJan 15, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitro injects the runtime env vars to the H3 event context. For Cloudflare, the property is event.context.cloudflare.
We pass this event object in a request lifecycle to make runtime env vars available
I answered the same question here.
@wobsoriano
wobsoriano
marked this pull request as ready for review
January 15, 2025 00:53
@wobsorianowobsoriano
mentioned this pull request
Jan 15, 2025

Closed

4 tasks
@wobsoriano
wobsoriano
merged commit bd5f050
into
mainJan 15, 2025
@wobsoriano
wobsoriano
deleted the

vaggelis/eco-274-env-loading-issue-in-tanstack-start

branch
January 15, 2025 15:30
@clerk-cookieclerk-cookie
mentioned this pull request
Jan 15, 2025
 Merged

@wobsorianowobsoriano
mentioned this pull request
Jan 21, 2025

Closed

4 tasks
wobsoriano added a commit
that referenced
this pull request
Feb 8, 2025
@octoper@wobsoriano
fix(tanstack-start): Fix environment variable loading in runtime cont…
3f7a4d7
…exts (#4743)
Co-authored-by: Robert Soriano <sorianorobertc@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano left review comments
@anagstefanagstefAwaiting requested review from anagstef
@panteliselefpanteliselefAwaiting requested review from panteliselef

+1 more reviewer

@LekoArtsLekoArtsLekoArts approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

tanstack

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@octoper@clerk-cookie@wobsoriano@LekoArts

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(tanstack-start): Fix environment variable loading in runtime contexts by octoper · Pull Request #4743 · clerk/javascript · GitHub
Skip to content
fix(tanstack-start): Fix environment variable loading in runtime contexts - #4743
Merged
wobsoriano merged 9 commits into
mainfrom 
vaggelis/eco-274-env-loading-issue-in-tanstack-start
Jan 15, 2025
Merged
fix(tanstack-start): Fix environment variable loading in runtime contexts#4743
wobsoriano merged 9 commits into
mainfrom 
vaggelis/eco-274-env-loading-issue-in-tanstack-start
Conversation
@octoper
@octoperoctoper
commented
Dec 10, 2024•

edited by wobsoriano

Loading

Copy link


Copy Markdown

Contributor
Description
The PR fixes an issue where environment variables are accessed global contexts, which doesn't work in runtimes like Cloudflare that only make them available during the request lifecycle.
Nitro environment variables guideline
Resolves ECO-288 and ECO-274
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@changeset-bot
changeset-botBot
commented
Dec 10, 2024•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 6685212
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/tanstack-startPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Dec 10, 2024•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackJan 15, 2025 0:05am
@octoper
octoper
commented
Dec 10, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Dec 10, 2024

Copy link


Copy Markdown

Collaborator
Hey @octoper - the snapshot version command generated the following package versions:
PackageVersion
@clerk/astro2.0.1-snapshot.v20241210001110
@clerk/backend1.20.3-snapshot.v20241210001110
@clerk/chrome-extension2.0.9-snapshot.v20241210001110
@clerk/clerk-js5.40.3-snapshot.v20241210001110
@clerk/elements0.21.4-snapshot.v20241210001110
@clerk/clerk-expo2.4.5-snapshot.v20241210001110
@clerk/expo-passkeys0.0.17-snapshot.v20241210001110
@clerk/express1.3.26-snapshot.v20241210001110
@clerk/fastify2.0.28-snapshot.v20241210001110
@clerk/localizations3.8.2-snapshot.v20241210001110
@clerk/nextjs6.8.3-snapshot.v20241210001110
@clerk/nuxt0.0.13-snapshot.v20241210001110
@clerk/clerk-react5.19.3-snapshot.v20241210001110
@clerk/react-router0.0.2-snapshot.v20241210001110
@clerk/remix4.3.6-snapshot.v20241210001110
@clerk/clerk-sdk-node5.0.77-snapshot.v20241210001110
@clerk/shared2.19.4-snapshot.v20241210001110
@clerk/tanstack-start0.7.0-snapshot.v20241210001110
@clerk/testing1.3.38-snapshot.v20241210001110
@clerk/themes2.1.55-snapshot.v20241210001110
@clerk/types4.39.2-snapshot.v20241210001110
@clerk/ui0.2.4-snapshot.v20241210001110
@clerk/vue0.0.17-snapshot.v20241210001110
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro
npm i @clerk/astro@2.0.1-snapshot.v20241210001110 --save-exact
@clerk/backend
npm i @clerk/backend@1.20.3-snapshot.v20241210001110 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@2.0.9-snapshot.v20241210001110 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.40.3-snapshot.v20241210001110 --save-exact
@clerk/elements
npm i @clerk/elements@0.21.4-snapshot.v20241210001110 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@2.4.5-snapshot.v20241210001110 --save-exact
@clerk/expo-passkeys
npm i @clerk/expo-passkeys@0.0.17-snapshot.v20241210001110 --save-exact
@clerk/express
npm i @clerk/express@1.3.26-snapshot.v20241210001110 --save-exact
@clerk/fastify
npm i @clerk/fastify@2.0.28-snapshot.v20241210001110 --save-exact
@clerk/localizations
npm i @clerk/localizations@3.8.2-snapshot.v20241210001110 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@6.8.3-snapshot.v20241210001110 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@0.0.13-snapshot.v20241210001110 --save-exact
@clerk/clerk-react
npm i @clerk/clerk-react@5.19.3-snapshot.v20241210001110 --save-exact
@clerk/react-router
npm i @clerk/react-router@0.0.2-snapshot.v20241210001110 --save-exact
@clerk/remix
npm i @clerk/remix@4.3.6-snapshot.v20241210001110 --save-exact
@clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@5.0.77-snapshot.v20241210001110 --save-exact
@clerk/shared
npm i @clerk/shared@2.19.4-snapshot.v20241210001110 --save-exact
@clerk/tanstack-start
npm i @clerk/tanstack-start@0.7.0-snapshot.v20241210001110 --save-exact
@clerk/testing
npm i @clerk/testing@1.3.38-snapshot.v20241210001110 --save-exact
@clerk/themes
npm i @clerk/themes@2.1.55-snapshot.v20241210001110 --save-exact
@clerk/types
npm i @clerk/types@4.39.2-snapshot.v20241210001110 --save-exact
@clerk/ui
npm i @clerk/ui@0.2.4-snapshot.v20241210001110 --save-exact
@clerk/vue
npm i @clerk/vue@0.0.17-snapshot.v20241210001110 --save-exact
@clerkclerk
deleted a comment from clerk-cookieJan 14, 2025
@wobsorianowobsoriano
changed the title
fix(tanstack-start): Fix ENV variable loadingfix(tanstack-start): Improve environment variable resolution for runtime contextJan 14, 2025
@wobsoriano
wobsoriano
commented
Jan 15, 2025

Copy link


Copy Markdown

Member
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 15, 2025

Copy link


Copy Markdown

Collaborator
Hey @wobsoriano - the snapshot version command generated the following package versions:
PackageVersion
@clerk/astro2.1.8-snapshot.v20250115000107
@clerk/backend1.22.1-snapshot.v20250115000107
@clerk/chrome-extension2.1.12-snapshot.v20250115000107
@clerk/clerk-js5.44.1-snapshot.v20250115000107
@clerk/clerk-expo2.6.11-snapshot.v20250115000107
@clerk/express1.3.35-snapshot.v20250115000107
@clerk/fastify2.1.8-snapshot.v20250115000107
@clerk/nextjs6.9.11-snapshot.v20250115000107
@clerk/nuxt1.0.4-snapshot.v20250115000107
@clerk/react-router0.1.9-snapshot.v20250115000107
@clerk/remix4.4.10-snapshot.v20250115000107
@clerk/tanstack-start0.8.9-snapshot.v20250115000107
@clerk/testing1.4.8-snapshot.v20250115000107
@clerk/vue1.0.3-snapshot.v20250115000107
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro
npm i @clerk/astro@2.1.8-snapshot.v20250115000107 --save-exact
@clerk/backend
npm i @clerk/backend@1.22.1-snapshot.v20250115000107 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@2.1.12-snapshot.v20250115000107 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.44.1-snapshot.v20250115000107 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@2.6.11-snapshot.v20250115000107 --save-exact
@clerk/express
npm i @clerk/express@1.3.35-snapshot.v20250115000107 --save-exact
@clerk/fastify
npm i @clerk/fastify@2.1.8-snapshot.v20250115000107 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@6.9.11-snapshot.v20250115000107 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@1.0.4-snapshot.v20250115000107 --save-exact
@clerk/react-router
npm i @clerk/react-router@0.1.9-snapshot.v20250115000107 --save-exact
@clerk/remix
npm i @clerk/remix@4.4.10-snapshot.v20250115000107 --save-exact
@clerk/tanstack-start
npm i @clerk/tanstack-start@0.8.9-snapshot.v20250115000107 --save-exact
@clerk/testing
npm i @clerk/testing@1.4.8-snapshot.v20250115000107 --save-exact
@clerk/vue
npm i @clerk/vue@1.0.3-snapshot.v20250115000107 --save-exact
@wobsorianowobsoriano
changed the title
fix(tanstack-start): Improve environment variable resolution for runtime contextfix(tanstack-start): Fix environment variable resolution for runtime contextJan 15, 2025
@wobsorianowobsoriano
changed the title
fix(tanstack-start): Fix environment variable resolution for runtime contextfix(tanstack-start): Fix environment variable loading in runtime contextsJan 15, 2025
wobsoriano
wobsoriano
reviewed
Jan 15, 2025
View reviewed changes
Comment threadpackages/tanstack-start/src/utils/env.ts

Comment on lines

+16
 to 
+20

 // Cloudflare context check
 const cfValue = event?.context?.cloudflare?.env[name];
 if (cfValue) {
 return cfValue;
 }
@wobsorianowobsorianoJan 15, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitro injects the runtime env vars to the H3 event context. For Cloudflare, the property is event.context.cloudflare.
We pass this event object in a request lifecycle to make runtime env vars available
I answered the same question here.
@wobsoriano
wobsoriano
marked this pull request as ready for review
January 15, 2025 00:53
@wobsorianowobsoriano
mentioned this pull request
Jan 15, 2025

Closed

4 tasks
@wobsoriano
wobsoriano
merged commit bd5f050
into
mainJan 15, 2025
@wobsoriano
wobsoriano
deleted the

vaggelis/eco-274-env-loading-issue-in-tanstack-start

branch
January 15, 2025 15:30
@clerk-cookieclerk-cookie
mentioned this pull request
Jan 15, 2025
 Merged

@wobsorianowobsoriano
mentioned this pull request
Jan 21, 2025

Closed

4 tasks
wobsoriano added a commit
that referenced
this pull request
Feb 8, 2025
@octoper@wobsoriano
fix(tanstack-start): Fix environment variable loading in runtime cont…
3f7a4d7
…exts (#4743)
Co-authored-by: Robert Soriano <sorianorobertc@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano left review comments
@anagstefanagstefAwaiting requested review from anagstef
@panteliselefpanteliselefAwaiting requested review from panteliselef

+1 more reviewer

@LekoArtsLekoArtsLekoArts approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

tanstack

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@octoper@clerk-cookie@wobsoriano@LekoArts

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix(tanstack-start): Fix environment variable loading in runtime contexts by octoper · Pull Request #4743 · clerk/javascript · GitHub
Skip to content
fix(tanstack-start): Fix environment variable loading in runtime contexts - #4743
Merged
wobsoriano merged 9 commits into
mainfrom 
vaggelis/eco-274-env-loading-issue-in-tanstack-start
Jan 15, 2025
Merged
fix(tanstack-start): Fix environment variable loading in runtime contexts#4743
wobsoriano merged 9 commits into
mainfrom 
vaggelis/eco-274-env-loading-issue-in-tanstack-start
Conversation
@octoper
@octoperoctoper
commented
Dec 10, 2024•

edited by wobsoriano

Loading

Copy link


Copy Markdown

Contributor
Description
The PR fixes an issue where environment variables are accessed global contexts, which doesn't work in runtimes like Cloudflare that only make them available during the request lifecycle.
Nitro environment variables guideline
Resolves ECO-288 and ECO-274
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@changeset-bot
changeset-botBot
commented
Dec 10, 2024•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 6685212
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/tanstack-startPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Dec 10, 2024•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackJan 15, 2025 0:05am
@octoper
octoper
commented
Dec 10, 2024

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Dec 10, 2024

Copy link


Copy Markdown

Collaborator
Hey @octoper - the snapshot version command generated the following package versions:
PackageVersion
@clerk/astro2.0.1-snapshot.v20241210001110
@clerk/backend1.20.3-snapshot.v20241210001110
@clerk/chrome-extension2.0.9-snapshot.v20241210001110
@clerk/clerk-js5.40.3-snapshot.v20241210001110
@clerk/elements0.21.4-snapshot.v20241210001110
@clerk/clerk-expo2.4.5-snapshot.v20241210001110
@clerk/expo-passkeys0.0.17-snapshot.v20241210001110
@clerk/express1.3.26-snapshot.v20241210001110
@clerk/fastify2.0.28-snapshot.v20241210001110
@clerk/localizations3.8.2-snapshot.v20241210001110
@clerk/nextjs6.8.3-snapshot.v20241210001110
@clerk/nuxt0.0.13-snapshot.v20241210001110
@clerk/clerk-react5.19.3-snapshot.v20241210001110
@clerk/react-router0.0.2-snapshot.v20241210001110
@clerk/remix4.3.6-snapshot.v20241210001110
@clerk/clerk-sdk-node5.0.77-snapshot.v20241210001110
@clerk/shared2.19.4-snapshot.v20241210001110
@clerk/tanstack-start0.7.0-snapshot.v20241210001110
@clerk/testing1.3.38-snapshot.v20241210001110
@clerk/themes2.1.55-snapshot.v20241210001110
@clerk/types4.39.2-snapshot.v20241210001110
@clerk/ui0.2.4-snapshot.v20241210001110
@clerk/vue0.0.17-snapshot.v20241210001110
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro
npm i @clerk/astro@2.0.1-snapshot.v20241210001110 --save-exact
@clerk/backend
npm i @clerk/backend@1.20.3-snapshot.v20241210001110 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@2.0.9-snapshot.v20241210001110 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.40.3-snapshot.v20241210001110 --save-exact
@clerk/elements
npm i @clerk/elements@0.21.4-snapshot.v20241210001110 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@2.4.5-snapshot.v20241210001110 --save-exact
@clerk/expo-passkeys
npm i @clerk/expo-passkeys@0.0.17-snapshot.v20241210001110 --save-exact
@clerk/express
npm i @clerk/express@1.3.26-snapshot.v20241210001110 --save-exact
@clerk/fastify
npm i @clerk/fastify@2.0.28-snapshot.v20241210001110 --save-exact
@clerk/localizations
npm i @clerk/localizations@3.8.2-snapshot.v20241210001110 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@6.8.3-snapshot.v20241210001110 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@0.0.13-snapshot.v20241210001110 --save-exact
@clerk/clerk-react
npm i @clerk/clerk-react@5.19.3-snapshot.v20241210001110 --save-exact
@clerk/react-router
npm i @clerk/react-router@0.0.2-snapshot.v20241210001110 --save-exact
@clerk/remix
npm i @clerk/remix@4.3.6-snapshot.v20241210001110 --save-exact
@clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@5.0.77-snapshot.v20241210001110 --save-exact
@clerk/shared
npm i @clerk/shared@2.19.4-snapshot.v20241210001110 --save-exact
@clerk/tanstack-start
npm i @clerk/tanstack-start@0.7.0-snapshot.v20241210001110 --save-exact
@clerk/testing
npm i @clerk/testing@1.3.38-snapshot.v20241210001110 --save-exact
@clerk/themes
npm i @clerk/themes@2.1.55-snapshot.v20241210001110 --save-exact
@clerk/types
npm i @clerk/types@4.39.2-snapshot.v20241210001110 --save-exact
@clerk/ui
npm i @clerk/ui@0.2.4-snapshot.v20241210001110 --save-exact
@clerk/vue
npm i @clerk/vue@0.0.17-snapshot.v20241210001110 --save-exact
@clerkclerk
deleted a comment from clerk-cookieJan 14, 2025
@wobsorianowobsoriano
changed the title
fix(tanstack-start): Fix ENV variable loadingfix(tanstack-start): Improve environment variable resolution for runtime contextJan 14, 2025
@wobsoriano
wobsoriano
commented
Jan 15, 2025

Copy link


Copy Markdown

Member
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 15, 2025

Copy link


Copy Markdown

Collaborator
Hey @wobsoriano - the snapshot version command generated the following package versions:
PackageVersion
@clerk/astro2.1.8-snapshot.v20250115000107
@clerk/backend1.22.1-snapshot.v20250115000107
@clerk/chrome-extension2.1.12-snapshot.v20250115000107
@clerk/clerk-js5.44.1-snapshot.v20250115000107
@clerk/clerk-expo2.6.11-snapshot.v20250115000107
@clerk/express1.3.35-snapshot.v20250115000107
@clerk/fastify2.1.8-snapshot.v20250115000107
@clerk/nextjs6.9.11-snapshot.v20250115000107
@clerk/nuxt1.0.4-snapshot.v20250115000107
@clerk/react-router0.1.9-snapshot.v20250115000107
@clerk/remix4.4.10-snapshot.v20250115000107
@clerk/tanstack-start0.8.9-snapshot.v20250115000107
@clerk/testing1.4.8-snapshot.v20250115000107
@clerk/vue1.0.3-snapshot.v20250115000107
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro
npm i @clerk/astro@2.1.8-snapshot.v20250115000107 --save-exact
@clerk/backend
npm i @clerk/backend@1.22.1-snapshot.v20250115000107 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@2.1.12-snapshot.v20250115000107 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.44.1-snapshot.v20250115000107 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@2.6.11-snapshot.v20250115000107 --save-exact
@clerk/express
npm i @clerk/express@1.3.35-snapshot.v20250115000107 --save-exact
@clerk/fastify
npm i @clerk/fastify@2.1.8-snapshot.v20250115000107 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@6.9.11-snapshot.v20250115000107 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@1.0.4-snapshot.v20250115000107 --save-exact
@clerk/react-router
npm i @clerk/react-router@0.1.9-snapshot.v20250115000107 --save-exact
@clerk/remix
npm i @clerk/remix@4.4.10-snapshot.v20250115000107 --save-exact
@clerk/tanstack-start
npm i @clerk/tanstack-start@0.8.9-snapshot.v20250115000107 --save-exact
@clerk/testing
npm i @clerk/testing@1.4.8-snapshot.v20250115000107 --save-exact
@clerk/vue
npm i @clerk/vue@1.0.3-snapshot.v20250115000107 --save-exact
@wobsorianowobsoriano
changed the title
fix(tanstack-start): Improve environment variable resolution for runtime contextfix(tanstack-start): Fix environment variable resolution for runtime contextJan 15, 2025
@wobsorianowobsoriano
changed the title
fix(tanstack-start): Fix environment variable resolution for runtime contextfix(tanstack-start): Fix environment variable loading in runtime contextsJan 15, 2025
wobsoriano
wobsoriano
reviewed
Jan 15, 2025
View reviewed changes
Comment threadpackages/tanstack-start/src/utils/env.ts

Comment on lines

+16
 to 
+20

 // Cloudflare context check
 const cfValue = event?.context?.cloudflare?.env[name];
 if (cfValue) {
 return cfValue;
 }
@wobsorianowobsorianoJan 15, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitro injects the runtime env vars to the H3 event context. For Cloudflare, the property is event.context.cloudflare.
We pass this event object in a request lifecycle to make runtime env vars available
I answered the same question here.
@wobsoriano
wobsoriano
marked this pull request as ready for review
January 15, 2025 00:53
@wobsorianowobsoriano
mentioned this pull request
Jan 15, 2025

Closed

4 tasks
@wobsoriano
wobsoriano
merged commit bd5f050
into
mainJan 15, 2025
@wobsoriano
wobsoriano
deleted the

vaggelis/eco-274-env-loading-issue-in-tanstack-start

branch
January 15, 2025 15:30
@clerk-cookieclerk-cookie
mentioned this pull request
Jan 15, 2025
 Merged

@wobsorianowobsoriano
mentioned this pull request
Jan 21, 2025

Closed

4 tasks
wobsoriano added a commit
that referenced
this pull request
Feb 8, 2025
@octoper@wobsoriano
fix(tanstack-start): Fix environment variable loading in runtime cont…
3f7a4d7
…exts (#4743)
Co-authored-by: Robert Soriano <sorianorobertc@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano left review comments
@anagstefanagstefAwaiting requested review from anagstef
@panteliselefpanteliselefAwaiting requested review from panteliselef

+1 more reviewer

@LekoArtsLekoArtsLekoArts approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

tanstack

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@octoper@clerk-cookie@wobsoriano@LekoArts