Skip to content

fix(chrome-extension): Bundle @clerk/shared to properly tree-shake - #4899

Merged
LekoArts merged 1 commit into
mainfrom
lekoarts/eco-300-chrome-web-store-rejection-mv3-remote-code-loading-issue
Jan 15, 2025
Merged

fix(chrome-extension): Bundle @clerk/shared to properly tree-shake#4899
LekoArts merged 1 commit into
mainfrom
lekoarts/eco-300-chrome-web-store-rejection-mv3-remote-code-loading-issue

Conversation

@LekoArts

@LekoArtsLekoArts commented Jan 15, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

If you look at https://unpkg.com/browse/@clerk/chrome-extension@2.1.11/dist/esm/index.js you'll see that we end up with:

import{setErrorThrowerOptions}from'./chunk-BGR6KYCZ.js';export{ ... }from'./chunk-BGR6KYCZ.js';import'./chunk-V7OWHRAI.js';import'@clerk/shared/loadClerkJsScript';setErrorThrowerOptions({packageName: "@clerk/chrome-extension"});

The unused import '@clerk/shared/loadClerkJsScript'; is problematic because inside is "remotely hosted code" that the Chrome extension store is flagging. In #4551 build flags were added and they work. But the unused imports are not removed during bundling.

So the fix is to also mark @clerk/sharednot external and bundle it. Then tsup seems to be able to remove those unused imports.

Fixes#4886

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented Jan 15, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8c6f91f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/chrome-extensionPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jan 15, 2025•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackJan 15, 2025 0:03am

@LekoArts

LekoArts commented Jan 15, 2025

Copy link
Copy Markdown
ContributorAuthor

!snapshot

@clerk-cookie

clerk-cookie commented Jan 15, 2025

Copy link
Copy Markdown
Collaborator

Hey @LekoArts - the snapshot version command generated the following package versions:

PackageVersion
@clerk/astro2.1.8-snapshot.v20250115120857
@clerk/backend1.22.1-snapshot.v20250115120857
@clerk/chrome-extension2.1.12-snapshot.v20250115120857
@clerk/clerk-js5.44.1-snapshot.v20250115120857
@clerk/clerk-expo2.6.11-snapshot.v20250115120857
@clerk/express1.3.35-snapshot.v20250115120857
@clerk/fastify2.1.8-snapshot.v20250115120857
@clerk/nextjs6.9.11-snapshot.v20250115120857
@clerk/nuxt1.0.4-snapshot.v20250115120857
@clerk/react-router0.1.9-snapshot.v20250115120857
@clerk/remix4.4.10-snapshot.v20250115120857
@clerk/tanstack-start0.8.9-snapshot.v20250115120857
@clerk/testing1.4.8-snapshot.v20250115120857
@clerk/vue1.0.3-snapshot.v20250115120857

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/astro@2.1.8-snapshot.v20250115120857 --save-exact

@clerk/backend

npm i @clerk/backend@1.22.1-snapshot.v20250115120857 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@2.1.12-snapshot.v20250115120857 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.44.1-snapshot.v20250115120857 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@2.6.11-snapshot.v20250115120857 --save-exact

@clerk/express

npm i @clerk/express@1.3.35-snapshot.v20250115120857 --save-exact

@clerk/fastify

npm i @clerk/fastify@2.1.8-snapshot.v20250115120857 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@6.9.11-snapshot.v20250115120857 --save-exact

@clerk/nuxt

npm i @clerk/nuxt@1.0.4-snapshot.v20250115120857 --save-exact

@clerk/react-router

npm i @clerk/react-router@0.1.9-snapshot.v20250115120857 --save-exact

@clerk/remix

npm i @clerk/remix@4.4.10-snapshot.v20250115120857 --save-exact

@clerk/tanstack-start

npm i @clerk/tanstack-start@0.8.9-snapshot.v20250115120857 --save-exact

@clerk/testing

npm i @clerk/testing@1.4.8-snapshot.v20250115120857 --save-exact

@clerk/vue

npm i @clerk/vue@1.0.3-snapshot.v20250115120857 --save-exact

@LekoArts
LekoArts marked this pull request as ready for review January 15, 2025 12:17
@LekoArts

LekoArts commented Jan 15, 2025

Copy link
Copy Markdown
ContributorAuthor

Import is gone: https://unpkg.com/browse/@clerk/chrome-extension@2.1.12-snapshot.v20250115120857/dist/esm/index.js

anagstef
anagstef approved these changes Jan 15, 2025
View reviewed changes

@anagstefanagstef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@LekoArts
LekoArts merged commit 3a03836 into mainJan 15, 2025
@LekoArts
LekoArts deleted the lekoarts/eco-300-chrome-web-store-rejection-mv3-remote-code-loading-issue branch January 15, 2025 13:25
@clerk-cookieclerk-cookie mentioned this pull request Jan 15, 2025
Merged
jacekradko pushed a commit that referenced this pull request Jan 15, 2025
@LekoArts@jacekradko
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake (#…
5c842f8
…4899)
wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
@LekoArts@wobsoriano
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake (#…
fb84acb
…4899)
@devlarabardevlarabar mentioned this pull request Jun 6, 2026
Closed
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@anagstefanagstefanagstef approved these changes
@panteliselefpanteliselefpanteliselef approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chrome-extension

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Chrome Web Store Rejection - MV3 Remote Code Loading Issue

4 participants

@LekoArts@clerk-cookie@anagstef@panteliselef
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake by LekoArts · Pull Request #4899 · clerk/javascript · GitHub
Skip to content
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake - #4899
Merged
LekoArts merged 1 commit into
mainfrom 
lekoarts/eco-300-chrome-web-store-rejection-mv3-remote-code-loading-issue
Jan 15, 2025
Merged
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake#4899
LekoArts merged 1 commit into
mainfrom 
lekoarts/eco-300-chrome-web-store-rejection-mv3-remote-code-loading-issue
Conversation
@LekoArts
@LekoArtsLekoArts
commented
Jan 15, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
If you look at https://unpkg.com/browse/@clerk/chrome-extension@2.1.11/dist/esm/index.js you'll see that we end up with:
import{setErrorThrowerOptions}from'./chunk-BGR6KYCZ.js';export{ ... }from'./chunk-BGR6KYCZ.js';import'./chunk-V7OWHRAI.js';import'@clerk/shared/loadClerkJsScript';setErrorThrowerOptions({packageName: "@clerk/chrome-extension"});
The unused import '@clerk/shared/loadClerkJsScript'; is problematic because inside is "remotely hosted code" that the Chrome extension store is flagging. In #4551 build flags were added and they work. But the unused imports are not removed during bundling.
So the fix is to also mark @clerk/sharednot external and bundle it. Then tsup seems to be able to remove those unused imports.
Fixes#4886
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@changeset-bot
changeset-botBot
commented
Jan 15, 2025

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 8c6f91f
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/chrome-extensionPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jan 15, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackJan 15, 2025 0:03am
@LekoArts
LekoArts
commented
Jan 15, 2025

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 15, 2025

Copy link


Copy Markdown

Collaborator
Hey @LekoArts - the snapshot version command generated the following package versions:
PackageVersion
@clerk/astro2.1.8-snapshot.v20250115120857
@clerk/backend1.22.1-snapshot.v20250115120857
@clerk/chrome-extension2.1.12-snapshot.v20250115120857
@clerk/clerk-js5.44.1-snapshot.v20250115120857
@clerk/clerk-expo2.6.11-snapshot.v20250115120857
@clerk/express1.3.35-snapshot.v20250115120857
@clerk/fastify2.1.8-snapshot.v20250115120857
@clerk/nextjs6.9.11-snapshot.v20250115120857
@clerk/nuxt1.0.4-snapshot.v20250115120857
@clerk/react-router0.1.9-snapshot.v20250115120857
@clerk/remix4.4.10-snapshot.v20250115120857
@clerk/tanstack-start0.8.9-snapshot.v20250115120857
@clerk/testing1.4.8-snapshot.v20250115120857
@clerk/vue1.0.3-snapshot.v20250115120857
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro
npm i @clerk/astro@2.1.8-snapshot.v20250115120857 --save-exact
@clerk/backend
npm i @clerk/backend@1.22.1-snapshot.v20250115120857 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@2.1.12-snapshot.v20250115120857 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.44.1-snapshot.v20250115120857 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@2.6.11-snapshot.v20250115120857 --save-exact
@clerk/express
npm i @clerk/express@1.3.35-snapshot.v20250115120857 --save-exact
@clerk/fastify
npm i @clerk/fastify@2.1.8-snapshot.v20250115120857 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@6.9.11-snapshot.v20250115120857 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@1.0.4-snapshot.v20250115120857 --save-exact
@clerk/react-router
npm i @clerk/react-router@0.1.9-snapshot.v20250115120857 --save-exact
@clerk/remix
npm i @clerk/remix@4.4.10-snapshot.v20250115120857 --save-exact
@clerk/tanstack-start
npm i @clerk/tanstack-start@0.8.9-snapshot.v20250115120857 --save-exact
@clerk/testing
npm i @clerk/testing@1.4.8-snapshot.v20250115120857 --save-exact
@clerk/vue
npm i @clerk/vue@1.0.3-snapshot.v20250115120857 --save-exact
@LekoArts
LekoArts
marked this pull request as ready for review
January 15, 2025 12:17
@LekoArts
LekoArts
commented
Jan 15, 2025

Copy link


Copy Markdown

ContributorAuthor
Import is gone: https://unpkg.com/browse/@clerk/chrome-extension@2.1.12-snapshot.v20250115120857/dist/esm/index.js
anagstef
anagstef
approved these changes
Jan 15, 2025
View reviewed changes
@anagstefanagstef
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯
@LekoArts
LekoArts
merged commit 3a03836
into
mainJan 15, 2025
@LekoArts
LekoArts
deleted the

lekoarts/eco-300-chrome-web-store-rejection-mv3-remote-code-loading-issue

branch
January 15, 2025 13:25
@clerk-cookieclerk-cookie
mentioned this pull request
Jan 15, 2025
 Merged

jacekradko pushed a commit
that referenced
this pull request
Jan 15, 2025
@LekoArts@jacekradko
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake (#…
5c842f8
…4899)
wobsoriano pushed a commit
that referenced
this pull request
Feb 8, 2025
@LekoArts@wobsoriano
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake (#…
fb84acb
…4899)
@devlarabardevlarabar
mentioned this pull request
Jun 6, 2026

Closed

4 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@anagstefanagstefanagstef approved these changes
@panteliselefpanteliselefpanteliselef approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

chrome-extension

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Chrome Web Store Rejection - MV3 Remote Code Loading Issue


4 participants

@LekoArts@clerk-cookie@anagstef@panteliselef

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake by LekoArts · Pull Request #4899 · clerk/javascript · GitHub
Skip to content
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake - #4899
Merged
LekoArts merged 1 commit into
mainfrom 
lekoarts/eco-300-chrome-web-store-rejection-mv3-remote-code-loading-issue
Jan 15, 2025
Merged
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake#4899
LekoArts merged 1 commit into
mainfrom 
lekoarts/eco-300-chrome-web-store-rejection-mv3-remote-code-loading-issue
Conversation
@LekoArts
@LekoArtsLekoArts
commented
Jan 15, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
If you look at https://unpkg.com/browse/@clerk/chrome-extension@2.1.11/dist/esm/index.js you'll see that we end up with:
import{setErrorThrowerOptions}from'./chunk-BGR6KYCZ.js';export{ ... }from'./chunk-BGR6KYCZ.js';import'./chunk-V7OWHRAI.js';import'@clerk/shared/loadClerkJsScript';setErrorThrowerOptions({packageName: "@clerk/chrome-extension"});
The unused import '@clerk/shared/loadClerkJsScript'; is problematic because inside is "remotely hosted code" that the Chrome extension store is flagging. In #4551 build flags were added and they work. But the unused imports are not removed during bundling.
So the fix is to also mark @clerk/sharednot external and bundle it. Then tsup seems to be able to remove those unused imports.
Fixes#4886
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@changeset-bot
changeset-botBot
commented
Jan 15, 2025

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 8c6f91f
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/chrome-extensionPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jan 15, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackJan 15, 2025 0:03am
@LekoArts
LekoArts
commented
Jan 15, 2025

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 15, 2025

Copy link


Copy Markdown

Collaborator
Hey @LekoArts - the snapshot version command generated the following package versions:
PackageVersion
@clerk/astro2.1.8-snapshot.v20250115120857
@clerk/backend1.22.1-snapshot.v20250115120857
@clerk/chrome-extension2.1.12-snapshot.v20250115120857
@clerk/clerk-js5.44.1-snapshot.v20250115120857
@clerk/clerk-expo2.6.11-snapshot.v20250115120857
@clerk/express1.3.35-snapshot.v20250115120857
@clerk/fastify2.1.8-snapshot.v20250115120857
@clerk/nextjs6.9.11-snapshot.v20250115120857
@clerk/nuxt1.0.4-snapshot.v20250115120857
@clerk/react-router0.1.9-snapshot.v20250115120857
@clerk/remix4.4.10-snapshot.v20250115120857
@clerk/tanstack-start0.8.9-snapshot.v20250115120857
@clerk/testing1.4.8-snapshot.v20250115120857
@clerk/vue1.0.3-snapshot.v20250115120857
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro
npm i @clerk/astro@2.1.8-snapshot.v20250115120857 --save-exact
@clerk/backend
npm i @clerk/backend@1.22.1-snapshot.v20250115120857 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@2.1.12-snapshot.v20250115120857 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.44.1-snapshot.v20250115120857 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@2.6.11-snapshot.v20250115120857 --save-exact
@clerk/express
npm i @clerk/express@1.3.35-snapshot.v20250115120857 --save-exact
@clerk/fastify
npm i @clerk/fastify@2.1.8-snapshot.v20250115120857 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@6.9.11-snapshot.v20250115120857 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@1.0.4-snapshot.v20250115120857 --save-exact
@clerk/react-router
npm i @clerk/react-router@0.1.9-snapshot.v20250115120857 --save-exact
@clerk/remix
npm i @clerk/remix@4.4.10-snapshot.v20250115120857 --save-exact
@clerk/tanstack-start
npm i @clerk/tanstack-start@0.8.9-snapshot.v20250115120857 --save-exact
@clerk/testing
npm i @clerk/testing@1.4.8-snapshot.v20250115120857 --save-exact
@clerk/vue
npm i @clerk/vue@1.0.3-snapshot.v20250115120857 --save-exact
@LekoArts
LekoArts
marked this pull request as ready for review
January 15, 2025 12:17
@LekoArts
LekoArts
commented
Jan 15, 2025

Copy link


Copy Markdown

ContributorAuthor
Import is gone: https://unpkg.com/browse/@clerk/chrome-extension@2.1.12-snapshot.v20250115120857/dist/esm/index.js
anagstef
anagstef
approved these changes
Jan 15, 2025
View reviewed changes
@anagstefanagstef
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯
@LekoArts
LekoArts
merged commit 3a03836
into
mainJan 15, 2025
@LekoArts
LekoArts
deleted the

lekoarts/eco-300-chrome-web-store-rejection-mv3-remote-code-loading-issue

branch
January 15, 2025 13:25
@clerk-cookieclerk-cookie
mentioned this pull request
Jan 15, 2025
 Merged

jacekradko pushed a commit
that referenced
this pull request
Jan 15, 2025
@LekoArts@jacekradko
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake (#…
5c842f8
…4899)
wobsoriano pushed a commit
that referenced
this pull request
Feb 8, 2025
@LekoArts@wobsoriano
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake (#…
fb84acb
…4899)
@devlarabardevlarabar
mentioned this pull request
Jun 6, 2026

Closed

4 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@anagstefanagstefanagstef approved these changes
@panteliselefpanteliselefpanteliselef approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

chrome-extension

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Chrome Web Store Rejection - MV3 Remote Code Loading Issue


4 participants

@LekoArts@clerk-cookie@anagstef@panteliselef

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake by LekoArts · Pull Request #4899 · clerk/javascript · GitHub
Skip to content
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake - #4899
Merged
LekoArts merged 1 commit into
mainfrom 
lekoarts/eco-300-chrome-web-store-rejection-mv3-remote-code-loading-issue
Jan 15, 2025
Merged
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake#4899
LekoArts merged 1 commit into
mainfrom 
lekoarts/eco-300-chrome-web-store-rejection-mv3-remote-code-loading-issue
Conversation
@LekoArts
@LekoArtsLekoArts
commented
Jan 15, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
If you look at https://unpkg.com/browse/@clerk/chrome-extension@2.1.11/dist/esm/index.js you'll see that we end up with:
import{setErrorThrowerOptions}from'./chunk-BGR6KYCZ.js';export{ ... }from'./chunk-BGR6KYCZ.js';import'./chunk-V7OWHRAI.js';import'@clerk/shared/loadClerkJsScript';setErrorThrowerOptions({packageName: "@clerk/chrome-extension"});
The unused import '@clerk/shared/loadClerkJsScript'; is problematic because inside is "remotely hosted code" that the Chrome extension store is flagging. In #4551 build flags were added and they work. But the unused imports are not removed during bundling.
So the fix is to also mark @clerk/sharednot external and bundle it. Then tsup seems to be able to remove those unused imports.
Fixes#4886
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@changeset-bot
changeset-botBot
commented
Jan 15, 2025

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 8c6f91f
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/chrome-extensionPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jan 15, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackJan 15, 2025 0:03am
@LekoArts
LekoArts
commented
Jan 15, 2025

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 15, 2025

Copy link


Copy Markdown

Collaborator
Hey @LekoArts - the snapshot version command generated the following package versions:
PackageVersion
@clerk/astro2.1.8-snapshot.v20250115120857
@clerk/backend1.22.1-snapshot.v20250115120857
@clerk/chrome-extension2.1.12-snapshot.v20250115120857
@clerk/clerk-js5.44.1-snapshot.v20250115120857
@clerk/clerk-expo2.6.11-snapshot.v20250115120857
@clerk/express1.3.35-snapshot.v20250115120857
@clerk/fastify2.1.8-snapshot.v20250115120857
@clerk/nextjs6.9.11-snapshot.v20250115120857
@clerk/nuxt1.0.4-snapshot.v20250115120857
@clerk/react-router0.1.9-snapshot.v20250115120857
@clerk/remix4.4.10-snapshot.v20250115120857
@clerk/tanstack-start0.8.9-snapshot.v20250115120857
@clerk/testing1.4.8-snapshot.v20250115120857
@clerk/vue1.0.3-snapshot.v20250115120857
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro
npm i @clerk/astro@2.1.8-snapshot.v20250115120857 --save-exact
@clerk/backend
npm i @clerk/backend@1.22.1-snapshot.v20250115120857 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@2.1.12-snapshot.v20250115120857 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.44.1-snapshot.v20250115120857 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@2.6.11-snapshot.v20250115120857 --save-exact
@clerk/express
npm i @clerk/express@1.3.35-snapshot.v20250115120857 --save-exact
@clerk/fastify
npm i @clerk/fastify@2.1.8-snapshot.v20250115120857 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@6.9.11-snapshot.v20250115120857 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@1.0.4-snapshot.v20250115120857 --save-exact
@clerk/react-router
npm i @clerk/react-router@0.1.9-snapshot.v20250115120857 --save-exact
@clerk/remix
npm i @clerk/remix@4.4.10-snapshot.v20250115120857 --save-exact
@clerk/tanstack-start
npm i @clerk/tanstack-start@0.8.9-snapshot.v20250115120857 --save-exact
@clerk/testing
npm i @clerk/testing@1.4.8-snapshot.v20250115120857 --save-exact
@clerk/vue
npm i @clerk/vue@1.0.3-snapshot.v20250115120857 --save-exact
@LekoArts
LekoArts
marked this pull request as ready for review
January 15, 2025 12:17
@LekoArts
LekoArts
commented
Jan 15, 2025

Copy link


Copy Markdown

ContributorAuthor
Import is gone: https://unpkg.com/browse/@clerk/chrome-extension@2.1.12-snapshot.v20250115120857/dist/esm/index.js
anagstef
anagstef
approved these changes
Jan 15, 2025
View reviewed changes
@anagstefanagstef
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯
@LekoArts
LekoArts
merged commit 3a03836
into
mainJan 15, 2025
@LekoArts
LekoArts
deleted the

lekoarts/eco-300-chrome-web-store-rejection-mv3-remote-code-loading-issue

branch
January 15, 2025 13:25
@clerk-cookieclerk-cookie
mentioned this pull request
Jan 15, 2025
 Merged

jacekradko pushed a commit
that referenced
this pull request
Jan 15, 2025
@LekoArts@jacekradko
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake (#…
5c842f8
…4899)
wobsoriano pushed a commit
that referenced
this pull request
Feb 8, 2025
@LekoArts@wobsoriano
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake (#…
fb84acb
…4899)
@devlarabardevlarabar
mentioned this pull request
Jun 6, 2026

Closed

4 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@anagstefanagstefanagstef approved these changes
@panteliselefpanteliselefpanteliselef approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

chrome-extension

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Chrome Web Store Rejection - MV3 Remote Code Loading Issue


4 participants

@LekoArts@clerk-cookie@anagstef@panteliselef

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake by LekoArts · Pull Request #4899 · clerk/javascript · GitHub
Skip to content
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake - #4899
Merged
LekoArts merged 1 commit into
mainfrom 
lekoarts/eco-300-chrome-web-store-rejection-mv3-remote-code-loading-issue
Jan 15, 2025
Merged
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake#4899
LekoArts merged 1 commit into
mainfrom 
lekoarts/eco-300-chrome-web-store-rejection-mv3-remote-code-loading-issue
Conversation
@LekoArts
@LekoArtsLekoArts
commented
Jan 15, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
If you look at https://unpkg.com/browse/@clerk/chrome-extension@2.1.11/dist/esm/index.js you'll see that we end up with:
import{setErrorThrowerOptions}from'./chunk-BGR6KYCZ.js';export{ ... }from'./chunk-BGR6KYCZ.js';import'./chunk-V7OWHRAI.js';import'@clerk/shared/loadClerkJsScript';setErrorThrowerOptions({packageName: "@clerk/chrome-extension"});
The unused import '@clerk/shared/loadClerkJsScript'; is problematic because inside is "remotely hosted code" that the Chrome extension store is flagging. In #4551 build flags were added and they work. But the unused imports are not removed during bundling.
So the fix is to also mark @clerk/sharednot external and bundle it. Then tsup seems to be able to remove those unused imports.
Fixes#4886
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@changeset-bot
changeset-botBot
commented
Jan 15, 2025

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 8c6f91f
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/chrome-extensionPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jan 15, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackJan 15, 2025 0:03am
@LekoArts
LekoArts
commented
Jan 15, 2025

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 15, 2025

Copy link


Copy Markdown

Collaborator
Hey @LekoArts - the snapshot version command generated the following package versions:
PackageVersion
@clerk/astro2.1.8-snapshot.v20250115120857
@clerk/backend1.22.1-snapshot.v20250115120857
@clerk/chrome-extension2.1.12-snapshot.v20250115120857
@clerk/clerk-js5.44.1-snapshot.v20250115120857
@clerk/clerk-expo2.6.11-snapshot.v20250115120857
@clerk/express1.3.35-snapshot.v20250115120857
@clerk/fastify2.1.8-snapshot.v20250115120857
@clerk/nextjs6.9.11-snapshot.v20250115120857
@clerk/nuxt1.0.4-snapshot.v20250115120857
@clerk/react-router0.1.9-snapshot.v20250115120857
@clerk/remix4.4.10-snapshot.v20250115120857
@clerk/tanstack-start0.8.9-snapshot.v20250115120857
@clerk/testing1.4.8-snapshot.v20250115120857
@clerk/vue1.0.3-snapshot.v20250115120857
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro
npm i @clerk/astro@2.1.8-snapshot.v20250115120857 --save-exact
@clerk/backend
npm i @clerk/backend@1.22.1-snapshot.v20250115120857 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@2.1.12-snapshot.v20250115120857 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.44.1-snapshot.v20250115120857 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@2.6.11-snapshot.v20250115120857 --save-exact
@clerk/express
npm i @clerk/express@1.3.35-snapshot.v20250115120857 --save-exact
@clerk/fastify
npm i @clerk/fastify@2.1.8-snapshot.v20250115120857 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@6.9.11-snapshot.v20250115120857 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@1.0.4-snapshot.v20250115120857 --save-exact
@clerk/react-router
npm i @clerk/react-router@0.1.9-snapshot.v20250115120857 --save-exact
@clerk/remix
npm i @clerk/remix@4.4.10-snapshot.v20250115120857 --save-exact
@clerk/tanstack-start
npm i @clerk/tanstack-start@0.8.9-snapshot.v20250115120857 --save-exact
@clerk/testing
npm i @clerk/testing@1.4.8-snapshot.v20250115120857 --save-exact
@clerk/vue
npm i @clerk/vue@1.0.3-snapshot.v20250115120857 --save-exact
@LekoArts
LekoArts
marked this pull request as ready for review
January 15, 2025 12:17
@LekoArts
LekoArts
commented
Jan 15, 2025

Copy link


Copy Markdown

ContributorAuthor
Import is gone: https://unpkg.com/browse/@clerk/chrome-extension@2.1.12-snapshot.v20250115120857/dist/esm/index.js
anagstef
anagstef
approved these changes
Jan 15, 2025
View reviewed changes
@anagstefanagstef
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯
@LekoArts
LekoArts
merged commit 3a03836
into
mainJan 15, 2025
@LekoArts
LekoArts
deleted the

lekoarts/eco-300-chrome-web-store-rejection-mv3-remote-code-loading-issue

branch
January 15, 2025 13:25
@clerk-cookieclerk-cookie
mentioned this pull request
Jan 15, 2025
 Merged

jacekradko pushed a commit
that referenced
this pull request
Jan 15, 2025
@LekoArts@jacekradko
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake (#…
5c842f8
…4899)
wobsoriano pushed a commit
that referenced
this pull request
Feb 8, 2025
@LekoArts@wobsoriano
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake (#…
fb84acb
…4899)
@devlarabardevlarabar
mentioned this pull request
Jun 6, 2026

Closed

4 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@anagstefanagstefanagstef approved these changes
@panteliselefpanteliselefpanteliselef approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

chrome-extension

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Chrome Web Store Rejection - MV3 Remote Code Loading Issue


4 participants

@LekoArts@clerk-cookie@anagstef@panteliselef

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake by LekoArts · Pull Request #4899 · clerk/javascript · GitHub
Skip to content
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake - #4899
Merged
LekoArts merged 1 commit into
mainfrom 
lekoarts/eco-300-chrome-web-store-rejection-mv3-remote-code-loading-issue
Jan 15, 2025
Merged
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake#4899
LekoArts merged 1 commit into
mainfrom 
lekoarts/eco-300-chrome-web-store-rejection-mv3-remote-code-loading-issue
Conversation
@LekoArts
@LekoArtsLekoArts
commented
Jan 15, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
If you look at https://unpkg.com/browse/@clerk/chrome-extension@2.1.11/dist/esm/index.js you'll see that we end up with:
import{setErrorThrowerOptions}from'./chunk-BGR6KYCZ.js';export{ ... }from'./chunk-BGR6KYCZ.js';import'./chunk-V7OWHRAI.js';import'@clerk/shared/loadClerkJsScript';setErrorThrowerOptions({packageName: "@clerk/chrome-extension"});
The unused import '@clerk/shared/loadClerkJsScript'; is problematic because inside is "remotely hosted code" that the Chrome extension store is flagging. In #4551 build flags were added and they work. But the unused imports are not removed during bundling.
So the fix is to also mark @clerk/sharednot external and bundle it. Then tsup seems to be able to remove those unused imports.
Fixes#4886
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@changeset-bot
changeset-botBot
commented
Jan 15, 2025

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 8c6f91f
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/chrome-extensionPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jan 15, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackJan 15, 2025 0:03am
@LekoArts
LekoArts
commented
Jan 15, 2025

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 15, 2025

Copy link


Copy Markdown

Collaborator
Hey @LekoArts - the snapshot version command generated the following package versions:
PackageVersion
@clerk/astro2.1.8-snapshot.v20250115120857
@clerk/backend1.22.1-snapshot.v20250115120857
@clerk/chrome-extension2.1.12-snapshot.v20250115120857
@clerk/clerk-js5.44.1-snapshot.v20250115120857
@clerk/clerk-expo2.6.11-snapshot.v20250115120857
@clerk/express1.3.35-snapshot.v20250115120857
@clerk/fastify2.1.8-snapshot.v20250115120857
@clerk/nextjs6.9.11-snapshot.v20250115120857
@clerk/nuxt1.0.4-snapshot.v20250115120857
@clerk/react-router0.1.9-snapshot.v20250115120857
@clerk/remix4.4.10-snapshot.v20250115120857
@clerk/tanstack-start0.8.9-snapshot.v20250115120857
@clerk/testing1.4.8-snapshot.v20250115120857
@clerk/vue1.0.3-snapshot.v20250115120857
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro
npm i @clerk/astro@2.1.8-snapshot.v20250115120857 --save-exact
@clerk/backend
npm i @clerk/backend@1.22.1-snapshot.v20250115120857 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@2.1.12-snapshot.v20250115120857 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.44.1-snapshot.v20250115120857 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@2.6.11-snapshot.v20250115120857 --save-exact
@clerk/express
npm i @clerk/express@1.3.35-snapshot.v20250115120857 --save-exact
@clerk/fastify
npm i @clerk/fastify@2.1.8-snapshot.v20250115120857 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@6.9.11-snapshot.v20250115120857 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@1.0.4-snapshot.v20250115120857 --save-exact
@clerk/react-router
npm i @clerk/react-router@0.1.9-snapshot.v20250115120857 --save-exact
@clerk/remix
npm i @clerk/remix@4.4.10-snapshot.v20250115120857 --save-exact
@clerk/tanstack-start
npm i @clerk/tanstack-start@0.8.9-snapshot.v20250115120857 --save-exact
@clerk/testing
npm i @clerk/testing@1.4.8-snapshot.v20250115120857 --save-exact
@clerk/vue
npm i @clerk/vue@1.0.3-snapshot.v20250115120857 --save-exact
@LekoArts
LekoArts
marked this pull request as ready for review
January 15, 2025 12:17
@LekoArts
LekoArts
commented
Jan 15, 2025

Copy link


Copy Markdown

ContributorAuthor
Import is gone: https://unpkg.com/browse/@clerk/chrome-extension@2.1.12-snapshot.v20250115120857/dist/esm/index.js
anagstef
anagstef
approved these changes
Jan 15, 2025
View reviewed changes
@anagstefanagstef
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯
@LekoArts
LekoArts
merged commit 3a03836
into
mainJan 15, 2025
@LekoArts
LekoArts
deleted the

lekoarts/eco-300-chrome-web-store-rejection-mv3-remote-code-loading-issue

branch
January 15, 2025 13:25
@clerk-cookieclerk-cookie
mentioned this pull request
Jan 15, 2025
 Merged

jacekradko pushed a commit
that referenced
this pull request
Jan 15, 2025
@LekoArts@jacekradko
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake (#…
5c842f8
…4899)
wobsoriano pushed a commit
that referenced
this pull request
Feb 8, 2025
@LekoArts@wobsoriano
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake (#…
fb84acb
…4899)
@devlarabardevlarabar
mentioned this pull request
Jun 6, 2026

Closed

4 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@anagstefanagstefanagstef approved these changes
@panteliselefpanteliselefpanteliselef approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

chrome-extension

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Chrome Web Store Rejection - MV3 Remote Code Loading Issue


4 participants

@LekoArts@clerk-cookie@anagstef@panteliselef

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake by LekoArts · Pull Request #4899 · clerk/javascript · GitHub
Skip to content
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake - #4899
Merged
LekoArts merged 1 commit into
mainfrom 
lekoarts/eco-300-chrome-web-store-rejection-mv3-remote-code-loading-issue
Jan 15, 2025
Merged
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake#4899
LekoArts merged 1 commit into
mainfrom 
lekoarts/eco-300-chrome-web-store-rejection-mv3-remote-code-loading-issue
Conversation
@LekoArts
@LekoArtsLekoArts
commented
Jan 15, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
If you look at https://unpkg.com/browse/@clerk/chrome-extension@2.1.11/dist/esm/index.js you'll see that we end up with:
import{setErrorThrowerOptions}from'./chunk-BGR6KYCZ.js';export{ ... }from'./chunk-BGR6KYCZ.js';import'./chunk-V7OWHRAI.js';import'@clerk/shared/loadClerkJsScript';setErrorThrowerOptions({packageName: "@clerk/chrome-extension"});
The unused import '@clerk/shared/loadClerkJsScript'; is problematic because inside is "remotely hosted code" that the Chrome extension store is flagging. In #4551 build flags were added and they work. But the unused imports are not removed during bundling.
So the fix is to also mark @clerk/sharednot external and bundle it. Then tsup seems to be able to remove those unused imports.
Fixes#4886
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@changeset-bot
changeset-botBot
commented
Jan 15, 2025

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 8c6f91f
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/chrome-extensionPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jan 15, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackJan 15, 2025 0:03am
@LekoArts
LekoArts
commented
Jan 15, 2025

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
Jan 15, 2025

Copy link


Copy Markdown

Collaborator
Hey @LekoArts - the snapshot version command generated the following package versions:
PackageVersion
@clerk/astro2.1.8-snapshot.v20250115120857
@clerk/backend1.22.1-snapshot.v20250115120857
@clerk/chrome-extension2.1.12-snapshot.v20250115120857
@clerk/clerk-js5.44.1-snapshot.v20250115120857
@clerk/clerk-expo2.6.11-snapshot.v20250115120857
@clerk/express1.3.35-snapshot.v20250115120857
@clerk/fastify2.1.8-snapshot.v20250115120857
@clerk/nextjs6.9.11-snapshot.v20250115120857
@clerk/nuxt1.0.4-snapshot.v20250115120857
@clerk/react-router0.1.9-snapshot.v20250115120857
@clerk/remix4.4.10-snapshot.v20250115120857
@clerk/tanstack-start0.8.9-snapshot.v20250115120857
@clerk/testing1.4.8-snapshot.v20250115120857
@clerk/vue1.0.3-snapshot.v20250115120857
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro
npm i @clerk/astro@2.1.8-snapshot.v20250115120857 --save-exact
@clerk/backend
npm i @clerk/backend@1.22.1-snapshot.v20250115120857 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@2.1.12-snapshot.v20250115120857 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.44.1-snapshot.v20250115120857 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@2.6.11-snapshot.v20250115120857 --save-exact
@clerk/express
npm i @clerk/express@1.3.35-snapshot.v20250115120857 --save-exact
@clerk/fastify
npm i @clerk/fastify@2.1.8-snapshot.v20250115120857 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@6.9.11-snapshot.v20250115120857 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@1.0.4-snapshot.v20250115120857 --save-exact
@clerk/react-router
npm i @clerk/react-router@0.1.9-snapshot.v20250115120857 --save-exact
@clerk/remix
npm i @clerk/remix@4.4.10-snapshot.v20250115120857 --save-exact
@clerk/tanstack-start
npm i @clerk/tanstack-start@0.8.9-snapshot.v20250115120857 --save-exact
@clerk/testing
npm i @clerk/testing@1.4.8-snapshot.v20250115120857 --save-exact
@clerk/vue
npm i @clerk/vue@1.0.3-snapshot.v20250115120857 --save-exact
@LekoArts
LekoArts
marked this pull request as ready for review
January 15, 2025 12:17
@LekoArts
LekoArts
commented
Jan 15, 2025

Copy link


Copy Markdown

ContributorAuthor
Import is gone: https://unpkg.com/browse/@clerk/chrome-extension@2.1.12-snapshot.v20250115120857/dist/esm/index.js
anagstef
anagstef
approved these changes
Jan 15, 2025
View reviewed changes
@anagstefanagstef
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯
@LekoArts
LekoArts
merged commit 3a03836
into
mainJan 15, 2025
@LekoArts
LekoArts
deleted the

lekoarts/eco-300-chrome-web-store-rejection-mv3-remote-code-loading-issue

branch
January 15, 2025 13:25
@clerk-cookieclerk-cookie
mentioned this pull request
Jan 15, 2025
 Merged

jacekradko pushed a commit
that referenced
this pull request
Jan 15, 2025
@LekoArts@jacekradko
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake (#…
5c842f8
…4899)
wobsoriano pushed a commit
that referenced
this pull request
Feb 8, 2025
@LekoArts@wobsoriano
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake (#…
fb84acb
…4899)
@devlarabardevlarabar
mentioned this pull request
Jun 6, 2026

Closed

4 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@anagstefanagstefanagstef approved these changes
@panteliselefpanteliselefpanteliselef approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

chrome-extension

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Chrome Web Store Rejection - MV3 Remote Code Loading Issue


4 participants

@LekoArts@clerk-cookie@anagstef@panteliselef