Uh oh!
There was an error while loading. Please reload this page.
feat(clerk-js,localizations,types): Add sign in or up subtitle localizations - #4988
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 1f2efb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Comment on lines
+443
to
+447
| sx={{ | ||
| '&:empty': { | ||
| display: 'none', | ||
| }, | ||
| }} |
MemberAuthor
There was a problem hiding this comment.
By default the sign in start subtitle is undefined, and we use the empty selector to ensure the element does not take up any space within the dom. This is to enable folks to see that there is a localization option available for subtitle when viewing source in the dom. Then they can add the localization and it will show for them.
alexcarpenter
marked this pull request as ready for review
January 23, 2025 20:10
tmilewski
approved these changes
Jan 23, 2025
panteliselef
approved these changes
Jan 24, 2025
anagstef
approved these changes
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds optional localization to sign-in-or-up flow to render a subtitle if needed.
We always render the subtitle in the dom and hide with CSS when undefined to help with localization key discoverability.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change