Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .changeset/metal-bobcats-wash.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
---
'@clerk/shared': major
---
This new version introduces the following breaking changes:
- Introduced a new `retry` utility function to replace the deprecated `callWithRetry`.
- Removed the `callWithRetry` function and its associated tests.
- Renamed `runWithExponentialBackOff` to `retry` for consistency.

Migration steps:
- Replace any usage of `callWithRetry` with the new `retry` function.
- Update import statements from:
```typescript
import { callWithRetry } from '@clerk/shared/callWithRetry';
```
to:
```typescript
import { retry } from '@clerk/shared/retry';
```
- Replace any usage of `runWithExponentialBackOff` with `retry`.
- Update import statements from:
```typescript
import { runWithExponentialBackOff } from '@clerk/shared/utils';
```
to:
```typescript
import { retry } from '@clerk/shared/retry';
```
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/keys.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,7 @@ import {
} from '../errors';
import { runtime } from '../runtime';
import { joinPaths } from '../util/path';
import { callWithRetry } from '../util/shared';
import { retry } from '../util/shared';

type JsonWebKeyWithKid = JsonWebKey & { kid: string };

Expand DownExpand Up@@ -137,8 +137,8 @@ export async function loadClerkJWKFromRemote({
reason: TokenVerificationErrorReason.RemoteJWKFailedToLoad,
});
}
const fetcher = () => fetchJWKSFromBAPI(apiUrl, secretKey, apiVersion);
const { keys } = await callWithRetry<{ keys: JsonWebKeyWithKid[] }>(fetcher);
const fetcher = () => fetchJWKSFromBAPI(apiUrl, secretKey, apiVersion) as Promise<{ keys: JsonWebKeyWithKid[] }>;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ why do we need to cast here?

const { keys } = await retry(fetcher);

if (!keys || !keys.length) {
throw new TokenVerificationError({
Expand Down
4 changes: 2 additions & 2 deletions packages/backend/src/util/shared.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
export { addClerkPrefix, getScriptUrl, getClerkJsMajorVersionOrTag } from '@clerk/shared/url';
export { callWithRetry } from '@clerk/shared/callWithRetry';
export { retry } from '@clerk/shared/retry';
export {
isDevelopmentFromSecretKey,
isProductionFromSecretKey,
Expand All@@ -10,8 +10,8 @@ export {
export { deprecated, deprecatedProperty } from '@clerk/shared/deprecated';

import { buildErrorThrower } from '@clerk/shared/error';
import { createDevOrStagingUrlCache } from '@clerk/shared/keys';
// TODO: replace packageName with `${PACKAGE_NAME}@${PACKAGE_VERSION}` from tsup.config.ts
export const errorThrower = buildErrorThrower({ packageName: '@clerk/backend' });

import { createDevOrStagingUrlCache } from '@clerk/shared/keys';
export const { isDevOrStagingUrl } = createDevOrStagingUrlCache();
8 changes: 4 additions & 4 deletions packages/clerk-js/src/core/fapiClient.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { isBrowserOnline } from '@clerk/shared/browser';
import { retry } from '@clerk/shared/retry';
import { camelToSnake } from '@clerk/shared/underscore';
import { runWithExponentialBackOff } from '@clerk/shared/utils';
import type { ClerkAPIErrorJSON, ClientJSON, InstanceType } from '@clerk/types';

import { buildEmailAddress as buildEmailAddressUtil, buildURL as buildUrlUtil, stringifyQueryParams } from '../utils';
Expand DownExpand Up@@ -235,9 +235,9 @@ export function createFapiClient(options: FapiClientOptions): FapiClient {
response =
// retry only on GET requests for safety
overwrittenRequestMethod === 'GET'
? await runWithExponentialBackOff(() => fetch(urlStr, fetchOpts), {
firstDelay: 500,
maxDelay: 3000,
? await retry(() => fetch(urlStr, fetchOpts), {
initialDelay: 500,
maxDelayBetweenRetries: 3000,
shouldRetry: (_: unknown, iterationsCount: number) => {
return iterationsCount < maxTries;
},
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/Session.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { createCheckAuthorization } from '@clerk/shared/authorization';
import { is4xxError } from '@clerk/shared/error';
import { runWithExponentialBackOff } from '@clerk/shared/utils';
import { retry } from '@clerk/shared/retry';
import type {
ActJWTClaim,
CheckAuthorization,
Expand DownExpand Up@@ -84,7 +84,7 @@ export class Session extends BaseResource implements SessionResource {
};

getToken: GetToken = async (options?: GetTokenOptions): Promise<string | null> => {
return runWithExponentialBackOff(() => this._getToken(options), {
return retry(() => this._getToken(options), {
shouldRetry: (error: unknown, currentIteration: number) => !is4xxError(error) && currentIteration < 4,
});
};
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -79,7 +79,7 @@
"authorization",
"authorization-errors",
"browser",
"callWithRetry",
"retry",
"color",
"cookie",
"date",
Expand Down
23 changes: 0 additions & 23 deletions packages/shared/src/__tests__/callWithRetry.test.ts

This file was deleted.

208 changes: 208 additions & 0 deletions packages/shared/src/__tests__/retry.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,208 @@
import { retry } from '../retry';

describe('retry', () => {
beforeEach(() => {
jest.useFakeTimers();
});

afterEach(() => {
jest.useRealTimers();
});

test('resolves with the result of the callback', async () => {
const result = await retry(() => Promise.resolve('success'));
expect(result).toBe('success');
});

test('retries the callback until it succeeds', async () => {
let attempts = 0;
const result = retry(
() => {
attempts++;
if (attempts < 2) {
throw new Error('failed');
}
return Promise.resolve('success');
},
{
initialDelay: 100,
factor: 1,
jitter: false,
},
);
await jest.advanceTimersByTimeAsync(200);
expect(await result).toBe('success');
expect(attempts).toBe(2);
});

test('maxDelayBetweenRetries prevents delays from growing beyond the limit', async () => {
jest.useFakeTimers();
let attempts = 0;

retry(
() => {
attempts++;
throw new Error('failed');
},
{
maxDelayBetweenRetries: 300,
initialDelay: 100,
factor: 3,
jitter: false,
shouldRetry: (_, count) => count <= 4,
},
).catch(e => {
expect(e.message).toBe('failed');
});

// Run all timer advances before testing the promise
await jest.advanceTimersByTimeAsync(100);
await jest.advanceTimersByTimeAsync(300);
await jest.advanceTimersByTimeAsync(300);
await jest.advanceTimersByTimeAsync(300);
expect(attempts).toBe(1 + 4);
jest.useRealTimers();
});

test('respects initialDelay option', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{ initialDelay: 200, jitter: false, shouldRetry: (_, count) => count <= 2 },
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(200);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(400);
expect(attempts).toBe(3);
});

test('respects retryImmediately option', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 1000,
retryImmediately: true,
jitter: false,
shouldRetry: (_, count) => count <= 2,
},
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(101);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(1000);
expect(attempts).toBe(3);
});

test('disables immediate retry when retryImmediately is false', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 200,
retryImmediately: false,
jitter: false,
shouldRetry: (_, count) => count <= 2,
},
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(200);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(400);
expect(attempts).toBe(3);
});

test('respects shouldRetry custom logic', async () => {
let attempts = 0;
const error = new Error('special error');

await retry(
() => {
attempts++;
throw error;
},
{
initialDelay: 100,
jitter: false,
shouldRetry: e => (e as Error).message !== 'special error',
},
).catch(e => {
expect(e).toBe(error);
});

expect(attempts).toBe(1);
});

test('respects factor for exponential backoff', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 100,
factor: 4,
jitter: false,
shouldRetry: (_, count) => count <= 3,
},
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(100);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(400);
expect(attempts).toBe(3);
await jest.advanceTimersByTimeAsync(1600);
expect(attempts).toBe(4);
});

test('applies jitter by default', async () => {
let attempts = 0;

jest.spyOn(Math, 'random').mockReturnValue(0.5);

retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 100,
factor: 1,
shouldRetry: (_, count) => count <= 2,
},
).catch(() => {});

// First attempt that triggers the retry
expect(attempts).toBe(1);
// Flush all microtasks
await Promise.resolve();
// Normal delay without jitter
await jest.advanceTimersByTimeAsync(100);
// But the attempt is still 1 because with the jitter enabled,
// the delay is now 150
expect(attempts).toBe(1);
// Wait for 50ms more (100 + 50)
await jest.advanceTimersByTimeAsync(50);
// Should now reach the second attempt
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(150);
expect(attempts).toBe(3);
await jest.advanceTimersByTimeAsync(150);
expect(attempts).toBe(3);
});
});
28 changes: 0 additions & 28 deletions packages/shared/src/callWithRetry.ts

This file was deleted.

1 change: 0 additions & 1 deletion packages/shared/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,6 @@ export * from './utils';

export { apiUrlFromPublishableKey } from './apiUrlFromPublishableKey';
export * from './browser';
export { callWithRetry } from './callWithRetry';
export * from './color';
export * from './constants';
export * from './date';
Expand Down
4 changes: 2 additions & 2 deletions packages/shared/src/loadScript.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { runWithExponentialBackOff } from './utils';
import { retry } from './retry';

const NO_DOCUMENT_ERROR = 'loadScript cannot be called when document does not exist';
const NO_SRC_ERROR = 'loadScript cannot be called without a src';
Expand DownExpand Up@@ -47,5 +47,5 @@ export async function loadScript(src = '', opts: LoadScriptOptions): Promise<HTM
});
};

return runWithExponentialBackOff(load, { shouldRetry: (_, iterations) => iterations < 5 });
return retry(load, { shouldRetry: (_, iterations) => iterations <= 5 });
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .changeset/metal-bobcats-wash.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
---
'@clerk/shared': major
---
This new version introduces the following breaking changes:
- Introduced a new `retry` utility function to replace the deprecated `callWithRetry`.
- Removed the `callWithRetry` function and its associated tests.
- Renamed `runWithExponentialBackOff` to `retry` for consistency.

Migration steps:
- Replace any usage of `callWithRetry` with the new `retry` function.
- Update import statements from:
```typescript
import { callWithRetry } from '@clerk/shared/callWithRetry';
```
to:
```typescript
import { retry } from '@clerk/shared/retry';
```
- Replace any usage of `runWithExponentialBackOff` with `retry`.
- Update import statements from:
```typescript
import { runWithExponentialBackOff } from '@clerk/shared/utils';
```
to:
```typescript
import { retry } from '@clerk/shared/retry';
```
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/keys.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,7 @@ import {
} from '../errors';
import { runtime } from '../runtime';
import { joinPaths } from '../util/path';
import { callWithRetry } from '../util/shared';
import { retry } from '../util/shared';

type JsonWebKeyWithKid = JsonWebKey & { kid: string };

Expand DownExpand Up@@ -137,8 +137,8 @@ export async function loadClerkJWKFromRemote({
reason: TokenVerificationErrorReason.RemoteJWKFailedToLoad,
});
}
const fetcher = () => fetchJWKSFromBAPI(apiUrl, secretKey, apiVersion);
const { keys } = await callWithRetry<{ keys: JsonWebKeyWithKid[] }>(fetcher);
const fetcher = () => fetchJWKSFromBAPI(apiUrl, secretKey, apiVersion) as Promise<{ keys: JsonWebKeyWithKid[] }>;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ why do we need to cast here?

const { keys } = await retry(fetcher);

if (!keys || !keys.length) {
throw new TokenVerificationError({
Expand Down
4 changes: 2 additions & 2 deletions packages/backend/src/util/shared.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
export { addClerkPrefix, getScriptUrl, getClerkJsMajorVersionOrTag } from '@clerk/shared/url';
export { callWithRetry } from '@clerk/shared/callWithRetry';
export { retry } from '@clerk/shared/retry';
export {
isDevelopmentFromSecretKey,
isProductionFromSecretKey,
Expand All@@ -10,8 +10,8 @@ export {
export { deprecated, deprecatedProperty } from '@clerk/shared/deprecated';

import { buildErrorThrower } from '@clerk/shared/error';
import { createDevOrStagingUrlCache } from '@clerk/shared/keys';
// TODO: replace packageName with `${PACKAGE_NAME}@${PACKAGE_VERSION}` from tsup.config.ts
export const errorThrower = buildErrorThrower({ packageName: '@clerk/backend' });

import { createDevOrStagingUrlCache } from '@clerk/shared/keys';
export const { isDevOrStagingUrl } = createDevOrStagingUrlCache();
8 changes: 4 additions & 4 deletions packages/clerk-js/src/core/fapiClient.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { isBrowserOnline } from '@clerk/shared/browser';
import { retry } from '@clerk/shared/retry';
import { camelToSnake } from '@clerk/shared/underscore';
import { runWithExponentialBackOff } from '@clerk/shared/utils';
import type { ClerkAPIErrorJSON, ClientJSON, InstanceType } from '@clerk/types';

import { buildEmailAddress as buildEmailAddressUtil, buildURL as buildUrlUtil, stringifyQueryParams } from '../utils';
Expand DownExpand Up@@ -235,9 +235,9 @@ export function createFapiClient(options: FapiClientOptions): FapiClient {
response =
// retry only on GET requests for safety
overwrittenRequestMethod === 'GET'
? await runWithExponentialBackOff(() => fetch(urlStr, fetchOpts), {
firstDelay: 500,
maxDelay: 3000,
? await retry(() => fetch(urlStr, fetchOpts), {
initialDelay: 500,
maxDelayBetweenRetries: 3000,
shouldRetry: (_: unknown, iterationsCount: number) => {
return iterationsCount < maxTries;
},
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/Session.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { createCheckAuthorization } from '@clerk/shared/authorization';
import { is4xxError } from '@clerk/shared/error';
import { runWithExponentialBackOff } from '@clerk/shared/utils';
import { retry } from '@clerk/shared/retry';
import type {
ActJWTClaim,
CheckAuthorization,
Expand DownExpand Up@@ -84,7 +84,7 @@ export class Session extends BaseResource implements SessionResource {
};

getToken: GetToken = async (options?: GetTokenOptions): Promise<string | null> => {
return runWithExponentialBackOff(() => this._getToken(options), {
return retry(() => this._getToken(options), {
shouldRetry: (error: unknown, currentIteration: number) => !is4xxError(error) && currentIteration < 4,
});
};
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -79,7 +79,7 @@
"authorization",
"authorization-errors",
"browser",
"callWithRetry",
"retry",
"color",
"cookie",
"date",
Expand Down
23 changes: 0 additions & 23 deletions packages/shared/src/__tests__/callWithRetry.test.ts

This file was deleted.

208 changes: 208 additions & 0 deletions packages/shared/src/__tests__/retry.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,208 @@
import { retry } from '../retry';

describe('retry', () => {
beforeEach(() => {
jest.useFakeTimers();
});

afterEach(() => {
jest.useRealTimers();
});

test('resolves with the result of the callback', async () => {
const result = await retry(() => Promise.resolve('success'));
expect(result).toBe('success');
});

test('retries the callback until it succeeds', async () => {
let attempts = 0;
const result = retry(
() => {
attempts++;
if (attempts < 2) {
throw new Error('failed');
}
return Promise.resolve('success');
},
{
initialDelay: 100,
factor: 1,
jitter: false,
},
);
await jest.advanceTimersByTimeAsync(200);
expect(await result).toBe('success');
expect(attempts).toBe(2);
});

test('maxDelayBetweenRetries prevents delays from growing beyond the limit', async () => {
jest.useFakeTimers();
let attempts = 0;

retry(
() => {
attempts++;
throw new Error('failed');
},
{
maxDelayBetweenRetries: 300,
initialDelay: 100,
factor: 3,
jitter: false,
shouldRetry: (_, count) => count <= 4,
},
).catch(e => {
expect(e.message).toBe('failed');
});

// Run all timer advances before testing the promise
await jest.advanceTimersByTimeAsync(100);
await jest.advanceTimersByTimeAsync(300);
await jest.advanceTimersByTimeAsync(300);
await jest.advanceTimersByTimeAsync(300);
expect(attempts).toBe(1 + 4);
jest.useRealTimers();
});

test('respects initialDelay option', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{ initialDelay: 200, jitter: false, shouldRetry: (_, count) => count <= 2 },
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(200);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(400);
expect(attempts).toBe(3);
});

test('respects retryImmediately option', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 1000,
retryImmediately: true,
jitter: false,
shouldRetry: (_, count) => count <= 2,
},
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(101);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(1000);
expect(attempts).toBe(3);
});

test('disables immediate retry when retryImmediately is false', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 200,
retryImmediately: false,
jitter: false,
shouldRetry: (_, count) => count <= 2,
},
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(200);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(400);
expect(attempts).toBe(3);
});

test('respects shouldRetry custom logic', async () => {
let attempts = 0;
const error = new Error('special error');

await retry(
() => {
attempts++;
throw error;
},
{
initialDelay: 100,
jitter: false,
shouldRetry: e => (e as Error).message !== 'special error',
},
).catch(e => {
expect(e).toBe(error);
});

expect(attempts).toBe(1);
});

test('respects factor for exponential backoff', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 100,
factor: 4,
jitter: false,
shouldRetry: (_, count) => count <= 3,
},
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(100);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(400);
expect(attempts).toBe(3);
await jest.advanceTimersByTimeAsync(1600);
expect(attempts).toBe(4);
});

test('applies jitter by default', async () => {
let attempts = 0;

jest.spyOn(Math, 'random').mockReturnValue(0.5);

retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 100,
factor: 1,
shouldRetry: (_, count) => count <= 2,
},
).catch(() => {});

// First attempt that triggers the retry
expect(attempts).toBe(1);
// Flush all microtasks
await Promise.resolve();
// Normal delay without jitter
await jest.advanceTimersByTimeAsync(100);
// But the attempt is still 1 because with the jitter enabled,
// the delay is now 150
expect(attempts).toBe(1);
// Wait for 50ms more (100 + 50)
await jest.advanceTimersByTimeAsync(50);
// Should now reach the second attempt
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(150);
expect(attempts).toBe(3);
await jest.advanceTimersByTimeAsync(150);
expect(attempts).toBe(3);
});
});
28 changes: 0 additions & 28 deletions packages/shared/src/callWithRetry.ts

This file was deleted.

1 change: 0 additions & 1 deletion packages/shared/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,6 @@ export * from './utils';

export { apiUrlFromPublishableKey } from './apiUrlFromPublishableKey';
export * from './browser';
export { callWithRetry } from './callWithRetry';
export * from './color';
export * from './constants';
export * from './date';
Expand Down
4 changes: 2 additions & 2 deletions packages/shared/src/loadScript.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { runWithExponentialBackOff } from './utils';
import { retry } from './retry';

const NO_DOCUMENT_ERROR = 'loadScript cannot be called when document does not exist';
const NO_SRC_ERROR = 'loadScript cannot be called without a src';
Expand DownExpand Up@@ -47,5 +47,5 @@ export async function loadScript(src = '', opts: LoadScriptOptions): Promise<HTM
});
};

return runWithExponentialBackOff(load, { shouldRetry: (_, iterations) => iterations < 5 });
return retry(load, { shouldRetry: (_, iterations) => iterations <= 5 });
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .changeset/metal-bobcats-wash.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
---
'@clerk/shared': major
---
This new version introduces the following breaking changes:
- Introduced a new `retry` utility function to replace the deprecated `callWithRetry`.
- Removed the `callWithRetry` function and its associated tests.
- Renamed `runWithExponentialBackOff` to `retry` for consistency.

Migration steps:
- Replace any usage of `callWithRetry` with the new `retry` function.
- Update import statements from:
```typescript
import { callWithRetry } from '@clerk/shared/callWithRetry';
```
to:
```typescript
import { retry } from '@clerk/shared/retry';
```
- Replace any usage of `runWithExponentialBackOff` with `retry`.
- Update import statements from:
```typescript
import { runWithExponentialBackOff } from '@clerk/shared/utils';
```
to:
```typescript
import { retry } from '@clerk/shared/retry';
```
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/keys.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,7 @@ import {
} from '../errors';
import { runtime } from '../runtime';
import { joinPaths } from '../util/path';
import { callWithRetry } from '../util/shared';
import { retry } from '../util/shared';

type JsonWebKeyWithKid = JsonWebKey & { kid: string };

Expand DownExpand Up@@ -137,8 +137,8 @@ export async function loadClerkJWKFromRemote({
reason: TokenVerificationErrorReason.RemoteJWKFailedToLoad,
});
}
const fetcher = () => fetchJWKSFromBAPI(apiUrl, secretKey, apiVersion);
const { keys } = await callWithRetry<{ keys: JsonWebKeyWithKid[] }>(fetcher);
const fetcher = () => fetchJWKSFromBAPI(apiUrl, secretKey, apiVersion) as Promise<{ keys: JsonWebKeyWithKid[] }>;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ why do we need to cast here?

const { keys } = await retry(fetcher);

if (!keys || !keys.length) {
throw new TokenVerificationError({
Expand Down
4 changes: 2 additions & 2 deletions packages/backend/src/util/shared.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
export { addClerkPrefix, getScriptUrl, getClerkJsMajorVersionOrTag } from '@clerk/shared/url';
export { callWithRetry } from '@clerk/shared/callWithRetry';
export { retry } from '@clerk/shared/retry';
export {
isDevelopmentFromSecretKey,
isProductionFromSecretKey,
Expand All@@ -10,8 +10,8 @@ export {
export { deprecated, deprecatedProperty } from '@clerk/shared/deprecated';

import { buildErrorThrower } from '@clerk/shared/error';
import { createDevOrStagingUrlCache } from '@clerk/shared/keys';
// TODO: replace packageName with `${PACKAGE_NAME}@${PACKAGE_VERSION}` from tsup.config.ts
export const errorThrower = buildErrorThrower({ packageName: '@clerk/backend' });

import { createDevOrStagingUrlCache } from '@clerk/shared/keys';
export const { isDevOrStagingUrl } = createDevOrStagingUrlCache();
8 changes: 4 additions & 4 deletions packages/clerk-js/src/core/fapiClient.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { isBrowserOnline } from '@clerk/shared/browser';
import { retry } from '@clerk/shared/retry';
import { camelToSnake } from '@clerk/shared/underscore';
import { runWithExponentialBackOff } from '@clerk/shared/utils';
import type { ClerkAPIErrorJSON, ClientJSON, InstanceType } from '@clerk/types';

import { buildEmailAddress as buildEmailAddressUtil, buildURL as buildUrlUtil, stringifyQueryParams } from '../utils';
Expand DownExpand Up@@ -235,9 +235,9 @@ export function createFapiClient(options: FapiClientOptions): FapiClient {
response =
// retry only on GET requests for safety
overwrittenRequestMethod === 'GET'
? await runWithExponentialBackOff(() => fetch(urlStr, fetchOpts), {
firstDelay: 500,
maxDelay: 3000,
? await retry(() => fetch(urlStr, fetchOpts), {
initialDelay: 500,
maxDelayBetweenRetries: 3000,
shouldRetry: (_: unknown, iterationsCount: number) => {
return iterationsCount < maxTries;
},
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/Session.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { createCheckAuthorization } from '@clerk/shared/authorization';
import { is4xxError } from '@clerk/shared/error';
import { runWithExponentialBackOff } from '@clerk/shared/utils';
import { retry } from '@clerk/shared/retry';
import type {
ActJWTClaim,
CheckAuthorization,
Expand DownExpand Up@@ -84,7 +84,7 @@ export class Session extends BaseResource implements SessionResource {
};

getToken: GetToken = async (options?: GetTokenOptions): Promise<string | null> => {
return runWithExponentialBackOff(() => this._getToken(options), {
return retry(() => this._getToken(options), {
shouldRetry: (error: unknown, currentIteration: number) => !is4xxError(error) && currentIteration < 4,
});
};
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -79,7 +79,7 @@
"authorization",
"authorization-errors",
"browser",
"callWithRetry",
"retry",
"color",
"cookie",
"date",
Expand Down
23 changes: 0 additions & 23 deletions packages/shared/src/__tests__/callWithRetry.test.ts

This file was deleted.

208 changes: 208 additions & 0 deletions packages/shared/src/__tests__/retry.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,208 @@
import { retry } from '../retry';

describe('retry', () => {
beforeEach(() => {
jest.useFakeTimers();
});

afterEach(() => {
jest.useRealTimers();
});

test('resolves with the result of the callback', async () => {
const result = await retry(() => Promise.resolve('success'));
expect(result).toBe('success');
});

test('retries the callback until it succeeds', async () => {
let attempts = 0;
const result = retry(
() => {
attempts++;
if (attempts < 2) {
throw new Error('failed');
}
return Promise.resolve('success');
},
{
initialDelay: 100,
factor: 1,
jitter: false,
},
);
await jest.advanceTimersByTimeAsync(200);
expect(await result).toBe('success');
expect(attempts).toBe(2);
});

test('maxDelayBetweenRetries prevents delays from growing beyond the limit', async () => {
jest.useFakeTimers();
let attempts = 0;

retry(
() => {
attempts++;
throw new Error('failed');
},
{
maxDelayBetweenRetries: 300,
initialDelay: 100,
factor: 3,
jitter: false,
shouldRetry: (_, count) => count <= 4,
},
).catch(e => {
expect(e.message).toBe('failed');
});

// Run all timer advances before testing the promise
await jest.advanceTimersByTimeAsync(100);
await jest.advanceTimersByTimeAsync(300);
await jest.advanceTimersByTimeAsync(300);
await jest.advanceTimersByTimeAsync(300);
expect(attempts).toBe(1 + 4);
jest.useRealTimers();
});

test('respects initialDelay option', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{ initialDelay: 200, jitter: false, shouldRetry: (_, count) => count <= 2 },
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(200);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(400);
expect(attempts).toBe(3);
});

test('respects retryImmediately option', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 1000,
retryImmediately: true,
jitter: false,
shouldRetry: (_, count) => count <= 2,
},
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(101);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(1000);
expect(attempts).toBe(3);
});

test('disables immediate retry when retryImmediately is false', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 200,
retryImmediately: false,
jitter: false,
shouldRetry: (_, count) => count <= 2,
},
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(200);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(400);
expect(attempts).toBe(3);
});

test('respects shouldRetry custom logic', async () => {
let attempts = 0;
const error = new Error('special error');

await retry(
() => {
attempts++;
throw error;
},
{
initialDelay: 100,
jitter: false,
shouldRetry: e => (e as Error).message !== 'special error',
},
).catch(e => {
expect(e).toBe(error);
});

expect(attempts).toBe(1);
});

test('respects factor for exponential backoff', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 100,
factor: 4,
jitter: false,
shouldRetry: (_, count) => count <= 3,
},
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(100);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(400);
expect(attempts).toBe(3);
await jest.advanceTimersByTimeAsync(1600);
expect(attempts).toBe(4);
});

test('applies jitter by default', async () => {
let attempts = 0;

jest.spyOn(Math, 'random').mockReturnValue(0.5);

retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 100,
factor: 1,
shouldRetry: (_, count) => count <= 2,
},
).catch(() => {});

// First attempt that triggers the retry
expect(attempts).toBe(1);
// Flush all microtasks
await Promise.resolve();
// Normal delay without jitter
await jest.advanceTimersByTimeAsync(100);
// But the attempt is still 1 because with the jitter enabled,
// the delay is now 150
expect(attempts).toBe(1);
// Wait for 50ms more (100 + 50)
await jest.advanceTimersByTimeAsync(50);
// Should now reach the second attempt
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(150);
expect(attempts).toBe(3);
await jest.advanceTimersByTimeAsync(150);
expect(attempts).toBe(3);
});
});
28 changes: 0 additions & 28 deletions packages/shared/src/callWithRetry.ts

This file was deleted.

1 change: 0 additions & 1 deletion packages/shared/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,6 @@ export * from './utils';

export { apiUrlFromPublishableKey } from './apiUrlFromPublishableKey';
export * from './browser';
export { callWithRetry } from './callWithRetry';
export * from './color';
export * from './constants';
export * from './date';
Expand Down
4 changes: 2 additions & 2 deletions packages/shared/src/loadScript.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { runWithExponentialBackOff } from './utils';
import { retry } from './retry';

const NO_DOCUMENT_ERROR = 'loadScript cannot be called when document does not exist';
const NO_SRC_ERROR = 'loadScript cannot be called without a src';
Expand DownExpand Up@@ -47,5 +47,5 @@ export async function loadScript(src = '', opts: LoadScriptOptions): Promise<HTM
});
};

return runWithExponentialBackOff(load, { shouldRetry: (_, iterations) => iterations < 5 });
return retry(load, { shouldRetry: (_, iterations) => iterations <= 5 });
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .changeset/metal-bobcats-wash.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
---
'@clerk/shared': major
---
This new version introduces the following breaking changes:
- Introduced a new `retry` utility function to replace the deprecated `callWithRetry`.
- Removed the `callWithRetry` function and its associated tests.
- Renamed `runWithExponentialBackOff` to `retry` for consistency.

Migration steps:
- Replace any usage of `callWithRetry` with the new `retry` function.
- Update import statements from:
```typescript
import { callWithRetry } from '@clerk/shared/callWithRetry';
```
to:
```typescript
import { retry } from '@clerk/shared/retry';
```
- Replace any usage of `runWithExponentialBackOff` with `retry`.
- Update import statements from:
```typescript
import { runWithExponentialBackOff } from '@clerk/shared/utils';
```
to:
```typescript
import { retry } from '@clerk/shared/retry';
```
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/keys.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,7 @@ import {
} from '../errors';
import { runtime } from '../runtime';
import { joinPaths } from '../util/path';
import { callWithRetry } from '../util/shared';
import { retry } from '../util/shared';

type JsonWebKeyWithKid = JsonWebKey & { kid: string };

Expand DownExpand Up@@ -137,8 +137,8 @@ export async function loadClerkJWKFromRemote({
reason: TokenVerificationErrorReason.RemoteJWKFailedToLoad,
});
}
const fetcher = () => fetchJWKSFromBAPI(apiUrl, secretKey, apiVersion);
const { keys } = await callWithRetry<{ keys: JsonWebKeyWithKid[] }>(fetcher);
const fetcher = () => fetchJWKSFromBAPI(apiUrl, secretKey, apiVersion) as Promise<{ keys: JsonWebKeyWithKid[] }>;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ why do we need to cast here?

const { keys } = await retry(fetcher);

if (!keys || !keys.length) {
throw new TokenVerificationError({
Expand Down
4 changes: 2 additions & 2 deletions packages/backend/src/util/shared.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
export { addClerkPrefix, getScriptUrl, getClerkJsMajorVersionOrTag } from '@clerk/shared/url';
export { callWithRetry } from '@clerk/shared/callWithRetry';
export { retry } from '@clerk/shared/retry';
export {
isDevelopmentFromSecretKey,
isProductionFromSecretKey,
Expand All@@ -10,8 +10,8 @@ export {
export { deprecated, deprecatedProperty } from '@clerk/shared/deprecated';

import { buildErrorThrower } from '@clerk/shared/error';
import { createDevOrStagingUrlCache } from '@clerk/shared/keys';
// TODO: replace packageName with `${PACKAGE_NAME}@${PACKAGE_VERSION}` from tsup.config.ts
export const errorThrower = buildErrorThrower({ packageName: '@clerk/backend' });

import { createDevOrStagingUrlCache } from '@clerk/shared/keys';
export const { isDevOrStagingUrl } = createDevOrStagingUrlCache();
8 changes: 4 additions & 4 deletions packages/clerk-js/src/core/fapiClient.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { isBrowserOnline } from '@clerk/shared/browser';
import { retry } from '@clerk/shared/retry';
import { camelToSnake } from '@clerk/shared/underscore';
import { runWithExponentialBackOff } from '@clerk/shared/utils';
import type { ClerkAPIErrorJSON, ClientJSON, InstanceType } from '@clerk/types';

import { buildEmailAddress as buildEmailAddressUtil, buildURL as buildUrlUtil, stringifyQueryParams } from '../utils';
Expand DownExpand Up@@ -235,9 +235,9 @@ export function createFapiClient(options: FapiClientOptions): FapiClient {
response =
// retry only on GET requests for safety
overwrittenRequestMethod === 'GET'
? await runWithExponentialBackOff(() => fetch(urlStr, fetchOpts), {
firstDelay: 500,
maxDelay: 3000,
? await retry(() => fetch(urlStr, fetchOpts), {
initialDelay: 500,
maxDelayBetweenRetries: 3000,
shouldRetry: (_: unknown, iterationsCount: number) => {
return iterationsCount < maxTries;
},
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/Session.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { createCheckAuthorization } from '@clerk/shared/authorization';
import { is4xxError } from '@clerk/shared/error';
import { runWithExponentialBackOff } from '@clerk/shared/utils';
import { retry } from '@clerk/shared/retry';
import type {
ActJWTClaim,
CheckAuthorization,
Expand DownExpand Up@@ -84,7 +84,7 @@ export class Session extends BaseResource implements SessionResource {
};

getToken: GetToken = async (options?: GetTokenOptions): Promise<string | null> => {
return runWithExponentialBackOff(() => this._getToken(options), {
return retry(() => this._getToken(options), {
shouldRetry: (error: unknown, currentIteration: number) => !is4xxError(error) && currentIteration < 4,
});
};
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -79,7 +79,7 @@
"authorization",
"authorization-errors",
"browser",
"callWithRetry",
"retry",
"color",
"cookie",
"date",
Expand Down
23 changes: 0 additions & 23 deletions packages/shared/src/__tests__/callWithRetry.test.ts

This file was deleted.

208 changes: 208 additions & 0 deletions packages/shared/src/__tests__/retry.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,208 @@
import { retry } from '../retry';

describe('retry', () => {
beforeEach(() => {
jest.useFakeTimers();
});

afterEach(() => {
jest.useRealTimers();
});

test('resolves with the result of the callback', async () => {
const result = await retry(() => Promise.resolve('success'));
expect(result).toBe('success');
});

test('retries the callback until it succeeds', async () => {
let attempts = 0;
const result = retry(
() => {
attempts++;
if (attempts < 2) {
throw new Error('failed');
}
return Promise.resolve('success');
},
{
initialDelay: 100,
factor: 1,
jitter: false,
},
);
await jest.advanceTimersByTimeAsync(200);
expect(await result).toBe('success');
expect(attempts).toBe(2);
});

test('maxDelayBetweenRetries prevents delays from growing beyond the limit', async () => {
jest.useFakeTimers();
let attempts = 0;

retry(
() => {
attempts++;
throw new Error('failed');
},
{
maxDelayBetweenRetries: 300,
initialDelay: 100,
factor: 3,
jitter: false,
shouldRetry: (_, count) => count <= 4,
},
).catch(e => {
expect(e.message).toBe('failed');
});

// Run all timer advances before testing the promise
await jest.advanceTimersByTimeAsync(100);
await jest.advanceTimersByTimeAsync(300);
await jest.advanceTimersByTimeAsync(300);
await jest.advanceTimersByTimeAsync(300);
expect(attempts).toBe(1 + 4);
jest.useRealTimers();
});

test('respects initialDelay option', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{ initialDelay: 200, jitter: false, shouldRetry: (_, count) => count <= 2 },
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(200);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(400);
expect(attempts).toBe(3);
});

test('respects retryImmediately option', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 1000,
retryImmediately: true,
jitter: false,
shouldRetry: (_, count) => count <= 2,
},
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(101);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(1000);
expect(attempts).toBe(3);
});

test('disables immediate retry when retryImmediately is false', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 200,
retryImmediately: false,
jitter: false,
shouldRetry: (_, count) => count <= 2,
},
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(200);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(400);
expect(attempts).toBe(3);
});

test('respects shouldRetry custom logic', async () => {
let attempts = 0;
const error = new Error('special error');

await retry(
() => {
attempts++;
throw error;
},
{
initialDelay: 100,
jitter: false,
shouldRetry: e => (e as Error).message !== 'special error',
},
).catch(e => {
expect(e).toBe(error);
});

expect(attempts).toBe(1);
});

test('respects factor for exponential backoff', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 100,
factor: 4,
jitter: false,
shouldRetry: (_, count) => count <= 3,
},
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(100);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(400);
expect(attempts).toBe(3);
await jest.advanceTimersByTimeAsync(1600);
expect(attempts).toBe(4);
});

test('applies jitter by default', async () => {
let attempts = 0;

jest.spyOn(Math, 'random').mockReturnValue(0.5);

retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 100,
factor: 1,
shouldRetry: (_, count) => count <= 2,
},
).catch(() => {});

// First attempt that triggers the retry
expect(attempts).toBe(1);
// Flush all microtasks
await Promise.resolve();
// Normal delay without jitter
await jest.advanceTimersByTimeAsync(100);
// But the attempt is still 1 because with the jitter enabled,
// the delay is now 150
expect(attempts).toBe(1);
// Wait for 50ms more (100 + 50)
await jest.advanceTimersByTimeAsync(50);
// Should now reach the second attempt
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(150);
expect(attempts).toBe(3);
await jest.advanceTimersByTimeAsync(150);
expect(attempts).toBe(3);
});
});
28 changes: 0 additions & 28 deletions packages/shared/src/callWithRetry.ts

This file was deleted.

1 change: 0 additions & 1 deletion packages/shared/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,6 @@ export * from './utils';

export { apiUrlFromPublishableKey } from './apiUrlFromPublishableKey';
export * from './browser';
export { callWithRetry } from './callWithRetry';
export * from './color';
export * from './constants';
export * from './date';
Expand Down
4 changes: 2 additions & 2 deletions packages/shared/src/loadScript.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { runWithExponentialBackOff } from './utils';
import { retry } from './retry';

const NO_DOCUMENT_ERROR = 'loadScript cannot be called when document does not exist';
const NO_SRC_ERROR = 'loadScript cannot be called without a src';
Expand DownExpand Up@@ -47,5 +47,5 @@ export async function loadScript(src = '', opts: LoadScriptOptions): Promise<HTM
});
};

return runWithExponentialBackOff(load, { shouldRetry: (_, iterations) => iterations < 5 });
return retry(load, { shouldRetry: (_, iterations) => iterations <= 5 });
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .changeset/metal-bobcats-wash.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
---
'@clerk/shared': major
---
This new version introduces the following breaking changes:
- Introduced a new `retry` utility function to replace the deprecated `callWithRetry`.
- Removed the `callWithRetry` function and its associated tests.
- Renamed `runWithExponentialBackOff` to `retry` for consistency.

Migration steps:
- Replace any usage of `callWithRetry` with the new `retry` function.
- Update import statements from:
```typescript
import { callWithRetry } from '@clerk/shared/callWithRetry';
```
to:
```typescript
import { retry } from '@clerk/shared/retry';
```
- Replace any usage of `runWithExponentialBackOff` with `retry`.
- Update import statements from:
```typescript
import { runWithExponentialBackOff } from '@clerk/shared/utils';
```
to:
```typescript
import { retry } from '@clerk/shared/retry';
```
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/keys.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,7 @@ import {
} from '../errors';
import { runtime } from '../runtime';
import { joinPaths } from '../util/path';
import { callWithRetry } from '../util/shared';
import { retry } from '../util/shared';

type JsonWebKeyWithKid = JsonWebKey & { kid: string };

Expand DownExpand Up@@ -137,8 +137,8 @@ export async function loadClerkJWKFromRemote({
reason: TokenVerificationErrorReason.RemoteJWKFailedToLoad,
});
}
const fetcher = () => fetchJWKSFromBAPI(apiUrl, secretKey, apiVersion);
const { keys } = await callWithRetry<{ keys: JsonWebKeyWithKid[] }>(fetcher);
const fetcher = () => fetchJWKSFromBAPI(apiUrl, secretKey, apiVersion) as Promise<{ keys: JsonWebKeyWithKid[] }>;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ why do we need to cast here?

const { keys } = await retry(fetcher);

if (!keys || !keys.length) {
throw new TokenVerificationError({
Expand Down
4 changes: 2 additions & 2 deletions packages/backend/src/util/shared.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
export { addClerkPrefix, getScriptUrl, getClerkJsMajorVersionOrTag } from '@clerk/shared/url';
export { callWithRetry } from '@clerk/shared/callWithRetry';
export { retry } from '@clerk/shared/retry';
export {
isDevelopmentFromSecretKey,
isProductionFromSecretKey,
Expand All@@ -10,8 +10,8 @@ export {
export { deprecated, deprecatedProperty } from '@clerk/shared/deprecated';

import { buildErrorThrower } from '@clerk/shared/error';
import { createDevOrStagingUrlCache } from '@clerk/shared/keys';
// TODO: replace packageName with `${PACKAGE_NAME}@${PACKAGE_VERSION}` from tsup.config.ts
export const errorThrower = buildErrorThrower({ packageName: '@clerk/backend' });

import { createDevOrStagingUrlCache } from '@clerk/shared/keys';
export const { isDevOrStagingUrl } = createDevOrStagingUrlCache();
8 changes: 4 additions & 4 deletions packages/clerk-js/src/core/fapiClient.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { isBrowserOnline } from '@clerk/shared/browser';
import { retry } from '@clerk/shared/retry';
import { camelToSnake } from '@clerk/shared/underscore';
import { runWithExponentialBackOff } from '@clerk/shared/utils';
import type { ClerkAPIErrorJSON, ClientJSON, InstanceType } from '@clerk/types';

import { buildEmailAddress as buildEmailAddressUtil, buildURL as buildUrlUtil, stringifyQueryParams } from '../utils';
Expand DownExpand Up@@ -235,9 +235,9 @@ export function createFapiClient(options: FapiClientOptions): FapiClient {
response =
// retry only on GET requests for safety
overwrittenRequestMethod === 'GET'
? await runWithExponentialBackOff(() => fetch(urlStr, fetchOpts), {
firstDelay: 500,
maxDelay: 3000,
? await retry(() => fetch(urlStr, fetchOpts), {
initialDelay: 500,
maxDelayBetweenRetries: 3000,
shouldRetry: (_: unknown, iterationsCount: number) => {
return iterationsCount < maxTries;
},
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/Session.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { createCheckAuthorization } from '@clerk/shared/authorization';
import { is4xxError } from '@clerk/shared/error';
import { runWithExponentialBackOff } from '@clerk/shared/utils';
import { retry } from '@clerk/shared/retry';
import type {
ActJWTClaim,
CheckAuthorization,
Expand DownExpand Up@@ -84,7 +84,7 @@ export class Session extends BaseResource implements SessionResource {
};

getToken: GetToken = async (options?: GetTokenOptions): Promise<string | null> => {
return runWithExponentialBackOff(() => this._getToken(options), {
return retry(() => this._getToken(options), {
shouldRetry: (error: unknown, currentIteration: number) => !is4xxError(error) && currentIteration < 4,
});
};
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -79,7 +79,7 @@
"authorization",
"authorization-errors",
"browser",
"callWithRetry",
"retry",
"color",
"cookie",
"date",
Expand Down
23 changes: 0 additions & 23 deletions packages/shared/src/__tests__/callWithRetry.test.ts

This file was deleted.

208 changes: 208 additions & 0 deletions packages/shared/src/__tests__/retry.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,208 @@
import { retry } from '../retry';

describe('retry', () => {
beforeEach(() => {
jest.useFakeTimers();
});

afterEach(() => {
jest.useRealTimers();
});

test('resolves with the result of the callback', async () => {
const result = await retry(() => Promise.resolve('success'));
expect(result).toBe('success');
});

test('retries the callback until it succeeds', async () => {
let attempts = 0;
const result = retry(
() => {
attempts++;
if (attempts < 2) {
throw new Error('failed');
}
return Promise.resolve('success');
},
{
initialDelay: 100,
factor: 1,
jitter: false,
},
);
await jest.advanceTimersByTimeAsync(200);
expect(await result).toBe('success');
expect(attempts).toBe(2);
});

test('maxDelayBetweenRetries prevents delays from growing beyond the limit', async () => {
jest.useFakeTimers();
let attempts = 0;

retry(
() => {
attempts++;
throw new Error('failed');
},
{
maxDelayBetweenRetries: 300,
initialDelay: 100,
factor: 3,
jitter: false,
shouldRetry: (_, count) => count <= 4,
},
).catch(e => {
expect(e.message).toBe('failed');
});

// Run all timer advances before testing the promise
await jest.advanceTimersByTimeAsync(100);
await jest.advanceTimersByTimeAsync(300);
await jest.advanceTimersByTimeAsync(300);
await jest.advanceTimersByTimeAsync(300);
expect(attempts).toBe(1 + 4);
jest.useRealTimers();
});

test('respects initialDelay option', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{ initialDelay: 200, jitter: false, shouldRetry: (_, count) => count <= 2 },
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(200);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(400);
expect(attempts).toBe(3);
});

test('respects retryImmediately option', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 1000,
retryImmediately: true,
jitter: false,
shouldRetry: (_, count) => count <= 2,
},
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(101);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(1000);
expect(attempts).toBe(3);
});

test('disables immediate retry when retryImmediately is false', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 200,
retryImmediately: false,
jitter: false,
shouldRetry: (_, count) => count <= 2,
},
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(200);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(400);
expect(attempts).toBe(3);
});

test('respects shouldRetry custom logic', async () => {
let attempts = 0;
const error = new Error('special error');

await retry(
() => {
attempts++;
throw error;
},
{
initialDelay: 100,
jitter: false,
shouldRetry: e => (e as Error).message !== 'special error',
},
).catch(e => {
expect(e).toBe(error);
});

expect(attempts).toBe(1);
});

test('respects factor for exponential backoff', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 100,
factor: 4,
jitter: false,
shouldRetry: (_, count) => count <= 3,
},
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(100);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(400);
expect(attempts).toBe(3);
await jest.advanceTimersByTimeAsync(1600);
expect(attempts).toBe(4);
});

test('applies jitter by default', async () => {
let attempts = 0;

jest.spyOn(Math, 'random').mockReturnValue(0.5);

retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 100,
factor: 1,
shouldRetry: (_, count) => count <= 2,
},
).catch(() => {});

// First attempt that triggers the retry
expect(attempts).toBe(1);
// Flush all microtasks
await Promise.resolve();
// Normal delay without jitter
await jest.advanceTimersByTimeAsync(100);
// But the attempt is still 1 because with the jitter enabled,
// the delay is now 150
expect(attempts).toBe(1);
// Wait for 50ms more (100 + 50)
await jest.advanceTimersByTimeAsync(50);
// Should now reach the second attempt
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(150);
expect(attempts).toBe(3);
await jest.advanceTimersByTimeAsync(150);
expect(attempts).toBe(3);
});
});
28 changes: 0 additions & 28 deletions packages/shared/src/callWithRetry.ts

This file was deleted.

1 change: 0 additions & 1 deletion packages/shared/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,6 @@ export * from './utils';

export { apiUrlFromPublishableKey } from './apiUrlFromPublishableKey';
export * from './browser';
export { callWithRetry } from './callWithRetry';
export * from './color';
export * from './constants';
export * from './date';
Expand Down
4 changes: 2 additions & 2 deletions packages/shared/src/loadScript.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { runWithExponentialBackOff } from './utils';
import { retry } from './retry';

const NO_DOCUMENT_ERROR = 'loadScript cannot be called when document does not exist';
const NO_SRC_ERROR = 'loadScript cannot be called without a src';
Expand DownExpand Up@@ -47,5 +47,5 @@ export async function loadScript(src = '', opts: LoadScriptOptions): Promise<HTM
});
};

return runWithExponentialBackOff(load, { shouldRetry: (_, iterations) => iterations < 5 });
return retry(load, { shouldRetry: (_, iterations) => iterations <= 5 });
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .changeset/metal-bobcats-wash.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
---
'@clerk/shared': major
---
This new version introduces the following breaking changes:
- Introduced a new `retry` utility function to replace the deprecated `callWithRetry`.
- Removed the `callWithRetry` function and its associated tests.
- Renamed `runWithExponentialBackOff` to `retry` for consistency.

Migration steps:
- Replace any usage of `callWithRetry` with the new `retry` function.
- Update import statements from:
```typescript
import { callWithRetry } from '@clerk/shared/callWithRetry';
```
to:
```typescript
import { retry } from '@clerk/shared/retry';
```
- Replace any usage of `runWithExponentialBackOff` with `retry`.
- Update import statements from:
```typescript
import { runWithExponentialBackOff } from '@clerk/shared/utils';
```
to:
```typescript
import { retry } from '@clerk/shared/retry';
```
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/keys.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,7 @@ import {
} from '../errors';
import { runtime } from '../runtime';
import { joinPaths } from '../util/path';
import { callWithRetry } from '../util/shared';
import { retry } from '../util/shared';

type JsonWebKeyWithKid = JsonWebKey & { kid: string };

Expand DownExpand Up@@ -137,8 +137,8 @@ export async function loadClerkJWKFromRemote({
reason: TokenVerificationErrorReason.RemoteJWKFailedToLoad,
});
}
const fetcher = () => fetchJWKSFromBAPI(apiUrl, secretKey, apiVersion);
const { keys } = await callWithRetry<{ keys: JsonWebKeyWithKid[] }>(fetcher);
const fetcher = () => fetchJWKSFromBAPI(apiUrl, secretKey, apiVersion) as Promise<{ keys: JsonWebKeyWithKid[] }>;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ why do we need to cast here?

const { keys } = await retry(fetcher);

if (!keys || !keys.length) {
throw new TokenVerificationError({
Expand Down
4 changes: 2 additions & 2 deletions packages/backend/src/util/shared.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
export { addClerkPrefix, getScriptUrl, getClerkJsMajorVersionOrTag } from '@clerk/shared/url';
export { callWithRetry } from '@clerk/shared/callWithRetry';
export { retry } from '@clerk/shared/retry';
export {
isDevelopmentFromSecretKey,
isProductionFromSecretKey,
Expand All@@ -10,8 +10,8 @@ export {
export { deprecated, deprecatedProperty } from '@clerk/shared/deprecated';

import { buildErrorThrower } from '@clerk/shared/error';
import { createDevOrStagingUrlCache } from '@clerk/shared/keys';
// TODO: replace packageName with `${PACKAGE_NAME}@${PACKAGE_VERSION}` from tsup.config.ts
export const errorThrower = buildErrorThrower({ packageName: '@clerk/backend' });

import { createDevOrStagingUrlCache } from '@clerk/shared/keys';
export const { isDevOrStagingUrl } = createDevOrStagingUrlCache();
8 changes: 4 additions & 4 deletions packages/clerk-js/src/core/fapiClient.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { isBrowserOnline } from '@clerk/shared/browser';
import { retry } from '@clerk/shared/retry';
import { camelToSnake } from '@clerk/shared/underscore';
import { runWithExponentialBackOff } from '@clerk/shared/utils';
import type { ClerkAPIErrorJSON, ClientJSON, InstanceType } from '@clerk/types';

import { buildEmailAddress as buildEmailAddressUtil, buildURL as buildUrlUtil, stringifyQueryParams } from '../utils';
Expand DownExpand Up@@ -235,9 +235,9 @@ export function createFapiClient(options: FapiClientOptions): FapiClient {
response =
// retry only on GET requests for safety
overwrittenRequestMethod === 'GET'
? await runWithExponentialBackOff(() => fetch(urlStr, fetchOpts), {
firstDelay: 500,
maxDelay: 3000,
? await retry(() => fetch(urlStr, fetchOpts), {
initialDelay: 500,
maxDelayBetweenRetries: 3000,
shouldRetry: (_: unknown, iterationsCount: number) => {
return iterationsCount < maxTries;
},
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/Session.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { createCheckAuthorization } from '@clerk/shared/authorization';
import { is4xxError } from '@clerk/shared/error';
import { runWithExponentialBackOff } from '@clerk/shared/utils';
import { retry } from '@clerk/shared/retry';
import type {
ActJWTClaim,
CheckAuthorization,
Expand DownExpand Up@@ -84,7 +84,7 @@ export class Session extends BaseResource implements SessionResource {
};

getToken: GetToken = async (options?: GetTokenOptions): Promise<string | null> => {
return runWithExponentialBackOff(() => this._getToken(options), {
return retry(() => this._getToken(options), {
shouldRetry: (error: unknown, currentIteration: number) => !is4xxError(error) && currentIteration < 4,
});
};
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -79,7 +79,7 @@
"authorization",
"authorization-errors",
"browser",
"callWithRetry",
"retry",
"color",
"cookie",
"date",
Expand Down
23 changes: 0 additions & 23 deletions packages/shared/src/__tests__/callWithRetry.test.ts

This file was deleted.

208 changes: 208 additions & 0 deletions packages/shared/src/__tests__/retry.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,208 @@
import { retry } from '../retry';

describe('retry', () => {
beforeEach(() => {
jest.useFakeTimers();
});

afterEach(() => {
jest.useRealTimers();
});

test('resolves with the result of the callback', async () => {
const result = await retry(() => Promise.resolve('success'));
expect(result).toBe('success');
});

test('retries the callback until it succeeds', async () => {
let attempts = 0;
const result = retry(
() => {
attempts++;
if (attempts < 2) {
throw new Error('failed');
}
return Promise.resolve('success');
},
{
initialDelay: 100,
factor: 1,
jitter: false,
},
);
await jest.advanceTimersByTimeAsync(200);
expect(await result).toBe('success');
expect(attempts).toBe(2);
});

test('maxDelayBetweenRetries prevents delays from growing beyond the limit', async () => {
jest.useFakeTimers();
let attempts = 0;

retry(
() => {
attempts++;
throw new Error('failed');
},
{
maxDelayBetweenRetries: 300,
initialDelay: 100,
factor: 3,
jitter: false,
shouldRetry: (_, count) => count <= 4,
},
).catch(e => {
expect(e.message).toBe('failed');
});

// Run all timer advances before testing the promise
await jest.advanceTimersByTimeAsync(100);
await jest.advanceTimersByTimeAsync(300);
await jest.advanceTimersByTimeAsync(300);
await jest.advanceTimersByTimeAsync(300);
expect(attempts).toBe(1 + 4);
jest.useRealTimers();
});

test('respects initialDelay option', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{ initialDelay: 200, jitter: false, shouldRetry: (_, count) => count <= 2 },
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(200);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(400);
expect(attempts).toBe(3);
});

test('respects retryImmediately option', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 1000,
retryImmediately: true,
jitter: false,
shouldRetry: (_, count) => count <= 2,
},
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(101);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(1000);
expect(attempts).toBe(3);
});

test('disables immediate retry when retryImmediately is false', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 200,
retryImmediately: false,
jitter: false,
shouldRetry: (_, count) => count <= 2,
},
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(200);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(400);
expect(attempts).toBe(3);
});

test('respects shouldRetry custom logic', async () => {
let attempts = 0;
const error = new Error('special error');

await retry(
() => {
attempts++;
throw error;
},
{
initialDelay: 100,
jitter: false,
shouldRetry: e => (e as Error).message !== 'special error',
},
).catch(e => {
expect(e).toBe(error);
});

expect(attempts).toBe(1);
});

test('respects factor for exponential backoff', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 100,
factor: 4,
jitter: false,
shouldRetry: (_, count) => count <= 3,
},
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(100);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(400);
expect(attempts).toBe(3);
await jest.advanceTimersByTimeAsync(1600);
expect(attempts).toBe(4);
});

test('applies jitter by default', async () => {
let attempts = 0;

jest.spyOn(Math, 'random').mockReturnValue(0.5);

retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 100,
factor: 1,
shouldRetry: (_, count) => count <= 2,
},
).catch(() => {});

// First attempt that triggers the retry
expect(attempts).toBe(1);
// Flush all microtasks
await Promise.resolve();
// Normal delay without jitter
await jest.advanceTimersByTimeAsync(100);
// But the attempt is still 1 because with the jitter enabled,
// the delay is now 150
expect(attempts).toBe(1);
// Wait for 50ms more (100 + 50)
await jest.advanceTimersByTimeAsync(50);
// Should now reach the second attempt
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(150);
expect(attempts).toBe(3);
await jest.advanceTimersByTimeAsync(150);
expect(attempts).toBe(3);
});
});
28 changes: 0 additions & 28 deletions packages/shared/src/callWithRetry.ts

This file was deleted.

1 change: 0 additions & 1 deletion packages/shared/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,6 @@ export * from './utils';

export { apiUrlFromPublishableKey } from './apiUrlFromPublishableKey';
export * from './browser';
export { callWithRetry } from './callWithRetry';
export * from './color';
export * from './constants';
export * from './date';
Expand Down
4 changes: 2 additions & 2 deletions packages/shared/src/loadScript.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { runWithExponentialBackOff } from './utils';
import { retry } from './retry';

const NO_DOCUMENT_ERROR = 'loadScript cannot be called when document does not exist';
const NO_SRC_ERROR = 'loadScript cannot be called without a src';
Expand DownExpand Up@@ -47,5 +47,5 @@ export async function loadScript(src = '', opts: LoadScriptOptions): Promise<HTM
});
};

return runWithExponentialBackOff(load, { shouldRetry: (_, iterations) => iterations < 5 });
return retry(load, { shouldRetry: (_, iterations) => iterations <= 5 });
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .changeset/metal-bobcats-wash.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
---
'@clerk/shared': major
---
This new version introduces the following breaking changes:
- Introduced a new `retry` utility function to replace the deprecated `callWithRetry`.
- Removed the `callWithRetry` function and its associated tests.
- Renamed `runWithExponentialBackOff` to `retry` for consistency.

Migration steps:
- Replace any usage of `callWithRetry` with the new `retry` function.
- Update import statements from:
```typescript
import { callWithRetry } from '@clerk/shared/callWithRetry';
```
to:
```typescript
import { retry } from '@clerk/shared/retry';
```
- Replace any usage of `runWithExponentialBackOff` with `retry`.
- Update import statements from:
```typescript
import { runWithExponentialBackOff } from '@clerk/shared/utils';
```
to:
```typescript
import { retry } from '@clerk/shared/retry';
```
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/keys.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,7 @@ import {
} from '../errors';
import { runtime } from '../runtime';
import { joinPaths } from '../util/path';
import { callWithRetry } from '../util/shared';
import { retry } from '../util/shared';

type JsonWebKeyWithKid = JsonWebKey & { kid: string };

Expand DownExpand Up@@ -137,8 +137,8 @@ export async function loadClerkJWKFromRemote({
reason: TokenVerificationErrorReason.RemoteJWKFailedToLoad,
});
}
const fetcher = () => fetchJWKSFromBAPI(apiUrl, secretKey, apiVersion);
const { keys } = await callWithRetry<{ keys: JsonWebKeyWithKid[] }>(fetcher);
const fetcher = () => fetchJWKSFromBAPI(apiUrl, secretKey, apiVersion) as Promise<{ keys: JsonWebKeyWithKid[] }>;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ why do we need to cast here?

const { keys } = await retry(fetcher);

if (!keys || !keys.length) {
throw new TokenVerificationError({
Expand Down
4 changes: 2 additions & 2 deletions packages/backend/src/util/shared.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
export { addClerkPrefix, getScriptUrl, getClerkJsMajorVersionOrTag } from '@clerk/shared/url';
export { callWithRetry } from '@clerk/shared/callWithRetry';
export { retry } from '@clerk/shared/retry';
export {
isDevelopmentFromSecretKey,
isProductionFromSecretKey,
Expand All@@ -10,8 +10,8 @@ export {
export { deprecated, deprecatedProperty } from '@clerk/shared/deprecated';

import { buildErrorThrower } from '@clerk/shared/error';
import { createDevOrStagingUrlCache } from '@clerk/shared/keys';
// TODO: replace packageName with `${PACKAGE_NAME}@${PACKAGE_VERSION}` from tsup.config.ts
export const errorThrower = buildErrorThrower({ packageName: '@clerk/backend' });

import { createDevOrStagingUrlCache } from '@clerk/shared/keys';
export const { isDevOrStagingUrl } = createDevOrStagingUrlCache();
8 changes: 4 additions & 4 deletions packages/clerk-js/src/core/fapiClient.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { isBrowserOnline } from '@clerk/shared/browser';
import { retry } from '@clerk/shared/retry';
import { camelToSnake } from '@clerk/shared/underscore';
import { runWithExponentialBackOff } from '@clerk/shared/utils';
import type { ClerkAPIErrorJSON, ClientJSON, InstanceType } from '@clerk/types';

import { buildEmailAddress as buildEmailAddressUtil, buildURL as buildUrlUtil, stringifyQueryParams } from '../utils';
Expand DownExpand Up@@ -235,9 +235,9 @@ export function createFapiClient(options: FapiClientOptions): FapiClient {
response =
// retry only on GET requests for safety
overwrittenRequestMethod === 'GET'
? await runWithExponentialBackOff(() => fetch(urlStr, fetchOpts), {
firstDelay: 500,
maxDelay: 3000,
? await retry(() => fetch(urlStr, fetchOpts), {
initialDelay: 500,
maxDelayBetweenRetries: 3000,
shouldRetry: (_: unknown, iterationsCount: number) => {
return iterationsCount < maxTries;
},
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/Session.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { createCheckAuthorization } from '@clerk/shared/authorization';
import { is4xxError } from '@clerk/shared/error';
import { runWithExponentialBackOff } from '@clerk/shared/utils';
import { retry } from '@clerk/shared/retry';
import type {
ActJWTClaim,
CheckAuthorization,
Expand DownExpand Up@@ -84,7 +84,7 @@ export class Session extends BaseResource implements SessionResource {
};

getToken: GetToken = async (options?: GetTokenOptions): Promise<string | null> => {
return runWithExponentialBackOff(() => this._getToken(options), {
return retry(() => this._getToken(options), {
shouldRetry: (error: unknown, currentIteration: number) => !is4xxError(error) && currentIteration < 4,
});
};
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -79,7 +79,7 @@
"authorization",
"authorization-errors",
"browser",
"callWithRetry",
"retry",
"color",
"cookie",
"date",
Expand Down
23 changes: 0 additions & 23 deletions packages/shared/src/__tests__/callWithRetry.test.ts

This file was deleted.

208 changes: 208 additions & 0 deletions packages/shared/src/__tests__/retry.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,208 @@
import { retry } from '../retry';

describe('retry', () => {
beforeEach(() => {
jest.useFakeTimers();
});

afterEach(() => {
jest.useRealTimers();
});

test('resolves with the result of the callback', async () => {
const result = await retry(() => Promise.resolve('success'));
expect(result).toBe('success');
});

test('retries the callback until it succeeds', async () => {
let attempts = 0;
const result = retry(
() => {
attempts++;
if (attempts < 2) {
throw new Error('failed');
}
return Promise.resolve('success');
},
{
initialDelay: 100,
factor: 1,
jitter: false,
},
);
await jest.advanceTimersByTimeAsync(200);
expect(await result).toBe('success');
expect(attempts).toBe(2);
});

test('maxDelayBetweenRetries prevents delays from growing beyond the limit', async () => {
jest.useFakeTimers();
let attempts = 0;

retry(
() => {
attempts++;
throw new Error('failed');
},
{
maxDelayBetweenRetries: 300,
initialDelay: 100,
factor: 3,
jitter: false,
shouldRetry: (_, count) => count <= 4,
},
).catch(e => {
expect(e.message).toBe('failed');
});

// Run all timer advances before testing the promise
await jest.advanceTimersByTimeAsync(100);
await jest.advanceTimersByTimeAsync(300);
await jest.advanceTimersByTimeAsync(300);
await jest.advanceTimersByTimeAsync(300);
expect(attempts).toBe(1 + 4);
jest.useRealTimers();
});

test('respects initialDelay option', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{ initialDelay: 200, jitter: false, shouldRetry: (_, count) => count <= 2 },
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(200);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(400);
expect(attempts).toBe(3);
});

test('respects retryImmediately option', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 1000,
retryImmediately: true,
jitter: false,
shouldRetry: (_, count) => count <= 2,
},
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(101);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(1000);
expect(attempts).toBe(3);
});

test('disables immediate retry when retryImmediately is false', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 200,
retryImmediately: false,
jitter: false,
shouldRetry: (_, count) => count <= 2,
},
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(200);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(400);
expect(attempts).toBe(3);
});

test('respects shouldRetry custom logic', async () => {
let attempts = 0;
const error = new Error('special error');

await retry(
() => {
attempts++;
throw error;
},
{
initialDelay: 100,
jitter: false,
shouldRetry: e => (e as Error).message !== 'special error',
},
).catch(e => {
expect(e).toBe(error);
});

expect(attempts).toBe(1);
});

test('respects factor for exponential backoff', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 100,
factor: 4,
jitter: false,
shouldRetry: (_, count) => count <= 3,
},
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(100);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(400);
expect(attempts).toBe(3);
await jest.advanceTimersByTimeAsync(1600);
expect(attempts).toBe(4);
});

test('applies jitter by default', async () => {
let attempts = 0;

jest.spyOn(Math, 'random').mockReturnValue(0.5);

retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 100,
factor: 1,
shouldRetry: (_, count) => count <= 2,
},
).catch(() => {});

// First attempt that triggers the retry
expect(attempts).toBe(1);
// Flush all microtasks
await Promise.resolve();
// Normal delay without jitter
await jest.advanceTimersByTimeAsync(100);
// But the attempt is still 1 because with the jitter enabled,
// the delay is now 150
expect(attempts).toBe(1);
// Wait for 50ms more (100 + 50)
await jest.advanceTimersByTimeAsync(50);
// Should now reach the second attempt
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(150);
expect(attempts).toBe(3);
await jest.advanceTimersByTimeAsync(150);
expect(attempts).toBe(3);
});
});
28 changes: 0 additions & 28 deletions packages/shared/src/callWithRetry.ts

This file was deleted.

1 change: 0 additions & 1 deletion packages/shared/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,6 @@ export * from './utils';

export { apiUrlFromPublishableKey } from './apiUrlFromPublishableKey';
export * from './browser';
export { callWithRetry } from './callWithRetry';
export * from './color';
export * from './constants';
export * from './date';
Expand Down
4 changes: 2 additions & 2 deletions packages/shared/src/loadScript.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { runWithExponentialBackOff } from './utils';
import { retry } from './retry';

const NO_DOCUMENT_ERROR = 'loadScript cannot be called when document does not exist';
const NO_SRC_ERROR = 'loadScript cannot be called without a src';
Expand DownExpand Up@@ -47,5 +47,5 @@ export async function loadScript(src = '', opts: LoadScriptOptions): Promise<HTM
});
};

return runWithExponentialBackOff(load, { shouldRetry: (_, iterations) => iterations < 5 });
return retry(load, { shouldRetry: (_, iterations) => iterations <= 5 });
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .changeset/metal-bobcats-wash.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
---
'@clerk/shared': major
---
This new version introduces the following breaking changes:
- Introduced a new `retry` utility function to replace the deprecated `callWithRetry`.
- Removed the `callWithRetry` function and its associated tests.
- Renamed `runWithExponentialBackOff` to `retry` for consistency.

Migration steps:
- Replace any usage of `callWithRetry` with the new `retry` function.
- Update import statements from:
```typescript
import { callWithRetry } from '@clerk/shared/callWithRetry';
```
to:
```typescript
import { retry } from '@clerk/shared/retry';
```
- Replace any usage of `runWithExponentialBackOff` with `retry`.
- Update import statements from:
```typescript
import { runWithExponentialBackOff } from '@clerk/shared/utils';
```
to:
```typescript
import { retry } from '@clerk/shared/retry';
```
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/keys.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,7 @@ import {
} from '../errors';
import { runtime } from '../runtime';
import { joinPaths } from '../util/path';
import { callWithRetry } from '../util/shared';
import { retry } from '../util/shared';

type JsonWebKeyWithKid = JsonWebKey & { kid: string };

Expand DownExpand Up@@ -137,8 +137,8 @@ export async function loadClerkJWKFromRemote({
reason: TokenVerificationErrorReason.RemoteJWKFailedToLoad,
});
}
const fetcher = () => fetchJWKSFromBAPI(apiUrl, secretKey, apiVersion);
const { keys } = await callWithRetry<{ keys: JsonWebKeyWithKid[] }>(fetcher);
const fetcher = () => fetchJWKSFromBAPI(apiUrl, secretKey, apiVersion) as Promise<{ keys: JsonWebKeyWithKid[] }>;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ why do we need to cast here?

const { keys } = await retry(fetcher);

if (!keys || !keys.length) {
throw new TokenVerificationError({
Expand Down
4 changes: 2 additions & 2 deletions packages/backend/src/util/shared.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
export { addClerkPrefix, getScriptUrl, getClerkJsMajorVersionOrTag } from '@clerk/shared/url';
export { callWithRetry } from '@clerk/shared/callWithRetry';
export { retry } from '@clerk/shared/retry';
export {
isDevelopmentFromSecretKey,
isProductionFromSecretKey,
Expand All@@ -10,8 +10,8 @@ export {
export { deprecated, deprecatedProperty } from '@clerk/shared/deprecated';

import { buildErrorThrower } from '@clerk/shared/error';
import { createDevOrStagingUrlCache } from '@clerk/shared/keys';
// TODO: replace packageName with `${PACKAGE_NAME}@${PACKAGE_VERSION}` from tsup.config.ts
export const errorThrower = buildErrorThrower({ packageName: '@clerk/backend' });

import { createDevOrStagingUrlCache } from '@clerk/shared/keys';
export const { isDevOrStagingUrl } = createDevOrStagingUrlCache();
8 changes: 4 additions & 4 deletions packages/clerk-js/src/core/fapiClient.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { isBrowserOnline } from '@clerk/shared/browser';
import { retry } from '@clerk/shared/retry';
import { camelToSnake } from '@clerk/shared/underscore';
import { runWithExponentialBackOff } from '@clerk/shared/utils';
import type { ClerkAPIErrorJSON, ClientJSON, InstanceType } from '@clerk/types';

import { buildEmailAddress as buildEmailAddressUtil, buildURL as buildUrlUtil, stringifyQueryParams } from '../utils';
Expand DownExpand Up@@ -235,9 +235,9 @@ export function createFapiClient(options: FapiClientOptions): FapiClient {
response =
// retry only on GET requests for safety
overwrittenRequestMethod === 'GET'
? await runWithExponentialBackOff(() => fetch(urlStr, fetchOpts), {
firstDelay: 500,
maxDelay: 3000,
? await retry(() => fetch(urlStr, fetchOpts), {
initialDelay: 500,
maxDelayBetweenRetries: 3000,
shouldRetry: (_: unknown, iterationsCount: number) => {
return iterationsCount < maxTries;
},
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/Session.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { createCheckAuthorization } from '@clerk/shared/authorization';
import { is4xxError } from '@clerk/shared/error';
import { runWithExponentialBackOff } from '@clerk/shared/utils';
import { retry } from '@clerk/shared/retry';
import type {
ActJWTClaim,
CheckAuthorization,
Expand DownExpand Up@@ -84,7 +84,7 @@ export class Session extends BaseResource implements SessionResource {
};

getToken: GetToken = async (options?: GetTokenOptions): Promise<string | null> => {
return runWithExponentialBackOff(() => this._getToken(options), {
return retry(() => this._getToken(options), {
shouldRetry: (error: unknown, currentIteration: number) => !is4xxError(error) && currentIteration < 4,
});
};
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -79,7 +79,7 @@
"authorization",
"authorization-errors",
"browser",
"callWithRetry",
"retry",
"color",
"cookie",
"date",
Expand Down
23 changes: 0 additions & 23 deletions packages/shared/src/__tests__/callWithRetry.test.ts

This file was deleted.

208 changes: 208 additions & 0 deletions packages/shared/src/__tests__/retry.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,208 @@
import { retry } from '../retry';

describe('retry', () => {
beforeEach(() => {
jest.useFakeTimers();
});

afterEach(() => {
jest.useRealTimers();
});

test('resolves with the result of the callback', async () => {
const result = await retry(() => Promise.resolve('success'));
expect(result).toBe('success');
});

test('retries the callback until it succeeds', async () => {
let attempts = 0;
const result = retry(
() => {
attempts++;
if (attempts < 2) {
throw new Error('failed');
}
return Promise.resolve('success');
},
{
initialDelay: 100,
factor: 1,
jitter: false,
},
);
await jest.advanceTimersByTimeAsync(200);
expect(await result).toBe('success');
expect(attempts).toBe(2);
});

test('maxDelayBetweenRetries prevents delays from growing beyond the limit', async () => {
jest.useFakeTimers();
let attempts = 0;

retry(
() => {
attempts++;
throw new Error('failed');
},
{
maxDelayBetweenRetries: 300,
initialDelay: 100,
factor: 3,
jitter: false,
shouldRetry: (_, count) => count <= 4,
},
).catch(e => {
expect(e.message).toBe('failed');
});

// Run all timer advances before testing the promise
await jest.advanceTimersByTimeAsync(100);
await jest.advanceTimersByTimeAsync(300);
await jest.advanceTimersByTimeAsync(300);
await jest.advanceTimersByTimeAsync(300);
expect(attempts).toBe(1 + 4);
jest.useRealTimers();
});

test('respects initialDelay option', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{ initialDelay: 200, jitter: false, shouldRetry: (_, count) => count <= 2 },
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(200);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(400);
expect(attempts).toBe(3);
});

test('respects retryImmediately option', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 1000,
retryImmediately: true,
jitter: false,
shouldRetry: (_, count) => count <= 2,
},
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(101);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(1000);
expect(attempts).toBe(3);
});

test('disables immediate retry when retryImmediately is false', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 200,
retryImmediately: false,
jitter: false,
shouldRetry: (_, count) => count <= 2,
},
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(200);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(400);
expect(attempts).toBe(3);
});

test('respects shouldRetry custom logic', async () => {
let attempts = 0;
const error = new Error('special error');

await retry(
() => {
attempts++;
throw error;
},
{
initialDelay: 100,
jitter: false,
shouldRetry: e => (e as Error).message !== 'special error',
},
).catch(e => {
expect(e).toBe(error);
});

expect(attempts).toBe(1);
});

test('respects factor for exponential backoff', async () => {
let attempts = 0;
retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 100,
factor: 4,
jitter: false,
shouldRetry: (_, count) => count <= 3,
},
).catch(() => {});

expect(attempts).toBe(1);
await jest.advanceTimersByTimeAsync(100);
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(400);
expect(attempts).toBe(3);
await jest.advanceTimersByTimeAsync(1600);
expect(attempts).toBe(4);
});

test('applies jitter by default', async () => {
let attempts = 0;

jest.spyOn(Math, 'random').mockReturnValue(0.5);

retry(
() => {
attempts++;
throw new Error('failed');
},
{
initialDelay: 100,
factor: 1,
shouldRetry: (_, count) => count <= 2,
},
).catch(() => {});

// First attempt that triggers the retry
expect(attempts).toBe(1);
// Flush all microtasks
await Promise.resolve();
// Normal delay without jitter
await jest.advanceTimersByTimeAsync(100);
// But the attempt is still 1 because with the jitter enabled,
// the delay is now 150
expect(attempts).toBe(1);
// Wait for 50ms more (100 + 50)
await jest.advanceTimersByTimeAsync(50);
// Should now reach the second attempt
expect(attempts).toBe(2);
await jest.advanceTimersByTimeAsync(150);
expect(attempts).toBe(3);
await jest.advanceTimersByTimeAsync(150);
expect(attempts).toBe(3);
});
});
28 changes: 0 additions & 28 deletions packages/shared/src/callWithRetry.ts

This file was deleted.

1 change: 0 additions & 1 deletion packages/shared/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,6 @@ export * from './utils';

export { apiUrlFromPublishableKey } from './apiUrlFromPublishableKey';
export * from './browser';
export { callWithRetry } from './callWithRetry';
export * from './color';
export * from './constants';
export * from './date';
Expand Down
4 changes: 2 additions & 2 deletions packages/shared/src/loadScript.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { runWithExponentialBackOff } from './utils';
import { retry } from './retry';

const NO_DOCUMENT_ERROR = 'loadScript cannot be called when document does not exist';
const NO_SRC_ERROR = 'loadScript cannot be called without a src';
Expand DownExpand Up@@ -47,5 +47,5 @@ export async function loadScript(src = '', opts: LoadScriptOptions): Promise<HTM
});
};

return runWithExponentialBackOff(load, { shouldRetry: (_, iterations) => iterations < 5 });
return retry(load, { shouldRetry: (_, iterations) => iterations <= 5 });
}
Loading