chore(repo): Replace `Clerk.user` with `Clerk.isSignedIn` on integration tests by LauraBeatris · Pull Request #5186 · clerk/javascript

LauraBeatris · 2025-02-17T18:44:56Z

Description

Blocked by #5136 - waiting to be deployed (currently stacked branch)

Instead of relying on the Clerk.user to determine whether to mount elements for a custom sign-in flow, use the newest Clerk.isSignedIn

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2025-02-17T18:45:01Z

⚠️ No Changeset found

Latest commit: 8b46b36

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-02-17T18:45:02Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
clerk-js-sandbox	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 17, 2025 6:50pm

panteliselef · 2025-02-17T20:22:05Z

 const controlStateEl = document.querySelector('#user-state');

- if (Clerk.user) {
+ if (Clerk.isSignedIn) {


For applications that don't have pending sessions, checking Clerk.user will still be the same as Clerk.isSignedIn, correct ?

Correct! We'll start replacing Clerk.user for custom flow branches of logic to keep it scalable for both active/pending - the following will be applied to our docs especially

LauraBeatris · 2025-02-18T11:44:11Z

Actually closing this one, realized that it's not super necessary as right now Clerk.user still gets resolved even when Clerk.isSignedIn is true

It'd just be required to replace it we were explicitly checking for session.status === 'active'

LauraBeatris · 2025-02-17T18:44:56Z

Description

Blocked by #5136 - waiting to be deployed (currently stacked branch)

Instead of relying on the Clerk.user to determine whether to mount elements for a custom sign-in flow, use the newest Clerk.isSignedIn

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2025-02-17T18:45:01Z

⚠️ No Changeset found

Latest commit: 8b46b36

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-02-17T18:45:02Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
clerk-js-sandbox	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 17, 2025 6:50pm

panteliselef · 2025-02-17T20:22:05Z

 const controlStateEl = document.querySelector('#user-state');

- if (Clerk.user) {
+ if (Clerk.isSignedIn) {


For applications that don't have pending sessions, checking Clerk.user will still be the same as Clerk.isSignedIn, correct ?

Correct! We'll start replacing Clerk.user for custom flow branches of logic to keep it scalable for both active/pending - the following will be applied to our docs especially

LauraBeatris · 2025-02-18T11:44:11Z

Actually closing this one, realized that it's not super necessary as right now Clerk.user still gets resolved even when Clerk.isSignedIn is true

It'd just be required to replace it we were explicitly checking for session.status === 'active'

LauraBeatris · 2025-02-17T18:44:56Z

Description

Blocked by #5136 - waiting to be deployed (currently stacked branch)

Instead of relying on the Clerk.user to determine whether to mount elements for a custom sign-in flow, use the newest Clerk.isSignedIn

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2025-02-17T18:45:01Z

⚠️ No Changeset found

Latest commit: 8b46b36

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-02-17T18:45:02Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
clerk-js-sandbox	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 17, 2025 6:50pm

panteliselef · 2025-02-17T20:22:05Z

 const controlStateEl = document.querySelector('#user-state');

- if (Clerk.user) {
+ if (Clerk.isSignedIn) {


For applications that don't have pending sessions, checking Clerk.user will still be the same as Clerk.isSignedIn, correct ?

Correct! We'll start replacing Clerk.user for custom flow branches of logic to keep it scalable for both active/pending - the following will be applied to our docs especially

LauraBeatris · 2025-02-18T11:44:11Z

Actually closing this one, realized that it's not super necessary as right now Clerk.user still gets resolved even when Clerk.isSignedIn is true

It'd just be required to replace it we were explicitly checking for session.status === 'active'

LauraBeatris · 2025-02-17T18:44:56Z

Description

Blocked by #5136 - waiting to be deployed (currently stacked branch)

Instead of relying on the Clerk.user to determine whether to mount elements for a custom sign-in flow, use the newest Clerk.isSignedIn

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2025-02-17T18:45:01Z

⚠️ No Changeset found

Latest commit: 8b46b36

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-02-17T18:45:02Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
clerk-js-sandbox	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 17, 2025 6:50pm

panteliselef · 2025-02-17T20:22:05Z

 const controlStateEl = document.querySelector('#user-state');

- if (Clerk.user) {
+ if (Clerk.isSignedIn) {


For applications that don't have pending sessions, checking Clerk.user will still be the same as Clerk.isSignedIn, correct ?

Correct! We'll start replacing Clerk.user for custom flow branches of logic to keep it scalable for both active/pending - the following will be applied to our docs especially

LauraBeatris · 2025-02-18T11:44:11Z

Actually closing this one, realized that it's not super necessary as right now Clerk.user still gets resolved even when Clerk.isSignedIn is true

It'd just be required to replace it we were explicitly checking for session.status === 'active'

LauraBeatris · 2025-02-17T18:44:56Z

Description

Blocked by #5136 - waiting to be deployed (currently stacked branch)

Instead of relying on the Clerk.user to determine whether to mount elements for a custom sign-in flow, use the newest Clerk.isSignedIn

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2025-02-17T18:45:01Z

⚠️ No Changeset found

Latest commit: 8b46b36

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-02-17T18:45:02Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
clerk-js-sandbox	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 17, 2025 6:50pm

panteliselef · 2025-02-17T20:22:05Z

 const controlStateEl = document.querySelector('#user-state');

- if (Clerk.user) {
+ if (Clerk.isSignedIn) {


For applications that don't have pending sessions, checking Clerk.user will still be the same as Clerk.isSignedIn, correct ?

Correct! We'll start replacing Clerk.user for custom flow branches of logic to keep it scalable for both active/pending - the following will be applied to our docs especially

LauraBeatris · 2025-02-18T11:44:11Z

Actually closing this one, realized that it's not super necessary as right now Clerk.user still gets resolved even when Clerk.isSignedIn is true

It'd just be required to replace it we were explicitly checking for session.status === 'active'

LauraBeatris · 2025-02-17T18:44:56Z

Description

Blocked by #5136 - waiting to be deployed (currently stacked branch)

Instead of relying on the Clerk.user to determine whether to mount elements for a custom sign-in flow, use the newest Clerk.isSignedIn

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2025-02-17T18:45:01Z

⚠️ No Changeset found

Latest commit: 8b46b36

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-02-17T18:45:02Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
clerk-js-sandbox	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 17, 2025 6:50pm

panteliselef · 2025-02-17T20:22:05Z

 const controlStateEl = document.querySelector('#user-state');

- if (Clerk.user) {
+ if (Clerk.isSignedIn) {


For applications that don't have pending sessions, checking Clerk.user will still be the same as Clerk.isSignedIn, correct ?

Correct! We'll start replacing Clerk.user for custom flow branches of logic to keep it scalable for both active/pending - the following will be applied to our docs especially

LauraBeatris · 2025-02-18T11:44:11Z

Actually closing this one, realized that it's not super necessary as right now Clerk.user still gets resolved even when Clerk.isSignedIn is true

It'd just be required to replace it we were explicitly checking for session.status === 'active'

LauraBeatris · 2025-02-17T18:44:56Z

Description

Blocked by #5136 - waiting to be deployed (currently stacked branch)

Instead of relying on the Clerk.user to determine whether to mount elements for a custom sign-in flow, use the newest Clerk.isSignedIn

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2025-02-17T18:45:01Z

⚠️ No Changeset found

Latest commit: 8b46b36

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-02-17T18:45:02Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
clerk-js-sandbox	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 17, 2025 6:50pm

panteliselef · 2025-02-17T20:22:05Z

 const controlStateEl = document.querySelector('#user-state');

- if (Clerk.user) {
+ if (Clerk.isSignedIn) {


For applications that don't have pending sessions, checking Clerk.user will still be the same as Clerk.isSignedIn, correct ?

Correct! We'll start replacing Clerk.user for custom flow branches of logic to keep it scalable for both active/pending - the following will be applied to our docs especially

LauraBeatris · 2025-02-18T11:44:11Z

Actually closing this one, realized that it's not super necessary as right now Clerk.user still gets resolved even when Clerk.isSignedIn is true

It'd just be required to replace it we were explicitly checking for session.status === 'active'

LauraBeatris · 2025-02-17T18:44:56Z

Description

Blocked by #5136 - waiting to be deployed (currently stacked branch)

Instead of relying on the Clerk.user to determine whether to mount elements for a custom sign-in flow, use the newest Clerk.isSignedIn

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2025-02-17T18:45:01Z

⚠️ No Changeset found

Latest commit: 8b46b36

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-02-17T18:45:02Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
clerk-js-sandbox	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 17, 2025 6:50pm

panteliselef · 2025-02-17T20:22:05Z

 const controlStateEl = document.querySelector('#user-state');

- if (Clerk.user) {
+ if (Clerk.isSignedIn) {


For applications that don't have pending sessions, checking Clerk.user will still be the same as Clerk.isSignedIn, correct ?

Correct! We'll start replacing Clerk.user for custom flow branches of logic to keep it scalable for both active/pending - the following will be applied to our docs especially

LauraBeatris · 2025-02-18T11:44:11Z

Actually closing this one, realized that it's not super necessary as right now Clerk.user still gets resolved even when Clerk.isSignedIn is true

It'd just be required to replace it we were explicitly checking for session.status === 'active'

LauraBeatris added 14 commits February 17, 2025 14:04

Add pending to SessionStatus union
35b3500

Plug pending session into main Client resource
f370173

Add test coverage for pending and active statuses
479672b

Update handshake tests
3445ca3

Update device section to list for pending
f978659

Fix sign in account switcher to look for pending sessions
c7d8701

Consider pending as authenticate state for client UAT
2bc7f70

Save JWT token on Expo for pending session status
7eb312c

Add isAuthenticated property to main Clerk instance
fe3d655

Update SignIn.SessionList to include pending sessions
265c274

Deprecate activeSessions
8a06daf

Add changeset
a5528d7

Introduce separate changesets
aa5eec7

Refactor from isAuthenticated to isSignedIn
add3313

LauraBeatris self-assigned this Feb 17, 2025

clerk-cookie added playground integration labels Feb 17, 2025

LauraBeatris force-pushed the laura/update-direct-user-access-for-pending branch from 39cfc4e to 3ea079eCompare February 17, 2025 18:46

vercelBotdeployed to Preview February 17, 2025 18:47 View deployment

LauraBeatris force-pushed the laura/update-direct-user-access-for-pending branch from 3ea079e to 546e4a5Compare February 17, 2025 18:48

LauraBeatris changed the title ~~chore(integration): Replace Clerk.user with Clerk.isSignedIn on integration tests~~ chore(repo): Replace Clerk.user with Clerk.isSignedIn on integration tests Feb 17, 2025

vercelBotdeployed to Preview February 17, 2025 18:48 View deployment

Update templates/playgrounds to look for Clerk.isSignedIn
8b46b36

LauraBeatris force-pushed the laura/update-direct-user-access-for-pending branch from 546e4a5 to 8b46b36Compare February 17, 2025 18:49

vercelBotdeployed to Preview February 17, 2025 18:50 View deployment

panteliselef reviewed Feb 17, 2025
View reviewed changes

LauraBeatris force-pushed the laura/orgs-544-sdk-handle-pending-session-status-as-authenticated branch from b503280 to bb1b736Compare February 18, 2025 11:23

LauraBeatris closed this Feb 18, 2025