feat(clerk-js,types): Navigate to session task on after sign-in/sign-up - #5187

Closed
LauraBeatris wants to merge 21 commits into
mainfrom
laura/tasks-sign-sign-up-routes
Closed

feat(clerk-js,types): Navigate to session task on after sign-in/sign-up#5187
LauraBeatris wants to merge 21 commits into
mainfrom
laura/tasks-sign-sign-up-routes

Conversation

@LauraBeatris

@LauraBeatrisLauraBeatris commented Feb 17, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Resolves ORGS-562

This PR introduces the redirection behavior after sign-in/sign-up if the session has pending tasks to be solved.

  • Displays the current pending session task as SignIn/SignUp routes
  • Introduce navigation to tasks after sign-in/sign-up

Developer flows

For AIO components, it'll work out of the box. Just rendering <SignIn /> and <SignUp /> will work, since the task gets appended to the routing path and displayed within each component.

For custom flows, no manual changes are needed to trigger navigation, however, the developer has to handle rendering the respective component on the task route, such as OrganizationSwitcher

The next PR will introduce a custom URL for customing the task route path to eject out of AIO components, eg: Instead of sign-in/select-organization - onboarding/select-organization

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@LauraBeatrisLauraBeatris self-assigned this Feb 17, 2025
@changeset-bot

changeset-botBot commented Feb 17, 2025•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: be6c67e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
NameType
@clerk/clerk-jsPatch
@clerk/typesPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/uiPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Feb 17, 2025•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackMar 4, 2025 1:37pm

@LauraBeatrisLauraBeatris changed the title [wip] feat(clerk-js): Display pending tasks on SignIn/SignUp[wip] chore(clerk-js): Display pending tasks on SignIn/SignUpFeb 17, 2025
@LauraBeatris
LauraBeatrisforce-pushed the introduce-session-tasks-types branch from e2e02ec to aa2c20aCompareFebruary 18, 2025 16:26
Base automatically changed from introduce-session-tasks-types to mainFebruary 18, 2025 16:35
@LauraBeatris
LauraBeatrisforce-pushed the laura/tasks-sign-sign-up-routes branch from 59a2b22 to e836ee1CompareFebruary 18, 2025 16:39
@LauraBeatris
LauraBeatrisforce-pushed the laura/tasks-sign-sign-up-routes branch from 62a62ae to 639e7f8CompareFebruary 18, 2025 21:13
@LauraBeatris
LauraBeatrisforce-pushed the laura/tasks-sign-sign-up-routes branch from 755c683 to 4a6e892CompareFebruary 18, 2025 22:45
@LauraBeatris
LauraBeatrisforce-pushed the laura/tasks-sign-sign-up-routes branch from 4a6e892 to a1c1c39CompareFebruary 18, 2025 23:26
@LauraBeatris
LauraBeatrisforce-pushed the laura/tasks-sign-sign-up-routes branch 2 times, most recently from d27d8c9 to 104791bCompareFebruary 18, 2025 23:31
@LauraBeatris
LauraBeatrisforce-pushed the laura/tasks-sign-sign-up-routes branch from 104791b to 48191f1CompareFebruary 19, 2025 01:21
@LauraBeatris
LauraBeatrisforce-pushed the laura/tasks-sign-sign-up-routes branch from 48191f1 to d74f3e7CompareFebruary 19, 2025 01:28
LauraBeatris
LauraBeatris commented Feb 19, 2025
View reviewed changes
Comment threadpackages/types/src/session.ts
}

export interface SessionTask {
key: 'orgs';

@LauraBeatrisLauraBeatrisFeb 19, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FAPI was previously returning orgs but it got updated to org

@LauraBeatris
LauraBeatrisforce-pushed the laura/tasks-sign-sign-up-routes branch from d74f3e7 to 08a8affCompareFebruary 19, 2025 01:32
@LauraBeatris
LauraBeatrisforce-pushed the laura/tasks-sign-sign-up-routes branch from 3032ea7 to 4a59b37CompareFebruary 20, 2025 20:43
@LauraBeatris
LauraBeatrisforce-pushed the laura/tasks-sign-sign-up-routes branch from 4a59b37 to 1120aa0CompareFebruary 20, 2025 21:26
panteliselef
panteliselef reviewed Feb 21, 2025
View reviewed changes
Comment threadpackages/types/src/session.ts

export interface SessionTask {
key: 'orgs';
key: 'org';

@panteliselefpanteliselefFeb 21, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is scope a better name ? or does key represent something else ?

@LauraBeatris
Add tasks on Session resource
6622e0a
@LauraBeatris
Add changeset
7d2d43d
@LauraBeatris
Update redirect guard to explict check for active
d4f072e
Previously, all session statuses were leading to a redirect to after sign-in URL
Now, when the session gets set with a `pending` status, it won't redirect to after sign in URL, but
instead display the pending task route
@LauraBeatris
Display pending task routes
e307f3a
@LauraBeatris
Update handling for array of tasks
0d0a717
@LauraBeatris
Fix session task key
f44a7ec
@LauraBeatris
Implement unit tests for Task component
43beb76
@LauraBeatris
Add unit tests for useTaskRoute
46fe2b8
@LauraBeatris
Add option for a custom tasks URL to cover custom flow
9234c79
@LauraBeatris
Refactor redirect guards for tasks
d38dbbc
@LauraBeatris
Does not trigger redirectUrl logic
1dc30d5
@LauraBeatris
Trigger navigation on client-piggybacking
36e0c91
@LauraBeatris
Set tasks URL on the sign-in/sign-up context
f1e64f1
@LauraBeatris
Introduce separate redirect guards for tasks
9a5415d
@LauraBeatris
Add unit test for redirection to task
1233d3b
@LauraBeatris
Introduce skeleton for integration tests
e15d124
LauraBeatris
LauraBeatris commented Feb 25, 2025
View reviewed changes
Comment threadintegration/tests/session-tasks.test.ts Outdated
import { testAgainstRunningApps } from '../testUtils';

// TODO ORGS-566 - write integration tests for after-auth flow
testAgainstRunningApps({ withEnv: [appConfigs.envs.withEmailCodes] })('after-auth flows @generic @nextjs', () => {

@LauraBeatrisLauraBeatrisFeb 25, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a placeholder for me to come back later which is helpful to visualize the redirection behavior introduced in this PR

The reason integration tests aren't being implemented is that FAPI changes for that are under development and it could break CI

@LauraBeatrisLauraBeatris mentioned this pull request Feb 28, 2025
Closed
9 tasks
@LauraBeatris

LauraBeatris commented Mar 4, 2025

Copy link
Copy Markdown
ContributorAuthor

I'm opening another PR for this as it became stale and I want to validate other approaches for in-component navigation

@LauraBeatris

LauraBeatris commented Mar 4, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

#5280

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@octoperoctoperAwaiting requested review from octoper
@brkalowbrkalowAwaiting requested review from brkalow
1 more reviewer
@panteliselefpanteliselefpanteliselef left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@LauraBeatrisLauraBeatris

Labels

clerk-jsintegrationtypes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@panteliselef@clerk-cookie
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat(clerk-js,types): Navigate to session task on after sign-in/sign-up - #5187
Closed
LauraBeatris wants to merge 21 commits into
mainfrom 
laura/tasks-sign-sign-up-routes
Closed
feat(clerk-js,types): Navigate to session task on after sign-in/sign-up#5187
LauraBeatris wants to merge 21 commits into
mainfrom 
laura/tasks-sign-sign-up-routes
Conversation
@LauraBeatris
@LauraBeatrisLauraBeatris
commented
Feb 17, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Resolves ORGS-562
This PR introduces the redirection behavior after sign-in/sign-up if the session has pending tasks to be solved.
  • Displays the current pending session task as SignIn/SignUp routes
  • Introduce navigation to tasks after sign-in/sign-up
Developer flows
For AIO components, it'll work out of the box. Just rendering <SignIn /> and <SignUp /> will work, since the task gets appended to the routing path and displayed within each component.
For custom flows, no manual changes are needed to trigger navigation, however, the developer has to handle rendering the respective component on the task route, such as OrganizationSwitcher
The next PR will introduce a custom URL for customing the task route path to eject out of AIO components, eg: Instead of sign-in/select-organization - onboarding/select-organization
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@LauraBeatrisLauraBeatris
self-assigned this
Feb 17, 2025
@changeset-bot
changeset-botBot
commented
Feb 17, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: be6c67e
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 23 packages
NameType
@clerk/clerk-jsPatch
@clerk/typesPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/uiPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Feb 17, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackMar 4, 2025 1:37pm
@LauraBeatrisLauraBeatris
changed the title
[wip] feat(clerk-js): Display pending tasks on SignIn/SignUp[wip] chore(clerk-js): Display pending tasks on SignIn/SignUpFeb 17, 2025
@LauraBeatris
LauraBeatrisforce-pushed
the
introduce-session-tasks-types
branch
from
e2e02ec to
aa2c20aCompareFebruary 18, 2025 16:26

Base automatically changed from
introduce-session-tasks-types to
mainFebruary 18, 2025 16:35
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
59a2b22 to
e836ee1CompareFebruary 18, 2025 16:39
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
62a62ae to
639e7f8CompareFebruary 18, 2025 21:13
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
755c683 to
4a6e892CompareFebruary 18, 2025 22:45
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
4a6e892 to
a1c1c39CompareFebruary 18, 2025 23:26
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
2 times, most recently
from
d27d8c9 to
104791bCompareFebruary 18, 2025 23:31
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
104791b to
48191f1CompareFebruary 19, 2025 01:21
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
48191f1 to
d74f3e7CompareFebruary 19, 2025 01:28
LauraBeatris
LauraBeatris
commented
Feb 19, 2025
View reviewed changes
Comment threadpackages/types/src/session.ts
}

export interface SessionTask {
 key: 'orgs';
@LauraBeatrisLauraBeatrisFeb 19, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FAPI was previously returning orgs but it got updated to org
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
d74f3e7 to
08a8affCompareFebruary 19, 2025 01:32
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
3032ea7 to
4a59b37CompareFebruary 20, 2025 20:43
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
4a59b37 to
1120aa0CompareFebruary 20, 2025 21:26
panteliselef
panteliselef
reviewed
Feb 21, 2025
View reviewed changes
Comment threadpackages/types/src/session.ts

export interface SessionTask {
 key: 'orgs';
 key: 'org';
@panteliselefpanteliselefFeb 21, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is scope a better name ? or does key represent something else ?
@LauraBeatris
Add tasks on Session resource
6622e0a
@LauraBeatris
Add changeset
7d2d43d
@LauraBeatris
Update redirect guard to explict check for active
d4f072e
Previously, all session statuses were leading to a redirect to after sign-in URL
Now, when the session gets set with a `pending` status, it won't redirect to after sign in URL, but
instead display the pending task route
@LauraBeatris
Display pending task routes
e307f3a
@LauraBeatris
Update handling for array of tasks
0d0a717
@LauraBeatris
Fix session task key
f44a7ec
@LauraBeatris
Implement unit tests for Task component
43beb76
@LauraBeatris
Add unit tests for useTaskRoute
46fe2b8
@LauraBeatris
Add option for a custom tasks URL to cover custom flow
9234c79
@LauraBeatris
Refactor redirect guards for tasks
d38dbbc
@LauraBeatris
Does not trigger redirectUrl logic
1dc30d5
@LauraBeatris
Trigger navigation on client-piggybacking
36e0c91
@LauraBeatris
Set tasks URL on the sign-in/sign-up context
f1e64f1
@LauraBeatris
Introduce separate redirect guards for tasks
9a5415d
@LauraBeatris
Add unit test for redirection to task
1233d3b
@LauraBeatris
Introduce skeleton for integration tests
e15d124
LauraBeatris
LauraBeatris
commented
Feb 25, 2025
View reviewed changes
Comment threadintegration/tests/session-tasks.test.ts
Outdated

import { testAgainstRunningApps } from '../testUtils';

// TODO ORGS-566 - write integration tests for after-auth flow
testAgainstRunningApps({ withEnv: [appConfigs.envs.withEmailCodes] })('after-auth flows @generic @nextjs', () => {
@LauraBeatrisLauraBeatrisFeb 25, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a placeholder for me to come back later which is helpful to visualize the redirection behavior introduced in this PR
The reason integration tests aren't being implemented is that FAPI changes for that are under development and it could break CI
@LauraBeatrisLauraBeatris
mentioned this pull request
Feb 28, 2025
 Closed

9 tasks
@LauraBeatris
LauraBeatris
commented
Mar 4, 2025

Copy link


Copy Markdown

ContributorAuthor
I'm opening another PR for this as it became stale and I want to validate other approaches for in-component navigation
@LauraBeatris
LauraBeatris
commented
Mar 4, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
#5280
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@octoperoctoperAwaiting requested review from octoper
@brkalowbrkalowAwaiting requested review from brkalow

1 more reviewer

@panteliselefpanteliselefpanteliselef left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@LauraBeatrisLauraBeatris

Labels

clerk-jsintegrationtypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@panteliselef@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(clerk-js,types): Navigate to session task on after sign-in/sign-up - #5187
Closed
LauraBeatris wants to merge 21 commits into
mainfrom 
laura/tasks-sign-sign-up-routes
Closed
feat(clerk-js,types): Navigate to session task on after sign-in/sign-up#5187
LauraBeatris wants to merge 21 commits into
mainfrom 
laura/tasks-sign-sign-up-routes
Conversation
@LauraBeatris
@LauraBeatrisLauraBeatris
commented
Feb 17, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Resolves ORGS-562
This PR introduces the redirection behavior after sign-in/sign-up if the session has pending tasks to be solved.
  • Displays the current pending session task as SignIn/SignUp routes
  • Introduce navigation to tasks after sign-in/sign-up
Developer flows
For AIO components, it'll work out of the box. Just rendering <SignIn /> and <SignUp /> will work, since the task gets appended to the routing path and displayed within each component.
For custom flows, no manual changes are needed to trigger navigation, however, the developer has to handle rendering the respective component on the task route, such as OrganizationSwitcher
The next PR will introduce a custom URL for customing the task route path to eject out of AIO components, eg: Instead of sign-in/select-organization - onboarding/select-organization
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@LauraBeatrisLauraBeatris
self-assigned this
Feb 17, 2025
@changeset-bot
changeset-botBot
commented
Feb 17, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: be6c67e
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 23 packages
NameType
@clerk/clerk-jsPatch
@clerk/typesPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/uiPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Feb 17, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackMar 4, 2025 1:37pm
@LauraBeatrisLauraBeatris
changed the title
[wip] feat(clerk-js): Display pending tasks on SignIn/SignUp[wip] chore(clerk-js): Display pending tasks on SignIn/SignUpFeb 17, 2025
@LauraBeatris
LauraBeatrisforce-pushed
the
introduce-session-tasks-types
branch
from
e2e02ec to
aa2c20aCompareFebruary 18, 2025 16:26

Base automatically changed from
introduce-session-tasks-types to
mainFebruary 18, 2025 16:35
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
59a2b22 to
e836ee1CompareFebruary 18, 2025 16:39
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
62a62ae to
639e7f8CompareFebruary 18, 2025 21:13
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
755c683 to
4a6e892CompareFebruary 18, 2025 22:45
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
4a6e892 to
a1c1c39CompareFebruary 18, 2025 23:26
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
2 times, most recently
from
d27d8c9 to
104791bCompareFebruary 18, 2025 23:31
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
104791b to
48191f1CompareFebruary 19, 2025 01:21
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
48191f1 to
d74f3e7CompareFebruary 19, 2025 01:28
LauraBeatris
LauraBeatris
commented
Feb 19, 2025
View reviewed changes
Comment threadpackages/types/src/session.ts
}

export interface SessionTask {
 key: 'orgs';
@LauraBeatrisLauraBeatrisFeb 19, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FAPI was previously returning orgs but it got updated to org
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
d74f3e7 to
08a8affCompareFebruary 19, 2025 01:32
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
3032ea7 to
4a59b37CompareFebruary 20, 2025 20:43
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
4a59b37 to
1120aa0CompareFebruary 20, 2025 21:26
panteliselef
panteliselef
reviewed
Feb 21, 2025
View reviewed changes
Comment threadpackages/types/src/session.ts

export interface SessionTask {
 key: 'orgs';
 key: 'org';
@panteliselefpanteliselefFeb 21, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is scope a better name ? or does key represent something else ?
@LauraBeatris
Add tasks on Session resource
6622e0a
@LauraBeatris
Add changeset
7d2d43d
@LauraBeatris
Update redirect guard to explict check for active
d4f072e
Previously, all session statuses were leading to a redirect to after sign-in URL
Now, when the session gets set with a `pending` status, it won't redirect to after sign in URL, but
instead display the pending task route
@LauraBeatris
Display pending task routes
e307f3a
@LauraBeatris
Update handling for array of tasks
0d0a717
@LauraBeatris
Fix session task key
f44a7ec
@LauraBeatris
Implement unit tests for Task component
43beb76
@LauraBeatris
Add unit tests for useTaskRoute
46fe2b8
@LauraBeatris
Add option for a custom tasks URL to cover custom flow
9234c79
@LauraBeatris
Refactor redirect guards for tasks
d38dbbc
@LauraBeatris
Does not trigger redirectUrl logic
1dc30d5
@LauraBeatris
Trigger navigation on client-piggybacking
36e0c91
@LauraBeatris
Set tasks URL on the sign-in/sign-up context
f1e64f1
@LauraBeatris
Introduce separate redirect guards for tasks
9a5415d
@LauraBeatris
Add unit test for redirection to task
1233d3b
@LauraBeatris
Introduce skeleton for integration tests
e15d124
LauraBeatris
LauraBeatris
commented
Feb 25, 2025
View reviewed changes
Comment threadintegration/tests/session-tasks.test.ts
Outdated

import { testAgainstRunningApps } from '../testUtils';

// TODO ORGS-566 - write integration tests for after-auth flow
testAgainstRunningApps({ withEnv: [appConfigs.envs.withEmailCodes] })('after-auth flows @generic @nextjs', () => {
@LauraBeatrisLauraBeatrisFeb 25, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a placeholder for me to come back later which is helpful to visualize the redirection behavior introduced in this PR
The reason integration tests aren't being implemented is that FAPI changes for that are under development and it could break CI
@LauraBeatrisLauraBeatris
mentioned this pull request
Feb 28, 2025
 Closed

9 tasks
@LauraBeatris
LauraBeatris
commented
Mar 4, 2025

Copy link


Copy Markdown

ContributorAuthor
I'm opening another PR for this as it became stale and I want to validate other approaches for in-component navigation
@LauraBeatris
LauraBeatris
commented
Mar 4, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
#5280
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@octoperoctoperAwaiting requested review from octoper
@brkalowbrkalowAwaiting requested review from brkalow

1 more reviewer

@panteliselefpanteliselefpanteliselef left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@LauraBeatrisLauraBeatris

Labels

clerk-jsintegrationtypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@panteliselef@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(clerk-js,types): Navigate to session task on after sign-in/sign-up - #5187
Closed
LauraBeatris wants to merge 21 commits into
mainfrom 
laura/tasks-sign-sign-up-routes
Closed
feat(clerk-js,types): Navigate to session task on after sign-in/sign-up#5187
LauraBeatris wants to merge 21 commits into
mainfrom 
laura/tasks-sign-sign-up-routes
Conversation
@LauraBeatris
@LauraBeatrisLauraBeatris
commented
Feb 17, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Resolves ORGS-562
This PR introduces the redirection behavior after sign-in/sign-up if the session has pending tasks to be solved.
  • Displays the current pending session task as SignIn/SignUp routes
  • Introduce navigation to tasks after sign-in/sign-up
Developer flows
For AIO components, it'll work out of the box. Just rendering <SignIn /> and <SignUp /> will work, since the task gets appended to the routing path and displayed within each component.
For custom flows, no manual changes are needed to trigger navigation, however, the developer has to handle rendering the respective component on the task route, such as OrganizationSwitcher
The next PR will introduce a custom URL for customing the task route path to eject out of AIO components, eg: Instead of sign-in/select-organization - onboarding/select-organization
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@LauraBeatrisLauraBeatris
self-assigned this
Feb 17, 2025
@changeset-bot
changeset-botBot
commented
Feb 17, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: be6c67e
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 23 packages
NameType
@clerk/clerk-jsPatch
@clerk/typesPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/uiPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Feb 17, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackMar 4, 2025 1:37pm
@LauraBeatrisLauraBeatris
changed the title
[wip] feat(clerk-js): Display pending tasks on SignIn/SignUp[wip] chore(clerk-js): Display pending tasks on SignIn/SignUpFeb 17, 2025
@LauraBeatris
LauraBeatrisforce-pushed
the
introduce-session-tasks-types
branch
from
e2e02ec to
aa2c20aCompareFebruary 18, 2025 16:26

Base automatically changed from
introduce-session-tasks-types to
mainFebruary 18, 2025 16:35
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
59a2b22 to
e836ee1CompareFebruary 18, 2025 16:39
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
62a62ae to
639e7f8CompareFebruary 18, 2025 21:13
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
755c683 to
4a6e892CompareFebruary 18, 2025 22:45
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
4a6e892 to
a1c1c39CompareFebruary 18, 2025 23:26
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
2 times, most recently
from
d27d8c9 to
104791bCompareFebruary 18, 2025 23:31
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
104791b to
48191f1CompareFebruary 19, 2025 01:21
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
48191f1 to
d74f3e7CompareFebruary 19, 2025 01:28
LauraBeatris
LauraBeatris
commented
Feb 19, 2025
View reviewed changes
Comment threadpackages/types/src/session.ts
}

export interface SessionTask {
 key: 'orgs';
@LauraBeatrisLauraBeatrisFeb 19, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FAPI was previously returning orgs but it got updated to org
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
d74f3e7 to
08a8affCompareFebruary 19, 2025 01:32
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
3032ea7 to
4a59b37CompareFebruary 20, 2025 20:43
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
4a59b37 to
1120aa0CompareFebruary 20, 2025 21:26
panteliselef
panteliselef
reviewed
Feb 21, 2025
View reviewed changes
Comment threadpackages/types/src/session.ts

export interface SessionTask {
 key: 'orgs';
 key: 'org';
@panteliselefpanteliselefFeb 21, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is scope a better name ? or does key represent something else ?
@LauraBeatris
Add tasks on Session resource
6622e0a
@LauraBeatris
Add changeset
7d2d43d
@LauraBeatris
Update redirect guard to explict check for active
d4f072e
Previously, all session statuses were leading to a redirect to after sign-in URL
Now, when the session gets set with a `pending` status, it won't redirect to after sign in URL, but
instead display the pending task route
@LauraBeatris
Display pending task routes
e307f3a
@LauraBeatris
Update handling for array of tasks
0d0a717
@LauraBeatris
Fix session task key
f44a7ec
@LauraBeatris
Implement unit tests for Task component
43beb76
@LauraBeatris
Add unit tests for useTaskRoute
46fe2b8
@LauraBeatris
Add option for a custom tasks URL to cover custom flow
9234c79
@LauraBeatris
Refactor redirect guards for tasks
d38dbbc
@LauraBeatris
Does not trigger redirectUrl logic
1dc30d5
@LauraBeatris
Trigger navigation on client-piggybacking
36e0c91
@LauraBeatris
Set tasks URL on the sign-in/sign-up context
f1e64f1
@LauraBeatris
Introduce separate redirect guards for tasks
9a5415d
@LauraBeatris
Add unit test for redirection to task
1233d3b
@LauraBeatris
Introduce skeleton for integration tests
e15d124
LauraBeatris
LauraBeatris
commented
Feb 25, 2025
View reviewed changes
Comment threadintegration/tests/session-tasks.test.ts
Outdated

import { testAgainstRunningApps } from '../testUtils';

// TODO ORGS-566 - write integration tests for after-auth flow
testAgainstRunningApps({ withEnv: [appConfigs.envs.withEmailCodes] })('after-auth flows @generic @nextjs', () => {
@LauraBeatrisLauraBeatrisFeb 25, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a placeholder for me to come back later which is helpful to visualize the redirection behavior introduced in this PR
The reason integration tests aren't being implemented is that FAPI changes for that are under development and it could break CI
@LauraBeatrisLauraBeatris
mentioned this pull request
Feb 28, 2025
 Closed

9 tasks
@LauraBeatris
LauraBeatris
commented
Mar 4, 2025

Copy link


Copy Markdown

ContributorAuthor
I'm opening another PR for this as it became stale and I want to validate other approaches for in-component navigation
@LauraBeatris
LauraBeatris
commented
Mar 4, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
#5280
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@octoperoctoperAwaiting requested review from octoper
@brkalowbrkalowAwaiting requested review from brkalow

1 more reviewer

@panteliselefpanteliselefpanteliselef left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@LauraBeatrisLauraBeatris

Labels

clerk-jsintegrationtypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@panteliselef@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat(clerk-js,types): Navigate to session task on after sign-in/sign-up - #5187
Closed
LauraBeatris wants to merge 21 commits into
mainfrom 
laura/tasks-sign-sign-up-routes
Closed
feat(clerk-js,types): Navigate to session task on after sign-in/sign-up#5187
LauraBeatris wants to merge 21 commits into
mainfrom 
laura/tasks-sign-sign-up-routes
Conversation
@LauraBeatris
@LauraBeatrisLauraBeatris
commented
Feb 17, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Resolves ORGS-562
This PR introduces the redirection behavior after sign-in/sign-up if the session has pending tasks to be solved.
  • Displays the current pending session task as SignIn/SignUp routes
  • Introduce navigation to tasks after sign-in/sign-up
Developer flows
For AIO components, it'll work out of the box. Just rendering <SignIn /> and <SignUp /> will work, since the task gets appended to the routing path and displayed within each component.
For custom flows, no manual changes are needed to trigger navigation, however, the developer has to handle rendering the respective component on the task route, such as OrganizationSwitcher
The next PR will introduce a custom URL for customing the task route path to eject out of AIO components, eg: Instead of sign-in/select-organization - onboarding/select-organization
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@LauraBeatrisLauraBeatris
self-assigned this
Feb 17, 2025
@changeset-bot
changeset-botBot
commented
Feb 17, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: be6c67e
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 23 packages
NameType
@clerk/clerk-jsPatch
@clerk/typesPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/uiPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Feb 17, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackMar 4, 2025 1:37pm
@LauraBeatrisLauraBeatris
changed the title
[wip] feat(clerk-js): Display pending tasks on SignIn/SignUp[wip] chore(clerk-js): Display pending tasks on SignIn/SignUpFeb 17, 2025
@LauraBeatris
LauraBeatrisforce-pushed
the
introduce-session-tasks-types
branch
from
e2e02ec to
aa2c20aCompareFebruary 18, 2025 16:26

Base automatically changed from
introduce-session-tasks-types to
mainFebruary 18, 2025 16:35
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
59a2b22 to
e836ee1CompareFebruary 18, 2025 16:39
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
62a62ae to
639e7f8CompareFebruary 18, 2025 21:13
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
755c683 to
4a6e892CompareFebruary 18, 2025 22:45
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
4a6e892 to
a1c1c39CompareFebruary 18, 2025 23:26
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
2 times, most recently
from
d27d8c9 to
104791bCompareFebruary 18, 2025 23:31
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
104791b to
48191f1CompareFebruary 19, 2025 01:21
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
48191f1 to
d74f3e7CompareFebruary 19, 2025 01:28
LauraBeatris
LauraBeatris
commented
Feb 19, 2025
View reviewed changes
Comment threadpackages/types/src/session.ts
}

export interface SessionTask {
 key: 'orgs';
@LauraBeatrisLauraBeatrisFeb 19, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FAPI was previously returning orgs but it got updated to org
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
d74f3e7 to
08a8affCompareFebruary 19, 2025 01:32
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
3032ea7 to
4a59b37CompareFebruary 20, 2025 20:43
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
4a59b37 to
1120aa0CompareFebruary 20, 2025 21:26
panteliselef
panteliselef
reviewed
Feb 21, 2025
View reviewed changes
Comment threadpackages/types/src/session.ts

export interface SessionTask {
 key: 'orgs';
 key: 'org';
@panteliselefpanteliselefFeb 21, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is scope a better name ? or does key represent something else ?
@LauraBeatris
Add tasks on Session resource
6622e0a
@LauraBeatris
Add changeset
7d2d43d
@LauraBeatris
Update redirect guard to explict check for active
d4f072e
Previously, all session statuses were leading to a redirect to after sign-in URL
Now, when the session gets set with a `pending` status, it won't redirect to after sign in URL, but
instead display the pending task route
@LauraBeatris
Display pending task routes
e307f3a
@LauraBeatris
Update handling for array of tasks
0d0a717
@LauraBeatris
Fix session task key
f44a7ec
@LauraBeatris
Implement unit tests for Task component
43beb76
@LauraBeatris
Add unit tests for useTaskRoute
46fe2b8
@LauraBeatris
Add option for a custom tasks URL to cover custom flow
9234c79
@LauraBeatris
Refactor redirect guards for tasks
d38dbbc
@LauraBeatris
Does not trigger redirectUrl logic
1dc30d5
@LauraBeatris
Trigger navigation on client-piggybacking
36e0c91
@LauraBeatris
Set tasks URL on the sign-in/sign-up context
f1e64f1
@LauraBeatris
Introduce separate redirect guards for tasks
9a5415d
@LauraBeatris
Add unit test for redirection to task
1233d3b
@LauraBeatris
Introduce skeleton for integration tests
e15d124
LauraBeatris
LauraBeatris
commented
Feb 25, 2025
View reviewed changes
Comment threadintegration/tests/session-tasks.test.ts
Outdated

import { testAgainstRunningApps } from '../testUtils';

// TODO ORGS-566 - write integration tests for after-auth flow
testAgainstRunningApps({ withEnv: [appConfigs.envs.withEmailCodes] })('after-auth flows @generic @nextjs', () => {
@LauraBeatrisLauraBeatrisFeb 25, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a placeholder for me to come back later which is helpful to visualize the redirection behavior introduced in this PR
The reason integration tests aren't being implemented is that FAPI changes for that are under development and it could break CI
@LauraBeatrisLauraBeatris
mentioned this pull request
Feb 28, 2025
 Closed

9 tasks
@LauraBeatris
LauraBeatris
commented
Mar 4, 2025

Copy link


Copy Markdown

ContributorAuthor
I'm opening another PR for this as it became stale and I want to validate other approaches for in-component navigation
@LauraBeatris
LauraBeatris
commented
Mar 4, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
#5280
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@octoperoctoperAwaiting requested review from octoper
@brkalowbrkalowAwaiting requested review from brkalow

1 more reviewer

@panteliselefpanteliselefpanteliselef left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@LauraBeatrisLauraBeatris

Labels

clerk-jsintegrationtypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@panteliselef@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(clerk-js,types): Navigate to session task on after sign-in/sign-up - #5187
Closed
LauraBeatris wants to merge 21 commits into
mainfrom 
laura/tasks-sign-sign-up-routes
Closed
feat(clerk-js,types): Navigate to session task on after sign-in/sign-up#5187
LauraBeatris wants to merge 21 commits into
mainfrom 
laura/tasks-sign-sign-up-routes
Conversation
@LauraBeatris
@LauraBeatrisLauraBeatris
commented
Feb 17, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Resolves ORGS-562
This PR introduces the redirection behavior after sign-in/sign-up if the session has pending tasks to be solved.
  • Displays the current pending session task as SignIn/SignUp routes
  • Introduce navigation to tasks after sign-in/sign-up
Developer flows
For AIO components, it'll work out of the box. Just rendering <SignIn /> and <SignUp /> will work, since the task gets appended to the routing path and displayed within each component.
For custom flows, no manual changes are needed to trigger navigation, however, the developer has to handle rendering the respective component on the task route, such as OrganizationSwitcher
The next PR will introduce a custom URL for customing the task route path to eject out of AIO components, eg: Instead of sign-in/select-organization - onboarding/select-organization
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@LauraBeatrisLauraBeatris
self-assigned this
Feb 17, 2025
@changeset-bot
changeset-botBot
commented
Feb 17, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: be6c67e
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 23 packages
NameType
@clerk/clerk-jsPatch
@clerk/typesPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/uiPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Feb 17, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackMar 4, 2025 1:37pm
@LauraBeatrisLauraBeatris
changed the title
[wip] feat(clerk-js): Display pending tasks on SignIn/SignUp[wip] chore(clerk-js): Display pending tasks on SignIn/SignUpFeb 17, 2025
@LauraBeatris
LauraBeatrisforce-pushed
the
introduce-session-tasks-types
branch
from
e2e02ec to
aa2c20aCompareFebruary 18, 2025 16:26

Base automatically changed from
introduce-session-tasks-types to
mainFebruary 18, 2025 16:35
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
59a2b22 to
e836ee1CompareFebruary 18, 2025 16:39
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
62a62ae to
639e7f8CompareFebruary 18, 2025 21:13
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
755c683 to
4a6e892CompareFebruary 18, 2025 22:45
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
4a6e892 to
a1c1c39CompareFebruary 18, 2025 23:26
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
2 times, most recently
from
d27d8c9 to
104791bCompareFebruary 18, 2025 23:31
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
104791b to
48191f1CompareFebruary 19, 2025 01:21
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
48191f1 to
d74f3e7CompareFebruary 19, 2025 01:28
LauraBeatris
LauraBeatris
commented
Feb 19, 2025
View reviewed changes
Comment threadpackages/types/src/session.ts
}

export interface SessionTask {
 key: 'orgs';
@LauraBeatrisLauraBeatrisFeb 19, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FAPI was previously returning orgs but it got updated to org
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
d74f3e7 to
08a8affCompareFebruary 19, 2025 01:32
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
3032ea7 to
4a59b37CompareFebruary 20, 2025 20:43
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
4a59b37 to
1120aa0CompareFebruary 20, 2025 21:26
panteliselef
panteliselef
reviewed
Feb 21, 2025
View reviewed changes
Comment threadpackages/types/src/session.ts

export interface SessionTask {
 key: 'orgs';
 key: 'org';
@panteliselefpanteliselefFeb 21, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is scope a better name ? or does key represent something else ?
@LauraBeatris
Add tasks on Session resource
6622e0a
@LauraBeatris
Add changeset
7d2d43d
@LauraBeatris
Update redirect guard to explict check for active
d4f072e
Previously, all session statuses were leading to a redirect to after sign-in URL
Now, when the session gets set with a `pending` status, it won't redirect to after sign in URL, but
instead display the pending task route
@LauraBeatris
Display pending task routes
e307f3a
@LauraBeatris
Update handling for array of tasks
0d0a717
@LauraBeatris
Fix session task key
f44a7ec
@LauraBeatris
Implement unit tests for Task component
43beb76
@LauraBeatris
Add unit tests for useTaskRoute
46fe2b8
@LauraBeatris
Add option for a custom tasks URL to cover custom flow
9234c79
@LauraBeatris
Refactor redirect guards for tasks
d38dbbc
@LauraBeatris
Does not trigger redirectUrl logic
1dc30d5
@LauraBeatris
Trigger navigation on client-piggybacking
36e0c91
@LauraBeatris
Set tasks URL on the sign-in/sign-up context
f1e64f1
@LauraBeatris
Introduce separate redirect guards for tasks
9a5415d
@LauraBeatris
Add unit test for redirection to task
1233d3b
@LauraBeatris
Introduce skeleton for integration tests
e15d124
LauraBeatris
LauraBeatris
commented
Feb 25, 2025
View reviewed changes
Comment threadintegration/tests/session-tasks.test.ts
Outdated

import { testAgainstRunningApps } from '../testUtils';

// TODO ORGS-566 - write integration tests for after-auth flow
testAgainstRunningApps({ withEnv: [appConfigs.envs.withEmailCodes] })('after-auth flows @generic @nextjs', () => {
@LauraBeatrisLauraBeatrisFeb 25, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a placeholder for me to come back later which is helpful to visualize the redirection behavior introduced in this PR
The reason integration tests aren't being implemented is that FAPI changes for that are under development and it could break CI
@LauraBeatrisLauraBeatris
mentioned this pull request
Feb 28, 2025
 Closed

9 tasks
@LauraBeatris
LauraBeatris
commented
Mar 4, 2025

Copy link


Copy Markdown

ContributorAuthor
I'm opening another PR for this as it became stale and I want to validate other approaches for in-component navigation
@LauraBeatris
LauraBeatris
commented
Mar 4, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
#5280
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@octoperoctoperAwaiting requested review from octoper
@brkalowbrkalowAwaiting requested review from brkalow

1 more reviewer

@panteliselefpanteliselefpanteliselef left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@LauraBeatrisLauraBeatris

Labels

clerk-jsintegrationtypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@panteliselef@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(clerk-js,types): Navigate to session task on after sign-in/sign-up - #5187
Closed
LauraBeatris wants to merge 21 commits into
mainfrom 
laura/tasks-sign-sign-up-routes
Closed
feat(clerk-js,types): Navigate to session task on after sign-in/sign-up#5187
LauraBeatris wants to merge 21 commits into
mainfrom 
laura/tasks-sign-sign-up-routes
Conversation
@LauraBeatris
@LauraBeatrisLauraBeatris
commented
Feb 17, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Resolves ORGS-562
This PR introduces the redirection behavior after sign-in/sign-up if the session has pending tasks to be solved.
  • Displays the current pending session task as SignIn/SignUp routes
  • Introduce navigation to tasks after sign-in/sign-up
Developer flows
For AIO components, it'll work out of the box. Just rendering <SignIn /> and <SignUp /> will work, since the task gets appended to the routing path and displayed within each component.
For custom flows, no manual changes are needed to trigger navigation, however, the developer has to handle rendering the respective component on the task route, such as OrganizationSwitcher
The next PR will introduce a custom URL for customing the task route path to eject out of AIO components, eg: Instead of sign-in/select-organization - onboarding/select-organization
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@LauraBeatrisLauraBeatris
self-assigned this
Feb 17, 2025
@changeset-bot
changeset-botBot
commented
Feb 17, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: be6c67e
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 23 packages
NameType
@clerk/clerk-jsPatch
@clerk/typesPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/uiPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Feb 17, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackMar 4, 2025 1:37pm
@LauraBeatrisLauraBeatris
changed the title
[wip] feat(clerk-js): Display pending tasks on SignIn/SignUp[wip] chore(clerk-js): Display pending tasks on SignIn/SignUpFeb 17, 2025
@LauraBeatris
LauraBeatrisforce-pushed
the
introduce-session-tasks-types
branch
from
e2e02ec to
aa2c20aCompareFebruary 18, 2025 16:26

Base automatically changed from
introduce-session-tasks-types to
mainFebruary 18, 2025 16:35
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
59a2b22 to
e836ee1CompareFebruary 18, 2025 16:39
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
62a62ae to
639e7f8CompareFebruary 18, 2025 21:13
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
755c683 to
4a6e892CompareFebruary 18, 2025 22:45
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
4a6e892 to
a1c1c39CompareFebruary 18, 2025 23:26
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
2 times, most recently
from
d27d8c9 to
104791bCompareFebruary 18, 2025 23:31
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
104791b to
48191f1CompareFebruary 19, 2025 01:21
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
48191f1 to
d74f3e7CompareFebruary 19, 2025 01:28
LauraBeatris
LauraBeatris
commented
Feb 19, 2025
View reviewed changes
Comment threadpackages/types/src/session.ts
}

export interface SessionTask {
 key: 'orgs';
@LauraBeatrisLauraBeatrisFeb 19, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FAPI was previously returning orgs but it got updated to org
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
d74f3e7 to
08a8affCompareFebruary 19, 2025 01:32
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
3032ea7 to
4a59b37CompareFebruary 20, 2025 20:43
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
4a59b37 to
1120aa0CompareFebruary 20, 2025 21:26
panteliselef
panteliselef
reviewed
Feb 21, 2025
View reviewed changes
Comment threadpackages/types/src/session.ts

export interface SessionTask {
 key: 'orgs';
 key: 'org';
@panteliselefpanteliselefFeb 21, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is scope a better name ? or does key represent something else ?
@LauraBeatris
Add tasks on Session resource
6622e0a
@LauraBeatris
Add changeset
7d2d43d
@LauraBeatris
Update redirect guard to explict check for active
d4f072e
Previously, all session statuses were leading to a redirect to after sign-in URL
Now, when the session gets set with a `pending` status, it won't redirect to after sign in URL, but
instead display the pending task route
@LauraBeatris
Display pending task routes
e307f3a
@LauraBeatris
Update handling for array of tasks
0d0a717
@LauraBeatris
Fix session task key
f44a7ec
@LauraBeatris
Implement unit tests for Task component
43beb76
@LauraBeatris
Add unit tests for useTaskRoute
46fe2b8
@LauraBeatris
Add option for a custom tasks URL to cover custom flow
9234c79
@LauraBeatris
Refactor redirect guards for tasks
d38dbbc
@LauraBeatris
Does not trigger redirectUrl logic
1dc30d5
@LauraBeatris
Trigger navigation on client-piggybacking
36e0c91
@LauraBeatris
Set tasks URL on the sign-in/sign-up context
f1e64f1
@LauraBeatris
Introduce separate redirect guards for tasks
9a5415d
@LauraBeatris
Add unit test for redirection to task
1233d3b
@LauraBeatris
Introduce skeleton for integration tests
e15d124
LauraBeatris
LauraBeatris
commented
Feb 25, 2025
View reviewed changes
Comment threadintegration/tests/session-tasks.test.ts
Outdated

import { testAgainstRunningApps } from '../testUtils';

// TODO ORGS-566 - write integration tests for after-auth flow
testAgainstRunningApps({ withEnv: [appConfigs.envs.withEmailCodes] })('after-auth flows @generic @nextjs', () => {
@LauraBeatrisLauraBeatrisFeb 25, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a placeholder for me to come back later which is helpful to visualize the redirection behavior introduced in this PR
The reason integration tests aren't being implemented is that FAPI changes for that are under development and it could break CI
@LauraBeatrisLauraBeatris
mentioned this pull request
Feb 28, 2025
 Closed

9 tasks
@LauraBeatris
LauraBeatris
commented
Mar 4, 2025

Copy link


Copy Markdown

ContributorAuthor
I'm opening another PR for this as it became stale and I want to validate other approaches for in-component navigation
@LauraBeatris
LauraBeatris
commented
Mar 4, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
#5280
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@octoperoctoperAwaiting requested review from octoper
@brkalowbrkalowAwaiting requested review from brkalow

1 more reviewer

@panteliselefpanteliselefpanteliselef left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@LauraBeatrisLauraBeatris

Labels

clerk-jsintegrationtypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@panteliselef@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat(clerk-js,types): Navigate to session task on after sign-in/sign-up - #5187
Closed
LauraBeatris wants to merge 21 commits into
mainfrom 
laura/tasks-sign-sign-up-routes
Closed
feat(clerk-js,types): Navigate to session task on after sign-in/sign-up#5187
LauraBeatris wants to merge 21 commits into
mainfrom 
laura/tasks-sign-sign-up-routes
Conversation
@LauraBeatris
@LauraBeatrisLauraBeatris
commented
Feb 17, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Resolves ORGS-562
This PR introduces the redirection behavior after sign-in/sign-up if the session has pending tasks to be solved.
  • Displays the current pending session task as SignIn/SignUp routes
  • Introduce navigation to tasks after sign-in/sign-up
Developer flows
For AIO components, it'll work out of the box. Just rendering <SignIn /> and <SignUp /> will work, since the task gets appended to the routing path and displayed within each component.
For custom flows, no manual changes are needed to trigger navigation, however, the developer has to handle rendering the respective component on the task route, such as OrganizationSwitcher
The next PR will introduce a custom URL for customing the task route path to eject out of AIO components, eg: Instead of sign-in/select-organization - onboarding/select-organization
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@LauraBeatrisLauraBeatris
self-assigned this
Feb 17, 2025
@changeset-bot
changeset-botBot
commented
Feb 17, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: be6c67e
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 23 packages
NameType
@clerk/clerk-jsPatch
@clerk/typesPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/uiPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Feb 17, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackMar 4, 2025 1:37pm
@LauraBeatrisLauraBeatris
changed the title
[wip] feat(clerk-js): Display pending tasks on SignIn/SignUp[wip] chore(clerk-js): Display pending tasks on SignIn/SignUpFeb 17, 2025
@LauraBeatris
LauraBeatrisforce-pushed
the
introduce-session-tasks-types
branch
from
e2e02ec to
aa2c20aCompareFebruary 18, 2025 16:26

Base automatically changed from
introduce-session-tasks-types to
mainFebruary 18, 2025 16:35
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
59a2b22 to
e836ee1CompareFebruary 18, 2025 16:39
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
62a62ae to
639e7f8CompareFebruary 18, 2025 21:13
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
755c683 to
4a6e892CompareFebruary 18, 2025 22:45
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
4a6e892 to
a1c1c39CompareFebruary 18, 2025 23:26
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
2 times, most recently
from
d27d8c9 to
104791bCompareFebruary 18, 2025 23:31
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
104791b to
48191f1CompareFebruary 19, 2025 01:21
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
48191f1 to
d74f3e7CompareFebruary 19, 2025 01:28
LauraBeatris
LauraBeatris
commented
Feb 19, 2025
View reviewed changes
Comment threadpackages/types/src/session.ts
}

export interface SessionTask {
 key: 'orgs';
@LauraBeatrisLauraBeatrisFeb 19, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FAPI was previously returning orgs but it got updated to org
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
d74f3e7 to
08a8affCompareFebruary 19, 2025 01:32
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
3032ea7 to
4a59b37CompareFebruary 20, 2025 20:43
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/tasks-sign-sign-up-routes
branch
from
4a59b37 to
1120aa0CompareFebruary 20, 2025 21:26
panteliselef
panteliselef
reviewed
Feb 21, 2025
View reviewed changes
Comment threadpackages/types/src/session.ts

export interface SessionTask {
 key: 'orgs';
 key: 'org';
@panteliselefpanteliselefFeb 21, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is scope a better name ? or does key represent something else ?
@LauraBeatris
Add tasks on Session resource
6622e0a
@LauraBeatris
Add changeset
7d2d43d
@LauraBeatris
Update redirect guard to explict check for active
d4f072e
Previously, all session statuses were leading to a redirect to after sign-in URL
Now, when the session gets set with a `pending` status, it won't redirect to after sign in URL, but
instead display the pending task route
@LauraBeatris
Display pending task routes
e307f3a
@LauraBeatris
Update handling for array of tasks
0d0a717
@LauraBeatris
Fix session task key
f44a7ec
@LauraBeatris
Implement unit tests for Task component
43beb76
@LauraBeatris
Add unit tests for useTaskRoute
46fe2b8
@LauraBeatris
Add option for a custom tasks URL to cover custom flow
9234c79
@LauraBeatris
Refactor redirect guards for tasks
d38dbbc
@LauraBeatris
Does not trigger redirectUrl logic
1dc30d5
@LauraBeatris
Trigger navigation on client-piggybacking
36e0c91
@LauraBeatris
Set tasks URL on the sign-in/sign-up context
f1e64f1
@LauraBeatris
Introduce separate redirect guards for tasks
9a5415d
@LauraBeatris
Add unit test for redirection to task
1233d3b
@LauraBeatris
Introduce skeleton for integration tests
e15d124
LauraBeatris
LauraBeatris
commented
Feb 25, 2025
View reviewed changes
Comment threadintegration/tests/session-tasks.test.ts
Outdated

import { testAgainstRunningApps } from '../testUtils';

// TODO ORGS-566 - write integration tests for after-auth flow
testAgainstRunningApps({ withEnv: [appConfigs.envs.withEmailCodes] })('after-auth flows @generic @nextjs', () => {
@LauraBeatrisLauraBeatrisFeb 25, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a placeholder for me to come back later which is helpful to visualize the redirection behavior introduced in this PR
The reason integration tests aren't being implemented is that FAPI changes for that are under development and it could break CI
@LauraBeatrisLauraBeatris
mentioned this pull request
Feb 28, 2025
 Closed

9 tasks
@LauraBeatris
LauraBeatris
commented
Mar 4, 2025

Copy link


Copy Markdown

ContributorAuthor
I'm opening another PR for this as it became stale and I want to validate other approaches for in-component navigation
@LauraBeatris
LauraBeatris
commented
Mar 4, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
#5280
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@octoperoctoperAwaiting requested review from octoper
@brkalowbrkalowAwaiting requested review from brkalow

1 more reviewer

@panteliselefpanteliselefpanteliselef left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@LauraBeatrisLauraBeatris

Labels

clerk-jsintegrationtypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@panteliselef@clerk-cookie