Uh oh!
There was an error while loading. Please reload this page.
fix(nuxt): Resolve duplicated imports warning - #5227
Merged
LekoArts merged 5 commits intoFeb 25, 2025
Conversation
🦋 Changeset detectedLatest commit: 2bcf74a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
wobsoriano
commented
Feb 24, 2025
MemberAuthor
!snapshot |
clerk-cookie
commented
Feb 24, 2025
Collaborator
Hey @wobsoriano - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/agent-toolkit@0.0.4-snapshot.v20250224173645 --save-exact
npm i @clerk/astro@2.3.0-snapshot.v20250224173645 --save-exact
npm i @clerk/backend@1.24.3-snapshot.v20250224173645 --save-exact
npm i @clerk/chrome-extension@2.2.11-snapshot.v20250224173645 --save-exact
npm i @clerk/clerk-js@5.54.0-snapshot.v20250224173645 --save-exact
npm i @clerk/elements@0.23.0-snapshot.v20250224173645 --save-exact
npm i @clerk/clerk-expo@2.8.0-snapshot.v20250224173645 --save-exact
npm i @clerk/expo-passkeys@0.1.22-snapshot.v20250224173645 --save-exact
npm i @clerk/express@1.3.50-snapshot.v20250224173645 --save-exact
npm i @clerk/fastify@2.1.23-snapshot.v20250224173645 --save-exact
npm i @clerk/localizations@3.10.8-snapshot.v20250224173645 --save-exact
npm i @clerk/nextjs@6.12.1-snapshot.v20250224173645 --save-exact
npm i @clerk/nuxt@1.2.1-snapshot.v20250224173645 --save-exact
npm i @clerk/clerk-react@5.24.0-snapshot.v20250224173645 --save-exact
npm i @clerk/react-router@1.1.1-snapshot.v20250224173645 --save-exact
npm i @clerk/remix@4.5.1-snapshot.v20250224173645 --save-exact
npm i @clerk/shared@2.23.0-snapshot.v20250224173645 --save-exact
npm i @clerk/tanstack-start@0.10.1-snapshot.v20250224173645 --save-exact
npm i @clerk/testing@1.4.24-snapshot.v20250224173645 --save-exact
npm i @clerk/themes@2.2.20-snapshot.v20250224173645 --save-exact
npm i @clerk/types@4.47.0-snapshot.v20250224173645 --save-exact
npm i @clerk/ui@0.3.25-snapshot.v20250224173645 --save-exact
npm i @clerk/vue@1.3.0-snapshot.v20250224173645 --save-exact |
wobsoriano
commented
Feb 24, 2025
Comment on lines
+102
to
+105
| addImports({ | ||
| name: 'createRouteMatcher', | ||
| from: resolver.resolve('./runtime/client'), | ||
| }); |
MemberAuthor
There was a problem hiding this comment.
Switched to using addImports (instead of addImportsDir which auto-imports to whole directory) to have more control over the auto-imported functions with a single point of import
LekoArts
approved these changes
Feb 25, 2025
LekoArts
deleted the
rob/eco-435-duplicated-imports-createroutematcher-on-nuxt
branch
February 25, 2025 09:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the duplicated imports warning in the Nuxt module related to the
createRouteMatcherfunction. The issue was caused by usingaddImportsDir, which imported all files in the client folder, including bothindex.tsandrouteMatcher.ts.Before:
After:
fix.mov
Resolves ECO-435
Fixes#5214
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change