Uh oh!
There was an error while loading. Please reload this page.
feat(clerk-js, types): <Drawer /> component - #5337
Merged
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
…vascript into alexcarpenter/commerce-drawer-4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces
<Drawer />component to be used within Commerce components.Drawer
The drawer component is a modal that enters from the right of the screen. Currently when open, we disallow interactions with elements outside of the drawer by using the
outsideElementsInertprop.Default
By default the
<Drawer />uses fixed positioning which will render to fill the viewport height and enter from the right.drawer-pricing-table.mov
Within a modal
There are instances where we need to render a drawer within a modal. To do that, we can make use of the
strategyandportalPropsoptions.drawer-user-button.mov
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change