Uh oh!
There was an error while loading. Please reload this page.
feat(clerk-js,types): Add PaymentSourceRow for displaying payment sources - #5570
Merged
Conversation
🦋 Changeset detectedLatest commit: 1ef5a36 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Comment on lines
+13
to
+40
| sx={{ overflow: 'hidden' }} | ||
| gap={2} | ||
| align='baseline' | ||
| > | ||
| <Icon | ||
| icon={paymentSource.walletType === 'apple_pay' ? ApplePay : CreditCard} | ||
| sx={{ alignSelf: 'center' }} | ||
| /> | ||
| <Text | ||
| sx={t => ({ color: t.colors.$colorText, textTransform: 'capitalize' })} | ||
| truncate | ||
| > | ||
| {paymentSource.paymentMethod === 'card' ? paymentSource.cardType : paymentSource.paymentMethod} | ||
| </Text> | ||
| <Text | ||
| sx={t => ({ color: t.colors.$colorTextSecondary })} | ||
| variant='caption' | ||
| truncate | ||
| > | ||
| {paymentSource.paymentMethod === 'card' ? `⋯ ${paymentSource.last4}` : '-'} | ||
| </Text> | ||
| {paymentSource.isDefault && <Badge localizationKey={localizationKeys('badge__default')} />} | ||
| {paymentSource.status === 'expired' && ( | ||
| <Badge | ||
| colorScheme='danger' | ||
| localizationKey={localizationKeys('badge__expired')} | ||
| /> | ||
| )} |
Member
There was a problem hiding this comment.
We should add descriptors for these elements.
alexcarpenter
approved these changes
Apr 11, 2025
iagodahlem
approved these changes
Apr 11, 2025
PaymentSourceRow for displaying payment sourcesPaymentSourceRow for displaying payment sources
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add component for consistently displaying a payment source row across various Commerce components.
Also makes the checkout form pre-select the default payment source.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change