Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 470
chore(tanstack-react-start): WIP WIP Remove vinxi dependency#5973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Uh oh!
There was an error while loading. Please reload this page.
Closed
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
0c1ed86
chore: Update handler types
wobsoriano 76d48ef
chore: use exported types
wobsoriano 52f99bd
chore: merge headers
wobsoriano c2a9a98
chore: fix merged objects
wobsoriano 5f35627
chore: fix merged objects
wobsoriano 4e5d73b
chore: update tests
wobsoriano 351aed4
chore: update .gitignore
wobsoriano 62c872b
Merge branch 'main' into rob/eco-645-tanstack-devinxi
wobsoriano ce2739c
chore: add changeset
wobsoriano 1c9cf4a
fix conflicts
wobsoriano 573bcc5
chore: remove als dependency for now
wobsoriano 8cae6e5
link actual github issue
wobsoriano d743eba
chore: add tanstack router template
wobsoriano 215b02f
chore: add back ts router turbo entry
wobsoriano d7bf9c9
chore: add tsrouter test
wobsoriano c57e1d6
chore: update to latest ts versions
wobsoriano 94347d2
chore: update changeset
wobsoriano 3569aaf
chore: update changeset
wobsoriano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@clerk/tanstack-react-start': minor | ||
| --- | ||
| Updated minimum required version of `@tanstack/react-start` to 1.121.0 (Devinxi), which removes the need for Vinxi. | ||
| See full migration guide: https://github.com/TanStack/router/discussions/2863#discussioncomment-13104960 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
225 changes: 52 additions & 173 deletions
225 integration/templates/tanstack-react-router/src/routeTree.gen.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,196 +1,75 @@ | ||
| /* prettier-ignore-start */ | ||
| /* eslint-disable */ | ||
| // @ts-nocheck | ||
| // noinspection JSUnusedGlobalSymbols | ||
| // This file is auto-generated by TanStack Router | ||
| // Import Routes | ||
| import { Route as rootRoute } from './routes/__root'; | ||
| import { Route as PostsImport } from './routes/posts'; | ||
| import { Route as LayoutImport } from './routes/_layout'; | ||
| import { Route as IndexImport } from './routes/index'; | ||
| import { Route as PostsIndexImport } from './routes/posts.index'; | ||
| import { Route as PostsPostIdImport } from './routes/posts.$postId'; | ||
| import { Route as LayoutLayout2Import } from './routes/_layout/_layout-2'; | ||
| import { Route as LayoutLayout2LayoutBImport } from './routes/_layout/_layout-2/layout-b'; | ||
| import { Route as LayoutLayout2LayoutAImport } from './routes/_layout/_layout-2/layout-a'; | ||
| // This file was automatically generated by TanStack Router. | ||
| // You should NOT make any changes in this file as it will be overwritten. | ||
| // Additionally, you should also exclude this file from your linter and/or formatter to prevent it from being checked or modified. | ||
| // Create/Update Routes | ||
| const PostsRoute = PostsImport.update({ | ||
| path: '/posts', | ||
| getParentRoute: () => rootRoute, | ||
| } as any); | ||
| import { Route as rootRouteImport } from './routes/__root'; | ||
| import { Route as SignInRouteImport } from './routes/sign-in'; | ||
| import { Route as IndexRouteImport } from './routes/index'; | ||
| const LayoutRoute = LayoutImport.update({ | ||
| id: '/_layout', | ||
| getParentRoute: () => rootRoute, | ||
| const SignInRoute = SignInRouteImport.update({ | ||
| id: '/sign-in', | ||
| path: '/sign-in', | ||
| getParentRoute: () => rootRouteImport, | ||
| } as any); | ||
| const IndexRoute = IndexImport.update({ | ||
| path: '/', | ||
| getParentRoute: () => rootRoute, | ||
| } as any); | ||
| const PostsIndexRoute = PostsIndexImport.update({ | ||
| const IndexRoute = IndexRouteImport.update({ | ||
| id: '/', | ||
| path: '/', | ||
| getParentRoute: () => PostsRoute, | ||
| getParentRoute: () => rootRouteImport, | ||
| } as any); | ||
| const PostsPostIdRoute = PostsPostIdImport.update({ | ||
| path: '/$postId', | ||
| getParentRoute: () => PostsRoute, | ||
| } as any); | ||
| const LayoutLayout2Route = LayoutLayout2Import.update({ | ||
| id: '/_layout-2', | ||
| getParentRoute: () => LayoutRoute, | ||
| } as any); | ||
| const LayoutLayout2LayoutBRoute = LayoutLayout2LayoutBImport.update({ | ||
| path: '/layout-b', | ||
| getParentRoute: () => LayoutLayout2Route, | ||
| } as any); | ||
| const LayoutLayout2LayoutARoute = LayoutLayout2LayoutAImport.update({ | ||
| path: '/layout-a', | ||
| getParentRoute: () => LayoutLayout2Route, | ||
| } as any); | ||
| // Populate the FileRoutesByPath interface | ||
| export interface FileRoutesByFullPath { | ||
| '/': typeof IndexRoute; | ||
| '/sign-in': typeof SignInRoute; | ||
| } | ||
| export interface FileRoutesByTo { | ||
| '/': typeof IndexRoute; | ||
| '/sign-in': typeof SignInRoute; | ||
| } | ||
| export interface FileRoutesById { | ||
| __root__: typeof rootRouteImport; | ||
| '/': typeof IndexRoute; | ||
| '/sign-in': typeof SignInRoute; | ||
| } | ||
| export interface FileRouteTypes { | ||
| fileRoutesByFullPath: FileRoutesByFullPath; | ||
| fullPaths: '/' | '/sign-in'; | ||
| fileRoutesByTo: FileRoutesByTo; | ||
| to: '/' | '/sign-in'; | ||
| id: '__root__' | '/' | '/sign-in'; | ||
| fileRoutesById: FileRoutesById; | ||
| } | ||
| export interface RootRouteChildren { | ||
| IndexRoute: typeof IndexRoute; | ||
| SignInRoute: typeof SignInRoute; | ||
| } | ||
| declare module '@tanstack/react-router' { | ||
| interface FileRoutesByPath { | ||
| '/sign-in': { | ||
| id: '/sign-in'; | ||
| path: '/sign-in'; | ||
| fullPath: '/sign-in'; | ||
| preLoaderRoute: typeof SignInRouteImport; | ||
| parentRoute: typeof rootRouteImport; | ||
| }; | ||
| '/': { | ||
| id: '/'; | ||
| path: '/'; | ||
| fullPath: '/'; | ||
| preLoaderRoute: typeof IndexImport; | ||
| parentRoute: typeof rootRoute; | ||
| }; | ||
| '/_layout': { | ||
| id: '/_layout'; | ||
| path: ''; | ||
| fullPath: ''; | ||
| preLoaderRoute: typeof LayoutImport; | ||
| parentRoute: typeof rootRoute; | ||
| }; | ||
| '/posts': { | ||
| id: '/posts'; | ||
| path: '/posts'; | ||
| fullPath: '/posts'; | ||
| preLoaderRoute: typeof PostsImport; | ||
| parentRoute: typeof rootRoute; | ||
| }; | ||
| '/_layout/_layout-2': { | ||
| id: '/_layout/_layout-2'; | ||
| path: ''; | ||
| fullPath: ''; | ||
| preLoaderRoute: typeof LayoutLayout2Import; | ||
| parentRoute: typeof LayoutImport; | ||
| }; | ||
| '/posts/$postId': { | ||
| id: '/posts/$postId'; | ||
| path: '/$postId'; | ||
| fullPath: '/posts/$postId'; | ||
| preLoaderRoute: typeof PostsPostIdImport; | ||
| parentRoute: typeof PostsImport; | ||
| }; | ||
| '/posts/': { | ||
| id: '/posts/'; | ||
| path: '/'; | ||
| fullPath: '/posts/'; | ||
| preLoaderRoute: typeof PostsIndexImport; | ||
| parentRoute: typeof PostsImport; | ||
| }; | ||
| '/_layout/_layout-2/layout-a': { | ||
| id: '/_layout/_layout-2/layout-a'; | ||
| path: '/layout-a'; | ||
| fullPath: '/layout-a'; | ||
| preLoaderRoute: typeof LayoutLayout2LayoutAImport; | ||
| parentRoute: typeof LayoutLayout2Import; | ||
| }; | ||
| '/_layout/_layout-2/layout-b': { | ||
| id: '/_layout/_layout-2/layout-b'; | ||
| path: '/layout-b'; | ||
| fullPath: '/layout-b'; | ||
| preLoaderRoute: typeof LayoutLayout2LayoutBImport; | ||
| parentRoute: typeof LayoutLayout2Import; | ||
| preLoaderRoute: typeof IndexRouteImport; | ||
| parentRoute: typeof rootRouteImport; | ||
| }; | ||
| } | ||
| } | ||
| // Create and export the route tree | ||
| export const routeTree = rootRoute.addChildren({ | ||
| IndexRoute, | ||
| LayoutRoute: LayoutRoute.addChildren({ | ||
| LayoutLayout2Route: LayoutLayout2Route.addChildren({ | ||
| LayoutLayout2LayoutARoute, | ||
| LayoutLayout2LayoutBRoute, | ||
| }), | ||
| }), | ||
| PostsRoute: PostsRoute.addChildren({ PostsPostIdRoute, PostsIndexRoute }), | ||
| }); | ||
| /* prettier-ignore-end */ | ||
| /* ROUTE_MANIFEST_START | ||
| { | ||
| "routes": { | ||
| "__root__": { | ||
| "filePath": "__root.tsx", | ||
| "children": [ | ||
| "/", | ||
| "/_layout", | ||
| "/posts" | ||
| ] | ||
| }, | ||
| "/": { | ||
| "filePath": "index.tsx" | ||
| }, | ||
| "/_layout": { | ||
| "filePath": "_layout.tsx", | ||
| "children": [ | ||
| "/_layout/_layout-2" | ||
| ] | ||
| }, | ||
| "/posts": { | ||
| "filePath": "posts.tsx", | ||
| "children": [ | ||
| "/posts/$postId", | ||
| "/posts/" | ||
| ] | ||
| }, | ||
| "/_layout/_layout-2": { | ||
| "filePath": "_layout/_layout-2.tsx", | ||
| "parent": "/_layout", | ||
| "children": [ | ||
| "/_layout/_layout-2/layout-a", | ||
| "/_layout/_layout-2/layout-b" | ||
| ] | ||
| }, | ||
| "/posts/$postId": { | ||
| "filePath": "posts.$postId.tsx", | ||
| "parent": "/posts" | ||
| }, | ||
| "/posts/": { | ||
| "filePath": "posts.index.tsx", | ||
| "parent": "/posts" | ||
| }, | ||
| "/_layout/_layout-2/layout-a": { | ||
| "filePath": "_layout/_layout-2/layout-a.tsx", | ||
| "parent": "/_layout/_layout-2" | ||
| }, | ||
| "/_layout/_layout-2/layout-b": { | ||
| "filePath": "_layout/_layout-2/layout-b.tsx", | ||
| "parent": "/_layout/_layout-2" | ||
| } | ||
| } | ||
| } | ||
| ROUTE_MANIFEST_END */ | ||
| const rootRouteChildren: RootRouteChildren = { | ||
| IndexRoute: IndexRoute, | ||
| SignInRoute: SignInRoute, | ||
| }; | ||
| export const routeTree = rootRouteImport._addFileChildren(rootRouteChildren)._addFileTypes<FileRouteTypes>(); |
7 changes: 6 additions & 1 deletion
7 integration/templates/tanstack-react-router/src/routes/__root.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 0 additions & 16 deletions
16 integration/templates/tanstack-react-router/src/routes/_layout.tsx
This file was deleted.
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,14 @@ | ||
| import { defineConfig } from 'vite'; | ||
| import react from '@vitejs/plugin-react'; | ||
| import { TanStackRouterVite } from '@tanstack/router-plugin/vite'; | ||
| import { tanstackRouter } from '@tanstack/router-plugin/vite'; | ||
| // https://vitejs.dev/config/ | ||
| export default defineConfig({ | ||
| plugins: [TanStackRouterVite(), react()], | ||
| plugins: [ | ||
| tanstackRouter({ | ||
| target: 'react', | ||
| autoCodeSplitting: true, | ||
| }), | ||
| react(), | ||
| ], | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Fix comment syntax on
/public/buildentry.The line
will be treated as a literal path pattern rather than an ignore plus comment. Gitignore comments must start the line or be preceded by whitespace. Update to:
📝 Committable suggestion
🤖 Prompt for AI Agents