fix(clerk-react): Initialize isomorphic clerk with useRef - #6024

Merged
panteliselef merged 4 commits into
mainfrom
elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across
May 29, 2025
Merged

fix(clerk-react): Initialize isomorphic clerk with useRef#6024
panteliselef merged 4 commits into
mainfrom
elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across

Conversation

@panteliselef

@panteliselefpanteliselef commented May 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Avoid memoizing the singleton, instead use a reference to store it, and then destroy it.

If logs are added when creating/getting the singleton and when clearing it, in the previous implementation you will notice that clearing occurs after the initializion causing the singleton to be set to null.

Unblocks this DSH PR

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@panteliselef
fix(clerk-react): Initialize isomorphic clerk with useRef
660c5e8
Avoid memoizing the singleton, instead use a reference to store it, and then destroy it.
If logs are added when creating/getting the singleton and when clearing it, in the previous implementation you will notice that clearing occurs after the initializion causing the singleton to be set to null.
@panteliselef
panteliselef requested review from a team and EphemMay 28, 2025 19:40
@panteliselefpanteliselef self-assigned this May 28, 2025
@changeset-bot

changeset-botBot commented May 28, 2025•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5b87669

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
NameType
@clerk/clerk-reactPatch
@clerk/chrome-extensionPatch
@clerk/elementsPatch
@clerk/clerk-expoPatch
@clerk/nextjsPatch
@clerk/react-routerPatch
@clerk/remixPatch
@clerk/tanstack-react-startPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented May 28, 2025•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackMay 29, 2025 3:05pm

@panteliselef

panteliselef commented May 28, 2025

Copy link
Copy Markdown
ContributorAuthor

!snapshot

@clerk-cookie

clerk-cookie commented May 28, 2025

Copy link
Copy Markdown
Collaborator

Hey @panteliselef - the snapshot version command generated the following package versions:

PackageVersion
@clerk/agent-toolkit0.0.40-snapshot.v20250528194123
@clerk/astro2.8.2-snapshot.v20250528194123
@clerk/backend1.33.2-snapshot.v20250528194123
@clerk/chrome-extension2.4.10-snapshot.v20250528194123
@clerk/clerk-js5.67.5-snapshot.v20250528194123
@clerk/elements0.23.31-snapshot.v20250528194123
@clerk/clerk-expo2.11.10-snapshot.v20250528194123
@clerk/expo-passkeys0.3.8-snapshot.v20250528194123
@clerk/express1.5.2-snapshot.v20250528194123
@clerk/fastify2.2.23-snapshot.v20250528194123
@clerk/localizations3.16.3-snapshot.v20250528194123
@clerk/nextjs6.20.2-snapshot.v20250528194123
@clerk/nuxt1.6.9-snapshot.v20250528194123
@clerk/clerk-react5.31.8-snapshot.v20250528194123
@clerk/react-router1.4.8-snapshot.v20250528194123
@clerk/remix4.7.8-snapshot.v20250528194123
@clerk/shared3.9.5-snapshot.v20250528194123
@clerk/tanstack-react-start0.15.8-snapshot.v20250528194123
@clerk/testing1.7.5-snapshot.v20250528194123
@clerk/themes2.2.48-snapshot.v20250528194123
@clerk/types4.59.3-snapshot.v20250528194123
@clerk/vue1.8.6-snapshot.v20250528194123

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/agent-toolkit

npm i @clerk/agent-toolkit@0.0.40-snapshot.v20250528194123 --save-exact

@clerk/astro

npm i @clerk/astro@2.8.2-snapshot.v20250528194123 --save-exact

@clerk/backend

npm i @clerk/backend@1.33.2-snapshot.v20250528194123 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@2.4.10-snapshot.v20250528194123 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.67.5-snapshot.v20250528194123 --save-exact

@clerk/elements

npm i @clerk/elements@0.23.31-snapshot.v20250528194123 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@2.11.10-snapshot.v20250528194123 --save-exact

@clerk/expo-passkeys

npm i @clerk/expo-passkeys@0.3.8-snapshot.v20250528194123 --save-exact

@clerk/express

npm i @clerk/express@1.5.2-snapshot.v20250528194123 --save-exact

@clerk/fastify

npm i @clerk/fastify@2.2.23-snapshot.v20250528194123 --save-exact

@clerk/localizations

npm i @clerk/localizations@3.16.3-snapshot.v20250528194123 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@6.20.2-snapshot.v20250528194123 --save-exact

@clerk/nuxt

npm i @clerk/nuxt@1.6.9-snapshot.v20250528194123 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.31.8-snapshot.v20250528194123 --save-exact

@clerk/react-router

npm i @clerk/react-router@1.4.8-snapshot.v20250528194123 --save-exact

@clerk/remix

npm i @clerk/remix@4.7.8-snapshot.v20250528194123 --save-exact

@clerk/shared

npm i @clerk/shared@3.9.5-snapshot.v20250528194123 --save-exact

@clerk/tanstack-react-start

npm i @clerk/tanstack-react-start@0.15.8-snapshot.v20250528194123 --save-exact

@clerk/testing

npm i @clerk/testing@1.7.5-snapshot.v20250528194123 --save-exact

@clerk/themes

npm i @clerk/themes@2.2.48-snapshot.v20250528194123 --save-exact

@clerk/types

npm i @clerk/types@4.59.3-snapshot.v20250528194123 --save-exact

@clerk/vue

npm i @clerk/vue@1.8.6-snapshot.v20250528194123 --save-exact

@pkg-pr-new

pkg-pr-newBot commented May 28, 2025•
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6024

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6024

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6024

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6024

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6024

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6024

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6024

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6024

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6024

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6024

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6024

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6024

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6024

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6024

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6024

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6024

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6024

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6024

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6024

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6024

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6024

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6024

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6024

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6024

commit: 5b87669

@panteliselef
panteliselefforce-pushed the elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across branch from 3546de1 to 5821b51CompareMay 28, 2025 21:43
tmilewski
tmilewski reviewed May 29, 2025
View reviewed changes

@tmilewskitmilewski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃 Added a few suggested changes around console.log

Comment threadpackages/react/src/isomorphicClerk.ts Outdated
Comment threadpackages/react/src/isomorphicClerk.ts Outdated
Comment threadpackages/react/src/components/uiComponents.tsx Outdated
@panteliselef
panteliselef merged commit a3232c7 into mainMay 29, 2025
@panteliselef
panteliselef deleted the elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across branch May 29, 2025 19:22
@clerk-cookieclerk-cookie mentioned this pull request May 29, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes
@brkalowbrkalowbrkalow approved these changes
@EphemEphemAwaiting requested review from Ephem

Assignees

@panteliselefpanteliselef

Labels

react

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@panteliselef@clerk-cookie@tmilewski@brkalow
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix(clerk-react): Initialize isomorphic clerk with useRef - #6024
Merged
panteliselef merged 4 commits into
mainfrom 
elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across
May 29, 2025
Merged
fix(clerk-react): Initialize isomorphic clerk with useRef#6024
panteliselef merged 4 commits into
mainfrom 
elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across
Conversation
@panteliselef
@panteliselefpanteliselef
commented
May 28, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Avoid memoizing the singleton, instead use a reference to store it, and then destroy it.
If logs are added when creating/getting the singleton and when clearing it, in the previous implementation you will notice that clearing occurs after the initializion causing the singleton to be set to null.
Unblocks this DSH PR
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@panteliselef
fix(clerk-react): Initialize isomorphic clerk with useRef
660c5e8
Avoid memoizing the singleton, instead use a reference to store it, and then destroy it.
If logs are added when creating/getting the singleton and when clearing it, in the previous implementation you will notice that clearing occurs after the initializion causing the singleton to be set to null.
@panteliselef
panteliselef
requested review from
a team and EphemMay 28, 2025 19:40
@panteliselefpanteliselef
self-assigned this
May 28, 2025
@changeset-bot
changeset-botBot
commented
May 28, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 5b87669
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 8 packages
NameType
@clerk/clerk-reactPatch
@clerk/chrome-extensionPatch
@clerk/elementsPatch
@clerk/clerk-expoPatch
@clerk/nextjsPatch
@clerk/react-routerPatch
@clerk/remixPatch
@clerk/tanstack-react-startPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
May 28, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackMay 29, 2025 3:05pm
@panteliselef
panteliselef
commented
May 28, 2025

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
May 28, 2025

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/agent-toolkit0.0.40-snapshot.v20250528194123
@clerk/astro2.8.2-snapshot.v20250528194123
@clerk/backend1.33.2-snapshot.v20250528194123
@clerk/chrome-extension2.4.10-snapshot.v20250528194123
@clerk/clerk-js5.67.5-snapshot.v20250528194123
@clerk/elements0.23.31-snapshot.v20250528194123
@clerk/clerk-expo2.11.10-snapshot.v20250528194123
@clerk/expo-passkeys0.3.8-snapshot.v20250528194123
@clerk/express1.5.2-snapshot.v20250528194123
@clerk/fastify2.2.23-snapshot.v20250528194123
@clerk/localizations3.16.3-snapshot.v20250528194123
@clerk/nextjs6.20.2-snapshot.v20250528194123
@clerk/nuxt1.6.9-snapshot.v20250528194123
@clerk/clerk-react5.31.8-snapshot.v20250528194123
@clerk/react-router1.4.8-snapshot.v20250528194123
@clerk/remix4.7.8-snapshot.v20250528194123
@clerk/shared3.9.5-snapshot.v20250528194123
@clerk/tanstack-react-start0.15.8-snapshot.v20250528194123
@clerk/testing1.7.5-snapshot.v20250528194123
@clerk/themes2.2.48-snapshot.v20250528194123
@clerk/types4.59.3-snapshot.v20250528194123
@clerk/vue1.8.6-snapshot.v20250528194123
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/agent-toolkit
npm i @clerk/agent-toolkit@0.0.40-snapshot.v20250528194123 --save-exact
@clerk/astro
npm i @clerk/astro@2.8.2-snapshot.v20250528194123 --save-exact
@clerk/backend
npm i @clerk/backend@1.33.2-snapshot.v20250528194123 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@2.4.10-snapshot.v20250528194123 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.67.5-snapshot.v20250528194123 --save-exact
@clerk/elements
npm i @clerk/elements@0.23.31-snapshot.v20250528194123 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@2.11.10-snapshot.v20250528194123 --save-exact
@clerk/expo-passkeys
npm i @clerk/expo-passkeys@0.3.8-snapshot.v20250528194123 --save-exact
@clerk/express
npm i @clerk/express@1.5.2-snapshot.v20250528194123 --save-exact
@clerk/fastify
npm i @clerk/fastify@2.2.23-snapshot.v20250528194123 --save-exact
@clerk/localizations
npm i @clerk/localizations@3.16.3-snapshot.v20250528194123 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@6.20.2-snapshot.v20250528194123 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@1.6.9-snapshot.v20250528194123 --save-exact
@clerk/clerk-react
npm i @clerk/clerk-react@5.31.8-snapshot.v20250528194123 --save-exact
@clerk/react-router
npm i @clerk/react-router@1.4.8-snapshot.v20250528194123 --save-exact
@clerk/remix
npm i @clerk/remix@4.7.8-snapshot.v20250528194123 --save-exact
@clerk/shared
npm i @clerk/shared@3.9.5-snapshot.v20250528194123 --save-exact
@clerk/tanstack-react-start
npm i @clerk/tanstack-react-start@0.15.8-snapshot.v20250528194123 --save-exact
@clerk/testing
npm i @clerk/testing@1.7.5-snapshot.v20250528194123 --save-exact
@clerk/themes
npm i @clerk/themes@2.2.48-snapshot.v20250528194123 --save-exact
@clerk/types
npm i @clerk/types@4.59.3-snapshot.v20250528194123 --save-exact
@clerk/vue
npm i @clerk/vue@1.8.6-snapshot.v20250528194123 --save-exact
@pkg-pr-new
pkg-pr-newBot
commented
May 28, 2025•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@6024

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@6024

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@6024

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@6024

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@6024

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@6024

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@6024

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@6024

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@6024

@clerk/express
npm i https://pkg.pr.new/@clerk/express@6024

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@6024

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@6024

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@6024

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@6024

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@6024

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@6024

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@6024

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@6024

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@6024

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@6024

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@6024

@clerk/types
npm i https://pkg.pr.new/@clerk/types@6024

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@6024

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@6024

commit: 5b87669
@panteliselef
panteliselefforce-pushed
the
elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across
branch
from
3546de1 to
5821b51CompareMay 28, 2025 21:43
tmilewski
tmilewski
reviewed
May 29, 2025
View reviewed changes
@tmilewskitmilewski
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃 Added a few suggested changes around console.log
Comment threadpackages/react/src/isomorphicClerk.ts
Outdated

Comment threadpackages/react/src/isomorphicClerk.ts
Outdated

Comment threadpackages/react/src/components/uiComponents.tsx
Outdated

@panteliselef
panteliselef
merged commit a3232c7
into
mainMay 29, 2025
@panteliselef
panteliselef
deleted the

elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across

branch
May 29, 2025 19:22
@clerk-cookieclerk-cookie
mentioned this pull request
May 29, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes
@brkalowbrkalowbrkalow approved these changes
@EphemEphemAwaiting requested review from Ephem

Assignees

@panteliselefpanteliselef

Labels

react

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@panteliselef@clerk-cookie@tmilewski@brkalow

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(clerk-react): Initialize isomorphic clerk with useRef - #6024
Merged
panteliselef merged 4 commits into
mainfrom 
elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across
May 29, 2025
Merged
fix(clerk-react): Initialize isomorphic clerk with useRef#6024
panteliselef merged 4 commits into
mainfrom 
elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across
Conversation
@panteliselef
@panteliselefpanteliselef
commented
May 28, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Avoid memoizing the singleton, instead use a reference to store it, and then destroy it.
If logs are added when creating/getting the singleton and when clearing it, in the previous implementation you will notice that clearing occurs after the initializion causing the singleton to be set to null.
Unblocks this DSH PR
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@panteliselef
fix(clerk-react): Initialize isomorphic clerk with useRef
660c5e8
Avoid memoizing the singleton, instead use a reference to store it, and then destroy it.
If logs are added when creating/getting the singleton and when clearing it, in the previous implementation you will notice that clearing occurs after the initializion causing the singleton to be set to null.
@panteliselef
panteliselef
requested review from
a team and EphemMay 28, 2025 19:40
@panteliselefpanteliselef
self-assigned this
May 28, 2025
@changeset-bot
changeset-botBot
commented
May 28, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 5b87669
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 8 packages
NameType
@clerk/clerk-reactPatch
@clerk/chrome-extensionPatch
@clerk/elementsPatch
@clerk/clerk-expoPatch
@clerk/nextjsPatch
@clerk/react-routerPatch
@clerk/remixPatch
@clerk/tanstack-react-startPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
May 28, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackMay 29, 2025 3:05pm
@panteliselef
panteliselef
commented
May 28, 2025

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
May 28, 2025

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/agent-toolkit0.0.40-snapshot.v20250528194123
@clerk/astro2.8.2-snapshot.v20250528194123
@clerk/backend1.33.2-snapshot.v20250528194123
@clerk/chrome-extension2.4.10-snapshot.v20250528194123
@clerk/clerk-js5.67.5-snapshot.v20250528194123
@clerk/elements0.23.31-snapshot.v20250528194123
@clerk/clerk-expo2.11.10-snapshot.v20250528194123
@clerk/expo-passkeys0.3.8-snapshot.v20250528194123
@clerk/express1.5.2-snapshot.v20250528194123
@clerk/fastify2.2.23-snapshot.v20250528194123
@clerk/localizations3.16.3-snapshot.v20250528194123
@clerk/nextjs6.20.2-snapshot.v20250528194123
@clerk/nuxt1.6.9-snapshot.v20250528194123
@clerk/clerk-react5.31.8-snapshot.v20250528194123
@clerk/react-router1.4.8-snapshot.v20250528194123
@clerk/remix4.7.8-snapshot.v20250528194123
@clerk/shared3.9.5-snapshot.v20250528194123
@clerk/tanstack-react-start0.15.8-snapshot.v20250528194123
@clerk/testing1.7.5-snapshot.v20250528194123
@clerk/themes2.2.48-snapshot.v20250528194123
@clerk/types4.59.3-snapshot.v20250528194123
@clerk/vue1.8.6-snapshot.v20250528194123
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/agent-toolkit
npm i @clerk/agent-toolkit@0.0.40-snapshot.v20250528194123 --save-exact
@clerk/astro
npm i @clerk/astro@2.8.2-snapshot.v20250528194123 --save-exact
@clerk/backend
npm i @clerk/backend@1.33.2-snapshot.v20250528194123 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@2.4.10-snapshot.v20250528194123 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.67.5-snapshot.v20250528194123 --save-exact
@clerk/elements
npm i @clerk/elements@0.23.31-snapshot.v20250528194123 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@2.11.10-snapshot.v20250528194123 --save-exact
@clerk/expo-passkeys
npm i @clerk/expo-passkeys@0.3.8-snapshot.v20250528194123 --save-exact
@clerk/express
npm i @clerk/express@1.5.2-snapshot.v20250528194123 --save-exact
@clerk/fastify
npm i @clerk/fastify@2.2.23-snapshot.v20250528194123 --save-exact
@clerk/localizations
npm i @clerk/localizations@3.16.3-snapshot.v20250528194123 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@6.20.2-snapshot.v20250528194123 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@1.6.9-snapshot.v20250528194123 --save-exact
@clerk/clerk-react
npm i @clerk/clerk-react@5.31.8-snapshot.v20250528194123 --save-exact
@clerk/react-router
npm i @clerk/react-router@1.4.8-snapshot.v20250528194123 --save-exact
@clerk/remix
npm i @clerk/remix@4.7.8-snapshot.v20250528194123 --save-exact
@clerk/shared
npm i @clerk/shared@3.9.5-snapshot.v20250528194123 --save-exact
@clerk/tanstack-react-start
npm i @clerk/tanstack-react-start@0.15.8-snapshot.v20250528194123 --save-exact
@clerk/testing
npm i @clerk/testing@1.7.5-snapshot.v20250528194123 --save-exact
@clerk/themes
npm i @clerk/themes@2.2.48-snapshot.v20250528194123 --save-exact
@clerk/types
npm i @clerk/types@4.59.3-snapshot.v20250528194123 --save-exact
@clerk/vue
npm i @clerk/vue@1.8.6-snapshot.v20250528194123 --save-exact
@pkg-pr-new
pkg-pr-newBot
commented
May 28, 2025•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@6024

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@6024

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@6024

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@6024

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@6024

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@6024

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@6024

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@6024

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@6024

@clerk/express
npm i https://pkg.pr.new/@clerk/express@6024

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@6024

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@6024

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@6024

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@6024

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@6024

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@6024

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@6024

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@6024

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@6024

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@6024

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@6024

@clerk/types
npm i https://pkg.pr.new/@clerk/types@6024

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@6024

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@6024

commit: 5b87669
@panteliselef
panteliselefforce-pushed
the
elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across
branch
from
3546de1 to
5821b51CompareMay 28, 2025 21:43
tmilewski
tmilewski
reviewed
May 29, 2025
View reviewed changes
@tmilewskitmilewski
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃 Added a few suggested changes around console.log
Comment threadpackages/react/src/isomorphicClerk.ts
Outdated

Comment threadpackages/react/src/isomorphicClerk.ts
Outdated

Comment threadpackages/react/src/components/uiComponents.tsx
Outdated

@panteliselef
panteliselef
merged commit a3232c7
into
mainMay 29, 2025
@panteliselef
panteliselef
deleted the

elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across

branch
May 29, 2025 19:22
@clerk-cookieclerk-cookie
mentioned this pull request
May 29, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes
@brkalowbrkalowbrkalow approved these changes
@EphemEphemAwaiting requested review from Ephem

Assignees

@panteliselefpanteliselef

Labels

react

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@panteliselef@clerk-cookie@tmilewski@brkalow

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(clerk-react): Initialize isomorphic clerk with useRef - #6024
Merged
panteliselef merged 4 commits into
mainfrom 
elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across
May 29, 2025
Merged
fix(clerk-react): Initialize isomorphic clerk with useRef#6024
panteliselef merged 4 commits into
mainfrom 
elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across
Conversation
@panteliselef
@panteliselefpanteliselef
commented
May 28, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Avoid memoizing the singleton, instead use a reference to store it, and then destroy it.
If logs are added when creating/getting the singleton and when clearing it, in the previous implementation you will notice that clearing occurs after the initializion causing the singleton to be set to null.
Unblocks this DSH PR
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@panteliselef
fix(clerk-react): Initialize isomorphic clerk with useRef
660c5e8
Avoid memoizing the singleton, instead use a reference to store it, and then destroy it.
If logs are added when creating/getting the singleton and when clearing it, in the previous implementation you will notice that clearing occurs after the initializion causing the singleton to be set to null.
@panteliselef
panteliselef
requested review from
a team and EphemMay 28, 2025 19:40
@panteliselefpanteliselef
self-assigned this
May 28, 2025
@changeset-bot
changeset-botBot
commented
May 28, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 5b87669
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 8 packages
NameType
@clerk/clerk-reactPatch
@clerk/chrome-extensionPatch
@clerk/elementsPatch
@clerk/clerk-expoPatch
@clerk/nextjsPatch
@clerk/react-routerPatch
@clerk/remixPatch
@clerk/tanstack-react-startPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
May 28, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackMay 29, 2025 3:05pm
@panteliselef
panteliselef
commented
May 28, 2025

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
May 28, 2025

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/agent-toolkit0.0.40-snapshot.v20250528194123
@clerk/astro2.8.2-snapshot.v20250528194123
@clerk/backend1.33.2-snapshot.v20250528194123
@clerk/chrome-extension2.4.10-snapshot.v20250528194123
@clerk/clerk-js5.67.5-snapshot.v20250528194123
@clerk/elements0.23.31-snapshot.v20250528194123
@clerk/clerk-expo2.11.10-snapshot.v20250528194123
@clerk/expo-passkeys0.3.8-snapshot.v20250528194123
@clerk/express1.5.2-snapshot.v20250528194123
@clerk/fastify2.2.23-snapshot.v20250528194123
@clerk/localizations3.16.3-snapshot.v20250528194123
@clerk/nextjs6.20.2-snapshot.v20250528194123
@clerk/nuxt1.6.9-snapshot.v20250528194123
@clerk/clerk-react5.31.8-snapshot.v20250528194123
@clerk/react-router1.4.8-snapshot.v20250528194123
@clerk/remix4.7.8-snapshot.v20250528194123
@clerk/shared3.9.5-snapshot.v20250528194123
@clerk/tanstack-react-start0.15.8-snapshot.v20250528194123
@clerk/testing1.7.5-snapshot.v20250528194123
@clerk/themes2.2.48-snapshot.v20250528194123
@clerk/types4.59.3-snapshot.v20250528194123
@clerk/vue1.8.6-snapshot.v20250528194123
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/agent-toolkit
npm i @clerk/agent-toolkit@0.0.40-snapshot.v20250528194123 --save-exact
@clerk/astro
npm i @clerk/astro@2.8.2-snapshot.v20250528194123 --save-exact
@clerk/backend
npm i @clerk/backend@1.33.2-snapshot.v20250528194123 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@2.4.10-snapshot.v20250528194123 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.67.5-snapshot.v20250528194123 --save-exact
@clerk/elements
npm i @clerk/elements@0.23.31-snapshot.v20250528194123 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@2.11.10-snapshot.v20250528194123 --save-exact
@clerk/expo-passkeys
npm i @clerk/expo-passkeys@0.3.8-snapshot.v20250528194123 --save-exact
@clerk/express
npm i @clerk/express@1.5.2-snapshot.v20250528194123 --save-exact
@clerk/fastify
npm i @clerk/fastify@2.2.23-snapshot.v20250528194123 --save-exact
@clerk/localizations
npm i @clerk/localizations@3.16.3-snapshot.v20250528194123 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@6.20.2-snapshot.v20250528194123 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@1.6.9-snapshot.v20250528194123 --save-exact
@clerk/clerk-react
npm i @clerk/clerk-react@5.31.8-snapshot.v20250528194123 --save-exact
@clerk/react-router
npm i @clerk/react-router@1.4.8-snapshot.v20250528194123 --save-exact
@clerk/remix
npm i @clerk/remix@4.7.8-snapshot.v20250528194123 --save-exact
@clerk/shared
npm i @clerk/shared@3.9.5-snapshot.v20250528194123 --save-exact
@clerk/tanstack-react-start
npm i @clerk/tanstack-react-start@0.15.8-snapshot.v20250528194123 --save-exact
@clerk/testing
npm i @clerk/testing@1.7.5-snapshot.v20250528194123 --save-exact
@clerk/themes
npm i @clerk/themes@2.2.48-snapshot.v20250528194123 --save-exact
@clerk/types
npm i @clerk/types@4.59.3-snapshot.v20250528194123 --save-exact
@clerk/vue
npm i @clerk/vue@1.8.6-snapshot.v20250528194123 --save-exact
@pkg-pr-new
pkg-pr-newBot
commented
May 28, 2025•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@6024

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@6024

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@6024

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@6024

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@6024

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@6024

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@6024

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@6024

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@6024

@clerk/express
npm i https://pkg.pr.new/@clerk/express@6024

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@6024

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@6024

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@6024

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@6024

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@6024

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@6024

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@6024

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@6024

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@6024

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@6024

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@6024

@clerk/types
npm i https://pkg.pr.new/@clerk/types@6024

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@6024

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@6024

commit: 5b87669
@panteliselef
panteliselefforce-pushed
the
elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across
branch
from
3546de1 to
5821b51CompareMay 28, 2025 21:43
tmilewski
tmilewski
reviewed
May 29, 2025
View reviewed changes
@tmilewskitmilewski
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃 Added a few suggested changes around console.log
Comment threadpackages/react/src/isomorphicClerk.ts
Outdated

Comment threadpackages/react/src/isomorphicClerk.ts
Outdated

Comment threadpackages/react/src/components/uiComponents.tsx
Outdated

@panteliselef
panteliselef
merged commit a3232c7
into
mainMay 29, 2025
@panteliselef
panteliselef
deleted the

elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across

branch
May 29, 2025 19:22
@clerk-cookieclerk-cookie
mentioned this pull request
May 29, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes
@brkalowbrkalowbrkalow approved these changes
@EphemEphemAwaiting requested review from Ephem

Assignees

@panteliselefpanteliselef

Labels

react

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@panteliselef@clerk-cookie@tmilewski@brkalow

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix(clerk-react): Initialize isomorphic clerk with useRef - #6024
Merged
panteliselef merged 4 commits into
mainfrom 
elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across
May 29, 2025
Merged
fix(clerk-react): Initialize isomorphic clerk with useRef#6024
panteliselef merged 4 commits into
mainfrom 
elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across
Conversation
@panteliselef
@panteliselefpanteliselef
commented
May 28, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Avoid memoizing the singleton, instead use a reference to store it, and then destroy it.
If logs are added when creating/getting the singleton and when clearing it, in the previous implementation you will notice that clearing occurs after the initializion causing the singleton to be set to null.
Unblocks this DSH PR
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@panteliselef
fix(clerk-react): Initialize isomorphic clerk with useRef
660c5e8
Avoid memoizing the singleton, instead use a reference to store it, and then destroy it.
If logs are added when creating/getting the singleton and when clearing it, in the previous implementation you will notice that clearing occurs after the initializion causing the singleton to be set to null.
@panteliselef
panteliselef
requested review from
a team and EphemMay 28, 2025 19:40
@panteliselefpanteliselef
self-assigned this
May 28, 2025
@changeset-bot
changeset-botBot
commented
May 28, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 5b87669
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 8 packages
NameType
@clerk/clerk-reactPatch
@clerk/chrome-extensionPatch
@clerk/elementsPatch
@clerk/clerk-expoPatch
@clerk/nextjsPatch
@clerk/react-routerPatch
@clerk/remixPatch
@clerk/tanstack-react-startPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
May 28, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackMay 29, 2025 3:05pm
@panteliselef
panteliselef
commented
May 28, 2025

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
May 28, 2025

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/agent-toolkit0.0.40-snapshot.v20250528194123
@clerk/astro2.8.2-snapshot.v20250528194123
@clerk/backend1.33.2-snapshot.v20250528194123
@clerk/chrome-extension2.4.10-snapshot.v20250528194123
@clerk/clerk-js5.67.5-snapshot.v20250528194123
@clerk/elements0.23.31-snapshot.v20250528194123
@clerk/clerk-expo2.11.10-snapshot.v20250528194123
@clerk/expo-passkeys0.3.8-snapshot.v20250528194123
@clerk/express1.5.2-snapshot.v20250528194123
@clerk/fastify2.2.23-snapshot.v20250528194123
@clerk/localizations3.16.3-snapshot.v20250528194123
@clerk/nextjs6.20.2-snapshot.v20250528194123
@clerk/nuxt1.6.9-snapshot.v20250528194123
@clerk/clerk-react5.31.8-snapshot.v20250528194123
@clerk/react-router1.4.8-snapshot.v20250528194123
@clerk/remix4.7.8-snapshot.v20250528194123
@clerk/shared3.9.5-snapshot.v20250528194123
@clerk/tanstack-react-start0.15.8-snapshot.v20250528194123
@clerk/testing1.7.5-snapshot.v20250528194123
@clerk/themes2.2.48-snapshot.v20250528194123
@clerk/types4.59.3-snapshot.v20250528194123
@clerk/vue1.8.6-snapshot.v20250528194123
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/agent-toolkit
npm i @clerk/agent-toolkit@0.0.40-snapshot.v20250528194123 --save-exact
@clerk/astro
npm i @clerk/astro@2.8.2-snapshot.v20250528194123 --save-exact
@clerk/backend
npm i @clerk/backend@1.33.2-snapshot.v20250528194123 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@2.4.10-snapshot.v20250528194123 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.67.5-snapshot.v20250528194123 --save-exact
@clerk/elements
npm i @clerk/elements@0.23.31-snapshot.v20250528194123 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@2.11.10-snapshot.v20250528194123 --save-exact
@clerk/expo-passkeys
npm i @clerk/expo-passkeys@0.3.8-snapshot.v20250528194123 --save-exact
@clerk/express
npm i @clerk/express@1.5.2-snapshot.v20250528194123 --save-exact
@clerk/fastify
npm i @clerk/fastify@2.2.23-snapshot.v20250528194123 --save-exact
@clerk/localizations
npm i @clerk/localizations@3.16.3-snapshot.v20250528194123 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@6.20.2-snapshot.v20250528194123 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@1.6.9-snapshot.v20250528194123 --save-exact
@clerk/clerk-react
npm i @clerk/clerk-react@5.31.8-snapshot.v20250528194123 --save-exact
@clerk/react-router
npm i @clerk/react-router@1.4.8-snapshot.v20250528194123 --save-exact
@clerk/remix
npm i @clerk/remix@4.7.8-snapshot.v20250528194123 --save-exact
@clerk/shared
npm i @clerk/shared@3.9.5-snapshot.v20250528194123 --save-exact
@clerk/tanstack-react-start
npm i @clerk/tanstack-react-start@0.15.8-snapshot.v20250528194123 --save-exact
@clerk/testing
npm i @clerk/testing@1.7.5-snapshot.v20250528194123 --save-exact
@clerk/themes
npm i @clerk/themes@2.2.48-snapshot.v20250528194123 --save-exact
@clerk/types
npm i @clerk/types@4.59.3-snapshot.v20250528194123 --save-exact
@clerk/vue
npm i @clerk/vue@1.8.6-snapshot.v20250528194123 --save-exact
@pkg-pr-new
pkg-pr-newBot
commented
May 28, 2025•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@6024

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@6024

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@6024

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@6024

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@6024

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@6024

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@6024

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@6024

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@6024

@clerk/express
npm i https://pkg.pr.new/@clerk/express@6024

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@6024

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@6024

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@6024

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@6024

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@6024

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@6024

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@6024

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@6024

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@6024

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@6024

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@6024

@clerk/types
npm i https://pkg.pr.new/@clerk/types@6024

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@6024

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@6024

commit: 5b87669
@panteliselef
panteliselefforce-pushed
the
elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across
branch
from
3546de1 to
5821b51CompareMay 28, 2025 21:43
tmilewski
tmilewski
reviewed
May 29, 2025
View reviewed changes
@tmilewskitmilewski
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃 Added a few suggested changes around console.log
Comment threadpackages/react/src/isomorphicClerk.ts
Outdated

Comment threadpackages/react/src/isomorphicClerk.ts
Outdated

Comment threadpackages/react/src/components/uiComponents.tsx
Outdated

@panteliselef
panteliselef
merged commit a3232c7
into
mainMay 29, 2025
@panteliselef
panteliselef
deleted the

elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across

branch
May 29, 2025 19:22
@clerk-cookieclerk-cookie
mentioned this pull request
May 29, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes
@brkalowbrkalowbrkalow approved these changes
@EphemEphemAwaiting requested review from Ephem

Assignees

@panteliselefpanteliselef

Labels

react

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@panteliselef@clerk-cookie@tmilewski@brkalow

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(clerk-react): Initialize isomorphic clerk with useRef - #6024
Merged
panteliselef merged 4 commits into
mainfrom 
elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across
May 29, 2025
Merged
fix(clerk-react): Initialize isomorphic clerk with useRef#6024
panteliselef merged 4 commits into
mainfrom 
elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across
Conversation
@panteliselef
@panteliselefpanteliselef
commented
May 28, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Avoid memoizing the singleton, instead use a reference to store it, and then destroy it.
If logs are added when creating/getting the singleton and when clearing it, in the previous implementation you will notice that clearing occurs after the initializion causing the singleton to be set to null.
Unblocks this DSH PR
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@panteliselef
fix(clerk-react): Initialize isomorphic clerk with useRef
660c5e8
Avoid memoizing the singleton, instead use a reference to store it, and then destroy it.
If logs are added when creating/getting the singleton and when clearing it, in the previous implementation you will notice that clearing occurs after the initializion causing the singleton to be set to null.
@panteliselef
panteliselef
requested review from
a team and EphemMay 28, 2025 19:40
@panteliselefpanteliselef
self-assigned this
May 28, 2025
@changeset-bot
changeset-botBot
commented
May 28, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 5b87669
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 8 packages
NameType
@clerk/clerk-reactPatch
@clerk/chrome-extensionPatch
@clerk/elementsPatch
@clerk/clerk-expoPatch
@clerk/nextjsPatch
@clerk/react-routerPatch
@clerk/remixPatch
@clerk/tanstack-react-startPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
May 28, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackMay 29, 2025 3:05pm
@panteliselef
panteliselef
commented
May 28, 2025

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
May 28, 2025

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/agent-toolkit0.0.40-snapshot.v20250528194123
@clerk/astro2.8.2-snapshot.v20250528194123
@clerk/backend1.33.2-snapshot.v20250528194123
@clerk/chrome-extension2.4.10-snapshot.v20250528194123
@clerk/clerk-js5.67.5-snapshot.v20250528194123
@clerk/elements0.23.31-snapshot.v20250528194123
@clerk/clerk-expo2.11.10-snapshot.v20250528194123
@clerk/expo-passkeys0.3.8-snapshot.v20250528194123
@clerk/express1.5.2-snapshot.v20250528194123
@clerk/fastify2.2.23-snapshot.v20250528194123
@clerk/localizations3.16.3-snapshot.v20250528194123
@clerk/nextjs6.20.2-snapshot.v20250528194123
@clerk/nuxt1.6.9-snapshot.v20250528194123
@clerk/clerk-react5.31.8-snapshot.v20250528194123
@clerk/react-router1.4.8-snapshot.v20250528194123
@clerk/remix4.7.8-snapshot.v20250528194123
@clerk/shared3.9.5-snapshot.v20250528194123
@clerk/tanstack-react-start0.15.8-snapshot.v20250528194123
@clerk/testing1.7.5-snapshot.v20250528194123
@clerk/themes2.2.48-snapshot.v20250528194123
@clerk/types4.59.3-snapshot.v20250528194123
@clerk/vue1.8.6-snapshot.v20250528194123
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/agent-toolkit
npm i @clerk/agent-toolkit@0.0.40-snapshot.v20250528194123 --save-exact
@clerk/astro
npm i @clerk/astro@2.8.2-snapshot.v20250528194123 --save-exact
@clerk/backend
npm i @clerk/backend@1.33.2-snapshot.v20250528194123 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@2.4.10-snapshot.v20250528194123 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.67.5-snapshot.v20250528194123 --save-exact
@clerk/elements
npm i @clerk/elements@0.23.31-snapshot.v20250528194123 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@2.11.10-snapshot.v20250528194123 --save-exact
@clerk/expo-passkeys
npm i @clerk/expo-passkeys@0.3.8-snapshot.v20250528194123 --save-exact
@clerk/express
npm i @clerk/express@1.5.2-snapshot.v20250528194123 --save-exact
@clerk/fastify
npm i @clerk/fastify@2.2.23-snapshot.v20250528194123 --save-exact
@clerk/localizations
npm i @clerk/localizations@3.16.3-snapshot.v20250528194123 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@6.20.2-snapshot.v20250528194123 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@1.6.9-snapshot.v20250528194123 --save-exact
@clerk/clerk-react
npm i @clerk/clerk-react@5.31.8-snapshot.v20250528194123 --save-exact
@clerk/react-router
npm i @clerk/react-router@1.4.8-snapshot.v20250528194123 --save-exact
@clerk/remix
npm i @clerk/remix@4.7.8-snapshot.v20250528194123 --save-exact
@clerk/shared
npm i @clerk/shared@3.9.5-snapshot.v20250528194123 --save-exact
@clerk/tanstack-react-start
npm i @clerk/tanstack-react-start@0.15.8-snapshot.v20250528194123 --save-exact
@clerk/testing
npm i @clerk/testing@1.7.5-snapshot.v20250528194123 --save-exact
@clerk/themes
npm i @clerk/themes@2.2.48-snapshot.v20250528194123 --save-exact
@clerk/types
npm i @clerk/types@4.59.3-snapshot.v20250528194123 --save-exact
@clerk/vue
npm i @clerk/vue@1.8.6-snapshot.v20250528194123 --save-exact
@pkg-pr-new
pkg-pr-newBot
commented
May 28, 2025•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@6024

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@6024

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@6024

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@6024

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@6024

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@6024

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@6024

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@6024

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@6024

@clerk/express
npm i https://pkg.pr.new/@clerk/express@6024

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@6024

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@6024

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@6024

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@6024

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@6024

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@6024

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@6024

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@6024

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@6024

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@6024

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@6024

@clerk/types
npm i https://pkg.pr.new/@clerk/types@6024

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@6024

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@6024

commit: 5b87669
@panteliselef
panteliselefforce-pushed
the
elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across
branch
from
3546de1 to
5821b51CompareMay 28, 2025 21:43
tmilewski
tmilewski
reviewed
May 29, 2025
View reviewed changes
@tmilewskitmilewski
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃 Added a few suggested changes around console.log
Comment threadpackages/react/src/isomorphicClerk.ts
Outdated

Comment threadpackages/react/src/isomorphicClerk.ts
Outdated

Comment threadpackages/react/src/components/uiComponents.tsx
Outdated

@panteliselef
panteliselef
merged commit a3232c7
into
mainMay 29, 2025
@panteliselef
panteliselef
deleted the

elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across

branch
May 29, 2025 19:22
@clerk-cookieclerk-cookie
mentioned this pull request
May 29, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes
@brkalowbrkalowbrkalow approved these changes
@EphemEphemAwaiting requested review from Ephem

Assignees

@panteliselefpanteliselef

Labels

react

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@panteliselef@clerk-cookie@tmilewski@brkalow

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(clerk-react): Initialize isomorphic clerk with useRef - #6024
Merged
panteliselef merged 4 commits into
mainfrom 
elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across
May 29, 2025
Merged
fix(clerk-react): Initialize isomorphic clerk with useRef#6024
panteliselef merged 4 commits into
mainfrom 
elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across
Conversation
@panteliselef
@panteliselefpanteliselef
commented
May 28, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Avoid memoizing the singleton, instead use a reference to store it, and then destroy it.
If logs are added when creating/getting the singleton and when clearing it, in the previous implementation you will notice that clearing occurs after the initializion causing the singleton to be set to null.
Unblocks this DSH PR
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@panteliselef
fix(clerk-react): Initialize isomorphic clerk with useRef
660c5e8
Avoid memoizing the singleton, instead use a reference to store it, and then destroy it.
If logs are added when creating/getting the singleton and when clearing it, in the previous implementation you will notice that clearing occurs after the initializion causing the singleton to be set to null.
@panteliselef
panteliselef
requested review from
a team and EphemMay 28, 2025 19:40
@panteliselefpanteliselef
self-assigned this
May 28, 2025
@changeset-bot
changeset-botBot
commented
May 28, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 5b87669
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 8 packages
NameType
@clerk/clerk-reactPatch
@clerk/chrome-extensionPatch
@clerk/elementsPatch
@clerk/clerk-expoPatch
@clerk/nextjsPatch
@clerk/react-routerPatch
@clerk/remixPatch
@clerk/tanstack-react-startPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
May 28, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackMay 29, 2025 3:05pm
@panteliselef
panteliselef
commented
May 28, 2025

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
May 28, 2025

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/agent-toolkit0.0.40-snapshot.v20250528194123
@clerk/astro2.8.2-snapshot.v20250528194123
@clerk/backend1.33.2-snapshot.v20250528194123
@clerk/chrome-extension2.4.10-snapshot.v20250528194123
@clerk/clerk-js5.67.5-snapshot.v20250528194123
@clerk/elements0.23.31-snapshot.v20250528194123
@clerk/clerk-expo2.11.10-snapshot.v20250528194123
@clerk/expo-passkeys0.3.8-snapshot.v20250528194123
@clerk/express1.5.2-snapshot.v20250528194123
@clerk/fastify2.2.23-snapshot.v20250528194123
@clerk/localizations3.16.3-snapshot.v20250528194123
@clerk/nextjs6.20.2-snapshot.v20250528194123
@clerk/nuxt1.6.9-snapshot.v20250528194123
@clerk/clerk-react5.31.8-snapshot.v20250528194123
@clerk/react-router1.4.8-snapshot.v20250528194123
@clerk/remix4.7.8-snapshot.v20250528194123
@clerk/shared3.9.5-snapshot.v20250528194123
@clerk/tanstack-react-start0.15.8-snapshot.v20250528194123
@clerk/testing1.7.5-snapshot.v20250528194123
@clerk/themes2.2.48-snapshot.v20250528194123
@clerk/types4.59.3-snapshot.v20250528194123
@clerk/vue1.8.6-snapshot.v20250528194123
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/agent-toolkit
npm i @clerk/agent-toolkit@0.0.40-snapshot.v20250528194123 --save-exact
@clerk/astro
npm i @clerk/astro@2.8.2-snapshot.v20250528194123 --save-exact
@clerk/backend
npm i @clerk/backend@1.33.2-snapshot.v20250528194123 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@2.4.10-snapshot.v20250528194123 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.67.5-snapshot.v20250528194123 --save-exact
@clerk/elements
npm i @clerk/elements@0.23.31-snapshot.v20250528194123 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@2.11.10-snapshot.v20250528194123 --save-exact
@clerk/expo-passkeys
npm i @clerk/expo-passkeys@0.3.8-snapshot.v20250528194123 --save-exact
@clerk/express
npm i @clerk/express@1.5.2-snapshot.v20250528194123 --save-exact
@clerk/fastify
npm i @clerk/fastify@2.2.23-snapshot.v20250528194123 --save-exact
@clerk/localizations
npm i @clerk/localizations@3.16.3-snapshot.v20250528194123 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@6.20.2-snapshot.v20250528194123 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@1.6.9-snapshot.v20250528194123 --save-exact
@clerk/clerk-react
npm i @clerk/clerk-react@5.31.8-snapshot.v20250528194123 --save-exact
@clerk/react-router
npm i @clerk/react-router@1.4.8-snapshot.v20250528194123 --save-exact
@clerk/remix
npm i @clerk/remix@4.7.8-snapshot.v20250528194123 --save-exact
@clerk/shared
npm i @clerk/shared@3.9.5-snapshot.v20250528194123 --save-exact
@clerk/tanstack-react-start
npm i @clerk/tanstack-react-start@0.15.8-snapshot.v20250528194123 --save-exact
@clerk/testing
npm i @clerk/testing@1.7.5-snapshot.v20250528194123 --save-exact
@clerk/themes
npm i @clerk/themes@2.2.48-snapshot.v20250528194123 --save-exact
@clerk/types
npm i @clerk/types@4.59.3-snapshot.v20250528194123 --save-exact
@clerk/vue
npm i @clerk/vue@1.8.6-snapshot.v20250528194123 --save-exact
@pkg-pr-new
pkg-pr-newBot
commented
May 28, 2025•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@6024

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@6024

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@6024

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@6024

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@6024

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@6024

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@6024

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@6024

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@6024

@clerk/express
npm i https://pkg.pr.new/@clerk/express@6024

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@6024

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@6024

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@6024

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@6024

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@6024

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@6024

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@6024

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@6024

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@6024

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@6024

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@6024

@clerk/types
npm i https://pkg.pr.new/@clerk/types@6024

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@6024

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@6024

commit: 5b87669
@panteliselef
panteliselefforce-pushed
the
elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across
branch
from
3546de1 to
5821b51CompareMay 28, 2025 21:43
tmilewski
tmilewski
reviewed
May 29, 2025
View reviewed changes
@tmilewskitmilewski
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃 Added a few suggested changes around console.log
Comment threadpackages/react/src/isomorphicClerk.ts
Outdated

Comment threadpackages/react/src/isomorphicClerk.ts
Outdated

Comment threadpackages/react/src/components/uiComponents.tsx
Outdated

@panteliselef
panteliselef
merged commit a3232c7
into
mainMay 29, 2025
@panteliselef
panteliselef
deleted the

elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across

branch
May 29, 2025 19:22
@clerk-cookieclerk-cookie
mentioned this pull request
May 29, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes
@brkalowbrkalowbrkalow approved these changes
@EphemEphemAwaiting requested review from Ephem

Assignees

@panteliselefpanteliselef

Labels

react

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@panteliselef@clerk-cookie@tmilewski@brkalow

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix(clerk-react): Initialize isomorphic clerk with useRef - #6024
Merged
panteliselef merged 4 commits into
mainfrom 
elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across
May 29, 2025
Merged
fix(clerk-react): Initialize isomorphic clerk with useRef#6024
panteliselef merged 4 commits into
mainfrom 
elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across
Conversation
@panteliselef
@panteliselefpanteliselef
commented
May 28, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Avoid memoizing the singleton, instead use a reference to store it, and then destroy it.
If logs are added when creating/getting the singleton and when clearing it, in the previous implementation you will notice that clearing occurs after the initializion causing the singleton to be set to null.
Unblocks this DSH PR
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@panteliselef
fix(clerk-react): Initialize isomorphic clerk with useRef
660c5e8
Avoid memoizing the singleton, instead use a reference to store it, and then destroy it.
If logs are added when creating/getting the singleton and when clearing it, in the previous implementation you will notice that clearing occurs after the initializion causing the singleton to be set to null.
@panteliselef
panteliselef
requested review from
a team and EphemMay 28, 2025 19:40
@panteliselefpanteliselef
self-assigned this
May 28, 2025
@changeset-bot
changeset-botBot
commented
May 28, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 5b87669
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 8 packages
NameType
@clerk/clerk-reactPatch
@clerk/chrome-extensionPatch
@clerk/elementsPatch
@clerk/clerk-expoPatch
@clerk/nextjsPatch
@clerk/react-routerPatch
@clerk/remixPatch
@clerk/tanstack-react-startPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
May 28, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackMay 29, 2025 3:05pm
@panteliselef
panteliselef
commented
May 28, 2025

Copy link


Copy Markdown

ContributorAuthor
!snapshot
@clerk-cookie
clerk-cookie
commented
May 28, 2025

Copy link


Copy Markdown

Collaborator
Hey @panteliselef - the snapshot version command generated the following package versions:
PackageVersion
@clerk/agent-toolkit0.0.40-snapshot.v20250528194123
@clerk/astro2.8.2-snapshot.v20250528194123
@clerk/backend1.33.2-snapshot.v20250528194123
@clerk/chrome-extension2.4.10-snapshot.v20250528194123
@clerk/clerk-js5.67.5-snapshot.v20250528194123
@clerk/elements0.23.31-snapshot.v20250528194123
@clerk/clerk-expo2.11.10-snapshot.v20250528194123
@clerk/expo-passkeys0.3.8-snapshot.v20250528194123
@clerk/express1.5.2-snapshot.v20250528194123
@clerk/fastify2.2.23-snapshot.v20250528194123
@clerk/localizations3.16.3-snapshot.v20250528194123
@clerk/nextjs6.20.2-snapshot.v20250528194123
@clerk/nuxt1.6.9-snapshot.v20250528194123
@clerk/clerk-react5.31.8-snapshot.v20250528194123
@clerk/react-router1.4.8-snapshot.v20250528194123
@clerk/remix4.7.8-snapshot.v20250528194123
@clerk/shared3.9.5-snapshot.v20250528194123
@clerk/tanstack-react-start0.15.8-snapshot.v20250528194123
@clerk/testing1.7.5-snapshot.v20250528194123
@clerk/themes2.2.48-snapshot.v20250528194123
@clerk/types4.59.3-snapshot.v20250528194123
@clerk/vue1.8.6-snapshot.v20250528194123
Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/agent-toolkit
npm i @clerk/agent-toolkit@0.0.40-snapshot.v20250528194123 --save-exact
@clerk/astro
npm i @clerk/astro@2.8.2-snapshot.v20250528194123 --save-exact
@clerk/backend
npm i @clerk/backend@1.33.2-snapshot.v20250528194123 --save-exact
@clerk/chrome-extension
npm i @clerk/chrome-extension@2.4.10-snapshot.v20250528194123 --save-exact
@clerk/clerk-js
npm i @clerk/clerk-js@5.67.5-snapshot.v20250528194123 --save-exact
@clerk/elements
npm i @clerk/elements@0.23.31-snapshot.v20250528194123 --save-exact
@clerk/clerk-expo
npm i @clerk/clerk-expo@2.11.10-snapshot.v20250528194123 --save-exact
@clerk/expo-passkeys
npm i @clerk/expo-passkeys@0.3.8-snapshot.v20250528194123 --save-exact
@clerk/express
npm i @clerk/express@1.5.2-snapshot.v20250528194123 --save-exact
@clerk/fastify
npm i @clerk/fastify@2.2.23-snapshot.v20250528194123 --save-exact
@clerk/localizations
npm i @clerk/localizations@3.16.3-snapshot.v20250528194123 --save-exact
@clerk/nextjs
npm i @clerk/nextjs@6.20.2-snapshot.v20250528194123 --save-exact
@clerk/nuxt
npm i @clerk/nuxt@1.6.9-snapshot.v20250528194123 --save-exact
@clerk/clerk-react
npm i @clerk/clerk-react@5.31.8-snapshot.v20250528194123 --save-exact
@clerk/react-router
npm i @clerk/react-router@1.4.8-snapshot.v20250528194123 --save-exact
@clerk/remix
npm i @clerk/remix@4.7.8-snapshot.v20250528194123 --save-exact
@clerk/shared
npm i @clerk/shared@3.9.5-snapshot.v20250528194123 --save-exact
@clerk/tanstack-react-start
npm i @clerk/tanstack-react-start@0.15.8-snapshot.v20250528194123 --save-exact
@clerk/testing
npm i @clerk/testing@1.7.5-snapshot.v20250528194123 --save-exact
@clerk/themes
npm i @clerk/themes@2.2.48-snapshot.v20250528194123 --save-exact
@clerk/types
npm i @clerk/types@4.59.3-snapshot.v20250528194123 --save-exact
@clerk/vue
npm i @clerk/vue@1.8.6-snapshot.v20250528194123 --save-exact
@pkg-pr-new
pkg-pr-newBot
commented
May 28, 2025•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@6024

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@6024

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@6024

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@6024

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@6024

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@6024

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@6024

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@6024

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@6024

@clerk/express
npm i https://pkg.pr.new/@clerk/express@6024

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@6024

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@6024

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@6024

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@6024

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@6024

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@6024

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@6024

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@6024

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@6024

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@6024

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@6024

@clerk/types
npm i https://pkg.pr.new/@clerk/types@6024

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@6024

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@6024

commit: 5b87669
@panteliselef
panteliselefforce-pushed
the
elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across
branch
from
3546de1 to
5821b51CompareMay 28, 2025 21:43
tmilewski
tmilewski
reviewed
May 29, 2025
View reviewed changes
@tmilewskitmilewski
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃 Added a few suggested changes around console.log
Comment threadpackages/react/src/isomorphicClerk.ts
Outdated

Comment threadpackages/react/src/isomorphicClerk.ts
Outdated

Comment threadpackages/react/src/components/uiComponents.tsx
Outdated

@panteliselef
panteliselef
merged commit a3232c7
into
mainMay 29, 2025
@panteliselef
panteliselef
deleted the

elef/sdk-2126-userbutton-shows-fallback-indefinitely-when-remounted-across

branch
May 29, 2025 19:22
@clerk-cookieclerk-cookie
mentioned this pull request
May 29, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes
@brkalowbrkalowbrkalow approved these changes
@EphemEphemAwaiting requested review from Ephem

Assignees

@panteliselefpanteliselef

Labels

react

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@panteliselef@clerk-cookie@tmilewski@brkalow