Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/open-swans-count.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
'@clerk/backend': minor
'@clerk/nextjs': minor
---

Respect `acceptsToken` when returning unauthenticated session or machine object.
4 changes: 3 additions & 1 deletion packages/backend/src/__tests__/exports.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,9 @@ describe('subpath /internal exports', () => {
"getAuthObjectForAcceptedToken",
"getAuthObjectFromJwt",
"getMachineTokenType",
"isMachineToken",
"invalidTokenAuthObject",
"isMachineTokenByPrefix",
"isMachineTokenType",
"isTokenTypeAccepted",
"makeAuthObjectSerializable",
"reverificationError",
Expand Down
2 changes: 1 addition & 1 deletion packages/backend/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -161,5 +161,5 @@ export type {
/**
* Auth objects
*/
export type { AuthObject } from './tokens/authObjects';
export type { AuthObject, InvalidTokenAuthObject } from './tokens/authObjects';
export type { SessionAuthObject, MachineAuthObject } from './tokens/types';
3 changes: 2 additions & 1 deletion packages/backend/src/internal.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,6 +31,7 @@ export {
signedInAuthObject,
authenticatedMachineObject,
unauthenticatedMachineObject,
invalidTokenAuthObject,
getAuthObjectFromJwt,
getAuthObjectForAcceptedToken,
} from './tokens/authObjects';
Expand All@@ -53,4 +54,4 @@ export { reverificationError, reverificationErrorResponse } from '@clerk/shared/

export { verifyMachineAuthToken } from './tokens/verify';

export { isMachineToken, getMachineTokenType, isTokenTypeAccepted } from './tokens/machine';
export { isMachineTokenByPrefix, isMachineTokenType, getMachineTokenType, isTokenTypeAccepted } from './tokens/machine';
45 changes: 45 additions & 0 deletions packages/backend/src/tokens/__tests__/authObjects.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,10 @@ import { describe, expect, it } from 'vitest';

import { mockTokens, mockVerificationResults } from '../../fixtures/machine';
import type { AuthenticateContext } from '../authenticateContext';
import type { InvalidTokenAuthObject, UnauthenticatedMachineObject } from '../authObjects';
import {
authenticatedMachineObject,
getAuthObjectForAcceptedToken,
makeAuthObjectSerializable,
signedInAuthObject,
signedOutAuthObject,
Expand DownExpand Up@@ -387,3 +389,46 @@ describe('unauthenticatedMachineObject', () => {
expect(retrievedToken).toBeNull();
});
});

describe('getAuthObjectForAcceptedToken', () => {
const debugData = { foo: 'bar' };
const sessionAuth = signedOutAuthObject(debugData);
const machineAuth = authenticatedMachineObject('api_key', 'ak_xxx', mockVerificationResults.api_key, debugData);

it('returns original object if acceptsToken is "any"', () => {
const result = getAuthObjectForAcceptedToken({ authObject: machineAuth, acceptsToken: 'any' });
expect(result).toBe(machineAuth);
});

it('returns original object if token type matches', () => {
const result = getAuthObjectForAcceptedToken({ authObject: machineAuth, acceptsToken: 'api_key' });
expect(result).toBe(machineAuth);
});

it('returns InvalidTokenAuthObject if acceptsToken is array and token type does not match', () => {
const result = getAuthObjectForAcceptedToken({
authObject: machineAuth,
acceptsToken: ['machine_token', 'oauth_token'],
});
expect((result as InvalidTokenAuthObject).tokenType).toBeNull();
expect((result as InvalidTokenAuthObject).isAuthenticated).toBe(false);
});

it('returns InvalidTokenAuthObject if parsed type is not a machine token and does not match any in acceptsToken array', () => {
const result = getAuthObjectForAcceptedToken({ authObject: sessionAuth, acceptsToken: ['api_key', 'oauth_token'] });
expect((result as InvalidTokenAuthObject).tokenType).toBeNull();
expect((result as InvalidTokenAuthObject).isAuthenticated).toBe(false);
});

it('returns signed-out session object if parsed type is not a machine token and does not match', () => {
const result = getAuthObjectForAcceptedToken({ authObject: sessionAuth, acceptsToken: ['api_key', 'oauth_token'] });
expect((result as InvalidTokenAuthObject).tokenType).toBeNull();
expect((result as InvalidTokenAuthObject).isAuthenticated).toBe(false);
});

it('returns unauthenticated object for requested type if acceptsToken is a single value and does not match', () => {
const result = getAuthObjectForAcceptedToken({ authObject: machineAuth, acceptsToken: 'machine_token' });
expect((result as UnauthenticatedMachineObject<'machine_token'>).tokenType).toBe('machine_token');
expect((result as UnauthenticatedMachineObject<'machine_token'>).id).toBeNull();
});
});
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/__tests__/getAuth.test-d.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { expectTypeOf, test } from 'vitest';

import type { AuthObject } from '../authObjects';
import type { AuthObject, InvalidTokenAuthObject } from '../authObjects';
import type { GetAuthFn, MachineAuthObject, SessionAuthObject } from '../types';

// Across our SDKs, we have a getAuth() function
Expand All@@ -22,10 +22,10 @@ test('infers the correct AuthObject type for each accepted token type', () => {

// Array of token types
expectTypeOf(getAuth(request, { acceptsToken: ['session_token', 'machine_token'] })).toMatchTypeOf<
SessionAuthObject | MachineAuthObject<'machine_token'>
SessionAuthObject | MachineAuthObject<'machine_token'> | InvalidTokenAuthObject
>();
expectTypeOf(getAuth(request, { acceptsToken: ['machine_token', 'oauth_token'] })).toMatchTypeOf<
MachineAuthObject<'machine_token' | 'oauth_token'>
MachineAuthObject<'machine_token' | 'oauth_token'> | InvalidTokenAuthObject
>();

// Any token type
Expand Down
29 changes: 21 additions & 8 deletions packages/backend/src/tokens/__tests__/machine.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,33 +3,34 @@ import { describe, expect, it } from 'vitest';
import {
API_KEY_PREFIX,
getMachineTokenType,
isMachineToken,
isMachineTokenByPrefix,
isMachineTokenType,
isTokenTypeAccepted,
M2M_TOKEN_PREFIX,
OAUTH_TOKEN_PREFIX,
} from '../machine';

describe('isMachineToken', () => {
it('returns true for tokens with M2M prefix', () => {
expect(isMachineToken(`${M2M_TOKEN_PREFIX}some-token-value`)).toBe(true);
expect(isMachineTokenByPrefix(`${M2M_TOKEN_PREFIX}some-token-value`)).toBe(true);
});

it('returns true for tokens with OAuth prefix', () => {
expect(isMachineToken(`${OAUTH_TOKEN_PREFIX}some-token-value`)).toBe(true);
expect(isMachineTokenByPrefix(`${OAUTH_TOKEN_PREFIX}some-token-value`)).toBe(true);
});

it('returns true for tokens with API key prefix', () => {
expect(isMachineToken(`${API_KEY_PREFIX}some-token-value`)).toBe(true);
expect(isMachineTokenByPrefix(`${API_KEY_PREFIX}some-token-value`)).toBe(true);
});

it('returns false for tokens without a recognized prefix', () => {
expect(isMachineToken('unknown_prefix_token')).toBe(false);
expect(isMachineToken('session_token_value')).toBe(false);
expect(isMachineToken('jwt_token_value')).toBe(false);
expect(isMachineTokenByPrefix('unknown_prefix_token')).toBe(false);
expect(isMachineTokenByPrefix('session_token_value')).toBe(false);
expect(isMachineTokenByPrefix('jwt_token_value')).toBe(false);
});

it('returns false for empty tokens', () => {
expect(isMachineToken('')).toBe(false);
expect(isMachineTokenByPrefix('')).toBe(false);
});
});

Expand DownExpand Up@@ -78,3 +79,15 @@ describe('isTokenTypeAccepted', () => {
expect(isTokenTypeAccepted('api_key', 'machine_token')).toBe(false);
});
});

describe('isMachineTokenType', () => {
it('returns true for machine token types', () => {
expect(isMachineTokenType('api_key')).toBe(true);
expect(isMachineTokenType('machine_token')).toBe(true);
expect(isMachineTokenType('oauth_token')).toBe(true);
});

it('returns false for non-machine token types', () => {
expect(isMachineTokenType('session_token')).toBe(false);
});
});
87 changes: 49 additions & 38 deletions packages/backend/src/tokens/authObjects.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ import type { APIKey, CreateBackendApiOptions, IdPOAuthAccessToken, MachineToken
import { createBackendApiClient } from '../api';
import { isTokenTypeAccepted } from '../internal';
import type { AuthenticateContext } from './authenticateContext';
import { isMachineTokenType } from './machine';
import type { MachineTokenType, SessionTokenType } from './tokenTypes';
import { TokenType } from './tokenTypes';
import type { AuthenticateRequestOptions, MachineAuthType } from './types';
Expand DownExpand Up@@ -57,6 +58,7 @@ export type SignedInAuthObject = SharedSignedInAuthObjectProperties & {
* Used to help debug issues when using Clerk in development.
*/
debug: AuthObjectDebug;
isAuthenticated: true;
};

/**
Expand All@@ -77,6 +79,7 @@ export type SignedOutAuthObject = {
getToken: ServerGetToken;
has: CheckAuthorizationFromSessionClaims;
debug: AuthObjectDebug;
isAuthenticated: false;
};

/**
Expand DownExpand Up@@ -120,6 +123,7 @@ export type AuthenticatedMachineObject<T extends MachineTokenType = MachineToken
has: CheckAuthorizationFromSessionClaims;
debug: AuthObjectDebug;
tokenType: T;
isAuthenticated: true;
} & MachineObjectExtendedProperties<true>[T]
: never;

Expand All@@ -140,17 +144,27 @@ export type UnauthenticatedMachineObject<T extends MachineTokenType = MachineTok
has: CheckAuthorizationFromSessionClaims;
debug: AuthObjectDebug;
tokenType: T;
isAuthenticated: false;
} & MachineObjectExtendedProperties<false>[T]
: never;

export type InvalidTokenAuthObject = {
isAuthenticated: false;
tokenType: null;
getToken: () => Promise<null>;
has: () => false;
debug: AuthObjectDebug;
};

/**
* @interface
*/
export type AuthObject =
| SignedInAuthObject
| SignedOutAuthObject
| AuthenticatedMachineObject
| UnauthenticatedMachineObject;
| UnauthenticatedMachineObject
| InvalidTokenAuthObject;

const createDebug = (data: AuthObjectDebugData | undefined) => {
return () => {
Expand DownExpand Up@@ -200,6 +214,7 @@ export function signedInAuthObject(
plans: (sessionClaims.pla as string) || '',
}),
debug: createDebug({ ...authenticateContext, sessionToken }),
isAuthenticated: true,
};
}

Expand All@@ -225,6 +240,7 @@ export function signedOutAuthObject(
getToken: () => Promise.resolve(null),
has: () => false,
debug: createDebug(debugData),
isAuthenticated: false,
};
}

Expand All@@ -243,6 +259,7 @@ export function authenticatedMachineObject<T extends MachineTokenType>(
getToken: () => Promise.resolve(token),
has: () => false,
debug: createDebug(debugData),
isAuthenticated: true,
};

// Type assertions are safe here since we know the verification result type matches the tokenType.
Expand DownExpand Up@@ -302,6 +319,7 @@ export function unauthenticatedMachineObject<T extends MachineTokenType>(
has: () => false,
getToken: () => Promise.resolve(null),
debug: createDebug(debugData),
isAuthenticated: false,
};

switch (tokenType) {
Expand DownExpand Up@@ -340,6 +358,19 @@ export function unauthenticatedMachineObject<T extends MachineTokenType>(
}
}

/**
* @internal
*/
export function invalidTokenAuthObject(): InvalidTokenAuthObject {
return {
isAuthenticated: false,
tokenType: null,
getToken: () => Promise.resolve(null),
has: () => false,
debug: () => ({}),
};
}

/**
* Auth objects moving through the server -> client boundary need to be serializable
* as we need to ensure that they can be transferred via the network as pure strings.
Expand DownExpand Up@@ -394,42 +425,13 @@ export const getAuthObjectFromJwt = (

/**
* @internal
* Filters and coerces an AuthObject based on the accepted token type(s).
*
* This function is used after authentication to ensure that the returned auth object
* matches the expected token type(s) specified by `acceptsToken`. If the token type
* of the provided `authObject` does not match any of the types in `acceptsToken`,
* it returns an unauthenticated or signed-out version of the object, depending on the token type.
*
* - If `acceptsToken` is `'any'`, the original auth object is returned.
* - If `acceptsToken` is a single token type or an array of token types, the function checks if
* `authObject.tokenType` matches any of them.
* - If the token type does not match and is a session token, a signed-out object is returned.
* - If the token type does not match and is a machine token, an unauthenticated machine object is returned.
* - If the token type matches, the original auth object is returned.
*
* @param {Object} params
* @param {AuthObject} params.authObject - The authenticated object to filter.
* @param {AuthenticateRequestOptions['acceptsToken']} [params.acceptsToken=TokenType.SessionToken] - The accepted token type(s). Can be a string, array of strings, or 'any'.
* @returns {AuthObject} The filtered or coerced auth object.
* Returns an auth object matching the requested token type(s).
*
* @example
* // Accept only 'api_key' tokens
* const authObject = { tokenType: 'session_token', userId: 'user_123' };
* const result = getAuthObjectForAcceptedToken({ authObject, acceptsToken: 'api_key' });
* // result will be a signed-out object (since tokenType is 'session_token' and does not match)
* If the parsed token type does not match any in acceptsToken, returns:
* - an unauthenticated machine object for the first machine token type in acceptsToken (if present), or
* - a signed-out session object otherwise.
*
* @example
* // Accept 'api_key' or 'machine_token'
* const authObject = { tokenType: 'machine_token', id: 'm2m_123' };
* const result = getAuthObjectForAcceptedToken({ authObject, acceptsToken: ['api_key', 'machine_token'] });
* // result will be the original authObject (since tokenType matches one in the array)
*
* @example
* // Accept any token type
* const authObject = { tokenType: 'api_key', id: 'ak_123' };
* const result = getAuthObjectForAcceptedToken({ authObject, acceptsToken: 'any' });
* // result will be the original authObject
* This ensures the returned object always matches the developer's intent.
*/
export function getAuthObjectForAcceptedToken({
authObject,
Expand All@@ -442,11 +444,20 @@ export function getAuthObjectForAcceptedToken({
return authObject;
}

if (Array.isArray(acceptsToken)) {
if (!isTokenTypeAccepted(authObject.tokenType, acceptsToken)) {
// If the token is not in the accepted array, return invalid token auth object
return invalidTokenAuthObject();
}
return authObject;
}
Comment thread
wobsoriano marked this conversation as resolved.

// Single value: Intent based
if (!isTokenTypeAccepted(authObject.tokenType, acceptsToken)) {
if (authObject.tokenType === TokenType.SessionToken) {
return signedOutAuthObject(authObject.debug);
if (isMachineTokenType(acceptsToken)) {
return unauthenticatedMachineObject(acceptsToken, authObject.debug);
}
return unauthenticatedMachineObject(authObject.tokenType, authObject.debug);
return signedOutAuthObject(authObject.debug);
}

return authObject;
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/open-swans-count.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
'@clerk/backend': minor
'@clerk/nextjs': minor
---

Respect `acceptsToken` when returning unauthenticated session or machine object.
4 changes: 3 additions & 1 deletion packages/backend/src/__tests__/exports.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,9 @@ describe('subpath /internal exports', () => {
"getAuthObjectForAcceptedToken",
"getAuthObjectFromJwt",
"getMachineTokenType",
"isMachineToken",
"invalidTokenAuthObject",
"isMachineTokenByPrefix",
"isMachineTokenType",
"isTokenTypeAccepted",
"makeAuthObjectSerializable",
"reverificationError",
Expand Down
2 changes: 1 addition & 1 deletion packages/backend/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -161,5 +161,5 @@ export type {
/**
* Auth objects
*/
export type { AuthObject } from './tokens/authObjects';
export type { AuthObject, InvalidTokenAuthObject } from './tokens/authObjects';
export type { SessionAuthObject, MachineAuthObject } from './tokens/types';
3 changes: 2 additions & 1 deletion packages/backend/src/internal.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,6 +31,7 @@ export {
signedInAuthObject,
authenticatedMachineObject,
unauthenticatedMachineObject,
invalidTokenAuthObject,
getAuthObjectFromJwt,
getAuthObjectForAcceptedToken,
} from './tokens/authObjects';
Expand All@@ -53,4 +54,4 @@ export { reverificationError, reverificationErrorResponse } from '@clerk/shared/

export { verifyMachineAuthToken } from './tokens/verify';

export { isMachineToken, getMachineTokenType, isTokenTypeAccepted } from './tokens/machine';
export { isMachineTokenByPrefix, isMachineTokenType, getMachineTokenType, isTokenTypeAccepted } from './tokens/machine';
45 changes: 45 additions & 0 deletions packages/backend/src/tokens/__tests__/authObjects.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,10 @@ import { describe, expect, it } from 'vitest';

import { mockTokens, mockVerificationResults } from '../../fixtures/machine';
import type { AuthenticateContext } from '../authenticateContext';
import type { InvalidTokenAuthObject, UnauthenticatedMachineObject } from '../authObjects';
import {
authenticatedMachineObject,
getAuthObjectForAcceptedToken,
makeAuthObjectSerializable,
signedInAuthObject,
signedOutAuthObject,
Expand DownExpand Up@@ -387,3 +389,46 @@ describe('unauthenticatedMachineObject', () => {
expect(retrievedToken).toBeNull();
});
});

describe('getAuthObjectForAcceptedToken', () => {
const debugData = { foo: 'bar' };
const sessionAuth = signedOutAuthObject(debugData);
const machineAuth = authenticatedMachineObject('api_key', 'ak_xxx', mockVerificationResults.api_key, debugData);

it('returns original object if acceptsToken is "any"', () => {
const result = getAuthObjectForAcceptedToken({ authObject: machineAuth, acceptsToken: 'any' });
expect(result).toBe(machineAuth);
});

it('returns original object if token type matches', () => {
const result = getAuthObjectForAcceptedToken({ authObject: machineAuth, acceptsToken: 'api_key' });
expect(result).toBe(machineAuth);
});

it('returns InvalidTokenAuthObject if acceptsToken is array and token type does not match', () => {
const result = getAuthObjectForAcceptedToken({
authObject: machineAuth,
acceptsToken: ['machine_token', 'oauth_token'],
});
expect((result as InvalidTokenAuthObject).tokenType).toBeNull();
expect((result as InvalidTokenAuthObject).isAuthenticated).toBe(false);
});

it('returns InvalidTokenAuthObject if parsed type is not a machine token and does not match any in acceptsToken array', () => {
const result = getAuthObjectForAcceptedToken({ authObject: sessionAuth, acceptsToken: ['api_key', 'oauth_token'] });
expect((result as InvalidTokenAuthObject).tokenType).toBeNull();
expect((result as InvalidTokenAuthObject).isAuthenticated).toBe(false);
});

it('returns signed-out session object if parsed type is not a machine token and does not match', () => {
const result = getAuthObjectForAcceptedToken({ authObject: sessionAuth, acceptsToken: ['api_key', 'oauth_token'] });
expect((result as InvalidTokenAuthObject).tokenType).toBeNull();
expect((result as InvalidTokenAuthObject).isAuthenticated).toBe(false);
});

it('returns unauthenticated object for requested type if acceptsToken is a single value and does not match', () => {
const result = getAuthObjectForAcceptedToken({ authObject: machineAuth, acceptsToken: 'machine_token' });
expect((result as UnauthenticatedMachineObject<'machine_token'>).tokenType).toBe('machine_token');
expect((result as UnauthenticatedMachineObject<'machine_token'>).id).toBeNull();
});
});
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/__tests__/getAuth.test-d.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { expectTypeOf, test } from 'vitest';

import type { AuthObject } from '../authObjects';
import type { AuthObject, InvalidTokenAuthObject } from '../authObjects';
import type { GetAuthFn, MachineAuthObject, SessionAuthObject } from '../types';

// Across our SDKs, we have a getAuth() function
Expand All@@ -22,10 +22,10 @@ test('infers the correct AuthObject type for each accepted token type', () => {

// Array of token types
expectTypeOf(getAuth(request, { acceptsToken: ['session_token', 'machine_token'] })).toMatchTypeOf<
SessionAuthObject | MachineAuthObject<'machine_token'>
SessionAuthObject | MachineAuthObject<'machine_token'> | InvalidTokenAuthObject
>();
expectTypeOf(getAuth(request, { acceptsToken: ['machine_token', 'oauth_token'] })).toMatchTypeOf<
MachineAuthObject<'machine_token' | 'oauth_token'>
MachineAuthObject<'machine_token' | 'oauth_token'> | InvalidTokenAuthObject
>();

// Any token type
Expand Down
29 changes: 21 additions & 8 deletions packages/backend/src/tokens/__tests__/machine.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,33 +3,34 @@ import { describe, expect, it } from 'vitest';
import {
API_KEY_PREFIX,
getMachineTokenType,
isMachineToken,
isMachineTokenByPrefix,
isMachineTokenType,
isTokenTypeAccepted,
M2M_TOKEN_PREFIX,
OAUTH_TOKEN_PREFIX,
} from '../machine';

describe('isMachineToken', () => {
it('returns true for tokens with M2M prefix', () => {
expect(isMachineToken(`${M2M_TOKEN_PREFIX}some-token-value`)).toBe(true);
expect(isMachineTokenByPrefix(`${M2M_TOKEN_PREFIX}some-token-value`)).toBe(true);
});

it('returns true for tokens with OAuth prefix', () => {
expect(isMachineToken(`${OAUTH_TOKEN_PREFIX}some-token-value`)).toBe(true);
expect(isMachineTokenByPrefix(`${OAUTH_TOKEN_PREFIX}some-token-value`)).toBe(true);
});

it('returns true for tokens with API key prefix', () => {
expect(isMachineToken(`${API_KEY_PREFIX}some-token-value`)).toBe(true);
expect(isMachineTokenByPrefix(`${API_KEY_PREFIX}some-token-value`)).toBe(true);
});

it('returns false for tokens without a recognized prefix', () => {
expect(isMachineToken('unknown_prefix_token')).toBe(false);
expect(isMachineToken('session_token_value')).toBe(false);
expect(isMachineToken('jwt_token_value')).toBe(false);
expect(isMachineTokenByPrefix('unknown_prefix_token')).toBe(false);
expect(isMachineTokenByPrefix('session_token_value')).toBe(false);
expect(isMachineTokenByPrefix('jwt_token_value')).toBe(false);
});

it('returns false for empty tokens', () => {
expect(isMachineToken('')).toBe(false);
expect(isMachineTokenByPrefix('')).toBe(false);
});
});

Expand DownExpand Up@@ -78,3 +79,15 @@ describe('isTokenTypeAccepted', () => {
expect(isTokenTypeAccepted('api_key', 'machine_token')).toBe(false);
});
});

describe('isMachineTokenType', () => {
it('returns true for machine token types', () => {
expect(isMachineTokenType('api_key')).toBe(true);
expect(isMachineTokenType('machine_token')).toBe(true);
expect(isMachineTokenType('oauth_token')).toBe(true);
});

it('returns false for non-machine token types', () => {
expect(isMachineTokenType('session_token')).toBe(false);
});
});
87 changes: 49 additions & 38 deletions packages/backend/src/tokens/authObjects.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ import type { APIKey, CreateBackendApiOptions, IdPOAuthAccessToken, MachineToken
import { createBackendApiClient } from '../api';
import { isTokenTypeAccepted } from '../internal';
import type { AuthenticateContext } from './authenticateContext';
import { isMachineTokenType } from './machine';
import type { MachineTokenType, SessionTokenType } from './tokenTypes';
import { TokenType } from './tokenTypes';
import type { AuthenticateRequestOptions, MachineAuthType } from './types';
Expand DownExpand Up@@ -57,6 +58,7 @@ export type SignedInAuthObject = SharedSignedInAuthObjectProperties & {
* Used to help debug issues when using Clerk in development.
*/
debug: AuthObjectDebug;
isAuthenticated: true;
};

/**
Expand All@@ -77,6 +79,7 @@ export type SignedOutAuthObject = {
getToken: ServerGetToken;
has: CheckAuthorizationFromSessionClaims;
debug: AuthObjectDebug;
isAuthenticated: false;
};

/**
Expand DownExpand Up@@ -120,6 +123,7 @@ export type AuthenticatedMachineObject<T extends MachineTokenType = MachineToken
has: CheckAuthorizationFromSessionClaims;
debug: AuthObjectDebug;
tokenType: T;
isAuthenticated: true;
} & MachineObjectExtendedProperties<true>[T]
: never;

Expand All@@ -140,17 +144,27 @@ export type UnauthenticatedMachineObject<T extends MachineTokenType = MachineTok
has: CheckAuthorizationFromSessionClaims;
debug: AuthObjectDebug;
tokenType: T;
isAuthenticated: false;
} & MachineObjectExtendedProperties<false>[T]
: never;

export type InvalidTokenAuthObject = {
isAuthenticated: false;
tokenType: null;
getToken: () => Promise<null>;
has: () => false;
debug: AuthObjectDebug;
};

/**
* @interface
*/
export type AuthObject =
| SignedInAuthObject
| SignedOutAuthObject
| AuthenticatedMachineObject
| UnauthenticatedMachineObject;
| UnauthenticatedMachineObject
| InvalidTokenAuthObject;

const createDebug = (data: AuthObjectDebugData | undefined) => {
return () => {
Expand DownExpand Up@@ -200,6 +214,7 @@ export function signedInAuthObject(
plans: (sessionClaims.pla as string) || '',
}),
debug: createDebug({ ...authenticateContext, sessionToken }),
isAuthenticated: true,
};
}

Expand All@@ -225,6 +240,7 @@ export function signedOutAuthObject(
getToken: () => Promise.resolve(null),
has: () => false,
debug: createDebug(debugData),
isAuthenticated: false,
};
}

Expand All@@ -243,6 +259,7 @@ export function authenticatedMachineObject<T extends MachineTokenType>(
getToken: () => Promise.resolve(token),
has: () => false,
debug: createDebug(debugData),
isAuthenticated: true,
};

// Type assertions are safe here since we know the verification result type matches the tokenType.
Expand DownExpand Up@@ -302,6 +319,7 @@ export function unauthenticatedMachineObject<T extends MachineTokenType>(
has: () => false,
getToken: () => Promise.resolve(null),
debug: createDebug(debugData),
isAuthenticated: false,
};

switch (tokenType) {
Expand DownExpand Up@@ -340,6 +358,19 @@ export function unauthenticatedMachineObject<T extends MachineTokenType>(
}
}

/**
* @internal
*/
export function invalidTokenAuthObject(): InvalidTokenAuthObject {
return {
isAuthenticated: false,
tokenType: null,
getToken: () => Promise.resolve(null),
has: () => false,
debug: () => ({}),
};
}

/**
* Auth objects moving through the server -> client boundary need to be serializable
* as we need to ensure that they can be transferred via the network as pure strings.
Expand DownExpand Up@@ -394,42 +425,13 @@ export const getAuthObjectFromJwt = (

/**
* @internal
* Filters and coerces an AuthObject based on the accepted token type(s).
*
* This function is used after authentication to ensure that the returned auth object
* matches the expected token type(s) specified by `acceptsToken`. If the token type
* of the provided `authObject` does not match any of the types in `acceptsToken`,
* it returns an unauthenticated or signed-out version of the object, depending on the token type.
*
* - If `acceptsToken` is `'any'`, the original auth object is returned.
* - If `acceptsToken` is a single token type or an array of token types, the function checks if
* `authObject.tokenType` matches any of them.
* - If the token type does not match and is a session token, a signed-out object is returned.
* - If the token type does not match and is a machine token, an unauthenticated machine object is returned.
* - If the token type matches, the original auth object is returned.
*
* @param {Object} params
* @param {AuthObject} params.authObject - The authenticated object to filter.
* @param {AuthenticateRequestOptions['acceptsToken']} [params.acceptsToken=TokenType.SessionToken] - The accepted token type(s). Can be a string, array of strings, or 'any'.
* @returns {AuthObject} The filtered or coerced auth object.
* Returns an auth object matching the requested token type(s).
*
* @example
* // Accept only 'api_key' tokens
* const authObject = { tokenType: 'session_token', userId: 'user_123' };
* const result = getAuthObjectForAcceptedToken({ authObject, acceptsToken: 'api_key' });
* // result will be a signed-out object (since tokenType is 'session_token' and does not match)
* If the parsed token type does not match any in acceptsToken, returns:
* - an unauthenticated machine object for the first machine token type in acceptsToken (if present), or
* - a signed-out session object otherwise.
*
* @example
* // Accept 'api_key' or 'machine_token'
* const authObject = { tokenType: 'machine_token', id: 'm2m_123' };
* const result = getAuthObjectForAcceptedToken({ authObject, acceptsToken: ['api_key', 'machine_token'] });
* // result will be the original authObject (since tokenType matches one in the array)
*
* @example
* // Accept any token type
* const authObject = { tokenType: 'api_key', id: 'ak_123' };
* const result = getAuthObjectForAcceptedToken({ authObject, acceptsToken: 'any' });
* // result will be the original authObject
* This ensures the returned object always matches the developer's intent.
*/
export function getAuthObjectForAcceptedToken({
authObject,
Expand All@@ -442,11 +444,20 @@ export function getAuthObjectForAcceptedToken({
return authObject;
}

if (Array.isArray(acceptsToken)) {
if (!isTokenTypeAccepted(authObject.tokenType, acceptsToken)) {
// If the token is not in the accepted array, return invalid token auth object
return invalidTokenAuthObject();
}
return authObject;
}
Comment thread
wobsoriano marked this conversation as resolved.

// Single value: Intent based
if (!isTokenTypeAccepted(authObject.tokenType, acceptsToken)) {
if (authObject.tokenType === TokenType.SessionToken) {
return signedOutAuthObject(authObject.debug);
if (isMachineTokenType(acceptsToken)) {
return unauthenticatedMachineObject(acceptsToken, authObject.debug);
}
return unauthenticatedMachineObject(authObject.tokenType, authObject.debug);
return signedOutAuthObject(authObject.debug);
}

return authObject;
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/open-swans-count.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
'@clerk/backend': minor
'@clerk/nextjs': minor
---

Respect `acceptsToken` when returning unauthenticated session or machine object.
4 changes: 3 additions & 1 deletion packages/backend/src/__tests__/exports.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,9 @@ describe('subpath /internal exports', () => {
"getAuthObjectForAcceptedToken",
"getAuthObjectFromJwt",
"getMachineTokenType",
"isMachineToken",
"invalidTokenAuthObject",
"isMachineTokenByPrefix",
"isMachineTokenType",
"isTokenTypeAccepted",
"makeAuthObjectSerializable",
"reverificationError",
Expand Down
2 changes: 1 addition & 1 deletion packages/backend/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -161,5 +161,5 @@ export type {
/**
* Auth objects
*/
export type { AuthObject } from './tokens/authObjects';
export type { AuthObject, InvalidTokenAuthObject } from './tokens/authObjects';
export type { SessionAuthObject, MachineAuthObject } from './tokens/types';
3 changes: 2 additions & 1 deletion packages/backend/src/internal.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,6 +31,7 @@ export {
signedInAuthObject,
authenticatedMachineObject,
unauthenticatedMachineObject,
invalidTokenAuthObject,
getAuthObjectFromJwt,
getAuthObjectForAcceptedToken,
} from './tokens/authObjects';
Expand All@@ -53,4 +54,4 @@ export { reverificationError, reverificationErrorResponse } from '@clerk/shared/

export { verifyMachineAuthToken } from './tokens/verify';

export { isMachineToken, getMachineTokenType, isTokenTypeAccepted } from './tokens/machine';
export { isMachineTokenByPrefix, isMachineTokenType, getMachineTokenType, isTokenTypeAccepted } from './tokens/machine';
45 changes: 45 additions & 0 deletions packages/backend/src/tokens/__tests__/authObjects.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,10 @@ import { describe, expect, it } from 'vitest';

import { mockTokens, mockVerificationResults } from '../../fixtures/machine';
import type { AuthenticateContext } from '../authenticateContext';
import type { InvalidTokenAuthObject, UnauthenticatedMachineObject } from '../authObjects';
import {
authenticatedMachineObject,
getAuthObjectForAcceptedToken,
makeAuthObjectSerializable,
signedInAuthObject,
signedOutAuthObject,
Expand DownExpand Up@@ -387,3 +389,46 @@ describe('unauthenticatedMachineObject', () => {
expect(retrievedToken).toBeNull();
});
});

describe('getAuthObjectForAcceptedToken', () => {
const debugData = { foo: 'bar' };
const sessionAuth = signedOutAuthObject(debugData);
const machineAuth = authenticatedMachineObject('api_key', 'ak_xxx', mockVerificationResults.api_key, debugData);

it('returns original object if acceptsToken is "any"', () => {
const result = getAuthObjectForAcceptedToken({ authObject: machineAuth, acceptsToken: 'any' });
expect(result).toBe(machineAuth);
});

it('returns original object if token type matches', () => {
const result = getAuthObjectForAcceptedToken({ authObject: machineAuth, acceptsToken: 'api_key' });
expect(result).toBe(machineAuth);
});

it('returns InvalidTokenAuthObject if acceptsToken is array and token type does not match', () => {
const result = getAuthObjectForAcceptedToken({
authObject: machineAuth,
acceptsToken: ['machine_token', 'oauth_token'],
});
expect((result as InvalidTokenAuthObject).tokenType).toBeNull();
expect((result as InvalidTokenAuthObject).isAuthenticated).toBe(false);
});

it('returns InvalidTokenAuthObject if parsed type is not a machine token and does not match any in acceptsToken array', () => {
const result = getAuthObjectForAcceptedToken({ authObject: sessionAuth, acceptsToken: ['api_key', 'oauth_token'] });
expect((result as InvalidTokenAuthObject).tokenType).toBeNull();
expect((result as InvalidTokenAuthObject).isAuthenticated).toBe(false);
});

it('returns signed-out session object if parsed type is not a machine token and does not match', () => {
const result = getAuthObjectForAcceptedToken({ authObject: sessionAuth, acceptsToken: ['api_key', 'oauth_token'] });
expect((result as InvalidTokenAuthObject).tokenType).toBeNull();
expect((result as InvalidTokenAuthObject).isAuthenticated).toBe(false);
});

it('returns unauthenticated object for requested type if acceptsToken is a single value and does not match', () => {
const result = getAuthObjectForAcceptedToken({ authObject: machineAuth, acceptsToken: 'machine_token' });
expect((result as UnauthenticatedMachineObject<'machine_token'>).tokenType).toBe('machine_token');
expect((result as UnauthenticatedMachineObject<'machine_token'>).id).toBeNull();
});
});
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/__tests__/getAuth.test-d.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { expectTypeOf, test } from 'vitest';

import type { AuthObject } from '../authObjects';
import type { AuthObject, InvalidTokenAuthObject } from '../authObjects';
import type { GetAuthFn, MachineAuthObject, SessionAuthObject } from '../types';

// Across our SDKs, we have a getAuth() function
Expand All@@ -22,10 +22,10 @@ test('infers the correct AuthObject type for each accepted token type', () => {

// Array of token types
expectTypeOf(getAuth(request, { acceptsToken: ['session_token', 'machine_token'] })).toMatchTypeOf<
SessionAuthObject | MachineAuthObject<'machine_token'>
SessionAuthObject | MachineAuthObject<'machine_token'> | InvalidTokenAuthObject
>();
expectTypeOf(getAuth(request, { acceptsToken: ['machine_token', 'oauth_token'] })).toMatchTypeOf<
MachineAuthObject<'machine_token' | 'oauth_token'>
MachineAuthObject<'machine_token' | 'oauth_token'> | InvalidTokenAuthObject
>();

// Any token type
Expand Down
29 changes: 21 additions & 8 deletions packages/backend/src/tokens/__tests__/machine.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,33 +3,34 @@ import { describe, expect, it } from 'vitest';
import {
API_KEY_PREFIX,
getMachineTokenType,
isMachineToken,
isMachineTokenByPrefix,
isMachineTokenType,
isTokenTypeAccepted,
M2M_TOKEN_PREFIX,
OAUTH_TOKEN_PREFIX,
} from '../machine';

describe('isMachineToken', () => {
it('returns true for tokens with M2M prefix', () => {
expect(isMachineToken(`${M2M_TOKEN_PREFIX}some-token-value`)).toBe(true);
expect(isMachineTokenByPrefix(`${M2M_TOKEN_PREFIX}some-token-value`)).toBe(true);
});

it('returns true for tokens with OAuth prefix', () => {
expect(isMachineToken(`${OAUTH_TOKEN_PREFIX}some-token-value`)).toBe(true);
expect(isMachineTokenByPrefix(`${OAUTH_TOKEN_PREFIX}some-token-value`)).toBe(true);
});

it('returns true for tokens with API key prefix', () => {
expect(isMachineToken(`${API_KEY_PREFIX}some-token-value`)).toBe(true);
expect(isMachineTokenByPrefix(`${API_KEY_PREFIX}some-token-value`)).toBe(true);
});

it('returns false for tokens without a recognized prefix', () => {
expect(isMachineToken('unknown_prefix_token')).toBe(false);
expect(isMachineToken('session_token_value')).toBe(false);
expect(isMachineToken('jwt_token_value')).toBe(false);
expect(isMachineTokenByPrefix('unknown_prefix_token')).toBe(false);
expect(isMachineTokenByPrefix('session_token_value')).toBe(false);
expect(isMachineTokenByPrefix('jwt_token_value')).toBe(false);
});

it('returns false for empty tokens', () => {
expect(isMachineToken('')).toBe(false);
expect(isMachineTokenByPrefix('')).toBe(false);
});
});

Expand DownExpand Up@@ -78,3 +79,15 @@ describe('isTokenTypeAccepted', () => {
expect(isTokenTypeAccepted('api_key', 'machine_token')).toBe(false);
});
});

describe('isMachineTokenType', () => {
it('returns true for machine token types', () => {
expect(isMachineTokenType('api_key')).toBe(true);
expect(isMachineTokenType('machine_token')).toBe(true);
expect(isMachineTokenType('oauth_token')).toBe(true);
});

it('returns false for non-machine token types', () => {
expect(isMachineTokenType('session_token')).toBe(false);
});
});
87 changes: 49 additions & 38 deletions packages/backend/src/tokens/authObjects.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ import type { APIKey, CreateBackendApiOptions, IdPOAuthAccessToken, MachineToken
import { createBackendApiClient } from '../api';
import { isTokenTypeAccepted } from '../internal';
import type { AuthenticateContext } from './authenticateContext';
import { isMachineTokenType } from './machine';
import type { MachineTokenType, SessionTokenType } from './tokenTypes';
import { TokenType } from './tokenTypes';
import type { AuthenticateRequestOptions, MachineAuthType } from './types';
Expand DownExpand Up@@ -57,6 +58,7 @@ export type SignedInAuthObject = SharedSignedInAuthObjectProperties & {
* Used to help debug issues when using Clerk in development.
*/
debug: AuthObjectDebug;
isAuthenticated: true;
};

/**
Expand All@@ -77,6 +79,7 @@ export type SignedOutAuthObject = {
getToken: ServerGetToken;
has: CheckAuthorizationFromSessionClaims;
debug: AuthObjectDebug;
isAuthenticated: false;
};

/**
Expand DownExpand Up@@ -120,6 +123,7 @@ export type AuthenticatedMachineObject<T extends MachineTokenType = MachineToken
has: CheckAuthorizationFromSessionClaims;
debug: AuthObjectDebug;
tokenType: T;
isAuthenticated: true;
} & MachineObjectExtendedProperties<true>[T]
: never;

Expand All@@ -140,17 +144,27 @@ export type UnauthenticatedMachineObject<T extends MachineTokenType = MachineTok
has: CheckAuthorizationFromSessionClaims;
debug: AuthObjectDebug;
tokenType: T;
isAuthenticated: false;
} & MachineObjectExtendedProperties<false>[T]
: never;

export type InvalidTokenAuthObject = {
isAuthenticated: false;
tokenType: null;
getToken: () => Promise<null>;
has: () => false;
debug: AuthObjectDebug;
};

/**
* @interface
*/
export type AuthObject =
| SignedInAuthObject
| SignedOutAuthObject
| AuthenticatedMachineObject
| UnauthenticatedMachineObject;
| UnauthenticatedMachineObject
| InvalidTokenAuthObject;

const createDebug = (data: AuthObjectDebugData | undefined) => {
return () => {
Expand DownExpand Up@@ -200,6 +214,7 @@ export function signedInAuthObject(
plans: (sessionClaims.pla as string) || '',
}),
debug: createDebug({ ...authenticateContext, sessionToken }),
isAuthenticated: true,
};
}

Expand All@@ -225,6 +240,7 @@ export function signedOutAuthObject(
getToken: () => Promise.resolve(null),
has: () => false,
debug: createDebug(debugData),
isAuthenticated: false,
};
}

Expand All@@ -243,6 +259,7 @@ export function authenticatedMachineObject<T extends MachineTokenType>(
getToken: () => Promise.resolve(token),
has: () => false,
debug: createDebug(debugData),
isAuthenticated: true,
};

// Type assertions are safe here since we know the verification result type matches the tokenType.
Expand DownExpand Up@@ -302,6 +319,7 @@ export function unauthenticatedMachineObject<T extends MachineTokenType>(
has: () => false,
getToken: () => Promise.resolve(null),
debug: createDebug(debugData),
isAuthenticated: false,
};

switch (tokenType) {
Expand DownExpand Up@@ -340,6 +358,19 @@ export function unauthenticatedMachineObject<T extends MachineTokenType>(
}
}

/**
* @internal
*/
export function invalidTokenAuthObject(): InvalidTokenAuthObject {
return {
isAuthenticated: false,
tokenType: null,
getToken: () => Promise.resolve(null),
has: () => false,
debug: () => ({}),
};
}

/**
* Auth objects moving through the server -> client boundary need to be serializable
* as we need to ensure that they can be transferred via the network as pure strings.
Expand DownExpand Up@@ -394,42 +425,13 @@ export const getAuthObjectFromJwt = (

/**
* @internal
* Filters and coerces an AuthObject based on the accepted token type(s).
*
* This function is used after authentication to ensure that the returned auth object
* matches the expected token type(s) specified by `acceptsToken`. If the token type
* of the provided `authObject` does not match any of the types in `acceptsToken`,
* it returns an unauthenticated or signed-out version of the object, depending on the token type.
*
* - If `acceptsToken` is `'any'`, the original auth object is returned.
* - If `acceptsToken` is a single token type or an array of token types, the function checks if
* `authObject.tokenType` matches any of them.
* - If the token type does not match and is a session token, a signed-out object is returned.
* - If the token type does not match and is a machine token, an unauthenticated machine object is returned.
* - If the token type matches, the original auth object is returned.
*
* @param {Object} params
* @param {AuthObject} params.authObject - The authenticated object to filter.
* @param {AuthenticateRequestOptions['acceptsToken']} [params.acceptsToken=TokenType.SessionToken] - The accepted token type(s). Can be a string, array of strings, or 'any'.
* @returns {AuthObject} The filtered or coerced auth object.
* Returns an auth object matching the requested token type(s).
*
* @example
* // Accept only 'api_key' tokens
* const authObject = { tokenType: 'session_token', userId: 'user_123' };
* const result = getAuthObjectForAcceptedToken({ authObject, acceptsToken: 'api_key' });
* // result will be a signed-out object (since tokenType is 'session_token' and does not match)
* If the parsed token type does not match any in acceptsToken, returns:
* - an unauthenticated machine object for the first machine token type in acceptsToken (if present), or
* - a signed-out session object otherwise.
*
* @example
* // Accept 'api_key' or 'machine_token'
* const authObject = { tokenType: 'machine_token', id: 'm2m_123' };
* const result = getAuthObjectForAcceptedToken({ authObject, acceptsToken: ['api_key', 'machine_token'] });
* // result will be the original authObject (since tokenType matches one in the array)
*
* @example
* // Accept any token type
* const authObject = { tokenType: 'api_key', id: 'ak_123' };
* const result = getAuthObjectForAcceptedToken({ authObject, acceptsToken: 'any' });
* // result will be the original authObject
* This ensures the returned object always matches the developer's intent.
*/
export function getAuthObjectForAcceptedToken({
authObject,
Expand All@@ -442,11 +444,20 @@ export function getAuthObjectForAcceptedToken({
return authObject;
}

if (Array.isArray(acceptsToken)) {
if (!isTokenTypeAccepted(authObject.tokenType, acceptsToken)) {
// If the token is not in the accepted array, return invalid token auth object
return invalidTokenAuthObject();
}
return authObject;
}
Comment thread
wobsoriano marked this conversation as resolved.

// Single value: Intent based
if (!isTokenTypeAccepted(authObject.tokenType, acceptsToken)) {
if (authObject.tokenType === TokenType.SessionToken) {
return signedOutAuthObject(authObject.debug);
if (isMachineTokenType(acceptsToken)) {
return unauthenticatedMachineObject(acceptsToken, authObject.debug);
}
return unauthenticatedMachineObject(authObject.tokenType, authObject.debug);
return signedOutAuthObject(authObject.debug);
}

return authObject;
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/open-swans-count.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
'@clerk/backend': minor
'@clerk/nextjs': minor
---

Respect `acceptsToken` when returning unauthenticated session or machine object.
4 changes: 3 additions & 1 deletion packages/backend/src/__tests__/exports.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,9 @@ describe('subpath /internal exports', () => {
"getAuthObjectForAcceptedToken",
"getAuthObjectFromJwt",
"getMachineTokenType",
"isMachineToken",
"invalidTokenAuthObject",
"isMachineTokenByPrefix",
"isMachineTokenType",
"isTokenTypeAccepted",
"makeAuthObjectSerializable",
"reverificationError",
Expand Down
2 changes: 1 addition & 1 deletion packages/backend/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -161,5 +161,5 @@ export type {
/**
* Auth objects
*/
export type { AuthObject } from './tokens/authObjects';
export type { AuthObject, InvalidTokenAuthObject } from './tokens/authObjects';
export type { SessionAuthObject, MachineAuthObject } from './tokens/types';
3 changes: 2 additions & 1 deletion packages/backend/src/internal.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,6 +31,7 @@ export {
signedInAuthObject,
authenticatedMachineObject,
unauthenticatedMachineObject,
invalidTokenAuthObject,
getAuthObjectFromJwt,
getAuthObjectForAcceptedToken,
} from './tokens/authObjects';
Expand All@@ -53,4 +54,4 @@ export { reverificationError, reverificationErrorResponse } from '@clerk/shared/

export { verifyMachineAuthToken } from './tokens/verify';

export { isMachineToken, getMachineTokenType, isTokenTypeAccepted } from './tokens/machine';
export { isMachineTokenByPrefix, isMachineTokenType, getMachineTokenType, isTokenTypeAccepted } from './tokens/machine';
45 changes: 45 additions & 0 deletions packages/backend/src/tokens/__tests__/authObjects.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,10 @@ import { describe, expect, it } from 'vitest';

import { mockTokens, mockVerificationResults } from '../../fixtures/machine';
import type { AuthenticateContext } from '../authenticateContext';
import type { InvalidTokenAuthObject, UnauthenticatedMachineObject } from '../authObjects';
import {
authenticatedMachineObject,
getAuthObjectForAcceptedToken,
makeAuthObjectSerializable,
signedInAuthObject,
signedOutAuthObject,
Expand DownExpand Up@@ -387,3 +389,46 @@ describe('unauthenticatedMachineObject', () => {
expect(retrievedToken).toBeNull();
});
});

describe('getAuthObjectForAcceptedToken', () => {
const debugData = { foo: 'bar' };
const sessionAuth = signedOutAuthObject(debugData);
const machineAuth = authenticatedMachineObject('api_key', 'ak_xxx', mockVerificationResults.api_key, debugData);

it('returns original object if acceptsToken is "any"', () => {
const result = getAuthObjectForAcceptedToken({ authObject: machineAuth, acceptsToken: 'any' });
expect(result).toBe(machineAuth);
});

it('returns original object if token type matches', () => {
const result = getAuthObjectForAcceptedToken({ authObject: machineAuth, acceptsToken: 'api_key' });
expect(result).toBe(machineAuth);
});

it('returns InvalidTokenAuthObject if acceptsToken is array and token type does not match', () => {
const result = getAuthObjectForAcceptedToken({
authObject: machineAuth,
acceptsToken: ['machine_token', 'oauth_token'],
});
expect((result as InvalidTokenAuthObject).tokenType).toBeNull();
expect((result as InvalidTokenAuthObject).isAuthenticated).toBe(false);
});

it('returns InvalidTokenAuthObject if parsed type is not a machine token and does not match any in acceptsToken array', () => {
const result = getAuthObjectForAcceptedToken({ authObject: sessionAuth, acceptsToken: ['api_key', 'oauth_token'] });
expect((result as InvalidTokenAuthObject).tokenType).toBeNull();
expect((result as InvalidTokenAuthObject).isAuthenticated).toBe(false);
});

it('returns signed-out session object if parsed type is not a machine token and does not match', () => {
const result = getAuthObjectForAcceptedToken({ authObject: sessionAuth, acceptsToken: ['api_key', 'oauth_token'] });
expect((result as InvalidTokenAuthObject).tokenType).toBeNull();
expect((result as InvalidTokenAuthObject).isAuthenticated).toBe(false);
});

it('returns unauthenticated object for requested type if acceptsToken is a single value and does not match', () => {
const result = getAuthObjectForAcceptedToken({ authObject: machineAuth, acceptsToken: 'machine_token' });
expect((result as UnauthenticatedMachineObject<'machine_token'>).tokenType).toBe('machine_token');
expect((result as UnauthenticatedMachineObject<'machine_token'>).id).toBeNull();
});
});
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/__tests__/getAuth.test-d.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { expectTypeOf, test } from 'vitest';

import type { AuthObject } from '../authObjects';
import type { AuthObject, InvalidTokenAuthObject } from '../authObjects';
import type { GetAuthFn, MachineAuthObject, SessionAuthObject } from '../types';

// Across our SDKs, we have a getAuth() function
Expand All@@ -22,10 +22,10 @@ test('infers the correct AuthObject type for each accepted token type', () => {

// Array of token types
expectTypeOf(getAuth(request, { acceptsToken: ['session_token', 'machine_token'] })).toMatchTypeOf<
SessionAuthObject | MachineAuthObject<'machine_token'>
SessionAuthObject | MachineAuthObject<'machine_token'> | InvalidTokenAuthObject
>();
expectTypeOf(getAuth(request, { acceptsToken: ['machine_token', 'oauth_token'] })).toMatchTypeOf<
MachineAuthObject<'machine_token' | 'oauth_token'>
MachineAuthObject<'machine_token' | 'oauth_token'> | InvalidTokenAuthObject
>();

// Any token type
Expand Down
29 changes: 21 additions & 8 deletions packages/backend/src/tokens/__tests__/machine.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,33 +3,34 @@ import { describe, expect, it } from 'vitest';
import {
API_KEY_PREFIX,
getMachineTokenType,
isMachineToken,
isMachineTokenByPrefix,
isMachineTokenType,
isTokenTypeAccepted,
M2M_TOKEN_PREFIX,
OAUTH_TOKEN_PREFIX,
} from '../machine';

describe('isMachineToken', () => {
it('returns true for tokens with M2M prefix', () => {
expect(isMachineToken(`${M2M_TOKEN_PREFIX}some-token-value`)).toBe(true);
expect(isMachineTokenByPrefix(`${M2M_TOKEN_PREFIX}some-token-value`)).toBe(true);
});

it('returns true for tokens with OAuth prefix', () => {
expect(isMachineToken(`${OAUTH_TOKEN_PREFIX}some-token-value`)).toBe(true);
expect(isMachineTokenByPrefix(`${OAUTH_TOKEN_PREFIX}some-token-value`)).toBe(true);
});

it('returns true for tokens with API key prefix', () => {
expect(isMachineToken(`${API_KEY_PREFIX}some-token-value`)).toBe(true);
expect(isMachineTokenByPrefix(`${API_KEY_PREFIX}some-token-value`)).toBe(true);
});

it('returns false for tokens without a recognized prefix', () => {
expect(isMachineToken('unknown_prefix_token')).toBe(false);
expect(isMachineToken('session_token_value')).toBe(false);
expect(isMachineToken('jwt_token_value')).toBe(false);
expect(isMachineTokenByPrefix('unknown_prefix_token')).toBe(false);
expect(isMachineTokenByPrefix('session_token_value')).toBe(false);
expect(isMachineTokenByPrefix('jwt_token_value')).toBe(false);
});

it('returns false for empty tokens', () => {
expect(isMachineToken('')).toBe(false);
expect(isMachineTokenByPrefix('')).toBe(false);
});
});

Expand DownExpand Up@@ -78,3 +79,15 @@ describe('isTokenTypeAccepted', () => {
expect(isTokenTypeAccepted('api_key', 'machine_token')).toBe(false);
});
});

describe('isMachineTokenType', () => {
it('returns true for machine token types', () => {
expect(isMachineTokenType('api_key')).toBe(true);
expect(isMachineTokenType('machine_token')).toBe(true);
expect(isMachineTokenType('oauth_token')).toBe(true);
});

it('returns false for non-machine token types', () => {
expect(isMachineTokenType('session_token')).toBe(false);
});
});
87 changes: 49 additions & 38 deletions packages/backend/src/tokens/authObjects.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ import type { APIKey, CreateBackendApiOptions, IdPOAuthAccessToken, MachineToken
import { createBackendApiClient } from '../api';
import { isTokenTypeAccepted } from '../internal';
import type { AuthenticateContext } from './authenticateContext';
import { isMachineTokenType } from './machine';
import type { MachineTokenType, SessionTokenType } from './tokenTypes';
import { TokenType } from './tokenTypes';
import type { AuthenticateRequestOptions, MachineAuthType } from './types';
Expand DownExpand Up@@ -57,6 +58,7 @@ export type SignedInAuthObject = SharedSignedInAuthObjectProperties & {
* Used to help debug issues when using Clerk in development.
*/
debug: AuthObjectDebug;
isAuthenticated: true;
};

/**
Expand All@@ -77,6 +79,7 @@ export type SignedOutAuthObject = {
getToken: ServerGetToken;
has: CheckAuthorizationFromSessionClaims;
debug: AuthObjectDebug;
isAuthenticated: false;
};

/**
Expand DownExpand Up@@ -120,6 +123,7 @@ export type AuthenticatedMachineObject<T extends MachineTokenType = MachineToken
has: CheckAuthorizationFromSessionClaims;
debug: AuthObjectDebug;
tokenType: T;
isAuthenticated: true;
} & MachineObjectExtendedProperties<true>[T]
: never;

Expand All@@ -140,17 +144,27 @@ export type UnauthenticatedMachineObject<T extends MachineTokenType = MachineTok
has: CheckAuthorizationFromSessionClaims;
debug: AuthObjectDebug;
tokenType: T;
isAuthenticated: false;
} & MachineObjectExtendedProperties<false>[T]
: never;

export type InvalidTokenAuthObject = {
isAuthenticated: false;
tokenType: null;
getToken: () => Promise<null>;
has: () => false;
debug: AuthObjectDebug;
};

/**
* @interface
*/
export type AuthObject =
| SignedInAuthObject
| SignedOutAuthObject
| AuthenticatedMachineObject
| UnauthenticatedMachineObject;
| UnauthenticatedMachineObject
| InvalidTokenAuthObject;

const createDebug = (data: AuthObjectDebugData | undefined) => {
return () => {
Expand DownExpand Up@@ -200,6 +214,7 @@ export function signedInAuthObject(
plans: (sessionClaims.pla as string) || '',
}),
debug: createDebug({ ...authenticateContext, sessionToken }),
isAuthenticated: true,
};
}

Expand All@@ -225,6 +240,7 @@ export function signedOutAuthObject(
getToken: () => Promise.resolve(null),
has: () => false,
debug: createDebug(debugData),
isAuthenticated: false,
};
}

Expand All@@ -243,6 +259,7 @@ export function authenticatedMachineObject<T extends MachineTokenType>(
getToken: () => Promise.resolve(token),
has: () => false,
debug: createDebug(debugData),
isAuthenticated: true,
};

// Type assertions are safe here since we know the verification result type matches the tokenType.
Expand DownExpand Up@@ -302,6 +319,7 @@ export function unauthenticatedMachineObject<T extends MachineTokenType>(
has: () => false,
getToken: () => Promise.resolve(null),
debug: createDebug(debugData),
isAuthenticated: false,
};

switch (tokenType) {
Expand DownExpand Up@@ -340,6 +358,19 @@ export function unauthenticatedMachineObject<T extends MachineTokenType>(
}
}

/**
* @internal
*/
export function invalidTokenAuthObject(): InvalidTokenAuthObject {
return {
isAuthenticated: false,
tokenType: null,
getToken: () => Promise.resolve(null),
has: () => false,
debug: () => ({}),
};
}

/**
* Auth objects moving through the server -> client boundary need to be serializable
* as we need to ensure that they can be transferred via the network as pure strings.
Expand DownExpand Up@@ -394,42 +425,13 @@ export const getAuthObjectFromJwt = (

/**
* @internal
* Filters and coerces an AuthObject based on the accepted token type(s).
*
* This function is used after authentication to ensure that the returned auth object
* matches the expected token type(s) specified by `acceptsToken`. If the token type
* of the provided `authObject` does not match any of the types in `acceptsToken`,
* it returns an unauthenticated or signed-out version of the object, depending on the token type.
*
* - If `acceptsToken` is `'any'`, the original auth object is returned.
* - If `acceptsToken` is a single token type or an array of token types, the function checks if
* `authObject.tokenType` matches any of them.
* - If the token type does not match and is a session token, a signed-out object is returned.
* - If the token type does not match and is a machine token, an unauthenticated machine object is returned.
* - If the token type matches, the original auth object is returned.
*
* @param {Object} params
* @param {AuthObject} params.authObject - The authenticated object to filter.
* @param {AuthenticateRequestOptions['acceptsToken']} [params.acceptsToken=TokenType.SessionToken] - The accepted token type(s). Can be a string, array of strings, or 'any'.
* @returns {AuthObject} The filtered or coerced auth object.
* Returns an auth object matching the requested token type(s).
*
* @example
* // Accept only 'api_key' tokens
* const authObject = { tokenType: 'session_token', userId: 'user_123' };
* const result = getAuthObjectForAcceptedToken({ authObject, acceptsToken: 'api_key' });
* // result will be a signed-out object (since tokenType is 'session_token' and does not match)
* If the parsed token type does not match any in acceptsToken, returns:
* - an unauthenticated machine object for the first machine token type in acceptsToken (if present), or
* - a signed-out session object otherwise.
*
* @example
* // Accept 'api_key' or 'machine_token'
* const authObject = { tokenType: 'machine_token', id: 'm2m_123' };
* const result = getAuthObjectForAcceptedToken({ authObject, acceptsToken: ['api_key', 'machine_token'] });
* // result will be the original authObject (since tokenType matches one in the array)
*
* @example
* // Accept any token type
* const authObject = { tokenType: 'api_key', id: 'ak_123' };
* const result = getAuthObjectForAcceptedToken({ authObject, acceptsToken: 'any' });
* // result will be the original authObject
* This ensures the returned object always matches the developer's intent.
*/
export function getAuthObjectForAcceptedToken({
authObject,
Expand All@@ -442,11 +444,20 @@ export function getAuthObjectForAcceptedToken({
return authObject;
}

if (Array.isArray(acceptsToken)) {
if (!isTokenTypeAccepted(authObject.tokenType, acceptsToken)) {
// If the token is not in the accepted array, return invalid token auth object
return invalidTokenAuthObject();
}
return authObject;
}
Comment thread
wobsoriano marked this conversation as resolved.

// Single value: Intent based
if (!isTokenTypeAccepted(authObject.tokenType, acceptsToken)) {
if (authObject.tokenType === TokenType.SessionToken) {
return signedOutAuthObject(authObject.debug);
if (isMachineTokenType(acceptsToken)) {
return unauthenticatedMachineObject(acceptsToken, authObject.debug);
}
return unauthenticatedMachineObject(authObject.tokenType, authObject.debug);
return signedOutAuthObject(authObject.debug);
}

return authObject;
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/open-swans-count.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
'@clerk/backend': minor
'@clerk/nextjs': minor
---

Respect `acceptsToken` when returning unauthenticated session or machine object.
4 changes: 3 additions & 1 deletion packages/backend/src/__tests__/exports.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,9 @@ describe('subpath /internal exports', () => {
"getAuthObjectForAcceptedToken",
"getAuthObjectFromJwt",
"getMachineTokenType",
"isMachineToken",
"invalidTokenAuthObject",
"isMachineTokenByPrefix",
"isMachineTokenType",
"isTokenTypeAccepted",
"makeAuthObjectSerializable",
"reverificationError",
Expand Down
2 changes: 1 addition & 1 deletion packages/backend/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -161,5 +161,5 @@ export type {
/**
* Auth objects
*/
export type { AuthObject } from './tokens/authObjects';
export type { AuthObject, InvalidTokenAuthObject } from './tokens/authObjects';
export type { SessionAuthObject, MachineAuthObject } from './tokens/types';
3 changes: 2 additions & 1 deletion packages/backend/src/internal.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,6 +31,7 @@ export {
signedInAuthObject,
authenticatedMachineObject,
unauthenticatedMachineObject,
invalidTokenAuthObject,
getAuthObjectFromJwt,
getAuthObjectForAcceptedToken,
} from './tokens/authObjects';
Expand All@@ -53,4 +54,4 @@ export { reverificationError, reverificationErrorResponse } from '@clerk/shared/

export { verifyMachineAuthToken } from './tokens/verify';

export { isMachineToken, getMachineTokenType, isTokenTypeAccepted } from './tokens/machine';
export { isMachineTokenByPrefix, isMachineTokenType, getMachineTokenType, isTokenTypeAccepted } from './tokens/machine';
45 changes: 45 additions & 0 deletions packages/backend/src/tokens/__tests__/authObjects.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,10 @@ import { describe, expect, it } from 'vitest';

import { mockTokens, mockVerificationResults } from '../../fixtures/machine';
import type { AuthenticateContext } from '../authenticateContext';
import type { InvalidTokenAuthObject, UnauthenticatedMachineObject } from '../authObjects';
import {
authenticatedMachineObject,
getAuthObjectForAcceptedToken,
makeAuthObjectSerializable,
signedInAuthObject,
signedOutAuthObject,
Expand DownExpand Up@@ -387,3 +389,46 @@ describe('unauthenticatedMachineObject', () => {
expect(retrievedToken).toBeNull();
});
});

describe('getAuthObjectForAcceptedToken', () => {
const debugData = { foo: 'bar' };
const sessionAuth = signedOutAuthObject(debugData);
const machineAuth = authenticatedMachineObject('api_key', 'ak_xxx', mockVerificationResults.api_key, debugData);

it('returns original object if acceptsToken is "any"', () => {
const result = getAuthObjectForAcceptedToken({ authObject: machineAuth, acceptsToken: 'any' });
expect(result).toBe(machineAuth);
});

it('returns original object if token type matches', () => {
const result = getAuthObjectForAcceptedToken({ authObject: machineAuth, acceptsToken: 'api_key' });
expect(result).toBe(machineAuth);
});

it('returns InvalidTokenAuthObject if acceptsToken is array and token type does not match', () => {
const result = getAuthObjectForAcceptedToken({
authObject: machineAuth,
acceptsToken: ['machine_token', 'oauth_token'],
});
expect((result as InvalidTokenAuthObject).tokenType).toBeNull();
expect((result as InvalidTokenAuthObject).isAuthenticated).toBe(false);
});

it('returns InvalidTokenAuthObject if parsed type is not a machine token and does not match any in acceptsToken array', () => {
const result = getAuthObjectForAcceptedToken({ authObject: sessionAuth, acceptsToken: ['api_key', 'oauth_token'] });
expect((result as InvalidTokenAuthObject).tokenType).toBeNull();
expect((result as InvalidTokenAuthObject).isAuthenticated).toBe(false);
});

it('returns signed-out session object if parsed type is not a machine token and does not match', () => {
const result = getAuthObjectForAcceptedToken({ authObject: sessionAuth, acceptsToken: ['api_key', 'oauth_token'] });
expect((result as InvalidTokenAuthObject).tokenType).toBeNull();
expect((result as InvalidTokenAuthObject).isAuthenticated).toBe(false);
});

it('returns unauthenticated object for requested type if acceptsToken is a single value and does not match', () => {
const result = getAuthObjectForAcceptedToken({ authObject: machineAuth, acceptsToken: 'machine_token' });
expect((result as UnauthenticatedMachineObject<'machine_token'>).tokenType).toBe('machine_token');
expect((result as UnauthenticatedMachineObject<'machine_token'>).id).toBeNull();
});
});
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/__tests__/getAuth.test-d.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { expectTypeOf, test } from 'vitest';

import type { AuthObject } from '../authObjects';
import type { AuthObject, InvalidTokenAuthObject } from '../authObjects';
import type { GetAuthFn, MachineAuthObject, SessionAuthObject } from '../types';

// Across our SDKs, we have a getAuth() function
Expand All@@ -22,10 +22,10 @@ test('infers the correct AuthObject type for each accepted token type', () => {

// Array of token types
expectTypeOf(getAuth(request, { acceptsToken: ['session_token', 'machine_token'] })).toMatchTypeOf<
SessionAuthObject | MachineAuthObject<'machine_token'>
SessionAuthObject | MachineAuthObject<'machine_token'> | InvalidTokenAuthObject
>();
expectTypeOf(getAuth(request, { acceptsToken: ['machine_token', 'oauth_token'] })).toMatchTypeOf<
MachineAuthObject<'machine_token' | 'oauth_token'>
MachineAuthObject<'machine_token' | 'oauth_token'> | InvalidTokenAuthObject
>();

// Any token type
Expand Down
29 changes: 21 additions & 8 deletions packages/backend/src/tokens/__tests__/machine.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,33 +3,34 @@ import { describe, expect, it } from 'vitest';
import {
API_KEY_PREFIX,
getMachineTokenType,
isMachineToken,
isMachineTokenByPrefix,
isMachineTokenType,
isTokenTypeAccepted,
M2M_TOKEN_PREFIX,
OAUTH_TOKEN_PREFIX,
} from '../machine';

describe('isMachineToken', () => {
it('returns true for tokens with M2M prefix', () => {
expect(isMachineToken(`${M2M_TOKEN_PREFIX}some-token-value`)).toBe(true);
expect(isMachineTokenByPrefix(`${M2M_TOKEN_PREFIX}some-token-value`)).toBe(true);
});

it('returns true for tokens with OAuth prefix', () => {
expect(isMachineToken(`${OAUTH_TOKEN_PREFIX}some-token-value`)).toBe(true);
expect(isMachineTokenByPrefix(`${OAUTH_TOKEN_PREFIX}some-token-value`)).toBe(true);
});

it('returns true for tokens with API key prefix', () => {
expect(isMachineToken(`${API_KEY_PREFIX}some-token-value`)).toBe(true);
expect(isMachineTokenByPrefix(`${API_KEY_PREFIX}some-token-value`)).toBe(true);
});

it('returns false for tokens without a recognized prefix', () => {
expect(isMachineToken('unknown_prefix_token')).toBe(false);
expect(isMachineToken('session_token_value')).toBe(false);
expect(isMachineToken('jwt_token_value')).toBe(false);
expect(isMachineTokenByPrefix('unknown_prefix_token')).toBe(false);
expect(isMachineTokenByPrefix('session_token_value')).toBe(false);
expect(isMachineTokenByPrefix('jwt_token_value')).toBe(false);
});

it('returns false for empty tokens', () => {
expect(isMachineToken('')).toBe(false);
expect(isMachineTokenByPrefix('')).toBe(false);
});
});

Expand DownExpand Up@@ -78,3 +79,15 @@ describe('isTokenTypeAccepted', () => {
expect(isTokenTypeAccepted('api_key', 'machine_token')).toBe(false);
});
});

describe('isMachineTokenType', () => {
it('returns true for machine token types', () => {
expect(isMachineTokenType('api_key')).toBe(true);
expect(isMachineTokenType('machine_token')).toBe(true);
expect(isMachineTokenType('oauth_token')).toBe(true);
});

it('returns false for non-machine token types', () => {
expect(isMachineTokenType('session_token')).toBe(false);
});
});
87 changes: 49 additions & 38 deletions packages/backend/src/tokens/authObjects.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ import type { APIKey, CreateBackendApiOptions, IdPOAuthAccessToken, MachineToken
import { createBackendApiClient } from '../api';
import { isTokenTypeAccepted } from '../internal';
import type { AuthenticateContext } from './authenticateContext';
import { isMachineTokenType } from './machine';
import type { MachineTokenType, SessionTokenType } from './tokenTypes';
import { TokenType } from './tokenTypes';
import type { AuthenticateRequestOptions, MachineAuthType } from './types';
Expand DownExpand Up@@ -57,6 +58,7 @@ export type SignedInAuthObject = SharedSignedInAuthObjectProperties & {
* Used to help debug issues when using Clerk in development.
*/
debug: AuthObjectDebug;
isAuthenticated: true;
};

/**
Expand All@@ -77,6 +79,7 @@ export type SignedOutAuthObject = {
getToken: ServerGetToken;
has: CheckAuthorizationFromSessionClaims;
debug: AuthObjectDebug;
isAuthenticated: false;
};

/**
Expand DownExpand Up@@ -120,6 +123,7 @@ export type AuthenticatedMachineObject<T extends MachineTokenType = MachineToken
has: CheckAuthorizationFromSessionClaims;
debug: AuthObjectDebug;
tokenType: T;
isAuthenticated: true;
} & MachineObjectExtendedProperties<true>[T]
: never;

Expand All@@ -140,17 +144,27 @@ export type UnauthenticatedMachineObject<T extends MachineTokenType = MachineTok
has: CheckAuthorizationFromSessionClaims;
debug: AuthObjectDebug;
tokenType: T;
isAuthenticated: false;
} & MachineObjectExtendedProperties<false>[T]
: never;

export type InvalidTokenAuthObject = {
isAuthenticated: false;
tokenType: null;
getToken: () => Promise<null>;
has: () => false;
debug: AuthObjectDebug;
};

/**
* @interface
*/
export type AuthObject =
| SignedInAuthObject
| SignedOutAuthObject
| AuthenticatedMachineObject
| UnauthenticatedMachineObject;
| UnauthenticatedMachineObject
| InvalidTokenAuthObject;

const createDebug = (data: AuthObjectDebugData | undefined) => {
return () => {
Expand DownExpand Up@@ -200,6 +214,7 @@ export function signedInAuthObject(
plans: (sessionClaims.pla as string) || '',
}),
debug: createDebug({ ...authenticateContext, sessionToken }),
isAuthenticated: true,
};
}

Expand All@@ -225,6 +240,7 @@ export function signedOutAuthObject(
getToken: () => Promise.resolve(null),
has: () => false,
debug: createDebug(debugData),
isAuthenticated: false,
};
}

Expand All@@ -243,6 +259,7 @@ export function authenticatedMachineObject<T extends MachineTokenType>(
getToken: () => Promise.resolve(token),
has: () => false,
debug: createDebug(debugData),
isAuthenticated: true,
};

// Type assertions are safe here since we know the verification result type matches the tokenType.
Expand DownExpand Up@@ -302,6 +319,7 @@ export function unauthenticatedMachineObject<T extends MachineTokenType>(
has: () => false,
getToken: () => Promise.resolve(null),
debug: createDebug(debugData),
isAuthenticated: false,
};

switch (tokenType) {
Expand DownExpand Up@@ -340,6 +358,19 @@ export function unauthenticatedMachineObject<T extends MachineTokenType>(
}
}

/**
* @internal
*/
export function invalidTokenAuthObject(): InvalidTokenAuthObject {
return {
isAuthenticated: false,
tokenType: null,
getToken: () => Promise.resolve(null),
has: () => false,
debug: () => ({}),
};
}

/**
* Auth objects moving through the server -> client boundary need to be serializable
* as we need to ensure that they can be transferred via the network as pure strings.
Expand DownExpand Up@@ -394,42 +425,13 @@ export const getAuthObjectFromJwt = (

/**
* @internal
* Filters and coerces an AuthObject based on the accepted token type(s).
*
* This function is used after authentication to ensure that the returned auth object
* matches the expected token type(s) specified by `acceptsToken`. If the token type
* of the provided `authObject` does not match any of the types in `acceptsToken`,
* it returns an unauthenticated or signed-out version of the object, depending on the token type.
*
* - If `acceptsToken` is `'any'`, the original auth object is returned.
* - If `acceptsToken` is a single token type or an array of token types, the function checks if
* `authObject.tokenType` matches any of them.
* - If the token type does not match and is a session token, a signed-out object is returned.
* - If the token type does not match and is a machine token, an unauthenticated machine object is returned.
* - If the token type matches, the original auth object is returned.
*
* @param {Object} params
* @param {AuthObject} params.authObject - The authenticated object to filter.
* @param {AuthenticateRequestOptions['acceptsToken']} [params.acceptsToken=TokenType.SessionToken] - The accepted token type(s). Can be a string, array of strings, or 'any'.
* @returns {AuthObject} The filtered or coerced auth object.
* Returns an auth object matching the requested token type(s).
*
* @example
* // Accept only 'api_key' tokens
* const authObject = { tokenType: 'session_token', userId: 'user_123' };
* const result = getAuthObjectForAcceptedToken({ authObject, acceptsToken: 'api_key' });
* // result will be a signed-out object (since tokenType is 'session_token' and does not match)
* If the parsed token type does not match any in acceptsToken, returns:
* - an unauthenticated machine object for the first machine token type in acceptsToken (if present), or
* - a signed-out session object otherwise.
*
* @example
* // Accept 'api_key' or 'machine_token'
* const authObject = { tokenType: 'machine_token', id: 'm2m_123' };
* const result = getAuthObjectForAcceptedToken({ authObject, acceptsToken: ['api_key', 'machine_token'] });
* // result will be the original authObject (since tokenType matches one in the array)
*
* @example
* // Accept any token type
* const authObject = { tokenType: 'api_key', id: 'ak_123' };
* const result = getAuthObjectForAcceptedToken({ authObject, acceptsToken: 'any' });
* // result will be the original authObject
* This ensures the returned object always matches the developer's intent.
*/
export function getAuthObjectForAcceptedToken({
authObject,
Expand All@@ -442,11 +444,20 @@ export function getAuthObjectForAcceptedToken({
return authObject;
}

if (Array.isArray(acceptsToken)) {
if (!isTokenTypeAccepted(authObject.tokenType, acceptsToken)) {
// If the token is not in the accepted array, return invalid token auth object
return invalidTokenAuthObject();
}
return authObject;
}
Comment thread
wobsoriano marked this conversation as resolved.

// Single value: Intent based
if (!isTokenTypeAccepted(authObject.tokenType, acceptsToken)) {
if (authObject.tokenType === TokenType.SessionToken) {
return signedOutAuthObject(authObject.debug);
if (isMachineTokenType(acceptsToken)) {
return unauthenticatedMachineObject(acceptsToken, authObject.debug);
}
return unauthenticatedMachineObject(authObject.tokenType, authObject.debug);
return signedOutAuthObject(authObject.debug);
}

return authObject;
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/open-swans-count.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
'@clerk/backend': minor
'@clerk/nextjs': minor
---

Respect `acceptsToken` when returning unauthenticated session or machine object.
4 changes: 3 additions & 1 deletion packages/backend/src/__tests__/exports.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,9 @@ describe('subpath /internal exports', () => {
"getAuthObjectForAcceptedToken",
"getAuthObjectFromJwt",
"getMachineTokenType",
"isMachineToken",
"invalidTokenAuthObject",
"isMachineTokenByPrefix",
"isMachineTokenType",
"isTokenTypeAccepted",
"makeAuthObjectSerializable",
"reverificationError",
Expand Down
2 changes: 1 addition & 1 deletion packages/backend/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -161,5 +161,5 @@ export type {
/**
* Auth objects
*/
export type { AuthObject } from './tokens/authObjects';
export type { AuthObject, InvalidTokenAuthObject } from './tokens/authObjects';
export type { SessionAuthObject, MachineAuthObject } from './tokens/types';
3 changes: 2 additions & 1 deletion packages/backend/src/internal.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,6 +31,7 @@ export {
signedInAuthObject,
authenticatedMachineObject,
unauthenticatedMachineObject,
invalidTokenAuthObject,
getAuthObjectFromJwt,
getAuthObjectForAcceptedToken,
} from './tokens/authObjects';
Expand All@@ -53,4 +54,4 @@ export { reverificationError, reverificationErrorResponse } from '@clerk/shared/

export { verifyMachineAuthToken } from './tokens/verify';

export { isMachineToken, getMachineTokenType, isTokenTypeAccepted } from './tokens/machine';
export { isMachineTokenByPrefix, isMachineTokenType, getMachineTokenType, isTokenTypeAccepted } from './tokens/machine';
45 changes: 45 additions & 0 deletions packages/backend/src/tokens/__tests__/authObjects.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,10 @@ import { describe, expect, it } from 'vitest';

import { mockTokens, mockVerificationResults } from '../../fixtures/machine';
import type { AuthenticateContext } from '../authenticateContext';
import type { InvalidTokenAuthObject, UnauthenticatedMachineObject } from '../authObjects';
import {
authenticatedMachineObject,
getAuthObjectForAcceptedToken,
makeAuthObjectSerializable,
signedInAuthObject,
signedOutAuthObject,
Expand DownExpand Up@@ -387,3 +389,46 @@ describe('unauthenticatedMachineObject', () => {
expect(retrievedToken).toBeNull();
});
});

describe('getAuthObjectForAcceptedToken', () => {
const debugData = { foo: 'bar' };
const sessionAuth = signedOutAuthObject(debugData);
const machineAuth = authenticatedMachineObject('api_key', 'ak_xxx', mockVerificationResults.api_key, debugData);

it('returns original object if acceptsToken is "any"', () => {
const result = getAuthObjectForAcceptedToken({ authObject: machineAuth, acceptsToken: 'any' });
expect(result).toBe(machineAuth);
});

it('returns original object if token type matches', () => {
const result = getAuthObjectForAcceptedToken({ authObject: machineAuth, acceptsToken: 'api_key' });
expect(result).toBe(machineAuth);
});

it('returns InvalidTokenAuthObject if acceptsToken is array and token type does not match', () => {
const result = getAuthObjectForAcceptedToken({
authObject: machineAuth,
acceptsToken: ['machine_token', 'oauth_token'],
});
expect((result as InvalidTokenAuthObject).tokenType).toBeNull();
expect((result as InvalidTokenAuthObject).isAuthenticated).toBe(false);
});

it('returns InvalidTokenAuthObject if parsed type is not a machine token and does not match any in acceptsToken array', () => {
const result = getAuthObjectForAcceptedToken({ authObject: sessionAuth, acceptsToken: ['api_key', 'oauth_token'] });
expect((result as InvalidTokenAuthObject).tokenType).toBeNull();
expect((result as InvalidTokenAuthObject).isAuthenticated).toBe(false);
});

it('returns signed-out session object if parsed type is not a machine token and does not match', () => {
const result = getAuthObjectForAcceptedToken({ authObject: sessionAuth, acceptsToken: ['api_key', 'oauth_token'] });
expect((result as InvalidTokenAuthObject).tokenType).toBeNull();
expect((result as InvalidTokenAuthObject).isAuthenticated).toBe(false);
});

it('returns unauthenticated object for requested type if acceptsToken is a single value and does not match', () => {
const result = getAuthObjectForAcceptedToken({ authObject: machineAuth, acceptsToken: 'machine_token' });
expect((result as UnauthenticatedMachineObject<'machine_token'>).tokenType).toBe('machine_token');
expect((result as UnauthenticatedMachineObject<'machine_token'>).id).toBeNull();
});
});
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/__tests__/getAuth.test-d.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { expectTypeOf, test } from 'vitest';

import type { AuthObject } from '../authObjects';
import type { AuthObject, InvalidTokenAuthObject } from '../authObjects';
import type { GetAuthFn, MachineAuthObject, SessionAuthObject } from '../types';

// Across our SDKs, we have a getAuth() function
Expand All@@ -22,10 +22,10 @@ test('infers the correct AuthObject type for each accepted token type', () => {

// Array of token types
expectTypeOf(getAuth(request, { acceptsToken: ['session_token', 'machine_token'] })).toMatchTypeOf<
SessionAuthObject | MachineAuthObject<'machine_token'>
SessionAuthObject | MachineAuthObject<'machine_token'> | InvalidTokenAuthObject
>();
expectTypeOf(getAuth(request, { acceptsToken: ['machine_token', 'oauth_token'] })).toMatchTypeOf<
MachineAuthObject<'machine_token' | 'oauth_token'>
MachineAuthObject<'machine_token' | 'oauth_token'> | InvalidTokenAuthObject
>();

// Any token type
Expand Down
29 changes: 21 additions & 8 deletions packages/backend/src/tokens/__tests__/machine.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,33 +3,34 @@ import { describe, expect, it } from 'vitest';
import {
API_KEY_PREFIX,
getMachineTokenType,
isMachineToken,
isMachineTokenByPrefix,
isMachineTokenType,
isTokenTypeAccepted,
M2M_TOKEN_PREFIX,
OAUTH_TOKEN_PREFIX,
} from '../machine';

describe('isMachineToken', () => {
it('returns true for tokens with M2M prefix', () => {
expect(isMachineToken(`${M2M_TOKEN_PREFIX}some-token-value`)).toBe(true);
expect(isMachineTokenByPrefix(`${M2M_TOKEN_PREFIX}some-token-value`)).toBe(true);
});

it('returns true for tokens with OAuth prefix', () => {
expect(isMachineToken(`${OAUTH_TOKEN_PREFIX}some-token-value`)).toBe(true);
expect(isMachineTokenByPrefix(`${OAUTH_TOKEN_PREFIX}some-token-value`)).toBe(true);
});

it('returns true for tokens with API key prefix', () => {
expect(isMachineToken(`${API_KEY_PREFIX}some-token-value`)).toBe(true);
expect(isMachineTokenByPrefix(`${API_KEY_PREFIX}some-token-value`)).toBe(true);
});

it('returns false for tokens without a recognized prefix', () => {
expect(isMachineToken('unknown_prefix_token')).toBe(false);
expect(isMachineToken('session_token_value')).toBe(false);
expect(isMachineToken('jwt_token_value')).toBe(false);
expect(isMachineTokenByPrefix('unknown_prefix_token')).toBe(false);
expect(isMachineTokenByPrefix('session_token_value')).toBe(false);
expect(isMachineTokenByPrefix('jwt_token_value')).toBe(false);
});

it('returns false for empty tokens', () => {
expect(isMachineToken('')).toBe(false);
expect(isMachineTokenByPrefix('')).toBe(false);
});
});

Expand DownExpand Up@@ -78,3 +79,15 @@ describe('isTokenTypeAccepted', () => {
expect(isTokenTypeAccepted('api_key', 'machine_token')).toBe(false);
});
});

describe('isMachineTokenType', () => {
it('returns true for machine token types', () => {
expect(isMachineTokenType('api_key')).toBe(true);
expect(isMachineTokenType('machine_token')).toBe(true);
expect(isMachineTokenType('oauth_token')).toBe(true);
});

it('returns false for non-machine token types', () => {
expect(isMachineTokenType('session_token')).toBe(false);
});
});
87 changes: 49 additions & 38 deletions packages/backend/src/tokens/authObjects.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ import type { APIKey, CreateBackendApiOptions, IdPOAuthAccessToken, MachineToken
import { createBackendApiClient } from '../api';
import { isTokenTypeAccepted } from '../internal';
import type { AuthenticateContext } from './authenticateContext';
import { isMachineTokenType } from './machine';
import type { MachineTokenType, SessionTokenType } from './tokenTypes';
import { TokenType } from './tokenTypes';
import type { AuthenticateRequestOptions, MachineAuthType } from './types';
Expand DownExpand Up@@ -57,6 +58,7 @@ export type SignedInAuthObject = SharedSignedInAuthObjectProperties & {
* Used to help debug issues when using Clerk in development.
*/
debug: AuthObjectDebug;
isAuthenticated: true;
};

/**
Expand All@@ -77,6 +79,7 @@ export type SignedOutAuthObject = {
getToken: ServerGetToken;
has: CheckAuthorizationFromSessionClaims;
debug: AuthObjectDebug;
isAuthenticated: false;
};

/**
Expand DownExpand Up@@ -120,6 +123,7 @@ export type AuthenticatedMachineObject<T extends MachineTokenType = MachineToken
has: CheckAuthorizationFromSessionClaims;
debug: AuthObjectDebug;
tokenType: T;
isAuthenticated: true;
} & MachineObjectExtendedProperties<true>[T]
: never;

Expand All@@ -140,17 +144,27 @@ export type UnauthenticatedMachineObject<T extends MachineTokenType = MachineTok
has: CheckAuthorizationFromSessionClaims;
debug: AuthObjectDebug;
tokenType: T;
isAuthenticated: false;
} & MachineObjectExtendedProperties<false>[T]
: never;

export type InvalidTokenAuthObject = {
isAuthenticated: false;
tokenType: null;
getToken: () => Promise<null>;
has: () => false;
debug: AuthObjectDebug;
};

/**
* @interface
*/
export type AuthObject =
| SignedInAuthObject
| SignedOutAuthObject
| AuthenticatedMachineObject
| UnauthenticatedMachineObject;
| UnauthenticatedMachineObject
| InvalidTokenAuthObject;

const createDebug = (data: AuthObjectDebugData | undefined) => {
return () => {
Expand DownExpand Up@@ -200,6 +214,7 @@ export function signedInAuthObject(
plans: (sessionClaims.pla as string) || '',
}),
debug: createDebug({ ...authenticateContext, sessionToken }),
isAuthenticated: true,
};
}

Expand All@@ -225,6 +240,7 @@ export function signedOutAuthObject(
getToken: () => Promise.resolve(null),
has: () => false,
debug: createDebug(debugData),
isAuthenticated: false,
};
}

Expand All@@ -243,6 +259,7 @@ export function authenticatedMachineObject<T extends MachineTokenType>(
getToken: () => Promise.resolve(token),
has: () => false,
debug: createDebug(debugData),
isAuthenticated: true,
};

// Type assertions are safe here since we know the verification result type matches the tokenType.
Expand DownExpand Up@@ -302,6 +319,7 @@ export function unauthenticatedMachineObject<T extends MachineTokenType>(
has: () => false,
getToken: () => Promise.resolve(null),
debug: createDebug(debugData),
isAuthenticated: false,
};

switch (tokenType) {
Expand DownExpand Up@@ -340,6 +358,19 @@ export function unauthenticatedMachineObject<T extends MachineTokenType>(
}
}

/**
* @internal
*/
export function invalidTokenAuthObject(): InvalidTokenAuthObject {
return {
isAuthenticated: false,
tokenType: null,
getToken: () => Promise.resolve(null),
has: () => false,
debug: () => ({}),
};
}

/**
* Auth objects moving through the server -> client boundary need to be serializable
* as we need to ensure that they can be transferred via the network as pure strings.
Expand DownExpand Up@@ -394,42 +425,13 @@ export const getAuthObjectFromJwt = (

/**
* @internal
* Filters and coerces an AuthObject based on the accepted token type(s).
*
* This function is used after authentication to ensure that the returned auth object
* matches the expected token type(s) specified by `acceptsToken`. If the token type
* of the provided `authObject` does not match any of the types in `acceptsToken`,
* it returns an unauthenticated or signed-out version of the object, depending on the token type.
*
* - If `acceptsToken` is `'any'`, the original auth object is returned.
* - If `acceptsToken` is a single token type or an array of token types, the function checks if
* `authObject.tokenType` matches any of them.
* - If the token type does not match and is a session token, a signed-out object is returned.
* - If the token type does not match and is a machine token, an unauthenticated machine object is returned.
* - If the token type matches, the original auth object is returned.
*
* @param {Object} params
* @param {AuthObject} params.authObject - The authenticated object to filter.
* @param {AuthenticateRequestOptions['acceptsToken']} [params.acceptsToken=TokenType.SessionToken] - The accepted token type(s). Can be a string, array of strings, or 'any'.
* @returns {AuthObject} The filtered or coerced auth object.
* Returns an auth object matching the requested token type(s).
*
* @example
* // Accept only 'api_key' tokens
* const authObject = { tokenType: 'session_token', userId: 'user_123' };
* const result = getAuthObjectForAcceptedToken({ authObject, acceptsToken: 'api_key' });
* // result will be a signed-out object (since tokenType is 'session_token' and does not match)
* If the parsed token type does not match any in acceptsToken, returns:
* - an unauthenticated machine object for the first machine token type in acceptsToken (if present), or
* - a signed-out session object otherwise.
*
* @example
* // Accept 'api_key' or 'machine_token'
* const authObject = { tokenType: 'machine_token', id: 'm2m_123' };
* const result = getAuthObjectForAcceptedToken({ authObject, acceptsToken: ['api_key', 'machine_token'] });
* // result will be the original authObject (since tokenType matches one in the array)
*
* @example
* // Accept any token type
* const authObject = { tokenType: 'api_key', id: 'ak_123' };
* const result = getAuthObjectForAcceptedToken({ authObject, acceptsToken: 'any' });
* // result will be the original authObject
* This ensures the returned object always matches the developer's intent.
*/
export function getAuthObjectForAcceptedToken({
authObject,
Expand All@@ -442,11 +444,20 @@ export function getAuthObjectForAcceptedToken({
return authObject;
}

if (Array.isArray(acceptsToken)) {
if (!isTokenTypeAccepted(authObject.tokenType, acceptsToken)) {
// If the token is not in the accepted array, return invalid token auth object
return invalidTokenAuthObject();
}
return authObject;
}
Comment thread
wobsoriano marked this conversation as resolved.

// Single value: Intent based
if (!isTokenTypeAccepted(authObject.tokenType, acceptsToken)) {
if (authObject.tokenType === TokenType.SessionToken) {
return signedOutAuthObject(authObject.debug);
if (isMachineTokenType(acceptsToken)) {
return unauthenticatedMachineObject(acceptsToken, authObject.debug);
}
return unauthenticatedMachineObject(authObject.tokenType, authObject.debug);
return signedOutAuthObject(authObject.debug);
}

return authObject;
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/open-swans-count.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
'@clerk/backend': minor
'@clerk/nextjs': minor
---

Respect `acceptsToken` when returning unauthenticated session or machine object.
4 changes: 3 additions & 1 deletion packages/backend/src/__tests__/exports.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,9 @@ describe('subpath /internal exports', () => {
"getAuthObjectForAcceptedToken",
"getAuthObjectFromJwt",
"getMachineTokenType",
"isMachineToken",
"invalidTokenAuthObject",
"isMachineTokenByPrefix",
"isMachineTokenType",
"isTokenTypeAccepted",
"makeAuthObjectSerializable",
"reverificationError",
Expand Down
2 changes: 1 addition & 1 deletion packages/backend/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -161,5 +161,5 @@ export type {
/**
* Auth objects
*/
export type { AuthObject } from './tokens/authObjects';
export type { AuthObject, InvalidTokenAuthObject } from './tokens/authObjects';
export type { SessionAuthObject, MachineAuthObject } from './tokens/types';
3 changes: 2 additions & 1 deletion packages/backend/src/internal.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,6 +31,7 @@ export {
signedInAuthObject,
authenticatedMachineObject,
unauthenticatedMachineObject,
invalidTokenAuthObject,
getAuthObjectFromJwt,
getAuthObjectForAcceptedToken,
} from './tokens/authObjects';
Expand All@@ -53,4 +54,4 @@ export { reverificationError, reverificationErrorResponse } from '@clerk/shared/

export { verifyMachineAuthToken } from './tokens/verify';

export { isMachineToken, getMachineTokenType, isTokenTypeAccepted } from './tokens/machine';
export { isMachineTokenByPrefix, isMachineTokenType, getMachineTokenType, isTokenTypeAccepted } from './tokens/machine';
45 changes: 45 additions & 0 deletions packages/backend/src/tokens/__tests__/authObjects.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,10 @@ import { describe, expect, it } from 'vitest';

import { mockTokens, mockVerificationResults } from '../../fixtures/machine';
import type { AuthenticateContext } from '../authenticateContext';
import type { InvalidTokenAuthObject, UnauthenticatedMachineObject } from '../authObjects';
import {
authenticatedMachineObject,
getAuthObjectForAcceptedToken,
makeAuthObjectSerializable,
signedInAuthObject,
signedOutAuthObject,
Expand DownExpand Up@@ -387,3 +389,46 @@ describe('unauthenticatedMachineObject', () => {
expect(retrievedToken).toBeNull();
});
});

describe('getAuthObjectForAcceptedToken', () => {
const debugData = { foo: 'bar' };
const sessionAuth = signedOutAuthObject(debugData);
const machineAuth = authenticatedMachineObject('api_key', 'ak_xxx', mockVerificationResults.api_key, debugData);

it('returns original object if acceptsToken is "any"', () => {
const result = getAuthObjectForAcceptedToken({ authObject: machineAuth, acceptsToken: 'any' });
expect(result).toBe(machineAuth);
});

it('returns original object if token type matches', () => {
const result = getAuthObjectForAcceptedToken({ authObject: machineAuth, acceptsToken: 'api_key' });
expect(result).toBe(machineAuth);
});

it('returns InvalidTokenAuthObject if acceptsToken is array and token type does not match', () => {
const result = getAuthObjectForAcceptedToken({
authObject: machineAuth,
acceptsToken: ['machine_token', 'oauth_token'],
});
expect((result as InvalidTokenAuthObject).tokenType).toBeNull();
expect((result as InvalidTokenAuthObject).isAuthenticated).toBe(false);
});

it('returns InvalidTokenAuthObject if parsed type is not a machine token and does not match any in acceptsToken array', () => {
const result = getAuthObjectForAcceptedToken({ authObject: sessionAuth, acceptsToken: ['api_key', 'oauth_token'] });
expect((result as InvalidTokenAuthObject).tokenType).toBeNull();
expect((result as InvalidTokenAuthObject).isAuthenticated).toBe(false);
});

it('returns signed-out session object if parsed type is not a machine token and does not match', () => {
const result = getAuthObjectForAcceptedToken({ authObject: sessionAuth, acceptsToken: ['api_key', 'oauth_token'] });
expect((result as InvalidTokenAuthObject).tokenType).toBeNull();
expect((result as InvalidTokenAuthObject).isAuthenticated).toBe(false);
});

it('returns unauthenticated object for requested type if acceptsToken is a single value and does not match', () => {
const result = getAuthObjectForAcceptedToken({ authObject: machineAuth, acceptsToken: 'machine_token' });
expect((result as UnauthenticatedMachineObject<'machine_token'>).tokenType).toBe('machine_token');
expect((result as UnauthenticatedMachineObject<'machine_token'>).id).toBeNull();
});
});
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/__tests__/getAuth.test-d.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { expectTypeOf, test } from 'vitest';

import type { AuthObject } from '../authObjects';
import type { AuthObject, InvalidTokenAuthObject } from '../authObjects';
import type { GetAuthFn, MachineAuthObject, SessionAuthObject } from '../types';

// Across our SDKs, we have a getAuth() function
Expand All@@ -22,10 +22,10 @@ test('infers the correct AuthObject type for each accepted token type', () => {

// Array of token types
expectTypeOf(getAuth(request, { acceptsToken: ['session_token', 'machine_token'] })).toMatchTypeOf<
SessionAuthObject | MachineAuthObject<'machine_token'>
SessionAuthObject | MachineAuthObject<'machine_token'> | InvalidTokenAuthObject
>();
expectTypeOf(getAuth(request, { acceptsToken: ['machine_token', 'oauth_token'] })).toMatchTypeOf<
MachineAuthObject<'machine_token' | 'oauth_token'>
MachineAuthObject<'machine_token' | 'oauth_token'> | InvalidTokenAuthObject
>();

// Any token type
Expand Down
29 changes: 21 additions & 8 deletions packages/backend/src/tokens/__tests__/machine.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,33 +3,34 @@ import { describe, expect, it } from 'vitest';
import {
API_KEY_PREFIX,
getMachineTokenType,
isMachineToken,
isMachineTokenByPrefix,
isMachineTokenType,
isTokenTypeAccepted,
M2M_TOKEN_PREFIX,
OAUTH_TOKEN_PREFIX,
} from '../machine';

describe('isMachineToken', () => {
it('returns true for tokens with M2M prefix', () => {
expect(isMachineToken(`${M2M_TOKEN_PREFIX}some-token-value`)).toBe(true);
expect(isMachineTokenByPrefix(`${M2M_TOKEN_PREFIX}some-token-value`)).toBe(true);
});

it('returns true for tokens with OAuth prefix', () => {
expect(isMachineToken(`${OAUTH_TOKEN_PREFIX}some-token-value`)).toBe(true);
expect(isMachineTokenByPrefix(`${OAUTH_TOKEN_PREFIX}some-token-value`)).toBe(true);
});

it('returns true for tokens with API key prefix', () => {
expect(isMachineToken(`${API_KEY_PREFIX}some-token-value`)).toBe(true);
expect(isMachineTokenByPrefix(`${API_KEY_PREFIX}some-token-value`)).toBe(true);
});

it('returns false for tokens without a recognized prefix', () => {
expect(isMachineToken('unknown_prefix_token')).toBe(false);
expect(isMachineToken('session_token_value')).toBe(false);
expect(isMachineToken('jwt_token_value')).toBe(false);
expect(isMachineTokenByPrefix('unknown_prefix_token')).toBe(false);
expect(isMachineTokenByPrefix('session_token_value')).toBe(false);
expect(isMachineTokenByPrefix('jwt_token_value')).toBe(false);
});

it('returns false for empty tokens', () => {
expect(isMachineToken('')).toBe(false);
expect(isMachineTokenByPrefix('')).toBe(false);
});
});

Expand DownExpand Up@@ -78,3 +79,15 @@ describe('isTokenTypeAccepted', () => {
expect(isTokenTypeAccepted('api_key', 'machine_token')).toBe(false);
});
});

describe('isMachineTokenType', () => {
it('returns true for machine token types', () => {
expect(isMachineTokenType('api_key')).toBe(true);
expect(isMachineTokenType('machine_token')).toBe(true);
expect(isMachineTokenType('oauth_token')).toBe(true);
});

it('returns false for non-machine token types', () => {
expect(isMachineTokenType('session_token')).toBe(false);
});
});
87 changes: 49 additions & 38 deletions packages/backend/src/tokens/authObjects.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ import type { APIKey, CreateBackendApiOptions, IdPOAuthAccessToken, MachineToken
import { createBackendApiClient } from '../api';
import { isTokenTypeAccepted } from '../internal';
import type { AuthenticateContext } from './authenticateContext';
import { isMachineTokenType } from './machine';
import type { MachineTokenType, SessionTokenType } from './tokenTypes';
import { TokenType } from './tokenTypes';
import type { AuthenticateRequestOptions, MachineAuthType } from './types';
Expand DownExpand Up@@ -57,6 +58,7 @@ export type SignedInAuthObject = SharedSignedInAuthObjectProperties & {
* Used to help debug issues when using Clerk in development.
*/
debug: AuthObjectDebug;
isAuthenticated: true;
};

/**
Expand All@@ -77,6 +79,7 @@ export type SignedOutAuthObject = {
getToken: ServerGetToken;
has: CheckAuthorizationFromSessionClaims;
debug: AuthObjectDebug;
isAuthenticated: false;
};

/**
Expand DownExpand Up@@ -120,6 +123,7 @@ export type AuthenticatedMachineObject<T extends MachineTokenType = MachineToken
has: CheckAuthorizationFromSessionClaims;
debug: AuthObjectDebug;
tokenType: T;
isAuthenticated: true;
} & MachineObjectExtendedProperties<true>[T]
: never;

Expand All@@ -140,17 +144,27 @@ export type UnauthenticatedMachineObject<T extends MachineTokenType = MachineTok
has: CheckAuthorizationFromSessionClaims;
debug: AuthObjectDebug;
tokenType: T;
isAuthenticated: false;
} & MachineObjectExtendedProperties<false>[T]
: never;

export type InvalidTokenAuthObject = {
isAuthenticated: false;
tokenType: null;
getToken: () => Promise<null>;
has: () => false;
debug: AuthObjectDebug;
};

/**
* @interface
*/
export type AuthObject =
| SignedInAuthObject
| SignedOutAuthObject
| AuthenticatedMachineObject
| UnauthenticatedMachineObject;
| UnauthenticatedMachineObject
| InvalidTokenAuthObject;

const createDebug = (data: AuthObjectDebugData | undefined) => {
return () => {
Expand DownExpand Up@@ -200,6 +214,7 @@ export function signedInAuthObject(
plans: (sessionClaims.pla as string) || '',
}),
debug: createDebug({ ...authenticateContext, sessionToken }),
isAuthenticated: true,
};
}

Expand All@@ -225,6 +240,7 @@ export function signedOutAuthObject(
getToken: () => Promise.resolve(null),
has: () => false,
debug: createDebug(debugData),
isAuthenticated: false,
};
}

Expand All@@ -243,6 +259,7 @@ export function authenticatedMachineObject<T extends MachineTokenType>(
getToken: () => Promise.resolve(token),
has: () => false,
debug: createDebug(debugData),
isAuthenticated: true,
};

// Type assertions are safe here since we know the verification result type matches the tokenType.
Expand DownExpand Up@@ -302,6 +319,7 @@ export function unauthenticatedMachineObject<T extends MachineTokenType>(
has: () => false,
getToken: () => Promise.resolve(null),
debug: createDebug(debugData),
isAuthenticated: false,
};

switch (tokenType) {
Expand DownExpand Up@@ -340,6 +358,19 @@ export function unauthenticatedMachineObject<T extends MachineTokenType>(
}
}

/**
* @internal
*/
export function invalidTokenAuthObject(): InvalidTokenAuthObject {
return {
isAuthenticated: false,
tokenType: null,
getToken: () => Promise.resolve(null),
has: () => false,
debug: () => ({}),
};
}

/**
* Auth objects moving through the server -> client boundary need to be serializable
* as we need to ensure that they can be transferred via the network as pure strings.
Expand DownExpand Up@@ -394,42 +425,13 @@ export const getAuthObjectFromJwt = (

/**
* @internal
* Filters and coerces an AuthObject based on the accepted token type(s).
*
* This function is used after authentication to ensure that the returned auth object
* matches the expected token type(s) specified by `acceptsToken`. If the token type
* of the provided `authObject` does not match any of the types in `acceptsToken`,
* it returns an unauthenticated or signed-out version of the object, depending on the token type.
*
* - If `acceptsToken` is `'any'`, the original auth object is returned.
* - If `acceptsToken` is a single token type or an array of token types, the function checks if
* `authObject.tokenType` matches any of them.
* - If the token type does not match and is a session token, a signed-out object is returned.
* - If the token type does not match and is a machine token, an unauthenticated machine object is returned.
* - If the token type matches, the original auth object is returned.
*
* @param {Object} params
* @param {AuthObject} params.authObject - The authenticated object to filter.
* @param {AuthenticateRequestOptions['acceptsToken']} [params.acceptsToken=TokenType.SessionToken] - The accepted token type(s). Can be a string, array of strings, or 'any'.
* @returns {AuthObject} The filtered or coerced auth object.
* Returns an auth object matching the requested token type(s).
*
* @example
* // Accept only 'api_key' tokens
* const authObject = { tokenType: 'session_token', userId: 'user_123' };
* const result = getAuthObjectForAcceptedToken({ authObject, acceptsToken: 'api_key' });
* // result will be a signed-out object (since tokenType is 'session_token' and does not match)
* If the parsed token type does not match any in acceptsToken, returns:
* - an unauthenticated machine object for the first machine token type in acceptsToken (if present), or
* - a signed-out session object otherwise.
*
* @example
* // Accept 'api_key' or 'machine_token'
* const authObject = { tokenType: 'machine_token', id: 'm2m_123' };
* const result = getAuthObjectForAcceptedToken({ authObject, acceptsToken: ['api_key', 'machine_token'] });
* // result will be the original authObject (since tokenType matches one in the array)
*
* @example
* // Accept any token type
* const authObject = { tokenType: 'api_key', id: 'ak_123' };
* const result = getAuthObjectForAcceptedToken({ authObject, acceptsToken: 'any' });
* // result will be the original authObject
* This ensures the returned object always matches the developer's intent.
*/
export function getAuthObjectForAcceptedToken({
authObject,
Expand All@@ -442,11 +444,20 @@ export function getAuthObjectForAcceptedToken({
return authObject;
}

if (Array.isArray(acceptsToken)) {
if (!isTokenTypeAccepted(authObject.tokenType, acceptsToken)) {
// If the token is not in the accepted array, return invalid token auth object
return invalidTokenAuthObject();
}
return authObject;
}
Comment thread
wobsoriano marked this conversation as resolved.

// Single value: Intent based
if (!isTokenTypeAccepted(authObject.tokenType, acceptsToken)) {
if (authObject.tokenType === TokenType.SessionToken) {
return signedOutAuthObject(authObject.debug);
if (isMachineTokenType(acceptsToken)) {
return unauthenticatedMachineObject(acceptsToken, authObject.debug);
}
return unauthenticatedMachineObject(authObject.tokenType, authObject.debug);
return signedOutAuthObject(authObject.debug);
}

return authObject;
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/open-swans-count.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
'@clerk/backend': minor
'@clerk/nextjs': minor
---

Respect `acceptsToken` when returning unauthenticated session or machine object.
4 changes: 3 additions & 1 deletion packages/backend/src/__tests__/exports.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,9 @@ describe('subpath /internal exports', () => {
"getAuthObjectForAcceptedToken",
"getAuthObjectFromJwt",
"getMachineTokenType",
"isMachineToken",
"invalidTokenAuthObject",
"isMachineTokenByPrefix",
"isMachineTokenType",
"isTokenTypeAccepted",
"makeAuthObjectSerializable",
"reverificationError",
Expand Down
2 changes: 1 addition & 1 deletion packages/backend/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -161,5 +161,5 @@ export type {
/**
* Auth objects
*/
export type { AuthObject } from './tokens/authObjects';
export type { AuthObject, InvalidTokenAuthObject } from './tokens/authObjects';
export type { SessionAuthObject, MachineAuthObject } from './tokens/types';
3 changes: 2 additions & 1 deletion packages/backend/src/internal.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,6 +31,7 @@ export {
signedInAuthObject,
authenticatedMachineObject,
unauthenticatedMachineObject,
invalidTokenAuthObject,
getAuthObjectFromJwt,
getAuthObjectForAcceptedToken,
} from './tokens/authObjects';
Expand All@@ -53,4 +54,4 @@ export { reverificationError, reverificationErrorResponse } from '@clerk/shared/

export { verifyMachineAuthToken } from './tokens/verify';

export { isMachineToken, getMachineTokenType, isTokenTypeAccepted } from './tokens/machine';
export { isMachineTokenByPrefix, isMachineTokenType, getMachineTokenType, isTokenTypeAccepted } from './tokens/machine';
45 changes: 45 additions & 0 deletions packages/backend/src/tokens/__tests__/authObjects.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,10 @@ import { describe, expect, it } from 'vitest';

import { mockTokens, mockVerificationResults } from '../../fixtures/machine';
import type { AuthenticateContext } from '../authenticateContext';
import type { InvalidTokenAuthObject, UnauthenticatedMachineObject } from '../authObjects';
import {
authenticatedMachineObject,
getAuthObjectForAcceptedToken,
makeAuthObjectSerializable,
signedInAuthObject,
signedOutAuthObject,
Expand DownExpand Up@@ -387,3 +389,46 @@ describe('unauthenticatedMachineObject', () => {
expect(retrievedToken).toBeNull();
});
});

describe('getAuthObjectForAcceptedToken', () => {
const debugData = { foo: 'bar' };
const sessionAuth = signedOutAuthObject(debugData);
const machineAuth = authenticatedMachineObject('api_key', 'ak_xxx', mockVerificationResults.api_key, debugData);

it('returns original object if acceptsToken is "any"', () => {
const result = getAuthObjectForAcceptedToken({ authObject: machineAuth, acceptsToken: 'any' });
expect(result).toBe(machineAuth);
});

it('returns original object if token type matches', () => {
const result = getAuthObjectForAcceptedToken({ authObject: machineAuth, acceptsToken: 'api_key' });
expect(result).toBe(machineAuth);
});

it('returns InvalidTokenAuthObject if acceptsToken is array and token type does not match', () => {
const result = getAuthObjectForAcceptedToken({
authObject: machineAuth,
acceptsToken: ['machine_token', 'oauth_token'],
});
expect((result as InvalidTokenAuthObject).tokenType).toBeNull();
expect((result as InvalidTokenAuthObject).isAuthenticated).toBe(false);
});

it('returns InvalidTokenAuthObject if parsed type is not a machine token and does not match any in acceptsToken array', () => {
const result = getAuthObjectForAcceptedToken({ authObject: sessionAuth, acceptsToken: ['api_key', 'oauth_token'] });
expect((result as InvalidTokenAuthObject).tokenType).toBeNull();
expect((result as InvalidTokenAuthObject).isAuthenticated).toBe(false);
});

it('returns signed-out session object if parsed type is not a machine token and does not match', () => {
const result = getAuthObjectForAcceptedToken({ authObject: sessionAuth, acceptsToken: ['api_key', 'oauth_token'] });
expect((result as InvalidTokenAuthObject).tokenType).toBeNull();
expect((result as InvalidTokenAuthObject).isAuthenticated).toBe(false);
});

it('returns unauthenticated object for requested type if acceptsToken is a single value and does not match', () => {
const result = getAuthObjectForAcceptedToken({ authObject: machineAuth, acceptsToken: 'machine_token' });
expect((result as UnauthenticatedMachineObject<'machine_token'>).tokenType).toBe('machine_token');
expect((result as UnauthenticatedMachineObject<'machine_token'>).id).toBeNull();
});
});
6 changes: 3 additions & 3 deletions packages/backend/src/tokens/__tests__/getAuth.test-d.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { expectTypeOf, test } from 'vitest';

import type { AuthObject } from '../authObjects';
import type { AuthObject, InvalidTokenAuthObject } from '../authObjects';
import type { GetAuthFn, MachineAuthObject, SessionAuthObject } from '../types';

// Across our SDKs, we have a getAuth() function
Expand All@@ -22,10 +22,10 @@ test('infers the correct AuthObject type for each accepted token type', () => {

// Array of token types
expectTypeOf(getAuth(request, { acceptsToken: ['session_token', 'machine_token'] })).toMatchTypeOf<
SessionAuthObject | MachineAuthObject<'machine_token'>
SessionAuthObject | MachineAuthObject<'machine_token'> | InvalidTokenAuthObject
>();
expectTypeOf(getAuth(request, { acceptsToken: ['machine_token', 'oauth_token'] })).toMatchTypeOf<
MachineAuthObject<'machine_token' | 'oauth_token'>
MachineAuthObject<'machine_token' | 'oauth_token'> | InvalidTokenAuthObject
>();

// Any token type
Expand Down
29 changes: 21 additions & 8 deletions packages/backend/src/tokens/__tests__/machine.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,33 +3,34 @@ import { describe, expect, it } from 'vitest';
import {
API_KEY_PREFIX,
getMachineTokenType,
isMachineToken,
isMachineTokenByPrefix,
isMachineTokenType,
isTokenTypeAccepted,
M2M_TOKEN_PREFIX,
OAUTH_TOKEN_PREFIX,
} from '../machine';

describe('isMachineToken', () => {
it('returns true for tokens with M2M prefix', () => {
expect(isMachineToken(`${M2M_TOKEN_PREFIX}some-token-value`)).toBe(true);
expect(isMachineTokenByPrefix(`${M2M_TOKEN_PREFIX}some-token-value`)).toBe(true);
});

it('returns true for tokens with OAuth prefix', () => {
expect(isMachineToken(`${OAUTH_TOKEN_PREFIX}some-token-value`)).toBe(true);
expect(isMachineTokenByPrefix(`${OAUTH_TOKEN_PREFIX}some-token-value`)).toBe(true);
});

it('returns true for tokens with API key prefix', () => {
expect(isMachineToken(`${API_KEY_PREFIX}some-token-value`)).toBe(true);
expect(isMachineTokenByPrefix(`${API_KEY_PREFIX}some-token-value`)).toBe(true);
});

it('returns false for tokens without a recognized prefix', () => {
expect(isMachineToken('unknown_prefix_token')).toBe(false);
expect(isMachineToken('session_token_value')).toBe(false);
expect(isMachineToken('jwt_token_value')).toBe(false);
expect(isMachineTokenByPrefix('unknown_prefix_token')).toBe(false);
expect(isMachineTokenByPrefix('session_token_value')).toBe(false);
expect(isMachineTokenByPrefix('jwt_token_value')).toBe(false);
});

it('returns false for empty tokens', () => {
expect(isMachineToken('')).toBe(false);
expect(isMachineTokenByPrefix('')).toBe(false);
});
});

Expand DownExpand Up@@ -78,3 +79,15 @@ describe('isTokenTypeAccepted', () => {
expect(isTokenTypeAccepted('api_key', 'machine_token')).toBe(false);
});
});

describe('isMachineTokenType', () => {
it('returns true for machine token types', () => {
expect(isMachineTokenType('api_key')).toBe(true);
expect(isMachineTokenType('machine_token')).toBe(true);
expect(isMachineTokenType('oauth_token')).toBe(true);
});

it('returns false for non-machine token types', () => {
expect(isMachineTokenType('session_token')).toBe(false);
});
});
87 changes: 49 additions & 38 deletions packages/backend/src/tokens/authObjects.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ import type { APIKey, CreateBackendApiOptions, IdPOAuthAccessToken, MachineToken
import { createBackendApiClient } from '../api';
import { isTokenTypeAccepted } from '../internal';
import type { AuthenticateContext } from './authenticateContext';
import { isMachineTokenType } from './machine';
import type { MachineTokenType, SessionTokenType } from './tokenTypes';
import { TokenType } from './tokenTypes';
import type { AuthenticateRequestOptions, MachineAuthType } from './types';
Expand DownExpand Up@@ -57,6 +58,7 @@ export type SignedInAuthObject = SharedSignedInAuthObjectProperties & {
* Used to help debug issues when using Clerk in development.
*/
debug: AuthObjectDebug;
isAuthenticated: true;
};

/**
Expand All@@ -77,6 +79,7 @@ export type SignedOutAuthObject = {
getToken: ServerGetToken;
has: CheckAuthorizationFromSessionClaims;
debug: AuthObjectDebug;
isAuthenticated: false;
};

/**
Expand DownExpand Up@@ -120,6 +123,7 @@ export type AuthenticatedMachineObject<T extends MachineTokenType = MachineToken
has: CheckAuthorizationFromSessionClaims;
debug: AuthObjectDebug;
tokenType: T;
isAuthenticated: true;
} & MachineObjectExtendedProperties<true>[T]
: never;

Expand All@@ -140,17 +144,27 @@ export type UnauthenticatedMachineObject<T extends MachineTokenType = MachineTok
has: CheckAuthorizationFromSessionClaims;
debug: AuthObjectDebug;
tokenType: T;
isAuthenticated: false;
} & MachineObjectExtendedProperties<false>[T]
: never;

export type InvalidTokenAuthObject = {
isAuthenticated: false;
tokenType: null;
getToken: () => Promise<null>;
has: () => false;
debug: AuthObjectDebug;
};

/**
* @interface
*/
export type AuthObject =
| SignedInAuthObject
| SignedOutAuthObject
| AuthenticatedMachineObject
| UnauthenticatedMachineObject;
| UnauthenticatedMachineObject
| InvalidTokenAuthObject;

const createDebug = (data: AuthObjectDebugData | undefined) => {
return () => {
Expand DownExpand Up@@ -200,6 +214,7 @@ export function signedInAuthObject(
plans: (sessionClaims.pla as string) || '',
}),
debug: createDebug({ ...authenticateContext, sessionToken }),
isAuthenticated: true,
};
}

Expand All@@ -225,6 +240,7 @@ export function signedOutAuthObject(
getToken: () => Promise.resolve(null),
has: () => false,
debug: createDebug(debugData),
isAuthenticated: false,
};
}

Expand All@@ -243,6 +259,7 @@ export function authenticatedMachineObject<T extends MachineTokenType>(
getToken: () => Promise.resolve(token),
has: () => false,
debug: createDebug(debugData),
isAuthenticated: true,
};

// Type assertions are safe here since we know the verification result type matches the tokenType.
Expand DownExpand Up@@ -302,6 +319,7 @@ export function unauthenticatedMachineObject<T extends MachineTokenType>(
has: () => false,
getToken: () => Promise.resolve(null),
debug: createDebug(debugData),
isAuthenticated: false,
};

switch (tokenType) {
Expand DownExpand Up@@ -340,6 +358,19 @@ export function unauthenticatedMachineObject<T extends MachineTokenType>(
}
}

/**
* @internal
*/
export function invalidTokenAuthObject(): InvalidTokenAuthObject {
return {
isAuthenticated: false,
tokenType: null,
getToken: () => Promise.resolve(null),
has: () => false,
debug: () => ({}),
};
}

/**
* Auth objects moving through the server -> client boundary need to be serializable
* as we need to ensure that they can be transferred via the network as pure strings.
Expand DownExpand Up@@ -394,42 +425,13 @@ export const getAuthObjectFromJwt = (

/**
* @internal
* Filters and coerces an AuthObject based on the accepted token type(s).
*
* This function is used after authentication to ensure that the returned auth object
* matches the expected token type(s) specified by `acceptsToken`. If the token type
* of the provided `authObject` does not match any of the types in `acceptsToken`,
* it returns an unauthenticated or signed-out version of the object, depending on the token type.
*
* - If `acceptsToken` is `'any'`, the original auth object is returned.
* - If `acceptsToken` is a single token type or an array of token types, the function checks if
* `authObject.tokenType` matches any of them.
* - If the token type does not match and is a session token, a signed-out object is returned.
* - If the token type does not match and is a machine token, an unauthenticated machine object is returned.
* - If the token type matches, the original auth object is returned.
*
* @param {Object} params
* @param {AuthObject} params.authObject - The authenticated object to filter.
* @param {AuthenticateRequestOptions['acceptsToken']} [params.acceptsToken=TokenType.SessionToken] - The accepted token type(s). Can be a string, array of strings, or 'any'.
* @returns {AuthObject} The filtered or coerced auth object.
* Returns an auth object matching the requested token type(s).
*
* @example
* // Accept only 'api_key' tokens
* const authObject = { tokenType: 'session_token', userId: 'user_123' };
* const result = getAuthObjectForAcceptedToken({ authObject, acceptsToken: 'api_key' });
* // result will be a signed-out object (since tokenType is 'session_token' and does not match)
* If the parsed token type does not match any in acceptsToken, returns:
* - an unauthenticated machine object for the first machine token type in acceptsToken (if present), or
* - a signed-out session object otherwise.
*
* @example
* // Accept 'api_key' or 'machine_token'
* const authObject = { tokenType: 'machine_token', id: 'm2m_123' };
* const result = getAuthObjectForAcceptedToken({ authObject, acceptsToken: ['api_key', 'machine_token'] });
* // result will be the original authObject (since tokenType matches one in the array)
*
* @example
* // Accept any token type
* const authObject = { tokenType: 'api_key', id: 'ak_123' };
* const result = getAuthObjectForAcceptedToken({ authObject, acceptsToken: 'any' });
* // result will be the original authObject
* This ensures the returned object always matches the developer's intent.
*/
export function getAuthObjectForAcceptedToken({
authObject,
Expand All@@ -442,11 +444,20 @@ export function getAuthObjectForAcceptedToken({
return authObject;
}

if (Array.isArray(acceptsToken)) {
if (!isTokenTypeAccepted(authObject.tokenType, acceptsToken)) {
// If the token is not in the accepted array, return invalid token auth object
return invalidTokenAuthObject();
}
return authObject;
}
Comment thread
wobsoriano marked this conversation as resolved.

// Single value: Intent based
if (!isTokenTypeAccepted(authObject.tokenType, acceptsToken)) {
if (authObject.tokenType === TokenType.SessionToken) {
return signedOutAuthObject(authObject.debug);
if (isMachineTokenType(acceptsToken)) {
return unauthenticatedMachineObject(acceptsToken, authObject.debug);
}
return unauthenticatedMachineObject(authObject.tokenType, authObject.debug);
return signedOutAuthObject(authObject.debug);
}

return authObject;
Expand Down
Loading