Skip to content

Revamp clerk-sdk-node build#612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikosdouvlis merged 2 commits into from
Dec 13, 2022
Merged

Revamp clerk-sdk-node build #612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1428d20
chore(repo): Share tsup dependency version
nikosdouvlis Dec 13, 2022
0491215
fix(clerk-sdk-node): Revamp build for esm and cjs in preparation for v5
nikosdouvlis Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/sdk-node/cjs/instance.d.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
export * from '../dist/cjs/instance';
export { default } from '../dist/cjs/instance';
export * from '../dist/types/instance';
export { default } from '../dist/types/instance';
2 changes: 1 addition & 1 deletion packages/sdk-node/cjs/instance.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
module.exports = require('../dist/cjs/instance');
module.exports = require('./../dist/instance');
4 changes: 2 additions & 2 deletions packages/sdk-node/esm/instance.d.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
export * from '../dist/esm/instance';
export { default } from '../dist/esm/instance';
export * from '../dist/types/instance';
export { default } from '../dist/types/instance';
2 changes: 1 addition & 1 deletion packages/sdk-node/esm/instance.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
module.exports = require('../dist/esm/instance');
export * from './../dist/instance.mjs';
30 changes: 23 additions & 7 deletions packages/sdk-node/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,37 @@
{
"version": "4.5.12",
"license": "MIT",
"main": "dist/cjs/index.js",
"module": "dist/esm/index.js",
"typings": "dist/cjs/index.d.ts",
"type": "commonjs",
"main": "./dist/index.js",
"module": "./dist/index.mjs",
"types": "./dist/types/index.d.ts",
"exports": {
".": {
"types": "./dist/types/index.d.ts",
"require": "./dist/index.js",
"import": "./dist/index.mjs",
"default": "./dist/index.js"
},
"./esm/instance": {
"types": "./dist/types/instance.d.ts",
"default": "./dist/instance.mjs"
},
"./cjs/instance": {
"types": "./dist/types/instance.d.ts",
"default": "./dist/instance.js"
}
},
"files": [
"dist",
"package.json",
"esm",
"cjs"
],
"engines": {
"node": ">=14"
},
"scripts": {
"build:es5": "node ./scripts/info.js && tsc -p tsconfig.build.json",
"build:esm": "node ./scripts/info.js && tsc -p tsconfig.esm.json",
"build": "run-p build:es5 build:esm",
"dev": "tsup --watch",
"build": "tsup --env.NODE_ENV production",
"clean": "rimraf ./dist",
"lint": "eslint .",
"test": "jest",
Expand All@@ -34,6 +49,7 @@
"npm-run-all": "^4.1.5",
"prettier": "^2.5.0",
"ts-jest": "^27.1.3",
"tsup": "*",
"typescript": "*"
},
"dependencies": {
Expand Down
9 changes: 0 additions & 9 deletions packages/sdk-node/tsconfig.build.json
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions packages/sdk-node/tsconfig.esm.json
View file
Open in desktop

This file was deleted.

24 changes: 13 additions & 11 deletions packages/sdk-node/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,21 @@
{
"include": ["src"],
"exclude": ["dist", "esm", "src/__tests__"],
"compilerOptions": {
"strict": true,
"declaration": true,
"declarationMap": false,
"downlevelIteration": true,
"sourceMap": false,
"declarationDir": "dist/types",
"declarationMap": true,
"emitDeclarationOnly": true,
"esModuleInterop": true,
"forceConsistentCasingInFileNames": true,
"importHelpers": true,
"moduleResolution": "node",
"noImplicitReturns": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"forceConsistentCasingInFileNames": true,
"target": "ES2020",
"moduleResolution": "node",
"esModuleInterop": true
}
"resolveJsonModule": true,
"sourceMap": false,
"strict": true,
"target": "ES2020"
},
"exclude": ["node_modules"],
"include": ["src/index.ts", "src/instance.ts"]
}
24 changes: 24 additions & 0 deletions packages/sdk-node/tsup.config.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
import { defineConfig } from 'tsup';

import { name, version } from './package.json';

console.log({ name, version });

@dimkldimklMar 21, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️

export default defineConfig(overrideOptions => {
const isProd = overrideOptions.env?.NODE_ENV === 'production';

return {
entry: ['src/index.ts', 'src/instance.ts'],
onSuccess: 'tsc',
clean: true,
// minify: isProd,
Comment thread
nikosdouvlis marked this conversation as resolved.
minify: false,

@dimkldimklMar 21, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ why is minify: false ?

sourcemap: true,
format: ['cjs', 'esm'],
define: {
PACKAGE_NAME: `"${name}"`,
PACKAGE_VERSION: `"${version}"`,
__DEV__: `${!isProd}`,
},
external: [],
};
});
2 changes: 1 addition & 1 deletion packages/shared/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,7 +26,7 @@
"@types/js-cookie": "^3.0.2",
"js-cookie": "^3.0.1",
"swr": "^1.3.0",
"tsup": "^6.2.3",
"tsup": "*",
"typescript": "*",
"vitest": "^0.23.4"
},
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Revamp clerk-sdk-node build by nikosdouvlis · Pull Request #612 · clerk/javascript · GitHub
Skip to content
Revamp clerk-sdk-node build#612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

nikosdouvlis
merged 2 commits into

from

Dec 13, 2022
 Merged


Revamp clerk-sdk-node build
#612
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
1428d20

chore(repo): Share tsup dependency version


nikosdouvlis Dec 13, 2022
0491215

fix(clerk-sdk-node): Revamp build for esm and cjs in preparation for v5


nikosdouvlis Dec 13, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 4 additions & 2 deletions
package-lock.json

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.


4 changes: 2 additions & 2 deletions
packages/sdk-node/cjs/instance.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
export * from '../dist/cjs/instance';
export { default } from '../dist/cjs/instance';
export * from '../dist/types/instance';
export { default } from '../dist/types/instance';

2 changes: 1 addition & 1 deletion
packages/sdk-node/cjs/instance.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
module.exports = require('../dist/cjs/instance');
module.exports = require('./../dist/instance');

4 changes: 2 additions & 2 deletions
packages/sdk-node/esm/instance.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
export * from '../dist/esm/instance';
export { default } from '../dist/esm/instance';
export * from '../dist/types/instance';
export { default } from '../dist/types/instance';

2 changes: 1 addition & 1 deletion
packages/sdk-node/esm/instance.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
module.exports = require('../dist/esm/instance');
export * from './../dist/instance.mjs';

30 changes: 23 additions & 7 deletions
packages/sdk-node/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,22 +1,37 @@
{
 "version": "4.5.12",
 "license": "MIT",
 "main": "dist/cjs/index.js",
 "module": "dist/esm/index.js",
 "typings": "dist/cjs/index.d.ts",
 "type": "commonjs",
 "main": "./dist/index.js",
 "module": "./dist/index.mjs",
 "types": "./dist/types/index.d.ts",
 "exports": {
 ".": {
 "types": "./dist/types/index.d.ts",
 "require": "./dist/index.js",
 "import": "./dist/index.mjs",
 "default": "./dist/index.js"
 },
 "./esm/instance": {
 "types": "./dist/types/instance.d.ts",
 "default": "./dist/instance.mjs"
 },
 "./cjs/instance": {
 "types": "./dist/types/instance.d.ts",
 "default": "./dist/instance.js"
 }
 },
 "files": [
 "dist",
 "package.json",
 "esm",
 "cjs"
 ],
 "engines": {
 "node": ">=14"
 },
 "scripts": {
 "build:es5": "node ./scripts/info.js && tsc -p tsconfig.build.json",
 "build:esm": "node ./scripts/info.js && tsc -p tsconfig.esm.json",
 "build": "run-p build:es5 build:esm",
 "dev": "tsup --watch",
 "build": "tsup --env.NODE_ENV production",
 "clean": "rimraf ./dist",
 "lint": "eslint .",
 "test": "jest",
Expand All@@ -34,6 +49,7 @@
 "npm-run-all": "^4.1.5",
 "prettier": "^2.5.0",
 "ts-jest": "^27.1.3",
 "tsup": "*",
 "typescript": "*"
 },
 "dependencies": {
Expand Down

9 changes: 0 additions & 9 deletions
packages/sdk-node/tsconfig.build.json

View file


Open in desktop


This file was deleted.


9 changes: 0 additions & 9 deletions
packages/sdk-node/tsconfig.esm.json

View file


Open in desktop


This file was deleted.


24 changes: 13 additions & 11 deletions
packages/sdk-node/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,19 +1,21 @@
{
 "include": ["src"],
 "exclude": ["dist", "esm", "src/__tests__"],
 "compilerOptions": {
 "strict": true,
 "declaration": true,
 "declarationMap": false,
 "downlevelIteration": true,
 "sourceMap": false,
 "declarationDir": "dist/types",
 "declarationMap": true,
 "emitDeclarationOnly": true,
 "esModuleInterop": true,
 "forceConsistentCasingInFileNames": true,
 "importHelpers": true,
 "moduleResolution": "node",
 "noImplicitReturns": true,
 "noUnusedLocals": true,
 "noUnusedParameters": true,
 "forceConsistentCasingInFileNames": true,
 "target": "ES2020",
 "moduleResolution": "node",
 "esModuleInterop": true
 }
 "resolveJsonModule": true,
 "sourceMap": false,
 "strict": true,
 "target": "ES2020"
 },
 "exclude": ["node_modules"],
 "include": ["src/index.ts", "src/instance.ts"]
}

24 changes: 24 additions & 0 deletions
packages/sdk-node/tsup.config.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
import { defineConfig } from 'tsup';

import { name, version } from './package.json';

console.log({ name, version });
@dimkldimklMar 21, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️
export default defineConfig(overrideOptions => {
 const isProd = overrideOptions.env?.NODE_ENV === 'production';

 return {
 entry: ['src/index.ts', 'src/instance.ts'],
 onSuccess: 'tsc',
 clean: true,
 // minify: isProd,
Comment thread
nikosdouvlis marked this conversation as resolved.

 minify: false,
@dimkldimklMar 21, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ why is minify: false ?
 sourcemap: true,
 format: ['cjs', 'esm'],
 define: {
 PACKAGE_NAME: `"${name}"`,
 PACKAGE_VERSION: `"${version}"`,
 __DEV__: `${!isProd}`,
 },
 external: [],
 };
});

2 changes: 1 addition & 1 deletion
packages/shared/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,7 +26,7 @@
 "@types/js-cookie": "^3.0.2",
 "js-cookie": "^3.0.1",
 "swr": "^1.3.0",
 "tsup": "^6.2.3",
 "tsup": "*",
 "typescript": "*",
 "vitest": "^0.23.4"
 },
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Revamp clerk-sdk-node build by nikosdouvlis · Pull Request #612 · clerk/javascript · GitHub
Skip to content
Revamp clerk-sdk-node build#612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

nikosdouvlis
merged 2 commits into

from

Dec 13, 2022
 Merged


Revamp clerk-sdk-node build
#612
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
1428d20

chore(repo): Share tsup dependency version


nikosdouvlis Dec 13, 2022
0491215

fix(clerk-sdk-node): Revamp build for esm and cjs in preparation for v5


nikosdouvlis Dec 13, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 4 additions & 2 deletions
package-lock.json

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.


4 changes: 2 additions & 2 deletions
packages/sdk-node/cjs/instance.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
export * from '../dist/cjs/instance';
export { default } from '../dist/cjs/instance';
export * from '../dist/types/instance';
export { default } from '../dist/types/instance';

2 changes: 1 addition & 1 deletion
packages/sdk-node/cjs/instance.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
module.exports = require('../dist/cjs/instance');
module.exports = require('./../dist/instance');

4 changes: 2 additions & 2 deletions
packages/sdk-node/esm/instance.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
export * from '../dist/esm/instance';
export { default } from '../dist/esm/instance';
export * from '../dist/types/instance';
export { default } from '../dist/types/instance';

2 changes: 1 addition & 1 deletion
packages/sdk-node/esm/instance.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
module.exports = require('../dist/esm/instance');
export * from './../dist/instance.mjs';

30 changes: 23 additions & 7 deletions
packages/sdk-node/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,22 +1,37 @@
{
 "version": "4.5.12",
 "license": "MIT",
 "main": "dist/cjs/index.js",
 "module": "dist/esm/index.js",
 "typings": "dist/cjs/index.d.ts",
 "type": "commonjs",
 "main": "./dist/index.js",
 "module": "./dist/index.mjs",
 "types": "./dist/types/index.d.ts",
 "exports": {
 ".": {
 "types": "./dist/types/index.d.ts",
 "require": "./dist/index.js",
 "import": "./dist/index.mjs",
 "default": "./dist/index.js"
 },
 "./esm/instance": {
 "types": "./dist/types/instance.d.ts",
 "default": "./dist/instance.mjs"
 },
 "./cjs/instance": {
 "types": "./dist/types/instance.d.ts",
 "default": "./dist/instance.js"
 }
 },
 "files": [
 "dist",
 "package.json",
 "esm",
 "cjs"
 ],
 "engines": {
 "node": ">=14"
 },
 "scripts": {
 "build:es5": "node ./scripts/info.js && tsc -p tsconfig.build.json",
 "build:esm": "node ./scripts/info.js && tsc -p tsconfig.esm.json",
 "build": "run-p build:es5 build:esm",
 "dev": "tsup --watch",
 "build": "tsup --env.NODE_ENV production",
 "clean": "rimraf ./dist",
 "lint": "eslint .",
 "test": "jest",
Expand All@@ -34,6 +49,7 @@
 "npm-run-all": "^4.1.5",
 "prettier": "^2.5.0",
 "ts-jest": "^27.1.3",
 "tsup": "*",
 "typescript": "*"
 },
 "dependencies": {
Expand Down

9 changes: 0 additions & 9 deletions
packages/sdk-node/tsconfig.build.json

View file


Open in desktop


This file was deleted.


9 changes: 0 additions & 9 deletions
packages/sdk-node/tsconfig.esm.json

View file


Open in desktop


This file was deleted.


24 changes: 13 additions & 11 deletions
packages/sdk-node/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,19 +1,21 @@
{
 "include": ["src"],
 "exclude": ["dist", "esm", "src/__tests__"],
 "compilerOptions": {
 "strict": true,
 "declaration": true,
 "declarationMap": false,
 "downlevelIteration": true,
 "sourceMap": false,
 "declarationDir": "dist/types",
 "declarationMap": true,
 "emitDeclarationOnly": true,
 "esModuleInterop": true,
 "forceConsistentCasingInFileNames": true,
 "importHelpers": true,
 "moduleResolution": "node",
 "noImplicitReturns": true,
 "noUnusedLocals": true,
 "noUnusedParameters": true,
 "forceConsistentCasingInFileNames": true,
 "target": "ES2020",
 "moduleResolution": "node",
 "esModuleInterop": true
 }
 "resolveJsonModule": true,
 "sourceMap": false,
 "strict": true,
 "target": "ES2020"
 },
 "exclude": ["node_modules"],
 "include": ["src/index.ts", "src/instance.ts"]
}

24 changes: 24 additions & 0 deletions
packages/sdk-node/tsup.config.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
import { defineConfig } from 'tsup';

import { name, version } from './package.json';

console.log({ name, version });
@dimkldimklMar 21, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️
export default defineConfig(overrideOptions => {
 const isProd = overrideOptions.env?.NODE_ENV === 'production';

 return {
 entry: ['src/index.ts', 'src/instance.ts'],
 onSuccess: 'tsc',
 clean: true,
 // minify: isProd,
Comment thread
nikosdouvlis marked this conversation as resolved.

 minify: false,
@dimkldimklMar 21, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ why is minify: false ?
 sourcemap: true,
 format: ['cjs', 'esm'],
 define: {
 PACKAGE_NAME: `"${name}"`,
 PACKAGE_VERSION: `"${version}"`,
 __DEV__: `${!isProd}`,
 },
 external: [],
 };
});

2 changes: 1 addition & 1 deletion
packages/shared/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,7 +26,7 @@
 "@types/js-cookie": "^3.0.2",
 "js-cookie": "^3.0.1",
 "swr": "^1.3.0",
 "tsup": "^6.2.3",
 "tsup": "*",
 "typescript": "*",
 "vitest": "^0.23.4"
 },
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Revamp clerk-sdk-node build by nikosdouvlis · Pull Request #612 · clerk/javascript · GitHub
Skip to content
Revamp clerk-sdk-node build#612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

nikosdouvlis
merged 2 commits into

from

Dec 13, 2022
 Merged


Revamp clerk-sdk-node build
#612
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
1428d20

chore(repo): Share tsup dependency version


nikosdouvlis Dec 13, 2022
0491215

fix(clerk-sdk-node): Revamp build for esm and cjs in preparation for v5


nikosdouvlis Dec 13, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 4 additions & 2 deletions
package-lock.json

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.


4 changes: 2 additions & 2 deletions
packages/sdk-node/cjs/instance.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
export * from '../dist/cjs/instance';
export { default } from '../dist/cjs/instance';
export * from '../dist/types/instance';
export { default } from '../dist/types/instance';

2 changes: 1 addition & 1 deletion
packages/sdk-node/cjs/instance.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
module.exports = require('../dist/cjs/instance');
module.exports = require('./../dist/instance');

4 changes: 2 additions & 2 deletions
packages/sdk-node/esm/instance.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
export * from '../dist/esm/instance';
export { default } from '../dist/esm/instance';
export * from '../dist/types/instance';
export { default } from '../dist/types/instance';

2 changes: 1 addition & 1 deletion
packages/sdk-node/esm/instance.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
module.exports = require('../dist/esm/instance');
export * from './../dist/instance.mjs';

30 changes: 23 additions & 7 deletions
packages/sdk-node/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,22 +1,37 @@
{
 "version": "4.5.12",
 "license": "MIT",
 "main": "dist/cjs/index.js",
 "module": "dist/esm/index.js",
 "typings": "dist/cjs/index.d.ts",
 "type": "commonjs",
 "main": "./dist/index.js",
 "module": "./dist/index.mjs",
 "types": "./dist/types/index.d.ts",
 "exports": {
 ".": {
 "types": "./dist/types/index.d.ts",
 "require": "./dist/index.js",
 "import": "./dist/index.mjs",
 "default": "./dist/index.js"
 },
 "./esm/instance": {
 "types": "./dist/types/instance.d.ts",
 "default": "./dist/instance.mjs"
 },
 "./cjs/instance": {
 "types": "./dist/types/instance.d.ts",
 "default": "./dist/instance.js"
 }
 },
 "files": [
 "dist",
 "package.json",
 "esm",
 "cjs"
 ],
 "engines": {
 "node": ">=14"
 },
 "scripts": {
 "build:es5": "node ./scripts/info.js && tsc -p tsconfig.build.json",
 "build:esm": "node ./scripts/info.js && tsc -p tsconfig.esm.json",
 "build": "run-p build:es5 build:esm",
 "dev": "tsup --watch",
 "build": "tsup --env.NODE_ENV production",
 "clean": "rimraf ./dist",
 "lint": "eslint .",
 "test": "jest",
Expand All@@ -34,6 +49,7 @@
 "npm-run-all": "^4.1.5",
 "prettier": "^2.5.0",
 "ts-jest": "^27.1.3",
 "tsup": "*",
 "typescript": "*"
 },
 "dependencies": {
Expand Down

9 changes: 0 additions & 9 deletions
packages/sdk-node/tsconfig.build.json

View file


Open in desktop


This file was deleted.


9 changes: 0 additions & 9 deletions
packages/sdk-node/tsconfig.esm.json

View file


Open in desktop


This file was deleted.


24 changes: 13 additions & 11 deletions
packages/sdk-node/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,19 +1,21 @@
{
 "include": ["src"],
 "exclude": ["dist", "esm", "src/__tests__"],
 "compilerOptions": {
 "strict": true,
 "declaration": true,
 "declarationMap": false,
 "downlevelIteration": true,
 "sourceMap": false,
 "declarationDir": "dist/types",
 "declarationMap": true,
 "emitDeclarationOnly": true,
 "esModuleInterop": true,
 "forceConsistentCasingInFileNames": true,
 "importHelpers": true,
 "moduleResolution": "node",
 "noImplicitReturns": true,
 "noUnusedLocals": true,
 "noUnusedParameters": true,
 "forceConsistentCasingInFileNames": true,
 "target": "ES2020",
 "moduleResolution": "node",
 "esModuleInterop": true
 }
 "resolveJsonModule": true,
 "sourceMap": false,
 "strict": true,
 "target": "ES2020"
 },
 "exclude": ["node_modules"],
 "include": ["src/index.ts", "src/instance.ts"]
}

24 changes: 24 additions & 0 deletions
packages/sdk-node/tsup.config.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
import { defineConfig } from 'tsup';

import { name, version } from './package.json';

console.log({ name, version });
@dimkldimklMar 21, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️
export default defineConfig(overrideOptions => {
 const isProd = overrideOptions.env?.NODE_ENV === 'production';

 return {
 entry: ['src/index.ts', 'src/instance.ts'],
 onSuccess: 'tsc',
 clean: true,
 // minify: isProd,
Comment thread
nikosdouvlis marked this conversation as resolved.

 minify: false,
@dimkldimklMar 21, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ why is minify: false ?
 sourcemap: true,
 format: ['cjs', 'esm'],
 define: {
 PACKAGE_NAME: `"${name}"`,
 PACKAGE_VERSION: `"${version}"`,
 __DEV__: `${!isProd}`,
 },
 external: [],
 };
});

2 changes: 1 addition & 1 deletion
packages/shared/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,7 +26,7 @@
 "@types/js-cookie": "^3.0.2",
 "js-cookie": "^3.0.1",
 "swr": "^1.3.0",
 "tsup": "^6.2.3",
 "tsup": "*",
 "typescript": "*",
 "vitest": "^0.23.4"
 },
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Revamp clerk-sdk-node build by nikosdouvlis · Pull Request #612 · clerk/javascript · GitHub
Skip to content
Revamp clerk-sdk-node build#612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

nikosdouvlis
merged 2 commits into

from

Dec 13, 2022
 Merged


Revamp clerk-sdk-node build
#612
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
1428d20

chore(repo): Share tsup dependency version


nikosdouvlis Dec 13, 2022
0491215

fix(clerk-sdk-node): Revamp build for esm and cjs in preparation for v5


nikosdouvlis Dec 13, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 4 additions & 2 deletions
package-lock.json

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.


4 changes: 2 additions & 2 deletions
packages/sdk-node/cjs/instance.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
export * from '../dist/cjs/instance';
export { default } from '../dist/cjs/instance';
export * from '../dist/types/instance';
export { default } from '../dist/types/instance';

2 changes: 1 addition & 1 deletion
packages/sdk-node/cjs/instance.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
module.exports = require('../dist/cjs/instance');
module.exports = require('./../dist/instance');

4 changes: 2 additions & 2 deletions
packages/sdk-node/esm/instance.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
export * from '../dist/esm/instance';
export { default } from '../dist/esm/instance';
export * from '../dist/types/instance';
export { default } from '../dist/types/instance';

2 changes: 1 addition & 1 deletion
packages/sdk-node/esm/instance.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
module.exports = require('../dist/esm/instance');
export * from './../dist/instance.mjs';

30 changes: 23 additions & 7 deletions
packages/sdk-node/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,22 +1,37 @@
{
 "version": "4.5.12",
 "license": "MIT",
 "main": "dist/cjs/index.js",
 "module": "dist/esm/index.js",
 "typings": "dist/cjs/index.d.ts",
 "type": "commonjs",
 "main": "./dist/index.js",
 "module": "./dist/index.mjs",
 "types": "./dist/types/index.d.ts",
 "exports": {
 ".": {
 "types": "./dist/types/index.d.ts",
 "require": "./dist/index.js",
 "import": "./dist/index.mjs",
 "default": "./dist/index.js"
 },
 "./esm/instance": {
 "types": "./dist/types/instance.d.ts",
 "default": "./dist/instance.mjs"
 },
 "./cjs/instance": {
 "types": "./dist/types/instance.d.ts",
 "default": "./dist/instance.js"
 }
 },
 "files": [
 "dist",
 "package.json",
 "esm",
 "cjs"
 ],
 "engines": {
 "node": ">=14"
 },
 "scripts": {
 "build:es5": "node ./scripts/info.js && tsc -p tsconfig.build.json",
 "build:esm": "node ./scripts/info.js && tsc -p tsconfig.esm.json",
 "build": "run-p build:es5 build:esm",
 "dev": "tsup --watch",
 "build": "tsup --env.NODE_ENV production",
 "clean": "rimraf ./dist",
 "lint": "eslint .",
 "test": "jest",
Expand All@@ -34,6 +49,7 @@
 "npm-run-all": "^4.1.5",
 "prettier": "^2.5.0",
 "ts-jest": "^27.1.3",
 "tsup": "*",
 "typescript": "*"
 },
 "dependencies": {
Expand Down

9 changes: 0 additions & 9 deletions
packages/sdk-node/tsconfig.build.json

View file


Open in desktop


This file was deleted.


9 changes: 0 additions & 9 deletions
packages/sdk-node/tsconfig.esm.json

View file


Open in desktop


This file was deleted.


24 changes: 13 additions & 11 deletions
packages/sdk-node/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,19 +1,21 @@
{
 "include": ["src"],
 "exclude": ["dist", "esm", "src/__tests__"],
 "compilerOptions": {
 "strict": true,
 "declaration": true,
 "declarationMap": false,
 "downlevelIteration": true,
 "sourceMap": false,
 "declarationDir": "dist/types",
 "declarationMap": true,
 "emitDeclarationOnly": true,
 "esModuleInterop": true,
 "forceConsistentCasingInFileNames": true,
 "importHelpers": true,
 "moduleResolution": "node",
 "noImplicitReturns": true,
 "noUnusedLocals": true,
 "noUnusedParameters": true,
 "forceConsistentCasingInFileNames": true,
 "target": "ES2020",
 "moduleResolution": "node",
 "esModuleInterop": true
 }
 "resolveJsonModule": true,
 "sourceMap": false,
 "strict": true,
 "target": "ES2020"
 },
 "exclude": ["node_modules"],
 "include": ["src/index.ts", "src/instance.ts"]
}

24 changes: 24 additions & 0 deletions
packages/sdk-node/tsup.config.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
import { defineConfig } from 'tsup';

import { name, version } from './package.json';

console.log({ name, version });
@dimkldimklMar 21, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️
export default defineConfig(overrideOptions => {
 const isProd = overrideOptions.env?.NODE_ENV === 'production';

 return {
 entry: ['src/index.ts', 'src/instance.ts'],
 onSuccess: 'tsc',
 clean: true,
 // minify: isProd,
Comment thread
nikosdouvlis marked this conversation as resolved.

 minify: false,
@dimkldimklMar 21, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ why is minify: false ?
 sourcemap: true,
 format: ['cjs', 'esm'],
 define: {
 PACKAGE_NAME: `"${name}"`,
 PACKAGE_VERSION: `"${version}"`,
 __DEV__: `${!isProd}`,
 },
 external: [],
 };
});

2 changes: 1 addition & 1 deletion
packages/shared/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,7 +26,7 @@
 "@types/js-cookie": "^3.0.2",
 "js-cookie": "^3.0.1",
 "swr": "^1.3.0",
 "tsup": "^6.2.3",
 "tsup": "*",
 "typescript": "*",
 "vitest": "^0.23.4"
 },
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Revamp clerk-sdk-node build by nikosdouvlis · Pull Request #612 · clerk/javascript · GitHub
Skip to content
Revamp clerk-sdk-node build#612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

nikosdouvlis
merged 2 commits into

from

Dec 13, 2022
 Merged


Revamp clerk-sdk-node build
#612
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
1428d20

chore(repo): Share tsup dependency version


nikosdouvlis Dec 13, 2022
0491215

fix(clerk-sdk-node): Revamp build for esm and cjs in preparation for v5


nikosdouvlis Dec 13, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 4 additions & 2 deletions
package-lock.json

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.


4 changes: 2 additions & 2 deletions
packages/sdk-node/cjs/instance.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
export * from '../dist/cjs/instance';
export { default } from '../dist/cjs/instance';
export * from '../dist/types/instance';
export { default } from '../dist/types/instance';

2 changes: 1 addition & 1 deletion
packages/sdk-node/cjs/instance.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
module.exports = require('../dist/cjs/instance');
module.exports = require('./../dist/instance');

4 changes: 2 additions & 2 deletions
packages/sdk-node/esm/instance.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
export * from '../dist/esm/instance';
export { default } from '../dist/esm/instance';
export * from '../dist/types/instance';
export { default } from '../dist/types/instance';

2 changes: 1 addition & 1 deletion
packages/sdk-node/esm/instance.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
module.exports = require('../dist/esm/instance');
export * from './../dist/instance.mjs';

30 changes: 23 additions & 7 deletions
packages/sdk-node/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,22 +1,37 @@
{
 "version": "4.5.12",
 "license": "MIT",
 "main": "dist/cjs/index.js",
 "module": "dist/esm/index.js",
 "typings": "dist/cjs/index.d.ts",
 "type": "commonjs",
 "main": "./dist/index.js",
 "module": "./dist/index.mjs",
 "types": "./dist/types/index.d.ts",
 "exports": {
 ".": {
 "types": "./dist/types/index.d.ts",
 "require": "./dist/index.js",
 "import": "./dist/index.mjs",
 "default": "./dist/index.js"
 },
 "./esm/instance": {
 "types": "./dist/types/instance.d.ts",
 "default": "./dist/instance.mjs"
 },
 "./cjs/instance": {
 "types": "./dist/types/instance.d.ts",
 "default": "./dist/instance.js"
 }
 },
 "files": [
 "dist",
 "package.json",
 "esm",
 "cjs"
 ],
 "engines": {
 "node": ">=14"
 },
 "scripts": {
 "build:es5": "node ./scripts/info.js && tsc -p tsconfig.build.json",
 "build:esm": "node ./scripts/info.js && tsc -p tsconfig.esm.json",
 "build": "run-p build:es5 build:esm",
 "dev": "tsup --watch",
 "build": "tsup --env.NODE_ENV production",
 "clean": "rimraf ./dist",
 "lint": "eslint .",
 "test": "jest",
Expand All@@ -34,6 +49,7 @@
 "npm-run-all": "^4.1.5",
 "prettier": "^2.5.0",
 "ts-jest": "^27.1.3",
 "tsup": "*",
 "typescript": "*"
 },
 "dependencies": {
Expand Down

9 changes: 0 additions & 9 deletions
packages/sdk-node/tsconfig.build.json

View file


Open in desktop


This file was deleted.


9 changes: 0 additions & 9 deletions
packages/sdk-node/tsconfig.esm.json

View file


Open in desktop


This file was deleted.


24 changes: 13 additions & 11 deletions
packages/sdk-node/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,19 +1,21 @@
{
 "include": ["src"],
 "exclude": ["dist", "esm", "src/__tests__"],
 "compilerOptions": {
 "strict": true,
 "declaration": true,
 "declarationMap": false,
 "downlevelIteration": true,
 "sourceMap": false,
 "declarationDir": "dist/types",
 "declarationMap": true,
 "emitDeclarationOnly": true,
 "esModuleInterop": true,
 "forceConsistentCasingInFileNames": true,
 "importHelpers": true,
 "moduleResolution": "node",
 "noImplicitReturns": true,
 "noUnusedLocals": true,
 "noUnusedParameters": true,
 "forceConsistentCasingInFileNames": true,
 "target": "ES2020",
 "moduleResolution": "node",
 "esModuleInterop": true
 }
 "resolveJsonModule": true,
 "sourceMap": false,
 "strict": true,
 "target": "ES2020"
 },
 "exclude": ["node_modules"],
 "include": ["src/index.ts", "src/instance.ts"]
}

24 changes: 24 additions & 0 deletions
packages/sdk-node/tsup.config.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
import { defineConfig } from 'tsup';

import { name, version } from './package.json';

console.log({ name, version });
@dimkldimklMar 21, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️
export default defineConfig(overrideOptions => {
 const isProd = overrideOptions.env?.NODE_ENV === 'production';

 return {
 entry: ['src/index.ts', 'src/instance.ts'],
 onSuccess: 'tsc',
 clean: true,
 // minify: isProd,
Comment thread
nikosdouvlis marked this conversation as resolved.

 minify: false,
@dimkldimklMar 21, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ why is minify: false ?
 sourcemap: true,
 format: ['cjs', 'esm'],
 define: {
 PACKAGE_NAME: `"${name}"`,
 PACKAGE_VERSION: `"${version}"`,
 __DEV__: `${!isProd}`,
 },
 external: [],
 };
});

2 changes: 1 addition & 1 deletion
packages/shared/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,7 +26,7 @@
 "@types/js-cookie": "^3.0.2",
 "js-cookie": "^3.0.1",
 "swr": "^1.3.0",
 "tsup": "^6.2.3",
 "tsup": "*",
 "typescript": "*",
 "vitest": "^0.23.4"
 },
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Revamp clerk-sdk-node build by nikosdouvlis · Pull Request #612 · clerk/javascript · GitHub
Skip to content
Revamp clerk-sdk-node build#612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

nikosdouvlis
merged 2 commits into

from

Dec 13, 2022
 Merged


Revamp clerk-sdk-node build
#612
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
1428d20

chore(repo): Share tsup dependency version


nikosdouvlis Dec 13, 2022
0491215

fix(clerk-sdk-node): Revamp build for esm and cjs in preparation for v5


nikosdouvlis Dec 13, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 4 additions & 2 deletions
package-lock.json

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.


4 changes: 2 additions & 2 deletions
packages/sdk-node/cjs/instance.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
export * from '../dist/cjs/instance';
export { default } from '../dist/cjs/instance';
export * from '../dist/types/instance';
export { default } from '../dist/types/instance';

2 changes: 1 addition & 1 deletion
packages/sdk-node/cjs/instance.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
module.exports = require('../dist/cjs/instance');
module.exports = require('./../dist/instance');

4 changes: 2 additions & 2 deletions
packages/sdk-node/esm/instance.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
export * from '../dist/esm/instance';
export { default } from '../dist/esm/instance';
export * from '../dist/types/instance';
export { default } from '../dist/types/instance';

2 changes: 1 addition & 1 deletion
packages/sdk-node/esm/instance.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
module.exports = require('../dist/esm/instance');
export * from './../dist/instance.mjs';

30 changes: 23 additions & 7 deletions
packages/sdk-node/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,22 +1,37 @@
{
 "version": "4.5.12",
 "license": "MIT",
 "main": "dist/cjs/index.js",
 "module": "dist/esm/index.js",
 "typings": "dist/cjs/index.d.ts",
 "type": "commonjs",
 "main": "./dist/index.js",
 "module": "./dist/index.mjs",
 "types": "./dist/types/index.d.ts",
 "exports": {
 ".": {
 "types": "./dist/types/index.d.ts",
 "require": "./dist/index.js",
 "import": "./dist/index.mjs",
 "default": "./dist/index.js"
 },
 "./esm/instance": {
 "types": "./dist/types/instance.d.ts",
 "default": "./dist/instance.mjs"
 },
 "./cjs/instance": {
 "types": "./dist/types/instance.d.ts",
 "default": "./dist/instance.js"
 }
 },
 "files": [
 "dist",
 "package.json",
 "esm",
 "cjs"
 ],
 "engines": {
 "node": ">=14"
 },
 "scripts": {
 "build:es5": "node ./scripts/info.js && tsc -p tsconfig.build.json",
 "build:esm": "node ./scripts/info.js && tsc -p tsconfig.esm.json",
 "build": "run-p build:es5 build:esm",
 "dev": "tsup --watch",
 "build": "tsup --env.NODE_ENV production",
 "clean": "rimraf ./dist",
 "lint": "eslint .",
 "test": "jest",
Expand All@@ -34,6 +49,7 @@
 "npm-run-all": "^4.1.5",
 "prettier": "^2.5.0",
 "ts-jest": "^27.1.3",
 "tsup": "*",
 "typescript": "*"
 },
 "dependencies": {
Expand Down

9 changes: 0 additions & 9 deletions
packages/sdk-node/tsconfig.build.json

View file


Open in desktop


This file was deleted.


9 changes: 0 additions & 9 deletions
packages/sdk-node/tsconfig.esm.json

View file


Open in desktop


This file was deleted.


24 changes: 13 additions & 11 deletions
packages/sdk-node/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,19 +1,21 @@
{
 "include": ["src"],
 "exclude": ["dist", "esm", "src/__tests__"],
 "compilerOptions": {
 "strict": true,
 "declaration": true,
 "declarationMap": false,
 "downlevelIteration": true,
 "sourceMap": false,
 "declarationDir": "dist/types",
 "declarationMap": true,
 "emitDeclarationOnly": true,
 "esModuleInterop": true,
 "forceConsistentCasingInFileNames": true,
 "importHelpers": true,
 "moduleResolution": "node",
 "noImplicitReturns": true,
 "noUnusedLocals": true,
 "noUnusedParameters": true,
 "forceConsistentCasingInFileNames": true,
 "target": "ES2020",
 "moduleResolution": "node",
 "esModuleInterop": true
 }
 "resolveJsonModule": true,
 "sourceMap": false,
 "strict": true,
 "target": "ES2020"
 },
 "exclude": ["node_modules"],
 "include": ["src/index.ts", "src/instance.ts"]
}

24 changes: 24 additions & 0 deletions
packages/sdk-node/tsup.config.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
import { defineConfig } from 'tsup';

import { name, version } from './package.json';

console.log({ name, version });
@dimkldimklMar 21, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️
export default defineConfig(overrideOptions => {
 const isProd = overrideOptions.env?.NODE_ENV === 'production';

 return {
 entry: ['src/index.ts', 'src/instance.ts'],
 onSuccess: 'tsc',
 clean: true,
 // minify: isProd,
Comment thread
nikosdouvlis marked this conversation as resolved.

 minify: false,
@dimkldimklMar 21, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ why is minify: false ?
 sourcemap: true,
 format: ['cjs', 'esm'],
 define: {
 PACKAGE_NAME: `"${name}"`,
 PACKAGE_VERSION: `"${version}"`,
 __DEV__: `${!isProd}`,
 },
 external: [],
 };
});

2 changes: 1 addition & 1 deletion
packages/shared/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,7 +26,7 @@
 "@types/js-cookie": "^3.0.2",
 "js-cookie": "^3.0.1",
 "swr": "^1.3.0",
 "tsup": "^6.2.3",
 "tsup": "*",
 "typescript": "*",
 "vitest": "^0.23.4"
 },
Expand Down