Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/twelve-ducks-refuse.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
---
'@clerk/chrome-extension': minor
---

- Explicitly mark `GoogleOneTap` and `SignInWithMetamaskButton` UI components as deprecated and unsupported (due to the requirement of Remotely Hosted Code) to help avoid confusion.

- Enable Metamask and OKXWallet Web3 for non-popup extensions.
5 changes: 3 additions & 2 deletions packages/chrome-extension/src/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
export * from '@clerk/clerk-react';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmilewski Is it better to simply control what's exported here instead of breaking without realising it ?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, though the plan was to deprecate, then remove in a major.


export type { StorageCache } from './internal/utils/storage';

// The order matters since we want override @clerk/clerk-react ClerkProvider
export { ClerkProvider } from './react';
// The order matters since we want override @clerk/clerk-react components
export { ClerkProvider, GoogleOneTap } from './react';

// Override Clerk React error thrower to show that errors come from @clerk/chrome-extension
import { setErrorThrowerOptions } from '@clerk/clerk-react/internal';
Expand Down
5 changes: 5 additions & 0 deletions packages/chrome-extension/src/react/NotSupported.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
/**
* @deprecated This component is not supported in Browser Extensions due to Chrome's security restrictions around remotely hosted code.
* @see https://clerk.com/docs/references/browser-extensions/browser-security-restrictions
*/
export const GoogleOneTap = () => null;
1 change: 1 addition & 0 deletions packages/chrome-extension/src/react/index.ts
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
export { ClerkProvider } from './ClerkProvider';
export { GoogleOneTap } from './NotSupported';
20 changes: 0 additions & 20 deletions packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1986,35 +1986,20 @@ export class Clerk implements ClerkInterface {
};

public authenticateWithMetamask = async (props: AuthenticateWithMetamaskParams = {}): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Metamask');
return;
}

await this.authenticateWithWeb3({
...props,
strategy: 'web3_metamask_signature',
});
};

public authenticateWithCoinbaseWallet = async (props: AuthenticateWithCoinbaseWalletParams = {}): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return;
}

await this.authenticateWithWeb3({
...props,
strategy: 'web3_coinbase_wallet_signature',
});
};

public authenticateWithOKXWallet = async (props: AuthenticateWithOKXWalletParams = {}): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('OKX Wallet');
return;
}

await this.authenticateWithWeb3({
...props,
strategy: 'web3_okx_wallet_signature',
Expand All@@ -2030,11 +2015,6 @@ export class Clerk implements ClerkInterface {
legalAccepted,
secondFactorUrl,
}: ClerkAuthenticateWithWeb3Params): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Web3');
return;
}

if (!this.client || !this.environment) {
return;
}
Expand Down
21 changes: 0 additions & 21 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -61,7 +61,6 @@ import {
clerkInvalidStrategy,
clerkMissingOptionError,
clerkMissingWebAuthnPublicKeyOptions,
clerkUnsupportedEnvironmentWarning,
clerkVerifyEmailAddressCalledBeforeCreate,
clerkVerifyPasskeyCalledBeforeCreate,
clerkVerifyWeb3WalletCalledBeforeCreate,
Expand DownExpand Up@@ -274,11 +273,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithWeb3 = async (params: AuthenticateWithWeb3Params): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Web3');
return this;
}

const { identifier, generateSignature, strategy = 'web3_metamask_signature' } = params || {};
const provider = strategy.replace('web3_', '').replace('_signature', '') as Web3Provider;

Expand DownExpand Up@@ -325,11 +319,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithMetamask = async (): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Metamask');
return this;
}

const identifier = await getMetamaskIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -339,11 +328,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithCoinbaseWallet = async (): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return this;
}

const identifier = await getCoinbaseWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -353,11 +337,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithOKXWallet = async (): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('OKX Wallet');
return this;
}

const identifier = await getOKXWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand Down
21 changes: 0 additions & 21 deletions packages/clerk-js/src/core/resources/SignUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,6 @@ import { normalizeUnsafeMetadata } from '../../utils/resourceParams';
import {
clerkInvalidFAPIResponse,
clerkMissingOptionError,
clerkUnsupportedEnvironmentWarning,
clerkVerifyEmailAddressCalledBeforeCreate,
clerkVerifyWeb3WalletCalledBeforeCreate,
} from '../errors';
Expand DownExpand Up@@ -183,11 +182,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Web3');
return this;
}

const {
generateSignature,
identifier,
Expand DownExpand Up@@ -237,11 +231,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Metamask');
return this;
}

const identifier = await getMetamaskIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -257,11 +246,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return this;
}

const identifier = await getCoinbaseWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -277,11 +261,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('OKX Wallet');
return this;
}

const identifier = await getOKXWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand Down
7 changes: 7 additions & 0 deletions packages/clerk-js/src/utils/web3.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
import type { Web3Provider } from '@clerk/types';

import { clerkUnsupportedEnvironmentWarning } from '@/core/errors';

import { toHex } from './hex';
import { getInjectedWeb3Providers } from './injectedWeb3Providers';

Expand DownExpand Up@@ -75,6 +77,11 @@ export async function generateSignatureWithOKXWallet(params: GenerateSignaturePa

async function getEthereumProvider(provider: Web3Provider) {
if (provider === 'coinbase_wallet') {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return null;
}

const createCoinbaseWalletSDK = await import('@coinbase/wallet-sdk').then(mod => mod.createCoinbaseWalletSDK);
const sdk = createCoinbaseWalletSDK({
preference: {
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/twelve-ducks-refuse.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
---
'@clerk/chrome-extension': minor
---

- Explicitly mark `GoogleOneTap` and `SignInWithMetamaskButton` UI components as deprecated and unsupported (due to the requirement of Remotely Hosted Code) to help avoid confusion.

- Enable Metamask and OKXWallet Web3 for non-popup extensions.
5 changes: 3 additions & 2 deletions packages/chrome-extension/src/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
export * from '@clerk/clerk-react';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmilewski Is it better to simply control what's exported here instead of breaking without realising it ?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, though the plan was to deprecate, then remove in a major.


export type { StorageCache } from './internal/utils/storage';

// The order matters since we want override @clerk/clerk-react ClerkProvider
export { ClerkProvider } from './react';
// The order matters since we want override @clerk/clerk-react components
export { ClerkProvider, GoogleOneTap } from './react';

// Override Clerk React error thrower to show that errors come from @clerk/chrome-extension
import { setErrorThrowerOptions } from '@clerk/clerk-react/internal';
Expand Down
5 changes: 5 additions & 0 deletions packages/chrome-extension/src/react/NotSupported.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
/**
* @deprecated This component is not supported in Browser Extensions due to Chrome's security restrictions around remotely hosted code.
* @see https://clerk.com/docs/references/browser-extensions/browser-security-restrictions
*/
export const GoogleOneTap = () => null;
1 change: 1 addition & 0 deletions packages/chrome-extension/src/react/index.ts
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
export { ClerkProvider } from './ClerkProvider';
export { GoogleOneTap } from './NotSupported';
20 changes: 0 additions & 20 deletions packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1986,35 +1986,20 @@ export class Clerk implements ClerkInterface {
};

public authenticateWithMetamask = async (props: AuthenticateWithMetamaskParams = {}): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Metamask');
return;
}

await this.authenticateWithWeb3({
...props,
strategy: 'web3_metamask_signature',
});
};

public authenticateWithCoinbaseWallet = async (props: AuthenticateWithCoinbaseWalletParams = {}): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return;
}

await this.authenticateWithWeb3({
...props,
strategy: 'web3_coinbase_wallet_signature',
});
};

public authenticateWithOKXWallet = async (props: AuthenticateWithOKXWalletParams = {}): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('OKX Wallet');
return;
}

await this.authenticateWithWeb3({
...props,
strategy: 'web3_okx_wallet_signature',
Expand All@@ -2030,11 +2015,6 @@ export class Clerk implements ClerkInterface {
legalAccepted,
secondFactorUrl,
}: ClerkAuthenticateWithWeb3Params): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Web3');
return;
}

if (!this.client || !this.environment) {
return;
}
Expand Down
21 changes: 0 additions & 21 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -61,7 +61,6 @@ import {
clerkInvalidStrategy,
clerkMissingOptionError,
clerkMissingWebAuthnPublicKeyOptions,
clerkUnsupportedEnvironmentWarning,
clerkVerifyEmailAddressCalledBeforeCreate,
clerkVerifyPasskeyCalledBeforeCreate,
clerkVerifyWeb3WalletCalledBeforeCreate,
Expand DownExpand Up@@ -274,11 +273,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithWeb3 = async (params: AuthenticateWithWeb3Params): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Web3');
return this;
}

const { identifier, generateSignature, strategy = 'web3_metamask_signature' } = params || {};
const provider = strategy.replace('web3_', '').replace('_signature', '') as Web3Provider;

Expand DownExpand Up@@ -325,11 +319,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithMetamask = async (): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Metamask');
return this;
}

const identifier = await getMetamaskIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -339,11 +328,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithCoinbaseWallet = async (): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return this;
}

const identifier = await getCoinbaseWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -353,11 +337,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithOKXWallet = async (): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('OKX Wallet');
return this;
}

const identifier = await getOKXWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand Down
21 changes: 0 additions & 21 deletions packages/clerk-js/src/core/resources/SignUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,6 @@ import { normalizeUnsafeMetadata } from '../../utils/resourceParams';
import {
clerkInvalidFAPIResponse,
clerkMissingOptionError,
clerkUnsupportedEnvironmentWarning,
clerkVerifyEmailAddressCalledBeforeCreate,
clerkVerifyWeb3WalletCalledBeforeCreate,
} from '../errors';
Expand DownExpand Up@@ -183,11 +182,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Web3');
return this;
}

const {
generateSignature,
identifier,
Expand DownExpand Up@@ -237,11 +231,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Metamask');
return this;
}

const identifier = await getMetamaskIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -257,11 +246,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return this;
}

const identifier = await getCoinbaseWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -277,11 +261,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('OKX Wallet');
return this;
}

const identifier = await getOKXWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand Down
7 changes: 7 additions & 0 deletions packages/clerk-js/src/utils/web3.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
import type { Web3Provider } from '@clerk/types';

import { clerkUnsupportedEnvironmentWarning } from '@/core/errors';

import { toHex } from './hex';
import { getInjectedWeb3Providers } from './injectedWeb3Providers';

Expand DownExpand Up@@ -75,6 +77,11 @@ export async function generateSignatureWithOKXWallet(params: GenerateSignaturePa

async function getEthereumProvider(provider: Web3Provider) {
if (provider === 'coinbase_wallet') {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return null;
}

const createCoinbaseWalletSDK = await import('@coinbase/wallet-sdk').then(mod => mod.createCoinbaseWalletSDK);
const sdk = createCoinbaseWalletSDK({
preference: {
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/twelve-ducks-refuse.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
---
'@clerk/chrome-extension': minor
---

- Explicitly mark `GoogleOneTap` and `SignInWithMetamaskButton` UI components as deprecated and unsupported (due to the requirement of Remotely Hosted Code) to help avoid confusion.

- Enable Metamask and OKXWallet Web3 for non-popup extensions.
5 changes: 3 additions & 2 deletions packages/chrome-extension/src/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
export * from '@clerk/clerk-react';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmilewski Is it better to simply control what's exported here instead of breaking without realising it ?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, though the plan was to deprecate, then remove in a major.


export type { StorageCache } from './internal/utils/storage';

// The order matters since we want override @clerk/clerk-react ClerkProvider
export { ClerkProvider } from './react';
// The order matters since we want override @clerk/clerk-react components
export { ClerkProvider, GoogleOneTap } from './react';

// Override Clerk React error thrower to show that errors come from @clerk/chrome-extension
import { setErrorThrowerOptions } from '@clerk/clerk-react/internal';
Expand Down
5 changes: 5 additions & 0 deletions packages/chrome-extension/src/react/NotSupported.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
/**
* @deprecated This component is not supported in Browser Extensions due to Chrome's security restrictions around remotely hosted code.
* @see https://clerk.com/docs/references/browser-extensions/browser-security-restrictions
*/
export const GoogleOneTap = () => null;
1 change: 1 addition & 0 deletions packages/chrome-extension/src/react/index.ts
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
export { ClerkProvider } from './ClerkProvider';
export { GoogleOneTap } from './NotSupported';
20 changes: 0 additions & 20 deletions packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1986,35 +1986,20 @@ export class Clerk implements ClerkInterface {
};

public authenticateWithMetamask = async (props: AuthenticateWithMetamaskParams = {}): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Metamask');
return;
}

await this.authenticateWithWeb3({
...props,
strategy: 'web3_metamask_signature',
});
};

public authenticateWithCoinbaseWallet = async (props: AuthenticateWithCoinbaseWalletParams = {}): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return;
}

await this.authenticateWithWeb3({
...props,
strategy: 'web3_coinbase_wallet_signature',
});
};

public authenticateWithOKXWallet = async (props: AuthenticateWithOKXWalletParams = {}): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('OKX Wallet');
return;
}

await this.authenticateWithWeb3({
...props,
strategy: 'web3_okx_wallet_signature',
Expand All@@ -2030,11 +2015,6 @@ export class Clerk implements ClerkInterface {
legalAccepted,
secondFactorUrl,
}: ClerkAuthenticateWithWeb3Params): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Web3');
return;
}

if (!this.client || !this.environment) {
return;
}
Expand Down
21 changes: 0 additions & 21 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -61,7 +61,6 @@ import {
clerkInvalidStrategy,
clerkMissingOptionError,
clerkMissingWebAuthnPublicKeyOptions,
clerkUnsupportedEnvironmentWarning,
clerkVerifyEmailAddressCalledBeforeCreate,
clerkVerifyPasskeyCalledBeforeCreate,
clerkVerifyWeb3WalletCalledBeforeCreate,
Expand DownExpand Up@@ -274,11 +273,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithWeb3 = async (params: AuthenticateWithWeb3Params): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Web3');
return this;
}

const { identifier, generateSignature, strategy = 'web3_metamask_signature' } = params || {};
const provider = strategy.replace('web3_', '').replace('_signature', '') as Web3Provider;

Expand DownExpand Up@@ -325,11 +319,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithMetamask = async (): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Metamask');
return this;
}

const identifier = await getMetamaskIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -339,11 +328,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithCoinbaseWallet = async (): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return this;
}

const identifier = await getCoinbaseWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -353,11 +337,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithOKXWallet = async (): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('OKX Wallet');
return this;
}

const identifier = await getOKXWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand Down
21 changes: 0 additions & 21 deletions packages/clerk-js/src/core/resources/SignUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,6 @@ import { normalizeUnsafeMetadata } from '../../utils/resourceParams';
import {
clerkInvalidFAPIResponse,
clerkMissingOptionError,
clerkUnsupportedEnvironmentWarning,
clerkVerifyEmailAddressCalledBeforeCreate,
clerkVerifyWeb3WalletCalledBeforeCreate,
} from '../errors';
Expand DownExpand Up@@ -183,11 +182,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Web3');
return this;
}

const {
generateSignature,
identifier,
Expand DownExpand Up@@ -237,11 +231,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Metamask');
return this;
}

const identifier = await getMetamaskIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -257,11 +246,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return this;
}

const identifier = await getCoinbaseWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -277,11 +261,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('OKX Wallet');
return this;
}

const identifier = await getOKXWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand Down
7 changes: 7 additions & 0 deletions packages/clerk-js/src/utils/web3.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
import type { Web3Provider } from '@clerk/types';

import { clerkUnsupportedEnvironmentWarning } from '@/core/errors';

import { toHex } from './hex';
import { getInjectedWeb3Providers } from './injectedWeb3Providers';

Expand DownExpand Up@@ -75,6 +77,11 @@ export async function generateSignatureWithOKXWallet(params: GenerateSignaturePa

async function getEthereumProvider(provider: Web3Provider) {
if (provider === 'coinbase_wallet') {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return null;
}

const createCoinbaseWalletSDK = await import('@coinbase/wallet-sdk').then(mod => mod.createCoinbaseWalletSDK);
const sdk = createCoinbaseWalletSDK({
preference: {
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/twelve-ducks-refuse.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
---
'@clerk/chrome-extension': minor
---

- Explicitly mark `GoogleOneTap` and `SignInWithMetamaskButton` UI components as deprecated and unsupported (due to the requirement of Remotely Hosted Code) to help avoid confusion.

- Enable Metamask and OKXWallet Web3 for non-popup extensions.
5 changes: 3 additions & 2 deletions packages/chrome-extension/src/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
export * from '@clerk/clerk-react';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmilewski Is it better to simply control what's exported here instead of breaking without realising it ?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, though the plan was to deprecate, then remove in a major.


export type { StorageCache } from './internal/utils/storage';

// The order matters since we want override @clerk/clerk-react ClerkProvider
export { ClerkProvider } from './react';
// The order matters since we want override @clerk/clerk-react components
export { ClerkProvider, GoogleOneTap } from './react';

// Override Clerk React error thrower to show that errors come from @clerk/chrome-extension
import { setErrorThrowerOptions } from '@clerk/clerk-react/internal';
Expand Down
5 changes: 5 additions & 0 deletions packages/chrome-extension/src/react/NotSupported.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
/**
* @deprecated This component is not supported in Browser Extensions due to Chrome's security restrictions around remotely hosted code.
* @see https://clerk.com/docs/references/browser-extensions/browser-security-restrictions
*/
export const GoogleOneTap = () => null;
1 change: 1 addition & 0 deletions packages/chrome-extension/src/react/index.ts
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
export { ClerkProvider } from './ClerkProvider';
export { GoogleOneTap } from './NotSupported';
20 changes: 0 additions & 20 deletions packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1986,35 +1986,20 @@ export class Clerk implements ClerkInterface {
};

public authenticateWithMetamask = async (props: AuthenticateWithMetamaskParams = {}): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Metamask');
return;
}

await this.authenticateWithWeb3({
...props,
strategy: 'web3_metamask_signature',
});
};

public authenticateWithCoinbaseWallet = async (props: AuthenticateWithCoinbaseWalletParams = {}): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return;
}

await this.authenticateWithWeb3({
...props,
strategy: 'web3_coinbase_wallet_signature',
});
};

public authenticateWithOKXWallet = async (props: AuthenticateWithOKXWalletParams = {}): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('OKX Wallet');
return;
}

await this.authenticateWithWeb3({
...props,
strategy: 'web3_okx_wallet_signature',
Expand All@@ -2030,11 +2015,6 @@ export class Clerk implements ClerkInterface {
legalAccepted,
secondFactorUrl,
}: ClerkAuthenticateWithWeb3Params): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Web3');
return;
}

if (!this.client || !this.environment) {
return;
}
Expand Down
21 changes: 0 additions & 21 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -61,7 +61,6 @@ import {
clerkInvalidStrategy,
clerkMissingOptionError,
clerkMissingWebAuthnPublicKeyOptions,
clerkUnsupportedEnvironmentWarning,
clerkVerifyEmailAddressCalledBeforeCreate,
clerkVerifyPasskeyCalledBeforeCreate,
clerkVerifyWeb3WalletCalledBeforeCreate,
Expand DownExpand Up@@ -274,11 +273,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithWeb3 = async (params: AuthenticateWithWeb3Params): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Web3');
return this;
}

const { identifier, generateSignature, strategy = 'web3_metamask_signature' } = params || {};
const provider = strategy.replace('web3_', '').replace('_signature', '') as Web3Provider;

Expand DownExpand Up@@ -325,11 +319,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithMetamask = async (): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Metamask');
return this;
}

const identifier = await getMetamaskIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -339,11 +328,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithCoinbaseWallet = async (): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return this;
}

const identifier = await getCoinbaseWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -353,11 +337,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithOKXWallet = async (): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('OKX Wallet');
return this;
}

const identifier = await getOKXWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand Down
21 changes: 0 additions & 21 deletions packages/clerk-js/src/core/resources/SignUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,6 @@ import { normalizeUnsafeMetadata } from '../../utils/resourceParams';
import {
clerkInvalidFAPIResponse,
clerkMissingOptionError,
clerkUnsupportedEnvironmentWarning,
clerkVerifyEmailAddressCalledBeforeCreate,
clerkVerifyWeb3WalletCalledBeforeCreate,
} from '../errors';
Expand DownExpand Up@@ -183,11 +182,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Web3');
return this;
}

const {
generateSignature,
identifier,
Expand DownExpand Up@@ -237,11 +231,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Metamask');
return this;
}

const identifier = await getMetamaskIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -257,11 +246,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return this;
}

const identifier = await getCoinbaseWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -277,11 +261,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('OKX Wallet');
return this;
}

const identifier = await getOKXWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand Down
7 changes: 7 additions & 0 deletions packages/clerk-js/src/utils/web3.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
import type { Web3Provider } from '@clerk/types';

import { clerkUnsupportedEnvironmentWarning } from '@/core/errors';

import { toHex } from './hex';
import { getInjectedWeb3Providers } from './injectedWeb3Providers';

Expand DownExpand Up@@ -75,6 +77,11 @@ export async function generateSignatureWithOKXWallet(params: GenerateSignaturePa

async function getEthereumProvider(provider: Web3Provider) {
if (provider === 'coinbase_wallet') {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return null;
}

const createCoinbaseWalletSDK = await import('@coinbase/wallet-sdk').then(mod => mod.createCoinbaseWalletSDK);
const sdk = createCoinbaseWalletSDK({
preference: {
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/twelve-ducks-refuse.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
---
'@clerk/chrome-extension': minor
---

- Explicitly mark `GoogleOneTap` and `SignInWithMetamaskButton` UI components as deprecated and unsupported (due to the requirement of Remotely Hosted Code) to help avoid confusion.

- Enable Metamask and OKXWallet Web3 for non-popup extensions.
5 changes: 3 additions & 2 deletions packages/chrome-extension/src/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
export * from '@clerk/clerk-react';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmilewski Is it better to simply control what's exported here instead of breaking without realising it ?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, though the plan was to deprecate, then remove in a major.


export type { StorageCache } from './internal/utils/storage';

// The order matters since we want override @clerk/clerk-react ClerkProvider
export { ClerkProvider } from './react';
// The order matters since we want override @clerk/clerk-react components
export { ClerkProvider, GoogleOneTap } from './react';

// Override Clerk React error thrower to show that errors come from @clerk/chrome-extension
import { setErrorThrowerOptions } from '@clerk/clerk-react/internal';
Expand Down
5 changes: 5 additions & 0 deletions packages/chrome-extension/src/react/NotSupported.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
/**
* @deprecated This component is not supported in Browser Extensions due to Chrome's security restrictions around remotely hosted code.
* @see https://clerk.com/docs/references/browser-extensions/browser-security-restrictions
*/
export const GoogleOneTap = () => null;
1 change: 1 addition & 0 deletions packages/chrome-extension/src/react/index.ts
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
export { ClerkProvider } from './ClerkProvider';
export { GoogleOneTap } from './NotSupported';
20 changes: 0 additions & 20 deletions packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1986,35 +1986,20 @@ export class Clerk implements ClerkInterface {
};

public authenticateWithMetamask = async (props: AuthenticateWithMetamaskParams = {}): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Metamask');
return;
}

await this.authenticateWithWeb3({
...props,
strategy: 'web3_metamask_signature',
});
};

public authenticateWithCoinbaseWallet = async (props: AuthenticateWithCoinbaseWalletParams = {}): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return;
}

await this.authenticateWithWeb3({
...props,
strategy: 'web3_coinbase_wallet_signature',
});
};

public authenticateWithOKXWallet = async (props: AuthenticateWithOKXWalletParams = {}): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('OKX Wallet');
return;
}

await this.authenticateWithWeb3({
...props,
strategy: 'web3_okx_wallet_signature',
Expand All@@ -2030,11 +2015,6 @@ export class Clerk implements ClerkInterface {
legalAccepted,
secondFactorUrl,
}: ClerkAuthenticateWithWeb3Params): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Web3');
return;
}

if (!this.client || !this.environment) {
return;
}
Expand Down
21 changes: 0 additions & 21 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -61,7 +61,6 @@ import {
clerkInvalidStrategy,
clerkMissingOptionError,
clerkMissingWebAuthnPublicKeyOptions,
clerkUnsupportedEnvironmentWarning,
clerkVerifyEmailAddressCalledBeforeCreate,
clerkVerifyPasskeyCalledBeforeCreate,
clerkVerifyWeb3WalletCalledBeforeCreate,
Expand DownExpand Up@@ -274,11 +273,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithWeb3 = async (params: AuthenticateWithWeb3Params): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Web3');
return this;
}

const { identifier, generateSignature, strategy = 'web3_metamask_signature' } = params || {};
const provider = strategy.replace('web3_', '').replace('_signature', '') as Web3Provider;

Expand DownExpand Up@@ -325,11 +319,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithMetamask = async (): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Metamask');
return this;
}

const identifier = await getMetamaskIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -339,11 +328,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithCoinbaseWallet = async (): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return this;
}

const identifier = await getCoinbaseWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -353,11 +337,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithOKXWallet = async (): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('OKX Wallet');
return this;
}

const identifier = await getOKXWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand Down
21 changes: 0 additions & 21 deletions packages/clerk-js/src/core/resources/SignUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,6 @@ import { normalizeUnsafeMetadata } from '../../utils/resourceParams';
import {
clerkInvalidFAPIResponse,
clerkMissingOptionError,
clerkUnsupportedEnvironmentWarning,
clerkVerifyEmailAddressCalledBeforeCreate,
clerkVerifyWeb3WalletCalledBeforeCreate,
} from '../errors';
Expand DownExpand Up@@ -183,11 +182,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Web3');
return this;
}

const {
generateSignature,
identifier,
Expand DownExpand Up@@ -237,11 +231,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Metamask');
return this;
}

const identifier = await getMetamaskIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -257,11 +246,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return this;
}

const identifier = await getCoinbaseWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -277,11 +261,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('OKX Wallet');
return this;
}

const identifier = await getOKXWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand Down
7 changes: 7 additions & 0 deletions packages/clerk-js/src/utils/web3.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
import type { Web3Provider } from '@clerk/types';

import { clerkUnsupportedEnvironmentWarning } from '@/core/errors';

import { toHex } from './hex';
import { getInjectedWeb3Providers } from './injectedWeb3Providers';

Expand DownExpand Up@@ -75,6 +77,11 @@ export async function generateSignatureWithOKXWallet(params: GenerateSignaturePa

async function getEthereumProvider(provider: Web3Provider) {
if (provider === 'coinbase_wallet') {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return null;
}

const createCoinbaseWalletSDK = await import('@coinbase/wallet-sdk').then(mod => mod.createCoinbaseWalletSDK);
const sdk = createCoinbaseWalletSDK({
preference: {
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/twelve-ducks-refuse.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
---
'@clerk/chrome-extension': minor
---

- Explicitly mark `GoogleOneTap` and `SignInWithMetamaskButton` UI components as deprecated and unsupported (due to the requirement of Remotely Hosted Code) to help avoid confusion.

- Enable Metamask and OKXWallet Web3 for non-popup extensions.
5 changes: 3 additions & 2 deletions packages/chrome-extension/src/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
export * from '@clerk/clerk-react';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmilewski Is it better to simply control what's exported here instead of breaking without realising it ?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, though the plan was to deprecate, then remove in a major.


export type { StorageCache } from './internal/utils/storage';

// The order matters since we want override @clerk/clerk-react ClerkProvider
export { ClerkProvider } from './react';
// The order matters since we want override @clerk/clerk-react components
export { ClerkProvider, GoogleOneTap } from './react';

// Override Clerk React error thrower to show that errors come from @clerk/chrome-extension
import { setErrorThrowerOptions } from '@clerk/clerk-react/internal';
Expand Down
5 changes: 5 additions & 0 deletions packages/chrome-extension/src/react/NotSupported.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
/**
* @deprecated This component is not supported in Browser Extensions due to Chrome's security restrictions around remotely hosted code.
* @see https://clerk.com/docs/references/browser-extensions/browser-security-restrictions
*/
export const GoogleOneTap = () => null;
1 change: 1 addition & 0 deletions packages/chrome-extension/src/react/index.ts
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
export { ClerkProvider } from './ClerkProvider';
export { GoogleOneTap } from './NotSupported';
20 changes: 0 additions & 20 deletions packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1986,35 +1986,20 @@ export class Clerk implements ClerkInterface {
};

public authenticateWithMetamask = async (props: AuthenticateWithMetamaskParams = {}): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Metamask');
return;
}

await this.authenticateWithWeb3({
...props,
strategy: 'web3_metamask_signature',
});
};

public authenticateWithCoinbaseWallet = async (props: AuthenticateWithCoinbaseWalletParams = {}): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return;
}

await this.authenticateWithWeb3({
...props,
strategy: 'web3_coinbase_wallet_signature',
});
};

public authenticateWithOKXWallet = async (props: AuthenticateWithOKXWalletParams = {}): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('OKX Wallet');
return;
}

await this.authenticateWithWeb3({
...props,
strategy: 'web3_okx_wallet_signature',
Expand All@@ -2030,11 +2015,6 @@ export class Clerk implements ClerkInterface {
legalAccepted,
secondFactorUrl,
}: ClerkAuthenticateWithWeb3Params): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Web3');
return;
}

if (!this.client || !this.environment) {
return;
}
Expand Down
21 changes: 0 additions & 21 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -61,7 +61,6 @@ import {
clerkInvalidStrategy,
clerkMissingOptionError,
clerkMissingWebAuthnPublicKeyOptions,
clerkUnsupportedEnvironmentWarning,
clerkVerifyEmailAddressCalledBeforeCreate,
clerkVerifyPasskeyCalledBeforeCreate,
clerkVerifyWeb3WalletCalledBeforeCreate,
Expand DownExpand Up@@ -274,11 +273,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithWeb3 = async (params: AuthenticateWithWeb3Params): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Web3');
return this;
}

const { identifier, generateSignature, strategy = 'web3_metamask_signature' } = params || {};
const provider = strategy.replace('web3_', '').replace('_signature', '') as Web3Provider;

Expand DownExpand Up@@ -325,11 +319,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithMetamask = async (): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Metamask');
return this;
}

const identifier = await getMetamaskIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -339,11 +328,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithCoinbaseWallet = async (): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return this;
}

const identifier = await getCoinbaseWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -353,11 +337,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithOKXWallet = async (): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('OKX Wallet');
return this;
}

const identifier = await getOKXWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand Down
21 changes: 0 additions & 21 deletions packages/clerk-js/src/core/resources/SignUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,6 @@ import { normalizeUnsafeMetadata } from '../../utils/resourceParams';
import {
clerkInvalidFAPIResponse,
clerkMissingOptionError,
clerkUnsupportedEnvironmentWarning,
clerkVerifyEmailAddressCalledBeforeCreate,
clerkVerifyWeb3WalletCalledBeforeCreate,
} from '../errors';
Expand DownExpand Up@@ -183,11 +182,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Web3');
return this;
}

const {
generateSignature,
identifier,
Expand DownExpand Up@@ -237,11 +231,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Metamask');
return this;
}

const identifier = await getMetamaskIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -257,11 +246,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return this;
}

const identifier = await getCoinbaseWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -277,11 +261,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('OKX Wallet');
return this;
}

const identifier = await getOKXWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand Down
7 changes: 7 additions & 0 deletions packages/clerk-js/src/utils/web3.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
import type { Web3Provider } from '@clerk/types';

import { clerkUnsupportedEnvironmentWarning } from '@/core/errors';

import { toHex } from './hex';
import { getInjectedWeb3Providers } from './injectedWeb3Providers';

Expand DownExpand Up@@ -75,6 +77,11 @@ export async function generateSignatureWithOKXWallet(params: GenerateSignaturePa

async function getEthereumProvider(provider: Web3Provider) {
if (provider === 'coinbase_wallet') {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return null;
}

const createCoinbaseWalletSDK = await import('@coinbase/wallet-sdk').then(mod => mod.createCoinbaseWalletSDK);
const sdk = createCoinbaseWalletSDK({
preference: {
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/twelve-ducks-refuse.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
---
'@clerk/chrome-extension': minor
---

- Explicitly mark `GoogleOneTap` and `SignInWithMetamaskButton` UI components as deprecated and unsupported (due to the requirement of Remotely Hosted Code) to help avoid confusion.

- Enable Metamask and OKXWallet Web3 for non-popup extensions.
5 changes: 3 additions & 2 deletions packages/chrome-extension/src/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
export * from '@clerk/clerk-react';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmilewski Is it better to simply control what's exported here instead of breaking without realising it ?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, though the plan was to deprecate, then remove in a major.


export type { StorageCache } from './internal/utils/storage';

// The order matters since we want override @clerk/clerk-react ClerkProvider
export { ClerkProvider } from './react';
// The order matters since we want override @clerk/clerk-react components
export { ClerkProvider, GoogleOneTap } from './react';

// Override Clerk React error thrower to show that errors come from @clerk/chrome-extension
import { setErrorThrowerOptions } from '@clerk/clerk-react/internal';
Expand Down
5 changes: 5 additions & 0 deletions packages/chrome-extension/src/react/NotSupported.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
/**
* @deprecated This component is not supported in Browser Extensions due to Chrome's security restrictions around remotely hosted code.
* @see https://clerk.com/docs/references/browser-extensions/browser-security-restrictions
*/
export const GoogleOneTap = () => null;
1 change: 1 addition & 0 deletions packages/chrome-extension/src/react/index.ts
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
export { ClerkProvider } from './ClerkProvider';
export { GoogleOneTap } from './NotSupported';
20 changes: 0 additions & 20 deletions packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1986,35 +1986,20 @@ export class Clerk implements ClerkInterface {
};

public authenticateWithMetamask = async (props: AuthenticateWithMetamaskParams = {}): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Metamask');
return;
}

await this.authenticateWithWeb3({
...props,
strategy: 'web3_metamask_signature',
});
};

public authenticateWithCoinbaseWallet = async (props: AuthenticateWithCoinbaseWalletParams = {}): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return;
}

await this.authenticateWithWeb3({
...props,
strategy: 'web3_coinbase_wallet_signature',
});
};

public authenticateWithOKXWallet = async (props: AuthenticateWithOKXWalletParams = {}): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('OKX Wallet');
return;
}

await this.authenticateWithWeb3({
...props,
strategy: 'web3_okx_wallet_signature',
Expand All@@ -2030,11 +2015,6 @@ export class Clerk implements ClerkInterface {
legalAccepted,
secondFactorUrl,
}: ClerkAuthenticateWithWeb3Params): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Web3');
return;
}

if (!this.client || !this.environment) {
return;
}
Expand Down
21 changes: 0 additions & 21 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -61,7 +61,6 @@ import {
clerkInvalidStrategy,
clerkMissingOptionError,
clerkMissingWebAuthnPublicKeyOptions,
clerkUnsupportedEnvironmentWarning,
clerkVerifyEmailAddressCalledBeforeCreate,
clerkVerifyPasskeyCalledBeforeCreate,
clerkVerifyWeb3WalletCalledBeforeCreate,
Expand DownExpand Up@@ -274,11 +273,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithWeb3 = async (params: AuthenticateWithWeb3Params): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Web3');
return this;
}

const { identifier, generateSignature, strategy = 'web3_metamask_signature' } = params || {};
const provider = strategy.replace('web3_', '').replace('_signature', '') as Web3Provider;

Expand DownExpand Up@@ -325,11 +319,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithMetamask = async (): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Metamask');
return this;
}

const identifier = await getMetamaskIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -339,11 +328,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithCoinbaseWallet = async (): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return this;
}

const identifier = await getCoinbaseWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -353,11 +337,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithOKXWallet = async (): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('OKX Wallet');
return this;
}

const identifier = await getOKXWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand Down
21 changes: 0 additions & 21 deletions packages/clerk-js/src/core/resources/SignUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,6 @@ import { normalizeUnsafeMetadata } from '../../utils/resourceParams';
import {
clerkInvalidFAPIResponse,
clerkMissingOptionError,
clerkUnsupportedEnvironmentWarning,
clerkVerifyEmailAddressCalledBeforeCreate,
clerkVerifyWeb3WalletCalledBeforeCreate,
} from '../errors';
Expand DownExpand Up@@ -183,11 +182,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Web3');
return this;
}

const {
generateSignature,
identifier,
Expand DownExpand Up@@ -237,11 +231,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Metamask');
return this;
}

const identifier = await getMetamaskIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -257,11 +246,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return this;
}

const identifier = await getCoinbaseWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -277,11 +261,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('OKX Wallet');
return this;
}

const identifier = await getOKXWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand Down
7 changes: 7 additions & 0 deletions packages/clerk-js/src/utils/web3.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
import type { Web3Provider } from '@clerk/types';

import { clerkUnsupportedEnvironmentWarning } from '@/core/errors';

import { toHex } from './hex';
import { getInjectedWeb3Providers } from './injectedWeb3Providers';

Expand DownExpand Up@@ -75,6 +77,11 @@ export async function generateSignatureWithOKXWallet(params: GenerateSignaturePa

async function getEthereumProvider(provider: Web3Provider) {
if (provider === 'coinbase_wallet') {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return null;
}

const createCoinbaseWalletSDK = await import('@coinbase/wallet-sdk').then(mod => mod.createCoinbaseWalletSDK);
const sdk = createCoinbaseWalletSDK({
preference: {
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/twelve-ducks-refuse.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
---
'@clerk/chrome-extension': minor
---

- Explicitly mark `GoogleOneTap` and `SignInWithMetamaskButton` UI components as deprecated and unsupported (due to the requirement of Remotely Hosted Code) to help avoid confusion.

- Enable Metamask and OKXWallet Web3 for non-popup extensions.
5 changes: 3 additions & 2 deletions packages/chrome-extension/src/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
export * from '@clerk/clerk-react';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmilewski Is it better to simply control what's exported here instead of breaking without realising it ?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, though the plan was to deprecate, then remove in a major.


export type { StorageCache } from './internal/utils/storage';

// The order matters since we want override @clerk/clerk-react ClerkProvider
export { ClerkProvider } from './react';
// The order matters since we want override @clerk/clerk-react components
export { ClerkProvider, GoogleOneTap } from './react';

// Override Clerk React error thrower to show that errors come from @clerk/chrome-extension
import { setErrorThrowerOptions } from '@clerk/clerk-react/internal';
Expand Down
5 changes: 5 additions & 0 deletions packages/chrome-extension/src/react/NotSupported.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
/**
* @deprecated This component is not supported in Browser Extensions due to Chrome's security restrictions around remotely hosted code.
* @see https://clerk.com/docs/references/browser-extensions/browser-security-restrictions
*/
export const GoogleOneTap = () => null;
1 change: 1 addition & 0 deletions packages/chrome-extension/src/react/index.ts
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
export { ClerkProvider } from './ClerkProvider';
export { GoogleOneTap } from './NotSupported';
20 changes: 0 additions & 20 deletions packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1986,35 +1986,20 @@ export class Clerk implements ClerkInterface {
};

public authenticateWithMetamask = async (props: AuthenticateWithMetamaskParams = {}): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Metamask');
return;
}

await this.authenticateWithWeb3({
...props,
strategy: 'web3_metamask_signature',
});
};

public authenticateWithCoinbaseWallet = async (props: AuthenticateWithCoinbaseWalletParams = {}): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return;
}

await this.authenticateWithWeb3({
...props,
strategy: 'web3_coinbase_wallet_signature',
});
};

public authenticateWithOKXWallet = async (props: AuthenticateWithOKXWalletParams = {}): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('OKX Wallet');
return;
}

await this.authenticateWithWeb3({
...props,
strategy: 'web3_okx_wallet_signature',
Expand All@@ -2030,11 +2015,6 @@ export class Clerk implements ClerkInterface {
legalAccepted,
secondFactorUrl,
}: ClerkAuthenticateWithWeb3Params): Promise<void> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Web3');
return;
}

if (!this.client || !this.environment) {
return;
}
Expand Down
21 changes: 0 additions & 21 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -61,7 +61,6 @@ import {
clerkInvalidStrategy,
clerkMissingOptionError,
clerkMissingWebAuthnPublicKeyOptions,
clerkUnsupportedEnvironmentWarning,
clerkVerifyEmailAddressCalledBeforeCreate,
clerkVerifyPasskeyCalledBeforeCreate,
clerkVerifyWeb3WalletCalledBeforeCreate,
Expand DownExpand Up@@ -274,11 +273,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithWeb3 = async (params: AuthenticateWithWeb3Params): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Web3');
return this;
}

const { identifier, generateSignature, strategy = 'web3_metamask_signature' } = params || {};
const provider = strategy.replace('web3_', '').replace('_signature', '') as Web3Provider;

Expand DownExpand Up@@ -325,11 +319,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithMetamask = async (): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Metamask');
return this;
}

const identifier = await getMetamaskIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -339,11 +328,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithCoinbaseWallet = async (): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return this;
}

const identifier = await getCoinbaseWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -353,11 +337,6 @@ export class SignIn extends BaseResource implements SignInResource {
};

public authenticateWithOKXWallet = async (): Promise<SignInResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('OKX Wallet');
return this;
}

const identifier = await getOKXWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand Down
21 changes: 0 additions & 21 deletions packages/clerk-js/src/core/resources/SignUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,6 @@ import { normalizeUnsafeMetadata } from '../../utils/resourceParams';
import {
clerkInvalidFAPIResponse,
clerkMissingOptionError,
clerkUnsupportedEnvironmentWarning,
clerkVerifyEmailAddressCalledBeforeCreate,
clerkVerifyWeb3WalletCalledBeforeCreate,
} from '../errors';
Expand DownExpand Up@@ -183,11 +182,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Web3');
return this;
}

const {
generateSignature,
identifier,
Expand DownExpand Up@@ -237,11 +231,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Metamask');
return this;
}

const identifier = await getMetamaskIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -257,11 +246,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return this;
}

const identifier = await getCoinbaseWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand All@@ -277,11 +261,6 @@ export class SignUp extends BaseResource implements SignUpResource {
legalAccepted?: boolean;
},
): Promise<SignUpResource> => {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('OKX Wallet');
return this;
}

const identifier = await getOKXWalletIdentifier();
return this.authenticateWithWeb3({
identifier,
Expand Down
7 changes: 7 additions & 0 deletions packages/clerk-js/src/utils/web3.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
import type { Web3Provider } from '@clerk/types';

import { clerkUnsupportedEnvironmentWarning } from '@/core/errors';

import { toHex } from './hex';
import { getInjectedWeb3Providers } from './injectedWeb3Providers';

Expand DownExpand Up@@ -75,6 +77,11 @@ export async function generateSignatureWithOKXWallet(params: GenerateSignaturePa

async function getEthereumProvider(provider: Web3Provider) {
if (provider === 'coinbase_wallet') {
if (__BUILD_DISABLE_RHC__) {
clerkUnsupportedEnvironmentWarning('Coinbase Wallet');
return null;
}

const createCoinbaseWalletSDK = await import('@coinbase/wallet-sdk').then(mod => mod.createCoinbaseWalletSDK);
const sdk = createCoinbaseWalletSDK({
preference: {
Expand Down