feat(clerk-js): Enhanced password manager detection#6311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmilewski merged 3 commits into from
Jul 15, 2025
Merged

feat(clerk-js): Enhanced password manager detection #6311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a9fbe3c
feat: Enhanced password manager detection
tmilewski Jul 14, 2025
2d42753
chore: Add changeset
tmilewski Jul 14, 2025
e467c10
fix: tests
tmilewski Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/twenty-camels-drum.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Enhanced detection of password manangers
62 changes: 56 additions & 6 deletions packages/clerk-js/src/ui/elements/CodeControl.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -196,6 +196,19 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
}
}, [values]);

// Focus management for password managers
React.useEffect(() => {
const handleFocus = () => {
// If focus is on the hidden input, redirect to first visible input
if (document.activeElement === hiddenInputRef.current) {
setTimeout(() => focusInputAt(0), 0);
}
};

document.addEventListener('focusin', handleFocus);
return () => document.removeEventListener('focusin', handleFocus);
}, []);

const handleMultipleCharValue = ({ eventValue, inputPosition }: { eventValue: string; inputPosition: number }) => {
const eventValues = (eventValue || '').split('');

Expand DownExpand Up@@ -311,26 +324,62 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
ref={hiddenInputRef}
type='text'
autoComplete='one-time-code'
data-otp-hidden-input
inputMode='numeric'
pattern={`[0-9]{${length}}`}
minLength={length}
maxLength={length}
spellCheck={false}
aria-hidden='true'
name='otp'
id='otp-input'
data-otp-input
data-otp-hidden-input
data-testid='otp-input'
Comment thread
tmilewski marked this conversation as resolved.
role='textbox'
aria-label='One-time password input for password managers'
aria-describedby='otp-instructions'
aria-hidden
tabIndex={-1}
onChange={handleHiddenInputChange}
onFocus={() => {
// When password manager focuses the hidden input, focus the first visible input
focusInputAt(0);
}}
sx={() => ({
...common.visuallyHidden(),
left: '-9999px',
// NOTE: Do not use the visuallyHidden() utility here, as it will break password manager autofill
position: 'absolute',
opacity: 0,
width: '1px',
height: '1px',
overflow: 'hidden',
clip: 'rect(0, 0, 0, 0)',
clipPath: 'inset(50%)',
whiteSpace: 'nowrap',
// Ensure the input is still accessible to password managers
// by not using display: none or visibility: hidden
pointerEvents: 'none',
// Position slightly within the container for better detection
top: 0,
left: 0,
})}
/>

{/* Hidden instructions for screen readers and password managers */}
<span
id='otp-instructions'
style={{
position: 'absolute',
width: '1px',
height: '1px',
padding: 0,
margin: '-1px',
overflow: 'hidden',
clip: 'rect(0, 0, 0, 0)',
border: 0,
}}
>
Enter the {length}-digit verification code
</span>

<Flex
isLoading={isLoading}
hasError={feedbackType === 'error'}
Expand All@@ -339,6 +388,7 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
sx={t => ({ direction: 'ltr', padding: t.space.$1, marginLeft: `calc(${t.space.$1} * -1)`, ...centerSx })}
role='group'
aria-label='Verification code input'
aria-describedby='otp-instructions'
>
{values.map((value: string, index: number) => (
<SingleCharInput
Expand All@@ -363,8 +413,8 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
type='text'
inputMode='numeric'
name={`codeInput-${index}`}
data-otp-segment
data-1p-ignore
data-otp-segment='true'
data-1p-ignore='true'
data-lpignore='true'
maxLength={1}
pattern='[0-9]'
Expand Down
74 changes: 70 additions & 4 deletions packages/clerk-js/src/ui/elements/__tests__/CodeControl.spec.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -328,19 +328,85 @@ describe('CodeControl', () => {

// Simulate autofill with mixed characters
if (hiddenInput) {
fireEvent.change(hiddenInput, { target: { value: '1a2b3c4d5e6f' } });
fireEvent.change(hiddenInput, { target: { value: '1a2b3c' } });
}

await waitFor(() => {
expect(visibleInputs[0]).toHaveValue('1');
expect(visibleInputs[1]).toHaveValue('2');
expect(visibleInputs[2]).toHaveValue('3');
expect(visibleInputs[3]).toHaveValue('4');
expect(visibleInputs[4]).toHaveValue('5');
expect(visibleInputs[5]).toHaveValue('6');
expect(visibleInputs[3]).toHaveValue('');
expect(visibleInputs[4]).toHaveValue('');
expect(visibleInputs[5]).toHaveValue('');
});
});

it('has proper password manager attributes for detection', async () => {
const { wrapper } = await createFixtures();
const onCodeEntryFinished = vi.fn();
const Component = createOTPComponent(onCodeEntryFinished);

const { container } = render(<Component />, { wrapper });

const hiddenInput = container.querySelector('[data-otp-hidden-input]');

// Verify critical attributes for detection
expect(hiddenInput).toHaveAttribute('autocomplete', 'one-time-code');
expect(hiddenInput).toHaveAttribute('inputmode', 'numeric');
expect(hiddenInput).toHaveAttribute('pattern', '[0-9]{6}');
expect(hiddenInput).toHaveAttribute('minlength', '6');
expect(hiddenInput).toHaveAttribute('maxlength', '6');
expect(hiddenInput).toHaveAttribute('name', 'otp');
expect(hiddenInput).toHaveAttribute('id', 'otp-input');
expect(hiddenInput).toHaveAttribute('data-otp-input');
Comment thread
tmilewski marked this conversation as resolved.
expect(hiddenInput).toHaveAttribute('role', 'textbox');
expect(hiddenInput).toHaveAttribute('aria-label', 'One-time password input for password managers');
expect(hiddenInput).toHaveAttribute('aria-hidden', 'true');
expect(hiddenInput).toHaveAttribute('data-testid', 'otp-input');
});

it('handles focus redirection from hidden input to visible inputs', async () => {
const { wrapper } = await createFixtures();
const onCodeEntryFinished = vi.fn();
const Component = createOTPComponent(onCodeEntryFinished);

const { container } = render(<Component />, { wrapper });

const hiddenInput = container.querySelector('[data-otp-hidden-input]') as HTMLInputElement;
const visibleInputs = container.querySelectorAll('[data-otp-segment]');

// Focus the hidden input (simulating password manager behavior)
hiddenInput.focus();

await waitFor(() => {
// Should redirect focus to first visible input
expect(visibleInputs[0]).toHaveFocus();
});
});

it('maintains accessibility with proper ARIA attributes', async () => {
const { wrapper } = await createFixtures();
const onCodeEntryFinished = vi.fn();
const Component = createOTPComponent(onCodeEntryFinished);

const { container } = render(<Component />, { wrapper });

const hiddenInput = container.querySelector('[data-otp-hidden-input]');
const inputContainer = container.querySelector('[role="group"]');
const instructions = container.querySelector('#otp-instructions');

// Verify ARIA setup - some attributes might be filtered by the Input component
expect(hiddenInput).toHaveAttribute('aria-hidden', 'true');
expect(inputContainer).toHaveAttribute('aria-describedby', 'otp-instructions');
expect(instructions).toHaveTextContent('Enter the 6-digit verification code');

// Check for any aria-describedby attribute (it might be there but not exactly as expected)
const ariaDescribedBy = hiddenInput?.getAttribute('aria-describedby');
if (ariaDescribedBy) {
expect(ariaDescribedBy).toBe('otp-instructions');
}
});

it('focuses first visible input when hidden input is focused', async () => {
const { wrapper } = await createFixtures();
const onCodeEntryFinished = vi.fn();
Expand Down
7 changes: 7 additions & 0 deletions packages/elements/src/react/common/form/hooks/use-input.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -183,6 +183,13 @@ export function useInput({
pattern: `[0-9]{${length}}`,
minLength: length,
maxLength: length,
// Enhanced naming for better password manager detection
name: 'otp',
id: 'otp-input',
// Additional attributes for password manager compatibility
'data-testid': 'otp-input',
role: 'textbox',
'aria-label': 'Enter verification code',
onChange: (event: React.ChangeEvent<HTMLInputElement>) => {
// Only accept numbers
event.currentTarget.value = event.currentTarget.value.replace(/\D+/g, '');
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat(clerk-js): Enhanced password manager detection#6311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tmilewski
merged 3 commits into

from

Jul 15, 2025
 Merged


feat(clerk-js): Enhanced password manager detection
#6311
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
a9fbe3c

feat: Enhanced password manager detection


tmilewski Jul 14, 2025
2d42753

chore: Add changeset


tmilewski Jul 14, 2025
e467c10

fix: tests


tmilewski Jul 14, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/twenty-camels-drum.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Enhanced detection of password manangers

62 changes: 56 additions & 6 deletions
packages/clerk-js/src/ui/elements/CodeControl.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -196,6 +196,19 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
 }
 }, [values]);

 // Focus management for password managers
 React.useEffect(() => {
 const handleFocus = () => {
 // If focus is on the hidden input, redirect to first visible input
 if (document.activeElement === hiddenInputRef.current) {
 setTimeout(() => focusInputAt(0), 0);
 }
 };

 document.addEventListener('focusin', handleFocus);
 return () => document.removeEventListener('focusin', handleFocus);
 }, []);

 const handleMultipleCharValue = ({ eventValue, inputPosition }: { eventValue: string; inputPosition: number }) => {
 const eventValues = (eventValue || '').split('');

Expand DownExpand Up@@ -311,26 +324,62 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
 ref={hiddenInputRef}
 type='text'
 autoComplete='one-time-code'
 data-otp-hidden-input
 inputMode='numeric'
 pattern={`[0-9]{${length}}`}
 minLength={length}
 maxLength={length}
 spellCheck={false}
 aria-hidden='true'
 name='otp'
 id='otp-input'
 data-otp-input
 data-otp-hidden-input
 data-testid='otp-input'
Comment thread
tmilewski marked this conversation as resolved.

 role='textbox'
 aria-label='One-time password input for password managers'
 aria-describedby='otp-instructions'
 aria-hidden
 tabIndex={-1}
 onChange={handleHiddenInputChange}
 onFocus={() => {
 // When password manager focuses the hidden input, focus the first visible input
 focusInputAt(0);
 }}
 sx={() => ({
 ...common.visuallyHidden(),
 left: '-9999px',
 // NOTE: Do not use the visuallyHidden() utility here, as it will break password manager autofill
 position: 'absolute',
 opacity: 0,
 width: '1px',
 height: '1px',
 overflow: 'hidden',
 clip: 'rect(0, 0, 0, 0)',
 clipPath: 'inset(50%)',
 whiteSpace: 'nowrap',
 // Ensure the input is still accessible to password managers
 // by not using display: none or visibility: hidden
 pointerEvents: 'none',
 // Position slightly within the container for better detection
 top: 0,
 left: 0,
 })}
 />

 {/* Hidden instructions for screen readers and password managers */}
 <span
 id='otp-instructions'
 style={{
 position: 'absolute',
 width: '1px',
 height: '1px',
 padding: 0,
 margin: '-1px',
 overflow: 'hidden',
 clip: 'rect(0, 0, 0, 0)',
 border: 0,
 }}
 >
 Enter the {length}-digit verification code
 </span>

 <Flex
 isLoading={isLoading}
 hasError={feedbackType === 'error'}
Expand All@@ -339,6 +388,7 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
 sx={t => ({ direction: 'ltr', padding: t.space.$1, marginLeft: `calc(${t.space.$1} * -1)`, ...centerSx })}
 role='group'
 aria-label='Verification code input'
 aria-describedby='otp-instructions'
 >
 {values.map((value: string, index: number) => (
 <SingleCharInput
Expand All@@ -363,8 +413,8 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
 type='text'
 inputMode='numeric'
 name={`codeInput-${index}`}
 data-otp-segment
 data-1p-ignore
 data-otp-segment='true'
 data-1p-ignore='true'
 data-lpignore='true'
 maxLength={1}
 pattern='[0-9]'
Expand Down

74 changes: 70 additions & 4 deletions
packages/clerk-js/src/ui/elements/__tests__/CodeControl.spec.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -328,19 +328,85 @@ describe('CodeControl', () => {

 // Simulate autofill with mixed characters
 if (hiddenInput) {
 fireEvent.change(hiddenInput, { target: { value: '1a2b3c4d5e6f' } });
 fireEvent.change(hiddenInput, { target: { value: '1a2b3c' } });
 }

 await waitFor(() => {
 expect(visibleInputs[0]).toHaveValue('1');
 expect(visibleInputs[1]).toHaveValue('2');
 expect(visibleInputs[2]).toHaveValue('3');
 expect(visibleInputs[3]).toHaveValue('4');
 expect(visibleInputs[4]).toHaveValue('5');
 expect(visibleInputs[5]).toHaveValue('6');
 expect(visibleInputs[3]).toHaveValue('');
 expect(visibleInputs[4]).toHaveValue('');
 expect(visibleInputs[5]).toHaveValue('');
 });
 });

 it('has proper password manager attributes for detection', async () => {
 const { wrapper } = await createFixtures();
 const onCodeEntryFinished = vi.fn();
 const Component = createOTPComponent(onCodeEntryFinished);

 const { container } = render(<Component />, { wrapper });

 const hiddenInput = container.querySelector('[data-otp-hidden-input]');

 // Verify critical attributes for detection
 expect(hiddenInput).toHaveAttribute('autocomplete', 'one-time-code');
 expect(hiddenInput).toHaveAttribute('inputmode', 'numeric');
 expect(hiddenInput).toHaveAttribute('pattern', '[0-9]{6}');
 expect(hiddenInput).toHaveAttribute('minlength', '6');
 expect(hiddenInput).toHaveAttribute('maxlength', '6');
 expect(hiddenInput).toHaveAttribute('name', 'otp');
 expect(hiddenInput).toHaveAttribute('id', 'otp-input');
 expect(hiddenInput).toHaveAttribute('data-otp-input');
Comment thread
tmilewski marked this conversation as resolved.

 expect(hiddenInput).toHaveAttribute('role', 'textbox');
 expect(hiddenInput).toHaveAttribute('aria-label', 'One-time password input for password managers');
 expect(hiddenInput).toHaveAttribute('aria-hidden', 'true');
 expect(hiddenInput).toHaveAttribute('data-testid', 'otp-input');
 });

 it('handles focus redirection from hidden input to visible inputs', async () => {
 const { wrapper } = await createFixtures();
 const onCodeEntryFinished = vi.fn();
 const Component = createOTPComponent(onCodeEntryFinished);

 const { container } = render(<Component />, { wrapper });

 const hiddenInput = container.querySelector('[data-otp-hidden-input]') as HTMLInputElement;
 const visibleInputs = container.querySelectorAll('[data-otp-segment]');

 // Focus the hidden input (simulating password manager behavior)
 hiddenInput.focus();

 await waitFor(() => {
 // Should redirect focus to first visible input
 expect(visibleInputs[0]).toHaveFocus();
 });
 });

 it('maintains accessibility with proper ARIA attributes', async () => {
 const { wrapper } = await createFixtures();
 const onCodeEntryFinished = vi.fn();
 const Component = createOTPComponent(onCodeEntryFinished);

 const { container } = render(<Component />, { wrapper });

 const hiddenInput = container.querySelector('[data-otp-hidden-input]');
 const inputContainer = container.querySelector('[role="group"]');
 const instructions = container.querySelector('#otp-instructions');

 // Verify ARIA setup - some attributes might be filtered by the Input component
 expect(hiddenInput).toHaveAttribute('aria-hidden', 'true');
 expect(inputContainer).toHaveAttribute('aria-describedby', 'otp-instructions');
 expect(instructions).toHaveTextContent('Enter the 6-digit verification code');

 // Check for any aria-describedby attribute (it might be there but not exactly as expected)
 const ariaDescribedBy = hiddenInput?.getAttribute('aria-describedby');
 if (ariaDescribedBy) {
 expect(ariaDescribedBy).toBe('otp-instructions');
 }
 });

 it('focuses first visible input when hidden input is focused', async () => {
 const { wrapper } = await createFixtures();
 const onCodeEntryFinished = vi.fn();
Expand Down

7 changes: 7 additions & 0 deletions
packages/elements/src/react/common/form/hooks/use-input.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -183,6 +183,13 @@ export function useInput({
 pattern: `[0-9]{${length}}`,
 minLength: length,
 maxLength: length,
 // Enhanced naming for better password manager detection
 name: 'otp',
 id: 'otp-input',
 // Additional attributes for password manager compatibility
 'data-testid': 'otp-input',
 role: 'textbox',
 'aria-label': 'Enter verification code',
 onChange: (event: React.ChangeEvent<HTMLInputElement>) => {
 // Only accept numbers
 event.currentTarget.value = event.currentTarget.value.replace(/\D+/g, '');
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(clerk-js): Enhanced password manager detection#6311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tmilewski
merged 3 commits into

from

Jul 15, 2025
 Merged


feat(clerk-js): Enhanced password manager detection
#6311
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
a9fbe3c

feat: Enhanced password manager detection


tmilewski Jul 14, 2025
2d42753

chore: Add changeset


tmilewski Jul 14, 2025
e467c10

fix: tests


tmilewski Jul 14, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/twenty-camels-drum.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Enhanced detection of password manangers

62 changes: 56 additions & 6 deletions
packages/clerk-js/src/ui/elements/CodeControl.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -196,6 +196,19 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
 }
 }, [values]);

 // Focus management for password managers
 React.useEffect(() => {
 const handleFocus = () => {
 // If focus is on the hidden input, redirect to first visible input
 if (document.activeElement === hiddenInputRef.current) {
 setTimeout(() => focusInputAt(0), 0);
 }
 };

 document.addEventListener('focusin', handleFocus);
 return () => document.removeEventListener('focusin', handleFocus);
 }, []);

 const handleMultipleCharValue = ({ eventValue, inputPosition }: { eventValue: string; inputPosition: number }) => {
 const eventValues = (eventValue || '').split('');

Expand DownExpand Up@@ -311,26 +324,62 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
 ref={hiddenInputRef}
 type='text'
 autoComplete='one-time-code'
 data-otp-hidden-input
 inputMode='numeric'
 pattern={`[0-9]{${length}}`}
 minLength={length}
 maxLength={length}
 spellCheck={false}
 aria-hidden='true'
 name='otp'
 id='otp-input'
 data-otp-input
 data-otp-hidden-input
 data-testid='otp-input'
Comment thread
tmilewski marked this conversation as resolved.

 role='textbox'
 aria-label='One-time password input for password managers'
 aria-describedby='otp-instructions'
 aria-hidden
 tabIndex={-1}
 onChange={handleHiddenInputChange}
 onFocus={() => {
 // When password manager focuses the hidden input, focus the first visible input
 focusInputAt(0);
 }}
 sx={() => ({
 ...common.visuallyHidden(),
 left: '-9999px',
 // NOTE: Do not use the visuallyHidden() utility here, as it will break password manager autofill
 position: 'absolute',
 opacity: 0,
 width: '1px',
 height: '1px',
 overflow: 'hidden',
 clip: 'rect(0, 0, 0, 0)',
 clipPath: 'inset(50%)',
 whiteSpace: 'nowrap',
 // Ensure the input is still accessible to password managers
 // by not using display: none or visibility: hidden
 pointerEvents: 'none',
 // Position slightly within the container for better detection
 top: 0,
 left: 0,
 })}
 />

 {/* Hidden instructions for screen readers and password managers */}
 <span
 id='otp-instructions'
 style={{
 position: 'absolute',
 width: '1px',
 height: '1px',
 padding: 0,
 margin: '-1px',
 overflow: 'hidden',
 clip: 'rect(0, 0, 0, 0)',
 border: 0,
 }}
 >
 Enter the {length}-digit verification code
 </span>

 <Flex
 isLoading={isLoading}
 hasError={feedbackType === 'error'}
Expand All@@ -339,6 +388,7 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
 sx={t => ({ direction: 'ltr', padding: t.space.$1, marginLeft: `calc(${t.space.$1} * -1)`, ...centerSx })}
 role='group'
 aria-label='Verification code input'
 aria-describedby='otp-instructions'
 >
 {values.map((value: string, index: number) => (
 <SingleCharInput
Expand All@@ -363,8 +413,8 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
 type='text'
 inputMode='numeric'
 name={`codeInput-${index}`}
 data-otp-segment
 data-1p-ignore
 data-otp-segment='true'
 data-1p-ignore='true'
 data-lpignore='true'
 maxLength={1}
 pattern='[0-9]'
Expand Down

74 changes: 70 additions & 4 deletions
packages/clerk-js/src/ui/elements/__tests__/CodeControl.spec.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -328,19 +328,85 @@ describe('CodeControl', () => {

 // Simulate autofill with mixed characters
 if (hiddenInput) {
 fireEvent.change(hiddenInput, { target: { value: '1a2b3c4d5e6f' } });
 fireEvent.change(hiddenInput, { target: { value: '1a2b3c' } });
 }

 await waitFor(() => {
 expect(visibleInputs[0]).toHaveValue('1');
 expect(visibleInputs[1]).toHaveValue('2');
 expect(visibleInputs[2]).toHaveValue('3');
 expect(visibleInputs[3]).toHaveValue('4');
 expect(visibleInputs[4]).toHaveValue('5');
 expect(visibleInputs[5]).toHaveValue('6');
 expect(visibleInputs[3]).toHaveValue('');
 expect(visibleInputs[4]).toHaveValue('');
 expect(visibleInputs[5]).toHaveValue('');
 });
 });

 it('has proper password manager attributes for detection', async () => {
 const { wrapper } = await createFixtures();
 const onCodeEntryFinished = vi.fn();
 const Component = createOTPComponent(onCodeEntryFinished);

 const { container } = render(<Component />, { wrapper });

 const hiddenInput = container.querySelector('[data-otp-hidden-input]');

 // Verify critical attributes for detection
 expect(hiddenInput).toHaveAttribute('autocomplete', 'one-time-code');
 expect(hiddenInput).toHaveAttribute('inputmode', 'numeric');
 expect(hiddenInput).toHaveAttribute('pattern', '[0-9]{6}');
 expect(hiddenInput).toHaveAttribute('minlength', '6');
 expect(hiddenInput).toHaveAttribute('maxlength', '6');
 expect(hiddenInput).toHaveAttribute('name', 'otp');
 expect(hiddenInput).toHaveAttribute('id', 'otp-input');
 expect(hiddenInput).toHaveAttribute('data-otp-input');
Comment thread
tmilewski marked this conversation as resolved.

 expect(hiddenInput).toHaveAttribute('role', 'textbox');
 expect(hiddenInput).toHaveAttribute('aria-label', 'One-time password input for password managers');
 expect(hiddenInput).toHaveAttribute('aria-hidden', 'true');
 expect(hiddenInput).toHaveAttribute('data-testid', 'otp-input');
 });

 it('handles focus redirection from hidden input to visible inputs', async () => {
 const { wrapper } = await createFixtures();
 const onCodeEntryFinished = vi.fn();
 const Component = createOTPComponent(onCodeEntryFinished);

 const { container } = render(<Component />, { wrapper });

 const hiddenInput = container.querySelector('[data-otp-hidden-input]') as HTMLInputElement;
 const visibleInputs = container.querySelectorAll('[data-otp-segment]');

 // Focus the hidden input (simulating password manager behavior)
 hiddenInput.focus();

 await waitFor(() => {
 // Should redirect focus to first visible input
 expect(visibleInputs[0]).toHaveFocus();
 });
 });

 it('maintains accessibility with proper ARIA attributes', async () => {
 const { wrapper } = await createFixtures();
 const onCodeEntryFinished = vi.fn();
 const Component = createOTPComponent(onCodeEntryFinished);

 const { container } = render(<Component />, { wrapper });

 const hiddenInput = container.querySelector('[data-otp-hidden-input]');
 const inputContainer = container.querySelector('[role="group"]');
 const instructions = container.querySelector('#otp-instructions');

 // Verify ARIA setup - some attributes might be filtered by the Input component
 expect(hiddenInput).toHaveAttribute('aria-hidden', 'true');
 expect(inputContainer).toHaveAttribute('aria-describedby', 'otp-instructions');
 expect(instructions).toHaveTextContent('Enter the 6-digit verification code');

 // Check for any aria-describedby attribute (it might be there but not exactly as expected)
 const ariaDescribedBy = hiddenInput?.getAttribute('aria-describedby');
 if (ariaDescribedBy) {
 expect(ariaDescribedBy).toBe('otp-instructions');
 }
 });

 it('focuses first visible input when hidden input is focused', async () => {
 const { wrapper } = await createFixtures();
 const onCodeEntryFinished = vi.fn();
Expand Down

7 changes: 7 additions & 0 deletions
packages/elements/src/react/common/form/hooks/use-input.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -183,6 +183,13 @@ export function useInput({
 pattern: `[0-9]{${length}}`,
 minLength: length,
 maxLength: length,
 // Enhanced naming for better password manager detection
 name: 'otp',
 id: 'otp-input',
 // Additional attributes for password manager compatibility
 'data-testid': 'otp-input',
 role: 'textbox',
 'aria-label': 'Enter verification code',
 onChange: (event: React.ChangeEvent<HTMLInputElement>) => {
 // Only accept numbers
 event.currentTarget.value = event.currentTarget.value.replace(/\D+/g, '');
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(clerk-js): Enhanced password manager detection#6311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tmilewski
merged 3 commits into

from

Jul 15, 2025
 Merged


feat(clerk-js): Enhanced password manager detection
#6311
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
a9fbe3c

feat: Enhanced password manager detection


tmilewski Jul 14, 2025
2d42753

chore: Add changeset


tmilewski Jul 14, 2025
e467c10

fix: tests


tmilewski Jul 14, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/twenty-camels-drum.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Enhanced detection of password manangers

62 changes: 56 additions & 6 deletions
packages/clerk-js/src/ui/elements/CodeControl.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -196,6 +196,19 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
 }
 }, [values]);

 // Focus management for password managers
 React.useEffect(() => {
 const handleFocus = () => {
 // If focus is on the hidden input, redirect to first visible input
 if (document.activeElement === hiddenInputRef.current) {
 setTimeout(() => focusInputAt(0), 0);
 }
 };

 document.addEventListener('focusin', handleFocus);
 return () => document.removeEventListener('focusin', handleFocus);
 }, []);

 const handleMultipleCharValue = ({ eventValue, inputPosition }: { eventValue: string; inputPosition: number }) => {
 const eventValues = (eventValue || '').split('');

Expand DownExpand Up@@ -311,26 +324,62 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
 ref={hiddenInputRef}
 type='text'
 autoComplete='one-time-code'
 data-otp-hidden-input
 inputMode='numeric'
 pattern={`[0-9]{${length}}`}
 minLength={length}
 maxLength={length}
 spellCheck={false}
 aria-hidden='true'
 name='otp'
 id='otp-input'
 data-otp-input
 data-otp-hidden-input
 data-testid='otp-input'
Comment thread
tmilewski marked this conversation as resolved.

 role='textbox'
 aria-label='One-time password input for password managers'
 aria-describedby='otp-instructions'
 aria-hidden
 tabIndex={-1}
 onChange={handleHiddenInputChange}
 onFocus={() => {
 // When password manager focuses the hidden input, focus the first visible input
 focusInputAt(0);
 }}
 sx={() => ({
 ...common.visuallyHidden(),
 left: '-9999px',
 // NOTE: Do not use the visuallyHidden() utility here, as it will break password manager autofill
 position: 'absolute',
 opacity: 0,
 width: '1px',
 height: '1px',
 overflow: 'hidden',
 clip: 'rect(0, 0, 0, 0)',
 clipPath: 'inset(50%)',
 whiteSpace: 'nowrap',
 // Ensure the input is still accessible to password managers
 // by not using display: none or visibility: hidden
 pointerEvents: 'none',
 // Position slightly within the container for better detection
 top: 0,
 left: 0,
 })}
 />

 {/* Hidden instructions for screen readers and password managers */}
 <span
 id='otp-instructions'
 style={{
 position: 'absolute',
 width: '1px',
 height: '1px',
 padding: 0,
 margin: '-1px',
 overflow: 'hidden',
 clip: 'rect(0, 0, 0, 0)',
 border: 0,
 }}
 >
 Enter the {length}-digit verification code
 </span>

 <Flex
 isLoading={isLoading}
 hasError={feedbackType === 'error'}
Expand All@@ -339,6 +388,7 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
 sx={t => ({ direction: 'ltr', padding: t.space.$1, marginLeft: `calc(${t.space.$1} * -1)`, ...centerSx })}
 role='group'
 aria-label='Verification code input'
 aria-describedby='otp-instructions'
 >
 {values.map((value: string, index: number) => (
 <SingleCharInput
Expand All@@ -363,8 +413,8 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
 type='text'
 inputMode='numeric'
 name={`codeInput-${index}`}
 data-otp-segment
 data-1p-ignore
 data-otp-segment='true'
 data-1p-ignore='true'
 data-lpignore='true'
 maxLength={1}
 pattern='[0-9]'
Expand Down

74 changes: 70 additions & 4 deletions
packages/clerk-js/src/ui/elements/__tests__/CodeControl.spec.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -328,19 +328,85 @@ describe('CodeControl', () => {

 // Simulate autofill with mixed characters
 if (hiddenInput) {
 fireEvent.change(hiddenInput, { target: { value: '1a2b3c4d5e6f' } });
 fireEvent.change(hiddenInput, { target: { value: '1a2b3c' } });
 }

 await waitFor(() => {
 expect(visibleInputs[0]).toHaveValue('1');
 expect(visibleInputs[1]).toHaveValue('2');
 expect(visibleInputs[2]).toHaveValue('3');
 expect(visibleInputs[3]).toHaveValue('4');
 expect(visibleInputs[4]).toHaveValue('5');
 expect(visibleInputs[5]).toHaveValue('6');
 expect(visibleInputs[3]).toHaveValue('');
 expect(visibleInputs[4]).toHaveValue('');
 expect(visibleInputs[5]).toHaveValue('');
 });
 });

 it('has proper password manager attributes for detection', async () => {
 const { wrapper } = await createFixtures();
 const onCodeEntryFinished = vi.fn();
 const Component = createOTPComponent(onCodeEntryFinished);

 const { container } = render(<Component />, { wrapper });

 const hiddenInput = container.querySelector('[data-otp-hidden-input]');

 // Verify critical attributes for detection
 expect(hiddenInput).toHaveAttribute('autocomplete', 'one-time-code');
 expect(hiddenInput).toHaveAttribute('inputmode', 'numeric');
 expect(hiddenInput).toHaveAttribute('pattern', '[0-9]{6}');
 expect(hiddenInput).toHaveAttribute('minlength', '6');
 expect(hiddenInput).toHaveAttribute('maxlength', '6');
 expect(hiddenInput).toHaveAttribute('name', 'otp');
 expect(hiddenInput).toHaveAttribute('id', 'otp-input');
 expect(hiddenInput).toHaveAttribute('data-otp-input');
Comment thread
tmilewski marked this conversation as resolved.

 expect(hiddenInput).toHaveAttribute('role', 'textbox');
 expect(hiddenInput).toHaveAttribute('aria-label', 'One-time password input for password managers');
 expect(hiddenInput).toHaveAttribute('aria-hidden', 'true');
 expect(hiddenInput).toHaveAttribute('data-testid', 'otp-input');
 });

 it('handles focus redirection from hidden input to visible inputs', async () => {
 const { wrapper } = await createFixtures();
 const onCodeEntryFinished = vi.fn();
 const Component = createOTPComponent(onCodeEntryFinished);

 const { container } = render(<Component />, { wrapper });

 const hiddenInput = container.querySelector('[data-otp-hidden-input]') as HTMLInputElement;
 const visibleInputs = container.querySelectorAll('[data-otp-segment]');

 // Focus the hidden input (simulating password manager behavior)
 hiddenInput.focus();

 await waitFor(() => {
 // Should redirect focus to first visible input
 expect(visibleInputs[0]).toHaveFocus();
 });
 });

 it('maintains accessibility with proper ARIA attributes', async () => {
 const { wrapper } = await createFixtures();
 const onCodeEntryFinished = vi.fn();
 const Component = createOTPComponent(onCodeEntryFinished);

 const { container } = render(<Component />, { wrapper });

 const hiddenInput = container.querySelector('[data-otp-hidden-input]');
 const inputContainer = container.querySelector('[role="group"]');
 const instructions = container.querySelector('#otp-instructions');

 // Verify ARIA setup - some attributes might be filtered by the Input component
 expect(hiddenInput).toHaveAttribute('aria-hidden', 'true');
 expect(inputContainer).toHaveAttribute('aria-describedby', 'otp-instructions');
 expect(instructions).toHaveTextContent('Enter the 6-digit verification code');

 // Check for any aria-describedby attribute (it might be there but not exactly as expected)
 const ariaDescribedBy = hiddenInput?.getAttribute('aria-describedby');
 if (ariaDescribedBy) {
 expect(ariaDescribedBy).toBe('otp-instructions');
 }
 });

 it('focuses first visible input when hidden input is focused', async () => {
 const { wrapper } = await createFixtures();
 const onCodeEntryFinished = vi.fn();
Expand Down

7 changes: 7 additions & 0 deletions
packages/elements/src/react/common/form/hooks/use-input.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -183,6 +183,13 @@ export function useInput({
 pattern: `[0-9]{${length}}`,
 minLength: length,
 maxLength: length,
 // Enhanced naming for better password manager detection
 name: 'otp',
 id: 'otp-input',
 // Additional attributes for password manager compatibility
 'data-testid': 'otp-input',
 role: 'textbox',
 'aria-label': 'Enter verification code',
 onChange: (event: React.ChangeEvent<HTMLInputElement>) => {
 // Only accept numbers
 event.currentTarget.value = event.currentTarget.value.replace(/\D+/g, '');
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat(clerk-js): Enhanced password manager detection#6311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tmilewski
merged 3 commits into

from

Jul 15, 2025
 Merged


feat(clerk-js): Enhanced password manager detection
#6311
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
a9fbe3c

feat: Enhanced password manager detection


tmilewski Jul 14, 2025
2d42753

chore: Add changeset


tmilewski Jul 14, 2025
e467c10

fix: tests


tmilewski Jul 14, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/twenty-camels-drum.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Enhanced detection of password manangers

62 changes: 56 additions & 6 deletions
packages/clerk-js/src/ui/elements/CodeControl.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -196,6 +196,19 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
 }
 }, [values]);

 // Focus management for password managers
 React.useEffect(() => {
 const handleFocus = () => {
 // If focus is on the hidden input, redirect to first visible input
 if (document.activeElement === hiddenInputRef.current) {
 setTimeout(() => focusInputAt(0), 0);
 }
 };

 document.addEventListener('focusin', handleFocus);
 return () => document.removeEventListener('focusin', handleFocus);
 }, []);

 const handleMultipleCharValue = ({ eventValue, inputPosition }: { eventValue: string; inputPosition: number }) => {
 const eventValues = (eventValue || '').split('');

Expand DownExpand Up@@ -311,26 +324,62 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
 ref={hiddenInputRef}
 type='text'
 autoComplete='one-time-code'
 data-otp-hidden-input
 inputMode='numeric'
 pattern={`[0-9]{${length}}`}
 minLength={length}
 maxLength={length}
 spellCheck={false}
 aria-hidden='true'
 name='otp'
 id='otp-input'
 data-otp-input
 data-otp-hidden-input
 data-testid='otp-input'
Comment thread
tmilewski marked this conversation as resolved.

 role='textbox'
 aria-label='One-time password input for password managers'
 aria-describedby='otp-instructions'
 aria-hidden
 tabIndex={-1}
 onChange={handleHiddenInputChange}
 onFocus={() => {
 // When password manager focuses the hidden input, focus the first visible input
 focusInputAt(0);
 }}
 sx={() => ({
 ...common.visuallyHidden(),
 left: '-9999px',
 // NOTE: Do not use the visuallyHidden() utility here, as it will break password manager autofill
 position: 'absolute',
 opacity: 0,
 width: '1px',
 height: '1px',
 overflow: 'hidden',
 clip: 'rect(0, 0, 0, 0)',
 clipPath: 'inset(50%)',
 whiteSpace: 'nowrap',
 // Ensure the input is still accessible to password managers
 // by not using display: none or visibility: hidden
 pointerEvents: 'none',
 // Position slightly within the container for better detection
 top: 0,
 left: 0,
 })}
 />

 {/* Hidden instructions for screen readers and password managers */}
 <span
 id='otp-instructions'
 style={{
 position: 'absolute',
 width: '1px',
 height: '1px',
 padding: 0,
 margin: '-1px',
 overflow: 'hidden',
 clip: 'rect(0, 0, 0, 0)',
 border: 0,
 }}
 >
 Enter the {length}-digit verification code
 </span>

 <Flex
 isLoading={isLoading}
 hasError={feedbackType === 'error'}
Expand All@@ -339,6 +388,7 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
 sx={t => ({ direction: 'ltr', padding: t.space.$1, marginLeft: `calc(${t.space.$1} * -1)`, ...centerSx })}
 role='group'
 aria-label='Verification code input'
 aria-describedby='otp-instructions'
 >
 {values.map((value: string, index: number) => (
 <SingleCharInput
Expand All@@ -363,8 +413,8 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
 type='text'
 inputMode='numeric'
 name={`codeInput-${index}`}
 data-otp-segment
 data-1p-ignore
 data-otp-segment='true'
 data-1p-ignore='true'
 data-lpignore='true'
 maxLength={1}
 pattern='[0-9]'
Expand Down

74 changes: 70 additions & 4 deletions
packages/clerk-js/src/ui/elements/__tests__/CodeControl.spec.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -328,19 +328,85 @@ describe('CodeControl', () => {

 // Simulate autofill with mixed characters
 if (hiddenInput) {
 fireEvent.change(hiddenInput, { target: { value: '1a2b3c4d5e6f' } });
 fireEvent.change(hiddenInput, { target: { value: '1a2b3c' } });
 }

 await waitFor(() => {
 expect(visibleInputs[0]).toHaveValue('1');
 expect(visibleInputs[1]).toHaveValue('2');
 expect(visibleInputs[2]).toHaveValue('3');
 expect(visibleInputs[3]).toHaveValue('4');
 expect(visibleInputs[4]).toHaveValue('5');
 expect(visibleInputs[5]).toHaveValue('6');
 expect(visibleInputs[3]).toHaveValue('');
 expect(visibleInputs[4]).toHaveValue('');
 expect(visibleInputs[5]).toHaveValue('');
 });
 });

 it('has proper password manager attributes for detection', async () => {
 const { wrapper } = await createFixtures();
 const onCodeEntryFinished = vi.fn();
 const Component = createOTPComponent(onCodeEntryFinished);

 const { container } = render(<Component />, { wrapper });

 const hiddenInput = container.querySelector('[data-otp-hidden-input]');

 // Verify critical attributes for detection
 expect(hiddenInput).toHaveAttribute('autocomplete', 'one-time-code');
 expect(hiddenInput).toHaveAttribute('inputmode', 'numeric');
 expect(hiddenInput).toHaveAttribute('pattern', '[0-9]{6}');
 expect(hiddenInput).toHaveAttribute('minlength', '6');
 expect(hiddenInput).toHaveAttribute('maxlength', '6');
 expect(hiddenInput).toHaveAttribute('name', 'otp');
 expect(hiddenInput).toHaveAttribute('id', 'otp-input');
 expect(hiddenInput).toHaveAttribute('data-otp-input');
Comment thread
tmilewski marked this conversation as resolved.

 expect(hiddenInput).toHaveAttribute('role', 'textbox');
 expect(hiddenInput).toHaveAttribute('aria-label', 'One-time password input for password managers');
 expect(hiddenInput).toHaveAttribute('aria-hidden', 'true');
 expect(hiddenInput).toHaveAttribute('data-testid', 'otp-input');
 });

 it('handles focus redirection from hidden input to visible inputs', async () => {
 const { wrapper } = await createFixtures();
 const onCodeEntryFinished = vi.fn();
 const Component = createOTPComponent(onCodeEntryFinished);

 const { container } = render(<Component />, { wrapper });

 const hiddenInput = container.querySelector('[data-otp-hidden-input]') as HTMLInputElement;
 const visibleInputs = container.querySelectorAll('[data-otp-segment]');

 // Focus the hidden input (simulating password manager behavior)
 hiddenInput.focus();

 await waitFor(() => {
 // Should redirect focus to first visible input
 expect(visibleInputs[0]).toHaveFocus();
 });
 });

 it('maintains accessibility with proper ARIA attributes', async () => {
 const { wrapper } = await createFixtures();
 const onCodeEntryFinished = vi.fn();
 const Component = createOTPComponent(onCodeEntryFinished);

 const { container } = render(<Component />, { wrapper });

 const hiddenInput = container.querySelector('[data-otp-hidden-input]');
 const inputContainer = container.querySelector('[role="group"]');
 const instructions = container.querySelector('#otp-instructions');

 // Verify ARIA setup - some attributes might be filtered by the Input component
 expect(hiddenInput).toHaveAttribute('aria-hidden', 'true');
 expect(inputContainer).toHaveAttribute('aria-describedby', 'otp-instructions');
 expect(instructions).toHaveTextContent('Enter the 6-digit verification code');

 // Check for any aria-describedby attribute (it might be there but not exactly as expected)
 const ariaDescribedBy = hiddenInput?.getAttribute('aria-describedby');
 if (ariaDescribedBy) {
 expect(ariaDescribedBy).toBe('otp-instructions');
 }
 });

 it('focuses first visible input when hidden input is focused', async () => {
 const { wrapper } = await createFixtures();
 const onCodeEntryFinished = vi.fn();
Expand Down

7 changes: 7 additions & 0 deletions
packages/elements/src/react/common/form/hooks/use-input.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -183,6 +183,13 @@ export function useInput({
 pattern: `[0-9]{${length}}`,
 minLength: length,
 maxLength: length,
 // Enhanced naming for better password manager detection
 name: 'otp',
 id: 'otp-input',
 // Additional attributes for password manager compatibility
 'data-testid': 'otp-input',
 role: 'textbox',
 'aria-label': 'Enter verification code',
 onChange: (event: React.ChangeEvent<HTMLInputElement>) => {
 // Only accept numbers
 event.currentTarget.value = event.currentTarget.value.replace(/\D+/g, '');
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(clerk-js): Enhanced password manager detection#6311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tmilewski
merged 3 commits into

from

Jul 15, 2025
 Merged


feat(clerk-js): Enhanced password manager detection
#6311
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
a9fbe3c

feat: Enhanced password manager detection


tmilewski Jul 14, 2025
2d42753

chore: Add changeset


tmilewski Jul 14, 2025
e467c10

fix: tests


tmilewski Jul 14, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/twenty-camels-drum.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Enhanced detection of password manangers

62 changes: 56 additions & 6 deletions
packages/clerk-js/src/ui/elements/CodeControl.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -196,6 +196,19 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
 }
 }, [values]);

 // Focus management for password managers
 React.useEffect(() => {
 const handleFocus = () => {
 // If focus is on the hidden input, redirect to first visible input
 if (document.activeElement === hiddenInputRef.current) {
 setTimeout(() => focusInputAt(0), 0);
 }
 };

 document.addEventListener('focusin', handleFocus);
 return () => document.removeEventListener('focusin', handleFocus);
 }, []);

 const handleMultipleCharValue = ({ eventValue, inputPosition }: { eventValue: string; inputPosition: number }) => {
 const eventValues = (eventValue || '').split('');

Expand DownExpand Up@@ -311,26 +324,62 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
 ref={hiddenInputRef}
 type='text'
 autoComplete='one-time-code'
 data-otp-hidden-input
 inputMode='numeric'
 pattern={`[0-9]{${length}}`}
 minLength={length}
 maxLength={length}
 spellCheck={false}
 aria-hidden='true'
 name='otp'
 id='otp-input'
 data-otp-input
 data-otp-hidden-input
 data-testid='otp-input'
Comment thread
tmilewski marked this conversation as resolved.

 role='textbox'
 aria-label='One-time password input for password managers'
 aria-describedby='otp-instructions'
 aria-hidden
 tabIndex={-1}
 onChange={handleHiddenInputChange}
 onFocus={() => {
 // When password manager focuses the hidden input, focus the first visible input
 focusInputAt(0);
 }}
 sx={() => ({
 ...common.visuallyHidden(),
 left: '-9999px',
 // NOTE: Do not use the visuallyHidden() utility here, as it will break password manager autofill
 position: 'absolute',
 opacity: 0,
 width: '1px',
 height: '1px',
 overflow: 'hidden',
 clip: 'rect(0, 0, 0, 0)',
 clipPath: 'inset(50%)',
 whiteSpace: 'nowrap',
 // Ensure the input is still accessible to password managers
 // by not using display: none or visibility: hidden
 pointerEvents: 'none',
 // Position slightly within the container for better detection
 top: 0,
 left: 0,
 })}
 />

 {/* Hidden instructions for screen readers and password managers */}
 <span
 id='otp-instructions'
 style={{
 position: 'absolute',
 width: '1px',
 height: '1px',
 padding: 0,
 margin: '-1px',
 overflow: 'hidden',
 clip: 'rect(0, 0, 0, 0)',
 border: 0,
 }}
 >
 Enter the {length}-digit verification code
 </span>

 <Flex
 isLoading={isLoading}
 hasError={feedbackType === 'error'}
Expand All@@ -339,6 +388,7 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
 sx={t => ({ direction: 'ltr', padding: t.space.$1, marginLeft: `calc(${t.space.$1} * -1)`, ...centerSx })}
 role='group'
 aria-label='Verification code input'
 aria-describedby='otp-instructions'
 >
 {values.map((value: string, index: number) => (
 <SingleCharInput
Expand All@@ -363,8 +413,8 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
 type='text'
 inputMode='numeric'
 name={`codeInput-${index}`}
 data-otp-segment
 data-1p-ignore
 data-otp-segment='true'
 data-1p-ignore='true'
 data-lpignore='true'
 maxLength={1}
 pattern='[0-9]'
Expand Down

74 changes: 70 additions & 4 deletions
packages/clerk-js/src/ui/elements/__tests__/CodeControl.spec.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -328,19 +328,85 @@ describe('CodeControl', () => {

 // Simulate autofill with mixed characters
 if (hiddenInput) {
 fireEvent.change(hiddenInput, { target: { value: '1a2b3c4d5e6f' } });
 fireEvent.change(hiddenInput, { target: { value: '1a2b3c' } });
 }

 await waitFor(() => {
 expect(visibleInputs[0]).toHaveValue('1');
 expect(visibleInputs[1]).toHaveValue('2');
 expect(visibleInputs[2]).toHaveValue('3');
 expect(visibleInputs[3]).toHaveValue('4');
 expect(visibleInputs[4]).toHaveValue('5');
 expect(visibleInputs[5]).toHaveValue('6');
 expect(visibleInputs[3]).toHaveValue('');
 expect(visibleInputs[4]).toHaveValue('');
 expect(visibleInputs[5]).toHaveValue('');
 });
 });

 it('has proper password manager attributes for detection', async () => {
 const { wrapper } = await createFixtures();
 const onCodeEntryFinished = vi.fn();
 const Component = createOTPComponent(onCodeEntryFinished);

 const { container } = render(<Component />, { wrapper });

 const hiddenInput = container.querySelector('[data-otp-hidden-input]');

 // Verify critical attributes for detection
 expect(hiddenInput).toHaveAttribute('autocomplete', 'one-time-code');
 expect(hiddenInput).toHaveAttribute('inputmode', 'numeric');
 expect(hiddenInput).toHaveAttribute('pattern', '[0-9]{6}');
 expect(hiddenInput).toHaveAttribute('minlength', '6');
 expect(hiddenInput).toHaveAttribute('maxlength', '6');
 expect(hiddenInput).toHaveAttribute('name', 'otp');
 expect(hiddenInput).toHaveAttribute('id', 'otp-input');
 expect(hiddenInput).toHaveAttribute('data-otp-input');
Comment thread
tmilewski marked this conversation as resolved.

 expect(hiddenInput).toHaveAttribute('role', 'textbox');
 expect(hiddenInput).toHaveAttribute('aria-label', 'One-time password input for password managers');
 expect(hiddenInput).toHaveAttribute('aria-hidden', 'true');
 expect(hiddenInput).toHaveAttribute('data-testid', 'otp-input');
 });

 it('handles focus redirection from hidden input to visible inputs', async () => {
 const { wrapper } = await createFixtures();
 const onCodeEntryFinished = vi.fn();
 const Component = createOTPComponent(onCodeEntryFinished);

 const { container } = render(<Component />, { wrapper });

 const hiddenInput = container.querySelector('[data-otp-hidden-input]') as HTMLInputElement;
 const visibleInputs = container.querySelectorAll('[data-otp-segment]');

 // Focus the hidden input (simulating password manager behavior)
 hiddenInput.focus();

 await waitFor(() => {
 // Should redirect focus to first visible input
 expect(visibleInputs[0]).toHaveFocus();
 });
 });

 it('maintains accessibility with proper ARIA attributes', async () => {
 const { wrapper } = await createFixtures();
 const onCodeEntryFinished = vi.fn();
 const Component = createOTPComponent(onCodeEntryFinished);

 const { container } = render(<Component />, { wrapper });

 const hiddenInput = container.querySelector('[data-otp-hidden-input]');
 const inputContainer = container.querySelector('[role="group"]');
 const instructions = container.querySelector('#otp-instructions');

 // Verify ARIA setup - some attributes might be filtered by the Input component
 expect(hiddenInput).toHaveAttribute('aria-hidden', 'true');
 expect(inputContainer).toHaveAttribute('aria-describedby', 'otp-instructions');
 expect(instructions).toHaveTextContent('Enter the 6-digit verification code');

 // Check for any aria-describedby attribute (it might be there but not exactly as expected)
 const ariaDescribedBy = hiddenInput?.getAttribute('aria-describedby');
 if (ariaDescribedBy) {
 expect(ariaDescribedBy).toBe('otp-instructions');
 }
 });

 it('focuses first visible input when hidden input is focused', async () => {
 const { wrapper } = await createFixtures();
 const onCodeEntryFinished = vi.fn();
Expand Down

7 changes: 7 additions & 0 deletions
packages/elements/src/react/common/form/hooks/use-input.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -183,6 +183,13 @@ export function useInput({
 pattern: `[0-9]{${length}}`,
 minLength: length,
 maxLength: length,
 // Enhanced naming for better password manager detection
 name: 'otp',
 id: 'otp-input',
 // Additional attributes for password manager compatibility
 'data-testid': 'otp-input',
 role: 'textbox',
 'aria-label': 'Enter verification code',
 onChange: (event: React.ChangeEvent<HTMLInputElement>) => {
 // Only accept numbers
 event.currentTarget.value = event.currentTarget.value.replace(/\D+/g, '');
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(clerk-js): Enhanced password manager detection#6311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tmilewski
merged 3 commits into

from

Jul 15, 2025
 Merged


feat(clerk-js): Enhanced password manager detection
#6311
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
a9fbe3c

feat: Enhanced password manager detection


tmilewski Jul 14, 2025
2d42753

chore: Add changeset


tmilewski Jul 14, 2025
e467c10

fix: tests


tmilewski Jul 14, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/twenty-camels-drum.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Enhanced detection of password manangers

62 changes: 56 additions & 6 deletions
packages/clerk-js/src/ui/elements/CodeControl.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -196,6 +196,19 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
 }
 }, [values]);

 // Focus management for password managers
 React.useEffect(() => {
 const handleFocus = () => {
 // If focus is on the hidden input, redirect to first visible input
 if (document.activeElement === hiddenInputRef.current) {
 setTimeout(() => focusInputAt(0), 0);
 }
 };

 document.addEventListener('focusin', handleFocus);
 return () => document.removeEventListener('focusin', handleFocus);
 }, []);

 const handleMultipleCharValue = ({ eventValue, inputPosition }: { eventValue: string; inputPosition: number }) => {
 const eventValues = (eventValue || '').split('');

Expand DownExpand Up@@ -311,26 +324,62 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
 ref={hiddenInputRef}
 type='text'
 autoComplete='one-time-code'
 data-otp-hidden-input
 inputMode='numeric'
 pattern={`[0-9]{${length}}`}
 minLength={length}
 maxLength={length}
 spellCheck={false}
 aria-hidden='true'
 name='otp'
 id='otp-input'
 data-otp-input
 data-otp-hidden-input
 data-testid='otp-input'
Comment thread
tmilewski marked this conversation as resolved.

 role='textbox'
 aria-label='One-time password input for password managers'
 aria-describedby='otp-instructions'
 aria-hidden
 tabIndex={-1}
 onChange={handleHiddenInputChange}
 onFocus={() => {
 // When password manager focuses the hidden input, focus the first visible input
 focusInputAt(0);
 }}
 sx={() => ({
 ...common.visuallyHidden(),
 left: '-9999px',
 // NOTE: Do not use the visuallyHidden() utility here, as it will break password manager autofill
 position: 'absolute',
 opacity: 0,
 width: '1px',
 height: '1px',
 overflow: 'hidden',
 clip: 'rect(0, 0, 0, 0)',
 clipPath: 'inset(50%)',
 whiteSpace: 'nowrap',
 // Ensure the input is still accessible to password managers
 // by not using display: none or visibility: hidden
 pointerEvents: 'none',
 // Position slightly within the container for better detection
 top: 0,
 left: 0,
 })}
 />

 {/* Hidden instructions for screen readers and password managers */}
 <span
 id='otp-instructions'
 style={{
 position: 'absolute',
 width: '1px',
 height: '1px',
 padding: 0,
 margin: '-1px',
 overflow: 'hidden',
 clip: 'rect(0, 0, 0, 0)',
 border: 0,
 }}
 >
 Enter the {length}-digit verification code
 </span>

 <Flex
 isLoading={isLoading}
 hasError={feedbackType === 'error'}
Expand All@@ -339,6 +388,7 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
 sx={t => ({ direction: 'ltr', padding: t.space.$1, marginLeft: `calc(${t.space.$1} * -1)`, ...centerSx })}
 role='group'
 aria-label='Verification code input'
 aria-describedby='otp-instructions'
 >
 {values.map((value: string, index: number) => (
 <SingleCharInput
Expand All@@ -363,8 +413,8 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
 type='text'
 inputMode='numeric'
 name={`codeInput-${index}`}
 data-otp-segment
 data-1p-ignore
 data-otp-segment='true'
 data-1p-ignore='true'
 data-lpignore='true'
 maxLength={1}
 pattern='[0-9]'
Expand Down

74 changes: 70 additions & 4 deletions
packages/clerk-js/src/ui/elements/__tests__/CodeControl.spec.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -328,19 +328,85 @@ describe('CodeControl', () => {

 // Simulate autofill with mixed characters
 if (hiddenInput) {
 fireEvent.change(hiddenInput, { target: { value: '1a2b3c4d5e6f' } });
 fireEvent.change(hiddenInput, { target: { value: '1a2b3c' } });
 }

 await waitFor(() => {
 expect(visibleInputs[0]).toHaveValue('1');
 expect(visibleInputs[1]).toHaveValue('2');
 expect(visibleInputs[2]).toHaveValue('3');
 expect(visibleInputs[3]).toHaveValue('4');
 expect(visibleInputs[4]).toHaveValue('5');
 expect(visibleInputs[5]).toHaveValue('6');
 expect(visibleInputs[3]).toHaveValue('');
 expect(visibleInputs[4]).toHaveValue('');
 expect(visibleInputs[5]).toHaveValue('');
 });
 });

 it('has proper password manager attributes for detection', async () => {
 const { wrapper } = await createFixtures();
 const onCodeEntryFinished = vi.fn();
 const Component = createOTPComponent(onCodeEntryFinished);

 const { container } = render(<Component />, { wrapper });

 const hiddenInput = container.querySelector('[data-otp-hidden-input]');

 // Verify critical attributes for detection
 expect(hiddenInput).toHaveAttribute('autocomplete', 'one-time-code');
 expect(hiddenInput).toHaveAttribute('inputmode', 'numeric');
 expect(hiddenInput).toHaveAttribute('pattern', '[0-9]{6}');
 expect(hiddenInput).toHaveAttribute('minlength', '6');
 expect(hiddenInput).toHaveAttribute('maxlength', '6');
 expect(hiddenInput).toHaveAttribute('name', 'otp');
 expect(hiddenInput).toHaveAttribute('id', 'otp-input');
 expect(hiddenInput).toHaveAttribute('data-otp-input');
Comment thread
tmilewski marked this conversation as resolved.

 expect(hiddenInput).toHaveAttribute('role', 'textbox');
 expect(hiddenInput).toHaveAttribute('aria-label', 'One-time password input for password managers');
 expect(hiddenInput).toHaveAttribute('aria-hidden', 'true');
 expect(hiddenInput).toHaveAttribute('data-testid', 'otp-input');
 });

 it('handles focus redirection from hidden input to visible inputs', async () => {
 const { wrapper } = await createFixtures();
 const onCodeEntryFinished = vi.fn();
 const Component = createOTPComponent(onCodeEntryFinished);

 const { container } = render(<Component />, { wrapper });

 const hiddenInput = container.querySelector('[data-otp-hidden-input]') as HTMLInputElement;
 const visibleInputs = container.querySelectorAll('[data-otp-segment]');

 // Focus the hidden input (simulating password manager behavior)
 hiddenInput.focus();

 await waitFor(() => {
 // Should redirect focus to first visible input
 expect(visibleInputs[0]).toHaveFocus();
 });
 });

 it('maintains accessibility with proper ARIA attributes', async () => {
 const { wrapper } = await createFixtures();
 const onCodeEntryFinished = vi.fn();
 const Component = createOTPComponent(onCodeEntryFinished);

 const { container } = render(<Component />, { wrapper });

 const hiddenInput = container.querySelector('[data-otp-hidden-input]');
 const inputContainer = container.querySelector('[role="group"]');
 const instructions = container.querySelector('#otp-instructions');

 // Verify ARIA setup - some attributes might be filtered by the Input component
 expect(hiddenInput).toHaveAttribute('aria-hidden', 'true');
 expect(inputContainer).toHaveAttribute('aria-describedby', 'otp-instructions');
 expect(instructions).toHaveTextContent('Enter the 6-digit verification code');

 // Check for any aria-describedby attribute (it might be there but not exactly as expected)
 const ariaDescribedBy = hiddenInput?.getAttribute('aria-describedby');
 if (ariaDescribedBy) {
 expect(ariaDescribedBy).toBe('otp-instructions');
 }
 });

 it('focuses first visible input when hidden input is focused', async () => {
 const { wrapper } = await createFixtures();
 const onCodeEntryFinished = vi.fn();
Expand Down

7 changes: 7 additions & 0 deletions
packages/elements/src/react/common/form/hooks/use-input.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -183,6 +183,13 @@ export function useInput({
 pattern: `[0-9]{${length}}`,
 minLength: length,
 maxLength: length,
 // Enhanced naming for better password manager detection
 name: 'otp',
 id: 'otp-input',
 // Additional attributes for password manager compatibility
 'data-testid': 'otp-input',
 role: 'textbox',
 'aria-label': 'Enter verification code',
 onChange: (event: React.ChangeEvent<HTMLInputElement>) => {
 // Only accept numbers
 event.currentTarget.value = event.currentTarget.value.replace(/\D+/g, '');
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat(clerk-js): Enhanced password manager detection#6311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tmilewski
merged 3 commits into

from

Jul 15, 2025
 Merged


feat(clerk-js): Enhanced password manager detection
#6311
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
a9fbe3c

feat: Enhanced password manager detection


tmilewski Jul 14, 2025
2d42753

chore: Add changeset


tmilewski Jul 14, 2025
e467c10

fix: tests


tmilewski Jul 14, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/twenty-camels-drum.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Enhanced detection of password manangers

62 changes: 56 additions & 6 deletions
packages/clerk-js/src/ui/elements/CodeControl.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -196,6 +196,19 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
 }
 }, [values]);

 // Focus management for password managers
 React.useEffect(() => {
 const handleFocus = () => {
 // If focus is on the hidden input, redirect to first visible input
 if (document.activeElement === hiddenInputRef.current) {
 setTimeout(() => focusInputAt(0), 0);
 }
 };

 document.addEventListener('focusin', handleFocus);
 return () => document.removeEventListener('focusin', handleFocus);
 }, []);

 const handleMultipleCharValue = ({ eventValue, inputPosition }: { eventValue: string; inputPosition: number }) => {
 const eventValues = (eventValue || '').split('');

Expand DownExpand Up@@ -311,26 +324,62 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
 ref={hiddenInputRef}
 type='text'
 autoComplete='one-time-code'
 data-otp-hidden-input
 inputMode='numeric'
 pattern={`[0-9]{${length}}`}
 minLength={length}
 maxLength={length}
 spellCheck={false}
 aria-hidden='true'
 name='otp'
 id='otp-input'
 data-otp-input
 data-otp-hidden-input
 data-testid='otp-input'
Comment thread
tmilewski marked this conversation as resolved.

 role='textbox'
 aria-label='One-time password input for password managers'
 aria-describedby='otp-instructions'
 aria-hidden
 tabIndex={-1}
 onChange={handleHiddenInputChange}
 onFocus={() => {
 // When password manager focuses the hidden input, focus the first visible input
 focusInputAt(0);
 }}
 sx={() => ({
 ...common.visuallyHidden(),
 left: '-9999px',
 // NOTE: Do not use the visuallyHidden() utility here, as it will break password manager autofill
 position: 'absolute',
 opacity: 0,
 width: '1px',
 height: '1px',
 overflow: 'hidden',
 clip: 'rect(0, 0, 0, 0)',
 clipPath: 'inset(50%)',
 whiteSpace: 'nowrap',
 // Ensure the input is still accessible to password managers
 // by not using display: none or visibility: hidden
 pointerEvents: 'none',
 // Position slightly within the container for better detection
 top: 0,
 left: 0,
 })}
 />

 {/* Hidden instructions for screen readers and password managers */}
 <span
 id='otp-instructions'
 style={{
 position: 'absolute',
 width: '1px',
 height: '1px',
 padding: 0,
 margin: '-1px',
 overflow: 'hidden',
 clip: 'rect(0, 0, 0, 0)',
 border: 0,
 }}
 >
 Enter the {length}-digit verification code
 </span>

 <Flex
 isLoading={isLoading}
 hasError={feedbackType === 'error'}
Expand All@@ -339,6 +388,7 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
 sx={t => ({ direction: 'ltr', padding: t.space.$1, marginLeft: `calc(${t.space.$1} * -1)`, ...centerSx })}
 role='group'
 aria-label='Verification code input'
 aria-describedby='otp-instructions'
 >
 {values.map((value: string, index: number) => (
 <SingleCharInput
Expand All@@ -363,8 +413,8 @@ export const OTPCodeControl = React.forwardRef<{ reset: any }>((_, ref) => {
 type='text'
 inputMode='numeric'
 name={`codeInput-${index}`}
 data-otp-segment
 data-1p-ignore
 data-otp-segment='true'
 data-1p-ignore='true'
 data-lpignore='true'
 maxLength={1}
 pattern='[0-9]'
Expand Down

74 changes: 70 additions & 4 deletions
packages/clerk-js/src/ui/elements/__tests__/CodeControl.spec.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -328,19 +328,85 @@ describe('CodeControl', () => {

 // Simulate autofill with mixed characters
 if (hiddenInput) {
 fireEvent.change(hiddenInput, { target: { value: '1a2b3c4d5e6f' } });
 fireEvent.change(hiddenInput, { target: { value: '1a2b3c' } });
 }

 await waitFor(() => {
 expect(visibleInputs[0]).toHaveValue('1');
 expect(visibleInputs[1]).toHaveValue('2');
 expect(visibleInputs[2]).toHaveValue('3');
 expect(visibleInputs[3]).toHaveValue('4');
 expect(visibleInputs[4]).toHaveValue('5');
 expect(visibleInputs[5]).toHaveValue('6');
 expect(visibleInputs[3]).toHaveValue('');
 expect(visibleInputs[4]).toHaveValue('');
 expect(visibleInputs[5]).toHaveValue('');
 });
 });

 it('has proper password manager attributes for detection', async () => {
 const { wrapper } = await createFixtures();
 const onCodeEntryFinished = vi.fn();
 const Component = createOTPComponent(onCodeEntryFinished);

 const { container } = render(<Component />, { wrapper });

 const hiddenInput = container.querySelector('[data-otp-hidden-input]');

 // Verify critical attributes for detection
 expect(hiddenInput).toHaveAttribute('autocomplete', 'one-time-code');
 expect(hiddenInput).toHaveAttribute('inputmode', 'numeric');
 expect(hiddenInput).toHaveAttribute('pattern', '[0-9]{6}');
 expect(hiddenInput).toHaveAttribute('minlength', '6');
 expect(hiddenInput).toHaveAttribute('maxlength', '6');
 expect(hiddenInput).toHaveAttribute('name', 'otp');
 expect(hiddenInput).toHaveAttribute('id', 'otp-input');
 expect(hiddenInput).toHaveAttribute('data-otp-input');
Comment thread
tmilewski marked this conversation as resolved.

 expect(hiddenInput).toHaveAttribute('role', 'textbox');
 expect(hiddenInput).toHaveAttribute('aria-label', 'One-time password input for password managers');
 expect(hiddenInput).toHaveAttribute('aria-hidden', 'true');
 expect(hiddenInput).toHaveAttribute('data-testid', 'otp-input');
 });

 it('handles focus redirection from hidden input to visible inputs', async () => {
 const { wrapper } = await createFixtures();
 const onCodeEntryFinished = vi.fn();
 const Component = createOTPComponent(onCodeEntryFinished);

 const { container } = render(<Component />, { wrapper });

 const hiddenInput = container.querySelector('[data-otp-hidden-input]') as HTMLInputElement;
 const visibleInputs = container.querySelectorAll('[data-otp-segment]');

 // Focus the hidden input (simulating password manager behavior)
 hiddenInput.focus();

 await waitFor(() => {
 // Should redirect focus to first visible input
 expect(visibleInputs[0]).toHaveFocus();
 });
 });

 it('maintains accessibility with proper ARIA attributes', async () => {
 const { wrapper } = await createFixtures();
 const onCodeEntryFinished = vi.fn();
 const Component = createOTPComponent(onCodeEntryFinished);

 const { container } = render(<Component />, { wrapper });

 const hiddenInput = container.querySelector('[data-otp-hidden-input]');
 const inputContainer = container.querySelector('[role="group"]');
 const instructions = container.querySelector('#otp-instructions');

 // Verify ARIA setup - some attributes might be filtered by the Input component
 expect(hiddenInput).toHaveAttribute('aria-hidden', 'true');
 expect(inputContainer).toHaveAttribute('aria-describedby', 'otp-instructions');
 expect(instructions).toHaveTextContent('Enter the 6-digit verification code');

 // Check for any aria-describedby attribute (it might be there but not exactly as expected)
 const ariaDescribedBy = hiddenInput?.getAttribute('aria-describedby');
 if (ariaDescribedBy) {
 expect(ariaDescribedBy).toBe('otp-instructions');
 }
 });

 it('focuses first visible input when hidden input is focused', async () => {
 const { wrapper } = await createFixtures();
 const onCodeEntryFinished = vi.fn();
Expand Down

7 changes: 7 additions & 0 deletions
packages/elements/src/react/common/form/hooks/use-input.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -183,6 +183,13 @@ export function useInput({
 pattern: `[0-9]{${length}}`,
 minLength: length,
 maxLength: length,
 // Enhanced naming for better password manager detection
 name: 'otp',
 id: 'otp-input',
 // Additional attributes for password manager compatibility
 'data-testid': 'otp-input',
 role: 'textbox',
 'aria-label': 'Enter verification code',
 onChange: (event: React.ChangeEvent<HTMLInputElement>) => {
 // Only accept numbers
 event.currentTarget.value = event.currentTarget.value.replace(/\D+/g, '');
Expand Down