chore(clerk-js): Rename org session task key to select-organization - #6372

Merged
LauraBeatris merged 1 commit into
mainfrom
laura/rename-task-key
Jul 22, 2025
Merged

chore(clerk-js): Rename org session task key to select-organization#6372
LauraBeatris merged 1 commit into
mainfrom
laura/rename-task-key

Conversation

@LauraBeatris

@LauraBeatrisLauraBeatris commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

Description

Waiting on API changes to be deployed first before merging this PR.https://github.com/clerk/clerk_go/pull/12757

It renames the session task key and all checks against it according to the latest FAPI nomenclature.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Refactor
    • Renamed the organization selection task key and related route from "org" and "add-organization" to "select-organization" for improved clarity and consistency in the user interface.
  • Tests
    • Updated test cases to align with the new task key and navigation path for organization selection.

@LauraBeatrisLauraBeatris self-assigned this Jul 21, 2025
@changeset-bot

changeset-botBot commented Jul 21, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c819cdc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
NameType
@clerk/clerk-jsPatch
@clerk/typesPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 21, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackJul 22, 2025 5:44pm

@LauraBeatris
LauraBeatris marked this pull request as ready for review July 21, 2025 23:19
@LauraBeatris
LauraBeatris requested a review from a teamJuly 21, 2025 23:19
@coderabbitai

coderabbitaiBot commented Jul 21, 2025

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This change updates the session task key related to organization handling throughout the codebase. The key value 'org' is renamed to 'select-organization' in the SessionTask interface, the INTERNAL_SESSION_TASK_ROUTE_BY_KEY mapping, and all related usages, including test mocks and route paths. The corresponding route value is also updated from 'add-organization' to 'select-organization'. All affected files are modified to reference the new key and route. No other logic, structure, or public API signatures are altered beyond this renaming.

Estimated code review effort

2 (~15 minutes)


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c3658b7 and c819cdc.

📒 Files selected for processing (5)
  • .changeset/wicked-meals-travel.md (1 hunks)
  • packages/clerk-js/src/core/__tests__/clerk.test.ts (3 hunks)
  • packages/clerk-js/src/core/sessionTasks.ts (1 hunks)
  • packages/clerk-js/src/ui/components/SessionTasks/index.tsx (1 hunks)
  • packages/types/src/session.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (5)
  • .changeset/wicked-meals-travel.md
  • packages/clerk-js/src/ui/components/SessionTasks/index.tsx
  • packages/types/src/session.ts
  • packages/clerk-js/src/core/sessionTasks.ts
  • packages/clerk-js/src/core/tests/clerk.test.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Build Packages
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pkg-pr-new

pkg-pr-newBot commented Jul 22, 2025

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6372

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6372

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6372

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6372

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6372

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6372

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6372

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6372

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6372

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6372

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6372

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6372

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6372

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6372

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6372

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6372

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6372

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6372

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6372

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6372

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6372

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6372

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6372

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6372

commit: c819cdc

@LauraBeatris

Copy link
Copy Markdown
ContributorAuthor

Tests are failing since we aren't expecting this new key from FAPI - it'll resolve once we deploy it.

@LauraBeatris
LauraBeatrisforce-pushed the laura/rename-task-key branch from c3658b7 to c819cdcCompareJuly 22, 2025 17:43
@LauraBeatris
LauraBeatris merged commit 43ea069 into mainJul 22, 2025
79 of 84 checks passed
@LauraBeatris
LauraBeatris deleted the laura/rename-task-key branch July 22, 2025 18:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@iagodahlem@clerk-cookie
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

chore(clerk-js): Rename org session task key to select-organization - #6372

Merged
LauraBeatris merged 1 commit into
mainfrom
laura/rename-task-key
Jul 22, 2025
Merged

chore(clerk-js): Rename org session task key to select-organization#6372
LauraBeatris merged 1 commit into
mainfrom
laura/rename-task-key

Conversation

@LauraBeatris

@LauraBeatrisLauraBeatris commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

Description

Waiting on API changes to be deployed first before merging this PR.https://github.com/clerk/clerk_go/pull/12757

It renames the session task key and all checks against it according to the latest FAPI nomenclature.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Refactor
    • Renamed the organization selection task key and related route from "org" and "add-organization" to "select-organization" for improved clarity and consistency in the user interface.
  • Tests
    • Updated test cases to align with the new task key and navigation path for organization selection.

@LauraBeatrisLauraBeatris self-assigned this Jul 21, 2025
@changeset-bot

changeset-botBot commented Jul 21, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c819cdc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
NameType
@clerk/clerk-jsPatch
@clerk/typesPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 21, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackJul 22, 2025 5:44pm

@LauraBeatris
LauraBeatris marked this pull request as ready for review July 21, 2025 23:19
@LauraBeatris
LauraBeatris requested a review from a teamJuly 21, 2025 23:19
@coderabbitai

coderabbitaiBot commented Jul 21, 2025

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This change updates the session task key related to organization handling throughout the codebase. The key value 'org' is renamed to 'select-organization' in the SessionTask interface, the INTERNAL_SESSION_TASK_ROUTE_BY_KEY mapping, and all related usages, including test mocks and route paths. The corresponding route value is also updated from 'add-organization' to 'select-organization'. All affected files are modified to reference the new key and route. No other logic, structure, or public API signatures are altered beyond this renaming.

Estimated code review effort

2 (~15 minutes)


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c3658b7 and c819cdc.

📒 Files selected for processing (5)
  • .changeset/wicked-meals-travel.md (1 hunks)
  • packages/clerk-js/src/core/__tests__/clerk.test.ts (3 hunks)
  • packages/clerk-js/src/core/sessionTasks.ts (1 hunks)
  • packages/clerk-js/src/ui/components/SessionTasks/index.tsx (1 hunks)
  • packages/types/src/session.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (5)
  • .changeset/wicked-meals-travel.md
  • packages/clerk-js/src/ui/components/SessionTasks/index.tsx
  • packages/types/src/session.ts
  • packages/clerk-js/src/core/sessionTasks.ts
  • packages/clerk-js/src/core/tests/clerk.test.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Build Packages
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pkg-pr-new

pkg-pr-newBot commented Jul 22, 2025

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6372

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6372

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6372

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6372

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6372

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6372

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6372

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6372

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6372

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6372

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6372

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6372

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6372

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6372

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6372

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6372

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6372

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6372

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6372

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6372

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6372

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6372

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6372

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6372

commit: c819cdc

@LauraBeatris

Copy link
Copy Markdown
ContributorAuthor

Tests are failing since we aren't expecting this new key from FAPI - it'll resolve once we deploy it.

@LauraBeatris
LauraBeatrisforce-pushed the laura/rename-task-key branch from c3658b7 to c819cdcCompareJuly 22, 2025 17:43
@LauraBeatris
LauraBeatris merged commit 43ea069 into mainJul 22, 2025
79 of 84 checks passed
@LauraBeatris
LauraBeatris deleted the laura/rename-task-key branch July 22, 2025 18:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@iagodahlem@clerk-cookie
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore(clerk-js): Rename org session task key to select-organization - #6372

Merged
LauraBeatris merged 1 commit into
mainfrom
laura/rename-task-key
Jul 22, 2025
Merged

chore(clerk-js): Rename org session task key to select-organization#6372
LauraBeatris merged 1 commit into
mainfrom
laura/rename-task-key

Conversation

@LauraBeatris

@LauraBeatrisLauraBeatris commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

Description

Waiting on API changes to be deployed first before merging this PR.https://github.com/clerk/clerk_go/pull/12757

It renames the session task key and all checks against it according to the latest FAPI nomenclature.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Refactor
    • Renamed the organization selection task key and related route from "org" and "add-organization" to "select-organization" for improved clarity and consistency in the user interface.
  • Tests
    • Updated test cases to align with the new task key and navigation path for organization selection.

@LauraBeatrisLauraBeatris self-assigned this Jul 21, 2025
@changeset-bot

changeset-botBot commented Jul 21, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c819cdc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
NameType
@clerk/clerk-jsPatch
@clerk/typesPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 21, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackJul 22, 2025 5:44pm

@LauraBeatris
LauraBeatris marked this pull request as ready for review July 21, 2025 23:19
@LauraBeatris
LauraBeatris requested a review from a teamJuly 21, 2025 23:19
@coderabbitai

coderabbitaiBot commented Jul 21, 2025

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This change updates the session task key related to organization handling throughout the codebase. The key value 'org' is renamed to 'select-organization' in the SessionTask interface, the INTERNAL_SESSION_TASK_ROUTE_BY_KEY mapping, and all related usages, including test mocks and route paths. The corresponding route value is also updated from 'add-organization' to 'select-organization'. All affected files are modified to reference the new key and route. No other logic, structure, or public API signatures are altered beyond this renaming.

Estimated code review effort

2 (~15 minutes)


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c3658b7 and c819cdc.

📒 Files selected for processing (5)
  • .changeset/wicked-meals-travel.md (1 hunks)
  • packages/clerk-js/src/core/__tests__/clerk.test.ts (3 hunks)
  • packages/clerk-js/src/core/sessionTasks.ts (1 hunks)
  • packages/clerk-js/src/ui/components/SessionTasks/index.tsx (1 hunks)
  • packages/types/src/session.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (5)
  • .changeset/wicked-meals-travel.md
  • packages/clerk-js/src/ui/components/SessionTasks/index.tsx
  • packages/types/src/session.ts
  • packages/clerk-js/src/core/sessionTasks.ts
  • packages/clerk-js/src/core/tests/clerk.test.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Build Packages
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pkg-pr-new

pkg-pr-newBot commented Jul 22, 2025

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6372

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6372

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6372

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6372

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6372

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6372

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6372

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6372

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6372

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6372

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6372

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6372

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6372

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6372

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6372

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6372

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6372

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6372

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6372

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6372

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6372

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6372

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6372

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6372

commit: c819cdc

@LauraBeatris

Copy link
Copy Markdown
ContributorAuthor

Tests are failing since we aren't expecting this new key from FAPI - it'll resolve once we deploy it.

@LauraBeatris
LauraBeatrisforce-pushed the laura/rename-task-key branch from c3658b7 to c819cdcCompareJuly 22, 2025 17:43
@LauraBeatris
LauraBeatris merged commit 43ea069 into mainJul 22, 2025
79 of 84 checks passed
@LauraBeatris
LauraBeatris deleted the laura/rename-task-key branch July 22, 2025 18:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@iagodahlem@clerk-cookie
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore(clerk-js): Rename org session task key to select-organization - #6372

Merged
LauraBeatris merged 1 commit into
mainfrom
laura/rename-task-key
Jul 22, 2025
Merged

chore(clerk-js): Rename org session task key to select-organization#6372
LauraBeatris merged 1 commit into
mainfrom
laura/rename-task-key

Conversation

@LauraBeatris

@LauraBeatrisLauraBeatris commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

Description

Waiting on API changes to be deployed first before merging this PR.https://github.com/clerk/clerk_go/pull/12757

It renames the session task key and all checks against it according to the latest FAPI nomenclature.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Refactor
    • Renamed the organization selection task key and related route from "org" and "add-organization" to "select-organization" for improved clarity and consistency in the user interface.
  • Tests
    • Updated test cases to align with the new task key and navigation path for organization selection.

@LauraBeatrisLauraBeatris self-assigned this Jul 21, 2025
@changeset-bot

changeset-botBot commented Jul 21, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c819cdc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
NameType
@clerk/clerk-jsPatch
@clerk/typesPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 21, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackJul 22, 2025 5:44pm

@LauraBeatris
LauraBeatris marked this pull request as ready for review July 21, 2025 23:19
@LauraBeatris
LauraBeatris requested a review from a teamJuly 21, 2025 23:19
@coderabbitai

coderabbitaiBot commented Jul 21, 2025

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This change updates the session task key related to organization handling throughout the codebase. The key value 'org' is renamed to 'select-organization' in the SessionTask interface, the INTERNAL_SESSION_TASK_ROUTE_BY_KEY mapping, and all related usages, including test mocks and route paths. The corresponding route value is also updated from 'add-organization' to 'select-organization'. All affected files are modified to reference the new key and route. No other logic, structure, or public API signatures are altered beyond this renaming.

Estimated code review effort

2 (~15 minutes)


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c3658b7 and c819cdc.

📒 Files selected for processing (5)
  • .changeset/wicked-meals-travel.md (1 hunks)
  • packages/clerk-js/src/core/__tests__/clerk.test.ts (3 hunks)
  • packages/clerk-js/src/core/sessionTasks.ts (1 hunks)
  • packages/clerk-js/src/ui/components/SessionTasks/index.tsx (1 hunks)
  • packages/types/src/session.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (5)
  • .changeset/wicked-meals-travel.md
  • packages/clerk-js/src/ui/components/SessionTasks/index.tsx
  • packages/types/src/session.ts
  • packages/clerk-js/src/core/sessionTasks.ts
  • packages/clerk-js/src/core/tests/clerk.test.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Build Packages
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pkg-pr-new

pkg-pr-newBot commented Jul 22, 2025

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6372

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6372

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6372

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6372

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6372

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6372

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6372

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6372

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6372

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6372

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6372

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6372

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6372

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6372

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6372

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6372

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6372

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6372

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6372

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6372

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6372

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6372

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6372

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6372

commit: c819cdc

@LauraBeatris

Copy link
Copy Markdown
ContributorAuthor

Tests are failing since we aren't expecting this new key from FAPI - it'll resolve once we deploy it.

@LauraBeatris
LauraBeatrisforce-pushed the laura/rename-task-key branch from c3658b7 to c819cdcCompareJuly 22, 2025 17:43
@LauraBeatris
LauraBeatris merged commit 43ea069 into mainJul 22, 2025
79 of 84 checks passed
@LauraBeatris
LauraBeatris deleted the laura/rename-task-key branch July 22, 2025 18:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@iagodahlem@clerk-cookie
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

chore(clerk-js): Rename org session task key to select-organization - #6372

Merged
LauraBeatris merged 1 commit into
mainfrom
laura/rename-task-key
Jul 22, 2025
Merged

chore(clerk-js): Rename org session task key to select-organization#6372
LauraBeatris merged 1 commit into
mainfrom
laura/rename-task-key

Conversation

@LauraBeatris

@LauraBeatrisLauraBeatris commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

Description

Waiting on API changes to be deployed first before merging this PR.https://github.com/clerk/clerk_go/pull/12757

It renames the session task key and all checks against it according to the latest FAPI nomenclature.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Refactor
    • Renamed the organization selection task key and related route from "org" and "add-organization" to "select-organization" for improved clarity and consistency in the user interface.
  • Tests
    • Updated test cases to align with the new task key and navigation path for organization selection.

@LauraBeatrisLauraBeatris self-assigned this Jul 21, 2025
@changeset-bot

changeset-botBot commented Jul 21, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c819cdc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
NameType
@clerk/clerk-jsPatch
@clerk/typesPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 21, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackJul 22, 2025 5:44pm

@LauraBeatris
LauraBeatris marked this pull request as ready for review July 21, 2025 23:19
@LauraBeatris
LauraBeatris requested a review from a teamJuly 21, 2025 23:19
@coderabbitai

coderabbitaiBot commented Jul 21, 2025

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This change updates the session task key related to organization handling throughout the codebase. The key value 'org' is renamed to 'select-organization' in the SessionTask interface, the INTERNAL_SESSION_TASK_ROUTE_BY_KEY mapping, and all related usages, including test mocks and route paths. The corresponding route value is also updated from 'add-organization' to 'select-organization'. All affected files are modified to reference the new key and route. No other logic, structure, or public API signatures are altered beyond this renaming.

Estimated code review effort

2 (~15 minutes)


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c3658b7 and c819cdc.

📒 Files selected for processing (5)
  • .changeset/wicked-meals-travel.md (1 hunks)
  • packages/clerk-js/src/core/__tests__/clerk.test.ts (3 hunks)
  • packages/clerk-js/src/core/sessionTasks.ts (1 hunks)
  • packages/clerk-js/src/ui/components/SessionTasks/index.tsx (1 hunks)
  • packages/types/src/session.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (5)
  • .changeset/wicked-meals-travel.md
  • packages/clerk-js/src/ui/components/SessionTasks/index.tsx
  • packages/types/src/session.ts
  • packages/clerk-js/src/core/sessionTasks.ts
  • packages/clerk-js/src/core/tests/clerk.test.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Build Packages
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pkg-pr-new

pkg-pr-newBot commented Jul 22, 2025

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6372

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6372

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6372

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6372

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6372

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6372

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6372

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6372

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6372

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6372

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6372

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6372

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6372

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6372

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6372

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6372

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6372

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6372

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6372

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6372

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6372

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6372

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6372

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6372

commit: c819cdc

@LauraBeatris

Copy link
Copy Markdown
ContributorAuthor

Tests are failing since we aren't expecting this new key from FAPI - it'll resolve once we deploy it.

@LauraBeatris
LauraBeatrisforce-pushed the laura/rename-task-key branch from c3658b7 to c819cdcCompareJuly 22, 2025 17:43
@LauraBeatris
LauraBeatris merged commit 43ea069 into mainJul 22, 2025
79 of 84 checks passed
@LauraBeatris
LauraBeatris deleted the laura/rename-task-key branch July 22, 2025 18:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@iagodahlem@clerk-cookie
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore(clerk-js): Rename org session task key to select-organization - #6372

Merged
LauraBeatris merged 1 commit into
mainfrom
laura/rename-task-key
Jul 22, 2025
Merged

chore(clerk-js): Rename org session task key to select-organization#6372
LauraBeatris merged 1 commit into
mainfrom
laura/rename-task-key

Conversation

@LauraBeatris

@LauraBeatrisLauraBeatris commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

Description

Waiting on API changes to be deployed first before merging this PR.https://github.com/clerk/clerk_go/pull/12757

It renames the session task key and all checks against it according to the latest FAPI nomenclature.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Refactor
    • Renamed the organization selection task key and related route from "org" and "add-organization" to "select-organization" for improved clarity and consistency in the user interface.
  • Tests
    • Updated test cases to align with the new task key and navigation path for organization selection.

@LauraBeatrisLauraBeatris self-assigned this Jul 21, 2025
@changeset-bot

changeset-botBot commented Jul 21, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c819cdc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
NameType
@clerk/clerk-jsPatch
@clerk/typesPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 21, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackJul 22, 2025 5:44pm

@LauraBeatris
LauraBeatris marked this pull request as ready for review July 21, 2025 23:19
@LauraBeatris
LauraBeatris requested a review from a teamJuly 21, 2025 23:19
@coderabbitai

coderabbitaiBot commented Jul 21, 2025

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This change updates the session task key related to organization handling throughout the codebase. The key value 'org' is renamed to 'select-organization' in the SessionTask interface, the INTERNAL_SESSION_TASK_ROUTE_BY_KEY mapping, and all related usages, including test mocks and route paths. The corresponding route value is also updated from 'add-organization' to 'select-organization'. All affected files are modified to reference the new key and route. No other logic, structure, or public API signatures are altered beyond this renaming.

Estimated code review effort

2 (~15 minutes)


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c3658b7 and c819cdc.

📒 Files selected for processing (5)
  • .changeset/wicked-meals-travel.md (1 hunks)
  • packages/clerk-js/src/core/__tests__/clerk.test.ts (3 hunks)
  • packages/clerk-js/src/core/sessionTasks.ts (1 hunks)
  • packages/clerk-js/src/ui/components/SessionTasks/index.tsx (1 hunks)
  • packages/types/src/session.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (5)
  • .changeset/wicked-meals-travel.md
  • packages/clerk-js/src/ui/components/SessionTasks/index.tsx
  • packages/types/src/session.ts
  • packages/clerk-js/src/core/sessionTasks.ts
  • packages/clerk-js/src/core/tests/clerk.test.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Build Packages
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pkg-pr-new

pkg-pr-newBot commented Jul 22, 2025

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6372

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6372

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6372

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6372

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6372

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6372

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6372

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6372

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6372

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6372

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6372

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6372

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6372

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6372

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6372

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6372

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6372

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6372

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6372

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6372

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6372

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6372

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6372

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6372

commit: c819cdc

@LauraBeatris

Copy link
Copy Markdown
ContributorAuthor

Tests are failing since we aren't expecting this new key from FAPI - it'll resolve once we deploy it.

@LauraBeatris
LauraBeatrisforce-pushed the laura/rename-task-key branch from c3658b7 to c819cdcCompareJuly 22, 2025 17:43
@LauraBeatris
LauraBeatris merged commit 43ea069 into mainJul 22, 2025
79 of 84 checks passed
@LauraBeatris
LauraBeatris deleted the laura/rename-task-key branch July 22, 2025 18:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@iagodahlem@clerk-cookie
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore(clerk-js): Rename org session task key to select-organization - #6372

Merged
LauraBeatris merged 1 commit into
mainfrom
laura/rename-task-key
Jul 22, 2025
Merged

chore(clerk-js): Rename org session task key to select-organization#6372
LauraBeatris merged 1 commit into
mainfrom
laura/rename-task-key

Conversation

@LauraBeatris

@LauraBeatrisLauraBeatris commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

Description

Waiting on API changes to be deployed first before merging this PR.https://github.com/clerk/clerk_go/pull/12757

It renames the session task key and all checks against it according to the latest FAPI nomenclature.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Refactor
    • Renamed the organization selection task key and related route from "org" and "add-organization" to "select-organization" for improved clarity and consistency in the user interface.
  • Tests
    • Updated test cases to align with the new task key and navigation path for organization selection.

@LauraBeatrisLauraBeatris self-assigned this Jul 21, 2025
@changeset-bot

changeset-botBot commented Jul 21, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c819cdc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
NameType
@clerk/clerk-jsPatch
@clerk/typesPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 21, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackJul 22, 2025 5:44pm

@LauraBeatris
LauraBeatris marked this pull request as ready for review July 21, 2025 23:19
@LauraBeatris
LauraBeatris requested a review from a teamJuly 21, 2025 23:19
@coderabbitai

coderabbitaiBot commented Jul 21, 2025

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This change updates the session task key related to organization handling throughout the codebase. The key value 'org' is renamed to 'select-organization' in the SessionTask interface, the INTERNAL_SESSION_TASK_ROUTE_BY_KEY mapping, and all related usages, including test mocks and route paths. The corresponding route value is also updated from 'add-organization' to 'select-organization'. All affected files are modified to reference the new key and route. No other logic, structure, or public API signatures are altered beyond this renaming.

Estimated code review effort

2 (~15 minutes)


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c3658b7 and c819cdc.

📒 Files selected for processing (5)
  • .changeset/wicked-meals-travel.md (1 hunks)
  • packages/clerk-js/src/core/__tests__/clerk.test.ts (3 hunks)
  • packages/clerk-js/src/core/sessionTasks.ts (1 hunks)
  • packages/clerk-js/src/ui/components/SessionTasks/index.tsx (1 hunks)
  • packages/types/src/session.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (5)
  • .changeset/wicked-meals-travel.md
  • packages/clerk-js/src/ui/components/SessionTasks/index.tsx
  • packages/types/src/session.ts
  • packages/clerk-js/src/core/sessionTasks.ts
  • packages/clerk-js/src/core/tests/clerk.test.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Build Packages
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pkg-pr-new

pkg-pr-newBot commented Jul 22, 2025

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6372

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6372

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6372

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6372

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6372

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6372

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6372

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6372

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6372

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6372

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6372

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6372

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6372

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6372

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6372

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6372

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6372

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6372

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6372

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6372

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6372

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6372

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6372

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6372

commit: c819cdc

@LauraBeatris

Copy link
Copy Markdown
ContributorAuthor

Tests are failing since we aren't expecting this new key from FAPI - it'll resolve once we deploy it.

@LauraBeatris
LauraBeatrisforce-pushed the laura/rename-task-key branch from c3658b7 to c819cdcCompareJuly 22, 2025 17:43
@LauraBeatris
LauraBeatris merged commit 43ea069 into mainJul 22, 2025
79 of 84 checks passed
@LauraBeatris
LauraBeatris deleted the laura/rename-task-key branch July 22, 2025 18:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@iagodahlem@clerk-cookie
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

chore(clerk-js): Rename org session task key to select-organization - #6372

Merged
LauraBeatris merged 1 commit into
mainfrom
laura/rename-task-key
Jul 22, 2025
Merged

chore(clerk-js): Rename org session task key to select-organization#6372
LauraBeatris merged 1 commit into
mainfrom
laura/rename-task-key

Conversation

@LauraBeatris

@LauraBeatrisLauraBeatris commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

Description

Waiting on API changes to be deployed first before merging this PR.https://github.com/clerk/clerk_go/pull/12757

It renames the session task key and all checks against it according to the latest FAPI nomenclature.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Refactor
    • Renamed the organization selection task key and related route from "org" and "add-organization" to "select-organization" for improved clarity and consistency in the user interface.
  • Tests
    • Updated test cases to align with the new task key and navigation path for organization selection.

@LauraBeatrisLauraBeatris self-assigned this Jul 21, 2025
@changeset-bot

changeset-botBot commented Jul 21, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c819cdc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
NameType
@clerk/clerk-jsPatch
@clerk/typesPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 21, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackJul 22, 2025 5:44pm

@LauraBeatris
LauraBeatris marked this pull request as ready for review July 21, 2025 23:19
@LauraBeatris
LauraBeatris requested a review from a teamJuly 21, 2025 23:19
@coderabbitai

coderabbitaiBot commented Jul 21, 2025

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This change updates the session task key related to organization handling throughout the codebase. The key value 'org' is renamed to 'select-organization' in the SessionTask interface, the INTERNAL_SESSION_TASK_ROUTE_BY_KEY mapping, and all related usages, including test mocks and route paths. The corresponding route value is also updated from 'add-organization' to 'select-organization'. All affected files are modified to reference the new key and route. No other logic, structure, or public API signatures are altered beyond this renaming.

Estimated code review effort

2 (~15 minutes)


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c3658b7 and c819cdc.

📒 Files selected for processing (5)
  • .changeset/wicked-meals-travel.md (1 hunks)
  • packages/clerk-js/src/core/__tests__/clerk.test.ts (3 hunks)
  • packages/clerk-js/src/core/sessionTasks.ts (1 hunks)
  • packages/clerk-js/src/ui/components/SessionTasks/index.tsx (1 hunks)
  • packages/types/src/session.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (5)
  • .changeset/wicked-meals-travel.md
  • packages/clerk-js/src/ui/components/SessionTasks/index.tsx
  • packages/types/src/session.ts
  • packages/clerk-js/src/core/sessionTasks.ts
  • packages/clerk-js/src/core/tests/clerk.test.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Build Packages
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pkg-pr-new

pkg-pr-newBot commented Jul 22, 2025

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6372

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6372

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6372

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6372

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6372

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6372

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6372

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6372

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6372

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6372

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6372

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6372

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6372

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6372

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6372

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6372

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6372

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6372

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6372

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6372

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6372

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6372

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6372

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6372

commit: c819cdc

@LauraBeatris

Copy link
Copy Markdown
ContributorAuthor

Tests are failing since we aren't expecting this new key from FAPI - it'll resolve once we deploy it.

@LauraBeatris
LauraBeatrisforce-pushed the laura/rename-task-key branch from c3658b7 to c819cdcCompareJuly 22, 2025 17:43
@LauraBeatris
LauraBeatris merged commit 43ea069 into mainJul 22, 2025
79 of 84 checks passed
@LauraBeatris
LauraBeatris deleted the laura/rename-task-key branch July 22, 2025 18:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@iagodahlem@clerk-cookie