Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/whole-knives-attend.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
---
'@clerk/clerk-js': patch
'@clerk/types': patch
---
Comment thread
LauraBeatris marked this conversation as resolved.

Add `taskUrls` option to customize task flow URLs:

```tsx
<ClerkProvider
taskUrls={{
'org': '/my-custom-org-selector'
}}
/>
```
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,6 +106,7 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/server-get-token.mdx",
"types/session-resource.mdx",
"types/session-status-claim.mdx",
"types/session-task.mdx",
"types/session-verification-level.mdx",
"types/session-verification-types.mdx",
"types/set-active-params.mdx",
Expand Down
21 changes: 18 additions & 3 deletions packages/clerk-js/src/core/__tests__/clerk.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2331,7 +2331,7 @@ describe('Clerk singleton', () => {
});
});

describe('nextTask', () => {
describe('navigateToTask', () => {
describe('with `pending` session status', () => {
const mockSession = {
id: '1',
Expand All@@ -2350,7 +2350,7 @@ describe('Clerk singleton', () => {
reload: jest.fn(() => Promise.resolve(mockSession)),
};

beforeAll(() => {
beforeEach(() => {
mockResource.touch.mockReturnValueOnce(Promise.resolve());
mockClientFetch.mockReturnValue(Promise.resolve({ signedInSessions: [mockResource] }));
});
Expand All@@ -2360,7 +2360,7 @@ describe('Clerk singleton', () => {
mockResource.touch.mockReset();
});

it('navigates to next task', async () => {
it('navigates to next task with default internal routing for AIOs', async () => {
const sut = new Clerk(productionPublishableKey);
await sut.load(mockedLoadOptions);

Expand All@@ -2369,6 +2369,21 @@ describe('Clerk singleton', () => {

expect(mockNavigate.mock.calls[0][0]).toBe('/sign-in#/tasks/add-organization');
});

it('navigates to next task with custom routing from clerk options', async () => {
const sut = new Clerk(productionPublishableKey);
await sut.load({
...mockedLoadOptions,
taskUrls: {
org: '/onboarding/select-organization',
},
});

await sut.setActive({ session: mockResource as any as PendingSessionResource });
await sut.__internal_navigateToTaskIfAvailable();

expect(mockNavigate.mock.calls[0][0]).toBe('/onboarding/select-organization');
});
});

describe('with `active` session status', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1317,7 +1317,7 @@ export class Clerk implements ClerkInterface {
eventBus.emit(events.TokenUpdate, { token: null });
}

// Only triggers navigation for internal AIO components routing
// Only triggers navigation for internal AIO components routing or custom URLs
const shouldNavigateOnSetActive = this.#componentNavigationContext;
if (newSession?.currentTask && shouldNavigateOnSetActive) {
await navigateToTask(session.currentTask.key, {
Expand Down
9 changes: 4 additions & 5 deletions packages/clerk-js/src/core/sessionTasks.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@ import type {

import { buildURL } from '../utils';

export const SESSION_TASK_ROUTE_BY_KEY: Record<SessionTask['key'], string> = {
export const INTERNAL_SESSION_TASK_ROUTE_BY_KEY: Record<SessionTask['key'], string> = {
org: 'add-organization',
} as const;

Expand All@@ -24,10 +24,10 @@ interface NavigateToTaskOptions {
* @internal
*/
export function navigateToTask(
routeKey: keyof typeof SESSION_TASK_ROUTE_BY_KEY,
routeKey: keyof typeof INTERNAL_SESSION_TASK_ROUTE_BY_KEY,
{ componentNavigationContext, globalNavigate, options, environment }: NavigateToTaskOptions,
) {
const taskRoute = `/tasks/${SESSION_TASK_ROUTE_BY_KEY[routeKey]}`;
const taskRoute = `/tasks/${INTERNAL_SESSION_TASK_ROUTE_BY_KEY[routeKey]}`;

if (componentNavigationContext) {
return componentNavigationContext.navigate(componentNavigationContext.indexPath + taskRoute);
Expand All@@ -38,13 +38,12 @@ export function navigateToTask(
const isReferrerSignUpUrl = window.location.href.startsWith(signUpUrl);

const sessionTaskUrl = buildURL(
// TODO - Accept custom URL option for custom flows in order to eject out of `signInUrl/signUpUrl`
{
base: isReferrerSignUpUrl ? signUpUrl : signInUrl,
hashPath: taskRoute,
},
{ stringify: true },
);

return globalNavigate(sessionTaskUrl);
return globalNavigate(options.taskUrls?.[routeKey] ?? sessionTaskUrl);
}
23 changes: 14 additions & 9 deletions packages/clerk-js/src/ui/common/redirects.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import type { SessionTask } from '@clerk/types';
import type { ClerkOptions, SessionTask } from '@clerk/types';

import { SESSION_TASK_ROUTE_BY_KEY } from '../../core/sessionTasks';
import { INTERNAL_SESSION_TASK_ROUTE_BY_KEY } from '../../core/sessionTasks';
import { buildURL } from '../../utils/url';
import type { SignInContextType, SignUpContextType, UserProfileContextType } from './../contexts';

Expand DownExpand Up@@ -33,21 +33,26 @@ export function buildSessionTaskRedirectUrl({
path,
baseUrl,
task,
taskUrls,
}: Pick<SignInContextType | SignUpContextType, 'routing' | 'path'> & {
baseUrl: string;
task?: SessionTask;
taskUrls?: ClerkOptions['taskUrls'];
}) {
if (!task) {
return null;
}

return buildRedirectUrl({
routing,
baseUrl,
path,
endpoint: `/tasks/${SESSION_TASK_ROUTE_BY_KEY[task.key]}`,
authQueryString: null,
});
return (
taskUrls?.[task.key] ??
buildRedirectUrl({
routing,
baseUrl,
path,
endpoint: `/tasks/${INTERNAL_SESSION_TASK_ROUTE_BY_KEY[task.key]}`,
authQueryString: null,
})
);
}

export function buildSSOCallbackURL(
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/ui/components/SessionTasks/index.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@ import { Card } from '@/ui/elements/Card';
import { withCardStateProvider } from '@/ui/elements/contexts';
import { LoadingCardContainer } from '@/ui/elements/LoadingCard';

import { SESSION_TASK_ROUTE_BY_KEY } from '../../../core/sessionTasks';
import { INTERNAL_SESSION_TASK_ROUTE_BY_KEY } from '../../../core/sessionTasks';
import { SignInContext, SignUpContext } from '../../../ui/contexts';
import { SessionTasksContext, useSessionTasksContext } from '../../contexts/components/SessionTasks';
import { Route, Switch, useRouter } from '../../router';
Expand DownExpand Up@@ -38,7 +38,7 @@ const SessionTasksStart = () => {
function SessionTaskRoutes(): JSX.Element {
return (
<Switch>
<Route path={SESSION_TASK_ROUTE_BY_KEY['org']}>
<Route path={INTERNAL_SESSION_TASK_ROUTE_BY_KEY['org']}>
<ForceOrganizationSelectionTask />
</Route>
<Route index>
Expand Down
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/contexts/components/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -126,6 +126,7 @@ export const useSignInContext = (): SignInContextType => {
path: ctx.path,
routing: ctx.routing,
baseUrl: signInUrl,
taskUrls: clerk.__internal_getOption('taskUrls'),
});

return {
Expand Down
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/contexts/components/SignUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -121,6 +121,7 @@ export const useSignUpContext = (): SignUpContextType => {
path: ctx.path,
routing: ctx.routing,
baseUrl: signUpUrl,
taskUrls: clerk.__internal_getOption('taskUrls'),
});

return {
Expand Down
10 changes: 9 additions & 1 deletion packages/types/src/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,7 @@
SignUpFallbackRedirectUrl,
SignUpForceRedirectUrl,
} from './redirects';
import type { PendingSessionOptions, SignedInSessionResource } from './session';
import type { PendingSessionOptions, SessionTask, SignedInSessionResource } from './session';
import type { SessionVerificationLevel } from './sessionVerification';
import type { SignInResource } from './signIn';
import type { SignUpResource } from './signUp';
Expand DownExpand Up@@ -1050,6 +1050,14 @@
* @internal
*/
__internal_keyless_dismissPrompt?: (() => Promise<void>) | null;

/**
* Customize the URL paths users are redirected to after sign-in or sign-up when specific
* session tasks need to be completed.
*
* @default undefined - Uses Clerk's default task flow URLs
*/
taskUrls?: Record<SessionTask['key'], string>;
};

export interface NavigateOptions {
Expand DownExpand Up@@ -1114,7 +1122,7 @@
*/
windowNavigate: (to: URL | string) => void;
},
) => Promise<unknown> | unknown;

Check warning on line 1125 in packages/types/src/clerk.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

'unknown' overrides all other types in this union type

export type WithoutRouting<T> = Omit<T, 'path' | 'routing'>;

Expand Down
7 changes: 7 additions & 0 deletions packages/types/src/session.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -326,7 +326,14 @@ export interface PublicUserData {
userId?: string;
}

/**
* Represents a required action that a user must complete
* before their session becomes fully active
*/
export interface SessionTask {
/**
* The unique identifier for the type of task that needs to be completed
*/
key: 'org';
}

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/whole-knives-attend.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
---
'@clerk/clerk-js': patch
'@clerk/types': patch
---
Comment thread
LauraBeatris marked this conversation as resolved.

Add `taskUrls` option to customize task flow URLs:

```tsx
<ClerkProvider
taskUrls={{
'org': '/my-custom-org-selector'
}}
/>
```
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,6 +106,7 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/server-get-token.mdx",
"types/session-resource.mdx",
"types/session-status-claim.mdx",
"types/session-task.mdx",
"types/session-verification-level.mdx",
"types/session-verification-types.mdx",
"types/set-active-params.mdx",
Expand Down
21 changes: 18 additions & 3 deletions packages/clerk-js/src/core/__tests__/clerk.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2331,7 +2331,7 @@ describe('Clerk singleton', () => {
});
});

describe('nextTask', () => {
describe('navigateToTask', () => {
describe('with `pending` session status', () => {
const mockSession = {
id: '1',
Expand All@@ -2350,7 +2350,7 @@ describe('Clerk singleton', () => {
reload: jest.fn(() => Promise.resolve(mockSession)),
};

beforeAll(() => {
beforeEach(() => {
mockResource.touch.mockReturnValueOnce(Promise.resolve());
mockClientFetch.mockReturnValue(Promise.resolve({ signedInSessions: [mockResource] }));
});
Expand All@@ -2360,7 +2360,7 @@ describe('Clerk singleton', () => {
mockResource.touch.mockReset();
});

it('navigates to next task', async () => {
it('navigates to next task with default internal routing for AIOs', async () => {
const sut = new Clerk(productionPublishableKey);
await sut.load(mockedLoadOptions);

Expand All@@ -2369,6 +2369,21 @@ describe('Clerk singleton', () => {

expect(mockNavigate.mock.calls[0][0]).toBe('/sign-in#/tasks/add-organization');
});

it('navigates to next task with custom routing from clerk options', async () => {
const sut = new Clerk(productionPublishableKey);
await sut.load({
...mockedLoadOptions,
taskUrls: {
org: '/onboarding/select-organization',
},
});

await sut.setActive({ session: mockResource as any as PendingSessionResource });
await sut.__internal_navigateToTaskIfAvailable();

expect(mockNavigate.mock.calls[0][0]).toBe('/onboarding/select-organization');
});
});

describe('with `active` session status', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1317,7 +1317,7 @@ export class Clerk implements ClerkInterface {
eventBus.emit(events.TokenUpdate, { token: null });
}

// Only triggers navigation for internal AIO components routing
// Only triggers navigation for internal AIO components routing or custom URLs
const shouldNavigateOnSetActive = this.#componentNavigationContext;
if (newSession?.currentTask && shouldNavigateOnSetActive) {
await navigateToTask(session.currentTask.key, {
Expand Down
9 changes: 4 additions & 5 deletions packages/clerk-js/src/core/sessionTasks.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@ import type {

import { buildURL } from '../utils';

export const SESSION_TASK_ROUTE_BY_KEY: Record<SessionTask['key'], string> = {
export const INTERNAL_SESSION_TASK_ROUTE_BY_KEY: Record<SessionTask['key'], string> = {
org: 'add-organization',
} as const;

Expand All@@ -24,10 +24,10 @@ interface NavigateToTaskOptions {
* @internal
*/
export function navigateToTask(
routeKey: keyof typeof SESSION_TASK_ROUTE_BY_KEY,
routeKey: keyof typeof INTERNAL_SESSION_TASK_ROUTE_BY_KEY,
{ componentNavigationContext, globalNavigate, options, environment }: NavigateToTaskOptions,
) {
const taskRoute = `/tasks/${SESSION_TASK_ROUTE_BY_KEY[routeKey]}`;
const taskRoute = `/tasks/${INTERNAL_SESSION_TASK_ROUTE_BY_KEY[routeKey]}`;

if (componentNavigationContext) {
return componentNavigationContext.navigate(componentNavigationContext.indexPath + taskRoute);
Expand All@@ -38,13 +38,12 @@ export function navigateToTask(
const isReferrerSignUpUrl = window.location.href.startsWith(signUpUrl);

const sessionTaskUrl = buildURL(
// TODO - Accept custom URL option for custom flows in order to eject out of `signInUrl/signUpUrl`
{
base: isReferrerSignUpUrl ? signUpUrl : signInUrl,
hashPath: taskRoute,
},
{ stringify: true },
);

return globalNavigate(sessionTaskUrl);
return globalNavigate(options.taskUrls?.[routeKey] ?? sessionTaskUrl);
}
23 changes: 14 additions & 9 deletions packages/clerk-js/src/ui/common/redirects.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import type { SessionTask } from '@clerk/types';
import type { ClerkOptions, SessionTask } from '@clerk/types';

import { SESSION_TASK_ROUTE_BY_KEY } from '../../core/sessionTasks';
import { INTERNAL_SESSION_TASK_ROUTE_BY_KEY } from '../../core/sessionTasks';
import { buildURL } from '../../utils/url';
import type { SignInContextType, SignUpContextType, UserProfileContextType } from './../contexts';

Expand DownExpand Up@@ -33,21 +33,26 @@ export function buildSessionTaskRedirectUrl({
path,
baseUrl,
task,
taskUrls,
}: Pick<SignInContextType | SignUpContextType, 'routing' | 'path'> & {
baseUrl: string;
task?: SessionTask;
taskUrls?: ClerkOptions['taskUrls'];
}) {
if (!task) {
return null;
}

return buildRedirectUrl({
routing,
baseUrl,
path,
endpoint: `/tasks/${SESSION_TASK_ROUTE_BY_KEY[task.key]}`,
authQueryString: null,
});
return (
taskUrls?.[task.key] ??
buildRedirectUrl({
routing,
baseUrl,
path,
endpoint: `/tasks/${INTERNAL_SESSION_TASK_ROUTE_BY_KEY[task.key]}`,
authQueryString: null,
})
);
}

export function buildSSOCallbackURL(
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/ui/components/SessionTasks/index.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@ import { Card } from '@/ui/elements/Card';
import { withCardStateProvider } from '@/ui/elements/contexts';
import { LoadingCardContainer } from '@/ui/elements/LoadingCard';

import { SESSION_TASK_ROUTE_BY_KEY } from '../../../core/sessionTasks';
import { INTERNAL_SESSION_TASK_ROUTE_BY_KEY } from '../../../core/sessionTasks';
import { SignInContext, SignUpContext } from '../../../ui/contexts';
import { SessionTasksContext, useSessionTasksContext } from '../../contexts/components/SessionTasks';
import { Route, Switch, useRouter } from '../../router';
Expand DownExpand Up@@ -38,7 +38,7 @@ const SessionTasksStart = () => {
function SessionTaskRoutes(): JSX.Element {
return (
<Switch>
<Route path={SESSION_TASK_ROUTE_BY_KEY['org']}>
<Route path={INTERNAL_SESSION_TASK_ROUTE_BY_KEY['org']}>
<ForceOrganizationSelectionTask />
</Route>
<Route index>
Expand Down
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/contexts/components/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -126,6 +126,7 @@ export const useSignInContext = (): SignInContextType => {
path: ctx.path,
routing: ctx.routing,
baseUrl: signInUrl,
taskUrls: clerk.__internal_getOption('taskUrls'),
});

return {
Expand Down
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/contexts/components/SignUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -121,6 +121,7 @@ export const useSignUpContext = (): SignUpContextType => {
path: ctx.path,
routing: ctx.routing,
baseUrl: signUpUrl,
taskUrls: clerk.__internal_getOption('taskUrls'),
});

return {
Expand Down
10 changes: 9 additions & 1 deletion packages/types/src/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,7 @@
SignUpFallbackRedirectUrl,
SignUpForceRedirectUrl,
} from './redirects';
import type { PendingSessionOptions, SignedInSessionResource } from './session';
import type { PendingSessionOptions, SessionTask, SignedInSessionResource } from './session';
import type { SessionVerificationLevel } from './sessionVerification';
import type { SignInResource } from './signIn';
import type { SignUpResource } from './signUp';
Expand DownExpand Up@@ -1050,6 +1050,14 @@
* @internal
*/
__internal_keyless_dismissPrompt?: (() => Promise<void>) | null;

/**
* Customize the URL paths users are redirected to after sign-in or sign-up when specific
* session tasks need to be completed.
*
* @default undefined - Uses Clerk's default task flow URLs
*/
taskUrls?: Record<SessionTask['key'], string>;
};

export interface NavigateOptions {
Expand DownExpand Up@@ -1114,7 +1122,7 @@
*/
windowNavigate: (to: URL | string) => void;
},
) => Promise<unknown> | unknown;

Check warning on line 1125 in packages/types/src/clerk.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

'unknown' overrides all other types in this union type

export type WithoutRouting<T> = Omit<T, 'path' | 'routing'>;

Expand Down
7 changes: 7 additions & 0 deletions packages/types/src/session.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -326,7 +326,14 @@ export interface PublicUserData {
userId?: string;
}

/**
* Represents a required action that a user must complete
* before their session becomes fully active
*/
export interface SessionTask {
/**
* The unique identifier for the type of task that needs to be completed
*/
key: 'org';
}

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/whole-knives-attend.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
---
'@clerk/clerk-js': patch
'@clerk/types': patch
---
Comment thread
LauraBeatris marked this conversation as resolved.

Add `taskUrls` option to customize task flow URLs:

```tsx
<ClerkProvider
taskUrls={{
'org': '/my-custom-org-selector'
}}
/>
```
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,6 +106,7 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/server-get-token.mdx",
"types/session-resource.mdx",
"types/session-status-claim.mdx",
"types/session-task.mdx",
"types/session-verification-level.mdx",
"types/session-verification-types.mdx",
"types/set-active-params.mdx",
Expand Down
21 changes: 18 additions & 3 deletions packages/clerk-js/src/core/__tests__/clerk.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2331,7 +2331,7 @@ describe('Clerk singleton', () => {
});
});

describe('nextTask', () => {
describe('navigateToTask', () => {
describe('with `pending` session status', () => {
const mockSession = {
id: '1',
Expand All@@ -2350,7 +2350,7 @@ describe('Clerk singleton', () => {
reload: jest.fn(() => Promise.resolve(mockSession)),
};

beforeAll(() => {
beforeEach(() => {
mockResource.touch.mockReturnValueOnce(Promise.resolve());
mockClientFetch.mockReturnValue(Promise.resolve({ signedInSessions: [mockResource] }));
});
Expand All@@ -2360,7 +2360,7 @@ describe('Clerk singleton', () => {
mockResource.touch.mockReset();
});

it('navigates to next task', async () => {
it('navigates to next task with default internal routing for AIOs', async () => {
const sut = new Clerk(productionPublishableKey);
await sut.load(mockedLoadOptions);

Expand All@@ -2369,6 +2369,21 @@ describe('Clerk singleton', () => {

expect(mockNavigate.mock.calls[0][0]).toBe('/sign-in#/tasks/add-organization');
});

it('navigates to next task with custom routing from clerk options', async () => {
const sut = new Clerk(productionPublishableKey);
await sut.load({
...mockedLoadOptions,
taskUrls: {
org: '/onboarding/select-organization',
},
});

await sut.setActive({ session: mockResource as any as PendingSessionResource });
await sut.__internal_navigateToTaskIfAvailable();

expect(mockNavigate.mock.calls[0][0]).toBe('/onboarding/select-organization');
});
});

describe('with `active` session status', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1317,7 +1317,7 @@ export class Clerk implements ClerkInterface {
eventBus.emit(events.TokenUpdate, { token: null });
}

// Only triggers navigation for internal AIO components routing
// Only triggers navigation for internal AIO components routing or custom URLs
const shouldNavigateOnSetActive = this.#componentNavigationContext;
if (newSession?.currentTask && shouldNavigateOnSetActive) {
await navigateToTask(session.currentTask.key, {
Expand Down
9 changes: 4 additions & 5 deletions packages/clerk-js/src/core/sessionTasks.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@ import type {

import { buildURL } from '../utils';

export const SESSION_TASK_ROUTE_BY_KEY: Record<SessionTask['key'], string> = {
export const INTERNAL_SESSION_TASK_ROUTE_BY_KEY: Record<SessionTask['key'], string> = {
org: 'add-organization',
} as const;

Expand All@@ -24,10 +24,10 @@ interface NavigateToTaskOptions {
* @internal
*/
export function navigateToTask(
routeKey: keyof typeof SESSION_TASK_ROUTE_BY_KEY,
routeKey: keyof typeof INTERNAL_SESSION_TASK_ROUTE_BY_KEY,
{ componentNavigationContext, globalNavigate, options, environment }: NavigateToTaskOptions,
) {
const taskRoute = `/tasks/${SESSION_TASK_ROUTE_BY_KEY[routeKey]}`;
const taskRoute = `/tasks/${INTERNAL_SESSION_TASK_ROUTE_BY_KEY[routeKey]}`;

if (componentNavigationContext) {
return componentNavigationContext.navigate(componentNavigationContext.indexPath + taskRoute);
Expand All@@ -38,13 +38,12 @@ export function navigateToTask(
const isReferrerSignUpUrl = window.location.href.startsWith(signUpUrl);

const sessionTaskUrl = buildURL(
// TODO - Accept custom URL option for custom flows in order to eject out of `signInUrl/signUpUrl`
{
base: isReferrerSignUpUrl ? signUpUrl : signInUrl,
hashPath: taskRoute,
},
{ stringify: true },
);

return globalNavigate(sessionTaskUrl);
return globalNavigate(options.taskUrls?.[routeKey] ?? sessionTaskUrl);
}
23 changes: 14 additions & 9 deletions packages/clerk-js/src/ui/common/redirects.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import type { SessionTask } from '@clerk/types';
import type { ClerkOptions, SessionTask } from '@clerk/types';

import { SESSION_TASK_ROUTE_BY_KEY } from '../../core/sessionTasks';
import { INTERNAL_SESSION_TASK_ROUTE_BY_KEY } from '../../core/sessionTasks';
import { buildURL } from '../../utils/url';
import type { SignInContextType, SignUpContextType, UserProfileContextType } from './../contexts';

Expand DownExpand Up@@ -33,21 +33,26 @@ export function buildSessionTaskRedirectUrl({
path,
baseUrl,
task,
taskUrls,
}: Pick<SignInContextType | SignUpContextType, 'routing' | 'path'> & {
baseUrl: string;
task?: SessionTask;
taskUrls?: ClerkOptions['taskUrls'];
}) {
if (!task) {
return null;
}

return buildRedirectUrl({
routing,
baseUrl,
path,
endpoint: `/tasks/${SESSION_TASK_ROUTE_BY_KEY[task.key]}`,
authQueryString: null,
});
return (
taskUrls?.[task.key] ??
buildRedirectUrl({
routing,
baseUrl,
path,
endpoint: `/tasks/${INTERNAL_SESSION_TASK_ROUTE_BY_KEY[task.key]}`,
authQueryString: null,
})
);
}

export function buildSSOCallbackURL(
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/ui/components/SessionTasks/index.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@ import { Card } from '@/ui/elements/Card';
import { withCardStateProvider } from '@/ui/elements/contexts';
import { LoadingCardContainer } from '@/ui/elements/LoadingCard';

import { SESSION_TASK_ROUTE_BY_KEY } from '../../../core/sessionTasks';
import { INTERNAL_SESSION_TASK_ROUTE_BY_KEY } from '../../../core/sessionTasks';
import { SignInContext, SignUpContext } from '../../../ui/contexts';
import { SessionTasksContext, useSessionTasksContext } from '../../contexts/components/SessionTasks';
import { Route, Switch, useRouter } from '../../router';
Expand DownExpand Up@@ -38,7 +38,7 @@ const SessionTasksStart = () => {
function SessionTaskRoutes(): JSX.Element {
return (
<Switch>
<Route path={SESSION_TASK_ROUTE_BY_KEY['org']}>
<Route path={INTERNAL_SESSION_TASK_ROUTE_BY_KEY['org']}>
<ForceOrganizationSelectionTask />
</Route>
<Route index>
Expand Down
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/contexts/components/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -126,6 +126,7 @@ export const useSignInContext = (): SignInContextType => {
path: ctx.path,
routing: ctx.routing,
baseUrl: signInUrl,
taskUrls: clerk.__internal_getOption('taskUrls'),
});

return {
Expand Down
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/contexts/components/SignUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -121,6 +121,7 @@ export const useSignUpContext = (): SignUpContextType => {
path: ctx.path,
routing: ctx.routing,
baseUrl: signUpUrl,
taskUrls: clerk.__internal_getOption('taskUrls'),
});

return {
Expand Down
10 changes: 9 additions & 1 deletion packages/types/src/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,7 @@
SignUpFallbackRedirectUrl,
SignUpForceRedirectUrl,
} from './redirects';
import type { PendingSessionOptions, SignedInSessionResource } from './session';
import type { PendingSessionOptions, SessionTask, SignedInSessionResource } from './session';
import type { SessionVerificationLevel } from './sessionVerification';
import type { SignInResource } from './signIn';
import type { SignUpResource } from './signUp';
Expand DownExpand Up@@ -1050,6 +1050,14 @@
* @internal
*/
__internal_keyless_dismissPrompt?: (() => Promise<void>) | null;

/**
* Customize the URL paths users are redirected to after sign-in or sign-up when specific
* session tasks need to be completed.
*
* @default undefined - Uses Clerk's default task flow URLs
*/
taskUrls?: Record<SessionTask['key'], string>;
};

export interface NavigateOptions {
Expand DownExpand Up@@ -1114,7 +1122,7 @@
*/
windowNavigate: (to: URL | string) => void;
},
) => Promise<unknown> | unknown;

Check warning on line 1125 in packages/types/src/clerk.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

'unknown' overrides all other types in this union type

export type WithoutRouting<T> = Omit<T, 'path' | 'routing'>;

Expand Down
7 changes: 7 additions & 0 deletions packages/types/src/session.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -326,7 +326,14 @@ export interface PublicUserData {
userId?: string;
}

/**
* Represents a required action that a user must complete
* before their session becomes fully active
*/
export interface SessionTask {
/**
* The unique identifier for the type of task that needs to be completed
*/
key: 'org';
}

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/whole-knives-attend.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
---
'@clerk/clerk-js': patch
'@clerk/types': patch
---
Comment thread
LauraBeatris marked this conversation as resolved.

Add `taskUrls` option to customize task flow URLs:

```tsx
<ClerkProvider
taskUrls={{
'org': '/my-custom-org-selector'
}}
/>
```
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,6 +106,7 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/server-get-token.mdx",
"types/session-resource.mdx",
"types/session-status-claim.mdx",
"types/session-task.mdx",
"types/session-verification-level.mdx",
"types/session-verification-types.mdx",
"types/set-active-params.mdx",
Expand Down
21 changes: 18 additions & 3 deletions packages/clerk-js/src/core/__tests__/clerk.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2331,7 +2331,7 @@ describe('Clerk singleton', () => {
});
});

describe('nextTask', () => {
describe('navigateToTask', () => {
describe('with `pending` session status', () => {
const mockSession = {
id: '1',
Expand All@@ -2350,7 +2350,7 @@ describe('Clerk singleton', () => {
reload: jest.fn(() => Promise.resolve(mockSession)),
};

beforeAll(() => {
beforeEach(() => {
mockResource.touch.mockReturnValueOnce(Promise.resolve());
mockClientFetch.mockReturnValue(Promise.resolve({ signedInSessions: [mockResource] }));
});
Expand All@@ -2360,7 +2360,7 @@ describe('Clerk singleton', () => {
mockResource.touch.mockReset();
});

it('navigates to next task', async () => {
it('navigates to next task with default internal routing for AIOs', async () => {
const sut = new Clerk(productionPublishableKey);
await sut.load(mockedLoadOptions);

Expand All@@ -2369,6 +2369,21 @@ describe('Clerk singleton', () => {

expect(mockNavigate.mock.calls[0][0]).toBe('/sign-in#/tasks/add-organization');
});

it('navigates to next task with custom routing from clerk options', async () => {
const sut = new Clerk(productionPublishableKey);
await sut.load({
...mockedLoadOptions,
taskUrls: {
org: '/onboarding/select-organization',
},
});

await sut.setActive({ session: mockResource as any as PendingSessionResource });
await sut.__internal_navigateToTaskIfAvailable();

expect(mockNavigate.mock.calls[0][0]).toBe('/onboarding/select-organization');
});
});

describe('with `active` session status', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1317,7 +1317,7 @@ export class Clerk implements ClerkInterface {
eventBus.emit(events.TokenUpdate, { token: null });
}

// Only triggers navigation for internal AIO components routing
// Only triggers navigation for internal AIO components routing or custom URLs
const shouldNavigateOnSetActive = this.#componentNavigationContext;
if (newSession?.currentTask && shouldNavigateOnSetActive) {
await navigateToTask(session.currentTask.key, {
Expand Down
9 changes: 4 additions & 5 deletions packages/clerk-js/src/core/sessionTasks.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@ import type {

import { buildURL } from '../utils';

export const SESSION_TASK_ROUTE_BY_KEY: Record<SessionTask['key'], string> = {
export const INTERNAL_SESSION_TASK_ROUTE_BY_KEY: Record<SessionTask['key'], string> = {
org: 'add-organization',
} as const;

Expand All@@ -24,10 +24,10 @@ interface NavigateToTaskOptions {
* @internal
*/
export function navigateToTask(
routeKey: keyof typeof SESSION_TASK_ROUTE_BY_KEY,
routeKey: keyof typeof INTERNAL_SESSION_TASK_ROUTE_BY_KEY,
{ componentNavigationContext, globalNavigate, options, environment }: NavigateToTaskOptions,
) {
const taskRoute = `/tasks/${SESSION_TASK_ROUTE_BY_KEY[routeKey]}`;
const taskRoute = `/tasks/${INTERNAL_SESSION_TASK_ROUTE_BY_KEY[routeKey]}`;

if (componentNavigationContext) {
return componentNavigationContext.navigate(componentNavigationContext.indexPath + taskRoute);
Expand All@@ -38,13 +38,12 @@ export function navigateToTask(
const isReferrerSignUpUrl = window.location.href.startsWith(signUpUrl);

const sessionTaskUrl = buildURL(
// TODO - Accept custom URL option for custom flows in order to eject out of `signInUrl/signUpUrl`
{
base: isReferrerSignUpUrl ? signUpUrl : signInUrl,
hashPath: taskRoute,
},
{ stringify: true },
);

return globalNavigate(sessionTaskUrl);
return globalNavigate(options.taskUrls?.[routeKey] ?? sessionTaskUrl);
}
23 changes: 14 additions & 9 deletions packages/clerk-js/src/ui/common/redirects.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import type { SessionTask } from '@clerk/types';
import type { ClerkOptions, SessionTask } from '@clerk/types';

import { SESSION_TASK_ROUTE_BY_KEY } from '../../core/sessionTasks';
import { INTERNAL_SESSION_TASK_ROUTE_BY_KEY } from '../../core/sessionTasks';
import { buildURL } from '../../utils/url';
import type { SignInContextType, SignUpContextType, UserProfileContextType } from './../contexts';

Expand DownExpand Up@@ -33,21 +33,26 @@ export function buildSessionTaskRedirectUrl({
path,
baseUrl,
task,
taskUrls,
}: Pick<SignInContextType | SignUpContextType, 'routing' | 'path'> & {
baseUrl: string;
task?: SessionTask;
taskUrls?: ClerkOptions['taskUrls'];
}) {
if (!task) {
return null;
}

return buildRedirectUrl({
routing,
baseUrl,
path,
endpoint: `/tasks/${SESSION_TASK_ROUTE_BY_KEY[task.key]}`,
authQueryString: null,
});
return (
taskUrls?.[task.key] ??
buildRedirectUrl({
routing,
baseUrl,
path,
endpoint: `/tasks/${INTERNAL_SESSION_TASK_ROUTE_BY_KEY[task.key]}`,
authQueryString: null,
})
);
}

export function buildSSOCallbackURL(
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/ui/components/SessionTasks/index.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@ import { Card } from '@/ui/elements/Card';
import { withCardStateProvider } from '@/ui/elements/contexts';
import { LoadingCardContainer } from '@/ui/elements/LoadingCard';

import { SESSION_TASK_ROUTE_BY_KEY } from '../../../core/sessionTasks';
import { INTERNAL_SESSION_TASK_ROUTE_BY_KEY } from '../../../core/sessionTasks';
import { SignInContext, SignUpContext } from '../../../ui/contexts';
import { SessionTasksContext, useSessionTasksContext } from '../../contexts/components/SessionTasks';
import { Route, Switch, useRouter } from '../../router';
Expand DownExpand Up@@ -38,7 +38,7 @@ const SessionTasksStart = () => {
function SessionTaskRoutes(): JSX.Element {
return (
<Switch>
<Route path={SESSION_TASK_ROUTE_BY_KEY['org']}>
<Route path={INTERNAL_SESSION_TASK_ROUTE_BY_KEY['org']}>
<ForceOrganizationSelectionTask />
</Route>
<Route index>
Expand Down
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/contexts/components/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -126,6 +126,7 @@ export const useSignInContext = (): SignInContextType => {
path: ctx.path,
routing: ctx.routing,
baseUrl: signInUrl,
taskUrls: clerk.__internal_getOption('taskUrls'),
});

return {
Expand Down
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/contexts/components/SignUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -121,6 +121,7 @@ export const useSignUpContext = (): SignUpContextType => {
path: ctx.path,
routing: ctx.routing,
baseUrl: signUpUrl,
taskUrls: clerk.__internal_getOption('taskUrls'),
});

return {
Expand Down
10 changes: 9 additions & 1 deletion packages/types/src/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,7 @@
SignUpFallbackRedirectUrl,
SignUpForceRedirectUrl,
} from './redirects';
import type { PendingSessionOptions, SignedInSessionResource } from './session';
import type { PendingSessionOptions, SessionTask, SignedInSessionResource } from './session';
import type { SessionVerificationLevel } from './sessionVerification';
import type { SignInResource } from './signIn';
import type { SignUpResource } from './signUp';
Expand DownExpand Up@@ -1050,6 +1050,14 @@
* @internal
*/
__internal_keyless_dismissPrompt?: (() => Promise<void>) | null;

/**
* Customize the URL paths users are redirected to after sign-in or sign-up when specific
* session tasks need to be completed.
*
* @default undefined - Uses Clerk's default task flow URLs
*/
taskUrls?: Record<SessionTask['key'], string>;
};

export interface NavigateOptions {
Expand DownExpand Up@@ -1114,7 +1122,7 @@
*/
windowNavigate: (to: URL | string) => void;
},
) => Promise<unknown> | unknown;

Check warning on line 1125 in packages/types/src/clerk.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

'unknown' overrides all other types in this union type

export type WithoutRouting<T> = Omit<T, 'path' | 'routing'>;

Expand Down
7 changes: 7 additions & 0 deletions packages/types/src/session.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -326,7 +326,14 @@ export interface PublicUserData {
userId?: string;
}

/**
* Represents a required action that a user must complete
* before their session becomes fully active
*/
export interface SessionTask {
/**
* The unique identifier for the type of task that needs to be completed
*/
key: 'org';
}

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/whole-knives-attend.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
---
'@clerk/clerk-js': patch
'@clerk/types': patch
---
Comment thread
LauraBeatris marked this conversation as resolved.

Add `taskUrls` option to customize task flow URLs:

```tsx
<ClerkProvider
taskUrls={{
'org': '/my-custom-org-selector'
}}
/>
```
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,6 +106,7 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/server-get-token.mdx",
"types/session-resource.mdx",
"types/session-status-claim.mdx",
"types/session-task.mdx",
"types/session-verification-level.mdx",
"types/session-verification-types.mdx",
"types/set-active-params.mdx",
Expand Down
21 changes: 18 additions & 3 deletions packages/clerk-js/src/core/__tests__/clerk.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2331,7 +2331,7 @@ describe('Clerk singleton', () => {
});
});

describe('nextTask', () => {
describe('navigateToTask', () => {
describe('with `pending` session status', () => {
const mockSession = {
id: '1',
Expand All@@ -2350,7 +2350,7 @@ describe('Clerk singleton', () => {
reload: jest.fn(() => Promise.resolve(mockSession)),
};

beforeAll(() => {
beforeEach(() => {
mockResource.touch.mockReturnValueOnce(Promise.resolve());
mockClientFetch.mockReturnValue(Promise.resolve({ signedInSessions: [mockResource] }));
});
Expand All@@ -2360,7 +2360,7 @@ describe('Clerk singleton', () => {
mockResource.touch.mockReset();
});

it('navigates to next task', async () => {
it('navigates to next task with default internal routing for AIOs', async () => {
const sut = new Clerk(productionPublishableKey);
await sut.load(mockedLoadOptions);

Expand All@@ -2369,6 +2369,21 @@ describe('Clerk singleton', () => {

expect(mockNavigate.mock.calls[0][0]).toBe('/sign-in#/tasks/add-organization');
});

it('navigates to next task with custom routing from clerk options', async () => {
const sut = new Clerk(productionPublishableKey);
await sut.load({
...mockedLoadOptions,
taskUrls: {
org: '/onboarding/select-organization',
},
});

await sut.setActive({ session: mockResource as any as PendingSessionResource });
await sut.__internal_navigateToTaskIfAvailable();

expect(mockNavigate.mock.calls[0][0]).toBe('/onboarding/select-organization');
});
});

describe('with `active` session status', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1317,7 +1317,7 @@ export class Clerk implements ClerkInterface {
eventBus.emit(events.TokenUpdate, { token: null });
}

// Only triggers navigation for internal AIO components routing
// Only triggers navigation for internal AIO components routing or custom URLs
const shouldNavigateOnSetActive = this.#componentNavigationContext;
if (newSession?.currentTask && shouldNavigateOnSetActive) {
await navigateToTask(session.currentTask.key, {
Expand Down
9 changes: 4 additions & 5 deletions packages/clerk-js/src/core/sessionTasks.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@ import type {

import { buildURL } from '../utils';

export const SESSION_TASK_ROUTE_BY_KEY: Record<SessionTask['key'], string> = {
export const INTERNAL_SESSION_TASK_ROUTE_BY_KEY: Record<SessionTask['key'], string> = {
org: 'add-organization',
} as const;

Expand All@@ -24,10 +24,10 @@ interface NavigateToTaskOptions {
* @internal
*/
export function navigateToTask(
routeKey: keyof typeof SESSION_TASK_ROUTE_BY_KEY,
routeKey: keyof typeof INTERNAL_SESSION_TASK_ROUTE_BY_KEY,
{ componentNavigationContext, globalNavigate, options, environment }: NavigateToTaskOptions,
) {
const taskRoute = `/tasks/${SESSION_TASK_ROUTE_BY_KEY[routeKey]}`;
const taskRoute = `/tasks/${INTERNAL_SESSION_TASK_ROUTE_BY_KEY[routeKey]}`;

if (componentNavigationContext) {
return componentNavigationContext.navigate(componentNavigationContext.indexPath + taskRoute);
Expand All@@ -38,13 +38,12 @@ export function navigateToTask(
const isReferrerSignUpUrl = window.location.href.startsWith(signUpUrl);

const sessionTaskUrl = buildURL(
// TODO - Accept custom URL option for custom flows in order to eject out of `signInUrl/signUpUrl`
{
base: isReferrerSignUpUrl ? signUpUrl : signInUrl,
hashPath: taskRoute,
},
{ stringify: true },
);

return globalNavigate(sessionTaskUrl);
return globalNavigate(options.taskUrls?.[routeKey] ?? sessionTaskUrl);
}
23 changes: 14 additions & 9 deletions packages/clerk-js/src/ui/common/redirects.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import type { SessionTask } from '@clerk/types';
import type { ClerkOptions, SessionTask } from '@clerk/types';

import { SESSION_TASK_ROUTE_BY_KEY } from '../../core/sessionTasks';
import { INTERNAL_SESSION_TASK_ROUTE_BY_KEY } from '../../core/sessionTasks';
import { buildURL } from '../../utils/url';
import type { SignInContextType, SignUpContextType, UserProfileContextType } from './../contexts';

Expand DownExpand Up@@ -33,21 +33,26 @@ export function buildSessionTaskRedirectUrl({
path,
baseUrl,
task,
taskUrls,
}: Pick<SignInContextType | SignUpContextType, 'routing' | 'path'> & {
baseUrl: string;
task?: SessionTask;
taskUrls?: ClerkOptions['taskUrls'];
}) {
if (!task) {
return null;
}

return buildRedirectUrl({
routing,
baseUrl,
path,
endpoint: `/tasks/${SESSION_TASK_ROUTE_BY_KEY[task.key]}`,
authQueryString: null,
});
return (
taskUrls?.[task.key] ??
buildRedirectUrl({
routing,
baseUrl,
path,
endpoint: `/tasks/${INTERNAL_SESSION_TASK_ROUTE_BY_KEY[task.key]}`,
authQueryString: null,
})
);
}

export function buildSSOCallbackURL(
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/ui/components/SessionTasks/index.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@ import { Card } from '@/ui/elements/Card';
import { withCardStateProvider } from '@/ui/elements/contexts';
import { LoadingCardContainer } from '@/ui/elements/LoadingCard';

import { SESSION_TASK_ROUTE_BY_KEY } from '../../../core/sessionTasks';
import { INTERNAL_SESSION_TASK_ROUTE_BY_KEY } from '../../../core/sessionTasks';
import { SignInContext, SignUpContext } from '../../../ui/contexts';
import { SessionTasksContext, useSessionTasksContext } from '../../contexts/components/SessionTasks';
import { Route, Switch, useRouter } from '../../router';
Expand DownExpand Up@@ -38,7 +38,7 @@ const SessionTasksStart = () => {
function SessionTaskRoutes(): JSX.Element {
return (
<Switch>
<Route path={SESSION_TASK_ROUTE_BY_KEY['org']}>
<Route path={INTERNAL_SESSION_TASK_ROUTE_BY_KEY['org']}>
<ForceOrganizationSelectionTask />
</Route>
<Route index>
Expand Down
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/contexts/components/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -126,6 +126,7 @@ export const useSignInContext = (): SignInContextType => {
path: ctx.path,
routing: ctx.routing,
baseUrl: signInUrl,
taskUrls: clerk.__internal_getOption('taskUrls'),
});

return {
Expand Down
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/contexts/components/SignUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -121,6 +121,7 @@ export const useSignUpContext = (): SignUpContextType => {
path: ctx.path,
routing: ctx.routing,
baseUrl: signUpUrl,
taskUrls: clerk.__internal_getOption('taskUrls'),
});

return {
Expand Down
10 changes: 9 additions & 1 deletion packages/types/src/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,7 @@
SignUpFallbackRedirectUrl,
SignUpForceRedirectUrl,
} from './redirects';
import type { PendingSessionOptions, SignedInSessionResource } from './session';
import type { PendingSessionOptions, SessionTask, SignedInSessionResource } from './session';
import type { SessionVerificationLevel } from './sessionVerification';
import type { SignInResource } from './signIn';
import type { SignUpResource } from './signUp';
Expand DownExpand Up@@ -1050,6 +1050,14 @@
* @internal
*/
__internal_keyless_dismissPrompt?: (() => Promise<void>) | null;

/**
* Customize the URL paths users are redirected to after sign-in or sign-up when specific
* session tasks need to be completed.
*
* @default undefined - Uses Clerk's default task flow URLs
*/
taskUrls?: Record<SessionTask['key'], string>;
};

export interface NavigateOptions {
Expand DownExpand Up@@ -1114,7 +1122,7 @@
*/
windowNavigate: (to: URL | string) => void;
},
) => Promise<unknown> | unknown;

Check warning on line 1125 in packages/types/src/clerk.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

'unknown' overrides all other types in this union type

export type WithoutRouting<T> = Omit<T, 'path' | 'routing'>;

Expand Down
7 changes: 7 additions & 0 deletions packages/types/src/session.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -326,7 +326,14 @@ export interface PublicUserData {
userId?: string;
}

/**
* Represents a required action that a user must complete
* before their session becomes fully active
*/
export interface SessionTask {
/**
* The unique identifier for the type of task that needs to be completed
*/
key: 'org';
}

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/whole-knives-attend.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
---
'@clerk/clerk-js': patch
'@clerk/types': patch
---
Comment thread
LauraBeatris marked this conversation as resolved.

Add `taskUrls` option to customize task flow URLs:

```tsx
<ClerkProvider
taskUrls={{
'org': '/my-custom-org-selector'
}}
/>
```
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,6 +106,7 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/server-get-token.mdx",
"types/session-resource.mdx",
"types/session-status-claim.mdx",
"types/session-task.mdx",
"types/session-verification-level.mdx",
"types/session-verification-types.mdx",
"types/set-active-params.mdx",
Expand Down
21 changes: 18 additions & 3 deletions packages/clerk-js/src/core/__tests__/clerk.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2331,7 +2331,7 @@ describe('Clerk singleton', () => {
});
});

describe('nextTask', () => {
describe('navigateToTask', () => {
describe('with `pending` session status', () => {
const mockSession = {
id: '1',
Expand All@@ -2350,7 +2350,7 @@ describe('Clerk singleton', () => {
reload: jest.fn(() => Promise.resolve(mockSession)),
};

beforeAll(() => {
beforeEach(() => {
mockResource.touch.mockReturnValueOnce(Promise.resolve());
mockClientFetch.mockReturnValue(Promise.resolve({ signedInSessions: [mockResource] }));
});
Expand All@@ -2360,7 +2360,7 @@ describe('Clerk singleton', () => {
mockResource.touch.mockReset();
});

it('navigates to next task', async () => {
it('navigates to next task with default internal routing for AIOs', async () => {
const sut = new Clerk(productionPublishableKey);
await sut.load(mockedLoadOptions);

Expand All@@ -2369,6 +2369,21 @@ describe('Clerk singleton', () => {

expect(mockNavigate.mock.calls[0][0]).toBe('/sign-in#/tasks/add-organization');
});

it('navigates to next task with custom routing from clerk options', async () => {
const sut = new Clerk(productionPublishableKey);
await sut.load({
...mockedLoadOptions,
taskUrls: {
org: '/onboarding/select-organization',
},
});

await sut.setActive({ session: mockResource as any as PendingSessionResource });
await sut.__internal_navigateToTaskIfAvailable();

expect(mockNavigate.mock.calls[0][0]).toBe('/onboarding/select-organization');
});
});

describe('with `active` session status', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1317,7 +1317,7 @@ export class Clerk implements ClerkInterface {
eventBus.emit(events.TokenUpdate, { token: null });
}

// Only triggers navigation for internal AIO components routing
// Only triggers navigation for internal AIO components routing or custom URLs
const shouldNavigateOnSetActive = this.#componentNavigationContext;
if (newSession?.currentTask && shouldNavigateOnSetActive) {
await navigateToTask(session.currentTask.key, {
Expand Down
9 changes: 4 additions & 5 deletions packages/clerk-js/src/core/sessionTasks.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@ import type {

import { buildURL } from '../utils';

export const SESSION_TASK_ROUTE_BY_KEY: Record<SessionTask['key'], string> = {
export const INTERNAL_SESSION_TASK_ROUTE_BY_KEY: Record<SessionTask['key'], string> = {
org: 'add-organization',
} as const;

Expand All@@ -24,10 +24,10 @@ interface NavigateToTaskOptions {
* @internal
*/
export function navigateToTask(
routeKey: keyof typeof SESSION_TASK_ROUTE_BY_KEY,
routeKey: keyof typeof INTERNAL_SESSION_TASK_ROUTE_BY_KEY,
{ componentNavigationContext, globalNavigate, options, environment }: NavigateToTaskOptions,
) {
const taskRoute = `/tasks/${SESSION_TASK_ROUTE_BY_KEY[routeKey]}`;
const taskRoute = `/tasks/${INTERNAL_SESSION_TASK_ROUTE_BY_KEY[routeKey]}`;

if (componentNavigationContext) {
return componentNavigationContext.navigate(componentNavigationContext.indexPath + taskRoute);
Expand All@@ -38,13 +38,12 @@ export function navigateToTask(
const isReferrerSignUpUrl = window.location.href.startsWith(signUpUrl);

const sessionTaskUrl = buildURL(
// TODO - Accept custom URL option for custom flows in order to eject out of `signInUrl/signUpUrl`
{
base: isReferrerSignUpUrl ? signUpUrl : signInUrl,
hashPath: taskRoute,
},
{ stringify: true },
);

return globalNavigate(sessionTaskUrl);
return globalNavigate(options.taskUrls?.[routeKey] ?? sessionTaskUrl);
}
23 changes: 14 additions & 9 deletions packages/clerk-js/src/ui/common/redirects.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import type { SessionTask } from '@clerk/types';
import type { ClerkOptions, SessionTask } from '@clerk/types';

import { SESSION_TASK_ROUTE_BY_KEY } from '../../core/sessionTasks';
import { INTERNAL_SESSION_TASK_ROUTE_BY_KEY } from '../../core/sessionTasks';
import { buildURL } from '../../utils/url';
import type { SignInContextType, SignUpContextType, UserProfileContextType } from './../contexts';

Expand DownExpand Up@@ -33,21 +33,26 @@ export function buildSessionTaskRedirectUrl({
path,
baseUrl,
task,
taskUrls,
}: Pick<SignInContextType | SignUpContextType, 'routing' | 'path'> & {
baseUrl: string;
task?: SessionTask;
taskUrls?: ClerkOptions['taskUrls'];
}) {
if (!task) {
return null;
}

return buildRedirectUrl({
routing,
baseUrl,
path,
endpoint: `/tasks/${SESSION_TASK_ROUTE_BY_KEY[task.key]}`,
authQueryString: null,
});
return (
taskUrls?.[task.key] ??
buildRedirectUrl({
routing,
baseUrl,
path,
endpoint: `/tasks/${INTERNAL_SESSION_TASK_ROUTE_BY_KEY[task.key]}`,
authQueryString: null,
})
);
}

export function buildSSOCallbackURL(
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/ui/components/SessionTasks/index.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@ import { Card } from '@/ui/elements/Card';
import { withCardStateProvider } from '@/ui/elements/contexts';
import { LoadingCardContainer } from '@/ui/elements/LoadingCard';

import { SESSION_TASK_ROUTE_BY_KEY } from '../../../core/sessionTasks';
import { INTERNAL_SESSION_TASK_ROUTE_BY_KEY } from '../../../core/sessionTasks';
import { SignInContext, SignUpContext } from '../../../ui/contexts';
import { SessionTasksContext, useSessionTasksContext } from '../../contexts/components/SessionTasks';
import { Route, Switch, useRouter } from '../../router';
Expand DownExpand Up@@ -38,7 +38,7 @@ const SessionTasksStart = () => {
function SessionTaskRoutes(): JSX.Element {
return (
<Switch>
<Route path={SESSION_TASK_ROUTE_BY_KEY['org']}>
<Route path={INTERNAL_SESSION_TASK_ROUTE_BY_KEY['org']}>
<ForceOrganizationSelectionTask />
</Route>
<Route index>
Expand Down
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/contexts/components/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -126,6 +126,7 @@ export const useSignInContext = (): SignInContextType => {
path: ctx.path,
routing: ctx.routing,
baseUrl: signInUrl,
taskUrls: clerk.__internal_getOption('taskUrls'),
});

return {
Expand Down
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/contexts/components/SignUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -121,6 +121,7 @@ export const useSignUpContext = (): SignUpContextType => {
path: ctx.path,
routing: ctx.routing,
baseUrl: signUpUrl,
taskUrls: clerk.__internal_getOption('taskUrls'),
});

return {
Expand Down
10 changes: 9 additions & 1 deletion packages/types/src/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,7 @@
SignUpFallbackRedirectUrl,
SignUpForceRedirectUrl,
} from './redirects';
import type { PendingSessionOptions, SignedInSessionResource } from './session';
import type { PendingSessionOptions, SessionTask, SignedInSessionResource } from './session';
import type { SessionVerificationLevel } from './sessionVerification';
import type { SignInResource } from './signIn';
import type { SignUpResource } from './signUp';
Expand DownExpand Up@@ -1050,6 +1050,14 @@
* @internal
*/
__internal_keyless_dismissPrompt?: (() => Promise<void>) | null;

/**
* Customize the URL paths users are redirected to after sign-in or sign-up when specific
* session tasks need to be completed.
*
* @default undefined - Uses Clerk's default task flow URLs
*/
taskUrls?: Record<SessionTask['key'], string>;
};

export interface NavigateOptions {
Expand DownExpand Up@@ -1114,7 +1122,7 @@
*/
windowNavigate: (to: URL | string) => void;
},
) => Promise<unknown> | unknown;

Check warning on line 1125 in packages/types/src/clerk.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

'unknown' overrides all other types in this union type

export type WithoutRouting<T> = Omit<T, 'path' | 'routing'>;

Expand Down
7 changes: 7 additions & 0 deletions packages/types/src/session.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -326,7 +326,14 @@ export interface PublicUserData {
userId?: string;
}

/**
* Represents a required action that a user must complete
* before their session becomes fully active
*/
export interface SessionTask {
/**
* The unique identifier for the type of task that needs to be completed
*/
key: 'org';
}

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/whole-knives-attend.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
---
'@clerk/clerk-js': patch
'@clerk/types': patch
---
Comment thread
LauraBeatris marked this conversation as resolved.

Add `taskUrls` option to customize task flow URLs:

```tsx
<ClerkProvider
taskUrls={{
'org': '/my-custom-org-selector'
}}
/>
```
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,6 +106,7 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/server-get-token.mdx",
"types/session-resource.mdx",
"types/session-status-claim.mdx",
"types/session-task.mdx",
"types/session-verification-level.mdx",
"types/session-verification-types.mdx",
"types/set-active-params.mdx",
Expand Down
21 changes: 18 additions & 3 deletions packages/clerk-js/src/core/__tests__/clerk.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2331,7 +2331,7 @@ describe('Clerk singleton', () => {
});
});

describe('nextTask', () => {
describe('navigateToTask', () => {
describe('with `pending` session status', () => {
const mockSession = {
id: '1',
Expand All@@ -2350,7 +2350,7 @@ describe('Clerk singleton', () => {
reload: jest.fn(() => Promise.resolve(mockSession)),
};

beforeAll(() => {
beforeEach(() => {
mockResource.touch.mockReturnValueOnce(Promise.resolve());
mockClientFetch.mockReturnValue(Promise.resolve({ signedInSessions: [mockResource] }));
});
Expand All@@ -2360,7 +2360,7 @@ describe('Clerk singleton', () => {
mockResource.touch.mockReset();
});

it('navigates to next task', async () => {
it('navigates to next task with default internal routing for AIOs', async () => {
const sut = new Clerk(productionPublishableKey);
await sut.load(mockedLoadOptions);

Expand All@@ -2369,6 +2369,21 @@ describe('Clerk singleton', () => {

expect(mockNavigate.mock.calls[0][0]).toBe('/sign-in#/tasks/add-organization');
});

it('navigates to next task with custom routing from clerk options', async () => {
const sut = new Clerk(productionPublishableKey);
await sut.load({
...mockedLoadOptions,
taskUrls: {
org: '/onboarding/select-organization',
},
});

await sut.setActive({ session: mockResource as any as PendingSessionResource });
await sut.__internal_navigateToTaskIfAvailable();

expect(mockNavigate.mock.calls[0][0]).toBe('/onboarding/select-organization');
});
});

describe('with `active` session status', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1317,7 +1317,7 @@ export class Clerk implements ClerkInterface {
eventBus.emit(events.TokenUpdate, { token: null });
}

// Only triggers navigation for internal AIO components routing
// Only triggers navigation for internal AIO components routing or custom URLs
const shouldNavigateOnSetActive = this.#componentNavigationContext;
if (newSession?.currentTask && shouldNavigateOnSetActive) {
await navigateToTask(session.currentTask.key, {
Expand Down
9 changes: 4 additions & 5 deletions packages/clerk-js/src/core/sessionTasks.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@ import type {

import { buildURL } from '../utils';

export const SESSION_TASK_ROUTE_BY_KEY: Record<SessionTask['key'], string> = {
export const INTERNAL_SESSION_TASK_ROUTE_BY_KEY: Record<SessionTask['key'], string> = {
org: 'add-organization',
} as const;

Expand All@@ -24,10 +24,10 @@ interface NavigateToTaskOptions {
* @internal
*/
export function navigateToTask(
routeKey: keyof typeof SESSION_TASK_ROUTE_BY_KEY,
routeKey: keyof typeof INTERNAL_SESSION_TASK_ROUTE_BY_KEY,
{ componentNavigationContext, globalNavigate, options, environment }: NavigateToTaskOptions,
) {
const taskRoute = `/tasks/${SESSION_TASK_ROUTE_BY_KEY[routeKey]}`;
const taskRoute = `/tasks/${INTERNAL_SESSION_TASK_ROUTE_BY_KEY[routeKey]}`;

if (componentNavigationContext) {
return componentNavigationContext.navigate(componentNavigationContext.indexPath + taskRoute);
Expand All@@ -38,13 +38,12 @@ export function navigateToTask(
const isReferrerSignUpUrl = window.location.href.startsWith(signUpUrl);

const sessionTaskUrl = buildURL(
// TODO - Accept custom URL option for custom flows in order to eject out of `signInUrl/signUpUrl`
{
base: isReferrerSignUpUrl ? signUpUrl : signInUrl,
hashPath: taskRoute,
},
{ stringify: true },
);

return globalNavigate(sessionTaskUrl);
return globalNavigate(options.taskUrls?.[routeKey] ?? sessionTaskUrl);
}
23 changes: 14 additions & 9 deletions packages/clerk-js/src/ui/common/redirects.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import type { SessionTask } from '@clerk/types';
import type { ClerkOptions, SessionTask } from '@clerk/types';

import { SESSION_TASK_ROUTE_BY_KEY } from '../../core/sessionTasks';
import { INTERNAL_SESSION_TASK_ROUTE_BY_KEY } from '../../core/sessionTasks';
import { buildURL } from '../../utils/url';
import type { SignInContextType, SignUpContextType, UserProfileContextType } from './../contexts';

Expand DownExpand Up@@ -33,21 +33,26 @@ export function buildSessionTaskRedirectUrl({
path,
baseUrl,
task,
taskUrls,
}: Pick<SignInContextType | SignUpContextType, 'routing' | 'path'> & {
baseUrl: string;
task?: SessionTask;
taskUrls?: ClerkOptions['taskUrls'];
}) {
if (!task) {
return null;
}

return buildRedirectUrl({
routing,
baseUrl,
path,
endpoint: `/tasks/${SESSION_TASK_ROUTE_BY_KEY[task.key]}`,
authQueryString: null,
});
return (
taskUrls?.[task.key] ??
buildRedirectUrl({
routing,
baseUrl,
path,
endpoint: `/tasks/${INTERNAL_SESSION_TASK_ROUTE_BY_KEY[task.key]}`,
authQueryString: null,
})
);
}

export function buildSSOCallbackURL(
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/ui/components/SessionTasks/index.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@ import { Card } from '@/ui/elements/Card';
import { withCardStateProvider } from '@/ui/elements/contexts';
import { LoadingCardContainer } from '@/ui/elements/LoadingCard';

import { SESSION_TASK_ROUTE_BY_KEY } from '../../../core/sessionTasks';
import { INTERNAL_SESSION_TASK_ROUTE_BY_KEY } from '../../../core/sessionTasks';
import { SignInContext, SignUpContext } from '../../../ui/contexts';
import { SessionTasksContext, useSessionTasksContext } from '../../contexts/components/SessionTasks';
import { Route, Switch, useRouter } from '../../router';
Expand DownExpand Up@@ -38,7 +38,7 @@ const SessionTasksStart = () => {
function SessionTaskRoutes(): JSX.Element {
return (
<Switch>
<Route path={SESSION_TASK_ROUTE_BY_KEY['org']}>
<Route path={INTERNAL_SESSION_TASK_ROUTE_BY_KEY['org']}>
<ForceOrganizationSelectionTask />
</Route>
<Route index>
Expand Down
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/contexts/components/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -126,6 +126,7 @@ export const useSignInContext = (): SignInContextType => {
path: ctx.path,
routing: ctx.routing,
baseUrl: signInUrl,
taskUrls: clerk.__internal_getOption('taskUrls'),
});

return {
Expand Down
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/contexts/components/SignUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -121,6 +121,7 @@ export const useSignUpContext = (): SignUpContextType => {
path: ctx.path,
routing: ctx.routing,
baseUrl: signUpUrl,
taskUrls: clerk.__internal_getOption('taskUrls'),
});

return {
Expand Down
10 changes: 9 additions & 1 deletion packages/types/src/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,7 @@
SignUpFallbackRedirectUrl,
SignUpForceRedirectUrl,
} from './redirects';
import type { PendingSessionOptions, SignedInSessionResource } from './session';
import type { PendingSessionOptions, SessionTask, SignedInSessionResource } from './session';
import type { SessionVerificationLevel } from './sessionVerification';
import type { SignInResource } from './signIn';
import type { SignUpResource } from './signUp';
Expand DownExpand Up@@ -1050,6 +1050,14 @@
* @internal
*/
__internal_keyless_dismissPrompt?: (() => Promise<void>) | null;

/**
* Customize the URL paths users are redirected to after sign-in or sign-up when specific
* session tasks need to be completed.
*
* @default undefined - Uses Clerk's default task flow URLs
*/
taskUrls?: Record<SessionTask['key'], string>;
};

export interface NavigateOptions {
Expand DownExpand Up@@ -1114,7 +1122,7 @@
*/
windowNavigate: (to: URL | string) => void;
},
) => Promise<unknown> | unknown;

Check warning on line 1125 in packages/types/src/clerk.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

'unknown' overrides all other types in this union type

export type WithoutRouting<T> = Omit<T, 'path' | 'routing'>;

Expand Down
7 changes: 7 additions & 0 deletions packages/types/src/session.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -326,7 +326,14 @@ export interface PublicUserData {
userId?: string;
}

/**
* Represents a required action that a user must complete
* before their session becomes fully active
*/
export interface SessionTask {
/**
* The unique identifier for the type of task that needs to be completed
*/
key: 'org';
}

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/whole-knives-attend.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
---
'@clerk/clerk-js': patch
'@clerk/types': patch
---
Comment thread
LauraBeatris marked this conversation as resolved.

Add `taskUrls` option to customize task flow URLs:

```tsx
<ClerkProvider
taskUrls={{
'org': '/my-custom-org-selector'
}}
/>
```
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,6 +106,7 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/server-get-token.mdx",
"types/session-resource.mdx",
"types/session-status-claim.mdx",
"types/session-task.mdx",
"types/session-verification-level.mdx",
"types/session-verification-types.mdx",
"types/set-active-params.mdx",
Expand Down
21 changes: 18 additions & 3 deletions packages/clerk-js/src/core/__tests__/clerk.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2331,7 +2331,7 @@ describe('Clerk singleton', () => {
});
});

describe('nextTask', () => {
describe('navigateToTask', () => {
describe('with `pending` session status', () => {
const mockSession = {
id: '1',
Expand All@@ -2350,7 +2350,7 @@ describe('Clerk singleton', () => {
reload: jest.fn(() => Promise.resolve(mockSession)),
};

beforeAll(() => {
beforeEach(() => {
mockResource.touch.mockReturnValueOnce(Promise.resolve());
mockClientFetch.mockReturnValue(Promise.resolve({ signedInSessions: [mockResource] }));
});
Expand All@@ -2360,7 +2360,7 @@ describe('Clerk singleton', () => {
mockResource.touch.mockReset();
});

it('navigates to next task', async () => {
it('navigates to next task with default internal routing for AIOs', async () => {
const sut = new Clerk(productionPublishableKey);
await sut.load(mockedLoadOptions);

Expand All@@ -2369,6 +2369,21 @@ describe('Clerk singleton', () => {

expect(mockNavigate.mock.calls[0][0]).toBe('/sign-in#/tasks/add-organization');
});

it('navigates to next task with custom routing from clerk options', async () => {
const sut = new Clerk(productionPublishableKey);
await sut.load({
...mockedLoadOptions,
taskUrls: {
org: '/onboarding/select-organization',
},
});

await sut.setActive({ session: mockResource as any as PendingSessionResource });
await sut.__internal_navigateToTaskIfAvailable();

expect(mockNavigate.mock.calls[0][0]).toBe('/onboarding/select-organization');
});
});

describe('with `active` session status', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/clerk-js/src/core/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1317,7 +1317,7 @@ export class Clerk implements ClerkInterface {
eventBus.emit(events.TokenUpdate, { token: null });
}

// Only triggers navigation for internal AIO components routing
// Only triggers navigation for internal AIO components routing or custom URLs
const shouldNavigateOnSetActive = this.#componentNavigationContext;
if (newSession?.currentTask && shouldNavigateOnSetActive) {
await navigateToTask(session.currentTask.key, {
Expand Down
9 changes: 4 additions & 5 deletions packages/clerk-js/src/core/sessionTasks.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@ import type {

import { buildURL } from '../utils';

export const SESSION_TASK_ROUTE_BY_KEY: Record<SessionTask['key'], string> = {
export const INTERNAL_SESSION_TASK_ROUTE_BY_KEY: Record<SessionTask['key'], string> = {
org: 'add-organization',
} as const;

Expand All@@ -24,10 +24,10 @@ interface NavigateToTaskOptions {
* @internal
*/
export function navigateToTask(
routeKey: keyof typeof SESSION_TASK_ROUTE_BY_KEY,
routeKey: keyof typeof INTERNAL_SESSION_TASK_ROUTE_BY_KEY,
{ componentNavigationContext, globalNavigate, options, environment }: NavigateToTaskOptions,
) {
const taskRoute = `/tasks/${SESSION_TASK_ROUTE_BY_KEY[routeKey]}`;
const taskRoute = `/tasks/${INTERNAL_SESSION_TASK_ROUTE_BY_KEY[routeKey]}`;

if (componentNavigationContext) {
return componentNavigationContext.navigate(componentNavigationContext.indexPath + taskRoute);
Expand All@@ -38,13 +38,12 @@ export function navigateToTask(
const isReferrerSignUpUrl = window.location.href.startsWith(signUpUrl);

const sessionTaskUrl = buildURL(
// TODO - Accept custom URL option for custom flows in order to eject out of `signInUrl/signUpUrl`
{
base: isReferrerSignUpUrl ? signUpUrl : signInUrl,
hashPath: taskRoute,
},
{ stringify: true },
);

return globalNavigate(sessionTaskUrl);
return globalNavigate(options.taskUrls?.[routeKey] ?? sessionTaskUrl);
}
23 changes: 14 additions & 9 deletions packages/clerk-js/src/ui/common/redirects.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import type { SessionTask } from '@clerk/types';
import type { ClerkOptions, SessionTask } from '@clerk/types';

import { SESSION_TASK_ROUTE_BY_KEY } from '../../core/sessionTasks';
import { INTERNAL_SESSION_TASK_ROUTE_BY_KEY } from '../../core/sessionTasks';
import { buildURL } from '../../utils/url';
import type { SignInContextType, SignUpContextType, UserProfileContextType } from './../contexts';

Expand DownExpand Up@@ -33,21 +33,26 @@ export function buildSessionTaskRedirectUrl({
path,
baseUrl,
task,
taskUrls,
}: Pick<SignInContextType | SignUpContextType, 'routing' | 'path'> & {
baseUrl: string;
task?: SessionTask;
taskUrls?: ClerkOptions['taskUrls'];
}) {
if (!task) {
return null;
}

return buildRedirectUrl({
routing,
baseUrl,
path,
endpoint: `/tasks/${SESSION_TASK_ROUTE_BY_KEY[task.key]}`,
authQueryString: null,
});
return (
taskUrls?.[task.key] ??
buildRedirectUrl({
routing,
baseUrl,
path,
endpoint: `/tasks/${INTERNAL_SESSION_TASK_ROUTE_BY_KEY[task.key]}`,
authQueryString: null,
})
);
}

export function buildSSOCallbackURL(
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/ui/components/SessionTasks/index.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@ import { Card } from '@/ui/elements/Card';
import { withCardStateProvider } from '@/ui/elements/contexts';
import { LoadingCardContainer } from '@/ui/elements/LoadingCard';

import { SESSION_TASK_ROUTE_BY_KEY } from '../../../core/sessionTasks';
import { INTERNAL_SESSION_TASK_ROUTE_BY_KEY } from '../../../core/sessionTasks';
import { SignInContext, SignUpContext } from '../../../ui/contexts';
import { SessionTasksContext, useSessionTasksContext } from '../../contexts/components/SessionTasks';
import { Route, Switch, useRouter } from '../../router';
Expand DownExpand Up@@ -38,7 +38,7 @@ const SessionTasksStart = () => {
function SessionTaskRoutes(): JSX.Element {
return (
<Switch>
<Route path={SESSION_TASK_ROUTE_BY_KEY['org']}>
<Route path={INTERNAL_SESSION_TASK_ROUTE_BY_KEY['org']}>
<ForceOrganizationSelectionTask />
</Route>
<Route index>
Expand Down
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/contexts/components/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -126,6 +126,7 @@ export const useSignInContext = (): SignInContextType => {
path: ctx.path,
routing: ctx.routing,
baseUrl: signInUrl,
taskUrls: clerk.__internal_getOption('taskUrls'),
});

return {
Expand Down
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/contexts/components/SignUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -121,6 +121,7 @@ export const useSignUpContext = (): SignUpContextType => {
path: ctx.path,
routing: ctx.routing,
baseUrl: signUpUrl,
taskUrls: clerk.__internal_getOption('taskUrls'),
});

return {
Expand Down
10 changes: 9 additions & 1 deletion packages/types/src/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,7 @@
SignUpFallbackRedirectUrl,
SignUpForceRedirectUrl,
} from './redirects';
import type { PendingSessionOptions, SignedInSessionResource } from './session';
import type { PendingSessionOptions, SessionTask, SignedInSessionResource } from './session';
import type { SessionVerificationLevel } from './sessionVerification';
import type { SignInResource } from './signIn';
import type { SignUpResource } from './signUp';
Expand DownExpand Up@@ -1050,6 +1050,14 @@
* @internal
*/
__internal_keyless_dismissPrompt?: (() => Promise<void>) | null;

/**
* Customize the URL paths users are redirected to after sign-in or sign-up when specific
* session tasks need to be completed.
*
* @default undefined - Uses Clerk's default task flow URLs
*/
taskUrls?: Record<SessionTask['key'], string>;
};

export interface NavigateOptions {
Expand DownExpand Up@@ -1114,7 +1122,7 @@
*/
windowNavigate: (to: URL | string) => void;
},
) => Promise<unknown> | unknown;

Check warning on line 1125 in packages/types/src/clerk.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

'unknown' overrides all other types in this union type

export type WithoutRouting<T> = Omit<T, 'path' | 'routing'>;

Expand Down
7 changes: 7 additions & 0 deletions packages/types/src/session.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -326,7 +326,14 @@ export interface PublicUserData {
userId?: string;
}

/**
* Represents a required action that a user must complete
* before their session becomes fully active
*/
export interface SessionTask {
/**
* The unique identifier for the type of task that needs to be completed
*/
key: 'org';
}

Expand Down
Loading