fix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddleware - #6477

Merged
LauraBeatris merged 2 commits into
mainfrom
laura/fix-pending-auth-object-middleware-handler
Aug 5, 2025
Merged

fix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddleware#6477
LauraBeatris merged 2 commits into
mainfrom
laura/fix-pending-auth-object-middleware-handler

Conversation

@LauraBeatris

@LauraBeatrisLauraBeatris commented Aug 5, 2025•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Previously, the treatPendingAsSignedOut wasn't being propagated to the clerkMiddleware handler. This PR fixes it by resolving the auth object on the handler itself using that option.

exportdefaultclerkMiddleware((auth,req)=>{// If the session has a `pending` status, `userId` will be `null` by default, treated as a signed-out stateconst{ userId }=awaitauth()})
exportdefaultclerkMiddleware((auth,req)=>{// If the session has a `pending` status, `userId` will be defined, treated as a signed-in stateconst{ userId }=awaitauth({treatPendingAsSignedOut: false})})

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Documentation

    • Added examples and improved documentation for handling pending sessions with the authentication middleware, clarifying how to control whether pending sessions are treated as signed in or signed out.

  • New Features

    • Introduced an option to explicitly control how pending authentication sessions are interpreted in middleware, allowing more flexible session handling for end-users.

@LauraBeatrisLauraBeatris self-assigned this Aug 5, 2025
@vercel

vercelBot commented Aug 5, 2025•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackAug 5, 2025 7:09pm

@changeset-bot

changeset-botBot commented Aug 5, 2025•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1a8024a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/nextjsPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LauraBeatris
LauraBeatrisforce-pushed the laura/fix-pending-auth-object-middleware-handler branch from 7537036 to 5733359CompareAugust 5, 2025 16:55
@LauraBeatrisLauraBeatris changed the title fix(backend): Propagate treatPendingAsSignedOut to auth from clerkMiddlewarefix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddlewareAug 5, 2025
@LauraBeatrisLauraBeatris changed the title fix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddlewarefix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddlewareAug 5, 2025
@LauraBeatris
LauraBeatrisforce-pushed the laura/fix-pending-auth-object-middleware-handler branch from 1040314 to 1f127e5CompareAugust 5, 2025 17:04
@LauraBeatris
LauraBeatris marked this pull request as ready for review August 5, 2025 17:04
@LauraBeatris
LauraBeatris requested a review from a teamAugust 5, 2025 17:04
@coderabbitai

coderabbitaiBot commented Aug 5, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This change updates the clerkMiddleware in the @clerk/nextjs package to propagate the treatPendingAsSignedOut option to the auth function. It modifies the function signature of createMiddlewareAuthHandler to accept a requestState parameter of type AuthenticatedState<'session_token'> | UnauthenticatedState<'session_token'> instead of a precomputed authObject. The conversion to an auth object is deferred until inside the handler by calling requestState.toAuth() with the treatPendingAsSignedOut option. Usage examples and documentation are added to demonstrate how the option affects session handling for pending states, allowing explicit control over whether pending sessions are treated as signed out or signed in.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c00fd88 and 1a8024a.

📒 Files selected for processing (2)
  • .changeset/tricky-planets-cry.md (1 hunks)
  • packages/nextjs/src/server/clerkMiddleware.ts (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • .changeset/tricky-planets-cry.md
  • packages/nextjs/src/server/clerkMiddleware.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (21)
  • GitHub Check: Integration Tests (nextjs, chrome, 14)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (expo-web, chrome)
  • GitHub Check: Integration Tests (tanstack-react-router, chrome)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: Integration Tests (elements, chrome)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Publish with pkg-pr-new
  • GitHub Check: Unit Tests (22, **)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome)
  • GitHub Check: Unit Tests (18, --filter=@clerk/astro --filter=@clerk/backend --filter=@clerk/express --filter=@c...
  • GitHub Check: Static analysis
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@LauraBeatris
LauraBeatrisforce-pushed the laura/fix-pending-auth-object-middleware-handler branch from 1f127e5 to c00fd88CompareAugust 5, 2025 17:08
@pkg-pr-new

pkg-pr-newBot commented Aug 5, 2025•
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6477

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6477

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6477

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6477

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6477

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6477

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6477

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6477

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6477

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6477

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6477

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6477

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6477

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6477

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6477

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6477

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6477

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6477

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6477

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6477

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6477

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6477

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6477

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6477

commit: 1a8024a

iagodahlem
iagodahlem approved these changes Aug 5, 2025
View reviewed changes
Comment thread.changeset/tricky-planets-cry.md Outdated
Comment thread.changeset/tricky-planets-cry.md Outdated
@LauraBeatris
LauraBeatrisforce-pushed the laura/fix-pending-auth-object-middleware-handler branch from c00fd88 to 9b07830CompareAugust 5, 2025 19:07
@LauraBeatris
LauraBeatrisforce-pushed the laura/fix-pending-auth-object-middleware-handler branch from 9b07830 to 1a8024aCompareAugust 5, 2025 19:07
@LauraBeatris
LauraBeatris merged commit 90acc76 into mainAug 5, 2025
36 checks passed
@LauraBeatris
LauraBeatris deleted the laura/fix-pending-auth-object-middleware-handler branch August 5, 2025 20:26
@clerk-cookieclerk-cookie mentioned this pull request Aug 5, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@iagodahlemiagodahlemiagodahlem approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LauraBeatrisLauraBeatris

Labels

nextjs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@iagodahlem@clerk-cookie
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddleware - #6477
Merged
LauraBeatris merged 2 commits into
mainfrom 
laura/fix-pending-auth-object-middleware-handler
Aug 5, 2025
Merged
fix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddleware#6477
LauraBeatris merged 2 commits into
mainfrom 
laura/fix-pending-auth-object-middleware-handler
Conversation
@LauraBeatris
@LauraBeatrisLauraBeatris
commented
Aug 5, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
Previously, the treatPendingAsSignedOut wasn't being propagated to the clerkMiddleware handler. This PR fixes it by resolving the auth object on the handler itself using that option.
exportdefaultclerkMiddleware((auth,req)=>{// If the session has a `pending` status, `userId` will be `null` by default, treated as a signed-out stateconst{ userId }=awaitauth()})
exportdefaultclerkMiddleware((auth,req)=>{// If the session has a `pending` status, `userId` will be defined, treated as a signed-in stateconst{ userId }=awaitauth({treatPendingAsSignedOut: false})})
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Documentation
    • Added examples and improved documentation for handling pending sessions with the authentication middleware, clarifying how to control whether pending sessions are treated as signed in or signed out.
  • New Features
    • Introduced an option to explicitly control how pending authentication sessions are interpreted in middleware, allowing more flexible session handling for end-users.
@LauraBeatrisLauraBeatris
self-assigned this
Aug 5, 2025
@vercel
vercelBot
commented
Aug 5, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackAug 5, 2025 7:09pm
@changeset-bot
changeset-botBot
commented
Aug 5, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 1a8024a
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/nextjsPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
7537036 to
5733359CompareAugust 5, 2025 16:55
@LauraBeatrisLauraBeatris
changed the title
fix(backend): Propagate treatPendingAsSignedOut to auth from clerkMiddlewarefix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddlewareAug 5, 2025
@LauraBeatrisLauraBeatris
changed the title
fix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddlewarefix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddlewareAug 5, 2025
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
1040314 to
1f127e5CompareAugust 5, 2025 17:04
@LauraBeatris
LauraBeatris
marked this pull request as ready for review
August 5, 2025 17:04
@LauraBeatris
LauraBeatris
requested a review
from a teamAugust 5, 2025 17:04
@coderabbitai
coderabbitaiBot
commented
Aug 5, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
This change updates the clerkMiddleware in the @clerk/nextjs package to propagate the treatPendingAsSignedOut option to the auth function. It modifies the function signature of createMiddlewareAuthHandler to accept a requestState parameter of type AuthenticatedState<'session_token'> | UnauthenticatedState<'session_token'> instead of a precomputed authObject. The conversion to an auth object is deferred until inside the handler by calling requestState.toAuth() with the treatPendingAsSignedOut option. Usage examples and documentation are added to demonstrate how the option affects session handling for pending states, allowing explicit control over whether pending sessions are treated as signed out or signed in.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~8 minutes
Note
⚡️ Unit Test Generation is now available in beta!
Learn more here, or try it out under "Finishing Touches" below.
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between c00fd88 and 1a8024a.
📒 Files selected for processing (2)
  • .changeset/tricky-planets-cry.md (1 hunks)
  • packages/nextjs/src/server/clerkMiddleware.ts (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • .changeset/tricky-planets-cry.md
  • packages/nextjs/src/server/clerkMiddleware.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (21)
  • GitHub Check: Integration Tests (nextjs, chrome, 14)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (expo-web, chrome)
  • GitHub Check: Integration Tests (tanstack-react-router, chrome)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: Integration Tests (elements, chrome)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Publish with pkg-pr-new
  • GitHub Check: Unit Tests (22, **)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome)
  • GitHub Check: Unit Tests (18, --filter=@clerk/astro --filter=@clerk/backend --filter=@clerk/express --filter=@c...
  • GitHub Check: Static analysis
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:

    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:

    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:

    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
CodeRabbit Commands (Invoked using PR comments)
  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.
Other keywords and placeholders
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
1f127e5 to
c00fd88CompareAugust 5, 2025 17:08
@pkg-pr-new
pkg-pr-newBot
commented
Aug 5, 2025•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@6477

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@6477

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@6477

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@6477

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@6477

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@6477

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@6477

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@6477

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@6477

@clerk/express
npm i https://pkg.pr.new/@clerk/express@6477

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@6477

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@6477

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@6477

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@6477

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@6477

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@6477

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@6477

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@6477

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@6477

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@6477

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@6477

@clerk/types
npm i https://pkg.pr.new/@clerk/types@6477

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@6477

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@6477

commit: 1a8024a
iagodahlem
iagodahlem
approved these changes
Aug 5, 2025
View reviewed changes
Comment thread.changeset/tricky-planets-cry.md
Outdated

Comment thread.changeset/tricky-planets-cry.md
Outdated

@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
c00fd88 to
9b07830CompareAugust 5, 2025 19:07
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
9b07830 to
1a8024aCompareAugust 5, 2025 19:07
@LauraBeatris
LauraBeatris
merged commit 90acc76
into
mainAug 5, 2025

36 checks passed

@LauraBeatris
LauraBeatris
deleted the

laura/fix-pending-auth-object-middleware-handler

branch
August 5, 2025 20:26
@clerk-cookieclerk-cookie
mentioned this pull request
Aug 5, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@iagodahlemiagodahlemiagodahlem approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LauraBeatrisLauraBeatris

Labels

nextjs

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@iagodahlem@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddleware - #6477
Merged
LauraBeatris merged 2 commits into
mainfrom 
laura/fix-pending-auth-object-middleware-handler
Aug 5, 2025
Merged
fix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddleware#6477
LauraBeatris merged 2 commits into
mainfrom 
laura/fix-pending-auth-object-middleware-handler
Conversation
@LauraBeatris
@LauraBeatrisLauraBeatris
commented
Aug 5, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
Previously, the treatPendingAsSignedOut wasn't being propagated to the clerkMiddleware handler. This PR fixes it by resolving the auth object on the handler itself using that option.
exportdefaultclerkMiddleware((auth,req)=>{// If the session has a `pending` status, `userId` will be `null` by default, treated as a signed-out stateconst{ userId }=awaitauth()})
exportdefaultclerkMiddleware((auth,req)=>{// If the session has a `pending` status, `userId` will be defined, treated as a signed-in stateconst{ userId }=awaitauth({treatPendingAsSignedOut: false})})
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Documentation
    • Added examples and improved documentation for handling pending sessions with the authentication middleware, clarifying how to control whether pending sessions are treated as signed in or signed out.
  • New Features
    • Introduced an option to explicitly control how pending authentication sessions are interpreted in middleware, allowing more flexible session handling for end-users.
@LauraBeatrisLauraBeatris
self-assigned this
Aug 5, 2025
@vercel
vercelBot
commented
Aug 5, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackAug 5, 2025 7:09pm
@changeset-bot
changeset-botBot
commented
Aug 5, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 1a8024a
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/nextjsPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
7537036 to
5733359CompareAugust 5, 2025 16:55
@LauraBeatrisLauraBeatris
changed the title
fix(backend): Propagate treatPendingAsSignedOut to auth from clerkMiddlewarefix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddlewareAug 5, 2025
@LauraBeatrisLauraBeatris
changed the title
fix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddlewarefix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddlewareAug 5, 2025
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
1040314 to
1f127e5CompareAugust 5, 2025 17:04
@LauraBeatris
LauraBeatris
marked this pull request as ready for review
August 5, 2025 17:04
@LauraBeatris
LauraBeatris
requested a review
from a teamAugust 5, 2025 17:04
@coderabbitai
coderabbitaiBot
commented
Aug 5, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
This change updates the clerkMiddleware in the @clerk/nextjs package to propagate the treatPendingAsSignedOut option to the auth function. It modifies the function signature of createMiddlewareAuthHandler to accept a requestState parameter of type AuthenticatedState<'session_token'> | UnauthenticatedState<'session_token'> instead of a precomputed authObject. The conversion to an auth object is deferred until inside the handler by calling requestState.toAuth() with the treatPendingAsSignedOut option. Usage examples and documentation are added to demonstrate how the option affects session handling for pending states, allowing explicit control over whether pending sessions are treated as signed out or signed in.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~8 minutes
Note
⚡️ Unit Test Generation is now available in beta!
Learn more here, or try it out under "Finishing Touches" below.
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between c00fd88 and 1a8024a.
📒 Files selected for processing (2)
  • .changeset/tricky-planets-cry.md (1 hunks)
  • packages/nextjs/src/server/clerkMiddleware.ts (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • .changeset/tricky-planets-cry.md
  • packages/nextjs/src/server/clerkMiddleware.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (21)
  • GitHub Check: Integration Tests (nextjs, chrome, 14)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (expo-web, chrome)
  • GitHub Check: Integration Tests (tanstack-react-router, chrome)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: Integration Tests (elements, chrome)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Publish with pkg-pr-new
  • GitHub Check: Unit Tests (22, **)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome)
  • GitHub Check: Unit Tests (18, --filter=@clerk/astro --filter=@clerk/backend --filter=@clerk/express --filter=@c...
  • GitHub Check: Static analysis
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:

    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:

    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:

    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
CodeRabbit Commands (Invoked using PR comments)
  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.
Other keywords and placeholders
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
1f127e5 to
c00fd88CompareAugust 5, 2025 17:08
@pkg-pr-new
pkg-pr-newBot
commented
Aug 5, 2025•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@6477

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@6477

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@6477

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@6477

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@6477

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@6477

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@6477

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@6477

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@6477

@clerk/express
npm i https://pkg.pr.new/@clerk/express@6477

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@6477

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@6477

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@6477

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@6477

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@6477

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@6477

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@6477

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@6477

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@6477

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@6477

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@6477

@clerk/types
npm i https://pkg.pr.new/@clerk/types@6477

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@6477

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@6477

commit: 1a8024a
iagodahlem
iagodahlem
approved these changes
Aug 5, 2025
View reviewed changes
Comment thread.changeset/tricky-planets-cry.md
Outdated

Comment thread.changeset/tricky-planets-cry.md
Outdated

@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
c00fd88 to
9b07830CompareAugust 5, 2025 19:07
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
9b07830 to
1a8024aCompareAugust 5, 2025 19:07
@LauraBeatris
LauraBeatris
merged commit 90acc76
into
mainAug 5, 2025

36 checks passed

@LauraBeatris
LauraBeatris
deleted the

laura/fix-pending-auth-object-middleware-handler

branch
August 5, 2025 20:26
@clerk-cookieclerk-cookie
mentioned this pull request
Aug 5, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@iagodahlemiagodahlemiagodahlem approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LauraBeatrisLauraBeatris

Labels

nextjs

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@iagodahlem@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddleware - #6477
Merged
LauraBeatris merged 2 commits into
mainfrom 
laura/fix-pending-auth-object-middleware-handler
Aug 5, 2025
Merged
fix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddleware#6477
LauraBeatris merged 2 commits into
mainfrom 
laura/fix-pending-auth-object-middleware-handler
Conversation
@LauraBeatris
@LauraBeatrisLauraBeatris
commented
Aug 5, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
Previously, the treatPendingAsSignedOut wasn't being propagated to the clerkMiddleware handler. This PR fixes it by resolving the auth object on the handler itself using that option.
exportdefaultclerkMiddleware((auth,req)=>{// If the session has a `pending` status, `userId` will be `null` by default, treated as a signed-out stateconst{ userId }=awaitauth()})
exportdefaultclerkMiddleware((auth,req)=>{// If the session has a `pending` status, `userId` will be defined, treated as a signed-in stateconst{ userId }=awaitauth({treatPendingAsSignedOut: false})})
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Documentation
    • Added examples and improved documentation for handling pending sessions with the authentication middleware, clarifying how to control whether pending sessions are treated as signed in or signed out.
  • New Features
    • Introduced an option to explicitly control how pending authentication sessions are interpreted in middleware, allowing more flexible session handling for end-users.
@LauraBeatrisLauraBeatris
self-assigned this
Aug 5, 2025
@vercel
vercelBot
commented
Aug 5, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackAug 5, 2025 7:09pm
@changeset-bot
changeset-botBot
commented
Aug 5, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 1a8024a
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/nextjsPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
7537036 to
5733359CompareAugust 5, 2025 16:55
@LauraBeatrisLauraBeatris
changed the title
fix(backend): Propagate treatPendingAsSignedOut to auth from clerkMiddlewarefix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddlewareAug 5, 2025
@LauraBeatrisLauraBeatris
changed the title
fix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddlewarefix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddlewareAug 5, 2025
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
1040314 to
1f127e5CompareAugust 5, 2025 17:04
@LauraBeatris
LauraBeatris
marked this pull request as ready for review
August 5, 2025 17:04
@LauraBeatris
LauraBeatris
requested a review
from a teamAugust 5, 2025 17:04
@coderabbitai
coderabbitaiBot
commented
Aug 5, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
This change updates the clerkMiddleware in the @clerk/nextjs package to propagate the treatPendingAsSignedOut option to the auth function. It modifies the function signature of createMiddlewareAuthHandler to accept a requestState parameter of type AuthenticatedState<'session_token'> | UnauthenticatedState<'session_token'> instead of a precomputed authObject. The conversion to an auth object is deferred until inside the handler by calling requestState.toAuth() with the treatPendingAsSignedOut option. Usage examples and documentation are added to demonstrate how the option affects session handling for pending states, allowing explicit control over whether pending sessions are treated as signed out or signed in.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~8 minutes
Note
⚡️ Unit Test Generation is now available in beta!
Learn more here, or try it out under "Finishing Touches" below.
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between c00fd88 and 1a8024a.
📒 Files selected for processing (2)
  • .changeset/tricky-planets-cry.md (1 hunks)
  • packages/nextjs/src/server/clerkMiddleware.ts (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • .changeset/tricky-planets-cry.md
  • packages/nextjs/src/server/clerkMiddleware.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (21)
  • GitHub Check: Integration Tests (nextjs, chrome, 14)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (expo-web, chrome)
  • GitHub Check: Integration Tests (tanstack-react-router, chrome)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: Integration Tests (elements, chrome)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Publish with pkg-pr-new
  • GitHub Check: Unit Tests (22, **)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome)
  • GitHub Check: Unit Tests (18, --filter=@clerk/astro --filter=@clerk/backend --filter=@clerk/express --filter=@c...
  • GitHub Check: Static analysis
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:

    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:

    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:

    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
CodeRabbit Commands (Invoked using PR comments)
  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.
Other keywords and placeholders
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
1f127e5 to
c00fd88CompareAugust 5, 2025 17:08
@pkg-pr-new
pkg-pr-newBot
commented
Aug 5, 2025•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@6477

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@6477

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@6477

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@6477

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@6477

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@6477

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@6477

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@6477

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@6477

@clerk/express
npm i https://pkg.pr.new/@clerk/express@6477

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@6477

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@6477

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@6477

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@6477

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@6477

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@6477

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@6477

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@6477

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@6477

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@6477

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@6477

@clerk/types
npm i https://pkg.pr.new/@clerk/types@6477

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@6477

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@6477

commit: 1a8024a
iagodahlem
iagodahlem
approved these changes
Aug 5, 2025
View reviewed changes
Comment thread.changeset/tricky-planets-cry.md
Outdated

Comment thread.changeset/tricky-planets-cry.md
Outdated

@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
c00fd88 to
9b07830CompareAugust 5, 2025 19:07
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
9b07830 to
1a8024aCompareAugust 5, 2025 19:07
@LauraBeatris
LauraBeatris
merged commit 90acc76
into
mainAug 5, 2025

36 checks passed

@LauraBeatris
LauraBeatris
deleted the

laura/fix-pending-auth-object-middleware-handler

branch
August 5, 2025 20:26
@clerk-cookieclerk-cookie
mentioned this pull request
Aug 5, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@iagodahlemiagodahlemiagodahlem approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LauraBeatrisLauraBeatris

Labels

nextjs

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@iagodahlem@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddleware - #6477
Merged
LauraBeatris merged 2 commits into
mainfrom 
laura/fix-pending-auth-object-middleware-handler
Aug 5, 2025
Merged
fix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddleware#6477
LauraBeatris merged 2 commits into
mainfrom 
laura/fix-pending-auth-object-middleware-handler
Conversation
@LauraBeatris
@LauraBeatrisLauraBeatris
commented
Aug 5, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
Previously, the treatPendingAsSignedOut wasn't being propagated to the clerkMiddleware handler. This PR fixes it by resolving the auth object on the handler itself using that option.
exportdefaultclerkMiddleware((auth,req)=>{// If the session has a `pending` status, `userId` will be `null` by default, treated as a signed-out stateconst{ userId }=awaitauth()})
exportdefaultclerkMiddleware((auth,req)=>{// If the session has a `pending` status, `userId` will be defined, treated as a signed-in stateconst{ userId }=awaitauth({treatPendingAsSignedOut: false})})
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Documentation
    • Added examples and improved documentation for handling pending sessions with the authentication middleware, clarifying how to control whether pending sessions are treated as signed in or signed out.
  • New Features
    • Introduced an option to explicitly control how pending authentication sessions are interpreted in middleware, allowing more flexible session handling for end-users.
@LauraBeatrisLauraBeatris
self-assigned this
Aug 5, 2025
@vercel
vercelBot
commented
Aug 5, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackAug 5, 2025 7:09pm
@changeset-bot
changeset-botBot
commented
Aug 5, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 1a8024a
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/nextjsPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
7537036 to
5733359CompareAugust 5, 2025 16:55
@LauraBeatrisLauraBeatris
changed the title
fix(backend): Propagate treatPendingAsSignedOut to auth from clerkMiddlewarefix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddlewareAug 5, 2025
@LauraBeatrisLauraBeatris
changed the title
fix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddlewarefix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddlewareAug 5, 2025
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
1040314 to
1f127e5CompareAugust 5, 2025 17:04
@LauraBeatris
LauraBeatris
marked this pull request as ready for review
August 5, 2025 17:04
@LauraBeatris
LauraBeatris
requested a review
from a teamAugust 5, 2025 17:04
@coderabbitai
coderabbitaiBot
commented
Aug 5, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
This change updates the clerkMiddleware in the @clerk/nextjs package to propagate the treatPendingAsSignedOut option to the auth function. It modifies the function signature of createMiddlewareAuthHandler to accept a requestState parameter of type AuthenticatedState<'session_token'> | UnauthenticatedState<'session_token'> instead of a precomputed authObject. The conversion to an auth object is deferred until inside the handler by calling requestState.toAuth() with the treatPendingAsSignedOut option. Usage examples and documentation are added to demonstrate how the option affects session handling for pending states, allowing explicit control over whether pending sessions are treated as signed out or signed in.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~8 minutes
Note
⚡️ Unit Test Generation is now available in beta!
Learn more here, or try it out under "Finishing Touches" below.
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between c00fd88 and 1a8024a.
📒 Files selected for processing (2)
  • .changeset/tricky-planets-cry.md (1 hunks)
  • packages/nextjs/src/server/clerkMiddleware.ts (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • .changeset/tricky-planets-cry.md
  • packages/nextjs/src/server/clerkMiddleware.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (21)
  • GitHub Check: Integration Tests (nextjs, chrome, 14)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (expo-web, chrome)
  • GitHub Check: Integration Tests (tanstack-react-router, chrome)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: Integration Tests (elements, chrome)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Publish with pkg-pr-new
  • GitHub Check: Unit Tests (22, **)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome)
  • GitHub Check: Unit Tests (18, --filter=@clerk/astro --filter=@clerk/backend --filter=@clerk/express --filter=@c...
  • GitHub Check: Static analysis
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:

    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:

    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:

    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
CodeRabbit Commands (Invoked using PR comments)
  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.
Other keywords and placeholders
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
1f127e5 to
c00fd88CompareAugust 5, 2025 17:08
@pkg-pr-new
pkg-pr-newBot
commented
Aug 5, 2025•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@6477

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@6477

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@6477

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@6477

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@6477

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@6477

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@6477

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@6477

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@6477

@clerk/express
npm i https://pkg.pr.new/@clerk/express@6477

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@6477

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@6477

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@6477

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@6477

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@6477

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@6477

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@6477

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@6477

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@6477

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@6477

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@6477

@clerk/types
npm i https://pkg.pr.new/@clerk/types@6477

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@6477

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@6477

commit: 1a8024a
iagodahlem
iagodahlem
approved these changes
Aug 5, 2025
View reviewed changes
Comment thread.changeset/tricky-planets-cry.md
Outdated

Comment thread.changeset/tricky-planets-cry.md
Outdated

@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
c00fd88 to
9b07830CompareAugust 5, 2025 19:07
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
9b07830 to
1a8024aCompareAugust 5, 2025 19:07
@LauraBeatris
LauraBeatris
merged commit 90acc76
into
mainAug 5, 2025

36 checks passed

@LauraBeatris
LauraBeatris
deleted the

laura/fix-pending-auth-object-middleware-handler

branch
August 5, 2025 20:26
@clerk-cookieclerk-cookie
mentioned this pull request
Aug 5, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@iagodahlemiagodahlemiagodahlem approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LauraBeatrisLauraBeatris

Labels

nextjs

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@iagodahlem@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddleware - #6477
Merged
LauraBeatris merged 2 commits into
mainfrom 
laura/fix-pending-auth-object-middleware-handler
Aug 5, 2025
Merged
fix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddleware#6477
LauraBeatris merged 2 commits into
mainfrom 
laura/fix-pending-auth-object-middleware-handler
Conversation
@LauraBeatris
@LauraBeatrisLauraBeatris
commented
Aug 5, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
Previously, the treatPendingAsSignedOut wasn't being propagated to the clerkMiddleware handler. This PR fixes it by resolving the auth object on the handler itself using that option.
exportdefaultclerkMiddleware((auth,req)=>{// If the session has a `pending` status, `userId` will be `null` by default, treated as a signed-out stateconst{ userId }=awaitauth()})
exportdefaultclerkMiddleware((auth,req)=>{// If the session has a `pending` status, `userId` will be defined, treated as a signed-in stateconst{ userId }=awaitauth({treatPendingAsSignedOut: false})})
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Documentation
    • Added examples and improved documentation for handling pending sessions with the authentication middleware, clarifying how to control whether pending sessions are treated as signed in or signed out.
  • New Features
    • Introduced an option to explicitly control how pending authentication sessions are interpreted in middleware, allowing more flexible session handling for end-users.
@LauraBeatrisLauraBeatris
self-assigned this
Aug 5, 2025
@vercel
vercelBot
commented
Aug 5, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackAug 5, 2025 7:09pm
@changeset-bot
changeset-botBot
commented
Aug 5, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 1a8024a
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/nextjsPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
7537036 to
5733359CompareAugust 5, 2025 16:55
@LauraBeatrisLauraBeatris
changed the title
fix(backend): Propagate treatPendingAsSignedOut to auth from clerkMiddlewarefix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddlewareAug 5, 2025
@LauraBeatrisLauraBeatris
changed the title
fix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddlewarefix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddlewareAug 5, 2025
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
1040314 to
1f127e5CompareAugust 5, 2025 17:04
@LauraBeatris
LauraBeatris
marked this pull request as ready for review
August 5, 2025 17:04
@LauraBeatris
LauraBeatris
requested a review
from a teamAugust 5, 2025 17:04
@coderabbitai
coderabbitaiBot
commented
Aug 5, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
This change updates the clerkMiddleware in the @clerk/nextjs package to propagate the treatPendingAsSignedOut option to the auth function. It modifies the function signature of createMiddlewareAuthHandler to accept a requestState parameter of type AuthenticatedState<'session_token'> | UnauthenticatedState<'session_token'> instead of a precomputed authObject. The conversion to an auth object is deferred until inside the handler by calling requestState.toAuth() with the treatPendingAsSignedOut option. Usage examples and documentation are added to demonstrate how the option affects session handling for pending states, allowing explicit control over whether pending sessions are treated as signed out or signed in.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~8 minutes
Note
⚡️ Unit Test Generation is now available in beta!
Learn more here, or try it out under "Finishing Touches" below.
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between c00fd88 and 1a8024a.
📒 Files selected for processing (2)
  • .changeset/tricky-planets-cry.md (1 hunks)
  • packages/nextjs/src/server/clerkMiddleware.ts (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • .changeset/tricky-planets-cry.md
  • packages/nextjs/src/server/clerkMiddleware.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (21)
  • GitHub Check: Integration Tests (nextjs, chrome, 14)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (expo-web, chrome)
  • GitHub Check: Integration Tests (tanstack-react-router, chrome)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: Integration Tests (elements, chrome)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Publish with pkg-pr-new
  • GitHub Check: Unit Tests (22, **)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome)
  • GitHub Check: Unit Tests (18, --filter=@clerk/astro --filter=@clerk/backend --filter=@clerk/express --filter=@c...
  • GitHub Check: Static analysis
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:

    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:

    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:

    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
CodeRabbit Commands (Invoked using PR comments)
  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.
Other keywords and placeholders
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
1f127e5 to
c00fd88CompareAugust 5, 2025 17:08
@pkg-pr-new
pkg-pr-newBot
commented
Aug 5, 2025•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@6477

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@6477

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@6477

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@6477

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@6477

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@6477

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@6477

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@6477

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@6477

@clerk/express
npm i https://pkg.pr.new/@clerk/express@6477

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@6477

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@6477

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@6477

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@6477

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@6477

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@6477

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@6477

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@6477

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@6477

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@6477

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@6477

@clerk/types
npm i https://pkg.pr.new/@clerk/types@6477

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@6477

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@6477

commit: 1a8024a
iagodahlem
iagodahlem
approved these changes
Aug 5, 2025
View reviewed changes
Comment thread.changeset/tricky-planets-cry.md
Outdated

Comment thread.changeset/tricky-planets-cry.md
Outdated

@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
c00fd88 to
9b07830CompareAugust 5, 2025 19:07
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
9b07830 to
1a8024aCompareAugust 5, 2025 19:07
@LauraBeatris
LauraBeatris
merged commit 90acc76
into
mainAug 5, 2025

36 checks passed

@LauraBeatris
LauraBeatris
deleted the

laura/fix-pending-auth-object-middleware-handler

branch
August 5, 2025 20:26
@clerk-cookieclerk-cookie
mentioned this pull request
Aug 5, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@iagodahlemiagodahlemiagodahlem approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LauraBeatrisLauraBeatris

Labels

nextjs

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@iagodahlem@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddleware - #6477
Merged
LauraBeatris merged 2 commits into
mainfrom 
laura/fix-pending-auth-object-middleware-handler
Aug 5, 2025
Merged
fix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddleware#6477
LauraBeatris merged 2 commits into
mainfrom 
laura/fix-pending-auth-object-middleware-handler
Conversation
@LauraBeatris
@LauraBeatrisLauraBeatris
commented
Aug 5, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
Previously, the treatPendingAsSignedOut wasn't being propagated to the clerkMiddleware handler. This PR fixes it by resolving the auth object on the handler itself using that option.
exportdefaultclerkMiddleware((auth,req)=>{// If the session has a `pending` status, `userId` will be `null` by default, treated as a signed-out stateconst{ userId }=awaitauth()})
exportdefaultclerkMiddleware((auth,req)=>{// If the session has a `pending` status, `userId` will be defined, treated as a signed-in stateconst{ userId }=awaitauth({treatPendingAsSignedOut: false})})
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Documentation
    • Added examples and improved documentation for handling pending sessions with the authentication middleware, clarifying how to control whether pending sessions are treated as signed in or signed out.
  • New Features
    • Introduced an option to explicitly control how pending authentication sessions are interpreted in middleware, allowing more flexible session handling for end-users.
@LauraBeatrisLauraBeatris
self-assigned this
Aug 5, 2025
@vercel
vercelBot
commented
Aug 5, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackAug 5, 2025 7:09pm
@changeset-bot
changeset-botBot
commented
Aug 5, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 1a8024a
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/nextjsPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
7537036 to
5733359CompareAugust 5, 2025 16:55
@LauraBeatrisLauraBeatris
changed the title
fix(backend): Propagate treatPendingAsSignedOut to auth from clerkMiddlewarefix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddlewareAug 5, 2025
@LauraBeatrisLauraBeatris
changed the title
fix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddlewarefix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddlewareAug 5, 2025
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
1040314 to
1f127e5CompareAugust 5, 2025 17:04
@LauraBeatris
LauraBeatris
marked this pull request as ready for review
August 5, 2025 17:04
@LauraBeatris
LauraBeatris
requested a review
from a teamAugust 5, 2025 17:04
@coderabbitai
coderabbitaiBot
commented
Aug 5, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
This change updates the clerkMiddleware in the @clerk/nextjs package to propagate the treatPendingAsSignedOut option to the auth function. It modifies the function signature of createMiddlewareAuthHandler to accept a requestState parameter of type AuthenticatedState<'session_token'> | UnauthenticatedState<'session_token'> instead of a precomputed authObject. The conversion to an auth object is deferred until inside the handler by calling requestState.toAuth() with the treatPendingAsSignedOut option. Usage examples and documentation are added to demonstrate how the option affects session handling for pending states, allowing explicit control over whether pending sessions are treated as signed out or signed in.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~8 minutes
Note
⚡️ Unit Test Generation is now available in beta!
Learn more here, or try it out under "Finishing Touches" below.
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between c00fd88 and 1a8024a.
📒 Files selected for processing (2)
  • .changeset/tricky-planets-cry.md (1 hunks)
  • packages/nextjs/src/server/clerkMiddleware.ts (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • .changeset/tricky-planets-cry.md
  • packages/nextjs/src/server/clerkMiddleware.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (21)
  • GitHub Check: Integration Tests (nextjs, chrome, 14)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (expo-web, chrome)
  • GitHub Check: Integration Tests (tanstack-react-router, chrome)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: Integration Tests (elements, chrome)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Publish with pkg-pr-new
  • GitHub Check: Unit Tests (22, **)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome)
  • GitHub Check: Unit Tests (18, --filter=@clerk/astro --filter=@clerk/backend --filter=@clerk/express --filter=@c...
  • GitHub Check: Static analysis
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:

    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:

    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:

    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
CodeRabbit Commands (Invoked using PR comments)
  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.
Other keywords and placeholders
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
1f127e5 to
c00fd88CompareAugust 5, 2025 17:08
@pkg-pr-new
pkg-pr-newBot
commented
Aug 5, 2025•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@6477

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@6477

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@6477

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@6477

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@6477

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@6477

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@6477

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@6477

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@6477

@clerk/express
npm i https://pkg.pr.new/@clerk/express@6477

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@6477

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@6477

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@6477

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@6477

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@6477

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@6477

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@6477

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@6477

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@6477

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@6477

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@6477

@clerk/types
npm i https://pkg.pr.new/@clerk/types@6477

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@6477

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@6477

commit: 1a8024a
iagodahlem
iagodahlem
approved these changes
Aug 5, 2025
View reviewed changes
Comment thread.changeset/tricky-planets-cry.md
Outdated

Comment thread.changeset/tricky-planets-cry.md
Outdated

@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
c00fd88 to
9b07830CompareAugust 5, 2025 19:07
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
9b07830 to
1a8024aCompareAugust 5, 2025 19:07
@LauraBeatris
LauraBeatris
merged commit 90acc76
into
mainAug 5, 2025

36 checks passed

@LauraBeatris
LauraBeatris
deleted the

laura/fix-pending-auth-object-middleware-handler

branch
August 5, 2025 20:26
@clerk-cookieclerk-cookie
mentioned this pull request
Aug 5, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@iagodahlemiagodahlemiagodahlem approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LauraBeatrisLauraBeatris

Labels

nextjs

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@iagodahlem@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddleware - #6477
Merged
LauraBeatris merged 2 commits into
mainfrom 
laura/fix-pending-auth-object-middleware-handler
Aug 5, 2025
Merged
fix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddleware#6477
LauraBeatris merged 2 commits into
mainfrom 
laura/fix-pending-auth-object-middleware-handler
Conversation
@LauraBeatris
@LauraBeatrisLauraBeatris
commented
Aug 5, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
Previously, the treatPendingAsSignedOut wasn't being propagated to the clerkMiddleware handler. This PR fixes it by resolving the auth object on the handler itself using that option.
exportdefaultclerkMiddleware((auth,req)=>{// If the session has a `pending` status, `userId` will be `null` by default, treated as a signed-out stateconst{ userId }=awaitauth()})
exportdefaultclerkMiddleware((auth,req)=>{// If the session has a `pending` status, `userId` will be defined, treated as a signed-in stateconst{ userId }=awaitauth({treatPendingAsSignedOut: false})})
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Documentation
    • Added examples and improved documentation for handling pending sessions with the authentication middleware, clarifying how to control whether pending sessions are treated as signed in or signed out.
  • New Features
    • Introduced an option to explicitly control how pending authentication sessions are interpreted in middleware, allowing more flexible session handling for end-users.
@LauraBeatrisLauraBeatris
self-assigned this
Aug 5, 2025
@vercel
vercelBot
commented
Aug 5, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
clerk-js-sandbox✅ Ready (Inspect)Visit Preview💬 Add feedbackAug 5, 2025 7:09pm
@changeset-bot
changeset-botBot
commented
Aug 5, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 1a8024a
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/nextjsPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
7537036 to
5733359CompareAugust 5, 2025 16:55
@LauraBeatrisLauraBeatris
changed the title
fix(backend): Propagate treatPendingAsSignedOut to auth from clerkMiddlewarefix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddlewareAug 5, 2025
@LauraBeatrisLauraBeatris
changed the title
fix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddlewarefix(nextjs): Propagate treatPendingAsSignedOut to auth from clerkMiddlewareAug 5, 2025
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
1040314 to
1f127e5CompareAugust 5, 2025 17:04
@LauraBeatris
LauraBeatris
marked this pull request as ready for review
August 5, 2025 17:04
@LauraBeatris
LauraBeatris
requested a review
from a teamAugust 5, 2025 17:04
@coderabbitai
coderabbitaiBot
commented
Aug 5, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
This change updates the clerkMiddleware in the @clerk/nextjs package to propagate the treatPendingAsSignedOut option to the auth function. It modifies the function signature of createMiddlewareAuthHandler to accept a requestState parameter of type AuthenticatedState<'session_token'> | UnauthenticatedState<'session_token'> instead of a precomputed authObject. The conversion to an auth object is deferred until inside the handler by calling requestState.toAuth() with the treatPendingAsSignedOut option. Usage examples and documentation are added to demonstrate how the option affects session handling for pending states, allowing explicit control over whether pending sessions are treated as signed out or signed in.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~8 minutes
Note
⚡️ Unit Test Generation is now available in beta!
Learn more here, or try it out under "Finishing Touches" below.
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between c00fd88 and 1a8024a.
📒 Files selected for processing (2)
  • .changeset/tricky-planets-cry.md (1 hunks)
  • packages/nextjs/src/server/clerkMiddleware.ts (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • .changeset/tricky-planets-cry.md
  • packages/nextjs/src/server/clerkMiddleware.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (21)
  • GitHub Check: Integration Tests (nextjs, chrome, 14)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (expo-web, chrome)
  • GitHub Check: Integration Tests (tanstack-react-router, chrome)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: Integration Tests (elements, chrome)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Publish with pkg-pr-new
  • GitHub Check: Unit Tests (22, **)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome)
  • GitHub Check: Unit Tests (18, --filter=@clerk/astro --filter=@clerk/backend --filter=@clerk/express --filter=@c...
  • GitHub Check: Static analysis
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:

    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:

    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:

    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
CodeRabbit Commands (Invoked using PR comments)
  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.
Other keywords and placeholders
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
1f127e5 to
c00fd88CompareAugust 5, 2025 17:08
@pkg-pr-new
pkg-pr-newBot
commented
Aug 5, 2025•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@6477

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@6477

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@6477

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@6477

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@6477

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@6477

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@6477

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@6477

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@6477

@clerk/express
npm i https://pkg.pr.new/@clerk/express@6477

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@6477

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@6477

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@6477

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@6477

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@6477

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@6477

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@6477

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@6477

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@6477

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@6477

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@6477

@clerk/types
npm i https://pkg.pr.new/@clerk/types@6477

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@6477

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@6477

commit: 1a8024a
iagodahlem
iagodahlem
approved these changes
Aug 5, 2025
View reviewed changes
Comment thread.changeset/tricky-planets-cry.md
Outdated

Comment thread.changeset/tricky-planets-cry.md
Outdated

@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
c00fd88 to
9b07830CompareAugust 5, 2025 19:07
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-pending-auth-object-middleware-handler
branch
from
9b07830 to
1a8024aCompareAugust 5, 2025 19:07
@LauraBeatris
LauraBeatris
merged commit 90acc76
into
mainAug 5, 2025

36 checks passed

@LauraBeatris
LauraBeatris
deleted the

laura/fix-pending-auth-object-middleware-handler

branch
August 5, 2025 20:26
@clerk-cookieclerk-cookie
mentioned this pull request
Aug 5, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@iagodahlemiagodahlemiagodahlem approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LauraBeatrisLauraBeatris

Labels

nextjs

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@iagodahlem@clerk-cookie