Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 470
ci(repo): Version packages#6525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "name": "@clerk/clerk-js", | ||
| "version": "5.82.0", | ||
| "version": "5.83.0", | ||
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainMinor bump to 5.83.0 aligns with noted feature (billing trial properties) and dependency updates.
Also confirm there are corresponding or prior tests covering the new billing trial props in:
If missing, do you want me to open a follow-up to add targeted tests? 🏁 Script executed: #!/bin/bashset -e
# Verify CHANGELOG entries exist for all bumped packages in this PR.
rg -n '^##\s+5\.83\.0\b' packages/clerk-js/CHANGELOG.md
rg -n '^##\s+3\.19\.1\b' packages/shared/CHANGELOG.md
rg -n '^##\s+0\.23\.52\b' packages/elements/CHANGELOG.md
rg -n '^##\s+1\.10\.13\b' packages/testing/CHANGELOG.md
rg -n '^##\s+2\.4\.8\b' packages/themes/CHANGELOG.mdLength of output: 355 I’d like to verify that there are actually tests covering the new “trial” properties in both the type definitions and runtime code. Running a quick grep across each package should reveal any existing coverage: This will confirm whether we already have test cases and type definitions for the billing-trial properties, or if a follow-up PR is needed to add them. 🏁 Script executed: #!/bin/bashset -e
echo"🔍 Searching for any mention of 'trial' in tests under packages/clerk-js..."
rg -n --color never 'trial' -g '*.{test,spec}.{ts,js,tsx,jsx}' packages/clerk-js ||echo"⚠️ No 'trial' references found in clerk-js tests."echoecho"🔍 Searching for any mention of 'trial' in packages/clerk-js source..."
rg -n --color never 'trial' -C2 packages/clerk-js
echoecho"🔍 Searching for any mention of 'trial' in packages/types..."
rg -n --color never 'trial' -C2 packages/typesLength of output: 3084 Missing Tests for Billing Trial Properties The version bump to 5.83.0 and all CHANGELOG entries look good, but I didn’t find any test coverage for the new trial fields: • packages/clerk-js – no Please add targeted unit tests for:
Let me know if you’d like a follow-up PR drafted for these tests. 🤖 Prompt for AI Agents | ||
| "description": "Clerk JS library", | ||
| "keywords": [ | ||
| "clerk", | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,13 @@ | ||
| # @clerk/expo-passkeys | ||
| ## 0.3.29 | ||
| ### Patch Changes | ||
| - Updated dependencies [[`15fe106`](https://github.com/clerk/javascript/commit/15fe1060f730a6a4391f3d2451d23edd3218e1ae), [`173837c`](https://github.com/clerk/javascript/commit/173837c2526aa826b7981ee8d6d4f52c00675da5), [`8b52d7a`](https://github.com/clerk/javascript/commit/8b52d7ae19407e8ab5a5451bd7d34b6bc38417de), [`854dde8`](https://github.com/clerk/javascript/commit/854dde88e642c47b5a29ac8f576c8c1976e5d067), [`ae2e2d6`](https://github.com/clerk/javascript/commit/ae2e2d6b336be6b596cc855e549843beb5bfd2a1), [`037f25a`](https://github.com/clerk/javascript/commit/037f25a8171888168913b186b7edf871e0aaf197), [`f8b38b7`](https://github.com/clerk/javascript/commit/f8b38b7059e498fef3ac1271346be0710aa31c76)]: | ||
| - @clerk/types@4.76.0 | ||
| - @clerk/shared@3.20.0 | ||
Comment on lines
+7
to
+9
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainVerify package.json version and dependency bumps are in sync. Ensure packages/expo-passkeys/package.json is bumped to 0.3.29 and its @clerk/types and @clerk/shared dependency ranges reflect 4.76.0 and 3.20.0 respectively (pinned or caret as per repo policy). Run this script from the repo root: 🏁 Script executed: #!/bin/bashset -euo pipefail
PKG="packages/expo-passkeys/package.json"if [ !-f"$PKG" ];thenecho"Missing $PKG"exit 1
fi
python - << 'PY'import json,sysp="packages/expo-passkeys/package.json"with open(p) as f: j=json.load(f)ver=j.get("version")deps=j.get("dependencies",{})print(f"expo-passkeys version: {ver}")print(f"@clerk/types dep: {deps.get('@clerk/types')}")print(f"@clerk/shared dep: {deps.get('@clerk/shared')}")assert ver=="0.3.29", "packages/expo-passkeys/package.json version is not 0.3.29"req_types="4.76.0"; req_shared="3.20.0"dt=deps.get("@clerk/types") or ""ds=deps.get("@clerk/shared") or ""# Accept caret or exact pinsassert req_types in dt, f"@clerk/types not bumped to {req_types} in expo-passkeys"assert req_shared in ds, f"@clerk/shared not bumped to {req_shared} in expo-passkeys"print("OK: expo-passkeys package.json is consistent with the changelog.")PYLength of output: 357 Action required — sync packages/expo-passkeys/package.json deps with CHANGELOG Short: packages/expo-passkeys/package.json is already bumped to 0.3.29, but @clerk/types and @clerk/shared are using the workspace protocol instead of the expected versions from the changelog. Files to update:
Suggested diff:
🤖 Prompt for AI Agents | ||
| ## 0.3.28 | ||
| ### Patch Changes | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "name": "@clerk/clerk-expo", | ||
| "version": "2.14.17", | ||
| "version": "2.14.18", | ||
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainOptional: Verify release hygiene across packages (name scope, publish config, changelog alignment). Run this script to check:
🏁 Script executed: #!/bin/bashset -euo pipefail
errors=0
# Find all publishable package.json files under packages/
mapfile -t PKGS <<(fd -a -t f '^package\.json$' packages)forpkgin"${PKGS[@]}";do
dir="$(dirname "$pkg")"
name="$(jq -r '.name'"$pkg")"
version="$(jq -r '.version'"$pkg")"
publish_access="$(jq -r '.publishConfig.access // empty'"$pkg")"# 1) Scope checkif [[ "$name"!= @clerk/* ]];thenecho"ERROR: $pkg => package name '$name' is not under @clerk scope"((errors++))||truefi# 2) publishConfig.access checkif [[ "$publish_access"!="public" ]];thenecho"ERROR: $pkg => publishConfig.access is not 'public' (got '${publish_access:-<missing>}')"((errors++))||truefi# 3) Changelog version alignment (if changelog exists)
changelog="$dir/CHANGELOG.md"if [[ -f"$changelog" ]];then
top_ch_ver="$(awk '/^## [0-9]+\.[0-9]+\.[0-9]+/ {print $2; exit}'"$changelog"| tr -d '[:space:]')"if [[ -n"$top_ch_ver"&&"$top_ch_ver"!="$version" ]];thenecho"ERROR: $pkg => version '$version' does not match top CHANGELOG entry '$top_ch_ver'"((errors++))||truefifidoneif [[ $errors-gt 0 ]];thenecho"Found $errors issue(s)."exit 1
elseecho"All checks passed."fiLength of output: 198 To work around the sandbox’s lack of 🏁 Script executed: #!/usr/bin/env bashset -euo pipefail
errors=0
# Gather all package.json files under packages/
PKGS=( $(fd -a -t f '^package\.json$' packages) )
forpkgin"${PKGS[@]}";do
dir=$(dirname "$pkg")
name=$(jq -r '.name'"$pkg")
version=$(jq -r '.version'"$pkg")
publish_access=$(jq -r '.publishConfig.access // empty'"$pkg")# 1) Scope checkif [[ $name!= @clerk/* ]];thenecho"ERROR: $pkg => package name '$name' is not under @clerk scope"
errors=$((errors +1))fi# 2) publishConfig.access checkif [[ $publish_access!= public ]];thenecho"ERROR: $pkg => publishConfig.access is not 'public' (got '${publish_access:-<missing>}')"
errors=$((errors +1))fi# 3) Changelog version alignment (if CHANGELOG.md exists)
changelog="$dir/CHANGELOG.md"if [[ -f$changelog ]];then
top_ch_ver=$(awk '/^## [0-9]+\.[0-9]+\.[0-9]+/ {print $2; exit}'"$changelog"| tr -d '[:space:]')if [[ -n$top_ch_ver&&$top_ch_ver!=$version ]];thenecho"ERROR: $pkg => version '$version' does not match top CHANGELOG entry '$top_ch_ver'"
errors=$((errors +1))fifidoneif(( errors >0));thenecho"Found $errors issue(s)."exit 1
elseecho"All checks passed."exit 0
fiLength of output: 59290 Release hygiene checks detected 69 package.json issues – action required The automated script flagged numerous nested packages (examples, client, internal, webhooks, etc.) with missing or mis-configured fields. Please address the following: • Missing name/version (reported as • Missing Recommended fixes:
| ||
| "description": "Clerk React Native/Expo library", | ||
| "keywords": [ | ||
| "react", | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "name": "@clerk/express", | ||
| "version": "1.7.18", | ||
| "version": "1.7.19", | ||
coderabbitai[bot] marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| "description": "Clerk server SDK for usage with Express", | ||
| "keywords": [ | ||
| "clerk", | ||
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two Patch entries are missing list markers; they won’t render as bullets.
“oAuthApplicationUrl” and “Harden Link component…” are currently plain paragraphs under the previous bullet. Make them separate list items.
Apply this diff:
📝 Committable suggestion
🤖 Prompt for AI Agents