Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 470
fix(clerk-js): Fix redirect when completing task within SignIn/SignUp#6580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
1383bf11dc808002bcaf9ceef882a390785d5dd8ec6427b93File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| '@clerk/clerk-js': patch | ||
| '@clerk/types': patch | ||
| --- | ||
| Fix incorrect redirect when completing session tasks within `SignIn` and `SignUp` components |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -136,15 +136,15 @@ function SignInRoutes(): JSX.Element { | ||
| </Route> | ||
| </Route> | ||
| <Route path='tasks'> | ||
| <LazySessionTasks /> | ||
| <LazySessionTasks redirectUrlComplete={signInContext.afterSignUpUrl} /> | ||
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Potentially what I would do is create a new | ||
| </Route> | ||
| <Route index> | ||
| <LazySignUpStart /> | ||
| </Route> | ||
| </Route> | ||
| )} | ||
| <Route path='tasks'> | ||
| <LazySessionTasks /> | ||
| <LazySessionTasks redirectUrlComplete={signInContext.afterSignInUrl} /> | ||
| </Route> | ||
| <Route index> | ||
| <SignInStart /> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -9,6 +9,7 @@ import type { | ||
| RedirectUrlProp, | ||
| SignInRedirectOptions, | ||
| SignUpRedirectOptions, | ||
| TasksRedirectOptions, | ||
| Without, | ||
| } from '@clerk/types'; | ||
| import type React from 'react'; | ||
| @@ -116,6 +117,7 @@ export type SignInWithMetamaskButtonProps = { | ||
| export type RedirectToSignInProps = SignInRedirectOptions; | ||
| export type RedirectToSignUpProps = SignUpRedirectOptions; | ||
| export type RedirectToTasksProps = TasksRedirectOptions; | ||
LauraBeatris marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| type PageProps<T extends string> = | ||
| | { | ||
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.