Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/rotten-falcons-cover.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
---
'@clerk/clerk-js': minor
'@clerk/clerk-react': minor
'@clerk/types': minor
---

[Experimental] Signals `isLoaded` removal
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -91,7 +91,7 @@ export class SignIn extends BaseResource implements SignInResource {
*
* An instance of `SignInFuture`, which has a different API than `SignIn`, intended to be used in custom flows.
*/
__internal_future: SignInFuture | null = new SignInFuture(this);
__internal_future: SignInFuture = new SignInFuture(this);

/**
* @internal Only used for internal purposes, and is not intended to be used directly.
Expand DownExpand Up@@ -638,7 +638,7 @@ class SignInFuture implements SignInFutureResource {
});
}

async finalize({ navigate }: { navigate?: SetActiveNavigate }): Promise<{ error: unknown }> {
async finalize({ navigate }: { navigate?: SetActiveNavigate } = {}): Promise<{ error: unknown }> {
return runAsyncResourceTask(this.resource, async () => {
if (!this.resource.createdSessionId) {
throw new Error('Cannot finalize sign-in without a created session.');
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/SignUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -87,7 +87,7 @@ export class SignUp extends BaseResource implements SignUpResource {
*
* An instance of `SignUpFuture`, which has a different API than `SignUp`, intended to be used in custom flows.
*/
__internal_future: SignUpFuture | null = new SignUpFuture(this);
__internal_future: SignUpFuture = new SignUpFuture(this);

/**
* @internal Only used for internal purposes, and is not intended to be used directly.
Expand DownExpand Up@@ -539,7 +539,7 @@ class SignUpFuture implements SignUpFutureResource {
});
}

async finalize({ navigate }: { navigate?: SetActiveNavigate }): Promise<{ error: unknown }> {
async finalize({ navigate }: { navigate?: SetActiveNavigate } = {}): Promise<{ error: unknown }> {
return runAsyncResourceTask(this.resource, async () => {
if (!this.resource.createdSessionId) {
throw new Error('Cannot finalize sign-up without a created session.');
Expand Down
32 changes: 18 additions & 14 deletions packages/react/src/hooks/useClerkSignal.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,28 +4,36 @@ import { useCallback, useSyncExternalStore } from 'react';
import { useIsomorphicClerkContext } from '../contexts/IsomorphicClerkContext';
import { useAssertWrappedByClerkProvider } from './useAssertWrappedByClerkProvider';

function useClerkSignal(signal: 'signIn'): ReturnType<SignInSignal> | null;
function useClerkSignal(signal: 'signUp'): ReturnType<SignUpSignal> | null;
function useClerkSignal(signal: 'signIn' | 'signUp'): ReturnType<SignInSignal> | ReturnType<SignUpSignal> | null {
// These types are used to remove the `null` value from the underlying resource. This is safe because IsomorphicClerk
// always returns a valid resource, even before Clerk is loaded, and if Clerk is loaded, the resource is guaranteed to
// be non-null
type NonNullSignInSignal = Omit<ReturnType<SignInSignal>, 'signIn'> & {
signIn: NonNullable<ReturnType<SignInSignal>['signIn']>;
};
type NonNullSignUpSignal = Omit<ReturnType<SignUpSignal>, 'signUp'> & {
signUp: NonNullable<ReturnType<SignUpSignal>['signUp']>;
};

function useClerkSignal(signal: 'signIn'): NonNullSignInSignal;
function useClerkSignal(signal: 'signUp'): NonNullSignUpSignal;
function useClerkSignal(signal: 'signIn' | 'signUp'): NonNullSignInSignal | NonNullSignUpSignal {
useAssertWrappedByClerkProvider('useClerkSignal');

const clerk = useIsomorphicClerkContext();

const subscribe = useCallback(
(callback: () => void) => {
if (!clerk.loaded || !clerk.__internal_state) {
if (!clerk.loaded) {
return () => {};
}

return clerk.__internal_state.__internal_effect(() => {
switch (signal) {
case 'signIn':
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- we know that the state is defined
clerk.__internal_state!.signInSignal();
clerk.__internal_state.signInSignal();
break;
case 'signUp':
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- we know that the state is defined
clerk.__internal_state!.signUpSignal();
clerk.__internal_state.signUpSignal();
break;
default:
throw new Error(`Unknown signal: ${signal}`);
Expand All@@ -36,15 +44,11 @@ function useClerkSignal(signal: 'signIn' | 'signUp'): ReturnType<SignInSignal> |
[clerk, clerk.loaded, clerk.__internal_state],
);
const getSnapshot = useCallback(() => {
if (!clerk.__internal_state) {
return null;
}

switch (signal) {
case 'signIn':
return clerk.__internal_state.signInSignal();
return clerk.__internal_state.signInSignal() as NonNullSignInSignal;
case 'signUp':
return clerk.__internal_state.signUpSignal();
return clerk.__internal_state.signUpSignal() as NonNullSignUpSignal;
default:
throw new Error(`Unknown signal: ${signal}`);
}
Expand Down
7 changes: 5 additions & 2 deletions packages/react/src/isomorphicClerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,7 @@ import type {

import { errorThrower } from './errors/errorThrower';
import { unsupportedNonBrowserDomainOrProxyUrlFunction } from './errors/messages';
import { StateProxy } from './stateProxy';
import type {
BrowserClerk,
BrowserClerkConstructor,
Expand DownExpand Up@@ -158,6 +159,7 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {
#proxyUrl: DomainOrProxyUrl['proxyUrl'];
#publishableKey: string;
#eventBus = createClerkEventBus();
#stateProxy: StateProxy;

get publishableKey(): string {
return this.#publishableKey;
Expand DownExpand Up@@ -250,6 +252,7 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {
this.options = options;
this.Clerk = Clerk;
this.mode = inBrowser() ? 'browser' : 'server';
this.#stateProxy = new StateProxy(this);

if (!this.options.sdkMetadata) {
this.options.sdkMetadata = SDK_METADATA;
Expand DownExpand Up@@ -723,8 +726,8 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {
return this.clerkjs?.billing;
}

get __internal_state(): State | undefined {
return this.clerkjs?.__internal_state;
get __internal_state(): State {
return this.loaded && this.clerkjs ? this.clerkjs.__internal_state : this.#stateProxy;
}

get apiKeys(): APIKeysNamespace | undefined {
Expand Down
113 changes: 113 additions & 0 deletions packages/react/src/stateProxy.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,113 @@
import { inBrowser } from '@clerk/shared/browser';
import type { Errors, State } from '@clerk/types';

import { errorThrower } from './errors/errorThrower';
import type { IsomorphicClerk } from './isomorphicClerk';

const defaultErrors = (): Errors => ({
fields: {
firstName: null,
lastName: null,
emailAddress: null,
identifier: null,
phoneNumber: null,
password: null,
username: null,
code: null,
captcha: null,
legalAccepted: null,
},
raw: [],
global: [],
});

export class StateProxy implements State {
constructor(private isomorphicClerk: IsomorphicClerk) {}

private readonly signInSignalProxy = this.buildSignInProxy();
private readonly signUpSignalProxy = this.buildSignUpProxy();

signInSignal() {
return this.signInSignalProxy;
}
signUpSignal() {
return this.signUpSignalProxy;
}

private buildSignInProxy() {
const target = () => this.client.signIn.__internal_future;

return {
errors: defaultErrors(),
fetchStatus: 'idle' as const,
signIn: {
status: 'needs_identifier' as const,
availableStrategies: [],

create: this.gateMethod(target, 'create'),
password: this.gateMethod(target, 'password'),
sso: this.gateMethod(target, 'sso'),
finalize: this.gateMethod(target, 'finalize'),

emailCode: this.wrapMethods(() => target().emailCode, ['sendCode', 'verifyCode'] as const),
resetPasswordEmailCode: this.wrapMethods(() => target().resetPasswordEmailCode, [
'sendCode',
'verifyCode',
'submitPassword',
] as const),
},
};
}

private buildSignUpProxy() {
const target = () => this.client.signUp.__internal_future;

return {
errors: defaultErrors(),
fetchStatus: 'idle' as const,
signUp: {
status: 'missing_requirements' as const,
unverifiedFields: [],

password: this.gateMethod(target, 'password'),
finalize: this.gateMethod(target, 'finalize'),

verifications: this.wrapMethods(() => target().verifications, ['sendEmailCode', 'verifyEmailCode'] as const),
},
};
}

__internal_effect(_: () => void): () => void {
throw new Error('__internal_effect called before Clerk is loaded');
}
__internal_computed<T>(_: (prev?: T) => T): () => T {
throw new Error('__internal_computed called before Clerk is loaded');
}

private get client() {
const c = this.isomorphicClerk.client;
if (!c) throw new Error('Clerk client not ready');
return c;
}

private gateMethod<T extends object, K extends keyof T & string>(getTarget: () => T, key: K) {
type F = Extract<T[K], (...args: unknown[]) => unknown>;
return (async (...args: Parameters<F>): Promise<ReturnType<F>> => {
if (!inBrowser()) {
return errorThrower.throw(`Attempted to call a method (${key}) that is not supported on the server.`);
}
if (!this.isomorphicClerk.loaded) {
await new Promise<void>(resolve => this.isomorphicClerk.addOnLoaded(resolve));
}
const t = getTarget();
return (t[key] as (...args: Parameters<F>) => ReturnType<F>).apply(t, args);
}) as F;
}

private wrapMethods<T extends object, K extends readonly (keyof T & string)[]>(
getTarget: () => T,
keys: K,
): Pick<T, K[number]> {
return Object.fromEntries(keys.map(k => [k, this.gateMethod(getTarget, k)])) as Pick<T, K[number]>;
}
}
2 changes: 1 addition & 1 deletion packages/types/src/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -235,7 +235,7 @@
* Entrypoint for Clerk's Signal API containing resource signals along with accessible versions of `computed()` and
* `effect()` that can be used to subscribe to changes from Signals.
*/
__internal_state: State | undefined;
__internal_state: State;

/**
* @experimental This is an experimental API for the Billing feature that is available under a public beta, and the API is subject to change.
Expand DownExpand Up@@ -1140,7 +1140,7 @@
/**
* @internal
*/
__internal_metadata?: RouterMetadata;

Check warning on line 1143 in packages/types/src/clerk.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

'unknown' overrides all other types in this union type
/**
* Provide a function to be used for navigation.
*/
Expand Down
7 changes: 6 additions & 1 deletion packages/types/src/signIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -124,6 +124,11 @@ export interface SignInResource extends ClerkResource {
* @internal
*/
__internal_toSnapshot: () => SignInJSONSnapshot;

/**
* @internal
*/
__internal_future: SignInFutureResource;
}

export interface SignInFutureResource {
Expand DownExpand Up@@ -151,7 +156,7 @@ export interface SignInFutureResource {
redirectUrl: string;
redirectUrlComplete: string;
}) => Promise<{ error: unknown }>;
finalize: (params: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;
finalize: (params?: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

}

export type SignInStatus =
Expand Down
7 changes: 6 additions & 1 deletion packages/types/src/signUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -117,6 +117,11 @@ export interface SignUpResource extends ClerkResource {
authenticateWithCoinbaseWallet: (params?: SignUpAuthenticateWithWeb3Params) => Promise<SignUpResource>;
authenticateWithOKXWallet: (params?: SignUpAuthenticateWithWeb3Params) => Promise<SignUpResource>;
__internal_toSnapshot: () => SignUpJSONSnapshot;

/**
* @internal
*/
__internal_future: SignUpFutureResource;
}

export interface SignUpFutureResource {
Expand All@@ -127,7 +132,7 @@ export interface SignUpFutureResource {
verifyEmailCode: (params: { code: string }) => Promise<{ error: unknown }>;
};
password: (params: { emailAddress: string; password: string }) => Promise<{ error: unknown }>;
finalize: (params: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;
finalize: (params?: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;
}

export type SignUpStatus = 'missing_requirements' | 'complete' | 'abandoned';
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/rotten-falcons-cover.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
---
'@clerk/clerk-js': minor
'@clerk/clerk-react': minor
'@clerk/types': minor
---

[Experimental] Signals `isLoaded` removal
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -91,7 +91,7 @@ export class SignIn extends BaseResource implements SignInResource {
*
* An instance of `SignInFuture`, which has a different API than `SignIn`, intended to be used in custom flows.
*/
__internal_future: SignInFuture | null = new SignInFuture(this);
__internal_future: SignInFuture = new SignInFuture(this);

/**
* @internal Only used for internal purposes, and is not intended to be used directly.
Expand DownExpand Up@@ -638,7 +638,7 @@ class SignInFuture implements SignInFutureResource {
});
}

async finalize({ navigate }: { navigate?: SetActiveNavigate }): Promise<{ error: unknown }> {
async finalize({ navigate }: { navigate?: SetActiveNavigate } = {}): Promise<{ error: unknown }> {
return runAsyncResourceTask(this.resource, async () => {
if (!this.resource.createdSessionId) {
throw new Error('Cannot finalize sign-in without a created session.');
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/SignUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -87,7 +87,7 @@ export class SignUp extends BaseResource implements SignUpResource {
*
* An instance of `SignUpFuture`, which has a different API than `SignUp`, intended to be used in custom flows.
*/
__internal_future: SignUpFuture | null = new SignUpFuture(this);
__internal_future: SignUpFuture = new SignUpFuture(this);

/**
* @internal Only used for internal purposes, and is not intended to be used directly.
Expand DownExpand Up@@ -539,7 +539,7 @@ class SignUpFuture implements SignUpFutureResource {
});
}

async finalize({ navigate }: { navigate?: SetActiveNavigate }): Promise<{ error: unknown }> {
async finalize({ navigate }: { navigate?: SetActiveNavigate } = {}): Promise<{ error: unknown }> {
return runAsyncResourceTask(this.resource, async () => {
if (!this.resource.createdSessionId) {
throw new Error('Cannot finalize sign-up without a created session.');
Expand Down
32 changes: 18 additions & 14 deletions packages/react/src/hooks/useClerkSignal.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,28 +4,36 @@ import { useCallback, useSyncExternalStore } from 'react';
import { useIsomorphicClerkContext } from '../contexts/IsomorphicClerkContext';
import { useAssertWrappedByClerkProvider } from './useAssertWrappedByClerkProvider';

function useClerkSignal(signal: 'signIn'): ReturnType<SignInSignal> | null;
function useClerkSignal(signal: 'signUp'): ReturnType<SignUpSignal> | null;
function useClerkSignal(signal: 'signIn' | 'signUp'): ReturnType<SignInSignal> | ReturnType<SignUpSignal> | null {
// These types are used to remove the `null` value from the underlying resource. This is safe because IsomorphicClerk
// always returns a valid resource, even before Clerk is loaded, and if Clerk is loaded, the resource is guaranteed to
// be non-null
type NonNullSignInSignal = Omit<ReturnType<SignInSignal>, 'signIn'> & {
signIn: NonNullable<ReturnType<SignInSignal>['signIn']>;
};
type NonNullSignUpSignal = Omit<ReturnType<SignUpSignal>, 'signUp'> & {
signUp: NonNullable<ReturnType<SignUpSignal>['signUp']>;
};

function useClerkSignal(signal: 'signIn'): NonNullSignInSignal;
function useClerkSignal(signal: 'signUp'): NonNullSignUpSignal;
function useClerkSignal(signal: 'signIn' | 'signUp'): NonNullSignInSignal | NonNullSignUpSignal {
useAssertWrappedByClerkProvider('useClerkSignal');

const clerk = useIsomorphicClerkContext();

const subscribe = useCallback(
(callback: () => void) => {
if (!clerk.loaded || !clerk.__internal_state) {
if (!clerk.loaded) {
return () => {};
}

return clerk.__internal_state.__internal_effect(() => {
switch (signal) {
case 'signIn':
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- we know that the state is defined
clerk.__internal_state!.signInSignal();
clerk.__internal_state.signInSignal();
break;
case 'signUp':
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- we know that the state is defined
clerk.__internal_state!.signUpSignal();
clerk.__internal_state.signUpSignal();
break;
default:
throw new Error(`Unknown signal: ${signal}`);
Expand All@@ -36,15 +44,11 @@ function useClerkSignal(signal: 'signIn' | 'signUp'): ReturnType<SignInSignal> |
[clerk, clerk.loaded, clerk.__internal_state],
);
const getSnapshot = useCallback(() => {
if (!clerk.__internal_state) {
return null;
}

switch (signal) {
case 'signIn':
return clerk.__internal_state.signInSignal();
return clerk.__internal_state.signInSignal() as NonNullSignInSignal;
case 'signUp':
return clerk.__internal_state.signUpSignal();
return clerk.__internal_state.signUpSignal() as NonNullSignUpSignal;
default:
throw new Error(`Unknown signal: ${signal}`);
}
Expand Down
7 changes: 5 additions & 2 deletions packages/react/src/isomorphicClerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,7 @@ import type {

import { errorThrower } from './errors/errorThrower';
import { unsupportedNonBrowserDomainOrProxyUrlFunction } from './errors/messages';
import { StateProxy } from './stateProxy';
import type {
BrowserClerk,
BrowserClerkConstructor,
Expand DownExpand Up@@ -158,6 +159,7 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {
#proxyUrl: DomainOrProxyUrl['proxyUrl'];
#publishableKey: string;
#eventBus = createClerkEventBus();
#stateProxy: StateProxy;

get publishableKey(): string {
return this.#publishableKey;
Expand DownExpand Up@@ -250,6 +252,7 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {
this.options = options;
this.Clerk = Clerk;
this.mode = inBrowser() ? 'browser' : 'server';
this.#stateProxy = new StateProxy(this);

if (!this.options.sdkMetadata) {
this.options.sdkMetadata = SDK_METADATA;
Expand DownExpand Up@@ -723,8 +726,8 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {
return this.clerkjs?.billing;
}

get __internal_state(): State | undefined {
return this.clerkjs?.__internal_state;
get __internal_state(): State {
return this.loaded && this.clerkjs ? this.clerkjs.__internal_state : this.#stateProxy;
}

get apiKeys(): APIKeysNamespace | undefined {
Expand Down
113 changes: 113 additions & 0 deletions packages/react/src/stateProxy.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,113 @@
import { inBrowser } from '@clerk/shared/browser';
import type { Errors, State } from '@clerk/types';

import { errorThrower } from './errors/errorThrower';
import type { IsomorphicClerk } from './isomorphicClerk';

const defaultErrors = (): Errors => ({
fields: {
firstName: null,
lastName: null,
emailAddress: null,
identifier: null,
phoneNumber: null,
password: null,
username: null,
code: null,
captcha: null,
legalAccepted: null,
},
raw: [],
global: [],
});

export class StateProxy implements State {
constructor(private isomorphicClerk: IsomorphicClerk) {}

private readonly signInSignalProxy = this.buildSignInProxy();
private readonly signUpSignalProxy = this.buildSignUpProxy();

signInSignal() {
return this.signInSignalProxy;
}
signUpSignal() {
return this.signUpSignalProxy;
}

private buildSignInProxy() {
const target = () => this.client.signIn.__internal_future;

return {
errors: defaultErrors(),
fetchStatus: 'idle' as const,
signIn: {
status: 'needs_identifier' as const,
availableStrategies: [],

create: this.gateMethod(target, 'create'),
password: this.gateMethod(target, 'password'),
sso: this.gateMethod(target, 'sso'),
finalize: this.gateMethod(target, 'finalize'),

emailCode: this.wrapMethods(() => target().emailCode, ['sendCode', 'verifyCode'] as const),
resetPasswordEmailCode: this.wrapMethods(() => target().resetPasswordEmailCode, [
'sendCode',
'verifyCode',
'submitPassword',
] as const),
},
};
}

private buildSignUpProxy() {
const target = () => this.client.signUp.__internal_future;

return {
errors: defaultErrors(),
fetchStatus: 'idle' as const,
signUp: {
status: 'missing_requirements' as const,
unverifiedFields: [],

password: this.gateMethod(target, 'password'),
finalize: this.gateMethod(target, 'finalize'),

verifications: this.wrapMethods(() => target().verifications, ['sendEmailCode', 'verifyEmailCode'] as const),
},
};
}

__internal_effect(_: () => void): () => void {
throw new Error('__internal_effect called before Clerk is loaded');
}
__internal_computed<T>(_: (prev?: T) => T): () => T {
throw new Error('__internal_computed called before Clerk is loaded');
}

private get client() {
const c = this.isomorphicClerk.client;
if (!c) throw new Error('Clerk client not ready');
return c;
}

private gateMethod<T extends object, K extends keyof T & string>(getTarget: () => T, key: K) {
type F = Extract<T[K], (...args: unknown[]) => unknown>;
return (async (...args: Parameters<F>): Promise<ReturnType<F>> => {
if (!inBrowser()) {
return errorThrower.throw(`Attempted to call a method (${key}) that is not supported on the server.`);
}
if (!this.isomorphicClerk.loaded) {
await new Promise<void>(resolve => this.isomorphicClerk.addOnLoaded(resolve));
}
const t = getTarget();
return (t[key] as (...args: Parameters<F>) => ReturnType<F>).apply(t, args);
}) as F;
}

private wrapMethods<T extends object, K extends readonly (keyof T & string)[]>(
getTarget: () => T,
keys: K,
): Pick<T, K[number]> {
return Object.fromEntries(keys.map(k => [k, this.gateMethod(getTarget, k)])) as Pick<T, K[number]>;
}
}
2 changes: 1 addition & 1 deletion packages/types/src/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -235,7 +235,7 @@
* Entrypoint for Clerk's Signal API containing resource signals along with accessible versions of `computed()` and
* `effect()` that can be used to subscribe to changes from Signals.
*/
__internal_state: State | undefined;
__internal_state: State;

/**
* @experimental This is an experimental API for the Billing feature that is available under a public beta, and the API is subject to change.
Expand DownExpand Up@@ -1140,7 +1140,7 @@
/**
* @internal
*/
__internal_metadata?: RouterMetadata;

Check warning on line 1143 in packages/types/src/clerk.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

'unknown' overrides all other types in this union type
/**
* Provide a function to be used for navigation.
*/
Expand Down
7 changes: 6 additions & 1 deletion packages/types/src/signIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -124,6 +124,11 @@ export interface SignInResource extends ClerkResource {
* @internal
*/
__internal_toSnapshot: () => SignInJSONSnapshot;

/**
* @internal
*/
__internal_future: SignInFutureResource;
}

export interface SignInFutureResource {
Expand DownExpand Up@@ -151,7 +156,7 @@ export interface SignInFutureResource {
redirectUrl: string;
redirectUrlComplete: string;
}) => Promise<{ error: unknown }>;
finalize: (params: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;
finalize: (params?: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

}

export type SignInStatus =
Expand Down
7 changes: 6 additions & 1 deletion packages/types/src/signUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -117,6 +117,11 @@ export interface SignUpResource extends ClerkResource {
authenticateWithCoinbaseWallet: (params?: SignUpAuthenticateWithWeb3Params) => Promise<SignUpResource>;
authenticateWithOKXWallet: (params?: SignUpAuthenticateWithWeb3Params) => Promise<SignUpResource>;
__internal_toSnapshot: () => SignUpJSONSnapshot;

/**
* @internal
*/
__internal_future: SignUpFutureResource;
}

export interface SignUpFutureResource {
Expand All@@ -127,7 +132,7 @@ export interface SignUpFutureResource {
verifyEmailCode: (params: { code: string }) => Promise<{ error: unknown }>;
};
password: (params: { emailAddress: string; password: string }) => Promise<{ error: unknown }>;
finalize: (params: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;
finalize: (params?: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;
}

export type SignUpStatus = 'missing_requirements' | 'complete' | 'abandoned';
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/rotten-falcons-cover.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
---
'@clerk/clerk-js': minor
'@clerk/clerk-react': minor
'@clerk/types': minor
---

[Experimental] Signals `isLoaded` removal
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -91,7 +91,7 @@ export class SignIn extends BaseResource implements SignInResource {
*
* An instance of `SignInFuture`, which has a different API than `SignIn`, intended to be used in custom flows.
*/
__internal_future: SignInFuture | null = new SignInFuture(this);
__internal_future: SignInFuture = new SignInFuture(this);

/**
* @internal Only used for internal purposes, and is not intended to be used directly.
Expand DownExpand Up@@ -638,7 +638,7 @@ class SignInFuture implements SignInFutureResource {
});
}

async finalize({ navigate }: { navigate?: SetActiveNavigate }): Promise<{ error: unknown }> {
async finalize({ navigate }: { navigate?: SetActiveNavigate } = {}): Promise<{ error: unknown }> {
return runAsyncResourceTask(this.resource, async () => {
if (!this.resource.createdSessionId) {
throw new Error('Cannot finalize sign-in without a created session.');
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/SignUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -87,7 +87,7 @@ export class SignUp extends BaseResource implements SignUpResource {
*
* An instance of `SignUpFuture`, which has a different API than `SignUp`, intended to be used in custom flows.
*/
__internal_future: SignUpFuture | null = new SignUpFuture(this);
__internal_future: SignUpFuture = new SignUpFuture(this);

/**
* @internal Only used for internal purposes, and is not intended to be used directly.
Expand DownExpand Up@@ -539,7 +539,7 @@ class SignUpFuture implements SignUpFutureResource {
});
}

async finalize({ navigate }: { navigate?: SetActiveNavigate }): Promise<{ error: unknown }> {
async finalize({ navigate }: { navigate?: SetActiveNavigate } = {}): Promise<{ error: unknown }> {
return runAsyncResourceTask(this.resource, async () => {
if (!this.resource.createdSessionId) {
throw new Error('Cannot finalize sign-up without a created session.');
Expand Down
32 changes: 18 additions & 14 deletions packages/react/src/hooks/useClerkSignal.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,28 +4,36 @@ import { useCallback, useSyncExternalStore } from 'react';
import { useIsomorphicClerkContext } from '../contexts/IsomorphicClerkContext';
import { useAssertWrappedByClerkProvider } from './useAssertWrappedByClerkProvider';

function useClerkSignal(signal: 'signIn'): ReturnType<SignInSignal> | null;
function useClerkSignal(signal: 'signUp'): ReturnType<SignUpSignal> | null;
function useClerkSignal(signal: 'signIn' | 'signUp'): ReturnType<SignInSignal> | ReturnType<SignUpSignal> | null {
// These types are used to remove the `null` value from the underlying resource. This is safe because IsomorphicClerk
// always returns a valid resource, even before Clerk is loaded, and if Clerk is loaded, the resource is guaranteed to
// be non-null
type NonNullSignInSignal = Omit<ReturnType<SignInSignal>, 'signIn'> & {
signIn: NonNullable<ReturnType<SignInSignal>['signIn']>;
};
type NonNullSignUpSignal = Omit<ReturnType<SignUpSignal>, 'signUp'> & {
signUp: NonNullable<ReturnType<SignUpSignal>['signUp']>;
};

function useClerkSignal(signal: 'signIn'): NonNullSignInSignal;
function useClerkSignal(signal: 'signUp'): NonNullSignUpSignal;
function useClerkSignal(signal: 'signIn' | 'signUp'): NonNullSignInSignal | NonNullSignUpSignal {
useAssertWrappedByClerkProvider('useClerkSignal');

const clerk = useIsomorphicClerkContext();

const subscribe = useCallback(
(callback: () => void) => {
if (!clerk.loaded || !clerk.__internal_state) {
if (!clerk.loaded) {
return () => {};
}

return clerk.__internal_state.__internal_effect(() => {
switch (signal) {
case 'signIn':
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- we know that the state is defined
clerk.__internal_state!.signInSignal();
clerk.__internal_state.signInSignal();
break;
case 'signUp':
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- we know that the state is defined
clerk.__internal_state!.signUpSignal();
clerk.__internal_state.signUpSignal();
break;
default:
throw new Error(`Unknown signal: ${signal}`);
Expand All@@ -36,15 +44,11 @@ function useClerkSignal(signal: 'signIn' | 'signUp'): ReturnType<SignInSignal> |
[clerk, clerk.loaded, clerk.__internal_state],
);
const getSnapshot = useCallback(() => {
if (!clerk.__internal_state) {
return null;
}

switch (signal) {
case 'signIn':
return clerk.__internal_state.signInSignal();
return clerk.__internal_state.signInSignal() as NonNullSignInSignal;
case 'signUp':
return clerk.__internal_state.signUpSignal();
return clerk.__internal_state.signUpSignal() as NonNullSignUpSignal;
default:
throw new Error(`Unknown signal: ${signal}`);
}
Expand Down
7 changes: 5 additions & 2 deletions packages/react/src/isomorphicClerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,7 @@ import type {

import { errorThrower } from './errors/errorThrower';
import { unsupportedNonBrowserDomainOrProxyUrlFunction } from './errors/messages';
import { StateProxy } from './stateProxy';
import type {
BrowserClerk,
BrowserClerkConstructor,
Expand DownExpand Up@@ -158,6 +159,7 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {
#proxyUrl: DomainOrProxyUrl['proxyUrl'];
#publishableKey: string;
#eventBus = createClerkEventBus();
#stateProxy: StateProxy;

get publishableKey(): string {
return this.#publishableKey;
Expand DownExpand Up@@ -250,6 +252,7 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {
this.options = options;
this.Clerk = Clerk;
this.mode = inBrowser() ? 'browser' : 'server';
this.#stateProxy = new StateProxy(this);

if (!this.options.sdkMetadata) {
this.options.sdkMetadata = SDK_METADATA;
Expand DownExpand Up@@ -723,8 +726,8 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {
return this.clerkjs?.billing;
}

get __internal_state(): State | undefined {
return this.clerkjs?.__internal_state;
get __internal_state(): State {
return this.loaded && this.clerkjs ? this.clerkjs.__internal_state : this.#stateProxy;
}

get apiKeys(): APIKeysNamespace | undefined {
Expand Down
113 changes: 113 additions & 0 deletions packages/react/src/stateProxy.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,113 @@
import { inBrowser } from '@clerk/shared/browser';
import type { Errors, State } from '@clerk/types';

import { errorThrower } from './errors/errorThrower';
import type { IsomorphicClerk } from './isomorphicClerk';

const defaultErrors = (): Errors => ({
fields: {
firstName: null,
lastName: null,
emailAddress: null,
identifier: null,
phoneNumber: null,
password: null,
username: null,
code: null,
captcha: null,
legalAccepted: null,
},
raw: [],
global: [],
});

export class StateProxy implements State {
constructor(private isomorphicClerk: IsomorphicClerk) {}

private readonly signInSignalProxy = this.buildSignInProxy();
private readonly signUpSignalProxy = this.buildSignUpProxy();

signInSignal() {
return this.signInSignalProxy;
}
signUpSignal() {
return this.signUpSignalProxy;
}

private buildSignInProxy() {
const target = () => this.client.signIn.__internal_future;

return {
errors: defaultErrors(),
fetchStatus: 'idle' as const,
signIn: {
status: 'needs_identifier' as const,
availableStrategies: [],

create: this.gateMethod(target, 'create'),
password: this.gateMethod(target, 'password'),
sso: this.gateMethod(target, 'sso'),
finalize: this.gateMethod(target, 'finalize'),

emailCode: this.wrapMethods(() => target().emailCode, ['sendCode', 'verifyCode'] as const),
resetPasswordEmailCode: this.wrapMethods(() => target().resetPasswordEmailCode, [
'sendCode',
'verifyCode',
'submitPassword',
] as const),
},
};
}

private buildSignUpProxy() {
const target = () => this.client.signUp.__internal_future;

return {
errors: defaultErrors(),
fetchStatus: 'idle' as const,
signUp: {
status: 'missing_requirements' as const,
unverifiedFields: [],

password: this.gateMethod(target, 'password'),
finalize: this.gateMethod(target, 'finalize'),

verifications: this.wrapMethods(() => target().verifications, ['sendEmailCode', 'verifyEmailCode'] as const),
},
};
}

__internal_effect(_: () => void): () => void {
throw new Error('__internal_effect called before Clerk is loaded');
}
__internal_computed<T>(_: (prev?: T) => T): () => T {
throw new Error('__internal_computed called before Clerk is loaded');
}

private get client() {
const c = this.isomorphicClerk.client;
if (!c) throw new Error('Clerk client not ready');
return c;
}

private gateMethod<T extends object, K extends keyof T & string>(getTarget: () => T, key: K) {
type F = Extract<T[K], (...args: unknown[]) => unknown>;
return (async (...args: Parameters<F>): Promise<ReturnType<F>> => {
if (!inBrowser()) {
return errorThrower.throw(`Attempted to call a method (${key}) that is not supported on the server.`);
}
if (!this.isomorphicClerk.loaded) {
await new Promise<void>(resolve => this.isomorphicClerk.addOnLoaded(resolve));
}
const t = getTarget();
return (t[key] as (...args: Parameters<F>) => ReturnType<F>).apply(t, args);
}) as F;
}

private wrapMethods<T extends object, K extends readonly (keyof T & string)[]>(
getTarget: () => T,
keys: K,
): Pick<T, K[number]> {
return Object.fromEntries(keys.map(k => [k, this.gateMethod(getTarget, k)])) as Pick<T, K[number]>;
}
}
2 changes: 1 addition & 1 deletion packages/types/src/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -235,7 +235,7 @@
* Entrypoint for Clerk's Signal API containing resource signals along with accessible versions of `computed()` and
* `effect()` that can be used to subscribe to changes from Signals.
*/
__internal_state: State | undefined;
__internal_state: State;

/**
* @experimental This is an experimental API for the Billing feature that is available under a public beta, and the API is subject to change.
Expand DownExpand Up@@ -1140,7 +1140,7 @@
/**
* @internal
*/
__internal_metadata?: RouterMetadata;

Check warning on line 1143 in packages/types/src/clerk.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

'unknown' overrides all other types in this union type
/**
* Provide a function to be used for navigation.
*/
Expand Down
7 changes: 6 additions & 1 deletion packages/types/src/signIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -124,6 +124,11 @@ export interface SignInResource extends ClerkResource {
* @internal
*/
__internal_toSnapshot: () => SignInJSONSnapshot;

/**
* @internal
*/
__internal_future: SignInFutureResource;
}

export interface SignInFutureResource {
Expand DownExpand Up@@ -151,7 +156,7 @@ export interface SignInFutureResource {
redirectUrl: string;
redirectUrlComplete: string;
}) => Promise<{ error: unknown }>;
finalize: (params: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;
finalize: (params?: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

}

export type SignInStatus =
Expand Down
7 changes: 6 additions & 1 deletion packages/types/src/signUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -117,6 +117,11 @@ export interface SignUpResource extends ClerkResource {
authenticateWithCoinbaseWallet: (params?: SignUpAuthenticateWithWeb3Params) => Promise<SignUpResource>;
authenticateWithOKXWallet: (params?: SignUpAuthenticateWithWeb3Params) => Promise<SignUpResource>;
__internal_toSnapshot: () => SignUpJSONSnapshot;

/**
* @internal
*/
__internal_future: SignUpFutureResource;
}

export interface SignUpFutureResource {
Expand All@@ -127,7 +132,7 @@ export interface SignUpFutureResource {
verifyEmailCode: (params: { code: string }) => Promise<{ error: unknown }>;
};
password: (params: { emailAddress: string; password: string }) => Promise<{ error: unknown }>;
finalize: (params: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;
finalize: (params?: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;
}

export type SignUpStatus = 'missing_requirements' | 'complete' | 'abandoned';
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/rotten-falcons-cover.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
---
'@clerk/clerk-js': minor
'@clerk/clerk-react': minor
'@clerk/types': minor
---

[Experimental] Signals `isLoaded` removal
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -91,7 +91,7 @@ export class SignIn extends BaseResource implements SignInResource {
*
* An instance of `SignInFuture`, which has a different API than `SignIn`, intended to be used in custom flows.
*/
__internal_future: SignInFuture | null = new SignInFuture(this);
__internal_future: SignInFuture = new SignInFuture(this);

/**
* @internal Only used for internal purposes, and is not intended to be used directly.
Expand DownExpand Up@@ -638,7 +638,7 @@ class SignInFuture implements SignInFutureResource {
});
}

async finalize({ navigate }: { navigate?: SetActiveNavigate }): Promise<{ error: unknown }> {
async finalize({ navigate }: { navigate?: SetActiveNavigate } = {}): Promise<{ error: unknown }> {
return runAsyncResourceTask(this.resource, async () => {
if (!this.resource.createdSessionId) {
throw new Error('Cannot finalize sign-in without a created session.');
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/SignUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -87,7 +87,7 @@ export class SignUp extends BaseResource implements SignUpResource {
*
* An instance of `SignUpFuture`, which has a different API than `SignUp`, intended to be used in custom flows.
*/
__internal_future: SignUpFuture | null = new SignUpFuture(this);
__internal_future: SignUpFuture = new SignUpFuture(this);

/**
* @internal Only used for internal purposes, and is not intended to be used directly.
Expand DownExpand Up@@ -539,7 +539,7 @@ class SignUpFuture implements SignUpFutureResource {
});
}

async finalize({ navigate }: { navigate?: SetActiveNavigate }): Promise<{ error: unknown }> {
async finalize({ navigate }: { navigate?: SetActiveNavigate } = {}): Promise<{ error: unknown }> {
return runAsyncResourceTask(this.resource, async () => {
if (!this.resource.createdSessionId) {
throw new Error('Cannot finalize sign-up without a created session.');
Expand Down
32 changes: 18 additions & 14 deletions packages/react/src/hooks/useClerkSignal.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,28 +4,36 @@ import { useCallback, useSyncExternalStore } from 'react';
import { useIsomorphicClerkContext } from '../contexts/IsomorphicClerkContext';
import { useAssertWrappedByClerkProvider } from './useAssertWrappedByClerkProvider';

function useClerkSignal(signal: 'signIn'): ReturnType<SignInSignal> | null;
function useClerkSignal(signal: 'signUp'): ReturnType<SignUpSignal> | null;
function useClerkSignal(signal: 'signIn' | 'signUp'): ReturnType<SignInSignal> | ReturnType<SignUpSignal> | null {
// These types are used to remove the `null` value from the underlying resource. This is safe because IsomorphicClerk
// always returns a valid resource, even before Clerk is loaded, and if Clerk is loaded, the resource is guaranteed to
// be non-null
type NonNullSignInSignal = Omit<ReturnType<SignInSignal>, 'signIn'> & {
signIn: NonNullable<ReturnType<SignInSignal>['signIn']>;
};
type NonNullSignUpSignal = Omit<ReturnType<SignUpSignal>, 'signUp'> & {
signUp: NonNullable<ReturnType<SignUpSignal>['signUp']>;
};

function useClerkSignal(signal: 'signIn'): NonNullSignInSignal;
function useClerkSignal(signal: 'signUp'): NonNullSignUpSignal;
function useClerkSignal(signal: 'signIn' | 'signUp'): NonNullSignInSignal | NonNullSignUpSignal {
useAssertWrappedByClerkProvider('useClerkSignal');

const clerk = useIsomorphicClerkContext();

const subscribe = useCallback(
(callback: () => void) => {
if (!clerk.loaded || !clerk.__internal_state) {
if (!clerk.loaded) {
return () => {};
}

return clerk.__internal_state.__internal_effect(() => {
switch (signal) {
case 'signIn':
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- we know that the state is defined
clerk.__internal_state!.signInSignal();
clerk.__internal_state.signInSignal();
break;
case 'signUp':
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- we know that the state is defined
clerk.__internal_state!.signUpSignal();
clerk.__internal_state.signUpSignal();
break;
default:
throw new Error(`Unknown signal: ${signal}`);
Expand All@@ -36,15 +44,11 @@ function useClerkSignal(signal: 'signIn' | 'signUp'): ReturnType<SignInSignal> |
[clerk, clerk.loaded, clerk.__internal_state],
);
const getSnapshot = useCallback(() => {
if (!clerk.__internal_state) {
return null;
}

switch (signal) {
case 'signIn':
return clerk.__internal_state.signInSignal();
return clerk.__internal_state.signInSignal() as NonNullSignInSignal;
case 'signUp':
return clerk.__internal_state.signUpSignal();
return clerk.__internal_state.signUpSignal() as NonNullSignUpSignal;
default:
throw new Error(`Unknown signal: ${signal}`);
}
Expand Down
7 changes: 5 additions & 2 deletions packages/react/src/isomorphicClerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,7 @@ import type {

import { errorThrower } from './errors/errorThrower';
import { unsupportedNonBrowserDomainOrProxyUrlFunction } from './errors/messages';
import { StateProxy } from './stateProxy';
import type {
BrowserClerk,
BrowserClerkConstructor,
Expand DownExpand Up@@ -158,6 +159,7 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {
#proxyUrl: DomainOrProxyUrl['proxyUrl'];
#publishableKey: string;
#eventBus = createClerkEventBus();
#stateProxy: StateProxy;

get publishableKey(): string {
return this.#publishableKey;
Expand DownExpand Up@@ -250,6 +252,7 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {
this.options = options;
this.Clerk = Clerk;
this.mode = inBrowser() ? 'browser' : 'server';
this.#stateProxy = new StateProxy(this);

if (!this.options.sdkMetadata) {
this.options.sdkMetadata = SDK_METADATA;
Expand DownExpand Up@@ -723,8 +726,8 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {
return this.clerkjs?.billing;
}

get __internal_state(): State | undefined {
return this.clerkjs?.__internal_state;
get __internal_state(): State {
return this.loaded && this.clerkjs ? this.clerkjs.__internal_state : this.#stateProxy;
}

get apiKeys(): APIKeysNamespace | undefined {
Expand Down
113 changes: 113 additions & 0 deletions packages/react/src/stateProxy.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,113 @@
import { inBrowser } from '@clerk/shared/browser';
import type { Errors, State } from '@clerk/types';

import { errorThrower } from './errors/errorThrower';
import type { IsomorphicClerk } from './isomorphicClerk';

const defaultErrors = (): Errors => ({
fields: {
firstName: null,
lastName: null,
emailAddress: null,
identifier: null,
phoneNumber: null,
password: null,
username: null,
code: null,
captcha: null,
legalAccepted: null,
},
raw: [],
global: [],
});

export class StateProxy implements State {
constructor(private isomorphicClerk: IsomorphicClerk) {}

private readonly signInSignalProxy = this.buildSignInProxy();
private readonly signUpSignalProxy = this.buildSignUpProxy();

signInSignal() {
return this.signInSignalProxy;
}
signUpSignal() {
return this.signUpSignalProxy;
}

private buildSignInProxy() {
const target = () => this.client.signIn.__internal_future;

return {
errors: defaultErrors(),
fetchStatus: 'idle' as const,
signIn: {
status: 'needs_identifier' as const,
availableStrategies: [],

create: this.gateMethod(target, 'create'),
password: this.gateMethod(target, 'password'),
sso: this.gateMethod(target, 'sso'),
finalize: this.gateMethod(target, 'finalize'),

emailCode: this.wrapMethods(() => target().emailCode, ['sendCode', 'verifyCode'] as const),
resetPasswordEmailCode: this.wrapMethods(() => target().resetPasswordEmailCode, [
'sendCode',
'verifyCode',
'submitPassword',
] as const),
},
};
}

private buildSignUpProxy() {
const target = () => this.client.signUp.__internal_future;

return {
errors: defaultErrors(),
fetchStatus: 'idle' as const,
signUp: {
status: 'missing_requirements' as const,
unverifiedFields: [],

password: this.gateMethod(target, 'password'),
finalize: this.gateMethod(target, 'finalize'),

verifications: this.wrapMethods(() => target().verifications, ['sendEmailCode', 'verifyEmailCode'] as const),
},
};
}

__internal_effect(_: () => void): () => void {
throw new Error('__internal_effect called before Clerk is loaded');
}
__internal_computed<T>(_: (prev?: T) => T): () => T {
throw new Error('__internal_computed called before Clerk is loaded');
}

private get client() {
const c = this.isomorphicClerk.client;
if (!c) throw new Error('Clerk client not ready');
return c;
}

private gateMethod<T extends object, K extends keyof T & string>(getTarget: () => T, key: K) {
type F = Extract<T[K], (...args: unknown[]) => unknown>;
return (async (...args: Parameters<F>): Promise<ReturnType<F>> => {
if (!inBrowser()) {
return errorThrower.throw(`Attempted to call a method (${key}) that is not supported on the server.`);
}
if (!this.isomorphicClerk.loaded) {
await new Promise<void>(resolve => this.isomorphicClerk.addOnLoaded(resolve));
}
const t = getTarget();
return (t[key] as (...args: Parameters<F>) => ReturnType<F>).apply(t, args);
}) as F;
}

private wrapMethods<T extends object, K extends readonly (keyof T & string)[]>(
getTarget: () => T,
keys: K,
): Pick<T, K[number]> {
return Object.fromEntries(keys.map(k => [k, this.gateMethod(getTarget, k)])) as Pick<T, K[number]>;
}
}
2 changes: 1 addition & 1 deletion packages/types/src/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -235,7 +235,7 @@
* Entrypoint for Clerk's Signal API containing resource signals along with accessible versions of `computed()` and
* `effect()` that can be used to subscribe to changes from Signals.
*/
__internal_state: State | undefined;
__internal_state: State;

/**
* @experimental This is an experimental API for the Billing feature that is available under a public beta, and the API is subject to change.
Expand DownExpand Up@@ -1140,7 +1140,7 @@
/**
* @internal
*/
__internal_metadata?: RouterMetadata;

Check warning on line 1143 in packages/types/src/clerk.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

'unknown' overrides all other types in this union type
/**
* Provide a function to be used for navigation.
*/
Expand Down
7 changes: 6 additions & 1 deletion packages/types/src/signIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -124,6 +124,11 @@ export interface SignInResource extends ClerkResource {
* @internal
*/
__internal_toSnapshot: () => SignInJSONSnapshot;

/**
* @internal
*/
__internal_future: SignInFutureResource;
}

export interface SignInFutureResource {
Expand DownExpand Up@@ -151,7 +156,7 @@ export interface SignInFutureResource {
redirectUrl: string;
redirectUrlComplete: string;
}) => Promise<{ error: unknown }>;
finalize: (params: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;
finalize: (params?: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

}

export type SignInStatus =
Expand Down
7 changes: 6 additions & 1 deletion packages/types/src/signUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -117,6 +117,11 @@ export interface SignUpResource extends ClerkResource {
authenticateWithCoinbaseWallet: (params?: SignUpAuthenticateWithWeb3Params) => Promise<SignUpResource>;
authenticateWithOKXWallet: (params?: SignUpAuthenticateWithWeb3Params) => Promise<SignUpResource>;
__internal_toSnapshot: () => SignUpJSONSnapshot;

/**
* @internal
*/
__internal_future: SignUpFutureResource;
}

export interface SignUpFutureResource {
Expand All@@ -127,7 +132,7 @@ export interface SignUpFutureResource {
verifyEmailCode: (params: { code: string }) => Promise<{ error: unknown }>;
};
password: (params: { emailAddress: string; password: string }) => Promise<{ error: unknown }>;
finalize: (params: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;
finalize: (params?: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;
}

export type SignUpStatus = 'missing_requirements' | 'complete' | 'abandoned';
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/rotten-falcons-cover.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
---
'@clerk/clerk-js': minor
'@clerk/clerk-react': minor
'@clerk/types': minor
---

[Experimental] Signals `isLoaded` removal
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -91,7 +91,7 @@ export class SignIn extends BaseResource implements SignInResource {
*
* An instance of `SignInFuture`, which has a different API than `SignIn`, intended to be used in custom flows.
*/
__internal_future: SignInFuture | null = new SignInFuture(this);
__internal_future: SignInFuture = new SignInFuture(this);

/**
* @internal Only used for internal purposes, and is not intended to be used directly.
Expand DownExpand Up@@ -638,7 +638,7 @@ class SignInFuture implements SignInFutureResource {
});
}

async finalize({ navigate }: { navigate?: SetActiveNavigate }): Promise<{ error: unknown }> {
async finalize({ navigate }: { navigate?: SetActiveNavigate } = {}): Promise<{ error: unknown }> {
return runAsyncResourceTask(this.resource, async () => {
if (!this.resource.createdSessionId) {
throw new Error('Cannot finalize sign-in without a created session.');
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/SignUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -87,7 +87,7 @@ export class SignUp extends BaseResource implements SignUpResource {
*
* An instance of `SignUpFuture`, which has a different API than `SignUp`, intended to be used in custom flows.
*/
__internal_future: SignUpFuture | null = new SignUpFuture(this);
__internal_future: SignUpFuture = new SignUpFuture(this);

/**
* @internal Only used for internal purposes, and is not intended to be used directly.
Expand DownExpand Up@@ -539,7 +539,7 @@ class SignUpFuture implements SignUpFutureResource {
});
}

async finalize({ navigate }: { navigate?: SetActiveNavigate }): Promise<{ error: unknown }> {
async finalize({ navigate }: { navigate?: SetActiveNavigate } = {}): Promise<{ error: unknown }> {
return runAsyncResourceTask(this.resource, async () => {
if (!this.resource.createdSessionId) {
throw new Error('Cannot finalize sign-up without a created session.');
Expand Down
32 changes: 18 additions & 14 deletions packages/react/src/hooks/useClerkSignal.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,28 +4,36 @@ import { useCallback, useSyncExternalStore } from 'react';
import { useIsomorphicClerkContext } from '../contexts/IsomorphicClerkContext';
import { useAssertWrappedByClerkProvider } from './useAssertWrappedByClerkProvider';

function useClerkSignal(signal: 'signIn'): ReturnType<SignInSignal> | null;
function useClerkSignal(signal: 'signUp'): ReturnType<SignUpSignal> | null;
function useClerkSignal(signal: 'signIn' | 'signUp'): ReturnType<SignInSignal> | ReturnType<SignUpSignal> | null {
// These types are used to remove the `null` value from the underlying resource. This is safe because IsomorphicClerk
// always returns a valid resource, even before Clerk is loaded, and if Clerk is loaded, the resource is guaranteed to
// be non-null
type NonNullSignInSignal = Omit<ReturnType<SignInSignal>, 'signIn'> & {
signIn: NonNullable<ReturnType<SignInSignal>['signIn']>;
};
type NonNullSignUpSignal = Omit<ReturnType<SignUpSignal>, 'signUp'> & {
signUp: NonNullable<ReturnType<SignUpSignal>['signUp']>;
};

function useClerkSignal(signal: 'signIn'): NonNullSignInSignal;
function useClerkSignal(signal: 'signUp'): NonNullSignUpSignal;
function useClerkSignal(signal: 'signIn' | 'signUp'): NonNullSignInSignal | NonNullSignUpSignal {
useAssertWrappedByClerkProvider('useClerkSignal');

const clerk = useIsomorphicClerkContext();

const subscribe = useCallback(
(callback: () => void) => {
if (!clerk.loaded || !clerk.__internal_state) {
if (!clerk.loaded) {
return () => {};
}

return clerk.__internal_state.__internal_effect(() => {
switch (signal) {
case 'signIn':
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- we know that the state is defined
clerk.__internal_state!.signInSignal();
clerk.__internal_state.signInSignal();
break;
case 'signUp':
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- we know that the state is defined
clerk.__internal_state!.signUpSignal();
clerk.__internal_state.signUpSignal();
break;
default:
throw new Error(`Unknown signal: ${signal}`);
Expand All@@ -36,15 +44,11 @@ function useClerkSignal(signal: 'signIn' | 'signUp'): ReturnType<SignInSignal> |
[clerk, clerk.loaded, clerk.__internal_state],
);
const getSnapshot = useCallback(() => {
if (!clerk.__internal_state) {
return null;
}

switch (signal) {
case 'signIn':
return clerk.__internal_state.signInSignal();
return clerk.__internal_state.signInSignal() as NonNullSignInSignal;
case 'signUp':
return clerk.__internal_state.signUpSignal();
return clerk.__internal_state.signUpSignal() as NonNullSignUpSignal;
default:
throw new Error(`Unknown signal: ${signal}`);
}
Expand Down
7 changes: 5 additions & 2 deletions packages/react/src/isomorphicClerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,7 @@ import type {

import { errorThrower } from './errors/errorThrower';
import { unsupportedNonBrowserDomainOrProxyUrlFunction } from './errors/messages';
import { StateProxy } from './stateProxy';
import type {
BrowserClerk,
BrowserClerkConstructor,
Expand DownExpand Up@@ -158,6 +159,7 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {
#proxyUrl: DomainOrProxyUrl['proxyUrl'];
#publishableKey: string;
#eventBus = createClerkEventBus();
#stateProxy: StateProxy;

get publishableKey(): string {
return this.#publishableKey;
Expand DownExpand Up@@ -250,6 +252,7 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {
this.options = options;
this.Clerk = Clerk;
this.mode = inBrowser() ? 'browser' : 'server';
this.#stateProxy = new StateProxy(this);

if (!this.options.sdkMetadata) {
this.options.sdkMetadata = SDK_METADATA;
Expand DownExpand Up@@ -723,8 +726,8 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {
return this.clerkjs?.billing;
}

get __internal_state(): State | undefined {
return this.clerkjs?.__internal_state;
get __internal_state(): State {
return this.loaded && this.clerkjs ? this.clerkjs.__internal_state : this.#stateProxy;
}

get apiKeys(): APIKeysNamespace | undefined {
Expand Down
113 changes: 113 additions & 0 deletions packages/react/src/stateProxy.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,113 @@
import { inBrowser } from '@clerk/shared/browser';
import type { Errors, State } from '@clerk/types';

import { errorThrower } from './errors/errorThrower';
import type { IsomorphicClerk } from './isomorphicClerk';

const defaultErrors = (): Errors => ({
fields: {
firstName: null,
lastName: null,
emailAddress: null,
identifier: null,
phoneNumber: null,
password: null,
username: null,
code: null,
captcha: null,
legalAccepted: null,
},
raw: [],
global: [],
});

export class StateProxy implements State {
constructor(private isomorphicClerk: IsomorphicClerk) {}

private readonly signInSignalProxy = this.buildSignInProxy();
private readonly signUpSignalProxy = this.buildSignUpProxy();

signInSignal() {
return this.signInSignalProxy;
}
signUpSignal() {
return this.signUpSignalProxy;
}

private buildSignInProxy() {
const target = () => this.client.signIn.__internal_future;

return {
errors: defaultErrors(),
fetchStatus: 'idle' as const,
signIn: {
status: 'needs_identifier' as const,
availableStrategies: [],

create: this.gateMethod(target, 'create'),
password: this.gateMethod(target, 'password'),
sso: this.gateMethod(target, 'sso'),
finalize: this.gateMethod(target, 'finalize'),

emailCode: this.wrapMethods(() => target().emailCode, ['sendCode', 'verifyCode'] as const),
resetPasswordEmailCode: this.wrapMethods(() => target().resetPasswordEmailCode, [
'sendCode',
'verifyCode',
'submitPassword',
] as const),
},
};
}

private buildSignUpProxy() {
const target = () => this.client.signUp.__internal_future;

return {
errors: defaultErrors(),
fetchStatus: 'idle' as const,
signUp: {
status: 'missing_requirements' as const,
unverifiedFields: [],

password: this.gateMethod(target, 'password'),
finalize: this.gateMethod(target, 'finalize'),

verifications: this.wrapMethods(() => target().verifications, ['sendEmailCode', 'verifyEmailCode'] as const),
},
};
}

__internal_effect(_: () => void): () => void {
throw new Error('__internal_effect called before Clerk is loaded');
}
__internal_computed<T>(_: (prev?: T) => T): () => T {
throw new Error('__internal_computed called before Clerk is loaded');
}

private get client() {
const c = this.isomorphicClerk.client;
if (!c) throw new Error('Clerk client not ready');
return c;
}

private gateMethod<T extends object, K extends keyof T & string>(getTarget: () => T, key: K) {
type F = Extract<T[K], (...args: unknown[]) => unknown>;
return (async (...args: Parameters<F>): Promise<ReturnType<F>> => {
if (!inBrowser()) {
return errorThrower.throw(`Attempted to call a method (${key}) that is not supported on the server.`);
}
if (!this.isomorphicClerk.loaded) {
await new Promise<void>(resolve => this.isomorphicClerk.addOnLoaded(resolve));
}
const t = getTarget();
return (t[key] as (...args: Parameters<F>) => ReturnType<F>).apply(t, args);
}) as F;
}

private wrapMethods<T extends object, K extends readonly (keyof T & string)[]>(
getTarget: () => T,
keys: K,
): Pick<T, K[number]> {
return Object.fromEntries(keys.map(k => [k, this.gateMethod(getTarget, k)])) as Pick<T, K[number]>;
}
}
2 changes: 1 addition & 1 deletion packages/types/src/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -235,7 +235,7 @@
* Entrypoint for Clerk's Signal API containing resource signals along with accessible versions of `computed()` and
* `effect()` that can be used to subscribe to changes from Signals.
*/
__internal_state: State | undefined;
__internal_state: State;

/**
* @experimental This is an experimental API for the Billing feature that is available under a public beta, and the API is subject to change.
Expand DownExpand Up@@ -1140,7 +1140,7 @@
/**
* @internal
*/
__internal_metadata?: RouterMetadata;

Check warning on line 1143 in packages/types/src/clerk.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

'unknown' overrides all other types in this union type
/**
* Provide a function to be used for navigation.
*/
Expand Down
7 changes: 6 additions & 1 deletion packages/types/src/signIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -124,6 +124,11 @@ export interface SignInResource extends ClerkResource {
* @internal
*/
__internal_toSnapshot: () => SignInJSONSnapshot;

/**
* @internal
*/
__internal_future: SignInFutureResource;
}

export interface SignInFutureResource {
Expand DownExpand Up@@ -151,7 +156,7 @@ export interface SignInFutureResource {
redirectUrl: string;
redirectUrlComplete: string;
}) => Promise<{ error: unknown }>;
finalize: (params: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;
finalize: (params?: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

}

export type SignInStatus =
Expand Down
7 changes: 6 additions & 1 deletion packages/types/src/signUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -117,6 +117,11 @@ export interface SignUpResource extends ClerkResource {
authenticateWithCoinbaseWallet: (params?: SignUpAuthenticateWithWeb3Params) => Promise<SignUpResource>;
authenticateWithOKXWallet: (params?: SignUpAuthenticateWithWeb3Params) => Promise<SignUpResource>;
__internal_toSnapshot: () => SignUpJSONSnapshot;

/**
* @internal
*/
__internal_future: SignUpFutureResource;
}

export interface SignUpFutureResource {
Expand All@@ -127,7 +132,7 @@ export interface SignUpFutureResource {
verifyEmailCode: (params: { code: string }) => Promise<{ error: unknown }>;
};
password: (params: { emailAddress: string; password: string }) => Promise<{ error: unknown }>;
finalize: (params: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;
finalize: (params?: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;
}

export type SignUpStatus = 'missing_requirements' | 'complete' | 'abandoned';
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/rotten-falcons-cover.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
---
'@clerk/clerk-js': minor
'@clerk/clerk-react': minor
'@clerk/types': minor
---

[Experimental] Signals `isLoaded` removal
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -91,7 +91,7 @@ export class SignIn extends BaseResource implements SignInResource {
*
* An instance of `SignInFuture`, which has a different API than `SignIn`, intended to be used in custom flows.
*/
__internal_future: SignInFuture | null = new SignInFuture(this);
__internal_future: SignInFuture = new SignInFuture(this);

/**
* @internal Only used for internal purposes, and is not intended to be used directly.
Expand DownExpand Up@@ -638,7 +638,7 @@ class SignInFuture implements SignInFutureResource {
});
}

async finalize({ navigate }: { navigate?: SetActiveNavigate }): Promise<{ error: unknown }> {
async finalize({ navigate }: { navigate?: SetActiveNavigate } = {}): Promise<{ error: unknown }> {
return runAsyncResourceTask(this.resource, async () => {
if (!this.resource.createdSessionId) {
throw new Error('Cannot finalize sign-in without a created session.');
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/SignUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -87,7 +87,7 @@ export class SignUp extends BaseResource implements SignUpResource {
*
* An instance of `SignUpFuture`, which has a different API than `SignUp`, intended to be used in custom flows.
*/
__internal_future: SignUpFuture | null = new SignUpFuture(this);
__internal_future: SignUpFuture = new SignUpFuture(this);

/**
* @internal Only used for internal purposes, and is not intended to be used directly.
Expand DownExpand Up@@ -539,7 +539,7 @@ class SignUpFuture implements SignUpFutureResource {
});
}

async finalize({ navigate }: { navigate?: SetActiveNavigate }): Promise<{ error: unknown }> {
async finalize({ navigate }: { navigate?: SetActiveNavigate } = {}): Promise<{ error: unknown }> {
return runAsyncResourceTask(this.resource, async () => {
if (!this.resource.createdSessionId) {
throw new Error('Cannot finalize sign-up without a created session.');
Expand Down
32 changes: 18 additions & 14 deletions packages/react/src/hooks/useClerkSignal.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,28 +4,36 @@ import { useCallback, useSyncExternalStore } from 'react';
import { useIsomorphicClerkContext } from '../contexts/IsomorphicClerkContext';
import { useAssertWrappedByClerkProvider } from './useAssertWrappedByClerkProvider';

function useClerkSignal(signal: 'signIn'): ReturnType<SignInSignal> | null;
function useClerkSignal(signal: 'signUp'): ReturnType<SignUpSignal> | null;
function useClerkSignal(signal: 'signIn' | 'signUp'): ReturnType<SignInSignal> | ReturnType<SignUpSignal> | null {
// These types are used to remove the `null` value from the underlying resource. This is safe because IsomorphicClerk
// always returns a valid resource, even before Clerk is loaded, and if Clerk is loaded, the resource is guaranteed to
// be non-null
type NonNullSignInSignal = Omit<ReturnType<SignInSignal>, 'signIn'> & {
signIn: NonNullable<ReturnType<SignInSignal>['signIn']>;
};
type NonNullSignUpSignal = Omit<ReturnType<SignUpSignal>, 'signUp'> & {
signUp: NonNullable<ReturnType<SignUpSignal>['signUp']>;
};

function useClerkSignal(signal: 'signIn'): NonNullSignInSignal;
function useClerkSignal(signal: 'signUp'): NonNullSignUpSignal;
function useClerkSignal(signal: 'signIn' | 'signUp'): NonNullSignInSignal | NonNullSignUpSignal {
useAssertWrappedByClerkProvider('useClerkSignal');

const clerk = useIsomorphicClerkContext();

const subscribe = useCallback(
(callback: () => void) => {
if (!clerk.loaded || !clerk.__internal_state) {
if (!clerk.loaded) {
return () => {};
}

return clerk.__internal_state.__internal_effect(() => {
switch (signal) {
case 'signIn':
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- we know that the state is defined
clerk.__internal_state!.signInSignal();
clerk.__internal_state.signInSignal();
break;
case 'signUp':
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- we know that the state is defined
clerk.__internal_state!.signUpSignal();
clerk.__internal_state.signUpSignal();
break;
default:
throw new Error(`Unknown signal: ${signal}`);
Expand All@@ -36,15 +44,11 @@ function useClerkSignal(signal: 'signIn' | 'signUp'): ReturnType<SignInSignal> |
[clerk, clerk.loaded, clerk.__internal_state],
);
const getSnapshot = useCallback(() => {
if (!clerk.__internal_state) {
return null;
}

switch (signal) {
case 'signIn':
return clerk.__internal_state.signInSignal();
return clerk.__internal_state.signInSignal() as NonNullSignInSignal;
case 'signUp':
return clerk.__internal_state.signUpSignal();
return clerk.__internal_state.signUpSignal() as NonNullSignUpSignal;
default:
throw new Error(`Unknown signal: ${signal}`);
}
Expand Down
7 changes: 5 additions & 2 deletions packages/react/src/isomorphicClerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,7 @@ import type {

import { errorThrower } from './errors/errorThrower';
import { unsupportedNonBrowserDomainOrProxyUrlFunction } from './errors/messages';
import { StateProxy } from './stateProxy';
import type {
BrowserClerk,
BrowserClerkConstructor,
Expand DownExpand Up@@ -158,6 +159,7 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {
#proxyUrl: DomainOrProxyUrl['proxyUrl'];
#publishableKey: string;
#eventBus = createClerkEventBus();
#stateProxy: StateProxy;

get publishableKey(): string {
return this.#publishableKey;
Expand DownExpand Up@@ -250,6 +252,7 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {
this.options = options;
this.Clerk = Clerk;
this.mode = inBrowser() ? 'browser' : 'server';
this.#stateProxy = new StateProxy(this);

if (!this.options.sdkMetadata) {
this.options.sdkMetadata = SDK_METADATA;
Expand DownExpand Up@@ -723,8 +726,8 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {
return this.clerkjs?.billing;
}

get __internal_state(): State | undefined {
return this.clerkjs?.__internal_state;
get __internal_state(): State {
return this.loaded && this.clerkjs ? this.clerkjs.__internal_state : this.#stateProxy;
}

get apiKeys(): APIKeysNamespace | undefined {
Expand Down
113 changes: 113 additions & 0 deletions packages/react/src/stateProxy.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,113 @@
import { inBrowser } from '@clerk/shared/browser';
import type { Errors, State } from '@clerk/types';

import { errorThrower } from './errors/errorThrower';
import type { IsomorphicClerk } from './isomorphicClerk';

const defaultErrors = (): Errors => ({
fields: {
firstName: null,
lastName: null,
emailAddress: null,
identifier: null,
phoneNumber: null,
password: null,
username: null,
code: null,
captcha: null,
legalAccepted: null,
},
raw: [],
global: [],
});

export class StateProxy implements State {
constructor(private isomorphicClerk: IsomorphicClerk) {}

private readonly signInSignalProxy = this.buildSignInProxy();
private readonly signUpSignalProxy = this.buildSignUpProxy();

signInSignal() {
return this.signInSignalProxy;
}
signUpSignal() {
return this.signUpSignalProxy;
}

private buildSignInProxy() {
const target = () => this.client.signIn.__internal_future;

return {
errors: defaultErrors(),
fetchStatus: 'idle' as const,
signIn: {
status: 'needs_identifier' as const,
availableStrategies: [],

create: this.gateMethod(target, 'create'),
password: this.gateMethod(target, 'password'),
sso: this.gateMethod(target, 'sso'),
finalize: this.gateMethod(target, 'finalize'),

emailCode: this.wrapMethods(() => target().emailCode, ['sendCode', 'verifyCode'] as const),
resetPasswordEmailCode: this.wrapMethods(() => target().resetPasswordEmailCode, [
'sendCode',
'verifyCode',
'submitPassword',
] as const),
},
};
}

private buildSignUpProxy() {
const target = () => this.client.signUp.__internal_future;

return {
errors: defaultErrors(),
fetchStatus: 'idle' as const,
signUp: {
status: 'missing_requirements' as const,
unverifiedFields: [],

password: this.gateMethod(target, 'password'),
finalize: this.gateMethod(target, 'finalize'),

verifications: this.wrapMethods(() => target().verifications, ['sendEmailCode', 'verifyEmailCode'] as const),
},
};
}

__internal_effect(_: () => void): () => void {
throw new Error('__internal_effect called before Clerk is loaded');
}
__internal_computed<T>(_: (prev?: T) => T): () => T {
throw new Error('__internal_computed called before Clerk is loaded');
}

private get client() {
const c = this.isomorphicClerk.client;
if (!c) throw new Error('Clerk client not ready');
return c;
}

private gateMethod<T extends object, K extends keyof T & string>(getTarget: () => T, key: K) {
type F = Extract<T[K], (...args: unknown[]) => unknown>;
return (async (...args: Parameters<F>): Promise<ReturnType<F>> => {
if (!inBrowser()) {
return errorThrower.throw(`Attempted to call a method (${key}) that is not supported on the server.`);
}
if (!this.isomorphicClerk.loaded) {
await new Promise<void>(resolve => this.isomorphicClerk.addOnLoaded(resolve));
}
const t = getTarget();
return (t[key] as (...args: Parameters<F>) => ReturnType<F>).apply(t, args);
}) as F;
}

private wrapMethods<T extends object, K extends readonly (keyof T & string)[]>(
getTarget: () => T,
keys: K,
): Pick<T, K[number]> {
return Object.fromEntries(keys.map(k => [k, this.gateMethod(getTarget, k)])) as Pick<T, K[number]>;
}
}
2 changes: 1 addition & 1 deletion packages/types/src/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -235,7 +235,7 @@
* Entrypoint for Clerk's Signal API containing resource signals along with accessible versions of `computed()` and
* `effect()` that can be used to subscribe to changes from Signals.
*/
__internal_state: State | undefined;
__internal_state: State;

/**
* @experimental This is an experimental API for the Billing feature that is available under a public beta, and the API is subject to change.
Expand DownExpand Up@@ -1140,7 +1140,7 @@
/**
* @internal
*/
__internal_metadata?: RouterMetadata;

Check warning on line 1143 in packages/types/src/clerk.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

'unknown' overrides all other types in this union type
/**
* Provide a function to be used for navigation.
*/
Expand Down
7 changes: 6 additions & 1 deletion packages/types/src/signIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -124,6 +124,11 @@ export interface SignInResource extends ClerkResource {
* @internal
*/
__internal_toSnapshot: () => SignInJSONSnapshot;

/**
* @internal
*/
__internal_future: SignInFutureResource;
}

export interface SignInFutureResource {
Expand DownExpand Up@@ -151,7 +156,7 @@ export interface SignInFutureResource {
redirectUrl: string;
redirectUrlComplete: string;
}) => Promise<{ error: unknown }>;
finalize: (params: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;
finalize: (params?: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

}

export type SignInStatus =
Expand Down
7 changes: 6 additions & 1 deletion packages/types/src/signUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -117,6 +117,11 @@ export interface SignUpResource extends ClerkResource {
authenticateWithCoinbaseWallet: (params?: SignUpAuthenticateWithWeb3Params) => Promise<SignUpResource>;
authenticateWithOKXWallet: (params?: SignUpAuthenticateWithWeb3Params) => Promise<SignUpResource>;
__internal_toSnapshot: () => SignUpJSONSnapshot;

/**
* @internal
*/
__internal_future: SignUpFutureResource;
}

export interface SignUpFutureResource {
Expand All@@ -127,7 +132,7 @@ export interface SignUpFutureResource {
verifyEmailCode: (params: { code: string }) => Promise<{ error: unknown }>;
};
password: (params: { emailAddress: string; password: string }) => Promise<{ error: unknown }>;
finalize: (params: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;
finalize: (params?: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;
}

export type SignUpStatus = 'missing_requirements' | 'complete' | 'abandoned';
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/rotten-falcons-cover.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
---
'@clerk/clerk-js': minor
'@clerk/clerk-react': minor
'@clerk/types': minor
---

[Experimental] Signals `isLoaded` removal
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -91,7 +91,7 @@ export class SignIn extends BaseResource implements SignInResource {
*
* An instance of `SignInFuture`, which has a different API than `SignIn`, intended to be used in custom flows.
*/
__internal_future: SignInFuture | null = new SignInFuture(this);
__internal_future: SignInFuture = new SignInFuture(this);

/**
* @internal Only used for internal purposes, and is not intended to be used directly.
Expand DownExpand Up@@ -638,7 +638,7 @@ class SignInFuture implements SignInFutureResource {
});
}

async finalize({ navigate }: { navigate?: SetActiveNavigate }): Promise<{ error: unknown }> {
async finalize({ navigate }: { navigate?: SetActiveNavigate } = {}): Promise<{ error: unknown }> {
return runAsyncResourceTask(this.resource, async () => {
if (!this.resource.createdSessionId) {
throw new Error('Cannot finalize sign-in without a created session.');
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/SignUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -87,7 +87,7 @@ export class SignUp extends BaseResource implements SignUpResource {
*
* An instance of `SignUpFuture`, which has a different API than `SignUp`, intended to be used in custom flows.
*/
__internal_future: SignUpFuture | null = new SignUpFuture(this);
__internal_future: SignUpFuture = new SignUpFuture(this);

/**
* @internal Only used for internal purposes, and is not intended to be used directly.
Expand DownExpand Up@@ -539,7 +539,7 @@ class SignUpFuture implements SignUpFutureResource {
});
}

async finalize({ navigate }: { navigate?: SetActiveNavigate }): Promise<{ error: unknown }> {
async finalize({ navigate }: { navigate?: SetActiveNavigate } = {}): Promise<{ error: unknown }> {
return runAsyncResourceTask(this.resource, async () => {
if (!this.resource.createdSessionId) {
throw new Error('Cannot finalize sign-up without a created session.');
Expand Down
32 changes: 18 additions & 14 deletions packages/react/src/hooks/useClerkSignal.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,28 +4,36 @@ import { useCallback, useSyncExternalStore } from 'react';
import { useIsomorphicClerkContext } from '../contexts/IsomorphicClerkContext';
import { useAssertWrappedByClerkProvider } from './useAssertWrappedByClerkProvider';

function useClerkSignal(signal: 'signIn'): ReturnType<SignInSignal> | null;
function useClerkSignal(signal: 'signUp'): ReturnType<SignUpSignal> | null;
function useClerkSignal(signal: 'signIn' | 'signUp'): ReturnType<SignInSignal> | ReturnType<SignUpSignal> | null {
// These types are used to remove the `null` value from the underlying resource. This is safe because IsomorphicClerk
// always returns a valid resource, even before Clerk is loaded, and if Clerk is loaded, the resource is guaranteed to
// be non-null
type NonNullSignInSignal = Omit<ReturnType<SignInSignal>, 'signIn'> & {
signIn: NonNullable<ReturnType<SignInSignal>['signIn']>;
};
type NonNullSignUpSignal = Omit<ReturnType<SignUpSignal>, 'signUp'> & {
signUp: NonNullable<ReturnType<SignUpSignal>['signUp']>;
};

function useClerkSignal(signal: 'signIn'): NonNullSignInSignal;
function useClerkSignal(signal: 'signUp'): NonNullSignUpSignal;
function useClerkSignal(signal: 'signIn' | 'signUp'): NonNullSignInSignal | NonNullSignUpSignal {
useAssertWrappedByClerkProvider('useClerkSignal');

const clerk = useIsomorphicClerkContext();

const subscribe = useCallback(
(callback: () => void) => {
if (!clerk.loaded || !clerk.__internal_state) {
if (!clerk.loaded) {
return () => {};
}

return clerk.__internal_state.__internal_effect(() => {
switch (signal) {
case 'signIn':
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- we know that the state is defined
clerk.__internal_state!.signInSignal();
clerk.__internal_state.signInSignal();
break;
case 'signUp':
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- we know that the state is defined
clerk.__internal_state!.signUpSignal();
clerk.__internal_state.signUpSignal();
break;
default:
throw new Error(`Unknown signal: ${signal}`);
Expand All@@ -36,15 +44,11 @@ function useClerkSignal(signal: 'signIn' | 'signUp'): ReturnType<SignInSignal> |
[clerk, clerk.loaded, clerk.__internal_state],
);
const getSnapshot = useCallback(() => {
if (!clerk.__internal_state) {
return null;
}

switch (signal) {
case 'signIn':
return clerk.__internal_state.signInSignal();
return clerk.__internal_state.signInSignal() as NonNullSignInSignal;
case 'signUp':
return clerk.__internal_state.signUpSignal();
return clerk.__internal_state.signUpSignal() as NonNullSignUpSignal;
default:
throw new Error(`Unknown signal: ${signal}`);
}
Expand Down
7 changes: 5 additions & 2 deletions packages/react/src/isomorphicClerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,7 @@ import type {

import { errorThrower } from './errors/errorThrower';
import { unsupportedNonBrowserDomainOrProxyUrlFunction } from './errors/messages';
import { StateProxy } from './stateProxy';
import type {
BrowserClerk,
BrowserClerkConstructor,
Expand DownExpand Up@@ -158,6 +159,7 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {
#proxyUrl: DomainOrProxyUrl['proxyUrl'];
#publishableKey: string;
#eventBus = createClerkEventBus();
#stateProxy: StateProxy;

get publishableKey(): string {
return this.#publishableKey;
Expand DownExpand Up@@ -250,6 +252,7 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {
this.options = options;
this.Clerk = Clerk;
this.mode = inBrowser() ? 'browser' : 'server';
this.#stateProxy = new StateProxy(this);

if (!this.options.sdkMetadata) {
this.options.sdkMetadata = SDK_METADATA;
Expand DownExpand Up@@ -723,8 +726,8 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {
return this.clerkjs?.billing;
}

get __internal_state(): State | undefined {
return this.clerkjs?.__internal_state;
get __internal_state(): State {
return this.loaded && this.clerkjs ? this.clerkjs.__internal_state : this.#stateProxy;
}

get apiKeys(): APIKeysNamespace | undefined {
Expand Down
113 changes: 113 additions & 0 deletions packages/react/src/stateProxy.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,113 @@
import { inBrowser } from '@clerk/shared/browser';
import type { Errors, State } from '@clerk/types';

import { errorThrower } from './errors/errorThrower';
import type { IsomorphicClerk } from './isomorphicClerk';

const defaultErrors = (): Errors => ({
fields: {
firstName: null,
lastName: null,
emailAddress: null,
identifier: null,
phoneNumber: null,
password: null,
username: null,
code: null,
captcha: null,
legalAccepted: null,
},
raw: [],
global: [],
});

export class StateProxy implements State {
constructor(private isomorphicClerk: IsomorphicClerk) {}

private readonly signInSignalProxy = this.buildSignInProxy();
private readonly signUpSignalProxy = this.buildSignUpProxy();

signInSignal() {
return this.signInSignalProxy;
}
signUpSignal() {
return this.signUpSignalProxy;
}

private buildSignInProxy() {
const target = () => this.client.signIn.__internal_future;

return {
errors: defaultErrors(),
fetchStatus: 'idle' as const,
signIn: {
status: 'needs_identifier' as const,
availableStrategies: [],

create: this.gateMethod(target, 'create'),
password: this.gateMethod(target, 'password'),
sso: this.gateMethod(target, 'sso'),
finalize: this.gateMethod(target, 'finalize'),

emailCode: this.wrapMethods(() => target().emailCode, ['sendCode', 'verifyCode'] as const),
resetPasswordEmailCode: this.wrapMethods(() => target().resetPasswordEmailCode, [
'sendCode',
'verifyCode',
'submitPassword',
] as const),
},
};
}

private buildSignUpProxy() {
const target = () => this.client.signUp.__internal_future;

return {
errors: defaultErrors(),
fetchStatus: 'idle' as const,
signUp: {
status: 'missing_requirements' as const,
unverifiedFields: [],

password: this.gateMethod(target, 'password'),
finalize: this.gateMethod(target, 'finalize'),

verifications: this.wrapMethods(() => target().verifications, ['sendEmailCode', 'verifyEmailCode'] as const),
},
};
}

__internal_effect(_: () => void): () => void {
throw new Error('__internal_effect called before Clerk is loaded');
}
__internal_computed<T>(_: (prev?: T) => T): () => T {
throw new Error('__internal_computed called before Clerk is loaded');
}

private get client() {
const c = this.isomorphicClerk.client;
if (!c) throw new Error('Clerk client not ready');
return c;
}

private gateMethod<T extends object, K extends keyof T & string>(getTarget: () => T, key: K) {
type F = Extract<T[K], (...args: unknown[]) => unknown>;
return (async (...args: Parameters<F>): Promise<ReturnType<F>> => {
if (!inBrowser()) {
return errorThrower.throw(`Attempted to call a method (${key}) that is not supported on the server.`);
}
if (!this.isomorphicClerk.loaded) {
await new Promise<void>(resolve => this.isomorphicClerk.addOnLoaded(resolve));
}
const t = getTarget();
return (t[key] as (...args: Parameters<F>) => ReturnType<F>).apply(t, args);
}) as F;
}

private wrapMethods<T extends object, K extends readonly (keyof T & string)[]>(
getTarget: () => T,
keys: K,
): Pick<T, K[number]> {
return Object.fromEntries(keys.map(k => [k, this.gateMethod(getTarget, k)])) as Pick<T, K[number]>;
}
}
2 changes: 1 addition & 1 deletion packages/types/src/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -235,7 +235,7 @@
* Entrypoint for Clerk's Signal API containing resource signals along with accessible versions of `computed()` and
* `effect()` that can be used to subscribe to changes from Signals.
*/
__internal_state: State | undefined;
__internal_state: State;

/**
* @experimental This is an experimental API for the Billing feature that is available under a public beta, and the API is subject to change.
Expand DownExpand Up@@ -1140,7 +1140,7 @@
/**
* @internal
*/
__internal_metadata?: RouterMetadata;

Check warning on line 1143 in packages/types/src/clerk.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

'unknown' overrides all other types in this union type
/**
* Provide a function to be used for navigation.
*/
Expand Down
7 changes: 6 additions & 1 deletion packages/types/src/signIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -124,6 +124,11 @@ export interface SignInResource extends ClerkResource {
* @internal
*/
__internal_toSnapshot: () => SignInJSONSnapshot;

/**
* @internal
*/
__internal_future: SignInFutureResource;
}

export interface SignInFutureResource {
Expand DownExpand Up@@ -151,7 +156,7 @@ export interface SignInFutureResource {
redirectUrl: string;
redirectUrlComplete: string;
}) => Promise<{ error: unknown }>;
finalize: (params: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;
finalize: (params?: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

}

export type SignInStatus =
Expand Down
7 changes: 6 additions & 1 deletion packages/types/src/signUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -117,6 +117,11 @@ export interface SignUpResource extends ClerkResource {
authenticateWithCoinbaseWallet: (params?: SignUpAuthenticateWithWeb3Params) => Promise<SignUpResource>;
authenticateWithOKXWallet: (params?: SignUpAuthenticateWithWeb3Params) => Promise<SignUpResource>;
__internal_toSnapshot: () => SignUpJSONSnapshot;

/**
* @internal
*/
__internal_future: SignUpFutureResource;
}

export interface SignUpFutureResource {
Expand All@@ -127,7 +132,7 @@ export interface SignUpFutureResource {
verifyEmailCode: (params: { code: string }) => Promise<{ error: unknown }>;
};
password: (params: { emailAddress: string; password: string }) => Promise<{ error: unknown }>;
finalize: (params: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;
finalize: (params?: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;
}

export type SignUpStatus = 'missing_requirements' | 'complete' | 'abandoned';
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/rotten-falcons-cover.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
---
'@clerk/clerk-js': minor
'@clerk/clerk-react': minor
'@clerk/types': minor
---

[Experimental] Signals `isLoaded` removal
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -91,7 +91,7 @@ export class SignIn extends BaseResource implements SignInResource {
*
* An instance of `SignInFuture`, which has a different API than `SignIn`, intended to be used in custom flows.
*/
__internal_future: SignInFuture | null = new SignInFuture(this);
__internal_future: SignInFuture = new SignInFuture(this);

/**
* @internal Only used for internal purposes, and is not intended to be used directly.
Expand DownExpand Up@@ -638,7 +638,7 @@ class SignInFuture implements SignInFutureResource {
});
}

async finalize({ navigate }: { navigate?: SetActiveNavigate }): Promise<{ error: unknown }> {
async finalize({ navigate }: { navigate?: SetActiveNavigate } = {}): Promise<{ error: unknown }> {
return runAsyncResourceTask(this.resource, async () => {
if (!this.resource.createdSessionId) {
throw new Error('Cannot finalize sign-in without a created session.');
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/SignUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -87,7 +87,7 @@ export class SignUp extends BaseResource implements SignUpResource {
*
* An instance of `SignUpFuture`, which has a different API than `SignUp`, intended to be used in custom flows.
*/
__internal_future: SignUpFuture | null = new SignUpFuture(this);
__internal_future: SignUpFuture = new SignUpFuture(this);

/**
* @internal Only used for internal purposes, and is not intended to be used directly.
Expand DownExpand Up@@ -539,7 +539,7 @@ class SignUpFuture implements SignUpFutureResource {
});
}

async finalize({ navigate }: { navigate?: SetActiveNavigate }): Promise<{ error: unknown }> {
async finalize({ navigate }: { navigate?: SetActiveNavigate } = {}): Promise<{ error: unknown }> {
return runAsyncResourceTask(this.resource, async () => {
if (!this.resource.createdSessionId) {
throw new Error('Cannot finalize sign-up without a created session.');
Expand Down
32 changes: 18 additions & 14 deletions packages/react/src/hooks/useClerkSignal.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,28 +4,36 @@ import { useCallback, useSyncExternalStore } from 'react';
import { useIsomorphicClerkContext } from '../contexts/IsomorphicClerkContext';
import { useAssertWrappedByClerkProvider } from './useAssertWrappedByClerkProvider';

function useClerkSignal(signal: 'signIn'): ReturnType<SignInSignal> | null;
function useClerkSignal(signal: 'signUp'): ReturnType<SignUpSignal> | null;
function useClerkSignal(signal: 'signIn' | 'signUp'): ReturnType<SignInSignal> | ReturnType<SignUpSignal> | null {
// These types are used to remove the `null` value from the underlying resource. This is safe because IsomorphicClerk
// always returns a valid resource, even before Clerk is loaded, and if Clerk is loaded, the resource is guaranteed to
// be non-null
type NonNullSignInSignal = Omit<ReturnType<SignInSignal>, 'signIn'> & {
signIn: NonNullable<ReturnType<SignInSignal>['signIn']>;
};
type NonNullSignUpSignal = Omit<ReturnType<SignUpSignal>, 'signUp'> & {
signUp: NonNullable<ReturnType<SignUpSignal>['signUp']>;
};

function useClerkSignal(signal: 'signIn'): NonNullSignInSignal;
function useClerkSignal(signal: 'signUp'): NonNullSignUpSignal;
function useClerkSignal(signal: 'signIn' | 'signUp'): NonNullSignInSignal | NonNullSignUpSignal {
useAssertWrappedByClerkProvider('useClerkSignal');

const clerk = useIsomorphicClerkContext();

const subscribe = useCallback(
(callback: () => void) => {
if (!clerk.loaded || !clerk.__internal_state) {
if (!clerk.loaded) {
return () => {};
}

return clerk.__internal_state.__internal_effect(() => {
switch (signal) {
case 'signIn':
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- we know that the state is defined
clerk.__internal_state!.signInSignal();
clerk.__internal_state.signInSignal();
break;
case 'signUp':
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- we know that the state is defined
clerk.__internal_state!.signUpSignal();
clerk.__internal_state.signUpSignal();
break;
default:
throw new Error(`Unknown signal: ${signal}`);
Expand All@@ -36,15 +44,11 @@ function useClerkSignal(signal: 'signIn' | 'signUp'): ReturnType<SignInSignal> |
[clerk, clerk.loaded, clerk.__internal_state],
);
const getSnapshot = useCallback(() => {
if (!clerk.__internal_state) {
return null;
}

switch (signal) {
case 'signIn':
return clerk.__internal_state.signInSignal();
return clerk.__internal_state.signInSignal() as NonNullSignInSignal;
case 'signUp':
return clerk.__internal_state.signUpSignal();
return clerk.__internal_state.signUpSignal() as NonNullSignUpSignal;
default:
throw new Error(`Unknown signal: ${signal}`);
}
Expand Down
7 changes: 5 additions & 2 deletions packages/react/src/isomorphicClerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,7 @@ import type {

import { errorThrower } from './errors/errorThrower';
import { unsupportedNonBrowserDomainOrProxyUrlFunction } from './errors/messages';
import { StateProxy } from './stateProxy';
import type {
BrowserClerk,
BrowserClerkConstructor,
Expand DownExpand Up@@ -158,6 +159,7 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {
#proxyUrl: DomainOrProxyUrl['proxyUrl'];
#publishableKey: string;
#eventBus = createClerkEventBus();
#stateProxy: StateProxy;

get publishableKey(): string {
return this.#publishableKey;
Expand DownExpand Up@@ -250,6 +252,7 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {
this.options = options;
this.Clerk = Clerk;
this.mode = inBrowser() ? 'browser' : 'server';
this.#stateProxy = new StateProxy(this);

if (!this.options.sdkMetadata) {
this.options.sdkMetadata = SDK_METADATA;
Expand DownExpand Up@@ -723,8 +726,8 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {
return this.clerkjs?.billing;
}

get __internal_state(): State | undefined {
return this.clerkjs?.__internal_state;
get __internal_state(): State {
return this.loaded && this.clerkjs ? this.clerkjs.__internal_state : this.#stateProxy;
}

get apiKeys(): APIKeysNamespace | undefined {
Expand Down
113 changes: 113 additions & 0 deletions packages/react/src/stateProxy.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,113 @@
import { inBrowser } from '@clerk/shared/browser';
import type { Errors, State } from '@clerk/types';

import { errorThrower } from './errors/errorThrower';
import type { IsomorphicClerk } from './isomorphicClerk';

const defaultErrors = (): Errors => ({
fields: {
firstName: null,
lastName: null,
emailAddress: null,
identifier: null,
phoneNumber: null,
password: null,
username: null,
code: null,
captcha: null,
legalAccepted: null,
},
raw: [],
global: [],
});

export class StateProxy implements State {
constructor(private isomorphicClerk: IsomorphicClerk) {}

private readonly signInSignalProxy = this.buildSignInProxy();
private readonly signUpSignalProxy = this.buildSignUpProxy();

signInSignal() {
return this.signInSignalProxy;
}
signUpSignal() {
return this.signUpSignalProxy;
}

private buildSignInProxy() {
const target = () => this.client.signIn.__internal_future;

return {
errors: defaultErrors(),
fetchStatus: 'idle' as const,
signIn: {
status: 'needs_identifier' as const,
availableStrategies: [],

create: this.gateMethod(target, 'create'),
password: this.gateMethod(target, 'password'),
sso: this.gateMethod(target, 'sso'),
finalize: this.gateMethod(target, 'finalize'),

emailCode: this.wrapMethods(() => target().emailCode, ['sendCode', 'verifyCode'] as const),
resetPasswordEmailCode: this.wrapMethods(() => target().resetPasswordEmailCode, [
'sendCode',
'verifyCode',
'submitPassword',
] as const),
},
};
}

private buildSignUpProxy() {
const target = () => this.client.signUp.__internal_future;

return {
errors: defaultErrors(),
fetchStatus: 'idle' as const,
signUp: {
status: 'missing_requirements' as const,
unverifiedFields: [],

password: this.gateMethod(target, 'password'),
finalize: this.gateMethod(target, 'finalize'),

verifications: this.wrapMethods(() => target().verifications, ['sendEmailCode', 'verifyEmailCode'] as const),
},
};
}

__internal_effect(_: () => void): () => void {
throw new Error('__internal_effect called before Clerk is loaded');
}
__internal_computed<T>(_: (prev?: T) => T): () => T {
throw new Error('__internal_computed called before Clerk is loaded');
}

private get client() {
const c = this.isomorphicClerk.client;
if (!c) throw new Error('Clerk client not ready');
return c;
}

private gateMethod<T extends object, K extends keyof T & string>(getTarget: () => T, key: K) {
type F = Extract<T[K], (...args: unknown[]) => unknown>;
return (async (...args: Parameters<F>): Promise<ReturnType<F>> => {
if (!inBrowser()) {
return errorThrower.throw(`Attempted to call a method (${key}) that is not supported on the server.`);
}
if (!this.isomorphicClerk.loaded) {
await new Promise<void>(resolve => this.isomorphicClerk.addOnLoaded(resolve));
}
const t = getTarget();
return (t[key] as (...args: Parameters<F>) => ReturnType<F>).apply(t, args);
}) as F;
}

private wrapMethods<T extends object, K extends readonly (keyof T & string)[]>(
getTarget: () => T,
keys: K,
): Pick<T, K[number]> {
return Object.fromEntries(keys.map(k => [k, this.gateMethod(getTarget, k)])) as Pick<T, K[number]>;
}
}
2 changes: 1 addition & 1 deletion packages/types/src/clerk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -235,7 +235,7 @@
* Entrypoint for Clerk's Signal API containing resource signals along with accessible versions of `computed()` and
* `effect()` that can be used to subscribe to changes from Signals.
*/
__internal_state: State | undefined;
__internal_state: State;

/**
* @experimental This is an experimental API for the Billing feature that is available under a public beta, and the API is subject to change.
Expand DownExpand Up@@ -1140,7 +1140,7 @@
/**
* @internal
*/
__internal_metadata?: RouterMetadata;

Check warning on line 1143 in packages/types/src/clerk.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

'unknown' overrides all other types in this union type
/**
* Provide a function to be used for navigation.
*/
Expand Down
7 changes: 6 additions & 1 deletion packages/types/src/signIn.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -124,6 +124,11 @@ export interface SignInResource extends ClerkResource {
* @internal
*/
__internal_toSnapshot: () => SignInJSONSnapshot;

/**
* @internal
*/
__internal_future: SignInFutureResource;
}

export interface SignInFutureResource {
Expand DownExpand Up@@ -151,7 +156,7 @@ export interface SignInFutureResource {
redirectUrl: string;
redirectUrlComplete: string;
}) => Promise<{ error: unknown }>;
finalize: (params: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;
finalize: (params?: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

}

export type SignInStatus =
Expand Down
7 changes: 6 additions & 1 deletion packages/types/src/signUp.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -117,6 +117,11 @@ export interface SignUpResource extends ClerkResource {
authenticateWithCoinbaseWallet: (params?: SignUpAuthenticateWithWeb3Params) => Promise<SignUpResource>;
authenticateWithOKXWallet: (params?: SignUpAuthenticateWithWeb3Params) => Promise<SignUpResource>;
__internal_toSnapshot: () => SignUpJSONSnapshot;

/**
* @internal
*/
__internal_future: SignUpFutureResource;
}

export interface SignUpFutureResource {
Expand All@@ -127,7 +132,7 @@ export interface SignUpFutureResource {
verifyEmailCode: (params: { code: string }) => Promise<{ error: unknown }>;
};
password: (params: { emailAddress: string; password: string }) => Promise<{ error: unknown }>;
finalize: (params: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;
finalize: (params?: { navigate?: SetActiveNavigate }) => Promise<{ error: unknown }>;
}

export type SignUpStatus = 'missing_requirements' | 'complete' | 'abandoned';
Expand Down
Loading