Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 470
chore(repo): Hide @experimental from typedoc rendering#6651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
845b750347a4884d6561b0d3c98ca627eb8b03787902d730dc4b7cf0d8c5dc26b7da9fdef7a200c3d485dea5e8e4171b93a07e9b06ff75efdc69c34a87f384a65289da82e8806dc4f193c104a05abfef476769f0b36edf5File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| --- | ||
| '@clerk/clerk-js': patch | ||
| '@clerk/backend': patch | ||
| '@clerk/shared': patch | ||
| '@clerk/clerk-react': patch | ||
| '@clerk/types': patch | ||
| '@clerk/clerk-expo': patch | ||
| --- | ||
| Update jsdocs mentions of `@experimental` tag. |
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -218,13 +218,19 @@ class ClerkMarkdownThemeContext extends MarkdownThemeContext { | ||||||||||||||||||||||||||||||||||||
| const customizedModel = model; | ||||||||||||||||||||||||||||||||||||
| customizedModel.typeParameters = undefined; | ||||||||||||||||||||||||||||||||||||
| // Extract the Accessors group (if any) and prevent default rendering for it | ||||||||||||||||||||||||||||||||||||
| const originalGroups = customizedModel.groups; | ||||||||||||||||||||||||||||||||||||
| const accessorsGroup = originalGroups?.find(g => g.title === 'Accessors'); | ||||||||||||||||||||||||||||||||||||
| const groupsWithoutAccessors = originalGroups?.filter(g => g.title !== 'Accessors'); | ||||||||||||||||||||||||||||||||||||
| // When an interface extends another interface, typedoc will generate a "Methods" group | ||||||||||||||||||||||||||||||||||||
| // We want to hide this group from being rendered | ||||||||||||||||||||||||||||||||||||
| const groupsWithoutMethods = originalGroups?.filter(g => g.title !== 'Methods'); | ||||||||||||||||||||||||||||||||||||
| // Extract the Accessors group (if any) and prevent default rendering for it | ||||||||||||||||||||||||||||||||||||
| const accessorsGroup = groupsWithoutMethods?.find(g => g.title === 'Accessors'); | ||||||||||||||||||||||||||||||||||||
| const groupsWithoutAccessors = groupsWithoutMethods?.filter(g => g.title !== 'Accessors'); | ||||||||||||||||||||||||||||||||||||
Comment on lines
+223
to
+229
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainHiding every “Methods” group is too broad; restrict to interfaces (extends case). As written, you’ll also remove legitimate methods from classes. Limit the filter to interface pages only. - const groupsWithoutMethods = originalGroups?.filter(g => g.title !== 'Methods');+ const isInterface = customizedModel?.kind === ReflectionKind.Interface;+ const groupsWithoutMethods = isInterface+ ? originalGroups?.filter(g => g.title !== 'Methods')+ : originalGroups;Build a sample class with methods in the docs to confirm the Methods section remains visible. 🏁 Script executed: #!/bin/bash# Locate ReflectionKind usage and import in custom-theme.mjs
grep -R "ReflectionKind" -n .typedoc/custom-theme.mjs ||true# Locate where customizedModel is defined or passed in
grep -R "customizedModel" -n .typedoc/custom-theme.mjs ||trueLength of output: 1133 Restrict “Methods” filtering to interfaces only - const groupsWithoutMethods = originalGroups?.filter(g => g.title !== 'Methods');+ const isInterface = customizedModel.kind === ReflectionKind.Interface;+ const groupsWithoutMethods = isInterface+ ? originalGroups.filter(g => g.title !== 'Methods')+ : originalGroups;[matches .typedoc/custom-theme.mjs:243] 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents | ||||||||||||||||||||||||||||||||||||
| customizedModel.groups = groupsWithoutAccessors; | ||||||||||||||||||||||||||||||||||||
| const nonAccessorOutput = superPartials.memberWithGroups(customizedModel, options); | ||||||||||||||||||||||||||||||||||||
| customizedModel.groups = originalGroups; | ||||||||||||||||||||||||||||||||||||
| /** @type {string[]} */ | ||||||||||||||||||||||||||||||||||||
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.