Uh oh!
There was an error while loading. Please reload this page.
fix(clerk-js): Ensure Base & Coinbase dependencies aren't bundled for non-RHC environments - #6742
Conversation
🦋 Changeset detectedLatest commit: 0d7a724 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughAdds a changeset and updates build config to externalize/ignore Coinbase/Base deps when RHC is disabled or in certain prod builds; also adds new searches for Coinbase/Base in the RHC scanning script. Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant Build as Rspack Build
participant Ignore as IgnorePlugin
participant Search as search-for-rhc.mjs
participant Output as Build Output Scanner
rect #E8F5E9
Dev->>Build: trigger build (disableRHC = true / prod)
Build->>Ignore: register IgnorePlugin for @coinbase/wallet-sdk & @base-org/account
Build->>Output: produce bundle (Coinbase/Base excluded)
end
rect #FFF3E0
Dev->>Search: run search-for-rhc
Search->>Output: scan for "coinbase.com"
Search->>Output: scan for import regex "@coinbase/wallet-sdk"
Search->>Output: scan for import regex "@base-org/account"
Output-->>Search: results
Search->>Dev: report findings (errors aggregated)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Pre-merge checks (3 passed)✅ Passed checks (3 passed)
Poem
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
✨ Finishing Touches
🧪 Generate unit tests
Comment |
@clerk/agent-toolkit@clerk/astro@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/dev-cli@clerk/elements@clerk/clerk-expo@clerk/expo-passkeys@clerk/express@clerk/fastify@clerk/localizations@clerk/nextjs@clerk/nuxt@clerk/clerk-react@clerk/react-router@clerk/remix@clerk/shared@clerk/tanstack-react-start@clerk/testing@clerk/themes@clerk/types@clerk/upgrade@clerk/vuecommit: |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/clerk-js/rspack.config.js (1)
621-625: Fix undefined variant key in dev config
Inpackages/clerk-js/rspack.config.js(lines 621–625), replace the nonexistentvariants.clerkBrowserNoRHCwith the definedvariants.clerkNoRHCto avoid undefined keys in dev builds:- [variants.clerkBrowserNoRHC]: merge(- entryForVariant(variants.clerkBrowserNoRHC),- common({ mode, disableRHC: true, variant: variants.clerkBrowserNoRHC }),+ [variants.clerkNoRHC]: merge(+ entryForVariant(variants.clerkNoRHC),+ common({ mode, disableRHC: true, variant: variants.clerkNoRHC }), commonForDev(), ),
🧹 Nitpick comments (2)
.changeset/funny-laws-fetch.md (1)
1-5: Changeset looks good; add ticket reference for traceability.Consider appending "Refs USER-4320" (or the appropriate tracker key) to the summary line so it’s linked in release notes.
-Ensure Coinbase dependencies aren't bundled for non-RHC environments+Ensure Coinbase dependencies aren't bundled for non-RHC environments (refs USER-4320)packages/clerk-js/rspack.config.js (1)
80-84: Update the comment to reflect Coinbase too.Stripe is mentioned but Coinbase is now treated similarly; keep comments in sync.
- * Remove the Stripe dependencies from the bundle, if RHC is disabled.- * Necessary to prevent the Stripe dependencies from being bundled into+ * Remove Stripe and Coinbase dependencies from the bundle when RHC is disabled.+ * Necessary to prevent these payment dependencies from being bundled into
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
.changeset/funny-laws-fetch.md(1 hunks)packages/clerk-js/rspack.config.js(2 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
.changeset/**
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Automated releases must use Changesets.
Files:
.changeset/funny-laws-fetch.md
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
**/*.{js,jsx,ts,tsx}: All code must pass ESLint checks with the project's configuration
Follow established naming conventions (PascalCase for components, camelCase for variables)
Maintain comprehensive JSDoc comments for public APIs
Use dynamic imports for optional features
All public APIs must be documented with JSDoc
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Profile and optimize critical paths
Validate all inputs and sanitize outputs
Implement proper logging with different levels
Files:
packages/clerk-js/rspack.config.js
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use Prettier for consistent code formatting
Files:
packages/clerk-js/rspack.config.js
**/*.{js,ts,tsx,jsx}
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Support multiple Clerk environment variables (CLERK_, NEXT_PUBLIC_CLERK_, etc.) for configuration.
Files:
packages/clerk-js/rspack.config.js
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Formatting | Dedupe | Changeset
- GitHub Check: Build Packages
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: semgrep/ci
🔇 Additional comments (1)
packages/clerk-js/rspack.config.js (1)
85-85: Switch externals to regex patterns for deep imports
Current string externals only match package roots. To ensure no@coinbase/wallet-sdk(or Stripe) subpaths slip through, use regex:externals: disableRHC ? [ - '@stripe/stripe-js',- '@stripe/react-stripe-js',- '@coinbase/wallet-sdk',+ /^@stripe\/stripe-js(?:\/.*)?$/,+ /^@stripe\/react-stripe-js(?:\/.*)?$/,+ /^@coinbase\/wallet-sdk(?:\/.*)?$/, ] : undefined,Scan the repo (and any downstream consumers) for
@coinbase/wallet-sdk/imports to confirm no deep paths remain.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
scripts/search-for-rhc.mjs (1)
16-18: Directory search isn’t recursive; grep will miss matches.Add -r so --include filters apply and directories are traversed.
- ? $`grep -${flag}q --include=\\*.js --include=\\*.mjs ${search} ${target}`+ ? $`grep -r -${flag}q --include=\\*.js --include=\\*.mjs ${search} ${target}`
♻️ Duplicate comments (1)
packages/clerk-js/rspack.config.js (1)
484-489: Broaden IgnorePlugin to catch deep imports (matches prior feedback).Mirror externals by allowing optional subpaths so “@…/foo/bar” is ignored too.
new rspack.IgnorePlugin({ - resourceRegExp: /^@coinbase\/wallet-sdk$/,+ resourceRegExp: /^@coinbase\/wallet-sdk(?:\/.*)?$/, }), new rspack.IgnorePlugin({ - resourceRegExp: /^@base-org\/account$/,+ resourceRegExp: /^@base-org\/account(?:\/.*)?$/, }),
🧹 Nitpick comments (2)
scripts/search-for-rhc.mjs (1)
31-31: Consider scanning wallet subdomains too.Add wallet.coinbase.com (and optionally walletlink) to reduce false negatives.
asyncSearchRHC('Coinbase', 'coinbase.com'), + asyncSearchRHC('Coinbase Wallet domain', 'wallet.coinbase.com'),+ // (optional legacy) asyncSearchRHC('WalletLink', 'walletlink.org'),packages/clerk-js/rspack.config.js (1)
479-490: DRY: centralize RHC module patterns and reuse for externals + IgnorePlugin.Define a single array of RegExp patterns (e.g., RHC_MODULES) and reference it in both places to avoid drift.
Example:
// top-levelconstRHC_MODULES=[/^@stripe\/stripe-js(?:\/.*)?$/,/^@stripe\/react-stripe-js(?:\/.*)?$/,/^@coinbase\/wallet-sdk(?:\/.*)?$/,/^@base-org\/account(?:\/.*)?$/,];// usage externals: disableRHC ? RHC_MODULES : undefined// ... plugins: [ ...RHC_MODULES.map(rx=>newrspack.IgnorePlugin({resourceRegExp: rx})), ... ]
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
.changeset/funny-laws-fetch.md(1 hunks)packages/clerk-js/rspack.config.js(2 hunks)scripts/search-for-rhc.mjs(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- .changeset/funny-laws-fetch.md
🧰 Additional context used
📓 Path-based instructions (5)
scripts/**
📄 CodeRabbit inference engine (.cursor/rules/global.mdc)
Build automation and utility scripts should be placed under the scripts/ directory
Files:
scripts/search-for-rhc.mjs
scripts/**/*
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Build and automation scripts must be located in the 'scripts/' directory.
Files:
scripts/search-for-rhc.mjs
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
**/*.{js,jsx,ts,tsx}: All code must pass ESLint checks with the project's configuration
Follow established naming conventions (PascalCase for components, camelCase for variables)
Maintain comprehensive JSDoc comments for public APIs
Use dynamic imports for optional features
All public APIs must be documented with JSDoc
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Profile and optimize critical paths
Validate all inputs and sanitize outputs
Implement proper logging with different levels
Files:
packages/clerk-js/rspack.config.js
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use Prettier for consistent code formatting
Files:
packages/clerk-js/rspack.config.js
**/*.{js,ts,tsx,jsx}
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Support multiple Clerk environment variables (CLERK_, NEXT_PUBLIC_CLERK_, etc.) for configuration.
Files:
packages/clerk-js/rspack.config.js
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Build Packages
- GitHub Check: Formatting | Dedupe | Changeset
- GitHub Check: semgrep/ci
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: Analyze (javascript-typescript)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Description
Ensures Base & Coinbase Wallet dependencies aren't bundled for non-RHC environments.
Note: Base now includes CB Wallet.
USER-4320
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
Bug Fixes
Chores