fix(clerk-js): Reduce unnecessary re-renders on CheckoutComplete#6765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
panteliselef merged 1 commit into from
Sep 14, 2025
Merged

fix(clerk-js): Reduce unnecessary re-renders on CheckoutComplete #6765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tangy-snails-poke.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Performance improvements for `<Checkout />`.
279 changes: 146 additions & 133 deletions packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,25 +14,160 @@ import { useRouter } from '../../router';
const capitalize = (name: string) => name[0].toUpperCase() + name.slice(1);
const lerp = (start: number, end: number, amt: number) => start + (end - start) * amt;

const SuccessRing = ({ positionX, positionY }: { positionX: number; positionY: number }) => {
const animationRef = useRef<number | null>(null);
const [currentPosition, setCurrentPosition] = useState({ x: 256, y: 256 });

const canHover =
typeof window === 'undefined' ? true : window.matchMedia('(hover: hover) and (pointer: fine)').matches;

useEffect(() => {
if (!canHover) {
return;
}
Comment on lines +21 to +27

@coderabbitaicoderabbitaiBotSep 12, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Honor reduced-motion and gate the animation accordingly.

SuccessRing ignores prefers-reduced-motion and still runs rAF. Gate both the effect and highlight.

Apply this diff:

@@
- const canHover =- typeof window === 'undefined' ? true : window.matchMedia('(hover: hover) and (pointer: fine)').matches;+ const canHover =+ typeof window === 'undefined' ? false : window.matchMedia('(hover: hover) and (pointer: fine)').matches;+ const prefersReducedMotion = usePrefersReducedMotion();+ const isMotionSafe = !prefersReducedMotion;
@@
- useEffect(() => {- if (!canHover) {+ useEffect(() => {+ if (!canHover || !isMotionSafe) {
return;
}
@@
- }, [positionX, positionY, canHover]);+ }, [positionX, positionY, canHover, isMotionSafe]);
@@
- {canHover && (+ {canHover && isMotionSafe && (

Also applies to: 24-44, 143-153

🤖 Prompt for AI Agents
In packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx around
lines 21-27 (and similarly for ranges 24-44 and 143-153), the component
currently checks only for hover capability but ignores the user's
prefers-reduced-motion setting; update the logic to also detect
prefers-reduced-motion via window.matchMedia('(prefers-reduced-motion:
reduce)').matches and gate both the useEffect that runs requestAnimationFrame
and any highlight/animation rendering by returning early when
prefersReducedMotion is true (i.e., treat either !canHover or
prefersReducedMotion as reasons to skip the effect), and ensure any
highlight/animated class or element is not applied/rendered when reduced motion
is requested.

const animate = () => {
setCurrentPosition(prev => {
const amt = 0.15;
const x = lerp(prev.x, positionX, amt);
const y = lerp(prev.y, positionY, amt);
return { x, y };
});
animationRef.current = requestAnimationFrame(animate);
};
animationRef.current = requestAnimationFrame(animate);
Comment on lines +28 to +37

@coderabbitaicoderabbitaiBotSep 12, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Stop the rAF loop when the target is reached to avoid perpetual re-renders.

The loop runs forever even when the point stabilizes. Add an epsilon and stop scheduling.

Apply this diff:

- const animate = () => {- setCurrentPosition(prev => {- const amt = 0.15;- const x = lerp(prev.x, positionX, amt);- const y = lerp(prev.y, positionY, amt);- return { x, y };- });- animationRef.current = requestAnimationFrame(animate);- };+ const animate = () => {+ let continueAnim = false;+ setCurrentPosition(prev => {+ const amt = 0.15;+ const x = lerp(prev.x, positionX, amt);+ const y = lerp(prev.y, positionY, amt);+ continueAnim = Math.hypot(x - prev.x, y - prev.y) > 0.5;+ return { x, y };+ });+ if (continueAnim) {+ animationRef.current = requestAnimationFrame(animate);+ } else {+ animationRef.current = null;+ }+ };

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents
In packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx around
lines 28–37, the requestAnimationFrame loop never stops once the point
stabilizes; add a small epsilon threshold (e.g., 0.5 pixels or a small
squared-distance) to detect when lerp has effectively reached the target, and
stop scheduling further frames by calling
cancelAnimationFrame(animationRef.current) and clearing animationRef.current
when within that threshold; only call requestAnimationFrame(animate) if the
distance is above epsilon, and ensure any existing animation is cancelled before
starting a new loop.

return () => {
if (animationRef.current) {
cancelAnimationFrame(animationRef.current);
}
};
}, [positionX, positionY, canHover]);

// Generate unique IDs for SVG elements to avoid conflicts with multiple component instances
const maskId1 = useId();
const maskId2 = useId();
const maskId3 = useId();

Comment on lines +45 to +49

@coderabbitaicoderabbitaiBotSep 12, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Make all SVG IDs unique to prevent collisions when multiple instances render.

Static IDs for the radialGradient, filter, and mask can collide. Generate unique IDs and update references.

Apply this diff:

@@
- // Generate unique IDs for SVG elements to avoid conflicts with multiple component instances- const maskId1 = useId();- const maskId2 = useId();- const maskId3 = useId();+ // Generate unique IDs per instance to avoid <defs> collisions+ const maskId1 = useId();+ const maskId2 = useId();+ const maskId3 = useId();+ const uid = useId();+ const mainMaskId = `clerk-checkout-success-mask-${uid}`;+ const radialGradientId = `clerk-checkout-success-gradient-${uid}`;+ const blurFilterId = `clerk-checkout-success-blur-effect-${uid}`;
@@
- <radialGradient id='clerk-checkout-success-gradient'>+ <radialGradient id={radialGradientId}>
@@
- <filter id='clerk-checkout-success-blur-effect'>+ <filter id={blurFilterId}>
@@
- <mask id='clerk-checkout-success-mask'>+ <mask id={mainMaskId}>
@@
- <g mask='url(#clerk-checkout-success-mask)'>+ <g mask={`url(#${mainMaskId})`}>
@@
- fill='url(#clerk-checkout-success-gradient)'- filter='url(#clerk-checkout-success-blur-effect)'+ fill={`url(#${radialGradientId})`}+ filter={`url(#${blurFilterId})`}

Also applies to: 64-82, 117-117, 135-135, 150-151

🤖 Prompt for AI Agents
In packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx around
lines 45-49, 64-82, 117, 135, and 150-151, the SVG IDs (for radialGradient,
filter, mask, etc.) are currently static and can collide across multiple
component instances; replace each static ID with a unique ID generated via useId
(or similar) at the top of the component and update every SVG attribute
reference (id, href/xlink:href, mask, filter, clipPath, etc.) to use those
generated IDs so each instance uses distinct identifiers and avoids collisions.

return (
<Box
elementDescriptor={descriptors.checkoutSuccessRings}
as='svg'
// @ts-ignore - viewBox is a valid prop for svg
viewBox='0 0 512 512'
sx={{
position: 'absolute',
inset: 0,
pointerEvents: 'none',
}}
aria-hidden
>
<defs>
<radialGradient id='clerk-checkout-success-gradient'>
<stop
offset='0%'
style={{
stopColor: 'var(--ring-highlight)',
}}
/>
<stop
offset='100%'
stopOpacity='0'
style={{
stopColor: 'var(--ring-highlight)',
}}
/>
</radialGradient>
<filter id='clerk-checkout-success-blur-effect'>
<feGaussianBlur stdDeviation='10' />
</filter>
{[
{ r: 225, maskStart: 10, maskEnd: 90, id: maskId1 },
{ r: 162.5, maskStart: 15, maskEnd: 85, id: maskId2 },
{ r: 100, maskStart: 20, maskEnd: 80, id: maskId3 },
].map(({ maskStart, maskEnd, id }) => (
<linearGradient
key={id}
id={`gradient-${id}`}
x1='0%'
y1='0%'
x2='0%'
y2='100%'
>
<stop
offset={`${maskStart + 5}%`}
stopColor='white'
stopOpacity='0'
/>
<stop
offset={`${maskStart + 35}%`}
stopColor='white'
stopOpacity='1'
/>
<stop
offset={`${maskEnd - 35}%`}
stopColor='white'
stopOpacity='1'
/>
<stop
offset={`${maskEnd - 5}%`}
stopColor='white'
stopOpacity='0'
/>
</linearGradient>
))}
<mask id='clerk-checkout-success-mask'>
{[
{ r: 225, id: maskId1 },
{ r: 162.5, id: maskId2 },
{ r: 100, id: maskId3 },
].map(({ r, id }) => (
<circle
key={id}
cx='256'
cy='256'
r={r}
stroke={`url(#gradient-${id})`}
fill='none'
strokeWidth='1'
/>
))}
</mask>
</defs>
<g mask='url(#clerk-checkout-success-mask)'>
<rect
width='512'
height='512'
style={{
fill: 'var(--ring-fill)',
}}
/>
{canHover && (
<rect
id='movingGradientHighlight'
width='256'
height='256'
x={currentPosition.x - 128}
y={currentPosition.y - 128}
fill='url(#clerk-checkout-success-gradient)'
filter='url(#clerk-checkout-success-blur-effect)'
/>
)}
</g>
</Box>
);
};

export const CheckoutComplete = () => {
const router = useRouter();
const { setIsOpen } = useDrawerContext();
const { newSubscriptionRedirectUrl } = useCheckoutContext();
const { checkout } = useCheckout();
const { totals, paymentSource, planPeriodStart, freeTrialEndsAt } = checkout;
const [mousePosition, setMousePosition] = useState({ x: 256, y: 256 });
const [currentPosition, setCurrentPosition] = useState({ x: 256, y: 256 });

// Generate unique IDs for SVG elements to avoid conflicts with multiple component instances
const maskId1 = useId();
const maskId2 = useId();
const maskId3 = useId();

const prefersReducedMotion = usePrefersReducedMotion();
const { animations: layoutAnimations } = useAppearance().parsedLayout;
const isMotionSafe = !prefersReducedMotion && layoutAnimations === true;

const animationRef = useRef<number | null>(null);
const checkoutSuccessRootRef = useRef<HTMLSpanElement>(null);
const canHover =
typeof window === 'undefined' ? true : window.matchMedia('(hover: hover) and (pointer: fine)').matches;
Expand All@@ -59,27 +194,6 @@ export const CheckoutComplete = () => {
}
};

useEffect(() => {
if (!canHover) {
return;
}
const animate = () => {
setCurrentPosition(prev => {
const amt = 0.15;
const x = lerp(prev.x, mousePosition.x, amt);
const y = lerp(prev.y, mousePosition.y, amt);
return { x, y };
});
animationRef.current = requestAnimationFrame(animate);
};
animationRef.current = requestAnimationFrame(animate);
return () => {
if (animationRef.current) {
cancelAnimationFrame(animationRef.current);
}
};
}, [mousePosition, canHover]);

const handleClose = () => {
if (newSubscriptionRedirectUrl) {
void router.navigate(newSubscriptionRedirectUrl);
Expand DownExpand Up@@ -135,111 +249,10 @@ export const CheckoutComplete = () => {
ref={checkoutSuccessRootRef}
onMouseMove={handleMouseMove}
>
<Box
elementDescriptor={descriptors.checkoutSuccessRings}
as='svg'
// @ts-ignore - viewBox is a valid prop for svg
viewBox='0 0 512 512'
sx={{
position: 'absolute',
inset: 0,
pointerEvents: 'none',
}}
aria-hidden
>
<defs>
<radialGradient id='clerk-checkout-success-gradient'>
<stop
offset='0%'
style={{
stopColor: 'var(--ring-highlight)',
}}
/>
<stop
offset='100%'
stopOpacity='0'
style={{
stopColor: 'var(--ring-highlight)',
}}
/>
</radialGradient>
<filter id='clerk-checkout-success-blur-effect'>
<feGaussianBlur stdDeviation='10' />
</filter>
{[
{ r: 225, maskStart: 10, maskEnd: 90, id: maskId1 },
{ r: 162.5, maskStart: 15, maskEnd: 85, id: maskId2 },
{ r: 100, maskStart: 20, maskEnd: 80, id: maskId3 },
].map(({ maskStart, maskEnd, id }) => (
<linearGradient
key={id}
id={`gradient-${id}`}
x1='0%'
y1='0%'
x2='0%'
y2='100%'
>
<stop
offset={`${maskStart + 5}%`}
stopColor='white'
stopOpacity='0'
/>
<stop
offset={`${maskStart + 35}%`}
stopColor='white'
stopOpacity='1'
/>
<stop
offset={`${maskEnd - 35}%`}
stopColor='white'
stopOpacity='1'
/>
<stop
offset={`${maskEnd - 5}%`}
stopColor='white'
stopOpacity='0'
/>
</linearGradient>
))}
<mask id='clerk-checkout-success-mask'>
{[
{ r: 225, id: maskId1 },
{ r: 162.5, id: maskId2 },
{ r: 100, id: maskId3 },
].map(({ r, id }) => (
<circle
key={id}
cx='256'
cy='256'
r={r}
stroke={`url(#gradient-${id})`}
fill='none'
strokeWidth='1'
/>
))}
</mask>
</defs>
<g mask='url(#clerk-checkout-success-mask)'>
<rect
width='512'
height='512'
style={{
fill: 'var(--ring-fill)',
}}
/>
{canHover && (
<rect
id='movingGradientHighlight'
width='256'
height='256'
x={currentPosition.x - 128}
y={currentPosition.y - 128}
fill='url(#clerk-checkout-success-gradient)'
filter='url(#clerk-checkout-success-blur-effect)'
/>
)}
</g>
</Box>
<SuccessRing
positionX={mousePosition.x}
positionY={mousePosition.y}
/>
<Box
elementDescriptor={descriptors.checkoutSuccessBadge}
sx={t => ({
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix(clerk-js): Reduce unnecessary re-renders on CheckoutComplete#6765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

panteliselef
merged 1 commit into

from

Sep 14, 2025
 Merged


fix(clerk-js): Reduce unnecessary re-renders on CheckoutComplete
#6765
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/tangy-snails-poke.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Performance improvements for `<Checkout />`.

279 changes: 146 additions & 133 deletions
packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,25 +14,160 @@ import { useRouter } from '../../router';
const capitalize = (name: string) => name[0].toUpperCase() + name.slice(1);
const lerp = (start: number, end: number, amt: number) => start + (end - start) * amt;

const SuccessRing = ({ positionX, positionY }: { positionX: number; positionY: number }) => {
 const animationRef = useRef<number | null>(null);
 const [currentPosition, setCurrentPosition] = useState({ x: 256, y: 256 });

 const canHover =
 typeof window === 'undefined' ? true : window.matchMedia('(hover: hover) and (pointer: fine)').matches;

 useEffect(() => {
 if (!canHover) {
 return;
 }

Comment on lines

+21
 to 
+27

@coderabbitaicoderabbitaiBotSep 12, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion
Honor reduced-motion and gate the animation accordingly.
SuccessRing ignores prefers-reduced-motion and still runs rAF. Gate both the effect and highlight.
Apply this diff:
@@
- const canHover =- typeof window === 'undefined' ? true : window.matchMedia('(hover: hover) and (pointer: fine)').matches;+ const canHover =+ typeof window === 'undefined' ? false : window.matchMedia('(hover: hover) and (pointer: fine)').matches;+ const prefersReducedMotion = usePrefersReducedMotion();+ const isMotionSafe = !prefersReducedMotion;
@@
- useEffect(() => {- if (!canHover) {+ useEffect(() => {+ if (!canHover || !isMotionSafe) {
return;
}
@@
- }, [positionX, positionY, canHover]);+ }, [positionX, positionY, canHover, isMotionSafe]);
@@
- {canHover && (+ {canHover && isMotionSafe && (
Also applies to: 24-44, 143-153
🤖 Prompt for AI Agents
In packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx around
lines 21-27 (and similarly for ranges 24-44 and 143-153), the component
currently checks only for hover capability but ignores the user's
prefers-reduced-motion setting; update the logic to also detect
prefers-reduced-motion via window.matchMedia('(prefers-reduced-motion:
reduce)').matches and gate both the useEffect that runs requestAnimationFrame
and any highlight/animation rendering by returning early when
prefersReducedMotion is true (i.e., treat either !canHover or
prefersReducedMotion as reasons to skip the effect), and ensure any
highlight/animated class or element is not applied/rendered when reduced motion
is requested.

 const animate = () => {
 setCurrentPosition(prev => {
 const amt = 0.15;
 const x = lerp(prev.x, positionX, amt);
 const y = lerp(prev.y, positionY, amt);
 return { x, y };
 });
 animationRef.current = requestAnimationFrame(animate);
 };
 animationRef.current = requestAnimationFrame(animate);

Comment on lines

+28
 to 
+37

@coderabbitaicoderabbitaiBotSep 12, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion
Stop the rAF loop when the target is reached to avoid perpetual re-renders.
The loop runs forever even when the point stabilizes. Add an epsilon and stop scheduling.
Apply this diff:
- const animate = () => {- setCurrentPosition(prev => {- const amt = 0.15;- const x = lerp(prev.x, positionX, amt);- const y = lerp(prev.y, positionY, amt);- return { x, y };- });- animationRef.current = requestAnimationFrame(animate);- };+ const animate = () => {+ let continueAnim = false;+ setCurrentPosition(prev => {+ const amt = 0.15;+ const x = lerp(prev.x, positionX, amt);+ const y = lerp(prev.y, positionY, amt);+ continueAnim = Math.hypot(x - prev.x, y - prev.y) > 0.5;+ return { x, y };+ });+ if (continueAnim) {+ animationRef.current = requestAnimationFrame(animate);+ } else {+ animationRef.current = null;+ }+ };
Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx around
lines 28–37, the requestAnimationFrame loop never stops once the point
stabilizes; add a small epsilon threshold (e.g., 0.5 pixels or a small
squared-distance) to detect when lerp has effectively reached the target, and
stop scheduling further frames by calling
cancelAnimationFrame(animationRef.current) and clearing animationRef.current
when within that threshold; only call requestAnimationFrame(animate) if the
distance is above epsilon, and ensure any existing animation is cancelled before
starting a new loop.

 return () => {
 if (animationRef.current) {
 cancelAnimationFrame(animationRef.current);
 }
 };
 }, [positionX, positionY, canHover]);

 // Generate unique IDs for SVG elements to avoid conflicts with multiple component instances
 const maskId1 = useId();
 const maskId2 = useId();
 const maskId3 = useId();


Comment on lines

+45
 to 
+49

@coderabbitaicoderabbitaiBotSep 12, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue
Make all SVG IDs unique to prevent collisions when multiple instances render.
Static IDs for the radialGradient, filter, and mask can collide. Generate unique IDs and update references.
Apply this diff:
@@
- // Generate unique IDs for SVG elements to avoid conflicts with multiple component instances- const maskId1 = useId();- const maskId2 = useId();- const maskId3 = useId();+ // Generate unique IDs per instance to avoid <defs> collisions+ const maskId1 = useId();+ const maskId2 = useId();+ const maskId3 = useId();+ const uid = useId();+ const mainMaskId = `clerk-checkout-success-mask-${uid}`;+ const radialGradientId = `clerk-checkout-success-gradient-${uid}`;+ const blurFilterId = `clerk-checkout-success-blur-effect-${uid}`;
@@
- <radialGradient id='clerk-checkout-success-gradient'>+ <radialGradient id={radialGradientId}>
@@
- <filter id='clerk-checkout-success-blur-effect'>+ <filter id={blurFilterId}>
@@
- <mask id='clerk-checkout-success-mask'>+ <mask id={mainMaskId}>
@@
- <g mask='url(#clerk-checkout-success-mask)'>+ <g mask={`url(#${mainMaskId})`}>
@@
- fill='url(#clerk-checkout-success-gradient)'- filter='url(#clerk-checkout-success-blur-effect)'+ fill={`url(#${radialGradientId})`}+ filter={`url(#${blurFilterId})`}
Also applies to: 64-82, 117-117, 135-135, 150-151
🤖 Prompt for AI Agents
In packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx around
lines 45-49, 64-82, 117, 135, and 150-151, the SVG IDs (for radialGradient,
filter, mask, etc.) are currently static and can collide across multiple
component instances; replace each static ID with a unique ID generated via useId
(or similar) at the top of the component and update every SVG attribute
reference (id, href/xlink:href, mask, filter, clipPath, etc.) to use those
generated IDs so each instance uses distinct identifiers and avoids collisions.

 return (
 <Box
 elementDescriptor={descriptors.checkoutSuccessRings}
 as='svg'
 // @ts-ignore - viewBox is a valid prop for svg
 viewBox='0 0 512 512'
 sx={{
 position: 'absolute',
 inset: 0,
 pointerEvents: 'none',
 }}
 aria-hidden
 >
 <defs>
 <radialGradient id='clerk-checkout-success-gradient'>
 <stop
 offset='0%'
 style={{
 stopColor: 'var(--ring-highlight)',
 }}
 />
 <stop
 offset='100%'
 stopOpacity='0'
 style={{
 stopColor: 'var(--ring-highlight)',
 }}
 />
 </radialGradient>
 <filter id='clerk-checkout-success-blur-effect'>
 <feGaussianBlur stdDeviation='10' />
 </filter>
 {[
 { r: 225, maskStart: 10, maskEnd: 90, id: maskId1 },
 { r: 162.5, maskStart: 15, maskEnd: 85, id: maskId2 },
 { r: 100, maskStart: 20, maskEnd: 80, id: maskId3 },
 ].map(({ maskStart, maskEnd, id }) => (
 <linearGradient
 key={id}
 id={`gradient-${id}`}
 x1='0%'
 y1='0%'
 x2='0%'
 y2='100%'
 >
 <stop
 offset={`${maskStart + 5}%`}
 stopColor='white'
 stopOpacity='0'
 />
 <stop
 offset={`${maskStart + 35}%`}
 stopColor='white'
 stopOpacity='1'
 />
 <stop
 offset={`${maskEnd - 35}%`}
 stopColor='white'
 stopOpacity='1'
 />
 <stop
 offset={`${maskEnd - 5}%`}
 stopColor='white'
 stopOpacity='0'
 />
 </linearGradient>
 ))}
 <mask id='clerk-checkout-success-mask'>
 {[
 { r: 225, id: maskId1 },
 { r: 162.5, id: maskId2 },
 { r: 100, id: maskId3 },
 ].map(({ r, id }) => (
 <circle
 key={id}
 cx='256'
 cy='256'
 r={r}
 stroke={`url(#gradient-${id})`}
 fill='none'
 strokeWidth='1'
 />
 ))}
 </mask>
 </defs>
 <g mask='url(#clerk-checkout-success-mask)'>
 <rect
 width='512'
 height='512'
 style={{
 fill: 'var(--ring-fill)',
 }}
 />
 {canHover && (
 <rect
 id='movingGradientHighlight'
 width='256'
 height='256'
 x={currentPosition.x - 128}
 y={currentPosition.y - 128}
 fill='url(#clerk-checkout-success-gradient)'
 filter='url(#clerk-checkout-success-blur-effect)'
 />
 )}
 </g>
 </Box>
 );
};

export const CheckoutComplete = () => {
 const router = useRouter();
 const { setIsOpen } = useDrawerContext();
 const { newSubscriptionRedirectUrl } = useCheckoutContext();
 const { checkout } = useCheckout();
 const { totals, paymentSource, planPeriodStart, freeTrialEndsAt } = checkout;
 const [mousePosition, setMousePosition] = useState({ x: 256, y: 256 });
 const [currentPosition, setCurrentPosition] = useState({ x: 256, y: 256 });

 // Generate unique IDs for SVG elements to avoid conflicts with multiple component instances
 const maskId1 = useId();
 const maskId2 = useId();
 const maskId3 = useId();

 const prefersReducedMotion = usePrefersReducedMotion();
 const { animations: layoutAnimations } = useAppearance().parsedLayout;
 const isMotionSafe = !prefersReducedMotion && layoutAnimations === true;

 const animationRef = useRef<number | null>(null);
 const checkoutSuccessRootRef = useRef<HTMLSpanElement>(null);
 const canHover =
 typeof window === 'undefined' ? true : window.matchMedia('(hover: hover) and (pointer: fine)').matches;
Expand All@@ -59,27 +194,6 @@ export const CheckoutComplete = () => {
 }
 };

 useEffect(() => {
 if (!canHover) {
 return;
 }
 const animate = () => {
 setCurrentPosition(prev => {
 const amt = 0.15;
 const x = lerp(prev.x, mousePosition.x, amt);
 const y = lerp(prev.y, mousePosition.y, amt);
 return { x, y };
 });
 animationRef.current = requestAnimationFrame(animate);
 };
 animationRef.current = requestAnimationFrame(animate);
 return () => {
 if (animationRef.current) {
 cancelAnimationFrame(animationRef.current);
 }
 };
 }, [mousePosition, canHover]);

 const handleClose = () => {
 if (newSubscriptionRedirectUrl) {
 void router.navigate(newSubscriptionRedirectUrl);
Expand DownExpand Up@@ -135,111 +249,10 @@ export const CheckoutComplete = () => {
 ref={checkoutSuccessRootRef}
 onMouseMove={handleMouseMove}
 >
 <Box
 elementDescriptor={descriptors.checkoutSuccessRings}
 as='svg'
 // @ts-ignore - viewBox is a valid prop for svg
 viewBox='0 0 512 512'
 sx={{
 position: 'absolute',
 inset: 0,
 pointerEvents: 'none',
 }}
 aria-hidden
 >
 <defs>
 <radialGradient id='clerk-checkout-success-gradient'>
 <stop
 offset='0%'
 style={{
 stopColor: 'var(--ring-highlight)',
 }}
 />
 <stop
 offset='100%'
 stopOpacity='0'
 style={{
 stopColor: 'var(--ring-highlight)',
 }}
 />
 </radialGradient>
 <filter id='clerk-checkout-success-blur-effect'>
 <feGaussianBlur stdDeviation='10' />
 </filter>
 {[
 { r: 225, maskStart: 10, maskEnd: 90, id: maskId1 },
 { r: 162.5, maskStart: 15, maskEnd: 85, id: maskId2 },
 { r: 100, maskStart: 20, maskEnd: 80, id: maskId3 },
 ].map(({ maskStart, maskEnd, id }) => (
 <linearGradient
 key={id}
 id={`gradient-${id}`}
 x1='0%'
 y1='0%'
 x2='0%'
 y2='100%'
 >
 <stop
 offset={`${maskStart + 5}%`}
 stopColor='white'
 stopOpacity='0'
 />
 <stop
 offset={`${maskStart + 35}%`}
 stopColor='white'
 stopOpacity='1'
 />
 <stop
 offset={`${maskEnd - 35}%`}
 stopColor='white'
 stopOpacity='1'
 />
 <stop
 offset={`${maskEnd - 5}%`}
 stopColor='white'
 stopOpacity='0'
 />
 </linearGradient>
 ))}
 <mask id='clerk-checkout-success-mask'>
 {[
 { r: 225, id: maskId1 },
 { r: 162.5, id: maskId2 },
 { r: 100, id: maskId3 },
 ].map(({ r, id }) => (
 <circle
 key={id}
 cx='256'
 cy='256'
 r={r}
 stroke={`url(#gradient-${id})`}
 fill='none'
 strokeWidth='1'
 />
 ))}
 </mask>
 </defs>
 <g mask='url(#clerk-checkout-success-mask)'>
 <rect
 width='512'
 height='512'
 style={{
 fill: 'var(--ring-fill)',
 }}
 />
 {canHover && (
 <rect
 id='movingGradientHighlight'
 width='256'
 height='256'
 x={currentPosition.x - 128}
 y={currentPosition.y - 128}
 fill='url(#clerk-checkout-success-gradient)'
 filter='url(#clerk-checkout-success-blur-effect)'
 />
 )}
 </g>
 </Box>
 <SuccessRing
 positionX={mousePosition.x}
 positionY={mousePosition.y}
 />
 <Box
 elementDescriptor={descriptors.checkoutSuccessBadge}
 sx={t => ({
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(clerk-js): Reduce unnecessary re-renders on CheckoutComplete#6765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

panteliselef
merged 1 commit into

from

Sep 14, 2025
 Merged


fix(clerk-js): Reduce unnecessary re-renders on CheckoutComplete
#6765
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/tangy-snails-poke.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Performance improvements for `<Checkout />`.

279 changes: 146 additions & 133 deletions
packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,25 +14,160 @@ import { useRouter } from '../../router';
const capitalize = (name: string) => name[0].toUpperCase() + name.slice(1);
const lerp = (start: number, end: number, amt: number) => start + (end - start) * amt;

const SuccessRing = ({ positionX, positionY }: { positionX: number; positionY: number }) => {
 const animationRef = useRef<number | null>(null);
 const [currentPosition, setCurrentPosition] = useState({ x: 256, y: 256 });

 const canHover =
 typeof window === 'undefined' ? true : window.matchMedia('(hover: hover) and (pointer: fine)').matches;

 useEffect(() => {
 if (!canHover) {
 return;
 }

Comment on lines

+21
 to 
+27

@coderabbitaicoderabbitaiBotSep 12, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion
Honor reduced-motion and gate the animation accordingly.
SuccessRing ignores prefers-reduced-motion and still runs rAF. Gate both the effect and highlight.
Apply this diff:
@@
- const canHover =- typeof window === 'undefined' ? true : window.matchMedia('(hover: hover) and (pointer: fine)').matches;+ const canHover =+ typeof window === 'undefined' ? false : window.matchMedia('(hover: hover) and (pointer: fine)').matches;+ const prefersReducedMotion = usePrefersReducedMotion();+ const isMotionSafe = !prefersReducedMotion;
@@
- useEffect(() => {- if (!canHover) {+ useEffect(() => {+ if (!canHover || !isMotionSafe) {
return;
}
@@
- }, [positionX, positionY, canHover]);+ }, [positionX, positionY, canHover, isMotionSafe]);
@@
- {canHover && (+ {canHover && isMotionSafe && (
Also applies to: 24-44, 143-153
🤖 Prompt for AI Agents
In packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx around
lines 21-27 (and similarly for ranges 24-44 and 143-153), the component
currently checks only for hover capability but ignores the user's
prefers-reduced-motion setting; update the logic to also detect
prefers-reduced-motion via window.matchMedia('(prefers-reduced-motion:
reduce)').matches and gate both the useEffect that runs requestAnimationFrame
and any highlight/animation rendering by returning early when
prefersReducedMotion is true (i.e., treat either !canHover or
prefersReducedMotion as reasons to skip the effect), and ensure any
highlight/animated class or element is not applied/rendered when reduced motion
is requested.

 const animate = () => {
 setCurrentPosition(prev => {
 const amt = 0.15;
 const x = lerp(prev.x, positionX, amt);
 const y = lerp(prev.y, positionY, amt);
 return { x, y };
 });
 animationRef.current = requestAnimationFrame(animate);
 };
 animationRef.current = requestAnimationFrame(animate);

Comment on lines

+28
 to 
+37

@coderabbitaicoderabbitaiBotSep 12, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion
Stop the rAF loop when the target is reached to avoid perpetual re-renders.
The loop runs forever even when the point stabilizes. Add an epsilon and stop scheduling.
Apply this diff:
- const animate = () => {- setCurrentPosition(prev => {- const amt = 0.15;- const x = lerp(prev.x, positionX, amt);- const y = lerp(prev.y, positionY, amt);- return { x, y };- });- animationRef.current = requestAnimationFrame(animate);- };+ const animate = () => {+ let continueAnim = false;+ setCurrentPosition(prev => {+ const amt = 0.15;+ const x = lerp(prev.x, positionX, amt);+ const y = lerp(prev.y, positionY, amt);+ continueAnim = Math.hypot(x - prev.x, y - prev.y) > 0.5;+ return { x, y };+ });+ if (continueAnim) {+ animationRef.current = requestAnimationFrame(animate);+ } else {+ animationRef.current = null;+ }+ };
Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx around
lines 28–37, the requestAnimationFrame loop never stops once the point
stabilizes; add a small epsilon threshold (e.g., 0.5 pixels or a small
squared-distance) to detect when lerp has effectively reached the target, and
stop scheduling further frames by calling
cancelAnimationFrame(animationRef.current) and clearing animationRef.current
when within that threshold; only call requestAnimationFrame(animate) if the
distance is above epsilon, and ensure any existing animation is cancelled before
starting a new loop.

 return () => {
 if (animationRef.current) {
 cancelAnimationFrame(animationRef.current);
 }
 };
 }, [positionX, positionY, canHover]);

 // Generate unique IDs for SVG elements to avoid conflicts with multiple component instances
 const maskId1 = useId();
 const maskId2 = useId();
 const maskId3 = useId();


Comment on lines

+45
 to 
+49

@coderabbitaicoderabbitaiBotSep 12, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue
Make all SVG IDs unique to prevent collisions when multiple instances render.
Static IDs for the radialGradient, filter, and mask can collide. Generate unique IDs and update references.
Apply this diff:
@@
- // Generate unique IDs for SVG elements to avoid conflicts with multiple component instances- const maskId1 = useId();- const maskId2 = useId();- const maskId3 = useId();+ // Generate unique IDs per instance to avoid <defs> collisions+ const maskId1 = useId();+ const maskId2 = useId();+ const maskId3 = useId();+ const uid = useId();+ const mainMaskId = `clerk-checkout-success-mask-${uid}`;+ const radialGradientId = `clerk-checkout-success-gradient-${uid}`;+ const blurFilterId = `clerk-checkout-success-blur-effect-${uid}`;
@@
- <radialGradient id='clerk-checkout-success-gradient'>+ <radialGradient id={radialGradientId}>
@@
- <filter id='clerk-checkout-success-blur-effect'>+ <filter id={blurFilterId}>
@@
- <mask id='clerk-checkout-success-mask'>+ <mask id={mainMaskId}>
@@
- <g mask='url(#clerk-checkout-success-mask)'>+ <g mask={`url(#${mainMaskId})`}>
@@
- fill='url(#clerk-checkout-success-gradient)'- filter='url(#clerk-checkout-success-blur-effect)'+ fill={`url(#${radialGradientId})`}+ filter={`url(#${blurFilterId})`}
Also applies to: 64-82, 117-117, 135-135, 150-151
🤖 Prompt for AI Agents
In packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx around
lines 45-49, 64-82, 117, 135, and 150-151, the SVG IDs (for radialGradient,
filter, mask, etc.) are currently static and can collide across multiple
component instances; replace each static ID with a unique ID generated via useId
(or similar) at the top of the component and update every SVG attribute
reference (id, href/xlink:href, mask, filter, clipPath, etc.) to use those
generated IDs so each instance uses distinct identifiers and avoids collisions.

 return (
 <Box
 elementDescriptor={descriptors.checkoutSuccessRings}
 as='svg'
 // @ts-ignore - viewBox is a valid prop for svg
 viewBox='0 0 512 512'
 sx={{
 position: 'absolute',
 inset: 0,
 pointerEvents: 'none',
 }}
 aria-hidden
 >
 <defs>
 <radialGradient id='clerk-checkout-success-gradient'>
 <stop
 offset='0%'
 style={{
 stopColor: 'var(--ring-highlight)',
 }}
 />
 <stop
 offset='100%'
 stopOpacity='0'
 style={{
 stopColor: 'var(--ring-highlight)',
 }}
 />
 </radialGradient>
 <filter id='clerk-checkout-success-blur-effect'>
 <feGaussianBlur stdDeviation='10' />
 </filter>
 {[
 { r: 225, maskStart: 10, maskEnd: 90, id: maskId1 },
 { r: 162.5, maskStart: 15, maskEnd: 85, id: maskId2 },
 { r: 100, maskStart: 20, maskEnd: 80, id: maskId3 },
 ].map(({ maskStart, maskEnd, id }) => (
 <linearGradient
 key={id}
 id={`gradient-${id}`}
 x1='0%'
 y1='0%'
 x2='0%'
 y2='100%'
 >
 <stop
 offset={`${maskStart + 5}%`}
 stopColor='white'
 stopOpacity='0'
 />
 <stop
 offset={`${maskStart + 35}%`}
 stopColor='white'
 stopOpacity='1'
 />
 <stop
 offset={`${maskEnd - 35}%`}
 stopColor='white'
 stopOpacity='1'
 />
 <stop
 offset={`${maskEnd - 5}%`}
 stopColor='white'
 stopOpacity='0'
 />
 </linearGradient>
 ))}
 <mask id='clerk-checkout-success-mask'>
 {[
 { r: 225, id: maskId1 },
 { r: 162.5, id: maskId2 },
 { r: 100, id: maskId3 },
 ].map(({ r, id }) => (
 <circle
 key={id}
 cx='256'
 cy='256'
 r={r}
 stroke={`url(#gradient-${id})`}
 fill='none'
 strokeWidth='1'
 />
 ))}
 </mask>
 </defs>
 <g mask='url(#clerk-checkout-success-mask)'>
 <rect
 width='512'
 height='512'
 style={{
 fill: 'var(--ring-fill)',
 }}
 />
 {canHover && (
 <rect
 id='movingGradientHighlight'
 width='256'
 height='256'
 x={currentPosition.x - 128}
 y={currentPosition.y - 128}
 fill='url(#clerk-checkout-success-gradient)'
 filter='url(#clerk-checkout-success-blur-effect)'
 />
 )}
 </g>
 </Box>
 );
};

export const CheckoutComplete = () => {
 const router = useRouter();
 const { setIsOpen } = useDrawerContext();
 const { newSubscriptionRedirectUrl } = useCheckoutContext();
 const { checkout } = useCheckout();
 const { totals, paymentSource, planPeriodStart, freeTrialEndsAt } = checkout;
 const [mousePosition, setMousePosition] = useState({ x: 256, y: 256 });
 const [currentPosition, setCurrentPosition] = useState({ x: 256, y: 256 });

 // Generate unique IDs for SVG elements to avoid conflicts with multiple component instances
 const maskId1 = useId();
 const maskId2 = useId();
 const maskId3 = useId();

 const prefersReducedMotion = usePrefersReducedMotion();
 const { animations: layoutAnimations } = useAppearance().parsedLayout;
 const isMotionSafe = !prefersReducedMotion && layoutAnimations === true;

 const animationRef = useRef<number | null>(null);
 const checkoutSuccessRootRef = useRef<HTMLSpanElement>(null);
 const canHover =
 typeof window === 'undefined' ? true : window.matchMedia('(hover: hover) and (pointer: fine)').matches;
Expand All@@ -59,27 +194,6 @@ export const CheckoutComplete = () => {
 }
 };

 useEffect(() => {
 if (!canHover) {
 return;
 }
 const animate = () => {
 setCurrentPosition(prev => {
 const amt = 0.15;
 const x = lerp(prev.x, mousePosition.x, amt);
 const y = lerp(prev.y, mousePosition.y, amt);
 return { x, y };
 });
 animationRef.current = requestAnimationFrame(animate);
 };
 animationRef.current = requestAnimationFrame(animate);
 return () => {
 if (animationRef.current) {
 cancelAnimationFrame(animationRef.current);
 }
 };
 }, [mousePosition, canHover]);

 const handleClose = () => {
 if (newSubscriptionRedirectUrl) {
 void router.navigate(newSubscriptionRedirectUrl);
Expand DownExpand Up@@ -135,111 +249,10 @@ export const CheckoutComplete = () => {
 ref={checkoutSuccessRootRef}
 onMouseMove={handleMouseMove}
 >
 <Box
 elementDescriptor={descriptors.checkoutSuccessRings}
 as='svg'
 // @ts-ignore - viewBox is a valid prop for svg
 viewBox='0 0 512 512'
 sx={{
 position: 'absolute',
 inset: 0,
 pointerEvents: 'none',
 }}
 aria-hidden
 >
 <defs>
 <radialGradient id='clerk-checkout-success-gradient'>
 <stop
 offset='0%'
 style={{
 stopColor: 'var(--ring-highlight)',
 }}
 />
 <stop
 offset='100%'
 stopOpacity='0'
 style={{
 stopColor: 'var(--ring-highlight)',
 }}
 />
 </radialGradient>
 <filter id='clerk-checkout-success-blur-effect'>
 <feGaussianBlur stdDeviation='10' />
 </filter>
 {[
 { r: 225, maskStart: 10, maskEnd: 90, id: maskId1 },
 { r: 162.5, maskStart: 15, maskEnd: 85, id: maskId2 },
 { r: 100, maskStart: 20, maskEnd: 80, id: maskId3 },
 ].map(({ maskStart, maskEnd, id }) => (
 <linearGradient
 key={id}
 id={`gradient-${id}`}
 x1='0%'
 y1='0%'
 x2='0%'
 y2='100%'
 >
 <stop
 offset={`${maskStart + 5}%`}
 stopColor='white'
 stopOpacity='0'
 />
 <stop
 offset={`${maskStart + 35}%`}
 stopColor='white'
 stopOpacity='1'
 />
 <stop
 offset={`${maskEnd - 35}%`}
 stopColor='white'
 stopOpacity='1'
 />
 <stop
 offset={`${maskEnd - 5}%`}
 stopColor='white'
 stopOpacity='0'
 />
 </linearGradient>
 ))}
 <mask id='clerk-checkout-success-mask'>
 {[
 { r: 225, id: maskId1 },
 { r: 162.5, id: maskId2 },
 { r: 100, id: maskId3 },
 ].map(({ r, id }) => (
 <circle
 key={id}
 cx='256'
 cy='256'
 r={r}
 stroke={`url(#gradient-${id})`}
 fill='none'
 strokeWidth='1'
 />
 ))}
 </mask>
 </defs>
 <g mask='url(#clerk-checkout-success-mask)'>
 <rect
 width='512'
 height='512'
 style={{
 fill: 'var(--ring-fill)',
 }}
 />
 {canHover && (
 <rect
 id='movingGradientHighlight'
 width='256'
 height='256'
 x={currentPosition.x - 128}
 y={currentPosition.y - 128}
 fill='url(#clerk-checkout-success-gradient)'
 filter='url(#clerk-checkout-success-blur-effect)'
 />
 )}
 </g>
 </Box>
 <SuccessRing
 positionX={mousePosition.x}
 positionY={mousePosition.y}
 />
 <Box
 elementDescriptor={descriptors.checkoutSuccessBadge}
 sx={t => ({
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(clerk-js): Reduce unnecessary re-renders on CheckoutComplete#6765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

panteliselef
merged 1 commit into

from

Sep 14, 2025
 Merged


fix(clerk-js): Reduce unnecessary re-renders on CheckoutComplete
#6765
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/tangy-snails-poke.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Performance improvements for `<Checkout />`.

279 changes: 146 additions & 133 deletions
packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,25 +14,160 @@ import { useRouter } from '../../router';
const capitalize = (name: string) => name[0].toUpperCase() + name.slice(1);
const lerp = (start: number, end: number, amt: number) => start + (end - start) * amt;

const SuccessRing = ({ positionX, positionY }: { positionX: number; positionY: number }) => {
 const animationRef = useRef<number | null>(null);
 const [currentPosition, setCurrentPosition] = useState({ x: 256, y: 256 });

 const canHover =
 typeof window === 'undefined' ? true : window.matchMedia('(hover: hover) and (pointer: fine)').matches;

 useEffect(() => {
 if (!canHover) {
 return;
 }

Comment on lines

+21
 to 
+27

@coderabbitaicoderabbitaiBotSep 12, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion
Honor reduced-motion and gate the animation accordingly.
SuccessRing ignores prefers-reduced-motion and still runs rAF. Gate both the effect and highlight.
Apply this diff:
@@
- const canHover =- typeof window === 'undefined' ? true : window.matchMedia('(hover: hover) and (pointer: fine)').matches;+ const canHover =+ typeof window === 'undefined' ? false : window.matchMedia('(hover: hover) and (pointer: fine)').matches;+ const prefersReducedMotion = usePrefersReducedMotion();+ const isMotionSafe = !prefersReducedMotion;
@@
- useEffect(() => {- if (!canHover) {+ useEffect(() => {+ if (!canHover || !isMotionSafe) {
return;
}
@@
- }, [positionX, positionY, canHover]);+ }, [positionX, positionY, canHover, isMotionSafe]);
@@
- {canHover && (+ {canHover && isMotionSafe && (
Also applies to: 24-44, 143-153
🤖 Prompt for AI Agents
In packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx around
lines 21-27 (and similarly for ranges 24-44 and 143-153), the component
currently checks only for hover capability but ignores the user's
prefers-reduced-motion setting; update the logic to also detect
prefers-reduced-motion via window.matchMedia('(prefers-reduced-motion:
reduce)').matches and gate both the useEffect that runs requestAnimationFrame
and any highlight/animation rendering by returning early when
prefersReducedMotion is true (i.e., treat either !canHover or
prefersReducedMotion as reasons to skip the effect), and ensure any
highlight/animated class or element is not applied/rendered when reduced motion
is requested.

 const animate = () => {
 setCurrentPosition(prev => {
 const amt = 0.15;
 const x = lerp(prev.x, positionX, amt);
 const y = lerp(prev.y, positionY, amt);
 return { x, y };
 });
 animationRef.current = requestAnimationFrame(animate);
 };
 animationRef.current = requestAnimationFrame(animate);

Comment on lines

+28
 to 
+37

@coderabbitaicoderabbitaiBotSep 12, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion
Stop the rAF loop when the target is reached to avoid perpetual re-renders.
The loop runs forever even when the point stabilizes. Add an epsilon and stop scheduling.
Apply this diff:
- const animate = () => {- setCurrentPosition(prev => {- const amt = 0.15;- const x = lerp(prev.x, positionX, amt);- const y = lerp(prev.y, positionY, amt);- return { x, y };- });- animationRef.current = requestAnimationFrame(animate);- };+ const animate = () => {+ let continueAnim = false;+ setCurrentPosition(prev => {+ const amt = 0.15;+ const x = lerp(prev.x, positionX, amt);+ const y = lerp(prev.y, positionY, amt);+ continueAnim = Math.hypot(x - prev.x, y - prev.y) > 0.5;+ return { x, y };+ });+ if (continueAnim) {+ animationRef.current = requestAnimationFrame(animate);+ } else {+ animationRef.current = null;+ }+ };
Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx around
lines 28–37, the requestAnimationFrame loop never stops once the point
stabilizes; add a small epsilon threshold (e.g., 0.5 pixels or a small
squared-distance) to detect when lerp has effectively reached the target, and
stop scheduling further frames by calling
cancelAnimationFrame(animationRef.current) and clearing animationRef.current
when within that threshold; only call requestAnimationFrame(animate) if the
distance is above epsilon, and ensure any existing animation is cancelled before
starting a new loop.

 return () => {
 if (animationRef.current) {
 cancelAnimationFrame(animationRef.current);
 }
 };
 }, [positionX, positionY, canHover]);

 // Generate unique IDs for SVG elements to avoid conflicts with multiple component instances
 const maskId1 = useId();
 const maskId2 = useId();
 const maskId3 = useId();


Comment on lines

+45
 to 
+49

@coderabbitaicoderabbitaiBotSep 12, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue
Make all SVG IDs unique to prevent collisions when multiple instances render.
Static IDs for the radialGradient, filter, and mask can collide. Generate unique IDs and update references.
Apply this diff:
@@
- // Generate unique IDs for SVG elements to avoid conflicts with multiple component instances- const maskId1 = useId();- const maskId2 = useId();- const maskId3 = useId();+ // Generate unique IDs per instance to avoid <defs> collisions+ const maskId1 = useId();+ const maskId2 = useId();+ const maskId3 = useId();+ const uid = useId();+ const mainMaskId = `clerk-checkout-success-mask-${uid}`;+ const radialGradientId = `clerk-checkout-success-gradient-${uid}`;+ const blurFilterId = `clerk-checkout-success-blur-effect-${uid}`;
@@
- <radialGradient id='clerk-checkout-success-gradient'>+ <radialGradient id={radialGradientId}>
@@
- <filter id='clerk-checkout-success-blur-effect'>+ <filter id={blurFilterId}>
@@
- <mask id='clerk-checkout-success-mask'>+ <mask id={mainMaskId}>
@@
- <g mask='url(#clerk-checkout-success-mask)'>+ <g mask={`url(#${mainMaskId})`}>
@@
- fill='url(#clerk-checkout-success-gradient)'- filter='url(#clerk-checkout-success-blur-effect)'+ fill={`url(#${radialGradientId})`}+ filter={`url(#${blurFilterId})`}
Also applies to: 64-82, 117-117, 135-135, 150-151
🤖 Prompt for AI Agents
In packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx around
lines 45-49, 64-82, 117, 135, and 150-151, the SVG IDs (for radialGradient,
filter, mask, etc.) are currently static and can collide across multiple
component instances; replace each static ID with a unique ID generated via useId
(or similar) at the top of the component and update every SVG attribute
reference (id, href/xlink:href, mask, filter, clipPath, etc.) to use those
generated IDs so each instance uses distinct identifiers and avoids collisions.

 return (
 <Box
 elementDescriptor={descriptors.checkoutSuccessRings}
 as='svg'
 // @ts-ignore - viewBox is a valid prop for svg
 viewBox='0 0 512 512'
 sx={{
 position: 'absolute',
 inset: 0,
 pointerEvents: 'none',
 }}
 aria-hidden
 >
 <defs>
 <radialGradient id='clerk-checkout-success-gradient'>
 <stop
 offset='0%'
 style={{
 stopColor: 'var(--ring-highlight)',
 }}
 />
 <stop
 offset='100%'
 stopOpacity='0'
 style={{
 stopColor: 'var(--ring-highlight)',
 }}
 />
 </radialGradient>
 <filter id='clerk-checkout-success-blur-effect'>
 <feGaussianBlur stdDeviation='10' />
 </filter>
 {[
 { r: 225, maskStart: 10, maskEnd: 90, id: maskId1 },
 { r: 162.5, maskStart: 15, maskEnd: 85, id: maskId2 },
 { r: 100, maskStart: 20, maskEnd: 80, id: maskId3 },
 ].map(({ maskStart, maskEnd, id }) => (
 <linearGradient
 key={id}
 id={`gradient-${id}`}
 x1='0%'
 y1='0%'
 x2='0%'
 y2='100%'
 >
 <stop
 offset={`${maskStart + 5}%`}
 stopColor='white'
 stopOpacity='0'
 />
 <stop
 offset={`${maskStart + 35}%`}
 stopColor='white'
 stopOpacity='1'
 />
 <stop
 offset={`${maskEnd - 35}%`}
 stopColor='white'
 stopOpacity='1'
 />
 <stop
 offset={`${maskEnd - 5}%`}
 stopColor='white'
 stopOpacity='0'
 />
 </linearGradient>
 ))}
 <mask id='clerk-checkout-success-mask'>
 {[
 { r: 225, id: maskId1 },
 { r: 162.5, id: maskId2 },
 { r: 100, id: maskId3 },
 ].map(({ r, id }) => (
 <circle
 key={id}
 cx='256'
 cy='256'
 r={r}
 stroke={`url(#gradient-${id})`}
 fill='none'
 strokeWidth='1'
 />
 ))}
 </mask>
 </defs>
 <g mask='url(#clerk-checkout-success-mask)'>
 <rect
 width='512'
 height='512'
 style={{
 fill: 'var(--ring-fill)',
 }}
 />
 {canHover && (
 <rect
 id='movingGradientHighlight'
 width='256'
 height='256'
 x={currentPosition.x - 128}
 y={currentPosition.y - 128}
 fill='url(#clerk-checkout-success-gradient)'
 filter='url(#clerk-checkout-success-blur-effect)'
 />
 )}
 </g>
 </Box>
 );
};

export const CheckoutComplete = () => {
 const router = useRouter();
 const { setIsOpen } = useDrawerContext();
 const { newSubscriptionRedirectUrl } = useCheckoutContext();
 const { checkout } = useCheckout();
 const { totals, paymentSource, planPeriodStart, freeTrialEndsAt } = checkout;
 const [mousePosition, setMousePosition] = useState({ x: 256, y: 256 });
 const [currentPosition, setCurrentPosition] = useState({ x: 256, y: 256 });

 // Generate unique IDs for SVG elements to avoid conflicts with multiple component instances
 const maskId1 = useId();
 const maskId2 = useId();
 const maskId3 = useId();

 const prefersReducedMotion = usePrefersReducedMotion();
 const { animations: layoutAnimations } = useAppearance().parsedLayout;
 const isMotionSafe = !prefersReducedMotion && layoutAnimations === true;

 const animationRef = useRef<number | null>(null);
 const checkoutSuccessRootRef = useRef<HTMLSpanElement>(null);
 const canHover =
 typeof window === 'undefined' ? true : window.matchMedia('(hover: hover) and (pointer: fine)').matches;
Expand All@@ -59,27 +194,6 @@ export const CheckoutComplete = () => {
 }
 };

 useEffect(() => {
 if (!canHover) {
 return;
 }
 const animate = () => {
 setCurrentPosition(prev => {
 const amt = 0.15;
 const x = lerp(prev.x, mousePosition.x, amt);
 const y = lerp(prev.y, mousePosition.y, amt);
 return { x, y };
 });
 animationRef.current = requestAnimationFrame(animate);
 };
 animationRef.current = requestAnimationFrame(animate);
 return () => {
 if (animationRef.current) {
 cancelAnimationFrame(animationRef.current);
 }
 };
 }, [mousePosition, canHover]);

 const handleClose = () => {
 if (newSubscriptionRedirectUrl) {
 void router.navigate(newSubscriptionRedirectUrl);
Expand DownExpand Up@@ -135,111 +249,10 @@ export const CheckoutComplete = () => {
 ref={checkoutSuccessRootRef}
 onMouseMove={handleMouseMove}
 >
 <Box
 elementDescriptor={descriptors.checkoutSuccessRings}
 as='svg'
 // @ts-ignore - viewBox is a valid prop for svg
 viewBox='0 0 512 512'
 sx={{
 position: 'absolute',
 inset: 0,
 pointerEvents: 'none',
 }}
 aria-hidden
 >
 <defs>
 <radialGradient id='clerk-checkout-success-gradient'>
 <stop
 offset='0%'
 style={{
 stopColor: 'var(--ring-highlight)',
 }}
 />
 <stop
 offset='100%'
 stopOpacity='0'
 style={{
 stopColor: 'var(--ring-highlight)',
 }}
 />
 </radialGradient>
 <filter id='clerk-checkout-success-blur-effect'>
 <feGaussianBlur stdDeviation='10' />
 </filter>
 {[
 { r: 225, maskStart: 10, maskEnd: 90, id: maskId1 },
 { r: 162.5, maskStart: 15, maskEnd: 85, id: maskId2 },
 { r: 100, maskStart: 20, maskEnd: 80, id: maskId3 },
 ].map(({ maskStart, maskEnd, id }) => (
 <linearGradient
 key={id}
 id={`gradient-${id}`}
 x1='0%'
 y1='0%'
 x2='0%'
 y2='100%'
 >
 <stop
 offset={`${maskStart + 5}%`}
 stopColor='white'
 stopOpacity='0'
 />
 <stop
 offset={`${maskStart + 35}%`}
 stopColor='white'
 stopOpacity='1'
 />
 <stop
 offset={`${maskEnd - 35}%`}
 stopColor='white'
 stopOpacity='1'
 />
 <stop
 offset={`${maskEnd - 5}%`}
 stopColor='white'
 stopOpacity='0'
 />
 </linearGradient>
 ))}
 <mask id='clerk-checkout-success-mask'>
 {[
 { r: 225, id: maskId1 },
 { r: 162.5, id: maskId2 },
 { r: 100, id: maskId3 },
 ].map(({ r, id }) => (
 <circle
 key={id}
 cx='256'
 cy='256'
 r={r}
 stroke={`url(#gradient-${id})`}
 fill='none'
 strokeWidth='1'
 />
 ))}
 </mask>
 </defs>
 <g mask='url(#clerk-checkout-success-mask)'>
 <rect
 width='512'
 height='512'
 style={{
 fill: 'var(--ring-fill)',
 }}
 />
 {canHover && (
 <rect
 id='movingGradientHighlight'
 width='256'
 height='256'
 x={currentPosition.x - 128}
 y={currentPosition.y - 128}
 fill='url(#clerk-checkout-success-gradient)'
 filter='url(#clerk-checkout-success-blur-effect)'
 />
 )}
 </g>
 </Box>
 <SuccessRing
 positionX={mousePosition.x}
 positionY={mousePosition.y}
 />
 <Box
 elementDescriptor={descriptors.checkoutSuccessBadge}
 sx={t => ({
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix(clerk-js): Reduce unnecessary re-renders on CheckoutComplete#6765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

panteliselef
merged 1 commit into

from

Sep 14, 2025
 Merged


fix(clerk-js): Reduce unnecessary re-renders on CheckoutComplete
#6765
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/tangy-snails-poke.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Performance improvements for `<Checkout />`.

279 changes: 146 additions & 133 deletions
packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,25 +14,160 @@ import { useRouter } from '../../router';
const capitalize = (name: string) => name[0].toUpperCase() + name.slice(1);
const lerp = (start: number, end: number, amt: number) => start + (end - start) * amt;

const SuccessRing = ({ positionX, positionY }: { positionX: number; positionY: number }) => {
 const animationRef = useRef<number | null>(null);
 const [currentPosition, setCurrentPosition] = useState({ x: 256, y: 256 });

 const canHover =
 typeof window === 'undefined' ? true : window.matchMedia('(hover: hover) and (pointer: fine)').matches;

 useEffect(() => {
 if (!canHover) {
 return;
 }

Comment on lines

+21
 to 
+27

@coderabbitaicoderabbitaiBotSep 12, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion
Honor reduced-motion and gate the animation accordingly.
SuccessRing ignores prefers-reduced-motion and still runs rAF. Gate both the effect and highlight.
Apply this diff:
@@
- const canHover =- typeof window === 'undefined' ? true : window.matchMedia('(hover: hover) and (pointer: fine)').matches;+ const canHover =+ typeof window === 'undefined' ? false : window.matchMedia('(hover: hover) and (pointer: fine)').matches;+ const prefersReducedMotion = usePrefersReducedMotion();+ const isMotionSafe = !prefersReducedMotion;
@@
- useEffect(() => {- if (!canHover) {+ useEffect(() => {+ if (!canHover || !isMotionSafe) {
return;
}
@@
- }, [positionX, positionY, canHover]);+ }, [positionX, positionY, canHover, isMotionSafe]);
@@
- {canHover && (+ {canHover && isMotionSafe && (
Also applies to: 24-44, 143-153
🤖 Prompt for AI Agents
In packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx around
lines 21-27 (and similarly for ranges 24-44 and 143-153), the component
currently checks only for hover capability but ignores the user's
prefers-reduced-motion setting; update the logic to also detect
prefers-reduced-motion via window.matchMedia('(prefers-reduced-motion:
reduce)').matches and gate both the useEffect that runs requestAnimationFrame
and any highlight/animation rendering by returning early when
prefersReducedMotion is true (i.e., treat either !canHover or
prefersReducedMotion as reasons to skip the effect), and ensure any
highlight/animated class or element is not applied/rendered when reduced motion
is requested.

 const animate = () => {
 setCurrentPosition(prev => {
 const amt = 0.15;
 const x = lerp(prev.x, positionX, amt);
 const y = lerp(prev.y, positionY, amt);
 return { x, y };
 });
 animationRef.current = requestAnimationFrame(animate);
 };
 animationRef.current = requestAnimationFrame(animate);

Comment on lines

+28
 to 
+37

@coderabbitaicoderabbitaiBotSep 12, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion
Stop the rAF loop when the target is reached to avoid perpetual re-renders.
The loop runs forever even when the point stabilizes. Add an epsilon and stop scheduling.
Apply this diff:
- const animate = () => {- setCurrentPosition(prev => {- const amt = 0.15;- const x = lerp(prev.x, positionX, amt);- const y = lerp(prev.y, positionY, amt);- return { x, y };- });- animationRef.current = requestAnimationFrame(animate);- };+ const animate = () => {+ let continueAnim = false;+ setCurrentPosition(prev => {+ const amt = 0.15;+ const x = lerp(prev.x, positionX, amt);+ const y = lerp(prev.y, positionY, amt);+ continueAnim = Math.hypot(x - prev.x, y - prev.y) > 0.5;+ return { x, y };+ });+ if (continueAnim) {+ animationRef.current = requestAnimationFrame(animate);+ } else {+ animationRef.current = null;+ }+ };
Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx around
lines 28–37, the requestAnimationFrame loop never stops once the point
stabilizes; add a small epsilon threshold (e.g., 0.5 pixels or a small
squared-distance) to detect when lerp has effectively reached the target, and
stop scheduling further frames by calling
cancelAnimationFrame(animationRef.current) and clearing animationRef.current
when within that threshold; only call requestAnimationFrame(animate) if the
distance is above epsilon, and ensure any existing animation is cancelled before
starting a new loop.

 return () => {
 if (animationRef.current) {
 cancelAnimationFrame(animationRef.current);
 }
 };
 }, [positionX, positionY, canHover]);

 // Generate unique IDs for SVG elements to avoid conflicts with multiple component instances
 const maskId1 = useId();
 const maskId2 = useId();
 const maskId3 = useId();


Comment on lines

+45
 to 
+49

@coderabbitaicoderabbitaiBotSep 12, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue
Make all SVG IDs unique to prevent collisions when multiple instances render.
Static IDs for the radialGradient, filter, and mask can collide. Generate unique IDs and update references.
Apply this diff:
@@
- // Generate unique IDs for SVG elements to avoid conflicts with multiple component instances- const maskId1 = useId();- const maskId2 = useId();- const maskId3 = useId();+ // Generate unique IDs per instance to avoid <defs> collisions+ const maskId1 = useId();+ const maskId2 = useId();+ const maskId3 = useId();+ const uid = useId();+ const mainMaskId = `clerk-checkout-success-mask-${uid}`;+ const radialGradientId = `clerk-checkout-success-gradient-${uid}`;+ const blurFilterId = `clerk-checkout-success-blur-effect-${uid}`;
@@
- <radialGradient id='clerk-checkout-success-gradient'>+ <radialGradient id={radialGradientId}>
@@
- <filter id='clerk-checkout-success-blur-effect'>+ <filter id={blurFilterId}>
@@
- <mask id='clerk-checkout-success-mask'>+ <mask id={mainMaskId}>
@@
- <g mask='url(#clerk-checkout-success-mask)'>+ <g mask={`url(#${mainMaskId})`}>
@@
- fill='url(#clerk-checkout-success-gradient)'- filter='url(#clerk-checkout-success-blur-effect)'+ fill={`url(#${radialGradientId})`}+ filter={`url(#${blurFilterId})`}
Also applies to: 64-82, 117-117, 135-135, 150-151
🤖 Prompt for AI Agents
In packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx around
lines 45-49, 64-82, 117, 135, and 150-151, the SVG IDs (for radialGradient,
filter, mask, etc.) are currently static and can collide across multiple
component instances; replace each static ID with a unique ID generated via useId
(or similar) at the top of the component and update every SVG attribute
reference (id, href/xlink:href, mask, filter, clipPath, etc.) to use those
generated IDs so each instance uses distinct identifiers and avoids collisions.

 return (
 <Box
 elementDescriptor={descriptors.checkoutSuccessRings}
 as='svg'
 // @ts-ignore - viewBox is a valid prop for svg
 viewBox='0 0 512 512'
 sx={{
 position: 'absolute',
 inset: 0,
 pointerEvents: 'none',
 }}
 aria-hidden
 >
 <defs>
 <radialGradient id='clerk-checkout-success-gradient'>
 <stop
 offset='0%'
 style={{
 stopColor: 'var(--ring-highlight)',
 }}
 />
 <stop
 offset='100%'
 stopOpacity='0'
 style={{
 stopColor: 'var(--ring-highlight)',
 }}
 />
 </radialGradient>
 <filter id='clerk-checkout-success-blur-effect'>
 <feGaussianBlur stdDeviation='10' />
 </filter>
 {[
 { r: 225, maskStart: 10, maskEnd: 90, id: maskId1 },
 { r: 162.5, maskStart: 15, maskEnd: 85, id: maskId2 },
 { r: 100, maskStart: 20, maskEnd: 80, id: maskId3 },
 ].map(({ maskStart, maskEnd, id }) => (
 <linearGradient
 key={id}
 id={`gradient-${id}`}
 x1='0%'
 y1='0%'
 x2='0%'
 y2='100%'
 >
 <stop
 offset={`${maskStart + 5}%`}
 stopColor='white'
 stopOpacity='0'
 />
 <stop
 offset={`${maskStart + 35}%`}
 stopColor='white'
 stopOpacity='1'
 />
 <stop
 offset={`${maskEnd - 35}%`}
 stopColor='white'
 stopOpacity='1'
 />
 <stop
 offset={`${maskEnd - 5}%`}
 stopColor='white'
 stopOpacity='0'
 />
 </linearGradient>
 ))}
 <mask id='clerk-checkout-success-mask'>
 {[
 { r: 225, id: maskId1 },
 { r: 162.5, id: maskId2 },
 { r: 100, id: maskId3 },
 ].map(({ r, id }) => (
 <circle
 key={id}
 cx='256'
 cy='256'
 r={r}
 stroke={`url(#gradient-${id})`}
 fill='none'
 strokeWidth='1'
 />
 ))}
 </mask>
 </defs>
 <g mask='url(#clerk-checkout-success-mask)'>
 <rect
 width='512'
 height='512'
 style={{
 fill: 'var(--ring-fill)',
 }}
 />
 {canHover && (
 <rect
 id='movingGradientHighlight'
 width='256'
 height='256'
 x={currentPosition.x - 128}
 y={currentPosition.y - 128}
 fill='url(#clerk-checkout-success-gradient)'
 filter='url(#clerk-checkout-success-blur-effect)'
 />
 )}
 </g>
 </Box>
 );
};

export const CheckoutComplete = () => {
 const router = useRouter();
 const { setIsOpen } = useDrawerContext();
 const { newSubscriptionRedirectUrl } = useCheckoutContext();
 const { checkout } = useCheckout();
 const { totals, paymentSource, planPeriodStart, freeTrialEndsAt } = checkout;
 const [mousePosition, setMousePosition] = useState({ x: 256, y: 256 });
 const [currentPosition, setCurrentPosition] = useState({ x: 256, y: 256 });

 // Generate unique IDs for SVG elements to avoid conflicts with multiple component instances
 const maskId1 = useId();
 const maskId2 = useId();
 const maskId3 = useId();

 const prefersReducedMotion = usePrefersReducedMotion();
 const { animations: layoutAnimations } = useAppearance().parsedLayout;
 const isMotionSafe = !prefersReducedMotion && layoutAnimations === true;

 const animationRef = useRef<number | null>(null);
 const checkoutSuccessRootRef = useRef<HTMLSpanElement>(null);
 const canHover =
 typeof window === 'undefined' ? true : window.matchMedia('(hover: hover) and (pointer: fine)').matches;
Expand All@@ -59,27 +194,6 @@ export const CheckoutComplete = () => {
 }
 };

 useEffect(() => {
 if (!canHover) {
 return;
 }
 const animate = () => {
 setCurrentPosition(prev => {
 const amt = 0.15;
 const x = lerp(prev.x, mousePosition.x, amt);
 const y = lerp(prev.y, mousePosition.y, amt);
 return { x, y };
 });
 animationRef.current = requestAnimationFrame(animate);
 };
 animationRef.current = requestAnimationFrame(animate);
 return () => {
 if (animationRef.current) {
 cancelAnimationFrame(animationRef.current);
 }
 };
 }, [mousePosition, canHover]);

 const handleClose = () => {
 if (newSubscriptionRedirectUrl) {
 void router.navigate(newSubscriptionRedirectUrl);
Expand DownExpand Up@@ -135,111 +249,10 @@ export const CheckoutComplete = () => {
 ref={checkoutSuccessRootRef}
 onMouseMove={handleMouseMove}
 >
 <Box
 elementDescriptor={descriptors.checkoutSuccessRings}
 as='svg'
 // @ts-ignore - viewBox is a valid prop for svg
 viewBox='0 0 512 512'
 sx={{
 position: 'absolute',
 inset: 0,
 pointerEvents: 'none',
 }}
 aria-hidden
 >
 <defs>
 <radialGradient id='clerk-checkout-success-gradient'>
 <stop
 offset='0%'
 style={{
 stopColor: 'var(--ring-highlight)',
 }}
 />
 <stop
 offset='100%'
 stopOpacity='0'
 style={{
 stopColor: 'var(--ring-highlight)',
 }}
 />
 </radialGradient>
 <filter id='clerk-checkout-success-blur-effect'>
 <feGaussianBlur stdDeviation='10' />
 </filter>
 {[
 { r: 225, maskStart: 10, maskEnd: 90, id: maskId1 },
 { r: 162.5, maskStart: 15, maskEnd: 85, id: maskId2 },
 { r: 100, maskStart: 20, maskEnd: 80, id: maskId3 },
 ].map(({ maskStart, maskEnd, id }) => (
 <linearGradient
 key={id}
 id={`gradient-${id}`}
 x1='0%'
 y1='0%'
 x2='0%'
 y2='100%'
 >
 <stop
 offset={`${maskStart + 5}%`}
 stopColor='white'
 stopOpacity='0'
 />
 <stop
 offset={`${maskStart + 35}%`}
 stopColor='white'
 stopOpacity='1'
 />
 <stop
 offset={`${maskEnd - 35}%`}
 stopColor='white'
 stopOpacity='1'
 />
 <stop
 offset={`${maskEnd - 5}%`}
 stopColor='white'
 stopOpacity='0'
 />
 </linearGradient>
 ))}
 <mask id='clerk-checkout-success-mask'>
 {[
 { r: 225, id: maskId1 },
 { r: 162.5, id: maskId2 },
 { r: 100, id: maskId3 },
 ].map(({ r, id }) => (
 <circle
 key={id}
 cx='256'
 cy='256'
 r={r}
 stroke={`url(#gradient-${id})`}
 fill='none'
 strokeWidth='1'
 />
 ))}
 </mask>
 </defs>
 <g mask='url(#clerk-checkout-success-mask)'>
 <rect
 width='512'
 height='512'
 style={{
 fill: 'var(--ring-fill)',
 }}
 />
 {canHover && (
 <rect
 id='movingGradientHighlight'
 width='256'
 height='256'
 x={currentPosition.x - 128}
 y={currentPosition.y - 128}
 fill='url(#clerk-checkout-success-gradient)'
 filter='url(#clerk-checkout-success-blur-effect)'
 />
 )}
 </g>
 </Box>
 <SuccessRing
 positionX={mousePosition.x}
 positionY={mousePosition.y}
 />
 <Box
 elementDescriptor={descriptors.checkoutSuccessBadge}
 sx={t => ({
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(clerk-js): Reduce unnecessary re-renders on CheckoutComplete#6765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

panteliselef
merged 1 commit into

from

Sep 14, 2025
 Merged


fix(clerk-js): Reduce unnecessary re-renders on CheckoutComplete
#6765
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/tangy-snails-poke.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Performance improvements for `<Checkout />`.

279 changes: 146 additions & 133 deletions
packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,25 +14,160 @@ import { useRouter } from '../../router';
const capitalize = (name: string) => name[0].toUpperCase() + name.slice(1);
const lerp = (start: number, end: number, amt: number) => start + (end - start) * amt;

const SuccessRing = ({ positionX, positionY }: { positionX: number; positionY: number }) => {
 const animationRef = useRef<number | null>(null);
 const [currentPosition, setCurrentPosition] = useState({ x: 256, y: 256 });

 const canHover =
 typeof window === 'undefined' ? true : window.matchMedia('(hover: hover) and (pointer: fine)').matches;

 useEffect(() => {
 if (!canHover) {
 return;
 }

Comment on lines

+21
 to 
+27

@coderabbitaicoderabbitaiBotSep 12, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion
Honor reduced-motion and gate the animation accordingly.
SuccessRing ignores prefers-reduced-motion and still runs rAF. Gate both the effect and highlight.
Apply this diff:
@@
- const canHover =- typeof window === 'undefined' ? true : window.matchMedia('(hover: hover) and (pointer: fine)').matches;+ const canHover =+ typeof window === 'undefined' ? false : window.matchMedia('(hover: hover) and (pointer: fine)').matches;+ const prefersReducedMotion = usePrefersReducedMotion();+ const isMotionSafe = !prefersReducedMotion;
@@
- useEffect(() => {- if (!canHover) {+ useEffect(() => {+ if (!canHover || !isMotionSafe) {
return;
}
@@
- }, [positionX, positionY, canHover]);+ }, [positionX, positionY, canHover, isMotionSafe]);
@@
- {canHover && (+ {canHover && isMotionSafe && (
Also applies to: 24-44, 143-153
🤖 Prompt for AI Agents
In packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx around
lines 21-27 (and similarly for ranges 24-44 and 143-153), the component
currently checks only for hover capability but ignores the user's
prefers-reduced-motion setting; update the logic to also detect
prefers-reduced-motion via window.matchMedia('(prefers-reduced-motion:
reduce)').matches and gate both the useEffect that runs requestAnimationFrame
and any highlight/animation rendering by returning early when
prefersReducedMotion is true (i.e., treat either !canHover or
prefersReducedMotion as reasons to skip the effect), and ensure any
highlight/animated class or element is not applied/rendered when reduced motion
is requested.

 const animate = () => {
 setCurrentPosition(prev => {
 const amt = 0.15;
 const x = lerp(prev.x, positionX, amt);
 const y = lerp(prev.y, positionY, amt);
 return { x, y };
 });
 animationRef.current = requestAnimationFrame(animate);
 };
 animationRef.current = requestAnimationFrame(animate);

Comment on lines

+28
 to 
+37

@coderabbitaicoderabbitaiBotSep 12, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion
Stop the rAF loop when the target is reached to avoid perpetual re-renders.
The loop runs forever even when the point stabilizes. Add an epsilon and stop scheduling.
Apply this diff:
- const animate = () => {- setCurrentPosition(prev => {- const amt = 0.15;- const x = lerp(prev.x, positionX, amt);- const y = lerp(prev.y, positionY, amt);- return { x, y };- });- animationRef.current = requestAnimationFrame(animate);- };+ const animate = () => {+ let continueAnim = false;+ setCurrentPosition(prev => {+ const amt = 0.15;+ const x = lerp(prev.x, positionX, amt);+ const y = lerp(prev.y, positionY, amt);+ continueAnim = Math.hypot(x - prev.x, y - prev.y) > 0.5;+ return { x, y };+ });+ if (continueAnim) {+ animationRef.current = requestAnimationFrame(animate);+ } else {+ animationRef.current = null;+ }+ };
Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx around
lines 28–37, the requestAnimationFrame loop never stops once the point
stabilizes; add a small epsilon threshold (e.g., 0.5 pixels or a small
squared-distance) to detect when lerp has effectively reached the target, and
stop scheduling further frames by calling
cancelAnimationFrame(animationRef.current) and clearing animationRef.current
when within that threshold; only call requestAnimationFrame(animate) if the
distance is above epsilon, and ensure any existing animation is cancelled before
starting a new loop.

 return () => {
 if (animationRef.current) {
 cancelAnimationFrame(animationRef.current);
 }
 };
 }, [positionX, positionY, canHover]);

 // Generate unique IDs for SVG elements to avoid conflicts with multiple component instances
 const maskId1 = useId();
 const maskId2 = useId();
 const maskId3 = useId();


Comment on lines

+45
 to 
+49

@coderabbitaicoderabbitaiBotSep 12, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue
Make all SVG IDs unique to prevent collisions when multiple instances render.
Static IDs for the radialGradient, filter, and mask can collide. Generate unique IDs and update references.
Apply this diff:
@@
- // Generate unique IDs for SVG elements to avoid conflicts with multiple component instances- const maskId1 = useId();- const maskId2 = useId();- const maskId3 = useId();+ // Generate unique IDs per instance to avoid <defs> collisions+ const maskId1 = useId();+ const maskId2 = useId();+ const maskId3 = useId();+ const uid = useId();+ const mainMaskId = `clerk-checkout-success-mask-${uid}`;+ const radialGradientId = `clerk-checkout-success-gradient-${uid}`;+ const blurFilterId = `clerk-checkout-success-blur-effect-${uid}`;
@@
- <radialGradient id='clerk-checkout-success-gradient'>+ <radialGradient id={radialGradientId}>
@@
- <filter id='clerk-checkout-success-blur-effect'>+ <filter id={blurFilterId}>
@@
- <mask id='clerk-checkout-success-mask'>+ <mask id={mainMaskId}>
@@
- <g mask='url(#clerk-checkout-success-mask)'>+ <g mask={`url(#${mainMaskId})`}>
@@
- fill='url(#clerk-checkout-success-gradient)'- filter='url(#clerk-checkout-success-blur-effect)'+ fill={`url(#${radialGradientId})`}+ filter={`url(#${blurFilterId})`}
Also applies to: 64-82, 117-117, 135-135, 150-151
🤖 Prompt for AI Agents
In packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx around
lines 45-49, 64-82, 117, 135, and 150-151, the SVG IDs (for radialGradient,
filter, mask, etc.) are currently static and can collide across multiple
component instances; replace each static ID with a unique ID generated via useId
(or similar) at the top of the component and update every SVG attribute
reference (id, href/xlink:href, mask, filter, clipPath, etc.) to use those
generated IDs so each instance uses distinct identifiers and avoids collisions.

 return (
 <Box
 elementDescriptor={descriptors.checkoutSuccessRings}
 as='svg'
 // @ts-ignore - viewBox is a valid prop for svg
 viewBox='0 0 512 512'
 sx={{
 position: 'absolute',
 inset: 0,
 pointerEvents: 'none',
 }}
 aria-hidden
 >
 <defs>
 <radialGradient id='clerk-checkout-success-gradient'>
 <stop
 offset='0%'
 style={{
 stopColor: 'var(--ring-highlight)',
 }}
 />
 <stop
 offset='100%'
 stopOpacity='0'
 style={{
 stopColor: 'var(--ring-highlight)',
 }}
 />
 </radialGradient>
 <filter id='clerk-checkout-success-blur-effect'>
 <feGaussianBlur stdDeviation='10' />
 </filter>
 {[
 { r: 225, maskStart: 10, maskEnd: 90, id: maskId1 },
 { r: 162.5, maskStart: 15, maskEnd: 85, id: maskId2 },
 { r: 100, maskStart: 20, maskEnd: 80, id: maskId3 },
 ].map(({ maskStart, maskEnd, id }) => (
 <linearGradient
 key={id}
 id={`gradient-${id}`}
 x1='0%'
 y1='0%'
 x2='0%'
 y2='100%'
 >
 <stop
 offset={`${maskStart + 5}%`}
 stopColor='white'
 stopOpacity='0'
 />
 <stop
 offset={`${maskStart + 35}%`}
 stopColor='white'
 stopOpacity='1'
 />
 <stop
 offset={`${maskEnd - 35}%`}
 stopColor='white'
 stopOpacity='1'
 />
 <stop
 offset={`${maskEnd - 5}%`}
 stopColor='white'
 stopOpacity='0'
 />
 </linearGradient>
 ))}
 <mask id='clerk-checkout-success-mask'>
 {[
 { r: 225, id: maskId1 },
 { r: 162.5, id: maskId2 },
 { r: 100, id: maskId3 },
 ].map(({ r, id }) => (
 <circle
 key={id}
 cx='256'
 cy='256'
 r={r}
 stroke={`url(#gradient-${id})`}
 fill='none'
 strokeWidth='1'
 />
 ))}
 </mask>
 </defs>
 <g mask='url(#clerk-checkout-success-mask)'>
 <rect
 width='512'
 height='512'
 style={{
 fill: 'var(--ring-fill)',
 }}
 />
 {canHover && (
 <rect
 id='movingGradientHighlight'
 width='256'
 height='256'
 x={currentPosition.x - 128}
 y={currentPosition.y - 128}
 fill='url(#clerk-checkout-success-gradient)'
 filter='url(#clerk-checkout-success-blur-effect)'
 />
 )}
 </g>
 </Box>
 );
};

export const CheckoutComplete = () => {
 const router = useRouter();
 const { setIsOpen } = useDrawerContext();
 const { newSubscriptionRedirectUrl } = useCheckoutContext();
 const { checkout } = useCheckout();
 const { totals, paymentSource, planPeriodStart, freeTrialEndsAt } = checkout;
 const [mousePosition, setMousePosition] = useState({ x: 256, y: 256 });
 const [currentPosition, setCurrentPosition] = useState({ x: 256, y: 256 });

 // Generate unique IDs for SVG elements to avoid conflicts with multiple component instances
 const maskId1 = useId();
 const maskId2 = useId();
 const maskId3 = useId();

 const prefersReducedMotion = usePrefersReducedMotion();
 const { animations: layoutAnimations } = useAppearance().parsedLayout;
 const isMotionSafe = !prefersReducedMotion && layoutAnimations === true;

 const animationRef = useRef<number | null>(null);
 const checkoutSuccessRootRef = useRef<HTMLSpanElement>(null);
 const canHover =
 typeof window === 'undefined' ? true : window.matchMedia('(hover: hover) and (pointer: fine)').matches;
Expand All@@ -59,27 +194,6 @@ export const CheckoutComplete = () => {
 }
 };

 useEffect(() => {
 if (!canHover) {
 return;
 }
 const animate = () => {
 setCurrentPosition(prev => {
 const amt = 0.15;
 const x = lerp(prev.x, mousePosition.x, amt);
 const y = lerp(prev.y, mousePosition.y, amt);
 return { x, y };
 });
 animationRef.current = requestAnimationFrame(animate);
 };
 animationRef.current = requestAnimationFrame(animate);
 return () => {
 if (animationRef.current) {
 cancelAnimationFrame(animationRef.current);
 }
 };
 }, [mousePosition, canHover]);

 const handleClose = () => {
 if (newSubscriptionRedirectUrl) {
 void router.navigate(newSubscriptionRedirectUrl);
Expand DownExpand Up@@ -135,111 +249,10 @@ export const CheckoutComplete = () => {
 ref={checkoutSuccessRootRef}
 onMouseMove={handleMouseMove}
 >
 <Box
 elementDescriptor={descriptors.checkoutSuccessRings}
 as='svg'
 // @ts-ignore - viewBox is a valid prop for svg
 viewBox='0 0 512 512'
 sx={{
 position: 'absolute',
 inset: 0,
 pointerEvents: 'none',
 }}
 aria-hidden
 >
 <defs>
 <radialGradient id='clerk-checkout-success-gradient'>
 <stop
 offset='0%'
 style={{
 stopColor: 'var(--ring-highlight)',
 }}
 />
 <stop
 offset='100%'
 stopOpacity='0'
 style={{
 stopColor: 'var(--ring-highlight)',
 }}
 />
 </radialGradient>
 <filter id='clerk-checkout-success-blur-effect'>
 <feGaussianBlur stdDeviation='10' />
 </filter>
 {[
 { r: 225, maskStart: 10, maskEnd: 90, id: maskId1 },
 { r: 162.5, maskStart: 15, maskEnd: 85, id: maskId2 },
 { r: 100, maskStart: 20, maskEnd: 80, id: maskId3 },
 ].map(({ maskStart, maskEnd, id }) => (
 <linearGradient
 key={id}
 id={`gradient-${id}`}
 x1='0%'
 y1='0%'
 x2='0%'
 y2='100%'
 >
 <stop
 offset={`${maskStart + 5}%`}
 stopColor='white'
 stopOpacity='0'
 />
 <stop
 offset={`${maskStart + 35}%`}
 stopColor='white'
 stopOpacity='1'
 />
 <stop
 offset={`${maskEnd - 35}%`}
 stopColor='white'
 stopOpacity='1'
 />
 <stop
 offset={`${maskEnd - 5}%`}
 stopColor='white'
 stopOpacity='0'
 />
 </linearGradient>
 ))}
 <mask id='clerk-checkout-success-mask'>
 {[
 { r: 225, id: maskId1 },
 { r: 162.5, id: maskId2 },
 { r: 100, id: maskId3 },
 ].map(({ r, id }) => (
 <circle
 key={id}
 cx='256'
 cy='256'
 r={r}
 stroke={`url(#gradient-${id})`}
 fill='none'
 strokeWidth='1'
 />
 ))}
 </mask>
 </defs>
 <g mask='url(#clerk-checkout-success-mask)'>
 <rect
 width='512'
 height='512'
 style={{
 fill: 'var(--ring-fill)',
 }}
 />
 {canHover && (
 <rect
 id='movingGradientHighlight'
 width='256'
 height='256'
 x={currentPosition.x - 128}
 y={currentPosition.y - 128}
 fill='url(#clerk-checkout-success-gradient)'
 filter='url(#clerk-checkout-success-blur-effect)'
 />
 )}
 </g>
 </Box>
 <SuccessRing
 positionX={mousePosition.x}
 positionY={mousePosition.y}
 />
 <Box
 elementDescriptor={descriptors.checkoutSuccessBadge}
 sx={t => ({
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(clerk-js): Reduce unnecessary re-renders on CheckoutComplete#6765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

panteliselef
merged 1 commit into

from

Sep 14, 2025
 Merged


fix(clerk-js): Reduce unnecessary re-renders on CheckoutComplete
#6765
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/tangy-snails-poke.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Performance improvements for `<Checkout />`.

279 changes: 146 additions & 133 deletions
packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,25 +14,160 @@ import { useRouter } from '../../router';
const capitalize = (name: string) => name[0].toUpperCase() + name.slice(1);
const lerp = (start: number, end: number, amt: number) => start + (end - start) * amt;

const SuccessRing = ({ positionX, positionY }: { positionX: number; positionY: number }) => {
 const animationRef = useRef<number | null>(null);
 const [currentPosition, setCurrentPosition] = useState({ x: 256, y: 256 });

 const canHover =
 typeof window === 'undefined' ? true : window.matchMedia('(hover: hover) and (pointer: fine)').matches;

 useEffect(() => {
 if (!canHover) {
 return;
 }

Comment on lines

+21
 to 
+27

@coderabbitaicoderabbitaiBotSep 12, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion
Honor reduced-motion and gate the animation accordingly.
SuccessRing ignores prefers-reduced-motion and still runs rAF. Gate both the effect and highlight.
Apply this diff:
@@
- const canHover =- typeof window === 'undefined' ? true : window.matchMedia('(hover: hover) and (pointer: fine)').matches;+ const canHover =+ typeof window === 'undefined' ? false : window.matchMedia('(hover: hover) and (pointer: fine)').matches;+ const prefersReducedMotion = usePrefersReducedMotion();+ const isMotionSafe = !prefersReducedMotion;
@@
- useEffect(() => {- if (!canHover) {+ useEffect(() => {+ if (!canHover || !isMotionSafe) {
return;
}
@@
- }, [positionX, positionY, canHover]);+ }, [positionX, positionY, canHover, isMotionSafe]);
@@
- {canHover && (+ {canHover && isMotionSafe && (
Also applies to: 24-44, 143-153
🤖 Prompt for AI Agents
In packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx around
lines 21-27 (and similarly for ranges 24-44 and 143-153), the component
currently checks only for hover capability but ignores the user's
prefers-reduced-motion setting; update the logic to also detect
prefers-reduced-motion via window.matchMedia('(prefers-reduced-motion:
reduce)').matches and gate both the useEffect that runs requestAnimationFrame
and any highlight/animation rendering by returning early when
prefersReducedMotion is true (i.e., treat either !canHover or
prefersReducedMotion as reasons to skip the effect), and ensure any
highlight/animated class or element is not applied/rendered when reduced motion
is requested.

 const animate = () => {
 setCurrentPosition(prev => {
 const amt = 0.15;
 const x = lerp(prev.x, positionX, amt);
 const y = lerp(prev.y, positionY, amt);
 return { x, y };
 });
 animationRef.current = requestAnimationFrame(animate);
 };
 animationRef.current = requestAnimationFrame(animate);

Comment on lines

+28
 to 
+37

@coderabbitaicoderabbitaiBotSep 12, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion
Stop the rAF loop when the target is reached to avoid perpetual re-renders.
The loop runs forever even when the point stabilizes. Add an epsilon and stop scheduling.
Apply this diff:
- const animate = () => {- setCurrentPosition(prev => {- const amt = 0.15;- const x = lerp(prev.x, positionX, amt);- const y = lerp(prev.y, positionY, amt);- return { x, y };- });- animationRef.current = requestAnimationFrame(animate);- };+ const animate = () => {+ let continueAnim = false;+ setCurrentPosition(prev => {+ const amt = 0.15;+ const x = lerp(prev.x, positionX, amt);+ const y = lerp(prev.y, positionY, amt);+ continueAnim = Math.hypot(x - prev.x, y - prev.y) > 0.5;+ return { x, y };+ });+ if (continueAnim) {+ animationRef.current = requestAnimationFrame(animate);+ } else {+ animationRef.current = null;+ }+ };
Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx around
lines 28–37, the requestAnimationFrame loop never stops once the point
stabilizes; add a small epsilon threshold (e.g., 0.5 pixels or a small
squared-distance) to detect when lerp has effectively reached the target, and
stop scheduling further frames by calling
cancelAnimationFrame(animationRef.current) and clearing animationRef.current
when within that threshold; only call requestAnimationFrame(animate) if the
distance is above epsilon, and ensure any existing animation is cancelled before
starting a new loop.

 return () => {
 if (animationRef.current) {
 cancelAnimationFrame(animationRef.current);
 }
 };
 }, [positionX, positionY, canHover]);

 // Generate unique IDs for SVG elements to avoid conflicts with multiple component instances
 const maskId1 = useId();
 const maskId2 = useId();
 const maskId3 = useId();


Comment on lines

+45
 to 
+49

@coderabbitaicoderabbitaiBotSep 12, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue
Make all SVG IDs unique to prevent collisions when multiple instances render.
Static IDs for the radialGradient, filter, and mask can collide. Generate unique IDs and update references.
Apply this diff:
@@
- // Generate unique IDs for SVG elements to avoid conflicts with multiple component instances- const maskId1 = useId();- const maskId2 = useId();- const maskId3 = useId();+ // Generate unique IDs per instance to avoid <defs> collisions+ const maskId1 = useId();+ const maskId2 = useId();+ const maskId3 = useId();+ const uid = useId();+ const mainMaskId = `clerk-checkout-success-mask-${uid}`;+ const radialGradientId = `clerk-checkout-success-gradient-${uid}`;+ const blurFilterId = `clerk-checkout-success-blur-effect-${uid}`;
@@
- <radialGradient id='clerk-checkout-success-gradient'>+ <radialGradient id={radialGradientId}>
@@
- <filter id='clerk-checkout-success-blur-effect'>+ <filter id={blurFilterId}>
@@
- <mask id='clerk-checkout-success-mask'>+ <mask id={mainMaskId}>
@@
- <g mask='url(#clerk-checkout-success-mask)'>+ <g mask={`url(#${mainMaskId})`}>
@@
- fill='url(#clerk-checkout-success-gradient)'- filter='url(#clerk-checkout-success-blur-effect)'+ fill={`url(#${radialGradientId})`}+ filter={`url(#${blurFilterId})`}
Also applies to: 64-82, 117-117, 135-135, 150-151
🤖 Prompt for AI Agents
In packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx around
lines 45-49, 64-82, 117, 135, and 150-151, the SVG IDs (for radialGradient,
filter, mask, etc.) are currently static and can collide across multiple
component instances; replace each static ID with a unique ID generated via useId
(or similar) at the top of the component and update every SVG attribute
reference (id, href/xlink:href, mask, filter, clipPath, etc.) to use those
generated IDs so each instance uses distinct identifiers and avoids collisions.

 return (
 <Box
 elementDescriptor={descriptors.checkoutSuccessRings}
 as='svg'
 // @ts-ignore - viewBox is a valid prop for svg
 viewBox='0 0 512 512'
 sx={{
 position: 'absolute',
 inset: 0,
 pointerEvents: 'none',
 }}
 aria-hidden
 >
 <defs>
 <radialGradient id='clerk-checkout-success-gradient'>
 <stop
 offset='0%'
 style={{
 stopColor: 'var(--ring-highlight)',
 }}
 />
 <stop
 offset='100%'
 stopOpacity='0'
 style={{
 stopColor: 'var(--ring-highlight)',
 }}
 />
 </radialGradient>
 <filter id='clerk-checkout-success-blur-effect'>
 <feGaussianBlur stdDeviation='10' />
 </filter>
 {[
 { r: 225, maskStart: 10, maskEnd: 90, id: maskId1 },
 { r: 162.5, maskStart: 15, maskEnd: 85, id: maskId2 },
 { r: 100, maskStart: 20, maskEnd: 80, id: maskId3 },
 ].map(({ maskStart, maskEnd, id }) => (
 <linearGradient
 key={id}
 id={`gradient-${id}`}
 x1='0%'
 y1='0%'
 x2='0%'
 y2='100%'
 >
 <stop
 offset={`${maskStart + 5}%`}
 stopColor='white'
 stopOpacity='0'
 />
 <stop
 offset={`${maskStart + 35}%`}
 stopColor='white'
 stopOpacity='1'
 />
 <stop
 offset={`${maskEnd - 35}%`}
 stopColor='white'
 stopOpacity='1'
 />
 <stop
 offset={`${maskEnd - 5}%`}
 stopColor='white'
 stopOpacity='0'
 />
 </linearGradient>
 ))}
 <mask id='clerk-checkout-success-mask'>
 {[
 { r: 225, id: maskId1 },
 { r: 162.5, id: maskId2 },
 { r: 100, id: maskId3 },
 ].map(({ r, id }) => (
 <circle
 key={id}
 cx='256'
 cy='256'
 r={r}
 stroke={`url(#gradient-${id})`}
 fill='none'
 strokeWidth='1'
 />
 ))}
 </mask>
 </defs>
 <g mask='url(#clerk-checkout-success-mask)'>
 <rect
 width='512'
 height='512'
 style={{
 fill: 'var(--ring-fill)',
 }}
 />
 {canHover && (
 <rect
 id='movingGradientHighlight'
 width='256'
 height='256'
 x={currentPosition.x - 128}
 y={currentPosition.y - 128}
 fill='url(#clerk-checkout-success-gradient)'
 filter='url(#clerk-checkout-success-blur-effect)'
 />
 )}
 </g>
 </Box>
 );
};

export const CheckoutComplete = () => {
 const router = useRouter();
 const { setIsOpen } = useDrawerContext();
 const { newSubscriptionRedirectUrl } = useCheckoutContext();
 const { checkout } = useCheckout();
 const { totals, paymentSource, planPeriodStart, freeTrialEndsAt } = checkout;
 const [mousePosition, setMousePosition] = useState({ x: 256, y: 256 });
 const [currentPosition, setCurrentPosition] = useState({ x: 256, y: 256 });

 // Generate unique IDs for SVG elements to avoid conflicts with multiple component instances
 const maskId1 = useId();
 const maskId2 = useId();
 const maskId3 = useId();

 const prefersReducedMotion = usePrefersReducedMotion();
 const { animations: layoutAnimations } = useAppearance().parsedLayout;
 const isMotionSafe = !prefersReducedMotion && layoutAnimations === true;

 const animationRef = useRef<number | null>(null);
 const checkoutSuccessRootRef = useRef<HTMLSpanElement>(null);
 const canHover =
 typeof window === 'undefined' ? true : window.matchMedia('(hover: hover) and (pointer: fine)').matches;
Expand All@@ -59,27 +194,6 @@ export const CheckoutComplete = () => {
 }
 };

 useEffect(() => {
 if (!canHover) {
 return;
 }
 const animate = () => {
 setCurrentPosition(prev => {
 const amt = 0.15;
 const x = lerp(prev.x, mousePosition.x, amt);
 const y = lerp(prev.y, mousePosition.y, amt);
 return { x, y };
 });
 animationRef.current = requestAnimationFrame(animate);
 };
 animationRef.current = requestAnimationFrame(animate);
 return () => {
 if (animationRef.current) {
 cancelAnimationFrame(animationRef.current);
 }
 };
 }, [mousePosition, canHover]);

 const handleClose = () => {
 if (newSubscriptionRedirectUrl) {
 void router.navigate(newSubscriptionRedirectUrl);
Expand DownExpand Up@@ -135,111 +249,10 @@ export const CheckoutComplete = () => {
 ref={checkoutSuccessRootRef}
 onMouseMove={handleMouseMove}
 >
 <Box
 elementDescriptor={descriptors.checkoutSuccessRings}
 as='svg'
 // @ts-ignore - viewBox is a valid prop for svg
 viewBox='0 0 512 512'
 sx={{
 position: 'absolute',
 inset: 0,
 pointerEvents: 'none',
 }}
 aria-hidden
 >
 <defs>
 <radialGradient id='clerk-checkout-success-gradient'>
 <stop
 offset='0%'
 style={{
 stopColor: 'var(--ring-highlight)',
 }}
 />
 <stop
 offset='100%'
 stopOpacity='0'
 style={{
 stopColor: 'var(--ring-highlight)',
 }}
 />
 </radialGradient>
 <filter id='clerk-checkout-success-blur-effect'>
 <feGaussianBlur stdDeviation='10' />
 </filter>
 {[
 { r: 225, maskStart: 10, maskEnd: 90, id: maskId1 },
 { r: 162.5, maskStart: 15, maskEnd: 85, id: maskId2 },
 { r: 100, maskStart: 20, maskEnd: 80, id: maskId3 },
 ].map(({ maskStart, maskEnd, id }) => (
 <linearGradient
 key={id}
 id={`gradient-${id}`}
 x1='0%'
 y1='0%'
 x2='0%'
 y2='100%'
 >
 <stop
 offset={`${maskStart + 5}%`}
 stopColor='white'
 stopOpacity='0'
 />
 <stop
 offset={`${maskStart + 35}%`}
 stopColor='white'
 stopOpacity='1'
 />
 <stop
 offset={`${maskEnd - 35}%`}
 stopColor='white'
 stopOpacity='1'
 />
 <stop
 offset={`${maskEnd - 5}%`}
 stopColor='white'
 stopOpacity='0'
 />
 </linearGradient>
 ))}
 <mask id='clerk-checkout-success-mask'>
 {[
 { r: 225, id: maskId1 },
 { r: 162.5, id: maskId2 },
 { r: 100, id: maskId3 },
 ].map(({ r, id }) => (
 <circle
 key={id}
 cx='256'
 cy='256'
 r={r}
 stroke={`url(#gradient-${id})`}
 fill='none'
 strokeWidth='1'
 />
 ))}
 </mask>
 </defs>
 <g mask='url(#clerk-checkout-success-mask)'>
 <rect
 width='512'
 height='512'
 style={{
 fill: 'var(--ring-fill)',
 }}
 />
 {canHover && (
 <rect
 id='movingGradientHighlight'
 width='256'
 height='256'
 x={currentPosition.x - 128}
 y={currentPosition.y - 128}
 fill='url(#clerk-checkout-success-gradient)'
 filter='url(#clerk-checkout-success-blur-effect)'
 />
 )}
 </g>
 </Box>
 <SuccessRing
 positionX={mousePosition.x}
 positionY={mousePosition.y}
 />
 <Box
 elementDescriptor={descriptors.checkoutSuccessBadge}
 sx={t => ({
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix(clerk-js): Reduce unnecessary re-renders on CheckoutComplete#6765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

panteliselef
merged 1 commit into

from

Sep 14, 2025
 Merged


fix(clerk-js): Reduce unnecessary re-renders on CheckoutComplete
#6765
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/tangy-snails-poke.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Performance improvements for `<Checkout />`.

279 changes: 146 additions & 133 deletions
packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,25 +14,160 @@ import { useRouter } from '../../router';
const capitalize = (name: string) => name[0].toUpperCase() + name.slice(1);
const lerp = (start: number, end: number, amt: number) => start + (end - start) * amt;

const SuccessRing = ({ positionX, positionY }: { positionX: number; positionY: number }) => {
 const animationRef = useRef<number | null>(null);
 const [currentPosition, setCurrentPosition] = useState({ x: 256, y: 256 });

 const canHover =
 typeof window === 'undefined' ? true : window.matchMedia('(hover: hover) and (pointer: fine)').matches;

 useEffect(() => {
 if (!canHover) {
 return;
 }

Comment on lines

+21
 to 
+27

@coderabbitaicoderabbitaiBotSep 12, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion
Honor reduced-motion and gate the animation accordingly.
SuccessRing ignores prefers-reduced-motion and still runs rAF. Gate both the effect and highlight.
Apply this diff:
@@
- const canHover =- typeof window === 'undefined' ? true : window.matchMedia('(hover: hover) and (pointer: fine)').matches;+ const canHover =+ typeof window === 'undefined' ? false : window.matchMedia('(hover: hover) and (pointer: fine)').matches;+ const prefersReducedMotion = usePrefersReducedMotion();+ const isMotionSafe = !prefersReducedMotion;
@@
- useEffect(() => {- if (!canHover) {+ useEffect(() => {+ if (!canHover || !isMotionSafe) {
return;
}
@@
- }, [positionX, positionY, canHover]);+ }, [positionX, positionY, canHover, isMotionSafe]);
@@
- {canHover && (+ {canHover && isMotionSafe && (
Also applies to: 24-44, 143-153
🤖 Prompt for AI Agents
In packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx around
lines 21-27 (and similarly for ranges 24-44 and 143-153), the component
currently checks only for hover capability but ignores the user's
prefers-reduced-motion setting; update the logic to also detect
prefers-reduced-motion via window.matchMedia('(prefers-reduced-motion:
reduce)').matches and gate both the useEffect that runs requestAnimationFrame
and any highlight/animation rendering by returning early when
prefersReducedMotion is true (i.e., treat either !canHover or
prefersReducedMotion as reasons to skip the effect), and ensure any
highlight/animated class or element is not applied/rendered when reduced motion
is requested.

 const animate = () => {
 setCurrentPosition(prev => {
 const amt = 0.15;
 const x = lerp(prev.x, positionX, amt);
 const y = lerp(prev.y, positionY, amt);
 return { x, y };
 });
 animationRef.current = requestAnimationFrame(animate);
 };
 animationRef.current = requestAnimationFrame(animate);

Comment on lines

+28
 to 
+37

@coderabbitaicoderabbitaiBotSep 12, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion
Stop the rAF loop when the target is reached to avoid perpetual re-renders.
The loop runs forever even when the point stabilizes. Add an epsilon and stop scheduling.
Apply this diff:
- const animate = () => {- setCurrentPosition(prev => {- const amt = 0.15;- const x = lerp(prev.x, positionX, amt);- const y = lerp(prev.y, positionY, amt);- return { x, y };- });- animationRef.current = requestAnimationFrame(animate);- };+ const animate = () => {+ let continueAnim = false;+ setCurrentPosition(prev => {+ const amt = 0.15;+ const x = lerp(prev.x, positionX, amt);+ const y = lerp(prev.y, positionY, amt);+ continueAnim = Math.hypot(x - prev.x, y - prev.y) > 0.5;+ return { x, y };+ });+ if (continueAnim) {+ animationRef.current = requestAnimationFrame(animate);+ } else {+ animationRef.current = null;+ }+ };
Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx around
lines 28–37, the requestAnimationFrame loop never stops once the point
stabilizes; add a small epsilon threshold (e.g., 0.5 pixels or a small
squared-distance) to detect when lerp has effectively reached the target, and
stop scheduling further frames by calling
cancelAnimationFrame(animationRef.current) and clearing animationRef.current
when within that threshold; only call requestAnimationFrame(animate) if the
distance is above epsilon, and ensure any existing animation is cancelled before
starting a new loop.

 return () => {
 if (animationRef.current) {
 cancelAnimationFrame(animationRef.current);
 }
 };
 }, [positionX, positionY, canHover]);

 // Generate unique IDs for SVG elements to avoid conflicts with multiple component instances
 const maskId1 = useId();
 const maskId2 = useId();
 const maskId3 = useId();


Comment on lines

+45
 to 
+49

@coderabbitaicoderabbitaiBotSep 12, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue
Make all SVG IDs unique to prevent collisions when multiple instances render.
Static IDs for the radialGradient, filter, and mask can collide. Generate unique IDs and update references.
Apply this diff:
@@
- // Generate unique IDs for SVG elements to avoid conflicts with multiple component instances- const maskId1 = useId();- const maskId2 = useId();- const maskId3 = useId();+ // Generate unique IDs per instance to avoid <defs> collisions+ const maskId1 = useId();+ const maskId2 = useId();+ const maskId3 = useId();+ const uid = useId();+ const mainMaskId = `clerk-checkout-success-mask-${uid}`;+ const radialGradientId = `clerk-checkout-success-gradient-${uid}`;+ const blurFilterId = `clerk-checkout-success-blur-effect-${uid}`;
@@
- <radialGradient id='clerk-checkout-success-gradient'>+ <radialGradient id={radialGradientId}>
@@
- <filter id='clerk-checkout-success-blur-effect'>+ <filter id={blurFilterId}>
@@
- <mask id='clerk-checkout-success-mask'>+ <mask id={mainMaskId}>
@@
- <g mask='url(#clerk-checkout-success-mask)'>+ <g mask={`url(#${mainMaskId})`}>
@@
- fill='url(#clerk-checkout-success-gradient)'- filter='url(#clerk-checkout-success-blur-effect)'+ fill={`url(#${radialGradientId})`}+ filter={`url(#${blurFilterId})`}
Also applies to: 64-82, 117-117, 135-135, 150-151
🤖 Prompt for AI Agents
In packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx around
lines 45-49, 64-82, 117, 135, and 150-151, the SVG IDs (for radialGradient,
filter, mask, etc.) are currently static and can collide across multiple
component instances; replace each static ID with a unique ID generated via useId
(or similar) at the top of the component and update every SVG attribute
reference (id, href/xlink:href, mask, filter, clipPath, etc.) to use those
generated IDs so each instance uses distinct identifiers and avoids collisions.

 return (
 <Box
 elementDescriptor={descriptors.checkoutSuccessRings}
 as='svg'
 // @ts-ignore - viewBox is a valid prop for svg
 viewBox='0 0 512 512'
 sx={{
 position: 'absolute',
 inset: 0,
 pointerEvents: 'none',
 }}
 aria-hidden
 >
 <defs>
 <radialGradient id='clerk-checkout-success-gradient'>
 <stop
 offset='0%'
 style={{
 stopColor: 'var(--ring-highlight)',
 }}
 />
 <stop
 offset='100%'
 stopOpacity='0'
 style={{
 stopColor: 'var(--ring-highlight)',
 }}
 />
 </radialGradient>
 <filter id='clerk-checkout-success-blur-effect'>
 <feGaussianBlur stdDeviation='10' />
 </filter>
 {[
 { r: 225, maskStart: 10, maskEnd: 90, id: maskId1 },
 { r: 162.5, maskStart: 15, maskEnd: 85, id: maskId2 },
 { r: 100, maskStart: 20, maskEnd: 80, id: maskId3 },
 ].map(({ maskStart, maskEnd, id }) => (
 <linearGradient
 key={id}
 id={`gradient-${id}`}
 x1='0%'
 y1='0%'
 x2='0%'
 y2='100%'
 >
 <stop
 offset={`${maskStart + 5}%`}
 stopColor='white'
 stopOpacity='0'
 />
 <stop
 offset={`${maskStart + 35}%`}
 stopColor='white'
 stopOpacity='1'
 />
 <stop
 offset={`${maskEnd - 35}%`}
 stopColor='white'
 stopOpacity='1'
 />
 <stop
 offset={`${maskEnd - 5}%`}
 stopColor='white'
 stopOpacity='0'
 />
 </linearGradient>
 ))}
 <mask id='clerk-checkout-success-mask'>
 {[
 { r: 225, id: maskId1 },
 { r: 162.5, id: maskId2 },
 { r: 100, id: maskId3 },
 ].map(({ r, id }) => (
 <circle
 key={id}
 cx='256'
 cy='256'
 r={r}
 stroke={`url(#gradient-${id})`}
 fill='none'
 strokeWidth='1'
 />
 ))}
 </mask>
 </defs>
 <g mask='url(#clerk-checkout-success-mask)'>
 <rect
 width='512'
 height='512'
 style={{
 fill: 'var(--ring-fill)',
 }}
 />
 {canHover && (
 <rect
 id='movingGradientHighlight'
 width='256'
 height='256'
 x={currentPosition.x - 128}
 y={currentPosition.y - 128}
 fill='url(#clerk-checkout-success-gradient)'
 filter='url(#clerk-checkout-success-blur-effect)'
 />
 )}
 </g>
 </Box>
 );
};

export const CheckoutComplete = () => {
 const router = useRouter();
 const { setIsOpen } = useDrawerContext();
 const { newSubscriptionRedirectUrl } = useCheckoutContext();
 const { checkout } = useCheckout();
 const { totals, paymentSource, planPeriodStart, freeTrialEndsAt } = checkout;
 const [mousePosition, setMousePosition] = useState({ x: 256, y: 256 });
 const [currentPosition, setCurrentPosition] = useState({ x: 256, y: 256 });

 // Generate unique IDs for SVG elements to avoid conflicts with multiple component instances
 const maskId1 = useId();
 const maskId2 = useId();
 const maskId3 = useId();

 const prefersReducedMotion = usePrefersReducedMotion();
 const { animations: layoutAnimations } = useAppearance().parsedLayout;
 const isMotionSafe = !prefersReducedMotion && layoutAnimations === true;

 const animationRef = useRef<number | null>(null);
 const checkoutSuccessRootRef = useRef<HTMLSpanElement>(null);
 const canHover =
 typeof window === 'undefined' ? true : window.matchMedia('(hover: hover) and (pointer: fine)').matches;
Expand All@@ -59,27 +194,6 @@ export const CheckoutComplete = () => {
 }
 };

 useEffect(() => {
 if (!canHover) {
 return;
 }
 const animate = () => {
 setCurrentPosition(prev => {
 const amt = 0.15;
 const x = lerp(prev.x, mousePosition.x, amt);
 const y = lerp(prev.y, mousePosition.y, amt);
 return { x, y };
 });
 animationRef.current = requestAnimationFrame(animate);
 };
 animationRef.current = requestAnimationFrame(animate);
 return () => {
 if (animationRef.current) {
 cancelAnimationFrame(animationRef.current);
 }
 };
 }, [mousePosition, canHover]);

 const handleClose = () => {
 if (newSubscriptionRedirectUrl) {
 void router.navigate(newSubscriptionRedirectUrl);
Expand DownExpand Up@@ -135,111 +249,10 @@ export const CheckoutComplete = () => {
 ref={checkoutSuccessRootRef}
 onMouseMove={handleMouseMove}
 >
 <Box
 elementDescriptor={descriptors.checkoutSuccessRings}
 as='svg'
 // @ts-ignore - viewBox is a valid prop for svg
 viewBox='0 0 512 512'
 sx={{
 position: 'absolute',
 inset: 0,
 pointerEvents: 'none',
 }}
 aria-hidden
 >
 <defs>
 <radialGradient id='clerk-checkout-success-gradient'>
 <stop
 offset='0%'
 style={{
 stopColor: 'var(--ring-highlight)',
 }}
 />
 <stop
 offset='100%'
 stopOpacity='0'
 style={{
 stopColor: 'var(--ring-highlight)',
 }}
 />
 </radialGradient>
 <filter id='clerk-checkout-success-blur-effect'>
 <feGaussianBlur stdDeviation='10' />
 </filter>
 {[
 { r: 225, maskStart: 10, maskEnd: 90, id: maskId1 },
 { r: 162.5, maskStart: 15, maskEnd: 85, id: maskId2 },
 { r: 100, maskStart: 20, maskEnd: 80, id: maskId3 },
 ].map(({ maskStart, maskEnd, id }) => (
 <linearGradient
 key={id}
 id={`gradient-${id}`}
 x1='0%'
 y1='0%'
 x2='0%'
 y2='100%'
 >
 <stop
 offset={`${maskStart + 5}%`}
 stopColor='white'
 stopOpacity='0'
 />
 <stop
 offset={`${maskStart + 35}%`}
 stopColor='white'
 stopOpacity='1'
 />
 <stop
 offset={`${maskEnd - 35}%`}
 stopColor='white'
 stopOpacity='1'
 />
 <stop
 offset={`${maskEnd - 5}%`}
 stopColor='white'
 stopOpacity='0'
 />
 </linearGradient>
 ))}
 <mask id='clerk-checkout-success-mask'>
 {[
 { r: 225, id: maskId1 },
 { r: 162.5, id: maskId2 },
 { r: 100, id: maskId3 },
 ].map(({ r, id }) => (
 <circle
 key={id}
 cx='256'
 cy='256'
 r={r}
 stroke={`url(#gradient-${id})`}
 fill='none'
 strokeWidth='1'
 />
 ))}
 </mask>
 </defs>
 <g mask='url(#clerk-checkout-success-mask)'>
 <rect
 width='512'
 height='512'
 style={{
 fill: 'var(--ring-fill)',
 }}
 />
 {canHover && (
 <rect
 id='movingGradientHighlight'
 width='256'
 height='256'
 x={currentPosition.x - 128}
 y={currentPosition.y - 128}
 fill='url(#clerk-checkout-success-gradient)'
 filter='url(#clerk-checkout-success-blur-effect)'
 />
 )}
 </g>
 </Box>
 <SuccessRing
 positionX={mousePosition.x}
 positionY={mousePosition.y}
 />
 <Box
 elementDescriptor={descriptors.checkoutSuccessBadge}
 sx={t => ({
Expand Down