Skip to content

chore(clerk-js,types): Clean up deprecated attribute - #6788

Merged
mauricioabreu merged 1 commit into
mainfrom
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
Sep 16, 2025
Merged

chore(clerk-js,types): Clean up deprecated attribute#6788
mauricioabreu merged 1 commit into
mainfrom
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi

Conversation

@mauricioabreu

@mauricioabreumauricioabreu commented Sep 16, 2025•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

This commit removes the subscription attribute from Billing structs. We deprecated this attribute a few weeks ago, and now it's time to remove it in-favor of subscription_item.

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Refactor

    • Removed a deprecated Billing attribute; use subscriptionItem going forward. Update any integrations referencing the old subscription field to ensure compatibility.

  • Chores

    • Published minor package updates to reflect the removal across client and type packages.

@changeset-bot

changeset-botBot commented Sep 16, 2025•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3c6cbe4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
NameType
@clerk/clerk-jsMinor
@clerk/typesMinor
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Sep 16, 2025•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentSep 16, 2025 5:43pm

@coderabbitai

coderabbitaiBot commented Sep 16, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

Removes the deprecated subscription field from CommercePayment in runtime and types, updates JSON parsing to stop assigning it, and adds a changeset bumping @clerk/clerk-js and @clerk/types documenting the Billing Beta removal.

Changes

Cohort / File(s)Summary of Changes
Release metadata
\.changeset/seven-buses-teach.md		Adds a changeset recording minor bumps for @clerk/clerk-js and @clerk/types and noting the removal of the deprecated Billing subscription attribute.
Runtime resource update
packages/clerk-js/src/core/resources/CommercePayment.ts		Removes the public subscription property and its assignment during JSON parsing; retains subscriptionItem mapping from data.subscription_item.
Types API update
packages/types/src/commerce.ts		Removes the deprecated subscription property from CommercePaymentResource; subscriptionItem remains as the public field.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

I nibbled old fields from the meadow of types,
Snipped a subscription, trimmed legacy stripes.
Now payments hop lightly with one tidy item—
Clean burrows ahead, no deprecated chime.
Thump-thump! Minor bumps, and onward I bound. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe title accurately and concisely describes the main change: cleaning up a deprecated attribute in the clerk-js and types packages, which matches the PR's removal of the deprecated subscription field; it uses conventional-commit style and is clear for a reviewer scanning history.
Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 00edd67 and 3c6cbe4.

📒 Files selected for processing (3)
  • .changeset/seven-buses-teach.md (1 hunks)
  • packages/clerk-js/src/core/resources/CommercePayment.ts (0 hunks)
  • packages/types/src/commerce.ts (0 hunks)
💤 Files with no reviewable changes (2)
  • packages/clerk-js/src/core/resources/CommercePayment.ts
  • packages/types/src/commerce.ts
✅ Files skipped from review due to trivial changes (1)
  • .changeset/seven-buses-teach.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"mode: "warning"instructions: | Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Comment @coderabbitai help to get the list of available commands and usage tips.

@mauricioabreumauricioabreu changed the title chore(billing): Clean up unused subscription attributechore(billing): Clean up unused deprecated attributeSep 16, 2025
@mauricioabreu
mauricioabreuforce-pushed the mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi branch from 02337fb to 3b2dabeCompareSeptember 16, 2025 15:59
@mauricioabreumauricioabreu changed the title chore(billing): Clean up unused deprecated attributechore(billing): Clean up deprecated attributeSep 16, 2025
@mauricioabreu
mauricioabreuforce-pushed the mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi branch from 3b2dabe to 00edd67CompareSeptember 16, 2025 16:07
@mauricioabreu
mauricioabreu marked this pull request as ready for review September 16, 2025 16:07
coderabbitai[bot]
coderabbitaiBot reviewed Sep 16, 2025
View reviewed changes

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.changeset/seven-buses-teach.md (1)

6-6: Expand the changeset body with a concise BREAKING + migration note.

Add explicit guidance so downstreams can migrate quickly; include the replacement field and JSON key rename.

Apply this diff:

-[Billing Beta] Remove deprecated `subscription` attribute from Billing+[Billing Beta][BREAKING] Remove deprecated `subscription` attribute from Billing.++Migration:+- Replace `subscription` with `subscriptionItem` in code.+- If parsing raw JSON, use `subscription_item` (was `subscription`).+- No other shape changes expected; nullability matches `subscriptionItem`.
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8bb283b and 00edd67.

📒 Files selected for processing (3)
  • .changeset/seven-buses-teach.md (1 hunks)
  • packages/clerk-js/src/core/resources/CommercePayment.ts (0 hunks)
  • packages/types/src/commerce.ts (0 hunks)
💤 Files with no reviewable changes (2)
  • packages/types/src/commerce.ts
  • packages/clerk-js/src/core/resources/CommercePayment.ts
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Automated releases must use Changesets.

Files:

  • .changeset/seven-buses-teach.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
.changeset/seven-buses-teach.md (1)

1-6: Sanity‑check repo for leftover references to subscription

Automated rg run was inconclusive ("No files were searched"). Re-run locally and paste the output of one of these checks:

git grep -n 'subscription' || true
rg --debug -n --hidden -uu -C2 '\bsubscription\b' || true

Comment thread.changeset/seven-buses-teach.md
@l-armstrong

l-armstrong commented Sep 16, 2025

Copy link
Copy Markdown
Contributor

There's no backend code that depends on this field?

@mauricioabreu
chore(clerk-js,types): Clean up deprecated subscription attribute
3c6cbe4
This commit removes the `subscription` attribute from Billing structs.
We deprecated this attribute a few weeks ago, and now it's time to
remove it in-favor of `subscription_item`.
@mauricioabreu
mauricioabreuforce-pushed the mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi branch from 00edd67 to 3c6cbe4CompareSeptember 16, 2025 17:42
@mauricioabreumauricioabreu changed the title chore(billing): Clean up deprecated attributechore(clerk-js,types): Clean up deprecated attributeSep 16, 2025
@mauricioabreu
mauricioabreu enabled auto-merge (squash) September 16, 2025 17:46
@pkg-pr-new

pkg-pr-newBot commented Sep 16, 2025

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6788

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6788

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6788

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6788

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6788

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6788

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6788

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6788

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6788

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6788

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6788

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6788

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6788

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6788

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6788

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6788

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6788

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6788

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6788

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6788

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6788

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6788

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6788

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6788

commit: 3c6cbe4

@mauricioabreu
mauricioabreu merged commit 9d4a95c into mainSep 16, 2025
42 checks passed
@mauricioabreu
mauricioabreu deleted the mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi branch September 16, 2025 17:57
@clerk-cookieclerk-cookie mentioned this pull request Sep 16, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
+2 more reviewers
@panteliselefpanteliselefpanteliselef approved these changes
@l-armstrongl-armstrongl-armstrong approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

clerk-jstypes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mauricioabreu@l-armstrong@panteliselef@clerk-cookie
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
chore(clerk-js,types): Clean up deprecated attribute by mauricioabreu · Pull Request #6788 · clerk/javascript · GitHub
Skip to content
chore(clerk-js,types): Clean up deprecated attribute - #6788
Merged
mauricioabreu merged 1 commit into
mainfrom 
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
Sep 16, 2025
Merged
chore(clerk-js,types): Clean up deprecated attribute#6788
mauricioabreu merged 1 commit into
mainfrom 
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
Conversation
@mauricioabreu
@mauricioabreumauricioabreu
commented
Sep 16, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
This commit removes the subscription attribute from Billing structs. We deprecated this attribute a few weeks ago, and now it's time to remove it in-favor of subscription_item.
Description
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Refactor
    • Removed a deprecated Billing attribute; use subscriptionItem going forward. Update any integrations referencing the old subscription field to ensure compatibility.
  • Chores
    • Published minor package updates to reflect the removal across client and type packages.
@changeset-bot
changeset-botBot
commented
Sep 16, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 3c6cbe4
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 22 packages
NameType
@clerk/clerk-jsMinor
@clerk/typesMinor
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Sep 16, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentSep 16, 2025 5:43pm
@coderabbitai
coderabbitaiBot
commented
Sep 16, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
Removes the deprecated subscription field from CommercePayment in runtime and types, updates JSON parsing to stop assigning it, and adds a changeset bumping @clerk/clerk-js and @clerk/types documenting the Billing Beta removal.
Changes
Cohort / File(s)Summary of Changes
Release metadata
\.changeset/seven-buses-teach.md		Adds a changeset recording minor bumps for @clerk/clerk-js and @clerk/types and noting the removal of the deprecated Billing subscription attribute.
Runtime resource update
packages/clerk-js/src/core/resources/CommercePayment.ts		Removes the public subscription property and its assignment during JSON parsing; retains subscriptionItem mapping from data.subscription_item.
Types API update
packages/types/src/commerce.ts		Removes the deprecated subscription property from CommercePaymentResource; subscriptionItem remains as the public field.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
I nibbled old fields from the meadow of types,

Snipped a subscription, trimmed legacy stripes.

Now payments hop lightly with one tidy item—

Clean burrows ahead, no deprecated chime.

Thump-thump! Minor bumps, and onward I bound. 🐇✨
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe title accurately and concisely describes the main change: cleaning up a deprecated attribute in the clerk-js and types packages, which matches the PR's removal of the deprecated subscription field; it uses conventional-commit style and is clear for a reviewer scanning history.
Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  •  📝 Generate Docstrings
🧪 Generate unit tests
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
📜 Recent review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
  • Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📥 Commits
Reviewing files that changed from the base of the PR and between 00edd67 and 3c6cbe4.
📒 Files selected for processing (3)
  • .changeset/seven-buses-teach.md (1 hunks)
  • packages/clerk-js/src/core/resources/CommercePayment.ts (0 hunks)
  • packages/types/src/commerce.ts (0 hunks)
💤 Files with no reviewable changes (2)
  • packages/clerk-js/src/core/resources/CommercePayment.ts
  • packages/types/src/commerce.ts
✅ Files skipped from review due to trivial changes (1)
  • .changeset/seven-buses-teach.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
Tip
👮 Agentic pre-merge checks are now available in preview!
Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.
Please see the documentation for more information.
Example:
reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"mode: "warning"instructions: | Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).
Please share your feedback with us on this Discord post.
Comment @coderabbitai help to get the list of available commands and usage tips.
@mauricioabreumauricioabreu
changed the title
chore(billing): Clean up unused subscription attributechore(billing): Clean up unused deprecated attributeSep 16, 2025
@mauricioabreu
mauricioabreuforce-pushed
the
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
branch
from
02337fb to
3b2dabeCompareSeptember 16, 2025 15:59
@mauricioabreumauricioabreu
changed the title
chore(billing): Clean up unused deprecated attributechore(billing): Clean up deprecated attributeSep 16, 2025
@mauricioabreu
mauricioabreuforce-pushed
the
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
branch
from
3b2dabe to
00edd67CompareSeptember 16, 2025 16:07
@mauricioabreu
mauricioabreu
marked this pull request as ready for review
September 16, 2025 16:07
coderabbitai[bot]
coderabbitaiBot
reviewed
Sep 16, 2025
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🧹 Nitpick comments (1)
.changeset/seven-buses-teach.md (1)
6-6: Expand the changeset body with a concise BREAKING + migration note.
Add explicit guidance so downstreams can migrate quickly; include the replacement field and JSON key rename.
Apply this diff:
-[Billing Beta] Remove deprecated `subscription` attribute from Billing+[Billing Beta][BREAKING] Remove deprecated `subscription` attribute from Billing.++Migration:+- Replace `subscription` with `subscriptionItem` in code.+- If parsing raw JSON, use `subscription_item` (was `subscription`).+- No other shape changes expected; nullability matches `subscriptionItem`.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
  • Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📥 Commits
Reviewing files that changed from the base of the PR and between 8bb283b and 00edd67.
📒 Files selected for processing (3)
  • .changeset/seven-buses-teach.md (1 hunks)
  • packages/clerk-js/src/core/resources/CommercePayment.ts (0 hunks)
  • packages/types/src/commerce.ts (0 hunks)
💤 Files with no reviewable changes (2)
  • packages/types/src/commerce.ts
  • packages/clerk-js/src/core/resources/CommercePayment.ts
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Automated releases must use Changesets.
Files:
  • .changeset/seven-buses-teach.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
.changeset/seven-buses-teach.md (1)
1-6: Sanity‑check repo for leftover references to subscription
Automated rg run was inconclusive ("No files were searched"). Re-run locally and paste the output of one of these checks:
git grep -n 'subscription' || true
rg --debug -n --hidden -uu -C2 '\bsubscription\b' || true

Comment thread.changeset/seven-buses-teach.md
@l-armstrong
l-armstrong
commented
Sep 16, 2025

Copy link


Copy Markdown

Contributor
There's no backend code that depends on this field?
@mauricioabreu
chore(clerk-js,types): Clean up deprecated subscription attribute
3c6cbe4
This commit removes the `subscription` attribute from Billing structs.
We deprecated this attribute a few weeks ago, and now it's time to
remove it in-favor of `subscription_item`.
@mauricioabreu
mauricioabreuforce-pushed
the
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
branch
from
00edd67 to
3c6cbe4CompareSeptember 16, 2025 17:42
@mauricioabreumauricioabreu
changed the title
chore(billing): Clean up deprecated attributechore(clerk-js,types): Clean up deprecated attributeSep 16, 2025
@mauricioabreu
mauricioabreu
enabled auto-merge (squash)
September 16, 2025 17:46
@pkg-pr-new
pkg-pr-newBot
commented
Sep 16, 2025

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@6788

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@6788

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@6788

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@6788

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@6788

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@6788

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@6788

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@6788

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@6788

@clerk/express
npm i https://pkg.pr.new/@clerk/express@6788

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@6788

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@6788

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@6788

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@6788

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@6788

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@6788

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@6788

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@6788

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@6788

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@6788

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@6788

@clerk/types
npm i https://pkg.pr.new/@clerk/types@6788

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@6788

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@6788

commit: 3c6cbe4
@mauricioabreu
mauricioabreu
merged commit 9d4a95c
into
mainSep 16, 2025

42 checks passed

@mauricioabreu
mauricioabreu
deleted the

mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi

branch
September 16, 2025 17:57
@clerk-cookieclerk-cookie
mentioned this pull request
Sep 16, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

+2 more reviewers

@panteliselefpanteliselefpanteliselef approved these changes
@l-armstrongl-armstrongl-armstrong approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

clerk-jstypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@mauricioabreu@l-armstrong@panteliselef@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore(clerk-js,types): Clean up deprecated attribute by mauricioabreu · Pull Request #6788 · clerk/javascript · GitHub
Skip to content
chore(clerk-js,types): Clean up deprecated attribute - #6788
Merged
mauricioabreu merged 1 commit into
mainfrom 
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
Sep 16, 2025
Merged
chore(clerk-js,types): Clean up deprecated attribute#6788
mauricioabreu merged 1 commit into
mainfrom 
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
Conversation
@mauricioabreu
@mauricioabreumauricioabreu
commented
Sep 16, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
This commit removes the subscription attribute from Billing structs. We deprecated this attribute a few weeks ago, and now it's time to remove it in-favor of subscription_item.
Description
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Refactor
    • Removed a deprecated Billing attribute; use subscriptionItem going forward. Update any integrations referencing the old subscription field to ensure compatibility.
  • Chores
    • Published minor package updates to reflect the removal across client and type packages.
@changeset-bot
changeset-botBot
commented
Sep 16, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 3c6cbe4
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 22 packages
NameType
@clerk/clerk-jsMinor
@clerk/typesMinor
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Sep 16, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentSep 16, 2025 5:43pm
@coderabbitai
coderabbitaiBot
commented
Sep 16, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
Removes the deprecated subscription field from CommercePayment in runtime and types, updates JSON parsing to stop assigning it, and adds a changeset bumping @clerk/clerk-js and @clerk/types documenting the Billing Beta removal.
Changes
Cohort / File(s)Summary of Changes
Release metadata
\.changeset/seven-buses-teach.md		Adds a changeset recording minor bumps for @clerk/clerk-js and @clerk/types and noting the removal of the deprecated Billing subscription attribute.
Runtime resource update
packages/clerk-js/src/core/resources/CommercePayment.ts		Removes the public subscription property and its assignment during JSON parsing; retains subscriptionItem mapping from data.subscription_item.
Types API update
packages/types/src/commerce.ts		Removes the deprecated subscription property from CommercePaymentResource; subscriptionItem remains as the public field.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
I nibbled old fields from the meadow of types,

Snipped a subscription, trimmed legacy stripes.

Now payments hop lightly with one tidy item—

Clean burrows ahead, no deprecated chime.

Thump-thump! Minor bumps, and onward I bound. 🐇✨
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe title accurately and concisely describes the main change: cleaning up a deprecated attribute in the clerk-js and types packages, which matches the PR's removal of the deprecated subscription field; it uses conventional-commit style and is clear for a reviewer scanning history.
Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  •  📝 Generate Docstrings
🧪 Generate unit tests
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
📜 Recent review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
  • Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📥 Commits
Reviewing files that changed from the base of the PR and between 00edd67 and 3c6cbe4.
📒 Files selected for processing (3)
  • .changeset/seven-buses-teach.md (1 hunks)
  • packages/clerk-js/src/core/resources/CommercePayment.ts (0 hunks)
  • packages/types/src/commerce.ts (0 hunks)
💤 Files with no reviewable changes (2)
  • packages/clerk-js/src/core/resources/CommercePayment.ts
  • packages/types/src/commerce.ts
✅ Files skipped from review due to trivial changes (1)
  • .changeset/seven-buses-teach.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
Tip
👮 Agentic pre-merge checks are now available in preview!
Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.
Please see the documentation for more information.
Example:
reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"mode: "warning"instructions: | Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).
Please share your feedback with us on this Discord post.
Comment @coderabbitai help to get the list of available commands and usage tips.
@mauricioabreumauricioabreu
changed the title
chore(billing): Clean up unused subscription attributechore(billing): Clean up unused deprecated attributeSep 16, 2025
@mauricioabreu
mauricioabreuforce-pushed
the
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
branch
from
02337fb to
3b2dabeCompareSeptember 16, 2025 15:59
@mauricioabreumauricioabreu
changed the title
chore(billing): Clean up unused deprecated attributechore(billing): Clean up deprecated attributeSep 16, 2025
@mauricioabreu
mauricioabreuforce-pushed
the
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
branch
from
3b2dabe to
00edd67CompareSeptember 16, 2025 16:07
@mauricioabreu
mauricioabreu
marked this pull request as ready for review
September 16, 2025 16:07
coderabbitai[bot]
coderabbitaiBot
reviewed
Sep 16, 2025
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🧹 Nitpick comments (1)
.changeset/seven-buses-teach.md (1)
6-6: Expand the changeset body with a concise BREAKING + migration note.
Add explicit guidance so downstreams can migrate quickly; include the replacement field and JSON key rename.
Apply this diff:
-[Billing Beta] Remove deprecated `subscription` attribute from Billing+[Billing Beta][BREAKING] Remove deprecated `subscription` attribute from Billing.++Migration:+- Replace `subscription` with `subscriptionItem` in code.+- If parsing raw JSON, use `subscription_item` (was `subscription`).+- No other shape changes expected; nullability matches `subscriptionItem`.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
  • Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📥 Commits
Reviewing files that changed from the base of the PR and between 8bb283b and 00edd67.
📒 Files selected for processing (3)
  • .changeset/seven-buses-teach.md (1 hunks)
  • packages/clerk-js/src/core/resources/CommercePayment.ts (0 hunks)
  • packages/types/src/commerce.ts (0 hunks)
💤 Files with no reviewable changes (2)
  • packages/types/src/commerce.ts
  • packages/clerk-js/src/core/resources/CommercePayment.ts
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Automated releases must use Changesets.
Files:
  • .changeset/seven-buses-teach.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
.changeset/seven-buses-teach.md (1)
1-6: Sanity‑check repo for leftover references to subscription
Automated rg run was inconclusive ("No files were searched"). Re-run locally and paste the output of one of these checks:
git grep -n 'subscription' || true
rg --debug -n --hidden -uu -C2 '\bsubscription\b' || true

Comment thread.changeset/seven-buses-teach.md
@l-armstrong
l-armstrong
commented
Sep 16, 2025

Copy link


Copy Markdown

Contributor
There's no backend code that depends on this field?
@mauricioabreu
chore(clerk-js,types): Clean up deprecated subscription attribute
3c6cbe4
This commit removes the `subscription` attribute from Billing structs.
We deprecated this attribute a few weeks ago, and now it's time to
remove it in-favor of `subscription_item`.
@mauricioabreu
mauricioabreuforce-pushed
the
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
branch
from
00edd67 to
3c6cbe4CompareSeptember 16, 2025 17:42
@mauricioabreumauricioabreu
changed the title
chore(billing): Clean up deprecated attributechore(clerk-js,types): Clean up deprecated attributeSep 16, 2025
@mauricioabreu
mauricioabreu
enabled auto-merge (squash)
September 16, 2025 17:46
@pkg-pr-new
pkg-pr-newBot
commented
Sep 16, 2025

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@6788

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@6788

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@6788

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@6788

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@6788

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@6788

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@6788

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@6788

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@6788

@clerk/express
npm i https://pkg.pr.new/@clerk/express@6788

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@6788

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@6788

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@6788

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@6788

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@6788

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@6788

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@6788

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@6788

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@6788

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@6788

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@6788

@clerk/types
npm i https://pkg.pr.new/@clerk/types@6788

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@6788

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@6788

commit: 3c6cbe4
@mauricioabreu
mauricioabreu
merged commit 9d4a95c
into
mainSep 16, 2025

42 checks passed

@mauricioabreu
mauricioabreu
deleted the

mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi

branch
September 16, 2025 17:57
@clerk-cookieclerk-cookie
mentioned this pull request
Sep 16, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

+2 more reviewers

@panteliselefpanteliselefpanteliselef approved these changes
@l-armstrongl-armstrongl-armstrong approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

clerk-jstypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@mauricioabreu@l-armstrong@panteliselef@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore(clerk-js,types): Clean up deprecated attribute by mauricioabreu · Pull Request #6788 · clerk/javascript · GitHub
Skip to content
chore(clerk-js,types): Clean up deprecated attribute - #6788
Merged
mauricioabreu merged 1 commit into
mainfrom 
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
Sep 16, 2025
Merged
chore(clerk-js,types): Clean up deprecated attribute#6788
mauricioabreu merged 1 commit into
mainfrom 
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
Conversation
@mauricioabreu
@mauricioabreumauricioabreu
commented
Sep 16, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
This commit removes the subscription attribute from Billing structs. We deprecated this attribute a few weeks ago, and now it's time to remove it in-favor of subscription_item.
Description
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Refactor
    • Removed a deprecated Billing attribute; use subscriptionItem going forward. Update any integrations referencing the old subscription field to ensure compatibility.
  • Chores
    • Published minor package updates to reflect the removal across client and type packages.
@changeset-bot
changeset-botBot
commented
Sep 16, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 3c6cbe4
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 22 packages
NameType
@clerk/clerk-jsMinor
@clerk/typesMinor
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Sep 16, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentSep 16, 2025 5:43pm
@coderabbitai
coderabbitaiBot
commented
Sep 16, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
Removes the deprecated subscription field from CommercePayment in runtime and types, updates JSON parsing to stop assigning it, and adds a changeset bumping @clerk/clerk-js and @clerk/types documenting the Billing Beta removal.
Changes
Cohort / File(s)Summary of Changes
Release metadata
\.changeset/seven-buses-teach.md		Adds a changeset recording minor bumps for @clerk/clerk-js and @clerk/types and noting the removal of the deprecated Billing subscription attribute.
Runtime resource update
packages/clerk-js/src/core/resources/CommercePayment.ts		Removes the public subscription property and its assignment during JSON parsing; retains subscriptionItem mapping from data.subscription_item.
Types API update
packages/types/src/commerce.ts		Removes the deprecated subscription property from CommercePaymentResource; subscriptionItem remains as the public field.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
I nibbled old fields from the meadow of types,

Snipped a subscription, trimmed legacy stripes.

Now payments hop lightly with one tidy item—

Clean burrows ahead, no deprecated chime.

Thump-thump! Minor bumps, and onward I bound. 🐇✨
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe title accurately and concisely describes the main change: cleaning up a deprecated attribute in the clerk-js and types packages, which matches the PR's removal of the deprecated subscription field; it uses conventional-commit style and is clear for a reviewer scanning history.
Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  •  📝 Generate Docstrings
🧪 Generate unit tests
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
📜 Recent review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
  • Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📥 Commits
Reviewing files that changed from the base of the PR and between 00edd67 and 3c6cbe4.
📒 Files selected for processing (3)
  • .changeset/seven-buses-teach.md (1 hunks)
  • packages/clerk-js/src/core/resources/CommercePayment.ts (0 hunks)
  • packages/types/src/commerce.ts (0 hunks)
💤 Files with no reviewable changes (2)
  • packages/clerk-js/src/core/resources/CommercePayment.ts
  • packages/types/src/commerce.ts
✅ Files skipped from review due to trivial changes (1)
  • .changeset/seven-buses-teach.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
Tip
👮 Agentic pre-merge checks are now available in preview!
Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.
Please see the documentation for more information.
Example:
reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"mode: "warning"instructions: | Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).
Please share your feedback with us on this Discord post.
Comment @coderabbitai help to get the list of available commands and usage tips.
@mauricioabreumauricioabreu
changed the title
chore(billing): Clean up unused subscription attributechore(billing): Clean up unused deprecated attributeSep 16, 2025
@mauricioabreu
mauricioabreuforce-pushed
the
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
branch
from
02337fb to
3b2dabeCompareSeptember 16, 2025 15:59
@mauricioabreumauricioabreu
changed the title
chore(billing): Clean up unused deprecated attributechore(billing): Clean up deprecated attributeSep 16, 2025
@mauricioabreu
mauricioabreuforce-pushed
the
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
branch
from
3b2dabe to
00edd67CompareSeptember 16, 2025 16:07
@mauricioabreu
mauricioabreu
marked this pull request as ready for review
September 16, 2025 16:07
coderabbitai[bot]
coderabbitaiBot
reviewed
Sep 16, 2025
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🧹 Nitpick comments (1)
.changeset/seven-buses-teach.md (1)
6-6: Expand the changeset body with a concise BREAKING + migration note.
Add explicit guidance so downstreams can migrate quickly; include the replacement field and JSON key rename.
Apply this diff:
-[Billing Beta] Remove deprecated `subscription` attribute from Billing+[Billing Beta][BREAKING] Remove deprecated `subscription` attribute from Billing.++Migration:+- Replace `subscription` with `subscriptionItem` in code.+- If parsing raw JSON, use `subscription_item` (was `subscription`).+- No other shape changes expected; nullability matches `subscriptionItem`.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
  • Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📥 Commits
Reviewing files that changed from the base of the PR and between 8bb283b and 00edd67.
📒 Files selected for processing (3)
  • .changeset/seven-buses-teach.md (1 hunks)
  • packages/clerk-js/src/core/resources/CommercePayment.ts (0 hunks)
  • packages/types/src/commerce.ts (0 hunks)
💤 Files with no reviewable changes (2)
  • packages/types/src/commerce.ts
  • packages/clerk-js/src/core/resources/CommercePayment.ts
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Automated releases must use Changesets.
Files:
  • .changeset/seven-buses-teach.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
.changeset/seven-buses-teach.md (1)
1-6: Sanity‑check repo for leftover references to subscription
Automated rg run was inconclusive ("No files were searched"). Re-run locally and paste the output of one of these checks:
git grep -n 'subscription' || true
rg --debug -n --hidden -uu -C2 '\bsubscription\b' || true

Comment thread.changeset/seven-buses-teach.md
@l-armstrong
l-armstrong
commented
Sep 16, 2025

Copy link


Copy Markdown

Contributor
There's no backend code that depends on this field?
@mauricioabreu
chore(clerk-js,types): Clean up deprecated subscription attribute
3c6cbe4
This commit removes the `subscription` attribute from Billing structs.
We deprecated this attribute a few weeks ago, and now it's time to
remove it in-favor of `subscription_item`.
@mauricioabreu
mauricioabreuforce-pushed
the
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
branch
from
00edd67 to
3c6cbe4CompareSeptember 16, 2025 17:42
@mauricioabreumauricioabreu
changed the title
chore(billing): Clean up deprecated attributechore(clerk-js,types): Clean up deprecated attributeSep 16, 2025
@mauricioabreu
mauricioabreu
enabled auto-merge (squash)
September 16, 2025 17:46
@pkg-pr-new
pkg-pr-newBot
commented
Sep 16, 2025

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@6788

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@6788

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@6788

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@6788

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@6788

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@6788

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@6788

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@6788

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@6788

@clerk/express
npm i https://pkg.pr.new/@clerk/express@6788

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@6788

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@6788

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@6788

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@6788

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@6788

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@6788

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@6788

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@6788

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@6788

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@6788

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@6788

@clerk/types
npm i https://pkg.pr.new/@clerk/types@6788

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@6788

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@6788

commit: 3c6cbe4
@mauricioabreu
mauricioabreu
merged commit 9d4a95c
into
mainSep 16, 2025

42 checks passed

@mauricioabreu
mauricioabreu
deleted the

mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi

branch
September 16, 2025 17:57
@clerk-cookieclerk-cookie
mentioned this pull request
Sep 16, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

+2 more reviewers

@panteliselefpanteliselefpanteliselef approved these changes
@l-armstrongl-armstrongl-armstrong approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

clerk-jstypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@mauricioabreu@l-armstrong@panteliselef@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
chore(clerk-js,types): Clean up deprecated attribute by mauricioabreu · Pull Request #6788 · clerk/javascript · GitHub
Skip to content
chore(clerk-js,types): Clean up deprecated attribute - #6788
Merged
mauricioabreu merged 1 commit into
mainfrom 
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
Sep 16, 2025
Merged
chore(clerk-js,types): Clean up deprecated attribute#6788
mauricioabreu merged 1 commit into
mainfrom 
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
Conversation
@mauricioabreu
@mauricioabreumauricioabreu
commented
Sep 16, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
This commit removes the subscription attribute from Billing structs. We deprecated this attribute a few weeks ago, and now it's time to remove it in-favor of subscription_item.
Description
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Refactor
    • Removed a deprecated Billing attribute; use subscriptionItem going forward. Update any integrations referencing the old subscription field to ensure compatibility.
  • Chores
    • Published minor package updates to reflect the removal across client and type packages.
@changeset-bot
changeset-botBot
commented
Sep 16, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 3c6cbe4
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 22 packages
NameType
@clerk/clerk-jsMinor
@clerk/typesMinor
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Sep 16, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentSep 16, 2025 5:43pm
@coderabbitai
coderabbitaiBot
commented
Sep 16, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
Removes the deprecated subscription field from CommercePayment in runtime and types, updates JSON parsing to stop assigning it, and adds a changeset bumping @clerk/clerk-js and @clerk/types documenting the Billing Beta removal.
Changes
Cohort / File(s)Summary of Changes
Release metadata
\.changeset/seven-buses-teach.md		Adds a changeset recording minor bumps for @clerk/clerk-js and @clerk/types and noting the removal of the deprecated Billing subscription attribute.
Runtime resource update
packages/clerk-js/src/core/resources/CommercePayment.ts		Removes the public subscription property and its assignment during JSON parsing; retains subscriptionItem mapping from data.subscription_item.
Types API update
packages/types/src/commerce.ts		Removes the deprecated subscription property from CommercePaymentResource; subscriptionItem remains as the public field.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
I nibbled old fields from the meadow of types,

Snipped a subscription, trimmed legacy stripes.

Now payments hop lightly with one tidy item—

Clean burrows ahead, no deprecated chime.

Thump-thump! Minor bumps, and onward I bound. 🐇✨
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe title accurately and concisely describes the main change: cleaning up a deprecated attribute in the clerk-js and types packages, which matches the PR's removal of the deprecated subscription field; it uses conventional-commit style and is clear for a reviewer scanning history.
Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  •  📝 Generate Docstrings
🧪 Generate unit tests
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
📜 Recent review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
  • Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📥 Commits
Reviewing files that changed from the base of the PR and between 00edd67 and 3c6cbe4.
📒 Files selected for processing (3)
  • .changeset/seven-buses-teach.md (1 hunks)
  • packages/clerk-js/src/core/resources/CommercePayment.ts (0 hunks)
  • packages/types/src/commerce.ts (0 hunks)
💤 Files with no reviewable changes (2)
  • packages/clerk-js/src/core/resources/CommercePayment.ts
  • packages/types/src/commerce.ts
✅ Files skipped from review due to trivial changes (1)
  • .changeset/seven-buses-teach.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
Tip
👮 Agentic pre-merge checks are now available in preview!
Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.
Please see the documentation for more information.
Example:
reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"mode: "warning"instructions: | Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).
Please share your feedback with us on this Discord post.
Comment @coderabbitai help to get the list of available commands and usage tips.
@mauricioabreumauricioabreu
changed the title
chore(billing): Clean up unused subscription attributechore(billing): Clean up unused deprecated attributeSep 16, 2025
@mauricioabreu
mauricioabreuforce-pushed
the
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
branch
from
02337fb to
3b2dabeCompareSeptember 16, 2025 15:59
@mauricioabreumauricioabreu
changed the title
chore(billing): Clean up unused deprecated attributechore(billing): Clean up deprecated attributeSep 16, 2025
@mauricioabreu
mauricioabreuforce-pushed
the
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
branch
from
3b2dabe to
00edd67CompareSeptember 16, 2025 16:07
@mauricioabreu
mauricioabreu
marked this pull request as ready for review
September 16, 2025 16:07
coderabbitai[bot]
coderabbitaiBot
reviewed
Sep 16, 2025
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🧹 Nitpick comments (1)
.changeset/seven-buses-teach.md (1)
6-6: Expand the changeset body with a concise BREAKING + migration note.
Add explicit guidance so downstreams can migrate quickly; include the replacement field and JSON key rename.
Apply this diff:
-[Billing Beta] Remove deprecated `subscription` attribute from Billing+[Billing Beta][BREAKING] Remove deprecated `subscription` attribute from Billing.++Migration:+- Replace `subscription` with `subscriptionItem` in code.+- If parsing raw JSON, use `subscription_item` (was `subscription`).+- No other shape changes expected; nullability matches `subscriptionItem`.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
  • Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📥 Commits
Reviewing files that changed from the base of the PR and between 8bb283b and 00edd67.
📒 Files selected for processing (3)
  • .changeset/seven-buses-teach.md (1 hunks)
  • packages/clerk-js/src/core/resources/CommercePayment.ts (0 hunks)
  • packages/types/src/commerce.ts (0 hunks)
💤 Files with no reviewable changes (2)
  • packages/types/src/commerce.ts
  • packages/clerk-js/src/core/resources/CommercePayment.ts
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Automated releases must use Changesets.
Files:
  • .changeset/seven-buses-teach.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
.changeset/seven-buses-teach.md (1)
1-6: Sanity‑check repo for leftover references to subscription
Automated rg run was inconclusive ("No files were searched"). Re-run locally and paste the output of one of these checks:
git grep -n 'subscription' || true
rg --debug -n --hidden -uu -C2 '\bsubscription\b' || true

Comment thread.changeset/seven-buses-teach.md
@l-armstrong
l-armstrong
commented
Sep 16, 2025

Copy link


Copy Markdown

Contributor
There's no backend code that depends on this field?
@mauricioabreu
chore(clerk-js,types): Clean up deprecated subscription attribute
3c6cbe4
This commit removes the `subscription` attribute from Billing structs.
We deprecated this attribute a few weeks ago, and now it's time to
remove it in-favor of `subscription_item`.
@mauricioabreu
mauricioabreuforce-pushed
the
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
branch
from
00edd67 to
3c6cbe4CompareSeptember 16, 2025 17:42
@mauricioabreumauricioabreu
changed the title
chore(billing): Clean up deprecated attributechore(clerk-js,types): Clean up deprecated attributeSep 16, 2025
@mauricioabreu
mauricioabreu
enabled auto-merge (squash)
September 16, 2025 17:46
@pkg-pr-new
pkg-pr-newBot
commented
Sep 16, 2025

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@6788

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@6788

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@6788

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@6788

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@6788

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@6788

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@6788

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@6788

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@6788

@clerk/express
npm i https://pkg.pr.new/@clerk/express@6788

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@6788

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@6788

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@6788

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@6788

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@6788

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@6788

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@6788

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@6788

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@6788

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@6788

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@6788

@clerk/types
npm i https://pkg.pr.new/@clerk/types@6788

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@6788

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@6788

commit: 3c6cbe4
@mauricioabreu
mauricioabreu
merged commit 9d4a95c
into
mainSep 16, 2025

42 checks passed

@mauricioabreu
mauricioabreu
deleted the

mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi

branch
September 16, 2025 17:57
@clerk-cookieclerk-cookie
mentioned this pull request
Sep 16, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

+2 more reviewers

@panteliselefpanteliselefpanteliselef approved these changes
@l-armstrongl-armstrongl-armstrong approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

clerk-jstypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@mauricioabreu@l-armstrong@panteliselef@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore(clerk-js,types): Clean up deprecated attribute by mauricioabreu · Pull Request #6788 · clerk/javascript · GitHub
Skip to content
chore(clerk-js,types): Clean up deprecated attribute - #6788
Merged
mauricioabreu merged 1 commit into
mainfrom 
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
Sep 16, 2025
Merged
chore(clerk-js,types): Clean up deprecated attribute#6788
mauricioabreu merged 1 commit into
mainfrom 
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
Conversation
@mauricioabreu
@mauricioabreumauricioabreu
commented
Sep 16, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
This commit removes the subscription attribute from Billing structs. We deprecated this attribute a few weeks ago, and now it's time to remove it in-favor of subscription_item.
Description
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Refactor
    • Removed a deprecated Billing attribute; use subscriptionItem going forward. Update any integrations referencing the old subscription field to ensure compatibility.
  • Chores
    • Published minor package updates to reflect the removal across client and type packages.
@changeset-bot
changeset-botBot
commented
Sep 16, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 3c6cbe4
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 22 packages
NameType
@clerk/clerk-jsMinor
@clerk/typesMinor
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Sep 16, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentSep 16, 2025 5:43pm
@coderabbitai
coderabbitaiBot
commented
Sep 16, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
Removes the deprecated subscription field from CommercePayment in runtime and types, updates JSON parsing to stop assigning it, and adds a changeset bumping @clerk/clerk-js and @clerk/types documenting the Billing Beta removal.
Changes
Cohort / File(s)Summary of Changes
Release metadata
\.changeset/seven-buses-teach.md		Adds a changeset recording minor bumps for @clerk/clerk-js and @clerk/types and noting the removal of the deprecated Billing subscription attribute.
Runtime resource update
packages/clerk-js/src/core/resources/CommercePayment.ts		Removes the public subscription property and its assignment during JSON parsing; retains subscriptionItem mapping from data.subscription_item.
Types API update
packages/types/src/commerce.ts		Removes the deprecated subscription property from CommercePaymentResource; subscriptionItem remains as the public field.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
I nibbled old fields from the meadow of types,

Snipped a subscription, trimmed legacy stripes.

Now payments hop lightly with one tidy item—

Clean burrows ahead, no deprecated chime.

Thump-thump! Minor bumps, and onward I bound. 🐇✨
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe title accurately and concisely describes the main change: cleaning up a deprecated attribute in the clerk-js and types packages, which matches the PR's removal of the deprecated subscription field; it uses conventional-commit style and is clear for a reviewer scanning history.
Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  •  📝 Generate Docstrings
🧪 Generate unit tests
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
📜 Recent review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
  • Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📥 Commits
Reviewing files that changed from the base of the PR and between 00edd67 and 3c6cbe4.
📒 Files selected for processing (3)
  • .changeset/seven-buses-teach.md (1 hunks)
  • packages/clerk-js/src/core/resources/CommercePayment.ts (0 hunks)
  • packages/types/src/commerce.ts (0 hunks)
💤 Files with no reviewable changes (2)
  • packages/clerk-js/src/core/resources/CommercePayment.ts
  • packages/types/src/commerce.ts
✅ Files skipped from review due to trivial changes (1)
  • .changeset/seven-buses-teach.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
Tip
👮 Agentic pre-merge checks are now available in preview!
Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.
Please see the documentation for more information.
Example:
reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"mode: "warning"instructions: | Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).
Please share your feedback with us on this Discord post.
Comment @coderabbitai help to get the list of available commands and usage tips.
@mauricioabreumauricioabreu
changed the title
chore(billing): Clean up unused subscription attributechore(billing): Clean up unused deprecated attributeSep 16, 2025
@mauricioabreu
mauricioabreuforce-pushed
the
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
branch
from
02337fb to
3b2dabeCompareSeptember 16, 2025 15:59
@mauricioabreumauricioabreu
changed the title
chore(billing): Clean up unused deprecated attributechore(billing): Clean up deprecated attributeSep 16, 2025
@mauricioabreu
mauricioabreuforce-pushed
the
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
branch
from
3b2dabe to
00edd67CompareSeptember 16, 2025 16:07
@mauricioabreu
mauricioabreu
marked this pull request as ready for review
September 16, 2025 16:07
coderabbitai[bot]
coderabbitaiBot
reviewed
Sep 16, 2025
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🧹 Nitpick comments (1)
.changeset/seven-buses-teach.md (1)
6-6: Expand the changeset body with a concise BREAKING + migration note.
Add explicit guidance so downstreams can migrate quickly; include the replacement field and JSON key rename.
Apply this diff:
-[Billing Beta] Remove deprecated `subscription` attribute from Billing+[Billing Beta][BREAKING] Remove deprecated `subscription` attribute from Billing.++Migration:+- Replace `subscription` with `subscriptionItem` in code.+- If parsing raw JSON, use `subscription_item` (was `subscription`).+- No other shape changes expected; nullability matches `subscriptionItem`.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
  • Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📥 Commits
Reviewing files that changed from the base of the PR and between 8bb283b and 00edd67.
📒 Files selected for processing (3)
  • .changeset/seven-buses-teach.md (1 hunks)
  • packages/clerk-js/src/core/resources/CommercePayment.ts (0 hunks)
  • packages/types/src/commerce.ts (0 hunks)
💤 Files with no reviewable changes (2)
  • packages/types/src/commerce.ts
  • packages/clerk-js/src/core/resources/CommercePayment.ts
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Automated releases must use Changesets.
Files:
  • .changeset/seven-buses-teach.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
.changeset/seven-buses-teach.md (1)
1-6: Sanity‑check repo for leftover references to subscription
Automated rg run was inconclusive ("No files were searched"). Re-run locally and paste the output of one of these checks:
git grep -n 'subscription' || true
rg --debug -n --hidden -uu -C2 '\bsubscription\b' || true

Comment thread.changeset/seven-buses-teach.md
@l-armstrong
l-armstrong
commented
Sep 16, 2025

Copy link


Copy Markdown

Contributor
There's no backend code that depends on this field?
@mauricioabreu
chore(clerk-js,types): Clean up deprecated subscription attribute
3c6cbe4
This commit removes the `subscription` attribute from Billing structs.
We deprecated this attribute a few weeks ago, and now it's time to
remove it in-favor of `subscription_item`.
@mauricioabreu
mauricioabreuforce-pushed
the
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
branch
from
00edd67 to
3c6cbe4CompareSeptember 16, 2025 17:42
@mauricioabreumauricioabreu
changed the title
chore(billing): Clean up deprecated attributechore(clerk-js,types): Clean up deprecated attributeSep 16, 2025
@mauricioabreu
mauricioabreu
enabled auto-merge (squash)
September 16, 2025 17:46
@pkg-pr-new
pkg-pr-newBot
commented
Sep 16, 2025

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@6788

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@6788

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@6788

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@6788

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@6788

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@6788

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@6788

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@6788

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@6788

@clerk/express
npm i https://pkg.pr.new/@clerk/express@6788

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@6788

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@6788

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@6788

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@6788

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@6788

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@6788

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@6788

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@6788

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@6788

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@6788

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@6788

@clerk/types
npm i https://pkg.pr.new/@clerk/types@6788

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@6788

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@6788

commit: 3c6cbe4
@mauricioabreu
mauricioabreu
merged commit 9d4a95c
into
mainSep 16, 2025

42 checks passed

@mauricioabreu
mauricioabreu
deleted the

mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi

branch
September 16, 2025 17:57
@clerk-cookieclerk-cookie
mentioned this pull request
Sep 16, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

+2 more reviewers

@panteliselefpanteliselefpanteliselef approved these changes
@l-armstrongl-armstrongl-armstrong approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

clerk-jstypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@mauricioabreu@l-armstrong@panteliselef@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore(clerk-js,types): Clean up deprecated attribute by mauricioabreu · Pull Request #6788 · clerk/javascript · GitHub
Skip to content
chore(clerk-js,types): Clean up deprecated attribute - #6788
Merged
mauricioabreu merged 1 commit into
mainfrom 
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
Sep 16, 2025
Merged
chore(clerk-js,types): Clean up deprecated attribute#6788
mauricioabreu merged 1 commit into
mainfrom 
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
Conversation
@mauricioabreu
@mauricioabreumauricioabreu
commented
Sep 16, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
This commit removes the subscription attribute from Billing structs. We deprecated this attribute a few weeks ago, and now it's time to remove it in-favor of subscription_item.
Description
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Refactor
    • Removed a deprecated Billing attribute; use subscriptionItem going forward. Update any integrations referencing the old subscription field to ensure compatibility.
  • Chores
    • Published minor package updates to reflect the removal across client and type packages.
@changeset-bot
changeset-botBot
commented
Sep 16, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 3c6cbe4
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 22 packages
NameType
@clerk/clerk-jsMinor
@clerk/typesMinor
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Sep 16, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentSep 16, 2025 5:43pm
@coderabbitai
coderabbitaiBot
commented
Sep 16, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
Removes the deprecated subscription field from CommercePayment in runtime and types, updates JSON parsing to stop assigning it, and adds a changeset bumping @clerk/clerk-js and @clerk/types documenting the Billing Beta removal.
Changes
Cohort / File(s)Summary of Changes
Release metadata
\.changeset/seven-buses-teach.md		Adds a changeset recording minor bumps for @clerk/clerk-js and @clerk/types and noting the removal of the deprecated Billing subscription attribute.
Runtime resource update
packages/clerk-js/src/core/resources/CommercePayment.ts		Removes the public subscription property and its assignment during JSON parsing; retains subscriptionItem mapping from data.subscription_item.
Types API update
packages/types/src/commerce.ts		Removes the deprecated subscription property from CommercePaymentResource; subscriptionItem remains as the public field.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
I nibbled old fields from the meadow of types,

Snipped a subscription, trimmed legacy stripes.

Now payments hop lightly with one tidy item—

Clean burrows ahead, no deprecated chime.

Thump-thump! Minor bumps, and onward I bound. 🐇✨
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe title accurately and concisely describes the main change: cleaning up a deprecated attribute in the clerk-js and types packages, which matches the PR's removal of the deprecated subscription field; it uses conventional-commit style and is clear for a reviewer scanning history.
Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  •  📝 Generate Docstrings
🧪 Generate unit tests
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
📜 Recent review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
  • Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📥 Commits
Reviewing files that changed from the base of the PR and between 00edd67 and 3c6cbe4.
📒 Files selected for processing (3)
  • .changeset/seven-buses-teach.md (1 hunks)
  • packages/clerk-js/src/core/resources/CommercePayment.ts (0 hunks)
  • packages/types/src/commerce.ts (0 hunks)
💤 Files with no reviewable changes (2)
  • packages/clerk-js/src/core/resources/CommercePayment.ts
  • packages/types/src/commerce.ts
✅ Files skipped from review due to trivial changes (1)
  • .changeset/seven-buses-teach.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
Tip
👮 Agentic pre-merge checks are now available in preview!
Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.
Please see the documentation for more information.
Example:
reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"mode: "warning"instructions: | Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).
Please share your feedback with us on this Discord post.
Comment @coderabbitai help to get the list of available commands and usage tips.
@mauricioabreumauricioabreu
changed the title
chore(billing): Clean up unused subscription attributechore(billing): Clean up unused deprecated attributeSep 16, 2025
@mauricioabreu
mauricioabreuforce-pushed
the
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
branch
from
02337fb to
3b2dabeCompareSeptember 16, 2025 15:59
@mauricioabreumauricioabreu
changed the title
chore(billing): Clean up unused deprecated attributechore(billing): Clean up deprecated attributeSep 16, 2025
@mauricioabreu
mauricioabreuforce-pushed
the
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
branch
from
3b2dabe to
00edd67CompareSeptember 16, 2025 16:07
@mauricioabreu
mauricioabreu
marked this pull request as ready for review
September 16, 2025 16:07
coderabbitai[bot]
coderabbitaiBot
reviewed
Sep 16, 2025
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🧹 Nitpick comments (1)
.changeset/seven-buses-teach.md (1)
6-6: Expand the changeset body with a concise BREAKING + migration note.
Add explicit guidance so downstreams can migrate quickly; include the replacement field and JSON key rename.
Apply this diff:
-[Billing Beta] Remove deprecated `subscription` attribute from Billing+[Billing Beta][BREAKING] Remove deprecated `subscription` attribute from Billing.++Migration:+- Replace `subscription` with `subscriptionItem` in code.+- If parsing raw JSON, use `subscription_item` (was `subscription`).+- No other shape changes expected; nullability matches `subscriptionItem`.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
  • Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📥 Commits
Reviewing files that changed from the base of the PR and between 8bb283b and 00edd67.
📒 Files selected for processing (3)
  • .changeset/seven-buses-teach.md (1 hunks)
  • packages/clerk-js/src/core/resources/CommercePayment.ts (0 hunks)
  • packages/types/src/commerce.ts (0 hunks)
💤 Files with no reviewable changes (2)
  • packages/types/src/commerce.ts
  • packages/clerk-js/src/core/resources/CommercePayment.ts
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Automated releases must use Changesets.
Files:
  • .changeset/seven-buses-teach.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
.changeset/seven-buses-teach.md (1)
1-6: Sanity‑check repo for leftover references to subscription
Automated rg run was inconclusive ("No files were searched"). Re-run locally and paste the output of one of these checks:
git grep -n 'subscription' || true
rg --debug -n --hidden -uu -C2 '\bsubscription\b' || true

Comment thread.changeset/seven-buses-teach.md
@l-armstrong
l-armstrong
commented
Sep 16, 2025

Copy link


Copy Markdown

Contributor
There's no backend code that depends on this field?
@mauricioabreu
chore(clerk-js,types): Clean up deprecated subscription attribute
3c6cbe4
This commit removes the `subscription` attribute from Billing structs.
We deprecated this attribute a few weeks ago, and now it's time to
remove it in-favor of `subscription_item`.
@mauricioabreu
mauricioabreuforce-pushed
the
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
branch
from
00edd67 to
3c6cbe4CompareSeptember 16, 2025 17:42
@mauricioabreumauricioabreu
changed the title
chore(billing): Clean up deprecated attributechore(clerk-js,types): Clean up deprecated attributeSep 16, 2025
@mauricioabreu
mauricioabreu
enabled auto-merge (squash)
September 16, 2025 17:46
@pkg-pr-new
pkg-pr-newBot
commented
Sep 16, 2025

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@6788

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@6788

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@6788

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@6788

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@6788

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@6788

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@6788

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@6788

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@6788

@clerk/express
npm i https://pkg.pr.new/@clerk/express@6788

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@6788

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@6788

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@6788

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@6788

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@6788

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@6788

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@6788

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@6788

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@6788

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@6788

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@6788

@clerk/types
npm i https://pkg.pr.new/@clerk/types@6788

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@6788

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@6788

commit: 3c6cbe4
@mauricioabreu
mauricioabreu
merged commit 9d4a95c
into
mainSep 16, 2025

42 checks passed

@mauricioabreu
mauricioabreu
deleted the

mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi

branch
September 16, 2025 17:57
@clerk-cookieclerk-cookie
mentioned this pull request
Sep 16, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

+2 more reviewers

@panteliselefpanteliselefpanteliselef approved these changes
@l-armstrongl-armstrongl-armstrong approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

clerk-jstypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@mauricioabreu@l-armstrong@panteliselef@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
chore(clerk-js,types): Clean up deprecated attribute by mauricioabreu · Pull Request #6788 · clerk/javascript · GitHub
Skip to content
chore(clerk-js,types): Clean up deprecated attribute - #6788
Merged
mauricioabreu merged 1 commit into
mainfrom 
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
Sep 16, 2025
Merged
chore(clerk-js,types): Clean up deprecated attribute#6788
mauricioabreu merged 1 commit into
mainfrom 
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
Conversation
@mauricioabreu
@mauricioabreumauricioabreu
commented
Sep 16, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
This commit removes the subscription attribute from Billing structs. We deprecated this attribute a few weeks ago, and now it's time to remove it in-favor of subscription_item.
Description
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Refactor
    • Removed a deprecated Billing attribute; use subscriptionItem going forward. Update any integrations referencing the old subscription field to ensure compatibility.
  • Chores
    • Published minor package updates to reflect the removal across client and type packages.
@changeset-bot
changeset-botBot
commented
Sep 16, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 3c6cbe4
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 22 packages
NameType
@clerk/clerk-jsMinor
@clerk/typesMinor
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Sep 16, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentSep 16, 2025 5:43pm
@coderabbitai
coderabbitaiBot
commented
Sep 16, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
Removes the deprecated subscription field from CommercePayment in runtime and types, updates JSON parsing to stop assigning it, and adds a changeset bumping @clerk/clerk-js and @clerk/types documenting the Billing Beta removal.
Changes
Cohort / File(s)Summary of Changes
Release metadata
\.changeset/seven-buses-teach.md		Adds a changeset recording minor bumps for @clerk/clerk-js and @clerk/types and noting the removal of the deprecated Billing subscription attribute.
Runtime resource update
packages/clerk-js/src/core/resources/CommercePayment.ts		Removes the public subscription property and its assignment during JSON parsing; retains subscriptionItem mapping from data.subscription_item.
Types API update
packages/types/src/commerce.ts		Removes the deprecated subscription property from CommercePaymentResource; subscriptionItem remains as the public field.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
I nibbled old fields from the meadow of types,

Snipped a subscription, trimmed legacy stripes.

Now payments hop lightly with one tidy item—

Clean burrows ahead, no deprecated chime.

Thump-thump! Minor bumps, and onward I bound. 🐇✨
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe title accurately and concisely describes the main change: cleaning up a deprecated attribute in the clerk-js and types packages, which matches the PR's removal of the deprecated subscription field; it uses conventional-commit style and is clear for a reviewer scanning history.
Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  •  📝 Generate Docstrings
🧪 Generate unit tests
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
📜 Recent review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
  • Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📥 Commits
Reviewing files that changed from the base of the PR and between 00edd67 and 3c6cbe4.
📒 Files selected for processing (3)
  • .changeset/seven-buses-teach.md (1 hunks)
  • packages/clerk-js/src/core/resources/CommercePayment.ts (0 hunks)
  • packages/types/src/commerce.ts (0 hunks)
💤 Files with no reviewable changes (2)
  • packages/clerk-js/src/core/resources/CommercePayment.ts
  • packages/types/src/commerce.ts
✅ Files skipped from review due to trivial changes (1)
  • .changeset/seven-buses-teach.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
Tip
👮 Agentic pre-merge checks are now available in preview!
Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.
Please see the documentation for more information.
Example:
reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"mode: "warning"instructions: | Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).
Please share your feedback with us on this Discord post.
Comment @coderabbitai help to get the list of available commands and usage tips.
@mauricioabreumauricioabreu
changed the title
chore(billing): Clean up unused subscription attributechore(billing): Clean up unused deprecated attributeSep 16, 2025
@mauricioabreu
mauricioabreuforce-pushed
the
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
branch
from
02337fb to
3b2dabeCompareSeptember 16, 2025 15:59
@mauricioabreumauricioabreu
changed the title
chore(billing): Clean up unused deprecated attributechore(billing): Clean up deprecated attributeSep 16, 2025
@mauricioabreu
mauricioabreuforce-pushed
the
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
branch
from
3b2dabe to
00edd67CompareSeptember 16, 2025 16:07
@mauricioabreu
mauricioabreu
marked this pull request as ready for review
September 16, 2025 16:07
coderabbitai[bot]
coderabbitaiBot
reviewed
Sep 16, 2025
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🧹 Nitpick comments (1)
.changeset/seven-buses-teach.md (1)
6-6: Expand the changeset body with a concise BREAKING + migration note.
Add explicit guidance so downstreams can migrate quickly; include the replacement field and JSON key rename.
Apply this diff:
-[Billing Beta] Remove deprecated `subscription` attribute from Billing+[Billing Beta][BREAKING] Remove deprecated `subscription` attribute from Billing.++Migration:+- Replace `subscription` with `subscriptionItem` in code.+- If parsing raw JSON, use `subscription_item` (was `subscription`).+- No other shape changes expected; nullability matches `subscriptionItem`.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
  • Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📥 Commits
Reviewing files that changed from the base of the PR and between 8bb283b and 00edd67.
📒 Files selected for processing (3)
  • .changeset/seven-buses-teach.md (1 hunks)
  • packages/clerk-js/src/core/resources/CommercePayment.ts (0 hunks)
  • packages/types/src/commerce.ts (0 hunks)
💤 Files with no reviewable changes (2)
  • packages/types/src/commerce.ts
  • packages/clerk-js/src/core/resources/CommercePayment.ts
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Automated releases must use Changesets.
Files:
  • .changeset/seven-buses-teach.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
.changeset/seven-buses-teach.md (1)
1-6: Sanity‑check repo for leftover references to subscription
Automated rg run was inconclusive ("No files were searched"). Re-run locally and paste the output of one of these checks:
git grep -n 'subscription' || true
rg --debug -n --hidden -uu -C2 '\bsubscription\b' || true

Comment thread.changeset/seven-buses-teach.md
@l-armstrong
l-armstrong
commented
Sep 16, 2025

Copy link


Copy Markdown

Contributor
There's no backend code that depends on this field?
@mauricioabreu
chore(clerk-js,types): Clean up deprecated subscription attribute
3c6cbe4
This commit removes the `subscription` attribute from Billing structs.
We deprecated this attribute a few weeks ago, and now it's time to
remove it in-favor of `subscription_item`.
@mauricioabreu
mauricioabreuforce-pushed
the
mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi
branch
from
00edd67 to
3c6cbe4CompareSeptember 16, 2025 17:42
@mauricioabreumauricioabreu
changed the title
chore(billing): Clean up deprecated attributechore(clerk-js,types): Clean up deprecated attributeSep 16, 2025
@mauricioabreu
mauricioabreu
enabled auto-merge (squash)
September 16, 2025 17:46
@pkg-pr-new
pkg-pr-newBot
commented
Sep 16, 2025

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@6788

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@6788

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@6788

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@6788

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@6788

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@6788

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@6788

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@6788

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@6788

@clerk/express
npm i https://pkg.pr.new/@clerk/express@6788

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@6788

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@6788

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@6788

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@6788

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@6788

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@6788

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@6788

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@6788

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@6788

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@6788

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@6788

@clerk/types
npm i https://pkg.pr.new/@clerk/types@6788

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@6788

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@6788

commit: 3c6cbe4
@mauricioabreu
mauricioabreu
merged commit 9d4a95c
into
mainSep 16, 2025

42 checks passed

@mauricioabreu
mauricioabreu
deleted the

mauricio-antunes/bill-1016-clean-up-unused-subscription-values-from-fapidapi

branch
September 16, 2025 17:57
@clerk-cookieclerk-cookie
mentioned this pull request
Sep 16, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

+2 more reviewers

@panteliselefpanteliselefpanteliselef approved these changes
@l-armstrongl-armstrongl-armstrong approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

clerk-jstypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@mauricioabreu@l-armstrong@panteliselef@clerk-cookie