chore(repo): Use node@20 in CI - #6848

Merged
jacekradko merged 2 commits into
vincent-and-the-doctorfrom
chore/upgrade-node-version-in-ci
Oct 6, 2025
Merged

chore(repo): Use node@20 in CI#6848
jacekradko merged 2 commits into
vincent-and-the-doctorfrom
chore/upgrade-node-version-in-ci

Conversation

@jacekradko

@jacekradkojacekradko commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

Description

Node@18 is past the EOL date so switching to Node@20 in CI

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Tests

    • Updated continuous integration to run unit tests on Node.js 20, aligning automated test coverage with the latest LTS environment.
  • Chores

    • Refreshed workflow labeling/comments to reflect Node.js 20 in test runs.
  • Notes

    • No user-facing changes in this release; these updates improve test infrastructure and consistency across environments.

@changeset-bot

changeset-botBot commented Sep 24, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: fe1f7d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitaiBot commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Updates CI configuration to run unit tests on Node.js 20 instead of 18 and adjusts a related comment in the workflow file.

Changes

Cohort / File(s)Summary
CI workflow update
.github/workflows/ci.yml
Bumps unit-tests matrix node-version from 18 to 20; updates initialization step comment to reflect “Unit Tests (20)”.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I thump my paws—version twenty, hooray!
Pipelines hop faster in a shiny new way.
From burrow to build, the carrots align,
Tests nibble on bytes, everything’s fine.
With a twitch of my whiskers, CI’s aglow—
Onward we bound where green checks grow! 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe title succinctly states the primary change—updating CI to use Node 20—and uses a conventional "chore(repo)" prefix, making it specific, concise, and directly aligned with the PR's content.
Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel

vercelBot commented Sep 24, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentOct 6, 2025 1:19pm

@pkg-pr-new

pkg-pr-newBot commented Sep 24, 2025

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6848

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6848

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6848

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6848

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6848

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6848

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6848

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6848

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6848

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6848

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6848

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6848

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6848

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6848

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6848

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6848

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6848

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6848

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6848

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6848

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6848

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6848

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6848

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6848

commit: fe1f7d8

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/ci.yml (2)

226-231: Fix misleading cache comment: matrix also runs on Node 22.

Comment implies a single “Unit Tests (20)” run name, but this job runs on 20 and 22. Clarify to avoid cache/key confusion.

- # Ensures that all builds are cached appropriately with a consistent run name `Unit Tests (20)`.+ # Ensures builds are cached appropriately; run name includes the Node version+ # (e.g., `Unit Tests (20)` / `Unit Tests (22)`).

210-213: LTS lane moved to Node 20 — sweep found many Node 18 references (mostly node: ">=18.17.0") — OK with Node 20; change only if you want to raise the project minimum to >=20.

  • Search found engine fields and README prerequisites in root package.json and many packages/templates (packages//package.json, integration/templates//package.json, playground//package.json) and docs (packages//README.md, packages/upgrade/**). pnpm-lock entries reflect dependency engines.
  • Action: if you intend to bump the repo minimum to Node 20, update engines and docs (root + packages + templates) and any tool/runtime pins (.nvmrc/.tool-versions); otherwise this CI change is safe to approve.
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a39f2fc and 2a81b25.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.github/workflows/*.yml

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

CI/CD must be configured with GitHub Actions.

Files:

  • .github/workflows/ci.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Build Packages
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan

@jacekradko
jacekradko changed the base branch from main to vincent-and-the-doctorOctober 6, 2025 13:17
@jacekradko
jacekradko merged commit 43bfbd0 into vincent-and-the-doctorOct 6, 2025
38 checks passed
@jacekradko
jacekradko deleted the chore/upgrade-node-version-in-ci branch October 6, 2025 15:20
jacekradko added a commit that referenced this pull request Oct 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jacekradko@dstaley@panteliselef@clerk-cookie
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

chore(repo): Use node@20 in CI - #6848

Merged
jacekradko merged 2 commits into
vincent-and-the-doctorfrom
chore/upgrade-node-version-in-ci
Oct 6, 2025
Merged

chore(repo): Use node@20 in CI#6848
jacekradko merged 2 commits into
vincent-and-the-doctorfrom
chore/upgrade-node-version-in-ci

Conversation

@jacekradko

@jacekradkojacekradko commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

Description

Node@18 is past the EOL date so switching to Node@20 in CI

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Tests

    • Updated continuous integration to run unit tests on Node.js 20, aligning automated test coverage with the latest LTS environment.
  • Chores

    • Refreshed workflow labeling/comments to reflect Node.js 20 in test runs.
  • Notes

    • No user-facing changes in this release; these updates improve test infrastructure and consistency across environments.

@changeset-bot

changeset-botBot commented Sep 24, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: fe1f7d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitaiBot commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Updates CI configuration to run unit tests on Node.js 20 instead of 18 and adjusts a related comment in the workflow file.

Changes

Cohort / File(s)Summary
CI workflow update
.github/workflows/ci.yml
Bumps unit-tests matrix node-version from 18 to 20; updates initialization step comment to reflect “Unit Tests (20)”.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I thump my paws—version twenty, hooray!
Pipelines hop faster in a shiny new way.
From burrow to build, the carrots align,
Tests nibble on bytes, everything’s fine.
With a twitch of my whiskers, CI’s aglow—
Onward we bound where green checks grow! 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe title succinctly states the primary change—updating CI to use Node 20—and uses a conventional "chore(repo)" prefix, making it specific, concise, and directly aligned with the PR's content.
Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel

vercelBot commented Sep 24, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentOct 6, 2025 1:19pm

@pkg-pr-new

pkg-pr-newBot commented Sep 24, 2025

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6848

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6848

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6848

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6848

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6848

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6848

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6848

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6848

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6848

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6848

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6848

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6848

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6848

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6848

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6848

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6848

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6848

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6848

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6848

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6848

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6848

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6848

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6848

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6848

commit: fe1f7d8

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/ci.yml (2)

226-231: Fix misleading cache comment: matrix also runs on Node 22.

Comment implies a single “Unit Tests (20)” run name, but this job runs on 20 and 22. Clarify to avoid cache/key confusion.

- # Ensures that all builds are cached appropriately with a consistent run name `Unit Tests (20)`.+ # Ensures builds are cached appropriately; run name includes the Node version+ # (e.g., `Unit Tests (20)` / `Unit Tests (22)`).

210-213: LTS lane moved to Node 20 — sweep found many Node 18 references (mostly node: ">=18.17.0") — OK with Node 20; change only if you want to raise the project minimum to >=20.

  • Search found engine fields and README prerequisites in root package.json and many packages/templates (packages//package.json, integration/templates//package.json, playground//package.json) and docs (packages//README.md, packages/upgrade/**). pnpm-lock entries reflect dependency engines.
  • Action: if you intend to bump the repo minimum to Node 20, update engines and docs (root + packages + templates) and any tool/runtime pins (.nvmrc/.tool-versions); otherwise this CI change is safe to approve.
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a39f2fc and 2a81b25.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.github/workflows/*.yml

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

CI/CD must be configured with GitHub Actions.

Files:

  • .github/workflows/ci.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Build Packages
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan

@jacekradko
jacekradko changed the base branch from main to vincent-and-the-doctorOctober 6, 2025 13:17
@jacekradko
jacekradko merged commit 43bfbd0 into vincent-and-the-doctorOct 6, 2025
38 checks passed
@jacekradko
jacekradko deleted the chore/upgrade-node-version-in-ci branch October 6, 2025 15:20
jacekradko added a commit that referenced this pull request Oct 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jacekradko@dstaley@panteliselef@clerk-cookie
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore(repo): Use node@20 in CI - #6848

Merged
jacekradko merged 2 commits into
vincent-and-the-doctorfrom
chore/upgrade-node-version-in-ci
Oct 6, 2025
Merged

chore(repo): Use node@20 in CI#6848
jacekradko merged 2 commits into
vincent-and-the-doctorfrom
chore/upgrade-node-version-in-ci

Conversation

@jacekradko

@jacekradkojacekradko commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

Description

Node@18 is past the EOL date so switching to Node@20 in CI

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Tests

    • Updated continuous integration to run unit tests on Node.js 20, aligning automated test coverage with the latest LTS environment.
  • Chores

    • Refreshed workflow labeling/comments to reflect Node.js 20 in test runs.
  • Notes

    • No user-facing changes in this release; these updates improve test infrastructure and consistency across environments.

@changeset-bot

changeset-botBot commented Sep 24, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: fe1f7d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitaiBot commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Updates CI configuration to run unit tests on Node.js 20 instead of 18 and adjusts a related comment in the workflow file.

Changes

Cohort / File(s)Summary
CI workflow update
.github/workflows/ci.yml
Bumps unit-tests matrix node-version from 18 to 20; updates initialization step comment to reflect “Unit Tests (20)”.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I thump my paws—version twenty, hooray!
Pipelines hop faster in a shiny new way.
From burrow to build, the carrots align,
Tests nibble on bytes, everything’s fine.
With a twitch of my whiskers, CI’s aglow—
Onward we bound where green checks grow! 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe title succinctly states the primary change—updating CI to use Node 20—and uses a conventional "chore(repo)" prefix, making it specific, concise, and directly aligned with the PR's content.
Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel

vercelBot commented Sep 24, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentOct 6, 2025 1:19pm

@pkg-pr-new

pkg-pr-newBot commented Sep 24, 2025

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6848

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6848

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6848

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6848

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6848

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6848

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6848

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6848

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6848

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6848

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6848

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6848

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6848

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6848

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6848

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6848

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6848

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6848

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6848

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6848

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6848

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6848

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6848

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6848

commit: fe1f7d8

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/ci.yml (2)

226-231: Fix misleading cache comment: matrix also runs on Node 22.

Comment implies a single “Unit Tests (20)” run name, but this job runs on 20 and 22. Clarify to avoid cache/key confusion.

- # Ensures that all builds are cached appropriately with a consistent run name `Unit Tests (20)`.+ # Ensures builds are cached appropriately; run name includes the Node version+ # (e.g., `Unit Tests (20)` / `Unit Tests (22)`).

210-213: LTS lane moved to Node 20 — sweep found many Node 18 references (mostly node: ">=18.17.0") — OK with Node 20; change only if you want to raise the project minimum to >=20.

  • Search found engine fields and README prerequisites in root package.json and many packages/templates (packages//package.json, integration/templates//package.json, playground//package.json) and docs (packages//README.md, packages/upgrade/**). pnpm-lock entries reflect dependency engines.
  • Action: if you intend to bump the repo minimum to Node 20, update engines and docs (root + packages + templates) and any tool/runtime pins (.nvmrc/.tool-versions); otherwise this CI change is safe to approve.
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a39f2fc and 2a81b25.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.github/workflows/*.yml

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

CI/CD must be configured with GitHub Actions.

Files:

  • .github/workflows/ci.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Build Packages
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan

@jacekradko
jacekradko changed the base branch from main to vincent-and-the-doctorOctober 6, 2025 13:17
@jacekradko
jacekradko merged commit 43bfbd0 into vincent-and-the-doctorOct 6, 2025
38 checks passed
@jacekradko
jacekradko deleted the chore/upgrade-node-version-in-ci branch October 6, 2025 15:20
jacekradko added a commit that referenced this pull request Oct 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jacekradko@dstaley@panteliselef@clerk-cookie
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore(repo): Use node@20 in CI - #6848

Merged
jacekradko merged 2 commits into
vincent-and-the-doctorfrom
chore/upgrade-node-version-in-ci
Oct 6, 2025
Merged

chore(repo): Use node@20 in CI#6848
jacekradko merged 2 commits into
vincent-and-the-doctorfrom
chore/upgrade-node-version-in-ci

Conversation

@jacekradko

@jacekradkojacekradko commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

Description

Node@18 is past the EOL date so switching to Node@20 in CI

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Tests

    • Updated continuous integration to run unit tests on Node.js 20, aligning automated test coverage with the latest LTS environment.
  • Chores

    • Refreshed workflow labeling/comments to reflect Node.js 20 in test runs.
  • Notes

    • No user-facing changes in this release; these updates improve test infrastructure and consistency across environments.

@changeset-bot

changeset-botBot commented Sep 24, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: fe1f7d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitaiBot commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Updates CI configuration to run unit tests on Node.js 20 instead of 18 and adjusts a related comment in the workflow file.

Changes

Cohort / File(s)Summary
CI workflow update
.github/workflows/ci.yml
Bumps unit-tests matrix node-version from 18 to 20; updates initialization step comment to reflect “Unit Tests (20)”.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I thump my paws—version twenty, hooray!
Pipelines hop faster in a shiny new way.
From burrow to build, the carrots align,
Tests nibble on bytes, everything’s fine.
With a twitch of my whiskers, CI’s aglow—
Onward we bound where green checks grow! 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe title succinctly states the primary change—updating CI to use Node 20—and uses a conventional "chore(repo)" prefix, making it specific, concise, and directly aligned with the PR's content.
Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel

vercelBot commented Sep 24, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentOct 6, 2025 1:19pm

@pkg-pr-new

pkg-pr-newBot commented Sep 24, 2025

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6848

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6848

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6848

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6848

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6848

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6848

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6848

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6848

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6848

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6848

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6848

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6848

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6848

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6848

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6848

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6848

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6848

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6848

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6848

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6848

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6848

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6848

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6848

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6848

commit: fe1f7d8

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/ci.yml (2)

226-231: Fix misleading cache comment: matrix also runs on Node 22.

Comment implies a single “Unit Tests (20)” run name, but this job runs on 20 and 22. Clarify to avoid cache/key confusion.

- # Ensures that all builds are cached appropriately with a consistent run name `Unit Tests (20)`.+ # Ensures builds are cached appropriately; run name includes the Node version+ # (e.g., `Unit Tests (20)` / `Unit Tests (22)`).

210-213: LTS lane moved to Node 20 — sweep found many Node 18 references (mostly node: ">=18.17.0") — OK with Node 20; change only if you want to raise the project minimum to >=20.

  • Search found engine fields and README prerequisites in root package.json and many packages/templates (packages//package.json, integration/templates//package.json, playground//package.json) and docs (packages//README.md, packages/upgrade/**). pnpm-lock entries reflect dependency engines.
  • Action: if you intend to bump the repo minimum to Node 20, update engines and docs (root + packages + templates) and any tool/runtime pins (.nvmrc/.tool-versions); otherwise this CI change is safe to approve.
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a39f2fc and 2a81b25.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.github/workflows/*.yml

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

CI/CD must be configured with GitHub Actions.

Files:

  • .github/workflows/ci.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Build Packages
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan

@jacekradko
jacekradko changed the base branch from main to vincent-and-the-doctorOctober 6, 2025 13:17
@jacekradko
jacekradko merged commit 43bfbd0 into vincent-and-the-doctorOct 6, 2025
38 checks passed
@jacekradko
jacekradko deleted the chore/upgrade-node-version-in-ci branch October 6, 2025 15:20
jacekradko added a commit that referenced this pull request Oct 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jacekradko@dstaley@panteliselef@clerk-cookie
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

chore(repo): Use node@20 in CI - #6848

Merged
jacekradko merged 2 commits into
vincent-and-the-doctorfrom
chore/upgrade-node-version-in-ci
Oct 6, 2025
Merged

chore(repo): Use node@20 in CI#6848
jacekradko merged 2 commits into
vincent-and-the-doctorfrom
chore/upgrade-node-version-in-ci

Conversation

@jacekradko

@jacekradkojacekradko commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

Description

Node@18 is past the EOL date so switching to Node@20 in CI

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Tests

    • Updated continuous integration to run unit tests on Node.js 20, aligning automated test coverage with the latest LTS environment.
  • Chores

    • Refreshed workflow labeling/comments to reflect Node.js 20 in test runs.
  • Notes

    • No user-facing changes in this release; these updates improve test infrastructure and consistency across environments.

@changeset-bot

changeset-botBot commented Sep 24, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: fe1f7d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitaiBot commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Updates CI configuration to run unit tests on Node.js 20 instead of 18 and adjusts a related comment in the workflow file.

Changes

Cohort / File(s)Summary
CI workflow update
.github/workflows/ci.yml
Bumps unit-tests matrix node-version from 18 to 20; updates initialization step comment to reflect “Unit Tests (20)”.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I thump my paws—version twenty, hooray!
Pipelines hop faster in a shiny new way.
From burrow to build, the carrots align,
Tests nibble on bytes, everything’s fine.
With a twitch of my whiskers, CI’s aglow—
Onward we bound where green checks grow! 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe title succinctly states the primary change—updating CI to use Node 20—and uses a conventional "chore(repo)" prefix, making it specific, concise, and directly aligned with the PR's content.
Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel

vercelBot commented Sep 24, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentOct 6, 2025 1:19pm

@pkg-pr-new

pkg-pr-newBot commented Sep 24, 2025

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6848

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6848

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6848

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6848

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6848

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6848

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6848

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6848

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6848

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6848

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6848

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6848

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6848

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6848

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6848

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6848

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6848

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6848

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6848

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6848

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6848

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6848

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6848

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6848

commit: fe1f7d8

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/ci.yml (2)

226-231: Fix misleading cache comment: matrix also runs on Node 22.

Comment implies a single “Unit Tests (20)” run name, but this job runs on 20 and 22. Clarify to avoid cache/key confusion.

- # Ensures that all builds are cached appropriately with a consistent run name `Unit Tests (20)`.+ # Ensures builds are cached appropriately; run name includes the Node version+ # (e.g., `Unit Tests (20)` / `Unit Tests (22)`).

210-213: LTS lane moved to Node 20 — sweep found many Node 18 references (mostly node: ">=18.17.0") — OK with Node 20; change only if you want to raise the project minimum to >=20.

  • Search found engine fields and README prerequisites in root package.json and many packages/templates (packages//package.json, integration/templates//package.json, playground//package.json) and docs (packages//README.md, packages/upgrade/**). pnpm-lock entries reflect dependency engines.
  • Action: if you intend to bump the repo minimum to Node 20, update engines and docs (root + packages + templates) and any tool/runtime pins (.nvmrc/.tool-versions); otherwise this CI change is safe to approve.
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a39f2fc and 2a81b25.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.github/workflows/*.yml

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

CI/CD must be configured with GitHub Actions.

Files:

  • .github/workflows/ci.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Build Packages
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan

@jacekradko
jacekradko changed the base branch from main to vincent-and-the-doctorOctober 6, 2025 13:17
@jacekradko
jacekradko merged commit 43bfbd0 into vincent-and-the-doctorOct 6, 2025
38 checks passed
@jacekradko
jacekradko deleted the chore/upgrade-node-version-in-ci branch October 6, 2025 15:20
jacekradko added a commit that referenced this pull request Oct 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jacekradko@dstaley@panteliselef@clerk-cookie
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore(repo): Use node@20 in CI - #6848

Merged
jacekradko merged 2 commits into
vincent-and-the-doctorfrom
chore/upgrade-node-version-in-ci
Oct 6, 2025
Merged

chore(repo): Use node@20 in CI#6848
jacekradko merged 2 commits into
vincent-and-the-doctorfrom
chore/upgrade-node-version-in-ci

Conversation

@jacekradko

@jacekradkojacekradko commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

Description

Node@18 is past the EOL date so switching to Node@20 in CI

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Tests

    • Updated continuous integration to run unit tests on Node.js 20, aligning automated test coverage with the latest LTS environment.
  • Chores

    • Refreshed workflow labeling/comments to reflect Node.js 20 in test runs.
  • Notes

    • No user-facing changes in this release; these updates improve test infrastructure and consistency across environments.

@changeset-bot

changeset-botBot commented Sep 24, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: fe1f7d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitaiBot commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Updates CI configuration to run unit tests on Node.js 20 instead of 18 and adjusts a related comment in the workflow file.

Changes

Cohort / File(s)Summary
CI workflow update
.github/workflows/ci.yml
Bumps unit-tests matrix node-version from 18 to 20; updates initialization step comment to reflect “Unit Tests (20)”.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I thump my paws—version twenty, hooray!
Pipelines hop faster in a shiny new way.
From burrow to build, the carrots align,
Tests nibble on bytes, everything’s fine.
With a twitch of my whiskers, CI’s aglow—
Onward we bound where green checks grow! 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe title succinctly states the primary change—updating CI to use Node 20—and uses a conventional "chore(repo)" prefix, making it specific, concise, and directly aligned with the PR's content.
Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel

vercelBot commented Sep 24, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentOct 6, 2025 1:19pm

@pkg-pr-new

pkg-pr-newBot commented Sep 24, 2025

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6848

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6848

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6848

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6848

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6848

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6848

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6848

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6848

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6848

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6848

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6848

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6848

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6848

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6848

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6848

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6848

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6848

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6848

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6848

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6848

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6848

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6848

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6848

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6848

commit: fe1f7d8

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/ci.yml (2)

226-231: Fix misleading cache comment: matrix also runs on Node 22.

Comment implies a single “Unit Tests (20)” run name, but this job runs on 20 and 22. Clarify to avoid cache/key confusion.

- # Ensures that all builds are cached appropriately with a consistent run name `Unit Tests (20)`.+ # Ensures builds are cached appropriately; run name includes the Node version+ # (e.g., `Unit Tests (20)` / `Unit Tests (22)`).

210-213: LTS lane moved to Node 20 — sweep found many Node 18 references (mostly node: ">=18.17.0") — OK with Node 20; change only if you want to raise the project minimum to >=20.

  • Search found engine fields and README prerequisites in root package.json and many packages/templates (packages//package.json, integration/templates//package.json, playground//package.json) and docs (packages//README.md, packages/upgrade/**). pnpm-lock entries reflect dependency engines.
  • Action: if you intend to bump the repo minimum to Node 20, update engines and docs (root + packages + templates) and any tool/runtime pins (.nvmrc/.tool-versions); otherwise this CI change is safe to approve.
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a39f2fc and 2a81b25.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.github/workflows/*.yml

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

CI/CD must be configured with GitHub Actions.

Files:

  • .github/workflows/ci.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Build Packages
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan

@jacekradko
jacekradko changed the base branch from main to vincent-and-the-doctorOctober 6, 2025 13:17
@jacekradko
jacekradko merged commit 43bfbd0 into vincent-and-the-doctorOct 6, 2025
38 checks passed
@jacekradko
jacekradko deleted the chore/upgrade-node-version-in-ci branch October 6, 2025 15:20
jacekradko added a commit that referenced this pull request Oct 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jacekradko@dstaley@panteliselef@clerk-cookie
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore(repo): Use node@20 in CI - #6848

Merged
jacekradko merged 2 commits into
vincent-and-the-doctorfrom
chore/upgrade-node-version-in-ci
Oct 6, 2025
Merged

chore(repo): Use node@20 in CI#6848
jacekradko merged 2 commits into
vincent-and-the-doctorfrom
chore/upgrade-node-version-in-ci

Conversation

@jacekradko

@jacekradkojacekradko commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

Description

Node@18 is past the EOL date so switching to Node@20 in CI

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Tests

    • Updated continuous integration to run unit tests on Node.js 20, aligning automated test coverage with the latest LTS environment.
  • Chores

    • Refreshed workflow labeling/comments to reflect Node.js 20 in test runs.
  • Notes

    • No user-facing changes in this release; these updates improve test infrastructure and consistency across environments.

@changeset-bot

changeset-botBot commented Sep 24, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: fe1f7d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitaiBot commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Updates CI configuration to run unit tests on Node.js 20 instead of 18 and adjusts a related comment in the workflow file.

Changes

Cohort / File(s)Summary
CI workflow update
.github/workflows/ci.yml
Bumps unit-tests matrix node-version from 18 to 20; updates initialization step comment to reflect “Unit Tests (20)”.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I thump my paws—version twenty, hooray!
Pipelines hop faster in a shiny new way.
From burrow to build, the carrots align,
Tests nibble on bytes, everything’s fine.
With a twitch of my whiskers, CI’s aglow—
Onward we bound where green checks grow! 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe title succinctly states the primary change—updating CI to use Node 20—and uses a conventional "chore(repo)" prefix, making it specific, concise, and directly aligned with the PR's content.
Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel

vercelBot commented Sep 24, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentOct 6, 2025 1:19pm

@pkg-pr-new

pkg-pr-newBot commented Sep 24, 2025

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6848

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6848

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6848

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6848

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6848

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6848

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6848

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6848

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6848

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6848

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6848

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6848

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6848

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6848

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6848

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6848

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6848

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6848

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6848

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6848

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6848

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6848

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6848

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6848

commit: fe1f7d8

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/ci.yml (2)

226-231: Fix misleading cache comment: matrix also runs on Node 22.

Comment implies a single “Unit Tests (20)” run name, but this job runs on 20 and 22. Clarify to avoid cache/key confusion.

- # Ensures that all builds are cached appropriately with a consistent run name `Unit Tests (20)`.+ # Ensures builds are cached appropriately; run name includes the Node version+ # (e.g., `Unit Tests (20)` / `Unit Tests (22)`).

210-213: LTS lane moved to Node 20 — sweep found many Node 18 references (mostly node: ">=18.17.0") — OK with Node 20; change only if you want to raise the project minimum to >=20.

  • Search found engine fields and README prerequisites in root package.json and many packages/templates (packages//package.json, integration/templates//package.json, playground//package.json) and docs (packages//README.md, packages/upgrade/**). pnpm-lock entries reflect dependency engines.
  • Action: if you intend to bump the repo minimum to Node 20, update engines and docs (root + packages + templates) and any tool/runtime pins (.nvmrc/.tool-versions); otherwise this CI change is safe to approve.
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a39f2fc and 2a81b25.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.github/workflows/*.yml

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

CI/CD must be configured with GitHub Actions.

Files:

  • .github/workflows/ci.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Build Packages
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan

@jacekradko
jacekradko changed the base branch from main to vincent-and-the-doctorOctober 6, 2025 13:17
@jacekradko
jacekradko merged commit 43bfbd0 into vincent-and-the-doctorOct 6, 2025
38 checks passed
@jacekradko
jacekradko deleted the chore/upgrade-node-version-in-ci branch October 6, 2025 15:20
jacekradko added a commit that referenced this pull request Oct 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jacekradko@dstaley@panteliselef@clerk-cookie
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

chore(repo): Use node@20 in CI - #6848

Merged
jacekradko merged 2 commits into
vincent-and-the-doctorfrom
chore/upgrade-node-version-in-ci
Oct 6, 2025
Merged

chore(repo): Use node@20 in CI#6848
jacekradko merged 2 commits into
vincent-and-the-doctorfrom
chore/upgrade-node-version-in-ci

Conversation

@jacekradko

@jacekradkojacekradko commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

Description

Node@18 is past the EOL date so switching to Node@20 in CI

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Tests

    • Updated continuous integration to run unit tests on Node.js 20, aligning automated test coverage with the latest LTS environment.
  • Chores

    • Refreshed workflow labeling/comments to reflect Node.js 20 in test runs.
  • Notes

    • No user-facing changes in this release; these updates improve test infrastructure and consistency across environments.

@changeset-bot

changeset-botBot commented Sep 24, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: fe1f7d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitaiBot commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Updates CI configuration to run unit tests on Node.js 20 instead of 18 and adjusts a related comment in the workflow file.

Changes

Cohort / File(s)Summary
CI workflow update
.github/workflows/ci.yml
Bumps unit-tests matrix node-version from 18 to 20; updates initialization step comment to reflect “Unit Tests (20)”.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I thump my paws—version twenty, hooray!
Pipelines hop faster in a shiny new way.
From burrow to build, the carrots align,
Tests nibble on bytes, everything’s fine.
With a twitch of my whiskers, CI’s aglow—
Onward we bound where green checks grow! 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe title succinctly states the primary change—updating CI to use Node 20—and uses a conventional "chore(repo)" prefix, making it specific, concise, and directly aligned with the PR's content.
Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel

vercelBot commented Sep 24, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentOct 6, 2025 1:19pm

@pkg-pr-new

pkg-pr-newBot commented Sep 24, 2025

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6848

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6848

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6848

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6848

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6848

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6848

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6848

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6848

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6848

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6848

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6848

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6848

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6848

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6848

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6848

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6848

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6848

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6848

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6848

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6848

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6848

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6848

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6848

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6848

commit: fe1f7d8

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/ci.yml (2)

226-231: Fix misleading cache comment: matrix also runs on Node 22.

Comment implies a single “Unit Tests (20)” run name, but this job runs on 20 and 22. Clarify to avoid cache/key confusion.

- # Ensures that all builds are cached appropriately with a consistent run name `Unit Tests (20)`.+ # Ensures builds are cached appropriately; run name includes the Node version+ # (e.g., `Unit Tests (20)` / `Unit Tests (22)`).

210-213: LTS lane moved to Node 20 — sweep found many Node 18 references (mostly node: ">=18.17.0") — OK with Node 20; change only if you want to raise the project minimum to >=20.

  • Search found engine fields and README prerequisites in root package.json and many packages/templates (packages//package.json, integration/templates//package.json, playground//package.json) and docs (packages//README.md, packages/upgrade/**). pnpm-lock entries reflect dependency engines.
  • Action: if you intend to bump the repo minimum to Node 20, update engines and docs (root + packages + templates) and any tool/runtime pins (.nvmrc/.tool-versions); otherwise this CI change is safe to approve.
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a39f2fc and 2a81b25.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.github/workflows/*.yml

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

CI/CD must be configured with GitHub Actions.

Files:

  • .github/workflows/ci.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Build Packages
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan

@jacekradko
jacekradko changed the base branch from main to vincent-and-the-doctorOctober 6, 2025 13:17
@jacekradko
jacekradko merged commit 43bfbd0 into vincent-and-the-doctorOct 6, 2025
38 checks passed
@jacekradko
jacekradko deleted the chore/upgrade-node-version-in-ci branch October 6, 2025 15:20
jacekradko added a commit that referenced this pull request Oct 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jacekradko@dstaley@panteliselef@clerk-cookie