Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .changeset/rich-breads-move.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
---
'@clerk/clerk-js': minor
'@clerk/shared': patch
'@clerk/types': minor
---

[Billing Beta] Rename payment source to payment method.
Comment thread
panteliselef marked this conversation as resolved.

`Clerk.user.initializePaymentSource()` -> `Clerk.user.initializePaymentMethod()`
`Clerk.user.addPaymentSource()` -> `Clerk.user.addPaymentMethod()`
`Clerk.user.getPaymentSources()` -> `Clerk.user.getPaymentMethods()`

`Clerk.organization.initializePaymentSource()` -> `Clerk.organization.initializePaymentMethod()`
`Clerk.organization.addPaymentSource()` -> `Clerk.organization.addPaymentMethod()`
`Clerk.organization.getPaymentSources()` -> `Clerk.organization.getPaymentMethods()`

22 changes: 11 additions & 11 deletions .typedoc/__tests__/__snapshots__/file-structure.test.ts.snap
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,26 +5,26 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/act-claim.mdx",
"types/act-jwt-claim.mdx",
"types/active-session-resource.mdx",
"types/add-payment-source-params.mdx",
"types/add-payment-method-params.mdx",
"types/billing-checkout-json.mdx",
"types/billing-checkout-resource.mdx",
"types/billing-checkout-totals-json.mdx",
"types/billing-checkout-totals.mdx",
"types/billing-initialized-payment-source-json.mdx",
"types/billing-initialized-payment-source-resource.mdx",
"types/billing-initialized-payment-method-json.mdx",
"types/billing-initialized-payment-method-resource.mdx",
"types/billing-money-amount-json.mdx",
"types/billing-money-amount.mdx",
"types/billing-namespace.mdx",
"types/billing-payer-json.mdx",
"types/billing-payer-methods.mdx",
"types/billing-payer-resource-type.mdx",
"types/billing-payer-resource.mdx",
"types/billing-payment-charge-type.mdx",
"types/billing-payment-json.mdx",
"types/billing-payment-method-json.mdx",
"types/billing-payment-method-resource.mdx",
"types/billing-payment-method-status.mdx",
"types/billing-payment-resource.mdx",
"types/billing-payment-source-json.mdx",
"types/billing-payment-source-methods.mdx",
"types/billing-payment-source-resource.mdx",
"types/billing-payment-source-status.mdx",
"types/billing-payment-status.mdx",
"types/billing-plan-json.mdx",
"types/billing-plan-resource.mdx",
Expand DownExpand Up@@ -72,21 +72,21 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/field-errors.mdx",
"types/for-payer-type.mdx",
"types/get-payment-attempts-params.mdx",
"types/get-payment-sources-params.mdx",
"types/get-payment-methods-params.mdx",
"types/get-plans-params.mdx",
"types/get-statements-params.mdx",
"types/get-subscription-params.mdx",
"types/get-token.mdx",
"types/id-selectors.mdx",
"types/initialize-payment-source-params.mdx",
"types/initialize-payment-method-params.mdx",
"types/internal_checkout-props.mdx",
"types/internal_plan-details-props.mdx",
"types/internal_subscription-details-props.mdx",
"types/jwt-claims.mdx",
"types/jwt-header.mdx",
"types/legacy-redirect-props.mdx",
"types/localization-resource.mdx",
"types/make-default-payment-source-params.mdx",
"types/make-default-payment-method-params.mdx",
"types/multi-domain-and-or-proxy.mdx",
"types/organization-custom-role-key.mdx",
"types/organization-domain-resource.mdx",
Expand All@@ -109,7 +109,7 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/protect-props.mdx",
"types/record-to-path.mdx",
"types/redirect-options.mdx",
"types/remove-payment-source-params.mdx",
"types/remove-payment-method-params.mdx",
"types/reverification-config.mdx",
"types/saml-strategy.mdx",
"types/sdk-metadata.mdx",
Expand Down
7 changes: 7 additions & 0 deletions packages/clerk-js/src/core/modules/billing/namespace.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,13 @@ import {
} from '../../resources/internal';

export class Billing implements BillingNamespace {
static readonly #pathRoot = '/commerce';
static path(subPath: string, param?: { orgId?: string }): string {
const { orgId } = param || {};
const prefix = orgId ? `/organizations/${orgId}` : '/me';
return `${prefix}${Billing.#pathRoot}${subPath}`;
}

getPlans = async (params?: GetPlansParams): Promise<ClerkPaginatedResponse<BillingPlanResource>> => {
const { for: forParam, ...safeParams } = params || {};
const searchParams = { ...safeParams, payer_type: forParam === 'organization' ? 'org' : 'user' };
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,55 +1,56 @@
import type {
AddPaymentSourceParams,
BillingInitializedPaymentSourceJSON,
BillingPaymentSourceJSON,
AddPaymentMethodParams,
BillingInitializedPaymentMethodJSON,
BillingPaymentMethodJSON,
ClerkPaginatedResponse,
GetPaymentSourcesParams,
InitializePaymentSourceParams,
GetPaymentMethodsParams,
InitializePaymentMethodParams,
} from '@clerk/types';

import { convertPageToOffsetSearchParams } from '../../../utils/convertPageToOffsetSearchParams';
import { BaseResource, BillingInitializedPaymentSource, BillingPaymentSource } from '../../resources/internal';
import { BaseResource, BillingInitializedPaymentMethod, BillingPaymentMethod } from '../../resources/internal';
import { Billing } from './namespace';

export const initializePaymentSource = async (params: InitializePaymentSourceParams) => {
const PAYMENT_METHODS_PATH = '/payment_methods';

export const initializePaymentMethod = async (params: InitializePaymentMethodParams) => {
const { orgId, ...rest } = params;
const json = (
await BaseResource._fetch({
path: orgId
? `/organizations/${orgId}/commerce/payment_sources/initialize`
: `/me/commerce/payment_sources/initialize`,
path: Billing.path(`${PAYMENT_METHODS_PATH}/initialize`, { orgId }),
method: 'POST',
body: rest as any,
})
)?.response as unknown as BillingInitializedPaymentSourceJSON;
return new BillingInitializedPaymentSource(json);
)?.response as unknown as BillingInitializedPaymentMethodJSON;
return new BillingInitializedPaymentMethod(json);
};

export const addPaymentSource = async (params: AddPaymentSourceParams) => {
export const addPaymentMethod = async (params: AddPaymentMethodParams) => {
const { orgId, ...rest } = params;

const json = (
await BaseResource._fetch({
path: orgId ? `/organizations/${orgId}/commerce/payment_sources` : `/me/commerce/payment_sources`,
path: Billing.path(PAYMENT_METHODS_PATH, { orgId }),
method: 'POST',
body: rest as any,
})
)?.response as unknown as BillingPaymentSourceJSON;
return new BillingPaymentSource(json);
)?.response as unknown as BillingPaymentMethodJSON;
return new BillingPaymentMethod(json);
};

export const getPaymentSources = async (params: GetPaymentSourcesParams) => {
export const getPaymentMethods = async (params: GetPaymentMethodsParams) => {
const { orgId, ...rest } = params;

return await BaseResource._fetch({
path: orgId ? `/organizations/${orgId}/commerce/payment_sources` : `/me/commerce/payment_sources`,
path: Billing.path(PAYMENT_METHODS_PATH, { orgId }),
method: 'GET',
search: convertPageToOffsetSearchParams(rest),
}).then(res => {
const { data: paymentSources, total_count } =
res?.response as unknown as ClerkPaginatedResponse<BillingPaymentSourceJSON>;
res?.response as unknown as ClerkPaginatedResponse<BillingPaymentMethodJSON>;
return {
total_count,
data: paymentSources.map(paymentSource => new BillingPaymentSource(paymentSource)),
data: paymentSources.map(paymentMethod => new BillingPaymentMethod(paymentMethod)),
};
});
};
7 changes: 4 additions & 3 deletions packages/clerk-js/src/core/resources/BillingCheckout.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@ import type {
BillingCheckoutResource,
BillingCheckoutTotals,
BillingPayerResource,
BillingPaymentMethodResource,
BillingSubscriptionPlanPeriod,
ConfirmCheckoutParams,
} from '@clerk/types';
Expand All@@ -13,13 +14,13 @@ import { unixEpochToDate } from '@/utils/date';

import { billingTotalsFromJSON } from '../../utils';
import { BillingPayer } from './BillingPayer';
import { BaseResource, BillingPaymentSource, BillingPlan } from './internal';
import { BaseResource, BillingPaymentMethod, BillingPlan } from './internal';

export class BillingCheckout extends BaseResource implements BillingCheckoutResource {
id!: string;
externalClientSecret!: string;
externalGatewayId!: string;
paymentSource?: BillingPaymentSource;
paymentMethod?: BillingPaymentMethodResource;
plan!: BillingPlan;
planPeriod!: BillingSubscriptionPlanPeriod;
planPeriodStart!: number | undefined;
Expand All@@ -42,7 +43,7 @@ export class BillingCheckout extends BaseResource implements BillingCheckoutReso
this.id = data.id;
this.externalClientSecret = data.external_client_secret;
this.externalGatewayId = data.external_gateway_id;
this.paymentSource = data.payment_source ? new BillingPaymentSource(data.payment_source) : undefined;
this.paymentMethod = data.payment_method ? new BillingPaymentMethod(data.payment_method) : undefined;
this.plan = new BillingPlan(data.plan);
this.planPeriod = data.plan_period;
this.planPeriodStart = data.plan_period_start;
Expand Down
8 changes: 4 additions & 4 deletions packages/clerk-js/src/core/resources/BillingPayment.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,23 +2,23 @@ import type {
BillingMoneyAmount,
BillingPaymentChargeType,
BillingPaymentJSON,
BillingPaymentMethodResource,
BillingPaymentResource,
BillingPaymentSourceResource,
BillingPaymentStatus,
BillingSubscriptionItemResource,
} from '@clerk/types';

import { billingMoneyAmountFromJSON } from '../../utils';
import { unixEpochToDate } from '../../utils/date';
import { BaseResource, BillingPaymentSource, BillingSubscriptionItem } from './internal';
import { BaseResource, BillingPaymentMethod, BillingSubscriptionItem } from './internal';

export class BillingPayment extends BaseResource implements BillingPaymentResource {
id!: string;
amount!: BillingMoneyAmount;
failedAt?: Date;
paidAt?: Date;
updatedAt!: Date;
paymentSource!: BillingPaymentSourceResource;
paymentMethod!: BillingPaymentMethodResource;
subscriptionItem!: BillingSubscriptionItemResource;
chargeType!: BillingPaymentChargeType;
status!: BillingPaymentStatus;
Expand All@@ -38,7 +38,7 @@ export class BillingPayment extends BaseResource implements BillingPaymentResour
this.paidAt = data.paid_at ? unixEpochToDate(data.paid_at) : undefined;
this.failedAt = data.failed_at ? unixEpochToDate(data.failed_at) : undefined;
this.updatedAt = unixEpochToDate(data.updated_at);
this.paymentSource = new BillingPaymentSource(data.payment_source);
this.paymentMethod = new BillingPaymentMethod(data.payment_method);
this.subscriptionItem = new BillingSubscriptionItem(data.subscription_item);
this.chargeType = data.charge_type;
this.status = data.status;
Expand Down
36 changes: 18 additions & 18 deletions packages/clerk-js/src/core/resources/BillingPaymentSource.ts
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,39 @@
import type {
BillingInitializedPaymentSourceJSON,
BillingInitializedPaymentSourceResource,
BillingPaymentSourceJSON,
BillingPaymentSourceResource,
BillingPaymentSourceStatus,
BillingInitializedPaymentMethodJSON,
BillingInitializedPaymentMethodResource,
BillingPaymentMethodJSON,
BillingPaymentMethodResource,
BillingPaymentMethodStatus,
DeletedObjectJSON,
MakeDefaultPaymentSourceParams,
RemovePaymentSourceParams,
MakeDefaultPaymentMethodParams,
RemovePaymentMethodParams,
} from '@clerk/types';

import { BaseResource, DeletedObject } from './internal';

export class BillingPaymentSource extends BaseResource implements BillingPaymentSourceResource {
export class BillingPaymentMethod extends BaseResource implements BillingPaymentMethodResource {
id!: string;
last4!: string;
paymentMethod!: string;
paymentType!: 'card' | 'link';
cardType!: string;
isDefault!: boolean;
isRemovable!: boolean;
status!: BillingPaymentSourceStatus;
status!: BillingPaymentMethodStatus;
walletType: string | undefined;

constructor(data: BillingPaymentSourceJSON) {
constructor(data: BillingPaymentMethodJSON) {
super();
this.fromJSON(data);
}

protected fromJSON(data: BillingPaymentSourceJSON | null): this {
protected fromJSON(data: BillingPaymentMethodJSON | null): this {
if (!data) {
return this;
}

this.id = data.id;
this.last4 = data.last4;
this.paymentMethod = data.payment_method;
this.paymentType = data.payment_type;
this.cardType = data.card_type;
this.isDefault = data.is_default;
this.isRemovable = data.is_removable;
Expand All@@ -43,7 +43,7 @@ export class BillingPaymentSource extends BaseResource implements BillingPayment
return this;
}

public async remove(params?: RemovePaymentSourceParams) {
public async remove(params?: RemovePaymentMethodParams) {
const { orgId } = params ?? {};
const json = (
await BaseResource._fetch({
Expand All@@ -57,7 +57,7 @@ export class BillingPaymentSource extends BaseResource implements BillingPayment
return new DeletedObject(json);
}

public async makeDefault(params?: MakeDefaultPaymentSourceParams) {
public async makeDefault(params?: MakeDefaultPaymentMethodParams) {
const { orgId } = params ?? {};
await BaseResource._fetch({
path: orgId
Expand All@@ -71,17 +71,17 @@ export class BillingPaymentSource extends BaseResource implements BillingPayment
}
}

export class BillingInitializedPaymentSource extends BaseResource implements BillingInitializedPaymentSourceResource {
export class BillingInitializedPaymentMethod extends BaseResource implements BillingInitializedPaymentMethodResource {
externalClientSecret!: string;
externalGatewayId!: string;
paymentMethodOrder!: string[];

constructor(data: BillingInitializedPaymentSourceJSON) {
constructor(data: BillingInitializedPaymentMethodJSON) {
super();
this.fromJSON(data);
}

protected fromJSON(data: BillingInitializedPaymentSourceJSON | null): this {
protected fromJSON(data: BillingInitializedPaymentMethodJSON | null): this {
if (!data) {
return this;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/BillingSubscription.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ export class BillingSubscription extends BaseResource implements BillingSubscrip

export class BillingSubscriptionItem extends BaseResource implements BillingSubscriptionItemResource {
id!: string;
paymentSourceId!: string;
paymentMethodId!: string;
plan!: BillingPlan;
planPeriod!: BillingSubscriptionPlanPeriod;
status!: BillingSubscriptionStatus;
Expand All@@ -86,7 +86,7 @@ export class BillingSubscriptionItem extends BaseResource implements BillingSubs
}

this.id = data.id;
this.paymentSourceId = data.payment_source_id;
this.paymentMethodId = data.payment_method_id;
this.plan = new BillingPlan(data.plan);
this.planPeriod = data.plan_period;
this.status = data.status;
Expand Down
14 changes: 7 additions & 7 deletions packages/clerk-js/src/core/resources/Organization.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,7 @@ import type {

import { convertPageToOffsetSearchParams } from '../../utils/convertPageToOffsetSearchParams';
import { unixEpochToDate } from '../../utils/date';
import { addPaymentSource, getPaymentSources, initializePaymentSource } from '../modules/billing';
import { addPaymentMethod, getPaymentMethods, initializePaymentMethod } from '../modules/billing';
import { BaseResource, OrganizationInvitation, OrganizationMembership } from './internal';
import { OrganizationDomain } from './OrganizationDomain';
import { OrganizationMembershipRequest } from './OrganizationMembershipRequest';
Expand DownExpand Up@@ -262,22 +262,22 @@ export class Organization extends BaseResource implements OrganizationResource {
}).then(res => new Organization(res?.response as OrganizationJSON));
};

initializePaymentSource: typeof initializePaymentSource = params => {
return initializePaymentSource({
initializePaymentMethod: typeof initializePaymentMethod = params => {
return initializePaymentMethod({
...params,
orgId: this.id,
});
};

addPaymentSource: typeof addPaymentSource = params => {
return addPaymentSource({
addPaymentMethod: typeof addPaymentMethod = params => {
return addPaymentMethod({
...params,
orgId: this.id,
});
};

getPaymentSources: typeof getPaymentSources = params => {
return getPaymentSources({
getPaymentMethods: typeof getPaymentMethods = params => {
return getPaymentMethods({
...params,
orgId: this.id,
});
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .changeset/rich-breads-move.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
---
'@clerk/clerk-js': minor
'@clerk/shared': patch
'@clerk/types': minor
---

[Billing Beta] Rename payment source to payment method.
Comment thread
panteliselef marked this conversation as resolved.

`Clerk.user.initializePaymentSource()` -> `Clerk.user.initializePaymentMethod()`
`Clerk.user.addPaymentSource()` -> `Clerk.user.addPaymentMethod()`
`Clerk.user.getPaymentSources()` -> `Clerk.user.getPaymentMethods()`

`Clerk.organization.initializePaymentSource()` -> `Clerk.organization.initializePaymentMethod()`
`Clerk.organization.addPaymentSource()` -> `Clerk.organization.addPaymentMethod()`
`Clerk.organization.getPaymentSources()` -> `Clerk.organization.getPaymentMethods()`

22 changes: 11 additions & 11 deletions .typedoc/__tests__/__snapshots__/file-structure.test.ts.snap
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,26 +5,26 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/act-claim.mdx",
"types/act-jwt-claim.mdx",
"types/active-session-resource.mdx",
"types/add-payment-source-params.mdx",
"types/add-payment-method-params.mdx",
"types/billing-checkout-json.mdx",
"types/billing-checkout-resource.mdx",
"types/billing-checkout-totals-json.mdx",
"types/billing-checkout-totals.mdx",
"types/billing-initialized-payment-source-json.mdx",
"types/billing-initialized-payment-source-resource.mdx",
"types/billing-initialized-payment-method-json.mdx",
"types/billing-initialized-payment-method-resource.mdx",
"types/billing-money-amount-json.mdx",
"types/billing-money-amount.mdx",
"types/billing-namespace.mdx",
"types/billing-payer-json.mdx",
"types/billing-payer-methods.mdx",
"types/billing-payer-resource-type.mdx",
"types/billing-payer-resource.mdx",
"types/billing-payment-charge-type.mdx",
"types/billing-payment-json.mdx",
"types/billing-payment-method-json.mdx",
"types/billing-payment-method-resource.mdx",
"types/billing-payment-method-status.mdx",
"types/billing-payment-resource.mdx",
"types/billing-payment-source-json.mdx",
"types/billing-payment-source-methods.mdx",
"types/billing-payment-source-resource.mdx",
"types/billing-payment-source-status.mdx",
"types/billing-payment-status.mdx",
"types/billing-plan-json.mdx",
"types/billing-plan-resource.mdx",
Expand DownExpand Up@@ -72,21 +72,21 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/field-errors.mdx",
"types/for-payer-type.mdx",
"types/get-payment-attempts-params.mdx",
"types/get-payment-sources-params.mdx",
"types/get-payment-methods-params.mdx",
"types/get-plans-params.mdx",
"types/get-statements-params.mdx",
"types/get-subscription-params.mdx",
"types/get-token.mdx",
"types/id-selectors.mdx",
"types/initialize-payment-source-params.mdx",
"types/initialize-payment-method-params.mdx",
"types/internal_checkout-props.mdx",
"types/internal_plan-details-props.mdx",
"types/internal_subscription-details-props.mdx",
"types/jwt-claims.mdx",
"types/jwt-header.mdx",
"types/legacy-redirect-props.mdx",
"types/localization-resource.mdx",
"types/make-default-payment-source-params.mdx",
"types/make-default-payment-method-params.mdx",
"types/multi-domain-and-or-proxy.mdx",
"types/organization-custom-role-key.mdx",
"types/organization-domain-resource.mdx",
Expand All@@ -109,7 +109,7 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/protect-props.mdx",
"types/record-to-path.mdx",
"types/redirect-options.mdx",
"types/remove-payment-source-params.mdx",
"types/remove-payment-method-params.mdx",
"types/reverification-config.mdx",
"types/saml-strategy.mdx",
"types/sdk-metadata.mdx",
Expand Down
7 changes: 7 additions & 0 deletions packages/clerk-js/src/core/modules/billing/namespace.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,13 @@ import {
} from '../../resources/internal';

export class Billing implements BillingNamespace {
static readonly #pathRoot = '/commerce';
static path(subPath: string, param?: { orgId?: string }): string {
const { orgId } = param || {};
const prefix = orgId ? `/organizations/${orgId}` : '/me';
return `${prefix}${Billing.#pathRoot}${subPath}`;
}

getPlans = async (params?: GetPlansParams): Promise<ClerkPaginatedResponse<BillingPlanResource>> => {
const { for: forParam, ...safeParams } = params || {};
const searchParams = { ...safeParams, payer_type: forParam === 'organization' ? 'org' : 'user' };
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,55 +1,56 @@
import type {
AddPaymentSourceParams,
BillingInitializedPaymentSourceJSON,
BillingPaymentSourceJSON,
AddPaymentMethodParams,
BillingInitializedPaymentMethodJSON,
BillingPaymentMethodJSON,
ClerkPaginatedResponse,
GetPaymentSourcesParams,
InitializePaymentSourceParams,
GetPaymentMethodsParams,
InitializePaymentMethodParams,
} from '@clerk/types';

import { convertPageToOffsetSearchParams } from '../../../utils/convertPageToOffsetSearchParams';
import { BaseResource, BillingInitializedPaymentSource, BillingPaymentSource } from '../../resources/internal';
import { BaseResource, BillingInitializedPaymentMethod, BillingPaymentMethod } from '../../resources/internal';
import { Billing } from './namespace';

export const initializePaymentSource = async (params: InitializePaymentSourceParams) => {
const PAYMENT_METHODS_PATH = '/payment_methods';

export const initializePaymentMethod = async (params: InitializePaymentMethodParams) => {
const { orgId, ...rest } = params;
const json = (
await BaseResource._fetch({
path: orgId
? `/organizations/${orgId}/commerce/payment_sources/initialize`
: `/me/commerce/payment_sources/initialize`,
path: Billing.path(`${PAYMENT_METHODS_PATH}/initialize`, { orgId }),
method: 'POST',
body: rest as any,
})
)?.response as unknown as BillingInitializedPaymentSourceJSON;
return new BillingInitializedPaymentSource(json);
)?.response as unknown as BillingInitializedPaymentMethodJSON;
return new BillingInitializedPaymentMethod(json);
};

export const addPaymentSource = async (params: AddPaymentSourceParams) => {
export const addPaymentMethod = async (params: AddPaymentMethodParams) => {
const { orgId, ...rest } = params;

const json = (
await BaseResource._fetch({
path: orgId ? `/organizations/${orgId}/commerce/payment_sources` : `/me/commerce/payment_sources`,
path: Billing.path(PAYMENT_METHODS_PATH, { orgId }),
method: 'POST',
body: rest as any,
})
)?.response as unknown as BillingPaymentSourceJSON;
return new BillingPaymentSource(json);
)?.response as unknown as BillingPaymentMethodJSON;
return new BillingPaymentMethod(json);
};

export const getPaymentSources = async (params: GetPaymentSourcesParams) => {
export const getPaymentMethods = async (params: GetPaymentMethodsParams) => {
const { orgId, ...rest } = params;

return await BaseResource._fetch({
path: orgId ? `/organizations/${orgId}/commerce/payment_sources` : `/me/commerce/payment_sources`,
path: Billing.path(PAYMENT_METHODS_PATH, { orgId }),
method: 'GET',
search: convertPageToOffsetSearchParams(rest),
}).then(res => {
const { data: paymentSources, total_count } =
res?.response as unknown as ClerkPaginatedResponse<BillingPaymentSourceJSON>;
res?.response as unknown as ClerkPaginatedResponse<BillingPaymentMethodJSON>;
return {
total_count,
data: paymentSources.map(paymentSource => new BillingPaymentSource(paymentSource)),
data: paymentSources.map(paymentMethod => new BillingPaymentMethod(paymentMethod)),
};
});
};
7 changes: 4 additions & 3 deletions packages/clerk-js/src/core/resources/BillingCheckout.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@ import type {
BillingCheckoutResource,
BillingCheckoutTotals,
BillingPayerResource,
BillingPaymentMethodResource,
BillingSubscriptionPlanPeriod,
ConfirmCheckoutParams,
} from '@clerk/types';
Expand All@@ -13,13 +14,13 @@ import { unixEpochToDate } from '@/utils/date';

import { billingTotalsFromJSON } from '../../utils';
import { BillingPayer } from './BillingPayer';
import { BaseResource, BillingPaymentSource, BillingPlan } from './internal';
import { BaseResource, BillingPaymentMethod, BillingPlan } from './internal';

export class BillingCheckout extends BaseResource implements BillingCheckoutResource {
id!: string;
externalClientSecret!: string;
externalGatewayId!: string;
paymentSource?: BillingPaymentSource;
paymentMethod?: BillingPaymentMethodResource;
plan!: BillingPlan;
planPeriod!: BillingSubscriptionPlanPeriod;
planPeriodStart!: number | undefined;
Expand All@@ -42,7 +43,7 @@ export class BillingCheckout extends BaseResource implements BillingCheckoutReso
this.id = data.id;
this.externalClientSecret = data.external_client_secret;
this.externalGatewayId = data.external_gateway_id;
this.paymentSource = data.payment_source ? new BillingPaymentSource(data.payment_source) : undefined;
this.paymentMethod = data.payment_method ? new BillingPaymentMethod(data.payment_method) : undefined;
this.plan = new BillingPlan(data.plan);
this.planPeriod = data.plan_period;
this.planPeriodStart = data.plan_period_start;
Expand Down
8 changes: 4 additions & 4 deletions packages/clerk-js/src/core/resources/BillingPayment.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,23 +2,23 @@ import type {
BillingMoneyAmount,
BillingPaymentChargeType,
BillingPaymentJSON,
BillingPaymentMethodResource,
BillingPaymentResource,
BillingPaymentSourceResource,
BillingPaymentStatus,
BillingSubscriptionItemResource,
} from '@clerk/types';

import { billingMoneyAmountFromJSON } from '../../utils';
import { unixEpochToDate } from '../../utils/date';
import { BaseResource, BillingPaymentSource, BillingSubscriptionItem } from './internal';
import { BaseResource, BillingPaymentMethod, BillingSubscriptionItem } from './internal';

export class BillingPayment extends BaseResource implements BillingPaymentResource {
id!: string;
amount!: BillingMoneyAmount;
failedAt?: Date;
paidAt?: Date;
updatedAt!: Date;
paymentSource!: BillingPaymentSourceResource;
paymentMethod!: BillingPaymentMethodResource;
subscriptionItem!: BillingSubscriptionItemResource;
chargeType!: BillingPaymentChargeType;
status!: BillingPaymentStatus;
Expand All@@ -38,7 +38,7 @@ export class BillingPayment extends BaseResource implements BillingPaymentResour
this.paidAt = data.paid_at ? unixEpochToDate(data.paid_at) : undefined;
this.failedAt = data.failed_at ? unixEpochToDate(data.failed_at) : undefined;
this.updatedAt = unixEpochToDate(data.updated_at);
this.paymentSource = new BillingPaymentSource(data.payment_source);
this.paymentMethod = new BillingPaymentMethod(data.payment_method);
this.subscriptionItem = new BillingSubscriptionItem(data.subscription_item);
this.chargeType = data.charge_type;
this.status = data.status;
Expand Down
36 changes: 18 additions & 18 deletions packages/clerk-js/src/core/resources/BillingPaymentSource.ts
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,39 @@
import type {
BillingInitializedPaymentSourceJSON,
BillingInitializedPaymentSourceResource,
BillingPaymentSourceJSON,
BillingPaymentSourceResource,
BillingPaymentSourceStatus,
BillingInitializedPaymentMethodJSON,
BillingInitializedPaymentMethodResource,
BillingPaymentMethodJSON,
BillingPaymentMethodResource,
BillingPaymentMethodStatus,
DeletedObjectJSON,
MakeDefaultPaymentSourceParams,
RemovePaymentSourceParams,
MakeDefaultPaymentMethodParams,
RemovePaymentMethodParams,
} from '@clerk/types';

import { BaseResource, DeletedObject } from './internal';

export class BillingPaymentSource extends BaseResource implements BillingPaymentSourceResource {
export class BillingPaymentMethod extends BaseResource implements BillingPaymentMethodResource {
id!: string;
last4!: string;
paymentMethod!: string;
paymentType!: 'card' | 'link';
cardType!: string;
isDefault!: boolean;
isRemovable!: boolean;
status!: BillingPaymentSourceStatus;
status!: BillingPaymentMethodStatus;
walletType: string | undefined;

constructor(data: BillingPaymentSourceJSON) {
constructor(data: BillingPaymentMethodJSON) {
super();
this.fromJSON(data);
}

protected fromJSON(data: BillingPaymentSourceJSON | null): this {
protected fromJSON(data: BillingPaymentMethodJSON | null): this {
if (!data) {
return this;
}

this.id = data.id;
this.last4 = data.last4;
this.paymentMethod = data.payment_method;
this.paymentType = data.payment_type;
this.cardType = data.card_type;
this.isDefault = data.is_default;
this.isRemovable = data.is_removable;
Expand All@@ -43,7 +43,7 @@ export class BillingPaymentSource extends BaseResource implements BillingPayment
return this;
}

public async remove(params?: RemovePaymentSourceParams) {
public async remove(params?: RemovePaymentMethodParams) {
const { orgId } = params ?? {};
const json = (
await BaseResource._fetch({
Expand All@@ -57,7 +57,7 @@ export class BillingPaymentSource extends BaseResource implements BillingPayment
return new DeletedObject(json);
}

public async makeDefault(params?: MakeDefaultPaymentSourceParams) {
public async makeDefault(params?: MakeDefaultPaymentMethodParams) {
const { orgId } = params ?? {};
await BaseResource._fetch({
path: orgId
Expand All@@ -71,17 +71,17 @@ export class BillingPaymentSource extends BaseResource implements BillingPayment
}
}

export class BillingInitializedPaymentSource extends BaseResource implements BillingInitializedPaymentSourceResource {
export class BillingInitializedPaymentMethod extends BaseResource implements BillingInitializedPaymentMethodResource {
externalClientSecret!: string;
externalGatewayId!: string;
paymentMethodOrder!: string[];

constructor(data: BillingInitializedPaymentSourceJSON) {
constructor(data: BillingInitializedPaymentMethodJSON) {
super();
this.fromJSON(data);
}

protected fromJSON(data: BillingInitializedPaymentSourceJSON | null): this {
protected fromJSON(data: BillingInitializedPaymentMethodJSON | null): this {
if (!data) {
return this;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/BillingSubscription.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ export class BillingSubscription extends BaseResource implements BillingSubscrip

export class BillingSubscriptionItem extends BaseResource implements BillingSubscriptionItemResource {
id!: string;
paymentSourceId!: string;
paymentMethodId!: string;
plan!: BillingPlan;
planPeriod!: BillingSubscriptionPlanPeriod;
status!: BillingSubscriptionStatus;
Expand All@@ -86,7 +86,7 @@ export class BillingSubscriptionItem extends BaseResource implements BillingSubs
}

this.id = data.id;
this.paymentSourceId = data.payment_source_id;
this.paymentMethodId = data.payment_method_id;
this.plan = new BillingPlan(data.plan);
this.planPeriod = data.plan_period;
this.status = data.status;
Expand Down
14 changes: 7 additions & 7 deletions packages/clerk-js/src/core/resources/Organization.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,7 @@ import type {

import { convertPageToOffsetSearchParams } from '../../utils/convertPageToOffsetSearchParams';
import { unixEpochToDate } from '../../utils/date';
import { addPaymentSource, getPaymentSources, initializePaymentSource } from '../modules/billing';
import { addPaymentMethod, getPaymentMethods, initializePaymentMethod } from '../modules/billing';
import { BaseResource, OrganizationInvitation, OrganizationMembership } from './internal';
import { OrganizationDomain } from './OrganizationDomain';
import { OrganizationMembershipRequest } from './OrganizationMembershipRequest';
Expand DownExpand Up@@ -262,22 +262,22 @@ export class Organization extends BaseResource implements OrganizationResource {
}).then(res => new Organization(res?.response as OrganizationJSON));
};

initializePaymentSource: typeof initializePaymentSource = params => {
return initializePaymentSource({
initializePaymentMethod: typeof initializePaymentMethod = params => {
return initializePaymentMethod({
...params,
orgId: this.id,
});
};

addPaymentSource: typeof addPaymentSource = params => {
return addPaymentSource({
addPaymentMethod: typeof addPaymentMethod = params => {
return addPaymentMethod({
...params,
orgId: this.id,
});
};

getPaymentSources: typeof getPaymentSources = params => {
return getPaymentSources({
getPaymentMethods: typeof getPaymentMethods = params => {
return getPaymentMethods({
...params,
orgId: this.id,
});
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .changeset/rich-breads-move.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
---
'@clerk/clerk-js': minor
'@clerk/shared': patch
'@clerk/types': minor
---

[Billing Beta] Rename payment source to payment method.
Comment thread
panteliselef marked this conversation as resolved.

`Clerk.user.initializePaymentSource()` -> `Clerk.user.initializePaymentMethod()`
`Clerk.user.addPaymentSource()` -> `Clerk.user.addPaymentMethod()`
`Clerk.user.getPaymentSources()` -> `Clerk.user.getPaymentMethods()`

`Clerk.organization.initializePaymentSource()` -> `Clerk.organization.initializePaymentMethod()`
`Clerk.organization.addPaymentSource()` -> `Clerk.organization.addPaymentMethod()`
`Clerk.organization.getPaymentSources()` -> `Clerk.organization.getPaymentMethods()`

22 changes: 11 additions & 11 deletions .typedoc/__tests__/__snapshots__/file-structure.test.ts.snap
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,26 +5,26 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/act-claim.mdx",
"types/act-jwt-claim.mdx",
"types/active-session-resource.mdx",
"types/add-payment-source-params.mdx",
"types/add-payment-method-params.mdx",
"types/billing-checkout-json.mdx",
"types/billing-checkout-resource.mdx",
"types/billing-checkout-totals-json.mdx",
"types/billing-checkout-totals.mdx",
"types/billing-initialized-payment-source-json.mdx",
"types/billing-initialized-payment-source-resource.mdx",
"types/billing-initialized-payment-method-json.mdx",
"types/billing-initialized-payment-method-resource.mdx",
"types/billing-money-amount-json.mdx",
"types/billing-money-amount.mdx",
"types/billing-namespace.mdx",
"types/billing-payer-json.mdx",
"types/billing-payer-methods.mdx",
"types/billing-payer-resource-type.mdx",
"types/billing-payer-resource.mdx",
"types/billing-payment-charge-type.mdx",
"types/billing-payment-json.mdx",
"types/billing-payment-method-json.mdx",
"types/billing-payment-method-resource.mdx",
"types/billing-payment-method-status.mdx",
"types/billing-payment-resource.mdx",
"types/billing-payment-source-json.mdx",
"types/billing-payment-source-methods.mdx",
"types/billing-payment-source-resource.mdx",
"types/billing-payment-source-status.mdx",
"types/billing-payment-status.mdx",
"types/billing-plan-json.mdx",
"types/billing-plan-resource.mdx",
Expand DownExpand Up@@ -72,21 +72,21 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/field-errors.mdx",
"types/for-payer-type.mdx",
"types/get-payment-attempts-params.mdx",
"types/get-payment-sources-params.mdx",
"types/get-payment-methods-params.mdx",
"types/get-plans-params.mdx",
"types/get-statements-params.mdx",
"types/get-subscription-params.mdx",
"types/get-token.mdx",
"types/id-selectors.mdx",
"types/initialize-payment-source-params.mdx",
"types/initialize-payment-method-params.mdx",
"types/internal_checkout-props.mdx",
"types/internal_plan-details-props.mdx",
"types/internal_subscription-details-props.mdx",
"types/jwt-claims.mdx",
"types/jwt-header.mdx",
"types/legacy-redirect-props.mdx",
"types/localization-resource.mdx",
"types/make-default-payment-source-params.mdx",
"types/make-default-payment-method-params.mdx",
"types/multi-domain-and-or-proxy.mdx",
"types/organization-custom-role-key.mdx",
"types/organization-domain-resource.mdx",
Expand All@@ -109,7 +109,7 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/protect-props.mdx",
"types/record-to-path.mdx",
"types/redirect-options.mdx",
"types/remove-payment-source-params.mdx",
"types/remove-payment-method-params.mdx",
"types/reverification-config.mdx",
"types/saml-strategy.mdx",
"types/sdk-metadata.mdx",
Expand Down
7 changes: 7 additions & 0 deletions packages/clerk-js/src/core/modules/billing/namespace.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,13 @@ import {
} from '../../resources/internal';

export class Billing implements BillingNamespace {
static readonly #pathRoot = '/commerce';
static path(subPath: string, param?: { orgId?: string }): string {
const { orgId } = param || {};
const prefix = orgId ? `/organizations/${orgId}` : '/me';
return `${prefix}${Billing.#pathRoot}${subPath}`;
}

getPlans = async (params?: GetPlansParams): Promise<ClerkPaginatedResponse<BillingPlanResource>> => {
const { for: forParam, ...safeParams } = params || {};
const searchParams = { ...safeParams, payer_type: forParam === 'organization' ? 'org' : 'user' };
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,55 +1,56 @@
import type {
AddPaymentSourceParams,
BillingInitializedPaymentSourceJSON,
BillingPaymentSourceJSON,
AddPaymentMethodParams,
BillingInitializedPaymentMethodJSON,
BillingPaymentMethodJSON,
ClerkPaginatedResponse,
GetPaymentSourcesParams,
InitializePaymentSourceParams,
GetPaymentMethodsParams,
InitializePaymentMethodParams,
} from '@clerk/types';

import { convertPageToOffsetSearchParams } from '../../../utils/convertPageToOffsetSearchParams';
import { BaseResource, BillingInitializedPaymentSource, BillingPaymentSource } from '../../resources/internal';
import { BaseResource, BillingInitializedPaymentMethod, BillingPaymentMethod } from '../../resources/internal';
import { Billing } from './namespace';

export const initializePaymentSource = async (params: InitializePaymentSourceParams) => {
const PAYMENT_METHODS_PATH = '/payment_methods';

export const initializePaymentMethod = async (params: InitializePaymentMethodParams) => {
const { orgId, ...rest } = params;
const json = (
await BaseResource._fetch({
path: orgId
? `/organizations/${orgId}/commerce/payment_sources/initialize`
: `/me/commerce/payment_sources/initialize`,
path: Billing.path(`${PAYMENT_METHODS_PATH}/initialize`, { orgId }),
method: 'POST',
body: rest as any,
})
)?.response as unknown as BillingInitializedPaymentSourceJSON;
return new BillingInitializedPaymentSource(json);
)?.response as unknown as BillingInitializedPaymentMethodJSON;
return new BillingInitializedPaymentMethod(json);
};

export const addPaymentSource = async (params: AddPaymentSourceParams) => {
export const addPaymentMethod = async (params: AddPaymentMethodParams) => {
const { orgId, ...rest } = params;

const json = (
await BaseResource._fetch({
path: orgId ? `/organizations/${orgId}/commerce/payment_sources` : `/me/commerce/payment_sources`,
path: Billing.path(PAYMENT_METHODS_PATH, { orgId }),
method: 'POST',
body: rest as any,
})
)?.response as unknown as BillingPaymentSourceJSON;
return new BillingPaymentSource(json);
)?.response as unknown as BillingPaymentMethodJSON;
return new BillingPaymentMethod(json);
};

export const getPaymentSources = async (params: GetPaymentSourcesParams) => {
export const getPaymentMethods = async (params: GetPaymentMethodsParams) => {
const { orgId, ...rest } = params;

return await BaseResource._fetch({
path: orgId ? `/organizations/${orgId}/commerce/payment_sources` : `/me/commerce/payment_sources`,
path: Billing.path(PAYMENT_METHODS_PATH, { orgId }),
method: 'GET',
search: convertPageToOffsetSearchParams(rest),
}).then(res => {
const { data: paymentSources, total_count } =
res?.response as unknown as ClerkPaginatedResponse<BillingPaymentSourceJSON>;
res?.response as unknown as ClerkPaginatedResponse<BillingPaymentMethodJSON>;
return {
total_count,
data: paymentSources.map(paymentSource => new BillingPaymentSource(paymentSource)),
data: paymentSources.map(paymentMethod => new BillingPaymentMethod(paymentMethod)),
};
});
};
7 changes: 4 additions & 3 deletions packages/clerk-js/src/core/resources/BillingCheckout.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@ import type {
BillingCheckoutResource,
BillingCheckoutTotals,
BillingPayerResource,
BillingPaymentMethodResource,
BillingSubscriptionPlanPeriod,
ConfirmCheckoutParams,
} from '@clerk/types';
Expand All@@ -13,13 +14,13 @@ import { unixEpochToDate } from '@/utils/date';

import { billingTotalsFromJSON } from '../../utils';
import { BillingPayer } from './BillingPayer';
import { BaseResource, BillingPaymentSource, BillingPlan } from './internal';
import { BaseResource, BillingPaymentMethod, BillingPlan } from './internal';

export class BillingCheckout extends BaseResource implements BillingCheckoutResource {
id!: string;
externalClientSecret!: string;
externalGatewayId!: string;
paymentSource?: BillingPaymentSource;
paymentMethod?: BillingPaymentMethodResource;
plan!: BillingPlan;
planPeriod!: BillingSubscriptionPlanPeriod;
planPeriodStart!: number | undefined;
Expand All@@ -42,7 +43,7 @@ export class BillingCheckout extends BaseResource implements BillingCheckoutReso
this.id = data.id;
this.externalClientSecret = data.external_client_secret;
this.externalGatewayId = data.external_gateway_id;
this.paymentSource = data.payment_source ? new BillingPaymentSource(data.payment_source) : undefined;
this.paymentMethod = data.payment_method ? new BillingPaymentMethod(data.payment_method) : undefined;
this.plan = new BillingPlan(data.plan);
this.planPeriod = data.plan_period;
this.planPeriodStart = data.plan_period_start;
Expand Down
8 changes: 4 additions & 4 deletions packages/clerk-js/src/core/resources/BillingPayment.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,23 +2,23 @@ import type {
BillingMoneyAmount,
BillingPaymentChargeType,
BillingPaymentJSON,
BillingPaymentMethodResource,
BillingPaymentResource,
BillingPaymentSourceResource,
BillingPaymentStatus,
BillingSubscriptionItemResource,
} from '@clerk/types';

import { billingMoneyAmountFromJSON } from '../../utils';
import { unixEpochToDate } from '../../utils/date';
import { BaseResource, BillingPaymentSource, BillingSubscriptionItem } from './internal';
import { BaseResource, BillingPaymentMethod, BillingSubscriptionItem } from './internal';

export class BillingPayment extends BaseResource implements BillingPaymentResource {
id!: string;
amount!: BillingMoneyAmount;
failedAt?: Date;
paidAt?: Date;
updatedAt!: Date;
paymentSource!: BillingPaymentSourceResource;
paymentMethod!: BillingPaymentMethodResource;
subscriptionItem!: BillingSubscriptionItemResource;
chargeType!: BillingPaymentChargeType;
status!: BillingPaymentStatus;
Expand All@@ -38,7 +38,7 @@ export class BillingPayment extends BaseResource implements BillingPaymentResour
this.paidAt = data.paid_at ? unixEpochToDate(data.paid_at) : undefined;
this.failedAt = data.failed_at ? unixEpochToDate(data.failed_at) : undefined;
this.updatedAt = unixEpochToDate(data.updated_at);
this.paymentSource = new BillingPaymentSource(data.payment_source);
this.paymentMethod = new BillingPaymentMethod(data.payment_method);
this.subscriptionItem = new BillingSubscriptionItem(data.subscription_item);
this.chargeType = data.charge_type;
this.status = data.status;
Expand Down
36 changes: 18 additions & 18 deletions packages/clerk-js/src/core/resources/BillingPaymentSource.ts
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,39 @@
import type {
BillingInitializedPaymentSourceJSON,
BillingInitializedPaymentSourceResource,
BillingPaymentSourceJSON,
BillingPaymentSourceResource,
BillingPaymentSourceStatus,
BillingInitializedPaymentMethodJSON,
BillingInitializedPaymentMethodResource,
BillingPaymentMethodJSON,
BillingPaymentMethodResource,
BillingPaymentMethodStatus,
DeletedObjectJSON,
MakeDefaultPaymentSourceParams,
RemovePaymentSourceParams,
MakeDefaultPaymentMethodParams,
RemovePaymentMethodParams,
} from '@clerk/types';

import { BaseResource, DeletedObject } from './internal';

export class BillingPaymentSource extends BaseResource implements BillingPaymentSourceResource {
export class BillingPaymentMethod extends BaseResource implements BillingPaymentMethodResource {
id!: string;
last4!: string;
paymentMethod!: string;
paymentType!: 'card' | 'link';
cardType!: string;
isDefault!: boolean;
isRemovable!: boolean;
status!: BillingPaymentSourceStatus;
status!: BillingPaymentMethodStatus;
walletType: string | undefined;

constructor(data: BillingPaymentSourceJSON) {
constructor(data: BillingPaymentMethodJSON) {
super();
this.fromJSON(data);
}

protected fromJSON(data: BillingPaymentSourceJSON | null): this {
protected fromJSON(data: BillingPaymentMethodJSON | null): this {
if (!data) {
return this;
}

this.id = data.id;
this.last4 = data.last4;
this.paymentMethod = data.payment_method;
this.paymentType = data.payment_type;
this.cardType = data.card_type;
this.isDefault = data.is_default;
this.isRemovable = data.is_removable;
Expand All@@ -43,7 +43,7 @@ export class BillingPaymentSource extends BaseResource implements BillingPayment
return this;
}

public async remove(params?: RemovePaymentSourceParams) {
public async remove(params?: RemovePaymentMethodParams) {
const { orgId } = params ?? {};
const json = (
await BaseResource._fetch({
Expand All@@ -57,7 +57,7 @@ export class BillingPaymentSource extends BaseResource implements BillingPayment
return new DeletedObject(json);
}

public async makeDefault(params?: MakeDefaultPaymentSourceParams) {
public async makeDefault(params?: MakeDefaultPaymentMethodParams) {
const { orgId } = params ?? {};
await BaseResource._fetch({
path: orgId
Expand All@@ -71,17 +71,17 @@ export class BillingPaymentSource extends BaseResource implements BillingPayment
}
}

export class BillingInitializedPaymentSource extends BaseResource implements BillingInitializedPaymentSourceResource {
export class BillingInitializedPaymentMethod extends BaseResource implements BillingInitializedPaymentMethodResource {
externalClientSecret!: string;
externalGatewayId!: string;
paymentMethodOrder!: string[];

constructor(data: BillingInitializedPaymentSourceJSON) {
constructor(data: BillingInitializedPaymentMethodJSON) {
super();
this.fromJSON(data);
}

protected fromJSON(data: BillingInitializedPaymentSourceJSON | null): this {
protected fromJSON(data: BillingInitializedPaymentMethodJSON | null): this {
if (!data) {
return this;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/BillingSubscription.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ export class BillingSubscription extends BaseResource implements BillingSubscrip

export class BillingSubscriptionItem extends BaseResource implements BillingSubscriptionItemResource {
id!: string;
paymentSourceId!: string;
paymentMethodId!: string;
plan!: BillingPlan;
planPeriod!: BillingSubscriptionPlanPeriod;
status!: BillingSubscriptionStatus;
Expand All@@ -86,7 +86,7 @@ export class BillingSubscriptionItem extends BaseResource implements BillingSubs
}

this.id = data.id;
this.paymentSourceId = data.payment_source_id;
this.paymentMethodId = data.payment_method_id;
this.plan = new BillingPlan(data.plan);
this.planPeriod = data.plan_period;
this.status = data.status;
Expand Down
14 changes: 7 additions & 7 deletions packages/clerk-js/src/core/resources/Organization.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,7 @@ import type {

import { convertPageToOffsetSearchParams } from '../../utils/convertPageToOffsetSearchParams';
import { unixEpochToDate } from '../../utils/date';
import { addPaymentSource, getPaymentSources, initializePaymentSource } from '../modules/billing';
import { addPaymentMethod, getPaymentMethods, initializePaymentMethod } from '../modules/billing';
import { BaseResource, OrganizationInvitation, OrganizationMembership } from './internal';
import { OrganizationDomain } from './OrganizationDomain';
import { OrganizationMembershipRequest } from './OrganizationMembershipRequest';
Expand DownExpand Up@@ -262,22 +262,22 @@ export class Organization extends BaseResource implements OrganizationResource {
}).then(res => new Organization(res?.response as OrganizationJSON));
};

initializePaymentSource: typeof initializePaymentSource = params => {
return initializePaymentSource({
initializePaymentMethod: typeof initializePaymentMethod = params => {
return initializePaymentMethod({
...params,
orgId: this.id,
});
};

addPaymentSource: typeof addPaymentSource = params => {
return addPaymentSource({
addPaymentMethod: typeof addPaymentMethod = params => {
return addPaymentMethod({
...params,
orgId: this.id,
});
};

getPaymentSources: typeof getPaymentSources = params => {
return getPaymentSources({
getPaymentMethods: typeof getPaymentMethods = params => {
return getPaymentMethods({
...params,
orgId: this.id,
});
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .changeset/rich-breads-move.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
---
'@clerk/clerk-js': minor
'@clerk/shared': patch
'@clerk/types': minor
---

[Billing Beta] Rename payment source to payment method.
Comment thread
panteliselef marked this conversation as resolved.

`Clerk.user.initializePaymentSource()` -> `Clerk.user.initializePaymentMethod()`
`Clerk.user.addPaymentSource()` -> `Clerk.user.addPaymentMethod()`
`Clerk.user.getPaymentSources()` -> `Clerk.user.getPaymentMethods()`

`Clerk.organization.initializePaymentSource()` -> `Clerk.organization.initializePaymentMethod()`
`Clerk.organization.addPaymentSource()` -> `Clerk.organization.addPaymentMethod()`
`Clerk.organization.getPaymentSources()` -> `Clerk.organization.getPaymentMethods()`

22 changes: 11 additions & 11 deletions .typedoc/__tests__/__snapshots__/file-structure.test.ts.snap
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,26 +5,26 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/act-claim.mdx",
"types/act-jwt-claim.mdx",
"types/active-session-resource.mdx",
"types/add-payment-source-params.mdx",
"types/add-payment-method-params.mdx",
"types/billing-checkout-json.mdx",
"types/billing-checkout-resource.mdx",
"types/billing-checkout-totals-json.mdx",
"types/billing-checkout-totals.mdx",
"types/billing-initialized-payment-source-json.mdx",
"types/billing-initialized-payment-source-resource.mdx",
"types/billing-initialized-payment-method-json.mdx",
"types/billing-initialized-payment-method-resource.mdx",
"types/billing-money-amount-json.mdx",
"types/billing-money-amount.mdx",
"types/billing-namespace.mdx",
"types/billing-payer-json.mdx",
"types/billing-payer-methods.mdx",
"types/billing-payer-resource-type.mdx",
"types/billing-payer-resource.mdx",
"types/billing-payment-charge-type.mdx",
"types/billing-payment-json.mdx",
"types/billing-payment-method-json.mdx",
"types/billing-payment-method-resource.mdx",
"types/billing-payment-method-status.mdx",
"types/billing-payment-resource.mdx",
"types/billing-payment-source-json.mdx",
"types/billing-payment-source-methods.mdx",
"types/billing-payment-source-resource.mdx",
"types/billing-payment-source-status.mdx",
"types/billing-payment-status.mdx",
"types/billing-plan-json.mdx",
"types/billing-plan-resource.mdx",
Expand DownExpand Up@@ -72,21 +72,21 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/field-errors.mdx",
"types/for-payer-type.mdx",
"types/get-payment-attempts-params.mdx",
"types/get-payment-sources-params.mdx",
"types/get-payment-methods-params.mdx",
"types/get-plans-params.mdx",
"types/get-statements-params.mdx",
"types/get-subscription-params.mdx",
"types/get-token.mdx",
"types/id-selectors.mdx",
"types/initialize-payment-source-params.mdx",
"types/initialize-payment-method-params.mdx",
"types/internal_checkout-props.mdx",
"types/internal_plan-details-props.mdx",
"types/internal_subscription-details-props.mdx",
"types/jwt-claims.mdx",
"types/jwt-header.mdx",
"types/legacy-redirect-props.mdx",
"types/localization-resource.mdx",
"types/make-default-payment-source-params.mdx",
"types/make-default-payment-method-params.mdx",
"types/multi-domain-and-or-proxy.mdx",
"types/organization-custom-role-key.mdx",
"types/organization-domain-resource.mdx",
Expand All@@ -109,7 +109,7 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/protect-props.mdx",
"types/record-to-path.mdx",
"types/redirect-options.mdx",
"types/remove-payment-source-params.mdx",
"types/remove-payment-method-params.mdx",
"types/reverification-config.mdx",
"types/saml-strategy.mdx",
"types/sdk-metadata.mdx",
Expand Down
7 changes: 7 additions & 0 deletions packages/clerk-js/src/core/modules/billing/namespace.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,13 @@ import {
} from '../../resources/internal';

export class Billing implements BillingNamespace {
static readonly #pathRoot = '/commerce';
static path(subPath: string, param?: { orgId?: string }): string {
const { orgId } = param || {};
const prefix = orgId ? `/organizations/${orgId}` : '/me';
return `${prefix}${Billing.#pathRoot}${subPath}`;
}

getPlans = async (params?: GetPlansParams): Promise<ClerkPaginatedResponse<BillingPlanResource>> => {
const { for: forParam, ...safeParams } = params || {};
const searchParams = { ...safeParams, payer_type: forParam === 'organization' ? 'org' : 'user' };
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,55 +1,56 @@
import type {
AddPaymentSourceParams,
BillingInitializedPaymentSourceJSON,
BillingPaymentSourceJSON,
AddPaymentMethodParams,
BillingInitializedPaymentMethodJSON,
BillingPaymentMethodJSON,
ClerkPaginatedResponse,
GetPaymentSourcesParams,
InitializePaymentSourceParams,
GetPaymentMethodsParams,
InitializePaymentMethodParams,
} from '@clerk/types';

import { convertPageToOffsetSearchParams } from '../../../utils/convertPageToOffsetSearchParams';
import { BaseResource, BillingInitializedPaymentSource, BillingPaymentSource } from '../../resources/internal';
import { BaseResource, BillingInitializedPaymentMethod, BillingPaymentMethod } from '../../resources/internal';
import { Billing } from './namespace';

export const initializePaymentSource = async (params: InitializePaymentSourceParams) => {
const PAYMENT_METHODS_PATH = '/payment_methods';

export const initializePaymentMethod = async (params: InitializePaymentMethodParams) => {
const { orgId, ...rest } = params;
const json = (
await BaseResource._fetch({
path: orgId
? `/organizations/${orgId}/commerce/payment_sources/initialize`
: `/me/commerce/payment_sources/initialize`,
path: Billing.path(`${PAYMENT_METHODS_PATH}/initialize`, { orgId }),
method: 'POST',
body: rest as any,
})
)?.response as unknown as BillingInitializedPaymentSourceJSON;
return new BillingInitializedPaymentSource(json);
)?.response as unknown as BillingInitializedPaymentMethodJSON;
return new BillingInitializedPaymentMethod(json);
};

export const addPaymentSource = async (params: AddPaymentSourceParams) => {
export const addPaymentMethod = async (params: AddPaymentMethodParams) => {
const { orgId, ...rest } = params;

const json = (
await BaseResource._fetch({
path: orgId ? `/organizations/${orgId}/commerce/payment_sources` : `/me/commerce/payment_sources`,
path: Billing.path(PAYMENT_METHODS_PATH, { orgId }),
method: 'POST',
body: rest as any,
})
)?.response as unknown as BillingPaymentSourceJSON;
return new BillingPaymentSource(json);
)?.response as unknown as BillingPaymentMethodJSON;
return new BillingPaymentMethod(json);
};

export const getPaymentSources = async (params: GetPaymentSourcesParams) => {
export const getPaymentMethods = async (params: GetPaymentMethodsParams) => {
const { orgId, ...rest } = params;

return await BaseResource._fetch({
path: orgId ? `/organizations/${orgId}/commerce/payment_sources` : `/me/commerce/payment_sources`,
path: Billing.path(PAYMENT_METHODS_PATH, { orgId }),
method: 'GET',
search: convertPageToOffsetSearchParams(rest),
}).then(res => {
const { data: paymentSources, total_count } =
res?.response as unknown as ClerkPaginatedResponse<BillingPaymentSourceJSON>;
res?.response as unknown as ClerkPaginatedResponse<BillingPaymentMethodJSON>;
return {
total_count,
data: paymentSources.map(paymentSource => new BillingPaymentSource(paymentSource)),
data: paymentSources.map(paymentMethod => new BillingPaymentMethod(paymentMethod)),
};
});
};
7 changes: 4 additions & 3 deletions packages/clerk-js/src/core/resources/BillingCheckout.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@ import type {
BillingCheckoutResource,
BillingCheckoutTotals,
BillingPayerResource,
BillingPaymentMethodResource,
BillingSubscriptionPlanPeriod,
ConfirmCheckoutParams,
} from '@clerk/types';
Expand All@@ -13,13 +14,13 @@ import { unixEpochToDate } from '@/utils/date';

import { billingTotalsFromJSON } from '../../utils';
import { BillingPayer } from './BillingPayer';
import { BaseResource, BillingPaymentSource, BillingPlan } from './internal';
import { BaseResource, BillingPaymentMethod, BillingPlan } from './internal';

export class BillingCheckout extends BaseResource implements BillingCheckoutResource {
id!: string;
externalClientSecret!: string;
externalGatewayId!: string;
paymentSource?: BillingPaymentSource;
paymentMethod?: BillingPaymentMethodResource;
plan!: BillingPlan;
planPeriod!: BillingSubscriptionPlanPeriod;
planPeriodStart!: number | undefined;
Expand All@@ -42,7 +43,7 @@ export class BillingCheckout extends BaseResource implements BillingCheckoutReso
this.id = data.id;
this.externalClientSecret = data.external_client_secret;
this.externalGatewayId = data.external_gateway_id;
this.paymentSource = data.payment_source ? new BillingPaymentSource(data.payment_source) : undefined;
this.paymentMethod = data.payment_method ? new BillingPaymentMethod(data.payment_method) : undefined;
this.plan = new BillingPlan(data.plan);
this.planPeriod = data.plan_period;
this.planPeriodStart = data.plan_period_start;
Expand Down
8 changes: 4 additions & 4 deletions packages/clerk-js/src/core/resources/BillingPayment.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,23 +2,23 @@ import type {
BillingMoneyAmount,
BillingPaymentChargeType,
BillingPaymentJSON,
BillingPaymentMethodResource,
BillingPaymentResource,
BillingPaymentSourceResource,
BillingPaymentStatus,
BillingSubscriptionItemResource,
} from '@clerk/types';

import { billingMoneyAmountFromJSON } from '../../utils';
import { unixEpochToDate } from '../../utils/date';
import { BaseResource, BillingPaymentSource, BillingSubscriptionItem } from './internal';
import { BaseResource, BillingPaymentMethod, BillingSubscriptionItem } from './internal';

export class BillingPayment extends BaseResource implements BillingPaymentResource {
id!: string;
amount!: BillingMoneyAmount;
failedAt?: Date;
paidAt?: Date;
updatedAt!: Date;
paymentSource!: BillingPaymentSourceResource;
paymentMethod!: BillingPaymentMethodResource;
subscriptionItem!: BillingSubscriptionItemResource;
chargeType!: BillingPaymentChargeType;
status!: BillingPaymentStatus;
Expand All@@ -38,7 +38,7 @@ export class BillingPayment extends BaseResource implements BillingPaymentResour
this.paidAt = data.paid_at ? unixEpochToDate(data.paid_at) : undefined;
this.failedAt = data.failed_at ? unixEpochToDate(data.failed_at) : undefined;
this.updatedAt = unixEpochToDate(data.updated_at);
this.paymentSource = new BillingPaymentSource(data.payment_source);
this.paymentMethod = new BillingPaymentMethod(data.payment_method);
this.subscriptionItem = new BillingSubscriptionItem(data.subscription_item);
this.chargeType = data.charge_type;
this.status = data.status;
Expand Down
36 changes: 18 additions & 18 deletions packages/clerk-js/src/core/resources/BillingPaymentSource.ts
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,39 @@
import type {
BillingInitializedPaymentSourceJSON,
BillingInitializedPaymentSourceResource,
BillingPaymentSourceJSON,
BillingPaymentSourceResource,
BillingPaymentSourceStatus,
BillingInitializedPaymentMethodJSON,
BillingInitializedPaymentMethodResource,
BillingPaymentMethodJSON,
BillingPaymentMethodResource,
BillingPaymentMethodStatus,
DeletedObjectJSON,
MakeDefaultPaymentSourceParams,
RemovePaymentSourceParams,
MakeDefaultPaymentMethodParams,
RemovePaymentMethodParams,
} from '@clerk/types';

import { BaseResource, DeletedObject } from './internal';

export class BillingPaymentSource extends BaseResource implements BillingPaymentSourceResource {
export class BillingPaymentMethod extends BaseResource implements BillingPaymentMethodResource {
id!: string;
last4!: string;
paymentMethod!: string;
paymentType!: 'card' | 'link';
cardType!: string;
isDefault!: boolean;
isRemovable!: boolean;
status!: BillingPaymentSourceStatus;
status!: BillingPaymentMethodStatus;
walletType: string | undefined;

constructor(data: BillingPaymentSourceJSON) {
constructor(data: BillingPaymentMethodJSON) {
super();
this.fromJSON(data);
}

protected fromJSON(data: BillingPaymentSourceJSON | null): this {
protected fromJSON(data: BillingPaymentMethodJSON | null): this {
if (!data) {
return this;
}

this.id = data.id;
this.last4 = data.last4;
this.paymentMethod = data.payment_method;
this.paymentType = data.payment_type;
this.cardType = data.card_type;
this.isDefault = data.is_default;
this.isRemovable = data.is_removable;
Expand All@@ -43,7 +43,7 @@ export class BillingPaymentSource extends BaseResource implements BillingPayment
return this;
}

public async remove(params?: RemovePaymentSourceParams) {
public async remove(params?: RemovePaymentMethodParams) {
const { orgId } = params ?? {};
const json = (
await BaseResource._fetch({
Expand All@@ -57,7 +57,7 @@ export class BillingPaymentSource extends BaseResource implements BillingPayment
return new DeletedObject(json);
}

public async makeDefault(params?: MakeDefaultPaymentSourceParams) {
public async makeDefault(params?: MakeDefaultPaymentMethodParams) {
const { orgId } = params ?? {};
await BaseResource._fetch({
path: orgId
Expand All@@ -71,17 +71,17 @@ export class BillingPaymentSource extends BaseResource implements BillingPayment
}
}

export class BillingInitializedPaymentSource extends BaseResource implements BillingInitializedPaymentSourceResource {
export class BillingInitializedPaymentMethod extends BaseResource implements BillingInitializedPaymentMethodResource {
externalClientSecret!: string;
externalGatewayId!: string;
paymentMethodOrder!: string[];

constructor(data: BillingInitializedPaymentSourceJSON) {
constructor(data: BillingInitializedPaymentMethodJSON) {
super();
this.fromJSON(data);
}

protected fromJSON(data: BillingInitializedPaymentSourceJSON | null): this {
protected fromJSON(data: BillingInitializedPaymentMethodJSON | null): this {
if (!data) {
return this;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/BillingSubscription.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ export class BillingSubscription extends BaseResource implements BillingSubscrip

export class BillingSubscriptionItem extends BaseResource implements BillingSubscriptionItemResource {
id!: string;
paymentSourceId!: string;
paymentMethodId!: string;
plan!: BillingPlan;
planPeriod!: BillingSubscriptionPlanPeriod;
status!: BillingSubscriptionStatus;
Expand All@@ -86,7 +86,7 @@ export class BillingSubscriptionItem extends BaseResource implements BillingSubs
}

this.id = data.id;
this.paymentSourceId = data.payment_source_id;
this.paymentMethodId = data.payment_method_id;
this.plan = new BillingPlan(data.plan);
this.planPeriod = data.plan_period;
this.status = data.status;
Expand Down
14 changes: 7 additions & 7 deletions packages/clerk-js/src/core/resources/Organization.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,7 @@ import type {

import { convertPageToOffsetSearchParams } from '../../utils/convertPageToOffsetSearchParams';
import { unixEpochToDate } from '../../utils/date';
import { addPaymentSource, getPaymentSources, initializePaymentSource } from '../modules/billing';
import { addPaymentMethod, getPaymentMethods, initializePaymentMethod } from '../modules/billing';
import { BaseResource, OrganizationInvitation, OrganizationMembership } from './internal';
import { OrganizationDomain } from './OrganizationDomain';
import { OrganizationMembershipRequest } from './OrganizationMembershipRequest';
Expand DownExpand Up@@ -262,22 +262,22 @@ export class Organization extends BaseResource implements OrganizationResource {
}).then(res => new Organization(res?.response as OrganizationJSON));
};

initializePaymentSource: typeof initializePaymentSource = params => {
return initializePaymentSource({
initializePaymentMethod: typeof initializePaymentMethod = params => {
return initializePaymentMethod({
...params,
orgId: this.id,
});
};

addPaymentSource: typeof addPaymentSource = params => {
return addPaymentSource({
addPaymentMethod: typeof addPaymentMethod = params => {
return addPaymentMethod({
...params,
orgId: this.id,
});
};

getPaymentSources: typeof getPaymentSources = params => {
return getPaymentSources({
getPaymentMethods: typeof getPaymentMethods = params => {
return getPaymentMethods({
...params,
orgId: this.id,
});
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .changeset/rich-breads-move.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
---
'@clerk/clerk-js': minor
'@clerk/shared': patch
'@clerk/types': minor
---

[Billing Beta] Rename payment source to payment method.
Comment thread
panteliselef marked this conversation as resolved.

`Clerk.user.initializePaymentSource()` -> `Clerk.user.initializePaymentMethod()`
`Clerk.user.addPaymentSource()` -> `Clerk.user.addPaymentMethod()`
`Clerk.user.getPaymentSources()` -> `Clerk.user.getPaymentMethods()`

`Clerk.organization.initializePaymentSource()` -> `Clerk.organization.initializePaymentMethod()`
`Clerk.organization.addPaymentSource()` -> `Clerk.organization.addPaymentMethod()`
`Clerk.organization.getPaymentSources()` -> `Clerk.organization.getPaymentMethods()`

22 changes: 11 additions & 11 deletions .typedoc/__tests__/__snapshots__/file-structure.test.ts.snap
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,26 +5,26 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/act-claim.mdx",
"types/act-jwt-claim.mdx",
"types/active-session-resource.mdx",
"types/add-payment-source-params.mdx",
"types/add-payment-method-params.mdx",
"types/billing-checkout-json.mdx",
"types/billing-checkout-resource.mdx",
"types/billing-checkout-totals-json.mdx",
"types/billing-checkout-totals.mdx",
"types/billing-initialized-payment-source-json.mdx",
"types/billing-initialized-payment-source-resource.mdx",
"types/billing-initialized-payment-method-json.mdx",
"types/billing-initialized-payment-method-resource.mdx",
"types/billing-money-amount-json.mdx",
"types/billing-money-amount.mdx",
"types/billing-namespace.mdx",
"types/billing-payer-json.mdx",
"types/billing-payer-methods.mdx",
"types/billing-payer-resource-type.mdx",
"types/billing-payer-resource.mdx",
"types/billing-payment-charge-type.mdx",
"types/billing-payment-json.mdx",
"types/billing-payment-method-json.mdx",
"types/billing-payment-method-resource.mdx",
"types/billing-payment-method-status.mdx",
"types/billing-payment-resource.mdx",
"types/billing-payment-source-json.mdx",
"types/billing-payment-source-methods.mdx",
"types/billing-payment-source-resource.mdx",
"types/billing-payment-source-status.mdx",
"types/billing-payment-status.mdx",
"types/billing-plan-json.mdx",
"types/billing-plan-resource.mdx",
Expand DownExpand Up@@ -72,21 +72,21 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/field-errors.mdx",
"types/for-payer-type.mdx",
"types/get-payment-attempts-params.mdx",
"types/get-payment-sources-params.mdx",
"types/get-payment-methods-params.mdx",
"types/get-plans-params.mdx",
"types/get-statements-params.mdx",
"types/get-subscription-params.mdx",
"types/get-token.mdx",
"types/id-selectors.mdx",
"types/initialize-payment-source-params.mdx",
"types/initialize-payment-method-params.mdx",
"types/internal_checkout-props.mdx",
"types/internal_plan-details-props.mdx",
"types/internal_subscription-details-props.mdx",
"types/jwt-claims.mdx",
"types/jwt-header.mdx",
"types/legacy-redirect-props.mdx",
"types/localization-resource.mdx",
"types/make-default-payment-source-params.mdx",
"types/make-default-payment-method-params.mdx",
"types/multi-domain-and-or-proxy.mdx",
"types/organization-custom-role-key.mdx",
"types/organization-domain-resource.mdx",
Expand All@@ -109,7 +109,7 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/protect-props.mdx",
"types/record-to-path.mdx",
"types/redirect-options.mdx",
"types/remove-payment-source-params.mdx",
"types/remove-payment-method-params.mdx",
"types/reverification-config.mdx",
"types/saml-strategy.mdx",
"types/sdk-metadata.mdx",
Expand Down
7 changes: 7 additions & 0 deletions packages/clerk-js/src/core/modules/billing/namespace.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,13 @@ import {
} from '../../resources/internal';

export class Billing implements BillingNamespace {
static readonly #pathRoot = '/commerce';
static path(subPath: string, param?: { orgId?: string }): string {
const { orgId } = param || {};
const prefix = orgId ? `/organizations/${orgId}` : '/me';
return `${prefix}${Billing.#pathRoot}${subPath}`;
}

getPlans = async (params?: GetPlansParams): Promise<ClerkPaginatedResponse<BillingPlanResource>> => {
const { for: forParam, ...safeParams } = params || {};
const searchParams = { ...safeParams, payer_type: forParam === 'organization' ? 'org' : 'user' };
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,55 +1,56 @@
import type {
AddPaymentSourceParams,
BillingInitializedPaymentSourceJSON,
BillingPaymentSourceJSON,
AddPaymentMethodParams,
BillingInitializedPaymentMethodJSON,
BillingPaymentMethodJSON,
ClerkPaginatedResponse,
GetPaymentSourcesParams,
InitializePaymentSourceParams,
GetPaymentMethodsParams,
InitializePaymentMethodParams,
} from '@clerk/types';

import { convertPageToOffsetSearchParams } from '../../../utils/convertPageToOffsetSearchParams';
import { BaseResource, BillingInitializedPaymentSource, BillingPaymentSource } from '../../resources/internal';
import { BaseResource, BillingInitializedPaymentMethod, BillingPaymentMethod } from '../../resources/internal';
import { Billing } from './namespace';

export const initializePaymentSource = async (params: InitializePaymentSourceParams) => {
const PAYMENT_METHODS_PATH = '/payment_methods';

export const initializePaymentMethod = async (params: InitializePaymentMethodParams) => {
const { orgId, ...rest } = params;
const json = (
await BaseResource._fetch({
path: orgId
? `/organizations/${orgId}/commerce/payment_sources/initialize`
: `/me/commerce/payment_sources/initialize`,
path: Billing.path(`${PAYMENT_METHODS_PATH}/initialize`, { orgId }),
method: 'POST',
body: rest as any,
})
)?.response as unknown as BillingInitializedPaymentSourceJSON;
return new BillingInitializedPaymentSource(json);
)?.response as unknown as BillingInitializedPaymentMethodJSON;
return new BillingInitializedPaymentMethod(json);
};

export const addPaymentSource = async (params: AddPaymentSourceParams) => {
export const addPaymentMethod = async (params: AddPaymentMethodParams) => {
const { orgId, ...rest } = params;

const json = (
await BaseResource._fetch({
path: orgId ? `/organizations/${orgId}/commerce/payment_sources` : `/me/commerce/payment_sources`,
path: Billing.path(PAYMENT_METHODS_PATH, { orgId }),
method: 'POST',
body: rest as any,
})
)?.response as unknown as BillingPaymentSourceJSON;
return new BillingPaymentSource(json);
)?.response as unknown as BillingPaymentMethodJSON;
return new BillingPaymentMethod(json);
};

export const getPaymentSources = async (params: GetPaymentSourcesParams) => {
export const getPaymentMethods = async (params: GetPaymentMethodsParams) => {
const { orgId, ...rest } = params;

return await BaseResource._fetch({
path: orgId ? `/organizations/${orgId}/commerce/payment_sources` : `/me/commerce/payment_sources`,
path: Billing.path(PAYMENT_METHODS_PATH, { orgId }),
method: 'GET',
search: convertPageToOffsetSearchParams(rest),
}).then(res => {
const { data: paymentSources, total_count } =
res?.response as unknown as ClerkPaginatedResponse<BillingPaymentSourceJSON>;
res?.response as unknown as ClerkPaginatedResponse<BillingPaymentMethodJSON>;
return {
total_count,
data: paymentSources.map(paymentSource => new BillingPaymentSource(paymentSource)),
data: paymentSources.map(paymentMethod => new BillingPaymentMethod(paymentMethod)),
};
});
};
7 changes: 4 additions & 3 deletions packages/clerk-js/src/core/resources/BillingCheckout.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@ import type {
BillingCheckoutResource,
BillingCheckoutTotals,
BillingPayerResource,
BillingPaymentMethodResource,
BillingSubscriptionPlanPeriod,
ConfirmCheckoutParams,
} from '@clerk/types';
Expand All@@ -13,13 +14,13 @@ import { unixEpochToDate } from '@/utils/date';

import { billingTotalsFromJSON } from '../../utils';
import { BillingPayer } from './BillingPayer';
import { BaseResource, BillingPaymentSource, BillingPlan } from './internal';
import { BaseResource, BillingPaymentMethod, BillingPlan } from './internal';

export class BillingCheckout extends BaseResource implements BillingCheckoutResource {
id!: string;
externalClientSecret!: string;
externalGatewayId!: string;
paymentSource?: BillingPaymentSource;
paymentMethod?: BillingPaymentMethodResource;
plan!: BillingPlan;
planPeriod!: BillingSubscriptionPlanPeriod;
planPeriodStart!: number | undefined;
Expand All@@ -42,7 +43,7 @@ export class BillingCheckout extends BaseResource implements BillingCheckoutReso
this.id = data.id;
this.externalClientSecret = data.external_client_secret;
this.externalGatewayId = data.external_gateway_id;
this.paymentSource = data.payment_source ? new BillingPaymentSource(data.payment_source) : undefined;
this.paymentMethod = data.payment_method ? new BillingPaymentMethod(data.payment_method) : undefined;
this.plan = new BillingPlan(data.plan);
this.planPeriod = data.plan_period;
this.planPeriodStart = data.plan_period_start;
Expand Down
8 changes: 4 additions & 4 deletions packages/clerk-js/src/core/resources/BillingPayment.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,23 +2,23 @@ import type {
BillingMoneyAmount,
BillingPaymentChargeType,
BillingPaymentJSON,
BillingPaymentMethodResource,
BillingPaymentResource,
BillingPaymentSourceResource,
BillingPaymentStatus,
BillingSubscriptionItemResource,
} from '@clerk/types';

import { billingMoneyAmountFromJSON } from '../../utils';
import { unixEpochToDate } from '../../utils/date';
import { BaseResource, BillingPaymentSource, BillingSubscriptionItem } from './internal';
import { BaseResource, BillingPaymentMethod, BillingSubscriptionItem } from './internal';

export class BillingPayment extends BaseResource implements BillingPaymentResource {
id!: string;
amount!: BillingMoneyAmount;
failedAt?: Date;
paidAt?: Date;
updatedAt!: Date;
paymentSource!: BillingPaymentSourceResource;
paymentMethod!: BillingPaymentMethodResource;
subscriptionItem!: BillingSubscriptionItemResource;
chargeType!: BillingPaymentChargeType;
status!: BillingPaymentStatus;
Expand All@@ -38,7 +38,7 @@ export class BillingPayment extends BaseResource implements BillingPaymentResour
this.paidAt = data.paid_at ? unixEpochToDate(data.paid_at) : undefined;
this.failedAt = data.failed_at ? unixEpochToDate(data.failed_at) : undefined;
this.updatedAt = unixEpochToDate(data.updated_at);
this.paymentSource = new BillingPaymentSource(data.payment_source);
this.paymentMethod = new BillingPaymentMethod(data.payment_method);
this.subscriptionItem = new BillingSubscriptionItem(data.subscription_item);
this.chargeType = data.charge_type;
this.status = data.status;
Expand Down
36 changes: 18 additions & 18 deletions packages/clerk-js/src/core/resources/BillingPaymentSource.ts
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,39 @@
import type {
BillingInitializedPaymentSourceJSON,
BillingInitializedPaymentSourceResource,
BillingPaymentSourceJSON,
BillingPaymentSourceResource,
BillingPaymentSourceStatus,
BillingInitializedPaymentMethodJSON,
BillingInitializedPaymentMethodResource,
BillingPaymentMethodJSON,
BillingPaymentMethodResource,
BillingPaymentMethodStatus,
DeletedObjectJSON,
MakeDefaultPaymentSourceParams,
RemovePaymentSourceParams,
MakeDefaultPaymentMethodParams,
RemovePaymentMethodParams,
} from '@clerk/types';

import { BaseResource, DeletedObject } from './internal';

export class BillingPaymentSource extends BaseResource implements BillingPaymentSourceResource {
export class BillingPaymentMethod extends BaseResource implements BillingPaymentMethodResource {
id!: string;
last4!: string;
paymentMethod!: string;
paymentType!: 'card' | 'link';
cardType!: string;
isDefault!: boolean;
isRemovable!: boolean;
status!: BillingPaymentSourceStatus;
status!: BillingPaymentMethodStatus;
walletType: string | undefined;

constructor(data: BillingPaymentSourceJSON) {
constructor(data: BillingPaymentMethodJSON) {
super();
this.fromJSON(data);
}

protected fromJSON(data: BillingPaymentSourceJSON | null): this {
protected fromJSON(data: BillingPaymentMethodJSON | null): this {
if (!data) {
return this;
}

this.id = data.id;
this.last4 = data.last4;
this.paymentMethod = data.payment_method;
this.paymentType = data.payment_type;
this.cardType = data.card_type;
this.isDefault = data.is_default;
this.isRemovable = data.is_removable;
Expand All@@ -43,7 +43,7 @@ export class BillingPaymentSource extends BaseResource implements BillingPayment
return this;
}

public async remove(params?: RemovePaymentSourceParams) {
public async remove(params?: RemovePaymentMethodParams) {
const { orgId } = params ?? {};
const json = (
await BaseResource._fetch({
Expand All@@ -57,7 +57,7 @@ export class BillingPaymentSource extends BaseResource implements BillingPayment
return new DeletedObject(json);
}

public async makeDefault(params?: MakeDefaultPaymentSourceParams) {
public async makeDefault(params?: MakeDefaultPaymentMethodParams) {
const { orgId } = params ?? {};
await BaseResource._fetch({
path: orgId
Expand All@@ -71,17 +71,17 @@ export class BillingPaymentSource extends BaseResource implements BillingPayment
}
}

export class BillingInitializedPaymentSource extends BaseResource implements BillingInitializedPaymentSourceResource {
export class BillingInitializedPaymentMethod extends BaseResource implements BillingInitializedPaymentMethodResource {
externalClientSecret!: string;
externalGatewayId!: string;
paymentMethodOrder!: string[];

constructor(data: BillingInitializedPaymentSourceJSON) {
constructor(data: BillingInitializedPaymentMethodJSON) {
super();
this.fromJSON(data);
}

protected fromJSON(data: BillingInitializedPaymentSourceJSON | null): this {
protected fromJSON(data: BillingInitializedPaymentMethodJSON | null): this {
if (!data) {
return this;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/BillingSubscription.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ export class BillingSubscription extends BaseResource implements BillingSubscrip

export class BillingSubscriptionItem extends BaseResource implements BillingSubscriptionItemResource {
id!: string;
paymentSourceId!: string;
paymentMethodId!: string;
plan!: BillingPlan;
planPeriod!: BillingSubscriptionPlanPeriod;
status!: BillingSubscriptionStatus;
Expand All@@ -86,7 +86,7 @@ export class BillingSubscriptionItem extends BaseResource implements BillingSubs
}

this.id = data.id;
this.paymentSourceId = data.payment_source_id;
this.paymentMethodId = data.payment_method_id;
this.plan = new BillingPlan(data.plan);
this.planPeriod = data.plan_period;
this.status = data.status;
Expand Down
14 changes: 7 additions & 7 deletions packages/clerk-js/src/core/resources/Organization.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,7 @@ import type {

import { convertPageToOffsetSearchParams } from '../../utils/convertPageToOffsetSearchParams';
import { unixEpochToDate } from '../../utils/date';
import { addPaymentSource, getPaymentSources, initializePaymentSource } from '../modules/billing';
import { addPaymentMethod, getPaymentMethods, initializePaymentMethod } from '../modules/billing';
import { BaseResource, OrganizationInvitation, OrganizationMembership } from './internal';
import { OrganizationDomain } from './OrganizationDomain';
import { OrganizationMembershipRequest } from './OrganizationMembershipRequest';
Expand DownExpand Up@@ -262,22 +262,22 @@ export class Organization extends BaseResource implements OrganizationResource {
}).then(res => new Organization(res?.response as OrganizationJSON));
};

initializePaymentSource: typeof initializePaymentSource = params => {
return initializePaymentSource({
initializePaymentMethod: typeof initializePaymentMethod = params => {
return initializePaymentMethod({
...params,
orgId: this.id,
});
};

addPaymentSource: typeof addPaymentSource = params => {
return addPaymentSource({
addPaymentMethod: typeof addPaymentMethod = params => {
return addPaymentMethod({
...params,
orgId: this.id,
});
};

getPaymentSources: typeof getPaymentSources = params => {
return getPaymentSources({
getPaymentMethods: typeof getPaymentMethods = params => {
return getPaymentMethods({
...params,
orgId: this.id,
});
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .changeset/rich-breads-move.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
---
'@clerk/clerk-js': minor
'@clerk/shared': patch
'@clerk/types': minor
---

[Billing Beta] Rename payment source to payment method.
Comment thread
panteliselef marked this conversation as resolved.

`Clerk.user.initializePaymentSource()` -> `Clerk.user.initializePaymentMethod()`
`Clerk.user.addPaymentSource()` -> `Clerk.user.addPaymentMethod()`
`Clerk.user.getPaymentSources()` -> `Clerk.user.getPaymentMethods()`

`Clerk.organization.initializePaymentSource()` -> `Clerk.organization.initializePaymentMethod()`
`Clerk.organization.addPaymentSource()` -> `Clerk.organization.addPaymentMethod()`
`Clerk.organization.getPaymentSources()` -> `Clerk.organization.getPaymentMethods()`

22 changes: 11 additions & 11 deletions .typedoc/__tests__/__snapshots__/file-structure.test.ts.snap
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,26 +5,26 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/act-claim.mdx",
"types/act-jwt-claim.mdx",
"types/active-session-resource.mdx",
"types/add-payment-source-params.mdx",
"types/add-payment-method-params.mdx",
"types/billing-checkout-json.mdx",
"types/billing-checkout-resource.mdx",
"types/billing-checkout-totals-json.mdx",
"types/billing-checkout-totals.mdx",
"types/billing-initialized-payment-source-json.mdx",
"types/billing-initialized-payment-source-resource.mdx",
"types/billing-initialized-payment-method-json.mdx",
"types/billing-initialized-payment-method-resource.mdx",
"types/billing-money-amount-json.mdx",
"types/billing-money-amount.mdx",
"types/billing-namespace.mdx",
"types/billing-payer-json.mdx",
"types/billing-payer-methods.mdx",
"types/billing-payer-resource-type.mdx",
"types/billing-payer-resource.mdx",
"types/billing-payment-charge-type.mdx",
"types/billing-payment-json.mdx",
"types/billing-payment-method-json.mdx",
"types/billing-payment-method-resource.mdx",
"types/billing-payment-method-status.mdx",
"types/billing-payment-resource.mdx",
"types/billing-payment-source-json.mdx",
"types/billing-payment-source-methods.mdx",
"types/billing-payment-source-resource.mdx",
"types/billing-payment-source-status.mdx",
"types/billing-payment-status.mdx",
"types/billing-plan-json.mdx",
"types/billing-plan-resource.mdx",
Expand DownExpand Up@@ -72,21 +72,21 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/field-errors.mdx",
"types/for-payer-type.mdx",
"types/get-payment-attempts-params.mdx",
"types/get-payment-sources-params.mdx",
"types/get-payment-methods-params.mdx",
"types/get-plans-params.mdx",
"types/get-statements-params.mdx",
"types/get-subscription-params.mdx",
"types/get-token.mdx",
"types/id-selectors.mdx",
"types/initialize-payment-source-params.mdx",
"types/initialize-payment-method-params.mdx",
"types/internal_checkout-props.mdx",
"types/internal_plan-details-props.mdx",
"types/internal_subscription-details-props.mdx",
"types/jwt-claims.mdx",
"types/jwt-header.mdx",
"types/legacy-redirect-props.mdx",
"types/localization-resource.mdx",
"types/make-default-payment-source-params.mdx",
"types/make-default-payment-method-params.mdx",
"types/multi-domain-and-or-proxy.mdx",
"types/organization-custom-role-key.mdx",
"types/organization-domain-resource.mdx",
Expand All@@ -109,7 +109,7 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/protect-props.mdx",
"types/record-to-path.mdx",
"types/redirect-options.mdx",
"types/remove-payment-source-params.mdx",
"types/remove-payment-method-params.mdx",
"types/reverification-config.mdx",
"types/saml-strategy.mdx",
"types/sdk-metadata.mdx",
Expand Down
7 changes: 7 additions & 0 deletions packages/clerk-js/src/core/modules/billing/namespace.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,13 @@ import {
} from '../../resources/internal';

export class Billing implements BillingNamespace {
static readonly #pathRoot = '/commerce';
static path(subPath: string, param?: { orgId?: string }): string {
const { orgId } = param || {};
const prefix = orgId ? `/organizations/${orgId}` : '/me';
return `${prefix}${Billing.#pathRoot}${subPath}`;
}

getPlans = async (params?: GetPlansParams): Promise<ClerkPaginatedResponse<BillingPlanResource>> => {
const { for: forParam, ...safeParams } = params || {};
const searchParams = { ...safeParams, payer_type: forParam === 'organization' ? 'org' : 'user' };
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,55 +1,56 @@
import type {
AddPaymentSourceParams,
BillingInitializedPaymentSourceJSON,
BillingPaymentSourceJSON,
AddPaymentMethodParams,
BillingInitializedPaymentMethodJSON,
BillingPaymentMethodJSON,
ClerkPaginatedResponse,
GetPaymentSourcesParams,
InitializePaymentSourceParams,
GetPaymentMethodsParams,
InitializePaymentMethodParams,
} from '@clerk/types';

import { convertPageToOffsetSearchParams } from '../../../utils/convertPageToOffsetSearchParams';
import { BaseResource, BillingInitializedPaymentSource, BillingPaymentSource } from '../../resources/internal';
import { BaseResource, BillingInitializedPaymentMethod, BillingPaymentMethod } from '../../resources/internal';
import { Billing } from './namespace';

export const initializePaymentSource = async (params: InitializePaymentSourceParams) => {
const PAYMENT_METHODS_PATH = '/payment_methods';

export const initializePaymentMethod = async (params: InitializePaymentMethodParams) => {
const { orgId, ...rest } = params;
const json = (
await BaseResource._fetch({
path: orgId
? `/organizations/${orgId}/commerce/payment_sources/initialize`
: `/me/commerce/payment_sources/initialize`,
path: Billing.path(`${PAYMENT_METHODS_PATH}/initialize`, { orgId }),
method: 'POST',
body: rest as any,
})
)?.response as unknown as BillingInitializedPaymentSourceJSON;
return new BillingInitializedPaymentSource(json);
)?.response as unknown as BillingInitializedPaymentMethodJSON;
return new BillingInitializedPaymentMethod(json);
};

export const addPaymentSource = async (params: AddPaymentSourceParams) => {
export const addPaymentMethod = async (params: AddPaymentMethodParams) => {
const { orgId, ...rest } = params;

const json = (
await BaseResource._fetch({
path: orgId ? `/organizations/${orgId}/commerce/payment_sources` : `/me/commerce/payment_sources`,
path: Billing.path(PAYMENT_METHODS_PATH, { orgId }),
method: 'POST',
body: rest as any,
})
)?.response as unknown as BillingPaymentSourceJSON;
return new BillingPaymentSource(json);
)?.response as unknown as BillingPaymentMethodJSON;
return new BillingPaymentMethod(json);
};

export const getPaymentSources = async (params: GetPaymentSourcesParams) => {
export const getPaymentMethods = async (params: GetPaymentMethodsParams) => {
const { orgId, ...rest } = params;

return await BaseResource._fetch({
path: orgId ? `/organizations/${orgId}/commerce/payment_sources` : `/me/commerce/payment_sources`,
path: Billing.path(PAYMENT_METHODS_PATH, { orgId }),
method: 'GET',
search: convertPageToOffsetSearchParams(rest),
}).then(res => {
const { data: paymentSources, total_count } =
res?.response as unknown as ClerkPaginatedResponse<BillingPaymentSourceJSON>;
res?.response as unknown as ClerkPaginatedResponse<BillingPaymentMethodJSON>;
return {
total_count,
data: paymentSources.map(paymentSource => new BillingPaymentSource(paymentSource)),
data: paymentSources.map(paymentMethod => new BillingPaymentMethod(paymentMethod)),
};
});
};
7 changes: 4 additions & 3 deletions packages/clerk-js/src/core/resources/BillingCheckout.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@ import type {
BillingCheckoutResource,
BillingCheckoutTotals,
BillingPayerResource,
BillingPaymentMethodResource,
BillingSubscriptionPlanPeriod,
ConfirmCheckoutParams,
} from '@clerk/types';
Expand All@@ -13,13 +14,13 @@ import { unixEpochToDate } from '@/utils/date';

import { billingTotalsFromJSON } from '../../utils';
import { BillingPayer } from './BillingPayer';
import { BaseResource, BillingPaymentSource, BillingPlan } from './internal';
import { BaseResource, BillingPaymentMethod, BillingPlan } from './internal';

export class BillingCheckout extends BaseResource implements BillingCheckoutResource {
id!: string;
externalClientSecret!: string;
externalGatewayId!: string;
paymentSource?: BillingPaymentSource;
paymentMethod?: BillingPaymentMethodResource;
plan!: BillingPlan;
planPeriod!: BillingSubscriptionPlanPeriod;
planPeriodStart!: number | undefined;
Expand All@@ -42,7 +43,7 @@ export class BillingCheckout extends BaseResource implements BillingCheckoutReso
this.id = data.id;
this.externalClientSecret = data.external_client_secret;
this.externalGatewayId = data.external_gateway_id;
this.paymentSource = data.payment_source ? new BillingPaymentSource(data.payment_source) : undefined;
this.paymentMethod = data.payment_method ? new BillingPaymentMethod(data.payment_method) : undefined;
this.plan = new BillingPlan(data.plan);
this.planPeriod = data.plan_period;
this.planPeriodStart = data.plan_period_start;
Expand Down
8 changes: 4 additions & 4 deletions packages/clerk-js/src/core/resources/BillingPayment.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,23 +2,23 @@ import type {
BillingMoneyAmount,
BillingPaymentChargeType,
BillingPaymentJSON,
BillingPaymentMethodResource,
BillingPaymentResource,
BillingPaymentSourceResource,
BillingPaymentStatus,
BillingSubscriptionItemResource,
} from '@clerk/types';

import { billingMoneyAmountFromJSON } from '../../utils';
import { unixEpochToDate } from '../../utils/date';
import { BaseResource, BillingPaymentSource, BillingSubscriptionItem } from './internal';
import { BaseResource, BillingPaymentMethod, BillingSubscriptionItem } from './internal';

export class BillingPayment extends BaseResource implements BillingPaymentResource {
id!: string;
amount!: BillingMoneyAmount;
failedAt?: Date;
paidAt?: Date;
updatedAt!: Date;
paymentSource!: BillingPaymentSourceResource;
paymentMethod!: BillingPaymentMethodResource;
subscriptionItem!: BillingSubscriptionItemResource;
chargeType!: BillingPaymentChargeType;
status!: BillingPaymentStatus;
Expand All@@ -38,7 +38,7 @@ export class BillingPayment extends BaseResource implements BillingPaymentResour
this.paidAt = data.paid_at ? unixEpochToDate(data.paid_at) : undefined;
this.failedAt = data.failed_at ? unixEpochToDate(data.failed_at) : undefined;
this.updatedAt = unixEpochToDate(data.updated_at);
this.paymentSource = new BillingPaymentSource(data.payment_source);
this.paymentMethod = new BillingPaymentMethod(data.payment_method);
this.subscriptionItem = new BillingSubscriptionItem(data.subscription_item);
this.chargeType = data.charge_type;
this.status = data.status;
Expand Down
36 changes: 18 additions & 18 deletions packages/clerk-js/src/core/resources/BillingPaymentSource.ts
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,39 @@
import type {
BillingInitializedPaymentSourceJSON,
BillingInitializedPaymentSourceResource,
BillingPaymentSourceJSON,
BillingPaymentSourceResource,
BillingPaymentSourceStatus,
BillingInitializedPaymentMethodJSON,
BillingInitializedPaymentMethodResource,
BillingPaymentMethodJSON,
BillingPaymentMethodResource,
BillingPaymentMethodStatus,
DeletedObjectJSON,
MakeDefaultPaymentSourceParams,
RemovePaymentSourceParams,
MakeDefaultPaymentMethodParams,
RemovePaymentMethodParams,
} from '@clerk/types';

import { BaseResource, DeletedObject } from './internal';

export class BillingPaymentSource extends BaseResource implements BillingPaymentSourceResource {
export class BillingPaymentMethod extends BaseResource implements BillingPaymentMethodResource {
id!: string;
last4!: string;
paymentMethod!: string;
paymentType!: 'card' | 'link';
cardType!: string;
isDefault!: boolean;
isRemovable!: boolean;
status!: BillingPaymentSourceStatus;
status!: BillingPaymentMethodStatus;
walletType: string | undefined;

constructor(data: BillingPaymentSourceJSON) {
constructor(data: BillingPaymentMethodJSON) {
super();
this.fromJSON(data);
}

protected fromJSON(data: BillingPaymentSourceJSON | null): this {
protected fromJSON(data: BillingPaymentMethodJSON | null): this {
if (!data) {
return this;
}

this.id = data.id;
this.last4 = data.last4;
this.paymentMethod = data.payment_method;
this.paymentType = data.payment_type;
this.cardType = data.card_type;
this.isDefault = data.is_default;
this.isRemovable = data.is_removable;
Expand All@@ -43,7 +43,7 @@ export class BillingPaymentSource extends BaseResource implements BillingPayment
return this;
}

public async remove(params?: RemovePaymentSourceParams) {
public async remove(params?: RemovePaymentMethodParams) {
const { orgId } = params ?? {};
const json = (
await BaseResource._fetch({
Expand All@@ -57,7 +57,7 @@ export class BillingPaymentSource extends BaseResource implements BillingPayment
return new DeletedObject(json);
}

public async makeDefault(params?: MakeDefaultPaymentSourceParams) {
public async makeDefault(params?: MakeDefaultPaymentMethodParams) {
const { orgId } = params ?? {};
await BaseResource._fetch({
path: orgId
Expand All@@ -71,17 +71,17 @@ export class BillingPaymentSource extends BaseResource implements BillingPayment
}
}

export class BillingInitializedPaymentSource extends BaseResource implements BillingInitializedPaymentSourceResource {
export class BillingInitializedPaymentMethod extends BaseResource implements BillingInitializedPaymentMethodResource {
externalClientSecret!: string;
externalGatewayId!: string;
paymentMethodOrder!: string[];

constructor(data: BillingInitializedPaymentSourceJSON) {
constructor(data: BillingInitializedPaymentMethodJSON) {
super();
this.fromJSON(data);
}

protected fromJSON(data: BillingInitializedPaymentSourceJSON | null): this {
protected fromJSON(data: BillingInitializedPaymentMethodJSON | null): this {
if (!data) {
return this;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/BillingSubscription.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ export class BillingSubscription extends BaseResource implements BillingSubscrip

export class BillingSubscriptionItem extends BaseResource implements BillingSubscriptionItemResource {
id!: string;
paymentSourceId!: string;
paymentMethodId!: string;
plan!: BillingPlan;
planPeriod!: BillingSubscriptionPlanPeriod;
status!: BillingSubscriptionStatus;
Expand All@@ -86,7 +86,7 @@ export class BillingSubscriptionItem extends BaseResource implements BillingSubs
}

this.id = data.id;
this.paymentSourceId = data.payment_source_id;
this.paymentMethodId = data.payment_method_id;
this.plan = new BillingPlan(data.plan);
this.planPeriod = data.plan_period;
this.status = data.status;
Expand Down
14 changes: 7 additions & 7 deletions packages/clerk-js/src/core/resources/Organization.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,7 @@ import type {

import { convertPageToOffsetSearchParams } from '../../utils/convertPageToOffsetSearchParams';
import { unixEpochToDate } from '../../utils/date';
import { addPaymentSource, getPaymentSources, initializePaymentSource } from '../modules/billing';
import { addPaymentMethod, getPaymentMethods, initializePaymentMethod } from '../modules/billing';
import { BaseResource, OrganizationInvitation, OrganizationMembership } from './internal';
import { OrganizationDomain } from './OrganizationDomain';
import { OrganizationMembershipRequest } from './OrganizationMembershipRequest';
Expand DownExpand Up@@ -262,22 +262,22 @@ export class Organization extends BaseResource implements OrganizationResource {
}).then(res => new Organization(res?.response as OrganizationJSON));
};

initializePaymentSource: typeof initializePaymentSource = params => {
return initializePaymentSource({
initializePaymentMethod: typeof initializePaymentMethod = params => {
return initializePaymentMethod({
...params,
orgId: this.id,
});
};

addPaymentSource: typeof addPaymentSource = params => {
return addPaymentSource({
addPaymentMethod: typeof addPaymentMethod = params => {
return addPaymentMethod({
...params,
orgId: this.id,
});
};

getPaymentSources: typeof getPaymentSources = params => {
return getPaymentSources({
getPaymentMethods: typeof getPaymentMethods = params => {
return getPaymentMethods({
...params,
orgId: this.id,
});
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .changeset/rich-breads-move.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
---
'@clerk/clerk-js': minor
'@clerk/shared': patch
'@clerk/types': minor
---

[Billing Beta] Rename payment source to payment method.
Comment thread
panteliselef marked this conversation as resolved.

`Clerk.user.initializePaymentSource()` -> `Clerk.user.initializePaymentMethod()`
`Clerk.user.addPaymentSource()` -> `Clerk.user.addPaymentMethod()`
`Clerk.user.getPaymentSources()` -> `Clerk.user.getPaymentMethods()`

`Clerk.organization.initializePaymentSource()` -> `Clerk.organization.initializePaymentMethod()`
`Clerk.organization.addPaymentSource()` -> `Clerk.organization.addPaymentMethod()`
`Clerk.organization.getPaymentSources()` -> `Clerk.organization.getPaymentMethods()`

22 changes: 11 additions & 11 deletions .typedoc/__tests__/__snapshots__/file-structure.test.ts.snap
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,26 +5,26 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/act-claim.mdx",
"types/act-jwt-claim.mdx",
"types/active-session-resource.mdx",
"types/add-payment-source-params.mdx",
"types/add-payment-method-params.mdx",
"types/billing-checkout-json.mdx",
"types/billing-checkout-resource.mdx",
"types/billing-checkout-totals-json.mdx",
"types/billing-checkout-totals.mdx",
"types/billing-initialized-payment-source-json.mdx",
"types/billing-initialized-payment-source-resource.mdx",
"types/billing-initialized-payment-method-json.mdx",
"types/billing-initialized-payment-method-resource.mdx",
"types/billing-money-amount-json.mdx",
"types/billing-money-amount.mdx",
"types/billing-namespace.mdx",
"types/billing-payer-json.mdx",
"types/billing-payer-methods.mdx",
"types/billing-payer-resource-type.mdx",
"types/billing-payer-resource.mdx",
"types/billing-payment-charge-type.mdx",
"types/billing-payment-json.mdx",
"types/billing-payment-method-json.mdx",
"types/billing-payment-method-resource.mdx",
"types/billing-payment-method-status.mdx",
"types/billing-payment-resource.mdx",
"types/billing-payment-source-json.mdx",
"types/billing-payment-source-methods.mdx",
"types/billing-payment-source-resource.mdx",
"types/billing-payment-source-status.mdx",
"types/billing-payment-status.mdx",
"types/billing-plan-json.mdx",
"types/billing-plan-resource.mdx",
Expand DownExpand Up@@ -72,21 +72,21 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/field-errors.mdx",
"types/for-payer-type.mdx",
"types/get-payment-attempts-params.mdx",
"types/get-payment-sources-params.mdx",
"types/get-payment-methods-params.mdx",
"types/get-plans-params.mdx",
"types/get-statements-params.mdx",
"types/get-subscription-params.mdx",
"types/get-token.mdx",
"types/id-selectors.mdx",
"types/initialize-payment-source-params.mdx",
"types/initialize-payment-method-params.mdx",
"types/internal_checkout-props.mdx",
"types/internal_plan-details-props.mdx",
"types/internal_subscription-details-props.mdx",
"types/jwt-claims.mdx",
"types/jwt-header.mdx",
"types/legacy-redirect-props.mdx",
"types/localization-resource.mdx",
"types/make-default-payment-source-params.mdx",
"types/make-default-payment-method-params.mdx",
"types/multi-domain-and-or-proxy.mdx",
"types/organization-custom-role-key.mdx",
"types/organization-domain-resource.mdx",
Expand All@@ -109,7 +109,7 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/protect-props.mdx",
"types/record-to-path.mdx",
"types/redirect-options.mdx",
"types/remove-payment-source-params.mdx",
"types/remove-payment-method-params.mdx",
"types/reverification-config.mdx",
"types/saml-strategy.mdx",
"types/sdk-metadata.mdx",
Expand Down
7 changes: 7 additions & 0 deletions packages/clerk-js/src/core/modules/billing/namespace.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,13 @@ import {
} from '../../resources/internal';

export class Billing implements BillingNamespace {
static readonly #pathRoot = '/commerce';
static path(subPath: string, param?: { orgId?: string }): string {
const { orgId } = param || {};
const prefix = orgId ? `/organizations/${orgId}` : '/me';
return `${prefix}${Billing.#pathRoot}${subPath}`;
}

getPlans = async (params?: GetPlansParams): Promise<ClerkPaginatedResponse<BillingPlanResource>> => {
const { for: forParam, ...safeParams } = params || {};
const searchParams = { ...safeParams, payer_type: forParam === 'organization' ? 'org' : 'user' };
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,55 +1,56 @@
import type {
AddPaymentSourceParams,
BillingInitializedPaymentSourceJSON,
BillingPaymentSourceJSON,
AddPaymentMethodParams,
BillingInitializedPaymentMethodJSON,
BillingPaymentMethodJSON,
ClerkPaginatedResponse,
GetPaymentSourcesParams,
InitializePaymentSourceParams,
GetPaymentMethodsParams,
InitializePaymentMethodParams,
} from '@clerk/types';

import { convertPageToOffsetSearchParams } from '../../../utils/convertPageToOffsetSearchParams';
import { BaseResource, BillingInitializedPaymentSource, BillingPaymentSource } from '../../resources/internal';
import { BaseResource, BillingInitializedPaymentMethod, BillingPaymentMethod } from '../../resources/internal';
import { Billing } from './namespace';

export const initializePaymentSource = async (params: InitializePaymentSourceParams) => {
const PAYMENT_METHODS_PATH = '/payment_methods';

export const initializePaymentMethod = async (params: InitializePaymentMethodParams) => {
const { orgId, ...rest } = params;
const json = (
await BaseResource._fetch({
path: orgId
? `/organizations/${orgId}/commerce/payment_sources/initialize`
: `/me/commerce/payment_sources/initialize`,
path: Billing.path(`${PAYMENT_METHODS_PATH}/initialize`, { orgId }),
method: 'POST',
body: rest as any,
})
)?.response as unknown as BillingInitializedPaymentSourceJSON;
return new BillingInitializedPaymentSource(json);
)?.response as unknown as BillingInitializedPaymentMethodJSON;
return new BillingInitializedPaymentMethod(json);
};

export const addPaymentSource = async (params: AddPaymentSourceParams) => {
export const addPaymentMethod = async (params: AddPaymentMethodParams) => {
const { orgId, ...rest } = params;

const json = (
await BaseResource._fetch({
path: orgId ? `/organizations/${orgId}/commerce/payment_sources` : `/me/commerce/payment_sources`,
path: Billing.path(PAYMENT_METHODS_PATH, { orgId }),
method: 'POST',
body: rest as any,
})
)?.response as unknown as BillingPaymentSourceJSON;
return new BillingPaymentSource(json);
)?.response as unknown as BillingPaymentMethodJSON;
return new BillingPaymentMethod(json);
};

export const getPaymentSources = async (params: GetPaymentSourcesParams) => {
export const getPaymentMethods = async (params: GetPaymentMethodsParams) => {
const { orgId, ...rest } = params;

return await BaseResource._fetch({
path: orgId ? `/organizations/${orgId}/commerce/payment_sources` : `/me/commerce/payment_sources`,
path: Billing.path(PAYMENT_METHODS_PATH, { orgId }),
method: 'GET',
search: convertPageToOffsetSearchParams(rest),
}).then(res => {
const { data: paymentSources, total_count } =
res?.response as unknown as ClerkPaginatedResponse<BillingPaymentSourceJSON>;
res?.response as unknown as ClerkPaginatedResponse<BillingPaymentMethodJSON>;
return {
total_count,
data: paymentSources.map(paymentSource => new BillingPaymentSource(paymentSource)),
data: paymentSources.map(paymentMethod => new BillingPaymentMethod(paymentMethod)),
};
});
};
7 changes: 4 additions & 3 deletions packages/clerk-js/src/core/resources/BillingCheckout.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@ import type {
BillingCheckoutResource,
BillingCheckoutTotals,
BillingPayerResource,
BillingPaymentMethodResource,
BillingSubscriptionPlanPeriod,
ConfirmCheckoutParams,
} from '@clerk/types';
Expand All@@ -13,13 +14,13 @@ import { unixEpochToDate } from '@/utils/date';

import { billingTotalsFromJSON } from '../../utils';
import { BillingPayer } from './BillingPayer';
import { BaseResource, BillingPaymentSource, BillingPlan } from './internal';
import { BaseResource, BillingPaymentMethod, BillingPlan } from './internal';

export class BillingCheckout extends BaseResource implements BillingCheckoutResource {
id!: string;
externalClientSecret!: string;
externalGatewayId!: string;
paymentSource?: BillingPaymentSource;
paymentMethod?: BillingPaymentMethodResource;
plan!: BillingPlan;
planPeriod!: BillingSubscriptionPlanPeriod;
planPeriodStart!: number | undefined;
Expand All@@ -42,7 +43,7 @@ export class BillingCheckout extends BaseResource implements BillingCheckoutReso
this.id = data.id;
this.externalClientSecret = data.external_client_secret;
this.externalGatewayId = data.external_gateway_id;
this.paymentSource = data.payment_source ? new BillingPaymentSource(data.payment_source) : undefined;
this.paymentMethod = data.payment_method ? new BillingPaymentMethod(data.payment_method) : undefined;
this.plan = new BillingPlan(data.plan);
this.planPeriod = data.plan_period;
this.planPeriodStart = data.plan_period_start;
Expand Down
8 changes: 4 additions & 4 deletions packages/clerk-js/src/core/resources/BillingPayment.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,23 +2,23 @@ import type {
BillingMoneyAmount,
BillingPaymentChargeType,
BillingPaymentJSON,
BillingPaymentMethodResource,
BillingPaymentResource,
BillingPaymentSourceResource,
BillingPaymentStatus,
BillingSubscriptionItemResource,
} from '@clerk/types';

import { billingMoneyAmountFromJSON } from '../../utils';
import { unixEpochToDate } from '../../utils/date';
import { BaseResource, BillingPaymentSource, BillingSubscriptionItem } from './internal';
import { BaseResource, BillingPaymentMethod, BillingSubscriptionItem } from './internal';

export class BillingPayment extends BaseResource implements BillingPaymentResource {
id!: string;
amount!: BillingMoneyAmount;
failedAt?: Date;
paidAt?: Date;
updatedAt!: Date;
paymentSource!: BillingPaymentSourceResource;
paymentMethod!: BillingPaymentMethodResource;
subscriptionItem!: BillingSubscriptionItemResource;
chargeType!: BillingPaymentChargeType;
status!: BillingPaymentStatus;
Expand All@@ -38,7 +38,7 @@ export class BillingPayment extends BaseResource implements BillingPaymentResour
this.paidAt = data.paid_at ? unixEpochToDate(data.paid_at) : undefined;
this.failedAt = data.failed_at ? unixEpochToDate(data.failed_at) : undefined;
this.updatedAt = unixEpochToDate(data.updated_at);
this.paymentSource = new BillingPaymentSource(data.payment_source);
this.paymentMethod = new BillingPaymentMethod(data.payment_method);
this.subscriptionItem = new BillingSubscriptionItem(data.subscription_item);
this.chargeType = data.charge_type;
this.status = data.status;
Expand Down
36 changes: 18 additions & 18 deletions packages/clerk-js/src/core/resources/BillingPaymentSource.ts
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,39 @@
import type {
BillingInitializedPaymentSourceJSON,
BillingInitializedPaymentSourceResource,
BillingPaymentSourceJSON,
BillingPaymentSourceResource,
BillingPaymentSourceStatus,
BillingInitializedPaymentMethodJSON,
BillingInitializedPaymentMethodResource,
BillingPaymentMethodJSON,
BillingPaymentMethodResource,
BillingPaymentMethodStatus,
DeletedObjectJSON,
MakeDefaultPaymentSourceParams,
RemovePaymentSourceParams,
MakeDefaultPaymentMethodParams,
RemovePaymentMethodParams,
} from '@clerk/types';

import { BaseResource, DeletedObject } from './internal';

export class BillingPaymentSource extends BaseResource implements BillingPaymentSourceResource {
export class BillingPaymentMethod extends BaseResource implements BillingPaymentMethodResource {
id!: string;
last4!: string;
paymentMethod!: string;
paymentType!: 'card' | 'link';
cardType!: string;
isDefault!: boolean;
isRemovable!: boolean;
status!: BillingPaymentSourceStatus;
status!: BillingPaymentMethodStatus;
walletType: string | undefined;

constructor(data: BillingPaymentSourceJSON) {
constructor(data: BillingPaymentMethodJSON) {
super();
this.fromJSON(data);
}

protected fromJSON(data: BillingPaymentSourceJSON | null): this {
protected fromJSON(data: BillingPaymentMethodJSON | null): this {
if (!data) {
return this;
}

this.id = data.id;
this.last4 = data.last4;
this.paymentMethod = data.payment_method;
this.paymentType = data.payment_type;
this.cardType = data.card_type;
this.isDefault = data.is_default;
this.isRemovable = data.is_removable;
Expand All@@ -43,7 +43,7 @@ export class BillingPaymentSource extends BaseResource implements BillingPayment
return this;
}

public async remove(params?: RemovePaymentSourceParams) {
public async remove(params?: RemovePaymentMethodParams) {
const { orgId } = params ?? {};
const json = (
await BaseResource._fetch({
Expand All@@ -57,7 +57,7 @@ export class BillingPaymentSource extends BaseResource implements BillingPayment
return new DeletedObject(json);
}

public async makeDefault(params?: MakeDefaultPaymentSourceParams) {
public async makeDefault(params?: MakeDefaultPaymentMethodParams) {
const { orgId } = params ?? {};
await BaseResource._fetch({
path: orgId
Expand All@@ -71,17 +71,17 @@ export class BillingPaymentSource extends BaseResource implements BillingPayment
}
}

export class BillingInitializedPaymentSource extends BaseResource implements BillingInitializedPaymentSourceResource {
export class BillingInitializedPaymentMethod extends BaseResource implements BillingInitializedPaymentMethodResource {
externalClientSecret!: string;
externalGatewayId!: string;
paymentMethodOrder!: string[];

constructor(data: BillingInitializedPaymentSourceJSON) {
constructor(data: BillingInitializedPaymentMethodJSON) {
super();
this.fromJSON(data);
}

protected fromJSON(data: BillingInitializedPaymentSourceJSON | null): this {
protected fromJSON(data: BillingInitializedPaymentMethodJSON | null): this {
if (!data) {
return this;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/BillingSubscription.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ export class BillingSubscription extends BaseResource implements BillingSubscrip

export class BillingSubscriptionItem extends BaseResource implements BillingSubscriptionItemResource {
id!: string;
paymentSourceId!: string;
paymentMethodId!: string;
plan!: BillingPlan;
planPeriod!: BillingSubscriptionPlanPeriod;
status!: BillingSubscriptionStatus;
Expand All@@ -86,7 +86,7 @@ export class BillingSubscriptionItem extends BaseResource implements BillingSubs
}

this.id = data.id;
this.paymentSourceId = data.payment_source_id;
this.paymentMethodId = data.payment_method_id;
this.plan = new BillingPlan(data.plan);
this.planPeriod = data.plan_period;
this.status = data.status;
Expand Down
14 changes: 7 additions & 7 deletions packages/clerk-js/src/core/resources/Organization.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,7 @@ import type {

import { convertPageToOffsetSearchParams } from '../../utils/convertPageToOffsetSearchParams';
import { unixEpochToDate } from '../../utils/date';
import { addPaymentSource, getPaymentSources, initializePaymentSource } from '../modules/billing';
import { addPaymentMethod, getPaymentMethods, initializePaymentMethod } from '../modules/billing';
import { BaseResource, OrganizationInvitation, OrganizationMembership } from './internal';
import { OrganizationDomain } from './OrganizationDomain';
import { OrganizationMembershipRequest } from './OrganizationMembershipRequest';
Expand DownExpand Up@@ -262,22 +262,22 @@ export class Organization extends BaseResource implements OrganizationResource {
}).then(res => new Organization(res?.response as OrganizationJSON));
};

initializePaymentSource: typeof initializePaymentSource = params => {
return initializePaymentSource({
initializePaymentMethod: typeof initializePaymentMethod = params => {
return initializePaymentMethod({
...params,
orgId: this.id,
});
};

addPaymentSource: typeof addPaymentSource = params => {
return addPaymentSource({
addPaymentMethod: typeof addPaymentMethod = params => {
return addPaymentMethod({
...params,
orgId: this.id,
});
};

getPaymentSources: typeof getPaymentSources = params => {
return getPaymentSources({
getPaymentMethods: typeof getPaymentMethods = params => {
return getPaymentMethods({
...params,
orgId: this.id,
});
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .changeset/rich-breads-move.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
---
'@clerk/clerk-js': minor
'@clerk/shared': patch
'@clerk/types': minor
---

[Billing Beta] Rename payment source to payment method.
Comment thread
panteliselef marked this conversation as resolved.

`Clerk.user.initializePaymentSource()` -> `Clerk.user.initializePaymentMethod()`
`Clerk.user.addPaymentSource()` -> `Clerk.user.addPaymentMethod()`
`Clerk.user.getPaymentSources()` -> `Clerk.user.getPaymentMethods()`

`Clerk.organization.initializePaymentSource()` -> `Clerk.organization.initializePaymentMethod()`
`Clerk.organization.addPaymentSource()` -> `Clerk.organization.addPaymentMethod()`
`Clerk.organization.getPaymentSources()` -> `Clerk.organization.getPaymentMethods()`

22 changes: 11 additions & 11 deletions .typedoc/__tests__/__snapshots__/file-structure.test.ts.snap
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,26 +5,26 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/act-claim.mdx",
"types/act-jwt-claim.mdx",
"types/active-session-resource.mdx",
"types/add-payment-source-params.mdx",
"types/add-payment-method-params.mdx",
"types/billing-checkout-json.mdx",
"types/billing-checkout-resource.mdx",
"types/billing-checkout-totals-json.mdx",
"types/billing-checkout-totals.mdx",
"types/billing-initialized-payment-source-json.mdx",
"types/billing-initialized-payment-source-resource.mdx",
"types/billing-initialized-payment-method-json.mdx",
"types/billing-initialized-payment-method-resource.mdx",
"types/billing-money-amount-json.mdx",
"types/billing-money-amount.mdx",
"types/billing-namespace.mdx",
"types/billing-payer-json.mdx",
"types/billing-payer-methods.mdx",
"types/billing-payer-resource-type.mdx",
"types/billing-payer-resource.mdx",
"types/billing-payment-charge-type.mdx",
"types/billing-payment-json.mdx",
"types/billing-payment-method-json.mdx",
"types/billing-payment-method-resource.mdx",
"types/billing-payment-method-status.mdx",
"types/billing-payment-resource.mdx",
"types/billing-payment-source-json.mdx",
"types/billing-payment-source-methods.mdx",
"types/billing-payment-source-resource.mdx",
"types/billing-payment-source-status.mdx",
"types/billing-payment-status.mdx",
"types/billing-plan-json.mdx",
"types/billing-plan-resource.mdx",
Expand DownExpand Up@@ -72,21 +72,21 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/field-errors.mdx",
"types/for-payer-type.mdx",
"types/get-payment-attempts-params.mdx",
"types/get-payment-sources-params.mdx",
"types/get-payment-methods-params.mdx",
"types/get-plans-params.mdx",
"types/get-statements-params.mdx",
"types/get-subscription-params.mdx",
"types/get-token.mdx",
"types/id-selectors.mdx",
"types/initialize-payment-source-params.mdx",
"types/initialize-payment-method-params.mdx",
"types/internal_checkout-props.mdx",
"types/internal_plan-details-props.mdx",
"types/internal_subscription-details-props.mdx",
"types/jwt-claims.mdx",
"types/jwt-header.mdx",
"types/legacy-redirect-props.mdx",
"types/localization-resource.mdx",
"types/make-default-payment-source-params.mdx",
"types/make-default-payment-method-params.mdx",
"types/multi-domain-and-or-proxy.mdx",
"types/organization-custom-role-key.mdx",
"types/organization-domain-resource.mdx",
Expand All@@ -109,7 +109,7 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/protect-props.mdx",
"types/record-to-path.mdx",
"types/redirect-options.mdx",
"types/remove-payment-source-params.mdx",
"types/remove-payment-method-params.mdx",
"types/reverification-config.mdx",
"types/saml-strategy.mdx",
"types/sdk-metadata.mdx",
Expand Down
7 changes: 7 additions & 0 deletions packages/clerk-js/src/core/modules/billing/namespace.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,13 @@ import {
} from '../../resources/internal';

export class Billing implements BillingNamespace {
static readonly #pathRoot = '/commerce';
static path(subPath: string, param?: { orgId?: string }): string {
const { orgId } = param || {};
const prefix = orgId ? `/organizations/${orgId}` : '/me';
return `${prefix}${Billing.#pathRoot}${subPath}`;
}

getPlans = async (params?: GetPlansParams): Promise<ClerkPaginatedResponse<BillingPlanResource>> => {
const { for: forParam, ...safeParams } = params || {};
const searchParams = { ...safeParams, payer_type: forParam === 'organization' ? 'org' : 'user' };
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,55 +1,56 @@
import type {
AddPaymentSourceParams,
BillingInitializedPaymentSourceJSON,
BillingPaymentSourceJSON,
AddPaymentMethodParams,
BillingInitializedPaymentMethodJSON,
BillingPaymentMethodJSON,
ClerkPaginatedResponse,
GetPaymentSourcesParams,
InitializePaymentSourceParams,
GetPaymentMethodsParams,
InitializePaymentMethodParams,
} from '@clerk/types';

import { convertPageToOffsetSearchParams } from '../../../utils/convertPageToOffsetSearchParams';
import { BaseResource, BillingInitializedPaymentSource, BillingPaymentSource } from '../../resources/internal';
import { BaseResource, BillingInitializedPaymentMethod, BillingPaymentMethod } from '../../resources/internal';
import { Billing } from './namespace';

export const initializePaymentSource = async (params: InitializePaymentSourceParams) => {
const PAYMENT_METHODS_PATH = '/payment_methods';

export const initializePaymentMethod = async (params: InitializePaymentMethodParams) => {
const { orgId, ...rest } = params;
const json = (
await BaseResource._fetch({
path: orgId
? `/organizations/${orgId}/commerce/payment_sources/initialize`
: `/me/commerce/payment_sources/initialize`,
path: Billing.path(`${PAYMENT_METHODS_PATH}/initialize`, { orgId }),
method: 'POST',
body: rest as any,
})
)?.response as unknown as BillingInitializedPaymentSourceJSON;
return new BillingInitializedPaymentSource(json);
)?.response as unknown as BillingInitializedPaymentMethodJSON;
return new BillingInitializedPaymentMethod(json);
};

export const addPaymentSource = async (params: AddPaymentSourceParams) => {
export const addPaymentMethod = async (params: AddPaymentMethodParams) => {
const { orgId, ...rest } = params;

const json = (
await BaseResource._fetch({
path: orgId ? `/organizations/${orgId}/commerce/payment_sources` : `/me/commerce/payment_sources`,
path: Billing.path(PAYMENT_METHODS_PATH, { orgId }),
method: 'POST',
body: rest as any,
})
)?.response as unknown as BillingPaymentSourceJSON;
return new BillingPaymentSource(json);
)?.response as unknown as BillingPaymentMethodJSON;
return new BillingPaymentMethod(json);
};

export const getPaymentSources = async (params: GetPaymentSourcesParams) => {
export const getPaymentMethods = async (params: GetPaymentMethodsParams) => {
const { orgId, ...rest } = params;

return await BaseResource._fetch({
path: orgId ? `/organizations/${orgId}/commerce/payment_sources` : `/me/commerce/payment_sources`,
path: Billing.path(PAYMENT_METHODS_PATH, { orgId }),
method: 'GET',
search: convertPageToOffsetSearchParams(rest),
}).then(res => {
const { data: paymentSources, total_count } =
res?.response as unknown as ClerkPaginatedResponse<BillingPaymentSourceJSON>;
res?.response as unknown as ClerkPaginatedResponse<BillingPaymentMethodJSON>;
return {
total_count,
data: paymentSources.map(paymentSource => new BillingPaymentSource(paymentSource)),
data: paymentSources.map(paymentMethod => new BillingPaymentMethod(paymentMethod)),
};
});
};
7 changes: 4 additions & 3 deletions packages/clerk-js/src/core/resources/BillingCheckout.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@ import type {
BillingCheckoutResource,
BillingCheckoutTotals,
BillingPayerResource,
BillingPaymentMethodResource,
BillingSubscriptionPlanPeriod,
ConfirmCheckoutParams,
} from '@clerk/types';
Expand All@@ -13,13 +14,13 @@ import { unixEpochToDate } from '@/utils/date';

import { billingTotalsFromJSON } from '../../utils';
import { BillingPayer } from './BillingPayer';
import { BaseResource, BillingPaymentSource, BillingPlan } from './internal';
import { BaseResource, BillingPaymentMethod, BillingPlan } from './internal';

export class BillingCheckout extends BaseResource implements BillingCheckoutResource {
id!: string;
externalClientSecret!: string;
externalGatewayId!: string;
paymentSource?: BillingPaymentSource;
paymentMethod?: BillingPaymentMethodResource;
plan!: BillingPlan;
planPeriod!: BillingSubscriptionPlanPeriod;
planPeriodStart!: number | undefined;
Expand All@@ -42,7 +43,7 @@ export class BillingCheckout extends BaseResource implements BillingCheckoutReso
this.id = data.id;
this.externalClientSecret = data.external_client_secret;
this.externalGatewayId = data.external_gateway_id;
this.paymentSource = data.payment_source ? new BillingPaymentSource(data.payment_source) : undefined;
this.paymentMethod = data.payment_method ? new BillingPaymentMethod(data.payment_method) : undefined;
this.plan = new BillingPlan(data.plan);
this.planPeriod = data.plan_period;
this.planPeriodStart = data.plan_period_start;
Expand Down
8 changes: 4 additions & 4 deletions packages/clerk-js/src/core/resources/BillingPayment.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,23 +2,23 @@ import type {
BillingMoneyAmount,
BillingPaymentChargeType,
BillingPaymentJSON,
BillingPaymentMethodResource,
BillingPaymentResource,
BillingPaymentSourceResource,
BillingPaymentStatus,
BillingSubscriptionItemResource,
} from '@clerk/types';

import { billingMoneyAmountFromJSON } from '../../utils';
import { unixEpochToDate } from '../../utils/date';
import { BaseResource, BillingPaymentSource, BillingSubscriptionItem } from './internal';
import { BaseResource, BillingPaymentMethod, BillingSubscriptionItem } from './internal';

export class BillingPayment extends BaseResource implements BillingPaymentResource {
id!: string;
amount!: BillingMoneyAmount;
failedAt?: Date;
paidAt?: Date;
updatedAt!: Date;
paymentSource!: BillingPaymentSourceResource;
paymentMethod!: BillingPaymentMethodResource;
subscriptionItem!: BillingSubscriptionItemResource;
chargeType!: BillingPaymentChargeType;
status!: BillingPaymentStatus;
Expand All@@ -38,7 +38,7 @@ export class BillingPayment extends BaseResource implements BillingPaymentResour
this.paidAt = data.paid_at ? unixEpochToDate(data.paid_at) : undefined;
this.failedAt = data.failed_at ? unixEpochToDate(data.failed_at) : undefined;
this.updatedAt = unixEpochToDate(data.updated_at);
this.paymentSource = new BillingPaymentSource(data.payment_source);
this.paymentMethod = new BillingPaymentMethod(data.payment_method);
this.subscriptionItem = new BillingSubscriptionItem(data.subscription_item);
this.chargeType = data.charge_type;
this.status = data.status;
Expand Down
36 changes: 18 additions & 18 deletions packages/clerk-js/src/core/resources/BillingPaymentSource.ts
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,39 @@
import type {
BillingInitializedPaymentSourceJSON,
BillingInitializedPaymentSourceResource,
BillingPaymentSourceJSON,
BillingPaymentSourceResource,
BillingPaymentSourceStatus,
BillingInitializedPaymentMethodJSON,
BillingInitializedPaymentMethodResource,
BillingPaymentMethodJSON,
BillingPaymentMethodResource,
BillingPaymentMethodStatus,
DeletedObjectJSON,
MakeDefaultPaymentSourceParams,
RemovePaymentSourceParams,
MakeDefaultPaymentMethodParams,
RemovePaymentMethodParams,
} from '@clerk/types';

import { BaseResource, DeletedObject } from './internal';

export class BillingPaymentSource extends BaseResource implements BillingPaymentSourceResource {
export class BillingPaymentMethod extends BaseResource implements BillingPaymentMethodResource {
id!: string;
last4!: string;
paymentMethod!: string;
paymentType!: 'card' | 'link';
cardType!: string;
isDefault!: boolean;
isRemovable!: boolean;
status!: BillingPaymentSourceStatus;
status!: BillingPaymentMethodStatus;
walletType: string | undefined;

constructor(data: BillingPaymentSourceJSON) {
constructor(data: BillingPaymentMethodJSON) {
super();
this.fromJSON(data);
}

protected fromJSON(data: BillingPaymentSourceJSON | null): this {
protected fromJSON(data: BillingPaymentMethodJSON | null): this {
if (!data) {
return this;
}

this.id = data.id;
this.last4 = data.last4;
this.paymentMethod = data.payment_method;
this.paymentType = data.payment_type;
this.cardType = data.card_type;
this.isDefault = data.is_default;
this.isRemovable = data.is_removable;
Expand All@@ -43,7 +43,7 @@ export class BillingPaymentSource extends BaseResource implements BillingPayment
return this;
}

public async remove(params?: RemovePaymentSourceParams) {
public async remove(params?: RemovePaymentMethodParams) {
const { orgId } = params ?? {};
const json = (
await BaseResource._fetch({
Expand All@@ -57,7 +57,7 @@ export class BillingPaymentSource extends BaseResource implements BillingPayment
return new DeletedObject(json);
}

public async makeDefault(params?: MakeDefaultPaymentSourceParams) {
public async makeDefault(params?: MakeDefaultPaymentMethodParams) {
const { orgId } = params ?? {};
await BaseResource._fetch({
path: orgId
Expand All@@ -71,17 +71,17 @@ export class BillingPaymentSource extends BaseResource implements BillingPayment
}
}

export class BillingInitializedPaymentSource extends BaseResource implements BillingInitializedPaymentSourceResource {
export class BillingInitializedPaymentMethod extends BaseResource implements BillingInitializedPaymentMethodResource {
externalClientSecret!: string;
externalGatewayId!: string;
paymentMethodOrder!: string[];

constructor(data: BillingInitializedPaymentSourceJSON) {
constructor(data: BillingInitializedPaymentMethodJSON) {
super();
this.fromJSON(data);
}

protected fromJSON(data: BillingInitializedPaymentSourceJSON | null): this {
protected fromJSON(data: BillingInitializedPaymentMethodJSON | null): this {
if (!data) {
return this;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/BillingSubscription.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ export class BillingSubscription extends BaseResource implements BillingSubscrip

export class BillingSubscriptionItem extends BaseResource implements BillingSubscriptionItemResource {
id!: string;
paymentSourceId!: string;
paymentMethodId!: string;
plan!: BillingPlan;
planPeriod!: BillingSubscriptionPlanPeriod;
status!: BillingSubscriptionStatus;
Expand All@@ -86,7 +86,7 @@ export class BillingSubscriptionItem extends BaseResource implements BillingSubs
}

this.id = data.id;
this.paymentSourceId = data.payment_source_id;
this.paymentMethodId = data.payment_method_id;
this.plan = new BillingPlan(data.plan);
this.planPeriod = data.plan_period;
this.status = data.status;
Expand Down
14 changes: 7 additions & 7 deletions packages/clerk-js/src/core/resources/Organization.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,7 @@ import type {

import { convertPageToOffsetSearchParams } from '../../utils/convertPageToOffsetSearchParams';
import { unixEpochToDate } from '../../utils/date';
import { addPaymentSource, getPaymentSources, initializePaymentSource } from '../modules/billing';
import { addPaymentMethod, getPaymentMethods, initializePaymentMethod } from '../modules/billing';
import { BaseResource, OrganizationInvitation, OrganizationMembership } from './internal';
import { OrganizationDomain } from './OrganizationDomain';
import { OrganizationMembershipRequest } from './OrganizationMembershipRequest';
Expand DownExpand Up@@ -262,22 +262,22 @@ export class Organization extends BaseResource implements OrganizationResource {
}).then(res => new Organization(res?.response as OrganizationJSON));
};

initializePaymentSource: typeof initializePaymentSource = params => {
return initializePaymentSource({
initializePaymentMethod: typeof initializePaymentMethod = params => {
return initializePaymentMethod({
...params,
orgId: this.id,
});
};

addPaymentSource: typeof addPaymentSource = params => {
return addPaymentSource({
addPaymentMethod: typeof addPaymentMethod = params => {
return addPaymentMethod({
...params,
orgId: this.id,
});
};

getPaymentSources: typeof getPaymentSources = params => {
return getPaymentSources({
getPaymentMethods: typeof getPaymentMethods = params => {
return getPaymentMethods({
...params,
orgId: this.id,
});
Expand Down
Loading
Loading