Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/dull-paws-march.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
'@clerk/clerk-js': patch
'@clerk/types': patch
---

Display organization slug based on environment settings
9 changes: 9 additions & 0 deletions packages/clerk-js/src/core/resources/OrganizationSettings.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,6 +18,11 @@ export class OrganizationSettings extends BaseResource implements OrganizationSe
enrollmentModes: [],
defaultRole: null,
};
slug: {
disabled: boolean;
} = {
disabled: false,
};
enabled: boolean = false;
maxAllowedMemberships: number = 1;
forceOrganizationSelection!: boolean;
Expand All@@ -42,6 +47,10 @@ export class OrganizationSettings extends BaseResource implements OrganizationSe
this.domains.defaultRole = this.withDefault(data.domains.default_role, this.domains.defaultRole);
}

if (data.slug) {
this.slug.disabled = this.withDefault(data.slug.disabled, this.slug.disabled);
}

this.enabled = this.withDefault(data.enabled, this.enabled);
this.maxAllowedMemberships = this.withDefault(data.max_allowed_memberships, this.maxAllowedMemberships);
this.forceOrganizationSelection = this.withDefault(
Expand Down
11 changes: 10 additions & 1 deletion packages/clerk-js/src/test/fixture-helpers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -342,13 +342,22 @@ const createOrganizationSettingsFixtureHelpers = (environment: EnvironmentJSON)
const withForceOrganizationSelection = () => {
os.force_organization_selection = true;
};
const withOrganizationSlug = (enabled = false) => {
os.slug.disabled = !enabled;
};

const withOrganizationDomains = (modes?: OrganizationEnrollmentMode[], defaultRole?: string) => {
os.domains.enabled = true;
os.domains.enrollment_modes = modes || ['automatic_invitation', 'manual_invitation'];
os.domains.default_role = defaultRole ?? null;
};
return { withOrganizations, withMaxAllowedMemberships, withOrganizationDomains, withForceOrganizationSelection };
return {
withOrganizations,
withMaxAllowedMemberships,
withOrganizationDomains,
withForceOrganizationSelection,
withOrganizationSlug,
};
};

const createBillingSettingsFixtureHelpers = (environment: EnvironmentJSON) => {
Expand Down
3 changes: 3 additions & 0 deletions packages/clerk-js/src/test/fixtures.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -89,6 +89,9 @@ const createBaseOrganizationSettings = (): OrganizationSettingsJSON => {
enabled: false,
enrollment_modes: [],
},
slug: {
disabled: true,
},
} as unknown as OrganizationSettingsJSON;
};

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@ import { useOrganization, useOrganizationList } from '@clerk/shared/react';
import type { CreateOrganizationParams, OrganizationResource } from '@clerk/types';
import React from 'react';

import { useEnvironment } from '@/ui/contexts';
import { useCardState, withCardStateProvider } from '@/ui/elements/contexts';
import { Form } from '@/ui/elements/Form';
import { FormButtonContainer } from '@/ui/elements/FormButtons';
Expand DownExpand Up@@ -33,6 +34,11 @@ type CreateOrganizationFormProps = {
headerTitle?: LocalizationKey;
headerSubtitle?: LocalizationKey;
};
/**
* @deprecated
* This prop will be removed in a future version.
* Configure whether organization slug is enabled via the Clerk Dashboard under Organization Settings.
*/
hideSlug?: boolean;
};

Expand All@@ -45,6 +51,7 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
userMemberships: organizationListParams.userMemberships,
});
const { organization } = useOrganization();
const { organizationSettings } = useEnvironment();
Comment thread
coderabbitai[bot] marked this conversation as resolved.
const [file, setFile] = React.useState<File | null>();

const nameField = useFormControl('name', '', {
Expand All@@ -62,6 +69,9 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
const dataChanged = !!nameField.value;
const canSubmit = dataChanged;

// Environment setting takes precedence over prop
const organizationSlugEnabled = !organizationSettings.slug.disabled && !props.hideSlug;

const onSubmit = async (e: React.FormEvent) => {
e.preventDefault();
if (!canSubmit) {
Expand All@@ -75,7 +85,7 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
try {
const createOrgParams: CreateOrganizationParams = { name: nameField.value };

if (!props.hideSlug) {
if (organizationSlugEnabled) {
createOrgParams.slug = slugField.value;
}

Expand DownExpand Up@@ -188,7 +198,7 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
ignorePasswordManager
/>
</Form.ControlRow>
{!props.hideSlug && (
{organizationSlugEnabled && (
<Form.ControlRow elementId={slugField.id}>
<Form.PlainInput
{...slugField.props}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -80,35 +80,169 @@ describe('CreateOrganization', () => {
expect(getByRole('heading', { name: 'Create organization', level: 1 })).toBeInTheDocument();
});

it('renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withUser({
email_addresses: ['test@clerk.com'],
describe('with `hideSlug` prop', () => {
it('renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);
describe('with organization slug configured on environment', () => {
it('when disabled, renders component without slug field', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(false);
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});

it('when enabled, renders component slug field', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();
it('when enabled and `hideSlug` prop is passed, renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));
fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});

it('when disabled and `hideSlug` prop is passed, renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(false); // Environment disables slug
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});
});
Comment thread
coderabbitai[bot] marked this conversation as resolved.

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -85,6 +85,7 @@ describe('OrganizationList', () => {
it('hides the personal account with no data to list', async () => {
const { wrapper, props } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
f.withUser({
email_addresses: ['test@clerk.com'],
organization_memberships: [{ name: 'Org1', id: '1', role: 'admin' }],
Expand DownExpand Up@@ -210,6 +211,7 @@ describe('OrganizationList', () => {
it('display CreateOrganization within OrganizationList', async () => {
const { wrapper } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
Comment thread
LauraBeatris marked this conversation as resolved.
f.withUser({
email_addresses: ['test@clerk.com'],
create_organization_enabled: true,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
import { useOrganizationList } from '@clerk/shared/react';
import type { CreateOrganizationParams } from '@clerk/types';

import { useEnvironment } from '@/ui/contexts';
import { useTaskChooseOrganizationContext } from '@/ui/contexts/components/SessionTasks';
import { localizationKeys } from '@/ui/customizables';
import { useCardState } from '@/ui/elements/contexts';
Expand All@@ -25,6 +27,7 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
const { createOrganization, isLoaded, setActive } = useOrganizationList({
userMemberships: organizationListParams.userMemberships,
});
const { organizationSettings } = useEnvironment();

const nameField = useFormControl('name', '', {
type: 'text',
Expand All@@ -37,6 +40,8 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
placeholder: localizationKeys('taskChooseOrganization.createOrganization.formFieldInputPlaceholder__slug'),
});

const organizationSlugEnabled = !organizationSettings.slug.disabled;

const onSubmit = async (e: React.FormEvent) => {
e.preventDefault();

Expand All@@ -45,7 +50,13 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
}

try {
const organization = await createOrganization({ name: nameField.value, slug: slugField.value });
const createOrgParams: CreateOrganizationParams = { name: nameField.value };

if (organizationSlugEnabled) {
createOrgParams.slug = slugField.value;
}

const organization = await createOrganization(createOrgParams);

await setActive({
organization,
Expand DownExpand Up@@ -90,15 +101,17 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
ignorePasswordManager
/>
</Form.ControlRow>
<Form.ControlRow elementId={slugField.id}>
<Form.PlainInput
{...slugField.props}
onChange={event => updateSlugField(event.target.value)}
isRequired
pattern='^(?=.*[a-z0-9])[a-z0-9\-]+$'
ignorePasswordManager
/>
</Form.ControlRow>
{organizationSlugEnabled && (
<Form.ControlRow elementId={slugField.id}>
<Form.PlainInput
{...slugField.props}
onChange={event => updateSlugField(event.target.value)}
isRequired
pattern='^(?=.*[a-z0-9])[a-z0-9\-]+$'
ignorePasswordManager
/>
</Form.ControlRow>
)}

<FormButtonContainer sx={() => ({ flexDirection: 'column' })}>
<Form.SubmitButton
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/dull-paws-march.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
'@clerk/clerk-js': patch
'@clerk/types': patch
---

Display organization slug based on environment settings
9 changes: 9 additions & 0 deletions packages/clerk-js/src/core/resources/OrganizationSettings.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,6 +18,11 @@ export class OrganizationSettings extends BaseResource implements OrganizationSe
enrollmentModes: [],
defaultRole: null,
};
slug: {
disabled: boolean;
} = {
disabled: false,
};
enabled: boolean = false;
maxAllowedMemberships: number = 1;
forceOrganizationSelection!: boolean;
Expand All@@ -42,6 +47,10 @@ export class OrganizationSettings extends BaseResource implements OrganizationSe
this.domains.defaultRole = this.withDefault(data.domains.default_role, this.domains.defaultRole);
}

if (data.slug) {
this.slug.disabled = this.withDefault(data.slug.disabled, this.slug.disabled);
}

this.enabled = this.withDefault(data.enabled, this.enabled);
this.maxAllowedMemberships = this.withDefault(data.max_allowed_memberships, this.maxAllowedMemberships);
this.forceOrganizationSelection = this.withDefault(
Expand Down
11 changes: 10 additions & 1 deletion packages/clerk-js/src/test/fixture-helpers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -342,13 +342,22 @@ const createOrganizationSettingsFixtureHelpers = (environment: EnvironmentJSON)
const withForceOrganizationSelection = () => {
os.force_organization_selection = true;
};
const withOrganizationSlug = (enabled = false) => {
os.slug.disabled = !enabled;
};

const withOrganizationDomains = (modes?: OrganizationEnrollmentMode[], defaultRole?: string) => {
os.domains.enabled = true;
os.domains.enrollment_modes = modes || ['automatic_invitation', 'manual_invitation'];
os.domains.default_role = defaultRole ?? null;
};
return { withOrganizations, withMaxAllowedMemberships, withOrganizationDomains, withForceOrganizationSelection };
return {
withOrganizations,
withMaxAllowedMemberships,
withOrganizationDomains,
withForceOrganizationSelection,
withOrganizationSlug,
};
};

const createBillingSettingsFixtureHelpers = (environment: EnvironmentJSON) => {
Expand Down
3 changes: 3 additions & 0 deletions packages/clerk-js/src/test/fixtures.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -89,6 +89,9 @@ const createBaseOrganizationSettings = (): OrganizationSettingsJSON => {
enabled: false,
enrollment_modes: [],
},
slug: {
disabled: true,
},
} as unknown as OrganizationSettingsJSON;
};

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@ import { useOrganization, useOrganizationList } from '@clerk/shared/react';
import type { CreateOrganizationParams, OrganizationResource } from '@clerk/types';
import React from 'react';

import { useEnvironment } from '@/ui/contexts';
import { useCardState, withCardStateProvider } from '@/ui/elements/contexts';
import { Form } from '@/ui/elements/Form';
import { FormButtonContainer } from '@/ui/elements/FormButtons';
Expand DownExpand Up@@ -33,6 +34,11 @@ type CreateOrganizationFormProps = {
headerTitle?: LocalizationKey;
headerSubtitle?: LocalizationKey;
};
/**
* @deprecated
* This prop will be removed in a future version.
* Configure whether organization slug is enabled via the Clerk Dashboard under Organization Settings.
*/
hideSlug?: boolean;
};

Expand All@@ -45,6 +51,7 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
userMemberships: organizationListParams.userMemberships,
});
const { organization } = useOrganization();
const { organizationSettings } = useEnvironment();
Comment thread
coderabbitai[bot] marked this conversation as resolved.
const [file, setFile] = React.useState<File | null>();

const nameField = useFormControl('name', '', {
Expand All@@ -62,6 +69,9 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
const dataChanged = !!nameField.value;
const canSubmit = dataChanged;

// Environment setting takes precedence over prop
const organizationSlugEnabled = !organizationSettings.slug.disabled && !props.hideSlug;

const onSubmit = async (e: React.FormEvent) => {
e.preventDefault();
if (!canSubmit) {
Expand All@@ -75,7 +85,7 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
try {
const createOrgParams: CreateOrganizationParams = { name: nameField.value };

if (!props.hideSlug) {
if (organizationSlugEnabled) {
createOrgParams.slug = slugField.value;
}

Expand DownExpand Up@@ -188,7 +198,7 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
ignorePasswordManager
/>
</Form.ControlRow>
{!props.hideSlug && (
{organizationSlugEnabled && (
<Form.ControlRow elementId={slugField.id}>
<Form.PlainInput
{...slugField.props}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -80,35 +80,169 @@ describe('CreateOrganization', () => {
expect(getByRole('heading', { name: 'Create organization', level: 1 })).toBeInTheDocument();
});

it('renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withUser({
email_addresses: ['test@clerk.com'],
describe('with `hideSlug` prop', () => {
it('renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);
describe('with organization slug configured on environment', () => {
it('when disabled, renders component without slug field', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(false);
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});

it('when enabled, renders component slug field', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();
it('when enabled and `hideSlug` prop is passed, renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));
fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});

it('when disabled and `hideSlug` prop is passed, renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(false); // Environment disables slug
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});
});
Comment thread
coderabbitai[bot] marked this conversation as resolved.

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -85,6 +85,7 @@ describe('OrganizationList', () => {
it('hides the personal account with no data to list', async () => {
const { wrapper, props } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
f.withUser({
email_addresses: ['test@clerk.com'],
organization_memberships: [{ name: 'Org1', id: '1', role: 'admin' }],
Expand DownExpand Up@@ -210,6 +211,7 @@ describe('OrganizationList', () => {
it('display CreateOrganization within OrganizationList', async () => {
const { wrapper } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
Comment thread
LauraBeatris marked this conversation as resolved.
f.withUser({
email_addresses: ['test@clerk.com'],
create_organization_enabled: true,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
import { useOrganizationList } from '@clerk/shared/react';
import type { CreateOrganizationParams } from '@clerk/types';

import { useEnvironment } from '@/ui/contexts';
import { useTaskChooseOrganizationContext } from '@/ui/contexts/components/SessionTasks';
import { localizationKeys } from '@/ui/customizables';
import { useCardState } from '@/ui/elements/contexts';
Expand All@@ -25,6 +27,7 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
const { createOrganization, isLoaded, setActive } = useOrganizationList({
userMemberships: organizationListParams.userMemberships,
});
const { organizationSettings } = useEnvironment();

const nameField = useFormControl('name', '', {
type: 'text',
Expand All@@ -37,6 +40,8 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
placeholder: localizationKeys('taskChooseOrganization.createOrganization.formFieldInputPlaceholder__slug'),
});

const organizationSlugEnabled = !organizationSettings.slug.disabled;

const onSubmit = async (e: React.FormEvent) => {
e.preventDefault();

Expand All@@ -45,7 +50,13 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
}

try {
const organization = await createOrganization({ name: nameField.value, slug: slugField.value });
const createOrgParams: CreateOrganizationParams = { name: nameField.value };

if (organizationSlugEnabled) {
createOrgParams.slug = slugField.value;
}

const organization = await createOrganization(createOrgParams);

await setActive({
organization,
Expand DownExpand Up@@ -90,15 +101,17 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
ignorePasswordManager
/>
</Form.ControlRow>
<Form.ControlRow elementId={slugField.id}>
<Form.PlainInput
{...slugField.props}
onChange={event => updateSlugField(event.target.value)}
isRequired
pattern='^(?=.*[a-z0-9])[a-z0-9\-]+$'
ignorePasswordManager
/>
</Form.ControlRow>
{organizationSlugEnabled && (
<Form.ControlRow elementId={slugField.id}>
<Form.PlainInput
{...slugField.props}
onChange={event => updateSlugField(event.target.value)}
isRequired
pattern='^(?=.*[a-z0-9])[a-z0-9\-]+$'
ignorePasswordManager
/>
</Form.ControlRow>
)}

<FormButtonContainer sx={() => ({ flexDirection: 'column' })}>
<Form.SubmitButton
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/dull-paws-march.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
'@clerk/clerk-js': patch
'@clerk/types': patch
---

Display organization slug based on environment settings
9 changes: 9 additions & 0 deletions packages/clerk-js/src/core/resources/OrganizationSettings.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,6 +18,11 @@ export class OrganizationSettings extends BaseResource implements OrganizationSe
enrollmentModes: [],
defaultRole: null,
};
slug: {
disabled: boolean;
} = {
disabled: false,
};
enabled: boolean = false;
maxAllowedMemberships: number = 1;
forceOrganizationSelection!: boolean;
Expand All@@ -42,6 +47,10 @@ export class OrganizationSettings extends BaseResource implements OrganizationSe
this.domains.defaultRole = this.withDefault(data.domains.default_role, this.domains.defaultRole);
}

if (data.slug) {
this.slug.disabled = this.withDefault(data.slug.disabled, this.slug.disabled);
}

this.enabled = this.withDefault(data.enabled, this.enabled);
this.maxAllowedMemberships = this.withDefault(data.max_allowed_memberships, this.maxAllowedMemberships);
this.forceOrganizationSelection = this.withDefault(
Expand Down
11 changes: 10 additions & 1 deletion packages/clerk-js/src/test/fixture-helpers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -342,13 +342,22 @@ const createOrganizationSettingsFixtureHelpers = (environment: EnvironmentJSON)
const withForceOrganizationSelection = () => {
os.force_organization_selection = true;
};
const withOrganizationSlug = (enabled = false) => {
os.slug.disabled = !enabled;
};

const withOrganizationDomains = (modes?: OrganizationEnrollmentMode[], defaultRole?: string) => {
os.domains.enabled = true;
os.domains.enrollment_modes = modes || ['automatic_invitation', 'manual_invitation'];
os.domains.default_role = defaultRole ?? null;
};
return { withOrganizations, withMaxAllowedMemberships, withOrganizationDomains, withForceOrganizationSelection };
return {
withOrganizations,
withMaxAllowedMemberships,
withOrganizationDomains,
withForceOrganizationSelection,
withOrganizationSlug,
};
};

const createBillingSettingsFixtureHelpers = (environment: EnvironmentJSON) => {
Expand Down
3 changes: 3 additions & 0 deletions packages/clerk-js/src/test/fixtures.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -89,6 +89,9 @@ const createBaseOrganizationSettings = (): OrganizationSettingsJSON => {
enabled: false,
enrollment_modes: [],
},
slug: {
disabled: true,
},
} as unknown as OrganizationSettingsJSON;
};

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@ import { useOrganization, useOrganizationList } from '@clerk/shared/react';
import type { CreateOrganizationParams, OrganizationResource } from '@clerk/types';
import React from 'react';

import { useEnvironment } from '@/ui/contexts';
import { useCardState, withCardStateProvider } from '@/ui/elements/contexts';
import { Form } from '@/ui/elements/Form';
import { FormButtonContainer } from '@/ui/elements/FormButtons';
Expand DownExpand Up@@ -33,6 +34,11 @@ type CreateOrganizationFormProps = {
headerTitle?: LocalizationKey;
headerSubtitle?: LocalizationKey;
};
/**
* @deprecated
* This prop will be removed in a future version.
* Configure whether organization slug is enabled via the Clerk Dashboard under Organization Settings.
*/
hideSlug?: boolean;
};

Expand All@@ -45,6 +51,7 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
userMemberships: organizationListParams.userMemberships,
});
const { organization } = useOrganization();
const { organizationSettings } = useEnvironment();
Comment thread
coderabbitai[bot] marked this conversation as resolved.
const [file, setFile] = React.useState<File | null>();

const nameField = useFormControl('name', '', {
Expand All@@ -62,6 +69,9 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
const dataChanged = !!nameField.value;
const canSubmit = dataChanged;

// Environment setting takes precedence over prop
const organizationSlugEnabled = !organizationSettings.slug.disabled && !props.hideSlug;

const onSubmit = async (e: React.FormEvent) => {
e.preventDefault();
if (!canSubmit) {
Expand All@@ -75,7 +85,7 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
try {
const createOrgParams: CreateOrganizationParams = { name: nameField.value };

if (!props.hideSlug) {
if (organizationSlugEnabled) {
createOrgParams.slug = slugField.value;
}

Expand DownExpand Up@@ -188,7 +198,7 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
ignorePasswordManager
/>
</Form.ControlRow>
{!props.hideSlug && (
{organizationSlugEnabled && (
<Form.ControlRow elementId={slugField.id}>
<Form.PlainInput
{...slugField.props}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -80,35 +80,169 @@ describe('CreateOrganization', () => {
expect(getByRole('heading', { name: 'Create organization', level: 1 })).toBeInTheDocument();
});

it('renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withUser({
email_addresses: ['test@clerk.com'],
describe('with `hideSlug` prop', () => {
it('renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);
describe('with organization slug configured on environment', () => {
it('when disabled, renders component without slug field', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(false);
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});

it('when enabled, renders component slug field', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();
it('when enabled and `hideSlug` prop is passed, renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));
fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});

it('when disabled and `hideSlug` prop is passed, renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(false); // Environment disables slug
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});
});
Comment thread
coderabbitai[bot] marked this conversation as resolved.

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -85,6 +85,7 @@ describe('OrganizationList', () => {
it('hides the personal account with no data to list', async () => {
const { wrapper, props } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
f.withUser({
email_addresses: ['test@clerk.com'],
organization_memberships: [{ name: 'Org1', id: '1', role: 'admin' }],
Expand DownExpand Up@@ -210,6 +211,7 @@ describe('OrganizationList', () => {
it('display CreateOrganization within OrganizationList', async () => {
const { wrapper } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
Comment thread
LauraBeatris marked this conversation as resolved.
f.withUser({
email_addresses: ['test@clerk.com'],
create_organization_enabled: true,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
import { useOrganizationList } from '@clerk/shared/react';
import type { CreateOrganizationParams } from '@clerk/types';

import { useEnvironment } from '@/ui/contexts';
import { useTaskChooseOrganizationContext } from '@/ui/contexts/components/SessionTasks';
import { localizationKeys } from '@/ui/customizables';
import { useCardState } from '@/ui/elements/contexts';
Expand All@@ -25,6 +27,7 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
const { createOrganization, isLoaded, setActive } = useOrganizationList({
userMemberships: organizationListParams.userMemberships,
});
const { organizationSettings } = useEnvironment();

const nameField = useFormControl('name', '', {
type: 'text',
Expand All@@ -37,6 +40,8 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
placeholder: localizationKeys('taskChooseOrganization.createOrganization.formFieldInputPlaceholder__slug'),
});

const organizationSlugEnabled = !organizationSettings.slug.disabled;

const onSubmit = async (e: React.FormEvent) => {
e.preventDefault();

Expand All@@ -45,7 +50,13 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
}

try {
const organization = await createOrganization({ name: nameField.value, slug: slugField.value });
const createOrgParams: CreateOrganizationParams = { name: nameField.value };

if (organizationSlugEnabled) {
createOrgParams.slug = slugField.value;
}

const organization = await createOrganization(createOrgParams);

await setActive({
organization,
Expand DownExpand Up@@ -90,15 +101,17 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
ignorePasswordManager
/>
</Form.ControlRow>
<Form.ControlRow elementId={slugField.id}>
<Form.PlainInput
{...slugField.props}
onChange={event => updateSlugField(event.target.value)}
isRequired
pattern='^(?=.*[a-z0-9])[a-z0-9\-]+$'
ignorePasswordManager
/>
</Form.ControlRow>
{organizationSlugEnabled && (
<Form.ControlRow elementId={slugField.id}>
<Form.PlainInput
{...slugField.props}
onChange={event => updateSlugField(event.target.value)}
isRequired
pattern='^(?=.*[a-z0-9])[a-z0-9\-]+$'
ignorePasswordManager
/>
</Form.ControlRow>
)}

<FormButtonContainer sx={() => ({ flexDirection: 'column' })}>
<Form.SubmitButton
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/dull-paws-march.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
'@clerk/clerk-js': patch
'@clerk/types': patch
---

Display organization slug based on environment settings
9 changes: 9 additions & 0 deletions packages/clerk-js/src/core/resources/OrganizationSettings.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,6 +18,11 @@ export class OrganizationSettings extends BaseResource implements OrganizationSe
enrollmentModes: [],
defaultRole: null,
};
slug: {
disabled: boolean;
} = {
disabled: false,
};
enabled: boolean = false;
maxAllowedMemberships: number = 1;
forceOrganizationSelection!: boolean;
Expand All@@ -42,6 +47,10 @@ export class OrganizationSettings extends BaseResource implements OrganizationSe
this.domains.defaultRole = this.withDefault(data.domains.default_role, this.domains.defaultRole);
}

if (data.slug) {
this.slug.disabled = this.withDefault(data.slug.disabled, this.slug.disabled);
}

this.enabled = this.withDefault(data.enabled, this.enabled);
this.maxAllowedMemberships = this.withDefault(data.max_allowed_memberships, this.maxAllowedMemberships);
this.forceOrganizationSelection = this.withDefault(
Expand Down
11 changes: 10 additions & 1 deletion packages/clerk-js/src/test/fixture-helpers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -342,13 +342,22 @@ const createOrganizationSettingsFixtureHelpers = (environment: EnvironmentJSON)
const withForceOrganizationSelection = () => {
os.force_organization_selection = true;
};
const withOrganizationSlug = (enabled = false) => {
os.slug.disabled = !enabled;
};

const withOrganizationDomains = (modes?: OrganizationEnrollmentMode[], defaultRole?: string) => {
os.domains.enabled = true;
os.domains.enrollment_modes = modes || ['automatic_invitation', 'manual_invitation'];
os.domains.default_role = defaultRole ?? null;
};
return { withOrganizations, withMaxAllowedMemberships, withOrganizationDomains, withForceOrganizationSelection };
return {
withOrganizations,
withMaxAllowedMemberships,
withOrganizationDomains,
withForceOrganizationSelection,
withOrganizationSlug,
};
};

const createBillingSettingsFixtureHelpers = (environment: EnvironmentJSON) => {
Expand Down
3 changes: 3 additions & 0 deletions packages/clerk-js/src/test/fixtures.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -89,6 +89,9 @@ const createBaseOrganizationSettings = (): OrganizationSettingsJSON => {
enabled: false,
enrollment_modes: [],
},
slug: {
disabled: true,
},
} as unknown as OrganizationSettingsJSON;
};

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@ import { useOrganization, useOrganizationList } from '@clerk/shared/react';
import type { CreateOrganizationParams, OrganizationResource } from '@clerk/types';
import React from 'react';

import { useEnvironment } from '@/ui/contexts';
import { useCardState, withCardStateProvider } from '@/ui/elements/contexts';
import { Form } from '@/ui/elements/Form';
import { FormButtonContainer } from '@/ui/elements/FormButtons';
Expand DownExpand Up@@ -33,6 +34,11 @@ type CreateOrganizationFormProps = {
headerTitle?: LocalizationKey;
headerSubtitle?: LocalizationKey;
};
/**
* @deprecated
* This prop will be removed in a future version.
* Configure whether organization slug is enabled via the Clerk Dashboard under Organization Settings.
*/
hideSlug?: boolean;
};

Expand All@@ -45,6 +51,7 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
userMemberships: organizationListParams.userMemberships,
});
const { organization } = useOrganization();
const { organizationSettings } = useEnvironment();
Comment thread
coderabbitai[bot] marked this conversation as resolved.
const [file, setFile] = React.useState<File | null>();

const nameField = useFormControl('name', '', {
Expand All@@ -62,6 +69,9 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
const dataChanged = !!nameField.value;
const canSubmit = dataChanged;

// Environment setting takes precedence over prop
const organizationSlugEnabled = !organizationSettings.slug.disabled && !props.hideSlug;

const onSubmit = async (e: React.FormEvent) => {
e.preventDefault();
if (!canSubmit) {
Expand All@@ -75,7 +85,7 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
try {
const createOrgParams: CreateOrganizationParams = { name: nameField.value };

if (!props.hideSlug) {
if (organizationSlugEnabled) {
createOrgParams.slug = slugField.value;
}

Expand DownExpand Up@@ -188,7 +198,7 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
ignorePasswordManager
/>
</Form.ControlRow>
{!props.hideSlug && (
{organizationSlugEnabled && (
<Form.ControlRow elementId={slugField.id}>
<Form.PlainInput
{...slugField.props}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -80,35 +80,169 @@ describe('CreateOrganization', () => {
expect(getByRole('heading', { name: 'Create organization', level: 1 })).toBeInTheDocument();
});

it('renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withUser({
email_addresses: ['test@clerk.com'],
describe('with `hideSlug` prop', () => {
it('renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);
describe('with organization slug configured on environment', () => {
it('when disabled, renders component without slug field', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(false);
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});

it('when enabled, renders component slug field', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();
it('when enabled and `hideSlug` prop is passed, renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));
fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});

it('when disabled and `hideSlug` prop is passed, renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(false); // Environment disables slug
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});
});
Comment thread
coderabbitai[bot] marked this conversation as resolved.

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -85,6 +85,7 @@ describe('OrganizationList', () => {
it('hides the personal account with no data to list', async () => {
const { wrapper, props } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
f.withUser({
email_addresses: ['test@clerk.com'],
organization_memberships: [{ name: 'Org1', id: '1', role: 'admin' }],
Expand DownExpand Up@@ -210,6 +211,7 @@ describe('OrganizationList', () => {
it('display CreateOrganization within OrganizationList', async () => {
const { wrapper } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
Comment thread
LauraBeatris marked this conversation as resolved.
f.withUser({
email_addresses: ['test@clerk.com'],
create_organization_enabled: true,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
import { useOrganizationList } from '@clerk/shared/react';
import type { CreateOrganizationParams } from '@clerk/types';

import { useEnvironment } from '@/ui/contexts';
import { useTaskChooseOrganizationContext } from '@/ui/contexts/components/SessionTasks';
import { localizationKeys } from '@/ui/customizables';
import { useCardState } from '@/ui/elements/contexts';
Expand All@@ -25,6 +27,7 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
const { createOrganization, isLoaded, setActive } = useOrganizationList({
userMemberships: organizationListParams.userMemberships,
});
const { organizationSettings } = useEnvironment();

const nameField = useFormControl('name', '', {
type: 'text',
Expand All@@ -37,6 +40,8 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
placeholder: localizationKeys('taskChooseOrganization.createOrganization.formFieldInputPlaceholder__slug'),
});

const organizationSlugEnabled = !organizationSettings.slug.disabled;

const onSubmit = async (e: React.FormEvent) => {
e.preventDefault();

Expand All@@ -45,7 +50,13 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
}

try {
const organization = await createOrganization({ name: nameField.value, slug: slugField.value });
const createOrgParams: CreateOrganizationParams = { name: nameField.value };

if (organizationSlugEnabled) {
createOrgParams.slug = slugField.value;
}

const organization = await createOrganization(createOrgParams);

await setActive({
organization,
Expand DownExpand Up@@ -90,15 +101,17 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
ignorePasswordManager
/>
</Form.ControlRow>
<Form.ControlRow elementId={slugField.id}>
<Form.PlainInput
{...slugField.props}
onChange={event => updateSlugField(event.target.value)}
isRequired
pattern='^(?=.*[a-z0-9])[a-z0-9\-]+$'
ignorePasswordManager
/>
</Form.ControlRow>
{organizationSlugEnabled && (
<Form.ControlRow elementId={slugField.id}>
<Form.PlainInput
{...slugField.props}
onChange={event => updateSlugField(event.target.value)}
isRequired
pattern='^(?=.*[a-z0-9])[a-z0-9\-]+$'
ignorePasswordManager
/>
</Form.ControlRow>
)}

<FormButtonContainer sx={() => ({ flexDirection: 'column' })}>
<Form.SubmitButton
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/dull-paws-march.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
'@clerk/clerk-js': patch
'@clerk/types': patch
---

Display organization slug based on environment settings
9 changes: 9 additions & 0 deletions packages/clerk-js/src/core/resources/OrganizationSettings.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,6 +18,11 @@ export class OrganizationSettings extends BaseResource implements OrganizationSe
enrollmentModes: [],
defaultRole: null,
};
slug: {
disabled: boolean;
} = {
disabled: false,
};
enabled: boolean = false;
maxAllowedMemberships: number = 1;
forceOrganizationSelection!: boolean;
Expand All@@ -42,6 +47,10 @@ export class OrganizationSettings extends BaseResource implements OrganizationSe
this.domains.defaultRole = this.withDefault(data.domains.default_role, this.domains.defaultRole);
}

if (data.slug) {
this.slug.disabled = this.withDefault(data.slug.disabled, this.slug.disabled);
}

this.enabled = this.withDefault(data.enabled, this.enabled);
this.maxAllowedMemberships = this.withDefault(data.max_allowed_memberships, this.maxAllowedMemberships);
this.forceOrganizationSelection = this.withDefault(
Expand Down
11 changes: 10 additions & 1 deletion packages/clerk-js/src/test/fixture-helpers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -342,13 +342,22 @@ const createOrganizationSettingsFixtureHelpers = (environment: EnvironmentJSON)
const withForceOrganizationSelection = () => {
os.force_organization_selection = true;
};
const withOrganizationSlug = (enabled = false) => {
os.slug.disabled = !enabled;
};

const withOrganizationDomains = (modes?: OrganizationEnrollmentMode[], defaultRole?: string) => {
os.domains.enabled = true;
os.domains.enrollment_modes = modes || ['automatic_invitation', 'manual_invitation'];
os.domains.default_role = defaultRole ?? null;
};
return { withOrganizations, withMaxAllowedMemberships, withOrganizationDomains, withForceOrganizationSelection };
return {
withOrganizations,
withMaxAllowedMemberships,
withOrganizationDomains,
withForceOrganizationSelection,
withOrganizationSlug,
};
};

const createBillingSettingsFixtureHelpers = (environment: EnvironmentJSON) => {
Expand Down
3 changes: 3 additions & 0 deletions packages/clerk-js/src/test/fixtures.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -89,6 +89,9 @@ const createBaseOrganizationSettings = (): OrganizationSettingsJSON => {
enabled: false,
enrollment_modes: [],
},
slug: {
disabled: true,
},
} as unknown as OrganizationSettingsJSON;
};

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@ import { useOrganization, useOrganizationList } from '@clerk/shared/react';
import type { CreateOrganizationParams, OrganizationResource } from '@clerk/types';
import React from 'react';

import { useEnvironment } from '@/ui/contexts';
import { useCardState, withCardStateProvider } from '@/ui/elements/contexts';
import { Form } from '@/ui/elements/Form';
import { FormButtonContainer } from '@/ui/elements/FormButtons';
Expand DownExpand Up@@ -33,6 +34,11 @@ type CreateOrganizationFormProps = {
headerTitle?: LocalizationKey;
headerSubtitle?: LocalizationKey;
};
/**
* @deprecated
* This prop will be removed in a future version.
* Configure whether organization slug is enabled via the Clerk Dashboard under Organization Settings.
*/
hideSlug?: boolean;
};

Expand All@@ -45,6 +51,7 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
userMemberships: organizationListParams.userMemberships,
});
const { organization } = useOrganization();
const { organizationSettings } = useEnvironment();
Comment thread
coderabbitai[bot] marked this conversation as resolved.
const [file, setFile] = React.useState<File | null>();

const nameField = useFormControl('name', '', {
Expand All@@ -62,6 +69,9 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
const dataChanged = !!nameField.value;
const canSubmit = dataChanged;

// Environment setting takes precedence over prop
const organizationSlugEnabled = !organizationSettings.slug.disabled && !props.hideSlug;

const onSubmit = async (e: React.FormEvent) => {
e.preventDefault();
if (!canSubmit) {
Expand All@@ -75,7 +85,7 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
try {
const createOrgParams: CreateOrganizationParams = { name: nameField.value };

if (!props.hideSlug) {
if (organizationSlugEnabled) {
createOrgParams.slug = slugField.value;
}

Expand DownExpand Up@@ -188,7 +198,7 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
ignorePasswordManager
/>
</Form.ControlRow>
{!props.hideSlug && (
{organizationSlugEnabled && (
<Form.ControlRow elementId={slugField.id}>
<Form.PlainInput
{...slugField.props}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -80,35 +80,169 @@ describe('CreateOrganization', () => {
expect(getByRole('heading', { name: 'Create organization', level: 1 })).toBeInTheDocument();
});

it('renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withUser({
email_addresses: ['test@clerk.com'],
describe('with `hideSlug` prop', () => {
it('renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);
describe('with organization slug configured on environment', () => {
it('when disabled, renders component without slug field', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(false);
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});

it('when enabled, renders component slug field', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();
it('when enabled and `hideSlug` prop is passed, renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));
fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});

it('when disabled and `hideSlug` prop is passed, renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(false); // Environment disables slug
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});
});
Comment thread
coderabbitai[bot] marked this conversation as resolved.

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -85,6 +85,7 @@ describe('OrganizationList', () => {
it('hides the personal account with no data to list', async () => {
const { wrapper, props } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
f.withUser({
email_addresses: ['test@clerk.com'],
organization_memberships: [{ name: 'Org1', id: '1', role: 'admin' }],
Expand DownExpand Up@@ -210,6 +211,7 @@ describe('OrganizationList', () => {
it('display CreateOrganization within OrganizationList', async () => {
const { wrapper } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
Comment thread
LauraBeatris marked this conversation as resolved.
f.withUser({
email_addresses: ['test@clerk.com'],
create_organization_enabled: true,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
import { useOrganizationList } from '@clerk/shared/react';
import type { CreateOrganizationParams } from '@clerk/types';

import { useEnvironment } from '@/ui/contexts';
import { useTaskChooseOrganizationContext } from '@/ui/contexts/components/SessionTasks';
import { localizationKeys } from '@/ui/customizables';
import { useCardState } from '@/ui/elements/contexts';
Expand All@@ -25,6 +27,7 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
const { createOrganization, isLoaded, setActive } = useOrganizationList({
userMemberships: organizationListParams.userMemberships,
});
const { organizationSettings } = useEnvironment();

const nameField = useFormControl('name', '', {
type: 'text',
Expand All@@ -37,6 +40,8 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
placeholder: localizationKeys('taskChooseOrganization.createOrganization.formFieldInputPlaceholder__slug'),
});

const organizationSlugEnabled = !organizationSettings.slug.disabled;

const onSubmit = async (e: React.FormEvent) => {
e.preventDefault();

Expand All@@ -45,7 +50,13 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
}

try {
const organization = await createOrganization({ name: nameField.value, slug: slugField.value });
const createOrgParams: CreateOrganizationParams = { name: nameField.value };

if (organizationSlugEnabled) {
createOrgParams.slug = slugField.value;
}

const organization = await createOrganization(createOrgParams);

await setActive({
organization,
Expand DownExpand Up@@ -90,15 +101,17 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
ignorePasswordManager
/>
</Form.ControlRow>
<Form.ControlRow elementId={slugField.id}>
<Form.PlainInput
{...slugField.props}
onChange={event => updateSlugField(event.target.value)}
isRequired
pattern='^(?=.*[a-z0-9])[a-z0-9\-]+$'
ignorePasswordManager
/>
</Form.ControlRow>
{organizationSlugEnabled && (
<Form.ControlRow elementId={slugField.id}>
<Form.PlainInput
{...slugField.props}
onChange={event => updateSlugField(event.target.value)}
isRequired
pattern='^(?=.*[a-z0-9])[a-z0-9\-]+$'
ignorePasswordManager
/>
</Form.ControlRow>
)}

<FormButtonContainer sx={() => ({ flexDirection: 'column' })}>
<Form.SubmitButton
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/dull-paws-march.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
'@clerk/clerk-js': patch
'@clerk/types': patch
---

Display organization slug based on environment settings
9 changes: 9 additions & 0 deletions packages/clerk-js/src/core/resources/OrganizationSettings.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,6 +18,11 @@ export class OrganizationSettings extends BaseResource implements OrganizationSe
enrollmentModes: [],
defaultRole: null,
};
slug: {
disabled: boolean;
} = {
disabled: false,
};
enabled: boolean = false;
maxAllowedMemberships: number = 1;
forceOrganizationSelection!: boolean;
Expand All@@ -42,6 +47,10 @@ export class OrganizationSettings extends BaseResource implements OrganizationSe
this.domains.defaultRole = this.withDefault(data.domains.default_role, this.domains.defaultRole);
}

if (data.slug) {
this.slug.disabled = this.withDefault(data.slug.disabled, this.slug.disabled);
}

this.enabled = this.withDefault(data.enabled, this.enabled);
this.maxAllowedMemberships = this.withDefault(data.max_allowed_memberships, this.maxAllowedMemberships);
this.forceOrganizationSelection = this.withDefault(
Expand Down
11 changes: 10 additions & 1 deletion packages/clerk-js/src/test/fixture-helpers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -342,13 +342,22 @@ const createOrganizationSettingsFixtureHelpers = (environment: EnvironmentJSON)
const withForceOrganizationSelection = () => {
os.force_organization_selection = true;
};
const withOrganizationSlug = (enabled = false) => {
os.slug.disabled = !enabled;
};

const withOrganizationDomains = (modes?: OrganizationEnrollmentMode[], defaultRole?: string) => {
os.domains.enabled = true;
os.domains.enrollment_modes = modes || ['automatic_invitation', 'manual_invitation'];
os.domains.default_role = defaultRole ?? null;
};
return { withOrganizations, withMaxAllowedMemberships, withOrganizationDomains, withForceOrganizationSelection };
return {
withOrganizations,
withMaxAllowedMemberships,
withOrganizationDomains,
withForceOrganizationSelection,
withOrganizationSlug,
};
};

const createBillingSettingsFixtureHelpers = (environment: EnvironmentJSON) => {
Expand Down
3 changes: 3 additions & 0 deletions packages/clerk-js/src/test/fixtures.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -89,6 +89,9 @@ const createBaseOrganizationSettings = (): OrganizationSettingsJSON => {
enabled: false,
enrollment_modes: [],
},
slug: {
disabled: true,
},
} as unknown as OrganizationSettingsJSON;
};

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@ import { useOrganization, useOrganizationList } from '@clerk/shared/react';
import type { CreateOrganizationParams, OrganizationResource } from '@clerk/types';
import React from 'react';

import { useEnvironment } from '@/ui/contexts';
import { useCardState, withCardStateProvider } from '@/ui/elements/contexts';
import { Form } from '@/ui/elements/Form';
import { FormButtonContainer } from '@/ui/elements/FormButtons';
Expand DownExpand Up@@ -33,6 +34,11 @@ type CreateOrganizationFormProps = {
headerTitle?: LocalizationKey;
headerSubtitle?: LocalizationKey;
};
/**
* @deprecated
* This prop will be removed in a future version.
* Configure whether organization slug is enabled via the Clerk Dashboard under Organization Settings.
*/
hideSlug?: boolean;
};

Expand All@@ -45,6 +51,7 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
userMemberships: organizationListParams.userMemberships,
});
const { organization } = useOrganization();
const { organizationSettings } = useEnvironment();
Comment thread
coderabbitai[bot] marked this conversation as resolved.
const [file, setFile] = React.useState<File | null>();

const nameField = useFormControl('name', '', {
Expand All@@ -62,6 +69,9 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
const dataChanged = !!nameField.value;
const canSubmit = dataChanged;

// Environment setting takes precedence over prop
const organizationSlugEnabled = !organizationSettings.slug.disabled && !props.hideSlug;

const onSubmit = async (e: React.FormEvent) => {
e.preventDefault();
if (!canSubmit) {
Expand All@@ -75,7 +85,7 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
try {
const createOrgParams: CreateOrganizationParams = { name: nameField.value };

if (!props.hideSlug) {
if (organizationSlugEnabled) {
createOrgParams.slug = slugField.value;
}

Expand DownExpand Up@@ -188,7 +198,7 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
ignorePasswordManager
/>
</Form.ControlRow>
{!props.hideSlug && (
{organizationSlugEnabled && (
<Form.ControlRow elementId={slugField.id}>
<Form.PlainInput
{...slugField.props}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -80,35 +80,169 @@ describe('CreateOrganization', () => {
expect(getByRole('heading', { name: 'Create organization', level: 1 })).toBeInTheDocument();
});

it('renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withUser({
email_addresses: ['test@clerk.com'],
describe('with `hideSlug` prop', () => {
it('renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);
describe('with organization slug configured on environment', () => {
it('when disabled, renders component without slug field', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(false);
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});

it('when enabled, renders component slug field', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();
it('when enabled and `hideSlug` prop is passed, renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));
fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});

it('when disabled and `hideSlug` prop is passed, renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(false); // Environment disables slug
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});
});
Comment thread
coderabbitai[bot] marked this conversation as resolved.

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -85,6 +85,7 @@ describe('OrganizationList', () => {
it('hides the personal account with no data to list', async () => {
const { wrapper, props } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
f.withUser({
email_addresses: ['test@clerk.com'],
organization_memberships: [{ name: 'Org1', id: '1', role: 'admin' }],
Expand DownExpand Up@@ -210,6 +211,7 @@ describe('OrganizationList', () => {
it('display CreateOrganization within OrganizationList', async () => {
const { wrapper } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
Comment thread
LauraBeatris marked this conversation as resolved.
f.withUser({
email_addresses: ['test@clerk.com'],
create_organization_enabled: true,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
import { useOrganizationList } from '@clerk/shared/react';
import type { CreateOrganizationParams } from '@clerk/types';

import { useEnvironment } from '@/ui/contexts';
import { useTaskChooseOrganizationContext } from '@/ui/contexts/components/SessionTasks';
import { localizationKeys } from '@/ui/customizables';
import { useCardState } from '@/ui/elements/contexts';
Expand All@@ -25,6 +27,7 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
const { createOrganization, isLoaded, setActive } = useOrganizationList({
userMemberships: organizationListParams.userMemberships,
});
const { organizationSettings } = useEnvironment();

const nameField = useFormControl('name', '', {
type: 'text',
Expand All@@ -37,6 +40,8 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
placeholder: localizationKeys('taskChooseOrganization.createOrganization.formFieldInputPlaceholder__slug'),
});

const organizationSlugEnabled = !organizationSettings.slug.disabled;

const onSubmit = async (e: React.FormEvent) => {
e.preventDefault();

Expand All@@ -45,7 +50,13 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
}

try {
const organization = await createOrganization({ name: nameField.value, slug: slugField.value });
const createOrgParams: CreateOrganizationParams = { name: nameField.value };

if (organizationSlugEnabled) {
createOrgParams.slug = slugField.value;
}

const organization = await createOrganization(createOrgParams);

await setActive({
organization,
Expand DownExpand Up@@ -90,15 +101,17 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
ignorePasswordManager
/>
</Form.ControlRow>
<Form.ControlRow elementId={slugField.id}>
<Form.PlainInput
{...slugField.props}
onChange={event => updateSlugField(event.target.value)}
isRequired
pattern='^(?=.*[a-z0-9])[a-z0-9\-]+$'
ignorePasswordManager
/>
</Form.ControlRow>
{organizationSlugEnabled && (
<Form.ControlRow elementId={slugField.id}>
<Form.PlainInput
{...slugField.props}
onChange={event => updateSlugField(event.target.value)}
isRequired
pattern='^(?=.*[a-z0-9])[a-z0-9\-]+$'
ignorePasswordManager
/>
</Form.ControlRow>
)}

<FormButtonContainer sx={() => ({ flexDirection: 'column' })}>
<Form.SubmitButton
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/dull-paws-march.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
'@clerk/clerk-js': patch
'@clerk/types': patch
---

Display organization slug based on environment settings
9 changes: 9 additions & 0 deletions packages/clerk-js/src/core/resources/OrganizationSettings.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,6 +18,11 @@ export class OrganizationSettings extends BaseResource implements OrganizationSe
enrollmentModes: [],
defaultRole: null,
};
slug: {
disabled: boolean;
} = {
disabled: false,
};
enabled: boolean = false;
maxAllowedMemberships: number = 1;
forceOrganizationSelection!: boolean;
Expand All@@ -42,6 +47,10 @@ export class OrganizationSettings extends BaseResource implements OrganizationSe
this.domains.defaultRole = this.withDefault(data.domains.default_role, this.domains.defaultRole);
}

if (data.slug) {
this.slug.disabled = this.withDefault(data.slug.disabled, this.slug.disabled);
}

this.enabled = this.withDefault(data.enabled, this.enabled);
this.maxAllowedMemberships = this.withDefault(data.max_allowed_memberships, this.maxAllowedMemberships);
this.forceOrganizationSelection = this.withDefault(
Expand Down
11 changes: 10 additions & 1 deletion packages/clerk-js/src/test/fixture-helpers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -342,13 +342,22 @@ const createOrganizationSettingsFixtureHelpers = (environment: EnvironmentJSON)
const withForceOrganizationSelection = () => {
os.force_organization_selection = true;
};
const withOrganizationSlug = (enabled = false) => {
os.slug.disabled = !enabled;
};

const withOrganizationDomains = (modes?: OrganizationEnrollmentMode[], defaultRole?: string) => {
os.domains.enabled = true;
os.domains.enrollment_modes = modes || ['automatic_invitation', 'manual_invitation'];
os.domains.default_role = defaultRole ?? null;
};
return { withOrganizations, withMaxAllowedMemberships, withOrganizationDomains, withForceOrganizationSelection };
return {
withOrganizations,
withMaxAllowedMemberships,
withOrganizationDomains,
withForceOrganizationSelection,
withOrganizationSlug,
};
};

const createBillingSettingsFixtureHelpers = (environment: EnvironmentJSON) => {
Expand Down
3 changes: 3 additions & 0 deletions packages/clerk-js/src/test/fixtures.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -89,6 +89,9 @@ const createBaseOrganizationSettings = (): OrganizationSettingsJSON => {
enabled: false,
enrollment_modes: [],
},
slug: {
disabled: true,
},
} as unknown as OrganizationSettingsJSON;
};

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@ import { useOrganization, useOrganizationList } from '@clerk/shared/react';
import type { CreateOrganizationParams, OrganizationResource } from '@clerk/types';
import React from 'react';

import { useEnvironment } from '@/ui/contexts';
import { useCardState, withCardStateProvider } from '@/ui/elements/contexts';
import { Form } from '@/ui/elements/Form';
import { FormButtonContainer } from '@/ui/elements/FormButtons';
Expand DownExpand Up@@ -33,6 +34,11 @@ type CreateOrganizationFormProps = {
headerTitle?: LocalizationKey;
headerSubtitle?: LocalizationKey;
};
/**
* @deprecated
* This prop will be removed in a future version.
* Configure whether organization slug is enabled via the Clerk Dashboard under Organization Settings.
*/
hideSlug?: boolean;
};

Expand All@@ -45,6 +51,7 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
userMemberships: organizationListParams.userMemberships,
});
const { organization } = useOrganization();
const { organizationSettings } = useEnvironment();
Comment thread
coderabbitai[bot] marked this conversation as resolved.
const [file, setFile] = React.useState<File | null>();

const nameField = useFormControl('name', '', {
Expand All@@ -62,6 +69,9 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
const dataChanged = !!nameField.value;
const canSubmit = dataChanged;

// Environment setting takes precedence over prop
const organizationSlugEnabled = !organizationSettings.slug.disabled && !props.hideSlug;

const onSubmit = async (e: React.FormEvent) => {
e.preventDefault();
if (!canSubmit) {
Expand All@@ -75,7 +85,7 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
try {
const createOrgParams: CreateOrganizationParams = { name: nameField.value };

if (!props.hideSlug) {
if (organizationSlugEnabled) {
createOrgParams.slug = slugField.value;
}

Expand DownExpand Up@@ -188,7 +198,7 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
ignorePasswordManager
/>
</Form.ControlRow>
{!props.hideSlug && (
{organizationSlugEnabled && (
<Form.ControlRow elementId={slugField.id}>
<Form.PlainInput
{...slugField.props}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -80,35 +80,169 @@ describe('CreateOrganization', () => {
expect(getByRole('heading', { name: 'Create organization', level: 1 })).toBeInTheDocument();
});

it('renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withUser({
email_addresses: ['test@clerk.com'],
describe('with `hideSlug` prop', () => {
it('renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);
describe('with organization slug configured on environment', () => {
it('when disabled, renders component without slug field', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(false);
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});

it('when enabled, renders component slug field', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();
it('when enabled and `hideSlug` prop is passed, renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));
fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});

it('when disabled and `hideSlug` prop is passed, renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(false); // Environment disables slug
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});
});
Comment thread
coderabbitai[bot] marked this conversation as resolved.

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -85,6 +85,7 @@ describe('OrganizationList', () => {
it('hides the personal account with no data to list', async () => {
const { wrapper, props } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
f.withUser({
email_addresses: ['test@clerk.com'],
organization_memberships: [{ name: 'Org1', id: '1', role: 'admin' }],
Expand DownExpand Up@@ -210,6 +211,7 @@ describe('OrganizationList', () => {
it('display CreateOrganization within OrganizationList', async () => {
const { wrapper } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
Comment thread
LauraBeatris marked this conversation as resolved.
f.withUser({
email_addresses: ['test@clerk.com'],
create_organization_enabled: true,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
import { useOrganizationList } from '@clerk/shared/react';
import type { CreateOrganizationParams } from '@clerk/types';

import { useEnvironment } from '@/ui/contexts';
import { useTaskChooseOrganizationContext } from '@/ui/contexts/components/SessionTasks';
import { localizationKeys } from '@/ui/customizables';
import { useCardState } from '@/ui/elements/contexts';
Expand All@@ -25,6 +27,7 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
const { createOrganization, isLoaded, setActive } = useOrganizationList({
userMemberships: organizationListParams.userMemberships,
});
const { organizationSettings } = useEnvironment();

const nameField = useFormControl('name', '', {
type: 'text',
Expand All@@ -37,6 +40,8 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
placeholder: localizationKeys('taskChooseOrganization.createOrganization.formFieldInputPlaceholder__slug'),
});

const organizationSlugEnabled = !organizationSettings.slug.disabled;

const onSubmit = async (e: React.FormEvent) => {
e.preventDefault();

Expand All@@ -45,7 +50,13 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
}

try {
const organization = await createOrganization({ name: nameField.value, slug: slugField.value });
const createOrgParams: CreateOrganizationParams = { name: nameField.value };

if (organizationSlugEnabled) {
createOrgParams.slug = slugField.value;
}

const organization = await createOrganization(createOrgParams);

await setActive({
organization,
Expand DownExpand Up@@ -90,15 +101,17 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
ignorePasswordManager
/>
</Form.ControlRow>
<Form.ControlRow elementId={slugField.id}>
<Form.PlainInput
{...slugField.props}
onChange={event => updateSlugField(event.target.value)}
isRequired
pattern='^(?=.*[a-z0-9])[a-z0-9\-]+$'
ignorePasswordManager
/>
</Form.ControlRow>
{organizationSlugEnabled && (
<Form.ControlRow elementId={slugField.id}>
<Form.PlainInput
{...slugField.props}
onChange={event => updateSlugField(event.target.value)}
isRequired
pattern='^(?=.*[a-z0-9])[a-z0-9\-]+$'
ignorePasswordManager
/>
</Form.ControlRow>
)}

<FormButtonContainer sx={() => ({ flexDirection: 'column' })}>
<Form.SubmitButton
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/dull-paws-march.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
'@clerk/clerk-js': patch
'@clerk/types': patch
---

Display organization slug based on environment settings
9 changes: 9 additions & 0 deletions packages/clerk-js/src/core/resources/OrganizationSettings.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,6 +18,11 @@ export class OrganizationSettings extends BaseResource implements OrganizationSe
enrollmentModes: [],
defaultRole: null,
};
slug: {
disabled: boolean;
} = {
disabled: false,
};
enabled: boolean = false;
maxAllowedMemberships: number = 1;
forceOrganizationSelection!: boolean;
Expand All@@ -42,6 +47,10 @@ export class OrganizationSettings extends BaseResource implements OrganizationSe
this.domains.defaultRole = this.withDefault(data.domains.default_role, this.domains.defaultRole);
}

if (data.slug) {
this.slug.disabled = this.withDefault(data.slug.disabled, this.slug.disabled);
}

this.enabled = this.withDefault(data.enabled, this.enabled);
this.maxAllowedMemberships = this.withDefault(data.max_allowed_memberships, this.maxAllowedMemberships);
this.forceOrganizationSelection = this.withDefault(
Expand Down
11 changes: 10 additions & 1 deletion packages/clerk-js/src/test/fixture-helpers.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -342,13 +342,22 @@ const createOrganizationSettingsFixtureHelpers = (environment: EnvironmentJSON)
const withForceOrganizationSelection = () => {
os.force_organization_selection = true;
};
const withOrganizationSlug = (enabled = false) => {
os.slug.disabled = !enabled;
};

const withOrganizationDomains = (modes?: OrganizationEnrollmentMode[], defaultRole?: string) => {
os.domains.enabled = true;
os.domains.enrollment_modes = modes || ['automatic_invitation', 'manual_invitation'];
os.domains.default_role = defaultRole ?? null;
};
return { withOrganizations, withMaxAllowedMemberships, withOrganizationDomains, withForceOrganizationSelection };
return {
withOrganizations,
withMaxAllowedMemberships,
withOrganizationDomains,
withForceOrganizationSelection,
withOrganizationSlug,
};
};

const createBillingSettingsFixtureHelpers = (environment: EnvironmentJSON) => {
Expand Down
3 changes: 3 additions & 0 deletions packages/clerk-js/src/test/fixtures.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -89,6 +89,9 @@ const createBaseOrganizationSettings = (): OrganizationSettingsJSON => {
enabled: false,
enrollment_modes: [],
},
slug: {
disabled: true,
},
} as unknown as OrganizationSettingsJSON;
};

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@ import { useOrganization, useOrganizationList } from '@clerk/shared/react';
import type { CreateOrganizationParams, OrganizationResource } from '@clerk/types';
import React from 'react';

import { useEnvironment } from '@/ui/contexts';
import { useCardState, withCardStateProvider } from '@/ui/elements/contexts';
import { Form } from '@/ui/elements/Form';
import { FormButtonContainer } from '@/ui/elements/FormButtons';
Expand DownExpand Up@@ -33,6 +34,11 @@ type CreateOrganizationFormProps = {
headerTitle?: LocalizationKey;
headerSubtitle?: LocalizationKey;
};
/**
* @deprecated
* This prop will be removed in a future version.
* Configure whether organization slug is enabled via the Clerk Dashboard under Organization Settings.
*/
hideSlug?: boolean;
};

Expand All@@ -45,6 +51,7 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
userMemberships: organizationListParams.userMemberships,
});
const { organization } = useOrganization();
const { organizationSettings } = useEnvironment();
Comment thread
coderabbitai[bot] marked this conversation as resolved.
const [file, setFile] = React.useState<File | null>();

const nameField = useFormControl('name', '', {
Expand All@@ -62,6 +69,9 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
const dataChanged = !!nameField.value;
const canSubmit = dataChanged;

// Environment setting takes precedence over prop
const organizationSlugEnabled = !organizationSettings.slug.disabled && !props.hideSlug;

const onSubmit = async (e: React.FormEvent) => {
e.preventDefault();
if (!canSubmit) {
Expand All@@ -75,7 +85,7 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
try {
const createOrgParams: CreateOrganizationParams = { name: nameField.value };

if (!props.hideSlug) {
if (organizationSlugEnabled) {
createOrgParams.slug = slugField.value;
}

Expand DownExpand Up@@ -188,7 +198,7 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
ignorePasswordManager
/>
</Form.ControlRow>
{!props.hideSlug && (
{organizationSlugEnabled && (
<Form.ControlRow elementId={slugField.id}>
<Form.PlainInput
{...slugField.props}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -80,35 +80,169 @@ describe('CreateOrganization', () => {
expect(getByRole('heading', { name: 'Create organization', level: 1 })).toBeInTheDocument();
});

it('renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withUser({
email_addresses: ['test@clerk.com'],
describe('with `hideSlug` prop', () => {
it('renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);
describe('with organization slug configured on environment', () => {
it('when disabled, renders component without slug field', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(false);
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});

it('when enabled, renders component slug field', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();
it('when enabled and `hideSlug` prop is passed, renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));
fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});

it('when disabled and `hideSlug` prop is passed, renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(false); // Environment disables slug
f.withUser({
email_addresses: ['test@clerk.com'],
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});
});
Comment thread
coderabbitai[bot] marked this conversation as resolved.

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -85,6 +85,7 @@ describe('OrganizationList', () => {
it('hides the personal account with no data to list', async () => {
const { wrapper, props } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
f.withUser({
email_addresses: ['test@clerk.com'],
organization_memberships: [{ name: 'Org1', id: '1', role: 'admin' }],
Expand DownExpand Up@@ -210,6 +211,7 @@ describe('OrganizationList', () => {
it('display CreateOrganization within OrganizationList', async () => {
const { wrapper } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
Comment thread
LauraBeatris marked this conversation as resolved.
f.withUser({
email_addresses: ['test@clerk.com'],
create_organization_enabled: true,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
import { useOrganizationList } from '@clerk/shared/react';
import type { CreateOrganizationParams } from '@clerk/types';

import { useEnvironment } from '@/ui/contexts';
import { useTaskChooseOrganizationContext } from '@/ui/contexts/components/SessionTasks';
import { localizationKeys } from '@/ui/customizables';
import { useCardState } from '@/ui/elements/contexts';
Expand All@@ -25,6 +27,7 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
const { createOrganization, isLoaded, setActive } = useOrganizationList({
userMemberships: organizationListParams.userMemberships,
});
const { organizationSettings } = useEnvironment();

const nameField = useFormControl('name', '', {
type: 'text',
Expand All@@ -37,6 +40,8 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
placeholder: localizationKeys('taskChooseOrganization.createOrganization.formFieldInputPlaceholder__slug'),
});

const organizationSlugEnabled = !organizationSettings.slug.disabled;

const onSubmit = async (e: React.FormEvent) => {
e.preventDefault();

Expand All@@ -45,7 +50,13 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
}

try {
const organization = await createOrganization({ name: nameField.value, slug: slugField.value });
const createOrgParams: CreateOrganizationParams = { name: nameField.value };

if (organizationSlugEnabled) {
createOrgParams.slug = slugField.value;
}

const organization = await createOrganization(createOrgParams);

await setActive({
organization,
Expand DownExpand Up@@ -90,15 +101,17 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
ignorePasswordManager
/>
</Form.ControlRow>
<Form.ControlRow elementId={slugField.id}>
<Form.PlainInput
{...slugField.props}
onChange={event => updateSlugField(event.target.value)}
isRequired
pattern='^(?=.*[a-z0-9])[a-z0-9\-]+$'
ignorePasswordManager
/>
</Form.ControlRow>
{organizationSlugEnabled && (
<Form.ControlRow elementId={slugField.id}>
<Form.PlainInput
{...slugField.props}
onChange={event => updateSlugField(event.target.value)}
isRequired
pattern='^(?=.*[a-z0-9])[a-z0-9\-]+$'
ignorePasswordManager
/>
</Form.ControlRow>
)}

<FormButtonContainer sx={() => ({ flexDirection: 'column' })}>
<Form.SubmitButton
Expand Down
Loading
Loading