Uh oh!
There was an error while loading. Please reload this page.
Revert "fix(nuxt): Prevent Nuxt route middlewares from seeing intermediate states during navigation" - #6928
Merged
Merged
Conversation
…diate st…" This reverts commit e2dd40a.
🦋 Changeset detectedLatest commit: 4114153 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
WalkthroughRemoved nextTick wrapping from Nuxt runtime navigation helpers. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant App
participant Router
rect rgba(220, 248, 207, 0.6)
note over App: New flow (direct)
User->>App: routerPush(to) / routerReplace(to)
App->>Router: navigateTo(to) / navigateTo(to, { replace: true })
Router-->>User: Navigation handled
end
rect rgba(255, 243, 207, 0.6)
note over App: Prior flow (queued)
User->>App: routerPush(to) / routerReplace(to)
App->>App: nextTick(() => ...)
App->>Router: navigateTo(...)
Router-->>User: Navigation handled
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
4 tasks
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.changeset/ten-poets-agree.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Automated releases must use Changesets.
Files:
.changeset/ten-poets-agree.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (29)
- GitHub Check: Integration Tests (machine, chrome)
- GitHub Check: Integration Tests (nextjs, chrome, 15)
- GitHub Check: Integration Tests (custom, chrome)
- GitHub Check: Integration Tests (react-router, chrome)
- GitHub Check: Integration Tests (nuxt, chrome)
- GitHub Check: Integration Tests (nextjs, chrome, 14)
- GitHub Check: Integration Tests (billing, chrome)
- GitHub Check: Integration Tests (vue, chrome)
- GitHub Check: Integration Tests (expo-web, chrome)
- GitHub Check: Integration Tests (tanstack-react-start, chrome)
- GitHub Check: Integration Tests (handshake, chrome)
- GitHub Check: Integration Tests (handshake:staging, chrome)
- GitHub Check: Integration Tests (tanstack-react-router, chrome)
- GitHub Check: Integration Tests (astro, chrome)
- GitHub Check: Integration Tests (sessions, chrome)
- GitHub Check: Integration Tests (elements, chrome)
- GitHub Check: Integration Tests (sessions:staging, chrome)
- GitHub Check: Integration Tests (quickstart, chrome)
- GitHub Check: Integration Tests (ap-flows, chrome)
- GitHub Check: Integration Tests (generic, chrome)
- GitHub Check: Integration Tests (localhost, chrome)
- GitHub Check: Integration Tests (express, chrome)
- GitHub Check: Unit Tests (18, --filter=@clerk/astro --filter=@clerk/backend --filter=@clerk/express --filter=@c...
- GitHub Check: Unit Tests (22, **)
- GitHub Check: Publish with pkg-pr-new
- GitHub Check: Static analysis
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: semgrep-cloud-platform/scan
Comment on lines
+1
to
+5
| --- | ||
| "@clerk/nuxt": minor | ||
| --- | ||
| Remove added `nextTick()` calls when invoking Clerk routing functions. |
Contributor
There was a problem hiding this comment.
Changeset summary contradicts the revert.
This PR restores the nextTick wrapper, yet the changeset still advertises removing it. Shipping this note would mislead downstream consumers and trigger an incorrect minor release. Please delete this changeset or replace it with one that accurately states the revert (likely a patch note explaining that the previous change was rolled back).
🤖 Prompt for AI Agents
.changeset/ten-poets-agree.md lines 1-5: the changeset message advertises
removing nextTick and marks a minor bump but this PR actually reverts that
change; either delete this changeset or update it to accurately describe the
revert and use a patch release. Replace the body summary to state that the
previous removal of nextTick was reverted (restored behavior), change the
release type from "minor" to "patch" (or remove the file if you prefer no
release note), and ensure the changelog text clearly explains the rollback.
@clerk/agent-toolkit@clerk/astro@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/dev-cli@clerk/elements@clerk/clerk-expo@clerk/expo-passkeys@clerk/express@clerk/fastify@clerk/localizations@clerk/nextjs@clerk/nuxt@clerk/clerk-react@clerk/react-router@clerk/remix@clerk/shared@clerk/tanstack-react-start@clerk/testing@clerk/themes@clerk/types@clerk/upgrade@clerk/vuecommit: |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
nikosdouvlis pushed a commit
that referenced
this pull request
Oct 12, 2025
…diate states during navigation" (#6928)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #6802
The original intent of the PR is to fix issues with
setTransitiveState()in non-React apps, but looks like it introduced another issue (#6904). We have plans to killsetTransitiveState()so I guess it's better to wait for that than to patch it like this.Summary by CodeRabbit