chore(clerk-js,types): Remove paymentMethodId from subscription item - #7017

Merged
panteliselef merged 1 commit into
mainfrom
elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js
Oct 17, 2025
Merged

chore(clerk-js,types): Remove paymentMethodId from subscription item#7017
panteliselef merged 1 commit into
mainfrom
elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js

Conversation

@panteliselef

@panteliselefpanteliselef commented Oct 17, 2025•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Chores
    • Removed paymentMethodId field from billing subscription items as part of Billing Beta updates. Type definitions and test fixtures updated accordingly.

@panteliselefpanteliselef self-assigned this Oct 17, 2025
@changeset-bot

changeset-botBot commented Oct 17, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ace9b39

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
NameType
@clerk/clerk-jsMinor
@clerk/typesMinor
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Oct 17, 2025•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentOct 17, 2025 11:39am

@coderabbitai

coderabbitaiBot commented Oct 17, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

Removes the paymentMethodId field from billing subscription types and implementation across @clerk/clerk-js and @clerk/types packages. Updates test fixtures to match the field removal. Includes changelog entry documenting the changes.

Changes

Cohort / File(s)Summary
Type Definitions
packages/types/src/billing.ts, packages/types/src/json.ts		Removed paymentMethodId (TypeScript) and payment_method_id (JSON) fields from BillingSubscriptionItemResource and BillingSubscriptionItemJSON interfaces respectively.
Implementation
packages/clerk-js/src/core/resources/BillingSubscription.ts		Removed public paymentMethodId property from BillingSubscriptionItem class and eliminated assignment from fromJSON deserialization path.
Test Fixtures
packages/clerk-js/src/ui/components/PricingTable/__tests__/PricingTable.test.tsx, packages/clerk-js/src/ui/components/PricingTable/utils/pricing-footer-state.spec.ts, packages/clerk-js/src/ui/components/SubscriptionDetails/__tests__/SubscriptionDetails.test.tsx, packages/clerk-js/src/ui/components/Subscriptions/__tests__/SubscriptionsList.test.tsx		Removed paymentMethodId property from subscriptionItems mock fixtures across multiple test cases.
Changelog
.changeset/good-buckets-cry.md		Added changelog entry documenting minor version bumps for @clerk/clerk-js and @clerk/types with billing beta note on paymentMethodId removal.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

The changes are homogeneous and mechanical—consistent field removal across type definitions, implementation, and test fixtures with no complex logic alterations.

Poem

🐰 A payment method fades away,
The billing subscription's simpler today,
With paymentMethodId removed with grace,
Our types find a cleaner space! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe PR title "chore(clerk-js,types): Remove paymentMethodId from subscription item" directly and accurately reflects the primary change across the entire changeset. The raw summary consistently documents that the paymentMethodId property is being removed from BillingSubscriptionItem classes, type definitions, and related test fixtures across both the clerk-js and types packages. The title uses the conventional commit format appropriately, specifies the affected packages, and clearly conveys the main objective without vague language or unnecessary noise. A teammate scanning the pull request history would immediately understand that this change removes a payment method identifier field from subscription items.
Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f4a444c and ace9b39.

📒 Files selected for processing (8)
  • .changeset/good-buckets-cry.md (1 hunks)
  • packages/clerk-js/src/core/resources/BillingSubscription.ts (0 hunks)
  • packages/clerk-js/src/ui/components/PricingTable/__tests__/PricingTable.test.tsx (0 hunks)
  • packages/clerk-js/src/ui/components/PricingTable/utils/pricing-footer-state.spec.ts (0 hunks)
  • packages/clerk-js/src/ui/components/SubscriptionDetails/__tests__/SubscriptionDetails.test.tsx (0 hunks)
  • packages/clerk-js/src/ui/components/Subscriptions/__tests__/SubscriptionsList.test.tsx (0 hunks)
  • packages/types/src/billing.ts (0 hunks)
  • packages/types/src/json.ts (0 hunks)
💤 Files with no reviewable changes (7)
  • packages/clerk-js/src/ui/components/PricingTable/tests/PricingTable.test.tsx
  • packages/types/src/billing.ts
  • packages/clerk-js/src/ui/components/Subscriptions/tests/SubscriptionsList.test.tsx
  • packages/clerk-js/src/ui/components/SubscriptionDetails/tests/SubscriptionDetails.test.tsx
  • packages/types/src/json.ts
  • packages/clerk-js/src/ui/components/PricingTable/utils/pricing-footer-state.spec.ts
  • packages/clerk-js/src/core/resources/BillingSubscription.ts
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Automated releases must use Changesets.

Files:

  • .changeset/good-buckets-cry.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Build Packages
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
.changeset/good-buckets-cry.md (1)

1-6: Changeset format and content look correct.

The changeset properly declares version bumps for both affected packages (@clerk/clerk-js and @clerk/types) and clearly documents the removal of paymentMethodId from the subscription item. The minor version bump is appropriate for field removal in a Beta API.

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Oct 17, 2025

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7017

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7017

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7017

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7017

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7017

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7017

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@7017

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@7017

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7017

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7017

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7017

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7017

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7017

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7017

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@7017

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7017

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@7017

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7017

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7017

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7017

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@7017

@clerk/types

npm i https://pkg.pr.new/@clerk/types@7017

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7017

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7017

commit: ace9b39

@panteliselef
panteliselef merged commit a172d51 into mainOct 17, 2025
42 checks passed
@panteliselef
panteliselef deleted the elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js branch October 17, 2025 12:24
@clerk-cookieclerk-cookie mentioned this pull request Oct 17, 2025
Merged
NicolasLopes7 pushed a commit that referenced this pull request Oct 23, 2025
@panteliselef@NicolasLopes7
chore(clerk-js,types): Remove paymentMethodId from subscription item (
6a1e6e1
#7017)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paddycarverpaddycarverAwaiting requested review from paddycarver
@mzhong9723mzhong9723Awaiting requested review from mzhong9723
1 more reviewer
@iagodahlemiagodahlemiagodahlem approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@panteliselefpanteliselef

Labels

clerk-jstypes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@panteliselef@iagodahlem@clerk-cookie
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
chore(clerk-js,types): Remove paymentMethodId from subscription item - #7017
Merged
panteliselef merged 1 commit into
mainfrom 
elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js
Oct 17, 2025
Merged
chore(clerk-js,types): Remove paymentMethodId from subscription item#7017
panteliselef merged 1 commit into
mainfrom 
elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js
Conversation
@panteliselef
@panteliselefpanteliselef
commented
Oct 17, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Chores
    • Removed paymentMethodId field from billing subscription items as part of Billing Beta updates. Type definitions and test fixtures updated accordingly.
@panteliselefpanteliselef
self-assigned this
Oct 17, 2025
@changeset-bot
changeset-botBot
commented
Oct 17, 2025

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: ace9b39
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 22 packages
NameType
@clerk/clerk-jsMinor
@clerk/typesMinor
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Oct 17, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentOct 17, 2025 11:39am
@coderabbitai
coderabbitaiBot
commented
Oct 17, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
Removes the paymentMethodId field from billing subscription types and implementation across @clerk/clerk-js and @clerk/types packages. Updates test fixtures to match the field removal. Includes changelog entry documenting the changes.
Changes
Cohort / File(s)Summary
Type Definitions
packages/types/src/billing.ts, packages/types/src/json.ts		Removed paymentMethodId (TypeScript) and payment_method_id (JSON) fields from BillingSubscriptionItemResource and BillingSubscriptionItemJSON interfaces respectively.
Implementation
packages/clerk-js/src/core/resources/BillingSubscription.ts		Removed public paymentMethodId property from BillingSubscriptionItem class and eliminated assignment from fromJSON deserialization path.
Test Fixtures
packages/clerk-js/src/ui/components/PricingTable/__tests__/PricingTable.test.tsx, packages/clerk-js/src/ui/components/PricingTable/utils/pricing-footer-state.spec.ts, packages/clerk-js/src/ui/components/SubscriptionDetails/__tests__/SubscriptionDetails.test.tsx, packages/clerk-js/src/ui/components/Subscriptions/__tests__/SubscriptionsList.test.tsx		Removed paymentMethodId property from subscriptionItems mock fixtures across multiple test cases.
Changelog
.changeset/good-buckets-cry.md		Added changelog entry documenting minor version bumps for @clerk/clerk-js and @clerk/types with billing beta note on paymentMethodId removal.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~12 minutes
The changes are homogeneous and mechanical—consistent field removal across type definitions, implementation, and test fixtures with no complex logic alterations.
Poem
🐰 A payment method fades away,

The billing subscription's simpler today,

With paymentMethodId removed with grace,

Our types find a cleaner space! ✨
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe PR title "chore(clerk-js,types): Remove paymentMethodId from subscription item" directly and accurately reflects the primary change across the entire changeset. The raw summary consistently documents that the paymentMethodId property is being removed from BillingSubscriptionItem classes, type definitions, and related test fixtures across both the clerk-js and types packages. The title uses the conventional commit format appropriately, specifies the affected packages, and clearly conveys the main objective without vague language or unnecessary noise. A teammate scanning the pull request history would immediately understand that this change removes a payment method identifier field from subscription items.
Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  •  📝 Generate docstrings
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js
📜 Recent review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
  • Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📥 Commits
Reviewing files that changed from the base of the PR and between f4a444c and ace9b39.
📒 Files selected for processing (8)
  • .changeset/good-buckets-cry.md (1 hunks)
  • packages/clerk-js/src/core/resources/BillingSubscription.ts (0 hunks)
  • packages/clerk-js/src/ui/components/PricingTable/__tests__/PricingTable.test.tsx (0 hunks)
  • packages/clerk-js/src/ui/components/PricingTable/utils/pricing-footer-state.spec.ts (0 hunks)
  • packages/clerk-js/src/ui/components/SubscriptionDetails/__tests__/SubscriptionDetails.test.tsx (0 hunks)
  • packages/clerk-js/src/ui/components/Subscriptions/__tests__/SubscriptionsList.test.tsx (0 hunks)
  • packages/types/src/billing.ts (0 hunks)
  • packages/types/src/json.ts (0 hunks)
💤 Files with no reviewable changes (7)
  • packages/clerk-js/src/ui/components/PricingTable/tests/PricingTable.test.tsx
  • packages/types/src/billing.ts
  • packages/clerk-js/src/ui/components/Subscriptions/tests/SubscriptionsList.test.tsx
  • packages/clerk-js/src/ui/components/SubscriptionDetails/tests/SubscriptionDetails.test.tsx
  • packages/types/src/json.ts
  • packages/clerk-js/src/ui/components/PricingTable/utils/pricing-footer-state.spec.ts
  • packages/clerk-js/src/core/resources/BillingSubscription.ts
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Automated releases must use Changesets.
Files:
  • .changeset/good-buckets-cry.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Build Packages
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
.changeset/good-buckets-cry.md (1)
1-6: Changeset format and content look correct.
The changeset properly declares version bumps for both affected packages (@clerk/clerk-js and @clerk/types) and clearly documents the removal of paymentMethodId from the subscription item. The minor version bump is appropriate for field removal in a Beta API.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Oct 17, 2025

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7017

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7017

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7017

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7017

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7017

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7017

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@7017

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@7017

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7017

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7017

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7017

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7017

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7017

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7017

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@7017

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7017

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@7017

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7017

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7017

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7017

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@7017

@clerk/types
npm i https://pkg.pr.new/@clerk/types@7017

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7017

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7017

commit: ace9b39
@panteliselef
panteliselef
merged commit a172d51
into
mainOct 17, 2025

42 checks passed

@panteliselef
panteliselef
deleted the

elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js

branch
October 17, 2025 12:24
@clerk-cookieclerk-cookie
mentioned this pull request
Oct 17, 2025
 Merged

NicolasLopes7 pushed a commit
that referenced
this pull request
Oct 23, 2025
@panteliselef@NicolasLopes7
chore(clerk-js,types): Remove paymentMethodId from subscription item (
6a1e6e1
#7017)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@paddycarverpaddycarverAwaiting requested review from paddycarver
@mzhong9723mzhong9723Awaiting requested review from mzhong9723

1 more reviewer

@iagodahlemiagodahlemiagodahlem approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@panteliselefpanteliselef

Labels

clerk-jstypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@panteliselef@iagodahlem@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(clerk-js,types): Remove paymentMethodId from subscription item - #7017
Merged
panteliselef merged 1 commit into
mainfrom 
elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js
Oct 17, 2025
Merged
chore(clerk-js,types): Remove paymentMethodId from subscription item#7017
panteliselef merged 1 commit into
mainfrom 
elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js
Conversation
@panteliselef
@panteliselefpanteliselef
commented
Oct 17, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Chores
    • Removed paymentMethodId field from billing subscription items as part of Billing Beta updates. Type definitions and test fixtures updated accordingly.
@panteliselefpanteliselef
self-assigned this
Oct 17, 2025
@changeset-bot
changeset-botBot
commented
Oct 17, 2025

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: ace9b39
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 22 packages
NameType
@clerk/clerk-jsMinor
@clerk/typesMinor
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Oct 17, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentOct 17, 2025 11:39am
@coderabbitai
coderabbitaiBot
commented
Oct 17, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
Removes the paymentMethodId field from billing subscription types and implementation across @clerk/clerk-js and @clerk/types packages. Updates test fixtures to match the field removal. Includes changelog entry documenting the changes.
Changes
Cohort / File(s)Summary
Type Definitions
packages/types/src/billing.ts, packages/types/src/json.ts		Removed paymentMethodId (TypeScript) and payment_method_id (JSON) fields from BillingSubscriptionItemResource and BillingSubscriptionItemJSON interfaces respectively.
Implementation
packages/clerk-js/src/core/resources/BillingSubscription.ts		Removed public paymentMethodId property from BillingSubscriptionItem class and eliminated assignment from fromJSON deserialization path.
Test Fixtures
packages/clerk-js/src/ui/components/PricingTable/__tests__/PricingTable.test.tsx, packages/clerk-js/src/ui/components/PricingTable/utils/pricing-footer-state.spec.ts, packages/clerk-js/src/ui/components/SubscriptionDetails/__tests__/SubscriptionDetails.test.tsx, packages/clerk-js/src/ui/components/Subscriptions/__tests__/SubscriptionsList.test.tsx		Removed paymentMethodId property from subscriptionItems mock fixtures across multiple test cases.
Changelog
.changeset/good-buckets-cry.md		Added changelog entry documenting minor version bumps for @clerk/clerk-js and @clerk/types with billing beta note on paymentMethodId removal.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~12 minutes
The changes are homogeneous and mechanical—consistent field removal across type definitions, implementation, and test fixtures with no complex logic alterations.
Poem
🐰 A payment method fades away,

The billing subscription's simpler today,

With paymentMethodId removed with grace,

Our types find a cleaner space! ✨
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe PR title "chore(clerk-js,types): Remove paymentMethodId from subscription item" directly and accurately reflects the primary change across the entire changeset. The raw summary consistently documents that the paymentMethodId property is being removed from BillingSubscriptionItem classes, type definitions, and related test fixtures across both the clerk-js and types packages. The title uses the conventional commit format appropriately, specifies the affected packages, and clearly conveys the main objective without vague language or unnecessary noise. A teammate scanning the pull request history would immediately understand that this change removes a payment method identifier field from subscription items.
Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  •  📝 Generate docstrings
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js
📜 Recent review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
  • Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📥 Commits
Reviewing files that changed from the base of the PR and between f4a444c and ace9b39.
📒 Files selected for processing (8)
  • .changeset/good-buckets-cry.md (1 hunks)
  • packages/clerk-js/src/core/resources/BillingSubscription.ts (0 hunks)
  • packages/clerk-js/src/ui/components/PricingTable/__tests__/PricingTable.test.tsx (0 hunks)
  • packages/clerk-js/src/ui/components/PricingTable/utils/pricing-footer-state.spec.ts (0 hunks)
  • packages/clerk-js/src/ui/components/SubscriptionDetails/__tests__/SubscriptionDetails.test.tsx (0 hunks)
  • packages/clerk-js/src/ui/components/Subscriptions/__tests__/SubscriptionsList.test.tsx (0 hunks)
  • packages/types/src/billing.ts (0 hunks)
  • packages/types/src/json.ts (0 hunks)
💤 Files with no reviewable changes (7)
  • packages/clerk-js/src/ui/components/PricingTable/tests/PricingTable.test.tsx
  • packages/types/src/billing.ts
  • packages/clerk-js/src/ui/components/Subscriptions/tests/SubscriptionsList.test.tsx
  • packages/clerk-js/src/ui/components/SubscriptionDetails/tests/SubscriptionDetails.test.tsx
  • packages/types/src/json.ts
  • packages/clerk-js/src/ui/components/PricingTable/utils/pricing-footer-state.spec.ts
  • packages/clerk-js/src/core/resources/BillingSubscription.ts
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Automated releases must use Changesets.
Files:
  • .changeset/good-buckets-cry.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Build Packages
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
.changeset/good-buckets-cry.md (1)
1-6: Changeset format and content look correct.
The changeset properly declares version bumps for both affected packages (@clerk/clerk-js and @clerk/types) and clearly documents the removal of paymentMethodId from the subscription item. The minor version bump is appropriate for field removal in a Beta API.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Oct 17, 2025

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7017

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7017

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7017

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7017

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7017

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7017

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@7017

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@7017

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7017

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7017

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7017

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7017

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7017

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7017

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@7017

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7017

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@7017

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7017

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7017

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7017

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@7017

@clerk/types
npm i https://pkg.pr.new/@clerk/types@7017

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7017

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7017

commit: ace9b39
@panteliselef
panteliselef
merged commit a172d51
into
mainOct 17, 2025

42 checks passed

@panteliselef
panteliselef
deleted the

elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js

branch
October 17, 2025 12:24
@clerk-cookieclerk-cookie
mentioned this pull request
Oct 17, 2025
 Merged

NicolasLopes7 pushed a commit
that referenced
this pull request
Oct 23, 2025
@panteliselef@NicolasLopes7
chore(clerk-js,types): Remove paymentMethodId from subscription item (
6a1e6e1
#7017)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@paddycarverpaddycarverAwaiting requested review from paddycarver
@mzhong9723mzhong9723Awaiting requested review from mzhong9723

1 more reviewer

@iagodahlemiagodahlemiagodahlem approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@panteliselefpanteliselef

Labels

clerk-jstypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@panteliselef@iagodahlem@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(clerk-js,types): Remove paymentMethodId from subscription item - #7017
Merged
panteliselef merged 1 commit into
mainfrom 
elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js
Oct 17, 2025
Merged
chore(clerk-js,types): Remove paymentMethodId from subscription item#7017
panteliselef merged 1 commit into
mainfrom 
elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js
Conversation
@panteliselef
@panteliselefpanteliselef
commented
Oct 17, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Chores
    • Removed paymentMethodId field from billing subscription items as part of Billing Beta updates. Type definitions and test fixtures updated accordingly.
@panteliselefpanteliselef
self-assigned this
Oct 17, 2025
@changeset-bot
changeset-botBot
commented
Oct 17, 2025

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: ace9b39
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 22 packages
NameType
@clerk/clerk-jsMinor
@clerk/typesMinor
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Oct 17, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentOct 17, 2025 11:39am
@coderabbitai
coderabbitaiBot
commented
Oct 17, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
Removes the paymentMethodId field from billing subscription types and implementation across @clerk/clerk-js and @clerk/types packages. Updates test fixtures to match the field removal. Includes changelog entry documenting the changes.
Changes
Cohort / File(s)Summary
Type Definitions
packages/types/src/billing.ts, packages/types/src/json.ts		Removed paymentMethodId (TypeScript) and payment_method_id (JSON) fields from BillingSubscriptionItemResource and BillingSubscriptionItemJSON interfaces respectively.
Implementation
packages/clerk-js/src/core/resources/BillingSubscription.ts		Removed public paymentMethodId property from BillingSubscriptionItem class and eliminated assignment from fromJSON deserialization path.
Test Fixtures
packages/clerk-js/src/ui/components/PricingTable/__tests__/PricingTable.test.tsx, packages/clerk-js/src/ui/components/PricingTable/utils/pricing-footer-state.spec.ts, packages/clerk-js/src/ui/components/SubscriptionDetails/__tests__/SubscriptionDetails.test.tsx, packages/clerk-js/src/ui/components/Subscriptions/__tests__/SubscriptionsList.test.tsx		Removed paymentMethodId property from subscriptionItems mock fixtures across multiple test cases.
Changelog
.changeset/good-buckets-cry.md		Added changelog entry documenting minor version bumps for @clerk/clerk-js and @clerk/types with billing beta note on paymentMethodId removal.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~12 minutes
The changes are homogeneous and mechanical—consistent field removal across type definitions, implementation, and test fixtures with no complex logic alterations.
Poem
🐰 A payment method fades away,

The billing subscription's simpler today,

With paymentMethodId removed with grace,

Our types find a cleaner space! ✨
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe PR title "chore(clerk-js,types): Remove paymentMethodId from subscription item" directly and accurately reflects the primary change across the entire changeset. The raw summary consistently documents that the paymentMethodId property is being removed from BillingSubscriptionItem classes, type definitions, and related test fixtures across both the clerk-js and types packages. The title uses the conventional commit format appropriately, specifies the affected packages, and clearly conveys the main objective without vague language or unnecessary noise. A teammate scanning the pull request history would immediately understand that this change removes a payment method identifier field from subscription items.
Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  •  📝 Generate docstrings
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js
📜 Recent review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
  • Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📥 Commits
Reviewing files that changed from the base of the PR and between f4a444c and ace9b39.
📒 Files selected for processing (8)
  • .changeset/good-buckets-cry.md (1 hunks)
  • packages/clerk-js/src/core/resources/BillingSubscription.ts (0 hunks)
  • packages/clerk-js/src/ui/components/PricingTable/__tests__/PricingTable.test.tsx (0 hunks)
  • packages/clerk-js/src/ui/components/PricingTable/utils/pricing-footer-state.spec.ts (0 hunks)
  • packages/clerk-js/src/ui/components/SubscriptionDetails/__tests__/SubscriptionDetails.test.tsx (0 hunks)
  • packages/clerk-js/src/ui/components/Subscriptions/__tests__/SubscriptionsList.test.tsx (0 hunks)
  • packages/types/src/billing.ts (0 hunks)
  • packages/types/src/json.ts (0 hunks)
💤 Files with no reviewable changes (7)
  • packages/clerk-js/src/ui/components/PricingTable/tests/PricingTable.test.tsx
  • packages/types/src/billing.ts
  • packages/clerk-js/src/ui/components/Subscriptions/tests/SubscriptionsList.test.tsx
  • packages/clerk-js/src/ui/components/SubscriptionDetails/tests/SubscriptionDetails.test.tsx
  • packages/types/src/json.ts
  • packages/clerk-js/src/ui/components/PricingTable/utils/pricing-footer-state.spec.ts
  • packages/clerk-js/src/core/resources/BillingSubscription.ts
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Automated releases must use Changesets.
Files:
  • .changeset/good-buckets-cry.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Build Packages
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
.changeset/good-buckets-cry.md (1)
1-6: Changeset format and content look correct.
The changeset properly declares version bumps for both affected packages (@clerk/clerk-js and @clerk/types) and clearly documents the removal of paymentMethodId from the subscription item. The minor version bump is appropriate for field removal in a Beta API.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Oct 17, 2025

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7017

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7017

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7017

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7017

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7017

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7017

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@7017

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@7017

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7017

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7017

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7017

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7017

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7017

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7017

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@7017

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7017

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@7017

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7017

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7017

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7017

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@7017

@clerk/types
npm i https://pkg.pr.new/@clerk/types@7017

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7017

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7017

commit: ace9b39
@panteliselef
panteliselef
merged commit a172d51
into
mainOct 17, 2025

42 checks passed

@panteliselef
panteliselef
deleted the

elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js

branch
October 17, 2025 12:24
@clerk-cookieclerk-cookie
mentioned this pull request
Oct 17, 2025
 Merged

NicolasLopes7 pushed a commit
that referenced
this pull request
Oct 23, 2025
@panteliselef@NicolasLopes7
chore(clerk-js,types): Remove paymentMethodId from subscription item (
6a1e6e1
#7017)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@paddycarverpaddycarverAwaiting requested review from paddycarver
@mzhong9723mzhong9723Awaiting requested review from mzhong9723

1 more reviewer

@iagodahlemiagodahlemiagodahlem approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@panteliselefpanteliselef

Labels

clerk-jstypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@panteliselef@iagodahlem@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
chore(clerk-js,types): Remove paymentMethodId from subscription item - #7017
Merged
panteliselef merged 1 commit into
mainfrom 
elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js
Oct 17, 2025
Merged
chore(clerk-js,types): Remove paymentMethodId from subscription item#7017
panteliselef merged 1 commit into
mainfrom 
elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js
Conversation
@panteliselef
@panteliselefpanteliselef
commented
Oct 17, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Chores
    • Removed paymentMethodId field from billing subscription items as part of Billing Beta updates. Type definitions and test fixtures updated accordingly.
@panteliselefpanteliselef
self-assigned this
Oct 17, 2025
@changeset-bot
changeset-botBot
commented
Oct 17, 2025

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: ace9b39
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 22 packages
NameType
@clerk/clerk-jsMinor
@clerk/typesMinor
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Oct 17, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentOct 17, 2025 11:39am
@coderabbitai
coderabbitaiBot
commented
Oct 17, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
Removes the paymentMethodId field from billing subscription types and implementation across @clerk/clerk-js and @clerk/types packages. Updates test fixtures to match the field removal. Includes changelog entry documenting the changes.
Changes
Cohort / File(s)Summary
Type Definitions
packages/types/src/billing.ts, packages/types/src/json.ts		Removed paymentMethodId (TypeScript) and payment_method_id (JSON) fields from BillingSubscriptionItemResource and BillingSubscriptionItemJSON interfaces respectively.
Implementation
packages/clerk-js/src/core/resources/BillingSubscription.ts		Removed public paymentMethodId property from BillingSubscriptionItem class and eliminated assignment from fromJSON deserialization path.
Test Fixtures
packages/clerk-js/src/ui/components/PricingTable/__tests__/PricingTable.test.tsx, packages/clerk-js/src/ui/components/PricingTable/utils/pricing-footer-state.spec.ts, packages/clerk-js/src/ui/components/SubscriptionDetails/__tests__/SubscriptionDetails.test.tsx, packages/clerk-js/src/ui/components/Subscriptions/__tests__/SubscriptionsList.test.tsx		Removed paymentMethodId property from subscriptionItems mock fixtures across multiple test cases.
Changelog
.changeset/good-buckets-cry.md		Added changelog entry documenting minor version bumps for @clerk/clerk-js and @clerk/types with billing beta note on paymentMethodId removal.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~12 minutes
The changes are homogeneous and mechanical—consistent field removal across type definitions, implementation, and test fixtures with no complex logic alterations.
Poem
🐰 A payment method fades away,

The billing subscription's simpler today,

With paymentMethodId removed with grace,

Our types find a cleaner space! ✨
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe PR title "chore(clerk-js,types): Remove paymentMethodId from subscription item" directly and accurately reflects the primary change across the entire changeset. The raw summary consistently documents that the paymentMethodId property is being removed from BillingSubscriptionItem classes, type definitions, and related test fixtures across both the clerk-js and types packages. The title uses the conventional commit format appropriately, specifies the affected packages, and clearly conveys the main objective without vague language or unnecessary noise. A teammate scanning the pull request history would immediately understand that this change removes a payment method identifier field from subscription items.
Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  •  📝 Generate docstrings
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js
📜 Recent review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
  • Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📥 Commits
Reviewing files that changed from the base of the PR and between f4a444c and ace9b39.
📒 Files selected for processing (8)
  • .changeset/good-buckets-cry.md (1 hunks)
  • packages/clerk-js/src/core/resources/BillingSubscription.ts (0 hunks)
  • packages/clerk-js/src/ui/components/PricingTable/__tests__/PricingTable.test.tsx (0 hunks)
  • packages/clerk-js/src/ui/components/PricingTable/utils/pricing-footer-state.spec.ts (0 hunks)
  • packages/clerk-js/src/ui/components/SubscriptionDetails/__tests__/SubscriptionDetails.test.tsx (0 hunks)
  • packages/clerk-js/src/ui/components/Subscriptions/__tests__/SubscriptionsList.test.tsx (0 hunks)
  • packages/types/src/billing.ts (0 hunks)
  • packages/types/src/json.ts (0 hunks)
💤 Files with no reviewable changes (7)
  • packages/clerk-js/src/ui/components/PricingTable/tests/PricingTable.test.tsx
  • packages/types/src/billing.ts
  • packages/clerk-js/src/ui/components/Subscriptions/tests/SubscriptionsList.test.tsx
  • packages/clerk-js/src/ui/components/SubscriptionDetails/tests/SubscriptionDetails.test.tsx
  • packages/types/src/json.ts
  • packages/clerk-js/src/ui/components/PricingTable/utils/pricing-footer-state.spec.ts
  • packages/clerk-js/src/core/resources/BillingSubscription.ts
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Automated releases must use Changesets.
Files:
  • .changeset/good-buckets-cry.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Build Packages
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
.changeset/good-buckets-cry.md (1)
1-6: Changeset format and content look correct.
The changeset properly declares version bumps for both affected packages (@clerk/clerk-js and @clerk/types) and clearly documents the removal of paymentMethodId from the subscription item. The minor version bump is appropriate for field removal in a Beta API.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Oct 17, 2025

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7017

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7017

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7017

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7017

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7017

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7017

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@7017

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@7017

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7017

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7017

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7017

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7017

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7017

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7017

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@7017

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7017

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@7017

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7017

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7017

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7017

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@7017

@clerk/types
npm i https://pkg.pr.new/@clerk/types@7017

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7017

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7017

commit: ace9b39
@panteliselef
panteliselef
merged commit a172d51
into
mainOct 17, 2025

42 checks passed

@panteliselef
panteliselef
deleted the

elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js

branch
October 17, 2025 12:24
@clerk-cookieclerk-cookie
mentioned this pull request
Oct 17, 2025
 Merged

NicolasLopes7 pushed a commit
that referenced
this pull request
Oct 23, 2025
@panteliselef@NicolasLopes7
chore(clerk-js,types): Remove paymentMethodId from subscription item (
6a1e6e1
#7017)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@paddycarverpaddycarverAwaiting requested review from paddycarver
@mzhong9723mzhong9723Awaiting requested review from mzhong9723

1 more reviewer

@iagodahlemiagodahlemiagodahlem approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@panteliselefpanteliselef

Labels

clerk-jstypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@panteliselef@iagodahlem@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(clerk-js,types): Remove paymentMethodId from subscription item - #7017
Merged
panteliselef merged 1 commit into
mainfrom 
elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js
Oct 17, 2025
Merged
chore(clerk-js,types): Remove paymentMethodId from subscription item#7017
panteliselef merged 1 commit into
mainfrom 
elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js
Conversation
@panteliselef
@panteliselefpanteliselef
commented
Oct 17, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Chores
    • Removed paymentMethodId field from billing subscription items as part of Billing Beta updates. Type definitions and test fixtures updated accordingly.
@panteliselefpanteliselef
self-assigned this
Oct 17, 2025
@changeset-bot
changeset-botBot
commented
Oct 17, 2025

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: ace9b39
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 22 packages
NameType
@clerk/clerk-jsMinor
@clerk/typesMinor
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Oct 17, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentOct 17, 2025 11:39am
@coderabbitai
coderabbitaiBot
commented
Oct 17, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
Removes the paymentMethodId field from billing subscription types and implementation across @clerk/clerk-js and @clerk/types packages. Updates test fixtures to match the field removal. Includes changelog entry documenting the changes.
Changes
Cohort / File(s)Summary
Type Definitions
packages/types/src/billing.ts, packages/types/src/json.ts		Removed paymentMethodId (TypeScript) and payment_method_id (JSON) fields from BillingSubscriptionItemResource and BillingSubscriptionItemJSON interfaces respectively.
Implementation
packages/clerk-js/src/core/resources/BillingSubscription.ts		Removed public paymentMethodId property from BillingSubscriptionItem class and eliminated assignment from fromJSON deserialization path.
Test Fixtures
packages/clerk-js/src/ui/components/PricingTable/__tests__/PricingTable.test.tsx, packages/clerk-js/src/ui/components/PricingTable/utils/pricing-footer-state.spec.ts, packages/clerk-js/src/ui/components/SubscriptionDetails/__tests__/SubscriptionDetails.test.tsx, packages/clerk-js/src/ui/components/Subscriptions/__tests__/SubscriptionsList.test.tsx		Removed paymentMethodId property from subscriptionItems mock fixtures across multiple test cases.
Changelog
.changeset/good-buckets-cry.md		Added changelog entry documenting minor version bumps for @clerk/clerk-js and @clerk/types with billing beta note on paymentMethodId removal.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~12 minutes
The changes are homogeneous and mechanical—consistent field removal across type definitions, implementation, and test fixtures with no complex logic alterations.
Poem
🐰 A payment method fades away,

The billing subscription's simpler today,

With paymentMethodId removed with grace,

Our types find a cleaner space! ✨
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe PR title "chore(clerk-js,types): Remove paymentMethodId from subscription item" directly and accurately reflects the primary change across the entire changeset. The raw summary consistently documents that the paymentMethodId property is being removed from BillingSubscriptionItem classes, type definitions, and related test fixtures across both the clerk-js and types packages. The title uses the conventional commit format appropriately, specifies the affected packages, and clearly conveys the main objective without vague language or unnecessary noise. A teammate scanning the pull request history would immediately understand that this change removes a payment method identifier field from subscription items.
Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  •  📝 Generate docstrings
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js
📜 Recent review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
  • Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📥 Commits
Reviewing files that changed from the base of the PR and between f4a444c and ace9b39.
📒 Files selected for processing (8)
  • .changeset/good-buckets-cry.md (1 hunks)
  • packages/clerk-js/src/core/resources/BillingSubscription.ts (0 hunks)
  • packages/clerk-js/src/ui/components/PricingTable/__tests__/PricingTable.test.tsx (0 hunks)
  • packages/clerk-js/src/ui/components/PricingTable/utils/pricing-footer-state.spec.ts (0 hunks)
  • packages/clerk-js/src/ui/components/SubscriptionDetails/__tests__/SubscriptionDetails.test.tsx (0 hunks)
  • packages/clerk-js/src/ui/components/Subscriptions/__tests__/SubscriptionsList.test.tsx (0 hunks)
  • packages/types/src/billing.ts (0 hunks)
  • packages/types/src/json.ts (0 hunks)
💤 Files with no reviewable changes (7)
  • packages/clerk-js/src/ui/components/PricingTable/tests/PricingTable.test.tsx
  • packages/types/src/billing.ts
  • packages/clerk-js/src/ui/components/Subscriptions/tests/SubscriptionsList.test.tsx
  • packages/clerk-js/src/ui/components/SubscriptionDetails/tests/SubscriptionDetails.test.tsx
  • packages/types/src/json.ts
  • packages/clerk-js/src/ui/components/PricingTable/utils/pricing-footer-state.spec.ts
  • packages/clerk-js/src/core/resources/BillingSubscription.ts
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Automated releases must use Changesets.
Files:
  • .changeset/good-buckets-cry.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Build Packages
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
.changeset/good-buckets-cry.md (1)
1-6: Changeset format and content look correct.
The changeset properly declares version bumps for both affected packages (@clerk/clerk-js and @clerk/types) and clearly documents the removal of paymentMethodId from the subscription item. The minor version bump is appropriate for field removal in a Beta API.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Oct 17, 2025

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7017

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7017

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7017

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7017

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7017

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7017

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@7017

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@7017

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7017

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7017

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7017

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7017

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7017

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7017

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@7017

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7017

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@7017

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7017

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7017

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7017

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@7017

@clerk/types
npm i https://pkg.pr.new/@clerk/types@7017

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7017

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7017

commit: ace9b39
@panteliselef
panteliselef
merged commit a172d51
into
mainOct 17, 2025

42 checks passed

@panteliselef
panteliselef
deleted the

elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js

branch
October 17, 2025 12:24
@clerk-cookieclerk-cookie
mentioned this pull request
Oct 17, 2025
 Merged

NicolasLopes7 pushed a commit
that referenced
this pull request
Oct 23, 2025
@panteliselef@NicolasLopes7
chore(clerk-js,types): Remove paymentMethodId from subscription item (
6a1e6e1
#7017)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@paddycarverpaddycarverAwaiting requested review from paddycarver
@mzhong9723mzhong9723Awaiting requested review from mzhong9723

1 more reviewer

@iagodahlemiagodahlemiagodahlem approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@panteliselefpanteliselef

Labels

clerk-jstypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@panteliselef@iagodahlem@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(clerk-js,types): Remove paymentMethodId from subscription item - #7017
Merged
panteliselef merged 1 commit into
mainfrom 
elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js
Oct 17, 2025
Merged
chore(clerk-js,types): Remove paymentMethodId from subscription item#7017
panteliselef merged 1 commit into
mainfrom 
elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js
Conversation
@panteliselef
@panteliselefpanteliselef
commented
Oct 17, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Chores
    • Removed paymentMethodId field from billing subscription items as part of Billing Beta updates. Type definitions and test fixtures updated accordingly.
@panteliselefpanteliselef
self-assigned this
Oct 17, 2025
@changeset-bot
changeset-botBot
commented
Oct 17, 2025

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: ace9b39
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 22 packages
NameType
@clerk/clerk-jsMinor
@clerk/typesMinor
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Oct 17, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentOct 17, 2025 11:39am
@coderabbitai
coderabbitaiBot
commented
Oct 17, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
Removes the paymentMethodId field from billing subscription types and implementation across @clerk/clerk-js and @clerk/types packages. Updates test fixtures to match the field removal. Includes changelog entry documenting the changes.
Changes
Cohort / File(s)Summary
Type Definitions
packages/types/src/billing.ts, packages/types/src/json.ts		Removed paymentMethodId (TypeScript) and payment_method_id (JSON) fields from BillingSubscriptionItemResource and BillingSubscriptionItemJSON interfaces respectively.
Implementation
packages/clerk-js/src/core/resources/BillingSubscription.ts		Removed public paymentMethodId property from BillingSubscriptionItem class and eliminated assignment from fromJSON deserialization path.
Test Fixtures
packages/clerk-js/src/ui/components/PricingTable/__tests__/PricingTable.test.tsx, packages/clerk-js/src/ui/components/PricingTable/utils/pricing-footer-state.spec.ts, packages/clerk-js/src/ui/components/SubscriptionDetails/__tests__/SubscriptionDetails.test.tsx, packages/clerk-js/src/ui/components/Subscriptions/__tests__/SubscriptionsList.test.tsx		Removed paymentMethodId property from subscriptionItems mock fixtures across multiple test cases.
Changelog
.changeset/good-buckets-cry.md		Added changelog entry documenting minor version bumps for @clerk/clerk-js and @clerk/types with billing beta note on paymentMethodId removal.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~12 minutes
The changes are homogeneous and mechanical—consistent field removal across type definitions, implementation, and test fixtures with no complex logic alterations.
Poem
🐰 A payment method fades away,

The billing subscription's simpler today,

With paymentMethodId removed with grace,

Our types find a cleaner space! ✨
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe PR title "chore(clerk-js,types): Remove paymentMethodId from subscription item" directly and accurately reflects the primary change across the entire changeset. The raw summary consistently documents that the paymentMethodId property is being removed from BillingSubscriptionItem classes, type definitions, and related test fixtures across both the clerk-js and types packages. The title uses the conventional commit format appropriately, specifies the affected packages, and clearly conveys the main objective without vague language or unnecessary noise. A teammate scanning the pull request history would immediately understand that this change removes a payment method identifier field from subscription items.
Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  •  📝 Generate docstrings
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js
📜 Recent review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
  • Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📥 Commits
Reviewing files that changed from the base of the PR and between f4a444c and ace9b39.
📒 Files selected for processing (8)
  • .changeset/good-buckets-cry.md (1 hunks)
  • packages/clerk-js/src/core/resources/BillingSubscription.ts (0 hunks)
  • packages/clerk-js/src/ui/components/PricingTable/__tests__/PricingTable.test.tsx (0 hunks)
  • packages/clerk-js/src/ui/components/PricingTable/utils/pricing-footer-state.spec.ts (0 hunks)
  • packages/clerk-js/src/ui/components/SubscriptionDetails/__tests__/SubscriptionDetails.test.tsx (0 hunks)
  • packages/clerk-js/src/ui/components/Subscriptions/__tests__/SubscriptionsList.test.tsx (0 hunks)
  • packages/types/src/billing.ts (0 hunks)
  • packages/types/src/json.ts (0 hunks)
💤 Files with no reviewable changes (7)
  • packages/clerk-js/src/ui/components/PricingTable/tests/PricingTable.test.tsx
  • packages/types/src/billing.ts
  • packages/clerk-js/src/ui/components/Subscriptions/tests/SubscriptionsList.test.tsx
  • packages/clerk-js/src/ui/components/SubscriptionDetails/tests/SubscriptionDetails.test.tsx
  • packages/types/src/json.ts
  • packages/clerk-js/src/ui/components/PricingTable/utils/pricing-footer-state.spec.ts
  • packages/clerk-js/src/core/resources/BillingSubscription.ts
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Automated releases must use Changesets.
Files:
  • .changeset/good-buckets-cry.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Build Packages
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
.changeset/good-buckets-cry.md (1)
1-6: Changeset format and content look correct.
The changeset properly declares version bumps for both affected packages (@clerk/clerk-js and @clerk/types) and clearly documents the removal of paymentMethodId from the subscription item. The minor version bump is appropriate for field removal in a Beta API.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Oct 17, 2025

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7017

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7017

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7017

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7017

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7017

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7017

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@7017

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@7017

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7017

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7017

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7017

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7017

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7017

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7017

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@7017

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7017

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@7017

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7017

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7017

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7017

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@7017

@clerk/types
npm i https://pkg.pr.new/@clerk/types@7017

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7017

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7017

commit: ace9b39
@panteliselef
panteliselef
merged commit a172d51
into
mainOct 17, 2025

42 checks passed

@panteliselef
panteliselef
deleted the

elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js

branch
October 17, 2025 12:24
@clerk-cookieclerk-cookie
mentioned this pull request
Oct 17, 2025
 Merged

NicolasLopes7 pushed a commit
that referenced
this pull request
Oct 23, 2025
@panteliselef@NicolasLopes7
chore(clerk-js,types): Remove paymentMethodId from subscription item (
6a1e6e1
#7017)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@paddycarverpaddycarverAwaiting requested review from paddycarver
@mzhong9723mzhong9723Awaiting requested review from mzhong9723

1 more reviewer

@iagodahlemiagodahlemiagodahlem approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@panteliselefpanteliselef

Labels

clerk-jstypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@panteliselef@iagodahlem@clerk-cookie

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
chore(clerk-js,types): Remove paymentMethodId from subscription item - #7017
Merged
panteliselef merged 1 commit into
mainfrom 
elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js
Oct 17, 2025
Merged
chore(clerk-js,types): Remove paymentMethodId from subscription item#7017
panteliselef merged 1 commit into
mainfrom 
elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js
Conversation
@panteliselef
@panteliselefpanteliselef
commented
Oct 17, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Chores
    • Removed paymentMethodId field from billing subscription items as part of Billing Beta updates. Type definitions and test fixtures updated accordingly.
@panteliselefpanteliselef
self-assigned this
Oct 17, 2025
@changeset-bot
changeset-botBot
commented
Oct 17, 2025

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: ace9b39
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 22 packages
NameType
@clerk/clerk-jsMinor
@clerk/typesMinor
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/elementsPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/localizationsPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/clerk-reactPatch
@clerk/remixPatch
@clerk/sharedPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/themesPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Oct 17, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentOct 17, 2025 11:39am
@coderabbitai
coderabbitaiBot
commented
Oct 17, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
Removes the paymentMethodId field from billing subscription types and implementation across @clerk/clerk-js and @clerk/types packages. Updates test fixtures to match the field removal. Includes changelog entry documenting the changes.
Changes
Cohort / File(s)Summary
Type Definitions
packages/types/src/billing.ts, packages/types/src/json.ts		Removed paymentMethodId (TypeScript) and payment_method_id (JSON) fields from BillingSubscriptionItemResource and BillingSubscriptionItemJSON interfaces respectively.
Implementation
packages/clerk-js/src/core/resources/BillingSubscription.ts		Removed public paymentMethodId property from BillingSubscriptionItem class and eliminated assignment from fromJSON deserialization path.
Test Fixtures
packages/clerk-js/src/ui/components/PricingTable/__tests__/PricingTable.test.tsx, packages/clerk-js/src/ui/components/PricingTable/utils/pricing-footer-state.spec.ts, packages/clerk-js/src/ui/components/SubscriptionDetails/__tests__/SubscriptionDetails.test.tsx, packages/clerk-js/src/ui/components/Subscriptions/__tests__/SubscriptionsList.test.tsx		Removed paymentMethodId property from subscriptionItems mock fixtures across multiple test cases.
Changelog
.changeset/good-buckets-cry.md		Added changelog entry documenting minor version bumps for @clerk/clerk-js and @clerk/types with billing beta note on paymentMethodId removal.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~12 minutes
The changes are homogeneous and mechanical—consistent field removal across type definitions, implementation, and test fixtures with no complex logic alterations.
Poem
🐰 A payment method fades away,

The billing subscription's simpler today,

With paymentMethodId removed with grace,

Our types find a cleaner space! ✨
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe PR title "chore(clerk-js,types): Remove paymentMethodId from subscription item" directly and accurately reflects the primary change across the entire changeset. The raw summary consistently documents that the paymentMethodId property is being removed from BillingSubscriptionItem classes, type definitions, and related test fixtures across both the clerk-js and types packages. The title uses the conventional commit format appropriately, specifies the affected packages, and clearly conveys the main objective without vague language or unnecessary noise. A teammate scanning the pull request history would immediately understand that this change removes a payment method identifier field from subscription items.
Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  •  📝 Generate docstrings
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js
📜 Recent review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
  • Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📥 Commits
Reviewing files that changed from the base of the PR and between f4a444c and ace9b39.
📒 Files selected for processing (8)
  • .changeset/good-buckets-cry.md (1 hunks)
  • packages/clerk-js/src/core/resources/BillingSubscription.ts (0 hunks)
  • packages/clerk-js/src/ui/components/PricingTable/__tests__/PricingTable.test.tsx (0 hunks)
  • packages/clerk-js/src/ui/components/PricingTable/utils/pricing-footer-state.spec.ts (0 hunks)
  • packages/clerk-js/src/ui/components/SubscriptionDetails/__tests__/SubscriptionDetails.test.tsx (0 hunks)
  • packages/clerk-js/src/ui/components/Subscriptions/__tests__/SubscriptionsList.test.tsx (0 hunks)
  • packages/types/src/billing.ts (0 hunks)
  • packages/types/src/json.ts (0 hunks)
💤 Files with no reviewable changes (7)
  • packages/clerk-js/src/ui/components/PricingTable/tests/PricingTable.test.tsx
  • packages/types/src/billing.ts
  • packages/clerk-js/src/ui/components/Subscriptions/tests/SubscriptionsList.test.tsx
  • packages/clerk-js/src/ui/components/SubscriptionDetails/tests/SubscriptionDetails.test.tsx
  • packages/types/src/json.ts
  • packages/clerk-js/src/ui/components/PricingTable/utils/pricing-footer-state.spec.ts
  • packages/clerk-js/src/core/resources/BillingSubscription.ts
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Automated releases must use Changesets.
Files:
  • .changeset/good-buckets-cry.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Build Packages
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
.changeset/good-buckets-cry.md (1)
1-6: Changeset format and content look correct.
The changeset properly declares version bumps for both affected packages (@clerk/clerk-js and @clerk/types) and clearly documents the removal of paymentMethodId from the subscription item. The minor version bump is appropriate for field removal in a Beta API.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Oct 17, 2025

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7017

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7017

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7017

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7017

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7017

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7017

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@7017

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@7017

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7017

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7017

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7017

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7017

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7017

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7017

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@7017

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7017

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@7017

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7017

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7017

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7017

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@7017

@clerk/types
npm i https://pkg.pr.new/@clerk/types@7017

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7017

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7017

commit: ace9b39
@panteliselef
panteliselef
merged commit a172d51
into
mainOct 17, 2025

42 checks passed

@panteliselef
panteliselef
deleted the

elef/bill-1354-remove-subscriptionitempaymentmethodid-from-clerk-js

branch
October 17, 2025 12:24
@clerk-cookieclerk-cookie
mentioned this pull request
Oct 17, 2025
 Merged

NicolasLopes7 pushed a commit
that referenced
this pull request
Oct 23, 2025
@panteliselef@NicolasLopes7
chore(clerk-js,types): Remove paymentMethodId from subscription item (
6a1e6e1
#7017)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@paddycarverpaddycarverAwaiting requested review from paddycarver
@mzhong9723mzhong9723Awaiting requested review from mzhong9723

1 more reviewer

@iagodahlemiagodahlemiagodahlem approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@panteliselefpanteliselef

Labels

clerk-jstypes

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@panteliselef@iagodahlem@clerk-cookie