5 changes: 5 additions & 0 deletions .changeset/plenty-dolls-pick.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': minor
---

Centralize redirect concerns for SignIn
Comment thread
jacekradko marked this conversation as resolved.
12 changes: 11 additions & 1 deletion integration/templates/next-app-router/next.config.js
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,19 @@
const path = require('path');

/** @type {import('next').NextConfig} */
const nextConfig = {
eslint: {
ignoreDuringBuilds: true,
},
outputFileTracingRoot: '/',
outputFileTracingRoot: path.resolve(__dirname, '../../../'),
webpack: config => {
// Exclude macOS .Trash directory and other system directories to prevent permission errors
config.watchOptions = {
...config.watchOptions,
ignored: ['**/.Trash/**', '**/node_modules/**', '**/.git/**'],
};
return config;
},
};

module.exports = nextConfig;
5 changes: 5 additions & 0 deletions integration/tests/session-tasks-multi-session.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -61,6 +61,11 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withSessionTasks] })(
// Create second user, to initiate a pending session
// Don't resolve task and switch to active session afterwards
await u.po.signIn.goTo();
await u.page.waitForURL(/sign-in\/choose/);
await u.page.getByText('Add account').click();
await u.page.waitForURL(/sign-in$/);
await u.po.signIn.waitForMounted();
await u.po.signIn.getIdentifierInput().waitFor({ state: 'visible' });
await u.po.signIn.setIdentifier(user2.email);
await u.po.signIn.continue();
await u.po.signIn.setPassword(user2.password);
Expand Down
79 changes: 79 additions & 0 deletions integration/tests/sign-in-single-session-mode.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
import type { FakeUser } from '@clerk/testing/playwright';
import { test } from '@playwright/test';

import type { Application } from '../models/application';
import { appConfigs } from '../presets';
import { createTestUtils, testAgainstRunningApps } from '../testUtils';

/**
* Tests for single-session mode behavior using the withBilling environment
* which is configured for single-session mode in the Clerk Dashboard.
*/
testAgainstRunningApps({ withEnv: [appConfigs.envs.withBilling] })(
'sign in with active session in single-session mode @generic @nextjs',
({ app }) => {
test.describe.configure({ mode: 'serial' });

let fakeUser: FakeUser;

test.beforeAll(async () => {
const u = createTestUtils({ app });
fakeUser = u.services.users.createFakeUser({
withPhoneNumber: true,
withUsername: true,
});
await u.services.users.createBapiUser(fakeUser);
});

test.afterAll(async () => {
await fakeUser.deleteIfExists();
});

test('redirects to afterSignIn URL when visiting /sign-in with active session in single-session mode', async ({
page,
context,
}) => {
const u = createTestUtils({ app, page, context });

await u.po.signIn.goTo();
await u.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
await u.po.expect.toBeSignedIn();
await u.page.waitForAppUrl('/');

await u.po.signIn.goTo();
await u.page.waitForAppUrl('/');
await u.po.expect.toBeSignedIn();
});

test('does NOT show account switcher in single-session mode', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.po.signIn.goTo();
await u.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
await u.po.expect.toBeSignedIn();

await u.page.goToRelative('/sign-in/choose');
await u.page.waitForAppUrl('/');
});

test('shows sign-in form when no active session in single-session mode', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.page.context().clearCookies();
await u.po.signIn.goTo();
await u.po.signIn.waitForMounted();
await u.page.waitForSelector('text=/email address|username|phone/i');
await u.page.waitForURL(/sign-in$/);
});

test('can sign in normally when not already authenticated in single-session mode', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.page.context().clearCookies();
await u.po.signIn.goTo();
await u.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
await u.po.expect.toBeSignedIn();
await u.page.waitForAppUrl('/');
});
},
);
44 changes: 20 additions & 24 deletions packages/ui/src/components/SignIn/SignInStart.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,31 +11,20 @@ import type {
SignInResource,
} from '@clerk/shared/types';
import { isWebAuthnAutofillSupported, isWebAuthnSupported } from '@clerk/shared/webauthn';
import { useEffect, useLayoutEffect, useMemo, useRef, useState } from 'react';

import { Card } from '@/ui/elements/Card';
import { useCardState, withCardStateProvider } from '@/ui/elements/contexts';
import { Form } from '@/ui/elements/Form';
import { Header } from '@/ui/elements/Header';
import { LoadingCard } from '@/ui/elements/LoadingCard';
import { SocialButtonsReversibleContainerWithDivider } from '@/ui/elements/ReversibleContainer';
import { handleError } from '@/ui/utils/errorHandler';
import { isMobileDevice } from '@/ui/utils/isMobileDevice';
import type { FormControlState } from '@/ui/utils/useFormControl';
import { buildRequest, useFormControl } from '@/ui/utils/useFormControl';
import React, { useEffect, useLayoutEffect, useMemo, useRef, useState } from 'react';

import type { SignInStartIdentifier } from '../../common';
import {
buildSSOCallbackURL,
getIdentifierControlDisplayValues,
groupIdentifiers,
withRedirectToAfterSignIn,
withRedirectToSignInTask,
} from '../../common';
import { buildSSOCallbackURL, getIdentifierControlDisplayValues, groupIdentifiers } from '../../common';
import { useCoreSignIn, useEnvironment, useSignInContext } from '../../contexts';
import { Col, descriptors, Flow, localizationKeys } from '../../customizables';
import { CaptchaElement } from '../../elements/CaptchaElement';
import { useLoadingStatus } from '../../hooks';
import { Card } from '../../elements/Card';
import { useCardState, withCardStateProvider } from '../../elements/contexts';
import { Form } from '../../elements/Form';
import { Header } from '../../elements/Header';
import { LoadingCard } from '../../elements/LoadingCard';
import { SocialButtonsReversibleContainerWithDivider } from '../../elements/ReversibleContainer';
import { useLoadingStatus, useSignInRedirect } from '../../hooks';
import { useSupportEmail } from '../../hooks/useSupportEmail';
import { useTotalEnabledAuthMethods } from '../../hooks/useTotalEnabledAuthMethods';
import { useRouter } from '../../router';
Expand All@@ -48,6 +37,10 @@ import {
getPreferredAlternativePhoneChannelForCombinedFlow,
getSignUpAttributeFromIdentifier,
} from './utils';
import { handleError } from '@/ui/utils/errorHandler';
import { isMobileDevice } from '@/ui/utils/isMobileDevice';
import type { FormControlState } from '@/ui/utils/useFormControl';
import { buildRequest, useFormControl } from '@/ui/utils/useFormControl';

const useAutoFillPasskey = () => {
const [isSupported, setIsSupported] = useState(false);
Expand DownExpand Up@@ -523,7 +516,12 @@ function SignInStartInternal(): JSX.Element {
return components[identifierField.type as keyof typeof components];
}, [identifierField.type]);

if (status.isLoading || clerkStatus === 'sign_up') {
const { isRedirecting } = useSignInRedirect({
afterSignInUrl,
organizationTicket,
});

if (isRedirecting || status.isLoading || clerkStatus === 'sign_up') {
// clerkStatus being sign_up will trigger a navigation to the sign up flow, so show a loading card instead of
// rendering the sign in flow.
return <LoadingCard />;
Expand DownExpand Up@@ -708,6 +706,4 @@ const InstantPasswordRow = ({ field }: { field?: FormControlState<'password'> })
);
};

export const SignInStart = withRedirectToSignInTask(
withRedirectToAfterSignIn(withCardStateProvider(SignInStartInternal)),
);
export const SignInStart = withCardStateProvider(SignInStartInternal);
13 changes: 11 additions & 2 deletions packages/ui/src/components/UserButton/useMultisessionActions.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import { windowNavigate } from '@clerk/shared/internal/clerk-js/windowNavigate';
import { useClerk } from '@clerk/shared/react';
import type { SignedInSessionResource, UserButtonProps, UserResource } from '@clerk/shared/types';

import { buildURL } from '@clerk/shared/internal/clerk-js/url';
import { useEnvironment } from '@/ui/contexts';
import { useCardState } from '@/ui/elements/contexts';
import { sleep } from '@/ui/utils/sleep';
Expand All@@ -25,7 +26,7 @@ export const useMultisessionActions = (opts: UseMultisessionActionsParams) => {
const { setActive, signOut, openUserProfile } = useClerk();
const card = useCardState();
const { signedInSessions, otherSessions } = useMultipleSessions({ user: opts.user });
const { navigate } = useRouter();
const { navigate, queryParams } = useRouter();
const { displayConfig } = useEnvironment();

const handleSignOutSessionClicked = (session: SignedInSessionResource) => () => {
Expand DownExpand Up@@ -99,7 +100,15 @@ export const useMultisessionActions = (opts: UseMultisessionActionsParams) => {
};

const handleAddAccountClicked = () => {
windowNavigate(opts.signInUrl || window.location.href);
const baseUrl = opts.signInUrl || (typeof window !== 'undefined' ? window.location.href : '');
const url = buildURL(
{
base: baseUrl,
searchParams: new URLSearchParams({ ...queryParams, __clerk_add_account: 'true' }),
},
{ stringify: true },
);
windowNavigate(url);
return sleep(2000);
};

Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
5 changes: 5 additions & 0 deletions .changeset/plenty-dolls-pick.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': minor
---

Centralize redirect concerns for SignIn
Comment thread
jacekradko marked this conversation as resolved.
12 changes: 11 additions & 1 deletion integration/templates/next-app-router/next.config.js
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,19 @@
const path = require('path');

/** @type {import('next').NextConfig} */
const nextConfig = {
eslint: {
ignoreDuringBuilds: true,
},
outputFileTracingRoot: '/',
outputFileTracingRoot: path.resolve(__dirname, '../../../'),
webpack: config => {
// Exclude macOS .Trash directory and other system directories to prevent permission errors
config.watchOptions = {
...config.watchOptions,
ignored: ['**/.Trash/**', '**/node_modules/**', '**/.git/**'],
};
return config;
},
};

module.exports = nextConfig;
5 changes: 5 additions & 0 deletions integration/tests/session-tasks-multi-session.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -61,6 +61,11 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withSessionTasks] })(
// Create second user, to initiate a pending session
// Don't resolve task and switch to active session afterwards
await u.po.signIn.goTo();
await u.page.waitForURL(/sign-in\/choose/);
await u.page.getByText('Add account').click();
await u.page.waitForURL(/sign-in$/);
await u.po.signIn.waitForMounted();
await u.po.signIn.getIdentifierInput().waitFor({ state: 'visible' });
await u.po.signIn.setIdentifier(user2.email);
await u.po.signIn.continue();
await u.po.signIn.setPassword(user2.password);
Expand Down
79 changes: 79 additions & 0 deletions integration/tests/sign-in-single-session-mode.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
import type { FakeUser } from '@clerk/testing/playwright';
import { test } from '@playwright/test';

import type { Application } from '../models/application';
import { appConfigs } from '../presets';
import { createTestUtils, testAgainstRunningApps } from '../testUtils';

/**
* Tests for single-session mode behavior using the withBilling environment
* which is configured for single-session mode in the Clerk Dashboard.
*/
testAgainstRunningApps({ withEnv: [appConfigs.envs.withBilling] })(
'sign in with active session in single-session mode @generic @nextjs',
({ app }) => {
test.describe.configure({ mode: 'serial' });

let fakeUser: FakeUser;

test.beforeAll(async () => {
const u = createTestUtils({ app });
fakeUser = u.services.users.createFakeUser({
withPhoneNumber: true,
withUsername: true,
});
await u.services.users.createBapiUser(fakeUser);
});

test.afterAll(async () => {
await fakeUser.deleteIfExists();
});

test('redirects to afterSignIn URL when visiting /sign-in with active session in single-session mode', async ({
page,
context,
}) => {
const u = createTestUtils({ app, page, context });

await u.po.signIn.goTo();
await u.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
await u.po.expect.toBeSignedIn();
await u.page.waitForAppUrl('/');

await u.po.signIn.goTo();
await u.page.waitForAppUrl('/');
await u.po.expect.toBeSignedIn();
});

test('does NOT show account switcher in single-session mode', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.po.signIn.goTo();
await u.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
await u.po.expect.toBeSignedIn();

await u.page.goToRelative('/sign-in/choose');
await u.page.waitForAppUrl('/');
});

test('shows sign-in form when no active session in single-session mode', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.page.context().clearCookies();
await u.po.signIn.goTo();
await u.po.signIn.waitForMounted();
await u.page.waitForSelector('text=/email address|username|phone/i');
await u.page.waitForURL(/sign-in$/);
});

test('can sign in normally when not already authenticated in single-session mode', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.page.context().clearCookies();
await u.po.signIn.goTo();
await u.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
await u.po.expect.toBeSignedIn();
await u.page.waitForAppUrl('/');
});
},
);
44 changes: 20 additions & 24 deletions packages/ui/src/components/SignIn/SignInStart.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,31 +11,20 @@ import type {
SignInResource,
} from '@clerk/shared/types';
import { isWebAuthnAutofillSupported, isWebAuthnSupported } from '@clerk/shared/webauthn';
import { useEffect, useLayoutEffect, useMemo, useRef, useState } from 'react';

import { Card } from '@/ui/elements/Card';
import { useCardState, withCardStateProvider } from '@/ui/elements/contexts';
import { Form } from '@/ui/elements/Form';
import { Header } from '@/ui/elements/Header';
import { LoadingCard } from '@/ui/elements/LoadingCard';
import { SocialButtonsReversibleContainerWithDivider } from '@/ui/elements/ReversibleContainer';
import { handleError } from '@/ui/utils/errorHandler';
import { isMobileDevice } from '@/ui/utils/isMobileDevice';
import type { FormControlState } from '@/ui/utils/useFormControl';
import { buildRequest, useFormControl } from '@/ui/utils/useFormControl';
import React, { useEffect, useLayoutEffect, useMemo, useRef, useState } from 'react';

import type { SignInStartIdentifier } from '../../common';
import {
buildSSOCallbackURL,
getIdentifierControlDisplayValues,
groupIdentifiers,
withRedirectToAfterSignIn,
withRedirectToSignInTask,
} from '../../common';
import { buildSSOCallbackURL, getIdentifierControlDisplayValues, groupIdentifiers } from '../../common';
import { useCoreSignIn, useEnvironment, useSignInContext } from '../../contexts';
import { Col, descriptors, Flow, localizationKeys } from '../../customizables';
import { CaptchaElement } from '../../elements/CaptchaElement';
import { useLoadingStatus } from '../../hooks';
import { Card } from '../../elements/Card';
import { useCardState, withCardStateProvider } from '../../elements/contexts';
import { Form } from '../../elements/Form';
import { Header } from '../../elements/Header';
import { LoadingCard } from '../../elements/LoadingCard';
import { SocialButtonsReversibleContainerWithDivider } from '../../elements/ReversibleContainer';
import { useLoadingStatus, useSignInRedirect } from '../../hooks';
import { useSupportEmail } from '../../hooks/useSupportEmail';
import { useTotalEnabledAuthMethods } from '../../hooks/useTotalEnabledAuthMethods';
import { useRouter } from '../../router';
Expand All@@ -48,6 +37,10 @@ import {
getPreferredAlternativePhoneChannelForCombinedFlow,
getSignUpAttributeFromIdentifier,
} from './utils';
import { handleError } from '@/ui/utils/errorHandler';
import { isMobileDevice } from '@/ui/utils/isMobileDevice';
import type { FormControlState } from '@/ui/utils/useFormControl';
import { buildRequest, useFormControl } from '@/ui/utils/useFormControl';

const useAutoFillPasskey = () => {
const [isSupported, setIsSupported] = useState(false);
Expand DownExpand Up@@ -523,7 +516,12 @@ function SignInStartInternal(): JSX.Element {
return components[identifierField.type as keyof typeof components];
}, [identifierField.type]);

if (status.isLoading || clerkStatus === 'sign_up') {
const { isRedirecting } = useSignInRedirect({
afterSignInUrl,
organizationTicket,
});

if (isRedirecting || status.isLoading || clerkStatus === 'sign_up') {
// clerkStatus being sign_up will trigger a navigation to the sign up flow, so show a loading card instead of
// rendering the sign in flow.
return <LoadingCard />;
Expand DownExpand Up@@ -708,6 +706,4 @@ const InstantPasswordRow = ({ field }: { field?: FormControlState<'password'> })
);
};

export const SignInStart = withRedirectToSignInTask(
withRedirectToAfterSignIn(withCardStateProvider(SignInStartInternal)),
);
export const SignInStart = withCardStateProvider(SignInStartInternal);
13 changes: 11 additions & 2 deletions packages/ui/src/components/UserButton/useMultisessionActions.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import { windowNavigate } from '@clerk/shared/internal/clerk-js/windowNavigate';
import { useClerk } from '@clerk/shared/react';
import type { SignedInSessionResource, UserButtonProps, UserResource } from '@clerk/shared/types';

import { buildURL } from '@clerk/shared/internal/clerk-js/url';
import { useEnvironment } from '@/ui/contexts';
import { useCardState } from '@/ui/elements/contexts';
import { sleep } from '@/ui/utils/sleep';
Expand All@@ -25,7 +26,7 @@ export const useMultisessionActions = (opts: UseMultisessionActionsParams) => {
const { setActive, signOut, openUserProfile } = useClerk();
const card = useCardState();
const { signedInSessions, otherSessions } = useMultipleSessions({ user: opts.user });
const { navigate } = useRouter();
const { navigate, queryParams } = useRouter();
const { displayConfig } = useEnvironment();

const handleSignOutSessionClicked = (session: SignedInSessionResource) => () => {
Expand DownExpand Up@@ -99,7 +100,15 @@ export const useMultisessionActions = (opts: UseMultisessionActionsParams) => {
};

const handleAddAccountClicked = () => {
windowNavigate(opts.signInUrl || window.location.href);
const baseUrl = opts.signInUrl || (typeof window !== 'undefined' ? window.location.href : '');
const url = buildURL(
{
base: baseUrl,
searchParams: new URLSearchParams({ ...queryParams, __clerk_add_account: 'true' }),
},
{ stringify: true },
);
windowNavigate(url);
return sleep(2000);
};

Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
5 changes: 5 additions & 0 deletions .changeset/plenty-dolls-pick.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': minor
---

Centralize redirect concerns for SignIn
Comment thread
jacekradko marked this conversation as resolved.
12 changes: 11 additions & 1 deletion integration/templates/next-app-router/next.config.js
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,19 @@
const path = require('path');

/** @type {import('next').NextConfig} */
const nextConfig = {
eslint: {
ignoreDuringBuilds: true,
},
outputFileTracingRoot: '/',
outputFileTracingRoot: path.resolve(__dirname, '../../../'),
webpack: config => {
// Exclude macOS .Trash directory and other system directories to prevent permission errors
config.watchOptions = {
...config.watchOptions,
ignored: ['**/.Trash/**', '**/node_modules/**', '**/.git/**'],
};
return config;
},
};

module.exports = nextConfig;
5 changes: 5 additions & 0 deletions integration/tests/session-tasks-multi-session.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -61,6 +61,11 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withSessionTasks] })(
// Create second user, to initiate a pending session
// Don't resolve task and switch to active session afterwards
await u.po.signIn.goTo();
await u.page.waitForURL(/sign-in\/choose/);
await u.page.getByText('Add account').click();
await u.page.waitForURL(/sign-in$/);
await u.po.signIn.waitForMounted();
await u.po.signIn.getIdentifierInput().waitFor({ state: 'visible' });
await u.po.signIn.setIdentifier(user2.email);
await u.po.signIn.continue();
await u.po.signIn.setPassword(user2.password);
Expand Down
79 changes: 79 additions & 0 deletions integration/tests/sign-in-single-session-mode.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
import type { FakeUser } from '@clerk/testing/playwright';
import { test } from '@playwright/test';

import type { Application } from '../models/application';
import { appConfigs } from '../presets';
import { createTestUtils, testAgainstRunningApps } from '../testUtils';

/**
* Tests for single-session mode behavior using the withBilling environment
* which is configured for single-session mode in the Clerk Dashboard.
*/
testAgainstRunningApps({ withEnv: [appConfigs.envs.withBilling] })(
'sign in with active session in single-session mode @generic @nextjs',
({ app }) => {
test.describe.configure({ mode: 'serial' });

let fakeUser: FakeUser;

test.beforeAll(async () => {
const u = createTestUtils({ app });
fakeUser = u.services.users.createFakeUser({
withPhoneNumber: true,
withUsername: true,
});
await u.services.users.createBapiUser(fakeUser);
});

test.afterAll(async () => {
await fakeUser.deleteIfExists();
});

test('redirects to afterSignIn URL when visiting /sign-in with active session in single-session mode', async ({
page,
context,
}) => {
const u = createTestUtils({ app, page, context });

await u.po.signIn.goTo();
await u.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
await u.po.expect.toBeSignedIn();
await u.page.waitForAppUrl('/');

await u.po.signIn.goTo();
await u.page.waitForAppUrl('/');
await u.po.expect.toBeSignedIn();
});

test('does NOT show account switcher in single-session mode', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.po.signIn.goTo();
await u.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
await u.po.expect.toBeSignedIn();

await u.page.goToRelative('/sign-in/choose');
await u.page.waitForAppUrl('/');
});

test('shows sign-in form when no active session in single-session mode', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.page.context().clearCookies();
await u.po.signIn.goTo();
await u.po.signIn.waitForMounted();
await u.page.waitForSelector('text=/email address|username|phone/i');
await u.page.waitForURL(/sign-in$/);
});

test('can sign in normally when not already authenticated in single-session mode', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.page.context().clearCookies();
await u.po.signIn.goTo();
await u.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
await u.po.expect.toBeSignedIn();
await u.page.waitForAppUrl('/');
});
},
);
44 changes: 20 additions & 24 deletions packages/ui/src/components/SignIn/SignInStart.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,31 +11,20 @@ import type {
SignInResource,
} from '@clerk/shared/types';
import { isWebAuthnAutofillSupported, isWebAuthnSupported } from '@clerk/shared/webauthn';
import { useEffect, useLayoutEffect, useMemo, useRef, useState } from 'react';

import { Card } from '@/ui/elements/Card';
import { useCardState, withCardStateProvider } from '@/ui/elements/contexts';
import { Form } from '@/ui/elements/Form';
import { Header } from '@/ui/elements/Header';
import { LoadingCard } from '@/ui/elements/LoadingCard';
import { SocialButtonsReversibleContainerWithDivider } from '@/ui/elements/ReversibleContainer';
import { handleError } from '@/ui/utils/errorHandler';
import { isMobileDevice } from '@/ui/utils/isMobileDevice';
import type { FormControlState } from '@/ui/utils/useFormControl';
import { buildRequest, useFormControl } from '@/ui/utils/useFormControl';
import React, { useEffect, useLayoutEffect, useMemo, useRef, useState } from 'react';

import type { SignInStartIdentifier } from '../../common';
import {
buildSSOCallbackURL,
getIdentifierControlDisplayValues,
groupIdentifiers,
withRedirectToAfterSignIn,
withRedirectToSignInTask,
} from '../../common';
import { buildSSOCallbackURL, getIdentifierControlDisplayValues, groupIdentifiers } from '../../common';
import { useCoreSignIn, useEnvironment, useSignInContext } from '../../contexts';
import { Col, descriptors, Flow, localizationKeys } from '../../customizables';
import { CaptchaElement } from '../../elements/CaptchaElement';
import { useLoadingStatus } from '../../hooks';
import { Card } from '../../elements/Card';
import { useCardState, withCardStateProvider } from '../../elements/contexts';
import { Form } from '../../elements/Form';
import { Header } from '../../elements/Header';
import { LoadingCard } from '../../elements/LoadingCard';
import { SocialButtonsReversibleContainerWithDivider } from '../../elements/ReversibleContainer';
import { useLoadingStatus, useSignInRedirect } from '../../hooks';
import { useSupportEmail } from '../../hooks/useSupportEmail';
import { useTotalEnabledAuthMethods } from '../../hooks/useTotalEnabledAuthMethods';
import { useRouter } from '../../router';
Expand All@@ -48,6 +37,10 @@ import {
getPreferredAlternativePhoneChannelForCombinedFlow,
getSignUpAttributeFromIdentifier,
} from './utils';
import { handleError } from '@/ui/utils/errorHandler';
import { isMobileDevice } from '@/ui/utils/isMobileDevice';
import type { FormControlState } from '@/ui/utils/useFormControl';
import { buildRequest, useFormControl } from '@/ui/utils/useFormControl';

const useAutoFillPasskey = () => {
const [isSupported, setIsSupported] = useState(false);
Expand DownExpand Up@@ -523,7 +516,12 @@ function SignInStartInternal(): JSX.Element {
return components[identifierField.type as keyof typeof components];
}, [identifierField.type]);

if (status.isLoading || clerkStatus === 'sign_up') {
const { isRedirecting } = useSignInRedirect({
afterSignInUrl,
organizationTicket,
});

if (isRedirecting || status.isLoading || clerkStatus === 'sign_up') {
// clerkStatus being sign_up will trigger a navigation to the sign up flow, so show a loading card instead of
// rendering the sign in flow.
return <LoadingCard />;
Expand DownExpand Up@@ -708,6 +706,4 @@ const InstantPasswordRow = ({ field }: { field?: FormControlState<'password'> })
);
};

export const SignInStart = withRedirectToSignInTask(
withRedirectToAfterSignIn(withCardStateProvider(SignInStartInternal)),
);
export const SignInStart = withCardStateProvider(SignInStartInternal);
13 changes: 11 additions & 2 deletions packages/ui/src/components/UserButton/useMultisessionActions.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import { windowNavigate } from '@clerk/shared/internal/clerk-js/windowNavigate';
import { useClerk } from '@clerk/shared/react';
import type { SignedInSessionResource, UserButtonProps, UserResource } from '@clerk/shared/types';

import { buildURL } from '@clerk/shared/internal/clerk-js/url';
import { useEnvironment } from '@/ui/contexts';
import { useCardState } from '@/ui/elements/contexts';
import { sleep } from '@/ui/utils/sleep';
Expand All@@ -25,7 +26,7 @@ export const useMultisessionActions = (opts: UseMultisessionActionsParams) => {
const { setActive, signOut, openUserProfile } = useClerk();
const card = useCardState();
const { signedInSessions, otherSessions } = useMultipleSessions({ user: opts.user });
const { navigate } = useRouter();
const { navigate, queryParams } = useRouter();
const { displayConfig } = useEnvironment();

const handleSignOutSessionClicked = (session: SignedInSessionResource) => () => {
Expand DownExpand Up@@ -99,7 +100,15 @@ export const useMultisessionActions = (opts: UseMultisessionActionsParams) => {
};

const handleAddAccountClicked = () => {
windowNavigate(opts.signInUrl || window.location.href);
const baseUrl = opts.signInUrl || (typeof window !== 'undefined' ? window.location.href : '');
const url = buildURL(
{
base: baseUrl,
searchParams: new URLSearchParams({ ...queryParams, __clerk_add_account: 'true' }),
},
{ stringify: true },
);
windowNavigate(url);
return sleep(2000);
};

Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
5 changes: 5 additions & 0 deletions .changeset/plenty-dolls-pick.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': minor
---

Centralize redirect concerns for SignIn
Comment thread
jacekradko marked this conversation as resolved.
12 changes: 11 additions & 1 deletion integration/templates/next-app-router/next.config.js
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,19 @@
const path = require('path');

/** @type {import('next').NextConfig} */
const nextConfig = {
eslint: {
ignoreDuringBuilds: true,
},
outputFileTracingRoot: '/',
outputFileTracingRoot: path.resolve(__dirname, '../../../'),
webpack: config => {
// Exclude macOS .Trash directory and other system directories to prevent permission errors
config.watchOptions = {
...config.watchOptions,
ignored: ['**/.Trash/**', '**/node_modules/**', '**/.git/**'],
};
return config;
},
};

module.exports = nextConfig;
5 changes: 5 additions & 0 deletions integration/tests/session-tasks-multi-session.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -61,6 +61,11 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withSessionTasks] })(
// Create second user, to initiate a pending session
// Don't resolve task and switch to active session afterwards
await u.po.signIn.goTo();
await u.page.waitForURL(/sign-in\/choose/);
await u.page.getByText('Add account').click();
await u.page.waitForURL(/sign-in$/);
await u.po.signIn.waitForMounted();
await u.po.signIn.getIdentifierInput().waitFor({ state: 'visible' });
await u.po.signIn.setIdentifier(user2.email);
await u.po.signIn.continue();
await u.po.signIn.setPassword(user2.password);
Expand Down
79 changes: 79 additions & 0 deletions integration/tests/sign-in-single-session-mode.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
import type { FakeUser } from '@clerk/testing/playwright';
import { test } from '@playwright/test';

import type { Application } from '../models/application';
import { appConfigs } from '../presets';
import { createTestUtils, testAgainstRunningApps } from '../testUtils';

/**
* Tests for single-session mode behavior using the withBilling environment
* which is configured for single-session mode in the Clerk Dashboard.
*/
testAgainstRunningApps({ withEnv: [appConfigs.envs.withBilling] })(
'sign in with active session in single-session mode @generic @nextjs',
({ app }) => {
test.describe.configure({ mode: 'serial' });

let fakeUser: FakeUser;

test.beforeAll(async () => {
const u = createTestUtils({ app });
fakeUser = u.services.users.createFakeUser({
withPhoneNumber: true,
withUsername: true,
});
await u.services.users.createBapiUser(fakeUser);
});

test.afterAll(async () => {
await fakeUser.deleteIfExists();
});

test('redirects to afterSignIn URL when visiting /sign-in with active session in single-session mode', async ({
page,
context,
}) => {
const u = createTestUtils({ app, page, context });

await u.po.signIn.goTo();
await u.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
await u.po.expect.toBeSignedIn();
await u.page.waitForAppUrl('/');

await u.po.signIn.goTo();
await u.page.waitForAppUrl('/');
await u.po.expect.toBeSignedIn();
});

test('does NOT show account switcher in single-session mode', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.po.signIn.goTo();
await u.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
await u.po.expect.toBeSignedIn();

await u.page.goToRelative('/sign-in/choose');
await u.page.waitForAppUrl('/');
});

test('shows sign-in form when no active session in single-session mode', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.page.context().clearCookies();
await u.po.signIn.goTo();
await u.po.signIn.waitForMounted();
await u.page.waitForSelector('text=/email address|username|phone/i');
await u.page.waitForURL(/sign-in$/);
});

test('can sign in normally when not already authenticated in single-session mode', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.page.context().clearCookies();
await u.po.signIn.goTo();
await u.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
await u.po.expect.toBeSignedIn();
await u.page.waitForAppUrl('/');
});
},
);
44 changes: 20 additions & 24 deletions packages/ui/src/components/SignIn/SignInStart.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,31 +11,20 @@ import type {
SignInResource,
} from '@clerk/shared/types';
import { isWebAuthnAutofillSupported, isWebAuthnSupported } from '@clerk/shared/webauthn';
import { useEffect, useLayoutEffect, useMemo, useRef, useState } from 'react';

import { Card } from '@/ui/elements/Card';
import { useCardState, withCardStateProvider } from '@/ui/elements/contexts';
import { Form } from '@/ui/elements/Form';
import { Header } from '@/ui/elements/Header';
import { LoadingCard } from '@/ui/elements/LoadingCard';
import { SocialButtonsReversibleContainerWithDivider } from '@/ui/elements/ReversibleContainer';
import { handleError } from '@/ui/utils/errorHandler';
import { isMobileDevice } from '@/ui/utils/isMobileDevice';
import type { FormControlState } from '@/ui/utils/useFormControl';
import { buildRequest, useFormControl } from '@/ui/utils/useFormControl';
import React, { useEffect, useLayoutEffect, useMemo, useRef, useState } from 'react';

import type { SignInStartIdentifier } from '../../common';
import {
buildSSOCallbackURL,
getIdentifierControlDisplayValues,
groupIdentifiers,
withRedirectToAfterSignIn,
withRedirectToSignInTask,
} from '../../common';
import { buildSSOCallbackURL, getIdentifierControlDisplayValues, groupIdentifiers } from '../../common';
import { useCoreSignIn, useEnvironment, useSignInContext } from '../../contexts';
import { Col, descriptors, Flow, localizationKeys } from '../../customizables';
import { CaptchaElement } from '../../elements/CaptchaElement';
import { useLoadingStatus } from '../../hooks';
import { Card } from '../../elements/Card';
import { useCardState, withCardStateProvider } from '../../elements/contexts';
import { Form } from '../../elements/Form';
import { Header } from '../../elements/Header';
import { LoadingCard } from '../../elements/LoadingCard';
import { SocialButtonsReversibleContainerWithDivider } from '../../elements/ReversibleContainer';
import { useLoadingStatus, useSignInRedirect } from '../../hooks';
import { useSupportEmail } from '../../hooks/useSupportEmail';
import { useTotalEnabledAuthMethods } from '../../hooks/useTotalEnabledAuthMethods';
import { useRouter } from '../../router';
Expand All@@ -48,6 +37,10 @@ import {
getPreferredAlternativePhoneChannelForCombinedFlow,
getSignUpAttributeFromIdentifier,
} from './utils';
import { handleError } from '@/ui/utils/errorHandler';
import { isMobileDevice } from '@/ui/utils/isMobileDevice';
import type { FormControlState } from '@/ui/utils/useFormControl';
import { buildRequest, useFormControl } from '@/ui/utils/useFormControl';

const useAutoFillPasskey = () => {
const [isSupported, setIsSupported] = useState(false);
Expand DownExpand Up@@ -523,7 +516,12 @@ function SignInStartInternal(): JSX.Element {
return components[identifierField.type as keyof typeof components];
}, [identifierField.type]);

if (status.isLoading || clerkStatus === 'sign_up') {
const { isRedirecting } = useSignInRedirect({
afterSignInUrl,
organizationTicket,
});

if (isRedirecting || status.isLoading || clerkStatus === 'sign_up') {
// clerkStatus being sign_up will trigger a navigation to the sign up flow, so show a loading card instead of
// rendering the sign in flow.
return <LoadingCard />;
Expand DownExpand Up@@ -708,6 +706,4 @@ const InstantPasswordRow = ({ field }: { field?: FormControlState<'password'> })
);
};

export const SignInStart = withRedirectToSignInTask(
withRedirectToAfterSignIn(withCardStateProvider(SignInStartInternal)),
);
export const SignInStart = withCardStateProvider(SignInStartInternal);
13 changes: 11 additions & 2 deletions packages/ui/src/components/UserButton/useMultisessionActions.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import { windowNavigate } from '@clerk/shared/internal/clerk-js/windowNavigate';
import { useClerk } from '@clerk/shared/react';
import type { SignedInSessionResource, UserButtonProps, UserResource } from '@clerk/shared/types';

import { buildURL } from '@clerk/shared/internal/clerk-js/url';
import { useEnvironment } from '@/ui/contexts';
import { useCardState } from '@/ui/elements/contexts';
import { sleep } from '@/ui/utils/sleep';
Expand All@@ -25,7 +26,7 @@ export const useMultisessionActions = (opts: UseMultisessionActionsParams) => {
const { setActive, signOut, openUserProfile } = useClerk();
const card = useCardState();
const { signedInSessions, otherSessions } = useMultipleSessions({ user: opts.user });
const { navigate } = useRouter();
const { navigate, queryParams } = useRouter();
const { displayConfig } = useEnvironment();

const handleSignOutSessionClicked = (session: SignedInSessionResource) => () => {
Expand DownExpand Up@@ -99,7 +100,15 @@ export const useMultisessionActions = (opts: UseMultisessionActionsParams) => {
};

const handleAddAccountClicked = () => {
windowNavigate(opts.signInUrl || window.location.href);
const baseUrl = opts.signInUrl || (typeof window !== 'undefined' ? window.location.href : '');
const url = buildURL(
{
base: baseUrl,
searchParams: new URLSearchParams({ ...queryParams, __clerk_add_account: 'true' }),
},
{ stringify: true },
);
windowNavigate(url);
return sleep(2000);
};

Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
5 changes: 5 additions & 0 deletions .changeset/plenty-dolls-pick.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': minor
---

Centralize redirect concerns for SignIn
Comment thread
jacekradko marked this conversation as resolved.
12 changes: 11 additions & 1 deletion integration/templates/next-app-router/next.config.js
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,19 @@
const path = require('path');

/** @type {import('next').NextConfig} */
const nextConfig = {
eslint: {
ignoreDuringBuilds: true,
},
outputFileTracingRoot: '/',
outputFileTracingRoot: path.resolve(__dirname, '../../../'),
webpack: config => {
// Exclude macOS .Trash directory and other system directories to prevent permission errors
config.watchOptions = {
...config.watchOptions,
ignored: ['**/.Trash/**', '**/node_modules/**', '**/.git/**'],
};
return config;
},
};

module.exports = nextConfig;
5 changes: 5 additions & 0 deletions integration/tests/session-tasks-multi-session.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -61,6 +61,11 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withSessionTasks] })(
// Create second user, to initiate a pending session
// Don't resolve task and switch to active session afterwards
await u.po.signIn.goTo();
await u.page.waitForURL(/sign-in\/choose/);
await u.page.getByText('Add account').click();
await u.page.waitForURL(/sign-in$/);
await u.po.signIn.waitForMounted();
await u.po.signIn.getIdentifierInput().waitFor({ state: 'visible' });
await u.po.signIn.setIdentifier(user2.email);
await u.po.signIn.continue();
await u.po.signIn.setPassword(user2.password);
Expand Down
79 changes: 79 additions & 0 deletions integration/tests/sign-in-single-session-mode.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
import type { FakeUser } from '@clerk/testing/playwright';
import { test } from '@playwright/test';

import type { Application } from '../models/application';
import { appConfigs } from '../presets';
import { createTestUtils, testAgainstRunningApps } from '../testUtils';

/**
* Tests for single-session mode behavior using the withBilling environment
* which is configured for single-session mode in the Clerk Dashboard.
*/
testAgainstRunningApps({ withEnv: [appConfigs.envs.withBilling] })(
'sign in with active session in single-session mode @generic @nextjs',
({ app }) => {
test.describe.configure({ mode: 'serial' });

let fakeUser: FakeUser;

test.beforeAll(async () => {
const u = createTestUtils({ app });
fakeUser = u.services.users.createFakeUser({
withPhoneNumber: true,
withUsername: true,
});
await u.services.users.createBapiUser(fakeUser);
});

test.afterAll(async () => {
await fakeUser.deleteIfExists();
});

test('redirects to afterSignIn URL when visiting /sign-in with active session in single-session mode', async ({
page,
context,
}) => {
const u = createTestUtils({ app, page, context });

await u.po.signIn.goTo();
await u.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
await u.po.expect.toBeSignedIn();
await u.page.waitForAppUrl('/');

await u.po.signIn.goTo();
await u.page.waitForAppUrl('/');
await u.po.expect.toBeSignedIn();
});

test('does NOT show account switcher in single-session mode', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.po.signIn.goTo();
await u.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
await u.po.expect.toBeSignedIn();

await u.page.goToRelative('/sign-in/choose');
await u.page.waitForAppUrl('/');
});

test('shows sign-in form when no active session in single-session mode', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.page.context().clearCookies();
await u.po.signIn.goTo();
await u.po.signIn.waitForMounted();
await u.page.waitForSelector('text=/email address|username|phone/i');
await u.page.waitForURL(/sign-in$/);
});

test('can sign in normally when not already authenticated in single-session mode', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.page.context().clearCookies();
await u.po.signIn.goTo();
await u.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
await u.po.expect.toBeSignedIn();
await u.page.waitForAppUrl('/');
});
},
);
44 changes: 20 additions & 24 deletions packages/ui/src/components/SignIn/SignInStart.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,31 +11,20 @@ import type {
SignInResource,
} from '@clerk/shared/types';
import { isWebAuthnAutofillSupported, isWebAuthnSupported } from '@clerk/shared/webauthn';
import { useEffect, useLayoutEffect, useMemo, useRef, useState } from 'react';

import { Card } from '@/ui/elements/Card';
import { useCardState, withCardStateProvider } from '@/ui/elements/contexts';
import { Form } from '@/ui/elements/Form';
import { Header } from '@/ui/elements/Header';
import { LoadingCard } from '@/ui/elements/LoadingCard';
import { SocialButtonsReversibleContainerWithDivider } from '@/ui/elements/ReversibleContainer';
import { handleError } from '@/ui/utils/errorHandler';
import { isMobileDevice } from '@/ui/utils/isMobileDevice';
import type { FormControlState } from '@/ui/utils/useFormControl';
import { buildRequest, useFormControl } from '@/ui/utils/useFormControl';
import React, { useEffect, useLayoutEffect, useMemo, useRef, useState } from 'react';

import type { SignInStartIdentifier } from '../../common';
import {
buildSSOCallbackURL,
getIdentifierControlDisplayValues,
groupIdentifiers,
withRedirectToAfterSignIn,
withRedirectToSignInTask,
} from '../../common';
import { buildSSOCallbackURL, getIdentifierControlDisplayValues, groupIdentifiers } from '../../common';
import { useCoreSignIn, useEnvironment, useSignInContext } from '../../contexts';
import { Col, descriptors, Flow, localizationKeys } from '../../customizables';
import { CaptchaElement } from '../../elements/CaptchaElement';
import { useLoadingStatus } from '../../hooks';
import { Card } from '../../elements/Card';
import { useCardState, withCardStateProvider } from '../../elements/contexts';
import { Form } from '../../elements/Form';
import { Header } from '../../elements/Header';
import { LoadingCard } from '../../elements/LoadingCard';
import { SocialButtonsReversibleContainerWithDivider } from '../../elements/ReversibleContainer';
import { useLoadingStatus, useSignInRedirect } from '../../hooks';
import { useSupportEmail } from '../../hooks/useSupportEmail';
import { useTotalEnabledAuthMethods } from '../../hooks/useTotalEnabledAuthMethods';
import { useRouter } from '../../router';
Expand All@@ -48,6 +37,10 @@ import {
getPreferredAlternativePhoneChannelForCombinedFlow,
getSignUpAttributeFromIdentifier,
} from './utils';
import { handleError } from '@/ui/utils/errorHandler';
import { isMobileDevice } from '@/ui/utils/isMobileDevice';
import type { FormControlState } from '@/ui/utils/useFormControl';
import { buildRequest, useFormControl } from '@/ui/utils/useFormControl';

const useAutoFillPasskey = () => {
const [isSupported, setIsSupported] = useState(false);
Expand DownExpand Up@@ -523,7 +516,12 @@ function SignInStartInternal(): JSX.Element {
return components[identifierField.type as keyof typeof components];
}, [identifierField.type]);

if (status.isLoading || clerkStatus === 'sign_up') {
const { isRedirecting } = useSignInRedirect({
afterSignInUrl,
organizationTicket,
});

if (isRedirecting || status.isLoading || clerkStatus === 'sign_up') {
// clerkStatus being sign_up will trigger a navigation to the sign up flow, so show a loading card instead of
// rendering the sign in flow.
return <LoadingCard />;
Expand DownExpand Up@@ -708,6 +706,4 @@ const InstantPasswordRow = ({ field }: { field?: FormControlState<'password'> })
);
};

export const SignInStart = withRedirectToSignInTask(
withRedirectToAfterSignIn(withCardStateProvider(SignInStartInternal)),
);
export const SignInStart = withCardStateProvider(SignInStartInternal);
13 changes: 11 additions & 2 deletions packages/ui/src/components/UserButton/useMultisessionActions.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import { windowNavigate } from '@clerk/shared/internal/clerk-js/windowNavigate';
import { useClerk } from '@clerk/shared/react';
import type { SignedInSessionResource, UserButtonProps, UserResource } from '@clerk/shared/types';

import { buildURL } from '@clerk/shared/internal/clerk-js/url';
import { useEnvironment } from '@/ui/contexts';
import { useCardState } from '@/ui/elements/contexts';
import { sleep } from '@/ui/utils/sleep';
Expand All@@ -25,7 +26,7 @@ export const useMultisessionActions = (opts: UseMultisessionActionsParams) => {
const { setActive, signOut, openUserProfile } = useClerk();
const card = useCardState();
const { signedInSessions, otherSessions } = useMultipleSessions({ user: opts.user });
const { navigate } = useRouter();
const { navigate, queryParams } = useRouter();
const { displayConfig } = useEnvironment();

const handleSignOutSessionClicked = (session: SignedInSessionResource) => () => {
Expand DownExpand Up@@ -99,7 +100,15 @@ export const useMultisessionActions = (opts: UseMultisessionActionsParams) => {
};

const handleAddAccountClicked = () => {
windowNavigate(opts.signInUrl || window.location.href);
const baseUrl = opts.signInUrl || (typeof window !== 'undefined' ? window.location.href : '');
const url = buildURL(
{
base: baseUrl,
searchParams: new URLSearchParams({ ...queryParams, __clerk_add_account: 'true' }),
},
{ stringify: true },
);
windowNavigate(url);
return sleep(2000);
};

Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
5 changes: 5 additions & 0 deletions .changeset/plenty-dolls-pick.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': minor
---

Centralize redirect concerns for SignIn
Comment thread
jacekradko marked this conversation as resolved.
12 changes: 11 additions & 1 deletion integration/templates/next-app-router/next.config.js
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,19 @@
const path = require('path');

/** @type {import('next').NextConfig} */
const nextConfig = {
eslint: {
ignoreDuringBuilds: true,
},
outputFileTracingRoot: '/',
outputFileTracingRoot: path.resolve(__dirname, '../../../'),
webpack: config => {
// Exclude macOS .Trash directory and other system directories to prevent permission errors
config.watchOptions = {
...config.watchOptions,
ignored: ['**/.Trash/**', '**/node_modules/**', '**/.git/**'],
};
return config;
},
};

module.exports = nextConfig;
5 changes: 5 additions & 0 deletions integration/tests/session-tasks-multi-session.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -61,6 +61,11 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withSessionTasks] })(
// Create second user, to initiate a pending session
// Don't resolve task and switch to active session afterwards
await u.po.signIn.goTo();
await u.page.waitForURL(/sign-in\/choose/);
await u.page.getByText('Add account').click();
await u.page.waitForURL(/sign-in$/);
await u.po.signIn.waitForMounted();
await u.po.signIn.getIdentifierInput().waitFor({ state: 'visible' });
await u.po.signIn.setIdentifier(user2.email);
await u.po.signIn.continue();
await u.po.signIn.setPassword(user2.password);
Expand Down
79 changes: 79 additions & 0 deletions integration/tests/sign-in-single-session-mode.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
import type { FakeUser } from '@clerk/testing/playwright';
import { test } from '@playwright/test';

import type { Application } from '../models/application';
import { appConfigs } from '../presets';
import { createTestUtils, testAgainstRunningApps } from '../testUtils';

/**
* Tests for single-session mode behavior using the withBilling environment
* which is configured for single-session mode in the Clerk Dashboard.
*/
testAgainstRunningApps({ withEnv: [appConfigs.envs.withBilling] })(
'sign in with active session in single-session mode @generic @nextjs',
({ app }) => {
test.describe.configure({ mode: 'serial' });

let fakeUser: FakeUser;

test.beforeAll(async () => {
const u = createTestUtils({ app });
fakeUser = u.services.users.createFakeUser({
withPhoneNumber: true,
withUsername: true,
});
await u.services.users.createBapiUser(fakeUser);
});

test.afterAll(async () => {
await fakeUser.deleteIfExists();
});

test('redirects to afterSignIn URL when visiting /sign-in with active session in single-session mode', async ({
page,
context,
}) => {
const u = createTestUtils({ app, page, context });

await u.po.signIn.goTo();
await u.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
await u.po.expect.toBeSignedIn();
await u.page.waitForAppUrl('/');

await u.po.signIn.goTo();
await u.page.waitForAppUrl('/');
await u.po.expect.toBeSignedIn();
});

test('does NOT show account switcher in single-session mode', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.po.signIn.goTo();
await u.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
await u.po.expect.toBeSignedIn();

await u.page.goToRelative('/sign-in/choose');
await u.page.waitForAppUrl('/');
});

test('shows sign-in form when no active session in single-session mode', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.page.context().clearCookies();
await u.po.signIn.goTo();
await u.po.signIn.waitForMounted();
await u.page.waitForSelector('text=/email address|username|phone/i');
await u.page.waitForURL(/sign-in$/);
});

test('can sign in normally when not already authenticated in single-session mode', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.page.context().clearCookies();
await u.po.signIn.goTo();
await u.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
await u.po.expect.toBeSignedIn();
await u.page.waitForAppUrl('/');
});
},
);
44 changes: 20 additions & 24 deletions packages/ui/src/components/SignIn/SignInStart.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,31 +11,20 @@ import type {
SignInResource,
} from '@clerk/shared/types';
import { isWebAuthnAutofillSupported, isWebAuthnSupported } from '@clerk/shared/webauthn';
import { useEffect, useLayoutEffect, useMemo, useRef, useState } from 'react';

import { Card } from '@/ui/elements/Card';
import { useCardState, withCardStateProvider } from '@/ui/elements/contexts';
import { Form } from '@/ui/elements/Form';
import { Header } from '@/ui/elements/Header';
import { LoadingCard } from '@/ui/elements/LoadingCard';
import { SocialButtonsReversibleContainerWithDivider } from '@/ui/elements/ReversibleContainer';
import { handleError } from '@/ui/utils/errorHandler';
import { isMobileDevice } from '@/ui/utils/isMobileDevice';
import type { FormControlState } from '@/ui/utils/useFormControl';
import { buildRequest, useFormControl } from '@/ui/utils/useFormControl';
import React, { useEffect, useLayoutEffect, useMemo, useRef, useState } from 'react';

import type { SignInStartIdentifier } from '../../common';
import {
buildSSOCallbackURL,
getIdentifierControlDisplayValues,
groupIdentifiers,
withRedirectToAfterSignIn,
withRedirectToSignInTask,
} from '../../common';
import { buildSSOCallbackURL, getIdentifierControlDisplayValues, groupIdentifiers } from '../../common';
import { useCoreSignIn, useEnvironment, useSignInContext } from '../../contexts';
import { Col, descriptors, Flow, localizationKeys } from '../../customizables';
import { CaptchaElement } from '../../elements/CaptchaElement';
import { useLoadingStatus } from '../../hooks';
import { Card } from '../../elements/Card';
import { useCardState, withCardStateProvider } from '../../elements/contexts';
import { Form } from '../../elements/Form';
import { Header } from '../../elements/Header';
import { LoadingCard } from '../../elements/LoadingCard';
import { SocialButtonsReversibleContainerWithDivider } from '../../elements/ReversibleContainer';
import { useLoadingStatus, useSignInRedirect } from '../../hooks';
import { useSupportEmail } from '../../hooks/useSupportEmail';
import { useTotalEnabledAuthMethods } from '../../hooks/useTotalEnabledAuthMethods';
import { useRouter } from '../../router';
Expand All@@ -48,6 +37,10 @@ import {
getPreferredAlternativePhoneChannelForCombinedFlow,
getSignUpAttributeFromIdentifier,
} from './utils';
import { handleError } from '@/ui/utils/errorHandler';
import { isMobileDevice } from '@/ui/utils/isMobileDevice';
import type { FormControlState } from '@/ui/utils/useFormControl';
import { buildRequest, useFormControl } from '@/ui/utils/useFormControl';

const useAutoFillPasskey = () => {
const [isSupported, setIsSupported] = useState(false);
Expand DownExpand Up@@ -523,7 +516,12 @@ function SignInStartInternal(): JSX.Element {
return components[identifierField.type as keyof typeof components];
}, [identifierField.type]);

if (status.isLoading || clerkStatus === 'sign_up') {
const { isRedirecting } = useSignInRedirect({
afterSignInUrl,
organizationTicket,
});

if (isRedirecting || status.isLoading || clerkStatus === 'sign_up') {
// clerkStatus being sign_up will trigger a navigation to the sign up flow, so show a loading card instead of
// rendering the sign in flow.
return <LoadingCard />;
Expand DownExpand Up@@ -708,6 +706,4 @@ const InstantPasswordRow = ({ field }: { field?: FormControlState<'password'> })
);
};

export const SignInStart = withRedirectToSignInTask(
withRedirectToAfterSignIn(withCardStateProvider(SignInStartInternal)),
);
export const SignInStart = withCardStateProvider(SignInStartInternal);
13 changes: 11 additions & 2 deletions packages/ui/src/components/UserButton/useMultisessionActions.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import { windowNavigate } from '@clerk/shared/internal/clerk-js/windowNavigate';
import { useClerk } from '@clerk/shared/react';
import type { SignedInSessionResource, UserButtonProps, UserResource } from '@clerk/shared/types';

import { buildURL } from '@clerk/shared/internal/clerk-js/url';
import { useEnvironment } from '@/ui/contexts';
import { useCardState } from '@/ui/elements/contexts';
import { sleep } from '@/ui/utils/sleep';
Expand All@@ -25,7 +26,7 @@ export const useMultisessionActions = (opts: UseMultisessionActionsParams) => {
const { setActive, signOut, openUserProfile } = useClerk();
const card = useCardState();
const { signedInSessions, otherSessions } = useMultipleSessions({ user: opts.user });
const { navigate } = useRouter();
const { navigate, queryParams } = useRouter();
const { displayConfig } = useEnvironment();

const handleSignOutSessionClicked = (session: SignedInSessionResource) => () => {
Expand DownExpand Up@@ -99,7 +100,15 @@ export const useMultisessionActions = (opts: UseMultisessionActionsParams) => {
};

const handleAddAccountClicked = () => {
windowNavigate(opts.signInUrl || window.location.href);
const baseUrl = opts.signInUrl || (typeof window !== 'undefined' ? window.location.href : '');
const url = buildURL(
{
base: baseUrl,
searchParams: new URLSearchParams({ ...queryParams, __clerk_add_account: 'true' }),
},
{ stringify: true },
);
windowNavigate(url);
return sleep(2000);
};

Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
5 changes: 5 additions & 0 deletions .changeset/plenty-dolls-pick.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': minor
---

Centralize redirect concerns for SignIn
Comment thread
jacekradko marked this conversation as resolved.
12 changes: 11 additions & 1 deletion integration/templates/next-app-router/next.config.js
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,19 @@
const path = require('path');

/** @type {import('next').NextConfig} */
const nextConfig = {
eslint: {
ignoreDuringBuilds: true,
},
outputFileTracingRoot: '/',
outputFileTracingRoot: path.resolve(__dirname, '../../../'),
webpack: config => {
// Exclude macOS .Trash directory and other system directories to prevent permission errors
config.watchOptions = {
...config.watchOptions,
ignored: ['**/.Trash/**', '**/node_modules/**', '**/.git/**'],
};
return config;
},
};

module.exports = nextConfig;
5 changes: 5 additions & 0 deletions integration/tests/session-tasks-multi-session.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -61,6 +61,11 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withSessionTasks] })(
// Create second user, to initiate a pending session
// Don't resolve task and switch to active session afterwards
await u.po.signIn.goTo();
await u.page.waitForURL(/sign-in\/choose/);
await u.page.getByText('Add account').click();
await u.page.waitForURL(/sign-in$/);
await u.po.signIn.waitForMounted();
await u.po.signIn.getIdentifierInput().waitFor({ state: 'visible' });
await u.po.signIn.setIdentifier(user2.email);
await u.po.signIn.continue();
await u.po.signIn.setPassword(user2.password);
Expand Down
79 changes: 79 additions & 0 deletions integration/tests/sign-in-single-session-mode.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
import type { FakeUser } from '@clerk/testing/playwright';
import { test } from '@playwright/test';

import type { Application } from '../models/application';
import { appConfigs } from '../presets';
import { createTestUtils, testAgainstRunningApps } from '../testUtils';

/**
* Tests for single-session mode behavior using the withBilling environment
* which is configured for single-session mode in the Clerk Dashboard.
*/
testAgainstRunningApps({ withEnv: [appConfigs.envs.withBilling] })(
'sign in with active session in single-session mode @generic @nextjs',
({ app }) => {
test.describe.configure({ mode: 'serial' });

let fakeUser: FakeUser;

test.beforeAll(async () => {
const u = createTestUtils({ app });
fakeUser = u.services.users.createFakeUser({
withPhoneNumber: true,
withUsername: true,
});
await u.services.users.createBapiUser(fakeUser);
});

test.afterAll(async () => {
await fakeUser.deleteIfExists();
});

test('redirects to afterSignIn URL when visiting /sign-in with active session in single-session mode', async ({
page,
context,
}) => {
const u = createTestUtils({ app, page, context });

await u.po.signIn.goTo();
await u.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
await u.po.expect.toBeSignedIn();
await u.page.waitForAppUrl('/');

await u.po.signIn.goTo();
await u.page.waitForAppUrl('/');
await u.po.expect.toBeSignedIn();
});

test('does NOT show account switcher in single-session mode', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.po.signIn.goTo();
await u.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
await u.po.expect.toBeSignedIn();

await u.page.goToRelative('/sign-in/choose');
await u.page.waitForAppUrl('/');
});

test('shows sign-in form when no active session in single-session mode', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.page.context().clearCookies();
await u.po.signIn.goTo();
await u.po.signIn.waitForMounted();
await u.page.waitForSelector('text=/email address|username|phone/i');
await u.page.waitForURL(/sign-in$/);
});

test('can sign in normally when not already authenticated in single-session mode', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.page.context().clearCookies();
await u.po.signIn.goTo();
await u.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
await u.po.expect.toBeSignedIn();
await u.page.waitForAppUrl('/');
});
},
);
44 changes: 20 additions & 24 deletions packages/ui/src/components/SignIn/SignInStart.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,31 +11,20 @@ import type {
SignInResource,
} from '@clerk/shared/types';
import { isWebAuthnAutofillSupported, isWebAuthnSupported } from '@clerk/shared/webauthn';
import { useEffect, useLayoutEffect, useMemo, useRef, useState } from 'react';

import { Card } from '@/ui/elements/Card';
import { useCardState, withCardStateProvider } from '@/ui/elements/contexts';
import { Form } from '@/ui/elements/Form';
import { Header } from '@/ui/elements/Header';
import { LoadingCard } from '@/ui/elements/LoadingCard';
import { SocialButtonsReversibleContainerWithDivider } from '@/ui/elements/ReversibleContainer';
import { handleError } from '@/ui/utils/errorHandler';
import { isMobileDevice } from '@/ui/utils/isMobileDevice';
import type { FormControlState } from '@/ui/utils/useFormControl';
import { buildRequest, useFormControl } from '@/ui/utils/useFormControl';
import React, { useEffect, useLayoutEffect, useMemo, useRef, useState } from 'react';

import type { SignInStartIdentifier } from '../../common';
import {
buildSSOCallbackURL,
getIdentifierControlDisplayValues,
groupIdentifiers,
withRedirectToAfterSignIn,
withRedirectToSignInTask,
} from '../../common';
import { buildSSOCallbackURL, getIdentifierControlDisplayValues, groupIdentifiers } from '../../common';
import { useCoreSignIn, useEnvironment, useSignInContext } from '../../contexts';
import { Col, descriptors, Flow, localizationKeys } from '../../customizables';
import { CaptchaElement } from '../../elements/CaptchaElement';
import { useLoadingStatus } from '../../hooks';
import { Card } from '../../elements/Card';
import { useCardState, withCardStateProvider } from '../../elements/contexts';
import { Form } from '../../elements/Form';
import { Header } from '../../elements/Header';
import { LoadingCard } from '../../elements/LoadingCard';
import { SocialButtonsReversibleContainerWithDivider } from '../../elements/ReversibleContainer';
import { useLoadingStatus, useSignInRedirect } from '../../hooks';
import { useSupportEmail } from '../../hooks/useSupportEmail';
import { useTotalEnabledAuthMethods } from '../../hooks/useTotalEnabledAuthMethods';
import { useRouter } from '../../router';
Expand All@@ -48,6 +37,10 @@ import {
getPreferredAlternativePhoneChannelForCombinedFlow,
getSignUpAttributeFromIdentifier,
} from './utils';
import { handleError } from '@/ui/utils/errorHandler';
import { isMobileDevice } from '@/ui/utils/isMobileDevice';
import type { FormControlState } from '@/ui/utils/useFormControl';
import { buildRequest, useFormControl } from '@/ui/utils/useFormControl';

const useAutoFillPasskey = () => {
const [isSupported, setIsSupported] = useState(false);
Expand DownExpand Up@@ -523,7 +516,12 @@ function SignInStartInternal(): JSX.Element {
return components[identifierField.type as keyof typeof components];
}, [identifierField.type]);

if (status.isLoading || clerkStatus === 'sign_up') {
const { isRedirecting } = useSignInRedirect({
afterSignInUrl,
organizationTicket,
});

if (isRedirecting || status.isLoading || clerkStatus === 'sign_up') {
// clerkStatus being sign_up will trigger a navigation to the sign up flow, so show a loading card instead of
// rendering the sign in flow.
return <LoadingCard />;
Expand DownExpand Up@@ -708,6 +706,4 @@ const InstantPasswordRow = ({ field }: { field?: FormControlState<'password'> })
);
};

export const SignInStart = withRedirectToSignInTask(
withRedirectToAfterSignIn(withCardStateProvider(SignInStartInternal)),
);
export const SignInStart = withCardStateProvider(SignInStartInternal);
13 changes: 11 additions & 2 deletions packages/ui/src/components/UserButton/useMultisessionActions.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import { windowNavigate } from '@clerk/shared/internal/clerk-js/windowNavigate';
import { useClerk } from '@clerk/shared/react';
import type { SignedInSessionResource, UserButtonProps, UserResource } from '@clerk/shared/types';

import { buildURL } from '@clerk/shared/internal/clerk-js/url';
import { useEnvironment } from '@/ui/contexts';
import { useCardState } from '@/ui/elements/contexts';
import { sleep } from '@/ui/utils/sleep';
Expand All@@ -25,7 +26,7 @@ export const useMultisessionActions = (opts: UseMultisessionActionsParams) => {
const { setActive, signOut, openUserProfile } = useClerk();
const card = useCardState();
const { signedInSessions, otherSessions } = useMultipleSessions({ user: opts.user });
const { navigate } = useRouter();
const { navigate, queryParams } = useRouter();
const { displayConfig } = useEnvironment();

const handleSignOutSessionClicked = (session: SignedInSessionResource) => () => {
Expand DownExpand Up@@ -99,7 +100,15 @@ export const useMultisessionActions = (opts: UseMultisessionActionsParams) => {
};

const handleAddAccountClicked = () => {
windowNavigate(opts.signInUrl || window.location.href);
const baseUrl = opts.signInUrl || (typeof window !== 'undefined' ? window.location.href : '');
const url = buildURL(
{
base: baseUrl,
searchParams: new URLSearchParams({ ...queryParams, __clerk_add_account: 'true' }),
},
{ stringify: true },
);
windowNavigate(url);
return sleep(2000);
};

Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
5 changes: 5 additions & 0 deletions .changeset/plenty-dolls-pick.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': minor
---

Centralize redirect concerns for SignIn
Comment thread
jacekradko marked this conversation as resolved.
12 changes: 11 additions & 1 deletion integration/templates/next-app-router/next.config.js
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,19 @@
const path = require('path');

/** @type {import('next').NextConfig} */
const nextConfig = {
eslint: {
ignoreDuringBuilds: true,
},
outputFileTracingRoot: '/',
outputFileTracingRoot: path.resolve(__dirname, '../../../'),
webpack: config => {
// Exclude macOS .Trash directory and other system directories to prevent permission errors
config.watchOptions = {
...config.watchOptions,
ignored: ['**/.Trash/**', '**/node_modules/**', '**/.git/**'],
};
return config;
},
};

module.exports = nextConfig;
5 changes: 5 additions & 0 deletions integration/tests/session-tasks-multi-session.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -61,6 +61,11 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withSessionTasks] })(
// Create second user, to initiate a pending session
// Don't resolve task and switch to active session afterwards
await u.po.signIn.goTo();
await u.page.waitForURL(/sign-in\/choose/);
await u.page.getByText('Add account').click();
await u.page.waitForURL(/sign-in$/);
await u.po.signIn.waitForMounted();
await u.po.signIn.getIdentifierInput().waitFor({ state: 'visible' });
await u.po.signIn.setIdentifier(user2.email);
await u.po.signIn.continue();
await u.po.signIn.setPassword(user2.password);
Expand Down
79 changes: 79 additions & 0 deletions integration/tests/sign-in-single-session-mode.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
import type { FakeUser } from '@clerk/testing/playwright';
import { test } from '@playwright/test';

import type { Application } from '../models/application';
import { appConfigs } from '../presets';
import { createTestUtils, testAgainstRunningApps } from '../testUtils';

/**
* Tests for single-session mode behavior using the withBilling environment
* which is configured for single-session mode in the Clerk Dashboard.
*/
testAgainstRunningApps({ withEnv: [appConfigs.envs.withBilling] })(
'sign in with active session in single-session mode @generic @nextjs',
({ app }) => {
test.describe.configure({ mode: 'serial' });

let fakeUser: FakeUser;

test.beforeAll(async () => {
const u = createTestUtils({ app });
fakeUser = u.services.users.createFakeUser({
withPhoneNumber: true,
withUsername: true,
});
await u.services.users.createBapiUser(fakeUser);
});

test.afterAll(async () => {
await fakeUser.deleteIfExists();
});

test('redirects to afterSignIn URL when visiting /sign-in with active session in single-session mode', async ({
page,
context,
}) => {
const u = createTestUtils({ app, page, context });

await u.po.signIn.goTo();
await u.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
await u.po.expect.toBeSignedIn();
await u.page.waitForAppUrl('/');

await u.po.signIn.goTo();
await u.page.waitForAppUrl('/');
await u.po.expect.toBeSignedIn();
});

test('does NOT show account switcher in single-session mode', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.po.signIn.goTo();
await u.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
await u.po.expect.toBeSignedIn();

await u.page.goToRelative('/sign-in/choose');
await u.page.waitForAppUrl('/');
});

test('shows sign-in form when no active session in single-session mode', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.page.context().clearCookies();
await u.po.signIn.goTo();
await u.po.signIn.waitForMounted();
await u.page.waitForSelector('text=/email address|username|phone/i');
await u.page.waitForURL(/sign-in$/);
});

test('can sign in normally when not already authenticated in single-session mode', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.page.context().clearCookies();
await u.po.signIn.goTo();
await u.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
await u.po.expect.toBeSignedIn();
await u.page.waitForAppUrl('/');
});
},
);
44 changes: 20 additions & 24 deletions packages/ui/src/components/SignIn/SignInStart.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,31 +11,20 @@ import type {
SignInResource,
} from '@clerk/shared/types';
import { isWebAuthnAutofillSupported, isWebAuthnSupported } from '@clerk/shared/webauthn';
import { useEffect, useLayoutEffect, useMemo, useRef, useState } from 'react';

import { Card } from '@/ui/elements/Card';
import { useCardState, withCardStateProvider } from '@/ui/elements/contexts';
import { Form } from '@/ui/elements/Form';
import { Header } from '@/ui/elements/Header';
import { LoadingCard } from '@/ui/elements/LoadingCard';
import { SocialButtonsReversibleContainerWithDivider } from '@/ui/elements/ReversibleContainer';
import { handleError } from '@/ui/utils/errorHandler';
import { isMobileDevice } from '@/ui/utils/isMobileDevice';
import type { FormControlState } from '@/ui/utils/useFormControl';
import { buildRequest, useFormControl } from '@/ui/utils/useFormControl';
import React, { useEffect, useLayoutEffect, useMemo, useRef, useState } from 'react';

import type { SignInStartIdentifier } from '../../common';
import {
buildSSOCallbackURL,
getIdentifierControlDisplayValues,
groupIdentifiers,
withRedirectToAfterSignIn,
withRedirectToSignInTask,
} from '../../common';
import { buildSSOCallbackURL, getIdentifierControlDisplayValues, groupIdentifiers } from '../../common';
import { useCoreSignIn, useEnvironment, useSignInContext } from '../../contexts';
import { Col, descriptors, Flow, localizationKeys } from '../../customizables';
import { CaptchaElement } from '../../elements/CaptchaElement';
import { useLoadingStatus } from '../../hooks';
import { Card } from '../../elements/Card';
import { useCardState, withCardStateProvider } from '../../elements/contexts';
import { Form } from '../../elements/Form';
import { Header } from '../../elements/Header';
import { LoadingCard } from '../../elements/LoadingCard';
import { SocialButtonsReversibleContainerWithDivider } from '../../elements/ReversibleContainer';
import { useLoadingStatus, useSignInRedirect } from '../../hooks';
import { useSupportEmail } from '../../hooks/useSupportEmail';
import { useTotalEnabledAuthMethods } from '../../hooks/useTotalEnabledAuthMethods';
import { useRouter } from '../../router';
Expand All@@ -48,6 +37,10 @@ import {
getPreferredAlternativePhoneChannelForCombinedFlow,
getSignUpAttributeFromIdentifier,
} from './utils';
import { handleError } from '@/ui/utils/errorHandler';
import { isMobileDevice } from '@/ui/utils/isMobileDevice';
import type { FormControlState } from '@/ui/utils/useFormControl';
import { buildRequest, useFormControl } from '@/ui/utils/useFormControl';

const useAutoFillPasskey = () => {
const [isSupported, setIsSupported] = useState(false);
Expand DownExpand Up@@ -523,7 +516,12 @@ function SignInStartInternal(): JSX.Element {
return components[identifierField.type as keyof typeof components];
}, [identifierField.type]);

if (status.isLoading || clerkStatus === 'sign_up') {
const { isRedirecting } = useSignInRedirect({
afterSignInUrl,
organizationTicket,
});

if (isRedirecting || status.isLoading || clerkStatus === 'sign_up') {
// clerkStatus being sign_up will trigger a navigation to the sign up flow, so show a loading card instead of
// rendering the sign in flow.
return <LoadingCard />;
Expand DownExpand Up@@ -708,6 +706,4 @@ const InstantPasswordRow = ({ field }: { field?: FormControlState<'password'> })
);
};

export const SignInStart = withRedirectToSignInTask(
withRedirectToAfterSignIn(withCardStateProvider(SignInStartInternal)),
);
export const SignInStart = withCardStateProvider(SignInStartInternal);
13 changes: 11 additions & 2 deletions packages/ui/src/components/UserButton/useMultisessionActions.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import { windowNavigate } from '@clerk/shared/internal/clerk-js/windowNavigate';
import { useClerk } from '@clerk/shared/react';
import type { SignedInSessionResource, UserButtonProps, UserResource } from '@clerk/shared/types';

import { buildURL } from '@clerk/shared/internal/clerk-js/url';
import { useEnvironment } from '@/ui/contexts';
import { useCardState } from '@/ui/elements/contexts';
import { sleep } from '@/ui/utils/sleep';
Expand All@@ -25,7 +26,7 @@ export const useMultisessionActions = (opts: UseMultisessionActionsParams) => {
const { setActive, signOut, openUserProfile } = useClerk();
const card = useCardState();
const { signedInSessions, otherSessions } = useMultipleSessions({ user: opts.user });
const { navigate } = useRouter();
const { navigate, queryParams } = useRouter();
const { displayConfig } = useEnvironment();

const handleSignOutSessionClicked = (session: SignedInSessionResource) => () => {
Expand DownExpand Up@@ -99,7 +100,15 @@ export const useMultisessionActions = (opts: UseMultisessionActionsParams) => {
};

const handleAddAccountClicked = () => {
windowNavigate(opts.signInUrl || window.location.href);
const baseUrl = opts.signInUrl || (typeof window !== 'undefined' ? window.location.href : '');
const url = buildURL(
{
base: baseUrl,
searchParams: new URLSearchParams({ ...queryParams, __clerk_add_account: 'true' }),
},
{ stringify: true },
);
windowNavigate(url);
return sleep(2000);
};

Expand Down
Loading
Loading